FieldRendererComplexText::renderLine() - Code Metrics - Inspection of "First pass at wrapping ComplexText" - graze/ciff-renderer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — complex-text-wrapping ( f40da2 )

by Burhan

created 2019-07-26 15:50 UTC

FieldRendererComplexText::renderLine() A

↳ Parent: FieldRendererComplexText

Complexity

Conditions	5
Paths	4

Size

Total Lines	51
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	5
eloc	27
c	3
b	0
f	0
nc	4
nop	4
dl	0
loc	51
ccs	0
cts	28
cp	0
crap	30
rs	9.1768

How to fix Long Method

<?php

namespace Graze\CiffRenderer\Renderer\FieldRenderer;

use Graze\CiffRenderer\Parser\FieldParser\FieldParserComplexText;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface;
use Intervention\Image\Gd\Font;
use Intervention\Image\ImageManager;

class FieldRendererComplexText implements FieldRendererInterface
{
    /**
     * @var float
     */
    const LETTER_SPACING_ADJUSTMENT = 0.97;

    /**
     * @var Font
     */
    private $font;

    /**
     * @param Font $font
     */
    public function __construct(Font $font)
    {
        $this->font = $font;
    }

    /**
     * @param ImageManager $imageManager
     * @param FieldParserInterface $parser
     * @param null|callable $fontResolver
     * @param null|callable $graphicResolver
     * @return \Intervention\Image\Image
     */
    public function render(
        ImageManager $imageManager,
        FieldParserInterface $parser,
        callable $fontResolver = null,
        callable $graphicResolver = null
    ) {
        $fontPath = $fontResolver($parser->getFontFace());

        $lines = $parser->getText();
        $texts = [];
        $height = 0;
        $text = $this->renderLine($imageManager, $parser, $fontPath, $lines);

        // store dimensions ready to create a canvas
        $width = $text->getWidth();
        $height += $text->getHeight();

        $texts[] = $text;

        if (empty($texts)) {
            // nothing to render
            return null;
        }

        // create a canvas to add each line of text to
        $canvas = $imageManager->canvas($width, $height);

        $offsetX = 0;
        $offsetY = 0;
        foreach ($texts as $text) {
            // add the text to the canvas
            $canvas->insert($text, 'top-left', (int) $offsetX, (int) $offsetY);

            // increase the offset for the next line
            $offsetY += $text->getHeight();
        }

        $orientation = $parser->getOrientation();
        if ($orientation) {
            $canvas->rotate(360 - $orientation);
        }

        return $canvas;
    }

    /**
     * @param ImageManager $imageManager
     * @param FieldParserInterface $parser
     * @param string $fontPath
     * @param string $text
     * @return \Intervention\Image\Image
     */
    private function renderLine(ImageManager $imageManager, FieldParserInterface $parser, $fontPath, $text)
    {
        // Pass the text through the wrapping function first
        $text = $this->wrap($parser->getFontSize(), $fontPath, $text, $parser->getWidth());

        // create the text here so it can be measured
        $this->font->text($text);

        $this->font->file($fontPath);
        $this->font->size($parser->getFontSize());
        $this->font->color('#000');
        $this->font->align($parser->getTextAlignment());
        $this->font->valign('top');

        $size = $this->font->getBoxSize();

        // if text consists of invisible chars, measured size will be zero, nothing to print
        if ($size['width'] < 1 || $size['height'] < 1) {
            return null;
        }

        $fontCallback = function (&$font) {
            // override the font created by Canvas::text()
            $font = $this->font;
        };

        $canvas = $imageManager->canvas($size['width'], $size['height']);

        // figure out the correct reference point for this alignment
        switch ($parser->getTextAlignment()) {
            case FieldParserComplexText::ALIGN_CENTRE:
                $posX = round($parser->getWidth()/2);
                break;

            case FieldParserComplexText::ALIGN_RIGHT:
                $posX = $parser->getWidth();
                break;

            default:
                $posX = 0;
                break;
        }

        // no need to pass the text in here as we override the font in the callback
        $canvas->text('', $posX, 0, $fontCallback);
        $canvas->text('', /** @scrutinizer ignore-type */ $posX, 0, $fontCallback);

        // attempt to correct differences between this and Clarisoft
        $width = (int) round($size['width'] * self::LETTER_SPACING_ADJUSTMENT);
        $canvas->resize($width, $size['height']);

        return $canvas;
    }

    /**
     * Wrap the given text such that it doesn't exceed the given width using the given font and size.
     * @param string $fontSize
     * @param string $fontFace
     * @param string $string
     * @param int $width
     * @return string
     */
    function wrap($fontSize, $fontFace, $string, $width){

        // Font size needs to be scaled a bit to work correctly.
        $fontSize = $fontSize * 0.8;
        $wrappedString = "";

        $words = explode(' ', $string);

        foreach ($words as $word){

            $teststring = $wrappedString=="" ? $word : $wrappedString.' '.$word;
            $testbox = imagettfbbox($fontSize, 0, $fontFace, $teststring);
            if ( $testbox[2] > $width ){
                $wrappedString.=($wrappedString=="" ? "" : "\n").$word;
            } else {
                $wrappedString.=($wrappedString=="" ? "" : ' ').$word;
            }
        }

        return $wrappedString;
    }

    /**
     * @return FieldRendererInterface
     */
    public static function factory()
    {
        return new static(
            new Font()
        );
    }
}


graze / ciff-renderer

Push — complex-text-wrapping ( f40da2 )

FieldRendererComplexText::renderLine() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like