FieldSorter::sort() - Code Metrics - Inspection of "Fixed text improvements" - graze/ciff-renderer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#39)

unknown

created 2019-07-11 15:14 UTC

FieldSorter::sort() A

↳ Parent: FieldSorter

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	15
ccs	4
cts	5
cp	0.8
crap	2.032
rs	10

<?php

namespace Graze\CiffRenderer\Parser;

use SimpleXMLElement;

class FieldSorter
{
    /**
     * @var int
     */
    protected $fieldTypeToOrder = [
        FieldType::FIELD_STATIC_GRAPHIC    => 1,
        FieldType::FIELD_FIXED_TEXT        => 2,
        FieldType::FIELD_COMPLEX_TEXT      => 3,
        FieldType::FIELD_BARCODE           => 4,
        FieldType::FIELD_DATE              => 5,
        FieldType::FIELD_OFFSET_DATE       => 6,
        FieldType::FIELD_MERGE_FIELD       => 7,
        FieldType::FIELD_GRAPHIC_PRIMITIVE => 8,
    ];

    /**
     * @param SimpleXMLElement[] $fields
     */
    public function sort(array &$fields)
    {
        usort($fields, function ($field1, $field2) {
            // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps
            $typeComparison = $this->fieldTypeToOrder[(string) $field1->FldType] - $this->fieldTypeToOrder[(string) $field2->FldType];

            if ($typeComparison === 0) {
                // Same field type, so order by field name
                /**
                 * @var SimpleXMLElement $field1
                 * @var SimpleXMLElement $field2
                 */
                return strcmp((string)$field1->attributes()['Name'], (string)$field2->attributes()['Name']);
            } else {
                return $typeComparison;
            }
        });
    }
}


1		<?php
2
3		namespace Graze\CiffRenderer\Parser;
4
5		use SimpleXMLElement;
6
7		class FieldSorter
8		{
9		/**
10		* @var int
11		*/
12		protected $fieldTypeToOrder = [
13		FieldType::FIELD_STATIC_GRAPHIC => 1,
14		FieldType::FIELD_FIXED_TEXT => 2,
15		FieldType::FIELD_COMPLEX_TEXT => 3,
16		FieldType::FIELD_BARCODE => 4,
17		FieldType::FIELD_DATE => 5,
18		FieldType::FIELD_OFFSET_DATE => 6,
19		FieldType::FIELD_MERGE_FIELD => 7,
20		FieldType::FIELD_GRAPHIC_PRIMITIVE => 8,
21		];
22
23		/**
24		* @param SimpleXMLElement[] $fields
25		*/
26		public function sort(array &$fields)
27		{
28	1	usort($fields, function ($field1, $field2) {
29		// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps
30	1	$typeComparison = $this->fieldTypeToOrder[(string) $field1->FldType] - $this->fieldTypeToOrder[(string) $field2->FldType];
31
32	1	if ($typeComparison === 0) {
33		// Same field type, so order by field name
34		/**
35		* @var SimpleXMLElement $field1
36		* @var SimpleXMLElement $field2
37		*/
38		return strcmp((string)$field1->attributes()['Name'], (string)$field2->attributes()['Name']);
39		} else {
40	1	return $typeComparison;
41		}
42	1	});
43	1	}
44		}
45

graze / ciff-renderer

Pull Request — master (#39)

FieldSorter::sort() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like