Graze\CiffRenderer\Parser\FieldParser\FieldParserFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

88%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	getFieldParser()	0	34	8

<?php

namespace Graze\CiffRenderer\Parser\FieldParser;

use Graze\CiffRenderer\Parser\SimpleXmlElement\SimpleXmlElementInterface;
use Graze\CiffRenderer\Parser\FieldType;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserFixedText;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserBarcode;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserDate;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserDateOffset;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserStaticGraphic;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserGraphicPrimitive;
use Graze\CiffRenderer\Exception\UnsupportedFieldTypeException;

class FieldParserFactory
{
    /**
     * @param SimpleXmlElementInterface $xml
     * @return FieldParserInterface
     */
    public function getFieldParser(SimpleXmlElementInterface $xml)
    {
        switch ((string) $xml->FldType) { // @codingStandardsIgnoreLine

Accessing FldType on the interface Graze\CiffRenderer\Parser\SimpleXmlElement\SimpleXmlElementInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            case FieldType::FIELD_FIXED_TEXT:
            case FieldType::FIELD_MERGE_FIELD:
                $className = FieldParserFixedText::class;
                break;

            case FieldType::FIELD_BARCODE:
                $className = FieldParserBarcode::class;
                break;

            case FieldType::FIELD_DATE:
                $className = FieldParserDate::class;
                break;

            case FieldType::FIELD_OFFSET_DATE:
                $className = FieldParserDateOffset::class;
                break;

            case FieldType::FIELD_STATIC_GRAPHIC:
                $className = FieldParserStaticGraphic::class;
                break;

            case FieldType::FIELD_GRAPHIC_PRIMITIVE:
                $className = FieldParserGraphicPrimitive::class;
                break;

            default:
                throw new UnsupportedFieldTypeException($fieldType);
        }

        return $className::factory();
    }
}