StaticGraphicBuilder::buildRenderer() - Code Metrics - Inspection of "Lower PHP dependency to 5.5" - graze/ciff-renderer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4984e7...9ad690 )

by John

created 2017-03-13 10:20 UTC

StaticGraphicBuilder::buildRenderer() A

↳ Parent: StaticGraphicBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	13
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	2.0116

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	13
loc	13
ccs	6
cts	7
cp	0.8571
rs	9.4285
cc	2
eloc	7
nc	2
nop	2
crap	2.0116

<?php

namespace Graze\CiffRenderer\Field\Builder;

use Graze\CiffRenderer\Field\Parser\StaticGraphicParser;
use Graze\CiffRenderer\Field\Renderer\StaticGraphicRenderer;
use Graze\CiffRenderer\Field\Parser\ParserInterface;
use Graze\CiffRenderer\Field\Renderer\RendererInterface;
use Graze\CiffRenderer\Exception\RuntimeException;

class StaticGraphicBuilder extends AbstractBuilder

{
    /**
     * @return StaticGraphicParser
     */
    protected function instantiateParser()
    {
        return new StaticGraphicParser($xmlField);

    }

    /**
     * @param ParserInterface $parser
     *
     * @return StaticGraphicRenderer
     */
    protected function instantiateRenderer(ParserInterface $parser)
    {
        return new StaticGraphicRenderer();
    }

    /**
     * @param RendererInterface $renderer
     * @param ParserInterface $parser
     *
     * @return StaticGraphicRenderer
     */
    public function buildRenderer(RendererInterface $renderer, ParserInterface $parser)
    {
        $renderer = parent::buildRenderer($renderer, $parser);

        $graphicResolver = $this->getGraphicResolver();
        if (!$graphicResolver) {
            throw new RuntimeException('Graphic resolver not set');
        }

        $renderer->setGraphicResolver($graphicResolver);

        return $renderer;
    }
}


1			<?php
2
3			namespace Graze\CiffRenderer\Field\Builder;
4
5			use Graze\CiffRenderer\Field\Parser\StaticGraphicParser;
6			use Graze\CiffRenderer\Field\Renderer\StaticGraphicRenderer;
7			use Graze\CiffRenderer\Field\Parser\ParserInterface;
8			use Graze\CiffRenderer\Field\Renderer\RendererInterface;
9			use Graze\CiffRenderer\Exception\RuntimeException;
10
11		View Code Duplication	class StaticGraphicBuilder extends AbstractBuilder
			0 ignored issues – show Duplication introduced 2016-04-23 16:33 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13			/**
14			* @return StaticGraphicParser
15			*/
16			protected function instantiateParser()
17			{
18			return new StaticGraphicParser($xmlField);
			0 ignored issues – show Bug introduced 2016-04-23 16:33 UTC by Report Bug Copy Issue Report The variable `$xmlField` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Unused Code introduced 2016-04-23 16:33 UTC by Report Bug Copy Issue Report The call to `StaticGraphicParser::__construct()` has too many arguments starting with `$xmlField`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
19			}
20
21			/**
22			* @param ParserInterface $parser
23			*
24			* @return StaticGraphicRenderer
25			*/
26			protected function instantiateRenderer(ParserInterface $parser)
27			{
28			return new StaticGraphicRenderer();
29			}
30
31			/**
32			* @param RendererInterface $renderer
33			* @param ParserInterface $parser
34			*
35			* @return StaticGraphicRenderer
36			*/
37	1		public function buildRenderer(RendererInterface $renderer, ParserInterface $parser)
38			{
39	1		$renderer = parent::buildRenderer($renderer, $parser);
40
41	1		$graphicResolver = $this->getGraphicResolver();
42	1		if (!$graphicResolver) {
43			throw new RuntimeException('Graphic resolver not set');
44			}
45
46	1		$renderer->setGraphicResolver($graphicResolver);
47
48	1		return $renderer;
49			}
50			}
51

graze / ciff-renderer

Push — master ( 4984e7...9ad690 )

StaticGraphicBuilder::buildRenderer() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like