Graze\CiffRenderer\Parser\FieldParser\FieldParserGraphicPrimitive

Complexity

Total Complexity

2

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getLineWeight()	0	3	1
A	getShape()	0	3	1

<?php

namespace Graze\CiffRenderer\Parser\FieldParser;

use Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface;

class FieldParserGraphicPrimitive extends AbstractFieldParser implements FieldParserInterface
{
    /**
     * @return string
     */
    public function getShape()
    {
        return (string) $this->xmlField->Graphic->Primitive->Shape;

Accessing Graphic on the interface Graze\CiffRenderer\SimpleXmlElement\SimpleXmlElementInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @return float
     */
    public function getLineWeight()
    {
        return (float) $this->xmlField->Graphic->Primitive->LineW;

Accessing Graphic on the interface Graze\CiffRenderer\SimpleXmlElement\SimpleXmlElementInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}