FieldSorter::sort() - Code Metrics - Inspection of "Refactor - 01 - decoupling" - graze/ciff-renderer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by John

created 2017-01-04 16:59 UTC

FieldSorter::sort() A

↳ Parent: FieldSorter

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	0
cts	8
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	6

<?php

namespace Graze\CiffRenderer\Parser;

use Graze\CiffRenderer\Parser\FieldType;
use Graze\CiffRenderer\Exception\UnsupportedFieldTypeException;

class FieldSorter
{
    /**
     * @var int
     */
    protected $fieldTypeToOrder = [
        FieldType::FIELD_STATIC_GRAPHIC    => 1,
        FieldType::FIELD_FIXED_TEXT        => 2,
        FieldType::FIELD_BARCODE           => 3,
        FieldType::FIELD_DATE              => 4,
        FieldType::FIELD_OFFSET_DATE       => 5,
        FieldType::FIELD_MERGE_FIELD       => 6,
        FieldType::FIELD_GRAPHIC_PRIMITIVE => 7
    ];

    /**
     * @param int $fieldType
     * @return int
     * @throws UnsupportedFieldTypeException;
     */
    private function getOrderByFieldType($fieldType)
    {
        if (!isset($this->fieldTypeToOrder[$fieldType])) {
            throw new UnsupportedFieldTypeException($fieldType);
        }

        return $this->fieldTypeToOrder[$fieldType];
    }

    /**
     * @param array $fields
     * @return array
     */
    public function sort(array $fields)
    {
        $fieldKeyToOrder = [];
        foreach ($fields as $key => $field) {
            $fieldType = (string) $field->FldType; // @codingStandardsIgnoreLine
            $fieldKeyToOrder[$key] = $this->getOrderByFieldType($fieldType);
        }

        // sort
        asort($fieldKeyToOrder);

        // apply the sort to the fields
        return array_replace($fieldKeyToOrder, $fields);
    }
}


1			<?php
2
3			namespace Graze\CiffRenderer\Parser;
4
5			use Graze\CiffRenderer\Parser\FieldType;
6			use Graze\CiffRenderer\Exception\UnsupportedFieldTypeException;
7
8			class FieldSorter
9			{
10			/**
11			* @var int
12			*/
13			protected $fieldTypeToOrder = [
14			FieldType::FIELD_STATIC_GRAPHIC => 1,
15			FieldType::FIELD_FIXED_TEXT => 2,
16			FieldType::FIELD_BARCODE => 3,
17			FieldType::FIELD_DATE => 4,
18			FieldType::FIELD_OFFSET_DATE => 5,
19			FieldType::FIELD_MERGE_FIELD => 6,
20			FieldType::FIELD_GRAPHIC_PRIMITIVE => 7
21			];
22
23			/**
24			* @param int $fieldType
25			* @return int
26			* @throws UnsupportedFieldTypeException;
27			*/
28			private function getOrderByFieldType($fieldType)
29			{
30			if (!isset($this->fieldTypeToOrder[$fieldType])) {
31			throw new UnsupportedFieldTypeException($fieldType);
32			}
33
34			return $this->fieldTypeToOrder[$fieldType];
35			}
36
37			/**
38			* @param array $fields
39			* @return array
40			*/
41			public function sort(array $fields)
42			{
43			$fieldKeyToOrder = [];
44			foreach ($fields as $key => $field) {
45			$fieldType = (string) $field->FldType; // @codingStandardsIgnoreLine
46			$fieldKeyToOrder[$key] = $this->getOrderByFieldType($fieldType);
47			}
48
49			// sort
50			asort($fieldKeyToOrder);
51
52			// apply the sort to the fields
53			return array_replace($fieldKeyToOrder, $fields);
54			}
55			}
56

graze / ciff-renderer

Pull Request — master (#19)

FieldSorter::sort() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like