AbstractFieldParserDate::getDateTime()

Completed

Push — refactor-04-parser-tests ( dc4950...bd4663 )

by John

created 2016-12-02 12:30 UTC

↳ Parent: AbstractFieldParserDate

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	1
ccs	0
cts	0
cp	0
c	0
b	0
f	0
nc	1

<?php

namespace Graze\CiffRenderer\Parser\FieldParser;

use Graze\CiffRenderer\Parser\FieldParser\FieldParserFixedText;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface;
use Graze\CiffRenderer\Parser\FieldParser\DateFormatter\DateFormatterFactory;
use Graze\CiffRenderer\Exception\UnsupportedDateFormatException;

abstract class AbstractFieldParserDate extends FieldParserFixedText implements FieldParserInterface
{
    /**
     * @var \DateTimeImmutable
     */
    protected $dateTimeNow;

    /**
     * @var DateFormatterFactory
     */
    private $dateFormatterFactory;

    /**
     * @param \DateTimeImmutable $dateTimeNow
     * @param DateFormatterFactory $dateFormatterFactory
     */
    public function __construct(\DateTimeImmutable $dateTimeNow, DateFormatterFactory $dateFormatterFactory)
    {
        $this->dateTimeNow = $dateTimeNow;
        $this->dateFormatterFactory = $dateFormatterFactory;
    }

    /**
     * @return string
     * @throws UnsupportedDateFormatException
     */
    public function getText()
    {
        try {
            $dateFormat = $this->getDateFormat();
            $dateFormatter = $this->dateFormatterFactory->getFormatter($dateFormat);
            return $dateFormatter->format($this->getDateTime(), $dateFormat);
        } catch (\Exception $e) {
            throw new UnsupportedDateFormatException($this->getDateFormat());
        }
    }

    /**
     * Fetch a DateTime object set to the correct date/time.
     *
     * @return \DateTimeInterface
     */
    abstract protected function getDateTime();

    /**
     * @return string
     */
    public function getDateFormat()
    {
        return (string) $this->xmlField->Data->Object->Default;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * @return FieldParserInterface
     */
    public static function factory()
    {
        return new static(
            new \DateTimeImmutable(),
            new DateFormatterFactory()
        );
    }
}


1		<?php
2
3		namespace Graze\CiffRenderer\Parser\FieldParser;
4
5		use Graze\CiffRenderer\Parser\FieldParser\FieldParserFixedText;
6		use Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface;
7		use Graze\CiffRenderer\Parser\FieldParser\DateFormatter\DateFormatterFactory;
8		use Graze\CiffRenderer\Exception\UnsupportedDateFormatException;
9
10		abstract class AbstractFieldParserDate extends FieldParserFixedText implements FieldParserInterface
11		{
12		/**
13		* @var \DateTimeImmutable
14		*/
15		protected $dateTimeNow;
16
17		/**
18		* @var DateFormatterFactory
19		*/
20		private $dateFormatterFactory;
21
22		/**
23		* @param \DateTimeImmutable $dateTimeNow
24		* @param DateFormatterFactory $dateFormatterFactory
25		*/
26	16	public function __construct(\DateTimeImmutable $dateTimeNow, DateFormatterFactory $dateFormatterFactory)
27		{
28	16	$this->dateTimeNow = $dateTimeNow;
29	16	$this->dateFormatterFactory = $dateFormatterFactory;
30	16	}
31
32		/**
33		* @return string
34		* @throws UnsupportedDateFormatException
35		*/
36	2	public function getText()
37		{
38		try {
39	2	$dateFormat = $this->getDateFormat();
40	2	$dateFormatter = $this->dateFormatterFactory->getFormatter($dateFormat);
41	2	return $dateFormatter->format($this->getDateTime(), $dateFormat);
42		} catch (\Exception $e) {
43		throw new UnsupportedDateFormatException($this->getDateFormat());
44		}
45		}
46
47		/**
48		* Fetch a DateTime object set to the correct date/time.
49		*
50		* @return \DateTimeInterface
51		*/
52		abstract protected function getDateTime();
53
54		/**
55		* @return string
56		*/
57	2	public function getDateFormat()
58		{
59	2	return (string) $this->xmlField->Data->Object->Default;
		0 ignored issues – show Bug introduced 2016-12-02 12:36 UTC by Report Bug Copy Issue Report Accessing `Data` on the interface `Graze\CiffRenderer\Parse...mpleXmlElementInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
60		}
61
62		/**
63		* @return FieldParserInterface
64		*/
65	2	public static function factory()
66		{
67	2	return new static(
68	2	new \DateTimeImmutable(),
69	2	new DateFormatterFactory()
70		);
71		}
72		}
73

graze / ciff-renderer

Push — refactor-04-parser-tests ( dc4950...bd4663 )

AbstractFieldParserDate::getDateTime()

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like