Complex classes like Addon_Settings often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Addon_Settings, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class Addon_Settings extends \GFAddOn { |
||
19 | /** |
||
20 | * @var string Title of the plugin to be used on the settings page, form settings and plugins page. Example: 'Gravity Forms MailChimp Add-On' |
||
21 | */ |
||
22 | protected $_title = 'GravityView'; |
||
23 | |||
24 | /** |
||
25 | * @var string Short version of the plugin title to be used on menus and other places where a less verbose string is useful. Example: 'MailChimp' |
||
26 | */ |
||
27 | protected $_short_title = 'GravityView'; |
||
28 | |||
29 | /** |
||
30 | * @var string URL-friendly identifier used for form settings, add-on settings, text domain localization... |
||
31 | */ |
||
32 | protected $_slug = 'gravityview'; |
||
33 | |||
34 | /** |
||
35 | * @var string|array A string or an array of capabilities or roles that can uninstall the plugin |
||
36 | */ |
||
37 | protected $_capabilities_uninstall = 'gravityview_uninstall'; |
||
38 | |||
39 | /** |
||
40 | * @var string|array A string or an array of capabilities or roles that have access to the settings page |
||
41 | */ |
||
42 | protected $_capabilities_app_settings = 'gravityview_view_settings'; |
||
43 | |||
44 | /** |
||
45 | * @var string|array A string or an array of capabilities or roles that have access to the settings page |
||
46 | */ |
||
47 | protected $_capabilities_app_menu = 'gravityview_view_settings'; |
||
48 | |||
49 | /** |
||
50 | * @var string The hook suffix for the app menu |
||
51 | */ |
||
52 | public $app_hook_suffix = 'gravityview'; |
||
53 | |||
54 | /** |
||
55 | * @var \GV\License_Handler Process license validation |
||
56 | */ |
||
57 | private $License_Handler; |
||
58 | |||
59 | /** |
||
60 | * @var bool Whether we have initialized already or not. |
||
61 | */ |
||
62 | private static $initialized = false; |
||
63 | |||
64 | 2 | public function __construct() { |
|
76 | |||
77 | /** |
||
78 | * Run actions when initializing admin. |
||
79 | * |
||
80 | * Triggers the license key notice, et.c |
||
81 | * |
||
82 | * @return void |
||
83 | */ |
||
84 | 1 | public function init_admin() { |
|
96 | |||
97 | /** |
||
98 | * Change the settings page header title to "GravityView" |
||
99 | * |
||
100 | * @param $setting_tabs |
||
101 | * |
||
102 | * @return array |
||
103 | */ |
||
104 | 1 | public function modify_app_settings_menu_title( $setting_tabs ) { |
|
108 | |||
109 | /** |
||
110 | * Load license handler in admin-ajax.php |
||
111 | * |
||
112 | * @return void |
||
113 | */ |
||
114 | 1 | public function init_ajax() { |
|
117 | |||
118 | /** |
||
119 | * Make sure the license handler is available |
||
120 | * |
||
121 | * @return void |
||
122 | */ |
||
123 | 1 | private function _load_license_handler() { |
|
129 | |||
130 | /** |
||
131 | * Add global Settings page for Multisite |
||
132 | * @since 1.7.6 |
||
133 | * @return void |
||
134 | */ |
||
135 | 1 | public function add_network_menu() { |
|
143 | |||
144 | /** |
||
145 | * Uninstall all traces of GravityView |
||
146 | * |
||
147 | * Note: method is public because parent method is public |
||
148 | * |
||
149 | * @return bool |
||
150 | */ |
||
151 | 1 | public function uninstall() { |
|
163 | |||
164 | /** |
||
165 | * Prevent uninstall tab from being shown by returning false for the uninstall capability check. Otherwise: |
||
166 | * @inheritDoc |
||
167 | * |
||
168 | * @hack |
||
169 | * |
||
170 | * @param array|string $caps |
||
171 | * |
||
172 | * @return bool |
||
173 | */ |
||
174 | 1 | public function current_user_can_any( $caps ) { |
|
180 | |||
181 | 1 | public function uninstall_warning_message() { |
|
186 | |||
187 | /** |
||
188 | * Get an array of reasons why the plugin might be uninstalled |
||
189 | * |
||
190 | * @since 1.17.5 |
||
191 | * |
||
192 | * @return array Array of reasons with the label and followup questions for each uninstall reason |
||
193 | */ |
||
194 | 1 | private function get_uninstall_reasons() { |
|
218 | |||
219 | /** |
||
220 | * Display a feedback form when the plugin is uninstalled |
||
221 | * |
||
222 | * @since 1.17.5 |
||
223 | * |
||
224 | * @return string HTML of the uninstallation form |
||
225 | */ |
||
226 | 1 | public function uninstall_form() { |
|
352 | |||
353 | 1 | public function app_settings_uninstall_tab() { |
|
395 | |||
396 | 1 | public function app_settings_tab() { |
|
403 | |||
404 | /** |
||
405 | * The Settings title |
||
406 | * |
||
407 | * @return string |
||
408 | */ |
||
409 | 1 | public function app_settings_title() { |
|
412 | |||
413 | /** |
||
414 | * Prevent displaying of any icon |
||
415 | * |
||
416 | * @return string |
||
417 | */ |
||
418 | 1 | public function app_settings_icon() { |
|
421 | |||
422 | /** |
||
423 | * Retrieve a setting. |
||
424 | * |
||
425 | * @deprecated Use \GV\Addon_Settings::get |
||
426 | * @param string $setting_name The setting key. |
||
427 | * |
||
428 | * @return mixed The setting or null |
||
429 | */ |
||
430 | 1 | public function get_app_setting( $setting_name ) { |
|
433 | |||
434 | /** |
||
435 | * Retrieve a setting. |
||
436 | * |
||
437 | * @param string $key The setting key. |
||
438 | * @param string $default A default if not found. |
||
439 | * |
||
440 | * @return mixed The setting value. |
||
441 | */ |
||
442 | 162 | public function get( $key, $default = null ) { |
|
456 | |||
457 | /** |
||
458 | * Get the setting for GravityView by name |
||
459 | * |
||
460 | * @deprecated Use gravityview()->plugin->settings->get() |
||
461 | * @param string $key Option key to fetch |
||
462 | * |
||
463 | * @return mixed |
||
464 | */ |
||
465 | 1 | static public function getSetting( $key ) { |
|
466 | 1 | if ( gravityview()->plugin->settings instanceof Addon_Settings ) { |
|
467 | 1 | return gravityview()->plugin->settings->get( $key ); |
|
468 | } |
||
469 | } |
||
470 | |||
471 | /** |
||
472 | * Get all settings. |
||
473 | * |
||
474 | * @deprecated Use \GV\Addon_Settings::all() or \GV\Addon_Settings::get() |
||
475 | * |
||
476 | * @return array The settings. |
||
477 | */ |
||
478 | 1 | public function get_app_settings() { |
|
479 | 1 | return $this->all(); |
|
480 | } |
||
481 | |||
482 | /** |
||
483 | * Get all the settings. |
||
484 | * |
||
485 | * @return array The settings. |
||
486 | */ |
||
487 | 162 | public function all() { |
|
488 | 162 | $option_name = 'gravityformsaddon_' . $this->_slug . '_app_settings'; |
|
489 | |||
490 | 162 | if( is_multisite() ) { |
|
491 | $option_value = get_blog_option( get_main_site_id(), $option_name, array() ); |
||
492 | } else { |
||
493 | 162 | $option_value = get_site_option( $option_name, array() ); |
|
494 | } |
||
495 | |||
496 | 162 | return wp_parse_args( $option_value, $this->defaults() ); |
|
497 | } |
||
498 | |||
499 | /** |
||
500 | * Default settings. |
||
501 | * |
||
502 | * @deprecated Use \GV\Addon_Settings::defaults() |
||
503 | * |
||
504 | * @return array The defaults. |
||
505 | */ |
||
506 | 1 | public function get_default_settings() { |
|
507 | 1 | return $this->defaults(); |
|
508 | } |
||
509 | |||
510 | /** |
||
511 | * Default settings. |
||
512 | * |
||
513 | * @return array The defaults. |
||
514 | */ |
||
515 | 162 | private function defaults() { |
|
516 | $defaults = array( |
||
517 | // Set the default license in wp-config.php |
||
518 | 162 | 'license_key' => defined( 'GRAVITYVIEW_LICENSE_KEY' ) ? GRAVITYVIEW_LICENSE_KEY : '', |
|
519 | 162 | 'license_key_response' => '', |
|
520 | 162 | 'license_key_status' => '', |
|
521 | 162 | 'support-email' => get_bloginfo( 'admin_email' ), |
|
522 | 162 | 'no-conflict-mode' => '1', |
|
523 | 162 | 'support_port' => '1', |
|
524 | 162 | 'flexbox_search' => '1', |
|
525 | 162 | 'rest_api' => '0', |
|
526 | 162 | 'beta' => '0', |
|
527 | ); |
||
528 | |||
529 | /** |
||
530 | * @filter `gravityview/settings/default` Filter default global settings. |
||
531 | * @param[in,out] array The defaults. |
||
532 | */ |
||
533 | 162 | return apply_filters( 'gravityview/settings/defaults', $defaults ); |
|
534 | } |
||
535 | |||
536 | /*** |
||
537 | * Renders the save button for settings pages |
||
538 | * |
||
539 | * @param array $field - Field array containing the configuration options of this field |
||
540 | * @param bool $echo = true - true to echo the output to the screen, false to simply return the contents as a string |
||
541 | * |
||
542 | * @return string The HTML |
||
543 | */ |
||
544 | 2 | public function as_html( $field, $echo = true ) { |
|
545 | 2 | $field['type'] = ( isset( $field['type'] ) && in_array( $field['type'], array( 'submit','reset','button' ) ) ) ? $field['type'] : 'submit'; |
|
546 | |||
547 | 2 | $attributes = $this->get_field_attributes( $field ); |
|
548 | 2 | $default_value = Utils::get( $field, 'value', Utils::get( $field, 'default_value' ) ); |
|
549 | 2 | $value = $this->get( $field['name'], $default_value ); |
|
550 | |||
551 | |||
552 | 2 | $attributes['class'] = isset( $attributes['class'] ) ? esc_attr( $attributes['class'] ) : 'button-primary gfbutton'; |
|
553 | 2 | $name = ( $field['name'] === 'gform-settings-save' ) ? $field['name'] : '_gaddon_setting_' . $field['name']; |
|
554 | |||
555 | 2 | if ( empty( $value ) ) { |
|
556 | 2 | $value = __( 'Update Settings', 'gravityview' ); |
|
557 | } |
||
558 | |||
559 | 2 | $attributes = $this->get_field_attributes( $field ); |
|
560 | |||
561 | $html = '<input |
||
562 | 2 | type="' . $field['type'] . '" |
|
563 | 2 | name="' . esc_attr( $name ) . '" |
|
564 | 2 | value="' . $value . '" ' . |
|
565 | 2 | implode( ' ', $attributes ) . |
|
566 | 2 | ' />'; |
|
567 | |||
568 | 2 | if ( $echo ) { |
|
569 | echo $html; |
||
570 | } |
||
571 | |||
572 | 2 | return $html; |
|
573 | } |
||
574 | |||
575 | /** |
||
576 | * @deprecated Use \GV\Addon_Settings::as_html |
||
577 | */ |
||
578 | 1 | public function settings_submit( $field, $echo = true ) { |
|
579 | 1 | gravityview()->log->warning( '\GV\Addon_Settings::settings_submit has been deprecated for \GV\Addon_Settings::as_html' ); |
|
580 | 1 | return $this->as_html( $field, $echo ); |
|
581 | } |
||
582 | |||
583 | /** |
||
584 | * Check whether GravityView is being saved |
||
585 | * |
||
586 | * The generic is_save_postback() is true for all addons |
||
587 | * |
||
588 | * @since 2.0.8 |
||
589 | * |
||
590 | * @return bool |
||
591 | */ |
||
592 | 1 | public function is_save_postback() { |
|
593 | 1 | return isset( $_POST['gform-settings-save'] ) && isset( $_POST['_gravityview_save_settings_nonce'] ); |
|
594 | } |
||
595 | |||
596 | /** |
||
597 | * Display a notice if the plugin is inactive. |
||
598 | * |
||
599 | * @return void |
||
600 | */ |
||
601 | public function license_key_notice() { |
||
602 | |||
603 | if( $this->is_save_postback() ) { |
||
604 | $settings = $this->get_posted_settings(); |
||
605 | $license_key = \GV\Utils::get( $settings, 'license_key' ); |
||
606 | $license_status = \GV\Utils::get( $settings, 'license_key_status', 'inactive' ); |
||
607 | } else { |
||
608 | $license_status = $this->get( 'license_key_status', 'inactive' ); |
||
609 | $license_key = $this->get( 'license_key' ); |
||
610 | } |
||
611 | |||
612 | $license_id = empty( $license_key ) ? 'license' : $license_key; |
||
613 | |||
614 | $message = esc_html__( 'Your GravityView license %s. This means you’re missing out on updates and support! %sActivate your license%s or %sget a license here%s.', 'gravityview' ); |
||
615 | |||
616 | /** @internal Do not use! Will change without notice (pun slightly intended). */ |
||
617 | $message = apply_filters( 'gravityview/settings/license-key-notice', $message ); |
||
618 | |||
619 | /** |
||
620 | * I wanted to remove the period from after the buttons in the string, |
||
621 | * but didn't want to mess up the translation strings for the translators. |
||
622 | */ |
||
623 | $message = mb_substr( $message, 0, mb_strlen( $message ) - 1 ); |
||
624 | $title = __( 'Inactive License', 'gravityview'); |
||
625 | $status = ''; |
||
626 | $update_below = false; |
||
627 | $primary_button_link = admin_url( 'edit.php?post_type=gravityview&page=gravityview_settings' ); |
||
628 | |||
629 | switch ( $license_status ) { |
||
630 | /** @since 1.17 */ |
||
631 | case 'expired': |
||
632 | $title = __( 'Expired License', 'gravityview' ); |
||
633 | $status = 'expired'; |
||
634 | $message = $this->get_license_handler()->strings( 'expired', $this->get( 'license_key_response' ) ); |
||
635 | break; |
||
636 | case 'invalid': |
||
637 | $title = __( 'Invalid License', 'gravityview' ); |
||
638 | $status = __( 'is invalid', 'gravityview' ); |
||
639 | break; |
||
640 | case 'deactivated': |
||
641 | $status = __( 'is inactive', 'gravityview' ); |
||
642 | $update_below = __( 'Activate your license key below.', 'gravityview' ); |
||
643 | break; |
||
644 | /** @noinspection PhpMissingBreakStatementInspection */ |
||
645 | case '': |
||
646 | $license_status = 'site_inactive'; |
||
647 | // break intentionally left blank |
||
648 | case 'inactive': |
||
649 | case 'site_inactive': |
||
650 | $status = __( 'has not been activated', 'gravityview' ); |
||
651 | $update_below = __( 'Activate your license key below.', 'gravityview' ); |
||
652 | break; |
||
653 | } |
||
654 | $url = 'https://gravityview.co/pricing/?utm_source=admin_notice&utm_medium=admin&utm_content='.$license_status.'&utm_campaign=Admin%20Notice'; |
||
655 | |||
656 | // Show a different notice on settings page for inactive licenses (hide the buttons) |
||
657 | if ( $update_below && gravityview()->request->is_admin( '', 'settings' ) ) { |
||
658 | $message = sprintf( $message, $status, '<div class="hidden">', '', '', '</div><a href="#" onclick="jQuery(\'#license_key\').focus(); return false;">' . $update_below . '</a>' ); |
||
659 | } else { |
||
660 | $message = sprintf( $message, $status, "\n\n" . '<a href="' . esc_url( $primary_button_link ) . '" class="button button-primary">', '</a>', '<a href="' . esc_url( $url ) . '" class="button button-secondary">', '</a>' ); |
||
661 | } |
||
662 | |||
663 | if ( empty( $status ) ) { |
||
664 | return; |
||
665 | } |
||
666 | |||
667 | \GravityView_Admin_Notices::add_notice( array( |
||
668 | 'message' => $message, |
||
669 | 'class' => 'notice notice-warning', |
||
670 | 'title' => $title, |
||
671 | 'cap' => 'gravityview_edit_settings', |
||
672 | 'dismiss' => sha1( $license_status . '_' . $license_id . '_' . date( 'z' ) ), // Show every day, instead of every 8 weeks (which is the default) |
||
673 | ) ); |
||
674 | } |
||
675 | |||
676 | /** |
||
677 | * Allow public access to the GV\License_Handler class |
||
678 | * @since 1.7.4 |
||
679 | * |
||
680 | * @return \GV\License_Handler |
||
681 | */ |
||
682 | 1 | public function get_license_handler() { |
|
683 | 1 | return $this->License_Handler; |
|
684 | } |
||
685 | |||
686 | /** |
||
687 | * Add tooltip script to app settings page. Not enqueued by Gravity Forms for some reason. |
||
688 | * |
||
689 | * @since 1.21.5 |
||
690 | * |
||
691 | * @see GFAddOn::scripts() |
||
692 | * |
||
693 | * @return array Array of scripts |
||
694 | */ |
||
695 | 15 | public function scripts() { |
|
709 | |||
710 | /** |
||
711 | * Register styles in the app admin page |
||
712 | * @return array |
||
713 | */ |
||
714 | 15 | public function styles() { |
|
715 | 15 | $styles = parent::styles(); |
|
716 | |||
717 | 15 | $styles[] = array( |
|
718 | 15 | 'handle' => 'gravityview_settings', |
|
719 | 15 | 'src' => plugins_url( 'assets/css/admin-settings.css', GRAVITYVIEW_FILE ), |
|
720 | 15 | 'version' => Plugin::$version, |
|
721 | 'deps' => array( |
||
722 | 'gform_admin', |
||
723 | 'gaddon_form_settings_css', |
||
724 | 'gform_tooltip', |
||
725 | 'gform_font_awesome', |
||
726 | ), |
||
727 | 'enqueue' => array( |
||
728 | array( 'admin_page' => array( |
||
729 | 'app_settings', |
||
730 | ) ), |
||
731 | ) |
||
732 | ); |
||
733 | |||
734 | 15 | return $styles; |
|
735 | } |
||
736 | |||
737 | /** |
||
738 | * Add Settings link to GravityView menu |
||
739 | * @return void |
||
740 | */ |
||
741 | 1 | public function create_app_menu() { |
|
742 | /** |
||
743 | * If not multisite, always show. |
||
744 | * If multisite and the plugin is network activated, show; we need to register the submenu page for the Network Admin settings to work. |
||
745 | * If multisite and not network admin, we don't want the settings to show. |
||
746 | * @since 1.7.6 |
||
747 | */ |
||
748 | 1 | $show_submenu = ( ! is_multisite() ) || is_main_site() || ( ! gravityview()->plugin->is_network_activated() ) || ( is_network_admin() && gravityview()->plugin->is_network_activated() ); |
|
749 | |||
750 | /** |
||
751 | * Override whether to show the Settings menu on a per-blog basis. |
||
752 | * @since 1.7.6 |
||
753 | * @param bool $hide_if_network_activated Default: true |
||
754 | */ |
||
755 | 1 | $show_submenu = apply_filters( 'gravityview/show-settings-menu', $show_submenu ); |
|
756 | |||
757 | 1 | if ( $show_submenu ) { |
|
758 | 1 | add_submenu_page( 'edit.php?post_type=gravityview', __( 'Settings', 'gravityview' ), __( 'Settings', 'gravityview' ), $this->_capabilities_app_settings, $this->_slug . '_settings', array( $this, 'app_tab_page' ) ); |
|
759 | } |
||
760 | 1 | } |
|
761 | |||
762 | /** |
||
763 | * Gets the required indicator |
||
764 | * Gets the markup of the required indicator symbol to highlight fields that are required |
||
765 | * |
||
766 | * @param $field - The field meta. |
||
767 | * |
||
768 | * @return string - Returns markup of the required indicator symbol |
||
769 | */ |
||
770 | 1 | public function get_required_indicator( $field ) { |
|
773 | |||
774 | /** |
||
775 | * Specify the settings fields to be rendered on the plugin settings page |
||
776 | * |
||
777 | * @return array |
||
778 | */ |
||
779 | 1 | public function app_settings_fields() { |
|
780 | 1 | $default_settings = $this->defaults(); |
|
781 | |||
782 | 1 | $disabled_attribute = \GVCommon::has_cap( 'gravityview_edit_settings' ) ? false : 'disabled'; |
|
783 | |||
784 | $fields = array( |
||
785 | array( |
||
985 | |||
986 | /** |
||
987 | * Updates app settings with the provided settings |
||
988 | * |
||
989 | * Same as the GFAddon, except it returns the value from update_option() |
||
990 | * |
||
991 | * @param array $settings - App settings to be saved |
||
992 | * |
||
993 | * @deprecated Use \GV\Addon_Settings::set or \GV\Addon_Settings::update |
||
994 | * |
||
995 | * @return boolean False if value was not updated and true if value was updated. |
||
996 | */ |
||
997 | public function update_app_settings( $settings ) { |
||
1000 | |||
1001 | /** |
||
1002 | * Sets a subset of settings. |
||
1003 | * |
||
1004 | * @param array|string An array of settings to update, or string (key) and $value to update one setting. |
||
1005 | * @param mixed $value A value if $settings is string (key). Default: null. |
||
1006 | */ |
||
1007 | 4 | public function set( $settings, $value = null ) { |
|
1014 | |||
1015 | /** |
||
1016 | * Updates settings. |
||
1017 | * |
||
1018 | * @param array $settings The settings array. |
||
1019 | * |
||
1020 | * @return boolean False if value was not updated and true if value was updated. |
||
1021 | */ |
||
1022 | 1 | public function update( $settings ) { |
|
1025 | |||
1026 | /** |
||
1027 | * Register the settings field for the EDD License field type |
||
1028 | * @param array $field |
||
1029 | * @param bool $echo Whether to echo the |
||
1030 | * |
||
1031 | * @return string |
||
1032 | */ |
||
1033 | 1 | protected function settings_edd_license( $field, $echo = true ) { |
|
1051 | |||
1052 | /** |
||
1053 | * Allow pure HTML settings row |
||
1054 | * |
||
1055 | * @since 2.0.6 |
||
1056 | * |
||
1057 | * @param array $field |
||
1058 | * @param bool $echo Whether to echo the |
||
1059 | * |
||
1060 | * @return string |
||
1061 | */ |
||
1062 | 1 | protected function settings_html( $field, $echo = true ) { |
|
1072 | |||
1073 | /** |
||
1074 | * No <th> needed for pure HTML settings row |
||
1075 | * |
||
1076 | * @since 2.0.6 |
||
1077 | * |
||
1078 | * @param array $field |
||
1079 | * |
||
1080 | * @return void |
||
1081 | */ |
||
1082 | 1 | public function single_setting_row_html( $field ) { |
|
1093 | |||
1094 | /** |
||
1095 | * Allow customizing the Save field parameters |
||
1096 | * |
||
1097 | * @param array $field |
||
1098 | * @param bool $echo |
||
1099 | * |
||
1100 | * @return string |
||
1101 | */ |
||
1102 | 1 | public function settings_save( $field, $echo = true ) { |
|
1120 | |||
1121 | /** |
||
1122 | * Keep GravityView styling for `$field['description']`, even though Gravity Forms added support for it |
||
1123 | * |
||
1124 | * Converts `$field['description']` to `$field['gv_description']` |
||
1125 | * Converts `$field['subtitle']` to `$field['description']` |
||
1126 | * |
||
1127 | * @see \GV\Addon_Settings::single_setting_label Converts `gv_description` back to `description` |
||
1128 | * @see http://share.gravityview.co/P28uGp/2OIRKxog for image that shows subtitle vs description |
||
1129 | * |
||
1130 | * @since 1.21.5.2 |
||
1131 | * |
||
1132 | * @param array $field |
||
1133 | * |
||
1134 | * @return void |
||
1135 | */ |
||
1136 | 1 | public function single_setting_row( $field ) { |
|
1141 | |||
1142 | /** |
||
1143 | * The same as the parent, except added support for field descriptions |
||
1144 | * @inheritDoc |
||
1145 | * @param $field array |
||
1146 | */ |
||
1147 | 1 | public function single_setting_label( $field ) { |
|
1153 | |||
1154 | /** |
||
1155 | * Check for the `gravityview_edit_settings` capability before saving plugin settings. |
||
1156 | * Gravity Forms says you're able to edit if you're able to view settings. GravityView allows two different permissions. |
||
1157 | * |
||
1158 | * @since 1.15 |
||
1159 | * @return void |
||
1160 | */ |
||
1161 | 1 | public function maybe_save_app_settings() { |
|
1172 | |||
1173 | /** |
||
1174 | * When the settings are saved, make sure the license key matches the previously activated key |
||
1175 | * |
||
1176 | * @return array settings from parent::get_posted_settings(), with `license_key_response` and `license_key_status` potentially unset |
||
1177 | */ |
||
1178 | 1 | public function get_posted_settings() { |
|
1193 | } |
||
1194 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.