Completed
Pull Request — master (#1143)
by Zack
16:48
created
future/includes/class-gv-view.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 	 *                                 rest      A REST call.
336 336
 	 * @param \GV\Request $request The request
337 337
 	 *
338
-	 * @return bool|\WP_Error An error if this View shouldn't be rendered here.
338
+	 * @return \WP_Error|null An error if this View shouldn't be rendered here.
339 339
 	 */
340 340
 	public function can_render( $context = null, $request = null ) {
341 341
 		if ( ! $request ) {
@@ -745,6 +745,7 @@  discard block
 block discarded – undo
745 745
 	 * Retrieve the entries for the current view and request.
746 746
 	 *
747 747
 	 * @param \GV\Request The request. Usued for now.
748
+	 * @param Request $request
748 749
 	 *
749 750
 	 * @return \GV\Entry_Collection The entries.
750 751
 	 */
Please login to merge, or discard this patch.
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 		$slug = apply_filters( 'gravityview_slug', 'view' );
210 210
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211 211
 
212
-		add_filter( 'query_vars', function( $query_vars ) { 
212
+		add_filter( 'query_vars', function( $query_vars ) {
213 213
 			$query_vars[] = 'csv';
214 214
 			return $query_vars;
215 215
 		} );
@@ -254,8 +254,9 @@  discard block
 block discarded – undo
254 254
 		 * Check permissions.
255 255
 		 */
256 256
 		while ( $error = $view->can_render( null, $request ) ) {
257
-			if ( ! is_wp_error( $error ) )
258
-				break;
257
+			if ( ! is_wp_error( $error ) ) {
258
+							break;
259
+			}
259 260
 
260 261
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
261 262
 				case 'post_password_required':
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gravityview.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,9 @@
 block discarded – undo
79 79
 		 * Check permissions.
80 80
 		 */
81 81
 		while ( $error = $view->can_render( array( 'shortcode' ), $request ) ) {
82
-			if ( ! is_wp_error( $error ) )
83
-				break;
82
+			if ( ! is_wp_error( $error ) ) {
83
+							break;
84
+			}
84 85
 
85 86
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
86 87
 				case 'post_password_required':
Please login to merge, or discard this patch.
future/includes/rest/class-gv-rest-views-route.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -319,8 +319,9 @@
 block discarded – undo
319 319
 		}
320 320
 
321 321
 		while ( $error = $view->can_render( array( 'rest' ), $request ) ) {
322
-			if ( ! is_wp_error( $error ) )
323
-				break;
322
+			if ( ! is_wp_error( $error ) ) {
323
+							break;
324
+			}
324 325
 
325 326
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
326 327
 				case 'rest_disabled':
Please login to merge, or discard this patch.