Completed
Pull Request — develop (#1577)
by Zack
31:56 queued 11:58
created
future/includes/class-gv-field.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	 * @return \GV\Field The field implementation from configuration (\GV\GF_Field, \GV\Internal_Field).
167 167
 	 */
168 168
 	public static function from_configuration( $configuration ) {
169
-		if ( empty( $configuration['id'] ) ) {
169
+		if ( empty( $configuration[ 'id' ] ) ) {
170 170
 			$field = new self();
171 171
 			gravityview()->log->error( 'Trying to get field from configuration without a field ID.', array( 'data' => $configuration ) );
172 172
 			$field->update_configuration( $configuration );
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 		} else {
180 180
 			$trace = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS );
181 181
 		}
182
-		$trace = $trace[1];
183
-		if ( $trace['function'] == 'from_configuration' && $trace['class'] == __CLASS__ ) {
182
+		$trace = $trace[ 1 ];
183
+		if ( $trace[ 'function' ] == 'from_configuration' && $trace[ 'class' ] == __CLASS__ ) {
184 184
 			$field = new self();
185 185
 			gravityview()->log->error( 'Infinite loop protection tripped. Returning default class here.' );
186 186
 			$field->update_configuration( $configuration );
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 		}
189 189
 
190 190
 		/** @type \GV\GF_Field|\GV\Internal_Field $field_class Determine the field implementation to use, and try to use. */
191
-		$field_class = is_numeric( $configuration['id'] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
191
+		$field_class = is_numeric( $configuration[ 'id' ] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
192 192
 
193 193
 		/**
194 194
 		 * @filter `gravityview/field/class` Filter the field class about to be created from the configuration.
@@ -227,24 +227,24 @@  discard block
 block discarded – undo
227 227
 	public function update_configuration( $configuration ) {
228 228
 		$configuration = wp_parse_args( $configuration, $this->as_configuration() );
229 229
 
230
-		if ( $this->ID != $configuration['id'] ) {
230
+		if ( $this->ID != $configuration[ 'id' ] ) {
231 231
 			/** Smelling trouble here... */
232 232
 			gravityview()->log->warning( 'ID is being changed for {field_class} instance, but implementation is not. Use ::from_configuration instead', array( 'field_class', __CLASS__ ) );
233 233
 		}
234 234
 
235
-		$this->ID = $configuration['id'];
236
-		$this->label = $configuration['label'];
237
-		$this->show_label = $configuration['show_label'] == '1';
238
-		$this->custom_label = $configuration['custom_label'];
239
-		$this->custom_class = $configuration['custom_class'];
240
-		$this->cap = $configuration['only_loggedin'] == '1' ? $configuration['only_loggedin_cap'] : '';
241
-		$this->search_filter = $configuration['search_filter'] == '1';
242
-		$this->show_as_link = $configuration['show_as_link'] == '1';
235
+		$this->ID = $configuration[ 'id' ];
236
+		$this->label = $configuration[ 'label' ];
237
+		$this->show_label = $configuration[ 'show_label' ] == '1';
238
+		$this->custom_label = $configuration[ 'custom_label' ];
239
+		$this->custom_class = $configuration[ 'custom_class' ];
240
+		$this->cap = $configuration[ 'only_loggedin' ] == '1' ? $configuration[ 'only_loggedin_cap' ] : '';
241
+		$this->search_filter = $configuration[ 'search_filter' ] == '1';
242
+		$this->show_as_link = $configuration[ 'show_as_link' ] == '1';
243 243
 
244 244
 		/** Shared among all field types (sort of). */
245 245
 		$shared_configuration_keys = array(
246 246
 			'id', 'label', 'show_label', 'custom_label', 'custom_class',
247
-			'only_loggedin' ,'only_loggedin_cap', 'search_filter', 'show_as_link',
247
+			'only_loggedin', 'only_loggedin_cap', 'search_filter', 'show_as_link',
248 248
 		);
249 249
 
250 250
 		/** Everything else goes into the properties for now. @todo subclasses! */
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 
274 274
 		/** A custom label is available. */
275 275
 		if ( ! empty( $this->custom_label ) ) {
276
-			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ? : null : null, $entry ? $entry->as_entry() : null );
276
+			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ?: null : null, $entry ? $entry->as_entry() : null );
277 277
 		}
278 278
 
279 279
 		return '';
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 	 * @return mixed|null The value for the given configuration key, null if doesn't exist.
360 360
 	 */
361 361
 	public function __get( $key ) {
362
-		switch( $key ) {
362
+		switch ( $key ) {
363 363
 			default:
364 364
 				if ( isset( $this->configuration[ $key ] ) ) {
365 365
 					return $this->configuration[ $key ];
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 	 * @return boolean Whether this $key is set or not.
378 378
 	 */
379 379
 	public function __isset( $key ) {
380
-		switch( $key ) {
380
+		switch ( $key ) {
381 381
 			default:
382 382
 				return isset( $this->configuration[ $key ] );
383 383
 		}
Please login to merge, or discard this patch.
includes/admin/metaboxes/class-gravityview-admin-metaboxes.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
 	function update_priority() {
53 53
 		global $wp_meta_boxes;
54 54
 
55
-		if ( ! empty( $wp_meta_boxes['gravityview'] ) ) {
55
+		if ( ! empty( $wp_meta_boxes[ 'gravityview' ] ) ) {
56 56
 			foreach ( array( 'high', 'core', 'low' ) as $position ) {
57
-				if ( isset( $wp_meta_boxes['gravityview']['normal'][ $position ] ) ) {
58
-					foreach ( $wp_meta_boxes['gravityview']['normal'][ $position ] as $key => $meta_box ) {
57
+				if ( isset( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ] ) ) {
58
+					foreach ( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ] as $key => $meta_box ) {
59 59
 						if ( ! preg_match( '/^gravityview_/ism', $key ) ) {
60
-							$wp_meta_boxes['gravityview']['advanced'][ $position ][ $key ] = $meta_box;
61
-							unset( $wp_meta_boxes['gravityview']['normal'][ $position ][ $key ] );
60
+							$wp_meta_boxes[ 'gravityview' ][ 'advanced' ][ $position ][ $key ] = $meta_box;
61
+							unset( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ][ $key ] );
62 62
 						}
63 63
 					}
64 64
 				}
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 
192 192
 		foreach ( $metaboxes as $m ) {
193 193
 
194
-			$tab = new GravityView_Metabox_Tab( $m['id'], $m['title'], $m['file'], $m['icon-class'], $m['callback'], $m['callback_args'] );
194
+			$tab = new GravityView_Metabox_Tab( $m[ 'id' ], $m[ 'title' ], $m[ 'file' ], $m[ 'icon-class' ], $m[ 'callback' ], $m[ 'callback_args' ] );
195 195
 
196 196
 			GravityView_Metabox_Tabs::add( $tab );
197 197
 
@@ -261,13 +261,13 @@  discard block
 block discarded – undo
261 261
 
262 262
 		$form = gravityview_get_form( $curr_form );
263 263
 
264
-		$get_id_backup = isset( $_GET['id'] ) ? $_GET['id'] : null;
264
+		$get_id_backup = isset( $_GET[ 'id' ] ) ? $_GET[ 'id' ] : null;
265 265
 
266
-		if ( isset( $form['id'] ) ) {
266
+		if ( isset( $form[ 'id' ] ) ) {
267 267
 			$form_script = 'var form = ' . GFCommon::json_encode( $form ) . ';';
268 268
 
269 269
 			// The `gf_vars()` method needs a $_GET[id] variable set with the form ID.
270
-			$_GET['id'] = $form['id'];
270
+			$_GET[ 'id' ] = $form[ 'id' ];
271 271
 
272 272
 		} else {
273 273
 			$form_script = 'var form = new Form();';
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
 		$output = '<script type="text/javascript" data-gv-merge-tags="1">' . $form_script . "\n" . GFCommon::gf_vars( false ) . '</script>';
277 277
 
278 278
 		// Restore previous $_GET setting
279
-		$_GET['id'] = $get_id_backup;
279
+		$_GET[ 'id' ] = $get_id_backup;
280 280
 
281 281
 		return $output;
282 282
 	}
Please login to merge, or discard this patch.
includes/extensions/delete-entry/class-delete-entry.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -532,7 +532,7 @@
 block discarded – undo
532 532
 				 * @since 1.16.4
533 533
 				 * @param  int $entry_id ID of the Gravity Forms entry
534 534
 				 * @param  array $entry Deleted entry array
535
-				*/
535
+				 */
536 536
 				do_action( 'gravityview/delete-entry/deleted', $entry_id, $entry );
537 537
 			}
538 538
 
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @since 2.9.2
65 65
 	 *
66
-	 * @param $component
66
+	 * @param string $component
67 67
 	 */
68 68
 	private function load_components( $component ) {
69 69
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 *
109 109
 	 * @param array $args Existing reserved args
110 110
 	 *
111
-	 * @return array
111
+	 * @return string[]
112 112
 	 */
113 113
 	public function add_reserved_arg( $args ) {
114 114
 
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
 	 * @uses GFAPI::delete_entry()
441 441
 	 * @uses GFAPI::update_entry_property()
442 442
 	 *
443
-	 * @return WP_Error|string "deleted" or "trashed" if successful, WP_Error if GFAPI::delete_entry() or updating entry failed.
443
+	 * @return string "deleted" or "trashed" if successful, WP_Error if GFAPI::delete_entry() or updating entry failed.
444 444
 	 */
445 445
 	private function delete_or_trash_entry( $entry ) {
446 446
 
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
 	 *
608 608
 	 * @since 1.5.1
609 609
 	 * @param  array $entry Gravity Forms entry array
610
-	 * @return boolean|WP_Error        True: can edit form. WP_Error: nope.
610
+	 * @return string        True: can edit form. WP_Error: nope.
611 611
 	 */
612 612
 	function user_can_delete_entry( $entry = array(), $view_id = null ) {
613 613
 
@@ -648,7 +648,7 @@  discard block
 block discarded – undo
648 648
 	 *
649 649
 	 * @param  array $entry Gravity Forms entry array
650 650
 	 * @param array $field Field settings (optional)
651
-	 * @param int|\GV\View $view Pass a View ID to check caps against. If not set, check against current View (@deprecated no longer optional)
651
+	 * @param integer $view Pass a View ID to check caps against. If not set, check against current View (@deprecated no longer optional)
652 652
 	 * @return bool
653 653
 	 */
654 654
 	public static function check_user_cap_delete_entry( $entry, $field = array(), $view = 0 ) {
Please login to merge, or discard this patch.
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 */
113 113
 	public function add_reserved_arg( $args ) {
114 114
 
115
-		$args[] = 'delete';
115
+		$args[ ] = 'delete';
116 116
 
117 117
 		return $args;
118 118
 	}
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 
183 183
 		// Index 100 is the default GravityView template path.
184 184
 		// Index 110 is Edit Entry link
185
-		$file_paths[115] = self::$file;
185
+		$file_paths[ 115 ] = self::$file;
186 186
 
187 187
 		return $file_paths;
188 188
 	}
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 
287 287
 		$attributes = array(
288 288
 			'class' => 'btn btn-sm button button-small alignright pull-right btn-danger gv-button-delete',
289
-			'tabindex' => ( GFCommon::$tab_index ++ ),
289
+			'tabindex' => ( GFCommon::$tab_index++ ),
290 290
 			'onclick' => self::get_confirm_dialog(),
291 291
 		);
292 292
 
@@ -322,12 +322,12 @@  discard block
 block discarded – undo
322 322
 		);
323 323
 
324 324
 		// If the form is not submitted, return early
325
-		if ( 'delete' !== $get_fields['action'] || empty( $get_fields['entry_id'] ) ) {
325
+		if ( 'delete' !== $get_fields[ 'action' ] || empty( $get_fields[ 'entry_id' ] ) ) {
326 326
 			return;
327 327
 		}
328 328
 
329 329
 		// Make sure it's a GravityView request
330
-		$valid_nonce_key = wp_verify_nonce( $get_fields['delete'], self::get_nonce_key( $get_fields['entry_id'] ) );
330
+		$valid_nonce_key = wp_verify_nonce( $get_fields[ 'delete' ], self::get_nonce_key( $get_fields[ 'entry_id' ] ) );
331 331
 
332 332
 		if ( ! $valid_nonce_key ) {
333 333
 			gravityview()->log->debug( 'Delete entry not processed: nonce validation failed.' );
@@ -336,10 +336,10 @@  discard block
 block discarded – undo
336 336
 		}
337 337
 
338 338
 		// Get the entry slug
339
-		$entry_slug = esc_attr( $get_fields['entry_id'] );
339
+		$entry_slug = esc_attr( $get_fields[ 'entry_id' ] );
340 340
 
341 341
 		// Redirect after deleting the entry.
342
-		$view = \GV\View::by_id( $get_fields['view_id'] );
342
+		$view = \GV\View::by_id( $get_fields[ 'view_id' ] );
343 343
 
344 344
 		// See if there's an entry there
345 345
 		$entry = gravityview_get_entry( $entry_slug, true, false, $view );
@@ -366,9 +366,9 @@  discard block
 block discarded – undo
366 366
 			$this->_redirect_and_exit( $delete_redirect_base, $delete_response->get_error_message(), 'error' );
367 367
 		}
368 368
 
369
-		if ( (int) $view->settings->get( 'delete_redirect' ) === self::REDIRECT_TO_URL_VALUE ) {
369
+		if ( (int)$view->settings->get( 'delete_redirect' ) === self::REDIRECT_TO_URL_VALUE ) {
370 370
 
371
-			$form                 = GFAPI::get_form( $entry['form_id'] );
371
+			$form                 = GFAPI::get_form( $entry[ 'form_id' ] );
372 372
 			$redirect_url_setting = $view->settings->get( 'delete_redirect_url' );
373 373
 			$redirect_url         = GFCommon::replace_variables( $redirect_url_setting, $form, $entry, false, false, false, 'text' );
374 374
 
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
 	 */
445 445
 	private function delete_or_trash_entry( $entry ) {
446 446
 
447
-		$entry_id = $entry['id'];
447
+		$entry_id = $entry[ 'id' ];
448 448
 
449 449
 		$mode = $this->get_delete_mode();
450 450
 
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 	public function process_connected_posts( $entry_id = 0, $entry = array() ) {
509 509
 
510 510
 		// The entry had no connected post
511
-		if ( empty( $entry['post_id'] ) ) {
511
+		if ( empty( $entry[ 'post_id' ] ) ) {
512 512
 			return;
513 513
 		}
514 514
 
@@ -526,9 +526,9 @@  discard block
 block discarded – undo
526 526
 		$action = current_action();
527 527
 
528 528
 		if ( 'gravityview/delete-entry/deleted' === $action ) {
529
-			$result = wp_delete_post( $entry['post_id'], true );
529
+			$result = wp_delete_post( $entry[ 'post_id' ], true );
530 530
 		} else {
531
-			$result = wp_trash_post( $entry['post_id'] );
531
+			$result = wp_trash_post( $entry[ 'post_id' ] );
532 532
 		}
533 533
 
534 534
 		if ( false === $result ) {
@@ -559,13 +559,13 @@  discard block
 block discarded – undo
559 559
 	public function verify_nonce() {
560 560
 
561 561
 		// No delete entry request was made
562
-		if ( empty( $_GET['entry_id'] ) || empty( $_GET['delete'] ) ) {
562
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'delete' ] ) ) {
563 563
 			return false;
564 564
 		}
565 565
 
566
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
566
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
567 567
 
568
-		$valid = wp_verify_nonce( $_GET['delete'], $nonce_key );
568
+		$valid = wp_verify_nonce( $_GET[ 'delete' ], $nonce_key );
569 569
 
570 570
 		/**
571 571
 		 * @filter `gravityview/delete-entry/verify_nonce` Override Delete Entry nonce validation. Return true to declare nonce valid.
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
 			$error = __( 'You do not have permission to delete this entry.', 'gravityview' );
622 622
 		}
623 623
 
624
-		if ( $entry['status'] === 'trash' ) {
624
+		if ( $entry[ 'status' ] === 'trash' ) {
625 625
 			if ( 'trash' === $this->get_delete_mode() ) {
626 626
 				$error = __( 'The entry is already in the trash.', 'gravityview' );
627 627
 			} else {
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
 
666 666
 		$current_user = wp_get_current_user();
667 667
 
668
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : null;
668
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : null;
669 669
 
670 670
 		// Or if they can delete any entries (as defined in Gravity Forms), we're good.
671 671
 		if ( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
@@ -679,17 +679,17 @@  discard block
 block discarded – undo
679 679
 		if ( ! empty( $field ) ) {
680 680
 
681 681
 			// If capability is not defined, something is not right!
682
-			if ( empty( $field['allow_edit_cap'] ) ) {
682
+			if ( empty( $field[ 'allow_edit_cap' ] ) ) {
683 683
 
684 684
 				gravityview()->log->error( 'Cannot read delete entry field caps', array( 'data' => $field ) );
685 685
 
686 686
 				return false;
687 687
 			}
688 688
 
689
-			if ( GVCommon::has_cap( $field['allow_edit_cap'] ) ) {
689
+			if ( GVCommon::has_cap( $field[ 'allow_edit_cap' ] ) ) {
690 690
 
691 691
 				// Do not return true if cap is read, as we need to check if the current user created the entry
692
-				if ( $field['allow_edit_cap'] !== 'read' ) {
692
+				if ( $field[ 'allow_edit_cap' ] !== 'read' ) {
693 693
 					return true;
694 694
 				}
695 695
 			} else {
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
 			}
701 701
 		}
702 702
 
703
-		if ( ! isset( $entry['created_by'] ) ) {
703
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
704 704
 
705 705
 			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.' );
706 706
 
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
716 716
 		}
717 717
 
718 718
 		// If the logged-in user is the same as the user who created the entry, we're good.
719
-		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
719
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
720 720
 
721 721
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
722 722
 
@@ -741,12 +741,12 @@  discard block
 block discarded – undo
741 741
 	 */
742 742
 	public function maybe_display_message( $current_view_id = 0 ) {
743 743
 
744
-		if ( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
744
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
745 745
 			return;
746 746
 		}
747 747
 
748 748
 		// Entry wasn't deleted from current View
749
-		if ( isset( $_GET['view_id'] ) && intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) {
749
+		if ( isset( $_GET[ 'view_id' ] ) && intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) {
750 750
 			return;
751 751
 		}
752 752
 
@@ -755,11 +755,11 @@  discard block
 block discarded – undo
755 755
 
756 756
 	public function display_message() {
757 757
 
758
-		if ( empty( $_GET['status'] ) || empty( $_GET['delete'] ) ) {
758
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'delete' ] ) ) {
759 759
 			return;
760 760
 		}
761 761
 
762
-		$status = esc_attr( $_GET['status'] );
762
+		$status = esc_attr( $_GET[ 'status' ] );
763 763
 		$message_from_url = \GV\Utils::_GET( 'message' );
764 764
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
765 765
 		$class = '';
Please login to merge, or discard this patch.
future/includes/class-gv-settings-view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
 		);
532 532
 
533 533
 		if ( version_compare( \GFCommon::$version, '2.3-beta-4', '>=' ) ) {
534
-			$default_settings['sort_direction']['options']['RAND'] = __( 'Random', 'gravityview' );
534
+			$default_settings[ 'sort_direction' ][ 'options' ][ 'RAND' ] = __( 'Random', 'gravityview' );
535 535
 		}
536 536
 
537 537
 		/**
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 		if ( ! $detailed ) {
553 553
 			$defaults = array();
554 554
 			foreach ( $default_settings as $key => $value ) {
555
-				$defaults[ $key ] = $value['value'];
555
+				$defaults[ $key ] = $value[ 'value' ];
556 556
 			}
557 557
 			return $defaults;
558 558
 
@@ -563,7 +563,7 @@  discard block
 block discarded – undo
563 563
 				// If the $group argument is set for the method,
564 564
 				// ignore any settings that aren't in that group.
565 565
 				if ( ! empty( $group ) && is_string( $group ) ) {
566
-					if ( empty( $value['group'] ) || $value['group'] !== $group ) {
566
+					if ( empty( $value[ 'group' ] ) || $value[ 'group' ] !== $group ) {
567 567
 						unset( $default_settings[ $key ] );
568 568
 					}
569 569
 				}
Please login to merge, or discard this patch.
includes/extensions/delete-entry/class-delete-entry-admin.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,6 @@
 block discarded – undo
67 67
 	 * @since 2.9.2 Moved here from GravityView_Delete_Entry
68 68
 	 *
69 69
 	 * @param array $visibility_caps Array of capabilities to display in field dropdown.
70
-	 * @param string $field_type Type of field options to render (`field` or `widget`)
71 70
 	 * @param string $template_id Table slug
72 71
 	 * @param float $field_id GF Field ID - Example: `3`, `5.2`, `entry_link`, `created_by`
73 72
 	 * @param string $context What context are we in? Example: `single` or `directory`
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -83,9 +83,9 @@  discard block
 block discarded – undo
83 83
 		if ( $field_id === 'delete_link' ) {
84 84
 
85 85
 			// Remove other built-in caps.
86
-			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['delete_others_posts'] );
86
+			unset( $caps[ 'publish_posts' ], $caps[ 'gravityforms_view_entries' ], $caps[ 'delete_others_posts' ] );
87 87
 
88
-			$caps['read'] = _x( 'Entry Creator', 'User capability', 'gravityview' );
88
+			$caps[ 'read' ] = _x( 'Entry Creator', 'User capability', 'gravityview' );
89 89
 		}
90 90
 
91 91
 		return $caps;
@@ -108,12 +108,12 @@  discard block
 block discarded – undo
108 108
 	public function delete_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
109 109
 
110 110
 		// Always a link, never a filter
111
-		unset( $field_options['show_as_link'], $field_options['search_filter'] );
111
+		unset( $field_options[ 'show_as_link' ], $field_options[ 'search_filter' ] );
112 112
 
113 113
 		// Delete Entry link should only appear to visitors capable of editing entries
114
-		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
114
+		unset( $field_options[ 'only_loggedin' ], $field_options[ 'only_loggedin_cap' ] );
115 115
 
116
-		$add_option['delete_link'] = array(
116
+		$add_option[ 'delete_link' ] = array(
117 117
 			'type'       => 'text',
118 118
 			'label'      => __( 'Delete Link Text', 'gravityview' ),
119 119
 			'desc'       => null,
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 			'merge_tags' => true,
122 122
 		);
123 123
 
124
-		$field_options['allow_edit_cap'] = array(
124
+		$field_options[ 'allow_edit_cap' ] = array(
125 125
 			'type'    => 'select',
126 126
 			'label'   => __( 'Allow the following users to delete the entry:', 'gravityview' ),
127 127
 			'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 	 */
147 147
 	public function add_available_field( $available_fields = array() ) {
148 148
 
149
-		$available_fields['delete_link'] = array(
149
+		$available_fields[ 'delete_link' ] = array(
150 150
 			'label_text'    => __( 'Delete Entry', 'gravityview' ),
151 151
 			'field_id'      => 'delete_link',
152 152
 			'label_type'    => 'field',
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	public function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
189 189
 
190 190
 		if ( 'edit' !== $zone ) {
191
-			$entry_default_fields['delete_link'] = array(
191
+			$entry_default_fields[ 'delete_link' ] = array(
192 192
 				'label' => __( 'Delete Entry', 'gravityview' ),
193 193
 				'type'  => 'delete_link',
194 194
 				'desc'  => __( 'A link to delete the entry. Respects the Delete Entry permissions.', 'gravityview' ),
Please login to merge, or discard this patch.
includes/extensions/delete-entry/fields/delete_link.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,11 +12,11 @@
 block discarded – undo
12 12
 extract( $gravityview_view->getCurrentField() );
13 13
 
14 14
 // Only show the link to logged-in users with the right caps.
15
-if( !GravityView_Delete_Entry::check_user_cap_delete_entry( $entry, $field_settings ) ) {
15
+if ( ! GravityView_Delete_Entry::check_user_cap_delete_entry( $entry, $field_settings ) ) {
16 16
 	return;
17 17
 }
18 18
 
19
-$link_text = empty( $field_settings['delete_link'] ) ? __('Delete Entry', 'gravityview') : $field_settings['delete_link'];
19
+$link_text = empty( $field_settings[ 'delete_link' ] ) ? __( 'Delete Entry', 'gravityview' ) : $field_settings[ 'delete_link' ];
20 20
 
21 21
 $link_text = apply_filters( 'gravityview_entry_link', GravityView_API::replace_variables( $link_text, $form, $entry ) );
22 22
 
Please login to merge, or discard this patch.
class-gravityview-plugin-hooks-gravityformspartialentries.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
 		$partial_entries_addon = GF_Partial_Entries::get_instance();
55 55
 
56
-		$feed_settings = $partial_entries_addon->get_feed_settings( $form['id'] );
56
+		$feed_settings = $partial_entries_addon->get_feed_settings( $form[ 'id' ] );
57 57
 
58 58
 		$is_enabled = \GV\Utils::get( $feed_settings, 'enable', 0 );
59 59
 
@@ -70,14 +70,14 @@  discard block
 block discarded – undo
70 70
 		}
71 71
 
72 72
 		// Set the expected $_POST key for the Add-On to use
73
-		$_POST['partial_entry_id'] = $partial_entry_id;
73
+		$_POST[ 'partial_entry_id' ] = $partial_entry_id;
74 74
 
75 75
 		gravityview()->log->debug( 'Saving partial entry (ID #{partial_entry_id}) for Entry #{entry_id}', array(
76 76
 			'partial_entry_id' => $partial_entry_id,
77 77
 			'entry_id'         => $entry_id
78 78
 		) );
79 79
 
80
-		$partial_entries_addon->maybe_save_partial_entry( $form['id'] );
80
+		$partial_entries_addon->maybe_save_partial_entry( $form[ 'id' ] );
81 81
 	}
82 82
 }
83 83
 
Please login to merge, or discard this patch.
includes/admin/class.render.settings.php 3 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
 			{{field_settings}}
309 309
 			{{hidden_fields}}
310 310
 		</div>
311
-EOD;
311
+eod;
312 312
 
313 313
 		$output = $template;
314 314
 
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@
 block discarded – undo
284 284
 					<div class="gv-field-detail gv-field-detail--field">
285 285
 						<span class="gv-field-detail--label">' . esc_html__( 'Field ID', 'gravityview' ) .'</span><span class="gv-field-detail--value">#{{field_id}}</span>
286 286
 					</div>';
287
-			    }
287
+				}
288 288
 
289 289
 				$item_details .= '
290 290
 					<div class="gv-field-detail gv-field-detail--type">
Please login to merge, or discard this patch.
Spacing   +85 added lines, -85 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
 		$is_table_layout = preg_match( '/table/ism', $template_id );
55 55
 
56
-		if( 'field' === $field_type ) {
56
+		if ( 'field' === $field_type ) {
57 57
 
58 58
 			// Default options - fields
59 59
 			$field_options = array(
@@ -105,11 +105,11 @@  discard block
 block discarded – undo
105 105
 			);
106 106
 
107 107
 			// Match Table as well as DataTables
108
-			if( $is_table_layout && 'directory' === $context ) {
109
-				$field_options['width'] = array(
108
+			if ( $is_table_layout && 'directory' === $context ) {
109
+				$field_options[ 'width' ] = array(
110 110
 					'type' => 'number',
111
-					'label' => __('Percent Width', 'gravityview'),
112
-					'desc' => __( 'Leave blank for column width to be based on the field content.', 'gravityview'),
111
+					'label' => __( 'Percent Width', 'gravityview' ),
112
+					'desc' => __( 'Leave blank for column width to be based on the field content.', 'gravityview' ),
113 113
 					'class' => 'code widefat',
114 114
 					'value' => '',
115 115
 					'priority' => 200,
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
 		// Remove suffix ":" from the labels to standardize style. Using trim() instead of rtrim() for i18n.
123 123
 		foreach ( $field_options as $key => $field_option ) {
124
-			$field_options[ $key ]['label'] = trim( $field_options[ $key ]['label'], ':' );
124
+			$field_options[ $key ][ 'label' ] = trim( $field_options[ $key ][ 'label' ], ':' );
125 125
 		}
126 126
 
127 127
 		/**
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 				switch ( $key ) {
157 157
 					case 'show_as_link':
158 158
 						$_group = 'display';
159
-						$field_option['priority'] = 100;
159
+						$field_option[ 'priority' ] = 100;
160 160
 						break;
161 161
 					default:
162 162
 						$_group = \GV\Utils::get( $field_option, 'group', 'display' );
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			}
172 172
 
173 173
 			$field_options = array();
174
-			foreach ( self::get_field_groups() as $group_key => $group_name  ) {
174
+			foreach ( self::get_field_groups() as $group_key => $group_name ) {
175 175
 				$field_options[ $group_key ] = \GV\Utils::get( $option_groups, $group_key, array() );
176 176
 			}
177 177
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 			return 0;
203 203
 		}
204 204
 
205
-		return ( $a_priority < $b_priority ) ? - 1 : 1;
205
+		return ( $a_priority < $b_priority ) ? -1 : 1;
206 206
 	}
207 207
 
208 208
 	/**
@@ -227,8 +227,8 @@  discard block
 block discarded – undo
227 227
 			'manage_options' => __( 'Administrator', 'gravityview' ),
228 228
 		);
229 229
 
230
-		if( is_multisite() ) {
231
-			$select_cap_choices['manage_network'] = __('Multisite Super Admin', 'gravityview' );
230
+		if ( is_multisite() ) {
231
+			$select_cap_choices[ 'manage_network' ] = __( 'Multisite Super Admin', 'gravityview' );
232 232
 		}
233 233
 
234 234
 		/**
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 		 * @param  string $context     Optional. What context are we in? Example: `single` or `directory`
242 242
 		 * @param  string $input_type  Optional. (textarea, list, select, etc.)
243 243
 		 */
244
-		$select_cap_choices = apply_filters('gravityview_field_visibility_caps', $select_cap_choices, $template_id, $field_id, $context, $input_type );
244
+		$select_cap_choices = apply_filters( 'gravityview_field_visibility_caps', $select_cap_choices, $template_id, $field_id, $context, $input_type );
245 245
 
246 246
 		return $select_cap_choices;
247 247
 	}
@@ -268,9 +268,9 @@  discard block
 block discarded – undo
268 268
 	 */
269 269
 	public static function render_field_options( $form_id, $field_type, $template_id, $field_id, $field_label, $area, $input_type = NULL, $uniqid = '', $current = '', $context = 'single', $item = array() ) {
270 270
 
271
-		if( empty( $uniqid ) ) {
271
+		if ( empty( $uniqid ) ) {
272 272
 			//generate a unique field id
273
-			$uniqid = uniqid('', false);
273
+			$uniqid = uniqid( '', false );
274 274
 		}
275 275
 
276 276
 		$grouped = ( 'field' === $field_type );
@@ -278,24 +278,24 @@  discard block
 block discarded – undo
278 278
 		// get field/widget options
279 279
 		$option_groups = self::get_default_field_options( $field_type, $template_id, $field_id, $context, $input_type, $form_id, $grouped );
280 280
 
281
-		if( ! $grouped ) {
281
+		if ( ! $grouped ) {
282 282
 			$option_groups = array( $option_groups );
283 283
 		}
284 284
 
285 285
 		$option_groups = array_filter( $option_groups );
286 286
 
287 287
 		// two different post arrays, depending of the field type
288
-		$name_prefix = $field_type .'s' .'['. $area .']['. $uniqid .']';
288
+		$name_prefix = $field_type . 's' . '[' . $area . '][' . $uniqid . ']';
289 289
 
290 290
 		// build output
291
-		$hidden_fields  = '<input type="hidden" class="field-key" name="'. $name_prefix .'[id]" value="'. esc_attr( $field_id ) .'">';
292
-		$hidden_fields .= '<input type="hidden" class="field-label" name="'. $name_prefix .'[label]" value="'. esc_attr( $field_label ) .'">';
291
+		$hidden_fields  = '<input type="hidden" class="field-key" name="' . $name_prefix . '[id]" value="' . esc_attr( $field_id ) . '">';
292
+		$hidden_fields .= '<input type="hidden" class="field-label" name="' . $name_prefix . '[label]" value="' . esc_attr( $field_label ) . '">';
293 293
 
294 294
 		$form_title = '';
295 295
 		if ( $form_id ) {
296
-			$hidden_fields .= '<input type="hidden" class="field-form-id" name="'. $name_prefix .'[form_id]" value="'. esc_attr( $form_id ) .'">';
296
+			$hidden_fields .= '<input type="hidden" class="field-form-id" name="' . $name_prefix . '[form_id]" value="' . esc_attr( $form_id ) . '">';
297 297
 			$form = GVCommon::get_form( $form_id );
298
-			$form_title = $form['title'];
298
+			$form_title = $form[ 'title' ];
299 299
 		}
300 300
 
301 301
 		// If there are no options, return what we got.
@@ -303,14 +303,14 @@  discard block
 block discarded – undo
303 303
 			return $hidden_fields . '<!-- No Options -->'; // The HTML comment is here for checking if the output is empty in render_label()
304 304
 		}
305 305
 
306
-		$settings_title = esc_attr( sprintf( __( '%s Settings', 'gravityview' ) , strip_tags( html_entity_decode( $field_label ) ) ) );
306
+		$settings_title = esc_attr( sprintf( __( '%s Settings', 'gravityview' ), strip_tags( html_entity_decode( $field_label ) ) ) );
307 307
 
308 308
 		$field_details = '';
309 309
 
310 310
 		// Get the pretty name for the input type
311 311
 		$gv_field = GravityView_Fields::get( $input_type );
312 312
 
313
-		if( $gv_field ) {
313
+		if ( $gv_field ) {
314 314
 			$input_type_label = $gv_field->label;
315 315
 		} else {
316 316
 			$input_type_label = $input_type;
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 			}
325 325
 
326 326
 			if ( $grouped ) {
327
-				$group_name     = rgar( self::get_field_groups(), $group_key, '' );
327
+				$group_name = rgar( self::get_field_groups(), $group_key, '' );
328 328
 				$field_settings .= '<fieldset class="item-settings-group item-settings-group-' . esc_attr( $group_key ) . '">';
329 329
 				$field_settings .= '<legend>' . esc_attr( $group_name ) . '</legend>';
330 330
 			}
@@ -341,15 +341,15 @@  discard block
 block discarded – undo
341 341
 				}
342 342
 
343 343
 				$show_if = '';
344
-				if ( ! empty( $option['requires'] ) ) {
345
-					$show_if .= sprintf( ' data-requires="%s"', $option['requires'] );
344
+				if ( ! empty( $option[ 'requires' ] ) ) {
345
+					$show_if .= sprintf( ' data-requires="%s"', $option[ 'requires' ] );
346 346
 				}
347 347
 
348
-				if ( ! empty( $option['requires_not'] ) ) {
349
-					$show_if .= sprintf( ' data-requires-not="%s"', $option['requires_not'] );
348
+				if ( ! empty( $option[ 'requires_not' ] ) ) {
349
+					$show_if .= sprintf( ' data-requires-not="%s"', $option[ 'requires_not' ] );
350 350
 				}
351 351
 
352
-				switch ( $option['type'] ) {
352
+				switch ( $option[ 'type' ] ) {
353 353
 					// Hide hidden fields
354 354
 					case 'hidden':
355 355
 						$field_settings .= '<div class="gv-setting-container gv-setting-container-' . esc_attr( $key ) . ' screen-reader-text">' . $field_output . '</div>';
@@ -367,30 +367,30 @@  discard block
 block discarded – undo
367 367
 		$item_details = '';
368 368
 		$subtitle = '';
369 369
 
370
-		if( 'field' === $field_type ) {
371
-			$subtitle = ! empty( $item['subtitle'] ) ? '<div class="subtitle">' . $item['subtitle'] . '</div>' : '';
370
+		if ( 'field' === $field_type ) {
371
+			$subtitle = ! empty( $item[ 'subtitle' ] ) ? '<div class="subtitle">' . $item[ 'subtitle' ] . '</div>' : '';
372 372
 
373 373
 			$item_details .= '
374 374
 			<div class="gv-field-details--container">
375
-				<label class="gv-field-details--toggle">' . esc_html__( 'Field Details', 'gravityview' ) .' <i class="dashicons dashicons-arrow-down"></i></label>
375
+				<label class="gv-field-details--toggle">' . esc_html__( 'Field Details', 'gravityview' ) . ' <i class="dashicons dashicons-arrow-down"></i></label>
376 376
 				<section class="gv-field-details gv-field-details--closed">';
377 377
 
378 378
 				if ( $field_id && is_numeric( $field_id ) ) {
379 379
 				$item_details .= '
380 380
 					<div class="gv-field-detail gv-field-detail--field">
381
-						<span class="gv-field-detail--label">' . esc_html__( 'Field ID', 'gravityview' ) .'</span><span class="gv-field-detail--value">#{{field_id}}</span>
381
+						<span class="gv-field-detail--label">' . esc_html__( 'Field ID', 'gravityview' ) . '</span><span class="gv-field-detail--value">#{{field_id}}</span>
382 382
 					</div>';
383 383
 			    }
384 384
 
385 385
 				$item_details .= '
386 386
 					<div class="gv-field-detail gv-field-detail--type">
387
-						<span class="gv-field-detail--label">' . esc_html_x( 'Type', 'The type of field being configured (eg: "Single Line Text")', 'gravityview' ) .'</span><span class="gv-field-detail--value">{{input_type_label}}</span>
387
+						<span class="gv-field-detail--label">' . esc_html_x( 'Type', 'The type of field being configured (eg: "Single Line Text")', 'gravityview' ) . '</span><span class="gv-field-detail--value">{{input_type_label}}</span>
388 388
 					</div>';
389 389
 
390
-				if( $form_id ) {
390
+				if ( $form_id ) {
391 391
 					$item_details .= '
392 392
 					<div class="gv-field-detail gv-field-detail--form">
393
-						<span class="gv-field-detail--label">' . esc_html__( 'Form', 'gravityview' ) .'</span><span class="gv-field-detail--value">{{form_title}} (#{{form_id}})</span>
393
+						<span class="gv-field-detail--label">' . esc_html__( 'Form', 'gravityview' ) . '</span><span class="gv-field-detail--value">{{form_title}} (#{{form_id}})</span>
394 394
 					</div>';
395 395
 				}
396 396
 				$item_details .= '
@@ -398,8 +398,8 @@  discard block
 block discarded – undo
398 398
 			</div>';
399 399
 		} else {
400 400
 			$widget_details_content = rgar( $item, 'description', '' );
401
-			if ( ! empty( $item['subtitle'] ) ) {
402
-				$widget_details_content .= ( '' !== $widget_details_content ) ? "\n\n" . $item['subtitle'] : $item['subtitle'];
401
+			if ( ! empty( $item[ 'subtitle' ] ) ) {
402
+				$widget_details_content .= ( '' !== $widget_details_content ) ? "\n\n" . $item[ 'subtitle' ] : $item[ 'subtitle' ];
403 403
 			}
404 404
 
405 405
 			// Intentionally not escaping to allow HTML.
@@ -455,17 +455,17 @@  discard block
 block discarded – undo
455 455
 		 * @deprecated setting index 'default' was replaced by 'value'
456 456
 		 * @see GravityView_FieldType::get_field_defaults
457 457
 		 */
458
-		if( !empty( $option['default'] ) && empty( $option['value'] ) ) {
459
-			$option['value'] = $option['default'];
460
-			_deprecated_function( 'GravityView_FieldType::get_field_defaults', '1.1.7', '[value] instead of [default] when defining the setting '. $name .' details' );
458
+		if ( ! empty( $option[ 'default' ] ) && empty( $option[ 'value' ] ) ) {
459
+			$option[ 'value' ] = $option[ 'default' ];
460
+			_deprecated_function( 'GravityView_FieldType::get_field_defaults', '1.1.7', '[value] instead of [default] when defining the setting ' . $name . ' details' );
461 461
 		}
462 462
 
463 463
 		// prepare to render option field type
464
-		if( isset( $option['type'] ) ) {
464
+		if ( isset( $option[ 'type' ] ) ) {
465 465
 
466 466
 			$type_class = self::load_type_class( $option );
467 467
 
468
-			if( class_exists( $type_class ) ) {
468
+			if ( class_exists( $type_class ) ) {
469 469
 
470 470
 				/** @type GravityView_FieldType $render_type */
471 471
 				$render_type = new $type_class( $name, $option, $curr_value );
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 				 * @param[in,out] string $output field class name
483 483
 				 * @param[in] array $option  option field data
484 484
 				 */
485
-				$output = apply_filters( "gravityview/option/output/{$option['type']}" , $output, $option );
485
+				$output = apply_filters( "gravityview/option/output/{$option[ 'type' ]}", $output, $option );
486 486
 			}
487 487
 
488 488
 		} // isset option[type]
@@ -517,27 +517,27 @@  discard block
 block discarded – undo
517 517
 		 * @deprecated setting index 'name' was replaced by 'label'
518 518
 		 * @see GravityView_FieldType::get_field_defaults
519 519
 		 */
520
-		if( isset( $setting['name'] ) && empty( $setting['label'] ) ) {
521
-			$setting['label'] = $setting['name'];
522
-			_deprecated_function( 'GravityView_FieldType::get_field_defaults', '1.1.7', '[label] instead of [name] when defining the setting '. $key .' details' );
520
+		if ( isset( $setting[ 'name' ] ) && empty( $setting[ 'label' ] ) ) {
521
+			$setting[ 'label' ] = $setting[ 'name' ];
522
+			_deprecated_function( 'GravityView_FieldType::get_field_defaults', '1.1.7', '[label] instead of [name] when defining the setting ' . $key . ' details' );
523 523
 		}
524 524
 
525 525
 		$name = esc_attr( sprintf( $name, $key ) );
526
-		$setting['id'] = esc_attr( sprintf( $id, $key ) );
527
-		$setting['tooltip'] = 'gv_' . $key;
526
+		$setting[ 'id' ] = esc_attr( sprintf( $id, $key ) );
527
+		$setting[ 'tooltip' ] = 'gv_' . $key;
528 528
 
529 529
 		// Use default if current setting isn't set.
530
-		$curr_value = isset( $current_settings[ $key ] ) ? $current_settings[ $key ] : $setting['value'];
530
+		$curr_value = isset( $current_settings[ $key ] ) ? $current_settings[ $key ] : $setting[ 'value' ];
531 531
 
532 532
 		// default setting type = text
533
-		$setting['type'] = empty( $setting['type'] ) ? 'text' : $setting['type'];
533
+		$setting[ 'type' ] = empty( $setting[ 'type' ] ) ? 'text' : $setting[ 'type' ];
534 534
 
535 535
 		// merge tags
536
-		if( !isset( $setting['merge_tags'] ) ) {
537
-			if( $setting['type'] === 'text' ) {
538
-				$setting['merge_tags'] = true;
536
+		if ( ! isset( $setting[ 'merge_tags' ] ) ) {
537
+			if ( $setting[ 'type' ] === 'text' ) {
538
+				$setting[ 'merge_tags' ] = true;
539 539
 			} else {
540
-				$setting['merge_tags'] = false;
540
+				$setting[ 'merge_tags' ] = false;
541 541
 			}
542 542
 		}
543 543
 
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 
546 546
 		// render the setting
547 547
 		$type_class = self::load_type_class( $setting );
548
-		if( class_exists( $type_class ) ) {
548
+		if ( class_exists( $type_class ) ) {
549 549
 			/** @type GravityView_FieldType $render_type */
550 550
 			$render_type = new $type_class( $name, $setting, $curr_value );
551 551
 			ob_start();
@@ -554,25 +554,25 @@  discard block
 block discarded – undo
554 554
 		}
555 555
 
556 556
 		// Check if setting is specific for a template
557
-		if( !empty( $setting['show_in_template'] ) ) {
558
-			if( !is_array( $setting['show_in_template'] ) ) {
559
-				$setting['show_in_template'] = array( $setting['show_in_template'] );
557
+		if ( ! empty( $setting[ 'show_in_template' ] ) ) {
558
+			if ( ! is_array( $setting[ 'show_in_template' ] ) ) {
559
+				$setting[ 'show_in_template' ] = array( $setting[ 'show_in_template' ] );
560 560
 			}
561
-			$show_if = ' data-show-if="'. implode( ' ', $setting['show_in_template'] ).'"';
561
+			$show_if = ' data-show-if="' . implode( ' ', $setting[ 'show_in_template' ] ) . '"';
562 562
 		} else {
563 563
 			$show_if = '';
564 564
 		}
565 565
 
566
-		if( ! empty( $setting['requires'] ) ) {
567
-			$show_if .= sprintf( ' data-requires="%s"', $setting['requires'] );
566
+		if ( ! empty( $setting[ 'requires' ] ) ) {
567
+			$show_if .= sprintf( ' data-requires="%s"', $setting[ 'requires' ] );
568 568
 		}
569 569
 
570
-		if( ! empty( $setting['requires_not'] ) ) {
571
-			$show_if .= sprintf( ' data-requires-not="%s"', $setting['requires_not'] );
570
+		if ( ! empty( $setting[ 'requires_not' ] ) ) {
571
+			$show_if .= sprintf( ' data-requires-not="%s"', $setting[ 'requires_not' ] );
572 572
 		}
573 573
 
574 574
 		// output
575
-		echo '<tr style="vertical-align: top;" '. $show_if .'>' . $output . '</tr>';
575
+		echo '<tr style="vertical-align: top;" ' . $show_if . '>' . $output . '</tr>';
576 576
 
577 577
 	}
578 578
 
@@ -584,7 +584,7 @@  discard block
 block discarded – undo
584 584
 	 */
585 585
 	public static function load_type_class( $field = NULL ) {
586 586
 
587
-		if( empty( $field['type'] ) ) {
587
+		if ( empty( $field[ 'type' ] ) ) {
588 588
 			return NULL;
589 589
 		}
590 590
 
@@ -593,9 +593,9 @@  discard block
 block discarded – undo
593 593
 		 * @param string $class_suffix  field class suffix; `GravityView_FieldType_{$class_suffix}`
594 594
 		 * @param array $field   field data
595 595
 		 */
596
-		$type_class = apply_filters( "gravityview/setting/class/{$field['type']}", 'GravityView_FieldType_' . $field['type'], $field );
596
+		$type_class = apply_filters( "gravityview/setting/class/{$field[ 'type' ]}", 'GravityView_FieldType_' . $field[ 'type' ], $field );
597 597
 
598
-		if( class_exists( $type_class ) ) {
598
+		if ( class_exists( $type_class ) ) {
599 599
 			return $type_class;
600 600
 		}
601 601
 
@@ -604,9 +604,9 @@  discard block
 block discarded – undo
604 604
 		 * @param string  $field_type_include_path field class file path
605 605
 		 * @param array $field  field data
606 606
 		 */
607
-		$class_file = apply_filters( "gravityview/setting/class_file/{$field['type']}", GRAVITYVIEW_DIR . "includes/admin/field-types/type_{$field['type']}.php", $field );
607
+		$class_file = apply_filters( "gravityview/setting/class_file/{$field[ 'type' ]}", GRAVITYVIEW_DIR . "includes/admin/field-types/type_{$field[ 'type' ]}.php", $field );
608 608
 
609
-		if( $class_file && file_exists( $class_file ) ) {
609
+		if ( $class_file && file_exists( $class_file ) ) {
610 610
 			require_once( $class_file );
611 611
 		}
612 612
 
@@ -628,8 +628,8 @@  discard block
 block discarded – undo
628 628
 
629 629
 		_deprecated_function( __METHOD__, '1.2', 'GravityView_FieldType_checkbox::render_input' );
630 630
 
631
-		$output  = '<input name="'. esc_attr( $name ) .'" type="hidden" value="0">';
632
-		$output .= '<input name="'. esc_attr( $name ) .'" id="'. esc_attr( $id ) .'" type="checkbox" value="1" '. checked( $current, '1', false ) .' >';
631
+		$output  = '<input name="' . esc_attr( $name ) . '" type="hidden" value="0">';
632
+		$output .= '<input name="' . esc_attr( $name ) . '" id="' . esc_attr( $id ) . '" type="checkbox" value="1" ' . checked( $current, '1', false ) . ' >';
633 633
 
634 634
 		return $output;
635 635
 	}
@@ -649,22 +649,22 @@  discard block
 block discarded – undo
649 649
 		_deprecated_function( __METHOD__, '1.2', 'GravityView_FieldType_text::render_input' );
650 650
 
651 651
 		// Show the merge tags if the field is a list view
652
-		$is_list = ( preg_match( '/_list-/ism', $name ));
652
+		$is_list = ( preg_match( '/_list-/ism', $name ) );
653 653
 
654 654
 		// Or is a single entry view
655
-		$is_single = ( preg_match( '/single_/ism', $name ));
655
+		$is_single = ( preg_match( '/single_/ism', $name ) );
656 656
 		$show = ( $is_single || $is_list );
657 657
 
658 658
 		$class = '';
659 659
 		// and $add_merge_tags is not false
660
-		if( $show && $add_merge_tags !== false || $add_merge_tags === 'force' ) {
660
+		if ( $show && $add_merge_tags !== false || $add_merge_tags === 'force' ) {
661 661
 			$class = 'merge-tag-support mt-position-right mt-hide_all_fields ';
662 662
 		}
663 663
 
664
-		$class .= !empty( $args['class'] ) ? $args['class'] : 'widefat';
665
-		$type = !empty( $args['type'] ) ? $args['type'] : 'text';
664
+		$class .= ! empty( $args[ 'class' ] ) ? $args[ 'class' ] : 'widefat';
665
+		$type = ! empty( $args[ 'type' ] ) ? $args[ 'type' ] : 'text';
666 666
 
667
-		return '<input name="'. esc_attr( $name ) .'" id="'. esc_attr( $id ) .'" type="'.esc_attr($type).'" value="'. esc_attr( $current ) .'" class="'.esc_attr( $class ).'">';
667
+		return '<input name="' . esc_attr( $name ) . '" id="' . esc_attr( $id ) . '" type="' . esc_attr( $type ) . '" value="' . esc_attr( $current ) . '" class="' . esc_attr( $class ) . '">';
668 668
 	}
669 669
 
670 670
 	/**
@@ -681,21 +681,21 @@  discard block
 block discarded – undo
681 681
 		_deprecated_function( __METHOD__, '1.2', 'GravityView_FieldType_textarea::render_input' );
682 682
 
683 683
 		// Show the merge tags if the field is a list view
684
-		$is_list = ( preg_match( '/_list-/ism', $name ));
684
+		$is_list = ( preg_match( '/_list-/ism', $name ) );
685 685
 
686 686
 		// Or is a single entry view
687
-		$is_single = ( preg_match( '/single_/ism', $name ));
687
+		$is_single = ( preg_match( '/single_/ism', $name ) );
688 688
 		$show = ( $is_single || $is_list );
689 689
 
690 690
 		$class = '';
691 691
 		// and $add_merge_tags is not false
692
-		if( $show && $add_merge_tags !== false || $add_merge_tags === 'force' ) {
692
+		if ( $show && $add_merge_tags !== false || $add_merge_tags === 'force' ) {
693 693
 			$class = 'merge-tag-support mt-position-right mt-hide_all_fields ';
694 694
 		}
695 695
 
696
-		$class .= !empty( $args['class'] ) ? 'widefat '.$args['class'] : 'widefat';
696
+		$class .= ! empty( $args[ 'class' ] ) ? 'widefat ' . $args[ 'class' ] : 'widefat';
697 697
 
698
-		return '<textarea name="'. esc_attr( $name ) .'" id="'. esc_attr( $id ) .'" class="'.esc_attr( $class ).'">'. esc_textarea( $current ) .'</textarea>';
698
+		return '<textarea name="' . esc_attr( $name ) . '" id="' . esc_attr( $id ) . '" class="' . esc_attr( $class ) . '">' . esc_textarea( $current ) . '</textarea>';
699 699
 	}
700 700
 
701 701
 	/**
@@ -711,9 +711,9 @@  discard block
 block discarded – undo
711 711
 
712 712
 		_deprecated_function( __METHOD__, '1.2', 'GravityView_FieldType_select::render_input' );
713 713
 
714
-		$output = '<select name="'. $name .'" id="'. $id .'">';
715
-		foreach( $choices as $value => $label ) {
716
-			$output .= '<option value="'. esc_attr( $value ) .'" '. selected( $value, $current, false ) .'>'. esc_html( $label ) .'</option>';
714
+		$output = '<select name="' . $name . '" id="' . $id . '">';
715
+		foreach ( $choices as $value => $label ) {
716
+			$output .= '<option value="' . esc_attr( $value ) . '" ' . selected( $value, $current, false ) . '>' . esc_html( $label ) . '</option>';
717 717
 		}
718 718
 		$output .= '</select>';
719 719
 
Please login to merge, or discard this patch.
includes/fields/class-gravityview-fields.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
 	 * @return GravityView_Field | bool
43 43
 	 */
44 44
 	public static function create( $properties ) {
45
-		$type = isset( $properties['type'] ) ? $properties['type'] : '';
46
-		$type = empty( $properties['inputType'] ) ? $type : $properties['inputType'];
45
+		$type = isset( $properties[ 'type' ] ) ? $properties[ 'type' ] : '';
46
+		$type = empty( $properties[ 'inputType' ] ) ? $type : $properties[ 'inputType' ];
47 47
 		if ( empty( $type ) || ! isset( self::$_fields[ $type ] ) ) {
48 48
 			return new GravityView_Field( $properties );
49 49
 		}
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 * @return bool True: yes, it exists; False: nope
63 63
 	 */
64 64
 	public static function exists( $field_name ) {
65
-		return isset( self::$_fields["{$field_name}"] );
65
+		return isset( self::$_fields[ "{$field_name}" ] );
66 66
 	}
67 67
 
68 68
 	/**
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
 
97 97
 		$field_type = is_a( $gf_field, 'GF_Field' ) ? get_class( $gf_field ) : $gf_field;
98 98
 
99
-		foreach( self::$_fields as $field ) {
100
-			if( $field_type === $field->_gf_field_class_name ) {
99
+		foreach ( self::$_fields as $field ) {
100
+			if ( $field_type === $field->_gf_field_class_name ) {
101 101
 				return $field;
102 102
 			}
103 103
 		}
@@ -116,13 +116,13 @@  discard block
 block discarded – undo
116 116
 	 */
117 117
 	public static function get_all( $groups = '' ) {
118 118
 
119
-		if( '' !== $groups ) {
119
+		if ( '' !== $groups ) {
120 120
 			$return_fields = self::$_fields;
121 121
 
122
-			$groups = (array) $groups;
122
+			$groups = (array)$groups;
123 123
 
124 124
 			foreach ( $return_fields as $key => $field ) {
125
-				if( ! in_array( $field->group, $groups, true ) ) {
125
+				if ( ! in_array( $field->group, $groups, true ) ) {
126 126
 					unset( $return_fields[ $key ] );
127 127
 				}
128 128
 			}
Please login to merge, or discard this patch.