Completed
Pull Request — develop (#1577)
by Zack
31:56 queued 11:58
created
includes/admin/metaboxes/views/data-source.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -10,13 +10,13 @@  discard block
 block discarded – undo
10 10
 wp_nonce_field( 'gravityview_select_form', 'gravityview_select_form_nonce' );
11 11
 
12 12
 //current value
13
-$current_form = (int) \GV\Utils::_GET( 'form_id', gravityview_get_form_id( $post->ID ) );
13
+$current_form = (int)\GV\Utils::_GET( 'form_id', gravityview_get_form_id( $post->ID ) );
14 14
 
15 15
 // If form is in trash or not existing, show error
16 16
 GravityView_Admin::connected_form_warning( $current_form );
17 17
 
18 18
 // check for available gravity forms
19
-$forms = gravityview_get_forms('any', false, 'title' );
19
+$forms = gravityview_get_forms( 'any', false, 'title' );
20 20
 
21 21
 /**
22 22
  * @param int $current_form Form currently selected in the View (0 if none selected)
@@ -35,24 +35,24 @@  discard block
 block discarded – undo
35 35
 		?>
36 36
 		<a class="button button-primary" href="#gv_start_fresh" title="<?php esc_attr_e( 'Use a Form Preset', 'gravityview' ); ?>"><?php esc_html_e( 'Use a Form Preset', 'gravityview' ); ?></a>
37 37
 
38
-		<?php if( !empty( $forms ) ) { ?>
38
+		<?php if ( ! empty( $forms ) ) { ?>
39 39
 			<span>&nbsp;<?php esc_html_e( 'or use an existing form', 'gravityview' ); ?>&nbsp;</span>
40 40
 		<?php }
41 41
 	}
42 42
 
43 43
 	// If there are no forms to select, show no forms.
44
-	if( !empty( $forms ) ) { ?>
44
+	if ( ! empty( $forms ) ) { ?>
45 45
 		<select name="gravityview_form_id" id="gravityview_form_id">
46 46
 			<option value="" <?php selected( '', $current_form, true ); ?>>&mdash; <?php esc_html_e( 'list of forms', 'gravityview' ); ?> &mdash;</option>
47
-			<?php foreach( $forms as $form ) { ?>
48
-				<option value="<?php echo $form['id']; ?>" <?php selected( $form['id'], $current_form, true ); ?>><?php echo esc_html( $form['title'] ); ?></option>
47
+			<?php foreach ( $forms as $form ) { ?>
48
+				<option value="<?php echo $form[ 'id' ]; ?>" <?php selected( $form[ 'id' ], $current_form, true ); ?>><?php echo esc_html( $form[ 'title' ] ); ?></option>
49 49
 			<?php } ?>
50 50
 		</select>
51 51
 	<?php } else { ?>
52 52
 		<select name="gravityview_form_id" id="gravityview_form_id" class="hidden"><option selected="selected" value=""></option></select>
53 53
 	<?php } ?>
54 54
 
55
-	&nbsp;<button class="button button-primary" <?php if( empty( $current_form ) ) { echo 'style="display:none;"'; } ?> id="gv_switch_view_button" title="<?php esc_attr_e( 'Switch View', 'gravityview' ); ?>"><?php esc_html_e( 'Switch View Type', 'gravityview' ); ?></button>
55
+	&nbsp;<button class="button button-primary" <?php if ( empty( $current_form ) ) { echo 'style="display:none;"'; } ?> id="gv_switch_view_button" title="<?php esc_attr_e( 'Switch View', 'gravityview' ); ?>"><?php esc_html_e( 'Switch View Type', 'gravityview' ); ?></button>
56 56
 </p>
57 57
 
58 58
 <?php // confirm dialog box ?>
Please login to merge, or discard this patch.
includes/class-frontend-views.php 3 patches
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 		}
452 452
 
453 453
 		// WooCommerce doesn't $post_id
454
-		if ( empty( $passed_post_id ) )  {
454
+		if ( empty( $passed_post_id ) ) {
455 455
 			return $passed_title;
456 456
 		}
457 457
 
@@ -1206,7 +1206,7 @@  discard block
 block discarded – undo
1206 1206
 					 */
1207 1207
 					$address_part = apply_filters( 'gravityview/sorting/address', 'city', $sort_field_id, $form_id );
1208 1208
 
1209
-					switch( strtolower( $address_part ) ){
1209
+					switch( strtolower( $address_part ) ) {
1210 1210
 						case 'street':
1211 1211
 							$sort_field_id .= '.1';
1212 1212
 							break;
@@ -1296,7 +1296,7 @@  discard block
 block discarded – undo
1296 1296
 		 */
1297 1297
 		$single_entry = apply_filters( 'gravityview/is_single_entry', $single_entry );
1298 1298
 
1299
-		if ( empty( $single_entry ) ){
1299
+		if ( empty( $single_entry ) ) {
1300 1300
 			return false;
1301 1301
 		} else {
1302 1302
 			return $single_entry;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 	 *
228 228
 	 *
229 229
 	 *
230
-	 * @param null $view_id
230
+	 * @param string $view_id
231 231
 	 */
232 232
 	public function set_context_view_id( $view_id = null ) {
233 233
 		$multiple_views = $this->getGvOutputData() && $this->getGvOutputData()->has_multiple_views();
@@ -922,7 +922,7 @@  discard block
 block discarded – undo
922 922
 	 *
923 923
 	 *
924 924
 	 * @uses  gravityview_get_entries()
925
-	 * @param array $args\n
925
+	 * @param array $args
926 926
 	 *   - $id - View id
927 927
 	 *   - $page_size - Page
928 928
 	 *   - $sort_field - form field id to sort
@@ -1051,7 +1051,6 @@  discard block
 block discarded – undo
1051 1051
 	 * @since 1.19.5
1052 1052
 	 *
1053 1053
 	 * @param $args
1054
-	 * @param int $form_id
1055 1054
 	 */
1056 1055
 	public static function get_search_criteria_paging( $args ) {
1057 1056
 
@@ -1553,7 +1552,7 @@  discard block
 block discarded – undo
1553 1552
 	/**
1554 1553
 	 * Checks if field (column) is sortable
1555 1554
 	 *
1556
-	 * @param string $field Field settings
1555
+	 * @param string $field_id Field settings
1557 1556
 	 * @param array $form Gravity Forms form array
1558 1557
 	 *
1559 1558
 	 * @since 1.7
Please login to merge, or discard this patch.
Spacing   +95 added lines, -95 removed lines patch added patch discarded remove patch
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 	private function __construct() {}
86 86
 
87 87
 	private function initialize() {
88
-		add_action( 'wp', array( $this, 'parse_content'), 11 );
88
+		add_action( 'wp', array( $this, 'parse_content' ), 11 );
89 89
 		add_filter( 'parse_query', array( $this, 'parse_query_fix_frontpage' ), 10 );
90
-		add_action( 'template_redirect', array( $this, 'set_entry_data'), 1 );
90
+		add_action( 'template_redirect', array( $this, 'set_entry_data' ), 1 );
91 91
 
92 92
 		// Enqueue scripts and styles after GravityView_Template::register_styles()
93 93
 		add_action( 'wp_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 20 );
@@ -234,18 +234,18 @@  discard block
 block discarded – undo
234 234
 
235 235
 		if ( ! empty( $view_id ) ) {
236 236
 
237
-			$this->context_view_id = (int) $view_id;
237
+			$this->context_view_id = (int)$view_id;
238 238
 
239
-		} elseif ( isset( $_GET['gvid'] ) && $multiple_views ) {
239
+		} elseif ( isset( $_GET[ 'gvid' ] ) && $multiple_views ) {
240 240
 			/**
241 241
 			 * used on a has_multiple_views context
242 242
 			 * @see GravityView_API::entry_link
243 243
 			 */
244
-			$this->context_view_id = (int) $_GET['gvid'];
244
+			$this->context_view_id = (int)$_GET[ 'gvid' ];
245 245
 
246 246
 		} elseif ( ! $multiple_views ) {
247 247
 			$array_keys = array_keys( $this->getGvOutputData()->get_views() );
248
-			$this->context_view_id = (int) array_pop( $array_keys );
248
+			$this->context_view_id = (int)array_pop( $array_keys );
249 249
 			unset( $array_keys );
250 250
 		}
251 251
 
@@ -278,25 +278,25 @@  discard block
 block discarded – undo
278 278
 		global $wp_rewrite;
279 279
 
280 280
 		$is_front_page = ( $query->is_home || $query->is_page );
281
-		$show_on_front = ( 'page' === get_option('show_on_front') );
282
-		$front_page_id = get_option('page_on_front');
281
+		$show_on_front = ( 'page' === get_option( 'show_on_front' ) );
282
+		$front_page_id = get_option( 'page_on_front' );
283 283
 
284
-		if (  $is_front_page && $show_on_front && $front_page_id ) {
284
+		if ( $is_front_page && $show_on_front && $front_page_id ) {
285 285
 
286 286
 			// Force to be an array, potentially a query string ( entry=16 )
287 287
 			$_query = wp_parse_args( $query->query );
288 288
 
289 289
 			// pagename can be set and empty depending on matched rewrite rules. Ignore an empty pagename.
290
-			if ( isset( $_query['pagename'] ) && '' === $_query['pagename'] ) {
291
-				unset( $_query['pagename'] );
290
+			if ( isset( $_query[ 'pagename' ] ) && '' === $_query[ 'pagename' ] ) {
291
+				unset( $_query[ 'pagename' ] );
292 292
 			}
293 293
 
294 294
 			// this is where will break from core wordpress
295 295
 			/** @internal Don't use this filter; it will be unnecessary soon - it's just a patch for specific use case */
296 296
 			$ignore = apply_filters( 'gravityview/internal/ignored_endpoints', array( 'preview', 'page', 'paged', 'cpage' ), $query );
297 297
 			$endpoints = \GV\Utils::get( $wp_rewrite, 'endpoints' );
298
-			foreach ( (array) $endpoints as $endpoint ) {
299
-				$ignore[] = $endpoint[1];
298
+			foreach ( (array)$endpoints as $endpoint ) {
299
+				$ignore[ ] = $endpoint[ 1 ];
300 300
 			}
301 301
 			unset( $endpoints );
302 302
 
@@ -306,21 +306,21 @@  discard block
 block discarded – undo
306 306
 			// - The query includes keys that are associated with registered endpoints. `entry`, for example.
307 307
 			if ( empty( $_query ) || ! array_diff( array_keys( $_query ), $ignore ) ) {
308 308
 
309
-				$qv =& $query->query_vars;
309
+				$qv = & $query->query_vars;
310 310
 
311 311
 				// Prevent redirect when on the single entry endpoint
312
-				if( self::is_single_entry() ) {
312
+				if ( self::is_single_entry() ) {
313 313
 					add_filter( 'redirect_canonical', '__return_false' );
314 314
 				}
315 315
 
316 316
 				$query->is_page = true;
317 317
 				$query->is_home = false;
318
-				$qv['page_id']  = $front_page_id;
318
+				$qv[ 'page_id' ]  = $front_page_id;
319 319
 
320 320
 				// Correct <!--nextpage--> for page_on_front
321
-				if ( ! empty( $qv['paged'] ) ) {
322
-					$qv['page'] = $qv['paged'];
323
-					unset( $qv['paged'] );
321
+				if ( ! empty( $qv[ 'paged' ] ) ) {
322
+					$qv[ 'page' ] = $qv[ 'paged' ];
323
+					unset( $qv[ 'paged' ] );
324 324
 				}
325 325
 			}
326 326
 
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
 		$this->setIsGravityviewPostType( get_post_type( $post ) === 'gravityview' );
352 352
 
353
-		$post_id = $this->getPostId() ? $this->getPostId() : (isset( $post ) ? $post->ID : null );
353
+		$post_id = $this->getPostId() ? $this->getPostId() : ( isset( $post ) ? $post->ID : null );
354 354
 		$this->setPostId( $post_id );
355 355
 		$post_has_shortcode = ! empty( $post->post_content ) ? gravityview_has_shortcode_r( $post->post_content, 'gravityview' ) : false;
356 356
 		$this->setPostHasShortcode( $this->isGravityviewPostType() ? null : ! empty( $post_has_shortcode ) );
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
 
387 387
 		$search_method = GravityView_Widget_Search::getInstance()->get_search_method();
388 388
 
389
-		if( 'post' === $search_method ) {
389
+		if ( 'post' === $search_method ) {
390 390
 			$get = $_POST;
391 391
 		} else {
392 392
 			$get = $_GET;
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 		$gventry = gravityview()->request->is_entry();
439 439
 
440 440
 		// If this is the directory view, return.
441
-		if( ! $gventry ) {
441
+		if ( ! $gventry ) {
442 442
 			return $passed_title;
443 443
 		}
444 444
 
@@ -456,19 +456,19 @@  discard block
 block discarded – undo
456 456
 		}
457 457
 
458 458
 		// WooCommerce doesn't $post_id
459
-		if ( empty( $passed_post_id ) )  {
459
+		if ( empty( $passed_post_id ) ) {
460 460
 			return $passed_title;
461 461
 		}
462 462
 
463 463
 		// Don't modify the title for anything other than the current view/post.
464 464
 		// This is true for embedded shortcodes and Views.
465
-		if ( is_object( $post ) && (int) $post->ID !== (int) $passed_post_id ) {
465
+		if ( is_object( $post ) && (int)$post->ID !== (int)$passed_post_id ) {
466 466
 			return $passed_title;
467 467
 		}
468 468
 
469 469
 		$view = gravityview()->request->is_view();
470 470
 
471
-		if( $view ) {
471
+		if ( $view ) {
472 472
 			return $this->_get_single_entry_title( $view, $entry, $passed_title );
473 473
 		}
474 474
 
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 		$view_collection = \GV\View_Collection::from_post( $post );
492 492
 
493 493
 		// We have multiple Views, but no gvid...this isn't valid security
494
-		if( 1 < $view_collection->count() ) {
494
+		if ( 1 < $view_collection->count() ) {
495 495
 			return $passed_title;
496 496
 		}
497 497
 
@@ -525,18 +525,18 @@  discard block
 block discarded – undo
525 525
 		 */
526 526
 		$check_entry_display = apply_filters( 'gravityview/single/title/check_entry_display', true, $entry, $view );
527 527
 
528
-		if( $check_entry_display ) {
528
+		if ( $check_entry_display ) {
529 529
 
530 530
 			$check_display = GVCommon::check_entry_display( $entry, $view );
531 531
 
532
-			if( is_wp_error( $check_display ) ) {
532
+			if ( is_wp_error( $check_display ) ) {
533 533
 				return $passed_title;
534 534
 			}
535 535
 		}
536 536
 
537 537
 		$title = $view->settings->get( 'single_title', $passed_title );
538 538
 
539
-		$form = GVCommon::get_form( $entry['form_id'] );
539
+		$form = GVCommon::get_form( $entry[ 'form_id' ] );
540 540
 
541 541
 		// We are allowing HTML in the fields, so no escaping the output
542 542
 		$title = GravityView_API::replace_variables( $title, $form, $entry );
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
 
608 608
 		$context = GravityView_View::getInstance()->getContext();
609 609
 
610
-		switch( $context ) {
610
+		switch ( $context ) {
611 611
 			case 'directory':
612 612
 				$tab = __( 'Multiple Entries', 'gravityview' );
613 613
 				break;
@@ -621,12 +621,12 @@  discard block
 block discarded – undo
621 621
 		}
622 622
 
623 623
 
624
-		$title = sprintf( esc_html_x('The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
624
+		$title = sprintf( esc_html_x( 'The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
625 625
 		$edit_link = admin_url( sprintf( 'post.php?post=%d&action=edit#%s-view', $view_id, $context ) );
626
-		$action_text = sprintf( esc_html__('Add fields to %s', 'gravityview' ), $tab );
626
+		$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
627 627
 		$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
628 628
 
629
-		$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url(plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
629
+		$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
630 630
 		$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
631 631
 
632 632
 		echo GVCommon::generate_notice( $output . $image, 'gv-error error', 'edit_gravityview', $view_id );
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
 		$direct_access = apply_filters( 'gravityview_direct_access', true, $view->ID );
674 674
 		$embed_only = $view->settings->get( 'embed_only' );
675 675
 
676
-		if( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
676
+		if ( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
677 677
 			return __( 'You are not allowed to view this content.', 'gravityview' );
678 678
 		}
679 679
 
@@ -720,7 +720,7 @@  discard block
 block discarded – undo
720 720
 				$datetime_format = 'Y-m-d H:i:s';
721 721
 				$search_is_outside_view_bounds = false;
722 722
 
723
-				if( ! empty( $search_criteria[ $key ] ) ) {
723
+				if ( ! empty( $search_criteria[ $key ] ) ) {
724 724
 
725 725
 					$search_date = strtotime( $search_criteria[ $key ], GFCommon::get_local_timestamp() );
726 726
 
@@ -748,14 +748,14 @@  discard block
 block discarded – undo
748 748
 				if ( empty( $search_criteria[ $key ] ) || $search_is_outside_view_bounds ) {
749 749
 
750 750
 					// Then we override the search and re-set the start date
751
-					$return_search_criteria[ $key ] = date_i18n( $datetime_format , $date, true );
751
+					$return_search_criteria[ $key ] = date_i18n( $datetime_format, $date, true );
752 752
 				}
753 753
 			}
754 754
 		}
755 755
 
756
-		if( isset( $return_search_criteria['start_date'] ) && isset( $return_search_criteria['end_date'] ) ) {
756
+		if ( isset( $return_search_criteria[ 'start_date' ] ) && isset( $return_search_criteria[ 'end_date' ] ) ) {
757 757
 			// The start date is AFTER the end date. This will result in no results, but let's not force the issue.
758
-			if ( strtotime( $return_search_criteria['start_date'] ) > strtotime( $return_search_criteria['end_date'] ) ) {
758
+			if ( strtotime( $return_search_criteria[ 'start_date' ] ) > strtotime( $return_search_criteria[ 'end_date' ] ) ) {
759 759
 				gravityview()->log->error( 'Invalid search: the start date is after the end date.', array( 'data' => $return_search_criteria ) );
760 760
 			}
761 761
 		}
@@ -774,19 +774,19 @@  discard block
 block discarded – undo
774 774
 	public static function process_search_only_approved( $args, $search_criteria ) {
775 775
 
776 776
 		/** @since 1.19 */
777
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
777
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
778 778
 			gravityview()->log->debug( 'User can moderate entries; showing all approval statuses' );
779 779
 			return $search_criteria;
780 780
 		}
781 781
 
782
-		if ( ! empty( $args['show_only_approved'] ) ) {
782
+		if ( ! empty( $args[ 'show_only_approved' ] ) ) {
783 783
 
784
-			$search_criteria['field_filters'][] = array(
784
+			$search_criteria[ 'field_filters' ][ ] = array(
785 785
 				'key' => GravityView_Entry_Approval::meta_key,
786 786
 				'value' => GravityView_Entry_Approval_Status::APPROVED
787 787
 			);
788 788
 
789
-			$search_criteria['field_filters']['mode'] = 'all'; // force all the criterias to be met
789
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all'; // force all the criterias to be met
790 790
 
791 791
 			gravityview()->log->debug( '[process_search_only_approved] Search Criteria if show only approved: ', array( 'data' => $search_criteria ) );
792 792
 		}
@@ -813,18 +813,18 @@  discard block
 block discarded – undo
813 813
 	 */
814 814
 	public static function is_entry_approved( $entry, $args = array() ) {
815 815
 
816
-		if ( empty( $entry['id'] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args['show_only_approved'] ) ) {
816
+		if ( empty( $entry[ 'id' ] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args[ 'show_only_approved' ] ) ) {
817 817
 			// is implicitly approved if entry is null or View settings doesn't require to check for approval
818 818
 			return true;
819 819
 		}
820 820
 
821 821
 		/** @since 1.19 */
822
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
822
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
823 823
 			gravityview()->log->debug( 'User can moderate entries, so entry is approved for viewing' );
824 824
 			return true;
825 825
 		}
826 826
 
827
-		$is_approved = gform_get_meta( $entry['id'], GravityView_Entry_Approval::meta_key );
827
+		$is_approved = gform_get_meta( $entry[ 'id' ], GravityView_Entry_Approval::meta_key );
828 828
 
829 829
 		return GravityView_Entry_Approval_Status::is_approved( $is_approved );
830 830
 	}
@@ -848,7 +848,7 @@  discard block
 block discarded – undo
848 848
 		 * Compatibility with filters hooking in `gravityview_search_criteria` instead of `gravityview_fe_search_criteria`.
849 849
 		 */
850 850
 		$criteria = apply_filters( 'gravityview_search_criteria', array(), array( $form_id ), \GV\Utils::get( $args, 'id' ) );
851
-		$search_criteria = isset( $criteria['search_criteria'] ) ? $criteria['search_criteria'] : array( 'field_filters' => array() );
851
+		$search_criteria = isset( $criteria[ 'search_criteria' ] ) ? $criteria[ 'search_criteria' ] : array( 'field_filters' => array() );
852 852
 
853 853
 		/**
854 854
 		 * @filter `gravityview_fe_search_criteria` Modify the search criteria
@@ -868,29 +868,29 @@  discard block
 block discarded – undo
868 868
 		gravityview()->log->debug( '[get_search_criteria] Search Criteria after hook gravityview_fe_search_criteria: ', array( 'data' =>$search_criteria ) );
869 869
 
870 870
 		// implicity search
871
-		if ( ! empty( $args['search_value'] ) ) {
871
+		if ( ! empty( $args[ 'search_value' ] ) ) {
872 872
 
873 873
 			// Search operator options. Options: `is` or `contains`
874
-			$operator = ! empty( $args['search_operator'] ) && in_array( $args['search_operator'], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args['search_operator'] : 'contains';
874
+			$operator = ! empty( $args[ 'search_operator' ] ) && in_array( $args[ 'search_operator' ], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args[ 'search_operator' ] : 'contains';
875 875
 
876
-			$search_criteria['field_filters'][] = array(
876
+			$search_criteria[ 'field_filters' ][ ] = array(
877 877
 				'key' => \GV\Utils::_GET( 'search_field', \GV\Utils::get( $args, 'search_field' ) ), // The field ID to search
878
-				'value' => _wp_specialchars( $args['search_value'] ), // The value to search. Encode ampersands but not quotes.
878
+				'value' => _wp_specialchars( $args[ 'search_value' ] ), // The value to search. Encode ampersands but not quotes.
879 879
 				'operator' => $operator,
880 880
 			);
881 881
 
882 882
 			// Lock search mode to "all" with implicit presearch filter.
883
-			$search_criteria['field_filters']['mode'] = 'all';
883
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all';
884 884
 		}
885 885
 
886
-		if( $search_criteria !== $original_search_criteria ) {
886
+		if ( $search_criteria !== $original_search_criteria ) {
887 887
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after implicity search: ', array( 'data' => $search_criteria ) );
888 888
 		}
889 889
 
890 890
 		// Handle setting date range
891 891
 		$search_criteria = self::process_search_dates( $args, $search_criteria );
892 892
 
893
-		if( $search_criteria !== $original_search_criteria ) {
893
+		if ( $search_criteria !== $original_search_criteria ) {
894 894
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after date params: ', array( 'data' => $search_criteria ) );
895 895
 		}
896 896
 
@@ -901,7 +901,7 @@  discard block
 block discarded – undo
901 901
 		 * @filter `gravityview_status` Modify entry status requirements to be included in search results.
902 902
 		 * @param string $status Default: `active`. Accepts all Gravity Forms entry statuses, including `spam` and `trash`
903 903
 		 */
904
-		$search_criteria['status'] = apply_filters( 'gravityview_status', 'active', $args );
904
+		$search_criteria[ 'status' ] = apply_filters( 'gravityview_status', 'active', $args );
905 905
 
906 906
 		return $search_criteria;
907 907
 	}
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
 			'search_criteria' => $search_criteria,
1014 1014
 			'sorting' => self::updateViewSorting( $args, $form_id ),
1015 1015
 			'paging' => $paging,
1016
-			'cache' => isset( $args['cache'] ) ? $args['cache'] : true,
1016
+			'cache' => isset( $args[ 'cache' ] ) ? $args[ 'cache' ] : true,
1017 1017
 		);
1018 1018
 
1019 1019
 		/**
@@ -1038,7 +1038,7 @@  discard block
 block discarded – undo
1038 1038
 		 * @param array $parameters Array with `search_criteria`, `sorting` and `paging` keys.
1039 1039
 		 * @param array $args View configuration args.
1040 1040
 		 */
1041
-		$parameters = apply_filters( 'gravityview_get_entries_'.\GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
1041
+		$parameters = apply_filters( 'gravityview_get_entries_' . \GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
1042 1042
 
1043 1043
 		gravityview()->log->debug( '$parameters passed to gravityview_get_entries(): ', array( 'data' => $parameters ) );
1044 1044
 
@@ -1063,17 +1063,17 @@  discard block
 block discarded – undo
1063 1063
 		$default_page_size = apply_filters( 'gravityview_default_page_size', 25 );
1064 1064
 
1065 1065
 		// Paging & offset
1066
-		$page_size = ! empty( $args['page_size'] ) ? intval( $args['page_size'] ) : $default_page_size;
1066
+		$page_size = ! empty( $args[ 'page_size' ] ) ? intval( $args[ 'page_size' ] ) : $default_page_size;
1067 1067
 
1068 1068
 		if ( -1 === $page_size ) {
1069 1069
 			$page_size = PHP_INT_MAX;
1070 1070
 		}
1071 1071
 
1072
-		$curr_page = empty( $_GET['pagenum'] ) ? 1 : intval( $_GET['pagenum'] );
1072
+		$curr_page = empty( $_GET[ 'pagenum' ] ) ? 1 : intval( $_GET[ 'pagenum' ] );
1073 1073
 		$offset = ( $curr_page - 1 ) * $page_size;
1074 1074
 
1075
-		if ( ! empty( $args['offset'] ) ) {
1076
-			$offset += intval( $args['offset'] );
1075
+		if ( ! empty( $args[ 'offset' ] ) ) {
1076
+			$offset += intval( $args[ 'offset' ] );
1077 1077
 		}
1078 1078
 
1079 1079
 		$paging = array(
@@ -1098,11 +1098,11 @@  discard block
 block discarded – undo
1098 1098
 	public static function updateViewSorting( $args, $form_id ) {
1099 1099
 		$sorting = array();
1100 1100
 
1101
-		$has_values = isset( $_GET['sort'] );
1101
+		$has_values = isset( $_GET[ 'sort' ] );
1102 1102
 
1103
-		if ( $has_values && is_array( $_GET['sort'] ) ) {
1104
-			$sorts = array_keys( $_GET['sort'] );
1105
-			$dirs  = array_values( $_GET['sort'] );
1103
+		if ( $has_values && is_array( $_GET[ 'sort' ] ) ) {
1104
+			$sorts = array_keys( $_GET[ 'sort' ] );
1105
+			$dirs  = array_values( $_GET[ 'sort' ] );
1106 1106
 
1107 1107
 			if ( $has_values = array_filter( $dirs ) ) {
1108 1108
 				$sort_field_id = end( $sorts );
@@ -1111,11 +1111,11 @@  discard block
 block discarded – undo
1111 1111
 		}
1112 1112
 
1113 1113
 		if ( ! isset( $sort_field_id ) ) {
1114
-			$sort_field_id = isset( $_GET['sort'] ) ? $_GET['sort'] : \GV\Utils::get( $args, 'sort_field' );
1114
+			$sort_field_id = isset( $_GET[ 'sort' ] ) ? $_GET[ 'sort' ] : \GV\Utils::get( $args, 'sort_field' );
1115 1115
 		}
1116 1116
 
1117 1117
 		if ( ! isset( $sort_direction ) ) {
1118
-			$sort_direction = isset( $_GET['dir'] ) ? $_GET['dir'] : \GV\Utils::get( $args, 'sort_direction' );
1118
+			$sort_direction = isset( $_GET[ 'dir' ] ) ? $_GET[ 'dir' ] : \GV\Utils::get( $args, 'sort_direction' );
1119 1119
 		}
1120 1120
 
1121 1121
 		if ( is_array( $sort_field_id ) ) {
@@ -1147,10 +1147,10 @@  discard block
 block discarded – undo
1147 1147
 				$form = GFAPI::get_form( $form_id );
1148 1148
 
1149 1149
 				// Get the first GF_Field field ID, set as the key for entry randomization
1150
-				if ( ! empty( $form['fields'] ) ) {
1150
+				if ( ! empty( $form[ 'fields' ] ) ) {
1151 1151
 
1152 1152
 					/** @var GF_Field $field */
1153
-					foreach ( $form['fields'] as $field ) {
1153
+					foreach ( $form[ 'fields' ] as $field ) {
1154 1154
 						if ( ! is_a( $field, 'GF_Field' ) ) {
1155 1155
 							continue;
1156 1156
 						}
@@ -1195,7 +1195,7 @@  discard block
 block discarded – undo
1195 1195
 		if ( is_array( $sort_field_id ) ) {
1196 1196
 			$modified_ids = array();
1197 1197
 			foreach ( $sort_field_id as $_sort_field_id ) {
1198
-				$modified_ids []= self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1198
+				$modified_ids [ ] = self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1199 1199
 			}
1200 1200
 			return $modified_ids;
1201 1201
 		}
@@ -1204,11 +1204,11 @@  discard block
 block discarded – undo
1204 1204
 
1205 1205
 		$sort_field = GFFormsModel::get_field( $form, $sort_field_id );
1206 1206
 
1207
-		if( ! $sort_field ) {
1207
+		if ( ! $sort_field ) {
1208 1208
 			return $sort_field_id;
1209 1209
 		}
1210 1210
 
1211
-		switch ( $sort_field['type'] ) {
1211
+		switch ( $sort_field[ 'type' ] ) {
1212 1212
 
1213 1213
 			case 'address':
1214 1214
 				// Sorting by full address
@@ -1225,7 +1225,7 @@  discard block
 block discarded – undo
1225 1225
 					 */
1226 1226
 					$address_part = apply_filters( 'gravityview/sorting/address', 'city', $sort_field_id, $form_id );
1227 1227
 
1228
-					switch( strtolower( $address_part ) ){
1228
+					switch ( strtolower( $address_part ) ) {
1229 1229
 						case 'street':
1230 1230
 							$sort_field_id .= '.1';
1231 1231
 							break;
@@ -1298,7 +1298,7 @@  discard block
 block discarded – undo
1298 1298
 		if ( ! class_exists( '\GV\Entry' ) ) {
1299 1299
 
1300 1300
 			// Not using gravityview()->log->error(), since that may not exist yet either!
1301
-			do_action( 'gravityview_log_error', '\GV\Entry not defined yet. Backtrace: ' . wp_debug_backtrace_summary()  );
1301
+			do_action( 'gravityview_log_error', '\GV\Entry not defined yet. Backtrace: ' . wp_debug_backtrace_summary() );
1302 1302
 
1303 1303
 			return null;
1304 1304
 		}
@@ -1315,7 +1315,7 @@  discard block
 block discarded – undo
1315 1315
 		 */
1316 1316
 		$single_entry = apply_filters( 'gravityview/is_single_entry', $single_entry );
1317 1317
 
1318
-		if ( empty( $single_entry ) ){
1318
+		if ( empty( $single_entry ) ) {
1319 1319
 			return false;
1320 1320
 		} else {
1321 1321
 			return $single_entry;
@@ -1336,7 +1336,7 @@  discard block
 block discarded – undo
1336 1336
 			$views = $this->getGvOutputData()->get_views();
1337 1337
 
1338 1338
 			foreach ( $views as $view_id => $data ) {
1339
-				$view = \GV\View::by_id( $data['id'] );
1339
+				$view = \GV\View::by_id( $data[ 'id' ] );
1340 1340
 				$view_id = $view->ID;
1341 1341
 				$template_id = gravityview_get_template_id( $view->ID );
1342 1342
 				$data = $view->as_data();
@@ -1345,7 +1345,7 @@  discard block
 block discarded – undo
1345 1345
 				 * Don't enqueue the scripts or styles if it's not going to be displayed.
1346 1346
 				 * @since 1.15
1347 1347
 				 */
1348
-				if( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1348
+				if ( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1349 1349
 					continue;
1350 1350
 				}
1351 1351
 
@@ -1374,7 +1374,7 @@  discard block
 block discarded – undo
1374 1374
 					 * @param \GV\View The View.
1375 1375
 					 */
1376 1376
 					$js_dependency = apply_filters( 'gravityview_lightbox_script', $js_dependency, $view );
1377
-					$js_dependencies[] = $js_dependency;
1377
+					$js_dependencies[ ] = $js_dependency;
1378 1378
 
1379 1379
 					/**
1380 1380
 					 * @filter `gravity_view_lightbox_style` Modify the lightbox CSS slug. Default: `thickbox`
@@ -1390,7 +1390,7 @@  discard block
 block discarded – undo
1390 1390
 					 * @param \GV\View The View.
1391 1391
 					 */
1392 1392
 					$css_dependency = apply_filters( 'gravityview_lightbox_style', $css_dependency, $view );
1393
-					$css_dependencies[] = $css_dependency;
1393
+					$css_dependencies[ ] = $css_dependency;
1394 1394
 				}
1395 1395
 
1396 1396
 				/**
@@ -1398,19 +1398,19 @@  discard block
 block discarded – undo
1398 1398
 				 * @see https://github.com/katzwebservices/GravityView/issues/536
1399 1399
 				 * @since 1.15
1400 1400
 				 */
1401
-				if( gravityview_view_has_single_checkbox_or_radio( $data['form'], $data['fields'] ) ) {
1402
-					$css_dependencies[] = 'dashicons';
1401
+				if ( gravityview_view_has_single_checkbox_or_radio( $data[ 'form' ], $data[ 'fields' ] ) ) {
1402
+					$css_dependencies[ ] = 'dashicons';
1403 1403
 				}
1404 1404
 
1405 1405
 				wp_register_script( 'gravityview-jquery-cookie', plugins_url( 'assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version, true );
1406 1406
 
1407 1407
 				$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
1408 1408
 
1409
-				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ) , GravityView_Plugin::version, true );
1409
+				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ), GravityView_Plugin::version, true );
1410 1410
 
1411 1411
 				wp_enqueue_script( 'gravityview-fe-view' );
1412 1412
 
1413
-				if ( ! empty( $data['atts']['sort_columns'] ) ) {
1413
+				if ( ! empty( $data[ 'atts' ][ 'sort_columns' ] ) ) {
1414 1414
 					wp_enqueue_style( 'gravityview_font', plugins_url( 'assets/css/font.css', GRAVITYVIEW_FILE ), $css_dependencies, GravityView_Plugin::version, 'all' );
1415 1415
 				}
1416 1416
 
@@ -1473,7 +1473,7 @@  discard block
 block discarded – undo
1473 1473
 	public static function add_style( $template_id ) {
1474 1474
 
1475 1475
 		if ( ! empty( $template_id ) && wp_style_is( 'gravityview_style_' . $template_id, 'registered' ) ) {
1476
-			gravityview()->log->debug(  'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1476
+			gravityview()->log->debug( 'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1477 1477
 			wp_enqueue_style( 'gravityview_style_' . $template_id );
1478 1478
 		} elseif ( empty( $template_id ) ) {
1479 1479
 			gravityview()->log->error( 'Cannot add template style; template_id is empty' );
@@ -1504,11 +1504,11 @@  discard block
 block discarded – undo
1504 1504
 		 * Not a table-based template; don't add sort icons
1505 1505
 		 * @since 1.12
1506 1506
 		 */
1507
-		if( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1507
+		if ( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1508 1508
 			return $label;
1509 1509
 		}
1510 1510
 
1511
-		if ( ! $this->is_field_sortable( $field['id'], $form ) ) {
1511
+		if ( ! $this->is_field_sortable( $field[ 'id' ], $form ) ) {
1512 1512
 			return $label;
1513 1513
 		}
1514 1514
 
@@ -1516,29 +1516,29 @@  discard block
 block discarded – undo
1516 1516
 
1517 1517
 		$class = 'gv-sort';
1518 1518
 
1519
-		$sort_field_id = self::_override_sorting_id_by_field_type( $field['id'], $form['id'] );
1519
+		$sort_field_id = self::_override_sorting_id_by_field_type( $field[ 'id' ], $form[ 'id' ] );
1520 1520
 
1521 1521
 		$sort_args = array(
1522
-			'sort' => $field['id'],
1522
+			'sort' => $field[ 'id' ],
1523 1523
 			'dir' => 'asc',
1524 1524
 		);
1525 1525
 
1526
-		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
1526
+		if ( ! empty( $sorting[ 'key' ] ) && (string)$sort_field_id === (string)$sorting[ 'key' ] ) {
1527 1527
 			//toggle sorting direction.
1528
-			if ( 'asc' === $sorting['direction'] ) {
1529
-				$sort_args['dir'] = 'desc';
1528
+			if ( 'asc' === $sorting[ 'direction' ] ) {
1529
+				$sort_args[ 'dir' ] = 'desc';
1530 1530
 				$class .= ' gv-icon-sort-desc';
1531 1531
 			} else {
1532
-				$sort_args['dir'] = 'asc';
1532
+				$sort_args[ 'dir' ] = 'asc';
1533 1533
 				$class .= ' gv-icon-sort-asc';
1534 1534
 			}
1535 1535
 		} else {
1536 1536
 			$class .= ' gv-icon-caret-up-down';
1537 1537
 		}
1538 1538
 
1539
-		$url = add_query_arg( $sort_args, remove_query_arg( array('pagenum') ) );
1539
+		$url = add_query_arg( $sort_args, remove_query_arg( array( 'pagenum' ) ) );
1540 1540
 
1541
-		return '<a href="'. esc_url_raw( $url ) .'" class="'. $class .'" ></a>&nbsp;'. $label;
1541
+		return '<a href="' . esc_url_raw( $url ) . '" class="' . $class . '" ></a>&nbsp;' . $label;
1542 1542
 
1543 1543
 	}
1544 1544
 
@@ -1556,7 +1556,7 @@  discard block
 block discarded – undo
1556 1556
 
1557 1557
 		$field_type = $field_id;
1558 1558
 
1559
-		if( is_numeric( $field_id ) ) {
1559
+		if ( is_numeric( $field_id ) ) {
1560 1560
 			$field = GFFormsModel::get_field( $form, $field_id );
1561 1561
 			$field_type = $field ? $field->type : $field_id;
1562 1562
 		}
@@ -1579,7 +1579,7 @@  discard block
 block discarded – undo
1579 1579
 			return false;
1580 1580
 		}
1581 1581
 
1582
-		return apply_filters( "gravityview/sortable/formfield_{$form['id']}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1582
+		return apply_filters( "gravityview/sortable/formfield_{$form[ 'id' ]}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1583 1583
 
1584 1584
 	}
1585 1585
 
Please login to merge, or discard this patch.
includes/class-gravityview-entry-list.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,13 +87,13 @@
 block discarded – undo
87 87
 	 * @since 2.0 Added $template_context parameter
88 88
 	 * @since 2.7.2 Added $view_id parameter
89 89
 	 *
90
-	 * @param array|GV\Entry[] $entries
90
+	 * @param GV\Entry[] $entries
91 91
 	 * @param int $post_id
92 92
 	 * @param array $form
93 93
 	 * @param string $link_format
94 94
 	 * @param string $after_link
95 95
 	 * @param \GV\Template_Context $template_context The context
96
-	 * @param int|null $view_id View to link to when displaying on a page with multiple Views
96
+	 * @param integer $view_id View to link to when displaying on a page with multiple Views
97 97
 	 */
98 98
 	function __construct( $entries = array(), $post_id = 0, $form = array(), $link_format = '', $after_link = '', $context = '', $template_context = null, $view_id = 0 ) {
99 99
 		$this->entries = $entries;
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
 	public function get_output() {
191 191
 
192 192
 		// No Entries
193
-		if( empty( $this->entries ) ) {
194
-			return '<div class="gv-no-results">'.$this->empty_message.'</div>';
193
+		if ( empty( $this->entries ) ) {
194
+			return '<div class="gv-no-results">' . $this->empty_message . '</div>';
195 195
 		}
196 196
 
197 197
 		$output = '';
@@ -202,22 +202,22 @@  discard block
 block discarded – undo
202 202
 			$current_entry = GravityView_View::getInstance()->getCurrentEntry();
203 203
 		}
204 204
 
205
-		$output .= '<'. $this->wrapper_tag .'>';
205
+		$output .= '<' . $this->wrapper_tag . '>';
206 206
 
207
-		foreach( $this->entries as $entry ) {
207
+		foreach ( $this->entries as $entry ) {
208 208
 
209 209
 			if ( $entry instanceof \GV\Entry ) {
210 210
 				$entry = $entry->as_entry();
211 211
 			}
212 212
 
213
-			if( $this->skip_entry( $entry, $current_entry ) ) {
213
+			if ( $this->skip_entry( $entry, $current_entry ) ) {
214 214
 				continue;
215 215
 			}
216 216
 
217 217
 			$output .= $this->get_item_output( $entry );
218 218
 		}
219 219
 
220
-		$output .= '</'. $this->wrapper_tag .'>';
220
+		$output .= '</' . $this->wrapper_tag . '>';
221 221
 
222 222
 		/**
223 223
 		 * @filter `gravityview/widget/recent-entries/output` Modify the HTML of the Recent Entries widget output
@@ -240,15 +240,15 @@  discard block
 block discarded – undo
240 240
 	private function skip_entry( $entry, $current_entry ) {
241 241
 
242 242
 		// If skip entry is off, or there's no current entry, return false
243
-		if( empty( $this->skip_current_entry ) || empty( $current_entry ) ) {
243
+		if ( empty( $this->skip_current_entry ) || empty( $current_entry ) ) {
244 244
 			return false;
245 245
 		}
246 246
 
247 247
 		// If in Single or Edit mode, $current_entry will be an array.
248
-		$current_entry_id = is_array( $current_entry ) ? $current_entry['id'] : $current_entry;
248
+		$current_entry_id = is_array( $current_entry ) ? $current_entry[ 'id' ] : $current_entry;
249 249
 
250 250
 		// If the entry ID matches the current entry, yes: skip
251
-		if( $entry['id'] === $current_entry_id ) {
251
+		if ( $entry[ 'id' ] === $current_entry_id ) {
252 252
 			return true;
253 253
 		}
254 254
 
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 
284 284
 		$item_output = gravityview_get_link( $link, $this->link_format );
285 285
 
286
-		if( !empty( $this->after_link ) ) {
286
+		if ( ! empty( $this->after_link ) ) {
287 287
 
288 288
 			/**
289 289
 			 * @filter `gravityview/entry-list/after-link` Modify the content displayed after the entry link in an entry list
@@ -292,14 +292,14 @@  discard block
 block discarded – undo
292 292
 			 * @param array $entry Gravity Forms entry array
293 293
 			 * @param GravityView_Entry_List $this The current class instance
294 294
 			 */
295
-			$after_link = apply_filters( 'gravityview/entry-list/after-link', '<div>'.$this->after_link.'</div>', $entry, $this );
295
+			$after_link = apply_filters( 'gravityview/entry-list/after-link', '<div>' . $this->after_link . '</div>', $entry, $this );
296 296
 
297 297
 			$item_output .= $after_link;
298 298
 		}
299 299
 
300 300
 		$item_output = GravityView_API::replace_variables( $item_output, $this->form, $entry );
301 301
 
302
-		$item_output = '<'. $this->item_tag .'>'. $item_output .'</'. $this->item_tag .'>';
302
+		$item_output = '<' . $this->item_tag . '>' . $item_output . '</' . $this->item_tag . '>';
303 303
 
304 304
 		/**
305 305
 		 * @filter `gravityview/entry-list/item` Modify each item's output in an entry list
Please login to merge, or discard this patch.
includes/wordpress-widgets/class-gravityview-recent-entries-widget.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	 * @param  array $instance Settings for the current widget
177 177
 	 * @param  string $form_id Form ID int, as string
178 178
 	 *
179
-	 * @return array|GV\Entry[] $entries Multidimensional array of Gravity Forms entries or GravityView Entry objects
179
+	 * @return GV\Entry[] $entries Multidimensional array of Gravity Forms entries or GravityView Entry objects
180 180
 	 */
181 181
 	private function get_entries( $instance, $form_id ) {
182 182
 
Please login to merge, or discard this patch.
Spacing   +55 added lines, -55 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 
13 13
 	function __construct( ) {
14 14
 
15
-		$name = __('GravityView Recent Entries', 'gravityview');
15
+		$name = __( 'GravityView Recent Entries', 'gravityview' );
16 16
 
17 17
 		$widget_options = array(
18 18
 			'description' => __( 'Display the most recent entries for a View', 'gravityview' ),
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
 	private function initialize() {
27 27
 
28
-		add_action('admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts') );
28
+		add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts' ) );
29 29
 
30 30
 		add_action( 'wp_ajax_gv_get_view_merge_tag_data', array( $this, 'ajax_get_view_merge_tag_data' ) );
31 31
 
@@ -38,21 +38,21 @@  discard block
 block discarded – undo
38 38
 	 */
39 39
 	function ajax_get_view_merge_tag_data() {
40 40
 
41
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajax_widget' ) ) {
41
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajax_widget' ) ) {
42 42
 			exit( false );
43 43
 		}
44 44
 
45
-		$form_id  = gravityview_get_form_id( $_POST['view_id'] );
45
+		$form_id = gravityview_get_form_id( $_POST[ 'view_id' ] );
46 46
 
47 47
 		$form = RGFormsModel::get_form_meta( $form_id );
48 48
 
49 49
 		$output = array(
50 50
 			'form' => array(
51
-				'id' => $form['id'],
52
-				'title' => $form['title'],
53
-				'fields' => $form['fields'],
51
+				'id' => $form[ 'id' ],
52
+				'title' => $form[ 'title' ],
53
+				'fields' => $form[ 'fields' ],
54 54
 			),
55
-			'mergeTags' => GFCommon::get_merge_tags( $form['fields'], '', false ),
55
+			'mergeTags' => GFCommon::get_merge_tags( $form[ 'fields' ], '', false ),
56 56
 		);
57 57
 
58 58
 		echo json_encode( $output );
@@ -68,17 +68,17 @@  discard block
 block discarded – undo
68 68
 	function admin_enqueue_scripts() {
69 69
 		global $pagenow;
70 70
 
71
-		if( $pagenow === 'widgets.php' ) {
71
+		if ( $pagenow === 'widgets.php' ) {
72 72
 
73
-			$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
73
+			$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
74 74
 
75
-			wp_enqueue_script( 'gravityview_widgets', plugins_url('assets/js/admin-widgets'.$script_debug.'.js', GRAVITYVIEW_FILE), array( 'jquery', 'gform_gravityforms' ), GravityView_Plugin::version );
75
+			wp_enqueue_script( 'gravityview_widgets', plugins_url( 'assets/js/admin-widgets' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery', 'gform_gravityforms' ), GravityView_Plugin::version );
76 76
 
77 77
 			wp_localize_script( 'gravityview_widgets', 'GVWidgets', array(
78 78
 				'nonce' => wp_create_nonce( 'gravityview_ajax_widget' )
79
-			));
79
+			) );
80 80
 
81
-			wp_enqueue_style( 'gravityview_views_styles', plugins_url('assets/css/admin-views.css', GRAVITYVIEW_FILE), array('dashicons' ), GravityView_Plugin::version );
81
+			wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array( 'dashicons' ), GravityView_Plugin::version );
82 82
 		}
83 83
 
84 84
 	}
@@ -93,19 +93,19 @@  discard block
 block discarded – undo
93 93
 	function widget( $args, $instance ) {
94 94
 
95 95
 		// Don't have the Customizer render too soon.
96
-		if( empty( $instance['view_id'] ) ) {
96
+		if ( empty( $instance[ 'view_id' ] ) ) {
97 97
 			return;
98 98
 		}
99 99
 
100
-		$args['id']        = ( isset( $args['id'] ) ) ? $args['id'] : 'gv_recent_entries';
101
-		$instance['title'] = ( isset( $instance['title'] ) ) ? $instance['title'] : '';
100
+		$args[ 'id' ]        = ( isset( $args[ 'id' ] ) ) ? $args[ 'id' ] : 'gv_recent_entries';
101
+		$instance[ 'title' ] = ( isset( $instance[ 'title' ] ) ) ? $instance[ 'title' ] : '';
102 102
 
103
-		$title = apply_filters( 'widget_title', $instance[ 'title' ], $instance, $args['id'] );
103
+		$title = apply_filters( 'widget_title', $instance[ 'title' ], $instance, $args[ 'id' ] );
104 104
 
105
-		echo $args['before_widget'];
105
+		echo $args[ 'before_widget' ];
106 106
 
107
-		if ( !empty( $title ) ) {
108
-			echo $args['before_title'] . $title . $args['after_title'];
107
+		if ( ! empty( $title ) ) {
108
+			echo $args[ 'before_title' ] . $title . $args[ 'after_title' ];
109 109
 		}
110 110
 
111 111
 		/**
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		 */
126 126
 		do_action( 'gravityview/widget/recent-entries/after_widget', $args, $instance );
127 127
 
128
-		echo $args['after_widget'];
128
+		echo $args[ 'after_widget' ];
129 129
 	}
130 130
 
131 131
 	/**
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	 */
140 140
 	private function get_output( $instance ) {
141 141
 
142
-		$form_id = gravityview_get_form_id( $instance['view_id'] );
142
+		$form_id = gravityview_get_form_id( $instance[ 'view_id' ] );
143 143
 
144 144
 		$form = gravityview_get_form( $form_id );
145 145
 
@@ -149,13 +149,13 @@  discard block
 block discarded – undo
149 149
 		 * @since 1.6.1
150 150
 		 * @var int $entry_link_post_id The ID to use as the parent post for the entry
151 151
 		 */
152
-		$entry_link_post_id = ( empty( $instance['error_post_id'] ) && !empty( $instance['post_id'] ) ) ? $instance['post_id'] : $instance['view_id'];
152
+		$entry_link_post_id = ( empty( $instance[ 'error_post_id' ] ) && ! empty( $instance[ 'post_id' ] ) ) ? $instance[ 'post_id' ] : $instance[ 'view_id' ];
153 153
 
154 154
 		/**
155 155
 		 * Generate list output
156 156
 		 * @since 1.7.2
157 157
 		 */
158
-		$List = new GravityView_Entry_List( $entries, $entry_link_post_id, $form, $instance['link_format'], $instance['after_link'], 'recent-entries-widget', null, $instance['view_id'] );
158
+		$List = new GravityView_Entry_List( $entries, $entry_link_post_id, $form, $instance[ 'link_format' ], $instance[ 'after_link' ], 'recent-entries-widget', null, $instance[ 'view_id' ] );
159 159
 
160 160
 		$output = $List->get_output();
161 161
 
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
 	 */
181 181
 	private function get_entries( $instance, $form_id ) {
182 182
 
183
-		$view = \GV\View::by_id( $instance['view_id'] );
183
+		$view = \GV\View::by_id( $instance[ 'view_id' ] );
184 184
 
185
-		$limit = isset( $instance['limit'] ) ? $instance['limit'] : 10;
185
+		$limit = isset( $instance[ 'limit' ] ) ? $instance[ 'limit' ] : 10;
186 186
 
187 187
 		$view->settings->set( 'page_size', $limit );
188 188
 
@@ -205,23 +205,23 @@  discard block
 block discarded – undo
205 205
 		$instance = $new_instance;
206 206
 
207 207
 		// Force positive number
208
-		$instance['limit'] = empty( $instance['limit'] ) ? 10 : absint( $instance['limit'] );
208
+		$instance[ 'limit' ] = empty( $instance[ 'limit' ] ) ? 10 : absint( $instance[ 'limit' ] );
209 209
 
210
-		$instance['view_id'] = intval( $instance['view_id'] );
210
+		$instance[ 'view_id' ] = intval( $instance[ 'view_id' ] );
211 211
 
212
-		$instance['link_format'] = trim( rtrim( $instance['link_format'] ) );
212
+		$instance[ 'link_format' ] = trim( rtrim( $instance[ 'link_format' ] ) );
213 213
 
214
-		$instance['link_format'] = empty( $instance['link_format'] ) ? $old_instance['link_format'] : $instance['link_format'];
214
+		$instance[ 'link_format' ] = empty( $instance[ 'link_format' ] ) ? $old_instance[ 'link_format' ] : $instance[ 'link_format' ];
215 215
 
216
-		$instance['post_id'] = empty( $instance['post_id'] ) ? '' : intval( $instance['post_id'] );
216
+		$instance[ 'post_id' ] = empty( $instance[ 'post_id' ] ) ? '' : intval( $instance[ 'post_id' ] );
217 217
 
218
-		$is_valid_embed_id = GravityView_View_Data::is_valid_embed_id( $instance['post_id'], $instance['view_id'] );
218
+		$is_valid_embed_id = GravityView_View_Data::is_valid_embed_id( $instance[ 'post_id' ], $instance[ 'view_id' ] );
219 219
 
220 220
 		//check if post_id is a valid post with embedded View
221
-		$instance['error_post_id'] = is_wp_error( $is_valid_embed_id ) ? $is_valid_embed_id->get_error_message() : NULL;
221
+		$instance[ 'error_post_id' ] = is_wp_error( $is_valid_embed_id ) ? $is_valid_embed_id->get_error_message() : NULL;
222 222
 
223 223
 		// Share that the widget isn't brand new
224
-		$instance['updated']  = 1;
224
+		$instance[ 'updated' ] = 1;
225 225
 
226 226
 		/**
227 227
 		 * Modify the updated instance. This will allow for validating any added instance settings externally.
@@ -243,22 +243,22 @@  discard block
 block discarded – undo
243 243
 
244 244
 		// Set up some default widget settings.
245 245
 		$defaults = array(
246
-			'title' 			=> __('Recent Entries', 'gravityview'),
246
+			'title' 			=> __( 'Recent Entries', 'gravityview' ),
247 247
 			'view_id'           => NULL,
248 248
 			'post_id'           => NULL,
249 249
 			'limit'            => 10,
250
-			'link_format'       => __('Entry #{entry_id}', 'gravityview'),
250
+			'link_format'       => __( 'Entry #{entry_id}', 'gravityview' ),
251 251
 			'after_link'        => ''
252 252
 		);
253 253
 
254
-		$instance = wp_parse_args( (array) $instance, $defaults );
254
+		$instance = wp_parse_args( (array)$instance, $defaults );
255 255
 
256 256
 		?>
257 257
 
258 258
 		<!-- Title -->
259 259
 		<p>
260 260
 			<label for="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>"><?php _e( 'Title:', 'gravityview' ) ?></label>
261
-			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'title' ) ); ?>" type="text" value="<?php echo esc_attr( $instance['title'] ); ?>" />
261
+			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'title' ) ); ?>" type="text" value="<?php echo esc_attr( $instance[ 'title' ] ); ?>" />
262 262
 		</p>
263 263
 
264 264
 		<!-- Download -->
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 		$views = get_posts( $args );
272 272
 
273 273
 		// If there are no views set up yet, we get outta here.
274
-		if( empty( $views ) ) {
274
+		if ( empty( $views ) ) {
275 275
 			echo '<div id="select_gravityview_view"><div class="wrap">' . GravityView_Admin::no_views_text() . '</div></div>';
276 276
 			return;
277 277
 		}
@@ -283,10 +283,10 @@  discard block
 block discarded – undo
283 283
 		 * Display errors generated for invalid embed IDs
284 284
 		 * @see GravityView_View_Data::is_valid_embed_id
285 285
 		 */
286
-		if( isset( $instance['updated'] ) && empty( $instance['view_id'] ) ) {
286
+		if ( isset( $instance[ 'updated' ] ) && empty( $instance[ 'view_id' ] ) ) {
287 287
 			?>
288 288
 			<div class="error inline hide-on-view-change">
289
-				<p><?php esc_html_e('Please select a View to search.', 'gravityview'); ?></p>
289
+				<p><?php esc_html_e( 'Please select a View to search.', 'gravityview' ); ?></p>
290 290
 			</div>
291 291
 			<?php
292 292
 			unset ( $error );
@@ -294,14 +294,14 @@  discard block
 block discarded – undo
294 294
 		?>
295 295
 
296 296
 		<p>
297
-			<label for="<?php echo esc_attr( $this->get_field_id( 'view_id' ) ); ?>"><?php esc_html_e('Select a View', 'gravityview'); ?></label>
297
+			<label for="<?php echo esc_attr( $this->get_field_id( 'view_id' ) ); ?>"><?php esc_html_e( 'Select a View', 'gravityview' ); ?></label>
298 298
 			<select class="widefat gv-recent-entries-select-view" name="<?php echo esc_attr( $this->get_field_name( 'view_id' ) ); ?>" id="<?php echo esc_attr( $this->get_field_id( 'view_id' ) ); ?>">
299 299
 				<option value=""><?php esc_html_e( '&mdash; Select a View as Entries Source &mdash;', 'gravityview' ); ?></option>
300 300
 				<?php
301 301
 
302
-				foreach( $views as $view ) {
303
-					$title = empty( $view->post_title ) ? __('(no title)', 'gravityview') : $view->post_title;
304
-					echo '<option value="'. $view->ID .'"'.selected( absint( $instance['view_id'] ), $view->ID ).'>'. esc_html( sprintf('%s #%d', $title, $view->ID ) ) .'</option>';
302
+				foreach ( $views as $view ) {
303
+					$title = empty( $view->post_title ) ? __( '(no title)', 'gravityview' ) : $view->post_title;
304
+					echo '<option value="' . $view->ID . '"' . selected( absint( $instance[ 'view_id' ] ), $view->ID ) . '>' . esc_html( sprintf( '%s #%d', $title, $view->ID ) ) . '</option>';
305 305
 				}
306 306
 
307 307
 				?>
@@ -313,10 +313,10 @@  discard block
 block discarded – undo
313 313
 		 * Display errors generated for invalid embed IDs
314 314
 		 * @see GravityView_View_Data::is_valid_embed_id
315 315
 		 */
316
-		if( !empty( $instance['error_post_id'] ) ) {
316
+		if ( ! empty( $instance[ 'error_post_id' ] ) ) {
317 317
 			?>
318 318
 			<div class="error inline">
319
-				<p><?php echo $instance['error_post_id']; ?></p>
319
+				<p><?php echo $instance[ 'error_post_id' ]; ?></p>
320 320
 			</div>
321 321
 			<?php
322 322
 			unset ( $error );
@@ -324,11 +324,11 @@  discard block
 block discarded – undo
324 324
 		?>
325 325
 
326 326
 		<p>
327
-			<label for="<?php echo $this->get_field_id('post_id'); ?>"><?php esc_html_e( 'If Embedded, Page ID:', 'gravityview' ); ?></label>
328
-			<input class="code" size="3" id="<?php echo $this->get_field_id('post_id'); ?>" name="<?php echo $this->get_field_name('post_id'); ?>" type="text" value="<?php echo esc_attr( $instance['post_id'] ); ?>" />
327
+			<label for="<?php echo $this->get_field_id( 'post_id' ); ?>"><?php esc_html_e( 'If Embedded, Page ID:', 'gravityview' ); ?></label>
328
+			<input class="code" size="3" id="<?php echo $this->get_field_id( 'post_id' ); ?>" name="<?php echo $this->get_field_name( 'post_id' ); ?>" type="text" value="<?php echo esc_attr( $instance[ 'post_id' ] ); ?>" />
329 329
 			<span class="howto"><?php
330
-				esc_html_e('To have a search performed on an embedded View, enter the ID of the post or page where the View is embedded.', 'gravityview' );
331
-				echo ' '.gravityview_get_link('https://docs.gravityview.co/article/222-the-search-widget', __('Learn more&hellip;', 'gravityview' ), 'target=_blank' );
330
+				esc_html_e( 'To have a search performed on an embedded View, enter the ID of the post or page where the View is embedded.', 'gravityview' );
331
+				echo ' ' . gravityview_get_link( 'https://docs.gravityview.co/article/222-the-search-widget', __( 'Learn more&hellip;', 'gravityview' ), 'target=_blank' );
332 332
 				?></span>
333 333
 		</p>
334 334
 
@@ -336,21 +336,21 @@  discard block
 block discarded – undo
336 336
 			<label for="<?php echo $this->get_field_id( 'limit' ); ?>">
337 337
 				<span><?php _e( 'Number of entries to show:', 'gravityview' ); ?></span>
338 338
 			</label>
339
-			<input class="code" id="<?php echo $this->get_field_id( 'limit' ); ?>" name="<?php echo $this->get_field_name( 'limit' ); ?>" type="number" value="<?php echo intval( $instance['limit'] ); ?>" size="3" />
339
+			<input class="code" id="<?php echo $this->get_field_id( 'limit' ); ?>" name="<?php echo $this->get_field_name( 'limit' ); ?>" type="number" value="<?php echo intval( $instance[ 'limit' ] ); ?>" size="3" />
340 340
 		</p>
341 341
 
342 342
 		<p>
343 343
 			<label for="<?php echo $this->get_field_id( 'link_format' ); ?>">
344 344
 				<span><?php _e( 'Entry link text (required)', 'gravityview' ); ?></span>
345 345
 			</label>
346
-			<input id="<?php echo $this->get_field_id( 'link_format' ); ?>" name="<?php echo $this->get_field_name( 'link_format' ); ?>" type="text" value="<?php echo esc_attr( $instance['link_format'] ); ?>" class="widefat merge-tag-support mt-position-right mt-hide_all_fields" />
346
+			<input id="<?php echo $this->get_field_id( 'link_format' ); ?>" name="<?php echo $this->get_field_name( 'link_format' ); ?>" type="text" value="<?php echo esc_attr( $instance[ 'link_format' ] ); ?>" class="widefat merge-tag-support mt-position-right mt-hide_all_fields" />
347 347
 		</p>
348 348
 
349 349
 		<p>
350 350
 			<label for="<?php echo $this->get_field_id( 'after_link' ); ?>">
351 351
 				<span><?php _e( 'Text or HTML to display after the link (optional)', 'gravityview' ); ?></span>
352 352
 			</label>
353
-			<textarea id="<?php echo $this->get_field_id( 'after_link' ); ?>" name="<?php echo $this->get_field_name( 'after_link' ); ?>" rows="5" class="widefat code merge-tag-support mt-position-right mt-hide_all_fields"><?php echo esc_textarea( $instance['after_link'] ); ?></textarea>
353
+			<textarea id="<?php echo $this->get_field_id( 'after_link' ); ?>" name="<?php echo $this->get_field_name( 'after_link' ); ?>" rows="5" class="widefat code merge-tag-support mt-position-right mt-hide_all_fields"><?php echo esc_textarea( $instance[ 'after_link' ] ); ?></textarea>
354 354
 		</p>
355 355
 
356 356
 		<?php
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 		 * @param GravityView_Recent_Entries_Widget $this WP_Widget object
361 361
 		 * @param array $instance Current widget instance
362 362
 		 */
363
-		do_action( 'gravityview_recent_entries_widget_form' , $this, $instance );
363
+		do_action( 'gravityview_recent_entries_widget_form', $this, $instance );
364 364
 
365 365
 		?>
366 366
 
Please login to merge, or discard this patch.
future/includes/rest/class-gv-rest-route.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
 		$format = '(?:\.(?P<format>html|json))?';
134 134
 
135
-		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ) , array(
135
+		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ), array(
136 136
 			array(
137 137
 				'methods'         => \WP_REST_Server::READABLE,
138 138
 				'callback'        => array( $this, 'get_sub_item' ),
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
 	 * @return \WP_REST_Response
383 383
 	 */
384 384
 	protected function not_implemented() {
385
-		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' )  );
385
+		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' ) );
386 386
 		return new \WP_REST_Response( $error, 501 );
387 387
 	}
388 388
 
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-textarea.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,13 +39,13 @@
 block discarded – undo
39 39
 			'tooltip' => __( 'Enter the number of words to be shown. If specified it truncates the text. Leave it blank if you want to show the full text.', 'gravityview' ),
40 40
 		);
41 41
 
42
-        $field_options['make_clickable'] = array(
43
-            'type' => 'checkbox',
44
-            'merge_tags' => false,
45
-            'value' => 0,
46
-            'label' => __( 'Convert text URLs to HTML links', 'gravityview' ),
47
-            'tooltip' => __( 'Converts URI, www, FTP, and email addresses in HTML links', 'gravityview' ),
48
-        );
42
+		$field_options['make_clickable'] = array(
43
+			'type' => 'checkbox',
44
+			'merge_tags' => false,
45
+			'value' => 0,
46
+			'label' => __( 'Convert text URLs to HTML links', 'gravityview' ),
47
+			'tooltip' => __( 'Converts URI, www, FTP, and email addresses in HTML links', 'gravityview' ),
48
+		);
49 49
 
50 50
 		$field_options['allow_html'] = array(
51 51
 			'type' => 'checkbox',
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
 
30 30
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
31 31
 
32
-		if( 'edit' === $context ) {
32
+		if ( 'edit' === $context ) {
33 33
 			return $field_options;
34 34
 		}
35 35
 
36
-		unset( $field_options['show_as_link'] );
36
+		unset( $field_options[ 'show_as_link' ] );
37 37
 
38
-		$field_options['trim_words'] = array(
38
+		$field_options[ 'trim_words' ] = array(
39 39
 			'type' => 'number',
40 40
 			'merge_tags' => false,
41 41
 			'value' => null,
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 			'tooltip' => __( 'Enter the number of words to be shown. If specified it truncates the text. Leave it blank if you want to show the full text.', 'gravityview' ),
44 44
 		);
45 45
 
46
-        $field_options['make_clickable'] = array(
46
+        $field_options[ 'make_clickable' ] = array(
47 47
             'type' => 'checkbox',
48 48
             'merge_tags' => false,
49 49
             'value' => 0,
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             'tooltip' => __( 'Converts URI, www, FTP, and email addresses in HTML links', 'gravityview' ),
52 52
         );
53 53
 
54
-		$field_options['allow_html'] = array(
54
+		$field_options[ 'allow_html' ] = array(
55 55
 			'type' => 'checkbox',
56 56
 			'merge_tags' => false,
57 57
 			'value' => 1,
Please login to merge, or discard this patch.
includes/admin/field-types/type_number.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * number input type
4 4
  */
5 5
 
6
-if( !class_exists('GravityView_FieldType_text') ) {
6
+if ( ! class_exists( 'GravityView_FieldType_text' ) ) {
7 7
 	include_once( GRAVITYVIEW_DIR . 'includes/admin/field-types/type_text.php' );
8 8
 }
9 9
 
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
 		$show_mt = $this->show_merge_tags();
22 22
 
23
-		if ( $show_mt && $this->field['merge_tags'] !== false || $this->field['merge_tags'] === 'force' ) {
23
+		if ( $show_mt && $this->field[ 'merge_tags' ] !== false || $this->field[ 'merge_tags' ] === 'force' ) {
24 24
 			$class = 'merge-tag-support mt-position-right mt-hide_all_fields ';
25 25
 		}
26 26
 
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 		$step = \GV\Utils::get( $this->field, 'step', null );
32 32
 
33 33
 		$atts = '';
34
-		$atts .= $max ? ' max="' . (int) $max . '"' : '';
35
-		$atts .= $min ? ' min="' . (int) $min . '"' : '';
36
-		$atts .= $step ? ' step="' . (int) $step . '"' : '';
34
+		$atts .= $max ? ' max="' . (int)$max . '"' : '';
35
+		$atts .= $min ? ' min="' . (int)$min . '"' : '';
36
+		$atts .= $step ? ' step="' . (int)$step . '"' : '';
37 37
 		?>
38 38
 		<input name="<?php echo esc_attr( $this->name ); ?>" id="<?php echo $this->get_field_id(); ?>" type="number"
39 39
 		       value="<?php echo esc_attr( $this->value ); ?>"
Please login to merge, or discard this patch.
includes/presets/default-table/class-gravityview-default-template-table.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,15 +88,15 @@
 block discarded – undo
88 88
 	 */
89 89
 	public function maybe_modify_button_label( $label = '', $atts = array() ) {
90 90
 
91
-		if( $this->template_id !== \GV\Utils::get( $atts, 'template_id' ) ) {
91
+		if ( $this->template_id !== \GV\Utils::get( $atts, 'template_id' ) ) {
92 92
 			return $label;
93 93
 		}
94 94
 
95
-		if( 'field' !== \GV\Utils::get( $atts, 'type' ) ) {
95
+		if ( 'field' !== \GV\Utils::get( $atts, 'type' ) ) {
96 96
 			return $label;
97 97
 		}
98 98
 
99
-		if( 'edit' === \GV\Utils::get( $atts, 'zone' ) ) {
99
+		if ( 'edit' === \GV\Utils::get( $atts, 'zone' ) ) {
100 100
 			return $label;
101 101
 		}
102 102
 
Please login to merge, or discard this patch.
future/includes/class-gv-utils.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @param string $name The key name (will be prefixed).
53 53
 	 * @param mixed $default The default value if not found (Default: null)
54 54
 	 *
55
-	 * @return mixed The value or $default if not found.
55
+	 * @return string The value or $default if not found.
56 56
 	 */
57 57
 	public static function _SERVER( $name, $default = null ) {
58 58
 		return self::get( $_SERVER, $name, $default );
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 *
127 127
 	 * @param mixed $value The value to return from the closure.
128 128
 	 *
129
-	 * @return Closure The closure with the $value bound.
129
+	 * @return \Closure The closure with the $value bound.
130 130
 	 */
131 131
 	public static function _return( $value ) {
132 132
 		return function() use ( $value ) { return $value; };
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 		 * Try subkeys after split.
92 92
 		 */
93 93
 		if ( count( $parts = explode( '/', $key, 2 ) ) > 1 ) {
94
-			return self::get( self::get( $array, $parts[0] ), $parts[1], $default );
94
+			return self::get( self::get( $array, $parts[ 0 ] ), $parts[ 1 ], $default );
95 95
 		}
96 96
 
97 97
 		return $default;
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	public static function gf_query_debug( $query ) {
146 146
 		$introspect = $query->_introspect();
147 147
 		return array(
148
-			'where' => $query->_where_unwrap( $introspect['where'] )
148
+			'where' => $query->_where_unwrap( $introspect[ 'where' ] )
149 149
 		);
150 150
 	}
151 151
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 		if ( $condition->expressions ) {
159 159
 			$conditions = array();
160 160
 			foreach ( $condition->expressions as $expression ) {
161
-				$conditions[] = self::gf_query_strip_condition_column_aliases( $expression );
161
+				$conditions[ ] = self::gf_query_strip_condition_column_aliases( $expression );
162 162
 			}
163 163
 			return call_user_func_array(
164 164
 				array( '\GF_Query_Condition', $condition->operator == 'AND' ? '_and' : '_or' ),
Please login to merge, or discard this patch.