Completed
Pull Request — develop (#1577)
by Zack
31:56 queued 11:58
created
includes/fields/class-gravityview-field-list.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@  discard block
 block discarded – undo
53 53
 	 * Columns are able to be added to View layouts, but not separately searched!
54 54
 	 *
55 55
 	 * @param array $fields
56
-	 * @param int $form_id
57 56
 	 *
58 57
 	 * @return array
59 58
 	 */
@@ -133,7 +132,7 @@  discard block
 block discarded – undo
133 132
 	 *
134 133
 	 * @param GF_Field_List $field Gravity Forms field
135 134
 	 * @param string|array $field_value Serialized or unserialized array value for the field
136
-	 * @param int|string $column_id The numeric key of the column (0-index) or the label of the column
135
+	 * @param integer $column_id The numeric key of the column (0-index) or the label of the column
137 136
 	 * @param string $format If set to 'raw', return an array of values for the column. Otherwise, allow Gravity Forms to render using `html` or `text`
138 137
 	 *
139 138
 	 * @return array|string|null Returns null if the $field_value passed wasn't an array or serialized array
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	public function remove_columns_from_searchable_fields( $fields ) {
61 61
 
62 62
 		foreach ( $fields as $key => $field ) {
63
-			if ( isset( $field['parent'] ) && $field['parent'] instanceof \GF_Field_List ) {
63
+			if ( isset( $field[ 'parent' ] ) && $field[ 'parent' ] instanceof \GF_Field_List ) {
64 64
 				unset( $fields[ $key ] );
65 65
 			}
66 66
 		}
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 		// Add the list columns
87 87
 		foreach ( $list_fields as $list_field ) {
88 88
 
89
-			if( empty( $list_field->enableColumns ) ) {
89
+			if ( empty( $list_field->enableColumns ) ) {
90 90
 				continue;
91 91
 			}
92 92
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 			}
108 108
 
109 109
 			// If there are columns, add them under the parent field
110
-			if( ! empty( $list_columns ) ) {
110
+			if ( ! empty( $list_columns ) ) {
111 111
 
112 112
 				$index = array_search( $list_field->id, array_keys( $fields ) ) + 1;
113 113
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 				 * Merge the $list_columns into the $fields array at $index
116 116
 				 * @see https://stackoverflow.com/a/1783125
117 117
 				 */
118
-				$fields = array_slice( $fields, 0, $index, true) + $list_columns + array_slice( $fields, $index, null, true);
118
+				$fields = array_slice( $fields, 0, $index, true ) + $list_columns + array_slice( $fields, $index, null, true );
119 119
 			}
120 120
 
121 121
 			unset( $list_columns, $index, $input_id );
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
 		$list_rows = maybe_unserialize( $field_value );
144 144
 
145
-		if( ! is_array( $list_rows ) ) {
145
+		if ( ! is_array( $list_rows ) ) {
146 146
 			gravityview()->log->error( '$field_value did not unserialize', array( 'data' => $field_value ) );
147 147
 			return null;
148 148
 		}
@@ -152,18 +152,18 @@  discard block
 block discarded – undo
152 152
 		// Each list row
153 153
 		foreach ( $list_rows as $list_row ) {
154 154
 			$current_column = 0;
155
-			foreach ( (array) $list_row as $column_key => $column_value ) {
155
+			foreach ( (array)$list_row as $column_key => $column_value ) {
156 156
 
157 157
 				// If the label of the column matches $column_id, or the numeric key value matches, add the value
158
-				if( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
-					$column_values[] = $column_value;
158
+				if ( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
+					$column_values[ ] = $column_value;
160 160
 				}
161 161
 				$current_column++;
162 162
 			}
163 163
 		}
164 164
 
165 165
 		// Return the array of values
166
-		if( 'raw' === $format ) {
166
+		if ( 'raw' === $format ) {
167 167
 			return $column_values;
168 168
 		}
169 169
 		// Return the Gravity Forms Field output
@@ -186,22 +186,22 @@  discard block
 block discarded – undo
186 186
 	 */
187 187
 	public function _filter_field_label( $label, $field, $form, $entry ) {
188 188
 
189
-		$field_object = RGFormsModel::get_field( $form, $field['id'] );
189
+		$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
190 190
 
191 191
 		// Not a list field
192
-		if( ! $field_object || 'list' !== $field_object->type ) {
192
+		if ( ! $field_object || 'list' !== $field_object->type ) {
193 193
 			return $label;
194 194
 		}
195 195
 
196 196
 		// Custom label is defined, so use it
197
-		if( ! empty( $field['custom_label'] ) ) {
197
+		if ( ! empty( $field[ 'custom_label' ] ) ) {
198 198
 			return $label;
199 199
 		}
200 200
 
201
-		$column_id = gravityview_get_input_id_from_id( $field['id'] );
201
+		$column_id = gravityview_get_input_id_from_id( $field[ 'id' ] );
202 202
 
203 203
 		// Parent field, not column field
204
-		if( false === $column_id ) {
204
+		if ( false === $column_id ) {
205 205
 			return $label;
206 206
 		}
207 207
 
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	public static function get_column_label( GF_Field_List $field, $column_id, $backup_label = '' ) {
223 223
 
224 224
 		// Doesn't have columns enabled
225
-		if( ! isset( $field->choices ) || ! $field->enableColumns ) {
225
+		if ( ! isset( $field->choices ) || ! $field->enableColumns ) {
226 226
 			return $backup_label;
227 227
 		}
228 228
 
Please login to merge, or discard this patch.
includes/widgets/search-widget/class-search-widget.php 3 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -603,7 +603,8 @@  discard block
 block discarded – undo
603 603
 				// Fast-forward 24 hour on the end time
604 604
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
605 605
 				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
606
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
606
+				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) {
607
+// See https://github.com/gravityview/GravityView/issues/1056
607 608
 					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
608 609
 				}
609 610
 			}
@@ -874,7 +875,7 @@  discard block
 block discarded – undo
874 875
 			'ymd_dot' => 'Y.m.d',
875 876
 		);
876 877
 
877
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
878
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
878 879
 			$format = $datepicker[ $field->dateFormat ];
879 880
 		}
880 881
 
Please login to merge, or discard this patch.
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 	/**
247 247
 	 * Add admin script to the no-conflict scripts whitelist
248 248
 	 * @param array $allowed Scripts allowed in no-conflict mode
249
-	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
249
+	 * @return string[] Scripts allowed in no-conflict mode, plus the search widget script
250 250
 	 */
251 251
 	public function register_no_conflict( $allowed ) {
252 252
 		$allowed[] = 'gravityview_searchwidget_admin';
@@ -420,6 +420,7 @@  discard block
 block discarded – undo
420 420
 	 * Display hidden fields to add support for sites using Default permalink structure
421 421
 	 *
422 422
 	 * @since 1.8
423
+	 * @param GravityView_Widget_Search $object
423 424
 	 * @return array Search fields, modified if not using permalinks
424 425
 	 */
425 426
 	public function add_no_permalink_fields( $search_fields, $object, $widget_args = array() ) {
@@ -729,7 +730,6 @@  discard block
 block discarded – undo
729 730
 	 * Dropin for the legacy flat filters when \GF_Query is available.
730 731
 	 *
731 732
 	 * @param \GF_Query $query The current query object reference
732
-	 * @param \GV\View $this The current view object
733 733
 	 * @param \GV\Request $request The request object
734 734
 	 */
735 735
 	public function gf_query_filter( &$query, $view, $request ) {
@@ -1428,7 +1428,7 @@  discard block
 block discarded – undo
1428 1428
 	/**
1429 1429
 	 * Get the label for a search form field
1430 1430
 	 * @param  array $field      Field setting as sent by the GV configuration - has `field`, `input` (input type), and `label` keys
1431
-	 * @param  array $form_field Form field data, as fetched by `gravityview_get_field()`
1431
+	 * @param  GF_Field|null $form_field Form field data, as fetched by `gravityview_get_field()`
1432 1432
 	 * @return string             Label for the search form
1433 1433
 	 */
1434 1434
 	private static function get_field_label( $field, $form_field = array() ) {
@@ -1486,7 +1486,7 @@  discard block
 block discarded – undo
1486 1486
 	 * @param array $field
1487 1487
 	 * @param \GV\Context $context
1488 1488
 	 *
1489
-	 * @return array
1489
+	 * @return GV\View
1490 1490
 	 */
1491 1491
 	private function get_search_filter_details( $field, $context ) {
1492 1492
 
@@ -1634,7 +1634,7 @@  discard block
 block discarded – undo
1634 1634
 	/**
1635 1635
 	 * Require the datepicker script for the frontend GV script
1636 1636
 	 * @param array $js_dependencies Array of existing required scripts for the fe-views.js script
1637
-	 * @return array Array required scripts, with `jquery-ui-datepicker` added
1637
+	 * @return string[] Array required scripts, with `jquery-ui-datepicker` added
1638 1638
 	 */
1639 1639
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1640 1640
 
@@ -1646,7 +1646,7 @@  discard block
 block discarded – undo
1646 1646
 	/**
1647 1647
 	 * Modify the array passed to wp_localize_script()
1648 1648
 	 *
1649
-	 * @param array $js_localization The data padded to the Javascript file
1649
+	 * @param array $localizations The data padded to the Javascript file
1650 1650
 	 * @param array $view_data View data array with View settings
1651 1651
 	 *
1652 1652
 	 * @return array
@@ -1826,7 +1826,7 @@  discard block
 block discarded – undo
1826 1826
 	 *
1827 1827
 	 * @param array  $get     Where to look for the operator.
1828 1828
 	 * @param string $key     The filter key to look for.
1829
-	 * @param array  $allowed The allowed operators (whitelist).
1829
+	 * @param string[]  $allowed The allowed operators (whitelist).
1830 1830
 	 * @param string $default The default operator.
1831 1831
 	 *
1832 1832
 	 * @return string The operator.
Please login to merge, or discard this patch.
Spacing   +184 added lines, -184 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 			'search_clear' => array(
55 55
 				'type'  => 'checkbox',
56 56
 				'label' => __( 'Show Clear button', 'gravityview' ),
57
-				'desc'  => __( 'When a search is performed, display a button that removes all search values.', 'gravityview'),
57
+				'desc'  => __( 'When a search is performed, display a button that removes all search values.', 'gravityview' ),
58 58
 				'value' => true,
59 59
 			),
60 60
 			'search_fields' => array(
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 				'type' => 'radio',
68 68
 				'full_width' => true,
69 69
 				'label' => esc_html__( 'Search Mode', 'gravityview' ),
70
-				'desc' => __('Should search results match all search fields, or any?', 'gravityview'),
70
+				'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),
71 71
 				'value' => 'any',
72 72
 				'class' => 'hide-if-js',
73 73
 				'options' => array(
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
 			// admin - add scripts - run at 1100 to make sure GravityView_Admin_Views::add_scripts_and_styles() runs first at 999
88 88
 			add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 1100 );
89
-			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts') );
89
+			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts' ) );
90 90
 			add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
91 91
 
92 92
 			// ajax - get the searchable fields
@@ -122,19 +122,19 @@  discard block
 block discarded – undo
122 122
 	 */
123 123
 	public function add_reserved_args( $args ) {
124 124
 
125
-		$args[] = 'gv_search';
126
-		$args[] = 'gv_start';
127
-		$args[] = 'gv_end';
128
-		$args[] = 'gv_id';
129
-		$args[] = 'gv_by';
130
-		$args[] = 'mode';
125
+		$args[ ] = 'gv_search';
126
+		$args[ ] = 'gv_start';
127
+		$args[ ] = 'gv_end';
128
+		$args[ ] = 'gv_id';
129
+		$args[ ] = 'gv_by';
130
+		$args[ ] = 'mode';
131 131
 
132
-		$get = (array) $_GET;
132
+		$get = (array)$_GET;
133 133
 
134 134
 		// If the fields being searched as reserved; not to be considered user-passed variables
135 135
 		foreach ( $get as $key => $value ) {
136 136
 			if ( $key !== $this->convert_request_key_to_filter_key( $key ) ) {
137
-				$args[] = $key;
137
+				$args[ ] = $key;
138 138
 			}
139 139
 		}
140 140
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 		$script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
259 259
 		$script_source = empty( $script_min ) ? '/source' : '';
260 260
 
261
-		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
261
+		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
262 262
 
263 263
 		wp_localize_script( 'gravityview_searchwidget_admin', 'gvSearchVar', array(
264 264
 			'nonce' => wp_create_nonce( 'gravityview_ajaxsearchwidget' ),
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
281 281
 	 */
282 282
 	public function register_no_conflict( $allowed ) {
283
-		$allowed[] = 'gravityview_searchwidget_admin';
283
+		$allowed[ ] = 'gravityview_searchwidget_admin';
284 284
 		return $allowed;
285 285
 	}
286 286
 
@@ -292,24 +292,24 @@  discard block
 block discarded – undo
292 292
 	 */
293 293
 	public static function get_searchable_fields() {
294 294
 
295
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) {
295
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) {
296 296
 			exit( '0' );
297 297
 		}
298 298
 
299 299
 		$form = '';
300 300
 
301 301
 		// Fetch the form for the current View
302
-		if ( ! empty( $_POST['view_id'] ) ) {
302
+		if ( ! empty( $_POST[ 'view_id' ] ) ) {
303 303
 
304
-			$form = gravityview_get_form_id( $_POST['view_id'] );
304
+			$form = gravityview_get_form_id( $_POST[ 'view_id' ] );
305 305
 
306
-		} elseif ( ! empty( $_POST['formid'] ) ) {
306
+		} elseif ( ! empty( $_POST[ 'formid' ] ) ) {
307 307
 
308
-			$form = (int) $_POST['formid'];
308
+			$form = (int)$_POST[ 'formid' ];
309 309
 
310
-		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) {
310
+		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) {
311 311
 
312
-			$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
312
+			$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
313 313
 
314 314
 		}
315 315
 
@@ -359,14 +359,14 @@  discard block
 block discarded – undo
359 359
 		);
360 360
 
361 361
 		if ( gravityview()->plugin->supports( \GV\Plugin::FEATURE_GFQUERY ) ) {
362
-			$custom_fields['is_approved'] = array(
362
+			$custom_fields[ 'is_approved' ] = array(
363 363
 				'text' => esc_html__( 'Approval Status', 'gravityview' ),
364 364
 				'type' => 'multi',
365 365
 			);
366 366
 		}
367 367
 
368
-		foreach( $custom_fields as $custom_field_key => $custom_field ) {
369
-			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] );
368
+		foreach ( $custom_fields as $custom_field_key => $custom_field ) {
369
+			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );
370 370
 		}
371 371
 
372 372
 		// Get fields with sub-inputs and no parent
@@ -388,13 +388,13 @@  discard block
 block discarded – undo
388 388
 
389 389
 			foreach ( $fields as $id => $field ) {
390 390
 
391
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
391
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
392 392
 					continue;
393 393
 				}
394 394
 
395
-				$types = self::get_search_input_types( $id, $field['type'] );
395
+				$types = self::get_search_input_types( $id, $field[ 'type' ] );
396 396
 
397
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';
397
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';
398 398
 			}
399 399
 		}
400 400
 
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
 	public static function get_search_input_types( $field_id = '', $field_type = null ) {
418 418
 
419 419
 		// @todo - This needs to be improved - many fields have . including products and addresses
420
-		if ( false !== strpos( (string) $field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
420
+		if ( false !== strpos( (string)$field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
421 421
 			$input_type = 'boolean'; // on/off checkbox
422 422
 		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) {
423 423
 			$input_type = 'multi'; //multiselect
@@ -463,19 +463,19 @@  discard block
 block discarded – undo
463 463
 			$post_id = 0;
464 464
 
465 465
 			// We're in the WordPress Widget context, and an overriding post ID has been set.
466
-			if ( ! empty( $widget_args['post_id'] ) ) {
467
-				$post_id = absint( $widget_args['post_id'] );
466
+			if ( ! empty( $widget_args[ 'post_id' ] ) ) {
467
+				$post_id = absint( $widget_args[ 'post_id' ] );
468 468
 			}
469 469
 			// We're in the WordPress Widget context, and the base View ID should be used
470
-			else if ( ! empty( $widget_args['view_id'] ) ) {
471
-				$post_id = absint( $widget_args['view_id'] );
470
+			else if ( ! empty( $widget_args[ 'view_id' ] ) ) {
471
+				$post_id = absint( $widget_args[ 'view_id' ] );
472 472
 			}
473 473
 
474 474
 			$args = gravityview_get_permalink_query_args( $post_id );
475 475
 
476 476
 			// Add hidden fields to the search form
477 477
 			foreach ( $args as $key => $value ) {
478
-				$search_fields[] = array(
478
+				$search_fields[ ] = array(
479 479
 					'name'  => $key,
480 480
 					'input' => 'hidden',
481 481
 					'value' => $value,
@@ -514,28 +514,28 @@  discard block
 block discarded – undo
514 514
 		/**
515 515
 		 * Include the sidebar Widgets.
516 516
 		 */
517
-		$widgets = (array) get_option( 'widget_gravityview_search', array() );
517
+		$widgets = (array)get_option( 'widget_gravityview_search', array() );
518 518
 
519 519
 		foreach ( $widgets as $widget ) {
520
-			if ( ! empty( $widget['view_id'] ) && $widget['view_id'] == $view->ID ) {
521
-				if( $_fields = json_decode( $widget['search_fields'], true ) ) {
520
+			if ( ! empty( $widget[ 'view_id' ] ) && $widget[ 'view_id' ] == $view->ID ) {
521
+				if ( $_fields = json_decode( $widget[ 'search_fields' ], true ) ) {
522 522
 					foreach ( $_fields as $field ) {
523
-						if ( empty( $field['form_id'] ) ) {
524
-							$field['form_id'] = $view->form ? $view->form->ID : 0;
523
+						if ( empty( $field[ 'form_id' ] ) ) {
524
+							$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
525 525
 						}
526
-						$searchable_fields[] = $with_full_field ? $field : $field['field'];
526
+						$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
527 527
 					}
528 528
 				}
529 529
 			}
530 530
 		}
531 531
 
532 532
 		foreach ( $view->widgets->by_id( $this->get_widget_id() )->all() as $widget ) {
533
-			if( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
533
+			if ( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
534 534
 				foreach ( $_fields as $field ) {
535
-					if ( empty( $field['form_id'] ) ) {
536
-						$field['form_id'] = $view->form ? $view->form->ID : 0;
535
+					if ( empty( $field[ 'form_id' ] ) ) {
536
+						$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
537 537
 					}
538
-					$searchable_fields[] = $with_full_field ? $field : $field['field'];
538
+					$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
539 539
 				}
540 540
 			}
541 541
 		}
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
 			return $search_criteria; // Return the original criteria, GF_Query modification kicks in later
574 574
 		}
575 575
 
576
-		if( 'post' === $this->search_method ) {
576
+		if ( 'post' === $this->search_method ) {
577 577
 			$get = $_POST;
578 578
 		} else {
579 579
 			$get = $_GET;
@@ -592,7 +592,7 @@  discard block
 block discarded – undo
592 592
 		$get = gv_map_deep( $get, 'rawurldecode' );
593 593
 
594 594
 		// Make sure array key is set up
595
-		$search_criteria['field_filters'] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
595
+		$search_criteria[ 'field_filters' ] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
596 596
 
597 597
 		$searchable_fields = $this->get_view_searchable_fields( $view );
598 598
 		$searchable_field_objects = $this->get_view_searchable_fields( $view, true );
@@ -612,9 +612,9 @@  discard block
 block discarded – undo
612 612
 		$trim_search_value = apply_filters( 'gravityview/search-trim-input', true );
613 613
 
614 614
 		// add free search
615
-		if ( isset( $get['gv_search'] ) && '' !== $get['gv_search'] && in_array( 'search_all', $searchable_fields ) ) {
615
+		if ( isset( $get[ 'gv_search' ] ) && '' !== $get[ 'gv_search' ] && in_array( 'search_all', $searchable_fields ) ) {
616 616
 
617
-			$search_all_value = $trim_search_value ? trim( $get['gv_search'] ) : $get['gv_search'];
617
+			$search_all_value = $trim_search_value ? trim( $get[ 'gv_search' ] ) : $get[ 'gv_search' ];
618 618
 
619 619
 			if ( $split_words ) {
620 620
 				// Search for a piece
@@ -630,7 +630,7 @@  discard block
 block discarded – undo
630 630
 			}
631 631
 
632 632
 			foreach ( $words as $word ) {
633
-				$search_criteria['field_filters'][] = array(
633
+				$search_criteria[ 'field_filters' ][ ] = array(
634 634
 					'key' => null, // The field ID to search
635 635
 					'value' => $word, // The value to search
636 636
 					'operator' => 'contains', // What to search in. Options: `is` or `contains`
@@ -643,14 +643,14 @@  discard block
 block discarded – undo
643 643
 			/**
644 644
 			 * Get and normalize the dates according to the input format.
645 645
 			 */
646
-			if ( $curr_start = ! empty( $get['gv_start'] ) ? $get['gv_start'] : '' ) {
647
-				if( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
646
+			if ( $curr_start = ! empty( $get[ 'gv_start' ] ) ? $get[ 'gv_start' ] : '' ) {
647
+				if ( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
648 648
 					$curr_start = $curr_start_date->format( 'Y-m-d' );
649 649
 				}
650 650
 			}
651 651
 
652
-			if ( $curr_end = ! empty( $get['gv_start'] ) ? ( ! empty( $get['gv_end'] ) ? $get['gv_end'] : '' ) : '' ) {
653
-				if( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
652
+			if ( $curr_end = ! empty( $get[ 'gv_start' ] ) ? ( ! empty( $get[ 'gv_end' ] ) ? $get[ 'gv_end' ] : '' ) : '' ) {
653
+				if ( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
654 654
 					$curr_end = $curr_end_date->format( 'Y-m-d' );
655 655
 				}
656 656
 			}
@@ -686,22 +686,22 @@  discard block
 block discarded – undo
686 686
 			 */
687 687
 			if ( ! empty( $curr_start ) ) {
688 688
 				$curr_start = date( 'Y-m-d H:i:s', strtotime( $curr_start ) );
689
-				$search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
689
+				$search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
690 690
 			}
691 691
 
692 692
 			if ( ! empty( $curr_end ) ) {
693 693
 				// Fast-forward 24 hour on the end time
694 694
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
695
-				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
696
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
697
-					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
695
+				$search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
696
+				if ( strpos( $search_criteria[ 'end_date' ], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
697
+					$search_criteria[ 'end_date' ] = date( 'Y-m-d H:i:s', strtotime( $search_criteria[ 'end_date' ] ) - 1 );
698 698
 				}
699 699
 			}
700 700
 		}
701 701
 
702 702
 		// search for a specific entry ID
703 703
 		if ( ! empty( $get[ 'gv_id' ] ) && in_array( 'entry_id', $searchable_fields ) ) {
704
-			$search_criteria['field_filters'][] = array(
704
+			$search_criteria[ 'field_filters' ][ ] = array(
705 705
 				'key' => 'id',
706 706
 				'value' => absint( $get[ 'gv_id' ] ),
707 707
 				'operator' => $this->get_operator( $get, 'gv_id', array( '=' ), '=' ),
@@ -710,15 +710,15 @@  discard block
 block discarded – undo
710 710
 
711 711
 		// search for a specific Created_by ID
712 712
 		if ( ! empty( $get[ 'gv_by' ] ) && in_array( 'created_by', $searchable_fields ) ) {
713
-			$search_criteria['field_filters'][] = array(
713
+			$search_criteria[ 'field_filters' ][ ] = array(
714 714
 				'key' => 'created_by',
715
-				'value' => $get['gv_by'],
715
+				'value' => $get[ 'gv_by' ],
716 716
 				'operator' => $this->get_operator( $get, 'gv_by', array( '=' ), '=' ),
717 717
 			);
718 718
 		}
719 719
 
720 720
 		// Get search mode passed in URL
721
-		$mode = isset( $get['mode'] ) && in_array( $get['mode'], array( 'any', 'all' ) ) ?  $get['mode'] : 'any';
721
+		$mode = isset( $get[ 'mode' ] ) && in_array( $get[ 'mode' ], array( 'any', 'all' ) ) ? $get[ 'mode' ] : 'any';
722 722
 
723 723
 		// get the other search filters
724 724
 		foreach ( $get as $key => $value ) {
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
 				$value = is_array( $value ) ? array_map( 'trim', $value ) : trim( $value );
728 728
 			}
729 729
 
730
-			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[0], false, false ) ) ) {
730
+			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[ 0 ], false, false ) ) ) {
731 731
 				continue; // Not a filter, or empty
732 732
 			}
733 733
 
@@ -741,21 +741,21 @@  discard block
 block discarded – undo
741 741
 				continue;
742 742
 			}
743 743
 
744
-			if ( ! isset( $filter['operator'] ) ) {
745
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
744
+			if ( ! isset( $filter[ 'operator' ] ) ) {
745
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
746 746
 			}
747 747
 
748
-			if ( isset( $filter[0]['value'] ) ) {
749
-				$filter[0]['value'] = $trim_search_value ? trim( $filter[0]['value'] ) : $filter[0]['value'];
748
+			if ( isset( $filter[ 0 ][ 'value' ] ) ) {
749
+				$filter[ 0 ][ 'value' ] = $trim_search_value ? trim( $filter[ 0 ][ 'value' ] ) : $filter[ 0 ][ 'value' ];
750 750
 
751
-				$search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );
751
+				$search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );
752 752
 
753 753
 				// if date range type, set search mode to ALL
754
-				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>=', '<=', '>', '<' ) ) ) {
754
+				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>=', '<=', '>', '<' ) ) ) {
755 755
 					$mode = 'all';
756 756
 				}
757
-			} elseif( !empty( $filter ) ) {
758
-				$search_criteria['field_filters'][] = $filter;
757
+			} elseif ( ! empty( $filter ) ) {
758
+				$search_criteria[ 'field_filters' ][ ] = $filter;
759 759
 			}
760 760
 		}
761 761
 
@@ -764,7 +764,7 @@  discard block
 block discarded – undo
764 764
 		 * @since 1.5.1
765 765
 		 * @param[out,in] string $mode Search mode (`any` vs `all`)
766 766
 		 */
767
-		$search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );
767
+		$search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );
768 768
 
769 769
 		gravityview()->log->debug( 'Returned Search Criteria: ', array( 'data' => $search_criteria ) );
770 770
 
@@ -798,19 +798,19 @@  discard block
 block discarded – undo
798 798
 
799 799
 		$query_class = $view->get_query_class();
800 800
 
801
-		if ( empty( $search_criteria['field_filters'] ) ) {
801
+		if ( empty( $search_criteria[ 'field_filters' ] ) ) {
802 802
 			return;
803 803
 		}
804 804
 
805 805
 		$widgets = $view->widgets->by_id( $this->widget_id );
806 806
 		if ( $widgets->count() ) {
807 807
 			$widgets = $widgets->all();
808
-			$widget  = $widgets[0];
808
+			$widget  = $widgets[ 0 ];
809 809
 
810 810
 			$search_fields = json_decode( $widget->configuration->get( 'search_fields' ), true );
811 811
 
812
-			foreach ( (array) $search_fields as $search_field ) {
813
-				if ( 'created_by' === $search_field['field'] && 'input_text' === $search_field['input'] ) {
812
+			foreach ( (array)$search_fields as $search_field ) {
813
+				if ( 'created_by' === $search_field[ 'field' ] && 'input_text' === $search_field[ 'input' ] ) {
814 814
 					$created_by_text_mode = true;
815 815
 				}
816 816
 			}
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 		$extra_conditions = array();
820 820
 		$mode = 'any';
821 821
 
822
-		foreach ( $search_criteria['field_filters'] as &$filter ) {
822
+		foreach ( $search_criteria[ 'field_filters' ] as &$filter ) {
823 823
 			if ( ! is_array( $filter ) ) {
824 824
 				if ( in_array( strtolower( $filter ), array( 'any', 'all' ) ) ) {
825 825
 					$mode = $filter;
@@ -828,13 +828,13 @@  discard block
 block discarded – undo
828 828
 			}
829 829
 
830 830
 			// Construct a manual query for unapproved statuses
831
-			if ( 'is_approved' === $filter['key'] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array) $filter['value'] ) ) {
832
-				$_tmp_query       = new $query_class( $view->form->ID, array(
831
+			if ( 'is_approved' === $filter[ 'key' ] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array)$filter[ 'value' ] ) ) {
832
+				$_tmp_query = new $query_class( $view->form->ID, array(
833 833
 					'field_filters' => array(
834 834
 						array(
835 835
 							'operator' => 'in',
836 836
 							'key'      => 'is_approved',
837
-							'value'    => (array) $filter['value'],
837
+							'value'    => (array)$filter[ 'value' ],
838 838
 						),
839 839
 						array(
840 840
 							'operator' => 'is',
@@ -846,30 +846,30 @@  discard block
 block discarded – undo
846 846
 				) );
847 847
 				$_tmp_query_parts = $_tmp_query->_introspect();
848 848
 
849
-				$extra_conditions[] = $_tmp_query_parts['where'];
849
+				$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
850 850
 
851 851
 				$filter = false;
852 852
 				continue;
853 853
 			}
854 854
 
855 855
 			// Construct manual query for text mode creator search
856
-			if ( 'created_by' === $filter['key'] && ! empty( $created_by_text_mode ) ) {
857
-				$extra_conditions[] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
856
+			if ( 'created_by' === $filter[ 'key' ] && ! empty( $created_by_text_mode ) ) {
857
+				$extra_conditions[ ] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
858 858
 				$filter = false;
859 859
 				continue;
860 860
 			}
861 861
 
862 862
 			// By default, we want searches to be wildcard for each field.
863
-			$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
863
+			$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
864 864
 
865 865
 			// For multichoice, let's have an in (OR) search.
866
-			if ( is_array( $filter['value'] ) ) {
867
-				$filter['operator'] = 'in'; // @todo what about in contains (OR LIKE chains)?
866
+			if ( is_array( $filter[ 'value' ] ) ) {
867
+				$filter[ 'operator' ] = 'in'; // @todo what about in contains (OR LIKE chains)?
868 868
 			}
869 869
 
870 870
 			// Default form with joins functionality
871
-			if ( empty( $filter['form_id'] ) ) {
872
-				$filter['form_id'] = $view->form ? $view->form->ID : 0;
871
+			if ( empty( $filter[ 'form_id' ] ) ) {
872
+				$filter[ 'form_id' ] = $view->form ? $view->form->ID : 0;
873 873
 			}
874 874
 
875 875
 			/**
@@ -879,28 +879,28 @@  discard block
 block discarded – undo
879 879
 			 * @since develop
880 880
 			 * @param \GV\View $view The View we're operating on.
881 881
 			 */
882
-			$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter, $view );
882
+			$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter, $view );
883 883
 		}
884 884
 
885
-		if ( ! empty( $search_criteria['start_date'] ) || ! empty( $search_criteria['end_date'] ) ) {
885
+		if ( ! empty( $search_criteria[ 'start_date' ] ) || ! empty( $search_criteria[ 'end_date' ] ) ) {
886 886
 			$date_criteria = array();
887 887
 
888
-			if ( isset( $search_criteria['start_date'] ) ) {
889
-				$date_criteria['start_date'] = $search_criteria['start_date'];
888
+			if ( isset( $search_criteria[ 'start_date' ] ) ) {
889
+				$date_criteria[ 'start_date' ] = $search_criteria[ 'start_date' ];
890 890
 			}
891 891
 
892
-			if ( isset( $search_criteria['end_date'] ) ) {
893
-				$date_criteria['end_date'] = $search_criteria['end_date'];
892
+			if ( isset( $search_criteria[ 'end_date' ] ) ) {
893
+				$date_criteria[ 'end_date' ] = $search_criteria[ 'end_date' ];
894 894
 			}
895 895
 
896 896
 			$_tmp_query         = new $query_class( $view->form->ID, $date_criteria );
897 897
 			$_tmp_query_parts   = $_tmp_query->_introspect();
898
-			$extra_conditions[] = $_tmp_query_parts['where'];
898
+			$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
899 899
 		}
900 900
 
901 901
 		$search_conditions = array();
902 902
 
903
-		if ( $filters = array_filter( $search_criteria['field_filters'] ) ) {
903
+		if ( $filters = array_filter( $search_criteria[ 'field_filters' ] ) ) {
904 904
 			foreach ( $filters as &$filter ) {
905 905
 				if ( ! is_array( $filter ) ) {
906 906
 					continue;
@@ -912,12 +912,12 @@  discard block
 block discarded – undo
912 912
 				 * code by reusing what's inside GF_Query already as they
913 913
 				 * take care of many small things like forcing numeric, etc.
914 914
 				 */
915
-				$_tmp_query       = new $query_class( $filter['form_id'], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
915
+				$_tmp_query       = new $query_class( $filter[ 'form_id' ], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
916 916
 				$_tmp_query_parts = $_tmp_query->_introspect();
917
-				$search_condition = $_tmp_query_parts['where'];
917
+				$search_condition = $_tmp_query_parts[ 'where' ];
918 918
 
919
-				if ( empty( $filter['key'] ) && $search_condition->expressions ) {
920
-					$search_conditions[] = $search_condition;
919
+				if ( empty( $filter[ 'key' ] ) && $search_condition->expressions ) {
920
+					$search_conditions[ ] = $search_condition;
921 921
 				} else {
922 922
 					$left = $search_condition->left;
923 923
 					$alias = $query->_alias( $left->field_id, $left->source, $left->is_entry_column() ? 't' : 'm' );
@@ -927,7 +927,7 @@  discard block
 block discarded – undo
927 927
 							$on = $_join->join_on;
928 928
 							$join = $_join->join;
929 929
 
930
-							$search_conditions[] = GF_Query_Condition::_or(
930
+							$search_conditions[ ] = GF_Query_Condition::_or(
931 931
 								// Join
932 932
 								new GF_Query_Condition(
933 933
 									new GF_Query_Column( GF_Query_Column::META, $join->ID, $query->_alias( GF_Query_Column::META, $join->ID, 'm' ) ),
@@ -943,7 +943,7 @@  discard block
 block discarded – undo
943 943
 							);
944 944
 						}
945 945
 					} else {
946
-						$search_conditions[] = new GF_Query_Condition(
946
+						$search_conditions[ ] = new GF_Query_Condition(
947 947
 							new GF_Query_Column( $left->field_id, $left->source, $alias ),
948 948
 							$search_condition->operator,
949 949
 							$search_condition->right
@@ -965,7 +965,7 @@  discard block
 block discarded – undo
965 965
 		/**
966 966
 		 * Combine the parts as a new WHERE clause.
967 967
 		 */
968
-		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts['where'] ), $search_conditions, $extra_conditions ) );
968
+		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts[ 'where' ] ), $search_conditions, $extra_conditions ) );
969 969
 		$query->where( $where );
970 970
 	}
971 971
 
@@ -988,7 +988,7 @@  discard block
 block discarded – undo
988 988
 		$field_id = str_replace( 'filter_', '', $key );
989 989
 
990 990
 		// calculates field_id, removing 'filter_' and for '_' for advanced fields ( like name or checkbox )
991
-		if ( preg_match('/^[0-9_]+$/ism', $field_id ) ) {
991
+		if ( preg_match( '/^[0-9_]+$/ism', $field_id ) ) {
992 992
 			$field_id = str_replace( '_', '.', $field_id );
993 993
 		}
994 994
 
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
 			// form is in searchable fields
1046 1046
 			$found = false;
1047 1047
 			foreach ( $searchable_fields as $field ) {
1048
-				if ( $field_id == $field['field'] && $form->ID == $field['form_id'] ) {
1048
+				if ( $field_id == $field[ 'field' ] && $form->ID == $field[ 'form_id' ] ) {
1049 1049
 					$found = true;
1050 1050
 					break;
1051 1051
 				}
@@ -1085,7 +1085,7 @@  discard block
 block discarded – undo
1085 1085
 
1086 1086
 			case 'select':
1087 1087
 			case 'radio':
1088
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1088
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1089 1089
 				break;
1090 1090
 
1091 1091
 			case 'post_category':
@@ -1099,7 +1099,7 @@  discard block
 block discarded – undo
1099 1099
 
1100 1100
 				foreach ( $value as $val ) {
1101 1101
 					$cat = get_term( $val, 'category' );
1102
-					$filter[] = array(
1102
+					$filter[ ] = array(
1103 1103
 						'key'      => $field_id,
1104 1104
 						'value'    => esc_attr( $cat->name ) . ':' . $val,
1105 1105
 						'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1118,7 +1118,7 @@  discard block
 block discarded – undo
1118 1118
 				$filter = array();
1119 1119
 
1120 1120
 				foreach ( $value as $val ) {
1121
-					$filter[] = array( 'key' => $field_id, 'value' => $val );
1121
+					$filter[ ] = array( 'key' => $field_id, 'value' => $val );
1122 1122
 				}
1123 1123
 
1124 1124
 				break;
@@ -1127,9 +1127,9 @@  discard block
 block discarded – undo
1127 1127
 				// convert checkbox on/off into the correct search filter
1128 1128
 				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field->inputs ) && ! empty( $form_field->choices ) ) {
1129 1129
 					foreach ( $form_field->inputs as $k => $input ) {
1130
-						if ( $input['id'] == $field_id ) {
1131
-							$filter['value'] = $form_field->choices[ $k ]['value'];
1132
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1130
+						if ( $input[ 'id' ] == $field_id ) {
1131
+							$filter[ 'value' ] = $form_field->choices[ $k ][ 'value' ];
1132
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1133 1133
 							break;
1134 1134
 						}
1135 1135
 					}
@@ -1139,7 +1139,7 @@  discard block
 block discarded – undo
1139 1139
 					$filter = array();
1140 1140
 
1141 1141
 					foreach ( $value as $val ) {
1142
-						$filter[] = array(
1142
+						$filter[ ] = array(
1143 1143
 							'key'      => $field_id,
1144 1144
 							'value'    => $val,
1145 1145
 							'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1160,9 +1160,9 @@  discard block
 block discarded – undo
1160 1160
 					foreach ( $words as $word ) {
1161 1161
 						if ( ! empty( $word ) && strlen( $word ) > 1 ) {
1162 1162
 							// Keep the same key for each filter
1163
-							$filter['value'] = $word;
1163
+							$filter[ 'value' ] = $word;
1164 1164
 							// Add a search for the value
1165
-							$filters[] = $filter;
1165
+							$filters[ ] = $filter;
1166 1166
 						}
1167 1167
 					}
1168 1168
 
@@ -1176,19 +1176,19 @@  discard block
 block discarded – undo
1176 1176
 
1177 1177
 					foreach ( $searchable_fields as $searchable_field ) {
1178 1178
 
1179
-						if( $form_field->ID !== $searchable_field['field'] ) {
1179
+						if ( $form_field->ID !== $searchable_field[ 'field' ] ) {
1180 1180
 							continue;
1181 1181
 						}
1182 1182
 
1183 1183
 						// Only exact-match dropdowns, not text search
1184
-						if( in_array( $searchable_field['input'], array( 'text', 'search' ), true ) ) {
1184
+						if ( in_array( $searchable_field[ 'input' ], array( 'text', 'search' ), true ) ) {
1185 1185
 							continue;
1186 1186
 						}
1187 1187
 
1188 1188
 						$input_id = gravityview_get_input_id_from_id( $form_field->ID );
1189 1189
 
1190 1190
 						if ( 4 === $input_id ) {
1191
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1191
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1192 1192
 						};
1193 1193
 					}
1194 1194
 				}
@@ -1216,12 +1216,12 @@  discard block
 block discarded – undo
1216 1216
 						 * @since 1.16.3
1217 1217
 						 * Safeguard until GF implements '<=' operator
1218 1218
 						 */
1219
-						if( !GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1219
+						if ( ! GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1220 1220
 							$operator = '<';
1221 1221
 							$date = date( 'Y-m-d', strtotime( self::get_formatted_date( $date, 'Y-m-d', $date_format ) . ' +1 day' ) );
1222 1222
 						}
1223 1223
 
1224
-						$filter[] = array(
1224
+						$filter[ ] = array(
1225 1225
 							'key'      => $field_id,
1226 1226
 							'value'    => self::get_formatted_date( $date, 'Y-m-d', $date_format ),
1227 1227
 							'operator' => $this->get_operator( $get, $key, array( $operator ), $operator ),
@@ -1229,12 +1229,12 @@  discard block
 block discarded – undo
1229 1229
 					}
1230 1230
 				} else {
1231 1231
 					$date = $value;
1232
-					$filter['value'] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1233
-					$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1232
+					$filter[ 'value' ] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1233
+					$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1234 1234
 				}
1235 1235
 
1236
-				if ('payment_date' === $key) {
1237
-					$filter['operator'] = 'contains';
1236
+				if ( 'payment_date' === $key ) {
1237
+					$filter[ 'operator' ] = 'contains';
1238 1238
 				}
1239 1239
 
1240 1240
 				break;
@@ -1263,7 +1263,7 @@  discard block
 block discarded – undo
1263 1263
 			'ymd_dot' => 'Y.m.d',
1264 1264
 		);
1265 1265
 
1266
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
1266
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
1267 1267
 			$format = $datepicker[ $field->dateFormat ];
1268 1268
 		}
1269 1269
 
@@ -1300,7 +1300,7 @@  discard block
 block discarded – undo
1300 1300
 	public function add_template_path( $file_paths ) {
1301 1301
 
1302 1302
 		// Index 100 is the default GravityView template path.
1303
-		$file_paths[102] = self::$file . 'templates/';
1303
+		$file_paths[ 102 ] = self::$file . 'templates/';
1304 1304
 
1305 1305
 		return $file_paths;
1306 1306
 	}
@@ -1319,7 +1319,7 @@  discard block
 block discarded – undo
1319 1319
 		$has_date = false;
1320 1320
 
1321 1321
 		foreach ( $search_fields as $k => $field ) {
1322
-			if ( in_array( $field['input'], array( 'date', 'date_range', 'entry_date' ) ) ) {
1322
+			if ( in_array( $field[ 'input' ], array( 'date', 'date_range', 'entry_date' ) ) ) {
1323 1323
 				$has_date = true;
1324 1324
 				break;
1325 1325
 			}
@@ -1348,7 +1348,7 @@  discard block
 block discarded – undo
1348 1348
 		$view = \GV\View::by_id( $gravityview_view->view_id );
1349 1349
 
1350 1350
 		// get configured search fields
1351
-		$search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';
1351
+		$search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';
1352 1352
 
1353 1353
 		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) {
1354 1354
 			gravityview()->log->debug( 'No search fields configured for widget:', array( 'data' => $widget_args ) );
@@ -1362,40 +1362,40 @@  discard block
 block discarded – undo
1362 1362
 
1363 1363
 			$updated_field = $this->get_search_filter_details( $updated_field, $context );
1364 1364
 
1365
-			switch ( $field['field'] ) {
1365
+			switch ( $field[ 'field' ] ) {
1366 1366
 
1367 1367
 				case 'search_all':
1368
-					$updated_field['key'] = 'search_all';
1369
-					$updated_field['input'] = 'search_all';
1370
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_search' );
1368
+					$updated_field[ 'key' ] = 'search_all';
1369
+					$updated_field[ 'input' ] = 'search_all';
1370
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_search' );
1371 1371
 					break;
1372 1372
 
1373 1373
 				case 'entry_date':
1374
-					$updated_field['key'] = 'entry_date';
1375
-					$updated_field['input'] = 'entry_date';
1376
-					$updated_field['value'] = array(
1374
+					$updated_field[ 'key' ] = 'entry_date';
1375
+					$updated_field[ 'input' ] = 'entry_date';
1376
+					$updated_field[ 'value' ] = array(
1377 1377
 						'start' => $this->rgget_or_rgpost( 'gv_start' ),
1378 1378
 						'end' => $this->rgget_or_rgpost( 'gv_end' ),
1379 1379
 					);
1380 1380
 					break;
1381 1381
 
1382 1382
 				case 'entry_id':
1383
-					$updated_field['key'] = 'entry_id';
1384
-					$updated_field['input'] = 'entry_id';
1385
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_id' );
1383
+					$updated_field[ 'key' ] = 'entry_id';
1384
+					$updated_field[ 'input' ] = 'entry_id';
1385
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_id' );
1386 1386
 					break;
1387 1387
 
1388 1388
 				case 'created_by':
1389
-					$updated_field['key'] = 'created_by';
1390
-					$updated_field['name'] = 'gv_by';
1391
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_by' );
1392
-					$updated_field['choices'] = self::get_created_by_choices( $view );
1389
+					$updated_field[ 'key' ] = 'created_by';
1390
+					$updated_field[ 'name' ] = 'gv_by';
1391
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_by' );
1392
+					$updated_field[ 'choices' ] = self::get_created_by_choices( $view );
1393 1393
 					break;
1394 1394
 
1395 1395
 				case 'is_approved':
1396
-					$updated_field['key'] = 'is_approved';
1397
-					$updated_field['value'] = $this->rgget_or_rgpost( 'filter_is_approved' );
1398
-					$updated_field['choices'] = self::get_is_approved_choices();
1396
+					$updated_field[ 'key' ] = 'is_approved';
1397
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'filter_is_approved' );
1398
+					$updated_field[ 'choices' ] = self::get_is_approved_choices();
1399 1399
 					break;
1400 1400
 			}
1401 1401
 
@@ -1416,16 +1416,16 @@  discard block
 block discarded – undo
1416 1416
 
1417 1417
 		$gravityview_view->permalink_fields = $this->add_no_permalink_fields( array(), $this, $widget_args );
1418 1418
 
1419
-		$gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';
1419
+		$gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';
1420 1420
 
1421 1421
 		/** @since 1.14 */
1422
-		$gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';
1422
+		$gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';
1423 1423
 
1424
-		$custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';
1424
+		$custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';
1425 1425
 
1426 1426
 		$gravityview_view->search_class = self::get_search_class( $custom_class );
1427 1427
 
1428
-		$gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;
1428
+		$gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;
1429 1429
 
1430 1430
 		if ( $this->has_date_field( $search_fields ) ) {
1431 1431
 			// enqueue datepicker stuff only if needed!
@@ -1447,10 +1447,10 @@  discard block
 block discarded – undo
1447 1447
 	public static function get_search_class( $custom_class = '' ) {
1448 1448
 		$gravityview_view = GravityView_View::getInstance();
1449 1449
 
1450
-		$search_class = 'gv-search-'.$gravityview_view->search_layout;
1450
+		$search_class = 'gv-search-' . $gravityview_view->search_layout;
1451 1451
 
1452
-		if ( ! empty( $custom_class )  ) {
1453
-			$search_class .= ' '.$custom_class;
1452
+		if ( ! empty( $custom_class ) ) {
1453
+			$search_class .= ' ' . $custom_class;
1454 1454
 		}
1455 1455
 
1456 1456
 		/**
@@ -1501,9 +1501,9 @@  discard block
 block discarded – undo
1501 1501
 
1502 1502
 		if ( ! $label ) {
1503 1503
 
1504
-			$label = isset( $form_field['label'] ) ? $form_field['label'] : '';
1504
+			$label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';
1505 1505
 
1506
-			switch( $field['field'] ) {
1506
+			switch ( $field[ 'field' ] ) {
1507 1507
 				case 'search_all':
1508 1508
 					$label = __( 'Search Entries:', 'gravityview' );
1509 1509
 					break;
@@ -1515,10 +1515,10 @@  discard block
 block discarded – undo
1515 1515
 					break;
1516 1516
 				default:
1517 1517
 					// If this is a field input, not a field
1518
-					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) {
1518
+					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) {
1519 1519
 
1520 1520
 						// Get the label for the field in question, which returns an array
1521
-						$items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );
1521
+						$items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );
1522 1522
 
1523 1523
 						// Get the item with the `label` key
1524 1524
 						$values = wp_list_pluck( $items, 'label' );
@@ -1559,13 +1559,13 @@  discard block
 block discarded – undo
1559 1559
 		$form = $gravityview_view->getForm();
1560 1560
 
1561 1561
 		// for advanced field ids (eg, first name / last name )
1562
-		$name = 'filter_' . str_replace( '.', '_', $field['field'] );
1562
+		$name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );
1563 1563
 
1564 1564
 		// get searched value from $_GET/$_POST (string or array)
1565 1565
 		$value = $this->rgget_or_rgpost( $name );
1566 1566
 
1567 1567
 		// get form field details
1568
-		$form_field = gravityview_get_field( $form, $field['field'] );
1568
+		$form_field = gravityview_get_field( $form, $field[ 'field' ] );
1569 1569
 
1570 1570
 		$form_field_type = \GV\Utils::get( $form_field, 'type' );
1571 1571
 
@@ -1579,17 +1579,17 @@  discard block
 block discarded – undo
1579 1579
 		);
1580 1580
 
1581 1581
 		// collect choices
1582
-		if ( 'post_category' === $form_field_type && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) {
1583
-			$filter['choices'] = gravityview_get_terms_choices();
1584
-		} elseif ( ! empty( $form_field['choices'] ) ) {
1585
-			$filter['choices'] = $form_field['choices'];
1582
+		if ( 'post_category' === $form_field_type && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) {
1583
+			$filter[ 'choices' ] = gravityview_get_terms_choices();
1584
+		} elseif ( ! empty( $form_field[ 'choices' ] ) ) {
1585
+			$filter[ 'choices' ] = $form_field[ 'choices' ];
1586 1586
 		}
1587 1587
 
1588
-		if ( 'date_range' === $field['input'] && empty( $value ) ) {
1589
-			$filter['value'] = array( 'start' => '', 'end' => '' );
1588
+		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) {
1589
+			$filter[ 'value' ] = array( 'start' => '', 'end' => '' );
1590 1590
 		}
1591 1591
 
1592
-		if ( ! empty( $filter['choices'] ) ) {
1592
+		if ( ! empty( $filter[ 'choices' ] ) ) {
1593 1593
 			/**
1594 1594
 			 * @filter `gravityview/search/sieve_choices` Only output used choices for this field.
1595 1595
 			 * @param[in,out] bool Yes or no.
@@ -1597,7 +1597,7 @@  discard block
 block discarded – undo
1597 1597
 			 * @param \GV\Context The context.
1598 1598
 			 */
1599 1599
 			if ( apply_filters( 'gravityview/search/sieve_choices', false, $field, $context ) ) {
1600
-				$filter['choices'] = $this->sieve_filter_choices( $filter, $context );
1600
+				$filter[ 'choices' ] = $this->sieve_filter_choices( $filter, $context );
1601 1601
 			}
1602 1602
 		}
1603 1603
 
@@ -1626,11 +1626,11 @@  discard block
 block discarded – undo
1626 1626
 	 * @return array The filter choices.
1627 1627
 	 */
1628 1628
 	private function sieve_filter_choices( $filter, $context ) {
1629
-		if ( empty( $filter['key'] ) || empty( $filter['choices'] ) ) {
1629
+		if ( empty( $filter[ 'key' ] ) || empty( $filter[ 'choices' ] ) ) {
1630 1630
 			return $filter; // @todo Populate plugins might give us empty choices
1631 1631
 		}
1632 1632
 
1633
-		if ( ! is_numeric( $filter['key'] ) ) {
1633
+		if ( ! is_numeric( $filter[ 'key' ] ) ) {
1634 1634
 			return $filter;
1635 1635
 		}
1636 1636
 
@@ -1640,29 +1640,29 @@  discard block
 block discarded – undo
1640 1640
 
1641 1641
 		$table = GFFormsModel::get_entry_meta_table_name();
1642 1642
 
1643
-		$key_like = $wpdb->esc_like( $filter['key'] ) . '.%';
1643
+		$key_like = $wpdb->esc_like( $filter[ 'key' ] ) . '.%';
1644 1644
 
1645 1645
 		switch ( \GV\Utils::get( $filter, 'type' ) ):
1646 1646
 			case 'post_category':
1647 1647
 				$choices = $wpdb->get_col( $wpdb->prepare(
1648 1648
 					"SELECT DISTINCT SUBSTRING_INDEX(meta_value, ':', 1) FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1649
-					$key_like, $filter['key'], $form_id
1649
+					$key_like, $filter[ 'key' ], $form_id
1650 1650
 				) );
1651 1651
 				break;
1652 1652
 			default:
1653 1653
 				$choices = $wpdb->get_col( $wpdb->prepare(
1654 1654
 					"SELECT DISTINCT meta_value FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1655
-					$key_like, $filter['key'], $form_id
1655
+					$key_like, $filter[ 'key' ], $form_id
1656 1656
 				) );
1657 1657
 
1658
-				if ( ( $field = gravityview_get_field( $form_id, $filter['key'] ) ) && 'json' === $field->storageType ) {
1658
+				if ( ( $field = gravityview_get_field( $form_id, $filter[ 'key' ] ) ) && 'json' === $field->storageType ) {
1659 1659
 					$choices = array_map( 'json_decode', $choices );
1660 1660
 					$_choices_array = array();
1661 1661
 					foreach ( $choices as $choice ) {
1662 1662
 						if ( is_array( $choice ) ) {
1663 1663
 							$_choices_array = array_merge( $_choices_array, $choice );
1664 1664
 						} else {
1665
-							$_choices_array []= $choice;
1665
+							$_choices_array [ ] = $choice;
1666 1666
 						}
1667 1667
 					}
1668 1668
 					$choices = array_unique( $_choices_array );
@@ -1672,9 +1672,9 @@  discard block
 block discarded – undo
1672 1672
 		endswitch;
1673 1673
 
1674 1674
 		$filter_choices = array();
1675
-		foreach ( $filter['choices'] as $choice ) {
1676
-			if ( in_array( $choice['text'], $choices, true ) || in_array( $choice['value'], $choices, true ) ) {
1677
-				$filter_choices[] = $choice;
1675
+		foreach ( $filter[ 'choices' ] as $choice ) {
1676
+			if ( in_array( $choice[ 'text' ], $choices, true ) || in_array( $choice[ 'value' ], $choices, true ) ) {
1677
+				$filter_choices[ ] = $choice;
1678 1678
 			}
1679 1679
 		}
1680 1680
 
@@ -1709,7 +1709,7 @@  discard block
 block discarded – undo
1709 1709
 			 * @param \GV\View $view The view.
1710 1710
 			 */
1711 1711
 			$text = apply_filters( 'gravityview/search/created_by/text', $user->display_name, $user, $view );
1712
-			$choices[] = array(
1712
+			$choices[ ] = array(
1713 1713
 				'value' => $user->ID,
1714 1714
 				'text' => $text,
1715 1715
 			);
@@ -1729,9 +1729,9 @@  discard block
 block discarded – undo
1729 1729
 
1730 1730
 		$choices = array();
1731 1731
 		foreach ( GravityView_Entry_Approval_Status::get_all() as $status ) {
1732
-			$choices[] = array(
1733
-				'value' => $status['value'],
1734
-				'text' => $status['label'],
1732
+			$choices[ ] = array(
1733
+				'value' => $status[ 'value' ],
1734
+				'text' => $status[ 'label' ],
1735 1735
 			);
1736 1736
 		}
1737 1737
 
@@ -1783,7 +1783,7 @@  discard block
 block discarded – undo
1783 1783
 	 */
1784 1784
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1785 1785
 
1786
-		$js_dependencies[] = 'jquery-ui-datepicker';
1786
+		$js_dependencies[ ] = 'jquery-ui-datepicker';
1787 1787
 
1788 1788
 		return $js_dependencies;
1789 1789
 	}
@@ -1827,7 +1827,7 @@  discard block
 block discarded – undo
1827 1827
 			'isRTL'             => is_rtl(),
1828 1828
 		), $view_data );
1829 1829
 
1830
-		$localizations['datepicker'] = $datepicker_settings;
1830
+		$localizations[ 'datepicker' ] = $datepicker_settings;
1831 1831
 
1832 1832
 		return $localizations;
1833 1833
 
@@ -1854,7 +1854,7 @@  discard block
 block discarded – undo
1854 1854
 	 * @return void
1855 1855
 	 */
1856 1856
 	private function maybe_enqueue_flexibility() {
1857
-		if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && preg_match( '/MSIE [8-9]/', $_SERVER['HTTP_USER_AGENT'] ) ) {
1857
+		if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) && preg_match( '/MSIE [8-9]/', $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
1858 1858
 			wp_enqueue_script( 'gv-flexibility' );
1859 1859
 		}
1860 1860
 	}
@@ -1876,7 +1876,7 @@  discard block
 block discarded – undo
1876 1876
 		add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );
1877 1877
 
1878 1878
 		$scheme = is_ssl() ? 'https://' : 'http://';
1879
-		wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1879
+		wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1880 1880
 
1881 1881
 		/**
1882 1882
 		 * @filter `gravityview_search_datepicker_class`
@@ -1955,7 +1955,7 @@  discard block
 block discarded – undo
1955 1955
 	public function add_preview_inputs() {
1956 1956
 		global $wp;
1957 1957
 
1958
-		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews') ) {
1958
+		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews' ) ) {
1959 1959
 			return;
1960 1960
 		}
1961 1961
 
@@ -2007,7 +2007,7 @@  discard block
 block discarded – undo
2007 2007
  */
2008 2008
 class GravityView_Widget_Search_Author_GF_Query_Condition extends \GF_Query_Condition {
2009 2009
 	public function __construct( $filter, $view ) {
2010
-		$this->value = $filter['value'];
2010
+		$this->value = $filter[ 'value' ];
2011 2011
 		$this->view = $view;
2012 2012
 	}
2013 2013
 
@@ -2039,11 +2039,11 @@  discard block
 block discarded – undo
2039 2039
 		$conditions = array();
2040 2040
 
2041 2041
 		foreach ( $user_fields as $user_field ) {
2042
-			$conditions[] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) .  '%' );
2042
+			$conditions[ ] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );
2043 2043
 		}
2044 2044
 
2045 2045
 		foreach ( $user_meta_fields as $meta_field ) {
2046
-			$conditions[] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) .  '%' );
2046
+			$conditions[ ] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );
2047 2047
 		}
2048 2048
 
2049 2049
 		$conditions = '(' . implode( ' OR ', $conditions ) . ')';
Please login to merge, or discard this patch.
future/includes/class-gv-template.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	 * @see \Gamajo_Template_Loader::set_template_data
85 85
 	 * @see \GV\Template::pop_template_data
86 86
 	 *
87
-	 * @return \Gamajo_Template_Loader The current instance.
87
+	 * @return Template The current instance.
88 88
 	 */
89 89
 	public function push_template_data( $data, $var_name = 'data' ) {
90 90
 		if ( ! isset( self::$data_stack[ $var_name ] ) ) {
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-workflow_final_status.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 */
42 42
 	function modify_entry_value_workflow_final_status( $output, $entry, $field_settings, $field ) {
43 43
 
44
-		if( ! empty( $output ) ) {
44
+		if ( ! empty( $output ) ) {
45 45
 			$output = gravity_flow()->translate_status_label( $output );
46 46
 		}
47 47
 
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
 		foreach ( $search_fields as & $search_field ) {
66 66
 			if ( $this->name === \GV\Utils::get( $search_field, 'key' ) ) {
67
-				$search_field['choices'] = GravityView_Plugin_Hooks_Gravity_Flow::get_status_options();
67
+				$search_field[ 'choices' ] = GravityView_Plugin_Hooks_Gravity_Flow::get_status_options();
68 68
 			}
69 69
 		}
70 70
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/partials/form-buttons.php 2 patches
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -7,15 +7,15 @@  discard block
 block discarded – undo
7 7
 <div id="publishing-action">
8 8
 	<?php
9 9
 
10
-    /**
11
-     * @filter `gravityview/edit_entry/cancel_link` Modify the cancel button link URL
12
-     * @since 1.11.1
13
-     * @param string $back_link Existing URL of the Cancel link
14
-     * @param array $form The Gravity Forms form
15
-     * @param array $entry The Gravity Forms entry
16
-     * @param int $view_id The current View ID
17
-     */
18
-    $back_link = apply_filters( 'gravityview/edit_entry/cancel_link', remove_query_arg( array( 'page', 'view', 'edit' ) ), $object->form, $object->entry, $object->view_id );
10
+	/**
11
+	 * @filter `gravityview/edit_entry/cancel_link` Modify the cancel button link URL
12
+	 * @since 1.11.1
13
+	 * @param string $back_link Existing URL of the Cancel link
14
+	 * @param array $form The Gravity Forms form
15
+	 * @param array $entry The Gravity Forms entry
16
+	 * @param int $view_id The current View ID
17
+	 */
18
+	$back_link = apply_filters( 'gravityview/edit_entry/cancel_link', remove_query_arg( array( 'page', 'view', 'edit' ) ), $object->form, $object->entry, $object->view_id );
19 19
 
20 20
 	/**
21 21
 	 * @action `gravityview/edit-entry/publishing-action/before` Triggered before the submit buttons in the Edit Entry screen, inside the `<div id="publishing-action">` container.
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
53 53
 	/**
54 54
 	 * @action `gravityview/edit-entry/publishing-action/after` Triggered after the submit buttons in the Edit Entry screen, inside the `<div id="publishing-action">` container.
55 55
 	 * @since 1.5.1
56
-     * @since 2.0.13 Added $post_id
56
+	 * @since 2.0.13 Added $post_id
57 57
 	 * @param array $form The Gravity Forms form
58 58
 	 * @param array $entry The Gravity Forms entry
59 59
 	 * @param int $view_id The current View ID
60
-     * @param int $post_id The current Post ID
60
+	 * @param int $post_id The current Post ID
61 61
 	 */
62 62
 	do_action( 'gravityview/edit-entry/publishing-action/after', $object->form, $object->entry, $object->view_id, $object->post_id );
63 63
 
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -60,28 +60,28 @@  discard block
 block discarded – undo
60 60
 	if ( $object->show_previous_button ) {
61 61
 		$previous_tabindex = GFCommon::get_tabindex();
62 62
 		?>
63
-		<input id="gform_previous_button_<?php echo esc_attr( $object->form['id'] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-previous" type="submit" <?php echo $previous_tabindex; ?> value="<?php echo esc_attr( $labels['previous'] ); ?>" name="save" />
63
+		<input id="gform_previous_button_<?php echo esc_attr( $object->form[ 'id' ] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-previous" type="submit" <?php echo $previous_tabindex; ?> value="<?php echo esc_attr( $labels[ 'previous' ] ); ?>" name="save" />
64 64
 		<?php
65 65
 	}
66 66
 
67 67
 	if ( $object->show_next_button ) {
68
-		$next_tabindex    = GFCommon::get_tabindex();
68
+		$next_tabindex = GFCommon::get_tabindex();
69 69
 		?>
70
-		<input id="gform_next_button_<?php echo esc_attr( $object->form['id'] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-next" type="submit" <?php echo $next_tabindex; ?> value="<?php echo esc_attr( $labels['next'] ); ?>" name="save" />
70
+		<input id="gform_next_button_<?php echo esc_attr( $object->form[ 'id' ] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-next" type="submit" <?php echo $next_tabindex; ?> value="<?php echo esc_attr( $labels[ 'next' ] ); ?>" name="save" />
71 71
 		<?php
72 72
 	}
73 73
 
74 74
 	if ( $object->show_update_button ) {
75
-		$update_tabindex  = GFCommon::get_tabindex();
75
+		$update_tabindex = GFCommon::get_tabindex();
76 76
 		?>
77
-		<input id="gform_submit_button_<?php echo esc_attr( $object->form['id'] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-update" type="submit" <?php echo $update_tabindex; ?> value="<?php echo esc_attr( $labels['submit'] ); ?>" name="save" />
77
+		<input id="gform_submit_button_<?php echo esc_attr( $object->form[ 'id' ] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-update" type="submit" <?php echo $update_tabindex; ?> value="<?php echo esc_attr( $labels[ 'submit' ] ); ?>" name="save" />
78 78
 		<?php
79 79
 	}
80 80
 
81
-	$cancel_tabindex   = GFCommon::get_tabindex();
81
+	$cancel_tabindex = GFCommon::get_tabindex();
82 82
 
83 83
 	?>
84
-	<a class="btn btn-sm button button-small gv-button-cancel" <?php echo $cancel_tabindex; ?> href="<?php echo esc_url( $back_link ); ?>"><?php echo esc_attr( $labels['cancel'] ); ?></a>
84
+	<a class="btn btn-sm button button-small gv-button-cancel" <?php echo $cancel_tabindex; ?> href="<?php echo esc_url( $back_link ); ?>"><?php echo esc_attr( $labels[ 'cancel' ] ); ?></a>
85 85
 	<?php
86 86
 
87 87
 	/**
@@ -97,5 +97,5 @@  discard block
 block discarded – undo
97 97
 
98 98
 	?>
99 99
 	<input type="hidden" name="action" value="update" />
100
-	<input type="hidden" name="lid" value="<?php echo esc_attr( $object->entry['id'] ); ?>" />
100
+	<input type="hidden" name="lid" value="<?php echo esc_attr( $object->entry[ 'id' ] ); ?>" />
101 101
 </div>
Please login to merge, or discard this patch.
includes/class-admin.php 2 patches
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -4,10 +4,10 @@  discard block
 block discarded – undo
4 4
 
5 5
 	function __construct() {
6 6
 
7
-		if( ! is_admin() ) { return; }
7
+		if ( ! is_admin() ) { return; }
8 8
 
9 9
 		// If Gravity Forms isn't active or compatibile, stop loading
10
-		if( false === GravityView_Compatibility::is_valid() ) {
10
+		if ( false === GravityView_Compatibility::is_valid() ) {
11 11
 			return;
12 12
 		}
13 13
 
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 		add_filter( 'post_updated_messages', array( $this, 'post_updated_messages' ) );
49 49
 		add_filter( 'bulk_post_updated_messages', array( $this, 'post_updated_messages' ) );
50 50
 
51
-		add_filter( 'plugin_action_links_'. plugin_basename( GRAVITYVIEW_FILE ) , array( $this, 'plugin_action_links' ) );
51
+		add_filter( 'plugin_action_links_' . plugin_basename( GRAVITYVIEW_FILE ), array( $this, 'plugin_action_links' ) );
52 52
 
53 53
 		add_action( 'plugins_loaded', array( $this, 'backend_actions' ), 100 );
54 54
 
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
 	 */
65 65
 	public static function no_views_text() {
66 66
 
67
-		if ( isset( $_REQUEST['post_status'] ) && 'trash' === $_REQUEST['post_status'] ) {
67
+		if ( isset( $_REQUEST[ 'post_status' ] ) && 'trash' === $_REQUEST[ 'post_status' ] ) {
68 68
 			return __( 'No Views found in Trash', 'gravityview' );
69
-		} elseif( ! empty( $_GET['s'] ) ) {
69
+		} elseif ( ! empty( $_GET[ 's' ] ) ) {
70 70
 			return __( 'No Views found.', 'gravityview' );
71 71
 		}
72 72
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 			$error .= ' ' . esc_html__( 'or select another form.', 'gravityview' );
111 111
 		}
112 112
 
113
-		if( $error ) {
113
+		if ( $error ) {
114 114
 			?>
115 115
 			<div class="wp-dialog notice-warning inline error wp-clearfix">
116 116
 				<?php echo gravityview_get_floaty(); ?>
@@ -129,23 +129,23 @@  discard block
 block discarded – undo
129 129
 	public function backend_actions() {
130 130
 
131 131
 		/** @define "GRAVITYVIEW_DIR" "../" */
132
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class.field.type.php' );
133
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class.render.settings.php' );
134
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class-gravityview-admin-view-item.php' );
135
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class-gravityview-admin-view-field.php' );
136
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class-gravityview-admin-view-widget.php' );
137
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-views.php' );
138
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-welcome.php' );
139
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-installer.php' );
140
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-add-shortcode.php' );
141
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
132
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class.field.type.php' );
133
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class.render.settings.php' );
134
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class-gravityview-admin-view-item.php' );
135
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class-gravityview-admin-view-field.php' );
136
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class-gravityview-admin-view-widget.php' );
137
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-views.php' );
138
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-welcome.php' );
139
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-installer.php' );
140
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-add-shortcode.php' );
141
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
142 142
 
143 143
 		/**
144 144
 		 * @action `gravityview_include_backend_actions` Triggered after all GravityView admin files are loaded
145 145
 		 *
146 146
 		 * Nice place to insert extensions' backend stuff
147 147
 		 */
148
-		do_action('gravityview_include_backend_actions');
148
+		do_action( 'gravityview_include_backend_actions' );
149 149
 	}
150 150
 
151 151
 	/**
@@ -161,12 +161,12 @@  discard block
 block discarded – undo
161 161
 
162 162
 		$actions = array();
163 163
 
164
-		if( GVCommon::has_cap( 'gravityview_view_settings' ) ) {
165
-			$actions[] = sprintf( '<a href="%s">%s</a>', admin_url( 'edit.php?post_type=gravityview&page=gravityview_settings' ), esc_html__( 'Settings', 'gravityview' ) );
164
+		if ( GVCommon::has_cap( 'gravityview_view_settings' ) ) {
165
+			$actions[ ] = sprintf( '<a href="%s">%s</a>', admin_url( 'edit.php?post_type=gravityview&page=gravityview_settings' ), esc_html__( 'Settings', 'gravityview' ) );
166 166
 		}
167 167
 
168
-		if( GVCommon::has_cap( 'gravityview_support_port' ) ) {
169
-			$actions[] = '<a href="https://docs.gravityview.co">' . esc_html__( 'Support', 'gravityview' ) . '</a>';
168
+		if ( GVCommon::has_cap( 'gravityview_support_port' ) ) {
169
+			$actions[ ] = '<a href="https://docs.gravityview.co">' . esc_html__( 'Support', 'gravityview' ) . '</a>';
170 170
 		}
171 171
 
172 172
 		return array_merge( $actions, $links );
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
 		// By default, there will only be one item being modified.
195 195
 		// When in the `bulk_post_updated_messages` filter, there will be passed a number
196 196
 		// of modified items that will override this array.
197
-		$bulk_counts = is_null( $bulk_counts ) ? array( 'updated' => 1 , 'locked' => 1 , 'deleted' => 1 , 'trashed' => 1, 'untrashed' => 1 ) : $bulk_counts;
197
+		$bulk_counts = is_null( $bulk_counts ) ? array( 'updated' => 1, 'locked' => 1, 'deleted' => 1, 'trashed' => 1, 'untrashed' => 1 ) : $bulk_counts;
198 198
 
199 199
 		// If we're starting fresh, a new form was created.
200 200
 		// We should let the user know this is the case.
@@ -202,60 +202,60 @@  discard block
 block discarded – undo
202 202
 
203 203
 		$new_form_text = '';
204 204
 
205
-		if( !empty( $start_fresh ) ) {
205
+		if ( ! empty( $start_fresh ) ) {
206 206
 
207 207
 			// Get the form that was created
208 208
 			$connected_form = gravityview_get_form_id( $post_id );
209 209
 
210
-			if( !empty( $connected_form ) ) {
210
+			if ( ! empty( $connected_form ) ) {
211 211
 				$form = gravityview_get_form( $connected_form );
212
-				$form_name = esc_attr( $form['title'] );
212
+				$form_name = esc_attr( $form[ 'title' ] );
213 213
 				$image = self::get_floaty();
214
-				$new_form_text .= '<h3>'.$image.sprintf( __( 'A new form was created for this View: "%s"', 'gravityview' ), $form_name ).'</h3>';
215
-				$new_form_text .=  sprintf( __( '%sThere are no entries for the new form, so the View will also be empty.%s To start collecting entries, you can add submissions through %sthe preview form%s and also embed the form on a post or page using this code: %s
214
+				$new_form_text .= '<h3>' . $image . sprintf( __( 'A new form was created for this View: "%s"', 'gravityview' ), $form_name ) . '</h3>';
215
+				$new_form_text .= sprintf( __( '%sThere are no entries for the new form, so the View will also be empty.%s To start collecting entries, you can add submissions through %sthe preview form%s and also embed the form on a post or page using this code: %s
216 216
 
217 217
 					You can %sedit the form%s in Gravity Forms and the updated fields will be available here. Don&rsquo;t forget to %scustomize the form settings%s.
218
-					', 'gravityview' ), '<strong>', '</strong>', '<a href="'.site_url( '?gf_page=preview&amp;id='.$connected_form ).'">', '</a>', '<code>[gravityform id="'.$connected_form.'" name="'.$form_name.'"]</code>', '<a href="'.admin_url( 'admin.php?page=gf_edit_forms&amp;id='.$connected_form ).'">', '</a>', '<a href="'.admin_url( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id='.$connected_form ).'">', '</a>');
218
+					', 'gravityview' ), '<strong>', '</strong>', '<a href="' . site_url( '?gf_page=preview&amp;id=' . $connected_form ) . '">', '</a>', '<code>[gravityform id="' . $connected_form . '" name="' . $form_name . '"]</code>', '<a href="' . admin_url( 'admin.php?page=gf_edit_forms&amp;id=' . $connected_form ) . '">', '</a>', '<a href="' . admin_url( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id=' . $connected_form ) . '">', '</a>' );
219 219
 				$new_form_text = wpautop( $new_form_text );
220 220
 
221 221
 				delete_post_meta( $post_id, '_gravityview_start_fresh' );
222 222
 			}
223 223
 		}
224 224
 
225
-		$messages['gravityview'] = array(
225
+		$messages[ 'gravityview' ] = array(
226 226
 			0  => '', // Unused. Messages start at index 1.
227 227
 			/* translators: %s and %s are HTML tags linking to the View on the website */
228
-			1  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
228
+			1  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
229 229
 			/* translators: %s and %s are HTML tags linking to the View on the website */
230
-			2  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
230
+			2  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
231 231
 			3  => __( 'View deleted.', 'gravityview' ),
232 232
 			/* translators: %s and %s are HTML tags linking to the View on the website */
233
-			4  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
233
+			4  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
234 234
 			/* translators: %s: date and time of the revision */
235
-			5  => isset( $_GET['revision'] ) ? sprintf( __( 'View restored to revision from %s', 'gravityview' ), wp_post_revision_title( (int) $_GET['revision'], false ) ) : false,
235
+			5  => isset( $_GET[ 'revision' ] ) ? sprintf( __( 'View restored to revision from %s', 'gravityview' ), wp_post_revision_title( (int)$_GET[ 'revision' ], false ) ) : false,
236 236
 			/* translators: %s and %s are HTML tags linking to the View on the website */
237
-			6  => sprintf(__( 'View published. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
237
+			6  => sprintf( __( 'View published. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ) . $new_form_text,
238 238
 			/* translators: %s and %s are HTML tags linking to the View on the website */
239
-			7  => sprintf(__( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
239
+			7  => sprintf( __( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ) . $new_form_text,
240 240
 			8  => __( 'View submitted.', 'gravityview' ),
241 241
 			9  => sprintf(
242 242
 		        /* translators: Date and time the View is scheduled to be published */
243 243
 				__( 'View scheduled for: %1$s.', 'gravityview' ),
244 244
 				// translators: Publish box date format, see http://php.net/date
245
-				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL )  ) )
245
+				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL ) ) )
246 246
 			) . $new_form_text,
247 247
 			/* translators: %s and %s are HTML tags linking to the View on the website */
248
-			10  => sprintf(__( 'View draft updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
248
+			10  => sprintf( __( 'View draft updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ) . $new_form_text,
249 249
 
250 250
 			/**
251 251
 			 * These apply to `bulk_post_updated_messages`
252 252
 			 * @file wp-admin/edit.php
253 253
 			 */
254
-			'updated'   => _n( '%s View updated.', '%s Views updated.', $bulk_counts['updated'], 'gravityview' ),
255
-			'locked'    => _n( '%s View not updated, somebody is editing it.', '%s Views not updated, somebody is editing them.', $bulk_counts['locked'], 'gravityview' ),
256
-			'deleted'   => _n( '%s View permanently deleted.', '%s Views permanently deleted.', $bulk_counts['deleted'], 'gravityview' ),
257
-			'trashed'   => _n( '%s View moved to the Trash.', '%s Views moved to the Trash.', $bulk_counts['trashed'], 'gravityview' ),
258
-			'untrashed' => _n( '%s View restored from the Trash.', '%s Views restored from the Trash.', $bulk_counts['untrashed'], 'gravityview' ),
254
+			'updated'   => _n( '%s View updated.', '%s Views updated.', $bulk_counts[ 'updated' ], 'gravityview' ),
255
+			'locked'    => _n( '%s View not updated, somebody is editing it.', '%s Views not updated, somebody is editing them.', $bulk_counts[ 'locked' ], 'gravityview' ),
256
+			'deleted'   => _n( '%s View permanently deleted.', '%s Views permanently deleted.', $bulk_counts[ 'deleted' ], 'gravityview' ),
257
+			'trashed'   => _n( '%s View moved to the Trash.', '%s Views moved to the Trash.', $bulk_counts[ 'trashed' ], 'gravityview' ),
258
+			'untrashed' => _n( '%s View restored from the Trash.', '%s Views restored from the Trash.', $bulk_counts[ 'untrashed' ], 'gravityview' ),
259 259
 		);
260 260
 
261 261
 		return $messages;
Please login to merge, or discard this patch.
Indentation   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	 * @return void
93 93
 	 */
94 94
 	public static function connected_form_warning( $form_id = 0 ) {
95
-        global $pagenow;
95
+		global $pagenow;
96 96
 
97 97
 		if ( empty( $form_id ) || $pagenow === 'post-new.php' ) {
98 98
 			return;
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 			<?php
120 120
 		}
121 121
 
122
-        remove_action( 'gravityview/metaboxes/data-source/before', array( 'GravityView_Admin', 'connected_form_warning' ) );
122
+		remove_action( 'gravityview/metaboxes/data-source/before', array( 'GravityView_Admin', 'connected_form_warning' ) );
123 123
 	}
124 124
 
125 125
 	/**
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 			7  => sprintf(__( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
242 242
 			8  => __( 'View submitted.', 'gravityview' ),
243 243
 			9  => sprintf(
244
-		        /* translators: Date and time the View is scheduled to be published */
244
+				/* translators: Date and time the View is scheduled to be published */
245 245
 				__( 'View scheduled for: %1$s.', 'gravityview' ),
246 246
 				// translators: Publish box date format, see http://php.net/date
247 247
 				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL )  ) )
@@ -298,7 +298,6 @@  discard block
 block discarded – undo
298 298
 	 *
299 299
 	 * @deprecated since 1.12
300 300
 	 * @see GravityView_Compatibility::get_plugin_status()
301
-
302 301
 	 * @return boolean|string True: plugin is active; False: plugin file doesn't exist at path; 'inactive' it's inactive
303 302
 	 */
304 303
 	static function get_plugin_status( $location = '' ) {
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-search_all.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -7,15 +7,15 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12 12
 
13 13
 $html_input_type = RGFormsModel::is_html5_enabled() ? 'search' : 'text';
14 14
 ?>
15 15
 
16 16
 <div class="gv-search-box gv-search-field-text gv-search-field-search_all">
17 17
 	<div class="gv-search">
18
-	<?php if( ! gv_empty( $label, false, false ) ) { ?>
18
+	<?php if ( ! gv_empty( $label, false, false ) ) { ?>
19 19
 		<label for="gv_search_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
20 20
 	<?php } ?>
21 21
 		<p><input type="<?php echo $html_input_type; ?>" name="gv_search" id="gv_search_<?php echo $view_id; ?>" value="<?php echo esc_attr( $value ); ?>" /></p>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-entry_id.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -7,13 +7,13 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12 12
 ?>
13 13
 
14 14
 <div class="gv-search-box gv-search-field-entry_id">
15 15
 	<div class="gv-search">
16
-		<?php if( ! gv_empty( $label, false, false ) ) { ?>
16
+		<?php if ( ! gv_empty( $label, false, false ) ) { ?>
17 17
 		<label for="gv_entry_id_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18
 		<?php } ?>
19 19
 		<p><input type="text" name="gv_id" id="gv_entry_id_<?php echo $view_id; ?>" value="<?php echo esc_attr( $value ); ?>" /></p>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-entry_date.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -7,17 +7,17 @@
 block discarded – undo
7 7
 
8 8
 $gravityview_view = GravityView_View::getInstance();
9 9
 $view_id = $gravityview_view->getViewId();
10
-$value = $gravityview_view->search_field['value'];
11
-$label = $gravityview_view->search_field['label'];
10
+$value = $gravityview_view->search_field[ 'value' ];
11
+$label = $gravityview_view->search_field[ 'label' ];
12 12
 
13 13
 ?>
14 14
 
15 15
 <div class="gv-search-box gv-search-date gv-search-date-range gv-search-field-entry_date">
16
-	<?php if( ! gv_empty( $label, false, false ) ) { ?>
16
+	<?php if ( ! gv_empty( $label, false, false ) ) { ?>
17 17
 	<label for="gv_start_date_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18
 	<?php } ?>
19 19
 	<p>
20
-		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('Start date', 'gravityview' ); ?>" value="<?php echo $value['start']; ?>">
21
-		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('End date', 'gravityview' ); ?>" value="<?php echo $value['end']; ?>">
20
+		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'Start date', 'gravityview' ); ?>" value="<?php echo $value[ 'start' ]; ?>">
21
+		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_attr( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'End date', 'gravityview' ); ?>" value="<?php echo $value[ 'end' ]; ?>">
22 22
 	</p>
23 23
 </div>
24 24
\ No newline at end of file
Please login to merge, or discard this patch.