GravityView_Field_Phone::field_options() - Code Metrics - Inspection of "Version 1.17" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#716)

by Zack

created 2016-06-15 02:14 UTC

GravityView_Field_Phone::field_options() A

↳ Parent: GravityView_Field_Phone

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	1
b	0
f	0
nc	2
nop	5
dl	0
loc	15
rs	9.4285

<?php

/**
 * @file class-gravityview-field-phone.php
 * @package GravityView
 * @subpackage includes\fields
 */

class GravityView_Field_Phone extends GravityView_Field {

	var $name = 'phone';
class A {
    var $property;
}

	var $is_searchable = false;
class A {
    var $property;
}

	var $_gf_field_class_name = 'GF_Field_Phone';
class A {
    var $property;
}

	var $group = 'advanced';
class A {
    var $property;
}

	public function __construct() {
		$this->label = esc_html__( 'Phone', 'gravityview' );
		parent::__construct();
	}

	/**
	 * Add option to link phone number
	 *
	 * @since TODO
	 *
	 * @param array $field_options
	 * @param string $template_id
	 * @param string $field_id
	 * @param string $context
	 * @param string $input_type
	 *
	 * @return array
	 */
	function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {


		if( 'edit' === $context ) {
			return $field_options;
		}

		$field_options['link_phone'] = array(
	        'type' => 'checkbox',
	        'label' => __( 'Make Phone Number Clickable', 'gravityview' ),
	        'desc' => __( 'Allow dialing a number by clicking it?', 'gravityview'),

	        'value' => true,
        );

		return $field_options;
	}
}

new GravityView_Field_Phone;


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-09 18:31 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 8 and the first side effect is on line 53. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* @file class-gravityview-field-phone.php
4			* @package GravityView
5			* @subpackage includes\fields
6			*/
7
8			class GravityView_Field_Phone extends GravityView_Field {
9
10			var $name = 'phone';
			0 ignored issues – show Coding Style introduced 2016-01-18 22:19 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$name`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
11
12			var $is_searchable = false;
			0 ignored issues – show Coding Style introduced 2016-01-18 22:19 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$is_searchable`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
13
14			var $_gf_field_class_name = 'GF_Field_Phone';
			0 ignored issues – show Coding Style introduced 2016-01-18 22:19 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$_gf_field_class_name`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
15
16			var $group = 'advanced';
			0 ignored issues – show Coding Style introduced 2016-01-18 22:19 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$group`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
17
18			public function __construct() {
19			$this->label = esc_html__( 'Phone', 'gravityview' );
20			parent::__construct();
21			}
22
23			/**
24			* Add option to link phone number
25			*
26			* @since TODO
27			*
28			* @param array $field_options
29			* @param string $template_id
30			* @param string $field_id
31			* @param string $context
32			* @param string $input_type
33			*
34			* @return array
35			*/
36			function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
			0 ignored issues – show Best Practice introduced 2016-04-07 05:27 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
37
38			if( 'edit' === $context ) {
39			return $field_options;
40			}
41
42			$field_options['link_phone'] = array(
43			'type' => 'checkbox',
44			'label' => __( 'Make Phone Number Clickable', 'gravityview' ),
45			'desc' => __( 'Allow dialing a number by clicking it?', 'gravityview'),
			0 ignored issues – show Coding Style introduced 2016-04-07 05:27 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
46			'value' => true,
47			);
48
49			return $field_options;
50			}
51			}
52
53			new GravityView_Field_Phone;
54

gravityview / GravityView

Pull Request — master (#716)

GravityView_Field_Phone::field_options() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like