Inspection of "Use FancyBox as the lightbox" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1484)

by Zack

created 2020-08-05 18:24 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -41,10 +41,10 @@
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		unset ( $field_options['search_filter'], $field_options['show_as_link'] );
+		unset ( $field_options[ 'search_filter' ], $field_options[ 'show_as_link' ] );
 
 		// Set the default CSS class to gv-section, which applies a border and top/bottom margin
-		$field_options['custom_class']['value'] = 'gv-section';
+		$field_options[ 'custom_class' ][ 'value' ] = 'gv-section';
 
 		return $field_options;
 	}

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-website.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -29,16 +29,16 @@  discard block
 block discarded – undo
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
 		// It makes no sense to use this as the link.
-		unset( $field_options['show_as_link'] );
+		unset( $field_options[ 'show_as_link' ] );
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
 		/**
 		 * @since 1.8
 		 */
-		$field_options['anchor_text'] = array(
+		$field_options[ 'anchor_text' ] = array(
 			'type' => 'text',
 			'label' => __( 'Link Text:', 'gravityview' ),
 			'desc' => __( 'Define custom link text. Leave blank to display the URL', 'gravityview' ),
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 			'merge_tags' => 'force',
 		);
 
-		$field_options['truncatelink'] = array(
+		$field_options[ 'truncatelink' ] = array(
 			'type' => 'checkbox',
 			'value' => true,
 			'label' => __( 'Shorten Link Display', 'gravityview' ),
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 			'desc' => __( 'Don&rsquo;t show the full URL, only show the domain.', 'gravityview' )
 		);
 
-		$field_options['open_same_window'] = array(
+		$field_options[ 'open_same_window' ] = array(
 			'type' => 'checkbox',
 			'value' => false,
 			'label' => __( 'Open link in the same window?', 'gravityview' ),

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-quiz.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
 			'quiz_show_explanation' => array(
 				'type' => 'checkbox',
 				'label' => __( 'Show Answer Explanation?', 'gravityview' ),
-				'desc' => __('If the field has an answer explanation, show it?', 'gravityview'),
+				'desc' => __( 'If the field has an answer explanation, show it?', 'gravityview' ),
 				'value' => false,
 				'merge_tags' => false,
 			),

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-pipe_recorder.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,13 +22,13 @@
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		unset( $field_options['search_filter'] );
+		unset( $field_options[ 'search_filter' ] );
 
 		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
-		$add_options['embed'] = array(
+		$add_options[ 'embed' ] = array(
 			'type' => 'checkbox',
 			'label' => __( 'Display as embedded', 'gravityview' ),
 			'desc' => __( 'Display the video in a player, rather than a direct link to the video.', 'gravityview' ),

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-number.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -31,17 +31,17 @@
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		$field_options['number_format'] = array(
+		$field_options[ 'number_format' ] = array(
 			'type' => 'checkbox',
 			'label' => __( 'Format number?', 'gravityview' ),
-			'desc' => __('Display numbers with thousands separators.', 'gravityview'),
+			'desc' => __( 'Display numbers with thousands separators.', 'gravityview' ),
 			'value' => false,
 		);
 
-		$field_options['decimals'] = array(
+		$field_options[ 'decimals' ] = array(
 			'type' => 'number',
 			'label' => __( 'Decimals', 'gravityview' ),
-			'desc' => __('Precision of the number of decimal places. Leave blank to use existing precision.', 'gravityview'),
+			'desc' => __( 'Precision of the number of decimal places. Leave blank to use existing precision.', 'gravityview' ),
 			'value' => '',
 			'merge_tags' => false,
 		);

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-html.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		unset ( $field_options['search_filter'], $field_options['show_as_link'] );
+		unset ( $field_options[ 'search_filter' ], $field_options[ 'show_as_link' ] );
 
 		return $field_options;
 	}

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-post-id.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		$this->add_field_support('link_to_post', $field_options );
+		$this->add_field_support( 'link_to_post', $field_options );
 
 		return $field_options;
 	}

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-email.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -28,9 +28,9 @@
 block discarded – undo
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
 		// It makes no sense to use this as the link.
-		unset( $field_options['show_as_link'] );
+		unset( $field_options[ 'show_as_link' ] );
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 

Please login to merge, or discard this patch.

includes/fields/class-gravityview-field-survey.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		unset( $field_options['search_filter'] );
+		unset( $field_options[ 'search_filter' ] );
 
 		if ( 'edit' === $context ) {
 			return $field_options;
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 		$add_options = array();
 
 		if ( $field->field->inputType === 'likert' && $field->field->gsurveyLikertEnableScoring ) {
-			$add_options['score'] = array(
+			$add_options[ 'score' ] = array(
 				'type' => 'checkbox',
 				'label' => __( 'Show score', 'gravityview' ),
 				'desc' => __( 'Display likert score as a simple number.', 'gravityview' ),

Please login to merge, or discard this patch.

		@@ -41,10 +41,10 @@
		block discarded – undo
41	41
42	42	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
43	43
44		- unset ( $field_options['search_filter'], $field_options['show_as_link'] );
	44	+ unset ( $field_options[ 'search_filter' ], $field_options[ 'show_as_link' ] );
45	45
46	46	// Set the default CSS class to gv-section, which applies a border and top/bottom margin
47		- $field_options['custom_class']['value'] = 'gv-section';
	47	+ $field_options[ 'custom_class' ][ 'value' ] = 'gv-section';
48	48
49	49	return $field_options;
50	50	}

		@@ -29,16 +29,16 @@ discard block
		block discarded – undo
29	29	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
30	30
31	31	// It makes no sense to use this as the link.
32		- unset( $field_options['show_as_link'] );
	32	+ unset( $field_options[ 'show_as_link' ] );
33	33
34		- if( 'edit' === $context ) {
	34	+ if ( 'edit' === $context ) {
35	35	return $field_options;
36	36	}
37	37
38	38	/**
39	39	* @since 1.8
40	40	*/
41		- $field_options['anchor_text'] = array(
	41	+ $field_options[ 'anchor_text' ] = array(
42	42	'type' => 'text',
43	43	'label' => __( 'Link Text:', 'gravityview' ),
44	44	'desc' => __( 'Define custom link text. Leave blank to display the URL', 'gravityview' ),
		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	'merge_tags' => 'force',
47	47	);
48	48
49		- $field_options['truncatelink'] = array(
	49	+ $field_options[ 'truncatelink' ] = array(
50	50	'type' => 'checkbox',
51	51	'value' => true,
52	52	'label' => __( 'Shorten Link Display', 'gravityview' ),
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	'desc' => __( 'Don’t show the full URL, only show the domain.', 'gravityview' )
55	55	);
56	56
57		- $field_options['open_same_window'] = array(
	57	+ $field_options[ 'open_same_window' ] = array(
58	58	'type' => 'checkbox',
59	59	'value' => false,
60	60	'label' => __( 'Open link in the same window?', 'gravityview' ),

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18
19	19	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
20	20
21		- if( 'edit' === $context ) {
	21	+ if ( 'edit' === $context ) {
22	22	return $field_options;
23	23	}
24	24
		@@ -26,7 +26,7 @@ discard block
		block discarded – undo
26	26	'quiz_show_explanation' => array(
27	27	'type' => 'checkbox',
28	28	'label' => __( 'Show Answer Explanation?', 'gravityview' ),
29		- 'desc' => __('If the field has an answer explanation, show it?', 'gravityview'),
	29	+ 'desc' => __( 'If the field has an answer explanation, show it?', 'gravityview' ),
30	30	'value' => false,
31	31	'merge_tags' => false,
32	32	),

		@@ -22,13 +22,13 @@
		block discarded – undo
22	22
23	23	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
24	24
25		- unset( $field_options['search_filter'] );
	25	+ unset( $field_options[ 'search_filter' ] );
26	26
27	27	if ( 'edit' === $context ) {
28	28	return $field_options;
29	29	}
30	30
31		- $add_options['embed'] = array(
	31	+ $add_options[ 'embed' ] = array(
32	32	'type' => 'checkbox',
33	33	'label' => __( 'Display as embedded', 'gravityview' ),
34	34	'desc' => __( 'Display the video in a player, rather than a direct link to the video.', 'gravityview' ),

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
33	33
34		- $field_options['number_format'] = array(
	34	+ $field_options[ 'number_format' ] = array(
35	35	'type' => 'checkbox',
36	36	'label' => __( 'Format number?', 'gravityview' ),
37		- 'desc' => __('Display numbers with thousands separators.', 'gravityview'),
	37	+ 'desc' => __( 'Display numbers with thousands separators.', 'gravityview' ),
38	38	'value' => false,
39	39	);
40	40
41		- $field_options['decimals'] = array(
	41	+ $field_options[ 'decimals' ] = array(
42	42	'type' => 'number',
43	43	'label' => __( 'Decimals', 'gravityview' ),
44		- 'desc' => __('Precision of the number of decimal places. Leave blank to use existing precision.', 'gravityview'),
	44	+ 'desc' => __( 'Precision of the number of decimal places. Leave blank to use existing precision.', 'gravityview' ),
45	45	'value' => '',
46	46	'merge_tags' => false,
47	47	);

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27
28	28	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
29	29
30		- unset ( $field_options['search_filter'], $field_options['show_as_link'] );
	30	+ unset ( $field_options[ 'search_filter' ], $field_options[ 'show_as_link' ] );
31	31
32	32	return $field_options;
33	33	}

		@@ -31,7 +31,7 @@
		block discarded – undo
31	31
32	32	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
33	33
34		- $this->add_field_support('link_to_post', $field_options );
	34	+ $this->add_field_support( 'link_to_post', $field_options );
35	35
36	36	return $field_options;
37	37	}

		@@ -28,9 +28,9 @@
		block discarded – undo
28	28	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
29	29
30	30	// It makes no sense to use this as the link.
31		- unset( $field_options['show_as_link'] );
	31	+ unset( $field_options[ 'show_as_link' ] );
32	32
33		- if( 'edit' === $context ) {
	33	+ if ( 'edit' === $context ) {
34	34	return $field_options;
35	35	}
36	36

		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22
23	23	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
24	24
25		- unset( $field_options['search_filter'] );
	25	+ unset( $field_options[ 'search_filter' ] );
26	26
27	27	if ( 'edit' === $context ) {
28	28	return $field_options;
		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	$add_options = array();
34	34
35	35	if ( $field->field->inputType === 'likert' && $field->field->gsurveyLikertEnableScoring ) {
36		- $add_options['score'] = array(
	36	+ $add_options[ 'score' ] = array(
37	37	'type' => 'checkbox',
38	38	'label' => __( 'Show score', 'gravityview' ),
39	39	'desc' => __( 'Display likert score as a simple number.', 'gravityview' ),

gravityview / GravityView

Pull Request — develop (#1484)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch