gravityview / GravityView

includes/fields/class-gravityview-field-address.php

Spacing +27 added lines, -27 removed lines

@@ -62,8 +62,8 @@ 
 				continue;
 			}
 
-			$field_id = intval( floor( $search_field['key'] ) );
-			$input_id = gravityview_get_input_id_from_id( $search_field['key'] );
+			$field_id = intval( floor( $search_field[ 'key' ] ) );
+			$input_id = gravityview_get_input_id_from_id( $search_field[ 'key' ] );
 			$form = GravityView_View::getInstance()->getForm();
 
 			/** @type GF_Field_Address $address_field */
@@ -72,7 +72,7 @@ 
 			$choices = array();
 
 			$method_name = 'get_choices_' . self::get_input_type_from_input_id( $input_id );
-			if( method_exists( $this, $method_name ) ) {
+			if ( method_exists( $this, $method_name ) ) {
 				/**
 				 * @uses GravityView_Field_Address::get_choices_country()
 				 * @uses GravityView_Field_Address::get_choices_state()
@@ -80,12 +80,12 @@ 
 				$choices = $this->{$method_name}( $address_field, $form );
 			}
 
-			if( ! empty( $choices ) ) {
-				$search_field['choices'] = $choices;
-				$search_field['type'] = \GV\Utils::get( $search_field, 'input');
+			if ( ! empty( $choices ) ) {
+				$search_field[ 'choices' ] = $choices;
+				$search_field[ 'type' ] = \GV\Utils::get( $search_field, 'input' );
 			} else {
-				$search_field['type'] = 'text';
-				$search_field['input'] = 'input_text';
+				$search_field[ 'type' ] = 'text';
+				$search_field[ 'input' ] = 'input_text';
 			}
 		}
 
@@ -110,7 +110,7 @@ 
 		$country_choices = array();
 
 		foreach ( $countries as $key => $country ) {
-			$country_choices[] = array(
+			$country_choices[ ] = array(
 				'value' => $country,
 				'text' => $country,
 			);
@@ -135,7 +135,7 @@ 
 	 */
 	private function get_choices_state( $address_field, $form ) {
 
-		$address_type = empty( $address_field->addressType ) ? $address_field->get_default_address_type( $form['id'] ) : $address_field->addressType;
+		$address_type = empty( $address_field->addressType ) ? $address_field->get_default_address_type( $form[ 'id' ] ) : $address_field->addressType;
 
 		$state_choices = array();
 
@@ -147,8 +147,8 @@ 
 				$states = GFCommon::get_canadian_provinces();
 				break;
 			default:
-				$address_types = $address_field->get_address_types( $form['id'] );
-				$states = empty( $address_types[ $address_type ]['states'] ) ? array() : $address_types[ $address_type ]['states'];
+				$address_types = $address_field->get_address_types( $form[ 'id' ] );
+				$states = empty( $address_types[ $address_type ][ 'states' ] ) ? array() : $address_types[ $address_type ][ 'states' ];
 				break;
 		}
 
@@ -157,19 +157,19 @@ 
 				$state_subchoices = array();
 
 				foreach ( $state as $key => $substate ) {
-					$state_subchoices[] = array(
+					$state_subchoices[ ] = array(
 						'value' => is_numeric( $key ) ? $substate : $key,
 						'text' => $substate,
 					);
 				}
 
-				$state_choices[] = array(
+				$state_choices[ ] = array(
 					'text' => $key,
 					'value' => $state_subchoices,
 				);
 
 			} else {
-				$state_choices[] = array(
+				$state_choices[ ] = array(
 					'value' => is_numeric( $key ) ? $state : $key,
 					'text' => $state,
 				);
@@ -193,13 +193,13 @@ 
 		// Use the same inputs as the "text" input type allows
 		$text_inputs = \GV\Utils::get( $input_types, 'text' );
 
-		$input_types['street'] = $text_inputs;
-		$input_types['street2'] = $text_inputs;
-		$input_types['city'] = $text_inputs;
+		$input_types[ 'street' ] = $text_inputs;
+		$input_types[ 'street2' ] = $text_inputs;
+		$input_types[ 'city' ] = $text_inputs;
 
-		$input_types['state'] = array( 'select', 'radio', 'link' ) + $text_inputs;
-		$input_types['zip'] = array( 'input_text' );
-		$input_types['country'] = array( 'select', 'radio', 'link' ) + $text_inputs;
+		$input_types[ 'state' ] = array( 'select', 'radio', 'link' ) + $text_inputs;
+		$input_types[ 'zip' ] = array( 'input_text' );
+		$input_types[ 'country' ] = array( 'select', 'radio', 'link' ) + $text_inputs;
 
 		return $input_types;
 	}
@@ -220,12 +220,12 @@ 
 		// Is this search field for an input (eg: 4.2) or the whole address field (eg: 4)?
 		$input_id = gravityview_get_input_id_from_id( $field_id );
 
-		if( 'address' !== $field_type && $input_id ) {
+		if ( 'address' !== $field_type && $input_id ) {
 			return $input_type;
 		}
 
 		// If the input ID matches an expected address input, set to that. Otherwise, keep existing input type.
-		if( $address_field_name = self::get_input_type_from_input_id( $input_id ) ) {
+		if ( $address_field_name = self::get_input_type_from_input_id( $input_id ) ) {
 			$input_type = $address_field_name;
 		}
 
@@ -273,20 +273,20 @@ 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
 		// If this is NOT the full address field, return default options.
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
 			return $field_options;
 		}
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
 		$add_options = array();
 
-		$add_options['show_map_link'] = array(
+		$add_options[ 'show_map_link' ] = array(
 			'type' => 'checkbox',
 			'label' => __( 'Show Map Link:', 'gravityview' ),
-			'desc' => __('Display a "Map It" link below the address', 'gravityview'),
+			'desc' => __( 'Display a "Map It" link below the address', 'gravityview' ),
 			'value' => true,
 			'merge_tags' => false,
 		);

includes/fields/class-gravityview-field-hidden.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
 	function edit_entry_fix_hidden_fields( $fields ) {
 
 		/** @type GF_Field $field */
-		foreach( $fields as &$field ) {
+		foreach ( $fields as &$field ) {
 
 			if ( 'hidden' === $field->type ) {
 
@@ -62,7 +62,7 @@ 
 				 */
 				$reveal_hidden_field = apply_filters( 'gravityview/edit_entry/reveal_hidden_field', false, $field );
 
-				if( ! $reveal_hidden_field ) {
+				if ( ! $reveal_hidden_field ) {
 					continue;
 				}
 

includes/plugin-and-theme-hooks/class-gravityview-plugin-hooks-gravity-perks.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
 	public function edit_entry_fix_uid_fields( $fields ) {
 
 		/** @type \GF_Field $field */
-		foreach( $fields as &$field ) {
+		foreach ( $fields as &$field ) {
 			if ( 'uid' === $field->type ) {
 
 				// Replace GF_Field with GF_Field_Text, copying all the data from $field

future/includes/class-gv-field.php

Spacing +17 added lines, -17 removed lines

@@ -166,7 +166,7 @@ 
 	 * @return \GV\Field The field implementation from configuration (\GV\GF_Field, \GV\Internal_Field).
 	 */
 	public static function from_configuration( $configuration ) {
-		if ( empty( $configuration['id'] ) ) {
+		if ( empty( $configuration[ 'id' ] ) ) {
 			$field = new self();
 			gravityview()->log->error( 'Trying to get field from configuration without a field ID.', array( 'data' => $configuration ) );
 			$field->update_configuration( $configuration );
@@ -179,8 +179,8 @@ 
 		} else {
 			$trace = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS );
 		}
-		$trace = $trace[1];
-		if ( $trace['function'] == 'from_configuration' && $trace['class'] == __CLASS__ ) {
+		$trace = $trace[ 1 ];
+		if ( $trace[ 'function' ] == 'from_configuration' && $trace[ 'class' ] == __CLASS__ ) {
 			$field = new self();
 			gravityview()->log->error( 'Infinite loop protection tripped. Returning default class here.' );
 			$field->update_configuration( $configuration );
@@ -188,7 +188,7 @@ 
 		}
 
 		/** @type \GV\GF_Field|\GV\Internal_Field $field_class Determine the field implementation to use, and try to use. */
-		$field_class = is_numeric( $configuration['id'] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
+		$field_class = is_numeric( $configuration[ 'id' ] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
 
 		/**
 		 * @filter `gravityview/field/class` Filter the field class about to be created from the configuration.
@@ -227,24 +227,24 @@ 
 	public function update_configuration( $configuration ) {
 		$configuration = wp_parse_args( $configuration, $this->as_configuration() );
 
-		if ( $this->ID != $configuration['id'] ) {
+		if ( $this->ID != $configuration[ 'id' ] ) {
 			/** Smelling trouble here... */
 			gravityview()->log->warning( 'ID is being changed for {field_class} instance, but implementation is not. Use ::from_configuration instead', array( 'field_class', __CLASS__ ) );
 		}
 
-		$this->ID = $configuration['id'];
-		$this->label = $configuration['label'];
-		$this->show_label = $configuration['show_label'] == '1';
-		$this->custom_label = $configuration['custom_label'];
-		$this->custom_class = $configuration['custom_class'];
-		$this->cap = $configuration['only_loggedin'] == '1' ? $configuration['only_loggedin_cap'] : '';
-		$this->search_filter = $configuration['search_filter'] == '1';
-		$this->show_as_link = $configuration['show_as_link'] == '1';
+		$this->ID = $configuration[ 'id' ];
+		$this->label = $configuration[ 'label' ];
+		$this->show_label = $configuration[ 'show_label' ] == '1';
+		$this->custom_label = $configuration[ 'custom_label' ];
+		$this->custom_class = $configuration[ 'custom_class' ];
+		$this->cap = $configuration[ 'only_loggedin' ] == '1' ? $configuration[ 'only_loggedin_cap' ] : '';
+		$this->search_filter = $configuration[ 'search_filter' ] == '1';
+		$this->show_as_link = $configuration[ 'show_as_link' ] == '1';
 
 		/** Shared among all field types (sort of). */
 		$shared_configuration_keys = array(
 			'id', 'label', 'show_label', 'custom_label', 'custom_class',
-			'only_loggedin' ,'only_loggedin_cap', 'search_filter', 'show_as_link',
+			'only_loggedin', 'only_loggedin_cap', 'search_filter', 'show_as_link',
 		);
 
 		/** Everything else goes into the properties for now. @todo subclasses! */
@@ -273,7 +273,7 @@ 
 
 		/** A custom label is available. */
 		if ( ! empty( $this->custom_label ) ) {
-			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ? : null : null, $entry ? $entry->as_entry() : null );
+			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ?: null : null, $entry ? $entry->as_entry() : null );
 		}
 
 		return '';
@@ -359,7 +359,7 @@ 
 	 * @return mixed|null The value for the given configuration key, null if doesn't exist.
 	 */
 	public function __get( $key ) {
-		switch( $key ) {
+		switch ( $key ) {
 			default:
 				if ( isset( $this->configuration[ $key ] ) ) {
 					return $this->configuration[ $key ];
@@ -377,7 +377,7 @@ 
 	 * @return boolean Whether this $key is set or not.
 	 */
 	public function __isset( $key ) {
-		switch( $key ) {
+		switch ( $key ) {
 			default:
 				return isset( $this->configuration[ $key ] );
 		}

includes/fields/class-gravityview-field-website.php

Spacing +5 added lines, -5 removed lines

@@ -29,9 +29,9 @@ 
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
 		// It makes no sense to use this as the link.
-		unset( $field_options['show_as_link'] );
+		unset( $field_options[ 'show_as_link' ] );
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
@@ -39,12 +39,12 @@ 
 		 * Set default to opening in new links for back-compatibility with Version 1.5.1
 		 * @link https://github.com/gravityview/GravityView/commit/e12e76e2d032754227728d41e65103042d4f75ec
 		 */
-		$field_options['new_window']['value'] = true;
+		$field_options[ 'new_window' ][ 'value' ] = true;
 
 		/**
 		 * @since 1.8
 		 */
-		$field_options['anchor_text'] = array(
+		$field_options[ 'anchor_text' ] = array(
 			'type' => 'text',
 			'label' => __( 'Link Text:', 'gravityview' ),
 			'desc' => __( 'Define custom link text. Leave blank to display the URL', 'gravityview' ),
@@ -52,7 +52,7 @@ 
 			'merge_tags' => 'force',
 		);
 
-		$field_options['truncatelink'] = array(
+		$field_options[ 'truncatelink' ] = array(
 			'type' => 'checkbox',
 			'value' => true,
 			'label' => __( 'Shorten Link Display', 'gravityview' ),

includes/fields/class-gravityview-field-other-entries.php

Spacing +19 added lines, -19 removed lines

@@ -25,7 +25,7 @@ 
 
 	public function __construct() {
 		$this->label = esc_html__( 'Other Entries', 'gravityview' );
-		$this->description = esc_html__('Display other entries created by the entry creator.', 'gravityview');
+		$this->description = esc_html__( 'Display other entries created by the entry creator.', 'gravityview' );
 		parent::__construct();
 	}
 
@@ -35,32 +35,32 @@ 
 	 */
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
 		// No "Link to single entry"; all the items will be links to entries!
-		unset( $field_options['show_as_link'] );
+		unset( $field_options[ 'show_as_link' ] );
 
 		$new_options = array();
 
-		$new_options['link_format'] = array(
+		$new_options[ 'link_format' ] = array(
 			'type'  => 'text',
 			'label' => __( 'Entry link text (required)', 'gravityview' ),
-			'value' => __('Entry #{entry_id}', 'gravityview'),
+			'value' => __( 'Entry #{entry_id}', 'gravityview' ),
 			'merge_tags' => 'force',
 		);
 
-		$new_options['after_link'] = array(
+		$new_options[ 'after_link' ] = array(
 			'type'  => 'textarea',
 			'label' => __( 'Text or HTML to display after the link (optional)', 'gravityview' ),
-			'desc'  => __('This content will be displayed below each entry link.', 'gravityview'),
+			'desc'  => __( 'This content will be displayed below each entry link.', 'gravityview' ),
 			'value' => '',
 			'merge_tags' => 'force',
 			'class' => 'widefat code',
 		);
 
-		$new_options['page_size'] = array(
+		$new_options[ 'page_size' ] = array(
 			'type'  => 'number',
 			'label' => __( 'Entries to Display', 'gravityview' ),
 			'desc'  => __( 'What is the maximum number of entries that should be shown?', 'gravityview' ) . ' ' . sprintf( _x( 'Set to %s for no maximum.', '%s replaced with a formatted 0', 'gravityview' ), '<code>0</code>' ),
@@ -69,14 +69,14 @@ 
 			'min'   => 0,
 		);
 
-		$new_options['no_entries_hide'] = array(
+		$new_options[ 'no_entries_hide' ] = array(
 			'type'  => 'checkbox',
 			'label' => __( 'Hide if no entries', 'gravityview' ),
 			'desc'  => __( 'Don\'t display this field if the entry creator has no other entries', 'gravityview' ),
 			'value' => false,
 		);
 
-		$new_options['no_entries_text'] = array(
+		$new_options[ 'no_entries_text' ] = array(
 			'type'  => 'text',
 			'label' => __( 'No Entries Text', 'gravityview' ),
 			'desc'  => __( 'The text that is shown if the entry creator has no other entries (and "Hide if no entries" is disabled).', 'gravityview' ),
@@ -110,11 +110,11 @@ 
 		foreach ( $filters as $filter ) {
 			foreach ( $wp_filter[ $filter ] as $priority => $callbacks ) {
 				foreach ( $callbacks as $id => $callback ) {
-					if ( ! is_array( $callback['function'] ) ) {
+					if ( ! is_array( $callback[ 'function' ] ) ) {
 						continue;
 					}
-					if ( $callback['function'][0] instanceof \GV\Widget ) {
-						$remove[] = array( $filter, $priority, $id );
+					if ( $callback[ 'function' ][ 0 ] instanceof \GV\Widget ) {
+						$remove[ ] = array( $filter, $priority, $id );
 					}
 				}
 			}
@@ -122,7 +122,7 @@ 
 
 		foreach ( $remove as $r ) {
 			list( $filter, $priority, $id ) = $r;
-			$removed[] = array( $filter, $priority, $id, $wp_filter[ $filter ]->callbacks[ $priority ][ $id ] );
+			$removed[ ] = array( $filter, $priority, $id, $wp_filter[ $filter ]->callbacks[ $priority ][ $id ] );
 			unset( $wp_filter[ $filter ]->callbacks[ $priority ][ $id ] );
 		}
 
@@ -146,10 +146,10 @@ 
 	public function filter_entries( $search_criteria, $form_id = null, $args = array(), $force_search_criteria = false ) {
 		$context = $this->context;
 
-		$created_by = $context->entry['created_by'];
+		$created_by = $context->entry[ 'created_by' ];
 
 		/** Filter entries by approved and created_by. */
-		$search_criteria['field_filters'][] = array(
+		$search_criteria[ 'field_filters' ][ ] = array(
 			'key' => 'created_by',
 			'value' => $created_by,
 			'operator' => 'is'
@@ -169,14 +169,14 @@ 
 		$criteria = apply_filters( 'gravityview/field/other_entries/criteria', $search_criteria, $context->view->settings->as_atts(), $context->view->form->ID, $context );
 
 		/** Force mode all and filter out our own entry. */
-		$search_criteria['field_filters']['mode'] = 'all';
-		$search_criteria['field_filters'][] = array(
+		$search_criteria[ 'field_filters' ][ 'mode' ] = 'all';
+		$search_criteria[ 'field_filters' ][ ] = array(
 			'key' => 'id',
 			'value' => $context->entry->ID,
 			'operator' => 'isnot'
 		);
 
-		$search_criteria['paging']['page_size'] = $context->field->page_size ? : 10;
+		$search_criteria[ 'paging' ][ 'page_size' ] = $context->field->page_size ?: 10;
 
 		return $search_criteria;
 	}

includes/admin/metaboxes/class-gravityview-admin-metaboxes.php

Spacing +10 added lines, -10 removed lines

@@ -52,13 +52,13 @@ 
 	function update_priority() {
 		global $wp_meta_boxes;
 
-		if ( ! empty( $wp_meta_boxes['gravityview'] ) ) {
+		if ( ! empty( $wp_meta_boxes[ 'gravityview' ] ) ) {
 			foreach ( array( 'high', 'core', 'low' ) as $position ) {
-				if ( isset( $wp_meta_boxes['gravityview']['normal'][ $position ] ) ) {
-					foreach ( $wp_meta_boxes['gravityview']['normal'][ $position ] as $key => $meta_box ) {
+				if ( isset( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ] ) ) {
+					foreach ( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ] as $key => $meta_box ) {
 						if ( ! preg_match( '/^gravityview_/ism', $key ) ) {
-							$wp_meta_boxes['gravityview']['advanced'][ $position ][ $key ] = $meta_box;
-							unset( $wp_meta_boxes['gravityview']['normal'][ $position ][ $key ] );
+							$wp_meta_boxes[ 'gravityview' ][ 'advanced' ][ $position ][ $key ] = $meta_box;
+							unset( $wp_meta_boxes[ 'gravityview' ][ 'normal' ][ $position ][ $key ] );
 						}
 					}
 				}
@@ -191,7 +191,7 @@ 
 
 		foreach ( $metaboxes as $m ) {
 
-			$tab = new GravityView_Metabox_Tab( $m['id'], $m['title'], $m['file'], $m['icon-class'], $m['callback'], $m['callback_args'] );
+			$tab = new GravityView_Metabox_Tab( $m[ 'id' ], $m[ 'title' ], $m[ 'file' ], $m[ 'icon-class' ], $m[ 'callback' ], $m[ 'callback_args' ] );
 
 			GravityView_Metabox_Tabs::add( $tab );
 
@@ -261,13 +261,13 @@ 
 
 		$form = gravityview_get_form( $curr_form );
 
-		$get_id_backup = isset( $_GET['id'] ) ? $_GET['id'] : null;
+		$get_id_backup = isset( $_GET[ 'id' ] ) ? $_GET[ 'id' ] : null;
 
-		if ( isset( $form['id'] ) ) {
+		if ( isset( $form[ 'id' ] ) ) {
 			$form_script = 'var form = ' . GFCommon::json_encode( $form ) . ';';
 
 			// The `gf_vars()` method needs a $_GET[id] variable set with the form ID.
-			$_GET['id'] = $form['id'];
+			$_GET[ 'id' ] = $form[ 'id' ];
 
 		} else {
 			$form_script = 'var form = new Form();';
@@ -276,7 +276,7 @@ 
 		$output = '<script type="text/javascript" data-gv-merge-tags="1">' . $form_script . "\n" . GFCommon::gf_vars( false ) . '</script>';
 
 		// Restore previous $_GET setting
-		$_GET['id'] = $get_id_backup;
+		$_GET[ 'id' ] = $get_id_backup;
 
 		return $output;
 	}

includes/extensions/delete-entry/class-delete-entry.php

Indentation +1 added lines, -1 removed lines

@@ -532,7 +532,7 @@
 				 * @since 1.16.4
 				 * @param  int $entry_id ID of the Gravity Forms entry
 				 * @param  array $entry Deleted entry array
-				*/
+				 */
 				do_action( 'gravityview/delete-entry/deleted', $entry_id, $entry );
 			}
 

Doc Comments +4 added lines, -4 removed lines

@@ -63,7 +63,7 @@ 
 	 *
 	 * @since 2.9.2
 	 *
-	 * @param $component
+	 * @param string $component
 	 */
 	private function load_components( $component ) {
 
@@ -423,7 +423,7 @@ 
 	 * @uses GFAPI::delete_entry()
 	 * @uses GFAPI::update_entry_property()
 	 *
-	 * @return WP_Error|string "deleted" or "trashed" if successful, WP_Error if GFAPI::delete_entry() or updating entry failed.
+	 * @return string "deleted" or "trashed" if successful, WP_Error if GFAPI::delete_entry() or updating entry failed.
 	 */
 	private function delete_or_trash_entry( $entry ) {
 
@@ -590,7 +590,7 @@ 
 	 *
 	 * @since 1.5.1
 	 * @param  array $entry Gravity Forms entry array
-	 * @return boolean|WP_Error        True: can edit form. WP_Error: nope.
+	 * @return string        True: can edit form. WP_Error: nope.
 	 */
 	function user_can_delete_entry( $entry = array(), $view_id = null ) {
 
@@ -631,7 +631,7 @@ 
 	 *
 	 * @param  array $entry Gravity Forms entry array
 	 * @param array $field Field settings (optional)
-	 * @param int|\GV\View $view Pass a View ID to check caps against. If not set, check against current View (@deprecated no longer optional)
+	 * @param integer $view Pass a View ID to check caps against. If not set, check against current View (@deprecated no longer optional)
 	 * @return bool
 	 */
 	public static function check_user_cap_delete_entry( $entry, $field = array(), $view = 0 ) {

Spacing +26 added lines, -26 removed lines

@@ -165,7 +165,7 @@ 
 
 		// Index 100 is the default GravityView template path.
 		// Index 110 is Edit Entry link
-		$file_paths[115] = self::$file;
+		$file_paths[ 115 ] = self::$file;
 
 		return $file_paths;
 	}
@@ -269,7 +269,7 @@ 
 
 		$attributes = array(
 			'class' => 'btn btn-sm button button-small alignright pull-right btn-danger gv-button-delete',
-			'tabindex' => ( GFCommon::$tab_index ++ ),
+			'tabindex' => ( GFCommon::$tab_index++ ),
 			'onclick' => self::get_confirm_dialog(),
 		);
 
@@ -305,12 +305,12 @@ 
 		);
 
 		// If the form is not submitted, return early
-		if ( 'delete' !== $get_fields['action'] || empty( $get_fields['entry_id'] ) ) {
+		if ( 'delete' !== $get_fields[ 'action' ] || empty( $get_fields[ 'entry_id' ] ) ) {
 			return;
 		}
 
 		// Make sure it's a GravityView request
-		$valid_nonce_key = wp_verify_nonce( $get_fields['delete'], self::get_nonce_key( $get_fields['entry_id'] ) );
+		$valid_nonce_key = wp_verify_nonce( $get_fields[ 'delete' ], self::get_nonce_key( $get_fields[ 'entry_id' ] ) );
 
 		if ( ! $valid_nonce_key ) {
 			gravityview()->log->debug( 'Delete entry not processed: nonce validation failed.' );
@@ -319,10 +319,10 @@ 
 		}
 
 		// Get the entry slug
-		$entry_slug = esc_attr( $get_fields['entry_id'] );
+		$entry_slug = esc_attr( $get_fields[ 'entry_id' ] );
 
 		// Redirect after deleting the entry.
-		$view = \GV\View::by_id( $get_fields['view_id'] );
+		$view = \GV\View::by_id( $get_fields[ 'view_id' ] );
 
 		// See if there's an entry there
 		$entry = gravityview_get_entry( $entry_slug, true, false, $view );
@@ -349,9 +349,9 @@ 
 			$this->_redirect_and_exit( $delete_redirect_base, $delete_response->get_error_message(), 'error' );
 		}
 
-		if ( (int) $view->settings->get( 'delete_redirect' ) === self::REDIRECT_TO_URL_VALUE ) {
+		if ( (int)$view->settings->get( 'delete_redirect' ) === self::REDIRECT_TO_URL_VALUE ) {
 
-			$form                 = GFAPI::get_form( $entry['form_id'] );
+			$form                 = GFAPI::get_form( $entry[ 'form_id' ] );
 			$redirect_url_setting = $view->settings->get( 'delete_redirect_url' );
 			$redirect_url         = GFCommon::replace_variables( $redirect_url_setting, $form, $entry, false, false, false, 'text' );
 
@@ -427,7 +427,7 @@ 
 	 */
 	private function delete_or_trash_entry( $entry ) {
 
-		$entry_id = $entry['id'];
+		$entry_id = $entry[ 'id' ];
 
 		$mode = $this->get_delete_mode();
 
@@ -491,7 +491,7 @@ 
 	public function process_connected_posts( $entry_id = 0, $entry = array() ) {
 
 		// The entry had no connected post
-		if ( empty( $entry['post_id'] ) ) {
+		if ( empty( $entry[ 'post_id' ] ) ) {
 			return;
 		}
 
@@ -509,9 +509,9 @@ 
 		$action = current_action();
 
 		if ( 'gravityview/delete-entry/deleted' === $action ) {
-			$result = wp_delete_post( $entry['post_id'], true );
+			$result = wp_delete_post( $entry[ 'post_id' ], true );
 		} else {
-			$result = wp_trash_post( $entry['post_id'] );
+			$result = wp_trash_post( $entry[ 'post_id' ] );
 		}
 
 		if ( false === $result ) {
@@ -542,13 +542,13 @@ 
 	public function verify_nonce() {
 
 		// No delete entry request was made
-		if ( empty( $_GET['entry_id'] ) || empty( $_GET['delete'] ) ) {
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'delete' ] ) ) {
 			return false;
 		}
 
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
 
-		$valid = wp_verify_nonce( $_GET['delete'], $nonce_key );
+		$valid = wp_verify_nonce( $_GET[ 'delete' ], $nonce_key );
 
 		/**
 		 * @filter `gravityview/delete-entry/verify_nonce` Override Delete Entry nonce validation. Return true to declare nonce valid.
@@ -604,7 +604,7 @@ 
 			$error = __( 'You do not have permission to delete this entry.', 'gravityview' );
 		}
 
-		if ( $entry['status'] === 'trash' ) {
+		if ( $entry[ 'status' ] === 'trash' ) {
 			if ( 'trash' === $this->get_delete_mode() ) {
 				$error = __( 'The entry is already in the trash.', 'gravityview' );
 			} else {
@@ -648,7 +648,7 @@ 
 
 		$current_user = wp_get_current_user();
 
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : null;
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : null;
 
 		// Or if they can delete any entries (as defined in Gravity Forms), we're good.
 		if ( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
@@ -662,17 +662,17 @@ 
 		if ( ! empty( $field ) ) {
 
 			// If capability is not defined, something is not right!
-			if ( empty( $field['allow_edit_cap'] ) ) {
+			if ( empty( $field[ 'allow_edit_cap' ] ) ) {
 
 				gravityview()->log->error( 'Cannot read delete entry field caps', array( 'data' => $field ) );
 
 				return false;
 			}
 
-			if ( GVCommon::has_cap( $field['allow_edit_cap'] ) ) {
+			if ( GVCommon::has_cap( $field[ 'allow_edit_cap' ] ) ) {
 
 				// Do not return true if cap is read, as we need to check if the current user created the entry
-				if ( $field['allow_edit_cap'] !== 'read' ) {
+				if ( $field[ 'allow_edit_cap' ] !== 'read' ) {
 					return true;
 				}
 			} else {
@@ -683,7 +683,7 @@ 
 			}
 		}
 
-		if ( ! isset( $entry['created_by'] ) ) {
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
 
 			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.' );
 
@@ -699,7 +699,7 @@ 
 		}
 
 		// If the logged-in user is the same as the user who created the entry, we're good.
-		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
 
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
 
@@ -724,12 +724,12 @@ 
 	 */
 	public function maybe_display_message( $current_view_id = 0 ) {
 
-		if ( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
 			return;
 		}
 
 		// Entry wasn't deleted from current View
-		if ( isset( $_GET['view_id'] ) && intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) {
+		if ( isset( $_GET[ 'view_id' ] ) && intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) {
 			return;
 		}
 
@@ -738,11 +738,11 @@ 
 
 	public function display_message() {
 
-		if ( empty( $_GET['status'] ) || empty( $_GET['delete'] ) ) {
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'delete' ] ) ) {
 			return;
 		}
 
-		$status = esc_attr( $_GET['status'] );
+		$status = esc_attr( $_GET[ 'status' ] );
 		$message_from_url = \GV\Utils::_GET( 'message' );
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
 		$class = '';

future/includes/class-gv-settings-view.php

Spacing +3 added lines, -3 removed lines

@@ -531,7 +531,7 @@ 
 		);
 
 		if ( version_compare( \GFCommon::$version, '2.3-beta-4', '>=' ) ) {
-			$default_settings['sort_direction']['options']['RAND'] = __( 'Random', 'gravityview' );
+			$default_settings[ 'sort_direction' ][ 'options' ][ 'RAND' ] = __( 'Random', 'gravityview' );
 		}
 
 		/**
@@ -552,7 +552,7 @@ 
 		if ( ! $detailed ) {
 			$defaults = array();
 			foreach ( $default_settings as $key => $value ) {
-				$defaults[ $key ] = $value['value'];
+				$defaults[ $key ] = $value[ 'value' ];
 			}
 			return $defaults;
 
@@ -563,7 +563,7 @@ 
 				// If the $group argument is set for the method,
 				// ignore any settings that aren't in that group.
 				if ( ! empty( $group ) && is_string( $group ) ) {
-					if ( empty( $value['group'] ) || $value['group'] !== $group ) {
+					if ( empty( $value[ 'group' ] ) || $value[ 'group' ] !== $group ) {
 						unset( $default_settings[ $key ] );
 					}
 				}