View GitHub Repository GravityView

Schedule Inspection
Subscribe
Completed
Pull Request — master (#747)
by Steve
19:06
created
Status
Category
Toggle Patches
includes/widgets/search-widget/templates/search-field-hidden.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -7,4 +7,4 @@
 
 block discarded – undo
7 7
8 8 
 $gravityview_view = GravityView_View::getInstance();
9 9 
 $search_field = $gravityview_view->search_field;
10 
-?><div><input type="hidden" name="<?php echo esc_attr( $search_field['name'] ); ?>" value="<?php echo esc_attr( $search_field['value'] ); ?>"></div>
11 10 
\ No newline at end of file
11 
+?><div><input type="hidden" name="<?php echo esc_attr( $search_field[ 'name' ] ); ?>" value="<?php echo esc_attr( $search_field[ 'value' ] ); ?>"></div>
12 12 
\ No newline at end of file
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-date_range.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -7,17 +7,17 @@
 
 block discarded – undo
7 7
8 8 
 $gravityview_view = GravityView_View::getInstance();
9 9 
 $view_id = $gravityview_view->getViewId();
10 
-$value = $gravityview_view->search_field['value'];
11 
-$label = $gravityview_view->search_field['label'];
12 
-$name = $gravityview_view->search_field['name'];
10 
+$value = $gravityview_view->search_field[ 'value' ];
11 
+$label = $gravityview_view->search_field[ 'label' ];
12 
+$name = $gravityview_view->search_field[ 'name' ];
13 13 
 ?>
14 14
15 15 
 <div class="gv-search-box gv-search-date">
16 
-	<?php if( ! gv_empty( $label, false ) ) { ?>
17 
-	<label for="search-box-<?php echo esc_attr( $name ).'-start'; ?>"><?php echo esc_html( $label ); ?></label>
16 
+	<?php if ( ! gv_empty( $label, false ) ) { ?>
17 
+	<label for="search-box-<?php echo esc_attr( $name ) . '-start'; ?>"><?php echo esc_html( $label ); ?></label>
18 18 
 	<?php } ?>
19 19 
 	<p>
20 
-		<input name="<?php echo esc_attr( $name ).'[start]'; ?>" id="search-box-<?php echo esc_attr( $name ).'-start'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('Start date', 'gravityview' ); ?>" value="<?php echo $value['start']; ?>">
21 
-		<input name="<?php echo esc_attr( $name ).'[end]'; ?>" id="search-box-<?php echo esc_attr( $name ).'-end'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('End date', 'gravityview' ); ?>" value="<?php echo $value['end']; ?>">
20 
+		<input name="<?php echo esc_attr( $name ) . '[start]'; ?>" id="search-box-<?php echo esc_attr( $name ) . '-start'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'Start date', 'gravityview' ); ?>" value="<?php echo $value[ 'start' ]; ?>">
21 
+		<input name="<?php echo esc_attr( $name ) . '[end]'; ?>" id="search-box-<?php echo esc_attr( $name ) . '-end'; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'End date', 'gravityview' ); ?>" value="<?php echo $value[ 'end' ]; ?>">
22 22 
 	</p>
23 23 
 </div>
24 24 
\ No newline at end of file
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-search_all.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -7,14 +7,14 @@
 
 block discarded – undo
7 7
8 8 
 $gravityview_view = GravityView_View::getInstance();
9 9 
 $view_id = $gravityview_view->getViewId();
10 
-$value = $gravityview_view->search_field['value'];
11 
-$label = $gravityview_view->search_field['label'];
10 
+$value = $gravityview_view->search_field[ 'value' ];
11 
+$label = $gravityview_view->search_field[ 'label' ];
12 12
13 13 
 ?>
14 14
15 15 
 <div class="gv-search-box">
16 16 
 	<div class="gv-search">
17 
-	<?php if( ! gv_empty( $label, false ) ) { ?>
17 
+	<?php if ( ! gv_empty( $label, false ) ) { ?>
18 18 
 		<label for="gv_search_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
19 19 
 	<?php } ?>
20 20 
 		<p><input type="text" name="gv_search" id="gv_search_<?php echo $view_id; ?>" value="<?php echo $value; ?>" /></p>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-entry_id.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -7,13 +7,13 @@
 
 block discarded – undo
7 7
8 8 
 $gravityview_view = GravityView_View::getInstance();
9 9 
 $view_id = $gravityview_view->getViewId();
10 
-$value = $gravityview_view->search_field['value'];
11 
-$label = $gravityview_view->search_field['label'];
10 
+$value = $gravityview_view->search_field[ 'value' ];
11 
+$label = $gravityview_view->search_field[ 'label' ];
12 12 
 ?>
13 13
14 14 
 <div class="gv-search-box">
15 15 
 	<div class="gv-search">
16 
-		<?php if( ! gv_empty( $label, false ) ) { ?>
16 
+		<?php if ( ! gv_empty( $label, false ) ) { ?>
17 17 
 		<label for="gv_entry_id_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18 
 		<?php } ?>
19 19 
 		<p><input type="text" name="gv_id" id="gv_entry_id_<?php echo $view_id; ?>" value="<?php echo $value; ?>" /></p>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-checkbox.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -10,22 +10,22 @@
 
 block discarded – undo
10 10 
 $search_field = $gravityview_view->search_field;
11 11
12 12 
 // Make sure that there are choices to display
13 
-if( empty( $search_field['choices'] ) ) {
14 
-	do_action('gravityview_log_debug', 'search-field-checkbox.php - No choices for field' );
13 
+if ( empty( $search_field[ 'choices' ] ) ) {
14 
+	do_action( 'gravityview_log_debug', 'search-field-checkbox.php - No choices for field' );
15 15 
 	return;
16 16 
 }
17 17
18 18 
 ?>
19 19 
 <div class="gv-search-box">
20 
-	<?php if( ! gv_empty( $search_field['label'], false ) ) { ?>
21 
-	<label for=search-box-<?php echo esc_attr( $search_field['name'] ); ?>><?php echo esc_html( $search_field['label'] ); ?></label>
20 
+	<?php if ( ! gv_empty( $search_field[ 'label' ], false ) ) { ?>
21 
+	<label for=search-box-<?php echo esc_attr( $search_field[ 'name' ] ); ?>><?php echo esc_html( $search_field[ 'label' ] ); ?></label>
22 22 
 	<?php } ?>
23 23 
 	<p>
24 
-	<?php foreach( $search_field['choices'] as $choice ) { ?>
24 
+	<?php foreach ( $search_field[ 'choices' ] as $choice ) { ?>
25 25
26 
-		<label for="search-box-<?php echo sanitize_html_class( $search_field['name'].$choice['value'].$choice['text'] ); ?>" class="gv-check-radio">
27 
-			<input type="checkbox" name="<?php echo esc_attr( $search_field['name'] ); ?>[]" value="<?php echo esc_attr( $choice['value'] ); ?>" id="search-box-<?php echo sanitize_html_class( $search_field['name'].$choice['value'].$choice['text'] ); ?>" <?php gv_selected( $choice['value'], $search_field['value'], true, 'checked' ); ?>>
28 
-			<?php echo esc_html( $choice['text'] ); ?>
26 
+		<label for="search-box-<?php echo sanitize_html_class( $search_field[ 'name' ] . $choice[ 'value' ] . $choice[ 'text' ] ); ?>" class="gv-check-radio">
27 
+			<input type="checkbox" name="<?php echo esc_attr( $search_field[ 'name' ] ); ?>[]" value="<?php echo esc_attr( $choice[ 'value' ] ); ?>" id="search-box-<?php echo sanitize_html_class( $search_field[ 'name' ] . $choice[ 'value' ] . $choice[ 'text' ] ); ?>" <?php gv_selected( $choice[ 'value' ], $search_field[ 'value' ], true, 'checked' ); ?>>
28 
+			<?php echo esc_html( $choice[ 'text' ] ); ?>
29 29 
 		</label>
30 30
31 31 
 	<?php } ?>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-entry_date.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -7,17 +7,17 @@
 
 block discarded – undo
7 7
8 8 
 $gravityview_view = GravityView_View::getInstance();
9 9 
 $view_id = $gravityview_view->getViewId();
10 
-$value = $gravityview_view->search_field['value'];
11 
-$label = $gravityview_view->search_field['label'];
10 
+$value = $gravityview_view->search_field[ 'value' ];
11 
+$label = $gravityview_view->search_field[ 'label' ];
12 12
13 13 
 ?>
14 14
15 15 
 <div class="gv-search-box gv-search-date">
16 
-	<?php if( ! gv_empty( $label, false ) ) { ?>
16 
+	<?php if ( ! gv_empty( $label, false ) ) { ?>
17 17 
 	<label for="gv_start_date_<?php echo $view_id; ?>"><?php echo esc_html( $label ); ?></label>
18 18 
 	<?php } ?>
19 19 
 	<p>
20 
-		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('Start date', 'gravityview' ); ?>" value="<?php echo $value['start']; ?>">
21 
-		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e('End date', 'gravityview' ); ?>" value="<?php echo $value['end']; ?>">
20 
+		<input name="gv_start" id="gv_start_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'Start date', 'gravityview' ); ?>" value="<?php echo $value[ 'start' ]; ?>">
21 
+		<input name="gv_end" id="gv_end_date_<?php echo $view_id; ?>" type="text" class="<?php echo esc_html( $gravityview_view->datepicker_class ); ?>" placeholder="<?php esc_attr_e( 'End date', 'gravityview' ); ?>" value="<?php echo $value[ 'end' ]; ?>">
22 22 
 	</p>
23 23 
 </div>
24 24 
\ No newline at end of file
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-radio.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -10,22 +10,22 @@
 
 block discarded – undo
10 10 
 $search_field = $gravityview_view->search_field;
11 11
12 12 
 // Make sure that there are choices to display
13 
-if( empty( $search_field['choices'] ) ) {
14 
-	do_action('gravityview_log_debug', 'search-field-radio.php - No choices for field' );
13 
+if ( empty( $search_field[ 'choices' ] ) ) {
14 
+	do_action( 'gravityview_log_debug', 'search-field-radio.php - No choices for field' );
15 15 
 	return;
16 16 
 }
17 17
18 18 
 ?>
19 19 
 <div class="gv-search-box">
20 
-	<?php if( ! gv_empty( $search_field['label'], false ) ) { ?>
21 
-	<label for=search-box-<?php echo esc_attr( $search_field['name'] ); ?>><?php echo esc_html( $search_field['label'] ); ?></label>
20 
+	<?php if ( ! gv_empty( $search_field[ 'label' ], false ) ) { ?>
21 
+	<label for=search-box-<?php echo esc_attr( $search_field[ 'name' ] ); ?>><?php echo esc_html( $search_field[ 'label' ] ); ?></label>
22 22 
 	<?php } ?>
23 23 
 	<p>
24 
-	<?php foreach( $search_field['choices'] as $choice ) { ?>
24 
+	<?php foreach ( $search_field[ 'choices' ] as $choice ) { ?>
25 25
26 
-		<label for="search-box-<?php echo sanitize_html_class( $search_field['name'].$choice['value'].$choice['text'] ); ?>" class="gv-check-radio">
27 
-			<input type="radio" name="<?php echo esc_attr( $search_field['name'] ); ?>" value="<?php echo esc_attr( $choice['value'] ); ?>" id="search-box-<?php echo sanitize_html_class( $search_field['name'].$choice['value'].$choice['text'] ); ?>" <?php checked( $choice['value'], $search_field['value'], true ); ?>>
28 
-			<?php echo esc_html( $choice['text'] ); ?>
26 
+		<label for="search-box-<?php echo sanitize_html_class( $search_field[ 'name' ] . $choice[ 'value' ] . $choice[ 'text' ] ); ?>" class="gv-check-radio">
27 
+			<input type="radio" name="<?php echo esc_attr( $search_field[ 'name' ] ); ?>" value="<?php echo esc_attr( $choice[ 'value' ] ); ?>" id="search-box-<?php echo sanitize_html_class( $search_field[ 'name' ] . $choice[ 'value' ] . $choice[ 'text' ] ); ?>" <?php checked( $choice[ 'value' ], $search_field[ 'value' ], true ); ?>>
28 
+			<?php echo esc_html( $choice[ 'text' ] ); ?>
29 29 
 		</label>
30 30
31 31 
 	<?php } ?>
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-single_checkbox.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -12,8 +12,8 @@
 
 block discarded – undo
12 12 
 ?>
13 13
14 14 
 <div class="gv-search-box">
15 
-	<label for="search-box-<?php echo esc_attr( $search_field['name'] ); ?>" class="gv-check-radio">
16 
-		<input type="checkbox" name="<?php echo esc_attr( $search_field['name'] ); ?>" value="1" id="search-box-<?php echo esc_attr( $search_field['name'] ); ?>" <?php checked( '1', $search_field['value'], true ); ?>>
17 
-			<?php if( ! gv_empty( $search_field['label'], false ) ) { echo esc_html(  $search_field['label'] ); } ?>
15 
+	<label for="search-box-<?php echo esc_attr( $search_field[ 'name' ] ); ?>" class="gv-check-radio">
16 
+		<input type="checkbox" name="<?php echo esc_attr( $search_field[ 'name' ] ); ?>" value="1" id="search-box-<?php echo esc_attr( $search_field[ 'name' ] ); ?>" <?php checked( '1', $search_field[ 'value' ], true ); ?>>
17 
+			<?php if ( ! gv_empty( $search_field[ 'label' ], false ) ) { echo esc_html( $search_field[ 'label' ] ); } ?>
18 18 
 	</label>
19 19 
 </div>
20 20 
\ No newline at end of file
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/widget-search.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -23,12 +23,12 @@  discard block
 
 block discarded – undo
23 23 
 	 */
24 24 
 	do_action( 'gravityview_search_widget_fields_before', $this );
25 25
26 
-	foreach( $this->search_fields as $search_field ) {
26 
+	foreach ( $this->search_fields as $search_field ) {
27 27 
 		$gravityview_view->search_field = $search_field;
28 
-		$this->render( 'search-field', $search_field['input'], false );
28 
+		$this->render( 'search-field', $search_field[ 'input' ], false );
29 29
30 30 
 		// show/hide the search button if there are input type fields
31 
-		if( !$has_inputs &&  $search_field['input'] != 'link' ) {
31 
+		if ( ! $has_inputs && $search_field[ 'input' ] != 'link' ) {
32 32 
 			$has_inputs = true;
33 33 
 		}
34 34 
 	}
 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
 	 */
40 40 
 	do_action( 'gravityview_search_widget_fields_after', $this );
41 41
42 
-	if( $has_inputs ) { ?>
42 
+	if ( $has_inputs ) { ?>
43 43 
 		<div class="gv-search-box gv-search-box-submit">
44 44 
 			<?php
45 45
Please login to merge, or discard this patch.