GravityView_GF_Entries_List

Complexity

Total Complexity

5

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	add_edit_script()	0	18	3
A	add_edit_link()	0	17	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 6 and the first side effect is on line 73.

/**
 * Actions to be performed on the Gravity Forms Entries list screen
 */
class GravityView_GF_Entries_List {

	function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

		// Add Edit link to the entry actions
		add_action( 'gform_entries_first_column_actions', array( $this, 'add_edit_link' ), 10, 5 );

		// Add script to enable edit link
		add_action( 'admin_head-forms_page_gf_entries', array( $this, 'add_edit_script') );

No space before closing parenthesis of array is bad style

	}

	/**
	 * When clicking the edit link, convert the Entries form to go to the edit screen.
	 *
	 * Gravity Forms requires $_POST['screen_mode'] to be set to get to the "Edit" mode. This enables direct access to the edit mode.
	 *
	 * @hack
	 * @return void
	 */
	public function add_edit_script() {

		// We're on a single entry page, or at least not the Entries page.
		if( !empty( $_GET['view'] ) && $_GET['view'] !== 'entries' ) { return; }

Found "!== '". Use Yoda Condition checks, you must

Space after opening control structure is required

Expected 1 space after "!"; 0 found

Detected access of super global var $_GET, probably need manual inspection.

Detected usage of a non-sanitized input variable: $_GET

	?>
		<script>
		jQuery( document ).ready( function( $ ) {
			$('.edit_entry a').click(function(e) {
				e.preventDefault();
				$( e.target ).parents('form')
					.prepend('<input name="screen_mode" type="hidden" value="edit" />')
					.attr('action', $(e.target).attr('href') )
					.submit();
			});
		});
		</script>
	<?php
	}

	/**
	 * Add an Edit link to the GF Entry actions row
	 * @param int $form_id      ID of the current form
	 * @param int $field_id     The ID of the field in the first column, where the row actions are shown
	 * @param string $value        The value of the `$field_id` field
	 * @param array  $lead         The current entry data
	 * @param string $query_string URL query string for a link to the current entry. Missing the `?page=` part, which is strange. Example: `gf_entries&view=entry&id=35&lid=5212&filter=&paged=1`
	 */
	function add_edit_link( $form_id = NULL, $field_id = NULL, $value = NULL, $lead = array(), $query_string = NULL ) {

It is generally recommended to explicitly declare the visibility for methods.

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

		$params = array(
			'page' => 'gf_entries',
			'view' => 'entry',
			'id'	=> (int)$form_id,

No space after closing casting parenthesis is prohibited

			'lid'	=>	(int)$lead["id"],

Expected 1 space after "=>"; 2 found

No space after closing casting parenthesis is prohibited

The string literal id does not require double quotes, as per coding-style, please use single quotes.

			'screen_mode'	=> 'edit',
		);
		?>

		<span class="edit edit_entry">
			|
		    <a title="<?php esc_attr_e( 'Edit this entry', 'gravityview'); ?>" href="<?php echo esc_url( add_query_arg( $params, admin_url( 'admin.php?page='.$query_string ) ) ); ?>"><?php esc_html_e( 'Edit', 'gravityview' ); ?></a>

Expected 1 spaces before closing bracket; 0 found

		</span>
		<?php
	}

}

new GravityView_GF_Entries_List;