Completed
Push — master ( 4ba683...3a59f6 )
by Zack
31:21 queued 27:45
created
includes/class-frontend-views.php 1 patch
Spacing   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 	private function __construct() {}
86 86
 
87 87
 	private function initialize() {
88
-		add_action( 'wp', array( $this, 'parse_content'), 11 );
88
+		add_action( 'wp', array( $this, 'parse_content' ), 11 );
89 89
 		add_filter( 'parse_query', array( $this, 'parse_query_fix_frontpage' ), 10 );
90
-		add_action( 'template_redirect', array( $this, 'set_entry_data'), 1 );
90
+		add_action( 'template_redirect', array( $this, 'set_entry_data' ), 1 );
91 91
 
92 92
 		// Enqueue scripts and styles after GravityView_Template::register_styles()
93 93
 		add_action( 'wp_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 20 );
@@ -236,12 +236,12 @@  discard block
 block discarded – undo
236 236
 
237 237
 			$this->context_view_id = $view_id;
238 238
 
239
-		} elseif ( isset( $_GET['gvid'] ) && $multiple_views ) {
239
+		} elseif ( isset( $_GET[ 'gvid' ] ) && $multiple_views ) {
240 240
 			/**
241 241
 			 * used on a has_multiple_views context
242 242
 			 * @see GravityView_API::entry_link
243 243
 			 */
244
-			$this->context_view_id = $_GET['gvid'];
244
+			$this->context_view_id = $_GET[ 'gvid' ];
245 245
 
246 246
 		} elseif ( ! $multiple_views ) {
247 247
 			$array_keys = array_keys( $this->getGvOutputData()->get_views() );
@@ -278,25 +278,25 @@  discard block
 block discarded – undo
278 278
 		global $wp_rewrite;
279 279
 
280 280
 		$is_front_page = ( $query->is_home || $query->is_page );
281
-		$show_on_front = ( 'page' === get_option('show_on_front') );
282
-		$front_page_id = get_option('page_on_front');
281
+		$show_on_front = ( 'page' === get_option( 'show_on_front' ) );
282
+		$front_page_id = get_option( 'page_on_front' );
283 283
 
284
-		if (  $is_front_page && $show_on_front && $front_page_id ) {
284
+		if ( $is_front_page && $show_on_front && $front_page_id ) {
285 285
 
286 286
 			// Force to be an array, potentially a query string ( entry=16 )
287 287
 			$_query = wp_parse_args( $query->query );
288 288
 
289 289
 			// pagename can be set and empty depending on matched rewrite rules. Ignore an empty pagename.
290
-			if ( isset( $_query['pagename'] ) && '' === $_query['pagename'] ) {
291
-				unset( $_query['pagename'] );
290
+			if ( isset( $_query[ 'pagename' ] ) && '' === $_query[ 'pagename' ] ) {
291
+				unset( $_query[ 'pagename' ] );
292 292
 			}
293 293
 
294 294
 			// this is where will break from core wordpress
295 295
 			/** @internal Don't use this filter; it will be unnecessary soon - it's just a patch for specific use case */
296 296
 			$ignore = apply_filters( 'gravityview/internal/ignored_endpoints', array( 'preview', 'page', 'paged', 'cpage' ), $query );
297 297
 			$endpoints = \GV\Utils::get( $wp_rewrite, 'endpoints' );
298
-			foreach ( (array) $endpoints as $endpoint ) {
299
-				$ignore[] = $endpoint[1];
298
+			foreach ( (array)$endpoints as $endpoint ) {
299
+				$ignore[ ] = $endpoint[ 1 ];
300 300
 			}
301 301
 			unset( $endpoints );
302 302
 
@@ -306,21 +306,21 @@  discard block
 block discarded – undo
306 306
 			// - The query includes keys that are associated with registered endpoints. `entry`, for example.
307 307
 			if ( empty( $_query ) || ! array_diff( array_keys( $_query ), $ignore ) ) {
308 308
 
309
-				$qv =& $query->query_vars;
309
+				$qv = & $query->query_vars;
310 310
 
311 311
 				// Prevent redirect when on the single entry endpoint
312
-				if( self::is_single_entry() ) {
312
+				if ( self::is_single_entry() ) {
313 313
 					add_filter( 'redirect_canonical', '__return_false' );
314 314
 				}
315 315
 
316 316
 				$query->is_page = true;
317 317
 				$query->is_home = false;
318
-				$qv['page_id']  = $front_page_id;
318
+				$qv[ 'page_id' ]  = $front_page_id;
319 319
 
320 320
 				// Correct <!--nextpage--> for page_on_front
321
-				if ( ! empty( $qv['paged'] ) ) {
322
-					$qv['page'] = $qv['paged'];
323
-					unset( $qv['paged'] );
321
+				if ( ! empty( $qv[ 'paged' ] ) ) {
322
+					$qv[ 'page' ] = $qv[ 'paged' ];
323
+					unset( $qv[ 'paged' ] );
324 324
 				}
325 325
 			}
326 326
 
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
 		$this->setIsGravityviewPostType( get_post_type( $post ) === 'gravityview' );
352 352
 
353
-		$post_id = $this->getPostId() ? $this->getPostId() : (isset( $post ) ? $post->ID : null );
353
+		$post_id = $this->getPostId() ? $this->getPostId() : ( isset( $post ) ? $post->ID : null );
354 354
 		$this->setPostId( $post_id );
355 355
 		$post_has_shortcode = ! empty( $post->post_content ) ? gravityview_has_shortcode_r( $post->post_content, 'gravityview' ) : false;
356 356
 		$this->setPostHasShortcode( $this->isGravityviewPostType() ? null : ! empty( $post_has_shortcode ) );
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
 
387 387
 		$search_method = GravityView_Widget_Search::getInstance()->get_search_method();
388 388
 
389
-		if( 'post' === $search_method ) {
389
+		if ( 'post' === $search_method ) {
390 390
 			$get = $_POST;
391 391
 		} else {
392 392
 			$get = $_GET;
@@ -443,20 +443,20 @@  discard block
 block discarded – undo
443 443
 		 * @param boolean $in_the_loop Whether to apply the filter to the menu title and the meta tag <title> - outside the loop
444 444
 		 * @param array $entry Current entry
445 445
 		 */
446
-		$apply_outside_loop = apply_filters( 'gravityview/single/title/out_loop' , in_the_loop(), $entry );
446
+		$apply_outside_loop = apply_filters( 'gravityview/single/title/out_loop', in_the_loop(), $entry );
447 447
 
448 448
 		if ( ! $apply_outside_loop ) {
449 449
 			return $title;
450 450
 		}
451 451
 
452 452
 		// User reported WooCommerce doesn't pass two args.
453
-		if ( empty( $passed_post_id ) )  {
453
+		if ( empty( $passed_post_id ) ) {
454 454
 			return $title;
455 455
 		}
456 456
 
457 457
 		// Don't modify the title for anything other than the current view/post.
458 458
 		// This is true for embedded shortcodes and Views.
459
-		if ( is_object( $post ) && (int) $post->ID !== (int) $passed_post_id ) {
459
+		if ( is_object( $post ) && (int)$post->ID !== (int)$passed_post_id ) {
460 460
 			return $title;
461 461
 		}
462 462
 
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
 			$view_meta = $this->getGvOutputData()->get_view( $context_view_id );
469 469
 		} else {
470 470
 			foreach ( $this->getGvOutputData()->get_views() as $view_id => $view_data ) {
471
-				if ( intval( $view_data['form_id'] ) === intval( $entry['form_id'] ) ) {
471
+				if ( intval( $view_data[ 'form_id' ] ) === intval( $entry[ 'form_id' ] ) ) {
472 472
 					$view_meta = $view_data;
473 473
 					break;
474 474
 				}
@@ -476,12 +476,12 @@  discard block
 block discarded – undo
476 476
 		}
477 477
 
478 478
 		/** Deprecated stuff in the future. See the branch above. */
479
-		if ( ! empty( $view_meta['atts']['single_title'] ) ) {
479
+		if ( ! empty( $view_meta[ 'atts' ][ 'single_title' ] ) ) {
480 480
 
481
-			$title = $view_meta['atts']['single_title'];
481
+			$title = $view_meta[ 'atts' ][ 'single_title' ];
482 482
 
483 483
 			// We are allowing HTML in the fields, so no escaping the output
484
-			$title = GravityView_API::replace_variables( $title, $view_meta['form'], $entry );
484
+			$title = GravityView_API::replace_variables( $title, $view_meta[ 'form' ], $entry );
485 485
 
486 486
 			$title = do_shortcode( $title );
487 487
 		}
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 
553 553
 		$context = GravityView_View::getInstance()->getContext();
554 554
 
555
-		switch( $context ) {
555
+		switch ( $context ) {
556 556
 			case 'directory':
557 557
 				$tab = __( 'Multiple Entries', 'gravityview' );
558 558
 				break;
@@ -566,12 +566,12 @@  discard block
 block discarded – undo
566 566
 		}
567 567
 
568 568
 
569
-		$title = sprintf( esc_html_x('The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
569
+		$title = sprintf( esc_html_x( 'The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
570 570
 		$edit_link = admin_url( sprintf( 'post.php?post=%d&action=edit#%s-view', $view_id, $context ) );
571
-		$action_text = sprintf( esc_html__('Add fields to %s', 'gravityview' ), $tab );
571
+		$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
572 572
 		$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
573 573
 
574
-		$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url(plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
574
+		$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
575 575
 		$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
576 576
 
577 577
 		echo GVCommon::generate_notice( $output . $image, 'gv-error error', 'edit_gravityview', $view_id );
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 		$direct_access = apply_filters( 'gravityview_direct_access', true, $view->ID );
620 620
 		$embed_only = $view->settings->get( 'embed_only' );
621 621
 
622
-		if( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
622
+		if ( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
623 623
 			return __( 'You are not allowed to view this content.', 'gravityview' );
624 624
 		}
625 625
 
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
 				$datetime_format = 'Y-m-d H:i:s';
667 667
 				$search_is_outside_view_bounds = false;
668 668
 
669
-				if( ! empty( $search_criteria[ $key ] ) ) {
669
+				if ( ! empty( $search_criteria[ $key ] ) ) {
670 670
 
671 671
 					$search_date = strtotime( $search_criteria[ $key ] );
672 672
 
@@ -694,14 +694,14 @@  discard block
 block discarded – undo
694 694
 				if ( empty( $search_criteria[ $key ] ) || $search_is_outside_view_bounds ) {
695 695
 
696 696
 					// Then we override the search and re-set the start date
697
-					$return_search_criteria[ $key ] = date_i18n( $datetime_format , $date, true );
697
+					$return_search_criteria[ $key ] = date_i18n( $datetime_format, $date, true );
698 698
 				}
699 699
 			}
700 700
 		}
701 701
 
702
-		if( isset( $return_search_criteria['start_date'] ) && isset( $return_search_criteria['end_date'] ) ) {
702
+		if ( isset( $return_search_criteria[ 'start_date' ] ) && isset( $return_search_criteria[ 'end_date' ] ) ) {
703 703
 			// The start date is AFTER the end date. This will result in no results, but let's not force the issue.
704
-			if ( strtotime( $return_search_criteria['start_date'] ) > strtotime( $return_search_criteria['end_date'] ) ) {
704
+			if ( strtotime( $return_search_criteria[ 'start_date' ] ) > strtotime( $return_search_criteria[ 'end_date' ] ) ) {
705 705
 				gravityview()->log->error( 'Invalid search: the start date is after the end date.', array( 'data' => $return_search_criteria ) );
706 706
 			}
707 707
 		}
@@ -720,19 +720,19 @@  discard block
 block discarded – undo
720 720
 	public static function process_search_only_approved( $args, $search_criteria ) {
721 721
 
722 722
 		/** @since 1.19 */
723
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
723
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
724 724
 			gravityview()->log->debug( 'User can moderate entries; showing all approval statuses' );
725 725
 			return $search_criteria;
726 726
 		}
727 727
 
728
-		if ( ! empty( $args['show_only_approved'] ) ) {
728
+		if ( ! empty( $args[ 'show_only_approved' ] ) ) {
729 729
 
730
-			$search_criteria['field_filters'][] = array(
730
+			$search_criteria[ 'field_filters' ][ ] = array(
731 731
 				'key' => GravityView_Entry_Approval::meta_key,
732 732
 				'value' => GravityView_Entry_Approval_Status::APPROVED
733 733
 			);
734 734
 
735
-			$search_criteria['field_filters']['mode'] = 'all'; // force all the criterias to be met
735
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all'; // force all the criterias to be met
736 736
 
737 737
 			gravityview()->log->debug( '[process_search_only_approved] Search Criteria if show only approved: ', array( 'data' => $search_criteria ) );
738 738
 		}
@@ -759,18 +759,18 @@  discard block
 block discarded – undo
759 759
 	 */
760 760
 	public static function is_entry_approved( $entry, $args = array() ) {
761 761
 
762
-		if ( empty( $entry['id'] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args['show_only_approved'] ) ) {
762
+		if ( empty( $entry[ 'id' ] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args[ 'show_only_approved' ] ) ) {
763 763
 			// is implicitly approved if entry is null or View settings doesn't require to check for approval
764 764
 			return true;
765 765
 		}
766 766
 
767 767
 		/** @since 1.19 */
768
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
768
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
769 769
 			gravityview()->log->debug( 'User can moderate entries, so entry is approved for viewing' );
770 770
 			return true;
771 771
 		}
772 772
 
773
-		$is_approved = gform_get_meta( $entry['id'], GravityView_Entry_Approval::meta_key );
773
+		$is_approved = gform_get_meta( $entry[ 'id' ], GravityView_Entry_Approval::meta_key );
774 774
 
775 775
 		return GravityView_Entry_Approval_Status::is_approved( $is_approved );
776 776
 	}
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 		 * Compatibility with filters hooking in `gravityview_search_criteria` instead of `gravityview_fe_search_criteria`.
795 795
 		 */
796 796
 		$criteria = apply_filters( 'gravityview_search_criteria', array(), array( $form_id ), \GV\Utils::get( $args, 'id' ) );
797
-		$search_criteria = isset( $criteria['search_criteria'] ) ? $criteria['search_criteria'] : array( 'field_filters' => array() );
797
+		$search_criteria = isset( $criteria[ 'search_criteria' ] ) ? $criteria[ 'search_criteria' ] : array( 'field_filters' => array() );
798 798
 
799 799
 		/**
800 800
 		 * @filter `gravityview_fe_search_criteria` Modify the search criteria
@@ -810,29 +810,29 @@  discard block
 block discarded – undo
810 810
 		gravityview()->log->debug( '[get_search_criteria] Search Criteria after hook gravityview_fe_search_criteria: ', array( 'data' =>$search_criteria ) );
811 811
 
812 812
 		// implicity search
813
-		if ( ! empty( $args['search_value'] ) ) {
813
+		if ( ! empty( $args[ 'search_value' ] ) ) {
814 814
 
815 815
 			// Search operator options. Options: `is` or `contains`
816
-			$operator = ! empty( $args['search_operator'] ) && in_array( $args['search_operator'], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args['search_operator'] : 'contains';
816
+			$operator = ! empty( $args[ 'search_operator' ] ) && in_array( $args[ 'search_operator' ], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args[ 'search_operator' ] : 'contains';
817 817
 
818
-			$search_criteria['field_filters'][] = array(
818
+			$search_criteria[ 'field_filters' ][ ] = array(
819 819
 				'key' => \GV\Utils::_GET( 'search_field', \GV\Utils::get( $args, 'search_field' ) ), // The field ID to search
820
-				'value' => _wp_specialchars( $args['search_value'] ), // The value to search. Encode ampersands but not quotes.
820
+				'value' => _wp_specialchars( $args[ 'search_value' ] ), // The value to search. Encode ampersands but not quotes.
821 821
 				'operator' => $operator,
822 822
 			);
823 823
 
824 824
 			// Lock search mode to "all" with implicit presearch filter.
825
-			$search_criteria['field_filters']['mode'] = 'all';
825
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all';
826 826
 		}
827 827
 
828
-		if( $search_criteria !== $original_search_criteria ) {
828
+		if ( $search_criteria !== $original_search_criteria ) {
829 829
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after implicity search: ', array( 'data' => $search_criteria ) );
830 830
 		}
831 831
 
832 832
 		// Handle setting date range
833 833
 		$search_criteria = self::process_search_dates( $args, $search_criteria );
834 834
 
835
-		if( $search_criteria !== $original_search_criteria ) {
835
+		if ( $search_criteria !== $original_search_criteria ) {
836 836
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after date params: ', array( 'data' => $search_criteria ) );
837 837
 		}
838 838
 
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
 		 * @filter `gravityview_status` Modify entry status requirements to be included in search results.
844 844
 		 * @param string $status Default: `active`. Accepts all Gravity Forms entry statuses, including `spam` and `trash`
845 845
 		 */
846
-		$search_criteria['status'] = apply_filters( 'gravityview_status', 'active', $args );
846
+		$search_criteria[ 'status' ] = apply_filters( 'gravityview_status', 'active', $args );
847 847
 
848 848
 		return $search_criteria;
849 849
 	}
@@ -956,7 +956,7 @@  discard block
 block discarded – undo
956 956
 			'search_criteria' => $search_criteria,
957 957
 			'sorting' => self::updateViewSorting( $args, $form_id ),
958 958
 			'paging' => $paging,
959
-			'cache' => isset( $args['cache'] ) ? $args['cache'] : true,
959
+			'cache' => isset( $args[ 'cache' ] ) ? $args[ 'cache' ] : true,
960 960
 		);
961 961
 
962 962
 		/**
@@ -981,7 +981,7 @@  discard block
 block discarded – undo
981 981
 		 * @param array $parameters Array with `search_criteria`, `sorting` and `paging` keys.
982 982
 		 * @param array $args View configuration args.
983 983
 		 */
984
-		$parameters = apply_filters( 'gravityview_get_entries_'.\GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
984
+		$parameters = apply_filters( 'gravityview_get_entries_' . \GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
985 985
 
986 986
 		gravityview()->log->debug( '$parameters passed to gravityview_get_entries(): ', array( 'data' => $parameters ) );
987 987
 
@@ -1006,17 +1006,17 @@  discard block
 block discarded – undo
1006 1006
 		$default_page_size = apply_filters( 'gravityview_default_page_size', 25 );
1007 1007
 
1008 1008
 		// Paging & offset
1009
-		$page_size = ! empty( $args['page_size'] ) ? intval( $args['page_size'] ) : $default_page_size;
1009
+		$page_size = ! empty( $args[ 'page_size' ] ) ? intval( $args[ 'page_size' ] ) : $default_page_size;
1010 1010
 
1011 1011
 		if ( -1 === $page_size ) {
1012 1012
 			$page_size = PHP_INT_MAX;
1013 1013
 		}
1014 1014
 
1015
-		$curr_page = empty( $_GET['pagenum'] ) ? 1 : intval( $_GET['pagenum'] );
1015
+		$curr_page = empty( $_GET[ 'pagenum' ] ) ? 1 : intval( $_GET[ 'pagenum' ] );
1016 1016
 		$offset = ( $curr_page - 1 ) * $page_size;
1017 1017
 
1018
-		if ( ! empty( $args['offset'] ) ) {
1019
-			$offset += intval( $args['offset'] );
1018
+		if ( ! empty( $args[ 'offset' ] ) ) {
1019
+			$offset += intval( $args[ 'offset' ] );
1020 1020
 		}
1021 1021
 
1022 1022
 		$paging = array(
@@ -1040,8 +1040,8 @@  discard block
 block discarded – undo
1040 1040
 	 */
1041 1041
 	public static function updateViewSorting( $args, $form_id ) {
1042 1042
 		$sorting = array();
1043
-		$sort_field_id = isset( $_GET['sort'] ) ? $_GET['sort'] : \GV\Utils::get( $args, 'sort_field' );
1044
-		$sort_direction = isset( $_GET['dir'] ) ? $_GET['dir'] : \GV\Utils::get( $args, 'sort_direction' );
1043
+		$sort_field_id = isset( $_GET[ 'sort' ] ) ? $_GET[ 'sort' ] : \GV\Utils::get( $args, 'sort_field' );
1044
+		$sort_direction = isset( $_GET[ 'dir' ] ) ? $_GET[ 'dir' ] : \GV\Utils::get( $args, 'sort_direction' );
1045 1045
 
1046 1046
 		if ( ! empty( $sort_field_id ) ) {
1047 1047
 			if ( is_array( $sort_field_id ) ) {
@@ -1064,10 +1064,10 @@  discard block
 block discarded – undo
1064 1064
 				$form = GFAPI::get_form( $form_id );
1065 1065
 
1066 1066
 				// Get the first GF_Field field ID, set as the key for entry randomization
1067
-				if ( ! empty( $form['fields'] ) ) {
1067
+				if ( ! empty( $form[ 'fields' ] ) ) {
1068 1068
 
1069 1069
 					/** @var GF_Field $field */
1070
-					foreach ( $form['fields'] as $field ) {
1070
+					foreach ( $form[ 'fields' ] as $field ) {
1071 1071
 						if ( ! is_a( $field, 'GF_Field' ) ) {
1072 1072
 							continue;
1073 1073
 						}
@@ -1112,7 +1112,7 @@  discard block
 block discarded – undo
1112 1112
 		if ( is_array( $sort_field_id ) ) {
1113 1113
 			$modified_ids = array();
1114 1114
 			foreach ( $sort_field_id as $_sort_field_id ) {
1115
-				$modified_ids []= self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1115
+				$modified_ids [ ] = self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1116 1116
 			}
1117 1117
 			return $modified_ids;
1118 1118
 		}
@@ -1121,11 +1121,11 @@  discard block
 block discarded – undo
1121 1121
 
1122 1122
 		$sort_field = GFFormsModel::get_field( $form, $sort_field_id );
1123 1123
 
1124
-		if( ! $sort_field ) {
1124
+		if ( ! $sort_field ) {
1125 1125
 			return $sort_field_id;
1126 1126
 		}
1127 1127
 
1128
-		switch ( $sort_field['type'] ) {
1128
+		switch ( $sort_field[ 'type' ] ) {
1129 1129
 
1130 1130
 			case 'address':
1131 1131
 				// Sorting by full address
@@ -1142,7 +1142,7 @@  discard block
 block discarded – undo
1142 1142
 					 */
1143 1143
 					$address_part = apply_filters( 'gravityview/sorting/address', 'city', $sort_field_id, $form_id );
1144 1144
 
1145
-					switch( strtolower( $address_part ) ){
1145
+					switch ( strtolower( $address_part ) ) {
1146 1146
 						case 'street':
1147 1147
 							$sort_field_id .= '.1';
1148 1148
 							break;
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
 		 */
1223 1223
 		$single_entry = apply_filters( 'gravityview/is_single_entry', $single_entry );
1224 1224
 
1225
-		if ( empty( $single_entry ) ){
1225
+		if ( empty( $single_entry ) ) {
1226 1226
 			return false;
1227 1227
 		} else {
1228 1228
 			return $single_entry;
@@ -1244,7 +1244,7 @@  discard block
 block discarded – undo
1244 1244
 			$views = $this->getGvOutputData()->get_views();
1245 1245
 
1246 1246
 			foreach ( $views as $view_id => $data ) {
1247
-				$view = \GV\View::by_id( $data['id'] );
1247
+				$view = \GV\View::by_id( $data[ 'id' ] );
1248 1248
 				$view_id = $view->ID;
1249 1249
 				$template_id = gravityview_get_template_id( $view->ID );
1250 1250
 				$data = $view->as_data();
@@ -1253,7 +1253,7 @@  discard block
 block discarded – undo
1253 1253
 				 * Don't enqueue the scripts or styles if it's not going to be displayed.
1254 1254
 				 * @since 1.15
1255 1255
 				 */
1256
-				if( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1256
+				if ( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1257 1257
 					continue;
1258 1258
 				}
1259 1259
 
@@ -1270,13 +1270,13 @@  discard block
 block discarded – undo
1270 1270
 					 * @filter `gravity_view_lightbox_script` Override the lightbox script to enqueue. Default: `thickbox`
1271 1271
 					 * @param string $script_slug If you want to use a different lightbox script, return the name of it here.
1272 1272
 					 */
1273
-					$js_dependencies[] = apply_filters( 'gravity_view_lightbox_script', 'thickbox' );
1273
+					$js_dependencies[ ] = apply_filters( 'gravity_view_lightbox_script', 'thickbox' );
1274 1274
 
1275 1275
 					/**
1276 1276
 					 * @filter `gravity_view_lightbox_style` Modify the lightbox CSS slug. Default: `thickbox`
1277 1277
 					 * @param string $script_slug If you want to use a different lightbox script, return the name of its CSS file here.
1278 1278
 					 */
1279
-					$css_dependencies[] = apply_filters( 'gravity_view_lightbox_style', 'thickbox' );
1279
+					$css_dependencies[ ] = apply_filters( 'gravity_view_lightbox_style', 'thickbox' );
1280 1280
 				}
1281 1281
 
1282 1282
 				/**
@@ -1284,19 +1284,19 @@  discard block
 block discarded – undo
1284 1284
 				 * @see https://github.com/katzwebservices/GravityView/issues/536
1285 1285
 				 * @since 1.15
1286 1286
 				 */
1287
-				if( gravityview_view_has_single_checkbox_or_radio( $data['form'], $data['fields'] ) ) {
1288
-					$css_dependencies[] = 'dashicons';
1287
+				if ( gravityview_view_has_single_checkbox_or_radio( $data[ 'form' ], $data[ 'fields' ] ) ) {
1288
+					$css_dependencies[ ] = 'dashicons';
1289 1289
 				}
1290 1290
 
1291 1291
 				wp_register_script( 'gravityview-jquery-cookie', plugins_url( 'assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version, true );
1292 1292
 
1293 1293
 				$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
1294 1294
 
1295
-				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ) , GravityView_Plugin::version, true );
1295
+				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ), GravityView_Plugin::version, true );
1296 1296
 
1297 1297
 				wp_enqueue_script( 'gravityview-fe-view' );
1298 1298
 
1299
-				if ( ! empty( $data['atts']['sort_columns'] ) ) {
1299
+				if ( ! empty( $data[ 'atts' ][ 'sort_columns' ] ) ) {
1300 1300
 					wp_enqueue_style( 'gravityview_font', plugins_url( 'assets/css/font.css', GRAVITYVIEW_FILE ), $css_dependencies, GravityView_Plugin::version, 'all' );
1301 1301
 				}
1302 1302
 
@@ -1359,7 +1359,7 @@  discard block
 block discarded – undo
1359 1359
 	public static function add_style( $template_id ) {
1360 1360
 
1361 1361
 		if ( ! empty( $template_id ) && wp_style_is( 'gravityview_style_' . $template_id, 'registered' ) ) {
1362
-			gravityview()->log->debug(  'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1362
+			gravityview()->log->debug( 'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1363 1363
 			wp_enqueue_style( 'gravityview_style_' . $template_id );
1364 1364
 		} elseif ( empty( $template_id ) ) {
1365 1365
 			gravityview()->log->error( 'Cannot add template style; template_id is empty' );
@@ -1390,11 +1390,11 @@  discard block
 block discarded – undo
1390 1390
 		 * Not a table-based template; don't add sort icons
1391 1391
 		 * @since 1.12
1392 1392
 		 */
1393
-		if( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1393
+		if ( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1394 1394
 			return $label;
1395 1395
 		}
1396 1396
 
1397
-		if ( ! $this->is_field_sortable( $field['id'], $form ) ) {
1397
+		if ( ! $this->is_field_sortable( $field[ 'id' ], $form ) ) {
1398 1398
 			return $label;
1399 1399
 		}
1400 1400
 
@@ -1402,29 +1402,29 @@  discard block
 block discarded – undo
1402 1402
 
1403 1403
 		$class = 'gv-sort';
1404 1404
 
1405
-		$sort_field_id = self::_override_sorting_id_by_field_type( $field['id'], $form['id'] );
1405
+		$sort_field_id = self::_override_sorting_id_by_field_type( $field[ 'id' ], $form[ 'id' ] );
1406 1406
 
1407 1407
 		$sort_args = array(
1408
-			'sort' => $field['id'],
1408
+			'sort' => $field[ 'id' ],
1409 1409
 			'dir' => 'asc',
1410 1410
 		);
1411 1411
 
1412
-		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
1412
+		if ( ! empty( $sorting[ 'key' ] ) && (string)$sort_field_id === (string)$sorting[ 'key' ] ) {
1413 1413
 			//toggle sorting direction.
1414
-			if ( 'asc' === $sorting['direction'] ) {
1415
-				$sort_args['dir'] = 'desc';
1414
+			if ( 'asc' === $sorting[ 'direction' ] ) {
1415
+				$sort_args[ 'dir' ] = 'desc';
1416 1416
 				$class .= ' gv-icon-sort-desc';
1417 1417
 			} else {
1418
-				$sort_args['dir'] = 'asc';
1418
+				$sort_args[ 'dir' ] = 'asc';
1419 1419
 				$class .= ' gv-icon-sort-asc';
1420 1420
 			}
1421 1421
 		} else {
1422 1422
 			$class .= ' gv-icon-caret-up-down';
1423 1423
 		}
1424 1424
 
1425
-		$url = add_query_arg( $sort_args, remove_query_arg( array('pagenum') ) );
1425
+		$url = add_query_arg( $sort_args, remove_query_arg( array( 'pagenum' ) ) );
1426 1426
 
1427
-		return '<a href="'. esc_url_raw( $url ) .'" class="'. $class .'" ></a>&nbsp;'. $label;
1427
+		return '<a href="' . esc_url_raw( $url ) . '" class="' . $class . '" ></a>&nbsp;' . $label;
1428 1428
 
1429 1429
 	}
1430 1430
 
@@ -1442,7 +1442,7 @@  discard block
 block discarded – undo
1442 1442
 
1443 1443
 		$field_type = $field_id;
1444 1444
 
1445
-		if( is_numeric( $field_id ) ) {
1445
+		if ( is_numeric( $field_id ) ) {
1446 1446
 			$field = GFFormsModel::get_field( $form, $field_id );
1447 1447
 			$field_type = $field ? $field->type : $field_id;
1448 1448
 		}
@@ -1465,7 +1465,7 @@  discard block
 block discarded – undo
1465 1465
 			return false;
1466 1466
 		}
1467 1467
 
1468
-		return apply_filters( "gravityview/sortable/formfield_{$form['id']}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1468
+		return apply_filters( "gravityview/sortable/formfield_{$form[ 'id' ]}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1469 1469
 
1470 1470
 	}
1471 1471
 
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +66 added lines, -67 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) { 
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -300,13 +300,13 @@  discard block
 block discarded – undo
300 300
 			return $content;
301 301
 		}
302 302
 
303
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
303
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
304 304
 
305 305
 		/**
306 306
 		 * Editing a single entry.
307 307
 		 */
308 308
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
309
-			if ( $entry['status'] != 'active' ) {
309
+			if ( $entry[ 'status' ] != 'active' ) {
310 310
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
311 311
 				return __( 'You are not allowed to view this content.', 'gravityview' );
312 312
 			}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 			}
318 318
 
319 319
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
320
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
320
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
321 321
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
322 322
 					return __( 'You are not allowed to view this content.', 'gravityview' );
323 323
 				}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 
341 341
 			foreach ( $entryset as $e ) {
342 342
 
343
-				if ( 'active' !== $e['status'] ) {
343
+				if ( 'active' !== $e[ 'status' ] ) {
344 344
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
345 345
 					return __( 'You are not allowed to view this content.', 'gravityview' );
346 346
 				}
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 				}
352 352
 
353 353
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
354
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
354
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
355 355
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
356 356
 						return __( 'You are not allowed to view this content.', 'gravityview' );
357 357
 					}
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
527 527
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
528 528
 
529
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
529
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
530 530
 		}
531 531
 
532 532
 		return $joins;
@@ -621,13 +621,13 @@  discard block
 block discarded – undo
621 621
 			}
622 622
 
623 623
 			foreach ( $_fields as $field ) {
624
-				if ( ! empty( $field['unions'] ) ) {
625
-					foreach ( $field['unions'] as $form_id => $field_id ) {
624
+				if ( ! empty( $field[ 'unions' ] ) ) {
625
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
626 626
 						if ( ! isset( $unions[ $form_id ] ) ) {
627 627
 							$unions[ $form_id ] = array();
628 628
 						}
629 629
 
630
-						$unions[ $form_id ][ $field['id'] ] =
630
+						$unions[ $form_id ][ $field[ 'id' ] ] =
631 631
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
632 632
 					}
633 633
 				}
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
 		if ( ! $view->form ) {
677 677
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
678 678
 				'view_id' => $view->ID,
679
-				'form_id' => $view->_gravityview_form_id ? : 0,
679
+				'form_id' => $view->_gravityview_form_id ?: 0,
680 680
 			) );
681 681
 		}
682 682
 
@@ -913,11 +913,11 @@  discard block
 block discarded – undo
913 913
 			 * Remove multiple sorting before calling legacy filters.
914 914
 			 * This allows us to fake it till we make it.
915 915
 			 */
916
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
916
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
917 917
 				$has_multisort = true;
918
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
919
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
920
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
918
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
919
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
920
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
921 921
 				}
922 922
 			}
923 923
 
@@ -925,40 +925,39 @@  discard block
 block discarded – undo
925 925
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
926 926
 			 */
927 927
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
928
-			$parameters['context_view_id'] = $this->ID;
928
+			$parameters[ 'context_view_id' ] = $this->ID;
929 929
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
930 930
 
931 931
 			if ( $request instanceof REST\Request ) {
932 932
 				$atts = $this->settings->as_atts();
933 933
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
934
-						'paging' => array( 'page_size' => $atts['page_size'] ),
934
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
935 935
 					) );
936
-				$parameters['paging'] = $paging_parameters['paging'];
936
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
937 937
 			}
938 938
 
939
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
940
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
939
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
941 940
 
942 941
 			/**
943 942
 			 * Cleanup duplicate field_filter parameters to simplify the query.
944 943
 			 */
945 944
 			$unique_field_filters = array();
946
-			foreach ( $parameters['search_criteria']['field_filters'] as $key => $filter ) {
945
+			foreach ( $parameters[ 'search_criteria' ][ 'field_filters' ] as $key => $filter ) {
947 946
 				if ( 'mode' === $key ) {
948
-					$unique_field_filters['mode'] = $filter;
947
+					$unique_field_filters[ 'mode' ] = $filter;
949 948
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
950
-					$unique_field_filters[] = $filter;
949
+					$unique_field_filters[ ] = $filter;
951 950
 				}
952 951
 			}
953
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
952
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
954 953
 
955
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
954
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
956 955
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
957 956
 			}
958 957
 
959 958
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
960 959
 				$query_class = $this->get_query_class();
961
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
960
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
962 961
 
963 962
 				/**
964 963
 				 * Apply multisort.
@@ -966,9 +965,9 @@  discard block
 block discarded – undo
966 965
 				if ( ! empty( $has_multisort ) ) {
967 966
 					$atts = $this->settings->as_atts();
968 967
 
969
-					if ( $this->settings->get( 'sort_columns' ) && ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] ) ) {
970
-						$sort_field_ids = array_keys( $_GET['sort'] );
971
-						$sort_directions = array_values( $_GET['sort'] );
968
+					if ( $this->settings->get( 'sort_columns' ) && ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] ) ) {
969
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
970
+						$sort_directions = array_values( $_GET[ 'sort' ] );
972 971
 					} else {
973 972
 						$sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
974 973
 						$sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
@@ -976,7 +975,7 @@  discard block
 block discarded – undo
976 975
 
977 976
 					$skip_first = false;
978 977
 
979
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
978
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
980 979
 						if ( ! $skip_first ) {
981 980
 							$skip_first = true; // Skip the first one, it's already in the query
982 981
 							continue;
@@ -996,8 +995,8 @@  discard block
 block discarded – undo
996 995
 					}
997 996
 				}
998 997
 
999
-				$query->limit( $parameters['paging']['page_size'] )
1000
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
998
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
999
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1001 1000
 
1002 1001
 				/**
1003 1002
 				 * Any joins?
@@ -1020,7 +1019,7 @@  discard block
 block discarded – undo
1020 1019
 
1021 1020
 							$query_parameters = $query->_introspect();
1022 1021
 
1023
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1022
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1024 1023
 						}
1025 1024
 
1026 1025
 						/**
@@ -1054,7 +1053,7 @@  discard block
 block discarded – undo
1054 1053
 						}
1055 1054
 
1056 1055
 						$q = $query->_introspect();
1057
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1056
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1058 1057
 
1059 1058
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1060 1059
 
@@ -1079,7 +1078,7 @@  discard block
 block discarded – undo
1079 1078
 
1080 1079
 							$query_parameters = $query->_introspect();
1081 1080
 
1082
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1081
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1083 1082
 						}
1084 1083
 					}
1085 1084
 				
@@ -1103,7 +1102,7 @@  discard block
 block discarded – undo
1103 1102
 							$conditions = array();
1104 1103
 
1105 1104
 							foreach ( $condition->expressions as $_condition ) {
1106
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1105
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1107 1106
 							}
1108 1107
 
1109 1108
 							return call_user_func_array(
@@ -1132,10 +1131,10 @@  discard block
 block discarded – undo
1132 1131
 						$q = new $query_class( $form_id );
1133 1132
 
1134 1133
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1135
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1134
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1136 1135
 
1137 1136
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1138
-						foreach ( $query_parameters['order'] as $order ) {
1137
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1139 1138
 							list( $column, $_order ) = $order;
1140 1139
 
1141 1140
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1149,15 +1148,15 @@  discard block
 block discarded – undo
1149 1148
 
1150 1149
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1151 1150
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1152
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1151
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1153 1152
 
1154 1153
 							// Record the SQL
1155
-							$unions_sql[] = array(
1154
+							$unions_sql[ ] = array(
1156 1155
 								// Remove columns, we'll rebuild them
1157 1156
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1158
-								'from'    => $sql['from'],
1159
-								'join'    => $sql['join'],
1160
-								'where'   => $sql['where'],
1157
+								'from'    => $sql[ 'from' ],
1158
+								'join'    => $sql[ 'join' ],
1159
+								'where'   => $sql[ 'where' ],
1161 1160
 								// Remove order and limit
1162 1161
 							);
1163 1162
 
@@ -1174,11 +1173,11 @@  discard block
 block discarded – undo
1174 1173
 
1175 1174
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1176 1175
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1177
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1176
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1178 1177
 
1179 1178
 						// Remove columns, we'll rebuild them
1180
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1181
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1179
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1180
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1182 1181
 
1183 1182
 						$unions = array();
1184 1183
 
@@ -1189,30 +1188,30 @@  discard block
 block discarded – undo
1189 1188
 						};
1190 1189
 
1191 1190
 						// Add all the order columns into the selects, so we can order by the whole union group
1192
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1191
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1193 1192
 						
1194 1193
 						$columns = array(
1195
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1194
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1196 1195
 						);
1197 1196
 
1198 1197
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1199
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1198
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1200 1199
 
1201 1200
 							// Rewrite the order columns to the shared aliases
1202
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1201
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1203 1202
 						}
1204 1203
 
1205 1204
 						$columns = array_unique( $columns );
1206 1205
 
1207 1206
 						// Add the columns to every UNION
1208 1207
 						foreach ( $unions_sql as $union_sql ) {
1209
-							$union_sql['select'] .= implode( ', ', $columns );
1210
-							$unions []= implode( ' ', $union_sql );
1208
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1209
+							$unions [ ] = implode( ' ', $union_sql );
1211 1210
 						}
1212 1211
 
1213 1212
 						// Add the columns to the main SELECT, but only grab the entry id column
1214
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1215
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1213
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1214
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1216 1215
 
1217 1216
 						return $sql;
1218 1217
 					} );
@@ -1253,20 +1252,20 @@  discard block
 block discarded – undo
1253 1252
 				} );
1254 1253
 			} else {
1255 1254
 				$entries = $this->form->entries
1256
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1255
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1257 1256
 					->offset( $this->settings->get( 'offset' ) )
1258
-					->limit( $parameters['paging']['page_size'] )
1257
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1259 1258
 					->page( $page );
1260 1259
 
1261
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1260
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1262 1261
 					// Pluck off multisort arrays
1263
-					$parameters['sorting'] = $parameters['sorting'][0];
1262
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1264 1263
 				}
1265 1264
 
1266
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1265
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1267 1266
 					$field = new \GV\Field();
1268
-					$field->ID = $parameters['sorting']['key'];
1269
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1267
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1268
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1270 1269
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1271 1270
 				}
1272 1271
 			}
@@ -1337,7 +1336,7 @@  discard block
 block discarded – undo
1337 1336
 		$allowed = $headers = array();
1338 1337
 
1339 1338
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $id => $field ) {
1340
-			$allowed[] = $field;
1339
+			$allowed[ ] = $field;
1341 1340
 		}
1342 1341
 
1343 1342
 		$renderer = new Field_Renderer();
@@ -1359,17 +1358,17 @@  discard block
 block discarded – undo
1359 1358
 			} );
1360 1359
 
1361 1360
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1362
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1361
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1363 1362
 			}
1364 1363
 
1365 1364
 			foreach ( $allowed as $field ) {
1366 1365
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1367 1366
 
1368
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1367
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1369 1368
 
1370 1369
 				if ( ! $headers_done ) {
1371 1370
 					$label = $field->get_label( $view, $source, $entry );
1372
-					$headers[] = $label ? $label : $field->ID;
1371
+					$headers[ ] = $label ? $label : $field->ID;
1373 1372
 				}
1374 1373
 			}
1375 1374
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 2 patches
Indentation   +289 added lines, -289 removed lines patch added patch discarded remove patch
@@ -102,10 +102,10 @@  discard block
 block discarded – undo
102 102
 
103 103
 	/**
104 104
 	 * ID of the current post. May also be ID of the current View.
105
-     *
106
-     * @since 2.0.13
107
-     * 
108
-     * @var int
105
+	 *
106
+	 * @since 2.0.13
107
+	 * 
108
+	 * @var int
109 109
 	 */
110 110
 	public $post_id;
111 111
 
@@ -177,12 +177,12 @@  discard block
 block discarded – undo
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179 179
 		if( ! empty( $_POST ) ) {
180
-	        gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
180
+			gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
181 181
 		}
182 182
 
183 183
 		if( $this->is_edit_entry_submission() ) {
184 184
 			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
185
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
185
+			remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
186 186
 		}
187 187
 	}
188 188
 
@@ -210,14 +210,14 @@  discard block
 block discarded – undo
210 210
 	 * When Edit entry view is requested setup the vars
211 211
 	 */
212 212
 	private function setup_vars() {
213
-        global $post;
213
+		global $post;
214 214
 
215 215
 		$gravityview_view = GravityView_View::getInstance();
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+		self::$original_entry = $entries[0];
220
+		$this->entry = $entries[0];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
@@ -359,8 +359,8 @@  discard block
 block discarded – undo
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362
-	        // Delete the values for hidden inputs
363
-	        $this->unset_hidden_field_values();
362
+			// Delete the values for hidden inputs
363
+			$this->unset_hidden_field_values();
364 364
 			
365 365
 			$this->entry['date_created'] = $date_created;
366 366
 
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
 			// Perform actions normally performed after updating a lead
371 371
 			$this->after_update();
372 372
 
373
-	        /**
373
+			/**
374 374
 			 * Must be AFTER after_update()!
375 375
 			 * @see https://github.com/gravityview/GravityView/issues/764
376 376
 			 */
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
 			/**
380 380
 			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
381
-             * @since 2.1 Added $gv_data parameter
381
+			 * @since 2.1 Added $gv_data parameter
382 382
 			 * @param array $form Gravity Forms form array
383 383
 			 * @param string $entry_id Numeric ID of the entry that was updated
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 	 * @return void
403 403
 	 */
404 404
 	private function unset_hidden_field_values() {
405
-	    global $wpdb;
405
+		global $wpdb;
406 406
 
407 407
 		/**
408 408
 		 * @filter `gravityview/edit_entry/unset_hidden_field_values` Whether to delete values of fields hidden by conditional logic
@@ -424,29 +424,29 @@  discard block
 block discarded – undo
424 424
 			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
425 425
 		}
426 426
 
427
-	    foreach ( $this->entry as $input_id => $field_value ) {
427
+		foreach ( $this->entry as $input_id => $field_value ) {
428 428
 
429
-		    $field = RGFormsModel::get_field( $this->form, $input_id );
429
+			$field = RGFormsModel::get_field( $this->form, $input_id );
430 430
 
431
-		    // Reset fields that are hidden
432
-		    // Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
433
-		    if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
431
+			// Reset fields that are hidden
432
+			// Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
433
+			if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437 437
 					$this->form, '', $this->entry['id'], $this->entry
438 438
 				);
439 439
 
440
-			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
440
+				$lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
441 441
 
442
-			    GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
442
+				GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
443 443
 
444
-			    // Prevent the $_POST values of hidden fields from being used as default values when rendering the form
444
+				// Prevent the $_POST values of hidden fields from being used as default values when rendering the form
445 445
 				// after submission
446
-			    $post_input_id = 'input_' . str_replace( '.', '_', $input_id );
447
-			    $_POST[ $post_input_id ] = '';
448
-		    }
449
-	    }
446
+				$post_input_id = 'input_' . str_replace( '.', '_', $input_id );
447
+				$_POST[ $post_input_id ] = '';
448
+			}
449
+		}
450 450
 	}
451 451
 
452 452
 	/**
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 
543 543
 		$non_submitted_fields = array();
544 544
 
545
-	    /** @var GF_Field $field */
545
+		/** @var GF_Field $field */
546 546
 		foreach( $form['fields'] as $k => &$field ) {
547 547
 
548 548
 			/**
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
 
559 559
 			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
560 560
 				foreach( $field->inputs as $key => $input ) {
561
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
561
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
562 562
 				}
563 563
 			}
564 564
 
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 			foreach ( $this->fields_with_calculation as $field ) {
620 620
 				$inputs = $field->get_entry_inputs();
621 621
 				if ( is_array( $inputs ) ) {
622
-				    foreach ( $inputs as $input ) {
622
+					foreach ( $inputs as $input ) {
623 623
 						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
624 624
 
625 625
 						if ( 'product' === $field->type ) {
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 						}
639 639
 
640 640
 						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
641
-				    }
641
+					}
642 642
 				} else {
643 643
 					// Set to what it previously was if it's not editable
644 644
 					if ( ! in_array( $field->id, $allowed_fields ) ) {
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
685 685
 
686 686
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
687
-	        $ary = stripslashes_deep( $ary );
687
+			$ary = stripslashes_deep( $ary );
688 688
 			$img_url = \GV\Utils::get( $ary, 0 );
689 689
 
690 690
 			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
@@ -757,7 +757,7 @@  discard block
 block discarded – undo
757 757
 	private function maybe_update_post_fields( $form ) {
758 758
 
759 759
 		if( empty( $this->entry['post_id'] ) ) {
760
-	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
760
+			gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
761 761
 			return;
762 762
 		}
763 763
 
@@ -792,49 +792,49 @@  discard block
 block discarded – undo
792 792
 
793 793
 				switch( $field->type ) {
794 794
 
795
-				    case 'post_title':
796
-				        $post_title = $value;
797
-				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
798
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
799
-				        }
800
-				        $updated_post->post_title = $post_title;
801
-				        $updated_post->post_name  = $post_title;
802
-				        unset( $post_title );
803
-				        break;
804
-
805
-				    case 'post_content':
806
-				        $post_content = $value;
807
-				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
808
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
809
-				        }
810
-				        $updated_post->post_content = $post_content;
811
-				        unset( $post_content );
812
-				        break;
813
-				    case 'post_excerpt':
814
-				        $updated_post->post_excerpt = $value;
815
-				        break;
816
-				    case 'post_tags':
817
-				        wp_set_post_tags( $post_id, $value, false );
818
-				        break;
819
-				    case 'post_category':
820
-				        break;
821
-				    case 'post_custom_field':
795
+					case 'post_title':
796
+						$post_title = $value;
797
+						if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
798
+							$post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
799
+						}
800
+						$updated_post->post_title = $post_title;
801
+						$updated_post->post_name  = $post_title;
802
+						unset( $post_title );
803
+						break;
804
+
805
+					case 'post_content':
806
+						$post_content = $value;
807
+						if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
808
+							$post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
809
+						}
810
+						$updated_post->post_content = $post_content;
811
+						unset( $post_content );
812
+						break;
813
+					case 'post_excerpt':
814
+						$updated_post->post_excerpt = $value;
815
+						break;
816
+					case 'post_tags':
817
+						wp_set_post_tags( $post_id, $value, false );
818
+						break;
819
+					case 'post_category':
820
+						break;
821
+					case 'post_custom_field':
822 822
 						if ( is_array( $value ) && ( floatval( $field_id ) !== floatval( $field->id ) ) ) {
823 823
 							$value = $value[ $field_id ];
824 824
 						}
825 825
 
826
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
827
-				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
828
-				        }
826
+						if( ! empty( $field->customFieldTemplateEnabled ) ) {
827
+							$value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
828
+						}
829 829
 
830 830
 						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
831 831
 
832
-				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
833
-				        break;
832
+						update_post_meta( $post_id, $field->postCustomFieldName, $value );
833
+						break;
834 834
 
835
-				    case 'post_image':
836
-				        $value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
837
-				        break;
835
+					case 'post_image':
836
+						$value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
837
+						break;
838 838
 
839 839
 				}
840 840
 
@@ -991,14 +991,14 @@  discard block
 block discarded – undo
991 991
 			?><h2 class="gv-edit-entry-title">
992 992
 				<span><?php
993 993
 
994
-				    /**
995
-				     * @filter `gravityview_edit_entry_title` Modify the edit entry title
996
-				     * @param string $edit_entry_title Modify the "Edit Entry" title
997
-				     * @param GravityView_Edit_Entry_Render $this This object
998
-				     */
999
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
994
+					/**
995
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
996
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
997
+					 * @param GravityView_Edit_Entry_Render $this This object
998
+					 */
999
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
1000 1000
 
1001
-				    echo esc_attr( $edit_entry_title );
1001
+					echo esc_attr( $edit_entry_title );
1002 1002
 			?></span>
1003 1003
 			</h2>
1004 1004
 
@@ -1061,26 +1061,26 @@  discard block
 block discarded – undo
1061 1061
 
1062 1062
 				switch ( $edit_redirect ) {
1063 1063
 
1064
-                    case '0':
1065
-	                    $redirect_url = $back_link;
1066
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1067
-                        break;
1068
-
1069
-                    case '1':
1070
-	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1071
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1072
-	                    break;
1073
-
1074
-                    case '2':
1075
-	                    $redirect_url = $edit_redirect_url;
1076
-	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1077
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1078
-                        break;
1079
-
1080
-                    case '':
1081
-                    default:
1082
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1083
-                        break;
1064
+					case '0':
1065
+						$redirect_url = $back_link;
1066
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1067
+						break;
1068
+
1069
+					case '1':
1070
+						$redirect_url = $directory_link = GravityView_API::directory_link();
1071
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1072
+						break;
1073
+
1074
+					case '2':
1075
+						$redirect_url = $edit_redirect_url;
1076
+						$redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1077
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1078
+						break;
1079
+
1080
+					case '':
1081
+					default:
1082
+						$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1083
+						break;
1084 1084
 				}
1085 1085
 
1086 1086
 				if ( isset( $redirect_url ) ) {
@@ -1137,7 +1137,7 @@  discard block
 block discarded – undo
1137 1137
 
1138 1138
 		ob_get_clean();
1139 1139
 
1140
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1140
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1141 1141
 		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1142 1142
 		remove_filter( 'gform_disable_view_counter', '__return_true' );
1143 1143
 		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
@@ -1191,7 +1191,7 @@  discard block
 block discarded – undo
1191 1191
 
1192 1192
 		// for now we don't support Save and Continue feature.
1193 1193
 		if( ! self::$supports_save_and_continue ) {
1194
-	        unset( $form['save'] );
1194
+			unset( $form['save'] );
1195 1195
 		}
1196 1196
 
1197 1197
 		$form = $this->unselect_default_values( $form );
@@ -1218,30 +1218,30 @@  discard block
 block discarded – undo
1218 1218
 			return $field_content;
1219 1219
 		}
1220 1220
 
1221
-        $message = null;
1221
+		$message = null;
1222 1222
 
1223
-        // First, make sure they have the capability to edit the post.
1224
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1223
+		// First, make sure they have the capability to edit the post.
1224
+		if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1225 1225
 
1226
-            /**
1227
-             * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1228
-             * @param string $message The existing "You don't have permission..." text
1229
-             */
1230
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1226
+			/**
1227
+			 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1228
+			 * @param string $message The existing "You don't have permission..." text
1229
+			 */
1230
+			$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1231 1231
 
1232
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1233
-            /**
1234
-             * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1235
-             * @param string $message The existing "This field is not editable; the post no longer exists." text
1236
-             */
1237
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1238
-        }
1232
+		} elseif( null === get_post( $this->entry['post_id'] ) ) {
1233
+			/**
1234
+			 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1235
+			 * @param string $message The existing "This field is not editable; the post no longer exists." text
1236
+			 */
1237
+			$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1238
+		}
1239 1239
 
1240
-        if( $message ) {
1241
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1242
-        }
1240
+		if( $message ) {
1241
+			$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1242
+		}
1243 1243
 
1244
-        return $field_content;
1244
+		return $field_content;
1245 1245
 	}
1246 1246
 
1247 1247
 	/**
@@ -1269,7 +1269,7 @@  discard block
 block discarded – undo
1269 1269
 			|| ! empty( $field_content )
1270 1270
 			|| in_array( $field->type, array( 'honeypot' ) )
1271 1271
 		) {
1272
-	        return $field_content;
1272
+			return $field_content;
1273 1273
 		}
1274 1274
 
1275 1275
 		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
@@ -1277,24 +1277,24 @@  discard block
 block discarded – undo
1277 1277
 
1278 1278
 		$field_value = $this->get_field_value( $field );
1279 1279
 
1280
-	    // Prevent any PHP warnings, like undefined index
1281
-	    ob_start();
1280
+		// Prevent any PHP warnings, like undefined index
1281
+		ob_start();
1282 1282
 
1283
-	    $return = null;
1283
+		$return = null;
1284 1284
 
1285 1285
 		/** @var GravityView_Field $gv_field */
1286 1286
 		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1287 1287
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1288 1288
 		} else {
1289
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1290
-	    }
1289
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
1290
+		}
1291 1291
 
1292
-	    // If there was output, it's an error
1293
-	    $warnings = ob_get_clean();
1292
+		// If there was output, it's an error
1293
+		$warnings = ob_get_clean();
1294 1294
 
1295
-	    if( !empty( $warnings ) ) {
1296
-		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1297
-	    }
1295
+		if( !empty( $warnings ) ) {
1296
+			gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1297
+		}
1298 1298
 
1299 1299
 		return $return;
1300 1300
 	}
@@ -1329,8 +1329,8 @@  discard block
 block discarded – undo
1329 1329
 				$input_id = strval( $input['id'] );
1330 1330
 
1331 1331
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1332
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1333
-				    $allow_pre_populated = false;
1332
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1333
+					$allow_pre_populated = false;
1334 1334
 				}
1335 1335
 
1336 1336
 			}
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
 			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1355 1355
 				$categories = array();
1356 1356
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1357
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1357
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1358 1358
 				}
1359 1359
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1360 1360
 			}
@@ -1364,25 +1364,25 @@  discard block
 block discarded – undo
1364 1364
 		// if value is empty get the default value if defined
1365 1365
 		$field_value = $field->get_value_default_if_empty( $field_value );
1366 1366
 
1367
-	    /**
1368
-	     * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1369
-	     * @since 1.11
1370
-	     * @since 1.20 Added third param
1371
-	     * @param mixed $field_value field value used to populate the input
1372
-	     * @param object $field Gravity Forms field object ( Class GF_Field )
1373
-	     * @param GravityView_Edit_Entry_Render $this Current object
1374
-	     */
1375
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1376
-
1377
-	    /**
1378
-	     * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1379
-	     * @since 1.17
1380
-	     * @since 1.20 Added third param
1381
-	     * @param mixed $field_value field value used to populate the input
1382
-	     * @param GF_Field $field Gravity Forms field object
1383
-	     * @param GravityView_Edit_Entry_Render $this Current object
1384
-	     */
1385
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1367
+		/**
1368
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1369
+		 * @since 1.11
1370
+		 * @since 1.20 Added third param
1371
+		 * @param mixed $field_value field value used to populate the input
1372
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
1373
+		 * @param GravityView_Edit_Entry_Render $this Current object
1374
+		 */
1375
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1376
+
1377
+		/**
1378
+		 * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1379
+		 * @since 1.17
1380
+		 * @since 1.20 Added third param
1381
+		 * @param mixed $field_value field value used to populate the input
1382
+		 * @param GF_Field $field Gravity Forms field object
1383
+		 * @param GravityView_Edit_Entry_Render $this Current object
1384
+		 */
1385
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1386 1386
 
1387 1387
 		return $field_value;
1388 1388
 	}
@@ -1409,7 +1409,7 @@  discard block
 block discarded – undo
1409 1409
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1410 1410
 			// expects certain field array items to be set.
1411 1411
 			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1412
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1412
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1413 1413
 			}
1414 1414
 
1415 1415
 			switch( RGFormsModel::get_input_type( $field ) ) {
@@ -1423,61 +1423,61 @@  discard block
 block discarded – undo
1423 1423
 				 */
1424 1424
 				case 'fileupload':
1425 1425
 
1426
-				    // Set the previous value
1427
-				    $entry = $this->get_entry();
1426
+					// Set the previous value
1427
+					$entry = $this->get_entry();
1428 1428
 
1429
-				    $input_name = 'input_'.$field->id;
1430
-				    $form_id = $form['id'];
1429
+					$input_name = 'input_'.$field->id;
1430
+					$form_id = $form['id'];
1431 1431
 
1432
-				    $value = NULL;
1432
+					$value = NULL;
1433 1433
 
1434
-				    // Use the previous entry value as the default.
1435
-				    if( isset( $entry[ $field->id ] ) ) {
1436
-				        $value = $entry[ $field->id ];
1437
-				    }
1434
+					// Use the previous entry value as the default.
1435
+					if( isset( $entry[ $field->id ] ) ) {
1436
+						$value = $entry[ $field->id ];
1437
+					}
1438 1438
 
1439
-				    // If this is a single upload file
1440
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1441
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1442
-				        $value = $file_path['url'];
1439
+					// If this is a single upload file
1440
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1441
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1442
+						$value = $file_path['url'];
1443 1443
 
1444
-				    } else {
1444
+					} else {
1445 1445
 
1446
-				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1447
-				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1448
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1446
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1447
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1448
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1449 1449
 
1450
-				    }
1450
+					}
1451 1451
 
1452
-				    if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1452
+					if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1453 1453
 
1454
-				        // If there are fresh uploads, process and merge them.
1455
-				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1456
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1457
-				            $value = empty( $value ) ? '[]' : $value;
1458
-				            $value = stripslashes_deep( $value );
1459
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1460
-				        }
1454
+						// If there are fresh uploads, process and merge them.
1455
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1456
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1457
+							$value = empty( $value ) ? '[]' : $value;
1458
+							$value = stripslashes_deep( $value );
1459
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1460
+						}
1461 1461
 
1462
-				    } else {
1462
+					} else {
1463 1463
 
1464
-				        // A file already exists when editing an entry
1465
-				        // We set this to solve issue when file upload fields are required.
1466
-				        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1464
+						// A file already exists when editing an entry
1465
+						// We set this to solve issue when file upload fields are required.
1466
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1467 1467
 
1468
-				    }
1468
+					}
1469 1469
 
1470
-				    $this->entry[ $input_name ] = $value;
1471
-				    $_POST[ $input_name ] = $value;
1470
+					$this->entry[ $input_name ] = $value;
1471
+					$_POST[ $input_name ] = $value;
1472 1472
 
1473
-				    break;
1473
+					break;
1474 1474
 
1475 1475
 				case 'number':
1476
-				    // Fix "undefined index" issue at line 1286 in form_display.php
1477
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1478
-				        $_POST['input_'.$field->id ] = NULL;
1479
-				    }
1480
-				    break;
1476
+					// Fix "undefined index" issue at line 1286 in form_display.php
1477
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1478
+						$_POST['input_'.$field->id ] = NULL;
1479
+					}
1480
+					break;
1481 1481
 			}
1482 1482
 
1483 1483
 		}
@@ -1562,43 +1562,43 @@  discard block
 block discarded – undo
1562 1562
 				case 'fileupload' :
1563 1563
 				case 'post_image':
1564 1564
 
1565
-				    // in case nothing is uploaded but there are already files saved
1566
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1567
-				        $field->failed_validation = false;
1568
-				        unset( $field->validation_message );
1569
-				    }
1565
+					// in case nothing is uploaded but there are already files saved
1566
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1567
+						$field->failed_validation = false;
1568
+						unset( $field->validation_message );
1569
+					}
1570 1570
 
1571
-				    // validate if multi file upload reached max number of files [maxFiles] => 2
1572
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1571
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1572
+					if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1573 1573
 
1574
-				        $input_name = 'input_' . $field->id;
1575
-				        //uploaded
1576
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1574
+						$input_name = 'input_' . $field->id;
1575
+						//uploaded
1576
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1577 1577
 
1578
-				        //existent
1579
-				        $entry = $this->get_entry();
1580
-				        $value = NULL;
1581
-				        if( isset( $entry[ $field->id ] ) ) {
1582
-				            $value = json_decode( $entry[ $field->id ], true );
1583
-				        }
1578
+						//existent
1579
+						$entry = $this->get_entry();
1580
+						$value = NULL;
1581
+						if( isset( $entry[ $field->id ] ) ) {
1582
+							$value = json_decode( $entry[ $field->id ], true );
1583
+						}
1584 1584
 
1585
-				        // count uploaded files and existent entry files
1586
-				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1587
-						               ( is_array( $value ) ? count( $value ) : 0 );
1585
+						// count uploaded files and existent entry files
1586
+						$count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1587
+									   ( is_array( $value ) ? count( $value ) : 0 );
1588 1588
 
1589
-				        if( $count_files > $field->maxFiles ) {
1590
-				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1591
-				            $field->failed_validation = 1;
1592
-				            $gv_valid = false;
1589
+						if( $count_files > $field->maxFiles ) {
1590
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1591
+							$field->failed_validation = 1;
1592
+							$gv_valid = false;
1593 1593
 
1594
-				            // in case of error make sure the newest upload files are removed from the upload input
1595
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1596
-				        }
1594
+							// in case of error make sure the newest upload files are removed from the upload input
1595
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1596
+						}
1597 1597
 
1598
-				    }
1598
+					}
1599 1599
 
1600 1600
 
1601
-				    break;
1601
+					break;
1602 1602
 
1603 1603
 			}
1604 1604
 
@@ -1609,47 +1609,47 @@  discard block
 block discarded – undo
1609 1609
 
1610 1610
 				switch ( $field_type ) {
1611 1611
 
1612
-				    // Captchas don't need to be re-entered.
1613
-				    case 'captcha':
1612
+					// Captchas don't need to be re-entered.
1613
+					case 'captcha':
1614 1614
 
1615
-				        // Post Image fields aren't editable, so we un-fail them.
1616
-				    case 'post_image':
1617
-				        $field->failed_validation = false;
1618
-				        unset( $field->validation_message );
1619
-				        break;
1615
+						// Post Image fields aren't editable, so we un-fail them.
1616
+					case 'post_image':
1617
+						$field->failed_validation = false;
1618
+						unset( $field->validation_message );
1619
+						break;
1620 1620
 
1621 1621
 				}
1622 1622
 
1623 1623
 				// You can't continue inside a switch, so we do it after.
1624 1624
 				if( empty( $field->failed_validation ) ) {
1625
-				    continue;
1625
+					continue;
1626 1626
 				}
1627 1627
 
1628 1628
 				// checks if the No Duplicates option is not validating entry against itself, since
1629 1629
 				// we're editing a stored entry, it would also assume it's a duplicate.
1630 1630
 				if( !empty( $field->noDuplicates ) ) {
1631 1631
 
1632
-				    $entry = $this->get_entry();
1632
+					$entry = $this->get_entry();
1633 1633
 
1634
-				    // If the value of the entry is the same as the stored value
1635
-				    // Then we can assume it's not a duplicate, it's the same.
1636
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1637
-				        //if value submitted was not changed, then don't validate
1638
-				        $field->failed_validation = false;
1634
+					// If the value of the entry is the same as the stored value
1635
+					// Then we can assume it's not a duplicate, it's the same.
1636
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1637
+						//if value submitted was not changed, then don't validate
1638
+						$field->failed_validation = false;
1639 1639
 
1640
-				        unset( $field->validation_message );
1640
+						unset( $field->validation_message );
1641 1641
 
1642
-				        gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1642
+						gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1643 1643
 
1644
-				        continue;
1645
-				    }
1644
+						continue;
1645
+					}
1646 1646
 				}
1647 1647
 
1648 1648
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1649 1649
 				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1650
-				    unset( $field->validation_message );
1651
-	                $field->validation_message = false;
1652
-				    continue;
1650
+					unset( $field->validation_message );
1651
+					$field->validation_message = false;
1652
+					continue;
1653 1653
 				}
1654 1654
 
1655 1655
 				$gv_valid = false;
@@ -1713,8 +1713,8 @@  discard block
 block discarded – undo
1713 1713
 		// Hide fields depending on admin settings
1714 1714
 		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1715 1715
 
1716
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1717
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1716
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1717
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1718 1718
 
1719 1719
 		/**
1720 1720
 		 * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
@@ -1774,11 +1774,11 @@  discard block
 block discarded – undo
1774 1774
 		// The edit tab has been configured, so we loop through to configured settings
1775 1775
 		foreach ( $configured_fields as $configured_field ) {
1776 1776
 
1777
-	        /** @var GF_Field $field */
1778
-	        foreach ( $fields as $field ) {
1777
+			/** @var GF_Field $field */
1778
+			foreach ( $fields as $field ) {
1779 1779
 				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1780
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1781
-				    break;
1780
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1781
+					break;
1782 1782
 				}
1783 1783
 
1784 1784
 			}
@@ -1834,28 +1834,28 @@  discard block
 block discarded – undo
1834 1834
 	 */
1835 1835
 	private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1836 1836
 
1837
-	    /**
1837
+		/**
1838 1838
 		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1839
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1840
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1841
-	     * @since 1.9.1
1842
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1843
-	     * @param array $form GF Form array
1844
-	     * @param int $view_id View ID
1845
-	     */
1846
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1847
-
1848
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1839
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1840
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1841
+		 * @since 1.9.1
1842
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1843
+		 * @param array $form GF Form array
1844
+		 * @param int $view_id View ID
1845
+		 */
1846
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1847
+
1848
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1849 1849
 			foreach( $fields as $k => $field ) {
1850 1850
 				if( $field->adminOnly ) {
1851
-				    unset( $fields[ $k ] );
1851
+					unset( $fields[ $k ] );
1852 1852
 				}
1853 1853
 			}
1854 1854
 			return array_values( $fields );
1855 1855
 		}
1856 1856
 
1857
-	    foreach( $fields as &$field ) {
1858
-		    $field->adminOnly = false;
1857
+		foreach( $fields as &$field ) {
1858
+			$field->adminOnly = false;
1859 1859
 		}
1860 1860
 
1861 1861
 		return $fields;
@@ -1875,13 +1875,13 @@  discard block
 block discarded – undo
1875 1875
 	 */
1876 1876
 	private function unselect_default_values( $form ) {
1877 1877
 
1878
-	    foreach ( $form['fields'] as &$field ) {
1878
+		foreach ( $form['fields'] as &$field ) {
1879 1879
 
1880 1880
 			if ( empty( $field->choices ) ) {
1881
-                continue;
1881
+				continue;
1882 1882
 			}
1883 1883
 
1884
-            foreach ( $field->choices as &$choice ) {
1884
+			foreach ( $field->choices as &$choice ) {
1885 1885
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1886 1886
 					$choice['isSelected'] = false;
1887 1887
 				}
@@ -1918,36 +1918,36 @@  discard block
 block discarded – undo
1918 1918
 
1919 1919
 			if( 'checkbox' === $field->type ) {
1920 1920
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1921
-				    $input_id = $input['id'];
1922
-				    $choice = $field->choices[ $key ];
1923
-				    $value = \GV\Utils::get( $this->entry, $input_id );
1924
-				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1925
-				    if( $match ) {
1926
-				        $field->choices[ $key ]['isSelected'] = true;
1927
-				    }
1921
+					$input_id = $input['id'];
1922
+					$choice = $field->choices[ $key ];
1923
+					$value = \GV\Utils::get( $this->entry, $input_id );
1924
+					$match = RGFormsModel::choice_value_match( $field, $choice, $value );
1925
+					if( $match ) {
1926
+						$field->choices[ $key ]['isSelected'] = true;
1927
+					}
1928 1928
 				}
1929 1929
 			} else {
1930 1930
 
1931 1931
 				// We need to run through each field to set the default values
1932 1932
 				foreach ( $this->entry as $field_id => $field_value ) {
1933 1933
 
1934
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1934
+					if( floatval( $field_id ) === floatval( $field->id ) ) {
1935 1935
 
1936
-				        if( 'list' === $field->type ) {
1937
-				            $list_rows = maybe_unserialize( $field_value );
1936
+						if( 'list' === $field->type ) {
1937
+							$list_rows = maybe_unserialize( $field_value );
1938 1938
 
1939
-				            $list_field_value = array();
1940
-				            foreach ( (array) $list_rows as $row ) {
1941
-				                foreach ( (array) $row as $column ) {
1942
-				                    $list_field_value[] = $column;
1943
-				                }
1944
-				            }
1939
+							$list_field_value = array();
1940
+							foreach ( (array) $list_rows as $row ) {
1941
+								foreach ( (array) $row as $column ) {
1942
+									$list_field_value[] = $column;
1943
+								}
1944
+							}
1945 1945
 
1946
-				            $field->defaultValue = serialize( $list_field_value );
1947
-				        } else {
1948
-				            $field->defaultValue = $field_value;
1949
-				        }
1950
-				    }
1946
+							$field->defaultValue = serialize( $list_field_value );
1947
+						} else {
1948
+							$field->defaultValue = $field_value;
1949
+						}
1950
+					}
1951 1951
 				}
1952 1952
 			}
1953 1953
 		}
@@ -2004,7 +2004,7 @@  discard block
 block discarded – undo
2004 2004
 			return $has_conditional_logic;
2005 2005
 		}
2006 2006
 
2007
-	    /** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2007
+		/** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2008 2008
 		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
2009 2009
 	}
2010 2010
 
@@ -2071,14 +2071,14 @@  discard block
 block discarded – undo
2071 2071
 
2072 2072
 		if( $echo && $error !== true ) {
2073 2073
 
2074
-	        $error = esc_html( $error );
2074
+			$error = esc_html( $error );
2075 2075
 
2076
-	        /**
2077
-	         * @since 1.9
2078
-	         */
2079
-	        if ( ! empty( $this->entry ) ) {
2080
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2081
-	        }
2076
+			/**
2077
+			 * @since 1.9
2078
+			 */
2079
+			if ( ! empty( $this->entry ) ) {
2080
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2081
+			}
2082 2082
 
2083 2083
 			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2084 2084
 		}
Please login to merge, or discard this patch.
Spacing   +219 added lines, -219 removed lines patch added patch discarded remove patch
@@ -123,16 +123,16 @@  discard block
 block discarded – undo
123 123
 	function load() {
124 124
 
125 125
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
126
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
126
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
127 127
 
128 128
 		// Don't display an embedded form when editing an entry
129 129
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
130 130
 		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
131 131
 
132 132
 		// Stop Gravity Forms processing what is ours!
133
-		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
133
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
134 134
 
135
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
135
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
136 136
 
137 137
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
138 138
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
144 144
 
145 145
 		// Add fields expected by GFFormDisplay::validate()
146
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
146
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
147 147
 
148 148
 		// Fix multiselect value for GF 2.2
149 149
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	 * @return void
161 161
 	 */
162 162
 	public function prevent_render_form() {
163
-		if( $this->is_edit_entry() ) {
164
-			if( 'wp_head' === current_filter() ) {
163
+		if ( $this->is_edit_entry() ) {
164
+			if ( 'wp_head' === current_filter() ) {
165 165
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
166 166
 			} else {
167 167
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -176,13 +176,13 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179
-		if( ! empty( $_POST ) ) {
179
+		if ( ! empty( $_POST ) ) {
180 180
 	        gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
181 181
 		}
182 182
 
183
-		if( $this->is_edit_entry_submission() ) {
184
-			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
185
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
183
+		if ( $this->is_edit_entry_submission() ) {
184
+			remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
185
+	        remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
186 186
 		}
187 187
 	}
188 188
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function is_edit_entry() {
194 194
 
195
-		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
195
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET[ 'edit' ] );
196 196
 
197 197
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
198 198
 	}
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @return boolean
204 204
 	 */
205 205
 	public function is_edit_entry_submission() {
206
-		return !empty( $_POST[ self::$nonce_field ] );
206
+		return ! empty( $_POST[ self::$nonce_field ] );
207 207
 	}
208 208
 
209 209
 	/**
@@ -216,16 +216,16 @@  discard block
 block discarded – undo
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+	    self::$original_entry = $entries[ 0 ];
220
+	    $this->entry = $entries[ 0 ];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
224
-		$this->form_id = $this->entry['form_id'];
224
+		$this->form_id = $this->entry[ 'form_id' ];
225 225
 		$this->view_id = $gravityview_view->getViewId();
226 226
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
227 227
 
228
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
228
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
229 229
 	}
230 230
 
231 231
 
@@ -284,9 +284,9 @@  discard block
 block discarded – undo
284 284
 	private function print_scripts() {
285 285
 		$gravityview_view = GravityView_View::getInstance();
286 286
 
287
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
287
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
288 288
 
289
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
289
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
290 290
 
291 291
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
292 292
 
@@ -302,19 +302,19 @@  discard block
 block discarded – undo
302 302
 	 */
303 303
 	private function process_save( $gv_data ) {
304 304
 
305
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
305
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
306 306
 			return;
307 307
 		}
308 308
 
309 309
 		// Make sure the entry, view, and form IDs are all correct
310 310
 		$valid = $this->verify_nonce();
311 311
 
312
-		if ( !$valid ) {
312
+		if ( ! $valid ) {
313 313
 			gravityview()->log->error( 'Nonce validation failed.' );
314 314
 			return;
315 315
 		}
316 316
 
317
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
317
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
318 318
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
319 319
 			return;
320 320
 		}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$this->validate();
327 327
 
328
-		if( $this->is_valid ) {
328
+		if ( $this->is_valid ) {
329 329
 
330 330
 			gravityview()->log->debug( 'Submission is valid.' );
331 331
 
@@ -337,15 +337,15 @@  discard block
 block discarded – undo
337 337
 			/**
338 338
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
339 339
 			 */
340
-			unset( $_GET['page'] );
340
+			unset( $_GET[ 'page' ] );
341 341
 
342
-			$date_created = $this->entry['date_created'];
342
+			$date_created = $this->entry[ 'date_created' ];
343 343
 
344 344
 			/**
345 345
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
346 346
 			 * @since 1.17.2
347 347
 			 */
348
-			unset( $this->entry['date_created'] );
348
+			unset( $this->entry[ 'date_created' ] );
349 349
 
350 350
 			/**
351 351
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 			 * @param GravityView_Edit_Entry_Render $this This object
356 356
 			 * @param GravityView_View_Data $gv_data The View data
357 357
 			 */
358
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
358
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362 362
 	        // Delete the values for hidden inputs
363 363
 	        $this->unset_hidden_field_values();
364 364
 			
365
-			$this->entry['date_created'] = $date_created;
365
+			$this->entry[ 'date_created' ] = $date_created;
366 366
 
367 367
 			// Process calculation fields
368 368
 			$this->update_calculation_fields();
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
385 385
 			 * @param GravityView_View_Data $gv_data The View data
386 386
 			 */
387
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
387
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
388 388
 
389 389
 		} else {
390 390
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -412,16 +412,16 @@  discard block
 block discarded – undo
412 412
 		 */
413 413
 		$unset_hidden_field_values = apply_filters( 'gravityview/edit_entry/unset_hidden_field_values', true, $this );
414 414
 
415
-		if( ! $unset_hidden_field_values ) {
415
+		if ( ! $unset_hidden_field_values ) {
416 416
 			return;
417 417
 		}
418 418
 
419 419
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
420 420
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
421
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
421
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
422 422
 		} else {
423 423
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
424
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
424
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
425 425
 		}
426 426
 
427 427
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437
-					$this->form, '', $this->entry['id'], $this->entry
437
+					$this->form, '', $this->entry[ 'id' ], $this->entry
438 438
 				);
439 439
 
440 440
 			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 		}
505 505
 
506 506
 		/** No file is being uploaded. */
507
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
507
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
508 508
 			/** So return the original upload */
509 509
 			return $entry[ $input_id ];
510 510
 		}
@@ -522,11 +522,11 @@  discard block
 block discarded – undo
522 522
 	 * @return mixed
523 523
 	 */
524 524
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
525
-		if( ! $this->is_edit_entry() ) {
525
+		if ( ! $this->is_edit_entry() ) {
526 526
 			return $plupload_init;
527 527
 		}
528 528
 
529
-		$plupload_init['gf_vars']['max_files'] = 0;
529
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
530 530
 
531 531
 		return $plupload_init;
532 532
 	}
@@ -543,22 +543,22 @@  discard block
 block discarded – undo
543 543
 		$non_submitted_fields = array();
544 544
 
545 545
 	    /** @var GF_Field $field */
546
-		foreach( $form['fields'] as $k => &$field ) {
546
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
547 547
 
548 548
 			/**
549 549
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
550 550
 			 * @since 1.16.3
551 551
 			 * @var GF_Field $field
552 552
 			 */
553
-			if( $field->has_calculation() ) {
554
-				unset( $form['fields'][ $k ] );
553
+			if ( $field->has_calculation() ) {
554
+				unset( $form[ 'fields' ][ $k ] );
555 555
 			}
556 556
 
557 557
 			$field->adminOnly = false;
558 558
 
559
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
560
-				foreach( $field->inputs as $key => $input ) {
561
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
559
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
560
+				foreach ( $field->inputs as $key => $input ) {
561
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
562 562
 				}
563 563
 			}
564 564
 
@@ -567,11 +567,11 @@  discard block
 block discarded – undo
567 567
 			 * are not present in the edit view fields.
568 568
 			 * @since develop
569 569
 			 */
570
-			if ( ! empty( $field['conditionalLogic'] ) && ! empty( $field['conditionalLogic']['rules'] ) ) {
571
-				foreach ( wp_list_pluck( $field['conditionalLogic']['rules'], 'fieldId' ) as $conditional_id ) {
570
+			if ( ! empty( $field[ 'conditionalLogic' ] ) && ! empty( $field[ 'conditionalLogic' ][ 'rules' ] ) ) {
571
+				foreach ( wp_list_pluck( $field[ 'conditionalLogic' ][ 'rules' ], 'fieldId' ) as $conditional_id ) {
572 572
 					$post_input_id = 'input_' . str_replace( '.', '_', $conditional_id );
573 573
 					if ( ! isset( $_POST[ $post_input_id ] ) ) {
574
-						$non_submitted_fields []= $conditional_id;
574
+						$non_submitted_fields [ ] = $conditional_id;
575 575
 					}
576 576
 				}
577 577
 			}
@@ -583,13 +583,13 @@  discard block
 block discarded – undo
583 583
 		 * (or need) to remove all fields that are not being submitted. Or look
584 584
 		 * at the view edit configuration.
585 585
 		 */
586
-		foreach ( $form['fields'] as $k => $field ) {
587
-			if ( in_array( $field['id'], $non_submitted_fields ) ) {
588
-				unset( $form['fields'][ $k ] );
586
+		foreach ( $form[ 'fields' ] as $k => $field ) {
587
+			if ( in_array( $field[ 'id' ], $non_submitted_fields ) ) {
588
+				unset( $form[ 'fields' ][ $k ] );
589 589
 			}
590 590
 		}
591 591
 
592
-		$form['fields'] = array_values( $form['fields'] );
592
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
593 593
 
594 594
 		return $form;
595 595
 	}
@@ -601,14 +601,14 @@  discard block
 block discarded – undo
601 601
 		$update = false;
602 602
 
603 603
 		// get the most up to date entry values
604
-		$entry = GFAPI::get_entry( $this->entry['id'] );
604
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
605 605
 
606 606
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
607 607
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
608
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
608
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
609 609
 		} else {
610 610
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
611
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
611
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
612 612
 		}
613 613
 
614 614
 
@@ -620,24 +620,24 @@  discard block
 block discarded – undo
620 620
 				$inputs = $field->get_entry_inputs();
621 621
 				if ( is_array( $inputs ) ) {
622 622
 				    foreach ( $inputs as $input ) {
623
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
623
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
624 624
 
625 625
 						if ( 'product' === $field->type ) {
626
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
626
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
627 627
 
628 628
 							// Only allow quantity to be set if it's allowed to be edited
629 629
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
630 630
 							} else { // otherwise set to what it previously was
631
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
631
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
632 632
 							}
633 633
 						} else {
634 634
 							// Set to what it previously was if it's not editable
635 635
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
636
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
636
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
637 637
 							}
638 638
 						}
639 639
 
640
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
640
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
641 641
 				    }
642 642
 				} else {
643 643
 					// Set to what it previously was if it's not editable
@@ -677,19 +677,19 @@  discard block
 block discarded – undo
677 677
 
678 678
 		$input_name = 'input_' . $field_id;
679 679
 
680
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
680
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
681 681
 
682 682
 			// We have a new image
683 683
 
684
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
684
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
685 685
 
686 686
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
687 687
 	        $ary = stripslashes_deep( $ary );
688 688
 			$img_url = \GV\Utils::get( $ary, 0 );
689 689
 
690
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
691
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
692
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
690
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
691
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
692
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
693 693
 
694 694
 			$image_meta = array(
695 695
 				'post_excerpt' => $img_caption,
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
 
699 699
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
700 700
 			if ( ! empty( $img_title ) ) {
701
-				$image_meta['post_title'] = $img_title;
701
+				$image_meta[ 'post_title' ] = $img_title;
702 702
 			}
703 703
 
704 704
 			/**
@@ -756,15 +756,15 @@  discard block
 block discarded – undo
756 756
 	 */
757 757
 	private function maybe_update_post_fields( $form ) {
758 758
 
759
-		if( empty( $this->entry['post_id'] ) ) {
759
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
760 760
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
761 761
 			return;
762 762
 		}
763 763
 
764
-		$post_id = $this->entry['post_id'];
764
+		$post_id = $this->entry[ 'post_id' ];
765 765
 
766 766
 		// Security check
767
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
767
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
768 768
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
769 769
 			return;
770 770
 		}
@@ -777,25 +777,25 @@  discard block
 block discarded – undo
777 777
 
778 778
 			$field = RGFormsModel::get_field( $form, $field_id );
779 779
 
780
-			if( ! $field ) {
780
+			if ( ! $field ) {
781 781
 				continue;
782 782
 			}
783 783
 
784
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
784
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
785 785
 
786 786
 				// Get the value of the field, including $_POSTed value
787 787
 				$value = RGFormsModel::get_field_value( $field );
788 788
 
789 789
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
790 790
 				$entry_tmp = $this->entry;
791
-				$entry_tmp["{$field_id}"] = $value;
791
+				$entry_tmp[ "{$field_id}" ] = $value;
792 792
 
793
-				switch( $field->type ) {
793
+				switch ( $field->type ) {
794 794
 
795 795
 				    case 'post_title':
796 796
 				        $post_title = $value;
797 797
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
798
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
798
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
799 799
 				        }
800 800
 				        $updated_post->post_title = $post_title;
801 801
 				        $updated_post->post_name  = $post_title;
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
 				    case 'post_content':
806 806
 				        $post_content = $value;
807 807
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
808
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
808
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
809 809
 				        }
810 810
 				        $updated_post->post_content = $post_content;
811 811
 				        unset( $post_content );
@@ -823,11 +823,11 @@  discard block
 block discarded – undo
823 823
 							$value = $value[ $field_id ];
824 824
 						}
825 825
 
826
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
826
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
827 827
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
828 828
 				        }
829 829
 
830
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
830
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
831 831
 
832 832
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
833 833
 				        break;
@@ -839,7 +839,7 @@  discard block
 block discarded – undo
839 839
 				}
840 840
 
841 841
 				// update entry after
842
-				$this->entry["{$field_id}"] = $value;
842
+				$this->entry[ "{$field_id}" ] = $value;
843 843
 
844 844
 				$update_entry = true;
845 845
 
@@ -848,11 +848,11 @@  discard block
 block discarded – undo
848 848
 
849 849
 		}
850 850
 
851
-		if( $update_entry ) {
851
+		if ( $update_entry ) {
852 852
 
853 853
 			$return_entry = GFAPI::update_entry( $this->entry );
854 854
 
855
-			if( is_wp_error( $return_entry ) ) {
855
+			if ( is_wp_error( $return_entry ) ) {
856 856
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
857 857
 			} else {
858 858
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -862,7 +862,7 @@  discard block
 block discarded – undo
862 862
 
863 863
 		$return_post = wp_update_post( $updated_post, true );
864 864
 
865
-		if( is_wp_error( $return_post ) ) {
865
+		if ( is_wp_error( $return_post ) ) {
866 866
 			$return_post->add_data( $updated_post, '$updated_post' );
867 867
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
868 868
 		} else {
@@ -896,7 +896,7 @@  discard block
 block discarded – undo
896 896
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
897 897
 
898 898
 		// replace conditional shortcodes
899
-		if( $do_shortcode ) {
899
+		if ( $do_shortcode ) {
900 900
 			$output = do_shortcode( $output );
901 901
 		}
902 902
 
@@ -915,19 +915,19 @@  discard block
 block discarded – undo
915 915
 	 */
916 916
 	private function after_update() {
917 917
 
918
-		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
919
-		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
918
+		do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ], self::$original_entry );
919
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ], self::$original_entry );
920 920
 
921 921
 		// Re-define the entry now that we've updated it.
922
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
922
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
923 923
 
924 924
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
925 925
 
926 926
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
927 927
 			// We need to clear the cache because Gravity Forms caches the field values, which
928 928
 			// we have just updated.
929
-			foreach ($this->form['fields'] as $key => $field) {
930
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
929
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
930
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
931 931
 			}
932 932
 		}
933 933
 
@@ -937,11 +937,11 @@  discard block
 block discarded – undo
937 937
 		 * @since develop
938 938
 		 */
939 939
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
940
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
940
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
941 941
 			if ( ! is_wp_error( $feeds ) ) {
942 942
 				$registered_feeds = array();
943 943
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
944
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
944
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
945 945
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
946 946
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
947 947
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -949,8 +949,8 @@  discard block
 block discarded – undo
949 949
 					}
950 950
 				}
951 951
 				foreach ( $feeds as $feed ) {
952
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
953
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
952
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
953
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
954 954
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
955 955
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
956 956
 								$entry = $returned_entry;
@@ -980,7 +980,7 @@  discard block
 block discarded – undo
980 980
 
981 981
 		<div class="gv-edit-entry-wrapper"><?php
982 982
 
983
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
983
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
984 984
 
985 985
 			/**
986 986
 			 * Fixes weird wpautop() issue
@@ -996,7 +996,7 @@  discard block
 block discarded – undo
996 996
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
997 997
 				     * @param GravityView_Edit_Entry_Render $this This object
998 998
 				     */
999
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
999
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
1000 1000
 
1001 1001
 				    echo esc_attr( $edit_entry_title );
1002 1002
 			?></span>
@@ -1046,13 +1046,13 @@  discard block
 block discarded – undo
1046 1046
 
1047 1047
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1048 1048
 
1049
-			if( ! $this->is_valid ){
1049
+			if ( ! $this->is_valid ) {
1050 1050
 
1051 1051
 				// Keeping this compatible with Gravity Forms.
1052
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1053
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1052
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1053
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1054 1054
 
1055
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1055
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1056 1056
 
1057 1057
 			} else {
1058 1058
 				$view = \GV\View::by_id( $this->view_id );
@@ -1063,23 +1063,23 @@  discard block
 block discarded – undo
1063 1063
 
1064 1064
                     case '0':
1065 1065
 	                    $redirect_url = $back_link;
1066
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1066
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1067 1067
                         break;
1068 1068
 
1069 1069
                     case '1':
1070 1070
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1071
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1071
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1072 1072
 	                    break;
1073 1073
 
1074 1074
                     case '2':
1075 1075
 	                    $redirect_url = $edit_redirect_url;
1076 1076
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1077
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1077
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1078 1078
                         break;
1079 1079
 
1080 1080
                     case '':
1081 1081
                     default:
1082
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1082
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1083 1083
                         break;
1084 1084
 				}
1085 1085
 
@@ -1095,7 +1095,7 @@  discard block
 block discarded – undo
1095 1095
 				 * @param array $entry Gravity Forms entry array
1096 1096
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1097 1097
 				 */
1098
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1098
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1099 1099
 
1100 1100
 				echo GVCommon::generate_notice( $message );
1101 1101
 			}
@@ -1119,21 +1119,21 @@  discard block
 block discarded – undo
1119 1119
 		 */
1120 1120
 		do_action( 'gravityview/edit-entry/render/before', $this );
1121 1121
 
1122
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1123
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1122
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1123
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1124 1124
 		add_filter( 'gform_disable_view_counter', '__return_true' );
1125 1125
 
1126 1126
 		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
1127 1127
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1128 1128
 
1129 1129
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1130
-		unset( $_GET['page'] );
1130
+		unset( $_GET[ 'page' ] );
1131 1131
 
1132 1132
 		// TODO: Verify multiple-page forms
1133 1133
 
1134 1134
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1135 1135
 
1136
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1136
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1137 1137
 
1138 1138
 		ob_get_clean();
1139 1139
 
@@ -1159,7 +1159,7 @@  discard block
 block discarded – undo
1159 1159
 	 * @return string
1160 1160
 	 */
1161 1161
 	public function render_form_buttons() {
1162
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1162
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1163 1163
 	}
1164 1164
 
1165 1165
 
@@ -1179,10 +1179,10 @@  discard block
 block discarded – undo
1179 1179
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1180 1180
 
1181 1181
 		// In case we have validated the form, use it to inject the validation results into the form render
1182
-		if( isset( $this->form_after_validation ) ) {
1182
+		if ( isset( $this->form_after_validation ) ) {
1183 1183
 			$form = $this->form_after_validation;
1184 1184
 		} else {
1185
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1185
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1186 1186
 		}
1187 1187
 
1188 1188
 		$form = $this->filter_conditional_logic( $form );
@@ -1190,8 +1190,8 @@  discard block
 block discarded – undo
1190 1190
 		$form = $this->prefill_conditional_logic( $form );
1191 1191
 
1192 1192
 		// for now we don't support Save and Continue feature.
1193
-		if( ! self::$supports_save_and_continue ) {
1194
-	        unset( $form['save'] );
1193
+		if ( ! self::$supports_save_and_continue ) {
1194
+	        unset( $form[ 'save' ] );
1195 1195
 		}
1196 1196
 
1197 1197
 		$form = $this->unselect_default_values( $form );
@@ -1214,31 +1214,31 @@  discard block
 block discarded – undo
1214 1214
 	 */
1215 1215
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1216 1216
 
1217
-		if( ! GFCommon::is_post_field( $field ) ) {
1217
+		if ( ! GFCommon::is_post_field( $field ) ) {
1218 1218
 			return $field_content;
1219 1219
 		}
1220 1220
 
1221 1221
         $message = null;
1222 1222
 
1223 1223
         // First, make sure they have the capability to edit the post.
1224
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1224
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1225 1225
 
1226 1226
             /**
1227 1227
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1228 1228
              * @param string $message The existing "You don't have permission..." text
1229 1229
              */
1230
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1230
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1231 1231
 
1232
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1232
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1233 1233
             /**
1234 1234
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1235 1235
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1236 1236
              */
1237
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1237
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1238 1238
         }
1239 1239
 
1240
-        if( $message ) {
1241
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1240
+        if ( $message ) {
1241
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1242 1242
         }
1243 1243
 
1244 1244
         return $field_content;
@@ -1262,8 +1262,8 @@  discard block
 block discarded – undo
1262 1262
 
1263 1263
 		// If the form has been submitted, then we don't need to pre-fill the values,
1264 1264
 		// Except for fileupload type and when a field input is overridden- run always!!
1265
-		if(
1266
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1265
+		if (
1266
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1267 1267
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1268 1268
 			&& ! GFCommon::is_product_field( $field->type )
1269 1269
 			|| ! empty( $field_content )
@@ -1283,7 +1283,7 @@  discard block
 block discarded – undo
1283 1283
 	    $return = null;
1284 1284
 
1285 1285
 		/** @var GravityView_Field $gv_field */
1286
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1286
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1287 1287
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1288 1288
 		} else {
1289 1289
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1292,7 +1292,7 @@  discard block
 block discarded – undo
1292 1292
 	    // If there was output, it's an error
1293 1293
 	    $warnings = ob_get_clean();
1294 1294
 
1295
-	    if( !empty( $warnings ) ) {
1295
+	    if ( ! empty( $warnings ) ) {
1296 1296
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1297 1297
 	    }
1298 1298
 
@@ -1317,7 +1317,7 @@  discard block
 block discarded – undo
1317 1317
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1318 1318
 
1319 1319
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1320
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1320
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1321 1321
 
1322 1322
 			$field_value = array();
1323 1323
 
@@ -1326,10 +1326,10 @@  discard block
 block discarded – undo
1326 1326
 
1327 1327
 			foreach ( (array)$field->inputs as $input ) {
1328 1328
 
1329
-				$input_id = strval( $input['id'] );
1329
+				$input_id = strval( $input[ 'id' ] );
1330 1330
 
1331 1331
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1332
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1332
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1333 1333
 				    $allow_pre_populated = false;
1334 1334
 				}
1335 1335
 
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
 
1338 1338
 			$pre_value = $field->get_value_submission( array(), false );
1339 1339
 
1340
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1340
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1341 1341
 
1342 1342
 		} else {
1343 1343
 
@@ -1348,13 +1348,13 @@  discard block
 block discarded – undo
1348 1348
 
1349 1349
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1350 1350
 			// or pre-populated value if not empty and set to override saved value
1351
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1351
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1352 1352
 
1353 1353
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1354
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1354
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1355 1355
 				$categories = array();
1356 1356
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1357
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1357
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1358 1358
 				}
1359 1359
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1360 1360
 			}
@@ -1382,7 +1382,7 @@  discard block
 block discarded – undo
1382 1382
 	     * @param GF_Field $field Gravity Forms field object
1383 1383
 	     * @param GravityView_Edit_Entry_Render $this Current object
1384 1384
 	     */
1385
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1385
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1386 1386
 
1387 1387
 		return $field_value;
1388 1388
 	}
@@ -1399,12 +1399,12 @@  discard block
 block discarded – undo
1399 1399
 	 */
1400 1400
 	public function gform_pre_validation( $form ) {
1401 1401
 
1402
-		if( ! $this->verify_nonce() ) {
1402
+		if ( ! $this->verify_nonce() ) {
1403 1403
 			return $form;
1404 1404
 		}
1405 1405
 
1406 1406
 		// Fix PHP warning regarding undefined index.
1407
-		foreach ( $form['fields'] as &$field) {
1407
+		foreach ( $form[ 'fields' ] as &$field ) {
1408 1408
 
1409 1409
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1410 1410
 			// expects certain field array items to be set.
@@ -1412,7 +1412,7 @@  discard block
 block discarded – undo
1412 1412
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1413 1413
 			}
1414 1414
 
1415
-			switch( RGFormsModel::get_input_type( $field ) ) {
1415
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1416 1416
 
1417 1417
 				/**
1418 1418
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1426,26 +1426,26 @@  discard block
 block discarded – undo
1426 1426
 				    // Set the previous value
1427 1427
 				    $entry = $this->get_entry();
1428 1428
 
1429
-				    $input_name = 'input_'.$field->id;
1430
-				    $form_id = $form['id'];
1429
+				    $input_name = 'input_' . $field->id;
1430
+				    $form_id = $form[ 'id' ];
1431 1431
 
1432 1432
 				    $value = NULL;
1433 1433
 
1434 1434
 				    // Use the previous entry value as the default.
1435
-				    if( isset( $entry[ $field->id ] ) ) {
1435
+				    if ( isset( $entry[ $field->id ] ) ) {
1436 1436
 				        $value = $entry[ $field->id ];
1437 1437
 				    }
1438 1438
 
1439 1439
 				    // If this is a single upload file
1440
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1441
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1442
-				        $value = $file_path['url'];
1440
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1441
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1442
+				        $value = $file_path[ 'url' ];
1443 1443
 
1444 1444
 				    } else {
1445 1445
 
1446 1446
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1447 1447
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1448
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1448
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1449 1449
 
1450 1450
 				    }
1451 1451
 
@@ -1453,10 +1453,10 @@  discard block
 block discarded – undo
1453 1453
 
1454 1454
 				        // If there are fresh uploads, process and merge them.
1455 1455
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1456
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1456
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1457 1457
 				            $value = empty( $value ) ? '[]' : $value;
1458 1458
 				            $value = stripslashes_deep( $value );
1459
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1459
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1460 1460
 				        }
1461 1461
 
1462 1462
 				    } else {
@@ -1474,8 +1474,8 @@  discard block
 block discarded – undo
1474 1474
 
1475 1475
 				case 'number':
1476 1476
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1477
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1478
-				        $_POST['input_'.$field->id ] = NULL;
1477
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1478
+				        $_POST[ 'input_' . $field->id ] = NULL;
1479 1479
 				    }
1480 1480
 				    break;
1481 1481
 			}
@@ -1512,7 +1512,7 @@  discard block
 block discarded – undo
1512 1512
 		 * You can enter whatever you want!
1513 1513
 		 * We try validating, and customize the results using `self::custom_validation()`
1514 1514
 		 */
1515
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1515
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1516 1516
 
1517 1517
 		// Needed by the validate funtion
1518 1518
 		$failed_validation_page = NULL;
@@ -1520,14 +1520,14 @@  discard block
 block discarded – undo
1520 1520
 
1521 1521
 		// Prevent entry limit from running when editing an entry, also
1522 1522
 		// prevent form scheduling from preventing editing
1523
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1523
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1524 1524
 
1525 1525
 		// Hide fields depending on Edit Entry settings
1526
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1526
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1527 1527
 
1528 1528
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1529 1529
 
1530
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1530
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1531 1531
 	}
1532 1532
 
1533 1533
 
@@ -1550,7 +1550,7 @@  discard block
 block discarded – undo
1550 1550
 
1551 1551
 		$gv_valid = true;
1552 1552
 
1553
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1553
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1554 1554
 
1555 1555
 			$value = RGFormsModel::get_field_value( $field );
1556 1556
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1563,22 +1563,22 @@  discard block
 block discarded – undo
1563 1563
 				case 'post_image':
1564 1564
 
1565 1565
 				    // in case nothing is uploaded but there are already files saved
1566
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1566
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1567 1567
 				        $field->failed_validation = false;
1568 1568
 				        unset( $field->validation_message );
1569 1569
 				    }
1570 1570
 
1571 1571
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1572
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1572
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1573 1573
 
1574 1574
 				        $input_name = 'input_' . $field->id;
1575 1575
 				        //uploaded
1576
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1576
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1577 1577
 
1578 1578
 				        //existent
1579 1579
 				        $entry = $this->get_entry();
1580 1580
 				        $value = NULL;
1581
-				        if( isset( $entry[ $field->id ] ) ) {
1581
+				        if ( isset( $entry[ $field->id ] ) ) {
1582 1582
 				            $value = json_decode( $entry[ $field->id ], true );
1583 1583
 				        }
1584 1584
 
@@ -1586,13 +1586,13 @@  discard block
 block discarded – undo
1586 1586
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1587 1587
 						               ( is_array( $value ) ? count( $value ) : 0 );
1588 1588
 
1589
-				        if( $count_files > $field->maxFiles ) {
1589
+				        if ( $count_files > $field->maxFiles ) {
1590 1590
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1591 1591
 				            $field->failed_validation = 1;
1592 1592
 				            $gv_valid = false;
1593 1593
 
1594 1594
 				            // in case of error make sure the newest upload files are removed from the upload input
1595
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1595
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1596 1596
 				        }
1597 1597
 
1598 1598
 				    }
@@ -1603,7 +1603,7 @@  discard block
 block discarded – undo
1603 1603
 			}
1604 1604
 
1605 1605
 			// This field has failed validation.
1606
-			if( !empty( $field->failed_validation ) ) {
1606
+			if ( ! empty( $field->failed_validation ) ) {
1607 1607
 
1608 1608
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1609 1609
 
@@ -1621,19 +1621,19 @@  discard block
 block discarded – undo
1621 1621
 				}
1622 1622
 
1623 1623
 				// You can't continue inside a switch, so we do it after.
1624
-				if( empty( $field->failed_validation ) ) {
1624
+				if ( empty( $field->failed_validation ) ) {
1625 1625
 				    continue;
1626 1626
 				}
1627 1627
 
1628 1628
 				// checks if the No Duplicates option is not validating entry against itself, since
1629 1629
 				// we're editing a stored entry, it would also assume it's a duplicate.
1630
-				if( !empty( $field->noDuplicates ) ) {
1630
+				if ( ! empty( $field->noDuplicates ) ) {
1631 1631
 
1632 1632
 				    $entry = $this->get_entry();
1633 1633
 
1634 1634
 				    // If the value of the entry is the same as the stored value
1635 1635
 				    // Then we can assume it's not a duplicate, it's the same.
1636
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1636
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1637 1637
 				        //if value submitted was not changed, then don't validate
1638 1638
 				        $field->failed_validation = false;
1639 1639
 
@@ -1646,7 +1646,7 @@  discard block
 block discarded – undo
1646 1646
 				}
1647 1647
 
1648 1648
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1649
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1649
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1650 1650
 				    unset( $field->validation_message );
1651 1651
 	                $field->validation_message = false;
1652 1652
 				    continue;
@@ -1658,12 +1658,12 @@  discard block
 block discarded – undo
1658 1658
 
1659 1659
 		}
1660 1660
 
1661
-		$validation_results['is_valid'] = $gv_valid;
1661
+		$validation_results[ 'is_valid' ] = $gv_valid;
1662 1662
 
1663 1663
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1664 1664
 
1665 1665
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1666
-		$this->form_after_validation = $validation_results['form'];
1666
+		$this->form_after_validation = $validation_results[ 'form' ];
1667 1667
 
1668 1668
 		return $validation_results;
1669 1669
 	}
@@ -1676,7 +1676,7 @@  discard block
 block discarded – undo
1676 1676
 	 */
1677 1677
 	public function get_entry() {
1678 1678
 
1679
-		if( empty( $this->entry ) ) {
1679
+		if ( empty( $this->entry ) ) {
1680 1680
 			// Get the database value of the entry that's being edited
1681 1681
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1682 1682
 		}
@@ -1708,10 +1708,10 @@  discard block
 block discarded – undo
1708 1708
 		}
1709 1709
 
1710 1710
 		// If edit tab not yet configured, show all fields
1711
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1711
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1712 1712
 
1713 1713
 		// Hide fields depending on admin settings
1714
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1714
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1715 1715
 
1716 1716
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1717 1717
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1743,7 +1743,7 @@  discard block
 block discarded – undo
1743 1743
 	 */
1744 1744
 	private function filter_fields( $fields, $configured_fields ) {
1745 1745
 
1746
-		if( empty( $fields ) || !is_array( $fields ) ) {
1746
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1747 1747
 			return $fields;
1748 1748
 		}
1749 1749
 
@@ -1756,18 +1756,18 @@  discard block
 block discarded – undo
1756 1756
 
1757 1757
 			// Remove the fields that have calculation properties and keep them to be used later
1758 1758
 			// @since 1.16.2
1759
-			if( $field->has_calculation() ) {
1760
-				$this->fields_with_calculation[] = $field;
1759
+			if ( $field->has_calculation() ) {
1760
+				$this->fields_with_calculation[ ] = $field;
1761 1761
 				// don't remove the calculation fields on form render.
1762 1762
 			}
1763 1763
 
1764
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1764
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1765 1765
 				unset( $fields[ $key ] );
1766 1766
 			}
1767 1767
 		}
1768 1768
 
1769 1769
 		// The Edit tab has not been configured, so we return all fields by default.
1770
-		if( empty( $configured_fields ) ) {
1770
+		if ( empty( $configured_fields ) ) {
1771 1771
 			return array_values( $fields );
1772 1772
 		}
1773 1773
 
@@ -1776,8 +1776,8 @@  discard block
 block discarded – undo
1776 1776
 
1777 1777
 	        /** @var GF_Field $field */
1778 1778
 	        foreach ( $fields as $field ) {
1779
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1780
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1779
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1780
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1781 1781
 				    break;
1782 1782
 				}
1783 1783
 
@@ -1800,14 +1800,14 @@  discard block
 block discarded – undo
1800 1800
 
1801 1801
 		$return_field = $field;
1802 1802
 
1803
-		if( empty( $field_setting['show_label'] ) ) {
1803
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1804 1804
 			$return_field->label = '';
1805
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1806
-			$return_field->label = $field_setting['custom_label'];
1805
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1806
+			$return_field->label = $field_setting[ 'custom_label' ];
1807 1807
 		}
1808 1808
 
1809
-		if( !empty( $field_setting['custom_class'] ) ) {
1810
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1809
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1810
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1811 1811
 		}
1812 1812
 
1813 1813
 		/**
@@ -1845,16 +1845,16 @@  discard block
 block discarded – undo
1845 1845
 	     */
1846 1846
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1847 1847
 
1848
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1849
-			foreach( $fields as $k => $field ) {
1850
-				if( $field->adminOnly ) {
1848
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1849
+			foreach ( $fields as $k => $field ) {
1850
+				if ( $field->adminOnly ) {
1851 1851
 				    unset( $fields[ $k ] );
1852 1852
 				}
1853 1853
 			}
1854 1854
 			return array_values( $fields );
1855 1855
 		}
1856 1856
 
1857
-	    foreach( $fields as &$field ) {
1857
+	    foreach ( $fields as &$field ) {
1858 1858
 		    $field->adminOnly = false;
1859 1859
 		}
1860 1860
 
@@ -1875,7 +1875,7 @@  discard block
 block discarded – undo
1875 1875
 	 */
1876 1876
 	private function unselect_default_values( $form ) {
1877 1877
 
1878
-	    foreach ( $form['fields'] as &$field ) {
1878
+	    foreach ( $form[ 'fields' ] as &$field ) {
1879 1879
 
1880 1880
 			if ( empty( $field->choices ) ) {
1881 1881
                 continue;
@@ -1883,7 +1883,7 @@  discard block
 block discarded – undo
1883 1883
 
1884 1884
             foreach ( $field->choices as &$choice ) {
1885 1885
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1886
-					$choice['isSelected'] = false;
1886
+					$choice[ 'isSelected' ] = false;
1887 1887
 				}
1888 1888
 			}
1889 1889
 		}
@@ -1908,22 +1908,22 @@  discard block
 block discarded – undo
1908 1908
 	 */
1909 1909
 	function prefill_conditional_logic( $form ) {
1910 1910
 
1911
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1911
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1912 1912
 			return $form;
1913 1913
 		}
1914 1914
 
1915 1915
 		// Have Conditional Logic pre-fill fields as if the data were default values
1916 1916
 		/** @var GF_Field $field */
1917
-		foreach ( $form['fields'] as &$field ) {
1917
+		foreach ( $form[ 'fields' ] as &$field ) {
1918 1918
 
1919
-			if( 'checkbox' === $field->type ) {
1919
+			if ( 'checkbox' === $field->type ) {
1920 1920
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1921
-				    $input_id = $input['id'];
1921
+				    $input_id = $input[ 'id' ];
1922 1922
 				    $choice = $field->choices[ $key ];
1923 1923
 				    $value = \GV\Utils::get( $this->entry, $input_id );
1924 1924
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1925
-				    if( $match ) {
1926
-				        $field->choices[ $key ]['isSelected'] = true;
1925
+				    if ( $match ) {
1926
+				        $field->choices[ $key ][ 'isSelected' ] = true;
1927 1927
 				    }
1928 1928
 				}
1929 1929
 			} else {
@@ -1931,15 +1931,15 @@  discard block
 block discarded – undo
1931 1931
 				// We need to run through each field to set the default values
1932 1932
 				foreach ( $this->entry as $field_id => $field_value ) {
1933 1933
 
1934
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1934
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
1935 1935
 
1936
-				        if( 'list' === $field->type ) {
1936
+				        if ( 'list' === $field->type ) {
1937 1937
 				            $list_rows = maybe_unserialize( $field_value );
1938 1938
 
1939 1939
 				            $list_field_value = array();
1940
-				            foreach ( (array) $list_rows as $row ) {
1941
-				                foreach ( (array) $row as $column ) {
1942
-				                    $list_field_value[] = $column;
1940
+				            foreach ( (array)$list_rows as $row ) {
1941
+				                foreach ( (array)$row as $column ) {
1942
+				                    $list_field_value[ ] = $column;
1943 1943
 				                }
1944 1944
 				            }
1945 1945
 
@@ -1974,16 +1974,16 @@  discard block
 block discarded – undo
1974 1974
 		 */
1975 1975
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1976 1976
 
1977
-		if( $use_conditional_logic ) {
1977
+		if ( $use_conditional_logic ) {
1978 1978
 			return $form;
1979 1979
 		}
1980 1980
 
1981
-		foreach( $form['fields'] as &$field ) {
1981
+		foreach ( $form[ 'fields' ] as &$field ) {
1982 1982
 			/* @var GF_Field $field */
1983 1983
 			$field->conditionalLogic = null;
1984 1984
 		}
1985 1985
 
1986
-		unset( $form['button']['conditionalLogic'] );
1986
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
1987 1987
 
1988 1988
 		return $form;
1989 1989
 
@@ -2000,7 +2000,7 @@  discard block
 block discarded – undo
2000 2000
 	 */
2001 2001
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
2002 2002
 
2003
-		if( ! $this->is_edit_entry() ) {
2003
+		if ( ! $this->is_edit_entry() ) {
2004 2004
 			return $has_conditional_logic;
2005 2005
 		}
2006 2006
 
@@ -2032,44 +2032,44 @@  discard block
 block discarded – undo
2032 2032
 		 *  2. There are two entries embedded using oEmbed
2033 2033
 		 *  3. One of the entries has just been saved
2034 2034
 		 */
2035
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2035
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2036 2036
 
2037 2037
 			$error = true;
2038 2038
 
2039 2039
 		}
2040 2040
 
2041
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2041
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2042 2042
 
2043 2043
 			$error = true;
2044 2044
 
2045
-		} elseif( ! $this->verify_nonce() ) {
2045
+		} elseif ( ! $this->verify_nonce() ) {
2046 2046
 
2047 2047
 			/**
2048 2048
 			 * If the Entry is embedded, there may be two entries on the same page.
2049 2049
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2050 2050
 			 */
2051
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2051
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2052 2052
 				$error = true;
2053 2053
 			} else {
2054
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2054
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2055 2055
 			}
2056 2056
 
2057 2057
 		}
2058 2058
 
2059
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2060
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2059
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2060
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2061 2061
 		}
2062 2062
 
2063
-		if( $this->entry['status'] === 'trash' ) {
2064
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2063
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2064
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2065 2065
 		}
2066 2066
 
2067 2067
 		// No errors; everything's fine here!
2068
-		if( empty( $error ) ) {
2068
+		if ( empty( $error ) ) {
2069 2069
 			return true;
2070 2070
 		}
2071 2071
 
2072
-		if( $echo && $error !== true ) {
2072
+		if ( $echo && $error !== true ) {
2073 2073
 
2074 2074
 	        $error = esc_html( $error );
2075 2075
 
@@ -2077,10 +2077,10 @@  discard block
 block discarded – undo
2077 2077
 	         * @since 1.9
2078 2078
 	         */
2079 2079
 	        if ( ! empty( $this->entry ) ) {
2080
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2080
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2081 2081
 	        }
2082 2082
 
2083
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2083
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2084 2084
 		}
2085 2085
 
2086 2086
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2100,17 +2100,17 @@  discard block
 block discarded – undo
2100 2100
 
2101 2101
 		$error = NULL;
2102 2102
 
2103
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2104
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2103
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2104
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2105 2105
 		}
2106 2106
 
2107 2107
 		// No errors; everything's fine here!
2108
-		if( empty( $error ) ) {
2108
+		if ( empty( $error ) ) {
2109 2109
 			return true;
2110 2110
 		}
2111 2111
 
2112
-		if( $echo ) {
2113
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2112
+		if ( $echo ) {
2113
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2114 2114
 		}
2115 2115
 
2116 2116
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2131,14 +2131,14 @@  discard block
 block discarded – undo
2131 2131
 	private function check_user_cap_edit_field( $field ) {
2132 2132
 
2133 2133
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2134
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2134
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2135 2135
 			return true;
2136 2136
 		}
2137 2137
 
2138
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2138
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2139 2139
 
2140
-		if( $field_cap ) {
2141
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2140
+		if ( $field_cap ) {
2141
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2142 2142
 		}
2143 2143
 
2144 2144
 		return false;
@@ -2152,17 +2152,17 @@  discard block
 block discarded – undo
2152 2152
 	public function verify_nonce() {
2153 2153
 
2154 2154
 		// Verify form submitted for editing single
2155
-		if( $this->is_edit_entry_submission() ) {
2155
+		if ( $this->is_edit_entry_submission() ) {
2156 2156
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2157 2157
 		}
2158 2158
 
2159 2159
 		// Verify
2160
-		else if( ! $this->is_edit_entry() ) {
2160
+		else if ( ! $this->is_edit_entry() ) {
2161 2161
 			$valid = false;
2162 2162
 		}
2163 2163
 
2164 2164
 		else {
2165
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2165
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2166 2166
 		}
2167 2167
 
2168 2168
 		/**
Please login to merge, or discard this patch.
future/includes/class-gv-template-view-table.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,8 +141,8 @@  discard block
 block discarded – undo
141 141
      *
142 142
      * @see add_columns_sort_links
143 143
 	 * @param string $url Single-sort URL
144
-	 * @param array $sort_args Single sorting for rules, in [ field_id, dir ] format
145
-     * @param string|int $field_id ID of the current field being displayed
144
+	 * @param string[] $sort_args Single sorting for rules, in [ field_id, dir ] format
145
+     * @param string $field_id ID of the current field being displayed
146 146
      *
147 147
      * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url
148 148
 	 */
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	 * Output a field cell.
347 347
 	 *
348 348
 	 * @param \GV\Field $field The field to be ouput.
349
-	 * @param \GV\Field $entry The entry this field is for.
349
+	 * @param Entry $entry The entry this field is for.
350 350
 	 *
351 351
 	 * @return void
352 352
 	 */
Please login to merge, or discard this patch.
Indentation   +88 added lines, -88 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 
20 20
 
21 21
 	/**
22
-     * Constructor. Add filters to modify output.
23
-     *
22
+	 * Constructor. Add filters to modify output.
23
+	 *
24 24
 	 * @since 2.0.4
25 25
 	 *
26 26
 	 * @param View $view
@@ -29,19 +29,19 @@  discard block
 block discarded – undo
29 29
 	 */
30 30
 	public function __construct( View $view, Entry_Collection $entries, Request $request ) {
31 31
 
32
-	    add_filter( 'gravityview/template/field/label', array( __CLASS__, 'add_columns_sort_links' ), 100, 2 );
32
+		add_filter( 'gravityview/template/field/label', array( __CLASS__, 'add_columns_sort_links' ), 100, 2 );
33 33
 
34 34
 		parent::__construct( $view, $entries, $request );
35 35
 	}
36 36
 
37 37
 	/**
38
-     * Add sorting links to HTML columns that support sorting
39
-     *
40
-     * @since 2.0.4
41
-     * @since 2.0.5 Made static
42
-     *
43
-     * @static
44
-     *
38
+	 * Add sorting links to HTML columns that support sorting
39
+	 *
40
+	 * @since 2.0.4
41
+	 * @since 2.0.5 Made static
42
+	 *
43
+	 * @static
44
+	 *
45 45
 	 * @param string $column_label Label for the table column
46 46
 	 * @param \GV\Template_Context $context
47 47
 	 *
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		$sort_columns = $context->view->settings->get( 'sort_columns' );
53 53
 
54 54
 		if ( empty( $sort_columns ) ) {
55
-            return $column_label;
55
+			return $column_label;
56 56
 		}
57 57
 
58 58
 		if ( ! \GravityView_frontend::getInstance()->is_field_sortable( $context->field->ID, $context->view->form->form ) ) {
@@ -102,22 +102,22 @@  discard block
 block discarded – undo
102 102
 		// If we are already sorting by the current field...
103 103
 		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
104 104
 
105
-		    switch( $sorting['direction'] ) {
106
-		        // No sort
107
-                case '':
108
-	                $sort_args[1] = 'asc';
109
-	                $class .= ' gv-icon-caret-up-down';
110
-                    break;
111
-                case 'desc':
112
-	                $sort_args[1] = '';
113
-	                $class .= ' gv-icon-sort-asc';
114
-	                break;
115
-                case 'asc':
116
-                default:
117
-                    $sort_args[1] = 'desc';
118
-                    $class .= ' gv-icon-sort-desc';
119
-                    break;
120
-            }
105
+			switch( $sorting['direction'] ) {
106
+				// No sort
107
+				case '':
108
+					$sort_args[1] = 'asc';
109
+					$class .= ' gv-icon-caret-up-down';
110
+					break;
111
+				case 'desc':
112
+					$sort_args[1] = '';
113
+					$class .= ' gv-icon-sort-asc';
114
+					break;
115
+				case 'asc':
116
+				default:
117
+					$sort_args[1] = 'desc';
118
+					$class .= ' gv-icon-sort-desc';
119
+					break;
120
+			}
121 121
 
122 122
 		} else {
123 123
 			$class .= ' gv-icon-caret-up-down';
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 		$url = remove_query_arg( 'sort', $url );
128 128
 		$multisort_url = self::_get_multisort_url( $url, $sort_args, $context->field->ID );
129 129
 
130
-    	$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
130
+		$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
131 131
 
132 132
 		$return = '<a href="'. esc_url_raw( $url ) .'"';
133 133
 
@@ -141,50 +141,50 @@  discard block
 block discarded – undo
141 141
 	}
142 142
 
143 143
 	/**
144
-     * Get the multi-sort URL used in the sorting links
145
-     *
146
-     * @todo Consider moving to Utils?
147
-     *
148
-     * @since 2.3
149
-     *
150
-     * @see add_columns_sort_links
144
+	 * Get the multi-sort URL used in the sorting links
145
+	 *
146
+	 * @todo Consider moving to Utils?
147
+	 *
148
+	 * @since 2.3
149
+	 *
150
+	 * @see add_columns_sort_links
151 151
 	 * @param string $url Single-sort URL
152 152
 	 * @param array $sort_args Single sorting for rules, in [ field_id, dir ] format
153
-     * @param string|int $field_id ID of the current field being displayed
154
-     *
155
-     * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url
153
+	 * @param string|int $field_id ID of the current field being displayed
154
+	 *
155
+	 * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url
156 156
 	 */
157 157
 	static public function _get_multisort_url( $url, $sort_args, $field_id ) {
158 158
 
159 159
 		$sorts = Utils::_GET( 'sort' );
160 160
 
161 161
 		if ( ! is_array( $sorts ) ) {
162
-            return $url;
162
+			return $url;
163 163
 		}
164 164
 
165
-        $multisort_url = $url;
165
+		$multisort_url = $url;
166 166
 
167 167
 		// If the field has already been sorted by, add the field to the URL
168
-        if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
169
-            if ( count( $keys ) ) {
170
-                $multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
171
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
172
-            } else {
173
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
174
-            }
175
-        }
176
-        // Otherwise, we are just updating the sort order
177
-        else {
178
-
179
-            // Pass empty value to unset
180
-            if( '' === $sort_args[1] ) {
181
-	            unset( $sorts[ $field_id ] );
182
-            } else {
183
-	            $sorts[ $field_id ] = $sort_args[1];
184
-            }
185
-
186
-            $multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
187
-        }
168
+		if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
169
+			if ( count( $keys ) ) {
170
+				$multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
171
+				$multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
172
+			} else {
173
+				$multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
174
+			}
175
+		}
176
+		// Otherwise, we are just updating the sort order
177
+		else {
178
+
179
+			// Pass empty value to unset
180
+			if( '' === $sort_args[1] ) {
181
+				unset( $sorts[ $field_id ] );
182
+			} else {
183
+				$sorts[ $field_id ] = $sort_args[1];
184
+			}
185
+
186
+			$multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
187
+		}
188 188
 
189 189
 		return $multisort_url;
190 190
 	}
@@ -214,10 +214,10 @@  discard block
 block discarded – undo
214 214
 	}
215 215
 
216 216
 	/**
217
-     * Returns the label for a column, with support for all deprecated filters
218
-     *
219
-     * @since 2.1
220
-     *
217
+	 * Returns the label for a column, with support for all deprecated filters
218
+	 *
219
+	 * @since 2.1
220
+	 *
221 221
 	 * @param \GV\Field $field
222 222
 	 * @param \GV\Template_Context $context
223 223
 	 */
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 		$column_label = apply_filters( 'gravityview/template/field/label', $column_label, $context );
241 241
 
242 242
 		return $column_label;
243
-    }
243
+	}
244 244
 
245 245
 	/**
246 246
 	 * Output the entry row.
@@ -309,15 +309,15 @@  discard block
 block discarded – undo
309 309
 				 */
310 310
 				do_action( 'gravityview/template/table/cells/before', $context );
311 311
 
312
-                /**
313
-                 * @action `gravityview_table_cells_before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
314
-                 * @since 1.0.7
312
+				/**
313
+				 * @action `gravityview_table_cells_before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
314
+				 * @since 1.0.7
315 315
 				 * @param \GravityView_View $this Current GravityView_View object
316 316
 				 * @deprecated Use `gravityview/template/table/cells/before`
317
-                 */
318
-                do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
317
+				 */
318
+				do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
319 319
 
320
-                foreach ( $fields->all() as $field ) {
320
+				foreach ( $fields->all() as $field ) {
321 321
 					if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) {
322 322
 						if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) {
323 323
 							$field = $this->view->unions[ $entry['form_id'] ][ $field->ID ];
@@ -337,13 +337,13 @@  discard block
 block discarded – undo
337 337
 				 */
338 338
 				do_action( 'gravityview/template/table/cells/after', $context );
339 339
 
340
-                /**
341
-                 * @action `gravityview_table_cells_after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
342
-                 * @since 1.0.7
340
+				/**
341
+				 * @action `gravityview_table_cells_after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
342
+				 * @since 1.0.7
343 343
 				 * @param \GravityView_View $this Current GravityView_View object
344 344
 				 * @deprecated Use `gravityview/template/table/cells/after`
345
-                 */
346
-                do_action( 'gravityview_table_cells_after', \GravityView_View::getInstance() );
345
+				 */
346
+				do_action( 'gravityview_table_cells_after', \GravityView_View::getInstance() );
347 347
 
348 348
 				?>
349 349
 			</tr>
@@ -384,9 +384,9 @@  discard block
 block discarded – undo
384 384
 			'value' => $value,
385 385
 			'hide_empty' => false,
386 386
 			'zone_id' => 'directory_table-columns',
387
-            'label' => self::get_field_column_label( $field, $context ),
387
+			'label' => self::get_field_column_label( $field, $context ),
388 388
 			'markup' => '<td id="{{ field_id }}" class="{{ class }}" data-label="{{label_value:data-label}}">{{ value }}</td>',
389
-            'form' => $form,
389
+			'form' => $form,
390 390
 		);
391 391
 
392 392
 		/** Output. */
@@ -411,11 +411,11 @@  discard block
 block discarded – undo
411 411
 		do_action( 'gravityview/template/table/body/before', $context );
412 412
 
413 413
 		/**
414
-		* @action `gravityview_table_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
415
-		* @deprecated Use `gravityview/template/table/body/before`
416
-		* @since 1.0.7
417
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
418
-		*/
414
+		 * @action `gravityview_table_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
415
+		 * @deprecated Use `gravityview/template/table/body/before`
416
+		 * @since 1.0.7
417
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
418
+		 */
419 419
 		do_action( 'gravityview_table_body_before', \GravityView_View::getInstance() /** ugh! */ );
420 420
 	}
421 421
 
@@ -437,11 +437,11 @@  discard block
 block discarded – undo
437 437
 		do_action( 'gravityview/template/table/body/after', $context );
438 438
 
439 439
 		/**
440
-		* @action `gravityview_table_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
441
-		* @deprecated Use `gravityview/template/table/body/after`
442
-		* @since 1.0.7
443
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
444
-		*/
440
+		 * @action `gravityview_table_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
441
+		 * @deprecated Use `gravityview/template/table/body/after`
442
+		 * @since 1.0.7
443
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
444
+		 */
445 445
 		do_action( 'gravityview_table_body_after', \GravityView_View::getInstance() /** ugh! */ );
446 446
 	}
447 447
 
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -69,22 +69,22 @@  discard block
 block discarded – undo
69 69
 			if ( is_array( $sorts ) ) {
70 70
 				foreach ( (array)$sorts as $key => $direction ) {
71 71
 					if ( $key == $context->field->ID ) {
72
-						$sorting['key'] = $context->field->ID;
73
-						$sorting['direction'] = strtolower( $direction );
72
+						$sorting[ 'key' ] = $context->field->ID;
73
+						$sorting[ 'direction' ] = strtolower( $direction );
74 74
 						break;
75 75
 					}
76 76
 				}
77 77
 			} else {
78 78
 				if ( $sorts == $context->field->ID ) {
79
-					$sorting['key'] = $context->field->ID;
80
-					$sorting['direction'] = strtolower( Utils::_GET( 'dir', '' ) );
79
+					$sorting[ 'key' ] = $context->field->ID;
80
+					$sorting[ 'direction' ] = strtolower( Utils::_GET( 'dir', '' ) );
81 81
 				}
82 82
 			}
83 83
 		} else {
84 84
 			foreach ( (array)$context->view->settings->get( 'sort_field', array() ) as $i => $sort_field ) {
85 85
 				if ( $sort_field == $context->field->ID ) {
86
-					$sorting['key'] = $sort_field;
87
-					$sorting['direction'] = strtolower( Utils::get( $directions, $i, '' ) );
86
+					$sorting[ 'key' ] = $sort_field;
87
+					$sorting[ 'direction' ] = strtolower( Utils::get( $directions, $i, '' ) );
88 88
 					break; // Only get the first sort
89 89
 				}
90 90
 			}
@@ -100,21 +100,21 @@  discard block
 block discarded – undo
100 100
 		);
101 101
 
102 102
 		// If we are already sorting by the current field...
103
-		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
103
+		if ( ! empty( $sorting[ 'key' ] ) && (string)$sort_field_id === (string)$sorting[ 'key' ] ) {
104 104
 
105
-		    switch( $sorting['direction'] ) {
105
+		    switch ( $sorting[ 'direction' ] ) {
106 106
 		        // No sort
107 107
                 case '':
108
-	                $sort_args[1] = 'asc';
108
+	                $sort_args[ 1 ] = 'asc';
109 109
 	                $class .= ' gv-icon-caret-up-down';
110 110
                     break;
111 111
                 case 'desc':
112
-	                $sort_args[1] = '';
112
+	                $sort_args[ 1 ] = '';
113 113
 	                $class .= ' gv-icon-sort-asc';
114 114
 	                break;
115 115
                 case 'asc':
116 116
                 default:
117
-                    $sort_args[1] = 'desc';
117
+                    $sort_args[ 1 ] = 'desc';
118 118
                     $class .= ' gv-icon-sort-desc';
119 119
                     break;
120 120
             }
@@ -127,15 +127,15 @@  discard block
 block discarded – undo
127 127
 		$url = remove_query_arg( 'sort', $url );
128 128
 		$multisort_url = self::_get_multisort_url( $url, $sort_args, $context->field->ID );
129 129
 
130
-    	$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
130
+    	$url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $url );
131 131
 
132
-		$return = '<a href="'. esc_url_raw( $url ) .'"';
132
+		$return = '<a href="' . esc_url_raw( $url ) . '"';
133 133
 
134 134
 		if ( ! empty( $multisort_url ) ) {
135
-			$return .= ' data-multisort-href="'. esc_url_raw( $multisort_url ) . '"';
135
+			$return .= ' data-multisort-href="' . esc_url_raw( $multisort_url ) . '"';
136 136
 		}
137 137
 
138
-		$return .= ' class="'. $class .'" ></a>&nbsp;'. $column_label;
138
+		$return .= ' class="' . $class . '" ></a>&nbsp;' . $column_label;
139 139
 
140 140
 		return $return;
141 141
 	}
@@ -168,19 +168,19 @@  discard block
 block discarded – undo
168 168
         if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
169 169
             if ( count( $keys ) ) {
170 170
                 $multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
171
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
171
+                $multisort_url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $multisort_url );
172 172
             } else {
173
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
173
+                $multisort_url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $multisort_url );
174 174
             }
175 175
         }
176 176
         // Otherwise, we are just updating the sort order
177 177
         else {
178 178
 
179 179
             // Pass empty value to unset
180
-            if( '' === $sort_args[1] ) {
180
+            if ( '' === $sort_args[ 1 ] ) {
181 181
 	            unset( $sorts[ $field_id ] );
182 182
             } else {
183
-	            $sorts[ $field_id ] = $sort_args[1];
183
+	            $sorts[ $field_id ] = $sort_args[ 1 ];
184 184
             }
185 185
 
186 186
             $multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
@@ -318,9 +318,9 @@  discard block
 block discarded – undo
318 318
                 do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
319 319
 
320 320
                 foreach ( $fields->all() as $field ) {
321
-					if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) {
322
-						if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) {
323
-							$field = $this->view->unions[ $entry['form_id'] ][ $field->ID ];
321
+					if ( isset( $this->view->unions[ $entry[ 'form_id' ] ] ) ) {
322
+						if ( isset( $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ] ) ) {
323
+							$field = $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ];
324 324
 						} else {
325 325
 							if ( ! $field instanceof Internal_Field ) {
326 326
 								$field = Internal_Field::from_configuration( array( 'id' => 'custom' ) );
Please login to merge, or discard this patch.
includes/class-gvlogic-shortcode.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	public static function get_instance() {
96 96
 
97
-		if( empty( self::$instance ) ) {
97
+		if ( empty( self::$instance ) ) {
98 98
 			self::$instance = new self;
99 99
 		}
100 100
 
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
 
129 129
 		$operators = array_merge( self::$SUPPORTED_ARRAY_OPERATORS, self::$SUPPORTED_NUMERIC_OPERATORS, self::$SUPPORTED_SCALAR_OPERATORS, self::$SUPPORTED_CUSTOM_OPERATORS );
130 130
 
131
-		if( $with_values ) {
131
+		if ( $with_values ) {
132 132
 			$operators_with_values = array();
133
-			foreach( $operators as $key ) {
133
+			foreach ( $operators as $key ) {
134 134
 				$operators_with_values[ $key ] = '';
135 135
 			}
136 136
 			return $operators_with_values;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		$operators = $this->get_operators( false );
151 151
 
152
-		if( !in_array( $operation, $operators ) ) {
152
+		if ( ! in_array( $operation, $operators ) ) {
153 153
 			gravityview()->log->debug( ' Attempted to add invalid operation type. {operation}', array( 'operation' => $operation ) );
154 154
 			return false;
155 155
 		}
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 			return null;
202 202
 		}
203 203
 
204
-		if( empty( $atts ) ) {
204
+		if ( empty( $atts ) ) {
205 205
 			gravityview()->log->error( '$atts are empty.', array( 'data' => $atts ) );
206 206
 			return null;
207 207
 		}
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 			$setup = $this->setup_operation_and_comparison();
226 226
 
227 227
 			// We need an operation and comparison value
228
-			if( ! $setup ) {
228
+			if ( ! $setup ) {
229 229
 				gravityview()->log->error( 'No valid operators were passed.', array( 'data' => $this->atts ) );
230 230
 				return null;
231 231
 			}
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 		$logged_in_match = ! $this->logged_in ^ is_user_logged_in(); // XNOR
278 278
 
279 279
 		// Only logged-in match
280
-		if( 1 === sizeof( $this->passed_atts ) ) {
280
+		if ( 1 === sizeof( $this->passed_atts ) ) {
281 281
 			$this->is_match = $logged_in_match;
282 282
 		} else {
283 283
 			$this->is_match = $logged_in_match && $comparison_match;
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 	 */
292 292
 	private function get_output() {
293 293
 
294
-		if( $this->is_match ) {
294
+		if ( $this->is_match ) {
295 295
 			$output = $this->content;
296 296
 		} else {
297 297
 			$output = $this->else_content;
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 		 * @param string $output HTML/text output
310 310
 		 * @param GVLogic_Shortcode $this This class
311 311
 		 */
312
-		$output = apply_filters('gravityview/gvlogic/output', $output, $this );
312
+		$output = apply_filters( 'gravityview/gvlogic/output', $output, $this );
313 313
 
314 314
 		gravityview()->log->debug( 'Output: ', array( 'data' => $output ) );
315 315
 
@@ -329,14 +329,14 @@  discard block
 block discarded – undo
329 329
 		list( $before_else, $after_else ) = array_pad( explode( '[else]', $passed_content ), 2, NULL );
330 330
 		list( $before_else_if, $after_else_if ) = array_pad( explode( '[else', $passed_content ), 2, NULL );
331 331
 
332
-		$else_attr = isset( $this->atts['else'] ) ? $this->atts['else'] : NULL;
332
+		$else_attr = isset( $this->atts[ 'else' ] ) ? $this->atts[ 'else' ] : NULL;
333 333
 		$else_content = isset( $after_else ) ? $after_else : $else_attr;
334 334
 
335 335
 		// The content is everything OTHER than the [else]
336 336
 		$this->content = $before_else_if;
337 337
 
338 338
 		if ( ! $this->is_match ) {
339
-			if( $elseif_content = $this->process_elseif( $before_else ) ) {
339
+			if ( $elseif_content = $this->process_elseif( $before_else ) ) {
340 340
 				$this->else_content = $elseif_content;
341 341
 			} else {
342 342
 				$this->else_content = $else_content;
@@ -364,16 +364,16 @@  discard block
 block discarded – undo
364 364
 		foreach ( $else_if_matches as $key => $else_if_match ) {
365 365
 
366 366
 			// If $else_if_match[5] exists and has content, check for more shortcodes
367
-			preg_match_all( '/' . $regex . '/', $else_if_match[5] . '[/else]', $recursive_matches, PREG_SET_ORDER );
367
+			preg_match_all( '/' . $regex . '/', $else_if_match[ 5 ] . '[/else]', $recursive_matches, PREG_SET_ORDER );
368 368
 
369 369
 			// If the logic passes, this is the value that should be used for $this->else_content
370
-			$else_if_value = $else_if_match[5];
371
-			$check_elseif_match = $else_if_match[0];
370
+			$else_if_value = $else_if_match[ 5 ];
371
+			$check_elseif_match = $else_if_match[ 0 ];
372 372
 
373 373
 			// Retrieve the value of the match that is currently being checked, without any other [else] tags
374
-			if( ! empty( $recursive_matches[0][0] ) ) {
375
-				$else_if_value = str_replace( $recursive_matches[0][0], '', $else_if_value );
376
-				$check_elseif_match = str_replace( $recursive_matches[0][0], '', $check_elseif_match );
374
+			if ( ! empty( $recursive_matches[ 0 ][ 0 ] ) ) {
375
+				$else_if_value = str_replace( $recursive_matches[ 0 ][ 0 ], '', $else_if_value );
376
+				$check_elseif_match = str_replace( $recursive_matches[ 0 ][ 0 ], '', $check_elseif_match );
377 377
 			}
378 378
 
379 379
 			$check_elseif_match = str_replace( '[else', '[gvlogicelse', $check_elseif_match );
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
 			}
391 391
 
392 392
 			// Process any remaining [else] tags
393
-			return $this->process_elseif( $else_if_match[5] );
393
+			return $this->process_elseif( $else_if_match[ 5 ] );
394 394
 		}
395 395
 
396 396
 		return false;
@@ -417,11 +417,11 @@  discard block
 block discarded – undo
417 417
 		$this->atts = array_intersect_key( $this->passed_atts, $this->atts );
418 418
 
419 419
 		// Strip whitespace if it's not default false
420
-		$this->if = ( isset( $this->atts['if'] ) && is_string( $this->atts['if'] ) ) ? trim( $this->atts['if'] ) : false;
420
+		$this->if = ( isset( $this->atts[ 'if' ] ) && is_string( $this->atts[ 'if' ] ) ) ? trim( $this->atts[ 'if' ] ) : false;
421 421
 
422
-		if ( isset( $this->atts['logged_in'] ) ) {
422
+		if ( isset( $this->atts[ 'logged_in' ] ) ) {
423 423
 			// Truthy
424
-			if ( in_array( strtolower( $this->atts['logged_in'] ), array( '0', 'false', 'no' ) ) ) {
424
+			if ( in_array( strtolower( $this->atts[ 'logged_in' ] ), array( '0', 'false', 'no' ) ) ) {
425 425
 				$this->logged_in = false;
426 426
 			} else {
427 427
 				$this->logged_in = true;
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
 		do_action( 'gravityview/gvlogic/parse_atts/after', $this );
438 438
 
439 439
 		// Make sure the "if" isn't processed in self::setup_operation_and_comparison()
440
-		unset( $this->atts['if'] );
440
+		unset( $this->atts[ 'if' ] );
441 441
 	}
442 442
 }
443 443
 
Please login to merge, or discard this patch.