Inspection of "Refresh admin styles" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1492)

by Zack

created 2021-01-11 16:22 UTC

Indentation +80 added lines, -80 removed lines patch added patch discarded remove patch

@@ -15,93 +15,93 @@
 block discarded – undo
 {
 
 
-    /**
-     * Get a list of CLI values to set before the file is tested.
-     *
-     * @param string                  $testFile The name of the file being tested.
-     * @param \PHP_CodeSniffer\Config $config   The config data for the test run.
-     *
-     * @return void
-     */
-    public function setCliValues($testFile, $config)
-    {
-        $config->tabWidth = 4;
+	/**
+	 * Get a list of CLI values to set before the file is tested.
+	 *
+	 * @param string                  $testFile The name of the file being tested.
+	 * @param \PHP_CodeSniffer\Config $config   The config data for the test run.
+	 *
+	 * @return void
+	 */
+	public function setCliValues($testFile, $config)
+	{
+		$config->tabWidth = 4;
 
-    }//end setCliValues()
+	}//end setCliValues()
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='')
-    {
-        switch ($testFile) {
-        case 'LineLengthUnitTest.1.inc':
-            return [
-                31 => 1,
-                34 => 1,
-                45 => 1,
-                82 => 1,
-            ];
-            break;
-        case 'LineLengthUnitTest.2.inc':
-        case 'LineLengthUnitTest.3.inc':
-            return [7 => 1];
-            break;
-        default:
-            return [];
-            break;
-        }//end switch
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='')
+	{
+		switch ($testFile) {
+		case 'LineLengthUnitTest.1.inc':
+			return [
+				31 => 1,
+				34 => 1,
+				45 => 1,
+				82 => 1,
+			];
+			break;
+		case 'LineLengthUnitTest.2.inc':
+		case 'LineLengthUnitTest.3.inc':
+			return [7 => 1];
+			break;
+		default:
+			return [];
+			break;
+		}//end switch
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList($testFile='')
-    {
-        switch ($testFile) {
-        case 'LineLengthUnitTest.1.inc':
-            return [
-                9  => 1,
-                15 => 1,
-                21 => 1,
-                24 => 1,
-                29 => 1,
-                37 => 1,
-                63 => 1,
-                73 => 1,
-                75 => 1,
-            ];
-            break;
-        case 'LineLengthUnitTest.2.inc':
-        case 'LineLengthUnitTest.3.inc':
-            return [6 => 1];
-            break;
-        case 'LineLengthUnitTest.4.inc':
-            return [10 => 1];
-            break;
-        default:
-            return [];
-            break;
-        }//end switch
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList($testFile='')
+	{
+		switch ($testFile) {
+		case 'LineLengthUnitTest.1.inc':
+			return [
+				9  => 1,
+				15 => 1,
+				21 => 1,
+				24 => 1,
+				29 => 1,
+				37 => 1,
+				63 => 1,
+				73 => 1,
+				75 => 1,
+			];
+			break;
+		case 'LineLengthUnitTest.2.inc':
+		case 'LineLengthUnitTest.3.inc':
+			return [6 => 1];
+			break;
+		case 'LineLengthUnitTest.4.inc':
+			return [10 => 1];
+			break;
+		default:
+			return [];
+			break;
+		}//end switch
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/OneObjectStructurePerFileUnitTest.php 1 patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -15,39 +15,39 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [
-            6  => 1,
-            10 => 1,
-            14 => 1,
-            18 => 1,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [
+			6  => 1,
+			10 => 1,
+			14 => 1,
+			18 => 1,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/Generic/Tests/Files/LineEndingsUnitTest.php 1 patch

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

@@ -15,49 +15,49 @@
 block discarded – undo
 {
 
 
-    /**
-     * Get a list of CLI values to set before the file is tested.
-     *
-     * @param string                  $testFile The name of the file being tested.
-     * @param \PHP_CodeSniffer\Config $config   The config data for the test run.
-     *
-     * @return void
-     */
-    public function setCliValues($testFile, $config)
-    {
-        $config->tabWidth = 4;
-
-    }//end setCliValues()
-
-
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList()
-    {
-        return [1 => 1];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Get a list of CLI values to set before the file is tested.
+	 *
+	 * @param string                  $testFile The name of the file being tested.
+	 * @param \PHP_CodeSniffer\Config $config   The config data for the test run.
+	 *
+	 * @return void
+	 */
+	public function setCliValues($testFile, $config)
+	{
+		$config->tabWidth = 4;
+
+	}//end setCliValues()
+
+
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList()
+	{
+		return [1 => 1];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/EndFileNoNewlineUnitTest.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -15,50 +15,50 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='')
-    {
-        switch ($testFile) {
-        case 'EndFileNoNewlineUnitTest.1.inc':
-        case 'EndFileNoNewlineUnitTest.1.css':
-        case 'EndFileNoNewlineUnitTest.1.js':
-        case 'EndFileNoNewlineUnitTest.2.inc':
-            return [3 => 1];
-        case 'EndFileNoNewlineUnitTest.2.css':
-        case 'EndFileNoNewlineUnitTest.2.js':
-        case 'EndFileNoNewlineUnitTest.6.inc':
-            return [2 => 1];
-        default:
-            return [];
-        }//end switch
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='')
+	{
+		switch ($testFile) {
+		case 'EndFileNoNewlineUnitTest.1.inc':
+		case 'EndFileNoNewlineUnitTest.1.css':
+		case 'EndFileNoNewlineUnitTest.1.js':
+		case 'EndFileNoNewlineUnitTest.2.inc':
+			return [3 => 1];
+		case 'EndFileNoNewlineUnitTest.2.css':
+		case 'EndFileNoNewlineUnitTest.2.js':
+		case 'EndFileNoNewlineUnitTest.6.inc':
+			return [2 => 1];
+		default:
+			return [];
+		}//end switch
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList($testFile='')
-    {
-        return [];
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList($testFile='')
+	{
+		return [];
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/OneTraitPerFileUnitTest.php 1 patch

Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -15,37 +15,37 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @return array(int => int)
-     */
-    public function getErrorList()
-    {
-        return [
-            6  => 1,
-            10 => 1,
-        ];
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array(int => int)
-     */
-    public function getWarningList()
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @return array(int => int)
+	 */
+	public function getErrorList()
+	{
+		return [
+			6  => 1,
+			10 => 1,
+		];
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array(int => int)
+	 */
+	public function getWarningList()
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/EndFileNewlineUnitTest.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -15,46 +15,46 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='')
-    {
-        switch ($testFile) {
-        case 'EndFileNewlineUnitTest.3.inc':
-        case 'EndFileNewlineUnitTest.3.js':
-        case 'EndFileNewlineUnitTest.3.css':
-        case 'EndFileNewlineUnitTest.4.inc':
-            return [2 => 1];
-        default:
-            return [];
-        }//end switch
-
-    }//end getErrorList()
-
-
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList($testFile='')
-    {
-        return [];
-
-    }//end getWarningList()
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='')
+	{
+		switch ($testFile) {
+		case 'EndFileNewlineUnitTest.3.inc':
+		case 'EndFileNewlineUnitTest.3.js':
+		case 'EndFileNewlineUnitTest.3.css':
+		case 'EndFileNewlineUnitTest.4.inc':
+			return [2 => 1];
+		default:
+			return [];
+		}//end switch
+
+	}//end getErrorList()
+
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList($testFile='')
+	{
+		return [];
+
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/Generic/Tests/Files/LineLengthUnitTest.1.inc 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -2,18 +2,18 @@  discard block
 block discarded – undo
 
 // This line is okay... just!
 if (($reallyLongVarName === true) || (is_array($anotherLongVarName) == false)) {
-    // Do something.
+	// Do something.
 }
 
 // This line is not okay... just!
 if (($reallyLongVarName === true) || (is_array($anotherLongVarName) === false)) {
-    // Do something.
+	// Do something.
 }
 
 
 // This line is is too long.
 if (($anotherReallyLongVarName === true) || (is_array($anotherReallyLongVarName) === false)) {
-    // Do something.
+	// Do something.
 }
 
 // This is a really really long comment that is going to go to exactly 80 chars.
@@ -57,14 +57,14 @@  discard block
 block discarded – undo
 # http://en.wikipedia.org/wiki/Binomial_proportion_confidence_interval#Wilson_score_interval
 
 if ($foo) {
-    if ($bar) {
-        if ($baz) {
-            // Next line can be broken:
-            // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblah
-            // But this one is just too long to break with this indent:
-            // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblahblah
-        }
-    }
+	if ($bar) {
+		if ($baz) {
+			// Next line can be broken:
+			// foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblah
+			// But this one is just too long to break with this indent:
+			// foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblahblah
+		}
+	}
 }
 
 /* -------------------------------- 80 chars -------------------------------- */

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Strings/UnnecessaryStringConcatUnitTest.inc 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -16,6 +16,6 @@
 block discarded – undo
 $code = '<'.'?php ';
 
 $string = 'This is a really long string. '
-        . 'It is being used for errors. '
-        . 'The message is not translated.';
+		. 'It is being used for errors. '
+		. 'The message is not translated.';
 ?>

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Strings/UnnecessaryStringConcatUnitTest.php 1 patch

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

@@ -15,59 +15,59 @@
 block discarded – undo
 {
 
 
-    /**
-     * Returns the lines where errors should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of errors that should occur on that line.
-     *
-     * @param string $testFile The name of the file being tested.
-     *
-     * @return array<int, int>
-     */
-    public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
-    {
-        switch ($testFile) {
-        case 'UnnecessaryStringConcatUnitTest.inc':
-            return [
-                2  => 1,
-                6  => 1,
-                9  => 1,
-                12 => 1,
-                19 => 1,
-                20 => 1,
-            ];
-            break;
-        case 'UnnecessaryStringConcatUnitTest.js':
-            return [
-                1  => 1,
-                8  => 1,
-                11 => 1,
-                14 => 1,
-                15 => 1,
-            ];
-            break;
-        default:
-            return [];
-            break;
-        }//end switch
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of errors that should occur on that line.
+	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
+	{
+		switch ($testFile) {
+		case 'UnnecessaryStringConcatUnitTest.inc':
+			return [
+				2  => 1,
+				6  => 1,
+				9  => 1,
+				12 => 1,
+				19 => 1,
+				20 => 1,
+			];
+			break;
+		case 'UnnecessaryStringConcatUnitTest.js':
+			return [
+				1  => 1,
+				8  => 1,
+				11 => 1,
+				14 => 1,
+				15 => 1,
+			];
+			break;
+		default:
+			return [];
+			break;
+		}//end switch
 
-    }//end getErrorList()
+	}//end getErrorList()
 
 
-    /**
-     * Returns the lines where warnings should occur.
-     *
-     * The key of the array should represent the line number and the value
-     * should represent the number of warnings that should occur on that line.
-     *
-     * @return array<int, int>
-     */
-    public function getWarningList()
-    {
-        return [];
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * The key of the array should represent the line number and the value
+	 * should represent the number of warnings that should occur on that line.
+	 *
+	 * @return array<int, int>
+	 */
+	public function getWarningList()
+	{
+		return [];
 
-    }//end getWarningList()
+	}//end getWarningList()
 
 
 }//end class

Please login to merge, or discard this patch.

		@@ -15,93 +15,93 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Get a list of CLI values to set before the file is tested.
20		- *
21		- * @param string $testFile The name of the file being tested.
22		- * @param \PHP_CodeSniffer\Config $config The config data for the test run.
23		- *
24		- * @return void
25		- */
26		- public function setCliValues($testFile, $config)
27		- {
28		- $config->tabWidth = 4;
	18	+ /**
	19	+ * Get a list of CLI values to set before the file is tested.
	20	+ *
	21	+ * @param string $testFile The name of the file being tested.
	22	+ * @param \PHP_CodeSniffer\Config $config The config data for the test run.
	23	+ *
	24	+ * @return void
	25	+ */
	26	+ public function setCliValues($testFile, $config)
	27	+ {
	28	+ $config->tabWidth = 4;
29	29
30		- }//end setCliValues()
	30	+ }//end setCliValues()
31	31
32	32
33		- /**
34		- * Returns the lines where errors should occur.
35		- *
36		- * The key of the array should represent the line number and the value
37		- * should represent the number of errors that should occur on that line.
38		- *
39		- * @param string $testFile The name of the file being tested.
40		- *
41		- * @return array<int, int>
42		- */
43		- public function getErrorList($testFile='')
44		- {
45		- switch ($testFile) {
46		- case 'LineLengthUnitTest.1.inc':
47		- return [
48		- 31 => 1,
49		- 34 => 1,
50		- 45 => 1,
51		- 82 => 1,
52		- ];
53		- break;
54		- case 'LineLengthUnitTest.2.inc':
55		- case 'LineLengthUnitTest.3.inc':
56		- return [7 => 1];
57		- break;
58		- default:
59		- return [];
60		- break;
61		- }//end switch
	33	+ /**
	34	+ * Returns the lines where errors should occur.
	35	+ *
	36	+ * The key of the array should represent the line number and the value
	37	+ * should represent the number of errors that should occur on that line.
	38	+ *
	39	+ * @param string $testFile The name of the file being tested.
	40	+ *
	41	+ * @return array<int, int>
	42	+ */
	43	+ public function getErrorList($testFile='')
	44	+ {
	45	+ switch ($testFile) {
	46	+ case 'LineLengthUnitTest.1.inc':
	47	+ return [
	48	+ 31 => 1,
	49	+ 34 => 1,
	50	+ 45 => 1,
	51	+ 82 => 1,
	52	+ ];
	53	+ break;
	54	+ case 'LineLengthUnitTest.2.inc':
	55	+ case 'LineLengthUnitTest.3.inc':
	56	+ return [7 => 1];
	57	+ break;
	58	+ default:
	59	+ return [];
	60	+ break;
	61	+ }//end switch
62	62
63		- }//end getErrorList()
	63	+ }//end getErrorList()
64	64
65	65
66		- /**
67		- * Returns the lines where warnings should occur.
68		- *
69		- * The key of the array should represent the line number and the value
70		- * should represent the number of warnings that should occur on that line.
71		- *
72		- * @param string $testFile The name of the file being tested.
73		- *
74		- * @return array<int, int>
75		- */
76		- public function getWarningList($testFile='')
77		- {
78		- switch ($testFile) {
79		- case 'LineLengthUnitTest.1.inc':
80		- return [
81		- 9 => 1,
82		- 15 => 1,
83		- 21 => 1,
84		- 24 => 1,
85		- 29 => 1,
86		- 37 => 1,
87		- 63 => 1,
88		- 73 => 1,
89		- 75 => 1,
90		- ];
91		- break;
92		- case 'LineLengthUnitTest.2.inc':
93		- case 'LineLengthUnitTest.3.inc':
94		- return [6 => 1];
95		- break;
96		- case 'LineLengthUnitTest.4.inc':
97		- return [10 => 1];
98		- break;
99		- default:
100		- return [];
101		- break;
102		- }//end switch
	66	+ /**
	67	+ * Returns the lines where warnings should occur.
	68	+ *
	69	+ * The key of the array should represent the line number and the value
	70	+ * should represent the number of warnings that should occur on that line.
	71	+ *
	72	+ * @param string $testFile The name of the file being tested.
	73	+ *
	74	+ * @return array<int, int>
	75	+ */
	76	+ public function getWarningList($testFile='')
	77	+ {
	78	+ switch ($testFile) {
	79	+ case 'LineLengthUnitTest.1.inc':
	80	+ return [
	81	+ 9 => 1,
	82	+ 15 => 1,
	83	+ 21 => 1,
	84	+ 24 => 1,
	85	+ 29 => 1,
	86	+ 37 => 1,
	87	+ 63 => 1,
	88	+ 73 => 1,
	89	+ 75 => 1,
	90	+ ];
	91	+ break;
	92	+ case 'LineLengthUnitTest.2.inc':
	93	+ case 'LineLengthUnitTest.3.inc':
	94	+ return [6 => 1];
	95	+ break;
	96	+ case 'LineLengthUnitTest.4.inc':
	97	+ return [10 => 1];
	98	+ break;
	99	+ default:
	100	+ return [];
	101	+ break;
	102	+ }//end switch
103	103
104		- }//end getWarningList()
	104	+ }//end getWarningList()
105	105
106	106
107	107	}//end class

		@@ -15,39 +15,39 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array<int, int>
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 6 => 1,
30		- 10 => 1,
31		- 14 => 1,
32		- 18 => 1,
33		- ];
34		-
35		- }//end getErrorList()
36		-
37		-
38		- /**
39		- * Returns the lines where warnings should occur.
40		- *
41		- * The key of the array should represent the line number and the value
42		- * should represent the number of warnings that should occur on that line.
43		- *
44		- * @return array<int, int>
45		- */
46		- public function getWarningList()
47		- {
48		- return [];
49		-
50		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array<int, int>
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 6 => 1,
	30	+ 10 => 1,
	31	+ 14 => 1,
	32	+ 18 => 1,
	33	+ ];
	34	+
	35	+ }//end getErrorList()
	36	+
	37	+
	38	+ /**
	39	+ * Returns the lines where warnings should occur.
	40	+ *
	41	+ * The key of the array should represent the line number and the value
	42	+ * should represent the number of warnings that should occur on that line.
	43	+ *
	44	+ * @return array<int, int>
	45	+ */
	46	+ public function getWarningList()
	47	+ {
	48	+ return [];
	49	+
	50	+ }//end getWarningList()
51	51
52	52
53	53	}//end class

		@@ -15,49 +15,49 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Get a list of CLI values to set before the file is tested.
20		- *
21		- * @param string $testFile The name of the file being tested.
22		- * @param \PHP_CodeSniffer\Config $config The config data for the test run.
23		- *
24		- * @return void
25		- */
26		- public function setCliValues($testFile, $config)
27		- {
28		- $config->tabWidth = 4;
29		-
30		- }//end setCliValues()
31		-
32		-
33		- /**
34		- * Returns the lines where errors should occur.
35		- *
36		- * The key of the array should represent the line number and the value
37		- * should represent the number of errors that should occur on that line.
38		- *
39		- * @return array<int, int>
40		- */
41		- public function getErrorList()
42		- {
43		- return [1 => 1];
44		-
45		- }//end getErrorList()
46		-
47		-
48		- /**
49		- * Returns the lines where warnings should occur.
50		- *
51		- * The key of the array should represent the line number and the value
52		- * should represent the number of warnings that should occur on that line.
53		- *
54		- * @return array<int, int>
55		- */
56		- public function getWarningList()
57		- {
58		- return [];
59		-
60		- }//end getWarningList()
	18	+ /**
	19	+ * Get a list of CLI values to set before the file is tested.
	20	+ *
	21	+ * @param string $testFile The name of the file being tested.
	22	+ * @param \PHP_CodeSniffer\Config $config The config data for the test run.
	23	+ *
	24	+ * @return void
	25	+ */
	26	+ public function setCliValues($testFile, $config)
	27	+ {
	28	+ $config->tabWidth = 4;
	29	+
	30	+ }//end setCliValues()
	31	+
	32	+
	33	+ /**
	34	+ * Returns the lines where errors should occur.
	35	+ *
	36	+ * The key of the array should represent the line number and the value
	37	+ * should represent the number of errors that should occur on that line.
	38	+ *
	39	+ * @return array<int, int>
	40	+ */
	41	+ public function getErrorList()
	42	+ {
	43	+ return [1 => 1];
	44	+
	45	+ }//end getErrorList()
	46	+
	47	+
	48	+ /**
	49	+ * Returns the lines where warnings should occur.
	50	+ *
	51	+ * The key of the array should represent the line number and the value
	52	+ * should represent the number of warnings that should occur on that line.
	53	+ *
	54	+ * @return array<int, int>
	55	+ */
	56	+ public function getWarningList()
	57	+ {
	58	+ return [];
	59	+
	60	+ }//end getWarningList()
61	61
62	62
63	63	}//end class

		@@ -15,50 +15,50 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @param string $testFile The name of the file being tested.
25		- *
26		- * @return array<int, int>
27		- */
28		- public function getErrorList($testFile='')
29		- {
30		- switch ($testFile) {
31		- case 'EndFileNoNewlineUnitTest.1.inc':
32		- case 'EndFileNoNewlineUnitTest.1.css':
33		- case 'EndFileNoNewlineUnitTest.1.js':
34		- case 'EndFileNoNewlineUnitTest.2.inc':
35		- return [3 => 1];
36		- case 'EndFileNoNewlineUnitTest.2.css':
37		- case 'EndFileNoNewlineUnitTest.2.js':
38		- case 'EndFileNoNewlineUnitTest.6.inc':
39		- return [2 => 1];
40		- default:
41		- return [];
42		- }//end switch
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @param string $testFile The name of the file being tested.
	25	+ *
	26	+ * @return array<int, int>
	27	+ */
	28	+ public function getErrorList($testFile='')
	29	+ {
	30	+ switch ($testFile) {
	31	+ case 'EndFileNoNewlineUnitTest.1.inc':
	32	+ case 'EndFileNoNewlineUnitTest.1.css':
	33	+ case 'EndFileNoNewlineUnitTest.1.js':
	34	+ case 'EndFileNoNewlineUnitTest.2.inc':
	35	+ return [3 => 1];
	36	+ case 'EndFileNoNewlineUnitTest.2.css':
	37	+ case 'EndFileNoNewlineUnitTest.2.js':
	38	+ case 'EndFileNoNewlineUnitTest.6.inc':
	39	+ return [2 => 1];
	40	+ default:
	41	+ return [];
	42	+ }//end switch
43	43
44		- }//end getErrorList()
	44	+ }//end getErrorList()
45	45
46	46
47		- /**
48		- * Returns the lines where warnings should occur.
49		- *
50		- * The key of the array should represent the line number and the value
51		- * should represent the number of warnings that should occur on that line.
52		- *
53		- * @param string $testFile The name of the file being tested.
54		- *
55		- * @return array<int, int>
56		- */
57		- public function getWarningList($testFile='')
58		- {
59		- return [];
	47	+ /**
	48	+ * Returns the lines where warnings should occur.
	49	+ *
	50	+ * The key of the array should represent the line number and the value
	51	+ * should represent the number of warnings that should occur on that line.
	52	+ *
	53	+ * @param string $testFile The name of the file being tested.
	54	+ *
	55	+ * @return array<int, int>
	56	+ */
	57	+ public function getWarningList($testFile='')
	58	+ {
	59	+ return [];
60	60
61		- }//end getWarningList()
	61	+ }//end getWarningList()
62	62
63	63
64	64	}//end class

		@@ -15,37 +15,37 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @return array(int => int)
25		- */
26		- public function getErrorList()
27		- {
28		- return [
29		- 6 => 1,
30		- 10 => 1,
31		- ];
32		-
33		- }//end getErrorList()
34		-
35		-
36		- /**
37		- * Returns the lines where warnings should occur.
38		- *
39		- * The key of the array should represent the line number and the value
40		- * should represent the number of warnings that should occur on that line.
41		- *
42		- * @return array(int => int)
43		- */
44		- public function getWarningList()
45		- {
46		- return [];
47		-
48		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @return array(int => int)
	25	+ */
	26	+ public function getErrorList()
	27	+ {
	28	+ return [
	29	+ 6 => 1,
	30	+ 10 => 1,
	31	+ ];
	32	+
	33	+ }//end getErrorList()
	34	+
	35	+
	36	+ /**
	37	+ * Returns the lines where warnings should occur.
	38	+ *
	39	+ * The key of the array should represent the line number and the value
	40	+ * should represent the number of warnings that should occur on that line.
	41	+ *
	42	+ * @return array(int => int)
	43	+ */
	44	+ public function getWarningList()
	45	+ {
	46	+ return [];
	47	+
	48	+ }//end getWarningList()
49	49
50	50
51	51	}//end class

		@@ -15,46 +15,46 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @param string $testFile The name of the file being tested.
25		- *
26		- * @return array<int, int>
27		- */
28		- public function getErrorList($testFile='')
29		- {
30		- switch ($testFile) {
31		- case 'EndFileNewlineUnitTest.3.inc':
32		- case 'EndFileNewlineUnitTest.3.js':
33		- case 'EndFileNewlineUnitTest.3.css':
34		- case 'EndFileNewlineUnitTest.4.inc':
35		- return [2 => 1];
36		- default:
37		- return [];
38		- }//end switch
39		-
40		- }//end getErrorList()
41		-
42		-
43		- /**
44		- * Returns the lines where warnings should occur.
45		- *
46		- * The key of the array should represent the line number and the value
47		- * should represent the number of warnings that should occur on that line.
48		- *
49		- * @param string $testFile The name of the file being tested.
50		- *
51		- * @return array<int, int>
52		- */
53		- public function getWarningList($testFile='')
54		- {
55		- return [];
56		-
57		- }//end getWarningList()
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @param string $testFile The name of the file being tested.
	25	+ *
	26	+ * @return array<int, int>
	27	+ */
	28	+ public function getErrorList($testFile='')
	29	+ {
	30	+ switch ($testFile) {
	31	+ case 'EndFileNewlineUnitTest.3.inc':
	32	+ case 'EndFileNewlineUnitTest.3.js':
	33	+ case 'EndFileNewlineUnitTest.3.css':
	34	+ case 'EndFileNewlineUnitTest.4.inc':
	35	+ return [2 => 1];
	36	+ default:
	37	+ return [];
	38	+ }//end switch
	39	+
	40	+ }//end getErrorList()
	41	+
	42	+
	43	+ /**
	44	+ * Returns the lines where warnings should occur.
	45	+ *
	46	+ * The key of the array should represent the line number and the value
	47	+ * should represent the number of warnings that should occur on that line.
	48	+ *
	49	+ * @param string $testFile The name of the file being tested.
	50	+ *
	51	+ * @return array<int, int>
	52	+ */
	53	+ public function getWarningList($testFile='')
	54	+ {
	55	+ return [];
	56	+
	57	+ }//end getWarningList()
58	58
59	59
60	60	}//end class

		@@ -2,18 +2,18 @@ discard block
		block discarded – undo
2	2
3	3	// This line is okay... just!
4	4	if (($reallyLongVarName === true) \|\| (is_array($anotherLongVarName) == false)) {
5		- // Do something.
	5	+ // Do something.
6	6	}
7	7
8	8	// This line is not okay... just!
9	9	if (($reallyLongVarName === true) \|\| (is_array($anotherLongVarName) === false)) {
10		- // Do something.
	10	+ // Do something.
11	11	}
12	12
13	13
14	14	// This line is is too long.
15	15	if (($anotherReallyLongVarName === true) \|\| (is_array($anotherReallyLongVarName) === false)) {
16		- // Do something.
	16	+ // Do something.
17	17	}
18	18
19	19	// This is a really really long comment that is going to go to exactly 80 chars.
		@@ -57,14 +57,14 @@ discard block
		block discarded – undo
57	57	# http://en.wikipedia.org/wiki/Binomial_proportion_confidence_interval#Wilson_score_interval
58	58
59	59	if ($foo) {
60		- if ($bar) {
61		- if ($baz) {
62		- // Next line can be broken:
63		- // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblah
64		- // But this one is just too long to break with this indent:
65		- // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblahblah
66		- }
67		- }
	60	+ if ($bar) {
	61	+ if ($baz) {
	62	+ // Next line can be broken:
	63	+ // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblah
	64	+ // But this one is just too long to break with this indent:
	65	+ // foo bar baz http://en.wikipedia.org/wiki/Binomial_proportion#blahblahblahblahblah
	66	+ }
	67	+ }
68	68	}
69	69
70	70	/* -------------------------------- 80 chars -------------------------------- */

		@@ -16,6 +16,6 @@
		block discarded – undo
16	16	$code = '<'.'?php ';
17	17
18	18	$string = 'This is a really long string. '
19		- . 'It is being used for errors. '
20		- . 'The message is not translated.';
	19	+ . 'It is being used for errors. '
	20	+ . 'The message is not translated.';
21	21	?>

		@@ -15,59 +15,59 @@
		block discarded – undo
15	15	{
16	16
17	17
18		- /**
19		- * Returns the lines where errors should occur.
20		- *
21		- * The key of the array should represent the line number and the value
22		- * should represent the number of errors that should occur on that line.
23		- *
24		- * @param string $testFile The name of the file being tested.
25		- *
26		- * @return array<int, int>
27		- */
28		- public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
29		- {
30		- switch ($testFile) {
31		- case 'UnnecessaryStringConcatUnitTest.inc':
32		- return [
33		- 2 => 1,
34		- 6 => 1,
35		- 9 => 1,
36		- 12 => 1,
37		- 19 => 1,
38		- 20 => 1,
39		- ];
40		- break;
41		- case 'UnnecessaryStringConcatUnitTest.js':
42		- return [
43		- 1 => 1,
44		- 8 => 1,
45		- 11 => 1,
46		- 14 => 1,
47		- 15 => 1,
48		- ];
49		- break;
50		- default:
51		- return [];
52		- break;
53		- }//end switch
	18	+ /**
	19	+ * Returns the lines where errors should occur.
	20	+ *
	21	+ * The key of the array should represent the line number and the value
	22	+ * should represent the number of errors that should occur on that line.
	23	+ *
	24	+ * @param string $testFile The name of the file being tested.
	25	+ *
	26	+ * @return array<int, int>
	27	+ */
	28	+ public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
	29	+ {
	30	+ switch ($testFile) {
	31	+ case 'UnnecessaryStringConcatUnitTest.inc':
	32	+ return [
	33	+ 2 => 1,
	34	+ 6 => 1,
	35	+ 9 => 1,
	36	+ 12 => 1,
	37	+ 19 => 1,
	38	+ 20 => 1,
	39	+ ];
	40	+ break;
	41	+ case 'UnnecessaryStringConcatUnitTest.js':
	42	+ return [
	43	+ 1 => 1,
	44	+ 8 => 1,
	45	+ 11 => 1,
	46	+ 14 => 1,
	47	+ 15 => 1,
	48	+ ];
	49	+ break;
	50	+ default:
	51	+ return [];
	52	+ break;
	53	+ }//end switch
54	54
55		- }//end getErrorList()
	55	+ }//end getErrorList()
56	56
57	57
58		- /**
59		- * Returns the lines where warnings should occur.
60		- *
61		- * The key of the array should represent the line number and the value
62		- * should represent the number of warnings that should occur on that line.
63		- *
64		- * @return array<int, int>
65		- */
66		- public function getWarningList()
67		- {
68		- return [];
	58	+ /**
	59	+ * Returns the lines where warnings should occur.
	60	+ *
	61	+ * The key of the array should represent the line number and the value
	62	+ * should represent the number of warnings that should occur on that line.
	63	+ *
	64	+ * @return array<int, int>
	65	+ */
	66	+ public function getWarningList()
	67	+ {
	68	+ return [];
69	69
70		- }//end getWarningList()
	70	+ }//end getWarningList()
71	71
72	72
73	73	}//end class

gravityview / GravityView

Pull Request — develop (#1492)

Category

Indentation +80 added lines, -80 removed lines patch added patch discarded remove patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch