gravityview /
GravityView
| Conditions | 12 |
| Paths | 193 |
| Total Lines | 87 |
| Code Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 63 | public function update_user( $form = array(), $entry_id = 0 ) { |
||
| 64 | |||
| 65 | if( !class_exists( 'GFAPI' ) || !class_exists( 'GFUser' ) || empty( $entry_id ) ) { |
||
| 66 | return; |
||
| 67 | } |
||
| 68 | |||
| 69 | // support for GF User Registration 3.x |
||
| 70 | $gf_user_3 = class_exists('GF_User_Registration') ? true : false; |
||
| 71 | |||
| 72 | if( $gf_user_3 ) { |
||
| 73 | $gf_user_registration = GF_User_Registration::get_instance(); |
||
| 74 | } |
||
| 75 | |||
| 76 | $entry = GFAPI::get_entry( $entry_id ); |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @filter `gravityview/edit_entry/user_registration/entry` Modify entry details before updating the user via User Registration add-on |
||
| 80 | * @since 1.11 |
||
| 81 | * @param array $entry Gravity Forms entry |
||
| 82 | * @param array $form Gravity Forms form |
||
| 83 | */ |
||
| 84 | $entry = apply_filters( 'gravityview/edit_entry/user_registration/entry', $entry, $form ); |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @since 1.14 |
||
| 88 | */ |
||
| 89 | if( $gf_user_3 ) { |
||
| 90 | $config = $gf_user_registration->get_single_submission_feed( $entry, $form ); |
||
| 91 | } else { |
||
| 92 | $config = GFUser::get_active_config( $form, $entry ); |
||
| 93 | } |
||
| 94 | |||
| 95 | /** |
||
| 96 | * @filter `gravityview/edit_entry/user_registration/preserve_role` Keep the current user role or override with the role defined in the Create feed |
||
| 97 | * @since 1.15 |
||
| 98 | * @param[in,out] boolean $preserve_role Preserve current user role Default: true |
||
| 99 | * @param[in] array $config Gravity Forms User Registration feed configuration for the form |
||
| 100 | * @param[in] array $form Gravity Forms form array |
||
| 101 | * @param[in] array $entry Gravity Forms entry being edited |
||
| 102 | */ |
||
| 103 | $preserve_role = apply_filters( 'gravityview/edit_entry/user_registration/preserve_role', true, $config, $form, $entry ); |
||
| 104 | |||
| 105 | if( $preserve_role ) { |
||
| 106 | $config['meta']['role'] = 'gfur_preserve_role'; |
||
| 107 | } |
||
| 108 | |||
| 109 | /** |
||
| 110 | * Make sure the current display name is not changed with the update user method. |
||
| 111 | * @since 1.15 |
||
| 112 | */ |
||
| 113 | $config['meta']['displayname'] = $this->match_current_display_name( $entry['created_by'] ); |
||
| 114 | |||
| 115 | |||
| 116 | /** |
||
| 117 | * @filter `gravityview/edit_entry/user_registration/config` Modify the User Registration Addon feed configuration |
||
| 118 | * @since 1.14 |
||
| 119 | * @param[in,out] array $config Gravity Forms User Registration feed configuration for the form |
||
| 120 | * @param[in] array $form Gravity Forms form array |
||
| 121 | * @param[in] array $entry Gravity Forms entry being edited |
||
| 122 | */ |
||
| 123 | $config = apply_filters( 'gravityview/edit_entry/user_registration/config', $config, $form, $entry ); |
||
| 124 | |||
| 125 | |||
| 126 | $feed_pos = $gf_user_3 ? 'meta/feedType' : 'meta/feed_type'; |
||
| 127 | $is_create_feed = ( $config && rgars( $config, $feed_pos ) === 'create' ); |
||
| 128 | |||
| 129 | // Only update if it's a create feed |
||
| 130 | if( ! $is_create_feed ) { |
||
| 131 | return; |
||
| 132 | } |
||
| 133 | |||
| 134 | // The priority is set to 3 so that default priority (10) will still override it |
||
| 135 | add_filter( 'send_password_change_email', '__return_false', 3 ); |
||
| 136 | add_filter( 'send_email_change_email', '__return_false', 3 ); |
||
| 137 | |||
| 138 | // Trigger the User Registration update user method |
||
| 139 | if( $gf_user_3 ) { |
||
| 140 | $gf_user_registration->update_user( $entry, $form, $config ); |
||
| 141 | } else { |
||
| 142 | GFUser::update_user( $entry, $form, $config ); |
||
| 143 | } |
||
| 144 | |||
| 145 | |||
| 146 | remove_filter( 'send_password_change_email', '__return_false', 3 ); |
||
| 147 | remove_filter( 'send_email_change_email', '__return_false', 3 ); |
||
| 148 | |||
| 149 | } |
||
| 150 | |||
| 277 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.