gravityview / GravityView

includes/class-gvlogic-shortcode.php

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
 	 * Does the if and the comparison match?
 	 * @uses GVCommon::matches_operation
 	 *
-	 * @return boolean True: yep; false: nope
+	 * @return boolean|null True: yep; false: nope
 	 */
 	private function set_is_match() {
 		$this->is_match = GVCommon::matches_operation( $this->if, $this->comparison, $this->operation );

Spacing +22 added lines, -22 removed lines

@@ -85,7 +85,7 @@ 
 	 */
 	public static function get_instance() {
 
-		if( empty( self::$instance ) ) {
+		if ( empty( self::$instance ) ) {
 			self::$instance = new self;
 		}
 
@@ -118,9 +118,9 @@ 
 
 		$operators = array_merge( self::$SUPPORTED_ARRAY_OPERATORS, self::$SUPPORTED_NUMERIC_OPERATORS, self::$SUPPORTED_SCALAR_OPERATORS, self::$SUPPORTED_CUSTOM_OPERATORS );
 
-		if( $with_values ) {
+		if ( $with_values ) {
 			$operators_with_values = array();
-			foreach( $operators as $key ) {
+			foreach ( $operators as $key ) {
 				$operators_with_values[ $key ] = '';
 			}
 			return $operators_with_values;
@@ -137,14 +137,14 @@ 
 	 */
 	function set_operation( $operation = '' ) {
 
-		if( empty( $operation ) ) {
+		if ( empty( $operation ) ) {
 			return false;
 		}
 
 		$operators = $this->get_operators( false );
 
-		if( !in_array( $operation, $operators ) ) {
-			do_action( 'gravityview_log_debug', __METHOD__ .' Attempted to add invalid operation type.', $operation );
+		if ( ! in_array( $operation, $operators ) ) {
+			do_action( 'gravityview_log_debug', __METHOD__ . ' Attempted to add invalid operation type.', $operation );
 			return false;
 		}
 
@@ -164,11 +164,11 @@ 
 	 */
 	private function setup_operation_and_comparison() {
 
-		foreach( $this->atts as $key => $value ) {
+		foreach ( $this->atts as $key => $value ) {
 
 			$valid = $this->set_operation( $key );
 
-			if( $valid ) {
+			if ( $valid ) {
 				$this->comparison = $value;
 				return true;
 			}
@@ -194,8 +194,8 @@ 
 			return null;
 		}
 
-		if( empty( $atts ) ) {
-			do_action( 'gravityview_log_error', __METHOD__.' $atts are empty.', $atts );
+		if ( empty( $atts ) ) {
+			do_action( 'gravityview_log_error', __METHOD__ . ' $atts are empty.', $atts );
 			return null;
 		}
 
@@ -206,16 +206,16 @@ 
 		$this->parse_atts();
 
 		// We need an "if"
-		if( false === $this->if ) {
-			do_action( 'gravityview_log_error', __METHOD__.' $atts->if is empty.', $this->passed_atts );
+		if ( false === $this->if ) {
+			do_action( 'gravityview_log_error', __METHOD__ . ' $atts->if is empty.', $this->passed_atts );
 			return null;
 		}
 
 		$setup = $this->setup_operation_and_comparison();
 
 		// We need an operation and comparison value
-		if( ! $setup ) {
-			do_action( 'gravityview_log_error', __METHOD__.' No valid operators were passed.', $this->atts );
+		if ( ! $setup ) {
+			do_action( 'gravityview_log_error', __METHOD__ . ' No valid operators were passed.', $this->atts );
 			return null;
 		}
 
@@ -248,7 +248,7 @@ 
 	 */
 	private function get_output() {
 
-		if( $this->is_match ) {
+		if ( $this->is_match ) {
 			$output = $this->content;
 		} else {
 			$output = $this->else_content;
@@ -262,9 +262,9 @@ 
 		 * @param string $output HTML/text output
 		 * @param GVLogic_Shortcode $this This class
 		 */
-		$output = apply_filters('gravityview/gvlogic/output', $output, $this );
+		$output = apply_filters( 'gravityview/gvlogic/output', $output, $this );
 
-		do_action( 'gravityview_log_debug', __METHOD__ .' Output: ', $output );
+		do_action( 'gravityview_log_debug', __METHOD__ . ' Output: ', $output );
 
 		return $output;
 	}
@@ -280,11 +280,11 @@ 
 
 		$content = explode( '[else]', $this->passed_content );
 
-		$this->content = $content[0];
+		$this->content = $content[ 0 ];
 
-		$else_attr = isset( $this->atts['else'] ) ? $this->atts['else'] : NULL;
+		$else_attr = isset( $this->atts[ 'else' ] ) ? $this->atts[ 'else' ] : NULL;
 
-		$this->else_content = isset( $content[1] ) ? $content[1] : $else_attr;
+		$this->else_content = isset( $content[ 1 ] ) ? $content[ 1 ] : $else_attr;
 	}
 
 	/**
@@ -307,7 +307,7 @@ 
 		$this->atts = function_exists( 'array_intersect_key' ) ? array_intersect_key( $this->passed_atts, $this->atts ) : $this->atts;
 
 		// Strip whitespace if it's not default false
-		$this->if = ( isset( $this->atts['if'] ) && is_string( $this->atts['if'] ) ) ? trim( $this->atts['if'] ) : false;
+		$this->if = ( isset( $this->atts[ 'if' ] ) && is_string( $this->atts[ 'if' ] ) ) ? trim( $this->atts[ 'if' ] ) : false;
 
 		/**
 		 * @action `gravityview/gvlogic/parse_atts/after` Modify shortcode attributes after it's been parsed
@@ -318,7 +318,7 @@ 
 		do_action( 'gravityview/gvlogic/parse_atts/after', $this );
 
 		// Make sure the "if" isn't processed in self::setup_operation_and_comparison()
-		unset( $this->atts['if'] );
+		unset( $this->atts[ 'if' ] );
 	}
 }
 

includes/fields/class-gravityview-field.php

Doc Comments +1 added lines, -1 removed lines

@@ -245,7 +245,7 @@
 	 * @param bool $url_encode Whether to URL-encode output
 	 * @param bool $esc_html Whether to apply `esc_html()` to output
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	public function replace_merge_tag( $matches = array(), $text = '', $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
 

Spacing +22 added lines, -22 removed lines

@@ -134,17 +134,17 @@ 
 
 		add_filter( 'gravityview/sortable/field_blacklist', array( $this, '_filter_sortable_fields' ), 1 );
 
-		if( $this->entry_meta_key ) {
+		if ( $this->entry_meta_key ) {
 			add_filter( 'gform_entry_meta', array( $this, 'add_entry_meta' ) );
 			add_filter( 'gravityview/common/sortable_fields', array( $this, 'add_sortable_field' ), 10, 2 );
 		}
 
-		if( $this->_custom_merge_tag ) {
+		if ( $this->_custom_merge_tag ) {
 			add_filter( 'gform_custom_merge_tags', array( $this, '_filter_gform_custom_merge_tags' ), 10, 4 );
 			add_filter( 'gform_replace_merge_tags', array( $this, '_filter_gform_replace_merge_tags' ), 10, 7 );
 		}
 
-		if( 'meta' === $this->group || '' !== $this->default_search_label ) {
+		if ( 'meta' === $this->group || '' !== $this->default_search_label ) {
 			add_filter( 'gravityview_search_field_label', array( $this, 'set_default_search_label' ), 10, 3 );
 		}
 
@@ -152,7 +152,7 @@ 
 		 * Auto-assign label from Gravity Forms label, if exists
 		 * @since 1.20
 		 */
-		if( empty( $this->label ) && ! empty( $this->_gf_field_class_name ) && class_exists( $this->_gf_field_class_name ) ) {
+		if ( empty( $this->label ) && ! empty( $this->_gf_field_class_name ) && class_exists( $this->_gf_field_class_name ) ) {
 			$this->label = ucfirst( GF_Fields::get( $this->name )->get_form_editor_field_title() );
 		}
 
@@ -175,7 +175,7 @@ 
 			'type'  => $this->name
 		);
 
-		$fields["{$this->entry_meta_key}"] = $added_field;
+		$fields[ "{$this->entry_meta_key}" ] = $added_field;
 
 		return $fields;
 	}
@@ -195,7 +195,7 @@ 
 	 */
 	function set_default_search_label( $label = '', $gf_field = null, $field = array() ) {
 
-		if( $this->name === $field['field'] && '' === $label ) {
+		if ( $this->name === $field[ 'field' ] && '' === $label ) {
 			$label = esc_html( $this->default_search_label );
 		}
 
@@ -216,7 +216,7 @@ 
 	 *
 	 * @return string Original text if {_custom_merge_tag} isn't found. Otherwise, replaced text.
 	 */
-	public function _filter_gform_replace_merge_tags( $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false  ) {
+	public function _filter_gform_replace_merge_tags( $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
 
 		// Is there is field merge tag? Strip whitespace off the ned, too.
 		preg_match_all( '/{' . preg_quote( $this->_custom_merge_tag ) . ':?(.*?)(?:\s)?}/ism', $text, $matches, PREG_SET_ORDER );
@@ -247,19 +247,19 @@ 
 	 */
 	public function replace_merge_tag( $matches = array(), $text = '', $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
 
-		foreach( $matches as $match ) {
+		foreach ( $matches as $match ) {
 
-			$full_tag = $match[0];
+			$full_tag = $match[ 0 ];
 
 			// Strip the Merge Tags
-			$tag = str_replace( array( '{', '}'), '', $full_tag );
+			$tag = str_replace( array( '{', '}' ), '', $full_tag );
 
 			// Replace the value from the entry, if exists
-			if( isset( $entry[ $tag ] ) ) {
+			if ( isset( $entry[ $tag ] ) ) {
 
 				$value = $entry[ $tag ];
 
-				if( is_callable( array( $this, 'get_content') ) ) {
+				if ( is_callable( array( $this, 'get_content' ) ) ) {
 					$value = $this->get_content( $value );
 				}
 
@@ -332,8 +332,8 @@ 
 	 */
 	public function _filter_sortable_fields( $not_sortable ) {
 
-		if( ! $this->is_sortable ) {
-			$not_sortable[] = $this->name;
+		if ( ! $this->is_sortable ) {
+			$not_sortable[ ] = $this->name;
 		}
 
 		return $not_sortable;
@@ -350,7 +350,7 @@ 
 	 */
 	function add_entry_meta( $entry_meta ) {
 
-		if( ! isset( $entry_meta["{$this->entry_meta_key}"] ) ) {
+		if ( ! isset( $entry_meta[ "{$this->entry_meta_key}" ] ) ) {
 
 			$added_meta = array(
 				'label'             => $this->label,
@@ -359,13 +359,13 @@ 
 			);
 
 			if ( $this->entry_meta_update_callback && is_callable( $this->entry_meta_update_callback ) ) {
-				$added_meta['update_entry_meta_callback'] = $this->entry_meta_update_callback;
+				$added_meta[ 'update_entry_meta_callback' ] = $this->entry_meta_update_callback;
 			}
 
-			$entry_meta["{$this->entry_meta_key}"] = $added_meta;
+			$entry_meta[ "{$this->entry_meta_key}" ] = $added_meta;
 
 		} else {
-			do_action( 'gravityview_log_error', __METHOD__ . ' Entry meta already set: ' . $this->entry_meta_key, $entry_meta["{$this->entry_meta_key}"] );
+			do_action( 'gravityview_log_error', __METHOD__ . ' Entry meta already set: ' . $this->entry_meta_key, $entry_meta[ "{$this->entry_meta_key}" ] );
 		}
 
 		return $entry_meta;
@@ -394,7 +394,7 @@ 
 			'date_display' => array(
 				'type' => 'text',
 				'label' => __( 'Override Date Format', 'gravityview' ),
-				'desc' => sprintf( __( 'Define how the date is displayed (using %sthe PHP date format%s)', 'gravityview'), '<a href="https://codex.wordpress.org/Formatting_Date_and_Time">', '</a>' ),
+				'desc' => sprintf( __( 'Define how the date is displayed (using %sthe PHP date format%s)', 'gravityview' ), '<a href="https://codex.wordpress.org/Formatting_Date_and_Time">', '</a>' ),
 				/**
 				 * @filter `gravityview_date_format` Override the date format with a [PHP date format](https://codex.wordpress.org/Formatting_Date_and_Time)
 				 * @param[in,out] null|string $date_format Date Format (default: null)
@@ -419,7 +419,7 @@ 
 
 		$options = $this->field_support_options();
 
-		if( isset( $options[ $key ] ) ) {
+		if ( isset( $options[ $key ] ) ) {
 			$field_options[ $key ] = $options[ $key ];
 		}
 
@@ -483,11 +483,11 @@ 
 		$connected_form = rgpost( 'form_id' );
 
 		// Otherwise, get the Form ID from the Post page
-		if( empty( $connected_form ) ) {
+		if ( empty( $connected_form ) ) {
 			$connected_form = gravityview_get_form_id( get_the_ID() );
 		}
 
-		if( empty( $connected_form ) ) {
+		if ( empty( $connected_form ) ) {
 			do_action( 'gravityview_log_error', sprintf( '%s: Form not found for form ID "%s"', __METHOD__, $connected_form ) );
 			return false;
 		}

includes/fields/class-gravityview-field-post-image.php

Spacing +12 added lines, -12 removed lines

@@ -23,16 +23,16 @@ 
 
 	function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
 
-		unset ( $field_options['search_filter'] );
+		unset ( $field_options[ 'search_filter' ] );
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
-		$this->add_field_support('link_to_post', $field_options );
+		$this->add_field_support( 'link_to_post', $field_options );
 
 		// @since 1.5.4
-		$this->add_field_support('dynamic_data', $field_options );
+		$this->add_field_support( 'dynamic_data', $field_options );
 
 		return $field_options;
 	}
@@ -59,7 +59,7 @@ 
 		$url = $title = $caption = $description = '';
 
 		// If there's a |:| match, process. Otherwise, empty array!
-		if( preg_match( '/\|\:\|/', $value ) ) {
+		if ( preg_match( '/\|\:\|/', $value ) ) {
 			list( $url, $title, $caption, $description ) = array_pad( explode( '|:|', $value ), 4, false );
 		}
 
@@ -88,8 +88,8 @@ 
 	 */
 	public function get_field_input( $form, $value = '', $entry = null, GF_Field_Post_Image $field ) {
 
-		$id = (int) $field->id;
-		$form_id = $form['id'];
+		$id = (int)$field->id;
+		$form_id = $form[ 'id' ];
 		$input_name = "input_{$id}";
 		$field_id = sprintf( 'input_%d_%d', $form_id, $id );
 		$img_name = null;
@@ -97,16 +97,16 @@ 
 		// Convert |:| to associative array
 		$img_array = self::explode_value( $value );
 
-		if( ! empty( $img_array['url'] ) ) {
+		if ( ! empty( $img_array[ 'url' ] ) ) {
 
-			$img_name = basename( $img_array['url'] );
+			$img_name = basename( $img_array[ 'url' ] );
 
 			/**
 			 * Set the $uploaded_files value so that the .ginput_preview renders, and the file upload is hidden
 			 * @see GF_Field_Post_Image::get_field_input See the `<span class='ginput_preview'>` code
 			 * @see GFFormsModel::get_temp_filename See the `rgget( $input_name, self::$uploaded_files[ $form_id ] );` code
 			 */
-			if( empty( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
+			if ( empty( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
 				GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $img_name;
 			}
 		}
@@ -135,8 +135,8 @@ 
 		 * @hack
 		 */
 		if ( null !== $img_name ) {
-			$current_file = sprintf( "<input name='%s' id='%s' type='hidden' value='%s' />", $input_name, $field_id, esc_url_raw( $img_array['url'] ) );
-			$gf_post_image_field_output = str_replace('<span class=\'ginput_preview\'>', '<span class=\'ginput_preview\'>'.$current_file, $gf_post_image_field_output );
+			$current_file = sprintf( "<input name='%s' id='%s' type='hidden' value='%s' />", $input_name, $field_id, esc_url_raw( $img_array[ 'url' ] ) );
+			$gf_post_image_field_output = str_replace( '<span class=\'ginput_preview\'>', '<span class=\'ginput_preview\'>' . $current_file, $gf_post_image_field_output );
 		}
 
 		return $gf_post_image_field_output;

includes/fields/class-gravityview-field-multiselect.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 	 * @see GFCommon::get_field_filter_settings Gravity Forms suggests checkboxes should just be "contains"
 	 * @var array
 	 */
-	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains');
+	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains' );
 
 	var $is_searchable = true;
 

includes/fields/class-gravityview-field-radio.php

Spacing +3 added lines, -3 removed lines

@@ -11,7 +11,7 @@ 
 
 	var $is_searchable = true;
 
-	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains');
+	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains' );
 
 	var $_gf_field_class_name = 'GF_Field_Radio';
 
@@ -40,8 +40,8 @@ 
 		// Set the $_field_id var
 		$field_options = parent::field_options( $field_options, $template_id, $field_id, $context, $input_type );
 		
-		if( $this->is_choice_value_enabled() ) {
-			$field_options['choice_display'] = array(
+		if ( $this->is_choice_value_enabled() ) {
+			$field_options[ 'choice_display' ] = array(
 				'type'    => 'radio',
 				'value'   => 'value',
 				'label'   => __( 'What should be displayed:', 'gravityview' ),

includes/fields/class-gravityview-field-is-fulfilled.php

Spacing +5 added lines, -5 removed lines

@@ -59,7 +59,7 @@ 
 	public function get_content( $output, $entry = array(), $field_settings = array(), $field = array() ) {
 
 		/** Overridden by a template. */
-		if( ! empty( $field['field_path'] ) ) { return $output; }
+		if ( ! empty( $field[ 'field_path' ] ) ) { return $output; }
 
 		return $this->get_string_from_value( $output );
 	}
@@ -78,11 +78,11 @@ 
 		switch ( intval( $value ) ) {
 			case self::NOT_FULFILLED:
 			default:
-				$return = __('Not Fulfilled', 'gravityview');
+				$return = __( 'Not Fulfilled', 'gravityview' );
 				break;
 
 			case self::FULFILLED:
-				$return = __('Fulfilled', 'gravityview');
+				$return = __( 'Fulfilled', 'gravityview' );
 				break;
 		}
 
@@ -102,13 +102,13 @@ 
 	 *
 	 * @return string Original text if {is_fulfilled} isn't found. Otherwise, "Not Fulfilled" or "Fulfilled"
 	 */
-	public function replace_merge_tag( $matches = array(), $text = '', $form = array(), $entry = array(), $url_encode = false, $esc_html = false  ) {
+	public function replace_merge_tag( $matches = array(), $text = '', $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
 
 		$return = $text;
 
 		foreach ( $matches as $match ) {
 
-			$full_tag = $match[0];
+			$full_tag = $match[ 0 ];
 
 			$fulfilled = rgar( $entry, 'is_fulfilled' );
 

includes/fields/class-gravityview-field-post-category.php

Spacing +10 added lines, -10 removed lines

@@ -11,7 +11,7 @@ 
 
 	var $is_searchable = true;
 
-	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains');
+	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains' );
 
 	var $_gf_field_class_name = 'GF_Field_Post_Category';
 
@@ -44,7 +44,7 @@ 
 		$entry = GFAPI::get_entry( $entry_id );
 		$post_id = rgar( $entry, 'post_id' );
 
-		if( empty( $post_id ) ) {
+		if ( empty( $post_id ) ) {
 			return false;
 		}
 
@@ -52,7 +52,7 @@ 
 
 		$post_category_fields = GFAPI::get_fields_by_type( $form, 'post_category' );
 
-		if( $post_category_fields ) {
+		if ( $post_category_fields ) {
 
 			$updated_categories = array();
 
@@ -119,18 +119,18 @@ 
 	 *
 	 * @return mixed
 	 */
-	function edit_entry_post_category_choices( $choices, $field, $form_id  ) {
+	function edit_entry_post_category_choices( $choices, $field, $form_id ) {
 
-		$entry = GravityView_Edit_Entry::getInstance()->instances['render']->get_entry();
+		$entry = GravityView_Edit_Entry::getInstance()->instances[ 'render' ]->get_entry();
 
 		// $entry['post_id'] should always be set, but we check to make sure.
-		if( $entry && isset( $entry['post_id'] ) && $post_id = $entry['post_id'] ) {
+		if ( $entry && isset( $entry[ 'post_id' ] ) && $post_id = $entry[ 'post_id' ] ) {
 
 			$post_categories = wp_get_post_categories( $post_id, array( 'fields' => 'ids' ) );
 
 			// Always use the live value
 			foreach ( $choices as &$choice ) {
-				$choice['isSelected'] = in_array( $choice['value'], array_values( $post_categories ) );
+				$choice[ 'isSelected' ] = in_array( $choice[ 'value' ], array_values( $post_categories ) );
 			}
 		}
 
@@ -139,12 +139,12 @@ 
 
 	function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
-		$this->add_field_support('dynamic_data', $field_options );
-		$this->add_field_support('link_to_term', $field_options );
+		$this->add_field_support( 'dynamic_data', $field_options );
+		$this->add_field_support( 'link_to_term', $field_options );
 
 		return $field_options;
 	}

includes/fields/class-gravityview-field-post-tags.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
 
 	var $is_searchable = true;
 
-	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains');
+	var $search_operators = array( 'is', 'in', 'not in', 'isnot', 'contains' );
 
 	var $_gf_field_class_name = 'GF_Field_Post_Tags';
 
@@ -27,12 +27,12 @@ 
 
 	function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
 
-		if( 'edit' === $context ) {
+		if ( 'edit' === $context ) {
 			return $field_options;
 		}
 
-		$this->add_field_support('dynamic_data', $field_options );
-		$this->add_field_support('link_to_term', $field_options );
+		$this->add_field_support( 'dynamic_data', $field_options );
+		$this->add_field_support( 'link_to_term', $field_options );
 
 		return $field_options;
 	}

includes/plugin-and-theme-hooks/class-gravityview-plugin-hooks-gravity-perks.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
 	public function edit_entry_fix_uid_fields( $fields ) {
 
 		/** @var GF_Field $field */
-		foreach( $fields as &$field ) {
+		foreach ( $fields as &$field ) {
 			if ( 'uid' === $field->type ) {
 
 				// Replace GF_Field with GF_Field_Text, copying all the data from $field