GravityView_Admin_View_Item

Complexity

Total Complexity

20

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	27	2
A	__toString()	0	4	1
A	additional_info()	0	3	1
B	get_item_info()	0	33	5
D	getOutput()	0	52	11

<?php

class GravityView_Admin_View_Field extends GravityView_Admin_View_Item {

	private $label_type = 'field';

Consider using a different property name as you override a private property of the parent class.

The property $label_type is not used and could be removed.

	protected function additional_info() {

		$field_info = '';

		$field_info_items = array();

		// Fields with IDs, not like Source URL or Entry ID
		if( is_numeric( $this->id ) ) {

			$field_type_title = GFCommon::get_field_type_title( $this->item['input_type'] );

			$field_info_items[] = array(
				'value' => sprintf( __('Type: %s', 'gravityview'), $field_type_title )

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			);

			$field_info_items[] = array(
				'value' => sprintf( __('Field ID: %s', 'gravityview'), $this->id ),

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			);

		}

		if( !empty( $this->item['desc'] ) ) {

Expected 1 space after "!"; 0 found

			$field_info_items[] = array(
				'value' => $this->item['desc']

Each line in an array declaration must end in a comma

			);
		}

		if( !empty( $this->item['adminLabel'] ) ) {

Expected 1 space after "!"; 0 found

			$field_info_items[] = array(
				'value' => sprintf( __('Admin Label: %s', 'gravityview' ), $this->item['adminLabel'] ),

Expected 1 spaces after opening bracket; 0 found

				'class'	=> 'gv-sublabel'

Each line in an array declaration must end in a comma

			);
		}

		return $field_info_items;
	}

}

class GravityView_Admin_View_Widget extends GravityView_Admin_View_Item {

	private $label_type = 'widget';

Consider using a different property name as you override a private property of the parent class.

The property $label_type is not used and could be removed.

	protected function additional_info() {

		$field_info = '';
		$field_info_items = array();

		if( !empty( $this->item['description'] ) ) {

Expected 1 space after "!"; 0 found

			$field_info_items[] = array(
				'value' => $this->item['description']

Each line in an array declaration must end in a comma

			);

		}

		return $field_info_items;
	}

}

/**
 * A field or widget in GravityView view configuration
 */
class GravityView_Admin_View_Item {

	protected $title;
	protected $id;
	protected $subtitle;
	protected $settings_html;
	private   $label_type;
	protected $item;

	function __construct( $title = '', $field_id, $item = array(), $settings = array() ) {

It is generally recommended to explicitly declare the visibility for methods.

		// Backward compat
		if( !empty( $item['type'] ) ) {

Expected 1 space after "!"; 0 found

			$item['input_type'] = $item['type'];
			unset( $item['type'] );
		}

		// Prevent items from not having index set
		$item = wp_parse_args( $item, array(
			'label_text' => $title,
			'field_id' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'parent_label' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'label_type' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'input_type' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'settings_html' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'adminLabel' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'adminOnly' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

			'subtitle' => NULL,

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

		));

		$this->title = $title;
		$this->item = $item;
		$this->id = $field_id;
		$this->settings = $settings;

The property settings does not seem to exist. Did you mean settings_html?

		$this->label_type = $item['label_type'];
	}

	/**
	 * When echoing this class, print the HTML output
	 * @return string HTML output of the class
	 */
	public function __toString() {

		return $this->getOutput();
	}

	/**
	 * Overridden by child classes
	 * @return array Array of content with arrays for each item. Those arrays have `value`, `label` and (optional) `class` keys
	 */
	protected function additional_info() {
		return array();
	}

	/**
	 * Generate the output for a field based on the additional_info() output
	 *
	 * @see GravityView_Admin_View_Item::additional_info()
	 * @param  boolean $html Display HTML output? If yes, output is wrapped in spans. If no, plaintext.
	 * @return string|null        If empty, return null. Otherwise, return output HTML/text.
	 */
	protected function get_item_info( $html = true ) {

		$output = NULL;

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

		$field_info_items = $this->additional_info();

		/**
		 * @filter `gravityview_admin_label_item_info` Tap in to modify the field information displayed next to an item
		 * @param array $field_info_items Additional information to display in a field
		 * @param GravityView_Admin_View_Field $this Field shown in the admin
		 */
		$field_info_items = apply_filters( 'gravityview_admin_label_item_info', $field_info_items, $this );

		if( $html ) {

			foreach ( $field_info_items as $item ) {
				$class = isset($item['class']) ? sanitize_html_class( $item['class'] ).' description' : 'description';

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				// Add the title in case the value's long, in which case, it'll be truncated by CSS.
				$output .= '<span class="'.$class.'">';
				$output .= esc_html( $item['value'] );
				$output .= '</span>';
			}

Blank line found after control structure

		} else {

			$values = wp_list_pluck( $field_info_items, 'value' );

			$output = esc_html( implode(', ', $values) );

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		}

		return empty( $output ) ? NULL : $output;

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

	}

	/**
	 * Generate HTML for field or a widget modal
	 *
	 * @return string
	 */
	function getOutput() {

It is generally recommended to explicitly declare the visibility for methods.

The function name getOutput is in camel caps, but expected get_output instead as per the coding standard.

		$settings_title = sprintf(__('Configure %s Settings', 'gravityview'), ucfirst($this->label_type));

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$delete_title = sprintf(__('Remove %s', 'gravityview'), ucfirst($this->label_type));

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$single_link_title = __('This field links to the Single Entry', 'gravityview');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		// $settings_html will just be hidden inputs if empty. Otherwise, it'll have an <ul>. Ugly hack, I know.
		// TODO: Un-hack this
		$hide_settings_link = ( empty( $this->item['settings_html'] ) || strpos( $this->item['settings_html'], '<!-- No Options -->') > 0 ) ? 'hide-if-js' : '';

Expected 1 spaces before closing bracket; 0 found

		$settings_link = sprintf( '<a href="#settings" class="dashicons-admin-generic dashicons %s" title="%s"></a>', $hide_settings_link, esc_attr( $settings_title ) );

		// Should we show the icon that the field is being used as a link to single entry?
		$hide_show_as_link_class = empty( $this->settings['show_as_link'] ) ? 'hide-if-js' : '';

The property settings does not seem to exist. Did you mean settings_html?

		$show_as_link = '<span class="dashicons dashicons-admin-links '.$hide_show_as_link_class.'" title="'.esc_attr( $single_link_title ).'"></span>';

		// When a field label is empty, use the Field ID
		$label = empty( $this->title ) ? sprintf( _x('Field #%s (No Label)', 'Label in field picker for empty label', 'gravityview'), $this->id ) : $this->title;

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		// If there's a custom label, and show label is checked, use that as the field heading
		if( !empty( $this->settings['custom_label'] ) && !empty( $this->settings['show_label'] ) ) {

The property settings does not seem to exist. Did you mean settings_html?

Expected 1 space after "!"; 0 found

			$label = $this->settings['custom_label'];

The property settings does not seem to exist. Did you mean settings_html?

		} else if( !empty( $this->item['customLabel'] ) ) {

Expected 1 space after "!"; 0 found

			$label = $this->item['customLabel'];
		}

		$output = '<h5 class="selectable gfield field-id-'.esc_attr($this->id).'">';

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$label = esc_attr( $label );

		if( !empty( $this->item['parent'] ) ) {

Expected 1 space after "!"; 0 found

			$label .= ' <small>('.esc_attr( $this->item['parent']['label'] ) .')</small>';
		}

		// Name of field / widget
		$output .= '<span class="gv-field-label" data-original-title="'.esc_attr( $label ).'" title="'. $this->get_item_info( false ) .'">'. $label . '</span>';

Functions must not contain multiple empty lines in a row; found 2 empty lines

		$output .= '<span class="gv-field-controls">'.$settings_link.$show_as_link.'<a href="#remove" class="dashicons-dismiss dashicons" title="'.esc_attr( $delete_title ) .'"></a></span>';

		// Displays only in the field/widget picker.
		if( $field_info = $this->get_item_info() ) {
			$output .= '<span class="gv-field-info">'.$field_info.'</span>';
		}

		$output .= '</h5>';

		$container_class = !empty( $this->item['parent'] ) ? ' gv-child-field' : '';

Expected 1 space after "!"; 0 found

		$output = '<div data-fieldid="'.esc_attr($this->id).'" data-inputtype="'.esc_attr( $this->item['input_type'] ).'" class="gv-fields'.$container_class.'">'.$output.$this->item['settings_html'].'</div>';

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		return $output;
	}

}