gravityview / GravityView

includes/class-gravityview-admin-duplicate-view.php

Doc Comments +1 added lines, -1 removed lines

@@ -195,7 +195,7 @@
 	 *
 	 * @since 1.6
 	 *
-	 * @param int $new_view_id The ID of the newly created View
+	 * @param int $new_id The ID of the newly created View
 	 * @param WP_Post $post The View that was just cloned
 	 *
 	 * @return void

Spacing +71 added lines, -71 removed lines

@@ -15,12 +15,12 @@ 
 	function __construct() {
 
 		// Only run on Admin
-		if ( !is_admin() ) {
+		if (!is_admin()) {
 			return;
 		}
 
 		// If the Duplicate Post plugin is active, don't run.
-		if( defined('DUPLICATE_POST_CURRENT_VERSION') ) {
+		if (defined('DUPLICATE_POST_CURRENT_VERSION')) {
 			return;
 		}
 
@@ -33,18 +33,18 @@ 
 	 * @return void
 	 */
 	private function add_hooks() {
-		add_filter( 'post_row_actions', array( $this, 'make_duplicate_link_row' ), 10, 2 );
+		add_filter('post_row_actions', array($this, 'make_duplicate_link_row'), 10, 2);
 
 		/**
 		 * Connect actions to functions
 		 */
-		add_action( 'admin_action_duplicate_view', array( $this, 'save_as_new_view' ) );
-		add_action( 'admin_action_duplicate_view_as_draft', array( $this, 'save_as_new_view_draft' ) );
+		add_action('admin_action_duplicate_view', array($this, 'save_as_new_view'));
+		add_action('admin_action_duplicate_view_as_draft', array($this, 'save_as_new_view_draft'));
 
 		// Using our action hooks to copy meta fields
-		add_action( 'gv_duplicate_view', array( $this, 'copy_view_meta_info' ), 10, 2 );
+		add_action('gv_duplicate_view', array($this, 'copy_view_meta_info'), 10, 2);
 
-		add_filter( 'gravityview_connected_form_links', array( $this, 'connected_form_links' ), 10, 2 );
+		add_filter('gravityview_connected_form_links', array($this, 'connected_form_links'), 10, 2);
 	}
 
 	/**
@@ -55,15 +55,15 @@ 
 	 *
 	 * @return array If it's the All Views page, return unedited. Otherwise, add a link to create cloned draft of View
 	 */
-	function connected_form_links( $links = array(), $form = array() ) {
+	function connected_form_links($links = array(), $form = array()) {
 		/** @global WP_Post $post */
 		global $post;
 
 		// We only want to add Clone links to the Edit View metabox
-		if( !$this->is_all_views_page() ) {
+		if (!$this->is_all_views_page()) {
 
-			if( $duplicate_links = $this->make_duplicate_link_row( array(), $post ) ) {
-				$links[] = '<span>' . $duplicate_links['edit_as_new_draft'] . '</span>';
+			if ($duplicate_links = $this->make_duplicate_link_row(array(), $post)) {
+				$links[] = '<span>'.$duplicate_links['edit_as_new_draft'].'</span>';
 			}
 
 		}
@@ -88,12 +88,12 @@ 
 	 *
 	 * @since 1.6
 	 */
-	private function current_user_can_copy( $post ) {
+	private function current_user_can_copy($post) {
 
-		$id = is_object( $post ) ? $post->ID : $post;
+		$id = is_object($post) ? $post->ID : $post;
 
 		// Can't edit this current View
-		return GVCommon::has_cap( 'copy_gravityviews', $id );
+		return GVCommon::has_cap('copy_gravityviews', $id);
 
 	}
 
@@ -104,10 +104,10 @@ 
 	 * @param string $status The post status
 	 * @since 1.6
 	 */
-	private function create_duplicate( $post, $status = '' ) {
+	private function create_duplicate($post, $status = '') {
 
 		// We only want to clone Views
-		if ( $post->post_type !== 'gravityview' ) {
+		if ($post->post_type !== 'gravityview') {
 			return;
 		}
 
@@ -119,7 +119,7 @@ 
 		 * @param string|null If string, the status to set for the new View. If empty, use existing View status.
 		 * @param WP_Post $post View being cloned
 		 */
-		$new_view_status = apply_filters('gravityview/duplicate-view/status', $status, $post );
+		$new_view_status = apply_filters('gravityview/duplicate-view/status', $status, $post);
 
 		$new_view = array(
 			'menu_order'     => $post->menu_order,
@@ -131,7 +131,7 @@ 
 			'post_mime_type' => $post->post_mime_type,
 			'post_parent'    => $post->post_parent,
 			'post_password'  => $post->post_password,
-			'post_status'    => ( empty( $new_view_status ) ) ? $post->post_status : $new_view_status,
+			'post_status'    => (empty($new_view_status)) ? $post->post_status : $new_view_status,
 			'post_title'     => $post->post_title,
 			'post_type'      => $post->post_type,
 		);
@@ -142,11 +142,11 @@ 
 		 * @param boolean $copy_date Whether the copy the date from the existing View. Default: `false`
 		 * @param WP_Post $post View being cloned
 		 */
-		$copy_date = apply_filters('gravityview/duplicate-view/copy-date', false, $post );
+		$copy_date = apply_filters('gravityview/duplicate-view/copy-date', false, $post);
 
-		if ( $copy_date ) {
+		if ($copy_date) {
 			$new_view['post_date']     = $new_post_date = $post->post_date;
-			$new_view['post_date_gmt'] = get_gmt_from_date( $new_post_date );
+			$new_view['post_date_gmt'] = get_gmt_from_date($new_post_date);
 		}
 
 		/**
@@ -155,15 +155,15 @@ 
 		 * @param array $new_view Array of settings to be passed to wp_insert_post()
 		 * @param WP_Post $post View being cloned
 		 */
-		$new_view = apply_filters('gravityview/duplicate-view/new-view', $new_view, $post );
+		$new_view = apply_filters('gravityview/duplicate-view/new-view', $new_view, $post);
 
 		// Magic happens here.
-		$new_view_id = wp_insert_post( $new_view );
+		$new_view_id = wp_insert_post($new_view);
 
 		// If the copy is published or scheduled, we have to set a proper slug.
-		if ( $new_view_status == 'publish' || $new_view_status == 'future' ) {
+		if ($new_view_status == 'publish' || $new_view_status == 'future') {
 
-			$view_name = wp_unique_post_slug( $post->post_name, $new_view_id, $new_view_status, $post->post_type, $post->post_parent );
+			$view_name = wp_unique_post_slug($post->post_name, $new_view_id, $new_view_status, $post->post_type, $post->post_parent);
 
 			$new_view_name_array = array(
 				'ID' => $new_view_id,
@@ -171,7 +171,7 @@ 
 			);
 
 			// Update the post into the database
-			wp_update_post( $new_view_name_array );
+			wp_update_post($new_view_name_array);
 		}
 
 		/**
@@ -181,11 +181,11 @@ 
 		 * @param int $new_view_id The ID of the newly created View
 		 * @param WP_Post The View that was just cloned
 		 */
-		do_action( 'gv_duplicate_view', $new_view_id, $post );
+		do_action('gv_duplicate_view', $new_view_id, $post);
 
-		delete_post_meta( $new_view_id, '_dp_original' );
+		delete_post_meta($new_view_id, '_dp_original');
 
-		add_post_meta( $new_view_id, '_dp_original', $post->ID, false );
+		add_post_meta($new_view_id, '_dp_original', $post->ID, false);
 
 		return $new_view_id;
 	}
@@ -200,23 +200,23 @@ 
 	 *
 	 * @return void
 	 */
-	public function copy_view_meta_info( $new_id, $post ) {
+	public function copy_view_meta_info($new_id, $post) {
 
-		$post_meta_keys = get_post_custom_keys( $post->ID );
+		$post_meta_keys = get_post_custom_keys($post->ID);
 
-		if ( empty( $post_meta_keys ) ) {
+		if (empty($post_meta_keys)) {
 			return;
 		}
 
-		foreach ( $post_meta_keys as $meta_key ) {
+		foreach ($post_meta_keys as $meta_key) {
 
-			$meta_values = get_post_custom_values( $meta_key, $post->ID );
+			$meta_values = get_post_custom_values($meta_key, $post->ID);
 
-			foreach ( $meta_values as $meta_value ) {
+			foreach ($meta_values as $meta_value) {
 
-				$meta_value = maybe_unserialize( $meta_value );
+				$meta_value = maybe_unserialize($meta_value);
 
-				add_post_meta( $new_id, $meta_key, $meta_value );
+				add_post_meta($new_id, $meta_key, $meta_value);
 			}
 		}
 	}
@@ -228,22 +228,22 @@ 
 	 * @param array $actions Row action links. Defaults are 'Edit', 'Quick Edit', 'Restore, 'Trash', 'Delete Permanently', 'Preview', and 'View'
 	 * @param WP_Post $post
 	 */
-	public function make_duplicate_link_row( $actions, $post ) {
+	public function make_duplicate_link_row($actions, $post) {
 
 		// Only process on GravityView Views
-		if ( get_post_type( $post ) === 'gravityview' && $this->current_user_can_copy( $post ) ) {
+		if (get_post_type($post) === 'gravityview' && $this->current_user_can_copy($post)) {
 
-			$clone_link = $this->get_clone_view_link( $post->ID, 'display', false );
-			$clone_text = __( 'Clone', 'gravityview' );
-			$clone_title = __( 'Clone this View', 'gravityview' );
+			$clone_link = $this->get_clone_view_link($post->ID, 'display', false);
+			$clone_text = __('Clone', 'gravityview');
+			$clone_title = __('Clone this View', 'gravityview');
 
-			$actions['clone'] = gravityview_get_link( $clone_link, $clone_text, 'title='.$clone_title );
+			$actions['clone'] = gravityview_get_link($clone_link, $clone_text, 'title='.$clone_title);
 
-			$clone_draft_link = $this->get_clone_view_link( $post->ID );
-			$clone_draft_text = $this->is_all_views_page() ? __( 'New Draft', 'gravityview' ) : __( 'Clone View', 'gravityview' );
-			$clone_draft_title = __( 'Copy as a new draft View', 'gravityview' );
+			$clone_draft_link = $this->get_clone_view_link($post->ID);
+			$clone_draft_text = $this->is_all_views_page() ? __('New Draft', 'gravityview') : __('Clone View', 'gravityview');
+			$clone_draft_title = __('Copy as a new draft View', 'gravityview');
 
-			$actions['edit_as_new_draft'] = gravityview_get_link( $clone_draft_link, esc_html( $clone_draft_text ), 'title='.$clone_draft_title );
+			$actions['edit_as_new_draft'] = gravityview_get_link($clone_draft_link, esc_html($clone_draft_text), 'title='.$clone_draft_title);
 		}
 
 		return $actions;
@@ -259,31 +259,31 @@ 
 	 * @param string $draft Optional, default to true
 	 * @return string
 	 */
-	private function get_clone_view_link( $id = 0, $context = 'display', $draft = true ) {
+	private function get_clone_view_link($id = 0, $context = 'display', $draft = true) {
 
 		// Make sure they have permission
-		if ( false === $this->current_user_can_copy( $id ) ) {
+		if (false === $this->current_user_can_copy($id)) {
 			return '';
 		}
 
 		// Verify the View exists
-		if ( !$view = get_post( $id ) ) {
+		if (!$view = get_post($id)) {
 			return '';
 		}
 
 		$action_name = $draft ? "duplicate_view_as_draft" : "duplicate_view";
 
-		$action = '?action=' . $action_name . '&post=' . $view->ID;
+		$action = '?action='.$action_name.'&post='.$view->ID;
 
-		if ( 'display' == $context ) {
-			$action = esc_html( $action );
+		if ('display' == $context) {
+			$action = esc_html($action);
 		}
 
-		$post_type_object = get_post_type_object( $view->post_type );
+		$post_type_object = get_post_type_object($view->post_type);
 
 		/** If there's no gravityview post type for some reason, abort! */
-		if ( !$post_type_object ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' No gravityview post type exists when trying to clone the View.', $view );
+		if (!$post_type_object) {
+			do_action('gravityview_log_error', __METHOD__.' No gravityview post type exists when trying to clone the View.', $view);
 			return '';
 		}
 
@@ -294,7 +294,7 @@ 
 		 * @param int $view_id View ID
 		 * @param string $context How to display the link. If "display", the URL is run through esc_html(). Default: `display`
 		 */
-		$clone_view_link = apply_filters( 'gravityview/duplicate-view/get_clone_view_link', admin_url( "admin.php". $action ), $view->ID, $context );
+		$clone_view_link = apply_filters('gravityview/duplicate-view/get_clone_view_link', admin_url("admin.php".$action), $view->ID, $context);
 
 		return $clone_view_link;
 	}
@@ -308,7 +308,7 @@ 
 	 * @return void
 	 */
 	public function save_as_new_view_draft() {
-		$this->save_as_new_view( 'draft' );
+		$this->save_as_new_view('draft');
 	}
 
 	/**
@@ -319,38 +319,38 @@ 
 	 * @param string $status The status to set for the new View
 	 * @return void
 	 */
-	public function save_as_new_view( $status = '' ) {
+	public function save_as_new_view($status = '') {
 
-		if ( ! ( isset( $_GET['post'] ) || isset( $_POST['post'] ) ) ) {
-			wp_die( __( 'No post to duplicate has been supplied!', 'gravityview' ) );
+		if (!(isset($_GET['post']) || isset($_POST['post']))) {
+			wp_die(__('No post to duplicate has been supplied!', 'gravityview'));
 		}
 
 		// Get the original post
-		$id   = ( isset( $_GET['post'] ) ? $_GET['post'] : $_POST['post'] );
+		$id = (isset($_GET['post']) ? $_GET['post'] : $_POST['post']);
 
-		if( ! $this->current_user_can_copy( $id ) ) {
-			wp_die( __( 'You don\'t have permission to copy this View.', 'gravityview' ) );
+		if (!$this->current_user_can_copy($id)) {
+			wp_die(__('You don\'t have permission to copy this View.', 'gravityview'));
 		}
 
-		$post = get_post( $id );
+		$post = get_post($id);
 
 		// Copy the post and insert it
-		if ( isset( $post ) && $post != NULL ) {
+		if (isset($post) && $post != NULL) {
 
-			$new_id = $this->create_duplicate( $post, $status );
+			$new_id = $this->create_duplicate($post, $status);
 
-			if ( $status == '' ) {
+			if ($status == '') {
 				// Redirect to the post list screen
-				wp_redirect( admin_url( 'edit.php?post_type=' . $post->post_type ) );
+				wp_redirect(admin_url('edit.php?post_type='.$post->post_type));
 			} else {
 				// Redirect to the edit screen for the new draft post
-				wp_redirect( admin_url( 'post.php?action=edit&post=' . $new_id ) );
+				wp_redirect(admin_url('post.php?action=edit&post='.$new_id));
 			}
 			exit;
 
 		} else {
 
-			wp_die( sprintf( esc_attr__( 'Copy creation failed, could not find original View with ID #%d', 'gravityview' ), $id ) );
+			wp_die(sprintf(esc_attr__('Copy creation failed, could not find original View with ID #%d', 'gravityview'), $id));
 
 		}
 	}

includes/class-gravityview-compatibility.php

Doc Comments +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
 
 	/**
 	 * @since 1.12
-	 * @return bool
+	 * @return boolean|null
 	 */
 	private function add_fallback_shortcode() {
 

Indentation +1 added lines, -1 removed lines

@@ -204,7 +204,7 @@
 			self::$notices['wp_version'] = array(
 				'class' => 'error',
 				'message' => sprintf( __( "%sGravityView requires WordPress %s or newer.%s \n\nYou're using Version %s. Please upgrade your WordPress installation.", 'gravityview' ), '<h3>', GV_MIN_WP_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.$wp_version.'</span>' ),
-			    'cap' => 'update_core',
+				'cap' => 'update_core',
 				'dismiss' => 'wp_version',
 			);
 

Spacing +39 added lines, -39 removed lines

@@ -57,7 +57,7 @@ 
 
 	function add_hooks() {
 
-		add_filter( 'gravityview/admin/notices', array( $this, 'insert_admin_notices' ) );
+		add_filter('gravityview/admin/notices', array($this, 'insert_admin_notices'));
 
 		$this->add_fallback_shortcode();
 	}
@@ -68,15 +68,15 @@ 
 	 *
 	 * @return array
 	 */
-	function insert_admin_notices( $notices = array() ) {
-		return array_merge( $notices, self::$notices );
+	function insert_admin_notices($notices = array()) {
+		return array_merge($notices, self::$notices);
 	}
 
 	/**
 	 * @return GravityView_Compatibility
 	 */
 	public static function getInstance() {
-		if( self::$instance ) {
+		if (self::$instance) {
 			return self::$instance;
 		}
 		return new self;
@@ -87,7 +87,7 @@ 
 	 * @return bool
 	 */
 	public static function is_valid() {
-		return ( self::is_valid_gravity_forms() && self::is_valid_wordpress() && self::is_valid_php() );
+		return (self::is_valid_gravity_forms() && self::is_valid_wordpress() && self::is_valid_php());
 	}
 
 	/**
@@ -123,10 +123,10 @@ 
 		// If Gravity Forms doesn't exist or is outdated, load the admin view class to
 		// show the notice, but not load any post types or process shortcodes.
 		// Without Gravity Forms, there is no GravityView. Beautiful, really.
-		if( ! self::is_valid() ) {
+		if (!self::is_valid()) {
 
 			// If the plugin's not loaded, might as well hide the shortcode for people.
-			add_shortcode( 'gravityview', array( $this, '_shortcode_gf_notice') );
+			add_shortcode('gravityview', array($this, '_shortcode_gf_notice'));
 
 		}
 	}
@@ -150,17 +150,17 @@ 
 	 *
 	 * @return null|string NULL returned if user can't activate plugins. Notice shown with a warning that GF isn't supported.
 	 */
-	public function _shortcode_gf_notice( $atts = array(), $content = null, $shortcode = 'gravityview' ) {
+	public function _shortcode_gf_notice($atts = array(), $content = null, $shortcode = 'gravityview') {
 
-		if( ! GVCommon::has_cap( 'activate_plugins' ) ) {
+		if (!GVCommon::has_cap('activate_plugins')) {
 			return null;
 		}
 
 		$notices = self::get_notices();
 
-		$message = '<div style="border:1px solid red; padding: 15px;"><p style="text-align:center;"><em>' . esc_html__( 'You are seeing this notice because you are an administrator. Other users of the site will see nothing.', 'gravityview') . '</em></p>';
-		foreach( (array)$notices as $notice ) {
-			$message .= wpautop( $notice['message'] );
+		$message = '<div style="border:1px solid red; padding: 15px;"><p style="text-align:center;"><em>'.esc_html__('You are seeing this notice because you are an administrator. Other users of the site will see nothing.', 'gravityview').'</em></p>';
+		foreach ((array)$notices as $notice) {
+			$message .= wpautop($notice['message']);
 		}
 		$message .= '</div>';
 
@@ -175,11 +175,11 @@ 
 	 * @return boolean
 	 */
 	public static function check_php() {
-		if( false === version_compare( phpversion(), GV_MIN_PHP_VERSION , '>=' ) ) {
+		if (false === version_compare(phpversion(), GV_MIN_PHP_VERSION, '>=')) {
 
 			self::$notices['php_version'] = array(
 				'class' => 'error',
-				'message' => sprintf( __( "%sGravityView requires PHP Version %s or newer.%s \n\nYou're using Version %s. Please ask your host to upgrade your server's PHP.", 'gravityview' ), '<h3>', GV_MIN_PHP_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.phpversion().'</span>' ),
+				'message' => sprintf(__("%sGravityView requires PHP Version %s or newer.%s \n\nYou're using Version %s. Please ask your host to upgrade your server's PHP.", 'gravityview'), '<h3>', GV_MIN_PHP_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.phpversion().'</span>'),
 				'cap' => 'manage_options',
 				'dismiss' => 'php_version',
 			);
@@ -199,11 +199,11 @@ 
 	public static function check_wordpress() {
 		global $wp_version;
 
-		if( version_compare( $wp_version, GV_MIN_WP_VERSION ) <= 0 ) {
+		if (version_compare($wp_version, GV_MIN_WP_VERSION) <= 0) {
 
 			self::$notices['wp_version'] = array(
 				'class' => 'error',
-				'message' => sprintf( __( "%sGravityView requires WordPress %s or newer.%s \n\nYou're using Version %s. Please upgrade your WordPress installation.", 'gravityview' ), '<h3>', GV_MIN_WP_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.$wp_version.'</span>' ),
+				'message' => sprintf(__("%sGravityView requires WordPress %s or newer.%s \n\nYou're using Version %s. Please upgrade your WordPress installation.", 'gravityview'), '<h3>', GV_MIN_WP_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.$wp_version.'</span>'),
 			    'cap' => 'update_core',
 				'dismiss' => 'wp_version',
 			);
@@ -226,17 +226,17 @@ 
 	public static function check_gravityforms() {
 
 		// Bypass other checks: if the class exists
-		if( class_exists( 'GFCommon' ) ) {
+		if (class_exists('GFCommon')) {
 
 			// and the version's right, we're good.
-			if( true === version_compare( GFCommon::$version, GV_MIN_GF_VERSION, ">=" ) ) {
+			if (true === version_compare(GFCommon::$version, GV_MIN_GF_VERSION, ">=")) {
 				return true;
 			}
 
 			// Or the version's wrong
 			self::$notices['gf_version'] = array(
 				'class' => 'error',
-				'message' => sprintf( __( "%sGravityView requires Gravity Forms Version %s or newer.%s \n\nYou're using Version %s. Please update your Gravity Forms or purchase a license. %sGet Gravity Forms%s - starting at $39%s%s", 'gravityview' ), '<h3>', GV_MIN_GF_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.GFCommon::$version.'</span>', "\n\n".'<a href="http://katz.si/gravityforms" class="button button-secondary button-large button-hero">' , '<em>', '</em>', '</a>'),
+				'message' => sprintf(__("%sGravityView requires Gravity Forms Version %s or newer.%s \n\nYou're using Version %s. Please update your Gravity Forms or purchase a license. %sGet Gravity Forms%s - starting at $39%s%s", 'gravityview'), '<h3>', GV_MIN_GF_VERSION, "</h3>\n\n", '<span style="font-family: Consolas, Courier, monospace;">'.GFCommon::$version.'</span>', "\n\n".'<a href="http://katz.si/gravityforms" class="button button-secondary button-large button-hero">', '<em>', '</em>', '</a>'),
 				'cap' => 'update_plugins',
 				'dismiss' => 'gf_version',
 			);
@@ -244,40 +244,40 @@ 
 			return false;
 		}
 
-		$gf_status = self::get_plugin_status( 'gravityforms/gravityforms.php' );
+		$gf_status = self::get_plugin_status('gravityforms/gravityforms.php');
 
 		/**
 		 * The plugin is activated and yet somehow GFCommon didn't get picked up...
 		 * OR
 		 * It's the Network Admin and we just don't know whether the sites have GF activated themselves.
 		 */
-		if( true === $gf_status || is_network_admin() ) {
+		if (true === $gf_status || is_network_admin()) {
 			return true;
 		}
 
 		// If GFCommon doesn't exist, assume GF not active
 		$return = false;
 
-		switch( $gf_status ) {
+		switch ($gf_status) {
 			case 'inactive':
 
 				// Required for multisite
-				if( ! function_exists('wp_create_nonce') ) {
-					require_once ABSPATH . WPINC . '/pluggable.php';
+				if (!function_exists('wp_create_nonce')) {
+					require_once ABSPATH.WPINC.'/pluggable.php';
 				}
 
 				// Otherwise, throws an error on activation & deactivation "Use of undefined constant LOGGED_IN_COOKIE"
-				if( is_multisite() ) {
+				if (is_multisite()) {
 					wp_cookie_constants();
 				}
 
 				$return = false;
 
-				$button = function_exists('is_network_admin') && is_network_admin() ? '<strong><a href="#gravity-forms">' : '<strong><a href="'. wp_nonce_url( admin_url( 'plugins.php?action=activate&plugin=gravityforms/gravityforms.php' ), 'activate-plugin_gravityforms/gravityforms.php') . '" class="button button-large">';
+				$button = function_exists('is_network_admin') && is_network_admin() ? '<strong><a href="#gravity-forms">' : '<strong><a href="'.wp_nonce_url(admin_url('plugins.php?action=activate&plugin=gravityforms/gravityforms.php'), 'activate-plugin_gravityforms/gravityforms.php').'" class="button button-large">';
 
 				self::$notices['gf_inactive'] = array(
 					'class' => 'error',
-					'message' => sprintf( __( '%sGravityView requires Gravity Forms to be active. %sActivate Gravity Forms%s to use the GravityView plugin.', 'gravityview' ), '<h3>', "</h3>\n\n". $button, '</a></strong>' ),
+					'message' => sprintf(__('%sGravityView requires Gravity Forms to be active. %sActivate Gravity Forms%s to use the GravityView plugin.', 'gravityview'), '<h3>', "</h3>\n\n".$button, '</a></strong>'),
 					'cap' => 'activate_plugins',
 					'dismiss' => 'gf_inactive',
 				);
@@ -286,7 +286,7 @@ 
 			default:
 				self::$notices['gf_installed'] = array(
 					'class' => 'error',
-					'message' => sprintf( __( '%sGravityView requires Gravity Forms to be installed in order to run properly. %sGet Gravity Forms%s - starting at $39%s%s', 'gravityview' ), '<h3>', "</h3>\n\n".'<a href="http://katz.si/gravityforms" class="button button-secondary button-large button-hero">' , '<em>', '</em>', '</a>'),
+					'message' => sprintf(__('%sGravityView requires Gravity Forms to be installed in order to run properly. %sGet Gravity Forms%s - starting at $39%s%s', 'gravityview'), '<h3>', "</h3>\n\n".'<a href="http://katz.si/gravityforms" class="button button-secondary button-large button-hero">', '<em>', '</em>', '</a>'),
 					'cap' => 'install_plugins',
 					'dismiss' => 'gf_installed',
 				);
@@ -303,11 +303,11 @@ 
 	 */
 	private static function check_gf_directory() {
 
-		if( class_exists( 'GFDirectory' ) ) {
+		if (class_exists('GFDirectory')) {
 			self::$notices['gf_directory'] = array(
 				'class' => 'error is-dismissible',
-				'title' => __('Potential Conflict', 'gravityview' ),
-				'message' => __( 'GravityView and Gravity Forms Directory are both active. This may cause problems. If you experience issues, disable the Gravity Forms Directory plugin.', 'gravityview' ),
+				'title' => __('Potential Conflict', 'gravityview'),
+				'message' => __('GravityView and Gravity Forms Directory are both active. This may cause problems. If you experience issues, disable the Gravity Forms Directory plugin.', 'gravityview'),
 				'dismiss' => 'gf_directory',
 				'cap' => 'activate_plugins',
 			);
@@ -323,23 +323,23 @@ 
 	 * @param string $location (default: '')
 	 * @return boolean|string True: plugin is active; False: plugin file doesn't exist at path; 'inactive' it's inactive
 	 */
-	public static function get_plugin_status( $location = '' ) {
+	public static function get_plugin_status($location = '') {
 
-		if( ! function_exists('is_plugin_active') ) {
-			include_once( ABSPATH . '/wp-admin/includes/plugin.php' );
+		if (!function_exists('is_plugin_active')) {
+			include_once(ABSPATH.'/wp-admin/includes/plugin.php');
 		}
 
-		if( is_network_admin() && is_plugin_active_for_network( $location ) ) {
+		if (is_network_admin() && is_plugin_active_for_network($location)) {
 			return true;
 		}
 
-		if( !is_network_admin() && is_plugin_active( $location ) ) {
+		if (!is_network_admin() && is_plugin_active($location)) {
 			return true;
 		}
 
-		if(
-			!file_exists( trailingslashit( WP_PLUGIN_DIR ) . $location ) &&
-			!file_exists( trailingslashit( WPMU_PLUGIN_DIR ) . $location )
+		if (
+			!file_exists(trailingslashit(WP_PLUGIN_DIR).$location) &&
+			!file_exists(trailingslashit(WPMU_PLUGIN_DIR).$location)
 		) {
 			return false;
 		}

includes/class-gravityview-entry-link-shortcode.php

Doc Comments +1 added lines, -2 removed lines

@@ -221,7 +221,6 @@ 
 	 *
 	 * @since 1.15
 	 *
-	 * @param string|null $content Content inside shortcode, if defined
 	 *
 	 * @return string|boolean If URL is fetched, the URL to the entry link. If not found, returns false.
 	 */
@@ -316,7 +315,7 @@ 
 	 *
 	 * @since 1.15
 	 *
-	 * @param string $href URL
+	 * @param string|null $url
 	 */
 	private function maybe_add_field_values_query_args( $url ) {
 

Spacing +59 added lines, -59 removed lines

@@ -51,17 +51,17 @@ 
 	 * @since 1.15
 	 */
 	private function add_hooks() {
-		add_shortcode( 'gv_entry_link', array( $this, 'read_shortcode' ) );
-		add_shortcode( 'gv_edit_entry_link', array( $this, 'edit_shortcode' ) );
-		add_shortcode( 'gv_delete_entry_link', array( $this, 'delete_shortcode' ) );
+		add_shortcode('gv_entry_link', array($this, 'read_shortcode'));
+		add_shortcode('gv_edit_entry_link', array($this, 'edit_shortcode'));
+		add_shortcode('gv_delete_entry_link', array($this, 'delete_shortcode'));
 	}
 
 	/**
 	 * @since 1.15
 	 * @copydoc GravityView_Entry_Link_Shortcode::shortcode
 	 */
-	public function read_shortcode( $atts, $content = null, $context = 'gv_entry_link' ) {
-		return $this->shortcode( $atts, $content, $context );
+	public function read_shortcode($atts, $content = null, $context = 'gv_entry_link') {
+		return $this->shortcode($atts, $content, $context);
 	}
 
 	/**
@@ -71,10 +71,10 @@ 
 	 * @since 1.15
 	 * @copydoc GravityView_Entry_Link_Shortcode::shortcode
 	 */
-	public function edit_shortcode( $atts, $content = null, $context = 'gv_edit_entry_link' ) {
+	public function edit_shortcode($atts, $content = null, $context = 'gv_edit_entry_link') {
 		$atts['action'] = 'edit';
 
-		return $this->shortcode( $atts, $content, $context );
+		return $this->shortcode($atts, $content, $context);
 	}
 
 	/**
@@ -84,10 +84,10 @@ 
 	 * @since 1.15
 	 * @copydoc GravityView_Entry_Link_Shortcode::shortcode
 	 */
-	public function delete_shortcode( $atts, $content = null, $context = 'gv_delete_entry_link' ) {
+	public function delete_shortcode($atts, $content = null, $context = 'gv_delete_entry_link') {
 		$atts['action'] = 'delete';
 
-		return $this->shortcode( $atts, $content, $context );
+		return $this->shortcode($atts, $content, $context);
 	}
 
 	/**
@@ -110,58 +110,58 @@ 
 	 *
 	 * @return null|string If admin or an error occurred, returns null. Otherwise, returns entry link output. If `$atts['return']` is 'url', the entry link URL. Otherwise, entry link `<a>` HTML tag.
 	 */
-	private function shortcode( $atts, $content = null, $context = 'gv_entry_link' ) {
+	private function shortcode($atts, $content = null, $context = 'gv_entry_link') {
 
 		// Don't process when saving post. Keep processing if it's admin-ajax.php
-		if ( ! class_exists( 'GravityView_Plugin' ) || GravityView_Plugin::is_admin() ) {
+		if (!class_exists('GravityView_Plugin') || GravityView_Plugin::is_admin()) {
 			return null;
 		}
 
 		// Make sure GV is loaded
-		if ( ! class_exists( 'GravityView_frontend' ) || ! class_exists( 'GravityView_View' ) ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' GravityView_frontend or GravityView_View do not exist.' );
+		if (!class_exists('GravityView_frontend') || !class_exists('GravityView_View')) {
+			do_action('gravityview_log_error', __METHOD__.' GravityView_frontend or GravityView_View do not exist.');
 
 			return null;
 		}
 
-		$this->settings = shortcode_atts( self::$defaults, $atts, $context );
+		$this->settings = shortcode_atts(self::$defaults, $atts, $context);
 
-		$this->view_id = empty( $this->settings['view_id'] ) ? GravityView_View::getInstance()->getViewId() : absint( $this->settings['view_id'] );
+		$this->view_id = empty($this->settings['view_id']) ? GravityView_View::getInstance()->getViewId() : absint($this->settings['view_id']);
 
-		if ( empty( $this->view_id ) ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' A View ID was not defined and we are not inside a View' );
+		if (empty($this->view_id)) {
+			do_action('gravityview_log_error', __METHOD__.' A View ID was not defined and we are not inside a View');
 
 			return null;
 		}
 
-		$this->entry = $this->get_entry( $this->settings['entry_id'] );
+		$this->entry = $this->get_entry($this->settings['entry_id']);
 
-		do_action( 'gravityview_log_debug', __METHOD__ . ' ' . $context . ' $atts: ', $atts );
+		do_action('gravityview_log_debug', __METHOD__.' '.$context.' $atts: ', $atts);
 
-		if ( ! $this->has_cap() ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' User does not have the capability to ' . esc_attr( $this->settings['action'] ) . ' this entry: ' . $this->entry['id'] );
+		if (!$this->has_cap()) {
+			do_action('gravityview_log_error', __METHOD__.' User does not have the capability to '.esc_attr($this->settings['action']).' this entry: '.$this->entry['id']);
 
 			return null;
 		}
 
 		$url = $this->get_url();
 
-		if ( ! $url ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' Link returned false; View or Post may not exist.' );
+		if (!$url) {
+			do_action('gravityview_log_error', __METHOD__.' Link returned false; View or Post may not exist.');
 
 			return false;
 		}
 
 		// Get just the URL, not the tag
-		if ( 'url' === $this->settings['return'] ) {
+		if ('url' === $this->settings['return']) {
 			return $url;
 		}
 
 		$link_atts = $this->get_link_atts();
 
-		$link_text = $this->get_anchor_text( $content );
+		$link_text = $this->get_anchor_text($content);
 
-		return gravityview_get_link( $url, $link_text, $link_atts );
+		return gravityview_get_link($url, $link_text, $link_atts);
 	}
 
 	/**
@@ -174,13 +174,13 @@ 
 	 */
 	private function get_link_atts() {
 
-		wp_parse_str( $this->settings['link_atts'], $link_atts );
+		wp_parse_str($this->settings['link_atts'], $link_atts);
 
-		if ( 'delete' === $this->settings['action'] ) {
-			$link_atts['onclick'] = isset( $link_atts['onclick'] ) ? $link_atts['onclick'] : GravityView_Delete_Entry::get_confirm_dialog();
+		if ('delete' === $this->settings['action']) {
+			$link_atts['onclick'] = isset($link_atts['onclick']) ? $link_atts['onclick'] : GravityView_Delete_Entry::get_confirm_dialog();
 		}
 
-		return (array) $link_atts;
+		return (array)$link_atts;
 	}
 
 	/**
@@ -194,21 +194,21 @@ 
 	 *
 	 * @return string Text to use for HTML anchor
 	 */
-	private function get_anchor_text( $content = null ) {
+	private function get_anchor_text($content = null) {
 
-		if ( $content ) {
+		if ($content) {
 			return $content;
 		}
 
-		switch ( $this->settings['action'] ) {
+		switch ($this->settings['action']) {
 			case 'edit':
-				$anchor_text = __( 'Edit Entry', 'gravityview' );
+				$anchor_text = __('Edit Entry', 'gravityview');
 				break;
 			case 'delete':
-				$anchor_text = __( 'Delete Entry', 'gravityview' );
+				$anchor_text = __('Delete Entry', 'gravityview');
 				break;
 			default:
-				$anchor_text = __( 'View Details', 'gravityview' );
+				$anchor_text = __('View Details', 'gravityview');
 		}
 
 		return $anchor_text;
@@ -228,21 +228,21 @@ 
 	private function get_url() {
 
 		// if post_id is not defined, default to view_id
-		$post_id = empty( $this->settings['post_id'] ) ? $this->view_id : absint( $this->settings['post_id'] );
+		$post_id = empty($this->settings['post_id']) ? $this->view_id : absint($this->settings['post_id']);
 
-		switch ( $this->settings['action'] ) {
+		switch ($this->settings['action']) {
 			case 'edit':
-				$url = GravityView_Edit_Entry::get_edit_link( $this->entry, $this->view_id, $post_id );
+				$url = GravityView_Edit_Entry::get_edit_link($this->entry, $this->view_id, $post_id);
 				break;
 			case 'delete':
-				$url = GravityView_Delete_Entry::get_delete_link( $this->entry, $this->view_id, $post_id );
+				$url = GravityView_Delete_Entry::get_delete_link($this->entry, $this->view_id, $post_id);
 				break;
 			case 'read':
 			default:
-				$url = GravityView_API::entry_link( $this->entry, $post_id );
+				$url = GravityView_API::entry_link($this->entry, $post_id);
 		}
 
-		$url = $this->maybe_add_field_values_query_args( $url );
+		$url = $this->maybe_add_field_values_query_args($url);
 
 		return $url;
 	}
@@ -255,12 +255,12 @@ 
 	 */
 	private function has_cap() {
 
-		switch ( $this->settings['action'] ) {
+		switch ($this->settings['action']) {
 			case 'edit':
-				$has_cap = GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry, $this->view_id );
+				$has_cap = GravityView_Edit_Entry::check_user_cap_edit_entry($this->entry, $this->view_id);
 				break;
 			case 'delete':
-				$has_cap = GravityView_Delete_Entry::check_user_cap_delete_entry( $this->entry, array(), $this->view_id );
+				$has_cap = GravityView_Delete_Entry::check_user_cap_delete_entry($this->entry, array(), $this->view_id);
 				break;
 			case 'read':
 			default:
@@ -281,28 +281,28 @@ 
 	 *
 	 * @return array|bool Gravity Forms array, if found. Otherwise, false.
 	 */
-	private function get_entry( $entry_id = 0 ) {
+	private function get_entry($entry_id = 0) {
 
 		$backup_entry = GravityView_frontend::getInstance()->getSingleEntry() ? GravityView_frontend::getInstance()->getEntry() : GravityView_View::getInstance()->getCurrentEntry();
 
-		if ( empty( $entry_id ) ) {
-			if ( ! $backup_entry ) {
-				do_action( 'gravityview_log_error', __METHOD__ . ' No entry defined (or entry id not valid number)', $this->settings );
+		if (empty($entry_id)) {
+			if (!$backup_entry) {
+				do_action('gravityview_log_error', __METHOD__.' No entry defined (or entry id not valid number)', $this->settings);
 
 				return false;
 			}
 			$entry = $backup_entry;
 		} else {
-			$entry = wp_cache_get( 'gv_entry_link_entry_' . $entry_id, 'gravityview_entry_link_shortcode' );
-			if ( false === $entry ) {
-				$entry = GVCommon::get_entry( $entry_id, true, false );
-				wp_cache_add( 'gv_entry_link_entry_' . $entry_id, $entry, 'gravityview_entry_link_shortcode' );
+			$entry = wp_cache_get('gv_entry_link_entry_'.$entry_id, 'gravityview_entry_link_shortcode');
+			if (false === $entry) {
+				$entry = GVCommon::get_entry($entry_id, true, false);
+				wp_cache_add('gv_entry_link_entry_'.$entry_id, $entry, 'gravityview_entry_link_shortcode');
 			}
 		}
 
 		// No search results
-		if ( false === $entry ) {
-			do_action( 'gravityview_log_error', __METHOD__ . ' No entries match the entry ID defined', $entry_id );
+		if (false === $entry) {
+			do_action('gravityview_log_error', __METHOD__.' No entries match the entry ID defined', $entry_id);
 
 			return false;
 		}
@@ -318,13 +318,13 @@ 
 	 *
 	 * @param string $href URL
 	 */
-	private function maybe_add_field_values_query_args( $url ) {
+	private function maybe_add_field_values_query_args($url) {
 
-		if ( $url && ! empty( $this->settings['field_values'] ) ) {
+		if ($url && !empty($this->settings['field_values'])) {
 
-			wp_parse_str( $this->settings['field_values'], $field_values );
+			wp_parse_str($this->settings['field_values'], $field_values);
 
-			$url = add_query_arg( $field_values, $url );
+			$url = add_query_arg($field_values, $url);
 		}
 
 		return $url;

includes/class-gravityview-extension.php

Doc Comments +1 added lines, -1 removed lines

@@ -278,7 +278,7 @@
 
 	/**
 	 * Add a notice to be displayed in the admin.
-	 * @param array $notice Array with `class` and `message` keys. The message is not escaped.
+	 * @param string $notice Array with `class` and `message` keys. The message is not escaped.
 	 */
 	public static function add_notice( $notice = array() ) {
 

Indentation +7 added lines, -7 removed lines

@@ -244,13 +244,13 @@
 			$this->_remote_update_url,
 			$this->_path,
 			array(
-            	'version'	=> $this->_version, // current version number
-            	'license'	=> $license['license'],
-	            'item_id'   => $this->_item_id, // The ID of the download on _remote_update_url
-            	'item_name' => $this->_title,  // name of this plugin
-            	'author' 	=> strip_tags( $this->_author )  // author of this plugin
-          	)
-        );
+				'version'	=> $this->_version, // current version number
+				'license'	=> $license['license'],
+				'item_id'   => $this->_item_id, // The ID of the download on _remote_update_url
+				'item_name' => $this->_title,  // name of this plugin
+				'author' 	=> strip_tags( $this->_author )  // author of this plugin
+		  	)
+		);
 	}
 
 	/**

Spacing +56 added lines, -56 removed lines

@@ -69,22 +69,22 @@ 
 
 	function __construct() {
 
-		add_action( 'init', array( $this, 'load_plugin_textdomain' ) );
+		add_action('init', array($this, 'load_plugin_textdomain'));
 
-		add_action( 'admin_init', array( $this, 'settings') );
+		add_action('admin_init', array($this, 'settings'));
 
-		add_action( 'admin_notices', array( $this, 'admin_notice' ), 100 );
+		add_action('admin_notices', array($this, 'admin_notice'), 100);
 
-		add_action( 'gravityview/metaboxes/before_render', array( $this, 'add_metabox_tab' ) );
+		add_action('gravityview/metaboxes/before_render', array($this, 'add_metabox_tab'));
 
-		if( false === $this->is_extension_supported() ) {
+		if (false === $this->is_extension_supported()) {
 			return;
 		}
 
-		add_filter( 'gravityview_tooltips', array( $this, 'tooltips' ) );
+		add_filter('gravityview_tooltips', array($this, 'tooltips'));
 
 		// Save the form configuration. Run at 14 so that View metadata is already saved (at 10)
-		add_action( 'save_post', array( $this, 'save_post' ), 14 );
+		add_action('save_post', array($this, 'save_post'), 14);
 
 		$this->add_hooks();
 
@@ -116,7 +116,7 @@ 
 		$tab_settings = $this->tab_settings();
 
 		// Don't add a tab if it's empty.
-		if( empty( $tab_settings ) ) {
+		if (empty($tab_settings)) {
 			return;
 		}
 
@@ -131,20 +131,20 @@ 
 			'priority' => 'default',
 		);
 
-		$tab = wp_parse_args( $tab_settings, $tab_defaults );
+		$tab = wp_parse_args($tab_settings, $tab_defaults);
 
 		// Force the screen to be GravityView
 		$tab['screen'] = 'gravityview';
 
-		if( class_exists('GravityView_Metabox_Tab') ) {
+		if (class_exists('GravityView_Metabox_Tab')) {
 
-			$metabox = new GravityView_Metabox_Tab( $tab['id'], $tab['title'], $tab['file'], $tab['icon-class'], $tab['callback'], $tab['callback_args'] );
+			$metabox = new GravityView_Metabox_Tab($tab['id'], $tab['title'], $tab['file'], $tab['icon-class'], $tab['callback'], $tab['callback_args']);
 
-			GravityView_Metabox_Tabs::add( $metabox );
+			GravityView_Metabox_Tabs::add($metabox);
 
 		} else {
 
-			add_meta_box( 'gravityview_'.$tab['id'], $tab['title'], $tab['callback'], $tab['screen'], $tab['context'], $tab['priority'] );
+			add_meta_box('gravityview_'.$tab['id'], $tab['title'], $tab['callback'], $tab['screen'], $tab['context'], $tab['priority']);
 
 		}
 	}
@@ -160,37 +160,37 @@ 
 	 */
 	public function load_plugin_textdomain() {
 
-		if( empty( $this->_text_domain ) ) {
-			do_action( 'gravityview_log_debug', __METHOD__ . ': Extension translation cannot be loaded; the `_text_domain` variable is not defined', $this );
+		if (empty($this->_text_domain)) {
+			do_action('gravityview_log_debug', __METHOD__.': Extension translation cannot be loaded; the `_text_domain` variable is not defined', $this);
 			return;
 		}
 
 		// Backward compat for Ratings & Reviews / Maps
-		$path = isset( $this->_path ) ? $this->_path : ( isset( $this->plugin_file ) ? $this->plugin_file : '' );
+		$path = isset($this->_path) ? $this->_path : (isset($this->plugin_file) ? $this->plugin_file : '');
 
 		// Set filter for plugin's languages directory
-		$lang_dir = dirname( plugin_basename( $path ) ) . '/languages/';
+		$lang_dir = dirname(plugin_basename($path)).'/languages/';
 
 		// Traditional WordPress plugin locale filter
-		$locale = apply_filters( 'plugin_locale',  get_locale(), $this->_text_domain );
+		$locale = apply_filters('plugin_locale', get_locale(), $this->_text_domain);
 
-		$mofile = sprintf( '%1$s-%2$s.mo', $this->_text_domain, $locale );
+		$mofile = sprintf('%1$s-%2$s.mo', $this->_text_domain, $locale);
 
 		// Setup paths to current locale file
-		$mofile_local  = $lang_dir . $mofile;
-		$mofile_global = WP_LANG_DIR . '/' . $this->_text_domain . '/' . $mofile;
+		$mofile_local  = $lang_dir.$mofile;
+		$mofile_global = WP_LANG_DIR.'/'.$this->_text_domain.'/'.$mofile;
 
-		if ( file_exists( $mofile_global ) ) {
+		if (file_exists($mofile_global)) {
 			// Look in global /wp-content/languages/[plugin-dir]/ folder
-			load_textdomain( $this->_text_domain, $mofile_global );
+			load_textdomain($this->_text_domain, $mofile_global);
 		}
-		elseif ( file_exists( $mofile_local ) ) {
+		elseif (file_exists($mofile_local)) {
 			// Look in local /wp-content/plugins/[plugin-dir]/languages/ folder
-			load_textdomain( $this->_text_domain, $mofile_local );
+			load_textdomain($this->_text_domain, $mofile_local);
 		}
 		else {
 			// Load the default language files
-			load_plugin_textdomain( $this->_text_domain, false, $lang_dir );
+			load_plugin_textdomain($this->_text_domain, false, $lang_dir);
 		}
 	}
 
@@ -202,7 +202,7 @@ 
 	 */
 	protected function get_license() {
 
-		if( !class_exists( 'GravityView_Settings' ) ) {
+		if (!class_exists('GravityView_Settings')) {
 			return false;
 		}
 
@@ -219,17 +219,17 @@ 
 	public function settings() {
 
 		// If doing ajax, get outta here
-		if( ! is_admin() || ( defined( 'DOING_AJAX' ) && DOING_AJAX ) )  {
+		if (!is_admin() || (defined('DOING_AJAX') && DOING_AJAX)) {
 			return;
 		}
 
-		if( !class_exists( 'EDD_SL_Plugin_Updater' ) ) {
+		if (!class_exists('EDD_SL_Plugin_Updater')) {
 
-			$file_path = plugin_dir_path( __FILE__ ) . 'lib/EDD_SL_Plugin_Updater.php';
+			$file_path = plugin_dir_path(__FILE__).'lib/EDD_SL_Plugin_Updater.php';
 
 			// This file may be in the lib/ directory already
-			if( ! file_exists( $file_path ) ) {
-				$file_path = plugin_dir_path( __FILE__ ) . '/EDD_SL_Plugin_Updater.php';
+			if (!file_exists($file_path)) {
+				$file_path = plugin_dir_path(__FILE__).'/EDD_SL_Plugin_Updater.php';
 			}
 
 			include_once $file_path;
@@ -238,7 +238,7 @@ 
 		$license = $this->get_license();
 
 		// Don't update if invalid license.
-		if( false === $license || empty( $license['status'] ) || strtolower( $license['status'] ) !== 'valid' ) { return; }
+		if (false === $license || empty($license['status']) || strtolower($license['status']) !== 'valid') { return; }
 
 		new EDD_SL_Plugin_Updater(
 			$this->_remote_update_url,
@@ -247,8 +247,8 @@ 
             	'version'	=> $this->_version, // current version number
             	'license'	=> $license['license'],
 	            'item_id'   => $this->_item_id, // The ID of the download on _remote_update_url
-            	'item_name' => $this->_title,  // name of this plugin
-            	'author' 	=> strip_tags( $this->_author )  // author of this plugin
+            	'item_name' => $this->_title, // name of this plugin
+            	'author' 	=> strip_tags($this->_author)  // author of this plugin
           	)
         );
 	}
@@ -260,14 +260,14 @@ 
 	 */
 	public function admin_notice() {
 
-		if( empty( self::$admin_notices ) ) {
+		if (empty(self::$admin_notices)) {
 			return;
 		}
 
-		foreach( self::$admin_notices as $key => $notice ) {
+		foreach (self::$admin_notices as $key => $notice) {
 
-			echo '<div id="message" class="'. esc_attr( $notice['class'] ).'">';
-			echo wpautop( $notice['message'] );
+			echo '<div id="message" class="'.esc_attr($notice['class']).'">';
+			echo wpautop($notice['message']);
 			echo '<div class="clear"></div>';
 			echo '</div>';
 		}
@@ -280,16 +280,16 @@ 
 	 * Add a notice to be displayed in the admin.
 	 * @param array $notice Array with `class` and `message` keys. The message is not escaped.
 	 */
-	public static function add_notice( $notice = array() ) {
+	public static function add_notice($notice = array()) {
 
-		if( is_array( $notice ) && !isset( $notice['message'] ) ) {
-			do_action( 'gravityview_log_error', __CLASS__.'[add_notice] Notice not set', $notice );
+		if (is_array($notice) && !isset($notice['message'])) {
+			do_action('gravityview_log_error', __CLASS__.'[add_notice] Notice not set', $notice);
 			return;
-		} else if( is_string( $notice ) ) {
-			$notice = array( 'message' => $notice );
+		} else if (is_string($notice)) {
+			$notice = array('message' => $notice);
 		}
 
-		$notice['class'] = empty( $notice['class'] ) ? 'error' : $notice['class'];
+		$notice['class'] = empty($notice['class']) ? 'error' : $notice['class'];
 
 		self::$admin_notices[] = $notice;
 	}
@@ -304,7 +304,7 @@ 
 	 * @param  int $post_id Post ID
 	 * @return void
 	 */
-	public function save_post( $post_id ) {}
+	public function save_post($post_id) {}
 
 	/**
 	 * Add tooltips for the extension.
@@ -323,7 +323,7 @@ 
 	 * @param  array  $tooltips Existing GV tooltips, with `title` and `value` keys
 	 * @return array           Modified tooltips
 	 */
-	public function tooltips( $tooltips = array() ) {
+	public function tooltips($tooltips = array()) {
 
 		return $tooltips;
 
@@ -346,17 +346,17 @@ 
 
 		$message = '';
 
-		if( !class_exists( 'GravityView_Plugin' ) ) {
+		if (!class_exists('GravityView_Plugin')) {
 
-			$message = sprintf( __('Could not activate the %s Extension; GravityView is not active.', 'gravityview'), $this->_title );
+			$message = sprintf(__('Could not activate the %s Extension; GravityView is not active.', 'gravityview'), $this->_title);
 
-		} else if( false === version_compare(GravityView_Plugin::version, $this->_min_gravityview_version , ">=") ) {
+		} else if (false === version_compare(GravityView_Plugin::version, $this->_min_gravityview_version, ">=")) {
 
-			$message = sprintf( __('The %s Extension requires GravityView Version %s or newer.', 'gravityview' ), $this->_title, '<tt>'.$this->_min_gravityview_version.'</tt>' );
+			$message = sprintf(__('The %s Extension requires GravityView Version %s or newer.', 'gravityview'), $this->_title, '<tt>'.$this->_min_gravityview_version.'</tt>');
 
-		} else if( isset( $this->_min_php_version ) && false === version_compare( phpversion(), $this->_min_php_version , ">=") ) {
+		} else if (isset($this->_min_php_version) && false === version_compare(phpversion(), $this->_min_php_version, ">=")) {
 
-			$message = sprintf( __('The %s Extension requires PHP Version %s or newer. Please ask your host to upgrade your server\'s PHP.', 'gravityview' ), $this->_title, '<tt>'.$this->_min_php_version.'</tt>' );
+			$message = sprintf(__('The %s Extension requires PHP Version %s or newer. Please ask your host to upgrade your server\'s PHP.', 'gravityview'), $this->_title, '<tt>'.$this->_min_php_version.'</tt>');
 
 		} else {
 
@@ -364,11 +364,11 @@ 
 
 		}
 
-		if ( ! empty( $message ) ) {
+		if (!empty($message)) {
 
-			self::add_notice( $message );
+			self::add_notice($message);
 
-			do_action( 'gravityview_log_error', __METHOD__. ' ' . $message );
+			do_action('gravityview_log_error', __METHOD__.' '.$message);
 
 			self::$is_compatible = false;
 		}

Braces +2 added lines, -4 removed lines

@@ -183,12 +183,10 @@
 		if ( file_exists( $mofile_global ) ) {
 			// Look in global /wp-content/languages/[plugin-dir]/ folder
 			load_textdomain( $this->_text_domain, $mofile_global );
-		}
-		elseif ( file_exists( $mofile_local ) ) {
+		} elseif ( file_exists( $mofile_local ) ) {
 			// Look in local /wp-content/plugins/[plugin-dir]/languages/ folder
 			load_textdomain( $this->_text_domain, $mofile_local );
-		}
-		else {
+		} else {
 			// Load the default language files
 			load_plugin_textdomain( $this->_text_domain, false, $lang_dir );
 		}

includes/class-gravityview-merge-tags.php

Doc Comments +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
 	 * @param bool $url_encode Whether to URL-encode output
 	 * @param bool $esc_html Whether to apply `esc_html()` to output
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	public static function replace_gv_merge_tags(  $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
 

Spacing +45 added lines, -45 removed lines

@@ -20,7 +20,7 @@ 
 	private function add_hooks() {
 
 		/** @see GFCommon::replace_variables_prepopulate **/
-		add_filter( 'gform_replace_merge_tags', array( 'GravityView_Merge_Tags', 'replace_gv_merge_tags' ), 10, 7 );
+		add_filter('gform_replace_merge_tags', array('GravityView_Merge_Tags', 'replace_gv_merge_tags'), 10, 7);
 
 	}
 
@@ -41,7 +41,7 @@ 
 	 * @param  bool       $esc_html     Pass return value through `esc_html()`
 	 * @return string                  Text with variables maybe replaced
 	 */
-	public static function replace_variables($text, $form = array(), $entry = array(), $url_encode = false, $esc_html = true ) {
+	public static function replace_variables($text, $form = array(), $entry = array(), $url_encode = false, $esc_html = true) {
 
 		/**
 		 * @filter `gravityview_do_replace_variables` Turn off merge tag variable replacements.\n
@@ -53,9 +53,9 @@ 
 		 * @param[in]  array      $form        GF Form array
 		 * @param[in]  array      $entry        GF Entry array
 		 */
-		$do_replace_variables = apply_filters( 'gravityview/merge_tags/do_replace_variables', true, $text, $form, $entry );
+		$do_replace_variables = apply_filters('gravityview/merge_tags/do_replace_variables', true, $text, $form, $entry);
 
-		if ( strpos( $text, '{' ) === false || ! $do_replace_variables ) {
+		if (strpos($text, '{') === false || !$do_replace_variables) {
 			return $text;
 		}
 
@@ -64,11 +64,11 @@ 
 		 *
 		 * @internal Reported to GF Support on 12/3
 		 */
-		$form['title']  = isset( $form['title'] ) ? $form['title'] : '';
-		$form['id']     = isset( $form['id'] ) ? $form['id'] : '';
-		$form['fields'] = isset( $form['fields'] ) ? $form['fields'] : array();
+		$form['title']  = isset($form['title']) ? $form['title'] : '';
+		$form['id']     = isset($form['id']) ? $form['id'] : '';
+		$form['fields'] = isset($form['fields']) ? $form['fields'] : array();
 
-		return GFCommon::replace_variables( $text, $form, $entry, $url_encode, $esc_html );
+		return GFCommon::replace_variables($text, $form, $entry, $url_encode, $esc_html);
 	}
 
 	/**
@@ -86,7 +86,7 @@ 
 	 *
 	 * @return mixed
 	 */
-	public static function replace_gv_merge_tags(  $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
+	public static function replace_gv_merge_tags($text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false) {
 
 		/**
 		 * This prevents the gform_replace_merge_tags filter from being called twice, as defined in:
@@ -94,52 +94,52 @@ 
 		 * @see GFCommon::replace_variables_prepopulate()
 		 * @todo Remove eventually: Gravity Forms fixed this issue in 1.9.14
 		 */
-		if( false === $form ) {
+		if (false === $form) {
 			return $text;
 		}
 
-		$text = self::replace_get_variables( $text, $form, $entry, $url_encode );
+		$text = self::replace_get_variables($text, $form, $entry, $url_encode);
 
 		return $text;
 	}
 
-	public static function format_date( $date_created, $full_tag, $property ) {
+	public static function format_date($date_created, $full_tag, $property) {
 
-		$site_date_format  = get_option( 'date_format' );
+		$site_date_format = get_option('date_format');
 
 		/**
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
 		 * @see GFCommon::format_date()
 		 */
-		$entry_gmt_time   = mysql2date( 'G', $date_created );
-		$entry_local_timestamp = GFCommon::get_local_timestamp( $entry_gmt_time );
+		$entry_gmt_time = mysql2date('G', $date_created);
+		$entry_local_timestamp = GFCommon::get_local_timestamp($entry_gmt_time);
 
 		// Expand all modifiers, skipping escaped colons. str_replace worked better than preg_split( "/(?<!\\):/" )
-		$exploded = explode( ':', str_replace( '\:', '|COLON|', $property ) );
+		$exploded = explode(':', str_replace('\:', '|COLON|', $property));
 
-		$is_human  = in_array( 'human', $exploded ); // {date_created:human}
-		$is_diff  = in_array( 'diff', $exploded ); // {date_created:diff}
-		$is_raw = in_array( 'raw', $exploded ); // {date_created:raw}
-		$is_timestamp = in_array( 'timestamp', $exploded ); // {date_created:timestamp}
+		$is_human = in_array('human', $exploded); // {date_created:human}
+		$is_diff  = in_array('diff', $exploded); // {date_created:diff}
+		$is_raw = in_array('raw', $exploded); // {date_created:raw}
+		$is_timestamp = in_array('timestamp', $exploded); // {date_created:timestamp}
 
 		// If {date_created:raw} was specified, don't modify the stored value
-		if ( $is_raw ) {
+		if ($is_raw) {
 			$formatted_date = $date_created;
-		} elseif( $is_timestamp ) {
+		} elseif ($is_timestamp) {
 			$formatted_date = $entry_local_timestamp;
-		} elseif ( $is_diff ) {
+		} elseif ($is_diff) {
 
 			/* translators: %s is the time (seconds, hours, days, weeks, months, years) since entry was created */
-			$relative_format = self::get_format_from_modifiers( $exploded, esc_html__( '%s ago', 'gravityview' ) );
+			$relative_format = self::get_format_from_modifiers($exploded, esc_html__('%s ago', 'gravityview'));
 
-			$formatted_date = sprintf( $relative_format, human_time_diff( $entry_gmt_time ) );
+			$formatted_date = sprintf($relative_format, human_time_diff($entry_gmt_time));
 
 		} else {
 
-			$include_time = in_array( 'time', $exploded );  // {date_created:time}
-			$match_date_format = self::get_format_from_modifiers( $exploded, $site_date_format );
+			$include_time = in_array('time', $exploded); // {date_created:time}
+			$match_date_format = self::get_format_from_modifiers($exploded, $site_date_format);
 
-			$formatted_date = GFCommon::format_date( $date_created, $is_human, $match_date_format, $include_time );
+			$formatted_date = GFCommon::format_date($date_created, $is_human, $match_date_format, $include_time);
 		}
 
 		return $formatted_date;
@@ -158,16 +158,16 @@ 
 	 *
 	 * @return string If format is found, the passed format. Otherwise, the backup.
 	 */
-	private static function get_format_from_modifiers( $exploded, $backup = '' ) {
+	private static function get_format_from_modifiers($exploded, $backup = '') {
 
 		$return = $backup;
 
-		$format_key_index = array_search( 'format', $exploded );
+		$format_key_index = array_search('format', $exploded);
 
 		// If there's a "format:[php date format string]" date format, grab it
-		if ( false !== $format_key_index && isset( $exploded[ $format_key_index + 1 ] ) ) {
+		if (false !== $format_key_index && isset($exploded[$format_key_index + 1])) {
 			// Return escaped colons placeholder
-			$return = str_replace( '|COLON|', ':', $exploded[ $format_key_index + 1 ] );
+			$return = str_replace('|COLON|', ':', $exploded[$format_key_index + 1]);
 		}
 
 		return $return;
@@ -194,22 +194,22 @@ 
 	 * @param array $entry Entry array
 	 * @param bool $url_encode Whether to URL-encode output
 	 */
-	public static function replace_get_variables( $text, $form = array(), $entry = array(), $url_encode = false ) {
+	public static function replace_get_variables($text, $form = array(), $entry = array(), $url_encode = false) {
 
 		// Is there is {get:[xyz]} merge tag?
-		preg_match_all( "/{get:(.*?)}/ism", $text, $matches, PREG_SET_ORDER );
+		preg_match_all("/{get:(.*?)}/ism", $text, $matches, PREG_SET_ORDER);
 
 		// If there are no matches OR the Entry `created_by` isn't set or is 0 (no user)
-		if( empty( $matches ) ) {
+		if (empty($matches)) {
 			return $text;
 		}
 
-		foreach ( $matches as $match ) {
+		foreach ($matches as $match) {
 
 			$full_tag = $match[0];
 			$property = $match[1];
 
-			$value = stripslashes_deep( rgget( $property ) );
+			$value = stripslashes_deep(rgget($property));
 
 			/**
 			 * @filter `gravityview/merge_tags/get/glue/` Modify the glue used to convert an array of `{get}` values from an array to string
@@ -217,11 +217,11 @@ 
 			 * @param[in,out] string $glue String used to `implode()` $_GET values Default: ', '
 			 * @param[in] string $property The current name of the $_GET parameter being combined
 			 */
-			$glue = apply_filters( 'gravityview/merge_tags/get/glue/', ', ', $property );
+			$glue = apply_filters('gravityview/merge_tags/get/glue/', ', ', $property);
 
-			$value = is_array( $value ) ? implode( $glue, $value ) : $value;
+			$value = is_array($value) ? implode($glue, $value) : $value;
 
-			$value = $url_encode ? urlencode( $value ) : $value;
+			$value = $url_encode ? urlencode($value) : $value;
 
 			/**
 			 * @filter `gravityview/merge_tags/get/esc_html/{url parameter name}` Disable esc_html() from running on `{get}` merge tag
@@ -231,9 +231,9 @@ 
 			 * @since 1.15
 			 * @param bool $esc_html Whether to esc_html() the value. Default: `true`
 			 */
-			$esc_html = apply_filters('gravityview/merge_tags/get/esc_html/' . $property, true );
+			$esc_html = apply_filters('gravityview/merge_tags/get/esc_html/'.$property, true);
 
-			$value = $esc_html ? esc_html( $value ) : $value;
+			$value = $esc_html ? esc_html($value) : $value;
 
 			/**
 			 * @filter `gravityview/merge_tags/get/esc_html/{url parameter name}` Modify the value of the `{get}` replacement before being used
@@ -242,12 +242,12 @@ 
 			 * @param[in] array $form Gravity Forms form array
 			 * @param[in] array $entry Entry array
 			 */
-			$value = apply_filters('gravityview/merge_tags/get/value/' . $property, $value, $text, $form, $entry );
+			$value = apply_filters('gravityview/merge_tags/get/value/'.$property, $value, $text, $form, $entry);
 
-			$text = str_replace( $full_tag, $value, $text );
+			$text = str_replace($full_tag, $value, $text);
 		}
 
-		unset( $value, $glue, $matches );
+		unset($value, $glue, $matches);
 
 		return $text;
 	}

includes/class-gravityview-roles-capabilities.php

Doc Comments -1 removed lines

@@ -67,7 +67,6 @@
 	 *
 	 * @since 1.15
 	 *
-	 * @param array   $allcaps An array of all the user's capabilities.
 	 * @param array   $caps    Actual capabilities for meta capability.
 	 * @param array   $args    Optional parameters passed to has_cap(), typically object ID.
 	 * @param WP_User|null $user    The user object, in WordPress 3.7.0 or higher

Indentation +1 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
 		add_filter( 'members_get_capabilities', array( 'GravityView_Roles_Capabilities', 'merge_with_all_caps' ) );
 		add_action( 'members_register_cap_groups', array( $this, 'members_register_cap_group' ), 20 );
 		add_filter( 'user_has_cap', array( $this, 'filter_user_has_cap' ), 10, 4 );
-        add_action( 'admin_init', array( $this, 'add_caps') );
+		add_action( 'admin_init', array( $this, 'add_caps') );
 	}
 
 
@@ -360,7 +360,6 @@ 
 	 * Add Gravity Forms and GravityView's "full access" caps when any other caps are checked against.
 	 *
 	 * @since 1.15
-
 	 * @param array $caps_to_check
 	 *
 	 * @return array

Spacing +57 added lines, -57 removed lines

@@ -11,7 +11,7 @@ 
  */
 
 // Exit if accessed directly
-defined( 'ABSPATH' ) || exit;
+defined('ABSPATH') || exit;
 
 /**
  * GravityView Roles Class
@@ -33,7 +33,7 @@ 
 	 */
 	public static function get_instance() {
 
-		if( ! self::$instance ) {
+		if (!self::$instance) {
 			self::$instance = new self;
 		}
 
@@ -53,10 +53,10 @@ 
 	 * @since 1.15
 	 */
 	private function add_hooks() {
-		add_filter( 'members_get_capabilities', array( 'GravityView_Roles_Capabilities', 'merge_with_all_caps' ) );
-		add_action( 'members_register_cap_groups', array( $this, 'members_register_cap_group' ), 20 );
-		add_filter( 'user_has_cap', array( $this, 'filter_user_has_cap' ), 10, 4 );
-        add_action( 'admin_init', array( $this, 'add_caps') );
+		add_filter('members_get_capabilities', array('GravityView_Roles_Capabilities', 'merge_with_all_caps'));
+		add_action('members_register_cap_groups', array($this, 'members_register_cap_group'), 20);
+		add_filter('user_has_cap', array($this, 'filter_user_has_cap'), 10, 4);
+        add_action('admin_init', array($this, 'add_caps'));
 	}
 
 
@@ -74,28 +74,28 @@ 
 	 *
 	 * @return mixed
 	 */
-	public function filter_user_has_cap( $usercaps = array(), $caps = array(), $args = array(), $user = NULL ) {
+	public function filter_user_has_cap($usercaps = array(), $caps = array(), $args = array(), $user = NULL) {
 
 		// Empty caps_to_check array
-		if( ! $usercaps || ! $caps ) {
+		if (!$usercaps || !$caps) {
 			return $usercaps;
 		}
 
 		/**
 		 * Enable all GravityView caps_to_check if `gravityview_full_access` is enabled
 		 */
-		if( ! empty( $usercaps['gravityview_full_access'] ) ) {
+		if (!empty($usercaps['gravityview_full_access'])) {
 
 			$all_gravityview_caps = self::all_caps();
 
-			foreach( $all_gravityview_caps as $gv_cap ) {
-				$usercaps[ $gv_cap ] = true;
+			foreach ($all_gravityview_caps as $gv_cap) {
+				$usercaps[$gv_cap] = true;
 			}
 
-			unset( $all_gravityview_caps );
+			unset($all_gravityview_caps);
 		}
 
-		$usercaps = $this->add_gravity_forms_usercaps_to_gravityview_caps( $usercaps );
+		$usercaps = $this->add_gravity_forms_usercaps_to_gravityview_caps($usercaps);
 
 		return $usercaps;
 	}
@@ -114,7 +114,7 @@ 
 	 *
 	 * @return array
 	 */
-	private function add_gravity_forms_usercaps_to_gravityview_caps( $usercaps ) {
+	private function add_gravity_forms_usercaps_to_gravityview_caps($usercaps) {
 
 		$gf_to_gv_caps = array(
 			'gravityforms_edit_entries'     => 'gravityview_edit_others_entries',
@@ -122,9 +122,9 @@ 
 			'gravityforms_edit_entry_notes' => 'gravityview_edit_others_entry_notes',
 		);
 
-		foreach ( $gf_to_gv_caps as $gf_cap => $gv_cap ) {
-			if ( isset( $usercaps[ $gf_cap ] ) && ! isset( $usercaps[ $gv_cap ] ) ) {
-				$usercaps[ $gv_cap ] = $usercaps[ $gf_cap ];
+		foreach ($gf_to_gv_caps as $gf_cap => $gv_cap) {
+			if (isset($usercaps[$gf_cap]) && !isset($usercaps[$gv_cap])) {
+				$usercaps[$gv_cap] = $usercaps[$gf_cap];
 			}
 		}
 
@@ -138,17 +138,17 @@ 
 	 * @return void
 	 */
 	function members_register_cap_group() {
-		if ( function_exists( 'members_register_cap_group' ) ) {
+		if (function_exists('members_register_cap_group')) {
 
 			$args = array(
-				'label'         => __( 'GravityView', 'gravityview' ),
+				'label'         => __('GravityView', 'gravityview'),
 				'icon'          => 'gv-icon-astronaut-head',
 				'caps'          => self::all_caps(),
 				'merge_added'   => true,
 				'diff_added'    => false,
 			);
 
-			members_register_cap_group( 'gravityview', $args );
+			members_register_cap_group('gravityview', $args);
 		}
 	}
 
@@ -159,11 +159,11 @@ 
 	 * @param array $caps Existing capabilities
 	 * @return array Modified capabilities array
 	 */
-	public static function merge_with_all_caps( $caps ) {
+	public static function merge_with_all_caps($caps) {
 
-		$return_caps = array_merge( $caps, self::all_caps() );
+		$return_caps = array_merge($caps, self::all_caps());
 
-		return array_unique( $return_caps );
+		return array_unique($return_caps);
 	}
 
 	/**
@@ -178,7 +178,7 @@ 
 	private function wp_roles() {
 		global $wp_roles;
 
-		if ( ! isset( $wp_roles ) ) {
+		if (!isset($wp_roles)) {
 			$wp_roles = new WP_Roles();
 		}
 
@@ -196,7 +196,7 @@ 
 
 		$wp_roles = $this->wp_roles();
 
-		if ( is_object( $wp_roles ) ) {
+		if (is_object($wp_roles)) {
 
 			$_use_db_backup = $wp_roles->use_db;
 
@@ -206,11 +206,11 @@ 
 			 */
 			$wp_roles->use_db = false;
 
-			$capabilities = self::all_caps( false, false );
+			$capabilities = self::all_caps(false, false);
 
-			foreach ( $capabilities as $role_slug => $role_caps ) {
-				foreach ( $role_caps as $cap ) {
-					$wp_roles->add_cap( $role_slug, $cap );
+			foreach ($capabilities as $role_slug => $role_caps) {
+				foreach ($role_caps as $cap) {
+					$wp_roles->add_cap($role_slug, $cap);
 				}
 			}
 
@@ -219,7 +219,7 @@ 
 			 *
 			 * @see WP_Roles::add_cap() Original code
 			 */
-			update_option( $wp_roles->role_key, $wp_roles->roles );
+			update_option($wp_roles->role_key, $wp_roles->roles);
 
 			/**
 			 * Restore previous $use_db setting
@@ -240,7 +240,7 @@ 
 	 *
 	 * @return array If $role is set, flat array of caps_to_check. Otherwise, a multi-dimensional array of roles and their caps_to_check with the following keys: 'administrator', 'editor', 'author', 'contributor', 'subscriber'
 	 */
-	public static function all_caps( $single_role = false, $flat_array = true ) {
+	public static function all_caps($single_role = false, $flat_array = true) {
 
 		// Change settings
 		$administrator_caps = array(
@@ -297,20 +297,20 @@ 
 		);
 
 		$subscriber = $subscriber_caps;
-		$contributor = array_merge( $contributor_caps, $subscriber_caps );
-		$author = array_merge( $author_caps, $contributor_caps, $subscriber_caps );
-		$editor = array_merge( $editor_caps, $author_caps, $contributor_caps, $subscriber_caps );
-		$administrator = array_merge( $administrator_caps, $editor_caps, $author_caps, $contributor_caps, $subscriber_caps );
+		$contributor = array_merge($contributor_caps, $subscriber_caps);
+		$author = array_merge($author_caps, $contributor_caps, $subscriber_caps);
+		$editor = array_merge($editor_caps, $author_caps, $contributor_caps, $subscriber_caps);
+		$administrator = array_merge($administrator_caps, $editor_caps, $author_caps, $contributor_caps, $subscriber_caps);
 		$all = $administrator;
 
 		// If role is set, return caps_to_check for just that role.
-		if( $single_role ) {
-			$caps = isset( ${$single_role} ) ? ${$single_role} : false;
-			return $flat_array ? $caps : array( $single_role => $caps );
+		if ($single_role) {
+			$caps = isset(${$single_role} ) ? ${$single_role} : false;
+			return $flat_array ? $caps : array($single_role => $caps);
 		}
 
 		// Otherwise, return multi-dimensional array of all caps_to_check
-		return $flat_array ? $all : compact( 'administrator', 'editor', 'author', 'contributor', 'subscriber' );
+		return $flat_array ? $all : compact('administrator', 'editor', 'author', 'contributor', 'subscriber');
 	}
 
 	/**
@@ -330,25 +330,25 @@ 
 	 *
 	 * @return bool True: user has at least one passed capability; False: user does not have any defined capabilities
 	 */
-	public static function has_cap( $caps_to_check = '', $object_id = null, $user_id = null ) {
+	public static function has_cap($caps_to_check = '', $object_id = null, $user_id = null) {
 
 		$has_cap = false;
 
-		if( empty( $caps_to_check ) ) {
+		if (empty($caps_to_check)) {
 			return $has_cap;
 		}
 
 		// Add full access caps for GV & GF
-		$caps_to_check = self::maybe_add_full_access_caps( $caps_to_check );
+		$caps_to_check = self::maybe_add_full_access_caps($caps_to_check);
 
-		foreach ( $caps_to_check as $cap ) {
-			if( ! is_null( $object_id ) ) {
-				$has_cap = $user_id ? user_can( $user_id, $cap, $object_id ) : current_user_can( $cap, $object_id );
+		foreach ($caps_to_check as $cap) {
+			if (!is_null($object_id)) {
+				$has_cap = $user_id ? user_can($user_id, $cap, $object_id) : current_user_can($cap, $object_id);
 			} else {
-				$has_cap = $user_id ? user_can( $user_id, $cap ) : current_user_can( $cap );
+				$has_cap = $user_id ? user_can($user_id, $cap) : current_user_can($cap);
 			}
 			// At the first successful response, stop checking
-			if( $has_cap ) {
+			if ($has_cap) {
 				break;
 			}
 		}
@@ -365,25 +365,25 @@ 
 	 *
 	 * @return array
 	 */
-	public static function maybe_add_full_access_caps( $caps_to_check = array() ) {
+	public static function maybe_add_full_access_caps($caps_to_check = array()) {
 
 		$caps_to_check = (array)$caps_to_check;
 
 		$all_gravityview_caps = self::all_caps();
 
 		// Are there any $caps_to_check that are from GravityView?
-		if( $has_gravityview_caps = array_intersect( $caps_to_check, $all_gravityview_caps ) ) {
+		if ($has_gravityview_caps = array_intersect($caps_to_check, $all_gravityview_caps)) {
 			$caps_to_check[] = 'gravityview_full_access';
 		}
 
-		$all_gravity_forms_caps = class_exists( 'GFCommon' ) ? GFCommon::all_caps() : array();
+		$all_gravity_forms_caps = class_exists('GFCommon') ? GFCommon::all_caps() : array();
 
 		// Are there any $caps_to_check that are from Gravity Forms?
-		if( $all_gravity_forms_caps = array_intersect( $caps_to_check, $all_gravity_forms_caps ) ) {
+		if ($all_gravity_forms_caps = array_intersect($caps_to_check, $all_gravity_forms_caps)) {
 			$caps_to_check[] = 'gform_full_access';
 		}
 
-		return array_unique( $caps_to_check );
+		return array_unique($caps_to_check);
 	}
 
 	/**
@@ -396,19 +396,19 @@ 
 
 		$wp_roles = $this->wp_roles();
 
-		if ( is_object( $wp_roles ) ) {
+		if (is_object($wp_roles)) {
 
 			/** Remove all GravityView caps_to_check from all roles */
 			$capabilities = self::all_caps();
 
 			// Loop through each role and remove GV caps_to_check
-			foreach( $wp_roles->get_names() as $role_slug => $role_name ) {
-				foreach ( $capabilities as $cap ) {
-					$wp_roles->remove_cap( $role_slug, $cap );
+			foreach ($wp_roles->get_names() as $role_slug => $role_name) {
+				foreach ($capabilities as $cap) {
+					$wp_roles->remove_cap($role_slug, $cap);
 				}
 			}
 		}
 	}
 }
 
-add_action( 'init', array( 'GravityView_Roles_Capabilities', 'get_instance' ), 1 );
\ No newline at end of file
+add_action('init', array('GravityView_Roles_Capabilities', 'get_instance'), 1);
\ No newline at end of file

includes/class-gravityview-template.php

Doc Comments +8 added lines, -2 removed lines

@@ -37,6 +37,9 @@ 
 	public $active_areas;
 
 
+	/**
+	 * @param string $id
+	 */
 	function __construct( $id, $settings = array(), $field_options = array(), $areas = array() ) {
 
 		if ( empty( $id ) ) {
@@ -144,6 +147,9 @@ 
 		return $areas;
 	}
 
+	/**
+	 * @param string $context
+	 */
 	public function get_active_areas( $context ) {
 		if ( isset( $this->active_areas[ $context ] ) ) {
 			return $this->active_areas[ $context ];
@@ -156,8 +162,8 @@ 
 	/**
 	 * Assign template specific field options
 	 *
-	 * @param array $options (default: array())
-	 * @param string $template (default: '')
+	 * @param array $field_options (default: array())
+	 * @param string $template_id (default: '')
 	 * @param string $field_id key for the field
 	 * @param  string|array $context Context for the field; `directory` or `single` for example.
 	 *

Spacing +36 added lines, -36 removed lines

@@ -37,15 +37,15 @@ 
 	public $active_areas;
 
 
-	function __construct( $id, $settings = array(), $field_options = array(), $areas = array() ) {
+	function __construct($id, $settings = array(), $field_options = array(), $areas = array()) {
 
-		if ( empty( $id ) ) {
+		if (empty($id)) {
 			return;
 		}
 
 		$this->template_id = $id;
 
-		$this->merge_defaults( $settings );
+		$this->merge_defaults($settings);
 
 		$this->field_options = $field_options;
 		$this->active_areas  = $areas;
@@ -60,25 +60,25 @@ 
 	 */
 	private function add_hooks() {
 
-		add_filter( 'gravityview_register_directory_template', array( $this, 'register_template' ) );
+		add_filter('gravityview_register_directory_template', array($this, 'register_template'));
 
 		// presets hooks:
 		// form xml
-		add_filter( 'gravityview_template_formxml', array( $this, 'assign_form_xml' ), 10, 2 );
+		add_filter('gravityview_template_formxml', array($this, 'assign_form_xml'), 10, 2);
 		// fields config xml
-		add_filter( 'gravityview_template_fieldsxml', array( $this, 'assign_fields_xml' ), 10, 2 );
+		add_filter('gravityview_template_fieldsxml', array($this, 'assign_fields_xml'), 10, 2);
 
 		// assign active areas
-		add_filter( 'gravityview_template_active_areas', array( $this, 'assign_active_areas' ), 10, 3 );
+		add_filter('gravityview_template_active_areas', array($this, 'assign_active_areas'), 10, 3);
 
 		// field options
-		add_filter( 'gravityview_template_field_options', array( $this, 'assign_field_options' ), 10, 4 );
+		add_filter('gravityview_template_field_options', array($this, 'assign_field_options'), 10, 4);
 
 		// template slug
-		add_filter( "gravityview_template_slug_{$this->template_id}", array( $this, 'assign_view_slug' ), 10, 2 );
+		add_filter("gravityview_template_slug_{$this->template_id}", array($this, 'assign_view_slug'), 10, 2);
 
 		// register template CSS
-		add_action( 'wp_enqueue_scripts', array( $this, 'register_styles' ) );
+		add_action('wp_enqueue_scripts', array($this, 'register_styles'));
 	}
 
 	/**
@@ -90,7 +90,7 @@ 
 	 *
 	 * @return array                Merged template settings.
 	 */
-	private function merge_defaults( $settings = array() ) {
+	private function merge_defaults($settings = array()) {
 
 		$defaults = array(
 			'slug'          => '',
@@ -105,7 +105,7 @@ 
 			'preset_fields' => ''
 		);
 
-		$this->settings = wp_parse_args( $settings, $defaults );
+		$this->settings = wp_parse_args($settings, $defaults);
 
 		return $this->settings;
 	}
@@ -119,8 +119,8 @@ 
 	 *
 	 * @return array Array of templates available for GV
 	 */
-	public function register_template( $templates ) {
-		$templates[ $this->template_id ] = $this->settings;
+	public function register_template($templates) {
+		$templates[$this->template_id] = $this->settings;
 
 		return $templates;
 	}
@@ -136,17 +136,17 @@ 
 	 *
 	 * @return array Array of active areas
 	 */
-	public function assign_active_areas( $areas, $template = '', $context = 'directory' ) {
-		if ( $this->template_id === $template ) {
-			$areas = $this->get_active_areas( $context );
+	public function assign_active_areas($areas, $template = '', $context = 'directory') {
+		if ($this->template_id === $template) {
+			$areas = $this->get_active_areas($context);
 		}
 
 		return $areas;
 	}
 
-	public function get_active_areas( $context ) {
-		if ( isset( $this->active_areas[ $context ] ) ) {
-			return $this->active_areas[ $context ];
+	public function get_active_areas($context) {
+		if (isset($this->active_areas[$context])) {
+			return $this->active_areas[$context];
 		} else {
 			return $this->active_areas;
 		}
@@ -163,21 +163,21 @@ 
 	 *
 	 * @return array Array of field options
 	 */
-	public function assign_field_options( $field_options, $template_id, $field_id = NULL, $context = 'directory' ) {
+	public function assign_field_options($field_options, $template_id, $field_id = NULL, $context = 'directory') {
 
-		if ( $this->template_id === $template_id ) {
+		if ($this->template_id === $template_id) {
 
-			foreach ( $this->field_options as $key => $field_option ) {
+			foreach ($this->field_options as $key => $field_option) {
 
-				$field_context = rgar( $field_option, 'context' );
+				$field_context = rgar($field_option, 'context');
 
 				// Does the field option only apply to a certain context?
 				// You can define multiple contexts as an array:  `context => array("directory", "single")`
-				$context_matches = is_array( $field_context ) ? in_array( $context, $field_context ) : $context === $field_context;
+				$context_matches = is_array($field_context) ? in_array($context, $field_context) : $context === $field_context;
 
 				// If the context matches (or isn't defined), add the field options.
-				if ( $context_matches ) {
-					$field_options[ $key ] = $field_option;
+				if ($context_matches) {
+					$field_options[$key] = $field_option;
 				}
 			}
 		}
@@ -192,8 +192,8 @@ 
 	 * @see GravityView_Admin_Views::create_preset_form()
 	 * @return string                Path to XML file
 	 */
-	public function assign_form_xml( $xml = '', $template = '' ) {
-		if ( $this->settings['type'] === 'preset' && ! empty( $this->settings['preset_form'] ) && $this->template_id === $template ) {
+	public function assign_form_xml($xml = '', $template = '') {
+		if ($this->settings['type'] === 'preset' && !empty($this->settings['preset_form']) && $this->template_id === $template) {
 			return $this->settings['preset_form'];
 		}
 
@@ -206,8 +206,8 @@ 
 	 * @see GravityView_Admin_Views::pre_get_form_fields()
 	 * @return string                Path to XML file
 	 */
-	public function assign_fields_xml( $xml = '', $template = '' ) {
-		if ( $this->settings['type'] === 'preset' && ! empty( $this->settings['preset_fields'] ) && $this->template_id === $template ) {
+	public function assign_fields_xml($xml = '', $template = '') {
+		if ($this->settings['type'] === 'preset' && !empty($this->settings['preset_fields']) && $this->template_id === $template) {
 			return $this->settings['preset_fields'];
 		}
 
@@ -224,12 +224,12 @@ 
 	 *
 	 * @return string
 	 */
-	public function assign_view_slug( $default, $context ) {
+	public function assign_view_slug($default, $context) {
 
-		if ( ! empty( $this->settings['slug'] ) ) {
+		if (!empty($this->settings['slug'])) {
 			return $this->settings['slug'];
 		}
-		if ( ! empty( $default ) ) {
+		if (!empty($default)) {
 			return $default;
 		}
 
@@ -244,8 +244,8 @@ 
 	 * @return void
 	 */
 	public function register_styles() {
-		if ( ! empty( $this->settings['css_source'] ) ) {
-			wp_register_style( 'gravityview_style_' . $this->template_id, $this->settings['css_source'], array(), GravityView_Plugin::version, 'all' );
+		if (!empty($this->settings['css_source'])) {
+			wp_register_style('gravityview_style_'.$this->template_id, $this->settings['css_source'], array(), GravityView_Plugin::version, 'all');
 		}
 	}
 

includes/class-gv-license-handler.php

Doc Comments +4 added lines, -1 removed lines

@@ -53,6 +53,9 @@ 
 		add_action( 'wp_ajax_gravityview_license', array( $this, 'license_call' ) );
 	}
 
+	/**
+	 * @param boolean $echo
+	 */
 	function settings_edd_license_activation( $field, $echo ) {
 
 		wp_enqueue_script( 'gv-admin-edd-license', GRAVITYVIEW_URL . 'assets/js/admin-edd-license.js', array( 'jquery' ) );
@@ -241,7 +244,7 @@ 
 	 * Generate the status message box HTML based on the current status
 	 *
 	 * @since 1.7.4
-	 * @param $message
+	 * @param string $message
 	 * @param string $class
 	 *
 	 * @return string

Indentation +1 added lines, -1 removed lines

@@ -340,7 +340,7 @@
 		// Update option with passed data license
 		$settings = $this->Addon->get_app_settings();
 
-        $settings['license_key'] = $license_data->license_key = trim( $data['license'] );
+		$settings['license_key'] = $license_data->license_key = trim( $data['license'] );
 		$settings['license_key_status'] = $license_data->license;
 		$settings['license_key_response'] = (array)$license_data;
 

Spacing +86 added lines, -86 removed lines

@@ -33,14 +33,14 @@ 
 	 *
 	 * @return GV_License_Handler
 	 */
-	public static function get_instance( GravityView_Settings $GFAddOn ) {
-		if( empty( self::$instance ) ) {
-			self::$instance = new self( $GFAddOn );
+	public static function get_instance(GravityView_Settings $GFAddOn) {
+		if (empty(self::$instance)) {
+			self::$instance = new self($GFAddOn);
 		}
 		return self::$instance;
 	}
 	
-	private function __construct( GravityView_Settings $GFAddOn ) {
+	private function __construct(GravityView_Settings $GFAddOn) {
 
 		$this->Addon = $GFAddOn;
 
@@ -50,25 +50,25 @@ 
 	}
 
 	private function add_hooks() {
-		add_action( 'wp_ajax_gravityview_license', array( $this, 'license_call' ) );
+		add_action('wp_ajax_gravityview_license', array($this, 'license_call'));
 	}
 
-	function settings_edd_license_activation( $field, $echo ) {
+	function settings_edd_license_activation($field, $echo) {
 
-		wp_enqueue_script( 'gv-admin-edd-license', GRAVITYVIEW_URL . 'assets/js/admin-edd-license.js', array( 'jquery' ) );
+		wp_enqueue_script('gv-admin-edd-license', GRAVITYVIEW_URL.'assets/js/admin-edd-license.js', array('jquery'));
 
-		$status = trim( $this->Addon->get_app_setting( 'license_key_status' ) );
-		$key = trim( $this->Addon->get_app_setting( 'license_key' ) );
+		$status = trim($this->Addon->get_app_setting('license_key_status'));
+		$key = trim($this->Addon->get_app_setting('license_key'));
 
-		if( !empty( $key ) ) {
-			$response = $this->Addon->get_app_setting( 'license_key_response' );
-			$response = is_array( $response ) ? (object) $response : json_decode( $response );
+		if (!empty($key)) {
+			$response = $this->Addon->get_app_setting('license_key_response');
+			$response = is_array($response) ? (object)$response : json_decode($response);
 		} else {
 			$response = array();
 		}
 
-		wp_localize_script( 'gv-admin-edd-license', 'GVGlobals', array(
-			'license_box' => $this->get_license_message( $response )
+		wp_localize_script('gv-admin-edd-license', 'GVGlobals', array(
+			'license_box' => $this->get_license_message($response)
 		));
 
 
@@ -85,7 +85,7 @@ 
 				'value' => __('Deactivate License', 'gravityview'),
 				'data-pending_text' => __('Deactivating license…', 'gravityview'),
 				'data-edd_action' => 'deactivate_license',
-				'class' => ( empty( $status ) ? 'button-primary hide' : 'button-primary' ),
+				'class' => (empty($status) ? 'button-primary hide' : 'button-primary'),
 			),
 			array(
 				'name'  => 'edd-check',
@@ -100,19 +100,19 @@ 
 
 		$class = 'button gv-edd-action';
 
-		$class .= ( !empty( $key ) && $status !== 'valid' ) ? '' : ' hide';
+		$class .= (!empty($key) && $status !== 'valid') ? '' : ' hide';
 
-		$disabled_attribute = GVCommon::has_cap( 'gravityview_edit_settings' ) ? false : 'disabled';
+		$disabled_attribute = GVCommon::has_cap('gravityview_edit_settings') ? false : 'disabled';
 
 		$submit = '<div class="gv-edd-button-wrapper">';
-		foreach ( $fields as $field ) {
+		foreach ($fields as $field) {
 			$field['type'] = 'button';
-			$field['class'] = isset( $field['class'] ) ? $field['class'] . ' '. $class : $class;
+			$field['class'] = isset($field['class']) ? $field['class'].' '.$class : $class;
 			$field['style'] = 'margin-left: 10px;';
-			if( $disabled_attribute ) {
+			if ($disabled_attribute) {
 				$field['disabled'] = $disabled_attribute;
 			}
-			$submit .= $this->Addon->settings_submit( $field, $echo );
+			$submit .= $this->Addon->settings_submit($field, $echo);
 		}
 		$submit .= '</div>';
 
@@ -126,8 +126,8 @@ 
 	 */
 	private function setup_edd() {
 
-		if( !class_exists('EDD_SL_Plugin_Updater') ) {
-			require_once( GRAVITYVIEW_DIR . 'includes/lib/EDD_SL_Plugin_Updater.php');
+		if (!class_exists('EDD_SL_Plugin_Updater')) {
+			require_once(GRAVITYVIEW_DIR.'includes/lib/EDD_SL_Plugin_Updater.php');
 		}
 
 		// setup the updater
@@ -149,10 +149,10 @@ 
 	 *
 	 * @return array
 	 */
-	function _get_edd_settings( $action = '', $license = '' ) {
+	function _get_edd_settings($action = '', $license = '') {
 
 		// retrieve our license key from the DB
-		$license_key = empty( $license ) ? trim( $this->Addon->get_app_setting( 'license_key' ) ) : $license;
+		$license_key = empty($license) ? trim($this->Addon->get_app_setting('license_key')) : $license;
 
 		$settings = array(
 			'version'   => self::version,
@@ -163,11 +163,11 @@ 
 			'url'       => home_url(),
 		);
 
-		if( !empty( $action ) ) {
-			$settings['edd_action'] = esc_attr( $action );
+		if (!empty($action)) {
+			$settings['edd_action'] = esc_attr($action);
 		}
 
-		$settings = array_map( 'urlencode', $settings );
+		$settings = array_map('urlencode', $settings);
 
 		return $settings;
 	}
@@ -176,27 +176,27 @@ 
 	 * Perform the call
 	 * @return array|WP_Error
 	 */
-	private function _license_get_remote_response( $data, $license = '' ) {
+	private function _license_get_remote_response($data, $license = '') {
 
-		$api_params = $this->_get_edd_settings( $data['edd_action'], $license );
+		$api_params = $this->_get_edd_settings($data['edd_action'], $license);
 
-		$url = add_query_arg( $api_params, self::url );
+		$url = add_query_arg($api_params, self::url);
 
-		$response = wp_remote_get( $url, array(
+		$response = wp_remote_get($url, array(
 			'timeout'   => 15,
 			'sslverify' => false,
 		));
 
-		if ( is_wp_error( $response ) ) {
+		if (is_wp_error($response)) {
 			return array();
 		}
 
-		$license_data = json_decode( wp_remote_retrieve_body( $response ) );
+		$license_data = json_decode(wp_remote_retrieve_body($response));
 
 		// Not JSON
-		if ( empty( $license_data ) ) {
+		if (empty($license_data)) {
 
-			delete_transient( 'gravityview_' . esc_attr( $data['field_id'] ) . '_valid' );
+			delete_transient('gravityview_'.esc_attr($data['field_id']).'_valid');
 
 			// Change status
 			return array();
@@ -216,14 +216,14 @@ 
 	 *
 	 * @return string
 	 */
-	function get_license_message( $license_data ) {
+	function get_license_message($license_data) {
 
-		if( empty( $license_data ) ) {
+		if (empty($license_data)) {
 			$class = 'hide';
 			$message = '';
 		} else {
 
-			if( ! empty( $license_data->error ) ) {
+			if (!empty($license_data->error)) {
 				$class = 'error';
 				$string_key = $license_data->error;
 			} else {
@@ -231,10 +231,10 @@ 
 				$string_key = $license_data->license;
 			}
 
-			$message = sprintf( '<p><strong>%s: %s</strong></p>', $this->strings('status'), $this->strings( $string_key, $license_data ) );
+			$message = sprintf('<p><strong>%s: %s</strong></p>', $this->strings('status'), $this->strings($string_key, $license_data));
 		}
 
-		return $this->generate_license_box( $message, $class );
+		return $this->generate_license_box($message, $class);
 	}
 
 	/**
@@ -246,11 +246,11 @@ 
 	 *
 	 * @return string
 	 */
-	private function generate_license_box( $message, $class = '' ) {
+	private function generate_license_box($message, $class = '') {
 
 		$template = '<div id="gv-edd-status" class="gv-edd-message inline %s">%s</div>';
 
-		$output = sprintf( $template, esc_attr( $class ), $message );
+		$output = sprintf($template, esc_attr($class), $message);
 
 		return $output;
 	}
@@ -270,63 +270,63 @@ 
 	 *
 	 * @return mixed|string|void
 	 */
-	public function license_call( $array = array() ) {
+	public function license_call($array = array()) {
 
-		$is_ajax = ( defined('DOING_AJAX') && DOING_AJAX );
-		$data = empty( $array ) ? $_POST['data'] : $array;
-		$has_cap = GVCommon::has_cap( 'gravityview_edit_settings' );
+		$is_ajax = (defined('DOING_AJAX') && DOING_AJAX);
+		$data = empty($array) ? $_POST['data'] : $array;
+		$has_cap = GVCommon::has_cap('gravityview_edit_settings');
 
-		if ( $is_ajax && empty( $data['license'] ) ) {
-			die( - 1 );
+		if ($is_ajax && empty($data['license'])) {
+			die( -1 );
 		}
 
 		// If the user isn't allowed to edit settings, show an error message
-		if( ! $has_cap ) {
+		if (!$has_cap) {
 			$license_data = new stdClass();
 			$license_data->error = 'capability';
-			$license_data->message = $this->get_license_message( $license_data );
-			$json = json_encode( $license_data );
+			$license_data->message = $this->get_license_message($license_data);
+			$json = json_encode($license_data);
 		} else {
 
-			$license      = esc_attr( rgget( 'license', $data ) );
-			$license_data = $this->_license_get_remote_response( $data, $license );
+			$license      = esc_attr(rgget('license', $data));
+			$license_data = $this->_license_get_remote_response($data, $license);
 
 			// Empty is returned when there's an error.
-			if ( empty( $license_data ) ) {
-				if ( $is_ajax ) {
-					exit( json_encode( array() ) );
+			if (empty($license_data)) {
+				if ($is_ajax) {
+					exit(json_encode(array()));
 				} else { // Non-ajax call
-					return json_encode( array() );
+					return json_encode(array());
 				}
 			}
 
-			$license_data->message = $this->get_license_message( $license_data );
+			$license_data->message = $this->get_license_message($license_data);
 
-			$json = json_encode( $license_data );
+			$json = json_encode($license_data);
 
-			$update_license = ( ! isset( $data['update'] ) || ! empty( $data['update'] ) );
+			$update_license = (!isset($data['update']) || !empty($data['update']));
 
-			$is_check_action_button = ( 'check_license' === $data['edd_action'] && defined( 'DOING_AJAX' ) && DOING_AJAX );
+			$is_check_action_button = ('check_license' === $data['edd_action'] && defined('DOING_AJAX') && DOING_AJAX);
 
 			// Failed is the response from trying to de-activate a license and it didn't work.
 			// This likely happened because people entered in a different key and clicked "Deactivate",
 			// meaning to deactivate the original key. We don't want to save this response, since it is
 			// most likely a mistake.
-			if ( $license_data->license !== 'failed' && ! $is_check_action_button && $update_license ) {
+			if ($license_data->license !== 'failed' && !$is_check_action_button && $update_license) {
 
-				if ( ! empty( $data['field_id'] ) ) {
-					set_transient( 'gravityview_' . esc_attr( $data['field_id'] ) . '_valid', $license_data, DAY_IN_SECONDS );
+				if (!empty($data['field_id'])) {
+					set_transient('gravityview_'.esc_attr($data['field_id']).'_valid', $license_data, DAY_IN_SECONDS);
 				}
 
-				$this->license_call_update_settings( $license_data, $data );
+				$this->license_call_update_settings($license_data, $data);
 
 			}
 		} // End $has_cap
 
-		if ( $is_ajax ) {
-			exit( $json );
+		if ($is_ajax) {
+			exit($json);
 		} else { // Non-ajax call
-			return ( rgget('format', $data ) === 'object' ) ? $license_data : $json;
+			return (rgget('format', $data) === 'object') ? $license_data : $json;
 		}
 	}
 
@@ -335,16 +335,16 @@ 
 	 * @param object $license_data
 	 * @return void
 	 */
-	private function license_call_update_settings( $license_data, $data ) {
+	private function license_call_update_settings($license_data, $data) {
 
 		// Update option with passed data license
 		$settings = $this->Addon->get_app_settings();
 
-        $settings['license_key'] = $license_data->license_key = trim( $data['license'] );
+        $settings['license_key'] = $license_data->license_key = trim($data['license']);
 		$settings['license_key_status'] = $license_data->license;
 		$settings['license_key_response'] = (array)$license_data;
 
-		$this->Addon->update_app_settings( $settings );
+		$this->Addon->update_app_settings($settings);
 	}
 
 	/**
@@ -353,8 +353,8 @@ 
 	 * @param  object|null $license_data Object with license data
 	 * @return string Renewal or account URL
 	 */
-	private function get_license_renewal_url( $license_data ) {
-		$renew_license_url = ( ! empty( $license_data ) && !empty( $license_data->license_key ) ) ? sprintf( 'https://gravityview.co/checkout/?download_id=17&edd_license_key=%s&utm_source=admin_notice&utm_medium=admin&utm_content=expired&utm_campaign=Activation', $license_data->license_key ) : 'https://gravityview.co/account/';
+	private function get_license_renewal_url($license_data) {
+		$renew_license_url = (!empty($license_data) && !empty($license_data->license_key)) ? sprintf('https://gravityview.co/checkout/?download_id=17&edd_license_key=%s&utm_source=admin_notice&utm_medium=admin&utm_content=expired&utm_campaign=Activation', $license_data->license_key) : 'https://gravityview.co/account/';
 		return $renew_license_url;
 	}
 
@@ -364,7 +364,7 @@ 
 	 * @param  object|null $license_data Object with license data
 	 * @return array          Modified array of content
 	 */
-	public function strings( $status = NULL, $license_data = null ) {
+	public function strings($status = NULL, $license_data = null) {
 
 
 		$strings = array(
@@ -372,14 +372,14 @@ 
 			'error' => esc_html__('There was an error processing the request.', 'gravityview'),
 			'failed'  => esc_html__('Could not deactivate the license. The license key you attempted to deactivate may not be active or valid.', 'gravityview'),
 			'site_inactive' => esc_html__('The license key is valid, but it has not been activated for this site.', 'gravityview'),
-			'no_activations_left' => esc_html__('Invalid: this license has reached its activation limit.', 'gravityview') . ' ' . sprintf( esc_html__('You can manage license activations %son your GravityView account page%s.', 'gravityview'), '<a href="https://gravityview.co/account/#licenses">', '</a>' ),
+			'no_activations_left' => esc_html__('Invalid: this license has reached its activation limit.', 'gravityview').' '.sprintf(esc_html__('You can manage license activations %son your GravityView account page%s.', 'gravityview'), '<a href="https://gravityview.co/account/#licenses">', '</a>'),
 			'deactivated' => esc_html__('The license has been deactivated.', 'gravityview'),
 			'valid' => esc_html__('The license key is valid and active.', 'gravityview'),
 			'invalid' => esc_html__('The license key entered is invalid.', 'gravityview'),
 			'missing' => esc_html__('The license key was not defined.', 'gravityview'),
 			'revoked' => esc_html__('This license key has been revoked.', 'gravityview'),
-			'expired' => sprintf( esc_html__('This license key has expired. %sRenew your license on the GravityView website%s to receive updates and support.', 'gravityview'), '<a href="'. esc_url( $this->get_license_renewal_url( $license_data ) ) .'">', '</a>' ),
-			'capability' => esc_html__( 'You don\'t have the ability to edit plugin settings.', 'gravityview' ),
+			'expired' => sprintf(esc_html__('This license key has expired. %sRenew your license on the GravityView website%s to receive updates and support.', 'gravityview'), '<a href="'.esc_url($this->get_license_renewal_url($license_data)).'">', '</a>'),
+			'capability' => esc_html__('You don\'t have the ability to edit plugin settings.', 'gravityview'),
 
 			'verifying_license' => esc_html__('Verifying license&hellip;', 'gravityview'),
 			'activate_license' => esc_html__('Activate License', 'gravityview'),
@@ -387,33 +387,33 @@ 
 			'check_license' => esc_html__('Verify License', 'gravityview'),
 		);
 
-		if( empty( $status ) ) {
+		if (empty($status)) {
 			return $strings;
 		}
 
-		if( isset( $strings[ $status ] ) ) {
-			return $strings[ $status ];
+		if (isset($strings[$status])) {
+			return $strings[$status];
 		}
 
 		return NULL;
 	}
 
-	public function validate_license_key( $value, $field ) {
+	public function validate_license_key($value, $field) {
 
 		// No license? No status.
-		if( empty( $value ) ) {
+		if (empty($value)) {
 			return NULL;
 		}
 
 		$response = $this->license_call(array(
-			'license' => $this->Addon->get_app_setting( 'license_key' ),
+			'license' => $this->Addon->get_app_setting('license_key'),
 			'edd_action' => 'check_license',
 			'field_id' => $field['name'],
 		));
 
-		$response = is_string( $response ) ? json_decode( $response, true ) : $response;
+		$response = is_string($response) ? json_decode($response, true) : $response;
 
-		switch( $response['license'] ) {
+		switch ($response['license']) {
 			case 'valid':
 				$return = true;
 				break;

includes/class-gvlogic-shortcode.php

Doc Comments +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 	 * Does the if and the comparison match?
 	 * @uses GVCommon::matches_operation
 	 *
-	 * @return boolean True: yep; false: nope
+	 * @return boolean|null True: yep; false: nope
 	 */
 	function set_is_match() {
 		$this->is_match = GVCommon::matches_operation( $this->if, $this->comparison, $this->operation );

Spacing +38 added lines, -38 removed lines

@@ -5,13 +5,13 @@ 
  */
 class GVLogic_Shortcode {
 
-	private static $SUPPORTED_SCALAR_OPERATORS = array( 'is', 'isnot', 'contains', 'starts_with', 'ends_with' );
+	private static $SUPPORTED_SCALAR_OPERATORS = array('is', 'isnot', 'contains', 'starts_with', 'ends_with');
 
-	private static $SUPPORTED_NUMERIC_OPERATORS = array( 'greater_than', 'less_than' );
+	private static $SUPPORTED_NUMERIC_OPERATORS = array('greater_than', 'less_than');
 
-	private static $SUPPORTED_ARRAY_OPERATORS = array( 'in', 'not_in', 'isnot', 'contains' );
+	private static $SUPPORTED_ARRAY_OPERATORS = array('in', 'not_in', 'isnot', 'contains');
 
-	private static $SUPPORTED_CUSTOM_OPERATORS = array( 'equals', 'greater_than_or_is', 'greater_than_or_equals', 'less_than_or_is', 'less_than_or_equals', 'not_contains' );
+	private static $SUPPORTED_CUSTOM_OPERATORS = array('equals', 'greater_than_or_is', 'greater_than_or_equals', 'less_than_or_is', 'less_than_or_equals', 'not_contains');
 
 	/**
 	 * Attributes passed to the shortcode
@@ -85,7 +85,7 @@ 
 	 */
 	public static function get_instance() {
 
-		if( empty( self::$instance ) ) {
+		if (empty(self::$instance)) {
 			self::$instance = new self;
 		}
 
@@ -105,7 +105,7 @@ 
 	 * @return void
 	 */
 	function add_hooks() {
-		add_shortcode( 'gvlogic', array( $this, 'shortcode' ) );
+		add_shortcode('gvlogic', array($this, 'shortcode'));
 	}
 
 	/**
@@ -114,14 +114,14 @@ 
 	 *
 	 * @return array
 	 */
-	function get_operators( $with_values = false ) {
+	function get_operators($with_values = false) {
 
-		$operators = array_merge( self::$SUPPORTED_ARRAY_OPERATORS, self::$SUPPORTED_NUMERIC_OPERATORS, self::$SUPPORTED_SCALAR_OPERATORS, self::$SUPPORTED_CUSTOM_OPERATORS );
+		$operators = array_merge(self::$SUPPORTED_ARRAY_OPERATORS, self::$SUPPORTED_NUMERIC_OPERATORS, self::$SUPPORTED_SCALAR_OPERATORS, self::$SUPPORTED_CUSTOM_OPERATORS);
 
-		if( $with_values ) {
+		if ($with_values) {
 			$operators_with_values = array();
-			foreach( $operators as $key ) {
-				$operators_with_values[ $key ] = '';
+			foreach ($operators as $key) {
+				$operators_with_values[$key] = '';
 			}
 			return $operators_with_values;
 		} else {
@@ -135,16 +135,16 @@ 
 	 *
 	 * @return bool True: it's an allowed operation type and was added. False: invalid operation type
 	 */
-	function set_operation( $operation = '' ) {
+	function set_operation($operation = '') {
 
-		if( empty( $operation ) ) {
+		if (empty($operation)) {
 			return false;
 		}
 
-		$operators = $this->get_operators( false );
+		$operators = $this->get_operators(false);
 
-		if( !in_array( $operation, $operators ) ) {
-			do_action( 'gravityview_log_debug', __METHOD__ .' Attempted to add invalid operation type.', $operation );
+		if (!in_array($operation, $operators)) {
+			do_action('gravityview_log_debug', __METHOD__.' Attempted to add invalid operation type.', $operation);
 			return false;
 		}
 
@@ -164,11 +164,11 @@ 
 	 */
 	function setup_operation_and_comparison() {
 
-		foreach( $this->atts as $key => $value ) {
+		foreach ($this->atts as $key => $value) {
 
-			$valid = $this->set_operation( $key );
+			$valid = $this->set_operation($key);
 
-			if( $valid ) {
+			if ($valid) {
 				$this->comparison = $value;
 				return true;
 			}
@@ -184,10 +184,10 @@ 
 	 *
 	 * @return string|null
 	 */
-	public function shortcode( $atts = array(), $content = NULL, $shortcode_tag = '' ) {
+	public function shortcode($atts = array(), $content = NULL, $shortcode_tag = '') {
 
 		// Don't process except on frontend
-		if ( GravityView_Plugin::is_admin() ) {
+		if (GravityView_Plugin::is_admin()) {
 			return null;
 		}
 
@@ -198,16 +198,16 @@ 
 		$this->parse_atts();
 
 		// We need an "if"
-		if( false === $this->if ) {
-			do_action( 'gravityview_log_error', __METHOD__.' $atts->if is empty.', $this->atts );
+		if (false === $this->if) {
+			do_action('gravityview_log_error', __METHOD__.' $atts->if is empty.', $this->atts);
 			return null;
 		}
 
 		$setup = $this->setup_operation_and_comparison();
 
 		// We need an operation and comparison value
-		if( ! $setup ) {
-			do_action( 'gravityview_log_error', __METHOD__.' No valid operators were passed.', $this->atts );
+		if (!$setup) {
+			do_action('gravityview_log_error', __METHOD__.' No valid operators were passed.', $this->atts);
 			return null;
 		}
 
@@ -228,7 +228,7 @@ 
 	 * @return boolean True: yep; false: nope
 	 */
 	function set_is_match() {
-		$this->is_match = GVCommon::matches_operation( $this->if, $this->comparison, $this->operation );
+		$this->is_match = GVCommon::matches_operation($this->if, $this->comparison, $this->operation);
 	}
 
 	/**
@@ -238,23 +238,23 @@ 
 	 */
 	function get_output() {
 
-		if( $this->is_match ) {
+		if ($this->is_match) {
 			$output = $this->content;
 		} else {
 			$output = $this->else_content;
 		}
 
 		// Get recursive!
-		$output = do_shortcode( $output );
+		$output = do_shortcode($output);
 
 		/**
 		 * @filter `gravityview/gvlogic/output` Modify the [gvlogic] output
 		 * @param string $output HTML/text output
 		 * @param GVLogic_Shortcode $this This class
 		 */
-		$output = apply_filters('gravityview/gvlogic/output', $output, $this );
+		$output = apply_filters('gravityview/gvlogic/output', $output, $this);
 
-		do_action( 'gravityview_log_debug', __METHOD__ .' Output: ', $output );
+		do_action('gravityview_log_debug', __METHOD__.' Output: ', $output);
 
 		return $output;
 	}
@@ -268,13 +268,13 @@ 
 	 */
 	function set_content_and_else_content() {
 
-		$content = explode( '[else]', $this->passed_content );
+		$content = explode('[else]', $this->passed_content);
 
 		$this->content = $content[0];
 
-		$else_attr = isset( $this->atts['else'] ) ? $this->atts['else'] : NULL;
+		$else_attr = isset($this->atts['else']) ? $this->atts['else'] : NULL;
 
-		$this->else_content = isset( $content[1] ) ? $content[1] : $else_attr;
+		$this->else_content = isset($content[1]) ? $content[1] : $else_attr;
 	}
 
 	/**
@@ -288,19 +288,19 @@ 
 			'else' => false,
 		);
 
-		$supported_args = $supported + $this->get_operators( true );
+		$supported_args = $supported + $this->get_operators(true);
 
 		// Whittle down the attributes to only valid pairs
-		$this->atts = shortcode_atts( $supported_args, $this->passed_atts, $this->shortcode );
+		$this->atts = shortcode_atts($supported_args, $this->passed_atts, $this->shortcode);
 
 		// Only keep the passed attributes after making sure that they're valid pairs
-		$this->atts = function_exists( 'array_intersect_key' ) ? array_intersect_key( $this->passed_atts, $this->atts ) : $this->atts;
+		$this->atts = function_exists('array_intersect_key') ? array_intersect_key($this->passed_atts, $this->atts) : $this->atts;
 
 		// Strip whitespace if it's not default false
-		$this->if = is_string( $this->atts['if'] ) ? trim( $this->atts['if'] ) : false;
+		$this->if = is_string($this->atts['if']) ? trim($this->atts['if']) : false;
 
 		// Make sure the "if" isn't processed in self::setup_operation_and_comparison()
-		unset( $this->atts['if'] );
+		unset($this->atts['if']);
 	}
 }