Completed
Pull Request — master (#1313)
by Zack
45:51 queued 36:57
created

Field_Template::render()   C

Complexity

Conditions 12
Paths 144

Size

Total Lines 221

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 55
CRAP Score 12.0062

Importance

Changes 0
Metric Value
cc 12
nc 144
nop 0
dl 0
loc 221
ccs 55
cts 57
cp 0.9649
crap 12.0062
rs 5.28
c 0
b 0
f 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 23 and the first side effect is on line 6.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
namespace GV;
3
4
/** If this file is called directly, abort. */
5
if ( ! defined( 'GRAVITYVIEW_DIR' ) ) {
6
	die();
7
}
8
9
/**
10
 * Load up the Gamajo Template Loader.
11
 *
12
 * @see https://github.com/GaryJones/Gamajo-Template-Loader
13
 */
14
if ( ! class_exists( '\GV\Gamajo_Template_Loader' ) ) {
15
	require gravityview()->plugin->dir( 'future/lib/class-gamajo-template-loader.php' );
16
}
17
18
/**
19
 * The Field Template class.
20
 *
21
 * Attached to a \GV\Field and used by a \GV\Field_Renderer.
22
 */
23
abstract class Field_Template extends Template {
24
	/**
25
	 * Prefix for filter names.
26
	 * @var string
27
	 */
28
	protected $filter_prefix = 'gravityview/template/fields';
29
30
	/**
31
	 * Directory name where custom templates for this plugin should be found in the theme.
32
	 * @var string
33
	 */
34
	protected $theme_template_directory = 'gravityview/fields/';
35
36
	/**
37
	 * Directory name where the default templates for this plugin are found.
38
	 * @var string
39
	 */
40
	protected $plugin_template_directory = 'templates/fields/';
41
42
	/**
43
	 * @var \GV\Field The field connected to this template.
44
	 */
45
	public $field;
46
47
	/**
48
	 * @var \GV\View The view context.
49
	 */
50
	public $view;
51
52
	/**
53
	 * @var \GV\Source The source context.
54
	 */
55
	public $source;
56
57
	/**
58
	 * @var \GV\Entry The entry context.
59
	 */
60
	public $entry;
61
62
	/**
63
	 * @var \GV\Request The request context.
64
	 */
65
	public $request;
66
67
	/**
68
	 * @var string The template slug to be loaded (like "table", "list")
69
	 */
70
	public static $slug;
71
72
	/**
73
	 * Initializer.
74
	 *
75
	 * @param \GV\Field $field The field about to be rendered.
76
	 * @param \GV\View $view The view in this context, if applicable.
77
	 * @param \GV\Source $source The source (form) in this context, if applicable.
78
	 * @param \GV\Entry $entry The entry in this context, if applicable.
79
	 * @param \GV\Request $request The request in this context, if applicable.
80
	 */
81 87
	public function __construct( Field $field, View $view = null, Source $source = null, Entry $entry = null, Request $request = null ) {
82 87
		$this->field = $field;
83 87
		$this->view = $view;
84 87
		$this->source = $source;
85 87
		$this->entry = $entry;
86 87
		$this->request = $request;
87
88
		/** Add granular overrides. */
89 87
		add_filter( $this->filter_prefix . '_get_template_part', $this->_add_id_specific_templates_callback = self::add_id_specific_templates( $this ), 10, 3 );
0 ignored issues
show
Bug introduced by
The property _add_id_specific_templates_callback does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
90
91 87
		parent::__construct();
92 87
	}
93
94 87
	public function __destruct() {
95 87
		remove_filter( $this->filter_prefix . '_get_template_part', $this->_add_id_specific_templates_callback );;
96 87
	}
97
98
	/**
99
	 * Enable granular template overrides based on current post, view, form, field types, etc.
100
	 *
101
	 * Why? See https://github.com/gravityview/GravityView/issues/1024
102
	 *
103
	 * @param \GV\Field_Template $template The template instance.
104
	 * @return callable The callback bound to `get_template_part`. See `\GV\Field_Template::__construct`
105
	 */
106 87
	public static function add_id_specific_templates( $template ) {
107
108 87
		$inputType  = null;
109 87
		$field_type = null;
110 87
		$field_id   = null;
111 87
		$view_id    = null;
112 87
		$form_id    = null;
113 87
		$is_view    = $template->request && $template->request->is_view();
114
115 87
		if ( $template->field ) {
116 87
			$inputType  = $template->field->inputType;
0 ignored issues
show
Bug introduced by
The property inputType does not seem to exist in GV\Field.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
117 87
			$field_type = $template->field->type;
0 ignored issues
show
Bug introduced by
The property type does not seem to exist in GV\Field.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
118 87
			$field_id   = $template->field->ID;
119
		}
120
121 87
		if ( $template->view ) {
122 87
			$view_id = $template->view->ID;
0 ignored issues
show
Bug introduced by
The property ID does not seem to exist in GV\View.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
123 87
			$form_id = $template->view->form ? $template->view->form->ID : null;
124
		}
125
126 87
		$class = get_class( $template );
127
128
		/**
129
		 * Enable granular template overrides based on current post, view, form, field types, etc.
130
		 *
131
		 * The hierarchy is as follows:
132
		 *
133
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field-[Field type]-html.php
134
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field-[Field inputType]-html.php
135
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field-html.php
136
		 * - post-[ID of post of page where view is embedded]-field-[Field type]-html.php
137
		 * - post-[ID of post of page where view is embedded]-field-[Field inputType]-html.php
138
		 * - post-[ID of post of page where view is embedded]-field-html.php
139
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field-[Field type].php
140
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field-[Field inputType].php
141
		 * - post-[ID of post of page where view is embedded]-view-[View ID]-field.php
142
		 * - post-[ID of post of page where view is embedded]-field-[Field type].php
143
		 * - post-[ID of post of page where view is embedded]-field-[Field inputType].php
144
		 * - post-[ID of post of page where view is embedded]-field.php
145
		 * - form-[Form ID]-field-[Field ID]-html.php
146
		 * - form-[Form ID]-field-[Field ID].php
147
		 * - form-[Form ID]-field-[Field type]-html.php
148
		 * - form-[Form ID]-field-[Field inputType]-html.php
149
		 * - form-[Form ID]-field-[Field type].php
150
		 * - form-[Form ID]-field-[Field inputType].php
151
		 * - view-[View ID]-field-[Field type]-html.php
152
		 * - view-[View ID]-field-[Field inputType]-html.php
153
		 * - view-[View ID]-field-[Field type].php
154
		 * - view-[View ID]-field-[Field inputType].php
155
		 * - field-[Field type]-html.php
156
		 * - field-[Field inputType]-html.php
157
		 * - field-[Field type].php
158
		 * - field-[Field inputType].php
159
		 * - field-html.php
160
		 * - field.php
161
		 *
162
		 * @see  Gamajo_Template_Loader::get_template_file_names() Where the filter is
163
		 * @param array $templates Existing list of templates.
164
		 * @param string $slug      Name of the template base, example: `html`, `json`, `xml`
165
		 * @param string $name      Name of the template part.
166
		 *
167
		 * @return array $templates Modified template array, merged with existing $templates values
168
		 */
169 87
		return function( $templates, $slug, $name ) use ( $class, $inputType, $field_type, $view_id, $is_view, $form_id, $field_id ) {
170 87
			$specifics = array();
171
172 87
			list( $slug_dir, $slug_name ) = $class::split_slug( $slug, $name );
173
174 87
			global $post;
0 ignored issues
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
175
176 87
			if ( $is_view && $post ) {
177 8
				if ( $field_type ) {
178 8
					$specifics []= sprintf( '%spost-%d-view-%d-field-%s-%s.php', $slug_dir, $post->ID, $view_id, $field_type, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
179 8
					$inputType && $specifics []= sprintf( '%spost-%d-view-%d-field-%s-%s.php', $slug_dir, $post->ID, $view_id, $inputType, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
180 8
					$specifics []= sprintf( '%spost-%d-view-%d-field-%s.php', $slug_dir, $post->ID, $view_id, $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
181 8
					$inputType && $specifics []= sprintf( '%spost-%d-view-%d-field-%s.php', $slug_dir, $post->ID, $view_id, $inputType );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
182 8
					$specifics []= sprintf( '%spost-%d-field-%s-%s.php', $slug_dir, $post->ID, $field_type, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
183 8
					$inputType && $specifics []= sprintf( '%spost-%d-field-%s-%s.php', $slug_dir, $post->ID, $inputType, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
184 8
					$specifics []= sprintf( '%spost-%d-field-%s.php', $slug_dir, $post->ID, $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
185 8
					$inputType &&  $specifics []= sprintf( '%spost-%d-field-%s.php', $slug_dir, $post->ID, $inputType );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
186
				}
187
188 8
				$specifics []= sprintf( '%spost-%d-view-%d-field-%s.php', $slug_dir, $post->ID, $view_id, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
189 8
				$specifics []= sprintf( '%spost-%d-view-%d-field.php', $slug_dir, $post->ID, $view_id );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
190 8
				$specifics []= sprintf( '%spost-%d-field-%s.php', $slug_dir, $post->ID, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
191 8
				$specifics []= sprintf( '%spost-%d-field.php', $slug_dir, $post->ID );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
192
			}
193
			
194
			/** Field-specific */
195 87
			if ( $field_id && $form_id ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $field_id of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
Bug Best Practice introduced by
The expression $form_id of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
196
197 87
				if ( $field_id ) {
198 87
					$specifics []= sprintf( '%sform-%d-field-%d-%s.php', $slug_dir, $form_id, $field_id, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
199 87
					$specifics []= sprintf( '%sform-%d-field-%d.php', $slug_dir, $form_id, $field_id );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
200
				}
201
202 87
				if ( $field_type ) {
203 87
					$specifics []= sprintf( '%sform-%d-field-%s-%s.php', $slug_dir, $form_id, $field_type, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
204 87
					$inputType && $specifics []= sprintf( '%sform-%d-field-%s-%s.php', $slug_dir, $form_id, $inputType, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
205 87
					$specifics []= sprintf( '%sform-%d-field-%s.php', $slug_dir, $form_id, $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
206 87
					$inputType && $specifics []= sprintf( '%sform-%d-field-%s.php', $slug_dir, $form_id, $inputType );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
207
208 87
					$specifics []= sprintf( '%sview-%d-field-%s-%s.php', $slug_dir, $view_id, $field_type, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
209 87
					$inputType && $specifics []= sprintf( '%sview-%d-field-%s-%s.php', $slug_dir, $view_id, $inputType, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
210 87
					$specifics []= sprintf( '%sview-%d-field-%s.php', $slug_dir, $view_id, $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
211 87
					$inputType && $specifics []= sprintf( '%sview-%d-field-%s.php', $slug_dir, $view_id, $inputType );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
212
213 87
					$specifics []= sprintf( '%sfield-%s-%s.php', $slug_dir, $field_type, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
214 87
					$inputType && $specifics []= sprintf( '%sfield-%s-%s.php', $slug_dir, $inputType, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
215 87
					$specifics []= sprintf( '%sfield-%s.php', $slug_dir, $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
216 87
					$inputType && $specifics []= sprintf( '%sfield-%s.php', $slug_dir, $inputType );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
217
				}
218
			}
219
220 87
			if ( $form_id ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $form_id of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
221
				/** Generic field templates */
222 87
				$specifics []= sprintf( '%sview-%d-field-%s.php', $slug_dir, $view_id, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
223 87
				$specifics []= sprintf( '%sform-%d-field-%s.php', $slug_dir, $form_id, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
224
225 87
				$specifics []= sprintf( '%sview-%d-field.php', $slug_dir, $view_id );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
226 87
				$specifics []= sprintf( '%sform-%d-field.php', $slug_dir, $form_id );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
227
			}
228
229
			/**
230
			 * Legacy.
231
			 * Ignore some types that conflict.
232
			 */
233 87
			if ( ! in_array( $field_type, array( 'notes' ) ) ) {
234 86
				$specifics []= sprintf( '%s.php', $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
235 86
				$specifics []= sprintf( 'fields/%s.php', $field_type );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
236
			}
237
238 87
			$specifics []= sprintf( '%sfield-%s.php', $slug_dir, $slug_name );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
239 87
			$specifics []= sprintf( '%sfield.php', $slug_dir );
0 ignored issues
show
introduced by
Expected 1 space before "="; 0 found
Loading history...
240
241 87
			return array_merge( $specifics, $templates );
242 87
		};
243
	}
244
245
	/**
246
	 * Output some HTML.
247
	 *
248
	 * @todo Move to \GV\Field_HTML_Template, but call filters here?
249
	 *
250
	 * @return void
251
	 */
252 87
	public function render() {
253 87
		$entry = $this->entry->from_field( $this->field );
254
255
		/** Retrieve the value. */
256 87
		$display_value = $value = $this->field->get_value( $this->view, $this->source, $entry );
257
258 87
		$source = $this->source;
259 87
		$source_backend = $source ? $source::$backend : null;
260
261 87
		\GV\Mocks\Legacy_Context::load( array(
262 87
			'field' => $this->field,
263
		) );
264
265
		/** Alter the display value according to Gravity Forms. */
266 87
		if ( $source_backend == \GV\Source::BACKEND_GRAVITYFORMS ) {
267
			/** Prevent any PHP warnings that may be generated. */
268 52
			ob_start();
269
270 52
			$display_value = \GFCommon::get_lead_field_display( $this->field->field, $value, $entry['currency'], false, 'html' );
0 ignored issues
show
Documentation introduced by
The property field does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
271
272 52
			if ( $errors = ob_get_clean() ) {
273
				gravityview()->log->error( 'Errors when calling GFCommon::get_lead_field_display()', array( 'data' => $errors ) );
274
			}
275
276
			// `gform_entry_field_value` expects a GF_Field, but $this->field->field can be NULL
277 52
			if ( ! $this->field->field instanceof GF_Field ) {
0 ignored issues
show
Documentation introduced by
The property field does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
278 52
				$gf_field = \GF_Fields::create( $this->field->field );
0 ignored issues
show
Documentation introduced by
The property field does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
279
			}
280
281
			/** Call the Gravity Forms field value filter. */
282 52
			$display_value = apply_filters( 'gform_entry_field_value', $display_value, $gf_field, $entry->as_entry(), $this->source->form );
0 ignored issues
show
Bug introduced by
The property form does not seem to exist in GV\Source.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
Bug introduced by
The variable $gf_field does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
283
284 52
			unset( $gf_field );
285
286
			/** Replace merge tags for admin-only fields. */
287 52
			if ( ! empty( $this->field->field->adminOnly ) ) {
0 ignored issues
show
Documentation introduced by
The property field does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
288
				$display_value = \GravityView_API::replace_variables( $display_value, $this->form->form, $entry->as_entry(), false, false );
0 ignored issues
show
Bug introduced by
The property form does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
289
			}
290
		}
291
292 87
		$context = Template_Context::from_template( $this, compact( 'display_value', 'value' ) );
293
294
		/**
295
		 * Make various pieces of data available to the template
296
		 *  under the $gravityview scoped variable.
297
		 *
298
		 * @filter `gravityview/template/field/context`
299
		 * @param \GV\Template_Context $context The context for this template.
300
		 * @since 2.0
301
		 */
302 87
		$this->push_template_data( apply_filters( 'gravityview/template/field/context', $context ), 'gravityview' );
303
304
		/** Bake the template. */
305 87
		ob_start();
306 87
		$this->located_template = $this->get_template_part( static::$slug );
307 87
		$output = ob_get_clean();
308
309 87
		if ( empty( $output ) ) {
310
			/**
311
			 * @filter `gravityview_empty_value` What to display when a field is empty
312
			 * @deprecated Use the `gravityview/field/value/empty` filter instead
313
			 * @param string $value (empty string)
314
			 */
315 26
			$output = apply_filters( 'gravityview_empty_value', $output );
316
317
			/**
318
			 * @filter `gravityview/field/value/empty` What to display when this field is empty.
319
			 * @param string $value The value to display (Default: empty string)
320
			 * @param \GV\Template_Context The template context this is being called from.
321
			 */
322 26
			$output = apply_filters( 'gravityview/field/value/empty', $output, Template_Context::from_template( $this ) );
323
324 26
			$context = Template_Context::from_template( $this, compact( 'display_value', 'value' ) );
325
		}
326
327 87
		gravityview()->log->info( 'Field template for field #{field_id} loaded: {located_template}', array( 'field_id' => $this->field->ID, 'located_template' => $this->located_template ) );
328
329 87
		$this->pop_template_data( 'gravityview' );
330
331
		/** A compatibility array that's required by some of the deprecated filters. */
332
		$field_compat = array(
333 87
			'form' => $source_backend == \GV\Source::BACKEND_GRAVITYFORMS ? $this->source->form : ( $this->view->form ? $this->view->form->form : null ),
0 ignored issues
show
Documentation introduced by
The property $form is declared private in GV\Form. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
334 87
			'field_id' => $this->field->ID,
335 87
			'field' => $this->field->field,
0 ignored issues
show
Documentation introduced by
The property field does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
336 87
			'field_settings' => $this->field->as_configuration(),
337 87
			'value' => $value,
338 87
			'display_value' => $display_value,
339 87
			'format' => 'html',
340 87
			'entry' => $entry->as_entry(),
341 87
			'field_type' => $this->field->type,
0 ignored issues
show
Documentation introduced by
The property type does not exist on object<GV\Field>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
342 87
			'field_path' => $this->located_template,
343
		);
344
345
		/**
346
		 * Wrap output in a link, if enabled in the field settings
347
		 *
348
		 * @param string $output HTML value output
349
		 * @param \GV\Template_Context $context
350
		 *
351
		 * @return mixed|string|void
352
		 */
353 87
		$pre_link_compat_callback = function( $output, $context ) use ( $field_compat ) {
354 87
			$field = $context->field;
355
356
			/**
357
			 * @filter `gravityview_field_entry_value_{$field_type}_pre_link` Modify the field value output for a field type before Show As Link setting is applied. Example: `gravityview_field_entry_value_number_pre_link`
358
			 * @since 1.16
359
			 * @param string $output HTML value output
360
			 * @param array  $entry The GF entry array
361
			 * @param array  $field_settings Settings for the particular GV field
362
			 * @param array  $field Field array, as fetched from GravityView_View::getCurrentField()
363
			 *
364
			 * @deprecated Use the `gravityview/field/{$field_type}/output` or `gravityview/field/output` filters instead.
365
			 */
366 87
			$output = apply_filters( "gravityview_field_entry_value_{$field->type}_pre_link", $output, $context->entry->as_entry(), $field->as_configuration(), $field_compat );
367
368 87
			$output = apply_filters( 'gravityview_field_entry_value_pre_link', $output, $context->entry->as_entry(), $field->as_configuration(), $field_compat );
369
370
			/**
371
			 * Link to the single entry by wrapping the output in an anchor tag
372
			 *
373
			 * Fields can override this by modifying the field data variable inside the field. See /templates/fields/post_image.php for an example.
374
			 */
375 87
			if ( ! empty( $field->show_as_link ) && ! \gv_empty( $output, false, false ) ) {
376 4
				$link_atts = empty( $field->new_window ) ? array() : array( 'target' => '_blank' );
377
378 4
				$permalink = $context->entry->get_permalink( $context->view, $context->request );
379 4
				$output = \gravityview_get_link( $permalink, $output, $link_atts );
380
381
				/**
382
				 * @filter `gravityview_field_entry_link` Modify the link HTML
383
				 * @param string $link HTML output of the link
384
				 * @param string $href URL of the link
385
				 * @param array  $entry The GF entry array
386
				 * @param array $field_settings Settings for the particular GV field
387
				 * @deprecated Use `gravityview/template/field/entry_link`
388
				 */
389 4
				$output = apply_filters( 'gravityview_field_entry_link', $output, $permalink, $context->entry->as_entry(), $field->as_configuration() );
390
391
				/**
392
				 * @filter `gravityview/template/field/entry_link` Modify the link HTML
393
				 * @since 2.0
394
				 * @param string $link HTML output of the link
395
				 * @param string $href URL of the link
396
				 * @param \GV\Template_Context $context The context
397
				 */
398 4
				$output = apply_filters( 'gravityview/template/field/entry_link', $output, $permalink, $context );
399
			}
400
401 87
			return $output;
402 87
		};
403
404 87
		$post_link_compat_callback = function( $output, $context ) use ( $field_compat ) {
405 87
			$field = $context->field;
406
407
			/**
408
			 * @filter `gravityview_field_entry_value_{$field_type}` Modify the field value output for a field type. Example: `gravityview_field_entry_value_number`
409
			 * @since 1.6
410
			 * @param string $output HTML value output
411
			 * @param array  $entry The GF entry array
412
			 * @param  array $field_settings Settings for the particular GV field
413
			 * @param array $field Current field being displayed
414
			 *
415
			 * @deprecated Use the `gravityview/field/{$field_type}/output` or `gravityview/field/output` filters instead.
416
			 */
417 87
			$output = apply_filters( "gravityview_field_entry_value_{$field->type}", $output, $context->entry->as_entry(), $field->as_configuration(), $field_compat );
418
419
			/**
420
			 * @filter `gravityview_field_entry_value` Modify the field value output for all field types
421
			 * @param string $output HTML value output
422
			 * @param array  $entry The GF entry array
423
			 * @param  array $field_settings Settings for the particular GV field
424
			 * @param array $field_data  {@since 1.6}
425
			 *
426
			 * @deprecated Use the `gravityview/field/{$field_type}/output` or `gravityview/field/output` filters instead.
427
			 */
428 87
			$output = apply_filters( 'gravityview_field_entry_value', $output, $context->entry->as_entry(), $field->as_configuration(), $field_compat );
429
430
			/**
431
			 * @filter `gravityview/template/field/{$field_type}/output` Modify the field output for a field type.
432
			 *
433
			 * @since 2.0
434
			 *
435
			 * @param string $output The current output.
436
			 * @param \GV\Template_Context The template context this is being called from.
437
			 */
438 87
			return apply_filters( "gravityview/template/field/{$field->type}/output", $output, $context );
439 87
		};
440
441
		/**
442
		 * Okay, what's this whole pre/post_link compat deal, huh?
443
		 *
444
		 * Well, the `gravityview_field_entry_value_{$field_type}_pre_link` filter
445
		 *  is expected to be applied before the value is turned into an entry link.
446
		 *
447
		 * And then `gravityview_field_entry_value_{$field_type}` and `gravityview_field_entry_value`
448
		 *  are called afterwards.
449
		 *
450
		 * So we're going to use filter priorities to make sure this happens inline with
451
		 *  our new filters, in the correct sequence. Pre-link called with priority 5 and
452
		 *  post-link called with priority 9. Then everything else.
453
		 *
454
		 * If a new code wants to alter the value before it is hyperlinked (hyperlinkified?),
455
		 *  it should hook into a priority between -inf. and 8. Afterwards: 10 to +inf.
456
		 */
457
		add_filter( 'gravityview/template/field/output', $pre_link_compat_callback, 5, 2 );
458
		add_filter( 'gravityview/template/field/output', $post_link_compat_callback, 9, 2 );
459
460
		/**
461
		 * @filter `gravityview/template/field/output` Modify the field output for a field.
462
		 *
463
		 * @since 2.0
464
		 *
465
		 * @param string $output The current output.
466
		 * @param \GV\Template_Context The template this is being called from.
467
		 */
468
		echo apply_filters( "gravityview/template/field/output", $output, $context );
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'apply_filters'
Loading history...
Coding Style Comprehensibility introduced by
The string literal gravityview/template/field/output does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
469
470
		remove_filter( 'gravityview/template/field/output', $pre_link_compat_callback, 5 );
471
		remove_filter( 'gravityview/template/field/output', $post_link_compat_callback, 9 );
472
	}
473
}
474
475
/** Load implementations. */
476
require gravityview()->plugin->dir( 'future/includes/class-gv-template-field-html.php' );
477
require gravityview()->plugin->dir( 'future/includes/class-gv-template-field-csv.php' );
478