Completed
Pull Request — master (#898)
by Zack
14:59
created
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Indentation   +1594 added lines, -1594 removed lines patch added patch discarded remove patch
@@ -10,20 +10,20 @@  discard block
 block discarded – undo
10 10
  */
11 11
 
12 12
 if ( ! defined( 'WPINC' ) ) {
13
-    die;
13
+	die;
14 14
 }
15 15
 
16 16
 class GravityView_Edit_Entry_Render {
17 17
 
18
-    /**
19
-     * @var GravityView_Edit_Entry
20
-     */
21
-    protected $loader;
18
+	/**
19
+	 * @var GravityView_Edit_Entry
20
+	 */
21
+	protected $loader;
22 22
 
23 23
 	/**
24 24
 	 * @var string String used to generate unique nonce for the entry/form/view combination. Allows access to edit page.
25 25
 	 */
26
-    static $nonce_key;
26
+	static $nonce_key;
27 27
 
28 28
 	/**
29 29
 	 * @since 1.9
@@ -37,12 +37,12 @@  discard block
 block discarded – undo
37 37
 	 */
38 38
 	private static $supports_save_and_continue = false;
39 39
 
40
-    /**
41
-     * Gravity Forms entry array
42
-     *
43
-     * @var array
44
-     */
45
-    public $entry;
40
+	/**
41
+	 * Gravity Forms entry array
42
+	 *
43
+	 * @var array
44
+	 */
45
+	public $entry;
46 46
 
47 47
 	/**
48 48
 	 * Gravity Forms entry array (it won't get changed during this class lifecycle)
@@ -51,134 +51,134 @@  discard block
 block discarded – undo
51 51
 	 */
52 52
 	private static $original_entry = array();
53 53
 
54
-    /**
55
-     * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
-     *
57
-     * @var array
58
-     */
54
+	/**
55
+	 * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
+	 *
57
+	 * @var array
58
+	 */
59 59
 	public $form;
60 60
 
61
-    /**
62
-     * Gravity Forms form array (it won't get changed during this class lifecycle)
63
-     * @since 1.16.2.1
64
-     * @var array
65
-     */
66
-    private static $original_form;
67
-
68
-    /**
69
-     * Gravity Forms form array after the form validation process
70
-     * @since 1.13
71
-     * @var array
72
-     */
61
+	/**
62
+	 * Gravity Forms form array (it won't get changed during this class lifecycle)
63
+	 * @since 1.16.2.1
64
+	 * @var array
65
+	 */
66
+	private static $original_form;
67
+
68
+	/**
69
+	 * Gravity Forms form array after the form validation process
70
+	 * @since 1.13
71
+	 * @var array
72
+	 */
73 73
 	public $form_after_validation = null;
74 74
 
75
-    /**
76
-     * Hold an array of GF field objects that have calculation rules
77
-     * @var array
78
-     */
75
+	/**
76
+	 * Hold an array of GF field objects that have calculation rules
77
+	 * @var array
78
+	 */
79 79
 	public $fields_with_calculation = array();
80 80
 
81
-    /**
82
-     * Gravity Forms form id
83
-     *
84
-     * @var int
85
-     */
81
+	/**
82
+	 * Gravity Forms form id
83
+	 *
84
+	 * @var int
85
+	 */
86 86
 	public $form_id;
87 87
 
88
-    /**
89
-     * ID of the current view
90
-     *
91
-     * @var int
92
-     */
88
+	/**
89
+	 * ID of the current view
90
+	 *
91
+	 * @var int
92
+	 */
93 93
 	public $view_id;
94 94
 
95
-    /**
96
-     * Updated entry is valid (GF Validation object)
97
-     *
98
-     * @var array
99
-     */
95
+	/**
96
+	 * Updated entry is valid (GF Validation object)
97
+	 *
98
+	 * @var array
99
+	 */
100 100
 	public $is_valid = NULL;
101 101
 
102
-    function __construct( GravityView_Edit_Entry $loader ) {
103
-        $this->loader = $loader;
104
-    }
102
+	function __construct( GravityView_Edit_Entry $loader ) {
103
+		$this->loader = $loader;
104
+	}
105 105
 
106
-    function load() {
106
+	function load() {
107 107
 
108
-        /** @define "GRAVITYVIEW_DIR" "../../../" */
109
-        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
108
+		/** @define "GRAVITYVIEW_DIR" "../../../" */
109
+		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
110 110
 
111
-        // Don't display an embedded form when editing an entry
112
-        add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
113
-        add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
111
+		// Don't display an embedded form when editing an entry
112
+		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
113
+		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
114 114
 
115
-        // Stop Gravity Forms processing what is ours!
116
-        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
115
+		// Stop Gravity Forms processing what is ours!
116
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
117 117
 
118
-        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
118
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
119 119
 
120
-        add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
120
+		add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
121 121
 
122
-        // Disable conditional logic if needed (since 1.9)
123
-        add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
122
+		// Disable conditional logic if needed (since 1.9)
123
+		add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
124 124
 
125
-        // Make sure GF doesn't validate max files (since 1.9)
126
-        add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
125
+		// Make sure GF doesn't validate max files (since 1.9)
126
+		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
127 127
 
128
-        // Add fields expected by GFFormDisplay::validate()
129
-        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
128
+		// Add fields expected by GFFormDisplay::validate()
129
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
130 130
 
131 131
 		// Fix multiselect value for GF 2.2
132 132
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
133
-    }
134
-
135
-    /**
136
-     * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
137
-     *
138
-     * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
139
-     * And then removes it on the `wp_footer` action
140
-     *
141
-     * @since 1.16.1
142
-     *
143
-     * @return void
144
-     */
145
-    public function prevent_render_form() {
146
-        if( $this->is_edit_entry() ) {
147
-            if( 'wp_head' === current_filter() ) {
148
-                add_filter( 'gform_shortcode_form', '__return_empty_string' );
149
-            } else {
150
-                remove_filter( 'gform_shortcode_form', '__return_empty_string' );
151
-            }
152
-        }
153
-    }
154
-
155
-    /**
156
-     * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
157
-     * backend form, we need to prevent them from saving twice.
158
-     * @return void
159
-     */
160
-    public function prevent_maybe_process_form() {
161
-
162
-        if( ! empty( $_POST ) ) {
163
-	        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
164
-        }
165
-
166
-        if( $this->is_edit_entry_submission() ) {
167
-            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
168
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
169
-        }
170
-    }
171
-
172
-    /**
173
-     * Is the current page an Edit Entry page?
174
-     * @return boolean
175
-     */
176
-    public function is_edit_entry() {
177
-
178
-        $is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
179
-
180
-        return ( $is_edit_entry || $this->is_edit_entry_submission() );
181
-    }
133
+	}
134
+
135
+	/**
136
+	 * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
137
+	 *
138
+	 * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
139
+	 * And then removes it on the `wp_footer` action
140
+	 *
141
+	 * @since 1.16.1
142
+	 *
143
+	 * @return void
144
+	 */
145
+	public function prevent_render_form() {
146
+		if( $this->is_edit_entry() ) {
147
+			if( 'wp_head' === current_filter() ) {
148
+				add_filter( 'gform_shortcode_form', '__return_empty_string' );
149
+			} else {
150
+				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
151
+			}
152
+		}
153
+	}
154
+
155
+	/**
156
+	 * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
157
+	 * backend form, we need to prevent them from saving twice.
158
+	 * @return void
159
+	 */
160
+	public function prevent_maybe_process_form() {
161
+
162
+		if( ! empty( $_POST ) ) {
163
+			do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
164
+		}
165
+
166
+		if( $this->is_edit_entry_submission() ) {
167
+			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
168
+			remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
169
+		}
170
+	}
171
+
172
+	/**
173
+	 * Is the current page an Edit Entry page?
174
+	 * @return boolean
175
+	 */
176
+	public function is_edit_entry() {
177
+
178
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
179
+
180
+		return ( $is_edit_entry || $this->is_edit_entry_submission() );
181
+	}
182 182
 
183 183
 	/**
184 184
 	 * Is the current page an Edit Entry page?
@@ -189,229 +189,229 @@  discard block
 block discarded – undo
189 189
 		return !empty( $_POST[ self::$nonce_field ] );
190 190
 	}
191 191
 
192
-    /**
193
-     * When Edit entry view is requested setup the vars
194
-     */
195
-    private function setup_vars() {
196
-        $gravityview_view = GravityView_View::getInstance();
192
+	/**
193
+	 * When Edit entry view is requested setup the vars
194
+	 */
195
+	private function setup_vars() {
196
+		$gravityview_view = GravityView_View::getInstance();
197 197
 
198 198
 
199
-        $entries = $gravityview_view->getEntries();
200
-	    self::$original_entry = $entries[0];
201
-	    $this->entry = $entries[0];
199
+		$entries = $gravityview_view->getEntries();
200
+		self::$original_entry = $entries[0];
201
+		$this->entry = $entries[0];
202 202
 
203
-        self::$original_form = $gravityview_view->getForm();
204
-        $this->form = $gravityview_view->getForm();
205
-        $this->form_id = $gravityview_view->getFormId();
206
-        $this->view_id = $gravityview_view->getViewId();
203
+		self::$original_form = $gravityview_view->getForm();
204
+		$this->form = $gravityview_view->getForm();
205
+		$this->form_id = $gravityview_view->getFormId();
206
+		$this->view_id = $gravityview_view->getViewId();
207 207
 
208
-        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
209
-    }
208
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
209
+	}
210 210
 
211 211
 
212
-    /**
213
-     * Load required files and trigger edit flow
214
-     *
215
-     * Run when the is_edit_entry returns true.
216
-     *
217
-     * @param GravityView_View_Data $gv_data GravityView Data object
218
-     * @return void
219
-     */
220
-    public function init( $gv_data ) {
212
+	/**
213
+	 * Load required files and trigger edit flow
214
+	 *
215
+	 * Run when the is_edit_entry returns true.
216
+	 *
217
+	 * @param GravityView_View_Data $gv_data GravityView Data object
218
+	 * @return void
219
+	 */
220
+	public function init( $gv_data ) {
221 221
 
222
-        require_once( GFCommon::get_base_path() . '/form_display.php' );
223
-        require_once( GFCommon::get_base_path() . '/entry_detail.php' );
222
+		require_once( GFCommon::get_base_path() . '/form_display.php' );
223
+		require_once( GFCommon::get_base_path() . '/entry_detail.php' );
224 224
 
225
-        $this->setup_vars();
225
+		$this->setup_vars();
226 226
 
227
-        // Multiple Views embedded, don't proceed if nonce fails
227
+		// Multiple Views embedded, don't proceed if nonce fails
228 228
 		$multiple_views = defined( 'GRAVITYVIEW_FUTURE_CORE_LOADED' ) ? gravityview()->views->count() > 1 : $gv_data->has_multiple_views();
229
-        if( $multiple_views && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
230
-            do_action('gravityview_log_error', __METHOD__ . ': Nonce validation failed for the Edit Entry request; returning' );
231
-            return;
232
-        }
229
+		if( $multiple_views && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
230
+			do_action('gravityview_log_error', __METHOD__ . ': Nonce validation failed for the Edit Entry request; returning' );
231
+			return;
232
+		}
233 233
 
234
-        // Sorry, you're not allowed here.
235
-        if( false === $this->user_can_edit_entry( true ) ) {
236
-            do_action('gravityview_log_error', __METHOD__ . ': User is not allowed to edit this entry; returning', $this->entry );
237
-            return;
238
-        }
234
+		// Sorry, you're not allowed here.
235
+		if( false === $this->user_can_edit_entry( true ) ) {
236
+			do_action('gravityview_log_error', __METHOD__ . ': User is not allowed to edit this entry; returning', $this->entry );
237
+			return;
238
+		}
239 239
 
240
-        $this->print_scripts();
240
+		$this->print_scripts();
241 241
 
242
-        $this->process_save();
242
+		$this->process_save();
243 243
 
244
-        $this->edit_entry_form();
244
+		$this->edit_entry_form();
245 245
 
246
-    }
246
+	}
247 247
 
248 248
 
249
-    /**
250
-     * Force Gravity Forms to output scripts as if it were in the admin
251
-     * @return void
252
-     */
253
-    private function print_scripts() {
254
-        $gravityview_view = GravityView_View::getInstance();
249
+	/**
250
+	 * Force Gravity Forms to output scripts as if it were in the admin
251
+	 * @return void
252
+	 */
253
+	private function print_scripts() {
254
+		$gravityview_view = GravityView_View::getInstance();
255 255
 
256
-        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
256
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
257 257
 
258
-        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
258
+		GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
259 259
 
260
-        // Sack is required for images
261
-        wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
262
-    }
260
+		// Sack is required for images
261
+		wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
262
+	}
263 263
 
264 264
 
265
-    /**
266
-     * Process edit entry form save
267
-     */
268
-    private function process_save() {
265
+	/**
266
+	 * Process edit entry form save
267
+	 */
268
+	private function process_save() {
269 269
 
270
-        if( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
271
-            return;
272
-        }
270
+		if( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
271
+			return;
272
+		}
273 273
 
274
-        // Make sure the entry, view, and form IDs are all correct
275
-        $valid = $this->verify_nonce();
274
+		// Make sure the entry, view, and form IDs are all correct
275
+		$valid = $this->verify_nonce();
276 276
 
277
-        if( !$valid ) {
278
-            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
279
-            return;
280
-        }
277
+		if( !$valid ) {
278
+			do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
279
+			return;
280
+		}
281 281
 
282
-        if( $this->entry['id'] !== $_POST['lid'] ) {
283
-            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
284
-            return;
285
-        }
282
+		if( $this->entry['id'] !== $_POST['lid'] ) {
283
+			do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
284
+			return;
285
+		}
286 286
 
287
-        do_action('gravityview_log_debug', __METHOD__ . ': $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
287
+		do_action('gravityview_log_debug', __METHOD__ . ': $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
288 288
 
289
-        $this->process_save_process_files( $this->form_id );
289
+		$this->process_save_process_files( $this->form_id );
290 290
 
291
-        $this->validate();
291
+		$this->validate();
292 292
 
293
-        if( $this->is_valid ) {
293
+		if( $this->is_valid ) {
294 294
 
295
-            do_action('gravityview_log_debug', __METHOD__ . ': Submission is valid.' );
295
+			do_action('gravityview_log_debug', __METHOD__ . ': Submission is valid.' );
296 296
 
297
-            /**
298
-             * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
299
-             */
300
-            $form = $this->form_prepare_for_save();
297
+			/**
298
+			 * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
299
+			 */
300
+			$form = $this->form_prepare_for_save();
301 301
 
302
-            /**
303
-             * @hack to avoid the capability validation of the method save_lead for GF 1.9+
304
-             */
305
-            unset( $_GET['page'] );
302
+			/**
303
+			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
304
+			 */
305
+			unset( $_GET['page'] );
306 306
 
307
-            $date_created = $this->entry['date_created'];
307
+			$date_created = $this->entry['date_created'];
308 308
 
309
-            /**
310
-             * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
311
-             * @since 1.17.2
312
-             */
313
-            unset( $this->entry['date_created'] );
309
+			/**
310
+			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
311
+			 * @since 1.17.2
312
+			 */
313
+			unset( $this->entry['date_created'] );
314 314
 
315
-            GFFormsModel::save_lead( $form, $this->entry );
315
+			GFFormsModel::save_lead( $form, $this->entry );
316 316
 
317
-	        // Delete the values for hidden inputs
318
-	        $this->unset_hidden_field_values();
317
+			// Delete the values for hidden inputs
318
+			$this->unset_hidden_field_values();
319 319
             
320
-            $this->entry['date_created'] = $date_created;
320
+			$this->entry['date_created'] = $date_created;
321 321
 
322
-            // Process calculation fields
323
-            $this->update_calculation_fields();
322
+			// Process calculation fields
323
+			$this->update_calculation_fields();
324 324
 
325
-            // Perform actions normally performed after updating a lead
326
-            $this->after_update();
325
+			// Perform actions normally performed after updating a lead
326
+			$this->after_update();
327 327
 
328
-	        /**
329
-             * Must be AFTER after_update()!
330
-             * @see https://github.com/gravityview/GravityView/issues/764
331
-             */
332
-            $this->maybe_update_post_fields( $form );
328
+			/**
329
+			 * Must be AFTER after_update()!
330
+			 * @see https://github.com/gravityview/GravityView/issues/764
331
+			 */
332
+			$this->maybe_update_post_fields( $form );
333 333
 
334
-            /**
335
-             * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
336
-             * @param array $form Gravity Forms form array
337
-             * @param string $entry_id Numeric ID of the entry that was updated
338
-             * @param GravityView_Edit_Entry_Render $this This object
339
-             */
340
-            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this );
334
+			/**
335
+			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
336
+			 * @param array $form Gravity Forms form array
337
+			 * @param string $entry_id Numeric ID of the entry that was updated
338
+			 * @param GravityView_Edit_Entry_Render $this This object
339
+			 */
340
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this );
341 341
 
342
-        } else {
343
-            do_action('gravityview_log_error', __METHOD__ . ': Submission is NOT valid.', $this->entry );
344
-        }
342
+		} else {
343
+			do_action('gravityview_log_error', __METHOD__ . ': Submission is NOT valid.', $this->entry );
344
+		}
345 345
 
346
-    } // process_save
346
+	} // process_save
347 347
 
348 348
 	/**
349 349
 	 * Delete the value of fields hidden by conditional logic when the entry is edited
350
-     *
351
-     * @uses GFFormsModel::update_lead_field_value()
352
-     *
353
-     * @since 1.17.4
354
-     *
355
-     * @return void
350
+	 *
351
+	 * @uses GFFormsModel::update_lead_field_value()
352
+	 *
353
+	 * @since 1.17.4
354
+	 *
355
+	 * @return void
356 356
 	 */
357
-    private function unset_hidden_field_values() {
358
-	    global $wpdb;
357
+	private function unset_hidden_field_values() {
358
+		global $wpdb;
359 359
 
360
-	    $lead_detail_table      = GFFormsModel::get_lead_details_table_name();
361
-	    $current_fields   = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_number FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
360
+		$lead_detail_table      = GFFormsModel::get_lead_details_table_name();
361
+		$current_fields   = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_number FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
362 362
 
363
-	    foreach ( $this->entry as $input_id => $field_value ) {
363
+		foreach ( $this->entry as $input_id => $field_value ) {
364 364
 
365
-		    $field = RGFormsModel::get_field( $this->form, $input_id );
365
+			$field = RGFormsModel::get_field( $this->form, $input_id );
366 366
 
367
-		    // Reset fields that are hidden
368
-		    // Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
369
-		    if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
367
+			// Reset fields that are hidden
368
+			// Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
369
+			if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
370 370
 
371
-		        // List fields are stored as empty arrays when empty
372
-			    $empty_value = $this->is_field_json_encoded( $field ) ? '[]' : '';
371
+				// List fields are stored as empty arrays when empty
372
+				$empty_value = $this->is_field_json_encoded( $field ) ? '[]' : '';
373 373
 
374
-			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
374
+				$lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
375 375
 
376
-			    GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
376
+				GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
377 377
 
378
-			    // Prevent the $_POST values of hidden fields from being used as default values when rendering the form
379
-                // after submission
380
-			    $post_input_id = 'input_' . str_replace( '.', '_', $input_id );
381
-			    $_POST[ $post_input_id ] = '';
382
-		    }
383
-	    }
384
-    }
378
+				// Prevent the $_POST values of hidden fields from being used as default values when rendering the form
379
+				// after submission
380
+				$post_input_id = 'input_' . str_replace( '.', '_', $input_id );
381
+				$_POST[ $post_input_id ] = '';
382
+			}
383
+		}
384
+	}
385 385
 
386
-    /**
387
-     * Have GF handle file uploads
388
-     *
389
-     * Copy of code from GFFormDisplay::process_form()
390
-     *
391
-     * @param int $form_id
392
-     */
393
-    private function process_save_process_files( $form_id ) {
386
+	/**
387
+	 * Have GF handle file uploads
388
+	 *
389
+	 * Copy of code from GFFormDisplay::process_form()
390
+	 *
391
+	 * @param int $form_id
392
+	 */
393
+	private function process_save_process_files( $form_id ) {
394 394
 
395
-        //Loading files that have been uploaded to temp folder
396
-        $files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
397
-        if ( ! is_array( $files ) ) {
398
-            $files = array();
399
-        }
395
+		//Loading files that have been uploaded to temp folder
396
+		$files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
397
+		if ( ! is_array( $files ) ) {
398
+			$files = array();
399
+		}
400 400
 
401 401
 		/**
402 402
 		 * Make sure the fileuploads are not overwritten if no such request was done.
403
-         * @since 1.20.1
403
+		 * @since 1.20.1
404 404
 		 */
405 405
 		add_filter( "gform_save_field_value_$form_id", array( $this, 'save_field_value' ), 99, 5 );
406 406
 
407
-        RGFormsModel::$uploaded_files[ $form_id ] = $files;
408
-    }
407
+		RGFormsModel::$uploaded_files[ $form_id ] = $files;
408
+	}
409 409
 
410 410
 	/**
411 411
 	 * Make sure the fileuploads are not overwritten if no such request was done.
412 412
 	 *
413
-     * TO ONLY BE USED INTERNALLY; DO NOT DEVELOP ON; MAY BE REMOVED AT ANY TIME.
414
-     *
413
+	 * TO ONLY BE USED INTERNALLY; DO NOT DEVELOP ON; MAY BE REMOVED AT ANY TIME.
414
+	 *
415 415
 	 * @since 1.20.1
416 416
 	 *
417 417
 	 * @param string $value Field value
@@ -446,156 +446,156 @@  discard block
 block discarded – undo
446 446
 		return $value;
447 447
 	}
448 448
 
449
-    /**
450
-     * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
451
-     * Late validation done on self::custom_validation
452
-     *
453
-     * @param $plupload_init array Plupload settings
454
-     * @param $form_id
455
-     * @param $instance
456
-     * @return mixed
457
-     */
458
-    public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
459
-        if( ! $this->is_edit_entry() ) {
460
-            return $plupload_init;
461
-        }
462
-
463
-        $plupload_init['gf_vars']['max_files'] = 0;
464
-
465
-        return $plupload_init;
466
-    }
467
-
468
-
469
-    /**
470
-     * Unset adminOnly and convert field input key to string
471
-     * @return array $form
472
-     */
473
-    private function form_prepare_for_save() {
474
-
475
-        $form = $this->form;
476
-
477
-	    /** @var GF_Field $field */
478
-        foreach( $form['fields'] as $k => &$field ) {
479
-
480
-            /**
481
-             * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
482
-             * @since 1.16.3
483
-             * @var GF_Field $field
484
-             */
485
-            if( $field->has_calculation() ) {
486
-                unset( $form['fields'][ $k ] );
487
-            }
488
-
489
-            $field->adminOnly = false;
490
-
491
-            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
492
-                foreach( $field->inputs as $key => $input ) {
493
-                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
494
-                }
495
-            }
496
-        }
497
-
498
-        return $form;
499
-    }
500
-
501
-    private function update_calculation_fields() {
502
-
503
-        $form = self::$original_form;
504
-        $update = false;
505
-
506
-        // get the most up to date entry values
507
-        $entry = GFAPI::get_entry( $this->entry['id'] );
508
-
509
-        if( !empty( $this->fields_with_calculation ) ) {
510
-            $update = true;
511
-            foreach ( $this->fields_with_calculation as $calc_field ) {
512
-                $inputs = $calc_field->get_entry_inputs();
513
-                if ( is_array( $inputs ) ) {
514
-                    foreach ( $inputs as $input ) {
515
-                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
516
-                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
517
-                    }
518
-                } else {
519
-                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
520
-                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
521
-                }
522
-            }
523
-
524
-        }
525
-
526
-        if( $update ) {
527
-
528
-            $return_entry = GFAPI::update_entry( $entry );
529
-
530
-            if( is_wp_error( $return_entry ) ) {
531
-                do_action( 'gravityview_log_error', 'Updating the entry calculation fields failed', $return_entry );
532
-            } else {
533
-                do_action( 'gravityview_log_debug', 'Updating the entry calculation fields succeeded' );
534
-            }
535
-        }
536
-    }
537
-
538
-    /**
539
-     * Handle updating the Post Image field
540
-     *
541
-     * Sets a new Featured Image if configured in Gravity Forms; otherwise uploads/updates media
542
-     *
543
-     * @since 1.17
544
-     *
545
-     * @uses GFFormsModel::media_handle_upload
546
-     * @uses set_post_thumbnail
547
-     * 
548
-     * @param array $form GF Form array
549
-     * @param GF_Field $field GF Field
550
-     * @param string $field_id Numeric ID of the field
551
-     * @param string $value
552
-     * @param array $entry GF Entry currently being edited
553
-     * @param int $post_id ID of the Post being edited
554
-     *
555
-     * @return mixed|string
556
-     */
557
-    private function update_post_image( $form, $field, $field_id, $value, $entry, $post_id ) {
558
-
559
-        $input_name = 'input_' . $field_id;
560
-
561
-        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
562
-
563
-            // We have a new image
564
-
565
-            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
566
-
567
-            $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
568
-            $img_url = rgar( $ary, 0 );
569
-
570
-            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
571
-            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
572
-            $img_description = count( $ary ) > 3 ? $ary[3] : '';
573
-
574
-            $image_meta = array(
575
-                'post_excerpt' => $img_caption,
576
-                'post_content' => $img_description,
577
-            );
578
-
579
-            //adding title only if it is not empty. It will default to the file name if it is not in the array
580
-            if ( ! empty( $img_title ) ) {
581
-                $image_meta['post_title'] = $img_title;
582
-            }
583
-
584
-            /**
585
-             * todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
586
-             * Note: the method became public in GF 1.9.17.7, but we don't require that version yet.
587
-             */
588
-            require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
589
-            $media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
590
-
591
-            // is this field set as featured image?
592
-            if ( $media_id && $field->postFeaturedImage ) {
593
-                set_post_thumbnail( $post_id, $media_id );
594
-            }
595
-
596
-        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
597
-
598
-            $img_url = $_POST[ $input_name ];
449
+	/**
450
+	 * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
451
+	 * Late validation done on self::custom_validation
452
+	 *
453
+	 * @param $plupload_init array Plupload settings
454
+	 * @param $form_id
455
+	 * @param $instance
456
+	 * @return mixed
457
+	 */
458
+	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
459
+		if( ! $this->is_edit_entry() ) {
460
+			return $plupload_init;
461
+		}
462
+
463
+		$plupload_init['gf_vars']['max_files'] = 0;
464
+
465
+		return $plupload_init;
466
+	}
467
+
468
+
469
+	/**
470
+	 * Unset adminOnly and convert field input key to string
471
+	 * @return array $form
472
+	 */
473
+	private function form_prepare_for_save() {
474
+
475
+		$form = $this->form;
476
+
477
+		/** @var GF_Field $field */
478
+		foreach( $form['fields'] as $k => &$field ) {
479
+
480
+			/**
481
+			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
482
+			 * @since 1.16.3
483
+			 * @var GF_Field $field
484
+			 */
485
+			if( $field->has_calculation() ) {
486
+				unset( $form['fields'][ $k ] );
487
+			}
488
+
489
+			$field->adminOnly = false;
490
+
491
+			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
492
+				foreach( $field->inputs as $key => $input ) {
493
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
494
+				}
495
+			}
496
+		}
497
+
498
+		return $form;
499
+	}
500
+
501
+	private function update_calculation_fields() {
502
+
503
+		$form = self::$original_form;
504
+		$update = false;
505
+
506
+		// get the most up to date entry values
507
+		$entry = GFAPI::get_entry( $this->entry['id'] );
508
+
509
+		if( !empty( $this->fields_with_calculation ) ) {
510
+			$update = true;
511
+			foreach ( $this->fields_with_calculation as $calc_field ) {
512
+				$inputs = $calc_field->get_entry_inputs();
513
+				if ( is_array( $inputs ) ) {
514
+					foreach ( $inputs as $input ) {
515
+						$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
516
+						$entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
517
+					}
518
+				} else {
519
+					$input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
520
+					$entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
521
+				}
522
+			}
523
+
524
+		}
525
+
526
+		if( $update ) {
527
+
528
+			$return_entry = GFAPI::update_entry( $entry );
529
+
530
+			if( is_wp_error( $return_entry ) ) {
531
+				do_action( 'gravityview_log_error', 'Updating the entry calculation fields failed', $return_entry );
532
+			} else {
533
+				do_action( 'gravityview_log_debug', 'Updating the entry calculation fields succeeded' );
534
+			}
535
+		}
536
+	}
537
+
538
+	/**
539
+	 * Handle updating the Post Image field
540
+	 *
541
+	 * Sets a new Featured Image if configured in Gravity Forms; otherwise uploads/updates media
542
+	 *
543
+	 * @since 1.17
544
+	 *
545
+	 * @uses GFFormsModel::media_handle_upload
546
+	 * @uses set_post_thumbnail
547
+	 * 
548
+	 * @param array $form GF Form array
549
+	 * @param GF_Field $field GF Field
550
+	 * @param string $field_id Numeric ID of the field
551
+	 * @param string $value
552
+	 * @param array $entry GF Entry currently being edited
553
+	 * @param int $post_id ID of the Post being edited
554
+	 *
555
+	 * @return mixed|string
556
+	 */
557
+	private function update_post_image( $form, $field, $field_id, $value, $entry, $post_id ) {
558
+
559
+		$input_name = 'input_' . $field_id;
560
+
561
+		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
562
+
563
+			// We have a new image
564
+
565
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
566
+
567
+			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
568
+			$img_url = rgar( $ary, 0 );
569
+
570
+			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
571
+			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
572
+			$img_description = count( $ary ) > 3 ? $ary[3] : '';
573
+
574
+			$image_meta = array(
575
+				'post_excerpt' => $img_caption,
576
+				'post_content' => $img_description,
577
+			);
578
+
579
+			//adding title only if it is not empty. It will default to the file name if it is not in the array
580
+			if ( ! empty( $img_title ) ) {
581
+				$image_meta['post_title'] = $img_title;
582
+			}
583
+
584
+			/**
585
+			 * todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
586
+			 * Note: the method became public in GF 1.9.17.7, but we don't require that version yet.
587
+			 */
588
+			require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
589
+			$media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
590
+
591
+			// is this field set as featured image?
592
+			if ( $media_id && $field->postFeaturedImage ) {
593
+				set_post_thumbnail( $post_id, $media_id );
594
+			}
595
+
596
+		} elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
597
+
598
+			$img_url = $_POST[ $input_name ];
599 599
 
600 600
 			$img_title       = rgar( $_POST, $input_name.'_1' );
601 601
 			$img_caption     = rgar( $_POST, $input_name .'_4' );
@@ -615,259 +615,259 @@  discard block
 block discarded – undo
615 615
 				// update image title, caption or description
616 616
 				wp_update_post( $image_meta );
617 617
 			}
618
-        } else {
619
-
620
-            // if we get here, image was removed or not set.
621
-            $value = '';
622
-
623
-            if ( $field->postFeaturedImage ) {
624
-                delete_post_thumbnail( $post_id );
625
-            }
626
-        }
627
-
628
-        return $value;
629
-    }
630
-
631
-    /**
632
-     * Loop through the fields being edited and if they include Post fields, update the Entry's post object
633
-     *
634
-     * @param array $form Gravity Forms form
635
-     *
636
-     * @return void
637
-     */
638
-    private function maybe_update_post_fields( $form ) {
639
-
640
-        if( empty( $this->entry['post_id'] ) ) {
641
-	        do_action( 'gravityview_log_debug', __METHOD__ . ': This entry has no post fields. Continuing...' );
642
-            return;
643
-        }
644
-
645
-        $post_id = $this->entry['post_id'];
646
-
647
-        // Security check
648
-        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
649
-            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
650
-            return;
651
-        }
652
-
653
-        $update_entry = false;
654
-
655
-        $updated_post = $original_post = get_post( $post_id );
656
-
657
-        foreach ( $this->entry as $field_id => $value ) {
618
+		} else {
658 619
 
659
-            $field = RGFormsModel::get_field( $form, $field_id );
620
+			// if we get here, image was removed or not set.
621
+			$value = '';
660 622
 
661
-            if( ! $field ) {
662
-                continue;
663
-            }
623
+			if ( $field->postFeaturedImage ) {
624
+				delete_post_thumbnail( $post_id );
625
+			}
626
+		}
664 627
 
665
-            if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
628
+		return $value;
629
+	}
666 630
 
667
-                // Get the value of the field, including $_POSTed value
668
-                $value = RGFormsModel::get_field_value( $field );
631
+	/**
632
+	 * Loop through the fields being edited and if they include Post fields, update the Entry's post object
633
+	 *
634
+	 * @param array $form Gravity Forms form
635
+	 *
636
+	 * @return void
637
+	 */
638
+	private function maybe_update_post_fields( $form ) {
669 639
 
670
-                // Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
671
-                $entry_tmp = $this->entry;
672
-                $entry_tmp["{$field_id}"] = $value;
640
+		if( empty( $this->entry['post_id'] ) ) {
641
+			do_action( 'gravityview_log_debug', __METHOD__ . ': This entry has no post fields. Continuing...' );
642
+			return;
643
+		}
673 644
 
674
-                switch( $field->type ) {
645
+		$post_id = $this->entry['post_id'];
675 646
 
676
-                    case 'post_title':
677
-                        $post_title = $value;
678
-                        if( rgar( $form, 'postTitleTemplateEnabled' ) ) {
679
-                            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
680
-                        }
681
-                        $updated_post->post_title = $post_title;
682
-                        $updated_post->post_name  = $post_title;
683
-                        unset( $post_title );
684
-                        break;
647
+		// Security check
648
+		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
649
+			do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
650
+			return;
651
+		}
685 652
 
686
-                    case 'post_content':
687
-                        $post_content = $value;
688
-                        if( rgar( $form, 'postContentTemplateEnabled' ) ) {
689
-                            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
690
-                        }
691
-                        $updated_post->post_content = $post_content;
692
-                        unset( $post_content );
693
-                        break;
694
-                    case 'post_excerpt':
695
-                        $updated_post->post_excerpt = $value;
696
-                        break;
697
-                    case 'post_tags':
698
-                        wp_set_post_tags( $post_id, $value, false );
699
-                        break;
700
-                    case 'post_category':
701
-                        break;
702
-                    case 'post_custom_field':
703
-                        if( ! empty( $field->customFieldTemplateEnabled ) ) {
704
-                            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
705
-                        }
653
+		$update_entry = false;
706 654
 
707
-	                    if ( $this->is_field_json_encoded( $field ) && ! is_string( $value ) ) {
708
-		                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
709
-	                    }
655
+		$updated_post = $original_post = get_post( $post_id );
710 656
 
711
-                        update_post_meta( $post_id, $field->postCustomFieldName, $value );
712
-                        break;
657
+		foreach ( $this->entry as $field_id => $value ) {
713 658
 
714
-                    case 'post_image':
715
-                        $value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
716
-                        break;
659
+			$field = RGFormsModel::get_field( $form, $field_id );
717 660
 
718
-                }
661
+			if( ! $field ) {
662
+				continue;
663
+			}
719 664
 
720
-                // update entry after
721
-                $this->entry["{$field_id}"] = $value;
665
+			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
666
+
667
+				// Get the value of the field, including $_POSTed value
668
+				$value = RGFormsModel::get_field_value( $field );
669
+
670
+				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
671
+				$entry_tmp = $this->entry;
672
+				$entry_tmp["{$field_id}"] = $value;
673
+
674
+				switch( $field->type ) {
675
+
676
+					case 'post_title':
677
+						$post_title = $value;
678
+						if( rgar( $form, 'postTitleTemplateEnabled' ) ) {
679
+							$post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
680
+						}
681
+						$updated_post->post_title = $post_title;
682
+						$updated_post->post_name  = $post_title;
683
+						unset( $post_title );
684
+						break;
685
+
686
+					case 'post_content':
687
+						$post_content = $value;
688
+						if( rgar( $form, 'postContentTemplateEnabled' ) ) {
689
+							$post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
690
+						}
691
+						$updated_post->post_content = $post_content;
692
+						unset( $post_content );
693
+						break;
694
+					case 'post_excerpt':
695
+						$updated_post->post_excerpt = $value;
696
+						break;
697
+					case 'post_tags':
698
+						wp_set_post_tags( $post_id, $value, false );
699
+						break;
700
+					case 'post_category':
701
+						break;
702
+					case 'post_custom_field':
703
+						if( ! empty( $field->customFieldTemplateEnabled ) ) {
704
+							$value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
705
+						}
706
+
707
+						if ( $this->is_field_json_encoded( $field ) && ! is_string( $value ) ) {
708
+							$value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
709
+						}
710
+
711
+						update_post_meta( $post_id, $field->postCustomFieldName, $value );
712
+						break;
713
+
714
+					case 'post_image':
715
+						$value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
716
+						break;
717
+
718
+				}
719
+
720
+				// update entry after
721
+				$this->entry["{$field_id}"] = $value;
722
+
723
+				$update_entry = true;
724
+
725
+				unset( $entry_tmp );
726
+			}
722 727
 
723
-                $update_entry = true;
724
-
725
-                unset( $entry_tmp );
726
-            }
728
+		}
727 729
 
728
-        }
730
+		if( $update_entry ) {
729 731
 
730
-        if( $update_entry ) {
731
-
732
-            $return_entry = GFAPI::update_entry( $this->entry );
732
+			$return_entry = GFAPI::update_entry( $this->entry );
733 733
 
734
-            if( is_wp_error( $return_entry ) ) {
735
-               do_action( 'gravityview_log_error', 'Updating the entry post fields failed', array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) );
736
-            } else {
737
-                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
738
-            }
734
+			if( is_wp_error( $return_entry ) ) {
735
+			   do_action( 'gravityview_log_error', 'Updating the entry post fields failed', array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) );
736
+			} else {
737
+				do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
738
+			}
739 739
 
740
-        }
740
+		}
741 741
 
742
-        $return_post = wp_update_post( $updated_post, true );
742
+		$return_post = wp_update_post( $updated_post, true );
743 743
 
744
-        if( is_wp_error( $return_post ) ) {
745
-            $return_post->add_data( $updated_post, '$updated_post' );
746
-            do_action( 'gravityview_log_error', 'Updating the post content failed', compact( 'updated_post', 'return_post' ) );
747
-        } else {
748
-            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
749
-        }
750
-    }
744
+		if( is_wp_error( $return_post ) ) {
745
+			$return_post->add_data( $updated_post, '$updated_post' );
746
+			do_action( 'gravityview_log_error', 'Updating the post content failed', compact( 'updated_post', 'return_post' ) );
747
+		} else {
748
+			do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
749
+		}
750
+	}
751 751
 
752 752
 	/**
753
-     * Is the field stored in a JSON-encoded manner?
754
-     *
753
+	 * Is the field stored in a JSON-encoded manner?
754
+	 *
755 755
 	 * @param GF_Field $field
756 756
 	 *
757 757
 	 * @return bool True: stored in DB json_encode()'d; False: not encoded
758 758
 	 */
759
-    private function is_field_json_encoded( $field ) {
759
+	private function is_field_json_encoded( $field ) {
760 760
 
761
-	    $json_encoded = false;
761
+		$json_encoded = false;
762 762
 
763
-        $input_type = RGFormsModel::get_input_type( $field );
763
+		$input_type = RGFormsModel::get_input_type( $field );
764 764
 
765
-	    // Only certain custom field types are supported
766
-	    switch( $input_type ) {
767
-		    case 'fileupload':
768
-		    case 'list':
769
-		    case 'multiselect':
770
-			    $json_encoded = true;
771
-			    break;
772
-	    }
765
+		// Only certain custom field types are supported
766
+		switch( $input_type ) {
767
+			case 'fileupload':
768
+			case 'list':
769
+			case 'multiselect':
770
+				$json_encoded = true;
771
+				break;
772
+		}
773 773
 
774
-	    return $json_encoded;
775
-    }
774
+		return $json_encoded;
775
+	}
776 776
 
777
-    /**
778
-     * Convert a field content template into prepared output
779
-     *
780
-     * @uses GravityView_GFFormsModel::get_post_field_images()
781
-     *
782
-     * @since 1.17
783
-     *
784
-     * @param string $template The content template for the field
785
-     * @param array $form Gravity Forms form
786
-     * @param bool $do_shortcode Whether to process shortcode inside content. In GF, only run on Custom Field and Post Content fields
787
-     *
788
-     * @return string
789
-     */
790
-    private function fill_post_template( $template, $form, $entry, $do_shortcode = false ) {
777
+	/**
778
+	 * Convert a field content template into prepared output
779
+	 *
780
+	 * @uses GravityView_GFFormsModel::get_post_field_images()
781
+	 *
782
+	 * @since 1.17
783
+	 *
784
+	 * @param string $template The content template for the field
785
+	 * @param array $form Gravity Forms form
786
+	 * @param bool $do_shortcode Whether to process shortcode inside content. In GF, only run on Custom Field and Post Content fields
787
+	 *
788
+	 * @return string
789
+	 */
790
+	private function fill_post_template( $template, $form, $entry, $do_shortcode = false ) {
791 791
 
792
-        require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
792
+		require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
793 793
 
794
-        $post_images = GravityView_GFFormsModel::get_post_field_images( $form, $entry );
794
+		$post_images = GravityView_GFFormsModel::get_post_field_images( $form, $entry );
795 795
 
796
-        //replacing post image variables
797
-        $output = GFCommon::replace_variables_post_image( $template, $post_images, $entry );
796
+		//replacing post image variables
797
+		$output = GFCommon::replace_variables_post_image( $template, $post_images, $entry );
798 798
 
799
-        //replacing all other variables
800
-        $output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
799
+		//replacing all other variables
800
+		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
801 801
 
802
-        // replace conditional shortcodes
803
-        if( $do_shortcode ) {
804
-            $output = do_shortcode( $output );
805
-        }
802
+		// replace conditional shortcodes
803
+		if( $do_shortcode ) {
804
+			$output = do_shortcode( $output );
805
+		}
806 806
 
807
-        return $output;
808
-    }
807
+		return $output;
808
+	}
809 809
 
810 810
 
811
-    /**
812
-     * Perform actions normally performed after updating a lead
813
-     *
814
-     * @since 1.8
815
-     *
816
-     * @see GFEntryDetail::lead_detail_page()
817
-     *
818
-     * @return void
819
-     */
820
-    private function after_update() {
811
+	/**
812
+	 * Perform actions normally performed after updating a lead
813
+	 *
814
+	 * @since 1.8
815
+	 *
816
+	 * @see GFEntryDetail::lead_detail_page()
817
+	 *
818
+	 * @return void
819
+	 */
820
+	private function after_update() {
821 821
 
822
-        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
823
-        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
822
+		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
823
+		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
824 824
 
825
-        // Re-define the entry now that we've updated it.
826
-        $entry = RGFormsModel::get_lead( $this->entry['id'] );
825
+		// Re-define the entry now that we've updated it.
826
+		$entry = RGFormsModel::get_lead( $this->entry['id'] );
827 827
 
828
-        $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
828
+		$entry = GFFormsModel::set_entry_meta( $entry, $this->form );
829 829
 
830
-        // We need to clear the cache because Gravity Forms caches the field values, which
831
-        // we have just updated.
832
-        foreach ($this->form['fields'] as $key => $field) {
833
-            GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
834
-        }
830
+		// We need to clear the cache because Gravity Forms caches the field values, which
831
+		// we have just updated.
832
+		foreach ($this->form['fields'] as $key => $field) {
833
+			GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
834
+		}
835 835
 
836
-        $this->entry = $entry;
837
-    }
836
+		$this->entry = $entry;
837
+	}
838 838
 
839 839
 
840
-    /**
841
-     * Display the Edit Entry form
842
-     *
843
-     * @return void
844
-     */
845
-    public function edit_entry_form() {
840
+	/**
841
+	 * Display the Edit Entry form
842
+	 *
843
+	 * @return void
844
+	 */
845
+	public function edit_entry_form() {
846 846
 
847
-        ?>
847
+		?>
848 848
 
849 849
         <div class="gv-edit-entry-wrapper"><?php
850 850
 
851
-            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
851
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
852 852
 
853
-            /**
854
-             * Fixes weird wpautop() issue
855
-             * @see https://github.com/katzwebservices/GravityView/issues/451
856
-             */
857
-            echo gravityview_strip_whitespace( $javascript );
853
+			/**
854
+			 * Fixes weird wpautop() issue
855
+			 * @see https://github.com/katzwebservices/GravityView/issues/451
856
+			 */
857
+			echo gravityview_strip_whitespace( $javascript );
858 858
 
859
-            ?><h2 class="gv-edit-entry-title">
859
+			?><h2 class="gv-edit-entry-title">
860 860
                 <span><?php
861 861
 
862
-                    /**
863
-                     * @filter `gravityview_edit_entry_title` Modify the edit entry title
864
-                     * @param string $edit_entry_title Modify the "Edit Entry" title
865
-                     * @param GravityView_Edit_Entry_Render $this This object
866
-                     */
867
-                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
862
+					/**
863
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
864
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
865
+					 * @param GravityView_Edit_Entry_Render $this This object
866
+					 */
867
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
868 868
 
869
-                    echo esc_attr( $edit_entry_title );
870
-            ?></span>
869
+					echo esc_attr( $edit_entry_title );
870
+			?></span>
871 871
             </h2>
872 872
 
873 873
             <?php $this->maybe_print_message(); ?>
@@ -878,14 +878,14 @@  discard block
 block discarded – undo
878 878
 
879 879
                 <?php
880 880
 
881
-                wp_nonce_field( self::$nonce_key, self::$nonce_key );
881
+				wp_nonce_field( self::$nonce_key, self::$nonce_key );
882 882
 
883
-                wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
883
+				wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
884 884
 
885
-                // Print the actual form HTML
886
-                $this->render_edit_form();
885
+				// Print the actual form HTML
886
+				$this->render_edit_form();
887 887
 
888
-                ?>
888
+				?>
889 889
             </form>
890 890
 
891 891
             <script>
@@ -897,643 +897,643 @@  discard block
 block discarded – undo
897 897
         </div>
898 898
 
899 899
     <?php
900
-    }
901
-
902
-    /**
903
-     * Display success or error message if the form has been submitted
904
-     *
905
-     * @uses GVCommon::generate_notice
906
-     *
907
-     * @since 1.16.2.2
908
-     *
909
-     * @return void
910
-     */
911
-    private function maybe_print_message() {
912
-
913
-        if( rgpost('action') === 'update' ) {
914
-
915
-            $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
916
-
917
-            if( ! $this->is_valid ){
918
-
919
-                // Keeping this compatible with Gravity Forms.
920
-                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
921
-                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
922
-
923
-                echo GVCommon::generate_notice( $message , 'gv-error' );
924
-
925
-            } else {
926
-                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
927
-
928
-                /**
929
-                 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
930
-                 * @since 1.5.4
931
-                 * @param string $entry_updated_message Existing message
932
-                 * @param int $view_id View ID
933
-                 * @param array $entry Gravity Forms entry array
934
-                 * @param string $back_link URL to return to the original entry. @since 1.6
935
-                 */
936
-                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
937
-
938
-                echo GVCommon::generate_notice( $message );
939
-            }
940
-
941
-        }
942
-    }
943
-
944
-    /**
945
-     * Display the Edit Entry form in the original Gravity Forms format
946
-     *
947
-     * @since 1.9
948
-     *
949
-     * @return void
950
-     */
951
-    private function render_edit_form() {
952
-
953
-        /**
954
-         * @action `gravityview/edit-entry/render/before` Before rendering the Edit Entry form
955
-         * @since 1.17
956
-         * @param GravityView_Edit_Entry_Render $this
957
-         */
958
-        do_action( 'gravityview/edit-entry/render/before', $this );
959
-
960
-        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
961
-        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
962
-        add_filter( 'gform_disable_view_counter', '__return_true' );
963
-
964
-        add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
965
-        add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
966
-
967
-        // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
968
-        unset( $_GET['page'] );
969
-
970
-        // TODO: Verify multiple-page forms
971
-
972
-        ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
973
-
974
-        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
975
-
976
-        ob_get_clean();
977
-
978
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
979
-        remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
980
-        remove_filter( 'gform_disable_view_counter', '__return_true' );
981
-        remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
982
-        remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
983
-
984
-        echo $html;
985
-
986
-        /**
987
-         * @action `gravityview/edit-entry/render/after` After rendering the Edit Entry form
988
-         * @since 1.17
989
-         * @param GravityView_Edit_Entry_Render $this
990
-         */
991
-        do_action( 'gravityview/edit-entry/render/after', $this );
992
-    }
993
-
994
-    /**
995
-     * Display the Update/Cancel/Delete buttons for the Edit Entry form
996
-     * @since 1.8
997
-     * @return string
998
-     */
999
-    public function render_form_buttons() {
1000
-        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1001
-    }
1002
-
1003
-
1004
-    /**
1005
-     * Modify the form fields that are shown when using GFFormDisplay::get_form()
1006
-     *
1007
-     * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
1008
-     *
1009
-     * @param array $form
1010
-     * @param boolean $ajax Whether in AJAX mode
1011
-     * @param array|string $field_values Passed parameters to the form
1012
-     *
1013
-     * @since 1.9
1014
-     *
1015
-     * @return array Modified form array
1016
-     */
1017
-    public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1018
-
1019
-        // In case we have validated the form, use it to inject the validation results into the form render
1020
-        if( isset( $this->form_after_validation ) ) {
1021
-            $form = $this->form_after_validation;
1022
-        } else {
1023
-            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1024
-        }
1025
-
1026
-        $form = $this->filter_conditional_logic( $form );
1027
-
1028
-        $form = $this->prefill_conditional_logic( $form );
1029
-
1030
-        // for now we don't support Save and Continue feature.
1031
-        if( ! self::$supports_save_and_continue ) {
1032
-	        unset( $form['save'] );
1033
-        }
1034
-
1035
-        return $form;
1036
-    }
1037
-
1038
-    /**
1039
-     * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
1040
-     *
1041
-     * @since 1.16.2.2
1042
-     *
1043
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
1044
-     * @param GF_Field $field
1045
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1046
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1047
-     * @param int $form_id Form ID
1048
-     *
1049
-     * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
1050
-     */
1051
-    public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1052
-
1053
-        if( GFCommon::is_post_field( $field ) ) {
1054
-
1055
-            $message = null;
1056
-
1057
-            // First, make sure they have the capability to edit the post.
1058
-            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1059
-
1060
-                /**
1061
-                 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1062
-                 * @param string $message The existing "You don't have permission..." text
1063
-                 */
1064
-                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1065
-
1066
-            } elseif( null === get_post( $this->entry['post_id'] ) ) {
1067
-                /**
1068
-                 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1069
-                 * @param string $message The existing "This field is not editable; the post no longer exists." text
1070
-                 */
1071
-                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1072
-            }
1073
-
1074
-            if( $message ) {
1075
-                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1076
-            }
1077
-        }
1078
-
1079
-        return $field_content;
1080
-    }
1081
-
1082
-    /**
1083
-     *
1084
-     * Fill-in the saved values into the form inputs
1085
-     *
1086
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
1087
-     * @param GF_Field $field
1088
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1089
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1090
-     * @param int $form_id Form ID
1091
-     *
1092
-     * @return mixed
1093
-     */
1094
-    public function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1095
-
1096
-        $gv_field = GravityView_Fields::get_associated_field( $field );
1097
-
1098
-        // If the form has been submitted, then we don't need to pre-fill the values,
1099
-        // Except for fileupload type and when a field input is overridden- run always!!
1100
-        if(
1101
-            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1102
-            && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1103
-            && ! GFCommon::is_product_field( $field->type )
1104
-            || ! empty( $field_content )
1105
-            || in_array( $field->type, array( 'honeypot' ) )
1106
-        ) {
1107
-	        return $field_content;
1108
-        }
1109
-
1110
-        // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
1111
-        $field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
1112
-
1113
-        $field_value = $this->get_field_value( $field );
1114
-
1115
-	    // Prevent any PHP warnings, like undefined index
1116
-	    ob_start();
1117
-
1118
-	    $return = null;
1119
-
1120
-        /** @var GravityView_Field $gv_field */
1121
-        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1122
-            $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1123
-        } else {
1124
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1125
-	    }
1126
-
1127
-	    // If there was output, it's an error
1128
-	    $warnings = ob_get_clean();
1129
-
1130
-	    if( !empty( $warnings ) ) {
1131
-		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1132
-	    }
1133
-
1134
-        return $return;
1135
-    }
1136
-
1137
-    /**
1138
-     * Modify the value for the current field input
1139
-     *
1140
-     * @param GF_Field $field
1141
-     *
1142
-     * @return array|mixed|string
1143
-     */
1144
-    private function get_field_value( $field ) {
1145
-
1146
-        /**
1147
-         * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
1148
-         * @param boolean True: override saved values; False: don't override (default)
1149
-         * @param $field GF_Field object Gravity Forms field object
1150
-         * @since 1.13
1151
-         */
1152
-        $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1153
-
1154
-        // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1155
-        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1156
-
1157
-            $field_value = array();
1158
-
1159
-            // only accept pre-populated values if the field doesn't have any choice selected.
1160
-            $allow_pre_populated = $field->allowsPrepopulate;
1161
-
1162
-            foreach ( (array)$field->inputs as $input ) {
1163
-
1164
-                $input_id = strval( $input['id'] );
1165
-                
1166
-                if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1167
-                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1168
-                    $allow_pre_populated = false;
1169
-                }
1170
-
1171
-            }
1172
-
1173
-            $pre_value = $field->get_value_submission( array(), false );
1174
-
1175
-            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1176
-
1177
-        } else {
1178
-
1179
-            $id = intval( $field->id );
900
+	}
1180 901
 
1181
-            // get pre-populated value if exists
1182
-            $pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1183
-
1184
-            // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1185
-            // or pre-populated value if not empty and set to override saved value
1186
-            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
902
+	/**
903
+	 * Display success or error message if the form has been submitted
904
+	 *
905
+	 * @uses GVCommon::generate_notice
906
+	 *
907
+	 * @since 1.16.2.2
908
+	 *
909
+	 * @return void
910
+	 */
911
+	private function maybe_print_message() {
1187 912
 
1188
-            // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1189
-            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1190
-                $categories = array();
1191
-                foreach ( explode( ',', $field_value ) as $cat_string ) {
1192
-                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1193
-                }
1194
-                $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1195
-            }
913
+		if( rgpost('action') === 'update' ) {
1196 914
 
1197
-        }
915
+			$back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
1198 916
 
1199
-        // if value is empty get the default value if defined
1200
-        $field_value = $field->get_value_default_if_empty( $field_value );
1201
-
1202
-	    /**
1203
-	     * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1204
-	     * @since 1.11
1205
-	     * @since 1.20 Added third param
1206
-	     * @param mixed $field_value field value used to populate the input
1207
-	     * @param object $field Gravity Forms field object ( Class GF_Field )
1208
-	     * @param GravityView_Edit_Entry_Render $this Current object
1209
-	     */
1210
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
917
+			if( ! $this->is_valid ){
1211 918
 
1212
-	    /**
1213
-	     * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1214
-	     * @since 1.17
1215
-	     * @since 1.20 Added third param
1216
-	     * @param mixed $field_value field value used to populate the input
1217
-	     * @param GF_Field $field Gravity Forms field object
1218
-	     * @param GravityView_Edit_Entry_Render $this Current object
1219
-	     */
1220
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
919
+				// Keeping this compatible with Gravity Forms.
920
+				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
921
+				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1221 922
 
1222
-        return $field_value;
1223
-    }
923
+				echo GVCommon::generate_notice( $message , 'gv-error' );
1224 924
 
925
+			} else {
926
+				$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
1225 927
 
1226
-    // ---- Entry validation
928
+				/**
929
+				 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
930
+				 * @since 1.5.4
931
+				 * @param string $entry_updated_message Existing message
932
+				 * @param int $view_id View ID
933
+				 * @param array $entry Gravity Forms entry array
934
+				 * @param string $back_link URL to return to the original entry. @since 1.6
935
+				 */
936
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1227 937
 
1228
-    /**
1229
-     * Add field keys that Gravity Forms expects.
1230
-     *
1231
-     * @see GFFormDisplay::validate()
1232
-     * @param  array $form GF Form
1233
-     * @return array       Modified GF Form
1234
-     */
1235
-    public function gform_pre_validation( $form ) {
938
+				echo GVCommon::generate_notice( $message );
939
+			}
1236 940
 
1237
-        if( ! $this->verify_nonce() ) {
1238
-            return $form;
1239
-        }
1240
-
1241
-        // Fix PHP warning regarding undefined index.
1242
-        foreach ( $form['fields'] as &$field) {
1243
-
1244
-            // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1245
-            // expects certain field array items to be set.
1246
-            foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1247
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1248
-            }
1249
-
1250
-            switch( RGFormsModel::get_input_type( $field ) ) {
1251
-
1252
-                /**
1253
-                 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1254
-                 *
1255
-                 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1256
-                 *
1257
-                 * @hack
1258
-                 */
1259
-                case 'fileupload':
1260
-
1261
-                    // Set the previous value
1262
-                    $entry = $this->get_entry();
1263
-
1264
-                    $input_name = 'input_'.$field->id;
1265
-                    $form_id = $form['id'];
1266
-
1267
-                    $value = NULL;
941
+		}
942
+	}
1268 943
 
1269
-                    // Use the previous entry value as the default.
1270
-                    if( isset( $entry[ $field->id ] ) ) {
1271
-                        $value = $entry[ $field->id ];
1272
-                    }
1273
-
1274
-                    // If this is a single upload file
1275
-                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1276
-                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1277
-                        $value = $file_path['url'];
1278
-
1279
-                    } else {
1280
-
1281
-                        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1282
-                        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1283
-                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1284
-
1285
-                    }
1286
-
1287
-                    if( rgar($field, "multipleFiles") ) {
1288
-
1289
-                        // If there are fresh uploads, process and merge them.
1290
-                        // Otherwise, use the passed values, which should be json-encoded array of URLs
1291
-                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1292
-                            $value = empty( $value ) ? '[]' : $value;
1293
-                            $value = stripslashes_deep( $value );
1294
-                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1295
-                        }
944
+	/**
945
+	 * Display the Edit Entry form in the original Gravity Forms format
946
+	 *
947
+	 * @since 1.9
948
+	 *
949
+	 * @return void
950
+	 */
951
+	private function render_edit_form() {
1296 952
 
1297
-                    } else {
953
+		/**
954
+		 * @action `gravityview/edit-entry/render/before` Before rendering the Edit Entry form
955
+		 * @since 1.17
956
+		 * @param GravityView_Edit_Entry_Render $this
957
+		 */
958
+		do_action( 'gravityview/edit-entry/render/before', $this );
1298 959
 
1299
-                        // A file already exists when editing an entry
1300
-                        // We set this to solve issue when file upload fields are required.
1301
-                        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1302
-
1303
-                    }
1304
-
1305
-                    $this->entry[ $input_name ] = $value;
1306
-                    $_POST[ $input_name ] = $value;
960
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
961
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
962
+		add_filter( 'gform_disable_view_counter', '__return_true' );
1307 963
 
1308
-                    break;
964
+		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
965
+		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1309 966
 
1310
-                case 'number':
1311
-                    // Fix "undefined index" issue at line 1286 in form_display.php
1312
-                    if( !isset( $_POST['input_'.$field->id ] ) ) {
1313
-                        $_POST['input_'.$field->id ] = NULL;
1314
-                    }
1315
-                    break;
1316
-            }
967
+		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
968
+		unset( $_GET['page'] );
1317 969
 
1318
-        }
970
+		// TODO: Verify multiple-page forms
1319 971
 
1320
-        return $form;
1321
-    }
972
+		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1322 973
 
974
+		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1323 975
 
1324
-    /**
1325
-     * Process validation for a edit entry submission
1326
-     *
1327
-     * Sets the `is_valid` object var
1328
-     *
1329
-     * @return void
1330
-     */
1331
-    private function validate() {
976
+		ob_get_clean();
1332 977
 
1333
-        /**
1334
-         * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1335
-         * GF User Registration Add-on version > 3.x has a different class name
1336
-         * @since 1.16.2
1337
-         */
1338
-        if ( class_exists( 'GF_User_Registration' ) ) {
1339
-            remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1340
-        } else  if ( class_exists( 'GFUser' ) ) {
1341
-            remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1342
-        }
978
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
979
+		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
980
+		remove_filter( 'gform_disable_view_counter', '__return_true' );
981
+		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
982
+		remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
1343 983
 
984
+		echo $html;
1344 985
 
1345
-        /**
1346
-         * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1347
-         * You can enter whatever you want!
1348
-         * We try validating, and customize the results using `self::custom_validation()`
1349
-         */
1350
-        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
986
+		/**
987
+		 * @action `gravityview/edit-entry/render/after` After rendering the Edit Entry form
988
+		 * @since 1.17
989
+		 * @param GravityView_Edit_Entry_Render $this
990
+		 */
991
+		do_action( 'gravityview/edit-entry/render/after', $this );
992
+	}
1351 993
 
1352
-        // Needed by the validate funtion
1353
-        $failed_validation_page = NULL;
1354
-        $field_values = RGForms::post( 'gform_field_values' );
994
+	/**
995
+	 * Display the Update/Cancel/Delete buttons for the Edit Entry form
996
+	 * @since 1.8
997
+	 * @return string
998
+	 */
999
+	public function render_form_buttons() {
1000
+		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1001
+	}
1355 1002
 
1356
-        // Prevent entry limit from running when editing an entry, also
1357
-        // prevent form scheduling from preventing editing
1358
-        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1359 1003
 
1360
-        // Hide fields depending on Edit Entry settings
1361
-        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1004
+	/**
1005
+	 * Modify the form fields that are shown when using GFFormDisplay::get_form()
1006
+	 *
1007
+	 * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
1008
+	 *
1009
+	 * @param array $form
1010
+	 * @param boolean $ajax Whether in AJAX mode
1011
+	 * @param array|string $field_values Passed parameters to the form
1012
+	 *
1013
+	 * @since 1.9
1014
+	 *
1015
+	 * @return array Modified form array
1016
+	 */
1017
+	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1362 1018
 
1363
-        $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1019
+		// In case we have validated the form, use it to inject the validation results into the form render
1020
+		if( isset( $this->form_after_validation ) ) {
1021
+			$form = $this->form_after_validation;
1022
+		} else {
1023
+			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1024
+		}
1364 1025
 
1365
-        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1366
-    }
1026
+		$form = $this->filter_conditional_logic( $form );
1367 1027
 
1028
+		$form = $this->prefill_conditional_logic( $form );
1368 1029
 
1369
-    /**
1370
-     * Make validation work for Edit Entry
1371
-     *
1372
-     * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1373
-     * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1374
-     * fields. This goes through all the fields and if they're an invalid post field, we
1375
-     * set them as valid. If there are still issues, we'll return false.
1376
-     *
1377
-     * @param  [type] $validation_results [description]
1378
-     * @return [type]                     [description]
1379
-     */
1380
-    public function custom_validation( $validation_results ) {
1030
+		// for now we don't support Save and Continue feature.
1031
+		if( ! self::$supports_save_and_continue ) {
1032
+			unset( $form['save'] );
1033
+		}
1381 1034
 
1382
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1035
+		return $form;
1036
+	}
1383 1037
 
1384
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1038
+	/**
1039
+	 * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
1040
+	 *
1041
+	 * @since 1.16.2.2
1042
+	 *
1043
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
1044
+	 * @param GF_Field $field
1045
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1046
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1047
+	 * @param int $form_id Form ID
1048
+	 *
1049
+	 * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
1050
+	 */
1051
+	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1385 1052
 
1386
-        $gv_valid = true;
1053
+		if( GFCommon::is_post_field( $field ) ) {
1387 1054
 
1388
-        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1055
+			$message = null;
1389 1056
 
1390
-            $value = RGFormsModel::get_field_value( $field );
1391
-            $field_type = RGFormsModel::get_input_type( $field );
1057
+			// First, make sure they have the capability to edit the post.
1058
+			if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1392 1059
 
1393
-            // Validate always
1394
-            switch ( $field_type ) {
1060
+				/**
1061
+				 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1062
+				 * @param string $message The existing "You don't have permission..." text
1063
+				 */
1064
+				$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1395 1065
 
1066
+			} elseif( null === get_post( $this->entry['post_id'] ) ) {
1067
+				/**
1068
+				 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1069
+				 * @param string $message The existing "This field is not editable; the post no longer exists." text
1070
+				 */
1071
+				$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1072
+			}
1396 1073
 
1397
-                case 'fileupload' :
1398
-                case 'post_image':
1074
+			if( $message ) {
1075
+				$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1076
+			}
1077
+		}
1399 1078
 
1400
-                    // in case nothing is uploaded but there are already files saved
1401
-                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1402
-                        $field->failed_validation = false;
1403
-                        unset( $field->validation_message );
1404
-                    }
1079
+		return $field_content;
1080
+	}
1405 1081
 
1406
-                    // validate if multi file upload reached max number of files [maxFiles] => 2
1407
-                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1082
+	/**
1083
+	 *
1084
+	 * Fill-in the saved values into the form inputs
1085
+	 *
1086
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
1087
+	 * @param GF_Field $field
1088
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1089
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1090
+	 * @param int $form_id Form ID
1091
+	 *
1092
+	 * @return mixed
1093
+	 */
1094
+	public function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1095
+
1096
+		$gv_field = GravityView_Fields::get_associated_field( $field );
1097
+
1098
+		// If the form has been submitted, then we don't need to pre-fill the values,
1099
+		// Except for fileupload type and when a field input is overridden- run always!!
1100
+		if(
1101
+			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1102
+			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1103
+			&& ! GFCommon::is_product_field( $field->type )
1104
+			|| ! empty( $field_content )
1105
+			|| in_array( $field->type, array( 'honeypot' ) )
1106
+		) {
1107
+			return $field_content;
1108
+		}
1408 1109
 
1409
-                        $input_name = 'input_' . $field->id;
1410
-                        //uploaded
1411
-                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1110
+		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
1111
+		$field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
1412 1112
 
1413
-                        //existent
1414
-                        $entry = $this->get_entry();
1415
-                        $value = NULL;
1416
-                        if( isset( $entry[ $field->id ] ) ) {
1417
-                            $value = json_decode( $entry[ $field->id ], true );
1418
-                        }
1113
+		$field_value = $this->get_field_value( $field );
1419 1114
 
1420
-                        // count uploaded files and existent entry files
1421
-                        $count_files = count( $file_names ) + count( $value );
1115
+		// Prevent any PHP warnings, like undefined index
1116
+		ob_start();
1422 1117
 
1423
-                        if( $count_files > $field->maxFiles ) {
1424
-                            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1425
-                            $field->failed_validation = 1;
1426
-                            $gv_valid = false;
1118
+		$return = null;
1427 1119
 
1428
-                            // in case of error make sure the newest upload files are removed from the upload input
1429
-                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1430
-                        }
1120
+		/** @var GravityView_Field $gv_field */
1121
+		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1122
+			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1123
+		} else {
1124
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
1125
+		}
1431 1126
 
1432
-                    }
1127
+		// If there was output, it's an error
1128
+		$warnings = ob_get_clean();
1433 1129
 
1130
+		if( !empty( $warnings ) ) {
1131
+			do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1132
+		}
1434 1133
 
1435
-                    break;
1134
+		return $return;
1135
+	}
1436 1136
 
1437
-            }
1137
+	/**
1138
+	 * Modify the value for the current field input
1139
+	 *
1140
+	 * @param GF_Field $field
1141
+	 *
1142
+	 * @return array|mixed|string
1143
+	 */
1144
+	private function get_field_value( $field ) {
1438 1145
 
1439
-            // This field has failed validation.
1440
-            if( !empty( $field->failed_validation ) ) {
1146
+		/**
1147
+		 * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
1148
+		 * @param boolean True: override saved values; False: don't override (default)
1149
+		 * @param $field GF_Field object Gravity Forms field object
1150
+		 * @since 1.13
1151
+		 */
1152
+		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1441 1153
 
1442
-                do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1154
+		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1155
+		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1443 1156
 
1444
-                switch ( $field_type ) {
1157
+			$field_value = array();
1445 1158
 
1446
-                    // Captchas don't need to be re-entered.
1447
-                    case 'captcha':
1159
+			// only accept pre-populated values if the field doesn't have any choice selected.
1160
+			$allow_pre_populated = $field->allowsPrepopulate;
1448 1161
 
1449
-                        // Post Image fields aren't editable, so we un-fail them.
1450
-                    case 'post_image':
1451
-                        $field->failed_validation = false;
1452
-                        unset( $field->validation_message );
1453
-                        break;
1162
+			foreach ( (array)$field->inputs as $input ) {
1454 1163
 
1455
-                }
1164
+				$input_id = strval( $input['id'] );
1165
+                
1166
+				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1167
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1168
+					$allow_pre_populated = false;
1169
+				}
1456 1170
 
1457
-                // You can't continue inside a switch, so we do it after.
1458
-                if( empty( $field->failed_validation ) ) {
1459
-                    continue;
1460
-                }
1171
+			}
1461 1172
 
1462
-                // checks if the No Duplicates option is not validating entry against itself, since
1463
-                // we're editing a stored entry, it would also assume it's a duplicate.
1464
-                if( !empty( $field->noDuplicates ) ) {
1173
+			$pre_value = $field->get_value_submission( array(), false );
1465 1174
 
1466
-                    $entry = $this->get_entry();
1175
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1467 1176
 
1468
-                    // If the value of the entry is the same as the stored value
1469
-                    // Then we can assume it's not a duplicate, it's the same.
1470
-                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1471
-                        //if value submitted was not changed, then don't validate
1472
-                        $field->failed_validation = false;
1177
+		} else {
1473 1178
 
1474
-                        unset( $field->validation_message );
1179
+			$id = intval( $field->id );
1475 1180
 
1476
-                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1181
+			// get pre-populated value if exists
1182
+			$pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1477 1183
 
1478
-                        continue;
1479
-                    }
1480
-                }
1184
+			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1185
+			// or pre-populated value if not empty and set to override saved value
1186
+			$field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1481 1187
 
1482
-                // if here then probably we are facing the validation 'At least one field must be filled out'
1483
-                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1484
-                    unset( $field->validation_message );
1485
-	                $field->validation_message = false;
1486
-                    continue;
1487
-                }
1188
+			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1189
+			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1190
+				$categories = array();
1191
+				foreach ( explode( ',', $field_value ) as $cat_string ) {
1192
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1193
+				}
1194
+				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1195
+			}
1196
+
1197
+		}
1198
+
1199
+		// if value is empty get the default value if defined
1200
+		$field_value = $field->get_value_default_if_empty( $field_value );
1201
+
1202
+		/**
1203
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1204
+		 * @since 1.11
1205
+		 * @since 1.20 Added third param
1206
+		 * @param mixed $field_value field value used to populate the input
1207
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
1208
+		 * @param GravityView_Edit_Entry_Render $this Current object
1209
+		 */
1210
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1211
+
1212
+		/**
1213
+		 * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1214
+		 * @since 1.17
1215
+		 * @since 1.20 Added third param
1216
+		 * @param mixed $field_value field value used to populate the input
1217
+		 * @param GF_Field $field Gravity Forms field object
1218
+		 * @param GravityView_Edit_Entry_Render $this Current object
1219
+		 */
1220
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1221
+
1222
+		return $field_value;
1223
+	}
1224
+
1225
+
1226
+	// ---- Entry validation
1227
+
1228
+	/**
1229
+	 * Add field keys that Gravity Forms expects.
1230
+	 *
1231
+	 * @see GFFormDisplay::validate()
1232
+	 * @param  array $form GF Form
1233
+	 * @return array       Modified GF Form
1234
+	 */
1235
+	public function gform_pre_validation( $form ) {
1236
+
1237
+		if( ! $this->verify_nonce() ) {
1238
+			return $form;
1239
+		}
1240
+
1241
+		// Fix PHP warning regarding undefined index.
1242
+		foreach ( $form['fields'] as &$field) {
1243
+
1244
+			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1245
+			// expects certain field array items to be set.
1246
+			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1247
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1248
+			}
1249
+
1250
+			switch( RGFormsModel::get_input_type( $field ) ) {
1251
+
1252
+				/**
1253
+				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1254
+				 *
1255
+				 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1256
+				 *
1257
+				 * @hack
1258
+				 */
1259
+				case 'fileupload':
1260
+
1261
+					// Set the previous value
1262
+					$entry = $this->get_entry();
1263
+
1264
+					$input_name = 'input_'.$field->id;
1265
+					$form_id = $form['id'];
1266
+
1267
+					$value = NULL;
1268
+
1269
+					// Use the previous entry value as the default.
1270
+					if( isset( $entry[ $field->id ] ) ) {
1271
+						$value = $entry[ $field->id ];
1272
+					}
1273
+
1274
+					// If this is a single upload file
1275
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1276
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1277
+						$value = $file_path['url'];
1278
+
1279
+					} else {
1280
+
1281
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1282
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1283
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1284
+
1285
+					}
1286
+
1287
+					if( rgar($field, "multipleFiles") ) {
1488 1288
 
1489
-                $gv_valid = false;
1289
+						// If there are fresh uploads, process and merge them.
1290
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1291
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1292
+							$value = empty( $value ) ? '[]' : $value;
1293
+							$value = stripslashes_deep( $value );
1294
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1295
+						}
1490 1296
 
1491
-            }
1297
+					} else {
1492 1298
 
1493
-        }
1299
+						// A file already exists when editing an entry
1300
+						// We set this to solve issue when file upload fields are required.
1301
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1302
+
1303
+					}
1304
+
1305
+					$this->entry[ $input_name ] = $value;
1306
+					$_POST[ $input_name ] = $value;
1307
+
1308
+					break;
1309
+
1310
+				case 'number':
1311
+					// Fix "undefined index" issue at line 1286 in form_display.php
1312
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1313
+						$_POST['input_'.$field->id ] = NULL;
1314
+					}
1315
+					break;
1316
+			}
1317
+
1318
+		}
1319
+
1320
+		return $form;
1321
+	}
1322
+
1323
+
1324
+	/**
1325
+	 * Process validation for a edit entry submission
1326
+	 *
1327
+	 * Sets the `is_valid` object var
1328
+	 *
1329
+	 * @return void
1330
+	 */
1331
+	private function validate() {
1332
+
1333
+		/**
1334
+		 * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1335
+		 * GF User Registration Add-on version > 3.x has a different class name
1336
+		 * @since 1.16.2
1337
+		 */
1338
+		if ( class_exists( 'GF_User_Registration' ) ) {
1339
+			remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1340
+		} else  if ( class_exists( 'GFUser' ) ) {
1341
+			remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1342
+		}
1343
+
1344
+
1345
+		/**
1346
+		 * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1347
+		 * You can enter whatever you want!
1348
+		 * We try validating, and customize the results using `self::custom_validation()`
1349
+		 */
1350
+		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1351
+
1352
+		// Needed by the validate funtion
1353
+		$failed_validation_page = NULL;
1354
+		$field_values = RGForms::post( 'gform_field_values' );
1355
+
1356
+		// Prevent entry limit from running when editing an entry, also
1357
+		// prevent form scheduling from preventing editing
1358
+		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1359
+
1360
+		// Hide fields depending on Edit Entry settings
1361
+		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1362
+
1363
+		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1364
+
1365
+		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1366
+	}
1367
+
1368
+
1369
+	/**
1370
+	 * Make validation work for Edit Entry
1371
+	 *
1372
+	 * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1373
+	 * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1374
+	 * fields. This goes through all the fields and if they're an invalid post field, we
1375
+	 * set them as valid. If there are still issues, we'll return false.
1376
+	 *
1377
+	 * @param  [type] $validation_results [description]
1378
+	 * @return [type]                     [description]
1379
+	 */
1380
+	public function custom_validation( $validation_results ) {
1494 1381
 
1495
-        $validation_results['is_valid'] = $gv_valid;
1382
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1496 1383
 
1497
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1384
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1498 1385
 
1499
-        // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1500
-        $this->form_after_validation = $validation_results['form'];
1386
+		$gv_valid = true;
1501 1387
 
1502
-        return $validation_results;
1503
-    }
1388
+		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1504 1389
 
1390
+			$value = RGFormsModel::get_field_value( $field );
1391
+			$field_type = RGFormsModel::get_input_type( $field );
1505 1392
 
1506
-    /**
1507
-     * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1508
-     * Get the current entry and set it if it's not yet set.
1509
-     * @return array Gravity Forms entry array
1510
-     */
1511
-    public function get_entry() {
1393
+			// Validate always
1394
+			switch ( $field_type ) {
1512 1395
 
1513
-        if( empty( $this->entry ) ) {
1514
-            // Get the database value of the entry that's being edited
1515
-            $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1516
-        }
1517 1396
 
1518
-        return $this->entry;
1519
-    }
1397
+				case 'fileupload' :
1398
+				case 'post_image':
1520 1399
 
1400
+					// in case nothing is uploaded but there are already files saved
1401
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1402
+						$field->failed_validation = false;
1403
+						unset( $field->validation_message );
1404
+					}
1521 1405
 
1406
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1407
+					if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1522 1408
 
1523
-    // --- Filters
1409
+						$input_name = 'input_' . $field->id;
1410
+						//uploaded
1411
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1524 1412
 
1525
-    /**
1526
-     * Get the Edit Entry fields as configured in the View
1527
-     *
1528
-     * @since 1.8
1529
-     *
1530
-     * @param int $view_id
1531
-     *
1532
-     * @return array Array of fields that are configured in the Edit tab in the Admin
1533
-     */
1534
-    private function get_configured_edit_fields( $form, $view_id ) {
1413
+						//existent
1414
+						$entry = $this->get_entry();
1415
+						$value = NULL;
1416
+						if( isset( $entry[ $field->id ] ) ) {
1417
+							$value = json_decode( $entry[ $field->id ], true );
1418
+						}
1535 1419
 
1536
-        // Get all fields for form
1420
+						// count uploaded files and existent entry files
1421
+						$count_files = count( $file_names ) + count( $value );
1422
+
1423
+						if( $count_files > $field->maxFiles ) {
1424
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1425
+							$field->failed_validation = 1;
1426
+							$gv_valid = false;
1427
+
1428
+							// in case of error make sure the newest upload files are removed from the upload input
1429
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1430
+						}
1431
+
1432
+					}
1433
+
1434
+
1435
+					break;
1436
+
1437
+			}
1438
+
1439
+			// This field has failed validation.
1440
+			if( !empty( $field->failed_validation ) ) {
1441
+
1442
+				do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1443
+
1444
+				switch ( $field_type ) {
1445
+
1446
+					// Captchas don't need to be re-entered.
1447
+					case 'captcha':
1448
+
1449
+						// Post Image fields aren't editable, so we un-fail them.
1450
+					case 'post_image':
1451
+						$field->failed_validation = false;
1452
+						unset( $field->validation_message );
1453
+						break;
1454
+
1455
+				}
1456
+
1457
+				// You can't continue inside a switch, so we do it after.
1458
+				if( empty( $field->failed_validation ) ) {
1459
+					continue;
1460
+				}
1461
+
1462
+				// checks if the No Duplicates option is not validating entry against itself, since
1463
+				// we're editing a stored entry, it would also assume it's a duplicate.
1464
+				if( !empty( $field->noDuplicates ) ) {
1465
+
1466
+					$entry = $this->get_entry();
1467
+
1468
+					// If the value of the entry is the same as the stored value
1469
+					// Then we can assume it's not a duplicate, it's the same.
1470
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1471
+						//if value submitted was not changed, then don't validate
1472
+						$field->failed_validation = false;
1473
+
1474
+						unset( $field->validation_message );
1475
+
1476
+						do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1477
+
1478
+						continue;
1479
+					}
1480
+				}
1481
+
1482
+				// if here then probably we are facing the validation 'At least one field must be filled out'
1483
+				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1484
+					unset( $field->validation_message );
1485
+					$field->validation_message = false;
1486
+					continue;
1487
+				}
1488
+
1489
+				$gv_valid = false;
1490
+
1491
+			}
1492
+
1493
+		}
1494
+
1495
+		$validation_results['is_valid'] = $gv_valid;
1496
+
1497
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1498
+
1499
+		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1500
+		$this->form_after_validation = $validation_results['form'];
1501
+
1502
+		return $validation_results;
1503
+	}
1504
+
1505
+
1506
+	/**
1507
+	 * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1508
+	 * Get the current entry and set it if it's not yet set.
1509
+	 * @return array Gravity Forms entry array
1510
+	 */
1511
+	public function get_entry() {
1512
+
1513
+		if( empty( $this->entry ) ) {
1514
+			// Get the database value of the entry that's being edited
1515
+			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1516
+		}
1517
+
1518
+		return $this->entry;
1519
+	}
1520
+
1521
+
1522
+
1523
+	// --- Filters
1524
+
1525
+	/**
1526
+	 * Get the Edit Entry fields as configured in the View
1527
+	 *
1528
+	 * @since 1.8
1529
+	 *
1530
+	 * @param int $view_id
1531
+	 *
1532
+	 * @return array Array of fields that are configured in the Edit tab in the Admin
1533
+	 */
1534
+	private function get_configured_edit_fields( $form, $view_id ) {
1535
+
1536
+		// Get all fields for form
1537 1537
 		if ( defined( 'GRAVITYVIEW_FUTURE_CORE_LOADED' ) ) {
1538 1538
 			if ( \GV\View::exists( $view_id ) ) {
1539 1539
 				$view = \GV\View::by_id( $view_id );
@@ -1544,446 +1544,446 @@  discard block
 block discarded – undo
1544 1544
 			$properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1545 1545
 		}
1546 1546
 
1547
-        // If edit tab not yet configured, show all fields
1548
-        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1547
+		// If edit tab not yet configured, show all fields
1548
+		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1549 1549
 
1550
-        // Hide fields depending on admin settings
1551
-        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1550
+		// Hide fields depending on admin settings
1551
+		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1552 1552
 
1553
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1554
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1553
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1554
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1555 1555
 
1556
-        /**
1557
-         * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
1558
-         * @since 1.17
1559
-         * @param GF_Field[] $fields Gravity Forms form fields
1560
-         * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1561
-         * @param array $form GF Form array (`fields` key modified to have only fields configured to show in Edit Entry)
1562
-         * @param int $view_id View ID
1563
-         */
1564
-        $fields = apply_filters( 'gravityview/edit_entry/form_fields', $fields, $edit_fields, $form, $view_id );
1556
+		/**
1557
+		 * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
1558
+		 * @since 1.17
1559
+		 * @param GF_Field[] $fields Gravity Forms form fields
1560
+		 * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1561
+		 * @param array $form GF Form array (`fields` key modified to have only fields configured to show in Edit Entry)
1562
+		 * @param int $view_id View ID
1563
+		 */
1564
+		$fields = apply_filters( 'gravityview/edit_entry/form_fields', $fields, $edit_fields, $form, $view_id );
1565 1565
 
1566
-        return $fields;
1567
-    }
1568
-
1569
-
1570
-    /**
1571
-     * Filter area fields based on specified conditions
1572
-     *  - This filter removes the fields that have calculation configured
1573
-     *
1574
-     * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1575
-     * @access private
1576
-     * @param GF_Field[] $fields
1577
-     * @param array $configured_fields
1578
-     * @since  1.5
1579
-     * @return array $fields
1580
-     */
1581
-    private function filter_fields( $fields, $configured_fields ) {
1582
-
1583
-        if( empty( $fields ) || !is_array( $fields ) ) {
1584
-            return $fields;
1585
-        }
1586
-
1587
-        $edit_fields = array();
1588
-
1589
-        $field_type_blacklist = $this->loader->get_field_blacklist( $this->entry );
1590
-
1591
-        // First, remove blacklist or calculation fields
1592
-        foreach ( $fields as $key => $field ) {
1593
-
1594
-            // Remove the fields that have calculation properties and keep them to be used later
1595
-            // @since 1.16.2
1596
-            if( $field->has_calculation() ) {
1597
-                $this->fields_with_calculation[] = $field;
1598
-                // don't remove the calculation fields on form render.
1599
-            }
1600
-
1601
-            if( in_array( $field->type, $field_type_blacklist ) ) {
1602
-                unset( $fields[ $key ] );
1603
-            }
1604
-        }
1605
-
1606
-        // The Edit tab has not been configured, so we return all fields by default.
1607
-        if( empty( $configured_fields ) ) {
1608
-            return $fields;
1609
-        }
1610
-
1611
-        // The edit tab has been configured, so we loop through to configured settings
1612
-        foreach ( $configured_fields as $configured_field ) {
1613
-
1614
-	        /** @var GF_Field $field */
1615
-	        foreach ( $fields as $field ) {
1616
-
1617
-                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1618
-                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1619
-                    break;
1620
-                }
1621
-
1622
-            }
1623
-
1624
-        }
1625
-
1626
-        return $edit_fields;
1627
-
1628
-    }
1629
-
1630
-    /**
1631
-     * Override GF Form field properties with the ones defined on the View
1632
-     * @param  GF_Field $field GF Form field object
1633
-     * @param  array $field_setting  GV field options
1634
-     * @since  1.5
1635
-     * @return array|GF_Field
1636
-     */
1637
-    private function merge_field_properties( $field, $field_setting ) {
1638
-
1639
-        $return_field = $field;
1640
-
1641
-        if( empty( $field_setting['show_label'] ) ) {
1642
-            $return_field->label = '';
1643
-        } elseif ( !empty( $field_setting['custom_label'] ) ) {
1644
-            $return_field->label = $field_setting['custom_label'];
1645
-        }
1646
-
1647
-        if( !empty( $field_setting['custom_class'] ) ) {
1648
-            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1649
-        }
1650
-
1651
-        /**
1652
-         * Normalize page numbers - avoid conflicts with page validation
1653
-         * @since 1.6
1654
-         */
1655
-        $return_field->pageNumber = 1;
1656
-
1657
-        return $return_field;
1658
-
1659
-    }
1660
-
1661
-    /**
1662
-     * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1663
-     *
1664
-     * @since 1.9.1
1665
-     *
1666
-     * @param array|GF_Field[] $fields Gravity Forms form fields
1667
-     * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1668
-     * @param array $form GF Form array
1669
-     * @param int $view_id View ID
1670
-     *
1671
-     * @return array Possibly modified form array
1672
-     */
1673
-    private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1674
-
1675
-	    /**
1676
-         * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1677
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1678
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1679
-	     * @since 1.9.1
1680
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1681
-	     * @param array $form GF Form array
1682
-	     * @param int $view_id View ID
1683
-	     */
1684
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1685
-
1686
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1687
-            foreach( $fields as $k => $field ) {
1688
-                if( $field->adminOnly ) {
1689
-                    unset( $fields[ $k ] );
1690
-                }
1691
-            }
1692
-            return $fields;
1693
-        }
1694
-
1695
-	    foreach( $fields as &$field ) {
1696
-		    $field->adminOnly = false;
1697
-        }
1698
-
1699
-        return $fields;
1700
-    }
1701
-
1702
-    // --- Conditional Logic
1703
-
1704
-    /**
1705
-     * Conditional logic isn't designed to work with forms that already have content. When switching input values,
1706
-     * the dependent fields will be blank.
1707
-     *
1708
-     * Note: This is because GF populates a JavaScript variable with the input values. This is tough to filter at the input level;
1709
-     * via the `gform_field_value` filter; it requires lots of legwork. Doing it at the form level is easier.
1710
-     *
1711
-     * @since 1.17.4
1712
-     *
1713
-     * @param array $form Gravity Forms array object
1714
-     *
1715
-     * @return array $form, modified to fix conditional
1716
-     */
1717
-    function prefill_conditional_logic( $form ) {
1718
-
1719
-        if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1720
-            return $form;
1721
-        }
1722
-
1723
-        // Have Conditional Logic pre-fill fields as if the data were default values
1724
-        /** @var GF_Field $field */
1725
-        foreach ( $form['fields'] as &$field ) {
1726
-
1727
-            if( 'checkbox' === $field->type ) {
1728
-                foreach ( $field->get_entry_inputs() as $key => $input ) {
1729
-                    $input_id = $input['id'];
1730
-                    $choice = $field->choices[ $key ];
1731
-                    $value = rgar( $this->entry, $input_id );
1732
-                    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1733
-                    if( $match ) {
1734
-                        $field->choices[ $key ]['isSelected'] = true;
1735
-                    }
1736
-                }
1737
-            } else {
1738
-
1739
-                // We need to run through each field to set the default values
1740
-                foreach ( $this->entry as $field_id => $field_value ) {
1741
-
1742
-                    if( floatval( $field_id ) === floatval( $field->id ) ) {
1743
-
1744
-                        if( 'list' === $field->type ) {
1745
-                            $list_rows = maybe_unserialize( $field_value );
1746
-
1747
-                            $list_field_value = array();
1748
-                            foreach ( (array) $list_rows as $row ) {
1749
-                                foreach ( (array) $row as $column ) {
1750
-                                    $list_field_value[] = $column;
1751
-                                }
1752
-                            }
1753
-
1754
-                            $field->defaultValue = serialize( $list_field_value );
1755
-                        } else {
1756
-                            $field->defaultValue = $field_value;
1757
-                        }
1758
-                    }
1759
-                }
1760
-            }
1761
-        }
1762
-
1763
-        return $form;
1764
-    }
1765
-
1766
-    /**
1767
-     * Remove the conditional logic rules from the form button and the form fields, if needed.
1768
-     *
1769
-     * @todo Merge with caller method
1770
-     * @since 1.9
1771
-     *
1772
-     * @param array $form Gravity Forms form
1773
-     * @return array Modified form, if not using Conditional Logic
1774
-     */
1775
-    private function filter_conditional_logic( $form ) {
1776
-
1777
-        /**
1778
-         * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1779
-         * @since 1.9
1780
-         * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1781
-         * @param array $form Gravity Forms form
1782
-         */
1783
-        $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1784
-
1785
-        if( $use_conditional_logic ) {
1786
-            return $form;
1787
-        }
1788
-
1789
-        foreach( $form['fields'] as &$field ) {
1790
-            /* @var GF_Field $field */
1791
-            $field->conditionalLogic = null;
1792
-        }
1793
-
1794
-        unset( $form['button']['conditionalLogic'] );
1795
-
1796
-        return $form;
1797
-
1798
-    }
1799
-
1800
-    /**
1801
-     * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1802
-     *
1803
-     * @since 1.9
1804
-     *
1805
-     * @param $has_conditional_logic
1806
-     * @param $form
1807
-     * @return mixed
1808
-     */
1809
-    public function manage_conditional_logic( $has_conditional_logic, $form ) {
1810
-
1811
-        if( ! $this->is_edit_entry() ) {
1812
-            return $has_conditional_logic;
1813
-        }
1814
-
1815
-	    /** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
1816
-        return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1817
-    }
1818
-
1819
-
1820
-    // --- User checks and nonces
1821
-
1822
-    /**
1823
-     * Check if the user can edit the entry
1824
-     *
1825
-     * - Is the nonce valid?
1826
-     * - Does the user have the right caps for the entry
1827
-     * - Is the entry in the trash?
1828
-     *
1829
-     * @todo Move to GVCommon
1830
-     *
1831
-     * @param  boolean $echo Show error messages in the form?
1832
-     * @return boolean        True: can edit form. False: nope.
1833
-     */
1834
-    private function user_can_edit_entry( $echo = false ) {
1835
-
1836
-        $error = NULL;
1837
-
1838
-        /**
1839
-         *  1. Permalinks are turned off
1840
-         *  2. There are two entries embedded using oEmbed
1841
-         *  3. One of the entries has just been saved
1842
-         */
1843
-        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1844
-
1845
-            $error = true;
1846
-
1847
-        }
1848
-
1849
-        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1850
-
1851
-            $error = true;
1852
-
1853
-        } elseif( ! $this->verify_nonce() ) {
1854
-
1855
-            /**
1856
-             * If the Entry is embedded, there may be two entries on the same page.
1857
-             * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1858
-             */
1859
-            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1860
-                $error = true;
1861
-            } else {
1862
-                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1863
-            }
1864
-
1865
-        }
1866
-
1867
-        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1868
-            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
1869
-        }
1870
-
1871
-        if( $this->entry['status'] === 'trash' ) {
1872
-            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1873
-        }
1566
+		return $fields;
1567
+	}
1874 1568
 
1875
-        // No errors; everything's fine here!
1876
-        if( empty( $error ) ) {
1877
-            return true;
1878
-        }
1879 1569
 
1880
-        if( $echo && $error !== true ) {
1570
+	/**
1571
+	 * Filter area fields based on specified conditions
1572
+	 *  - This filter removes the fields that have calculation configured
1573
+	 *
1574
+	 * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1575
+	 * @access private
1576
+	 * @param GF_Field[] $fields
1577
+	 * @param array $configured_fields
1578
+	 * @since  1.5
1579
+	 * @return array $fields
1580
+	 */
1581
+	private function filter_fields( $fields, $configured_fields ) {
1881 1582
 
1882
-	        $error = esc_html( $error );
1583
+		if( empty( $fields ) || !is_array( $fields ) ) {
1584
+			return $fields;
1585
+		}
1883 1586
 
1884
-	        /**
1885
-	         * @since 1.9
1886
-	         */
1887
-	        if ( ! empty( $this->entry ) ) {
1888
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1889
-	        }
1587
+		$edit_fields = array();
1890 1588
 
1891
-            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1892
-        }
1589
+		$field_type_blacklist = $this->loader->get_field_blacklist( $this->entry );
1893 1590
 
1894
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1591
+		// First, remove blacklist or calculation fields
1592
+		foreach ( $fields as $key => $field ) {
1895 1593
 
1896
-        return false;
1897
-    }
1898
-
1899
-
1900
-    /**
1901
-     * Check whether a field is editable by the current user, and optionally display an error message
1902
-     * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1903
-     * @param  array  $field Field or field settings array
1904
-     * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1905
-     * @return boolean         True: user can edit the current field; False: nope, they can't.
1906
-     */
1907
-    private function user_can_edit_field( $field, $echo = false ) {
1594
+			// Remove the fields that have calculation properties and keep them to be used later
1595
+			// @since 1.16.2
1596
+			if( $field->has_calculation() ) {
1597
+				$this->fields_with_calculation[] = $field;
1598
+				// don't remove the calculation fields on form render.
1599
+			}
1908 1600
 
1909
-        $error = NULL;
1601
+			if( in_array( $field->type, $field_type_blacklist ) ) {
1602
+				unset( $fields[ $key ] );
1603
+			}
1604
+		}
1910 1605
 
1911
-        if( ! $this->check_user_cap_edit_field( $field ) ) {
1912
-            $error = __( 'You do not have permission to edit this field.', 'gravityview');
1913
-        }
1606
+		// The Edit tab has not been configured, so we return all fields by default.
1607
+		if( empty( $configured_fields ) ) {
1608
+			return $fields;
1609
+		}
1914 1610
 
1915
-        // No errors; everything's fine here!
1916
-        if( empty( $error ) ) {
1917
-            return true;
1918
-        }
1611
+		// The edit tab has been configured, so we loop through to configured settings
1612
+		foreach ( $configured_fields as $configured_field ) {
1919 1613
 
1920
-        if( $echo ) {
1921
-            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1922
-        }
1923
-
1924
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1614
+			/** @var GF_Field $field */
1615
+			foreach ( $fields as $field ) {
1925 1616
 
1926
-        return false;
1617
+				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1618
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1619
+					break;
1620
+				}
1927 1621
 
1928
-    }
1622
+			}
1929 1623
 
1624
+		}
1930 1625
 
1931
-    /**
1932
-     * checks if user has permissions to edit a specific field
1933
-     *
1934
-     * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1935
-     *
1936
-     * @param  [type] $field [description]
1937
-     * @return bool
1938
-     */
1939
-    private function check_user_cap_edit_field( $field ) {
1626
+		return $edit_fields;
1940 1627
 
1941
-        // If they can edit any entries (as defined in Gravity Forms), we're good.
1942
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1943
-            return true;
1944
-        }
1628
+	}
1945 1629
 
1946
-        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1630
+	/**
1631
+	 * Override GF Form field properties with the ones defined on the View
1632
+	 * @param  GF_Field $field GF Form field object
1633
+	 * @param  array $field_setting  GV field options
1634
+	 * @since  1.5
1635
+	 * @return array|GF_Field
1636
+	 */
1637
+	private function merge_field_properties( $field, $field_setting ) {
1947 1638
 
1948
-        // If the field has custom editing capaibilities set, check those
1949
-        if( $field_cap ) {
1950
-            return GVCommon::has_cap( $field['allow_edit_cap'] );
1951
-        }
1952
-
1953
-        return false;
1954
-    }
1639
+		$return_field = $field;
1955 1640
 
1641
+		if( empty( $field_setting['show_label'] ) ) {
1642
+			$return_field->label = '';
1643
+		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1644
+			$return_field->label = $field_setting['custom_label'];
1645
+		}
1956 1646
 
1957
-    /**
1958
-     * Is the current nonce valid for editing the entry?
1959
-     * @return boolean
1960
-     */
1961
-    public function verify_nonce() {
1647
+		if( !empty( $field_setting['custom_class'] ) ) {
1648
+			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1649
+		}
1962 1650
 
1963
-        // Verify form submitted for editing single
1964
-        if( $this->is_edit_entry_submission() ) {
1965
-            $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1966
-        }
1651
+		/**
1652
+		 * Normalize page numbers - avoid conflicts with page validation
1653
+		 * @since 1.6
1654
+		 */
1655
+		$return_field->pageNumber = 1;
1967 1656
 
1968
-        // Verify
1969
-        else if( ! $this->is_edit_entry() ) {
1970
-            $valid = false;
1971
-        }
1657
+		return $return_field;
1972 1658
 
1973
-        else {
1974
-            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1975
-        }
1659
+	}
1660
+
1661
+	/**
1662
+	 * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1663
+	 *
1664
+	 * @since 1.9.1
1665
+	 *
1666
+	 * @param array|GF_Field[] $fields Gravity Forms form fields
1667
+	 * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1668
+	 * @param array $form GF Form array
1669
+	 * @param int $view_id View ID
1670
+	 *
1671
+	 * @return array Possibly modified form array
1672
+	 */
1673
+	private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1674
+
1675
+		/**
1676
+		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1677
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1678
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1679
+		 * @since 1.9.1
1680
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1681
+		 * @param array $form GF Form array
1682
+		 * @param int $view_id View ID
1683
+		 */
1684
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1685
+
1686
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1687
+			foreach( $fields as $k => $field ) {
1688
+				if( $field->adminOnly ) {
1689
+					unset( $fields[ $k ] );
1690
+				}
1691
+			}
1692
+			return $fields;
1693
+		}
1694
+
1695
+		foreach( $fields as &$field ) {
1696
+			$field->adminOnly = false;
1697
+		}
1698
+
1699
+		return $fields;
1700
+	}
1701
+
1702
+	// --- Conditional Logic
1703
+
1704
+	/**
1705
+	 * Conditional logic isn't designed to work with forms that already have content. When switching input values,
1706
+	 * the dependent fields will be blank.
1707
+	 *
1708
+	 * Note: This is because GF populates a JavaScript variable with the input values. This is tough to filter at the input level;
1709
+	 * via the `gform_field_value` filter; it requires lots of legwork. Doing it at the form level is easier.
1710
+	 *
1711
+	 * @since 1.17.4
1712
+	 *
1713
+	 * @param array $form Gravity Forms array object
1714
+	 *
1715
+	 * @return array $form, modified to fix conditional
1716
+	 */
1717
+	function prefill_conditional_logic( $form ) {
1718
+
1719
+		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1720
+			return $form;
1721
+		}
1722
+
1723
+		// Have Conditional Logic pre-fill fields as if the data were default values
1724
+		/** @var GF_Field $field */
1725
+		foreach ( $form['fields'] as &$field ) {
1726
+
1727
+			if( 'checkbox' === $field->type ) {
1728
+				foreach ( $field->get_entry_inputs() as $key => $input ) {
1729
+					$input_id = $input['id'];
1730
+					$choice = $field->choices[ $key ];
1731
+					$value = rgar( $this->entry, $input_id );
1732
+					$match = RGFormsModel::choice_value_match( $field, $choice, $value );
1733
+					if( $match ) {
1734
+						$field->choices[ $key ]['isSelected'] = true;
1735
+					}
1736
+				}
1737
+			} else {
1738
+
1739
+				// We need to run through each field to set the default values
1740
+				foreach ( $this->entry as $field_id => $field_value ) {
1741
+
1742
+					if( floatval( $field_id ) === floatval( $field->id ) ) {
1743
+
1744
+						if( 'list' === $field->type ) {
1745
+							$list_rows = maybe_unserialize( $field_value );
1746
+
1747
+							$list_field_value = array();
1748
+							foreach ( (array) $list_rows as $row ) {
1749
+								foreach ( (array) $row as $column ) {
1750
+									$list_field_value[] = $column;
1751
+								}
1752
+							}
1753
+
1754
+							$field->defaultValue = serialize( $list_field_value );
1755
+						} else {
1756
+							$field->defaultValue = $field_value;
1757
+						}
1758
+					}
1759
+				}
1760
+			}
1761
+		}
1762
+
1763
+		return $form;
1764
+	}
1765
+
1766
+	/**
1767
+	 * Remove the conditional logic rules from the form button and the form fields, if needed.
1768
+	 *
1769
+	 * @todo Merge with caller method
1770
+	 * @since 1.9
1771
+	 *
1772
+	 * @param array $form Gravity Forms form
1773
+	 * @return array Modified form, if not using Conditional Logic
1774
+	 */
1775
+	private function filter_conditional_logic( $form ) {
1776
+
1777
+		/**
1778
+		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1779
+		 * @since 1.9
1780
+		 * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1781
+		 * @param array $form Gravity Forms form
1782
+		 */
1783
+		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1784
+
1785
+		if( $use_conditional_logic ) {
1786
+			return $form;
1787
+		}
1788
+
1789
+		foreach( $form['fields'] as &$field ) {
1790
+			/* @var GF_Field $field */
1791
+			$field->conditionalLogic = null;
1792
+		}
1793
+
1794
+		unset( $form['button']['conditionalLogic'] );
1795
+
1796
+		return $form;
1797
+
1798
+	}
1799
+
1800
+	/**
1801
+	 * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1802
+	 *
1803
+	 * @since 1.9
1804
+	 *
1805
+	 * @param $has_conditional_logic
1806
+	 * @param $form
1807
+	 * @return mixed
1808
+	 */
1809
+	public function manage_conditional_logic( $has_conditional_logic, $form ) {
1810
+
1811
+		if( ! $this->is_edit_entry() ) {
1812
+			return $has_conditional_logic;
1813
+		}
1814
+
1815
+		/** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
1816
+		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1817
+	}
1818
+
1819
+
1820
+	// --- User checks and nonces
1821
+
1822
+	/**
1823
+	 * Check if the user can edit the entry
1824
+	 *
1825
+	 * - Is the nonce valid?
1826
+	 * - Does the user have the right caps for the entry
1827
+	 * - Is the entry in the trash?
1828
+	 *
1829
+	 * @todo Move to GVCommon
1830
+	 *
1831
+	 * @param  boolean $echo Show error messages in the form?
1832
+	 * @return boolean        True: can edit form. False: nope.
1833
+	 */
1834
+	private function user_can_edit_entry( $echo = false ) {
1835
+
1836
+		$error = NULL;
1837
+
1838
+		/**
1839
+		 *  1. Permalinks are turned off
1840
+		 *  2. There are two entries embedded using oEmbed
1841
+		 *  3. One of the entries has just been saved
1842
+		 */
1843
+		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1844
+
1845
+			$error = true;
1846
+
1847
+		}
1848
+
1849
+		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1850
+
1851
+			$error = true;
1852
+
1853
+		} elseif( ! $this->verify_nonce() ) {
1854
+
1855
+			/**
1856
+			 * If the Entry is embedded, there may be two entries on the same page.
1857
+			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1858
+			 */
1859
+			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1860
+				$error = true;
1861
+			} else {
1862
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1863
+			}
1864
+
1865
+		}
1866
+
1867
+		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1868
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
1869
+		}
1870
+
1871
+		if( $this->entry['status'] === 'trash' ) {
1872
+			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1873
+		}
1874
+
1875
+		// No errors; everything's fine here!
1876
+		if( empty( $error ) ) {
1877
+			return true;
1878
+		}
1976 1879
 
1977
-        /**
1978
-         * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1979
-         * @since 1.13
1980
-         * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1981
-         * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1982
-         */
1983
-        $valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1880
+		if( $echo && $error !== true ) {
1881
+
1882
+			$error = esc_html( $error );
1883
+
1884
+			/**
1885
+			 * @since 1.9
1886
+			 */
1887
+			if ( ! empty( $this->entry ) ) {
1888
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1889
+			}
1890
+
1891
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1892
+		}
1893
+
1894
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1895
+
1896
+		return false;
1897
+	}
1898
+
1899
+
1900
+	/**
1901
+	 * Check whether a field is editable by the current user, and optionally display an error message
1902
+	 * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1903
+	 * @param  array  $field Field or field settings array
1904
+	 * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1905
+	 * @return boolean         True: user can edit the current field; False: nope, they can't.
1906
+	 */
1907
+	private function user_can_edit_field( $field, $echo = false ) {
1908
+
1909
+		$error = NULL;
1910
+
1911
+		if( ! $this->check_user_cap_edit_field( $field ) ) {
1912
+			$error = __( 'You do not have permission to edit this field.', 'gravityview');
1913
+		}
1914
+
1915
+		// No errors; everything's fine here!
1916
+		if( empty( $error ) ) {
1917
+			return true;
1918
+		}
1984 1919
 
1985
-        return $valid;
1986
-    }
1920
+		if( $echo ) {
1921
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1922
+		}
1923
+
1924
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1925
+
1926
+		return false;
1927
+
1928
+	}
1929
+
1930
+
1931
+	/**
1932
+	 * checks if user has permissions to edit a specific field
1933
+	 *
1934
+	 * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1935
+	 *
1936
+	 * @param  [type] $field [description]
1937
+	 * @return bool
1938
+	 */
1939
+	private function check_user_cap_edit_field( $field ) {
1940
+
1941
+		// If they can edit any entries (as defined in Gravity Forms), we're good.
1942
+		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1943
+			return true;
1944
+		}
1945
+
1946
+		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1947
+
1948
+		// If the field has custom editing capaibilities set, check those
1949
+		if( $field_cap ) {
1950
+			return GVCommon::has_cap( $field['allow_edit_cap'] );
1951
+		}
1952
+
1953
+		return false;
1954
+	}
1955
+
1956
+
1957
+	/**
1958
+	 * Is the current nonce valid for editing the entry?
1959
+	 * @return boolean
1960
+	 */
1961
+	public function verify_nonce() {
1962
+
1963
+		// Verify form submitted for editing single
1964
+		if( $this->is_edit_entry_submission() ) {
1965
+			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1966
+		}
1967
+
1968
+		// Verify
1969
+		else if( ! $this->is_edit_entry() ) {
1970
+			$valid = false;
1971
+		}
1972
+
1973
+		else {
1974
+			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1975
+		}
1976
+
1977
+		/**
1978
+		 * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1979
+		 * @since 1.13
1980
+		 * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1981
+		 * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1982
+		 */
1983
+		$valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1984
+
1985
+		return $valid;
1986
+	}
1987 1987
 
1988 1988
 
1989 1989
 	/**
Please login to merge, or discard this patch.
includes/class-gravityview-change-entry-creator.php 1 patch
Indentation   +205 added lines, -205 removed lines patch added patch discarded remove patch
@@ -5,251 +5,251 @@
 block discarded – undo
5 5
  */
6 6
 class GravityView_Change_Entry_Creator {
7 7
 
8
-    function __construct() {
9
-
10
-    	/**
11
-    	 * @since  1.5.1
12
-    	 */
13
-    	add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
14
-
15
-    	// ONLY ADMIN FROM HERE ON.
16
-    	if( !is_admin() ) { return; }
17
-
18
-	    /**
19
-         * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20
-	     * @since 1.7.4
21
-	     * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22
-	     */
23
-	    if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
24
-		    return;
25
-	    }
26
-
27
-        /**
28
-         * Use `init` to fix bbPress warning
29
-         * @see https://bbpress.trac.wordpress.org/ticket/2309
30
-         */
31
-    	add_action('init', array( $this, 'load'), 100 );
32
-
33
-    	add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
34
-
35
-    }
36
-
37
-    /**
38
-     * When an user is created using the User Registration add-on, assign the entry to them
39
-     *
40
-     * @since  1.5.1
41
-     * @uses RGFormsModel::update_lead_property() Modify the entry `created_by` field
42
-     * @param  int $user_id  WordPress User ID
43
-     * @param  array $config   User registration feed configuration
44
-     * @param  array  $entry     GF Entry array
45
-     * @param  string $password User password
46
-     * @return void
47
-     */
48
-    function assign_new_user_to_lead( $user_id, $config, $entry = array(), $password = '' ) {
49
-
50
-    	/**
51
-    	 * Disable assigning the new user to the entry by returning false.
52
-    	 * @param  int $user_id  WordPress User ID
53
-	     * @param  array $config   User registration feed configuration
54
-	     * @param  array  $entry     GF Entry array
55
-    	 */
56
-    	$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57
-
58
-    	// If filter returns false, do not process
59
-    	if( empty( $assign_to_lead ) ) {
60
-    		return;
61
-    	}
62
-
63
-    	// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
-    	$result = RGFormsModel::update_lead_property( $entry['id'], 'created_by', $user_id, false, true );
65
-
66
-    	if( empty( $result ) ) {
67
-    		$status = __('Error', 'gravityview');
68
-    	} else {
69
-    		$status = __('Success', 'gravityview');
70
-    	}
71
-
72
-    	$note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
73
-
74
-    	do_action( 'gravityview_log_debug', 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - '.$note );
75
-
76
-	    /**
77
-	     * @filter `gravityview_disable_change_entry_creator_note` Disable adding a note when changing the entry creator
78
-	     * @since 1.21.5
79
-	     * @param boolean $disable Disable the Change Entry Creator note. Default: false.
80
-	     */
81
-	    if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
82
-		    return;
83
-	    }
84
-
85
-        GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
8
+	function __construct() {
9
+
10
+		/**
11
+		 * @since  1.5.1
12
+		 */
13
+		add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
14
+
15
+		// ONLY ADMIN FROM HERE ON.
16
+		if( !is_admin() ) { return; }
17
+
18
+		/**
19
+		 * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20
+		 * @since 1.7.4
21
+		 * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22
+		 */
23
+		if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
24
+			return;
25
+		}
26
+
27
+		/**
28
+		 * Use `init` to fix bbPress warning
29
+		 * @see https://bbpress.trac.wordpress.org/ticket/2309
30
+		 */
31
+		add_action('init', array( $this, 'load'), 100 );
32
+
33
+		add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
34
+
35
+	}
36
+
37
+	/**
38
+	 * When an user is created using the User Registration add-on, assign the entry to them
39
+	 *
40
+	 * @since  1.5.1
41
+	 * @uses RGFormsModel::update_lead_property() Modify the entry `created_by` field
42
+	 * @param  int $user_id  WordPress User ID
43
+	 * @param  array $config   User registration feed configuration
44
+	 * @param  array  $entry     GF Entry array
45
+	 * @param  string $password User password
46
+	 * @return void
47
+	 */
48
+	function assign_new_user_to_lead( $user_id, $config, $entry = array(), $password = '' ) {
49
+
50
+		/**
51
+		 * Disable assigning the new user to the entry by returning false.
52
+		 * @param  int $user_id  WordPress User ID
53
+		 * @param  array $config   User registration feed configuration
54
+		 * @param  array  $entry     GF Entry array
55
+		 */
56
+		$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57
+
58
+		// If filter returns false, do not process
59
+		if( empty( $assign_to_lead ) ) {
60
+			return;
61
+		}
62
+
63
+		// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
+		$result = RGFormsModel::update_lead_property( $entry['id'], 'created_by', $user_id, false, true );
65
+
66
+		if( empty( $result ) ) {
67
+			$status = __('Error', 'gravityview');
68
+		} else {
69
+			$status = __('Success', 'gravityview');
70
+		}
71
+
72
+		$note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
73
+
74
+		do_action( 'gravityview_log_debug', 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - '.$note );
75
+
76
+		/**
77
+		 * @filter `gravityview_disable_change_entry_creator_note` Disable adding a note when changing the entry creator
78
+		 * @since 1.21.5
79
+		 * @param boolean $disable Disable the Change Entry Creator note. Default: false.
80
+		 */
81
+		if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
82
+			return;
83
+		}
84
+
85
+		GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
86 86
 
87
-    }
87
+	}
88 88
 
89
-    /**
90
-     * Disable previous functionality; use this one as the canonical.
91
-     * @return void
92
-     */
93
-    function prevent_conflicts() {
89
+	/**
90
+	 * Disable previous functionality; use this one as the canonical.
91
+	 * @return void
92
+	 */
93
+	function prevent_conflicts() {
94 94
 
95
-    	// Plugin that was provided here:
96
-    	// @link https://gravityview.co/support/documentation/201991205/
97
-    	remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
98
-    	remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
99
-
100
-    	// Disable for Gravity Forms Add-ons 3.6.2 and lower
101
-    	if( class_exists( 'KWS_GF_Change_Lead_Creator' ) ) {
95
+		// Plugin that was provided here:
96
+		// @link https://gravityview.co/support/documentation/201991205/
97
+		remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
98
+		remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
99
+
100
+		// Disable for Gravity Forms Add-ons 3.6.2 and lower
101
+		if( class_exists( 'KWS_GF_Change_Lead_Creator' ) ) {
102 102
 
103
-    		$Old_Lead_Creator = new KWS_GF_Change_Lead_Creator;
103
+			$Old_Lead_Creator = new KWS_GF_Change_Lead_Creator;
104 104
 
105
-    		// Now, no validation is required in the methods; let's hook in.
106
-    		remove_action('admin_init', array( $Old_Lead_Creator, 'set_screen_mode' ) );
107
-
108
-    		remove_action("gform_entry_info", array( $Old_Lead_Creator, 'add_select' ), 10 );
109
-
110
-    		remove_action("gform_after_update_entry", array( $Old_Lead_Creator, 'update_entry_creator' ), 10 );
111
-    	}
112
-
113
-    }
114
-
115
-    /**
116
-     * @since  3.6.3
117
-     * @return void
118
-     */
119
-    function load() {
105
+			// Now, no validation is required in the methods; let's hook in.
106
+			remove_action('admin_init', array( $Old_Lead_Creator, 'set_screen_mode' ) );
107
+
108
+			remove_action("gform_entry_info", array( $Old_Lead_Creator, 'add_select' ), 10 );
109
+
110
+			remove_action("gform_after_update_entry", array( $Old_Lead_Creator, 'update_entry_creator' ), 10 );
111
+		}
112
+
113
+	}
114
+
115
+	/**
116
+	 * @since  3.6.3
117
+	 * @return void
118
+	 */
119
+	function load() {
120 120
 
121
-    	// Does GF exist?
122
-        if( !class_exists('GFCommon') ) {
123
-            return;
124
-        }
121
+		// Does GF exist?
122
+		if( !class_exists('GFCommon') ) {
123
+			return;
124
+		}
125 125
 
126
-        // Can the user edit entries?
127
-        if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
128
-            return;
129
-        }
126
+		// Can the user edit entries?
127
+		if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
128
+			return;
129
+		}
130 130
 
131
-        // If screen mode isn't set, then we're in the wrong place.
132
-        if( empty( $_REQUEST['screen_mode'] ) ) {
133
-            return;
134
-        }
131
+		// If screen mode isn't set, then we're in the wrong place.
132
+		if( empty( $_REQUEST['screen_mode'] ) ) {
133
+			return;
134
+		}
135 135
 
136
-        // Now, no validation is required in the methods; let's hook in.
137
-        add_action('admin_init', array( &$this, 'set_screen_mode' ) );
136
+		// Now, no validation is required in the methods; let's hook in.
137
+		add_action('admin_init', array( &$this, 'set_screen_mode' ) );
138 138
 
139
-        add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
139
+		add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
140 140
 
141
-        add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
141
+		add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
142 142
 
143
-    }
143
+	}
144 144
 
145
-    /**
146
-     * Allows for edit links to work with a link instead of a form (GET instead of POST)
147
-     * @return void
148
-     */
149
-    function set_screen_mode() {
145
+	/**
146
+	 * Allows for edit links to work with a link instead of a form (GET instead of POST)
147
+	 * @return void
148
+	 */
149
+	function set_screen_mode() {
150 150
 
151
-    	// If $_GET['screen_mode'] is set to edit, set $_POST value
152
-        if( rgget('screen_mode') === 'edit' ) {
153
-            $_POST["screen_mode"] = 'edit';
154
-        }
151
+		// If $_GET['screen_mode'] is set to edit, set $_POST value
152
+		if( rgget('screen_mode') === 'edit' ) {
153
+			$_POST["screen_mode"] = 'edit';
154
+		}
155 155
 
156
-    }
156
+	}
157 157
 
158
-    /**
159
-     * When the entry creator is changed, add a note to the entry
160
-     * @param  array $form   GF entry array
161
-     * @param  int $entry_id Entry ID
162
-     * @return void
163
-     */
164
-    function update_entry_creator($form, $entry_id) {
165
-            global $current_user;
158
+	/**
159
+	 * When the entry creator is changed, add a note to the entry
160
+	 * @param  array $form   GF entry array
161
+	 * @param  int $entry_id Entry ID
162
+	 * @return void
163
+	 */
164
+	function update_entry_creator($form, $entry_id) {
165
+			global $current_user;
166 166
 
167
-        // Update the entry
168
-        $created_by = absint( rgpost('created_by') );
167
+		// Update the entry
168
+		$created_by = absint( rgpost('created_by') );
169 169
 
170
-        RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
170
+		RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
171 171
 
172
-        // If the creator has changed, let's add a note about who it used to be.
173
-        $originally_created_by = rgpost('originally_created_by');
172
+		// If the creator has changed, let's add a note about who it used to be.
173
+		$originally_created_by = rgpost('originally_created_by');
174 174
 
175
-        // If there's no owner and there didn't used to be, keep going
176
-        if( empty( $originally_created_by ) && empty( $created_by ) ) {
177
-            return;
178
-        }
175
+		// If there's no owner and there didn't used to be, keep going
176
+		if( empty( $originally_created_by ) && empty( $created_by ) ) {
177
+			return;
178
+		}
179 179
 
180
-        // If the values have changed
181
-        if( absint( $originally_created_by ) !== absint( $created_by ) ) {
180
+		// If the values have changed
181
+		if( absint( $originally_created_by ) !== absint( $created_by ) ) {
182 182
 
183
-            $user_data = get_userdata($current_user->ID);
183
+			$user_data = get_userdata($current_user->ID);
184 184
 
185
-            $user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
185
+			$user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
186 186
 
187
-            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
187
+			$original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
188 188
 
189
-            if( !empty( $originally_created_by ) ) {
190
-                $originally_created_by_user_data = get_userdata($originally_created_by);
191
-                $original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
192
-            }
189
+			if( !empty( $originally_created_by ) ) {
190
+				$originally_created_by_user_data = get_userdata($originally_created_by);
191
+				$original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
192
+			}
193 193
 
194
-            if( !empty( $created_by ) ) {
195
-                $created_by_user_data =  get_userdata($created_by);
196
-                $created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
197
-            }
194
+			if( !empty( $created_by ) ) {
195
+				$created_by_user_data =  get_userdata($created_by);
196
+				$created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
197
+			}
198 198
 
199
-            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
200
-        }
199
+			GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
200
+		}
201 201
 
202
-    }
202
+	}
203 203
 
204
-    /**
205
-     * Output the select to change the entry creator
206
-     * @param int $form_id GF Form ID
207
-     * @param array $entry    GF entry array
208
-     * @return void
209
-     */
210
-    function add_select($form_id, $entry ) {
204
+	/**
205
+	 * Output the select to change the entry creator
206
+	 * @param int $form_id GF Form ID
207
+	 * @param array $entry    GF entry array
208
+	 * @return void
209
+	 */
210
+	function add_select($form_id, $entry ) {
211 211
 
212
-        if( rgpost('screen_mode') !== 'edit' ) {
213
-            return;
214
-        }
212
+		if( rgpost('screen_mode') !== 'edit' ) {
213
+			return;
214
+		}
215 215
 
216
-        $created_by_id = rgar( $entry, 'created_by' );
216
+		$created_by_id = rgar( $entry, 'created_by' );
217 217
 
218
-        $users = GVCommon::get_users( 'change_entry_creator' );
218
+		$users = GVCommon::get_users( 'change_entry_creator' );
219 219
 
220
-        $is_created_by_in_users = wp_list_filter( $users, array( 'ID' => $created_by_id ) );
220
+		$is_created_by_in_users = wp_list_filter( $users, array( 'ID' => $created_by_id ) );
221 221
 
222
-        // Make sure that the entry creator is included in the users list. If not, add them.
223
-        if ( ! empty( $created_by_id ) && empty( $is_created_by_in_users ) ) {
222
+		// Make sure that the entry creator is included in the users list. If not, add them.
223
+		if ( ! empty( $created_by_id ) && empty( $is_created_by_in_users ) ) {
224 224
 
225
-	        if ( $created_by_user = GVCommon::get_users( 'change_entry_creator', array( 'include' => $created_by_id ) ) ) {
226
-	            $users = array_merge( $users, $created_by_user );
227
-	        }
228
-	    }
225
+			if ( $created_by_user = GVCommon::get_users( 'change_entry_creator', array( 'include' => $created_by_id ) ) ) {
226
+				$users = array_merge( $users, $created_by_user );
227
+			}
228
+		}
229 229
 
230
-        $output = '<label for="change_created_by">';
231
-        $output .= esc_html__('Change Entry Creator:', 'gravityview');
232
-        $output .= '</label>';
230
+		$output = '<label for="change_created_by">';
231
+		$output .= esc_html__('Change Entry Creator:', 'gravityview');
232
+		$output .= '</label>';
233 233
 
234
-	    // If there are users who are not being shown, show a warning.
235
-	    // TODO: Use AJAX instead of <select>
236
-	    $count_users = count_users();
237
-	    if( sizeof( $users ) < $count_users['total_users'] ) {
238
-		    $output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
239
-	    }
234
+		// If there are users who are not being shown, show a warning.
235
+		// TODO: Use AJAX instead of <select>
236
+		$count_users = count_users();
237
+		if( sizeof( $users ) < $count_users['total_users'] ) {
238
+			$output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
239
+		}
240 240
 
241
-	    $output .= '<select name="created_by" id="change_created_by" class="widefat">';
242
-        $output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
243
-        foreach($users as $user) {
244
-            $output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
245
-        }
246
-        $output .= '</select>';
247
-        $output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
241
+		$output .= '<select name="created_by" id="change_created_by" class="widefat">';
242
+		$output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
243
+		foreach($users as $user) {
244
+			$output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
245
+		}
246
+		$output .= '</select>';
247
+		$output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
248 248
 
249
-	    unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
249
+		unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
250 250
 
251
-        echo $output;
252
-    }
251
+		echo $output;
252
+	}
253 253
 
254 254
 }
255 255
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-user-registration.php 1 patch
Indentation   +259 added lines, -259 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
  */
12 12
 
13 13
 if ( ! defined( 'WPINC' ) ) {
14
-    die;
14
+	die;
15 15
 }
16 16
 
17 17
 /**
@@ -22,104 +22,104 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @var GravityView_Edit_Entry
24 24
 	 */
25
-    protected $loader;
25
+	protected $loader;
26 26
 
27
-    /**
28
-     * @var WP_User|null Temporary storage used by restore_user_details()
29
-     */
30
-    private $_user_before_update = null;
27
+	/**
28
+	 * @var WP_User|null Temporary storage used by restore_user_details()
29
+	 */
30
+	private $_user_before_update = null;
31 31
 
32
-    function __construct( GravityView_Edit_Entry $loader ) {
33
-        $this->loader = $loader;
34
-    }
32
+	function __construct( GravityView_Edit_Entry $loader ) {
33
+		$this->loader = $loader;
34
+	}
35 35
 
36 36
 	/**
37 37
 	 * @since 1.11
38 38
 	 */
39 39
 	public function load() {
40 40
 		add_action( 'wp', array( $this, 'add_hooks' ), 10 );
41
-    }
41
+	}
42 42
 
43 43
 	/**
44 44
 	 * Add hooks to trigger updating the user
45 45
 	 *
46 46
 	 * @since 1.18
47 47
 	 */
48
-    public function add_hooks() {
49
-
50
-	    /**
51
-	     * @filter `gravityview/edit_entry/user_registration/trigger_update` Choose whether to update user information via User Registration add-on when an entry is updated?
52
-	     * @since 1.11
53
-	     * @param boolean $boolean Whether to trigger update on user registration (default: true)
54
-	     */
55
-	    if( apply_filters( 'gravityview/edit_entry/user_registration/trigger_update', true ) ) {
56
-
57
-	    	add_action( 'gravityview/edit_entry/after_update' , array( $this, 'update_user' ), 10, 2 );
58
-
59
-		    // last resort in case the current user display name don't match any of the defaults
60
-		    add_action( 'gform_user_updated', array( $this, 'restore_display_name' ), 10, 4 );
61
-	    }
62
-    }
63
-
64
-    /**
65
-     * Update the WordPress user profile based on the GF User Registration create feed
66
-     *
67
-     * @since 1.11
68
-     *
69
-     * @param array $form Gravity Forms form array
70
-     * @param string $entry_id Gravity Forms entry ID
71
-     * @return void
72
-     */
73
-    public function update_user( $form = array(), $entry_id = 0 ) {
74
-
75
-        if( ! class_exists( 'GFAPI' ) || ! class_exists( 'GF_User_Registration' ) ) {
76
-	        do_action( 'gravityview_log_error', __METHOD__ . ': GFAPI or User Registration class not found; not updating the user' );
77
-	        return;
78
-        } elseif( empty( $entry_id ) ) {
79
-        	do_action( 'gravityview_log_error', __METHOD__ . ': Entry ID is empty; not updating the user', $entry_id );
80
-	        return;
81
-        }
82
-
83
-        /** @var GF_User_Registration $gf_user_registration */
84
-        $gf_user_registration = GF_User_Registration::get_instance();
85
-
86
-        $entry = GFAPI::get_entry( $entry_id );
87
-
88
-	    /**
89
-	     * @filter `gravityview/edit_entry/user_registration/entry` Modify entry details before updating the user via User Registration add-on
90
-	     * @since 1.11
91
-	     * @param array $entry Gravity Forms entry
92
-	     * @param array $form Gravity Forms form
93
-	     */
94
-        $entry = apply_filters( 'gravityview/edit_entry/user_registration/entry', $entry, $form );
95
-
96
-	    $config = $this->get_feed_configuration( $entry, $form );
97
-
98
-        // Make sure the feed is active
99
-	    if ( ! rgar( $config, 'is_active', false ) ) {
48
+	public function add_hooks() {
49
+
50
+		/**
51
+		 * @filter `gravityview/edit_entry/user_registration/trigger_update` Choose whether to update user information via User Registration add-on when an entry is updated?
52
+		 * @since 1.11
53
+		 * @param boolean $boolean Whether to trigger update on user registration (default: true)
54
+		 */
55
+		if( apply_filters( 'gravityview/edit_entry/user_registration/trigger_update', true ) ) {
56
+
57
+			add_action( 'gravityview/edit_entry/after_update' , array( $this, 'update_user' ), 10, 2 );
58
+
59
+			// last resort in case the current user display name don't match any of the defaults
60
+			add_action( 'gform_user_updated', array( $this, 'restore_display_name' ), 10, 4 );
61
+		}
62
+	}
63
+
64
+	/**
65
+	 * Update the WordPress user profile based on the GF User Registration create feed
66
+	 *
67
+	 * @since 1.11
68
+	 *
69
+	 * @param array $form Gravity Forms form array
70
+	 * @param string $entry_id Gravity Forms entry ID
71
+	 * @return void
72
+	 */
73
+	public function update_user( $form = array(), $entry_id = 0 ) {
74
+
75
+		if( ! class_exists( 'GFAPI' ) || ! class_exists( 'GF_User_Registration' ) ) {
76
+			do_action( 'gravityview_log_error', __METHOD__ . ': GFAPI or User Registration class not found; not updating the user' );
100 77
 			return;
101
-	    }
78
+		} elseif( empty( $entry_id ) ) {
79
+			do_action( 'gravityview_log_error', __METHOD__ . ': Entry ID is empty; not updating the user', $entry_id );
80
+			return;
81
+		}
82
+
83
+		/** @var GF_User_Registration $gf_user_registration */
84
+		$gf_user_registration = GF_User_Registration::get_instance();
85
+
86
+		$entry = GFAPI::get_entry( $entry_id );
102 87
 
103
-	    // If an Update feed, make sure the conditions are met.
104
-	    if( rgars( $config, 'meta/feedType' ) === 'update' ) {
105
-	    	if( ! $gf_user_registration->is_feed_condition_met( $config, $form, $entry ) ) {
106
-			    return;
107
-		    }
108
-	    }
88
+		/**
89
+		 * @filter `gravityview/edit_entry/user_registration/entry` Modify entry details before updating the user via User Registration add-on
90
+		 * @since 1.11
91
+		 * @param array $entry Gravity Forms entry
92
+		 * @param array $form Gravity Forms form
93
+		 */
94
+		$entry = apply_filters( 'gravityview/edit_entry/user_registration/entry', $entry, $form );
95
+
96
+		$config = $this->get_feed_configuration( $entry, $form );
97
+
98
+		// Make sure the feed is active
99
+		if ( ! rgar( $config, 'is_active', false ) ) {
100
+			return;
101
+		}
109 102
 
110
-        // The priority is set to 3 so that default priority (10) will still override it
111
-        add_filter( 'send_password_change_email', '__return_false', 3 );
112
-        add_filter( 'send_email_change_email', '__return_false', 3 );
103
+		// If an Update feed, make sure the conditions are met.
104
+		if( rgars( $config, 'meta/feedType' ) === 'update' ) {
105
+			if( ! $gf_user_registration->is_feed_condition_met( $config, $form, $entry ) ) {
106
+				return;
107
+			}
108
+		}
113 109
 
114
-        // Trigger the User Registration update user method
115
-        $gf_user_registration->update_user( $entry, $form, $config );
110
+		// The priority is set to 3 so that default priority (10) will still override it
111
+		add_filter( 'send_password_change_email', '__return_false', 3 );
112
+		add_filter( 'send_email_change_email', '__return_false', 3 );
116 113
 
117
-        remove_filter( 'send_password_change_email', '__return_false', 3 );
118
-        remove_filter( 'send_email_change_email', '__return_false', 3 );
114
+		// Trigger the User Registration update user method
115
+		$gf_user_registration->update_user( $entry, $form, $config );
119 116
 
120
-        // Prevent double-triggering by removing the hook
121
-	    remove_action( 'gravityview/edit_entry/after_update' , array( $this, 'update_user' ), 10 );
122
-    }
117
+		remove_filter( 'send_password_change_email', '__return_false', 3 );
118
+		remove_filter( 'send_email_change_email', '__return_false', 3 );
119
+
120
+		// Prevent double-triggering by removing the hook
121
+		remove_action( 'gravityview/edit_entry/after_update' , array( $this, 'update_user' ), 10 );
122
+	}
123 123
 
124 124
 	/**
125 125
 	 * Get the User Registration feed configuration for the entry & form
@@ -134,185 +134,185 @@  discard block
 block discarded – undo
134 134
 	 *
135 135
 	 * @return array
136 136
 	 */
137
-    public function get_feed_configuration( $entry, $form ) {
138
-
139
-	    /** @var GF_User_Registration $gf_user_registration */
140
-	    $gf_user_registration = GF_User_Registration::get_instance();
141
-
142
-	    $config = $gf_user_registration->get_single_submission_feed( $entry, $form );
143
-
144
-	    /**
145
-	     * @filter `gravityview/edit_entry/user_registration/preserve_role` Keep the current user role or override with the role defined in the Create feed
146
-	     * @since 1.15
147
-	     * @param[in,out] boolean $preserve_role Preserve current user role Default: true
148
-	     * @param[in] array $config Gravity Forms User Registration feed configuration for the form
149
-	     * @param[in] array $form Gravity Forms form array
150
-	     * @param[in] array $entry Gravity Forms entry being edited
151
-	     */
152
-	    $preserve_role = apply_filters( 'gravityview/edit_entry/user_registration/preserve_role', true, $config, $form, $entry );
153
-
154
-	    if( $preserve_role ) {
155
-		    $config['meta']['role'] = 'gfur_preserve_role';
156
-	    }
157
-
158
-	    $displayname = $this->match_current_display_name( $entry['created_by'] );
159
-
160
-	    /**
161
-	     * Make sure the current display name is not changed with the update user method.
162
-	     * @since 1.15
163
-	     */
164
-	    $config['meta']['displayname'] = $displayname ? $displayname : $config['meta']['displayname'];
165
-
166
-	    /**
167
-	     * @filter `gravityview/edit_entry/user_registration/config` Modify the User Registration Addon feed configuration
168
-	     * @since 1.14
169
-	     * @param[in,out] array $config Gravity Forms User Registration feed configuration for the form
170
-	     * @param[in] array $form Gravity Forms form array
171
-	     * @param[in] array $entry Gravity Forms entry being edited
172
-	     */
173
-	    $config = apply_filters( 'gravityview/edit_entry/user_registration/config', $config, $form, $entry );
174
-
175
-	    return $config;
176
-    }
177
-
178
-    /**
179
-     * Calculate the user display name format
180
-     *
181
-     * @since 1.15
182
-     * @since 1.20 Returns false if user not found at $user_id
183
-     *
184
-     * @param int $user_id WP User ID
185
-     * @return false|string Display name format as used inside Gravity Forms User Registration. Returns false if user not found.
186
-     */
187
-    public function match_current_display_name( $user_id ) {
188
-
189
-        $user = get_userdata( $user_id );
190
-
191
-        if( ! $user ) {
192
-        	return false;
193
-        }
194
-
195
-        $names = $this->generate_display_names( $user );
196
-
197
-        $format = array_search( $user->display_name, $names, true );
198
-
199
-        /**
200
-         * In case we can't find the current display name format, trigger last resort method at the 'gform_user_updated' hook
201
-         * @see restore_display_name
202
-         */
203
-        if( false === $format ) {
204
-            $this->_user_before_update = $user;
205
-        }
206
-
207
-        return $format;
208
-    }
209
-
210
-    /**
211
-     * Generate an array of all the user display names possibilities
212
-     *
213
-     * @since 1.15
214
-     *
215
-     * @param object $profileuser WP_User object
216
-     * @return array List all the possible display names for a certain User object
217
-     */
218
-    public function generate_display_names( $profileuser ) {
219
-
220
-        $public_display = array();
221
-        $public_display['nickname']  = $profileuser->nickname;
222
-        $public_display['username']  = $profileuser->user_login;
223
-
224
-        if ( !empty($profileuser->first_name) ) {
225
-	        $public_display['firstname'] = $profileuser->first_name;
226
-        }
227
-
228
-        if ( !empty($profileuser->last_name) ) {
229
-	        $public_display['lastname'] = $profileuser->last_name;
230
-        }
231
-
232
-        if ( !empty($profileuser->first_name) && !empty($profileuser->last_name) ) {
233
-            $public_display['firstlast'] = $profileuser->first_name . ' ' . $profileuser->last_name;
234
-            $public_display['lastfirst'] = $profileuser->last_name . ' ' . $profileuser->first_name;
235
-        }
236
-
237
-        $public_display = array_map( 'trim', $public_display );
238
-        $public_display = array_unique( $public_display );
239
-
240
-        return $public_display;
241
-    }
242
-
243
-
244
-    /**
245
-     * Restore the Display Name and roles of a user after being updated by Gravity Forms User Registration Addon
246
-     *
247
-     * @see GFUser::update_user()
248
-     * @param int $user_id WP User ID that was updated by Gravity Forms User Registration Addon
249
-     * @param array $config Gravity Forms User Registration Addon form feed configuration
250
-     * @param array $entry The Gravity Forms entry that was just updated
251
-     * @param string $password User password
252
-     * @return int|false|WP_Error|null True: User updated; False: $user_id not a valid User ID; WP_Error: User update error; Null: Method didn't process
253
-     */
254
-    public function restore_display_name( $user_id = 0, $config = array(), $entry = array(), $password = '' ) {
255
-
256
-        /**
257
-         * @filter `gravityview/edit_entry/restore_display_name` Whether display names should be restored to before updating an entry.
258
-         * Otherwise, display names will be reset to the format specified in Gravity Forms User Registration "Update" feed
259
-         * @since 1.14.4
260
-         * @param boolean $restore_display_name Restore Display Name? Default: true
261
-         */
262
-        $restore_display_name = apply_filters( 'gravityview/edit_entry/restore_display_name', true );
263
-
264
-        $is_update_feed = ( $config && rgars( $config, 'meta/feed_type') === 'update' );
265
-
266
-        /**
267
-         * Don't restore display name:
268
-         *   - either disabled,
269
-         *   - or it is an Update feed (we only care about Create feed)
270
-         *   - or we don't need as we found the correct format before updating user.
271
-         * @since 1.14.4
272
-         */
273
-        if( ! $restore_display_name || $is_update_feed || is_null( $this->_user_before_update ) ) {
274
-            return null;
275
-        }
276
-
277
-        $user_after_update = get_userdata( $user_id );
278
-
279
-        // User not found
280
-	    if ( ! $user_after_update ) {
281
-	    	do_action('gravityview_log_error', __METHOD__ . sprintf( ' - User not found at $user_id #%d', $user_id ) );
282
-		    return false;
283
-	    }
284
-
285
-        $restored_user = $user_after_update;
286
-
287
-	    // Restore previous display_name
288
-        $restored_user->display_name = $this->_user_before_update->display_name;
289
-
290
-	    // Don't have WP update the password.
291
-	    unset( $restored_user->data->user_pass, $restored_user->user_pass );
292
-
293
-        /**
294
-         * Modify the user data after updated by Gravity Forms User Registration but before restored by GravityView
295
-         * @since 1.14
296
-         * @param WP_User $restored_user The user with restored details about to be updated by wp_update_user()
297
-         * @param WP_User $user_before_update The user before being updated by Gravity Forms User Registration
298
-         * @param WP_User $user_after_update The user after being updated by Gravity Forms User Registration
299
-         * @param array   $entry The Gravity Forms entry that was just updated
300
-         */
301
-        $restored_user = apply_filters( 'gravityview/edit_entry/user_registration/restored_user', $restored_user, $this->_user_before_update, $user_after_update, $entry );
302
-
303
-        $updated = wp_update_user( $restored_user );
304
-
305
-        if( is_wp_error( $updated ) ) {
306
-            do_action('gravityview_log_error', __METHOD__ . sprintf( ' - There was an error updating user #%d details', $user_id ), $updated );
307
-        } else {
308
-            do_action('gravityview_log_debug', __METHOD__ . sprintf( ' - User #%d details restored', $user_id ) );
309
-        }
310
-
311
-        $this->_user_before_update = null;
312
-
313
-        unset( $restored_user, $user_after_update );
314
-
315
-        return $updated;
316
-    }
137
+	public function get_feed_configuration( $entry, $form ) {
138
+
139
+		/** @var GF_User_Registration $gf_user_registration */
140
+		$gf_user_registration = GF_User_Registration::get_instance();
141
+
142
+		$config = $gf_user_registration->get_single_submission_feed( $entry, $form );
143
+
144
+		/**
145
+		 * @filter `gravityview/edit_entry/user_registration/preserve_role` Keep the current user role or override with the role defined in the Create feed
146
+		 * @since 1.15
147
+		 * @param[in,out] boolean $preserve_role Preserve current user role Default: true
148
+		 * @param[in] array $config Gravity Forms User Registration feed configuration for the form
149
+		 * @param[in] array $form Gravity Forms form array
150
+		 * @param[in] array $entry Gravity Forms entry being edited
151
+		 */
152
+		$preserve_role = apply_filters( 'gravityview/edit_entry/user_registration/preserve_role', true, $config, $form, $entry );
153
+
154
+		if( $preserve_role ) {
155
+			$config['meta']['role'] = 'gfur_preserve_role';
156
+		}
157
+
158
+		$displayname = $this->match_current_display_name( $entry['created_by'] );
159
+
160
+		/**
161
+		 * Make sure the current display name is not changed with the update user method.
162
+		 * @since 1.15
163
+		 */
164
+		$config['meta']['displayname'] = $displayname ? $displayname : $config['meta']['displayname'];
165
+
166
+		/**
167
+		 * @filter `gravityview/edit_entry/user_registration/config` Modify the User Registration Addon feed configuration
168
+		 * @since 1.14
169
+		 * @param[in,out] array $config Gravity Forms User Registration feed configuration for the form
170
+		 * @param[in] array $form Gravity Forms form array
171
+		 * @param[in] array $entry Gravity Forms entry being edited
172
+		 */
173
+		$config = apply_filters( 'gravityview/edit_entry/user_registration/config', $config, $form, $entry );
174
+
175
+		return $config;
176
+	}
177
+
178
+	/**
179
+	 * Calculate the user display name format
180
+	 *
181
+	 * @since 1.15
182
+	 * @since 1.20 Returns false if user not found at $user_id
183
+	 *
184
+	 * @param int $user_id WP User ID
185
+	 * @return false|string Display name format as used inside Gravity Forms User Registration. Returns false if user not found.
186
+	 */
187
+	public function match_current_display_name( $user_id ) {
188
+
189
+		$user = get_userdata( $user_id );
190
+
191
+		if( ! $user ) {
192
+			return false;
193
+		}
194
+
195
+		$names = $this->generate_display_names( $user );
196
+
197
+		$format = array_search( $user->display_name, $names, true );
198
+
199
+		/**
200
+		 * In case we can't find the current display name format, trigger last resort method at the 'gform_user_updated' hook
201
+		 * @see restore_display_name
202
+		 */
203
+		if( false === $format ) {
204
+			$this->_user_before_update = $user;
205
+		}
206
+
207
+		return $format;
208
+	}
209
+
210
+	/**
211
+	 * Generate an array of all the user display names possibilities
212
+	 *
213
+	 * @since 1.15
214
+	 *
215
+	 * @param object $profileuser WP_User object
216
+	 * @return array List all the possible display names for a certain User object
217
+	 */
218
+	public function generate_display_names( $profileuser ) {
219
+
220
+		$public_display = array();
221
+		$public_display['nickname']  = $profileuser->nickname;
222
+		$public_display['username']  = $profileuser->user_login;
223
+
224
+		if ( !empty($profileuser->first_name) ) {
225
+			$public_display['firstname'] = $profileuser->first_name;
226
+		}
227
+
228
+		if ( !empty($profileuser->last_name) ) {
229
+			$public_display['lastname'] = $profileuser->last_name;
230
+		}
231
+
232
+		if ( !empty($profileuser->first_name) && !empty($profileuser->last_name) ) {
233
+			$public_display['firstlast'] = $profileuser->first_name . ' ' . $profileuser->last_name;
234
+			$public_display['lastfirst'] = $profileuser->last_name . ' ' . $profileuser->first_name;
235
+		}
236
+
237
+		$public_display = array_map( 'trim', $public_display );
238
+		$public_display = array_unique( $public_display );
239
+
240
+		return $public_display;
241
+	}
242
+
243
+
244
+	/**
245
+	 * Restore the Display Name and roles of a user after being updated by Gravity Forms User Registration Addon
246
+	 *
247
+	 * @see GFUser::update_user()
248
+	 * @param int $user_id WP User ID that was updated by Gravity Forms User Registration Addon
249
+	 * @param array $config Gravity Forms User Registration Addon form feed configuration
250
+	 * @param array $entry The Gravity Forms entry that was just updated
251
+	 * @param string $password User password
252
+	 * @return int|false|WP_Error|null True: User updated; False: $user_id not a valid User ID; WP_Error: User update error; Null: Method didn't process
253
+	 */
254
+	public function restore_display_name( $user_id = 0, $config = array(), $entry = array(), $password = '' ) {
255
+
256
+		/**
257
+		 * @filter `gravityview/edit_entry/restore_display_name` Whether display names should be restored to before updating an entry.
258
+		 * Otherwise, display names will be reset to the format specified in Gravity Forms User Registration "Update" feed
259
+		 * @since 1.14.4
260
+		 * @param boolean $restore_display_name Restore Display Name? Default: true
261
+		 */
262
+		$restore_display_name = apply_filters( 'gravityview/edit_entry/restore_display_name', true );
263
+
264
+		$is_update_feed = ( $config && rgars( $config, 'meta/feed_type') === 'update' );
265
+
266
+		/**
267
+		 * Don't restore display name:
268
+		 *   - either disabled,
269
+		 *   - or it is an Update feed (we only care about Create feed)
270
+		 *   - or we don't need as we found the correct format before updating user.
271
+		 * @since 1.14.4
272
+		 */
273
+		if( ! $restore_display_name || $is_update_feed || is_null( $this->_user_before_update ) ) {
274
+			return null;
275
+		}
276
+
277
+		$user_after_update = get_userdata( $user_id );
278
+
279
+		// User not found
280
+		if ( ! $user_after_update ) {
281
+			do_action('gravityview_log_error', __METHOD__ . sprintf( ' - User not found at $user_id #%d', $user_id ) );
282
+			return false;
283
+		}
284
+
285
+		$restored_user = $user_after_update;
286
+
287
+		// Restore previous display_name
288
+		$restored_user->display_name = $this->_user_before_update->display_name;
289
+
290
+		// Don't have WP update the password.
291
+		unset( $restored_user->data->user_pass, $restored_user->user_pass );
292
+
293
+		/**
294
+		 * Modify the user data after updated by Gravity Forms User Registration but before restored by GravityView
295
+		 * @since 1.14
296
+		 * @param WP_User $restored_user The user with restored details about to be updated by wp_update_user()
297
+		 * @param WP_User $user_before_update The user before being updated by Gravity Forms User Registration
298
+		 * @param WP_User $user_after_update The user after being updated by Gravity Forms User Registration
299
+		 * @param array   $entry The Gravity Forms entry that was just updated
300
+		 */
301
+		$restored_user = apply_filters( 'gravityview/edit_entry/user_registration/restored_user', $restored_user, $this->_user_before_update, $user_after_update, $entry );
302
+
303
+		$updated = wp_update_user( $restored_user );
304
+
305
+		if( is_wp_error( $updated ) ) {
306
+			do_action('gravityview_log_error', __METHOD__ . sprintf( ' - There was an error updating user #%d details', $user_id ), $updated );
307
+		} else {
308
+			do_action('gravityview_log_debug', __METHOD__ . sprintf( ' - User #%d details restored', $user_id ) );
309
+		}
310
+
311
+		$this->_user_before_update = null;
312
+
313
+		unset( $restored_user, $user_after_update );
314
+
315
+		return $updated;
316
+	}
317 317
 
318 318
 } //end class
Please login to merge, or discard this patch.
includes/class-gv-license-handler.php 1 patch
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -116,14 +116,14 @@  discard block
 block discarded – undo
116 116
 			// Call the custom API.
117 117
 			$response = wp_remote_post( self::url, array(
118 118
 				'timeout'   => 15,
119
-			    'sslverify' => false,
120
-			    'body'      =>  array(
121
-				    'edd_action' => 'check_license',
122
-				    'license'    => trim( $this->Addon->get_app_setting( 'license_key' ) ),
123
-				    'item_name'  => self::name,
124
-				    'url'        => home_url(),
125
-				    'site_data'  => $this->get_site_data(),
126
-			    ),
119
+				'sslverify' => false,
120
+				'body'      =>  array(
121
+					'edd_action' => 'check_license',
122
+					'license'    => trim( $this->Addon->get_app_setting( 'license_key' ) ),
123
+					'item_name'  => self::name,
124
+					'url'        => home_url(),
125
+					'site_data'  => $this->get_site_data(),
126
+				),
127 127
 			));
128 128
 
129 129
 			// make sure the response came back okay
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
 			'author'    => self::author,
386 386
 			'language'  => get_locale(),
387 387
 			'url'       => home_url(),
388
-		    'beta'      => $this->Addon->get_app_setting( 'beta' ),
388
+			'beta'      => $this->Addon->get_app_setting( 'beta' ),
389 389
 		);
390 390
 
391 391
 		if( !empty( $action ) ) {
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
 		// Update option with passed data license
679 679
 		$settings = $this->Addon->get_app_settings();
680 680
 
681
-        $settings['license_key'] = $license_data->license_key = trim( $data['license'] );
681
+		$settings['license_key'] = $license_data->license_key = trim( $data['license'] );
682 682
 		$settings['license_key_status'] = $license_data->license;
683 683
 		$settings['license_key_response'] = (array)$license_data;
684 684
 
Please login to merge, or discard this patch.
includes/plugin-and-theme-hooks/class-gravityview-theme-hooks-rcp.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 	 */
24 24
 	protected $script_handles = array(
25 25
 		'rcp-admin-scripts',
26
-	    'bbq',
26
+		'bbq',
27 27
 	);
28 28
 
29 29
 	/**
Please login to merge, or discard this patch.
includes/class-admin-views.php 1 patch
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 
137 137
 		if( empty( $connected_views ) ) {
138 138
 
139
-		    $menu_items['gravityview'] = array(
139
+			$menu_items['gravityview'] = array(
140 140
 				'label'          => esc_attr__( 'Create a View', 'gravityview' ),
141 141
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
142 142
 				'title'          => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -167,13 +167,13 @@  discard block
 block discarded – undo
167 167
 		// If there were no items added, then let's create the parent menu
168 168
 		if( $sub_menu_items ) {
169 169
 
170
-		    $sub_menu_items[] = array(
171
-			    'label' => esc_attr__( 'Create a View', 'gravityview' ),
172
-                'link_class' => 'gv-create-view',
173
-			    'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
174
-			    'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
175
-			    'capabilities'   => array( 'edit_gravityviews' ),
176
-            );
170
+			$sub_menu_items[] = array(
171
+				'label' => esc_attr__( 'Create a View', 'gravityview' ),
172
+				'link_class' => 'gv-create-view',
173
+				'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
174
+				'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
175
+				'capabilities'   => array( 'edit_gravityviews' ),
176
+			);
177 177
 
178 178
 			// Make sure Gravity Forms uses the submenu; if there's only one item, it uses a link instead of a dropdown
179 179
 			$sub_menu_items[] = array(
@@ -549,12 +549,12 @@  discard block
 block discarded – undo
549 549
 	 * Render html for displaying available fields based on a Form ID
550 550
 	 * $blacklist_field_types - contains the field types which are not proper to be shown in a directory.
551 551
 	 *
552
-     * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
552
+	 * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
553 553
 	 * @access public
554
-     *
554
+	 *
555 555
 	 * @param int $form Gravity Forms Form ID (default: '')
556 556
 	 * @param string $context (default: 'single')
557
-     *
557
+	 *
558 558
 	 * @return void
559 559
 	 */
560 560
 	function render_available_fields( $form = 0, $context = 'single' ) {
@@ -568,7 +568,7 @@  discard block
 block discarded – undo
568 568
 
569 569
 		if ( ! is_array( $blacklist_field_types ) ) {
570 570
 
571
-		    do_action( 'gravityview_log_error', __METHOD__ . ': $blacklist_field_types is not an array', print_r( $blacklist_field_types, true ) );
571
+			do_action( 'gravityview_log_error', __METHOD__ . ': $blacklist_field_types is not an array', print_r( $blacklist_field_types, true ) );
572 572
 
573 573
 			$blacklist_field_types = array();
574 574
 		}
@@ -700,12 +700,12 @@  discard block
 block discarded – undo
700 700
 				/**
701 701
 				 * @since 1.7.2
702 702
 				 */
703
-			    'other_entries' => array(
704
-				    'label'	=> __('Other Entries', 'gravityview'),
705
-				    'type'	=> 'other_entries',
706
-				    'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
707
-			    ),
708
-	        );
703
+				'other_entries' => array(
704
+					'label'	=> __('Other Entries', 'gravityview'),
705
+					'type'	=> 'other_entries',
706
+					'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
707
+				),
708
+			);
709 709
 
710 710
 			if( 'single' !== $zone) {
711 711
 
@@ -1016,59 +1016,59 @@  discard block
 block discarded – undo
1016 1016
 
1017 1017
 		// Don't process any scripts below here if it's not a GravityView page.
1018 1018
 		if( ! gravityview_is_admin_page( $hook, 'single' ) && ! $is_widgets_page ) {
1019
-		    return;
1019
+			return;
1020 1020
 		}
1021 1021
 
1022
-        wp_enqueue_script( 'jquery-ui-datepicker' );
1023
-        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), GravityView_Plugin::version );
1024
-
1025
-        $script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1026
-
1027
-        //enqueue scripts
1028
-        wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), GravityView_Plugin::version );
1029
-
1030
-        wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1031
-            'cookiepath' => COOKIEPATH,
1032
-            'passed_form_id' => (bool) rgget( 'form_id' ),
1033
-            'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1034
-            'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1035
-            'label_close' => __( 'Close', 'gravityview' ),
1036
-            'label_cancel' => __( 'Cancel', 'gravityview' ),
1037
-            'label_continue' => __( 'Continue', 'gravityview' ),
1038
-            'label_ok' => __( 'Ok', 'gravityview' ),
1039
-            'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1040
-            'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1041
-            'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1042
-            'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1043
-            'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1044
-        ));
1045
-
1046
-        wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array('dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1047
-
1048
-        // Enqueue scripts needed for merge tags
1049
-        self::enqueue_gravity_forms_scripts();
1022
+		wp_enqueue_script( 'jquery-ui-datepicker' );
1023
+		wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), GravityView_Plugin::version );
1024
+
1025
+		$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1026
+
1027
+		//enqueue scripts
1028
+		wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), GravityView_Plugin::version );
1029
+
1030
+		wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1031
+			'cookiepath' => COOKIEPATH,
1032
+			'passed_form_id' => (bool) rgget( 'form_id' ),
1033
+			'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1034
+			'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1035
+			'label_close' => __( 'Close', 'gravityview' ),
1036
+			'label_cancel' => __( 'Cancel', 'gravityview' ),
1037
+			'label_continue' => __( 'Continue', 'gravityview' ),
1038
+			'label_ok' => __( 'Ok', 'gravityview' ),
1039
+			'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1040
+			'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1041
+			'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1042
+			'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1043
+			'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1044
+		));
1045
+
1046
+		wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array('dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1047
+
1048
+		// Enqueue scripts needed for merge tags
1049
+		self::enqueue_gravity_forms_scripts();
1050 1050
 	}
1051 1051
 
1052 1052
 	/**
1053 1053
 	 * Enqueue Gravity Forms scripts, needed for Merge Tags
1054
-     *
1055
-     * @since 1.0.5-beta
1056
-     *
1057
-     * @return void
1054
+	 *
1055
+	 * @since 1.0.5-beta
1056
+	 *
1057
+	 * @return void
1058 1058
 	 */
1059 1059
 	static function enqueue_gravity_forms_scripts() {
1060 1060
 		GFForms::register_scripts();
1061 1061
 
1062 1062
 		$scripts = array(
1063
-		    'sack',
1064
-		    'gform_gravityforms',
1065
-		    'gform_forms',
1066
-		    'gform_form_admin',
1067
-		    'jquery-ui-autocomplete'
1063
+			'sack',
1064
+			'gform_gravityforms',
1065
+			'gform_forms',
1066
+			'gform_form_admin',
1067
+			'jquery-ui-autocomplete'
1068 1068
 		);
1069 1069
 
1070 1070
 		if ( wp_is_mobile() ) {
1071
-		    $scripts[] = 'jquery-touch-punch';
1071
+			$scripts[] = 'jquery-touch-punch';
1072 1072
 		}
1073 1073
 
1074 1074
 		wp_enqueue_script( $scripts );
Please login to merge, or discard this patch.
includes/class-gravityview-settings.php 1 patch
Indentation   +76 added lines, -76 removed lines patch added patch discarded remove patch
@@ -122,10 +122,10 @@  discard block
 block discarded – undo
122 122
 	}
123 123
 
124 124
 	/**
125
-     * Uninstall all traces of GravityView
126
-     *
127
-     * Note: method is public because parent method is public
128
-     *
125
+	 * Uninstall all traces of GravityView
126
+	 *
127
+	 * Note: method is public because parent method is public
128
+	 *
129 129
 	 * @return bool
130 130
 	 */
131 131
 	public function uninstall() {
@@ -137,53 +137,53 @@  discard block
 block discarded – undo
137 137
 		$uninstaller->fire_everything();
138 138
 
139 139
 		/**
140
-         * Set the path so that Gravity Forms can de-activate GravityView
141
-         * @see GFAddOn::uninstall_addon
142
-         * @uses deactivate_plugins()
143
-         */
140
+		 * Set the path so that Gravity Forms can de-activate GravityView
141
+		 * @see GFAddOn::uninstall_addon
142
+		 * @uses deactivate_plugins()
143
+		 */
144 144
 		$this->_path = GRAVITYVIEW_FILE;
145 145
 
146 146
 		return true;
147 147
 	}
148 148
 
149 149
 	/**
150
-     * Get an array of reasons why the plugin might be uninstalled
151
-     *
152
-     * @since 1.17.5
153
-     *
150
+	 * Get an array of reasons why the plugin might be uninstalled
151
+	 *
152
+	 * @since 1.17.5
153
+	 *
154 154
 	 * @return array Array of reasons with the label and followup questions for each uninstall reason
155 155
 	 */
156 156
 	private function get_uninstall_reasons() {
157 157
 
158 158
 		$reasons = array(
159 159
 			'will-continue' => array(
160
-                'label' => esc_html__( 'I am going to continue using GravityView', 'gravityview' ),
161
-            ),
160
+				'label' => esc_html__( 'I am going to continue using GravityView', 'gravityview' ),
161
+			),
162 162
 			'no-longer-need' => array(
163
-                'label' => esc_html__( 'I no longer need GravityView', 'gravityview' ),
164
-            ),
163
+				'label' => esc_html__( 'I no longer need GravityView', 'gravityview' ),
164
+			),
165 165
 			'doesnt-work' => array(
166
-                'label' => esc_html__( 'The plugin doesn\'t work', 'gravityview' ),
167
-            ),
166
+				'label' => esc_html__( 'The plugin doesn\'t work', 'gravityview' ),
167
+			),
168 168
 			'found-other' => array(
169
-                'label' => esc_html__( 'I found a better plugin', 'gravityview' ),
170
-                'followup' => esc_attr__('What plugin you are using, and why?', 'gravityview'),
171
-            ),
169
+				'label' => esc_html__( 'I found a better plugin', 'gravityview' ),
170
+				'followup' => esc_attr__('What plugin you are using, and why?', 'gravityview'),
171
+			),
172 172
 			'other' => array(
173
-                'label' => esc_html__( 'Other', 'gravityview' ),
174
-            ),
173
+				'label' => esc_html__( 'Other', 'gravityview' ),
174
+			),
175 175
 		);
176 176
 
177 177
 		shuffle( $reasons );
178 178
 
179 179
 		return $reasons;
180
-    }
180
+	}
181 181
 
182 182
 	/**
183
-     * Display a feedback form when the plugin is uninstalled
184
-     *
185
-     * @since 1.17.5
186
-     *
183
+	 * Display a feedback form when the plugin is uninstalled
184
+	 *
185
+	 * @since 1.17.5
186
+	 *
187 187
 	 * @return string HTML of the uninstallation form
188 188
 	 */
189 189
 	public function uninstall_form() {
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             <h2><?php esc_html_e( 'Why did you uninstall GravityView?', 'gravityview' ); ?></h2>
264 264
             <ul>
265 265
 				<?php
266
-                $reasons = $this->get_uninstall_reasons();
266
+				$reasons = $this->get_uninstall_reasons();
267 267
 				foreach ( $reasons as $reason ) {
268 268
 					printf( '<li><label><input name="reason" type="radio" value="other" data-followup="%s"> %s</label></li>', rgar( $reason, 'followup' ), rgar( $reason, 'label' ) );
269 269
 				}
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
 		$license_key = self::getSetting('license_key');
432 432
 		if( '' === $license_key ) {
433 433
 			$license_status = 'inactive';
434
-        }
434
+		}
435 435
 		$license_id = empty( $license_key ) ? 'license' : $license_key;
436 436
 
437 437
 		$message = esc_html__('Your GravityView license %s. This means you&rsquo;re missing out on updates and support! %sActivate your license%s or %sget a license here%s.', 'gravityview');
@@ -491,12 +491,12 @@  discard block
 block discarded – undo
491 491
 	}
492 492
 
493 493
 	/**
494
-     * Add tooltip script to app settings page. Not enqueued by Gravity Forms for some reason.
495
-     *
496
-     * @since 1.21.5
497
-     *
498
-     * @see GFAddOn::scripts()
499
-     *
494
+	 * Add tooltip script to app settings page. Not enqueued by Gravity Forms for some reason.
495
+	 *
496
+	 * @since 1.21.5
497
+	 *
498
+	 * @see GFAddOn::scripts()
499
+	 *
500 500
 	 * @return array Array of scripts
501 501
 	 */
502 502
 	public function scripts() {
@@ -505,10 +505,10 @@  discard block
 block discarded – undo
505 505
 		$scripts[] = array(
506 506
 			'handle'  => 'gform_tooltip_init',
507 507
 			'enqueue' => array(
508
-                array(
509
-			        'admin_page' => array( 'app_settings' )
510
-                )
511
-            )
508
+				array(
509
+					'admin_page' => array( 'app_settings' )
510
+				)
511
+			)
512 512
 		);
513 513
 
514 514
 		return $scripts;
@@ -528,8 +528,8 @@  discard block
 block discarded – undo
528 528
 			'version' => GravityView_Plugin::version,
529 529
 			"deps" => array(
530 530
 				'gaddon_form_settings_css',
531
-                'gform_tooltip',
532
-                'gform_font_awesome',
531
+				'gform_tooltip',
532
+				'gform_font_awesome',
533 533
 			),
534 534
 			'enqueue' => array(
535 535
 				array( 'admin_page' => array(
@@ -595,12 +595,12 @@  discard block
 block discarded – undo
595 595
 	}
596 596
 
597 597
 	public function app_settings_tab() {
598
-	    parent::app_settings_tab();
598
+		parent::app_settings_tab();
599 599
 
600 600
 		if ( $this->maybe_uninstall() ) {
601
-            echo $this->uninstall_form();
601
+			echo $this->uninstall_form();
602 602
 		}
603
-    }
603
+	}
604 604
 
605 605
 	/**
606 606
 	 * Make protected public
@@ -723,8 +723,8 @@  discard block
 block discarded – undo
723 723
                     type="' . $field['type'] . '"
724 724
                     name="' . esc_attr( $name ) . '"
725 725
                     value="' . $value . '" ' .
726
-		        implode( ' ', $attributes ) .
727
-		        ' />';
726
+				implode( ' ', $attributes ) .
727
+				' />';
728 728
 
729 729
 		if ( $echo ) {
730 730
 			echo $html;
@@ -950,7 +950,7 @@  discard block
 block discarded – undo
950 950
 					array(
951 951
 						'label' => _x('Show me beta versions if they are available.', 'gravityview'),
952 952
 						'value' => '1',
953
-                        'name'  => 'beta',
953
+						'name'  => 'beta',
954 954
 					),
955 955
 				),
956 956
 				'description'   => __( 'You will have early access to the latest GravityView features and improvements. There may be bugs! If you encounter an issue, help make GravityView better by reporting it!', 'gravityview'),
@@ -975,36 +975,36 @@  discard block
 block discarded – undo
975 975
 		}
976 976
 
977 977
 
978
-        $sections = array(
979
-            array(
980
-                'description' =>      sprintf( '<span class="version-info description">%s</span>', sprintf( __('You are running GravityView version %s', 'gravityview'), GravityView_Plugin::version ) ),
981
-                'fields'      => $fields,
982
-            )
983
-        );
978
+		$sections = array(
979
+			array(
980
+				'description' =>      sprintf( '<span class="version-info description">%s</span>', sprintf( __('You are running GravityView version %s', 'gravityview'), GravityView_Plugin::version ) ),
981
+				'fields'      => $fields,
982
+			)
983
+		);
984 984
 
985
-        // custom 'update settings' button
986
-        $button = array(
987
-            'class' => 'button button-primary button-hero',
988
-            'type'     => 'save',
989
-        );
985
+		// custom 'update settings' button
986
+		$button = array(
987
+			'class' => 'button button-primary button-hero',
988
+			'type'     => 'save',
989
+		);
990 990
 
991 991
 		if( $disabled_attribute ) {
992 992
 			$button['disabled'] = $disabled_attribute;
993 993
 		}
994 994
 
995 995
 
996
-        /**
997
-         * @filter `gravityview/settings/extension/sections` Modify the GravityView settings page
998
-         * Extensions can tap in here to insert their own section and settings.
999
-         * <code>
1000
-         *   $sections[] = array(
1001
-         *      'title' => __( 'GravityView My Extension Settings', 'gravityview' ),
1002
-         *      'fields' => $settings,
1003
-         *   );
1004
-         * </code>
1005
-         * @param array $extension_settings Empty array, ready for extension settings!
1006
-         */
1007
-        $extension_sections = apply_filters( 'gravityview/settings/extension/sections', array() );
996
+		/**
997
+		 * @filter `gravityview/settings/extension/sections` Modify the GravityView settings page
998
+		 * Extensions can tap in here to insert their own section and settings.
999
+		 * <code>
1000
+		 *   $sections[] = array(
1001
+		 *      'title' => __( 'GravityView My Extension Settings', 'gravityview' ),
1002
+		 *      'fields' => $settings,
1003
+		 *   );
1004
+		 * </code>
1005
+		 * @param array $extension_settings Empty array, ready for extension settings!
1006
+		 */
1007
+		$extension_sections = apply_filters( 'gravityview/settings/extension/sections', array() );
1008 1008
 
1009 1009
 		// If there are extensions, add a section for them
1010 1010
 		if ( ! empty( $extension_sections ) ) {
@@ -1017,13 +1017,13 @@  discard block
 block discarded – undo
1017 1017
 				}
1018 1018
 			}
1019 1019
 
1020
-            $k = count( $extension_sections ) - 1 ;
1021
-            $extension_sections[ $k ]['fields'][] = $button;
1020
+			$k = count( $extension_sections ) - 1 ;
1021
+			$extension_sections[ $k ]['fields'][] = $button;
1022 1022
 			$sections = array_merge( $sections, $extension_sections );
1023 1023
 		} else {
1024
-            // add the 'update settings' button to the general section
1025
-            $sections[0]['fields'][] = $button;
1026
-        }
1024
+			// add the 'update settings' button to the general section
1025
+			$sections[0]['fields'][] = $button;
1026
+		}
1027 1027
 
1028 1028
 		return $sections;
1029 1029
 	}
Please login to merge, or discard this patch.