Completed
Push — master ( 578283...5ad19b )
by Zack
15s
created
includes/extensions/edit-entry/class-edit-entry-render.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -976,7 +976,7 @@  discard block
 block discarded – undo
976 976
 
977 977
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
978 978
 
979
-			if( ! $this->is_valid ){
979
+			if( ! $this->is_valid ) {
980 980
 
981 981
 				// Keeping this compatible with Gravity Forms.
982 982
 				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
@@ -2058,9 +2058,7 @@  discard block
 block discarded – undo
2058 2058
 		// Verify
2059 2059
 		else if( ! $this->is_edit_entry() ) {
2060 2060
 			$valid = false;
2061
-		}
2062
-
2063
-		else {
2061
+		} else {
2064 2062
 			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2065 2063
 		}
2066 2064
 
Please login to merge, or discard this patch.
Spacing   +202 added lines, -202 removed lines patch added patch discarded remove patch
@@ -115,16 +115,16 @@  discard block
 block discarded – undo
115 115
 	function load() {
116 116
 
117 117
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
118
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
118
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
119 119
 
120 120
 		// Don't display an embedded form when editing an entry
121 121
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
122 122
 		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
123 123
 
124 124
 		// Stop Gravity Forms processing what is ours!
125
-		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
125
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
126 126
 
127
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
127
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
128 128
 
129 129
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
130 130
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
136 136
 
137 137
 		// Add fields expected by GFFormDisplay::validate()
138
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
138
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
139 139
 
140 140
 		// Fix multiselect value for GF 2.2
141 141
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -152,8 +152,8 @@  discard block
 block discarded – undo
152 152
 	 * @return void
153 153
 	 */
154 154
 	public function prevent_render_form() {
155
-		if( $this->is_edit_entry() ) {
156
-			if( 'wp_head' === current_filter() ) {
155
+		if ( $this->is_edit_entry() ) {
156
+			if ( 'wp_head' === current_filter() ) {
157 157
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
158 158
 			} else {
159 159
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -168,13 +168,13 @@  discard block
 block discarded – undo
168 168
 	 */
169 169
 	public function prevent_maybe_process_form() {
170 170
 
171
-		if( ! empty( $_POST ) ) {
171
+		if ( ! empty( $_POST ) ) {
172 172
 	        gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
173 173
 		}
174 174
 
175
-		if( $this->is_edit_entry_submission() ) {
176
-			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
177
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
175
+		if ( $this->is_edit_entry_submission() ) {
176
+			remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
177
+	        remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
178 178
 		}
179 179
 	}
180 180
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 	 */
185 185
 	public function is_edit_entry() {
186 186
 
187
-		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
187
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET[ 'edit' ] );
188 188
 
189 189
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
190 190
 	}
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * @return boolean
196 196
 	 */
197 197
 	public function is_edit_entry_submission() {
198
-		return !empty( $_POST[ self::$nonce_field ] );
198
+		return ! empty( $_POST[ self::$nonce_field ] );
199 199
 	}
200 200
 
201 201
 	/**
@@ -208,8 +208,8 @@  discard block
 block discarded – undo
208 208
 
209 209
 
210 210
 		$entries = $gravityview_view->getEntries();
211
-	    self::$original_entry = $entries[0];
212
-	    $this->entry = $entries[0];
211
+	    self::$original_entry = $entries[ 0 ];
212
+	    $this->entry = $entries[ 0 ];
213 213
 
214 214
 		self::$original_form = $gravityview_view->getForm();
215 215
 		$this->form = $gravityview_view->getForm();
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 		$this->view_id = $gravityview_view->getViewId();
218 218
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
219 219
 
220
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
220
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
221 221
 	}
222 222
 
223 223
 
@@ -268,9 +268,9 @@  discard block
 block discarded – undo
268 268
 	private function print_scripts() {
269 269
 		$gravityview_view = GravityView_View::getInstance();
270 270
 
271
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
271
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
272 272
 
273
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
273
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
274 274
 
275 275
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
276 276
 
@@ -286,19 +286,19 @@  discard block
 block discarded – undo
286 286
 	 */
287 287
 	private function process_save( $gv_data ) {
288 288
 
289
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
289
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
290 290
 			return;
291 291
 		}
292 292
 
293 293
 		// Make sure the entry, view, and form IDs are all correct
294 294
 		$valid = $this->verify_nonce();
295 295
 
296
-		if ( !$valid ) {
296
+		if ( ! $valid ) {
297 297
 			gravityview()->log->error( 'Nonce validation failed.' );
298 298
 			return;
299 299
 		}
300 300
 
301
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
301
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
302 302
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
303 303
 			return;
304 304
 		}
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 
310 310
 		$this->validate();
311 311
 
312
-		if( $this->is_valid ) {
312
+		if ( $this->is_valid ) {
313 313
 
314 314
 			gravityview()->log->debug( 'Submission is valid.' );
315 315
 
@@ -321,22 +321,22 @@  discard block
 block discarded – undo
321 321
 			/**
322 322
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
323 323
 			 */
324
-			unset( $_GET['page'] );
324
+			unset( $_GET[ 'page' ] );
325 325
 
326
-			$date_created = $this->entry['date_created'];
326
+			$date_created = $this->entry[ 'date_created' ];
327 327
 
328 328
 			/**
329 329
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
330 330
 			 * @since 1.17.2
331 331
 			 */
332
-			unset( $this->entry['date_created'] );
332
+			unset( $this->entry[ 'date_created' ] );
333 333
 
334 334
 			GFFormsModel::save_lead( $form, $this->entry );
335 335
 
336 336
 	        // Delete the values for hidden inputs
337 337
 	        $this->unset_hidden_field_values();
338 338
 			
339
-			$this->entry['date_created'] = $date_created;
339
+			$this->entry[ 'date_created' ] = $date_created;
340 340
 
341 341
 			// Process calculation fields
342 342
 			$this->update_calculation_fields();
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 			 * @param GravityView_Edit_Entry_Render $this This object
359 359
 			 * @param GravityView_View_Data $gv_data The View data
360 360
 			 */
361
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
361
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
362 362
 
363 363
 		} else {
364 364
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -386,16 +386,16 @@  discard block
 block discarded – undo
386 386
 		 */
387 387
 		$unset_hidden_field_values = apply_filters( 'gravityview/edit_entry/unset_hidden_field_values', true, $this );
388 388
 
389
-		if( ! $unset_hidden_field_values ) {
389
+		if ( ! $unset_hidden_field_values ) {
390 390
 			return;
391 391
 		}
392 392
 
393 393
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
394 394
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
395
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT meta_key, meta_value FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
395
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT meta_key, meta_value FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
396 396
 		} else {
397 397
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
398
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_number FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
398
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_number FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
399 399
 		}
400 400
 
401 401
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
 		}
477 477
 
478 478
 		/** No file is being uploaded. */
479
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
479
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
480 480
 			/** So return the original upload */
481 481
 			return $entry[ $input_id ];
482 482
 		}
@@ -494,11 +494,11 @@  discard block
 block discarded – undo
494 494
 	 * @return mixed
495 495
 	 */
496 496
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
497
-		if( ! $this->is_edit_entry() ) {
497
+		if ( ! $this->is_edit_entry() ) {
498 498
 			return $plupload_init;
499 499
 		}
500 500
 
501
-		$plupload_init['gf_vars']['max_files'] = 0;
501
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
502 502
 
503 503
 		return $plupload_init;
504 504
 	}
@@ -513,27 +513,27 @@  discard block
 block discarded – undo
513 513
 		$form = $this->form;
514 514
 
515 515
 	    /** @var GF_Field $field */
516
-		foreach( $form['fields'] as $k => &$field ) {
516
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
517 517
 
518 518
 			/**
519 519
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
520 520
 			 * @since 1.16.3
521 521
 			 * @var GF_Field $field
522 522
 			 */
523
-			if( $field->has_calculation() ) {
524
-				unset( $form['fields'][ $k ] );
523
+			if ( $field->has_calculation() ) {
524
+				unset( $form[ 'fields' ][ $k ] );
525 525
 			}
526 526
 
527 527
 			$field->adminOnly = false;
528 528
 
529
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
530
-				foreach( $field->inputs as $key => $input ) {
531
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
529
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
530
+				foreach ( $field->inputs as $key => $input ) {
531
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
532 532
 				}
533 533
 			}
534 534
 		}
535 535
 
536
-		$form['fields'] = array_values( $form['fields'] );
536
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
537 537
 
538 538
 		return $form;
539 539
 	}
@@ -545,14 +545,14 @@  discard block
 block discarded – undo
545 545
 		$update = false;
546 546
 
547 547
 		// get the most up to date entry values
548
-		$entry = GFAPI::get_entry( $this->entry['id'] );
548
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
549 549
 
550 550
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
551 551
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
552
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
552
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
553 553
 		} else {
554 554
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
555
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
555
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
556 556
 		}
557 557
 
558 558
 
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
 				$inputs = $field->get_entry_inputs();
563 563
 				if ( is_array( $inputs ) ) {
564 564
 				    foreach ( $inputs as $input ) {
565
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
565
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
566 566
 				    }
567 567
 				} else {
568 568
 					GFFormsModel::save_input( $form, $field, $entry, $current_fields, $field->id );
@@ -598,19 +598,19 @@  discard block
 block discarded – undo
598 598
 
599 599
 		$input_name = 'input_' . $field_id;
600 600
 
601
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
601
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
602 602
 
603 603
 			// We have a new image
604 604
 
605
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
605
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
606 606
 
607 607
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
608 608
 	        $ary = stripslashes_deep( $ary );
609 609
 			$img_url = \GV\Utils::get( $ary, 0 );
610 610
 
611
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
612
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
613
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
611
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
612
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
613
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
614 614
 
615 615
 			$image_meta = array(
616 616
 				'post_excerpt' => $img_caption,
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 
620 620
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
621 621
 			if ( ! empty( $img_title ) ) {
622
-				$image_meta['post_title'] = $img_title;
622
+				$image_meta[ 'post_title' ] = $img_title;
623 623
 			}
624 624
 
625 625
 			/**
@@ -677,15 +677,15 @@  discard block
 block discarded – undo
677 677
 	 */
678 678
 	private function maybe_update_post_fields( $form ) {
679 679
 
680
-		if( empty( $this->entry['post_id'] ) ) {
680
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
681 681
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
682 682
 			return;
683 683
 		}
684 684
 
685
-		$post_id = $this->entry['post_id'];
685
+		$post_id = $this->entry[ 'post_id' ];
686 686
 
687 687
 		// Security check
688
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
688
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
689 689
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
690 690
 			return;
691 691
 		}
@@ -698,25 +698,25 @@  discard block
 block discarded – undo
698 698
 
699 699
 			$field = RGFormsModel::get_field( $form, $field_id );
700 700
 
701
-			if( ! $field ) {
701
+			if ( ! $field ) {
702 702
 				continue;
703 703
 			}
704 704
 
705
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
705
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
706 706
 
707 707
 				// Get the value of the field, including $_POSTed value
708 708
 				$value = RGFormsModel::get_field_value( $field );
709 709
 
710 710
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
711 711
 				$entry_tmp = $this->entry;
712
-				$entry_tmp["{$field_id}"] = $value;
712
+				$entry_tmp[ "{$field_id}" ] = $value;
713 713
 
714
-				switch( $field->type ) {
714
+				switch ( $field->type ) {
715 715
 
716 716
 				    case 'post_title':
717 717
 				        $post_title = $value;
718 718
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
719
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
719
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
720 720
 				        }
721 721
 				        $updated_post->post_title = $post_title;
722 722
 				        $updated_post->post_name  = $post_title;
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
 				    case 'post_content':
727 727
 				        $post_content = $value;
728 728
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
729
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
729
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
730 730
 				        }
731 731
 				        $updated_post->post_content = $post_content;
732 732
 				        unset( $post_content );
@@ -744,7 +744,7 @@  discard block
 block discarded – undo
744 744
 							$value = $value[ $field_id ];
745 745
 						}
746 746
 
747
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
747
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
748 748
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
749 749
 				        }
750 750
 
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 				}
763 763
 
764 764
 				// update entry after
765
-				$this->entry["{$field_id}"] = $value;
765
+				$this->entry[ "{$field_id}" ] = $value;
766 766
 
767 767
 				$update_entry = true;
768 768
 
@@ -771,11 +771,11 @@  discard block
 block discarded – undo
771 771
 
772 772
 		}
773 773
 
774
-		if( $update_entry ) {
774
+		if ( $update_entry ) {
775 775
 
776 776
 			$return_entry = GFAPI::update_entry( $this->entry );
777 777
 
778
-			if( is_wp_error( $return_entry ) ) {
778
+			if ( is_wp_error( $return_entry ) ) {
779 779
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
780 780
 			} else {
781 781
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -785,7 +785,7 @@  discard block
 block discarded – undo
785 785
 
786 786
 		$return_post = wp_update_post( $updated_post, true );
787 787
 
788
-		if( is_wp_error( $return_post ) ) {
788
+		if ( is_wp_error( $return_post ) ) {
789 789
 			$return_post->add_data( $updated_post, '$updated_post' );
790 790
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
791 791
 		} else {
@@ -807,7 +807,7 @@  discard block
 block discarded – undo
807 807
 		$input_type = RGFormsModel::get_input_type( $field );
808 808
 
809 809
 	    // Only certain custom field types are supported
810
-	    switch( $input_type ) {
810
+	    switch ( $input_type ) {
811 811
 		    case 'fileupload':
812 812
 		    case 'list':
813 813
 		    case 'multiselect':
@@ -844,7 +844,7 @@  discard block
 block discarded – undo
844 844
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
845 845
 
846 846
 		// replace conditional shortcodes
847
-		if( $do_shortcode ) {
847
+		if ( $do_shortcode ) {
848 848
 			$output = do_shortcode( $output );
849 849
 		}
850 850
 
@@ -863,19 +863,19 @@  discard block
 block discarded – undo
863 863
 	 */
864 864
 	private function after_update() {
865 865
 
866
-		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
867
-		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
866
+		do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ], self::$original_entry );
867
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ], self::$original_entry );
868 868
 
869 869
 		// Re-define the entry now that we've updated it.
870
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
870
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
871 871
 
872 872
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
873 873
 
874 874
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
875 875
 			// We need to clear the cache because Gravity Forms caches the field values, which
876 876
 			// we have just updated.
877
-			foreach ($this->form['fields'] as $key => $field) {
878
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
877
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
878
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
879 879
 			}
880 880
 		}
881 881
 
@@ -894,7 +894,7 @@  discard block
 block discarded – undo
894 894
 
895 895
 		<div class="gv-edit-entry-wrapper"><?php
896 896
 
897
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
897
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
898 898
 
899 899
 			/**
900 900
 			 * Fixes weird wpautop() issue
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
911 911
 				     * @param GravityView_Edit_Entry_Render $this This object
912 912
 				     */
913
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
913
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
914 914
 
915 915
 				    echo esc_attr( $edit_entry_title );
916 916
 			?></span>
@@ -960,13 +960,13 @@  discard block
 block discarded – undo
960 960
 
961 961
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
962 962
 
963
-			if( ! $this->is_valid ){
963
+			if ( ! $this->is_valid ) {
964 964
 
965 965
 				// Keeping this compatible with Gravity Forms.
966
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
967
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
966
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
967
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
968 968
 
969
-				echo GVCommon::generate_notice( $message , 'gv-error' );
969
+				echo GVCommon::generate_notice( $message, 'gv-error' );
970 970
 
971 971
 			} else {
972 972
 				$view = \GV\View::by_id( $this->view_id );
@@ -977,23 +977,23 @@  discard block
 block discarded – undo
977 977
 
978 978
                     case '0':
979 979
 	                    $redirect_url = $back_link;
980
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
980
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
981 981
                         break;
982 982
 
983 983
                     case '1':
984 984
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
985
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
985
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
986 986
 	                    break;
987 987
 
988 988
                     case '2':
989 989
 	                    $redirect_url = $edit_redirect_url;
990 990
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
991
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
991
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
992 992
                         break;
993 993
 
994 994
                     case '':
995 995
                     default:
996
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
996
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
997 997
                         break;
998 998
 				}
999 999
 
@@ -1009,7 +1009,7 @@  discard block
 block discarded – undo
1009 1009
 				 * @param array $entry Gravity Forms entry array
1010 1010
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1011 1011
 				 */
1012
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1012
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1013 1013
 
1014 1014
 				echo GVCommon::generate_notice( $message );
1015 1015
 			}
@@ -1033,21 +1033,21 @@  discard block
 block discarded – undo
1033 1033
 		 */
1034 1034
 		do_action( 'gravityview/edit-entry/render/before', $this );
1035 1035
 
1036
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1037
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1036
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1037
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1038 1038
 		add_filter( 'gform_disable_view_counter', '__return_true' );
1039 1039
 
1040 1040
 		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
1041 1041
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1042 1042
 
1043 1043
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1044
-		unset( $_GET['page'] );
1044
+		unset( $_GET[ 'page' ] );
1045 1045
 
1046 1046
 		// TODO: Verify multiple-page forms
1047 1047
 
1048 1048
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1049 1049
 
1050
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1050
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1051 1051
 
1052 1052
 		ob_get_clean();
1053 1053
 
@@ -1073,7 +1073,7 @@  discard block
 block discarded – undo
1073 1073
 	 * @return string
1074 1074
 	 */
1075 1075
 	public function render_form_buttons() {
1076
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1076
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1077 1077
 	}
1078 1078
 
1079 1079
 
@@ -1093,10 +1093,10 @@  discard block
 block discarded – undo
1093 1093
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1094 1094
 
1095 1095
 		// In case we have validated the form, use it to inject the validation results into the form render
1096
-		if( isset( $this->form_after_validation ) ) {
1096
+		if ( isset( $this->form_after_validation ) ) {
1097 1097
 			$form = $this->form_after_validation;
1098 1098
 		} else {
1099
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1099
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1100 1100
 		}
1101 1101
 
1102 1102
 		$form = $this->filter_conditional_logic( $form );
@@ -1104,8 +1104,8 @@  discard block
 block discarded – undo
1104 1104
 		$form = $this->prefill_conditional_logic( $form );
1105 1105
 
1106 1106
 		// for now we don't support Save and Continue feature.
1107
-		if( ! self::$supports_save_and_continue ) {
1108
-	        unset( $form['save'] );
1107
+		if ( ! self::$supports_save_and_continue ) {
1108
+	        unset( $form[ 'save' ] );
1109 1109
 		}
1110 1110
 
1111 1111
 		$form = $this->unselect_default_values( $form );
@@ -1128,31 +1128,31 @@  discard block
 block discarded – undo
1128 1128
 	 */
1129 1129
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1130 1130
 
1131
-		if( ! GFCommon::is_post_field( $field ) ) {
1131
+		if ( ! GFCommon::is_post_field( $field ) ) {
1132 1132
 			return $field_content;
1133 1133
 		}
1134 1134
 
1135 1135
         $message = null;
1136 1136
 
1137 1137
         // First, make sure they have the capability to edit the post.
1138
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1138
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1139 1139
 
1140 1140
             /**
1141 1141
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1142 1142
              * @param string $message The existing "You don't have permission..." text
1143 1143
              */
1144
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1144
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1145 1145
 
1146
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1146
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1147 1147
             /**
1148 1148
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1149 1149
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1150 1150
              */
1151
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1151
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1152 1152
         }
1153 1153
 
1154
-        if( $message ) {
1155
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1154
+        if ( $message ) {
1155
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1156 1156
         }
1157 1157
 
1158 1158
         return $field_content;
@@ -1176,8 +1176,8 @@  discard block
 block discarded – undo
1176 1176
 
1177 1177
 		// If the form has been submitted, then we don't need to pre-fill the values,
1178 1178
 		// Except for fileupload type and when a field input is overridden- run always!!
1179
-		if(
1180
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1179
+		if (
1180
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1181 1181
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1182 1182
 			&& ! GFCommon::is_product_field( $field->type )
1183 1183
 			|| ! empty( $field_content )
@@ -1197,7 +1197,7 @@  discard block
 block discarded – undo
1197 1197
 	    $return = null;
1198 1198
 
1199 1199
 		/** @var GravityView_Field $gv_field */
1200
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1200
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1201 1201
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1202 1202
 		} else {
1203 1203
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1206,7 +1206,7 @@  discard block
 block discarded – undo
1206 1206
 	    // If there was output, it's an error
1207 1207
 	    $warnings = ob_get_clean();
1208 1208
 
1209
-	    if( !empty( $warnings ) ) {
1209
+	    if ( ! empty( $warnings ) ) {
1210 1210
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1211 1211
 	    }
1212 1212
 
@@ -1231,7 +1231,7 @@  discard block
 block discarded – undo
1231 1231
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1232 1232
 
1233 1233
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1234
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1234
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1235 1235
 
1236 1236
 			$field_value = array();
1237 1237
 
@@ -1240,10 +1240,10 @@  discard block
 block discarded – undo
1240 1240
 
1241 1241
 			foreach ( (array)$field->inputs as $input ) {
1242 1242
 
1243
-				$input_id = strval( $input['id'] );
1243
+				$input_id = strval( $input[ 'id' ] );
1244 1244
 
1245 1245
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1246
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1246
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1247 1247
 				    $allow_pre_populated = false;
1248 1248
 				}
1249 1249
 
@@ -1251,7 +1251,7 @@  discard block
 block discarded – undo
1251 1251
 
1252 1252
 			$pre_value = $field->get_value_submission( array(), false );
1253 1253
 
1254
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1254
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1255 1255
 
1256 1256
 		} else {
1257 1257
 
@@ -1262,13 +1262,13 @@  discard block
 block discarded – undo
1262 1262
 
1263 1263
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1264 1264
 			// or pre-populated value if not empty and set to override saved value
1265
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1265
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1266 1266
 
1267 1267
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1268
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1268
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1269 1269
 				$categories = array();
1270 1270
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1271
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1271
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1272 1272
 				}
1273 1273
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1274 1274
 			}
@@ -1296,7 +1296,7 @@  discard block
 block discarded – undo
1296 1296
 	     * @param GF_Field $field Gravity Forms field object
1297 1297
 	     * @param GravityView_Edit_Entry_Render $this Current object
1298 1298
 	     */
1299
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1299
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1300 1300
 
1301 1301
 		return $field_value;
1302 1302
 	}
@@ -1313,12 +1313,12 @@  discard block
 block discarded – undo
1313 1313
 	 */
1314 1314
 	public function gform_pre_validation( $form ) {
1315 1315
 
1316
-		if( ! $this->verify_nonce() ) {
1316
+		if ( ! $this->verify_nonce() ) {
1317 1317
 			return $form;
1318 1318
 		}
1319 1319
 
1320 1320
 		// Fix PHP warning regarding undefined index.
1321
-		foreach ( $form['fields'] as &$field) {
1321
+		foreach ( $form[ 'fields' ] as &$field ) {
1322 1322
 
1323 1323
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1324 1324
 			// expects certain field array items to be set.
@@ -1326,7 +1326,7 @@  discard block
 block discarded – undo
1326 1326
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1327 1327
 			}
1328 1328
 
1329
-			switch( RGFormsModel::get_input_type( $field ) ) {
1329
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1330 1330
 
1331 1331
 				/**
1332 1332
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1340,26 +1340,26 @@  discard block
 block discarded – undo
1340 1340
 				    // Set the previous value
1341 1341
 				    $entry = $this->get_entry();
1342 1342
 
1343
-				    $input_name = 'input_'.$field->id;
1344
-				    $form_id = $form['id'];
1343
+				    $input_name = 'input_' . $field->id;
1344
+				    $form_id = $form[ 'id' ];
1345 1345
 
1346 1346
 				    $value = NULL;
1347 1347
 
1348 1348
 				    // Use the previous entry value as the default.
1349
-				    if( isset( $entry[ $field->id ] ) ) {
1349
+				    if ( isset( $entry[ $field->id ] ) ) {
1350 1350
 				        $value = $entry[ $field->id ];
1351 1351
 				    }
1352 1352
 
1353 1353
 				    // If this is a single upload file
1354
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1355
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1356
-				        $value = $file_path['url'];
1354
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1355
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1356
+				        $value = $file_path[ 'url' ];
1357 1357
 
1358 1358
 				    } else {
1359 1359
 
1360 1360
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1361 1361
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1362
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1362
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1363 1363
 
1364 1364
 				    }
1365 1365
 
@@ -1367,10 +1367,10 @@  discard block
 block discarded – undo
1367 1367
 
1368 1368
 				        // If there are fresh uploads, process and merge them.
1369 1369
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1370
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1370
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1371 1371
 				            $value = empty( $value ) ? '[]' : $value;
1372 1372
 				            $value = stripslashes_deep( $value );
1373
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1373
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1374 1374
 				        }
1375 1375
 
1376 1376
 				    } else {
@@ -1388,8 +1388,8 @@  discard block
 block discarded – undo
1388 1388
 
1389 1389
 				case 'number':
1390 1390
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1391
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1392
-				        $_POST['input_'.$field->id ] = NULL;
1391
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1392
+				        $_POST[ 'input_' . $field->id ] = NULL;
1393 1393
 				    }
1394 1394
 				    break;
1395 1395
 			}
@@ -1426,7 +1426,7 @@  discard block
 block discarded – undo
1426 1426
 		 * You can enter whatever you want!
1427 1427
 		 * We try validating, and customize the results using `self::custom_validation()`
1428 1428
 		 */
1429
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1429
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1430 1430
 
1431 1431
 		// Needed by the validate funtion
1432 1432
 		$failed_validation_page = NULL;
@@ -1434,14 +1434,14 @@  discard block
 block discarded – undo
1434 1434
 
1435 1435
 		// Prevent entry limit from running when editing an entry, also
1436 1436
 		// prevent form scheduling from preventing editing
1437
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1437
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1438 1438
 
1439 1439
 		// Hide fields depending on Edit Entry settings
1440
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1440
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1441 1441
 
1442 1442
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1443 1443
 
1444
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1444
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1445 1445
 	}
1446 1446
 
1447 1447
 
@@ -1464,7 +1464,7 @@  discard block
 block discarded – undo
1464 1464
 
1465 1465
 		$gv_valid = true;
1466 1466
 
1467
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1467
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1468 1468
 
1469 1469
 			$value = RGFormsModel::get_field_value( $field );
1470 1470
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1477,35 +1477,35 @@  discard block
 block discarded – undo
1477 1477
 				case 'post_image':
1478 1478
 
1479 1479
 				    // in case nothing is uploaded but there are already files saved
1480
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1480
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1481 1481
 				        $field->failed_validation = false;
1482 1482
 				        unset( $field->validation_message );
1483 1483
 				    }
1484 1484
 
1485 1485
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1486
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1486
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1487 1487
 
1488 1488
 				        $input_name = 'input_' . $field->id;
1489 1489
 				        //uploaded
1490
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1490
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1491 1491
 
1492 1492
 				        //existent
1493 1493
 				        $entry = $this->get_entry();
1494 1494
 				        $value = NULL;
1495
-				        if( isset( $entry[ $field->id ] ) ) {
1495
+				        if ( isset( $entry[ $field->id ] ) ) {
1496 1496
 				            $value = json_decode( $entry[ $field->id ], true );
1497 1497
 				        }
1498 1498
 
1499 1499
 				        // count uploaded files and existent entry files
1500 1500
 				        $count_files = count( $file_names ) + count( $value );
1501 1501
 
1502
-				        if( $count_files > $field->maxFiles ) {
1502
+				        if ( $count_files > $field->maxFiles ) {
1503 1503
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1504 1504
 				            $field->failed_validation = 1;
1505 1505
 				            $gv_valid = false;
1506 1506
 
1507 1507
 				            // in case of error make sure the newest upload files are removed from the upload input
1508
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1508
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1509 1509
 				        }
1510 1510
 
1511 1511
 				    }
@@ -1516,7 +1516,7 @@  discard block
 block discarded – undo
1516 1516
 			}
1517 1517
 
1518 1518
 			// This field has failed validation.
1519
-			if( !empty( $field->failed_validation ) ) {
1519
+			if ( ! empty( $field->failed_validation ) ) {
1520 1520
 
1521 1521
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1522 1522
 
@@ -1534,19 +1534,19 @@  discard block
 block discarded – undo
1534 1534
 				}
1535 1535
 
1536 1536
 				// You can't continue inside a switch, so we do it after.
1537
-				if( empty( $field->failed_validation ) ) {
1537
+				if ( empty( $field->failed_validation ) ) {
1538 1538
 				    continue;
1539 1539
 				}
1540 1540
 
1541 1541
 				// checks if the No Duplicates option is not validating entry against itself, since
1542 1542
 				// we're editing a stored entry, it would also assume it's a duplicate.
1543
-				if( !empty( $field->noDuplicates ) ) {
1543
+				if ( ! empty( $field->noDuplicates ) ) {
1544 1544
 
1545 1545
 				    $entry = $this->get_entry();
1546 1546
 
1547 1547
 				    // If the value of the entry is the same as the stored value
1548 1548
 				    // Then we can assume it's not a duplicate, it's the same.
1549
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1549
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1550 1550
 				        //if value submitted was not changed, then don't validate
1551 1551
 				        $field->failed_validation = false;
1552 1552
 
@@ -1559,7 +1559,7 @@  discard block
 block discarded – undo
1559 1559
 				}
1560 1560
 
1561 1561
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1562
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1562
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1563 1563
 				    unset( $field->validation_message );
1564 1564
 	                $field->validation_message = false;
1565 1565
 				    continue;
@@ -1571,12 +1571,12 @@  discard block
 block discarded – undo
1571 1571
 
1572 1572
 		}
1573 1573
 
1574
-		$validation_results['is_valid'] = $gv_valid;
1574
+		$validation_results[ 'is_valid' ] = $gv_valid;
1575 1575
 
1576 1576
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1577 1577
 
1578 1578
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1579
-		$this->form_after_validation = $validation_results['form'];
1579
+		$this->form_after_validation = $validation_results[ 'form' ];
1580 1580
 
1581 1581
 		return $validation_results;
1582 1582
 	}
@@ -1589,7 +1589,7 @@  discard block
 block discarded – undo
1589 1589
 	 */
1590 1590
 	public function get_entry() {
1591 1591
 
1592
-		if( empty( $this->entry ) ) {
1592
+		if ( empty( $this->entry ) ) {
1593 1593
 			// Get the database value of the entry that's being edited
1594 1594
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1595 1595
 		}
@@ -1621,10 +1621,10 @@  discard block
 block discarded – undo
1621 1621
 		}
1622 1622
 
1623 1623
 		// If edit tab not yet configured, show all fields
1624
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1624
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1625 1625
 
1626 1626
 		// Hide fields depending on admin settings
1627
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1627
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1628 1628
 
1629 1629
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1630 1630
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1656,7 +1656,7 @@  discard block
 block discarded – undo
1656 1656
 	 */
1657 1657
 	private function filter_fields( $fields, $configured_fields ) {
1658 1658
 
1659
-		if( empty( $fields ) || !is_array( $fields ) ) {
1659
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1660 1660
 			return $fields;
1661 1661
 		}
1662 1662
 
@@ -1669,18 +1669,18 @@  discard block
 block discarded – undo
1669 1669
 
1670 1670
 			// Remove the fields that have calculation properties and keep them to be used later
1671 1671
 			// @since 1.16.2
1672
-			if( $field->has_calculation() ) {
1673
-				$this->fields_with_calculation[] = $field;
1672
+			if ( $field->has_calculation() ) {
1673
+				$this->fields_with_calculation[ ] = $field;
1674 1674
 				// don't remove the calculation fields on form render.
1675 1675
 			}
1676 1676
 
1677
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1677
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1678 1678
 				unset( $fields[ $key ] );
1679 1679
 			}
1680 1680
 		}
1681 1681
 
1682 1682
 		// The Edit tab has not been configured, so we return all fields by default.
1683
-		if( empty( $configured_fields ) ) {
1683
+		if ( empty( $configured_fields ) ) {
1684 1684
 			return array_values( $fields );
1685 1685
 		}
1686 1686
 
@@ -1689,8 +1689,8 @@  discard block
 block discarded – undo
1689 1689
 
1690 1690
 	        /** @var GF_Field $field */
1691 1691
 	        foreach ( $fields as $field ) {
1692
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1693
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1692
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1693
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1694 1694
 				    break;
1695 1695
 				}
1696 1696
 
@@ -1713,14 +1713,14 @@  discard block
 block discarded – undo
1713 1713
 
1714 1714
 		$return_field = $field;
1715 1715
 
1716
-		if( empty( $field_setting['show_label'] ) ) {
1716
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1717 1717
 			$return_field->label = '';
1718
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1719
-			$return_field->label = $field_setting['custom_label'];
1718
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1719
+			$return_field->label = $field_setting[ 'custom_label' ];
1720 1720
 		}
1721 1721
 
1722
-		if( !empty( $field_setting['custom_class'] ) ) {
1723
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1722
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1723
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1724 1724
 		}
1725 1725
 
1726 1726
 		/**
@@ -1758,16 +1758,16 @@  discard block
 block discarded – undo
1758 1758
 	     */
1759 1759
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1760 1760
 
1761
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1762
-			foreach( $fields as $k => $field ) {
1763
-				if( $field->adminOnly ) {
1761
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1762
+			foreach ( $fields as $k => $field ) {
1763
+				if ( $field->adminOnly ) {
1764 1764
 				    unset( $fields[ $k ] );
1765 1765
 				}
1766 1766
 			}
1767 1767
 			return array_values( $fields );
1768 1768
 		}
1769 1769
 
1770
-	    foreach( $fields as &$field ) {
1770
+	    foreach ( $fields as &$field ) {
1771 1771
 		    $field->adminOnly = false;
1772 1772
 		}
1773 1773
 
@@ -1788,7 +1788,7 @@  discard block
 block discarded – undo
1788 1788
 	 */
1789 1789
 	private function unselect_default_values( $form ) {
1790 1790
 
1791
-	    foreach ( $form['fields'] as &$field ) {
1791
+	    foreach ( $form[ 'fields' ] as &$field ) {
1792 1792
 
1793 1793
 			if ( empty( $field->choices ) ) {
1794 1794
                 continue;
@@ -1796,7 +1796,7 @@  discard block
 block discarded – undo
1796 1796
 
1797 1797
             foreach ( $field->choices as &$choice ) {
1798 1798
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1799
-					$choice['isSelected'] = false;
1799
+					$choice[ 'isSelected' ] = false;
1800 1800
 				}
1801 1801
 			}
1802 1802
 		}
@@ -1821,22 +1821,22 @@  discard block
 block discarded – undo
1821 1821
 	 */
1822 1822
 	function prefill_conditional_logic( $form ) {
1823 1823
 
1824
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1824
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1825 1825
 			return $form;
1826 1826
 		}
1827 1827
 
1828 1828
 		// Have Conditional Logic pre-fill fields as if the data were default values
1829 1829
 		/** @var GF_Field $field */
1830
-		foreach ( $form['fields'] as &$field ) {
1830
+		foreach ( $form[ 'fields' ] as &$field ) {
1831 1831
 
1832
-			if( 'checkbox' === $field->type ) {
1832
+			if ( 'checkbox' === $field->type ) {
1833 1833
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1834
-				    $input_id = $input['id'];
1834
+				    $input_id = $input[ 'id' ];
1835 1835
 				    $choice = $field->choices[ $key ];
1836 1836
 				    $value = \GV\Utils::get( $this->entry, $input_id );
1837 1837
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1838
-				    if( $match ) {
1839
-				        $field->choices[ $key ]['isSelected'] = true;
1838
+				    if ( $match ) {
1839
+				        $field->choices[ $key ][ 'isSelected' ] = true;
1840 1840
 				    }
1841 1841
 				}
1842 1842
 			} else {
@@ -1844,15 +1844,15 @@  discard block
 block discarded – undo
1844 1844
 				// We need to run through each field to set the default values
1845 1845
 				foreach ( $this->entry as $field_id => $field_value ) {
1846 1846
 
1847
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1847
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
1848 1848
 
1849
-				        if( 'list' === $field->type ) {
1849
+				        if ( 'list' === $field->type ) {
1850 1850
 				            $list_rows = maybe_unserialize( $field_value );
1851 1851
 
1852 1852
 				            $list_field_value = array();
1853
-				            foreach ( (array) $list_rows as $row ) {
1854
-				                foreach ( (array) $row as $column ) {
1855
-				                    $list_field_value[] = $column;
1853
+				            foreach ( (array)$list_rows as $row ) {
1854
+				                foreach ( (array)$row as $column ) {
1855
+				                    $list_field_value[ ] = $column;
1856 1856
 				                }
1857 1857
 				            }
1858 1858
 
@@ -1887,16 +1887,16 @@  discard block
 block discarded – undo
1887 1887
 		 */
1888 1888
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1889 1889
 
1890
-		if( $use_conditional_logic ) {
1890
+		if ( $use_conditional_logic ) {
1891 1891
 			return $form;
1892 1892
 		}
1893 1893
 
1894
-		foreach( $form['fields'] as &$field ) {
1894
+		foreach ( $form[ 'fields' ] as &$field ) {
1895 1895
 			/* @var GF_Field $field */
1896 1896
 			$field->conditionalLogic = null;
1897 1897
 		}
1898 1898
 
1899
-		unset( $form['button']['conditionalLogic'] );
1899
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
1900 1900
 
1901 1901
 		return $form;
1902 1902
 
@@ -1913,7 +1913,7 @@  discard block
 block discarded – undo
1913 1913
 	 */
1914 1914
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
1915 1915
 
1916
-		if( ! $this->is_edit_entry() ) {
1916
+		if ( ! $this->is_edit_entry() ) {
1917 1917
 			return $has_conditional_logic;
1918 1918
 		}
1919 1919
 
@@ -1945,44 +1945,44 @@  discard block
 block discarded – undo
1945 1945
 		 *  2. There are two entries embedded using oEmbed
1946 1946
 		 *  3. One of the entries has just been saved
1947 1947
 		 */
1948
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1948
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
1949 1949
 
1950 1950
 			$error = true;
1951 1951
 
1952 1952
 		}
1953 1953
 
1954
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1954
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
1955 1955
 
1956 1956
 			$error = true;
1957 1957
 
1958
-		} elseif( ! $this->verify_nonce() ) {
1958
+		} elseif ( ! $this->verify_nonce() ) {
1959 1959
 
1960 1960
 			/**
1961 1961
 			 * If the Entry is embedded, there may be two entries on the same page.
1962 1962
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1963 1963
 			 */
1964
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1964
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1965 1965
 				$error = true;
1966 1966
 			} else {
1967
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1967
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
1968 1968
 			}
1969 1969
 
1970 1970
 		}
1971 1971
 
1972
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1973
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
1972
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1973
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
1974 1974
 		}
1975 1975
 
1976
-		if( $this->entry['status'] === 'trash' ) {
1977
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1976
+		if ( $this->entry[ 'status' ] === 'trash' ) {
1977
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
1978 1978
 		}
1979 1979
 
1980 1980
 		// No errors; everything's fine here!
1981
-		if( empty( $error ) ) {
1981
+		if ( empty( $error ) ) {
1982 1982
 			return true;
1983 1983
 		}
1984 1984
 
1985
-		if( $echo && $error !== true ) {
1985
+		if ( $echo && $error !== true ) {
1986 1986
 
1987 1987
 	        $error = esc_html( $error );
1988 1988
 
@@ -1990,10 +1990,10 @@  discard block
 block discarded – undo
1990 1990
 	         * @since 1.9
1991 1991
 	         */
1992 1992
 	        if ( ! empty( $this->entry ) ) {
1993
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1993
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1994 1994
 	        }
1995 1995
 
1996
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1996
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
1997 1997
 		}
1998 1998
 
1999 1999
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2013,17 +2013,17 @@  discard block
 block discarded – undo
2013 2013
 
2014 2014
 		$error = NULL;
2015 2015
 
2016
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2017
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2016
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2017
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2018 2018
 		}
2019 2019
 
2020 2020
 		// No errors; everything's fine here!
2021
-		if( empty( $error ) ) {
2021
+		if ( empty( $error ) ) {
2022 2022
 			return true;
2023 2023
 		}
2024 2024
 
2025
-		if( $echo ) {
2026
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2025
+		if ( $echo ) {
2026
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2027 2027
 		}
2028 2028
 
2029 2029
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2044,14 +2044,14 @@  discard block
 block discarded – undo
2044 2044
 	private function check_user_cap_edit_field( $field ) {
2045 2045
 
2046 2046
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2047
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2047
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2048 2048
 			return true;
2049 2049
 		}
2050 2050
 
2051
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2051
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2052 2052
 
2053
-		if( $field_cap ) {
2054
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2053
+		if ( $field_cap ) {
2054
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2055 2055
 		}
2056 2056
 
2057 2057
 		return false;
@@ -2065,17 +2065,17 @@  discard block
 block discarded – undo
2065 2065
 	public function verify_nonce() {
2066 2066
 
2067 2067
 		// Verify form submitted for editing single
2068
-		if( $this->is_edit_entry_submission() ) {
2068
+		if ( $this->is_edit_entry_submission() ) {
2069 2069
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2070 2070
 		}
2071 2071
 
2072 2072
 		// Verify
2073
-		else if( ! $this->is_edit_entry() ) {
2073
+		else if ( ! $this->is_edit_entry() ) {
2074 2074
 			$valid = false;
2075 2075
 		}
2076 2076
 
2077 2077
 		else {
2078
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2078
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2079 2079
 		}
2080 2080
 
2081 2081
 		/**
Please login to merge, or discard this patch.
future/includes/class-gv-utils.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 		 * Try subkeys after split.
92 92
 		 */
93 93
 		if ( count( $parts = explode( '/', $key, 2 ) ) > 1 ) {
94
-			return self::get( self::get( $array, $parts[0] ), $parts[1], $default );
94
+			return self::get( self::get( $array, $parts[ 0 ] ), $parts[ 1 ], $default );
95 95
 		}
96 96
 
97 97
 		return $default;
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	public static function gf_query_debug( $query ) {
146 146
 		$introspect = $query->_introspect();
147 147
 		return array(
148
-			'where' => $query->_where_unwrap( $introspect['where'] )
148
+			'where' => $query->_where_unwrap( $introspect[ 'where' ] )
149 149
 		);
150 150
 	}
151 151
 }
Please login to merge, or discard this patch.
class-gravityview-plugin-hooks-gravity-forms-directory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,11 +29,11 @@
 block discarded – undo
29 29
 		$KWS_GF_Change_Lead_Creator = new KWS_GF_Change_Lead_Creator;
30 30
 
31 31
 		// Now, no validation is required in the methods; let's hook in.
32
-		remove_action('admin_init', array( $KWS_GF_Change_Lead_Creator, 'set_screen_mode' ) );
32
+		remove_action( 'admin_init', array( $KWS_GF_Change_Lead_Creator, 'set_screen_mode' ) );
33 33
 
34
-		remove_action("gform_entry_info", array( $KWS_GF_Change_Lead_Creator, 'add_select' ), 10 );
34
+		remove_action( "gform_entry_info", array( $KWS_GF_Change_Lead_Creator, 'add_select' ), 10 );
35 35
 
36
-		remove_action("gform_after_update_entry", array( $KWS_GF_Change_Lead_Creator, 'update_entry_creator' ), 10 );
36
+		remove_action( "gform_after_update_entry", array( $KWS_GF_Change_Lead_Creator, 'update_entry_creator' ), 10 );
37 37
 
38 38
 	}
39 39
 }
Please login to merge, or discard this patch.
includes/class-gravityview-change-entry-creator.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -10,17 +10,17 @@  discard block
 block discarded – undo
10 10
     	/**
11 11
     	 * @since  1.5.1
12 12
     	 */
13
-    	add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
13
+    	add_action( 'gform_user_registered', array( $this, 'assign_new_user_to_lead' ), 10, 4 );
14 14
 
15 15
     	// ONLY ADMIN FROM HERE ON.
16
-    	if( !is_admin() ) { return; }
16
+    	if ( ! is_admin() ) { return; }
17 17
 
18 18
 	    /**
19 19
          * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20 20
 	     * @since 1.7.4
21 21
 	     * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22 22
 	     */
23
-	    if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
23
+	    if ( apply_filters( 'gravityview_disable_change_entry_creator', false ) ) {
24 24
 		    return;
25 25
 	    }
26 26
 
@@ -28,9 +28,9 @@  discard block
 block discarded – undo
28 28
          * Use `init` to fix bbPress warning
29 29
          * @see https://bbpress.trac.wordpress.org/ticket/2309
30 30
          */
31
-    	add_action('init', array( $this, 'load'), 100 );
31
+    	add_action( 'init', array( $this, 'load' ), 100 );
32 32
 
33
-    	add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
33
+    	add_action( 'plugins_loaded', array( $this, 'prevent_conflicts' ) );
34 34
 
35 35
     }
36 36
 
@@ -56,20 +56,20 @@  discard block
 block discarded – undo
56 56
     	$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57 57
 
58 58
     	// If filter returns false, do not process
59
-    	if( empty( $assign_to_lead ) ) {
59
+    	if ( empty( $assign_to_lead ) ) {
60 60
     		return;
61 61
     	}
62 62
 
63 63
     	// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
-    	$result = RGFormsModel::update_entry_property( (int) $entry['id'], 'created_by', (int) $user_id, false, true );
64
+    	$result = RGFormsModel::update_entry_property( (int)$entry[ 'id' ], 'created_by', (int)$user_id, false, true );
65 65
 
66 66
     	if ( false === $result ) {
67
-    		$status = __('Error', 'gravityview');
67
+    		$status = __( 'Error', 'gravityview' );
68 68
     		global $wpdb;
69 69
 		    $note = sprintf( '%s: Failed to assign User ID #%d as the entry creator (Last database error: "%s")', $status, $user_id, $wpdb->last_error );
70 70
     	} else {
71
-    		$status = __('Success', 'gravityview');
72
-    	    $note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
71
+    		$status = __( 'Success', 'gravityview' );
72
+    	    $note = sprintf( _x( '%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview' ), $status, $user_id );
73 73
     	}
74 74
 
75 75
     	gravityview()->log->debug( 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - {note}', array( 'note' => $note ) );
@@ -79,11 +79,11 @@  discard block
 block discarded – undo
79 79
 	     * @since 1.21.5
80 80
 	     * @param boolean $disable Disable the Change Entry Creator note. Default: false.
81 81
 	     */
82
-	    if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
82
+	    if ( apply_filters( 'gravityview_disable_change_entry_creator_note', false ) ) {
83 83
 		    return;
84 84
 	    }
85 85
 
86
-        GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
86
+        GravityView_Entry_Notes::add_note( $entry[ 'id' ], -1, 'GravityView', $note, 'gravityview' );
87 87
 
88 88
     }
89 89
 
@@ -95,8 +95,8 @@  discard block
 block discarded – undo
95 95
 
96 96
     	// Plugin that was provided here:
97 97
     	// @link https://gravityview.co/support/documentation/201991205/
98
-    	remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
-    	remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
98
+    	remove_action( "gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
+    	remove_action( "gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
100 100
 
101 101
     }
102 102
 
@@ -107,26 +107,26 @@  discard block
 block discarded – undo
107 107
     function load() {
108 108
 
109 109
     	// Does GF exist?
110
-        if( !class_exists('GFCommon') ) {
110
+        if ( ! class_exists( 'GFCommon' ) ) {
111 111
             return;
112 112
         }
113 113
 
114 114
         // Can the user edit entries?
115
-        if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
115
+        if ( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
116 116
             return;
117 117
         }
118 118
 
119 119
         // If screen mode isn't set, then we're in the wrong place.
120
-        if( empty( $_REQUEST['screen_mode'] ) ) {
120
+        if ( empty( $_REQUEST[ 'screen_mode' ] ) ) {
121 121
             return;
122 122
         }
123 123
 
124 124
         // Now, no validation is required in the methods; let's hook in.
125
-        add_action('admin_init', array( &$this, 'set_screen_mode' ) );
125
+        add_action( 'admin_init', array( &$this, 'set_screen_mode' ) );
126 126
 
127
-        add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
127
+        add_action( "gform_entry_info", array( &$this, 'add_select' ), 10, 2 );
128 128
 
129
-        add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
129
+        add_action( "gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2 );
130 130
 
131 131
     }
132 132
 
@@ -137,8 +137,8 @@  discard block
 block discarded – undo
137 137
     function set_screen_mode() {
138 138
 
139 139
     	// If $_GET['screen_mode'] is set to edit, set $_POST value
140
-        if( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
141
-            $_POST["screen_mode"] = 'edit';
140
+        if ( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
141
+            $_POST[ "screen_mode" ] = 'edit';
142 142
         }
143 143
 
144 144
     }
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
      * @param  int $entry_id Entry ID
150 150
      * @return void
151 151
      */
152
-    function update_entry_creator($form, $entry_id) {
152
+    function update_entry_creator( $form, $entry_id ) {
153 153
             global $current_user;
154 154
 
155 155
         // Update the entry
156
-        $created_by = absint( \GV\Utils::_POST( 'created_by') );
156
+        $created_by = absint( \GV\Utils::_POST( 'created_by' ) );
157 157
 
158 158
         RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
159 159
 
@@ -161,30 +161,30 @@  discard block
 block discarded – undo
161 161
         $originally_created_by = \GV\Utils::_POST( 'originally_created_by' );
162 162
 
163 163
         // If there's no owner and there didn't used to be, keep going
164
-        if( empty( $originally_created_by ) && empty( $created_by ) ) {
164
+        if ( empty( $originally_created_by ) && empty( $created_by ) ) {
165 165
             return;
166 166
         }
167 167
 
168 168
         // If the values have changed
169
-        if( absint( $originally_created_by ) !== absint( $created_by ) ) {
169
+        if ( absint( $originally_created_by ) !== absint( $created_by ) ) {
170 170
 
171
-            $user_data = get_userdata($current_user->ID);
171
+            $user_data = get_userdata( $current_user->ID );
172 172
 
173
-            $user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
173
+            $user_format = _x( '%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview' );
174 174
 
175
-            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
175
+            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview' );
176 176
 
177
-            if( !empty( $originally_created_by ) ) {
178
-                $originally_created_by_user_data = get_userdata($originally_created_by);
177
+            if ( ! empty( $originally_created_by ) ) {
178
+                $originally_created_by_user_data = get_userdata( $originally_created_by );
179 179
                 $original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
180 180
             }
181 181
 
182
-            if( !empty( $created_by ) ) {
183
-                $created_by_user_data =  get_userdata($created_by);
182
+            if ( ! empty( $created_by ) ) {
183
+                $created_by_user_data = get_userdata( $created_by );
184 184
                 $created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
185 185
             }
186 186
 
187
-            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
187
+            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __( 'Changed entry creator from %s to %s', 'gravityview' ), $original_name, $created_by_name ), 'note' );
188 188
         }
189 189
 
190 190
     }
@@ -195,9 +195,9 @@  discard block
 block discarded – undo
195 195
      * @param array $entry    GF entry array
196 196
      * @return void
197 197
      */
198
-    function add_select($form_id, $entry ) {
198
+    function add_select( $form_id, $entry ) {
199 199
 
200
-        if( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
200
+        if ( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
201 201
             return;
202 202
         }
203 203
 
@@ -216,23 +216,23 @@  discard block
 block discarded – undo
216 216
 	    }
217 217
 
218 218
         $output = '<label for="change_created_by">';
219
-        $output .= esc_html__('Change Entry Creator:', 'gravityview');
219
+        $output .= esc_html__( 'Change Entry Creator:', 'gravityview' );
220 220
         $output .= '</label>';
221 221
 
222 222
 	    // If there are users who are not being shown, show a warning.
223 223
 	    // TODO: Use AJAX instead of <select>
224 224
 	    $count_users = count_users();
225
-	    if( sizeof( $users ) < $count_users['total_users'] ) {
225
+	    if ( sizeof( $users ) < $count_users[ 'total_users' ] ) {
226 226
 		    $output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
227 227
 	    }
228 228
 
229 229
 	    $output .= '<select name="created_by" id="change_created_by" class="widefat">';
230
-        $output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
231
-        foreach($users as $user) {
232
-            $output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
230
+        $output .= '<option value="' . selected( $entry[ 'created_by' ], '0', false ) . '"> &mdash; ' . esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview' ) . ' &mdash; </option>';
231
+        foreach ( $users as $user ) {
232
+            $output .= '<option value="' . $user->ID . '"' . selected( $entry[ 'created_by' ], $user->ID, false ) . '>' . esc_attr( $user->display_name . ' (' . $user->user_nicename . ')' ) . '</option>';
233 233
         }
234 234
         $output .= '</select>';
235
-        $output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
235
+        $output .= '<input name="originally_created_by" value="' . esc_attr( $entry[ 'created_by' ] ) . '" type="hidden" />';
236 236
 
237 237
 	    unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
238 238
 
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +29 added lines, -30 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$supports = array( 'title', 'revisions' );
109 109
 
110 110
 		if ( $is_hierarchical ) {
111
-			$supports[] = 'page-attributes';
111
+			$supports[ ] = 'page-attributes';
112 112
 		}
113 113
 
114 114
 		/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211 211
 
212 212
 		add_filter( 'query_vars', function( $query_vars ) { 
213
-			$query_vars[] = 'csv';
213
+			$query_vars[ ] = 'csv';
214 214
 			return $query_vars;
215 215
 		} );
216 216
 
217
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
217
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
218 218
 			call_user_func_array( 'add_rewrite_rule', $rule );
219 219
 		}
220 220
 	}
@@ -283,13 +283,13 @@  discard block
 block discarded – undo
283 283
 			return $content;
284 284
 		}
285 285
 
286
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
286
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
287 287
 
288 288
 		/**
289 289
 		 * Editing a single entry.
290 290
 		 */
291 291
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
292
-			if ( $entry['status'] != 'active' ) {
292
+			if ( $entry[ 'status' ] != 'active' ) {
293 293
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
294 294
 				return __( 'You are not allowed to view this content.', 'gravityview' );
295 295
 			}
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 			}
301 301
 
302 302
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
303
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
303
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
304 304
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
305 305
 					return __( 'You are not allowed to view this content.', 'gravityview' );
306 306
 				}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 		 * Viewing a single entry.
314 314
 		 */
315 315
 		} else if ( $entry = $request->is_entry( $view->form ? $view->form->ID : 0 ) ) {
316
-			if ( $entry['status'] != 'active' ) {
316
+			if ( $entry[ 'status' ] != 'active' ) {
317 317
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
318 318
 				return __( 'You are not allowed to view this content.', 'gravityview' );
319 319
 			}
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 			}
325 325
 
326 326
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
327
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
327
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
328 328
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
329 329
 					return __( 'You are not allowed to view this content.', 'gravityview' );
330 330
 				}
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
499 499
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
500 500
 
501
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
501
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
502 502
 		}
503 503
 
504 504
 		return $joins;
@@ -540,10 +540,10 @@  discard block
 block discarded – undo
540 540
 
541 541
 			list( $join, $join_column, $join_on, $join_on_column ) = $meta;
542 542
 
543
-			$forms_ids [] = GF_Form::by_id( $join_on );
543
+			$forms_ids [ ] = GF_Form::by_id( $join_on );
544 544
 		}
545 545
 
546
-		return ( !empty( $forms_ids) ) ? $forms_ids : null;
546
+		return ( ! empty( $forms_ids ) ) ? $forms_ids : null;
547 547
 	}
548 548
 
549 549
 	/**
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
 		if ( ! $view->form ) {
582 582
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
583 583
 				'view_id' => $view->ID,
584
-				'form_id' => $view->_gravityview_form_id ? : 0,
584
+				'form_id' => $view->_gravityview_form_id ?: 0,
585 585
 			) );
586 586
 		}
587 587
 
@@ -814,34 +814,33 @@  discard block
 block discarded – undo
814 814
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
815 815
 			 */
816 816
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
817
-			$parameters['context_view_id'] = $this->ID;
817
+			$parameters[ 'context_view_id' ] = $this->ID;
818 818
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
819 819
 
820 820
 			if ( $request instanceof REST\Request ) {
821 821
 				$atts = $this->settings->as_atts();
822 822
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
823
-						'paging' => array( 'page_size' => $atts['page_size'] ),
823
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
824 824
 					) );
825
-				$parameters['paging'] = $paging_parameters['paging'];
825
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
826 826
 			}
827 827
 
828
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
829
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
828
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
830 829
 
831 830
 			/**
832 831
 			 * Cleanup duplicate field_filter parameters to simplify the query.
833 832
 			 */
834 833
 			$unique_field_filters = array();
835
-			foreach ( $parameters['search_criteria']['field_filters'] as $key => $filter ) {
834
+			foreach ( $parameters[ 'search_criteria' ][ 'field_filters' ] as $key => $filter ) {
836 835
 				if ( 'mode' === $key ) {
837
-					$unique_field_filters['mode'] = $filter;
836
+					$unique_field_filters[ 'mode' ] = $filter;
838 837
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
839
-					$unique_field_filters[] = $filter;
838
+					$unique_field_filters[ ] = $filter;
840 839
 				}
841 840
 			}
842
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
841
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
843 842
 
844
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
843
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
845 844
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
846 845
 			}
847 846
 
@@ -849,10 +848,10 @@  discard block
 block discarded – undo
849 848
 				/**
850 849
 				 * New \GF_Query stuff :)
851 850
 				 */
852
-				$query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
851
+				$query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
853 852
 
854
-				$query->limit( $parameters['paging']['page_size'] )
855
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
853
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
854
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
856 855
 
857 856
 				/**
858 857
 				 * Any joins?
@@ -894,15 +893,15 @@  discard block
 block discarded – undo
894 893
 				} );
895 894
 			} else {
896 895
 				$entries = $this->form->entries
897
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
896
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
898 897
 					->offset( $this->settings->get( 'offset' ) )
899
-					->limit( $parameters['paging']['page_size'] )
898
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
900 899
 					->page( $page );
901 900
 
902
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
901
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
903 902
 					$field = new \GV\Field();
904
-					$field->ID = $parameters['sorting']['key'];
905
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
903
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
904
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
906 905
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
907 906
 				}
908 907
 			}
Please login to merge, or discard this patch.
includes/class-admin-installer.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 */
54 54
 	public function register_noconflict( $items ) {
55 55
 
56
-		$items[] = 'gravityview-admin-installer';
56
+		$items[ ] = 'gravityview-admin-installer';
57 57
 
58 58
 		return $items;
59 59
 	}
@@ -72,17 +72,17 @@  discard block
 block discarded – undo
72 72
 			return;
73 73
 		}
74 74
 
75
-		add_filter( 'plugins_api', function ( $data, $action, $args ) use ( $downloads_data ) {
75
+		add_filter( 'plugins_api', function( $data, $action, $args ) use ( $downloads_data ) {
76 76
 			foreach ( $downloads_data as $extension ) {
77
-				if ( empty( $extension['info'] ) || empty( $args->slug ) || $args->slug !== $extension['info']['slug'] ) {
77
+				if ( empty( $extension[ 'info' ] ) || empty( $args->slug ) || $args->slug !== $extension[ 'info' ][ 'slug' ] ) {
78 78
 					continue;
79 79
 				}
80 80
 
81
-				return (object) array(
82
-					'slug'          => $extension['info']['slug'],
83
-					'name'          => $extension['info']['title'],
84
-					'version'       => $extension['licensing']['version'],
85
-					'download_link' => $extension['files'][0]['file'],
81
+				return (object)array(
82
+					'slug'          => $extension[ 'info' ][ 'slug' ],
83
+					'name'          => $extension[ 'info' ][ 'title' ],
84
+					'version'       => $extension[ 'licensing' ][ 'version' ],
85
+					'download_link' => $extension[ 'files' ][ 0 ][ 'file' ],
86 86
 				);
87 87
 			}
88 88
 
@@ -144,13 +144,13 @@  discard block
 block discarded – undo
144 144
 
145 145
 		foreach ( $all_plugins as $path => $plugin ) {
146 146
 
147
-			if ( empty( $plugin['TextDomain'] ) ) {
147
+			if ( empty( $plugin[ 'TextDomain' ] ) ) {
148 148
 				continue;
149 149
 			}
150 150
 
151
-			$wp_plugins[ $plugin['TextDomain'] ] = array(
151
+			$wp_plugins[ $plugin[ 'TextDomain' ] ] = array(
152 152
 				'path'      => $path,
153
-				'version'   => $plugin['Version'],
153
+				'version'   => $plugin[ 'Version' ],
154 154
 				'activated' => is_plugin_active( $path )
155 155
 			);
156 156
 		}
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 			return $downloads_data;
209 209
 		}
210 210
 
211
-		if( \GV\Plugin::is_network_activated() ) {
211
+		if ( \GV\Plugin::is_network_activated() ) {
212 212
 			$home_url = network_home_url();
213 213
 		} else {
214 214
 			$home_url = home_url();
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 
237 237
 		$downloads_data = json_decode( wp_remote_retrieve_body( $response ), true );
238 238
 
239
-		if ( empty( $downloads_data['products'] ) ) {
239
+		if ( empty( $downloads_data[ 'products' ] ) ) {
240 240
 			return array();
241 241
 		}
242 242
 
243
-		$this->set_downloads_data( $downloads_data['products'] );
243
+		$this->set_downloads_data( $downloads_data[ 'products' ] );
244 244
 
245
-		return $downloads_data['products'];
245
+		return $downloads_data[ 'products' ];
246 246
 	}
247 247
 
248 248
 	/**
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 
316 316
 				foreach ( $downloads_data as $extension ) {
317 317
 
318
-					if ( empty( $extension['info'] ) ) {
318
+					if ( empty( $extension[ 'info' ] ) ) {
319 319
 						continue;
320 320
 					}
321 321
 
@@ -344,29 +344,29 @@  discard block
 block discarded – undo
344 344
 
345 345
         $details = $this->get_download_display_details( $download, $wp_plugins );
346 346
 
347
-        $download_info = $details['download_info'];
347
+        $download_info = $details[ 'download_info' ];
348 348
 
349 349
 		?>
350
-        <div class="item <?php echo esc_attr( $details['item_class'] ); ?>">
350
+        <div class="item <?php echo esc_attr( $details[ 'item_class' ] ); ?>">
351 351
             <div class="addon-inner">
352
-                <a href="<?php echo esc_url( $download_info['link'] ); ?>" rel="external noreferrer noopener" title="<?php esc_html_e( 'Visit the plugin page', 'gravityview' ); ?>"><img class="thumbnail" src="<?php echo esc_attr( $download_info['thumbnail'] ); ?>" alt="" /></a>
353
-                <h3><?php echo esc_html( \GV\Utils::get( $download_info, 'installer_title', $download_info['title'] ) ); ?></h3>
352
+                <a href="<?php echo esc_url( $download_info[ 'link' ] ); ?>" rel="external noreferrer noopener" title="<?php esc_html_e( 'Visit the plugin page', 'gravityview' ); ?>"><img class="thumbnail" src="<?php echo esc_attr( $download_info[ 'thumbnail' ] ); ?>" alt="" /></a>
353
+                <h3><?php echo esc_html( \GV\Utils::get( $download_info, 'installer_title', $download_info[ 'title' ] ) ); ?></h3>
354 354
                 <div>
355
-                    <?php if( ! empty( $details['status_label'] ) ) { ?>
356
-                    <div class="status <?php echo esc_attr( $details['status'] ); ?>" title="<?php printf( esc_attr__( 'Plugin status: %s', 'gravityview' ), esc_html( $details['status_label'] ) ); ?>">
357
-                        <span class="dashicons dashicons-admin-plugins"></span> <span class="status-label"><?php echo esc_html( $details['status_label'] ); ?></span>
355
+                    <?php if ( ! empty( $details[ 'status_label' ] ) ) { ?>
356
+                    <div class="status <?php echo esc_attr( $details[ 'status' ] ); ?>" title="<?php printf( esc_attr__( 'Plugin status: %s', 'gravityview' ), esc_html( $details[ 'status_label' ] ) ); ?>">
357
+                        <span class="dashicons dashicons-admin-plugins"></span> <span class="status-label"><?php echo esc_html( $details[ 'status_label' ] ); ?></span>
358 358
                     </div>
359 359
 			        <?php } ?>
360 360
 
361
-                    <a data-status="<?php echo esc_attr( $details['status'] ); ?>" data-plugin-path="<?php echo esc_attr( $details['plugin_path'] ); ?>" href="<?php echo esc_url( $details['href'] ); ?>" class="button <?php echo esc_attr( $details['button_class'] ); ?>" title="<?php echo esc_attr( $details['button_title'] ); ?>">
362
-                        <span class="title"><?php echo esc_html( $details['button_label'] ); ?></span>
363
-                        <?php if( $details['spinner'] ) { ?><span class="spinner"></span><?php } ?>
361
+                    <a data-status="<?php echo esc_attr( $details[ 'status' ] ); ?>" data-plugin-path="<?php echo esc_attr( $details[ 'plugin_path' ] ); ?>" href="<?php echo esc_url( $details[ 'href' ] ); ?>" class="button <?php echo esc_attr( $details[ 'button_class' ] ); ?>" title="<?php echo esc_attr( $details[ 'button_title' ] ); ?>">
362
+                        <span class="title"><?php echo esc_html( $details[ 'button_label' ] ); ?></span>
363
+                        <?php if ( $details[ 'spinner' ] ) { ?><span class="spinner"></span><?php } ?>
364 364
                     </a>
365 365
                 </div>
366 366
 
367 367
                 <div class="addon-excerpt"><?php
368 368
 
369
-                    $excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info['excerpt'] );
369
+                    $excerpt = \GV\Utils::get( $download_info, 'installer_excerpt', $download_info[ 'excerpt' ] );
370 370
 
371 371
                     // Allow some pure HTML tags, but remove everything else from the excerpt.
372 372
                     $tags = array( '<strong>', '</strong>', '<em>', '</em>', '<code>', '</code>' );
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 	 */
407 407
 	private function get_download_display_details( $download, $wp_plugins ) {
408 408
 
409
-		$download_info = wp_parse_args( (array) $download['info'], array(
409
+		$download_info = wp_parse_args( (array)$download[ 'info' ], array(
410 410
 			'thumbnail' => '',
411 411
 			'title' => '',
412 412
 			'textdomain' => '',
@@ -418,9 +418,9 @@  discard block
 block discarded – undo
418 418
 			'installer_excerpt' => null, // May not be defined
419 419
 		) );
420 420
 
421
-		$wp_plugin = \GV\Utils::get( $wp_plugins, $download_info['textdomain'], false );
421
+		$wp_plugin = \GV\Utils::get( $wp_plugins, $download_info[ 'textdomain' ], false );
422 422
 
423
-		$has_access = ! empty( $download['files'] );
423
+		$has_access = ! empty( $download[ 'files' ] );
424 424
 		$spinner = true;
425 425
 		$href = $plugin_path = '#';
426 426
 		$status = $item_class = $button_title = $button_class = '';
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 		$required_license = $galactic_only ? __( 'All Access', 'gravityview' ) : __( 'Core + Extensions', 'gravityview' );
431 431
 
432 432
 		// The license is not active - no matter what level, this should not work
433
-		if( ! $is_active  && empty( $base_price ) ) {
433
+		if ( ! $is_active && empty( $base_price ) ) {
434 434
 			$spinner      = false;
435 435
 			$status_label = '';
436 436
 			$button_class = 'disabled disabled-license';
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
 			$status_label = '';
444 444
 			$button_label = sprintf( __( 'Purchase Now for %s', 'gravityview' ), '$' . $base_price );
445 445
 			$button_class = 'button-primary button-large';
446
-			$href         = $download_info['link'];
446
+			$href         = $download_info[ 'link' ];
447 447
 			$item_class   = 'featured';
448 448
 		}
449 449
 
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
 			$href         = 'https://gravityview.co/pricing/?utm_source=admin-installer&utm_medium=admin&utm_campaign=Admin%20Notice&utm_content=' . $required_license;
457 457
 		}
458 458
 
459
-        elseif ( ! empty( $download_info['coming_soon'] ) ) {
459
+        elseif ( ! empty( $download_info[ 'coming_soon' ] ) ) {
460 460
 	        $spinner      = false;
461 461
 	        $status       = 'notinstalled';
462 462
 	        $status_label = __( 'Coming Soon', 'gravityview' );
@@ -471,8 +471,8 @@  discard block
 block discarded – undo
471 471
 			$href = add_query_arg(
472 472
 				array(
473 473
 					'action'   => 'install-plugin',
474
-					'plugin'   => $download_info['slug'],
475
-					'_wpnonce' => wp_create_nonce( 'install-plugin_' . $download_info['slug'] ),
474
+					'plugin'   => $download_info[ 'slug' ],
475
+					'_wpnonce' => wp_create_nonce( 'install-plugin_' . $download_info[ 'slug' ] ),
476 476
 				),
477 477
 				self_admin_url( 'update.php' )
478 478
 			);
@@ -484,25 +484,25 @@  discard block
 block discarded – undo
484 484
 		}
485 485
 
486 486
 		// Access and the plugin is installed but not active
487
-		elseif ( false === $wp_plugin['activated'] ) {
487
+		elseif ( false === $wp_plugin[ 'activated' ] ) {
488 488
 			$status = 'inactive';
489 489
 			$status_label = __( 'Inactive', 'gravityview' );
490 490
 			$button_label = __( 'Activate', 'gravityview' );
491
-			$plugin_path = $wp_plugin['path'];
491
+			$plugin_path = $wp_plugin[ 'path' ];
492 492
 
493 493
 		}
494 494
 
495 495
 		// Access and the plugin is installed and active
496 496
 		else {
497 497
 
498
-			$plugin_path = $wp_plugin['path'];
498
+			$plugin_path = $wp_plugin[ 'path' ];
499 499
 			$status = 'active';
500 500
 			$status_label = __( 'Active', 'gravityview' );
501 501
 			$button_label = __( 'Deactivate', 'gravityview' );
502 502
 
503 503
 		}
504 504
 
505
-		return compact( 'download_info','plugin_path', 'status', 'status_label', 'button_title', 'button_class', 'button_label', 'href', 'spinner', 'item_class', 'required_license', 'is_active' );
505
+		return compact( 'download_info', 'plugin_path', 'status', 'status_label', 'button_title', 'button_class', 'button_label', 'href', 'spinner', 'item_class', 'required_license', 'is_active' );
506 506
     }
507 507
 
508 508
 	/**
@@ -517,11 +517,11 @@  discard block
 block discarded – undo
517 517
 	    $base_price = \GV\Utils::get( $download, 'pricing/amount', 0 );
518 518
 		$base_price = \GFCommon::to_number( $base_price );
519 519
 
520
-		unset( $download['pricing']['amount'] );
520
+		unset( $download[ 'pricing' ][ 'amount' ] );
521 521
 
522 522
 		// Price options array, not single price
523
-		if ( ! $base_price && ! empty( $download['pricing'] ) ) {
524
-			$base_price = array_shift( $download['pricing'] );
523
+		if ( ! $base_price && ! empty( $download[ 'pricing' ] ) ) {
524
+			$base_price = array_shift( $download[ 'pricing' ] );
525 525
 		}
526 526
 
527 527
 		return floatval( $base_price );
@@ -535,13 +535,13 @@  discard block
 block discarded – undo
535 535
 	public function activate_download() {
536 536
 		$data = \GV\Utils::_POST( 'data', array() );
537 537
 
538
-		if ( empty( $data['path'] ) ) {
538
+		if ( empty( $data[ 'path' ] ) ) {
539 539
 			return;
540 540
 		}
541 541
 
542
-		$result = activate_plugin( $data['path'] );
542
+		$result = activate_plugin( $data[ 'path' ] );
543 543
 
544
-		if ( is_wp_error( $result ) || ! is_plugin_active( $data['path'] ) ) {
544
+		if ( is_wp_error( $result ) || ! is_plugin_active( $data[ 'path' ] ) ) {
545 545
 			wp_send_json_error( array(
546 546
                 'error' => sprintf( __( 'Plugin activation failed: %s', 'gravityview' ), $result->get_error_message() )
547 547
             ) );
@@ -558,13 +558,13 @@  discard block
 block discarded – undo
558 558
 	public function deactivate_download() {
559 559
 		$data = \GV\Utils::_POST( 'data', array() );
560 560
 
561
-		if ( empty( $data['path'] ) ) {
561
+		if ( empty( $data[ 'path' ] ) ) {
562 562
 			return;
563 563
 		}
564 564
 
565
-		deactivate_plugins( $data['path'] );
565
+		deactivate_plugins( $data[ 'path' ] );
566 566
 
567
-		if( is_plugin_active( $data['path'] ) ) {
567
+		if ( is_plugin_active( $data[ 'path' ] ) ) {
568 568
             wp_send_json_error( array(
569 569
                 'error' => sprintf( __( 'Plugin deactivation failed.', 'gravityview' ) )
570 570
             ) );
Please login to merge, or discard this patch.
includes/class-gravityview-gfformsmodel.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -40,17 +40,17 @@  discard block
 block discarded – undo
40 40
 	public static function is_value_match( $field_value, $target_value, $operation = 'is', $source_field = null, $rule = null, $form = null ) {
41 41
 
42 42
 		if ( in_array( $source_field, array( 'date_created', 'date_updated', 'payment_date' ), true ) ) {
43
-			$field_value = is_int( $field_value )? $field_value : strtotime( $field_value );
44
-			$target_value = is_int( $target_value )? $target_value : strtotime( $target_value );
43
+			$field_value = is_int( $field_value ) ? $field_value : strtotime( $field_value );
44
+			$target_value = is_int( $target_value ) ? $target_value : strtotime( $target_value );
45 45
 		}
46 46
 
47 47
 		if ( $source_field instanceof GF_Field && $source_field->type == 'date' ) {
48
-			$field_value = is_int( $field_value )? $field_value : strtotime( $field_value );
49
-			$target_value = is_int( $target_value )? $target_value : strtotime( $target_value );
48
+			$field_value = is_int( $field_value ) ? $field_value : strtotime( $field_value );
49
+			$target_value = is_int( $target_value ) ? $target_value : strtotime( $target_value );
50 50
 		}
51 51
 
52 52
 		if ( in_array( $_operation = str_replace( ' ', '_', trim( $operation ) ), array( 'in', 'not_in' ) ) ) {
53
-			return GVCommon::matches_operation( (array) $field_value, (array) $target_value, $_operation );
53
+			return GVCommon::matches_operation( (array)$field_value, (array)$target_value, $_operation );
54 54
 		}
55 55
 
56 56
 		return parent::is_value_match( $field_value, $target_value, $operation, $source_field, $rule, $form );
@@ -74,18 +74,18 @@  discard block
 block discarded – undo
74 74
 
75 75
         $post_data = self::get_post_fields( $form, $entry );
76 76
 
77
-        $media = get_attached_media( 'image', $entry['post_id'] );
77
+        $media = get_attached_media( 'image', $entry[ 'post_id' ] );
78 78
 
79 79
         $post_images = array();
80 80
 
81 81
         foreach ( $media as $media_item ) {
82
-            foreach( (array) $post_data['images'] as $post_data_item ) {
83
-                if(
82
+            foreach ( (array)$post_data[ 'images' ] as $post_data_item ) {
83
+                if (
84 84
                     \GV\Utils::get( $post_data_item, 'title' ) === $media_item->post_title &&
85 85
                     \GV\Utils::get( $post_data_item, 'description' ) === $media_item->post_content &&
86 86
                     \GV\Utils::get( $post_data_item, 'caption' ) === $media_item->post_excerpt
87 87
                 ) {
88
-                    $post_images["{$post_data_item['field_id']}"] = $media_item->ID;
88
+                    $post_images[ "{$post_data_item[ 'field_id' ]}" ] = $media_item->ID;
89 89
                 }
90 90
             }
91 91
         }
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
          * If the method changes to public, use Gravity Forms' method
114 114
          * @todo: If/when the method is public, remove the unneeded copied code.
115 115
          */
116
-        if( $reflection->isPublic() ) {
116
+        if ( $reflection->isPublic() ) {
117 117
             return parent::get_post_fields( $form, $entry );
118 118
         }
119 119
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
          * If the method changes to public, use Gravity Forms' method
141 141
          * @todo: If/when the method is public, remove the unneeded copied code.
142 142
          */
143
-        if( $reflection->isPublic() ) {
143
+        if ( $reflection->isPublic() ) {
144 144
             return parent::copy_post_image( $url, $post_id );
145 145
         }
146 146
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
          * If the method changes to public, use Gravity Forms' method
176 176
          * @todo: If/when the method is public, remove the unneeded copied code.
177 177
          */
178
-        if( $reflection->isPublic() ) {
178
+        if ( $reflection->isPublic() ) {
179 179
             return parent::media_handle_upload( $url, $post_id, $post_data );
180 180
         }
181 181
 
Please login to merge, or discard this patch.
includes/class-api.php 1 patch
Spacing   +103 added lines, -103 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
 		$form = $gravityview_view->getForm();
33 33
 
34
-		if ( defined( 'DOING_GRAVITYVIEW_TESTS' ) && ! empty( $GLOBALS['GravityView_API_field_label_override'] ) ) {
34
+		if ( defined( 'DOING_GRAVITYVIEW_TESTS' ) && ! empty( $GLOBALS[ 'GravityView_API_field_label_override' ] ) ) {
35 35
 			/** Allow to fall through for back compatibility testing purposes. */
36 36
 		} else {
37 37
 			return \GV\Mocks\GravityView_API_field_label( $form, $field, $entry, $force_show_label );
@@ -39,29 +39,29 @@  discard block
 block discarded – undo
39 39
 
40 40
 		$label = '';
41 41
 
42
-		if( !empty( $field['show_label'] ) || $force_show_label ) {
42
+		if ( ! empty( $field[ 'show_label' ] ) || $force_show_label ) {
43 43
 
44
-			$label = $field['label'];
44
+			$label = $field[ 'label' ];
45 45
 
46 46
 			// Support Gravity Forms 1.9+
47
-			if( class_exists( 'GF_Field' ) ) {
47
+			if ( class_exists( 'GF_Field' ) ) {
48 48
 
49
-				$field_object = RGFormsModel::get_field( $form, $field['id'] );
49
+				$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
50 50
 
51
-				if( $field_object ) {
51
+				if ( $field_object ) {
52 52
 
53
-					$input = GFFormsModel::get_input( $field_object, $field['id'] );
53
+					$input = GFFormsModel::get_input( $field_object, $field[ 'id' ] );
54 54
 
55 55
 					// This is a complex field, with labels on a per-input basis
56
-					if( $input ) {
56
+					if ( $input ) {
57 57
 
58 58
 						// Does the input have a custom label on a per-input basis? Otherwise, default label.
59
-						$label = ! empty( $input['customLabel'] ) ? $input['customLabel'] : $input['label'];
59
+						$label = ! empty( $input[ 'customLabel' ] ) ? $input[ 'customLabel' ] : $input[ 'label' ];
60 60
 
61 61
 					} else {
62 62
 
63 63
 						// This is a field with one label
64
-						$label = $field_object->get_field_label( true, $field['label'] );
64
+						$label = $field_object->get_field_label( true, $field[ 'label' ] );
65 65
 
66 66
 					}
67 67
 
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
 			}
71 71
 
72 72
 			// Use Gravity Forms label by default, but if a custom label is defined in GV, use it.
73
-			if ( !empty( $field['custom_label'] ) ) {
73
+			if ( ! empty( $field[ 'custom_label' ] ) ) {
74 74
 
75
-				$label = self::replace_variables( $field['custom_label'], $form, $entry );
75
+				$label = self::replace_variables( $field[ 'custom_label' ], $form, $entry );
76 76
 
77 77
 			}
78 78
 
@@ -134,11 +134,11 @@  discard block
 block discarded – undo
134 134
 
135 135
 		$width = NULL;
136 136
 
137
-		if( !empty( $field['width'] ) ) {
138
-			$width = absint( $field['width'] );
137
+		if ( ! empty( $field[ 'width' ] ) ) {
138
+			$width = absint( $field[ 'width' ] );
139 139
 
140 140
 			// If using percentages, limit to 100%
141
-			if( '%d%%' === $format && $width > 100 ) {
141
+			if ( '%d%%' === $format && $width > 100 ) {
142 142
 				$width = 100;
143 143
 			}
144 144
 
@@ -159,42 +159,42 @@  discard block
 block discarded – undo
159 159
 	public static function field_class( $field, $form = NULL, $entry = NULL ) {
160 160
 		$classes = array();
161 161
 
162
-		if( !empty( $field['custom_class'] ) ) {
162
+		if ( ! empty( $field[ 'custom_class' ] ) ) {
163 163
 
164
-            $custom_class = $field['custom_class'];
164
+            $custom_class = $field[ 'custom_class' ];
165 165
 
166
-            if( !empty( $entry ) ) {
166
+            if ( ! empty( $entry ) ) {
167 167
 
168 168
                 // We want the merge tag to be formatted as a class. The merge tag may be
169 169
                 // replaced by a multiple-word value that should be output as a single class.
170 170
                 // "Office Manager" will be formatted as `.OfficeManager`, not `.Office` and `.Manager`
171
-                add_filter('gform_merge_tag_filter', 'sanitize_html_class');
171
+                add_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
172 172
 
173
-                $custom_class = self::replace_variables( $custom_class, $form, $entry);
173
+                $custom_class = self::replace_variables( $custom_class, $form, $entry );
174 174
 
175 175
                 // And then we want life to return to normal
176
-                remove_filter('gform_merge_tag_filter', 'sanitize_html_class');
176
+                remove_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
177 177
             }
178 178
 
179 179
 			// And now we want the spaces to be handled nicely.
180
-			$classes[] = gravityview_sanitize_html_class( $custom_class );
180
+			$classes[ ] = gravityview_sanitize_html_class( $custom_class );
181 181
 
182 182
 		}
183 183
 
184
-		if(!empty($field['id'])) {
185
-			if( !empty( $form ) && !empty( $form['id'] ) ) {
186
-				$form_id = '-'.$form['id'];
184
+		if ( ! empty( $field[ 'id' ] ) ) {
185
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
186
+				$form_id = '-' . $form[ 'id' ];
187 187
 			} else {
188 188
 				// @deprecated path. Form should always be given.
189 189
 				gravityview()->log->warning( 'GravityView_View::getInstance() legacy API called' );
190 190
 				$gravityview_view = GravityView_View::getInstance();
191
-				$form_id = $gravityview_view->getFormId() ? '-'. $gravityview_view->getFormId() : '';
191
+				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
192 192
 			}
193 193
 
194
-			$classes[] = 'gv-field'.$form_id.'-'.$field['id'];
194
+			$classes[ ] = 'gv-field' . $form_id . '-' . $field[ 'id' ];
195 195
 		}
196 196
 
197
-		return esc_attr(implode(' ', $classes));
197
+		return esc_attr( implode( ' ', $classes ) );
198 198
 	}
199 199
 
200 200
 	/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 	 * @return string Sanitized unique HTML `id` attribute for the field
211 211
 	 */
212 212
 	public static function field_html_attr_id( $field, $form = array(), $entry = array() ) {
213
-		$id = $field['id'];
213
+		$id = $field[ 'id' ];
214 214
 
215 215
 		if ( ! empty( $id ) ) {
216
-			if ( ! empty( $form ) && ! empty( $form['id'] ) ) {
217
-				$form_id = '-' . $form['id'];
216
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
217
+				$form_id = '-' . $form[ 'id' ];
218 218
 			} else {
219 219
 				// @deprecated path. Form should always be given.
220 220
 				gravityview()->log->warning( 'GravityView_View::getInstance() legacy API called' );
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
223 223
 			}
224 224
 
225
-			$id = 'gv-field' . $form_id . '-' . $field['id'];
225
+			$id = 'gv-field' . $form_id . '-' . $field[ 'id' ];
226 226
 		}
227 227
 
228 228
 		return esc_attr( $id );
@@ -262,14 +262,14 @@  discard block
 block discarded – undo
262 262
 	 */
263 263
 	public static function entry_link_html( $entry = array(), $anchor_text = '', $passed_tag_atts = array(), $field_settings = array(), $base_id = null ) {
264 264
 
265
-		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry['id'] ) ) {
265
+		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry[ 'id' ] ) ) {
266 266
 			gravityview()->log->debug( 'Entry not defined; returning null', array( 'data' => $entry ) );
267 267
 			return NULL;
268 268
 		}
269 269
 
270 270
 		$href = self::entry_link( $entry, $base_id );
271 271
 
272
-		if( '' === $href ) {
272
+		if ( '' === $href ) {
273 273
 			return NULL;
274 274
 		}
275 275
 
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 		} else {
307 307
 			$gravityview_view = GravityView_View::getInstance();
308 308
 
309
-			if( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
309
+			if ( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
310 310
 				$is_search = true;
311 311
 			}
312 312
 		}
@@ -403,9 +403,9 @@  discard block
 block discarded – undo
403 403
 
404 404
 		// If we've saved the permalink in memory, use it
405 405
 		// @since 1.3
406
-		$link = wp_cache_get( 'gv_directory_link_'.$post_id );
406
+		$link = wp_cache_get( 'gv_directory_link_' . $post_id );
407 407
 
408
-		if ( (int) $post_id === (int) get_option( 'page_on_front' ) ) {
408
+		if ( (int)$post_id === (int)get_option( 'page_on_front' ) ) {
409 409
 			$link = home_url();
410 410
 		}
411 411
 
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 
415 415
 			// If not yet saved, cache the permalink.
416 416
 			// @since 1.3
417
-			wp_cache_set( 'gv_directory_link_'.$post_id, $link );
417
+			wp_cache_set( 'gv_directory_link_' . $post_id, $link );
418 418
 		}
419 419
 
420 420
 		// Deal with returning to proper pagination for embedded views
@@ -422,13 +422,13 @@  discard block
 block discarded – undo
422 422
 
423 423
 			$args = array();
424 424
 
425
-			if( $pagenum = \GV\Utils::_GET( 'pagenum' ) ) {
426
-				$args['pagenum'] = intval( $pagenum );
425
+			if ( $pagenum = \GV\Utils::_GET( 'pagenum' ) ) {
426
+				$args[ 'pagenum' ] = intval( $pagenum );
427 427
 			}
428 428
 
429
-			if( $sort = \GV\Utils::_GET( 'sort' ) ) {
430
-				$args['sort'] = $sort;
431
-				$args['dir'] = \GV\Utils::_GET( 'dir' );
429
+			if ( $sort = \GV\Utils::_GET( 'sort' ) ) {
430
+				$args[ 'sort' ] = $sort;
431
+				$args[ 'dir' ] = \GV\Utils::_GET( 'dir' );
432 432
 			}
433 433
 
434 434
 			$link = add_query_arg( $args, $link );
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
 	private static function get_custom_entry_slug( $id, $entry = array() ) {
466 466
 
467 467
 		// Generate an unique hash to use as the default value
468
-		$slug = substr( wp_hash( $id, 'gravityview'.$id ), 0, 8 );
468
+		$slug = substr( wp_hash( $id, 'gravityview' . $id ), 0, 8 );
469 469
 
470 470
 		/**
471 471
 		 * @filter `gravityview_entry_slug` Modify the unique hash ID generated, if you want to improve usability or change the format. This will allow for custom URLs, such as `{entryid}-{first-name}` or even, if unique, `{first-name}-{last-name}`
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
 		$slug = apply_filters( 'gravityview_entry_slug', $slug, $id, $entry );
477 477
 
478 478
 		// Make sure we have something - use the original ID as backup.
479
-		if( empty( $slug ) ) {
479
+		if ( empty( $slug ) ) {
480 480
 			$slug = $id;
481 481
 		}
482 482
 
@@ -570,15 +570,15 @@  discard block
 block discarded – undo
570 570
          * @param boolean $custom Should we process the custom entry slug?
571 571
          */
572 572
         $custom = apply_filters( 'gravityview_custom_entry_slug', false );
573
-        if( $custom ) {
573
+        if ( $custom ) {
574 574
             // create the gravityview_unique_id and save it
575 575
 
576 576
             // Get the entry hash
577
-            $hash = self::get_custom_entry_slug( $entry['id'], $entry );
577
+            $hash = self::get_custom_entry_slug( $entry[ 'id' ], $entry );
578 578
 
579
-	        gravityview()->log->debug( 'Setting hash for entry {entry_id}: {hash}', array( 'entry_id' => $entry['id'], 'hash' => $hash ) );
579
+	        gravityview()->log->debug( 'Setting hash for entry {entry_id}: {hash}', array( 'entry_id' => $entry[ 'id' ], 'hash' => $hash ) );
580 580
 
581
-            gform_update_meta( $entry['id'], 'gravityview_unique_id', $hash, \GV\Utils::get( $entry, 'form_id' ) );
581
+            gform_update_meta( $entry[ 'id' ], 'gravityview_unique_id', $hash, \GV\Utils::get( $entry, 'form_id' ) );
582 582
 
583 583
         }
584 584
     }
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
 
598 598
 		if ( ! empty( $entry ) && ! is_array( $entry ) ) {
599 599
 			$entry = GVCommon::get_entry( $entry );
600
-		} else if( empty( $entry ) ) {
600
+		} else if ( empty( $entry ) ) {
601 601
 			// @deprecated path
602 602
 			$entry = GravityView_frontend::getInstance()->getEntry();
603 603
 		}
@@ -617,9 +617,9 @@  discard block
 block discarded – undo
617 617
 
618 618
 		$query_arg_name = \GV\Entry::get_endpoint_name();
619 619
 
620
-		$entry_slug = self::get_entry_slug( $entry['id'], $entry );
620
+		$entry_slug = self::get_entry_slug( $entry[ 'id' ], $entry );
621 621
 
622
-		if ( get_option('permalink_structure') && !is_preview() ) {
622
+		if ( get_option( 'permalink_structure' ) && ! is_preview() ) {
623 623
 
624 624
 			$args = array();
625 625
 
@@ -629,9 +629,9 @@  discard block
 block discarded – undo
629 629
 			 */
630 630
 			$link_parts = explode( '?', $directory_link );
631 631
 
632
-			$query = !empty( $link_parts[1] ) ? '?'.$link_parts[1] : '';
632
+			$query = ! empty( $link_parts[ 1 ] ) ? '?' . $link_parts[ 1 ] : '';
633 633
 
634
-			$directory_link = trailingslashit( $link_parts[0] ) . $query_arg_name . '/'. $entry_slug .'/' . $query;
634
+			$directory_link = trailingslashit( $link_parts[ 0 ] ) . $query_arg_name . '/' . $entry_slug . '/' . $query;
635 635
 
636 636
 		} else {
637 637
 
@@ -643,21 +643,21 @@  discard block
 block discarded – undo
643 643
 		 */
644 644
 		if ( $add_directory_args ) {
645 645
 
646
-			if ( ! empty( $_GET['pagenum'] ) ) {
647
-				$args['pagenum'] = intval( $_GET['pagenum'] );
646
+			if ( ! empty( $_GET[ 'pagenum' ] ) ) {
647
+				$args[ 'pagenum' ] = intval( $_GET[ 'pagenum' ] );
648 648
 			}
649 649
 
650 650
 			/**
651 651
 			 * @since 1.7
652 652
 			 */
653 653
 			if ( $sort = \GV\Utils::_GET( 'sort' ) ) {
654
-				$args['sort'] = $sort;
655
-				$args['dir'] = \GV\Utils::_GET( 'dir' );
654
+				$args[ 'sort' ] = $sort;
655
+				$args[ 'dir' ] = \GV\Utils::_GET( 'dir' );
656 656
 			}
657 657
 
658 658
 		}
659 659
 
660
-		if( $post_id ) {
660
+		if ( $post_id ) {
661 661
 			$passed_post = get_post( $post_id );
662 662
 			$views       = \GV\View_Collection::from_post( $passed_post );
663 663
 			$has_multiple_views = $views->count() > 1;
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
 		}
667 667
 
668 668
 		if ( $has_multiple_views ) {
669
-			$args['gvid'] = gravityview_get_view_id();
669
+			$args[ 'gvid' ] = gravityview_get_view_id();
670 670
 		}
671 671
 
672 672
 		return add_query_arg( $args, $directory_link );
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
 }
688 688
 
689 689
 function gv_class( $field, $form = NULL, $entry = array() ) {
690
-	return GravityView_API::field_class( $field, $form, $entry  );
690
+	return GravityView_API::field_class( $field, $form, $entry );
691 691
 }
692 692
 
693 693
 /**
@@ -710,7 +710,7 @@  discard block
 block discarded – undo
710 710
 		$view_id = 0;
711 711
 		if ( $context->view ) {
712 712
 			$view_id = $context->view->ID;
713
-			if( $context->view->settings->get( 'hide_until_searched' ) ) {
713
+			if ( $context->view->settings->get( 'hide_until_searched' ) ) {
714 714
 				$hide_until_searched = ( empty( $context->entry ) && ! $context->request->is_search() );
715 715
 			}
716 716
 		}
@@ -738,7 +738,7 @@  discard block
 block discarded – undo
738 738
 		$default_css_class .= ' gv-container-no-results';
739 739
 	}
740 740
 
741
-	$css_class = trim( $passed_css_class . ' '. $default_css_class );
741
+	$css_class = trim( $passed_css_class . ' ' . $default_css_class );
742 742
 
743 743
 	/**
744 744
 	 * @filter `gravityview/render/container/class` Modify the CSS class to be added to the wrapper <div> of a View
@@ -765,7 +765,7 @@  discard block
 block discarded – undo
765 765
 
766 766
 	$value = GravityView_API::field_value( $entry, $field );
767 767
 
768
-	if( $value === '' ) {
768
+	if ( $value === '' ) {
769 769
 		/**
770 770
 		 * @filter `gravityview_empty_value` What to display when a field is empty
771 771
 		 * @param string $value (empty string)
@@ -878,7 +878,7 @@  discard block
 block discarded – undo
878 878
  */
879 879
 function gravityview_get_field_value( $entry, $field_id, $display_value ) {
880 880
 
881
-	if( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
881
+	if ( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
882 882
 
883 883
 		// For the complete field value as generated by Gravity Forms
884 884
 		return $display_value;
@@ -912,16 +912,16 @@  discard block
 block discarded – undo
912 912
 		$terms = explode( ', ', $value );
913 913
 	}
914 914
 
915
-	foreach ($terms as $term_name ) {
915
+	foreach ( $terms as $term_name ) {
916 916
 
917 917
 		// If we're processing a category,
918
-		if( $taxonomy === 'category' ) {
918
+		if ( $taxonomy === 'category' ) {
919 919
 
920 920
 			// Use rgexplode to prevent errors if : doesn't exist
921 921
 			list( $term_name, $term_id ) = rgexplode( ':', $term_name, 2 );
922 922
 
923 923
 			// The explode was succesful; we have the category ID
924
-			if( !empty( $term_id )) {
924
+			if ( ! empty( $term_id ) ) {
925 925
 				$term = get_term_by( 'id', $term_id, $taxonomy );
926 926
 			} else {
927 927
 			// We have to fall back to the name
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
934 934
 		}
935 935
 
936 936
 		// There's still a tag/category here.
937
-		if( $term ) {
937
+		if ( $term ) {
938 938
 
939 939
 			$term_link = get_term_link( $term, $taxonomy );
940 940
 
@@ -943,11 +943,11 @@  discard block
 block discarded – undo
943 943
 			    continue;
944 944
 			}
945 945
 
946
-			$output[] = gravityview_get_link( $term_link, esc_html( $term->name ) );
946
+			$output[ ] = gravityview_get_link( $term_link, esc_html( $term->name ) );
947 947
 		}
948 948
 	}
949 949
 
950
-	return implode(', ', $output );
950
+	return implode( ', ', $output );
951 951
 }
952 952
 
953 953
 /**
@@ -961,8 +961,8 @@  discard block
 block discarded – undo
961 961
 
962 962
 	$output = get_the_term_list( $post_id, $taxonomy, NULL, ', ' );
963 963
 
964
-	if( empty( $link ) ) {
965
-		return strip_tags( $output);
964
+	if ( empty( $link ) ) {
965
+		return strip_tags( $output );
966 966
 	}
967 967
 
968 968
 	return $output;
@@ -981,7 +981,7 @@  discard block
 block discarded – undo
981 981
 	$fe = GravityView_frontend::getInstance();
982 982
 
983 983
 	// Solve problem when loading content via admin-ajax.php
984
-	if( ! $fe->getGvOutputData() ) {
984
+	if ( ! $fe->getGvOutputData() ) {
985 985
 
986 986
 		gravityview()->log->debug( 'gv_output_data not defined; parsing content.' );
987 987
 
@@ -989,7 +989,7 @@  discard block
 block discarded – undo
989 989
 	}
990 990
 
991 991
 	// Make 100% sure that we're dealing with a properly called situation
992
-	if( !is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
992
+	if ( ! is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
993 993
 
994 994
 		gravityview()->log->debug( 'gv_output_data not an object or get_view not callable.', array( 'data' => $fe->getGvOutputData() ) );
995 995
 
@@ -1211,12 +1211,12 @@  discard block
 block discarded – undo
1211 1211
 function gravityview_get_files_array( $value, $gv_class = '', $context = null ) {
1212 1212
 	/** @define "GRAVITYVIEW_DIR" "../" */
1213 1213
 
1214
-	if( !class_exists( 'GravityView_Field' ) ) {
1215
-		include_once( GRAVITYVIEW_DIR .'includes/fields/class-gravityview-field.php' );
1214
+	if ( ! class_exists( 'GravityView_Field' ) ) {
1215
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/class-gravityview-field.php' );
1216 1216
 	}
1217 1217
 
1218
-	if( !class_exists( 'GravityView_Field_FileUpload' ) ) {
1219
-		include_once( GRAVITYVIEW_DIR .'includes/fields/class-gravityview-field-fileupload.php' );
1218
+	if ( ! class_exists( 'GravityView_Field_FileUpload' ) ) {
1219
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/class-gravityview-field-fileupload.php' );
1220 1220
 	}
1221 1221
 
1222 1222
 	if ( is_null( $context ) ) {
@@ -1319,21 +1319,21 @@  discard block
 block discarded – undo
1319 1319
 	} else {
1320 1320
 		// @deprecated path
1321 1321
 		// Required fields.
1322
-		if ( empty( $args['field'] ) || empty( $args['form'] ) ) {
1322
+		if ( empty( $args[ 'field' ] ) || empty( $args[ 'form' ] ) ) {
1323 1323
 			gravityview()->log->error( 'Field or form are empty.', array( 'data' => $args ) );
1324 1324
 			return '';
1325 1325
 		}
1326 1326
 	}
1327 1327
 
1328 1328
 	if ( $context instanceof \GV\Template_Context ) {
1329
-		$entry = $args['entry'] ? : ( $context->entry ? $context->entry->as_entry() : array() );
1330
-		$field = $args['field'] ? : ( $context->field ? $context->field->as_configuration() : array() );
1331
-		$form = $args['form'] ? : ( $context->view->form ? $context->view->form->form : array() );
1329
+		$entry = $args[ 'entry' ] ?: ( $context->entry ? $context->entry->as_entry() : array() );
1330
+		$field = $args[ 'field' ] ?: ( $context->field ? $context->field->as_configuration() : array() );
1331
+		$form = $args[ 'form' ] ?: ( $context->view->form ? $context->view->form->form : array() );
1332 1332
 	} else {
1333 1333
 		// @deprecated path
1334
-		$entry = empty( $args['entry'] ) ? array() : $args['entry'];
1335
-		$field = $args['field'];
1336
-		$form = $args['form'];
1334
+		$entry = empty( $args[ 'entry' ] ) ? array() : $args[ 'entry' ];
1335
+		$field = $args[ 'field' ];
1336
+		$form = $args[ 'form' ];
1337 1337
 	}
1338 1338
 
1339 1339
 	/**
@@ -1353,43 +1353,43 @@  discard block
 block discarded – undo
1353 1353
 	);
1354 1354
 
1355 1355
 	if ( $context instanceof \GV\Template_Context ) {
1356
-		$placeholders['value'] = \GV\Utils::get( $args, 'value', '' );
1356
+		$placeholders[ 'value' ] = \GV\Utils::get( $args, 'value', '' );
1357 1357
 	} else {
1358 1358
 		// @deprecated path
1359
-		$placeholders['value'] = gv_value( $entry, $field );
1359
+		$placeholders[ 'value' ] = gv_value( $entry, $field );
1360 1360
 	}
1361 1361
 
1362 1362
 	// If the value is empty and we're hiding empty, return empty.
1363
-	if ( $placeholders['value'] === '' && ! empty( $args['hide_empty'] ) ) {
1363
+	if ( $placeholders[ 'value' ] === '' && ! empty( $args[ 'hide_empty' ] ) ) {
1364 1364
 		return '';
1365 1365
 	}
1366 1366
 
1367
-	if ( $placeholders['value'] !== '' && ! empty( $args['wpautop'] ) ) {
1368
-		$placeholders['value'] = wpautop( $placeholders['value'] );
1367
+	if ( $placeholders[ 'value' ] !== '' && ! empty( $args[ 'wpautop' ] ) ) {
1368
+		$placeholders[ 'value' ] = wpautop( $placeholders[ 'value' ] );
1369 1369
 	}
1370 1370
 
1371 1371
 	// Get width setting, if exists
1372
-	$placeholders['width'] = GravityView_API::field_width( $field );
1372
+	$placeholders[ 'width' ] = GravityView_API::field_width( $field );
1373 1373
 
1374 1374
 	// If replacing with CSS inline formatting, let's do it.
1375
-	$placeholders['width:style'] = GravityView_API::field_width( $field, 'width:' . $placeholders['width'] . '%;' );
1375
+	$placeholders[ 'width:style' ] = GravityView_API::field_width( $field, 'width:' . $placeholders[ 'width' ] . '%;' );
1376 1376
 
1377 1377
 	// Grab the Class using `gv_class`
1378
-	$placeholders['class'] = gv_class( $field, $form, $entry );
1379
-	$placeholders['field_id'] = GravityView_API::field_html_attr_id( $field, $form, $entry );
1378
+	$placeholders[ 'class' ] = gv_class( $field, $form, $entry );
1379
+	$placeholders[ 'field_id' ] = GravityView_API::field_html_attr_id( $field, $form, $entry );
1380 1380
 
1381 1381
 	if ( $context instanceof \GV\Template_Context ) {
1382
-		$placeholders['label_value'] = \GV\Utils::get( $args, 'label' );
1382
+		$placeholders[ 'label_value' ] = \GV\Utils::get( $args, 'label' );
1383 1383
 	} else {
1384 1384
 		// Default Label value
1385
-		$placeholders['label_value'] = gv_label( $field, $entry );
1385
+		$placeholders[ 'label_value' ] = gv_label( $field, $entry );
1386 1386
 	}
1387 1387
 
1388
-	$placeholders['label_value:data-label'] = trim( esc_attr( strip_tags( str_replace( '>&nbsp;', '>', $placeholders['label_value'] ) ) ) );
1389
-	$placeholders['label_value:esc_attr'] = esc_attr( $placeholders['label_value'] );
1388
+	$placeholders[ 'label_value:data-label' ] = trim( esc_attr( strip_tags( str_replace( '>&nbsp;', '>', $placeholders[ 'label_value' ] ) ) ) );
1389
+	$placeholders[ 'label_value:esc_attr' ] = esc_attr( $placeholders[ 'label_value' ] );
1390 1390
 
1391
-	if ( empty( $placeholders['label'] ) && ! empty( $placeholders['label_value'] ) ){
1392
-		$placeholders['label'] = '<span class="gv-field-label">{{ label_value }}</span>';
1391
+	if ( empty( $placeholders[ 'label' ] ) && ! empty( $placeholders[ 'label_value' ] ) ) {
1392
+		$placeholders[ 'label' ] = '<span class="gv-field-label">{{ label_value }}</span>';
1393 1393
 	}
1394 1394
 
1395 1395
 	/**
@@ -1400,7 +1400,7 @@  discard block
 block discarded – undo
1400 1400
 	 * @since 2.0
1401 1401
 	 * @param \GV\Template_Context $context The context.
1402 1402
 	 */
1403
-	$html = apply_filters( 'gravityview/field_output/pre_html', $args['markup'], $args, $context );
1403
+	$html = apply_filters( 'gravityview/field_output/pre_html', $args[ 'markup' ], $args, $context );
1404 1404
 
1405 1405
 	/**
1406 1406
 	 * @filter `gravityview/field_output/open_tag` Modify the opening tags for the template content placeholders
@@ -1427,7 +1427,7 @@  discard block
 block discarded – undo
1427 1427
 	foreach ( $placeholders as $tag => $value ) {
1428 1428
 
1429 1429
 		// If the tag doesn't exist just skip it
1430
-		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ){
1430
+		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ) {
1431 1431
 			continue;
1432 1432
 		}
1433 1433
 
Please login to merge, or discard this patch.
future/includes/class-gv-collection-entry.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
 
105 105
 		/** Call all lazy callbacks. */
106 106
 		foreach ( $this->callbacks as $callback ) {
107
-			if ( $callback[0] != 'count' ) {
107
+			if ( $callback[ 0 ] != 'count' ) {
108 108
 				continue;
109 109
 			}
110 110
 
111
-			$total += $callback[1]( $this->filters );
111
+			$total += $callback[ 1 ]( $this->filters );
112 112
 		}
113 113
 
114 114
 		if ( ! $total ) {
@@ -185,11 +185,11 @@  discard block
 block discarded – undo
185 185
 
186 186
 		/** Call all lazy callbacks. */
187 187
 		foreach ( $this->callbacks as $i => $callback ) {
188
-			if ( $callback[0] != 'fetch' ) {
188
+			if ( $callback[ 0 ] != 'fetch' ) {
189 189
 				continue;
190 190
 			}
191 191
 
192
-			$this->merge( $callback[1]( $this->filters, $this->sorts, $offset ) );
192
+			$this->merge( $callback[ 1 ]( $this->filters, $this->sorts, $offset ) );
193 193
 		}
194 194
 
195 195
 		$this->fetched = parent::count();
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
 			return;
346 346
 		}
347 347
 
348
-		$this->callbacks []= array( $type, $callback );
348
+		$this->callbacks [ ] = array( $type, $callback );
349 349
 	}
350 350
 
351 351
 	/**
Please login to merge, or discard this patch.