Completed
Pull Request — develop (#1192)
by Zack
19:08
created
plugin-and-theme-hooks/class-gravityview-theme-hooks-siteorigin.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	function merge_content_meta_keys( $meta_keys = array(), $post = null, & $views = null ) {
41 41
 
42
-		if( empty( $post->panels_data ) || empty( $post->panels_data['widgets'] ) ) {
42
+		if ( empty( $post->panels_data ) || empty( $post->panels_data[ 'widgets' ] ) ) {
43 43
 			return $meta_keys;
44 44
 		}
45 45
 
46
-		foreach ( (array) $post->panels_data['widgets'] as $widget ) {
46
+		foreach ( (array)$post->panels_data[ 'widgets' ] as $widget ) {
47 47
 
48 48
 			$views->merge( \GV\View_Collection::from_content( \GV\Utils::get( $widget, 'text' ) ) );
49 49
 
50
-			if ( empty( $widget['tabs'] ) || ! is_array( $widget['tabs'] ) ) {
50
+			if ( empty( $widget[ 'tabs' ] ) || ! is_array( $widget[ 'tabs' ] ) ) {
51 51
 				continue;
52 52
 			}
53 53
 
54
-			foreach ( $widget['tabs'] as $tab ) {
54
+			foreach ( $widget[ 'tabs' ] as $tab ) {
55 55
 
56 56
 				// Livemesh Tabs
57 57
 				$backup = \GV\Utils::get( $tab, 'tab_content' );
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 				// SiteOrigin Tabs
60 60
 				$content = \GV\Utils::get( $tab, 'content_text', $backup );
61 61
 
62
-				if( $content ) {
62
+				if ( $content ) {
63 63
 					$views->merge( \GV\View_Collection::from_content( $content ) );
64 64
 				}
65 65
 			}
Please login to merge, or discard this patch.
includes/plugin-and-theme-hooks/class-gravityview-plugin-hooks-acf.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
 		$acf_keys = get_field_objects( $post->ID, array( 'load_value' => false ) );
57 57
 
58
-		if( $acf_keys ) {
58
+		if ( $acf_keys ) {
59 59
 			return array_merge( array_keys( $acf_keys ), $meta_keys );
60 60
 		}
61 61
 
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
 	 * @return void
71 71
 	 */
72 72
 	private function fix_posted_fields() {
73
-		if( is_admin() && isset( $_POST['action'] ) && isset( $_POST['post_type'] ) ) {
74
-			if( 'editpost' === $_POST['action'] && 'gravityview' === $_POST['post_type'] ) {
75
-				$_POST['fields'] = _gravityview_process_posted_fields();
73
+		if ( is_admin() && isset( $_POST[ 'action' ] ) && isset( $_POST[ 'post_type' ] ) ) {
74
+			if ( 'editpost' === $_POST[ 'action' ] && 'gravityview' === $_POST[ 'post_type' ] ) {
75
+				$_POST[ 'fields' ] = _gravityview_process_posted_fields();
76 76
 			}
77 77
 		}
78 78
 	}
Please login to merge, or discard this patch.
future/includes/class-gv-source-internal.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,9 +24,8 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * Get a \GV\Field by Field ID for this data source.
26 26
 	 *
27
-	 * @param int $field_id The internal field ID (custom content, etc.)
28 27
 	 *
29
-	 * @return \GV\Field|null The requested field or null if not found.
28
+	 * @return null|Internal_Field The requested field or null if not found.
30 29
 	 */
31 30
 	public static function get_field( /** varargs */ ) {
32 31
 		$args = func_get_args();
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gventry.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -44,16 +44,16 @@  discard block
 block discarded – undo
44 44
 		 */
45 45
 		$atts = apply_filters( 'gravityview/shortcodes/gventry/atts', $atts );
46 46
 
47
-		$view = \GV\View::by_id( $atts['view_id'] );
47
+		$view = \GV\View::by_id( $atts[ 'view_id' ] );
48 48
 
49 49
 		if ( ! $view ) {
50
-			gravityview()->log->error( 'View does not exist #{view_id}', array( 'view_id' => $atts['view_id'] ) );
50
+			gravityview()->log->error( 'View does not exist #{view_id}', array( 'view_id' => $atts[ 'view_id' ] ) );
51 51
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', null, null, $atts );
52 52
 		}
53 53
 
54
-		$entry_id = ! empty( $atts['entry_id'] ) ? $atts['entry_id'] : $atts['id'];
54
+		$entry_id = ! empty( $atts[ 'entry_id' ] ) ? $atts[ 'entry_id' ] : $atts[ 'id' ];
55 55
 
56
-		switch( $entry_id ):
56
+		switch ( $entry_id ):
57 57
 			case 'last':
58 58
 				if ( class_exists( '\GF_Query' ) ) {
59 59
 					/**
@@ -62,17 +62,17 @@  discard block
 block discarded – undo
62 62
 					 * Since we're using \GF_Query shorthand initialization we have to reverse the order parameters here.
63 63
 					 */
64 64
 					add_filter( 'gravityview_get_entries', $filter = function( $parameters, $args, $form_id ) {
65
-						if ( ! empty( $parameters['sorting'] ) ) {
65
+						if ( ! empty( $parameters[ 'sorting' ] ) ) {
66 66
 							/**
67 67
 							 * Reverse existing sorts.
68 68
 							 */
69
-							$sort = &$parameters['sorting'];
70
-							$sort['direction'] = $sort['direction'] == 'RAND' ? : ( $sort['direction'] == 'ASC' ? 'DESC' : 'ASC' );
69
+							$sort = &$parameters[ 'sorting' ];
70
+							$sort[ 'direction' ] = $sort[ 'direction' ] == 'RAND' ?: ( $sort[ 'direction' ] == 'ASC' ? 'DESC' : 'ASC' );
71 71
 						} else {
72 72
 							/**
73 73
 							 * Otherwise, sort by date_created.
74 74
 							 */
75
-							$parameters['sorting'] = array(
75
+							$parameters[ 'sorting' ] = array(
76 76
 								'key' => 'id',
77 77
 								'direction' => 'ASC',
78 78
 								'is_numeric' => true
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
 					/** If a sort already exists, reverse it. */
89 89
 					if ( $sort = end( $entries->sorts ) ) {
90
-						$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ? : ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
90
+						$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ?: ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
91 91
 					} else {
92 92
 						/** Otherwise, sort by date_created */
93 93
 						$entries = $entries->sort( new \GV\Entry_Sort( \GV\Internal_Field::by_id( 'id' ), \GV\Entry_Sort::ASC ), \GV\Entry_Sort::NUMERIC );
@@ -105,12 +105,12 @@  discard block
 block discarded – undo
105 105
 				break;
106 106
 			default:
107 107
 				if ( ! $entry = \GV\GF_Entry::by_id( $entry_id ) ) {
108
-					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts['view_id'] ) );
108
+					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) );
109 109
 					return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, null, $atts );
110 110
 				}
111 111
 		endswitch;
112 112
 
113
-		if ( $view->form->ID != $entry['form_id'] ) {
113
+		if ( $view->form->ID != $entry[ 'form_id' ] ) {
114 114
 			gravityview()->log->error( 'Entry does not belong to view (form mismatch)' );
115 115
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
116 116
 		}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 			return apply_filters( 'gravityview/shortcodes/gventry/output', get_the_password_form( $view->ID ), $view, $entry, $atts );
121 121
 		}
122 122
 
123
-		if ( ! $view->form  ) {
123
+		if ( ! $view->form ) {
124 124
 			gravityview()->log->notice( 'View #{id} has no form attached to it.', array( 'id' => $view->ID ) );
125 125
 
126 126
 			/**
@@ -143,15 +143,15 @@  discard block
 block discarded – undo
143 143
 		}
144 144
 
145 145
 		/** Unapproved entries. */
146
-		if ( $entry['status'] != 'active' ) {
146
+		if ( $entry[ 'status' ] != 'active' ) {
147 147
 			gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
148 148
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
149 149
 		}
150 150
 
151
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
151
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
152 152
 
153 153
 		if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
154
-			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
154
+			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
155 155
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
156 156
 				return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
157 157
 			}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 		$renderer = new \GV\Entry_Renderer();
164 164
 
165 165
 		$request = new \GV\Mock_Request();
166
-		$request->returns['is_entry'] = $entry;
166
+		$request->returns[ 'is_entry' ] = $entry;
167 167
 
168 168
 		$output = $renderer->render( $entry, $view, $request );
169 169
 
Please login to merge, or discard this patch.
future/includes/class-gv-field-internal.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,12 +29,12 @@
 block discarded – undo
29 29
 	 */
30 30
 	public static function from_configuration( $configuration ) {
31 31
 
32
-		if ( empty( $configuration['id'] ) || ! is_string( $configuration['id'] ) ) {
32
+		if ( empty( $configuration[ 'id' ] ) || ! is_string( $configuration[ 'id' ] ) ) {
33 33
 			gravityview()->log->error( 'Invalid configuration[id] supplied.' );
34 34
 			return null;
35 35
 		}
36 36
 
37
-		$field = self::by_id( $configuration['id'] );
37
+		$field = self::by_id( $configuration[ 'id' ] );
38 38
 
39 39
 		$field->update_configuration( $configuration );
40 40
 
Please login to merge, or discard this patch.
future/includes/class-gv-field.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	 * @return \GV\Field The field implementation from configuration (\GV\GF_Field, \GV\Internal_Field).
167 167
 	 */
168 168
 	public static function from_configuration( $configuration ) {
169
-		if ( empty( $configuration['id'] ) ) {
169
+		if ( empty( $configuration[ 'id' ] ) ) {
170 170
 			$field = new self();
171 171
 			gravityview()->log->error( 'Trying to get field from configuration without a field ID.', array( 'data' => $configuration ) );
172 172
 			$field->update_configuration( $configuration );
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 		} else {
180 180
 			$trace = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS );
181 181
 		}
182
-		$trace = $trace[1];
183
-		if ( $trace['function'] == 'from_configuration' && $trace['class'] == __CLASS__ ) {
182
+		$trace = $trace[ 1 ];
183
+		if ( $trace[ 'function' ] == 'from_configuration' && $trace[ 'class' ] == __CLASS__ ) {
184 184
 			$field = new self();
185 185
 			gravityview()->log->error( 'Infinite loop protection tripped. Returning default class here.' );
186 186
 			$field->update_configuration( $configuration );
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 		}
189 189
 
190 190
 		/** Determine the field implementation to use, and try to use. */
191
-		$field_class = is_numeric( $configuration['id'] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
191
+		$field_class = is_numeric( $configuration[ 'id' ] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
192 192
 
193 193
 		/**
194 194
 		 * @filter `gravityview/field/class` Filter the field class about to be created from the configuration.
@@ -227,24 +227,24 @@  discard block
 block discarded – undo
227 227
 	public function update_configuration( $configuration ) {
228 228
 		$configuration = wp_parse_args( $configuration, $this->as_configuration() );
229 229
 
230
-		if ( $this->ID != $configuration['id'] ) {
230
+		if ( $this->ID != $configuration[ 'id' ] ) {
231 231
 			/** Smelling trouble here... */
232 232
 			gravityview()->log->warning( 'ID is being changed for {field_class} instance, but implementation is not. Use ::from_configuration instead', array( 'field_class', __CLASS__ ) );
233 233
 		}
234 234
 
235
-		$this->ID = $configuration['id'];
236
-		$this->label = $configuration['label'];
237
-		$this->show_label = $configuration['show_label'] == '1';
238
-		$this->custom_label = $configuration['custom_label'];
239
-		$this->custom_class = $configuration['custom_class'];
240
-		$this->cap = $configuration['only_loggedin'] == '1' ? $configuration['only_loggedin_cap'] : '';
241
-		$this->search_filter = $configuration['search_filter'] == '1';
242
-		$this->show_as_link = $configuration['show_as_link'] == '1';
235
+		$this->ID = $configuration[ 'id' ];
236
+		$this->label = $configuration[ 'label' ];
237
+		$this->show_label = $configuration[ 'show_label' ] == '1';
238
+		$this->custom_label = $configuration[ 'custom_label' ];
239
+		$this->custom_class = $configuration[ 'custom_class' ];
240
+		$this->cap = $configuration[ 'only_loggedin' ] == '1' ? $configuration[ 'only_loggedin_cap' ] : '';
241
+		$this->search_filter = $configuration[ 'search_filter' ] == '1';
242
+		$this->show_as_link = $configuration[ 'show_as_link' ] == '1';
243 243
 
244 244
 		/** Shared among all field types (sort of). */
245 245
 		$shared_configuration_keys = array(
246 246
 			'id', 'label', 'show_label', 'custom_label', 'custom_class',
247
-			'only_loggedin' ,'only_loggedin_cap', 'search_filter', 'show_as_link',
247
+			'only_loggedin', 'only_loggedin_cap', 'search_filter', 'show_as_link',
248 248
 		);
249 249
 
250 250
 		/** Everything else goes into the properties for now. @todo subclasses! */
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 
274 274
 		/** A custom label is available. */
275 275
 		if ( ! empty( $this->custom_label ) ) {
276
-			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ? : null : null, $entry ? $entry->as_entry() : null );
276
+			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ?: null : null, $entry ? $entry->as_entry() : null );
277 277
 		}
278 278
 
279 279
 		return '';
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * @return mixed|null The value for the given configuration key, null if doesn't exist.
351 351
 	 */
352 352
 	public function __get( $key ) {
353
-		switch( $key ):
353
+		switch ( $key ):
354 354
 			default:
355 355
 				if ( isset( $this->configuration[ $key ] ) ) {
356 356
 					return $this->configuration[ $key ];
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
 	 * @return boolean Whether this $key is set or not.
367 367
 	 */
368 368
 	public function __isset( $key ) {
369
-		switch( $key ):
369
+		switch ( $key ):
370 370
 			default:
371 371
 				return isset( $this->configuration[ $key ] );
372 372
 		endswitch;
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-list.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@  discard block
 block discarded – undo
53 53
 	 * Columns are able to be added to View layouts, but not separately searched!
54 54
 	 *
55 55
 	 * @param array $fields
56
-	 * @param int $form_id
57 56
 	 *
58 57
 	 * @return array
59 58
 	 */
@@ -133,7 +132,7 @@  discard block
 block discarded – undo
133 132
 	 *
134 133
 	 * @param GF_Field_List $field Gravity Forms field
135 134
 	 * @param string|array $field_value Serialized or unserialized array value for the field
136
-	 * @param int|string $column_id The numeric key of the column (0-index) or the label of the column
135
+	 * @param integer $column_id The numeric key of the column (0-index) or the label of the column
137 136
 	 * @param string $format If set to 'raw', return an array of values for the column. Otherwise, allow Gravity Forms to render using `html` or `text`
138 137
 	 *
139 138
 	 * @return array|string|null Returns null if the $field_value passed wasn't an array or serialized array
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	public function remove_columns_from_searchable_fields( $fields ) {
61 61
 
62 62
 		foreach ( $fields as $key => $field ) {
63
-			if ( isset( $field['parent'] ) && $field['parent'] instanceof \GF_Field_List ) {
63
+			if ( isset( $field[ 'parent' ] ) && $field[ 'parent' ] instanceof \GF_Field_List ) {
64 64
 				unset( $fields[ $key ] );
65 65
 			}
66 66
 		}
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 		// Add the list columns
87 87
 		foreach ( $list_fields as $list_field ) {
88 88
 
89
-			if( empty( $list_field->enableColumns ) ) {
89
+			if ( empty( $list_field->enableColumns ) ) {
90 90
 				continue;
91 91
 			}
92 92
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 			}
108 108
 
109 109
 			// If there are columns, add them under the parent field
110
-			if( ! empty( $list_columns ) ) {
110
+			if ( ! empty( $list_columns ) ) {
111 111
 
112 112
 				$index = array_search( $list_field->id, array_keys( $fields ) ) + 1;
113 113
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 				 * Merge the $list_columns into the $fields array at $index
116 116
 				 * @see https://stackoverflow.com/a/1783125
117 117
 				 */
118
-				$fields = array_slice( $fields, 0, $index, true) + $list_columns + array_slice( $fields, $index, null, true);
118
+				$fields = array_slice( $fields, 0, $index, true ) + $list_columns + array_slice( $fields, $index, null, true );
119 119
 			}
120 120
 
121 121
 			unset( $list_columns, $index, $input_id );
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
 		$list_rows = maybe_unserialize( $field_value );
144 144
 
145
-		if( ! is_array( $list_rows ) ) {
145
+		if ( ! is_array( $list_rows ) ) {
146 146
 			gravityview()->log->error( '$field_value did not unserialize', array( 'data' => $field_value ) );
147 147
 			return null;
148 148
 		}
@@ -152,18 +152,18 @@  discard block
 block discarded – undo
152 152
 		// Each list row
153 153
 		foreach ( $list_rows as $list_row ) {
154 154
 			$current_column = 0;
155
-			foreach ( (array) $list_row as $column_key => $column_value ) {
155
+			foreach ( (array)$list_row as $column_key => $column_value ) {
156 156
 
157 157
 				// If the label of the column matches $column_id, or the numeric key value matches, add the value
158
-				if( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
-					$column_values[] = $column_value;
158
+				if ( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
+					$column_values[ ] = $column_value;
160 160
 				}
161 161
 				$current_column++;
162 162
 			}
163 163
 		}
164 164
 
165 165
 		// Return the array of values
166
-		if( 'raw' === $format ) {
166
+		if ( 'raw' === $format ) {
167 167
 			return $column_values;
168 168
 		}
169 169
 		// Return the Gravity Forms Field output
@@ -186,22 +186,22 @@  discard block
 block discarded – undo
186 186
 	 */
187 187
 	public function _filter_field_label( $label, $field, $form, $entry ) {
188 188
 
189
-		$field_object = RGFormsModel::get_field( $form, $field['id'] );
189
+		$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
190 190
 
191 191
 		// Not a list field
192
-		if( ! $field_object || 'list' !== $field_object->type ) {
192
+		if ( ! $field_object || 'list' !== $field_object->type ) {
193 193
 			return $label;
194 194
 		}
195 195
 
196 196
 		// Custom label is defined, so use it
197
-		if( ! empty( $field['custom_label'] ) ) {
197
+		if ( ! empty( $field[ 'custom_label' ] ) ) {
198 198
 			return $label;
199 199
 		}
200 200
 
201
-		$column_id = gravityview_get_input_id_from_id( $field['id'] );
201
+		$column_id = gravityview_get_input_id_from_id( $field[ 'id' ] );
202 202
 
203 203
 		// Parent field, not column field
204
-		if( false === $column_id ) {
204
+		if ( false === $column_id ) {
205 205
 			return $label;
206 206
 		}
207 207
 
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	public static function get_column_label( GF_Field_List $field, $column_id, $backup_label = '' ) {
223 223
 
224 224
 		// Doesn't have columns enabled
225
-		if( ! isset( $field->choices ) || ! $field->enableColumns ) {
225
+		if ( ! isset( $field->choices ) || ! $field->enableColumns ) {
226 226
 			return $backup_label;
227 227
 		}
228 228
 
Please login to merge, or discard this patch.
includes/widgets/search-widget/class-search-widget.php 3 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -603,7 +603,8 @@  discard block
 block discarded – undo
603 603
 				// Fast-forward 24 hour on the end time
604 604
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
605 605
 				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
606
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
606
+				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) {
607
+// See https://github.com/gravityview/GravityView/issues/1056
607 608
 					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
608 609
 				}
609 610
 			}
@@ -874,7 +875,7 @@  discard block
 block discarded – undo
874 875
 			'ymd_dot' => 'Y.m.d',
875 876
 		);
876 877
 
877
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
878
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
878 879
 			$format = $datepicker[ $field->dateFormat ];
879 880
 		}
880 881
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 	/**
244 244
 	 * Add admin script to the no-conflict scripts whitelist
245 245
 	 * @param array $allowed Scripts allowed in no-conflict mode
246
-	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
246
+	 * @return string[] Scripts allowed in no-conflict mode, plus the search widget script
247 247
 	 */
248 248
 	public function register_no_conflict( $allowed ) {
249 249
 		$allowed[] = 'gravityview_searchwidget_admin';
@@ -709,7 +709,6 @@  discard block
 block discarded – undo
709 709
 	 * Dropin for the legacy flat filters when \GF_Query is available.
710 710
 	 *
711 711
 	 * @param \GF_Query $query The current query object reference
712
-	 * @param \GV\View $this The current view object
713 712
 	 * @param \GV\Request $request The request object
714 713
 	 */
715 714
 	public function gf_query_filter( &$query, $view, $request ) {
@@ -1199,7 +1198,7 @@  discard block
 block discarded – undo
1199 1198
 	/**
1200 1199
 	 * Get the label for a search form field
1201 1200
 	 * @param  array $field      Field setting as sent by the GV configuration - has `field`, `input` (input type), and `label` keys
1202
-	 * @param  array $form_field Form field data, as fetched by `gravityview_get_field()`
1201
+	 * @param  GF_Field|null $form_field Form field data, as fetched by `gravityview_get_field()`
1203 1202
 	 * @return string             Label for the search form
1204 1203
 	 */
1205 1204
 	private static function get_field_label( $field, $form_field = array() ) {
@@ -1364,7 +1363,7 @@  discard block
 block discarded – undo
1364 1363
 	/**
1365 1364
 	 * Require the datepicker script for the frontend GV script
1366 1365
 	 * @param array $js_dependencies Array of existing required scripts for the fe-views.js script
1367
-	 * @return array Array required scripts, with `jquery-ui-datepicker` added
1366
+	 * @return string[] Array required scripts, with `jquery-ui-datepicker` added
1368 1367
 	 */
1369 1368
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1370 1369
 
@@ -1376,7 +1375,7 @@  discard block
 block discarded – undo
1376 1375
 	/**
1377 1376
 	 * Modify the array passed to wp_localize_script()
1378 1377
 	 *
1379
-	 * @param array $js_localization The data padded to the Javascript file
1378
+	 * @param array $localizations The data padded to the Javascript file
1380 1379
 	 * @param array $view_data View data array with View settings
1381 1380
 	 *
1382 1381
 	 * @return array
Please login to merge, or discard this patch.
Spacing   +142 added lines, -142 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 				'type' => 'radio',
65 65
 				'full_width' => true,
66 66
 				'label' => esc_html__( 'Search Mode', 'gravityview' ),
67
-				'desc' => __('Should search results match all search fields, or any?', 'gravityview'),
67
+				'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),
68 68
 				'value' => 'any',
69 69
 				'class' => 'hide-if-js',
70 70
 				'options' => array(
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
 			// admin - add scripts - run at 1100 to make sure GravityView_Admin_Views::add_scripts_and_styles() runs first at 999
88 88
 			add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 1100 );
89
-			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts') );
89
+			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts' ) );
90 90
 			add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
91 91
 
92 92
 			// ajax - get the searchable fields
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 		$script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
228 228
 		$script_source = empty( $script_min ) ? '/source' : '';
229 229
 
230
-		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
230
+		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
231 231
 
232 232
 		wp_localize_script( 'gravityview_searchwidget_admin', 'gvSearchVar', array(
233 233
 			'nonce' => wp_create_nonce( 'gravityview_ajaxsearchwidget' ),
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
250 250
 	 */
251 251
 	public function register_no_conflict( $allowed ) {
252
-		$allowed[] = 'gravityview_searchwidget_admin';
252
+		$allowed[ ] = 'gravityview_searchwidget_admin';
253 253
 		return $allowed;
254 254
 	}
255 255
 
@@ -262,24 +262,24 @@  discard block
 block discarded – undo
262 262
 	 */
263 263
 	public static function get_searchable_fields() {
264 264
 
265
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) {
265
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) {
266 266
 			exit( '0' );
267 267
 		}
268 268
 
269 269
 		$form = '';
270 270
 
271 271
 		// Fetch the form for the current View
272
-		if ( ! empty( $_POST['view_id'] ) ) {
272
+		if ( ! empty( $_POST[ 'view_id' ] ) ) {
273 273
 
274
-			$form = gravityview_get_form_id( $_POST['view_id'] );
274
+			$form = gravityview_get_form_id( $_POST[ 'view_id' ] );
275 275
 
276
-		} elseif ( ! empty( $_POST['formid'] ) ) {
276
+		} elseif ( ! empty( $_POST[ 'formid' ] ) ) {
277 277
 
278
-			$form = (int) $_POST['formid'];
278
+			$form = (int)$_POST[ 'formid' ];
279 279
 
280
-		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) {
280
+		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) {
281 281
 
282
-			$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
282
+			$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
283 283
 
284 284
 		}
285 285
 
@@ -329,14 +329,14 @@  discard block
 block discarded – undo
329 329
 		);
330 330
 
331 331
 		if ( gravityview()->plugin->supports( \GV\Plugin::FEATURE_GFQUERY ) ) {
332
-			$custom_fields['is_approved'] = array(
332
+			$custom_fields[ 'is_approved' ] = array(
333 333
 				'text' => esc_html__( 'Is Approved', 'gravityview' ),
334 334
 				'type' => 'boolean',
335 335
 			);
336 336
 		}
337 337
 
338
-		foreach( $custom_fields as $custom_field_key => $custom_field ) {
339
-			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] );
338
+		foreach ( $custom_fields as $custom_field_key => $custom_field ) {
339
+			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );
340 340
 		}
341 341
 
342 342
 		// Get fields with sub-inputs and no parent
@@ -358,13 +358,13 @@  discard block
 block discarded – undo
358 358
 
359 359
 			foreach ( $fields as $id => $field ) {
360 360
 
361
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
361
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
362 362
 					continue;
363 363
 				}
364 364
 
365
-				$types = self::get_search_input_types( $id, $field['type'] );
365
+				$types = self::get_search_input_types( $id, $field[ 'type' ] );
366 366
 
367
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';
367
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';
368 368
 			}
369 369
 		}
370 370
 
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 	public static function get_search_input_types( $field_id = '', $field_type = null ) {
388 388
 
389 389
 		// @todo - This needs to be improved - many fields have . including products and addresses
390
-		if ( false !== strpos( (string) $field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
390
+		if ( false !== strpos( (string)$field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
391 391
 			$input_type = 'boolean'; // on/off checkbox
392 392
 		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) {
393 393
 			$input_type = 'multi'; //multiselect
@@ -431,19 +431,19 @@  discard block
 block discarded – undo
431 431
 			$post_id = 0;
432 432
 
433 433
 			// We're in the WordPress Widget context, and an overriding post ID has been set.
434
-			if ( ! empty( $widget_args['post_id'] ) ) {
435
-				$post_id = absint( $widget_args['post_id'] );
434
+			if ( ! empty( $widget_args[ 'post_id' ] ) ) {
435
+				$post_id = absint( $widget_args[ 'post_id' ] );
436 436
 			}
437 437
 			// We're in the WordPress Widget context, and the base View ID should be used
438
-			else if ( ! empty( $widget_args['view_id'] ) ) {
439
-				$post_id = absint( $widget_args['view_id'] );
438
+			else if ( ! empty( $widget_args[ 'view_id' ] ) ) {
439
+				$post_id = absint( $widget_args[ 'view_id' ] );
440 440
 			}
441 441
 
442 442
 			$args = gravityview_get_permalink_query_args( $post_id );
443 443
 
444 444
 			// Add hidden fields to the search form
445 445
 			foreach ( $args as $key => $value ) {
446
-				$search_fields[] = array(
446
+				$search_fields[ ] = array(
447 447
 					'name'  => $key,
448 448
 					'input' => 'hidden',
449 449
 					'value' => $value,
@@ -482,22 +482,22 @@  discard block
 block discarded – undo
482 482
 		/**
483 483
 		 * Include the sidebar Widgets.
484 484
 		 */
485
-		$widgets = (array) get_option( 'widget_gravityview_search', array() );
485
+		$widgets = (array)get_option( 'widget_gravityview_search', array() );
486 486
 
487 487
 		foreach ( $widgets as $widget ) {
488
-			if ( ! empty( $widget['view_id'] ) && $widget['view_id'] == $view->ID ) {
489
-				if( $_fields = json_decode( $widget['search_fields'], true ) ) {
488
+			if ( ! empty( $widget[ 'view_id' ] ) && $widget[ 'view_id' ] == $view->ID ) {
489
+				if ( $_fields = json_decode( $widget[ 'search_fields' ], true ) ) {
490 490
 					foreach ( $_fields as $field ) {
491
-						$searchable_fields [] = $with_full_field ? $field : $field['field'];
491
+						$searchable_fields [ ] = $with_full_field ? $field : $field[ 'field' ];
492 492
 					}
493 493
 				}
494 494
 			}
495 495
 		}
496 496
 
497 497
 		foreach ( $view->widgets->by_id( $this->get_widget_id() )->all() as $widget ) {
498
-			if( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
498
+			if ( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
499 499
 				foreach ( $_fields as $field ) {
500
-					$searchable_fields [] = $with_full_field ? $field : $field['field'];
500
+					$searchable_fields [ ] = $with_full_field ? $field : $field[ 'field' ];
501 501
 				}
502 502
 			}
503 503
 		}
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
 			return $search_criteria; // Return the original criteria, GF_Query modification kicks in later
528 528
 		}
529 529
 
530
-		if( 'post' === $this->search_method ) {
530
+		if ( 'post' === $this->search_method ) {
531 531
 			$get = $_POST;
532 532
 		} else {
533 533
 			$get = $_GET;
@@ -546,14 +546,14 @@  discard block
 block discarded – undo
546 546
 		$get = gv_map_deep( $get, 'rawurldecode' );
547 547
 
548 548
 		// Make sure array key is set up
549
-		$search_criteria['field_filters'] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
549
+		$search_criteria[ 'field_filters' ] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
550 550
 
551 551
 		$searchable_fields = $this->get_view_searchable_fields( $view );
552 552
 
553 553
 		// add free search
554
-		if ( isset( $get['gv_search'] ) && '' !== $get['gv_search'] && in_array( 'search_all', $searchable_fields ) ) {
554
+		if ( isset( $get[ 'gv_search' ] ) && '' !== $get[ 'gv_search' ] && in_array( 'search_all', $searchable_fields ) ) {
555 555
 
556
-			$search_all_value = trim( $get['gv_search'] );
556
+			$search_all_value = trim( $get[ 'gv_search' ] );
557 557
 
558 558
 			/**
559 559
 			 * @filter `gravityview/search-all-split-words` Search for each word separately or the whole phrase?
@@ -578,7 +578,7 @@  discard block
 block discarded – undo
578 578
 			}
579 579
 
580 580
 			foreach ( $words as $word ) {
581
-				$search_criteria['field_filters'][] = array(
581
+				$search_criteria[ 'field_filters' ][ ] = array(
582 582
 					'key' => null, // The field ID to search
583 583
 					'value' => $word, // The value to search
584 584
 					'operator' => 'contains', // What to search in. Options: `is` or `contains`
@@ -591,14 +591,14 @@  discard block
 block discarded – undo
591 591
 			/**
592 592
 			 * Get and normalize the dates according to the input format.
593 593
 			 */
594
-			if ( $curr_start = ! empty( $get['gv_start'] ) ? $get['gv_start'] : '' ) {
595
-				if( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
594
+			if ( $curr_start = ! empty( $get[ 'gv_start' ] ) ? $get[ 'gv_start' ] : '' ) {
595
+				if ( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
596 596
 					$curr_start = $curr_start_date->format( 'Y-m-d' );
597 597
 				}
598 598
 			}
599 599
 
600
-			if ( $curr_end = ! empty( $get['gv_start'] ) ? ( ! empty( $get['gv_end'] ) ? $get['gv_end'] : '' ) : '' ) {
601
-				if( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
600
+			if ( $curr_end = ! empty( $get[ 'gv_start' ] ) ? ( ! empty( $get[ 'gv_end' ] ) ? $get[ 'gv_end' ] : '' ) : '' ) {
601
+				if ( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
602 602
 					$curr_end = $curr_end_date->format( 'Y-m-d' );
603 603
 				}
604 604
 			}
@@ -633,22 +633,22 @@  discard block
 block discarded – undo
633 633
 			 */
634 634
 			if ( ! empty( $curr_start ) ) {
635 635
 				$curr_start = date( 'Y-m-d H:i:s', strtotime( $curr_start ) );
636
-				$search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
636
+				$search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
637 637
 			}
638 638
 
639 639
 			if ( ! empty( $curr_end ) ) {
640 640
 				// Fast-forward 24 hour on the end time
641 641
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
642
-				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
643
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
644
-					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
642
+				$search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
643
+				if ( strpos( $search_criteria[ 'end_date' ], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
644
+					$search_criteria[ 'end_date' ] = date( 'Y-m-d H:i:s', strtotime( $search_criteria[ 'end_date' ] ) - 1 );
645 645
 				}
646 646
 			}
647 647
 		}
648 648
 
649 649
 		// search for a specific entry ID
650 650
 		if ( ! empty( $get[ 'gv_id' ] ) && in_array( 'entry_id', $searchable_fields ) ) {
651
-			$search_criteria['field_filters'][] = array(
651
+			$search_criteria[ 'field_filters' ][ ] = array(
652 652
 				'key' => 'id',
653 653
 				'value' => absint( $get[ 'gv_id' ] ),
654 654
 				'operator' => '=',
@@ -657,41 +657,41 @@  discard block
 block discarded – undo
657 657
 
658 658
 		// search for a specific Created_by ID
659 659
 		if ( ! empty( $get[ 'gv_by' ] ) && in_array( 'created_by', $searchable_fields ) ) {
660
-			$search_criteria['field_filters'][] = array(
660
+			$search_criteria[ 'field_filters' ][ ] = array(
661 661
 				'key' => 'created_by',
662
-				'value' => $get['gv_by'],
662
+				'value' => $get[ 'gv_by' ],
663 663
 				'operator' => '=',
664 664
 			);
665 665
 		}
666 666
 
667 667
 		// Get search mode passed in URL
668
-		$mode = isset( $get['mode'] ) && in_array( $get['mode'], array( 'any', 'all' ) ) ?  $get['mode'] : 'any';
668
+		$mode = isset( $get[ 'mode' ] ) && in_array( $get[ 'mode' ], array( 'any', 'all' ) ) ? $get[ 'mode' ] : 'any';
669 669
 
670 670
 		// get the other search filters
671 671
 		foreach ( $get as $key => $value ) {
672 672
 
673
-			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[0], false, false ) ) ) {
673
+			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[ 0 ], false, false ) ) ) {
674 674
 				continue;
675 675
 			}
676 676
 
677 677
 			$filter_key = $this->convert_request_key_to_filter_key( $key );
678 678
 
679 679
 			// could return simple filter or multiple filters
680
-			if ( ! in_array( 'search_all', $searchable_fields ) && ! in_array( $filter_key , $searchable_fields ) ) {
680
+			if ( ! in_array( 'search_all', $searchable_fields ) && ! in_array( $filter_key, $searchable_fields ) ) {
681 681
 				continue;
682 682
 			}
683 683
 
684 684
 			$filter = $this->prepare_field_filter( $filter_key, $value, $view );
685 685
 
686
-			if ( isset( $filter[0]['value'] ) ) {
687
-				$search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );
686
+			if ( isset( $filter[ 0 ][ 'value' ] ) ) {
687
+				$search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );
688 688
 
689 689
 				// if date range type, set search mode to ALL
690
-				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>=', '<=', '>', '<' ) ) ) {
690
+				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>=', '<=', '>', '<' ) ) ) {
691 691
 					$mode = 'all';
692 692
 				}
693
-			} elseif( !empty( $filter ) ) {
694
-				$search_criteria['field_filters'][] = $filter;
693
+			} elseif ( ! empty( $filter ) ) {
694
+				$search_criteria[ 'field_filters' ][ ] = $filter;
695 695
 			}
696 696
 		}
697 697
 
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
 		 * @since 1.5.1
701 701
 		 * @param[out,in] string $mode Search mode (`any` vs `all`)
702 702
 		 */
703
-		$search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );
703
+		$search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );
704 704
 
705 705
 		gravityview()->log->debug( 'Returned Search Criteria: ', array( 'data' => $search_criteria ) );
706 706
 
@@ -725,16 +725,16 @@  discard block
 block discarded – undo
725 725
 		 */
726 726
 		$search_criteria = $this->filter_entries( array(), null, array( 'id' => $view->ID ), true /** force search_criteria */ );
727 727
 
728
-		if ( empty( $search_criteria['field_filters'] ) ) {
728
+		if ( empty( $search_criteria[ 'field_filters' ] ) ) {
729 729
 			return;
730 730
 		}
731 731
 
732 732
 		$widgets = $view->widgets->by_id( $this->widget_id );
733 733
 		if ( $widgets->count() ) {
734 734
 			$widgets = $widgets->all();
735
-			$widget  = $widgets[0];
735
+			$widget  = $widgets[ 0 ];
736 736
 			foreach ( $search_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) as $search_field ) {
737
-				if ( 'created_by' === $search_field['field'] && 'input_text' === $search_field['input'] ) {
737
+				if ( 'created_by' === $search_field[ 'field' ] && 'input_text' === $search_field[ 'input' ] ) {
738 738
 					$created_by_text_mode = true;
739 739
 				}
740 740
 			}
@@ -742,19 +742,19 @@  discard block
 block discarded – undo
742 742
 
743 743
 		$extra_conditions = array();
744 744
 
745
-		foreach ( $search_criteria['field_filters'] as &$filter ) {
745
+		foreach ( $search_criteria[ 'field_filters' ] as &$filter ) {
746 746
 			if ( ! is_array( $filter ) ) {
747 747
 				continue;
748 748
 			}
749 749
 
750 750
 			// Construct a manual query for unapproved statuses
751
-			if ( 'is_approved' === $filter['key'] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, $filter['value'] ) ) {
752
-				$_tmp_query       = new GF_Query( $view->form->ID, array(
751
+			if ( 'is_approved' === $filter[ 'key' ] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, $filter[ 'value' ] ) ) {
752
+				$_tmp_query = new GF_Query( $view->form->ID, array(
753 753
 					'field_filters' => array(
754 754
 						array(
755 755
 							'operator' => 'in',
756 756
 							'key'      => 'is_approved',
757
-							'value'    => $filter['value'],
757
+							'value'    => $filter[ 'value' ],
758 758
 						),
759 759
 						array(
760 760
 							'operator' => 'is',
@@ -766,25 +766,25 @@  discard block
 block discarded – undo
766 766
 				) );
767 767
 				$_tmp_query_parts = $_tmp_query->_introspect();
768 768
 
769
-				$extra_conditions[] = $_tmp_query_parts['where'];
769
+				$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
770 770
 
771 771
 				$filter = false;
772 772
 				continue;
773 773
 			}
774 774
 
775 775
 			// Construct manual query for text mode creator search
776
-			if ( 'created_by' === $filter['key'] && ! empty( $created_by_text_mode ) ) {
777
-				$extra_conditions[] = new GravityView_Widget_Search_GF_Query_Condition( $filter, $view );
776
+			if ( 'created_by' === $filter[ 'key' ] && ! empty( $created_by_text_mode ) ) {
777
+				$extra_conditions[ ] = new GravityView_Widget_Search_GF_Query_Condition( $filter, $view );
778 778
 				$filter = false;
779 779
 				continue;
780 780
 			}
781 781
 
782 782
 			// By default, we want searches to be wildcard for each field.
783
-			$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
783
+			$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
784 784
 
785 785
 			// For multichoice, let's have an in (OR) search.
786
-			if ( is_array( $filter['value'] ) ) {
787
-				$filter['operator'] = 'in'; // @todo what about in contains (OR LIKE chains)?
786
+			if ( is_array( $filter[ 'value' ] ) ) {
787
+				$filter[ 'operator' ] = 'in'; // @todo what about in contains (OR LIKE chains)?
788 788
 			}
789 789
 
790 790
 			/**
@@ -792,10 +792,10 @@  discard block
 block discarded – undo
792 792
 			 * @param string $operator Existing search operator
793 793
 			 * @param array $filter array with `key`, `value`, `operator`, `type` keys
794 794
 			 */
795
-			$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
795
+			$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
796 796
 		}
797 797
 
798
-		$search_criteria['field_filters'] = array_filter( $search_criteria['field_filters'] );
798
+		$search_criteria[ 'field_filters' ] = array_filter( $search_criteria[ 'field_filters' ] );
799 799
 
800 800
 		/**
801 801
 		 * Parse the filter criteria to generate the needed
@@ -808,12 +808,12 @@  discard block
 block discarded – undo
808 808
 		/**
809 809
 		 * Grab the current clauses. We'll be combining them shortly.
810 810
 		 */
811
-		$query_parts      = $query->_introspect();
811
+		$query_parts = $query->_introspect();
812 812
 
813 813
 		/**
814 814
 		 * Combine the parts as a new WHERE clause.
815 815
 		 */
816
-		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts['where'], $_tmp_query_parts['where'] ), $extra_conditions ) );
816
+		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts[ 'where' ], $_tmp_query_parts[ 'where' ] ), $extra_conditions ) );
817 817
 		$query->where( $where );
818 818
 	}
819 819
 
@@ -836,7 +836,7 @@  discard block
 block discarded – undo
836 836
 		$field_id = str_replace( 'filter_', '', $key );
837 837
 
838 838
 		// calculates field_id, removing 'filter_' and for '_' for advanced fields ( like name or checkbox )
839
-		if ( preg_match('/^[0-9_]+$/ism', $field_id ) ) {
839
+		if ( preg_match( '/^[0-9_]+$/ism', $field_id ) ) {
840 840
 			$field_id = str_replace( '_', '.', $field_id );
841 841
 		}
842 842
 
@@ -871,7 +871,7 @@  discard block
 block discarded – undo
871 871
 
872 872
 			case 'select':
873 873
 			case 'radio':
874
-				$filter['operator'] = 'is';
874
+				$filter[ 'operator' ] = 'is';
875 875
 				break;
876 876
 
877 877
 			case 'post_category':
@@ -885,7 +885,7 @@  discard block
 block discarded – undo
885 885
 
886 886
 				foreach ( $value as $val ) {
887 887
 					$cat = get_term( $val, 'category' );
888
-					$filter[] = array(
888
+					$filter[ ] = array(
889 889
 						'key'      => $filter_key,
890 890
 						'value'    => esc_attr( $cat->name ) . ':' . $val,
891 891
 						'operator' => 'is',
@@ -904,7 +904,7 @@  discard block
 block discarded – undo
904 904
 				$filter = array();
905 905
 
906 906
 				foreach ( $value as $val ) {
907
-					$filter[] = array( 'key' => $filter_key, 'value' => $val );
907
+					$filter[ ] = array( 'key' => $filter_key, 'value' => $val );
908 908
 				}
909 909
 
910 910
 				break;
@@ -913,9 +913,9 @@  discard block
 block discarded – undo
913 913
 				// convert checkbox on/off into the correct search filter
914 914
 				if ( false !== strpos( $filter_key, '.' ) && ! empty( $form_field->inputs ) && ! empty( $form_field->choices ) ) {
915 915
 					foreach ( $form_field->inputs as $k => $input ) {
916
-						if ( $input['id'] == $filter_key ) {
917
-							$filter['value'] = $form_field->choices[ $k ]['value'];
918
-							$filter['operator'] = 'is';
916
+						if ( $input[ 'id' ] == $filter_key ) {
917
+							$filter[ 'value' ] = $form_field->choices[ $k ][ 'value' ];
918
+							$filter[ 'operator' ] = 'is';
919 919
 							break;
920 920
 						}
921 921
 					}
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
925 925
 					$filter = array();
926 926
 
927 927
 					foreach ( $value as $val ) {
928
-						$filter[] = array(
928
+						$filter[ ] = array(
929 929
 							'key'      => $filter_key,
930 930
 							'value'    => $val,
931 931
 							'operator' => 'is',
@@ -946,9 +946,9 @@  discard block
 block discarded – undo
946 946
 					foreach ( $words as $word ) {
947 947
 						if ( ! empty( $word ) && strlen( $word ) > 1 ) {
948 948
 							// Keep the same key for each filter
949
-							$filter['value'] = $word;
949
+							$filter[ 'value' ] = $word;
950 950
 							// Add a search for the value
951
-							$filters[] = $filter;
951
+							$filters[ ] = $filter;
952 952
 						}
953 953
 					}
954 954
 
@@ -962,19 +962,19 @@  discard block
 block discarded – undo
962 962
 
963 963
 					foreach ( $searchable_fields as $searchable_field ) {
964 964
 
965
-						if( $form_field->ID !== $searchable_field['field'] ) {
965
+						if ( $form_field->ID !== $searchable_field[ 'field' ] ) {
966 966
 							continue;
967 967
 						}
968 968
 
969 969
 						// Only exact-match dropdowns, not text search
970
-						if( in_array( $searchable_field['input'], array( 'text', 'search' ), true ) ) {
970
+						if ( in_array( $searchable_field[ 'input' ], array( 'text', 'search' ), true ) ) {
971 971
 							continue;
972 972
 						}
973 973
 
974 974
 						$input_id = gravityview_get_input_id_from_id( $form_field->ID );
975 975
 
976 976
 						if ( 4 === $input_id ) {
977
-							$filter['operator'] = 'is';
977
+							$filter[ 'operator' ] = 'is';
978 978
 						};
979 979
 					}
980 980
 				}
@@ -1001,12 +1001,12 @@  discard block
 block discarded – undo
1001 1001
 						 * @since 1.16.3
1002 1002
 						 * Safeguard until GF implements '<=' operator
1003 1003
 						 */
1004
-						if( !GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1004
+						if ( ! GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1005 1005
 							$operator = '<';
1006 1006
 							$date = date( 'Y-m-d', strtotime( self::get_formatted_date( $date, 'Y-m-d', $date_format ) . ' +1 day' ) );
1007 1007
 						}
1008 1008
 
1009
-						$filter[] = array(
1009
+						$filter[ ] = array(
1010 1010
 							'key'      => $filter_key,
1011 1011
 							'value'    => self::get_formatted_date( $date, 'Y-m-d', $date_format ),
1012 1012
 							'operator' => $operator,
@@ -1014,7 +1014,7 @@  discard block
 block discarded – undo
1014 1014
 					}
1015 1015
 				} else {
1016 1016
 					$date = $value;
1017
-					$filter['value'] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1017
+					$filter[ 'value' ] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1018 1018
 				}
1019 1019
 
1020 1020
 				break;
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
 			'ymd_dot' => 'Y.m.d',
1046 1046
 		);
1047 1047
 
1048
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
1048
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
1049 1049
 			$format = $datepicker[ $field->dateFormat ];
1050 1050
 		}
1051 1051
 
@@ -1082,7 +1082,7 @@  discard block
 block discarded – undo
1082 1082
 	public function add_template_path( $file_paths ) {
1083 1083
 
1084 1084
 		// Index 100 is the default GravityView template path.
1085
-		$file_paths[102] = self::$file . 'templates/';
1085
+		$file_paths[ 102 ] = self::$file . 'templates/';
1086 1086
 
1087 1087
 		return $file_paths;
1088 1088
 	}
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
 		$has_date = false;
1102 1102
 
1103 1103
 		foreach ( $search_fields as $k => $field ) {
1104
-			if ( in_array( $field['input'], array( 'date', 'date_range', 'entry_date' ) ) ) {
1104
+			if ( in_array( $field[ 'input' ], array( 'date', 'date_range', 'entry_date' ) ) ) {
1105 1105
 				$has_date = true;
1106 1106
 				break;
1107 1107
 			}
@@ -1128,7 +1128,7 @@  discard block
 block discarded – undo
1128 1128
 		}
1129 1129
 
1130 1130
 		// get configured search fields
1131
-		$search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';
1131
+		$search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';
1132 1132
 
1133 1133
 		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) {
1134 1134
 			gravityview()->log->debug( 'No search fields configured for widget:', array( 'data' => $widget_args ) );
@@ -1143,41 +1143,41 @@  discard block
 block discarded – undo
1143 1143
 
1144 1144
 			$updated_field = $this->get_search_filter_details( $updated_field );
1145 1145
 
1146
-			switch ( $field['field'] ) {
1146
+			switch ( $field[ 'field' ] ) {
1147 1147
 
1148 1148
 				case 'search_all':
1149
-					$updated_field['key'] = 'search_all';
1150
-					$updated_field['input'] = 'search_all';
1151
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_search' );
1149
+					$updated_field[ 'key' ] = 'search_all';
1150
+					$updated_field[ 'input' ] = 'search_all';
1151
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_search' );
1152 1152
 					break;
1153 1153
 
1154 1154
 				case 'entry_date':
1155
-					$updated_field['key'] = 'entry_date';
1156
-					$updated_field['input'] = 'entry_date';
1157
-					$updated_field['value'] = array(
1155
+					$updated_field[ 'key' ] = 'entry_date';
1156
+					$updated_field[ 'input' ] = 'entry_date';
1157
+					$updated_field[ 'value' ] = array(
1158 1158
 						'start' => $this->rgget_or_rgpost( 'gv_start' ),
1159 1159
 						'end' => $this->rgget_or_rgpost( 'gv_end' ),
1160 1160
 					);
1161 1161
 					break;
1162 1162
 
1163 1163
 				case 'entry_id':
1164
-					$updated_field['key'] = 'entry_id';
1165
-					$updated_field['input'] = 'entry_id';
1166
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_id' );
1164
+					$updated_field[ 'key' ] = 'entry_id';
1165
+					$updated_field[ 'input' ] = 'entry_id';
1166
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_id' );
1167 1167
 					break;
1168 1168
 
1169 1169
 				case 'created_by':
1170
-					$updated_field['key'] = 'created_by';
1171
-					$updated_field['name'] = 'gv_by';
1172
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_by' );
1173
-					$updated_field['choices'] = self::get_created_by_choices();
1170
+					$updated_field[ 'key' ] = 'created_by';
1171
+					$updated_field[ 'name' ] = 'gv_by';
1172
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_by' );
1173
+					$updated_field[ 'choices' ] = self::get_created_by_choices();
1174 1174
 					break;
1175 1175
 				
1176 1176
 				case 'is_approved':
1177
-					$updated_field['key'] = 'is_approved';
1178
-					$updated_field['input'] = 'checkbox';
1179
-					$updated_field['value'] = $this->rgget_or_rgpost( 'filter_is_approved' );
1180
-					$updated_field['choices'] = self::get_is_approved_choices();
1177
+					$updated_field[ 'key' ] = 'is_approved';
1178
+					$updated_field[ 'input' ] = 'checkbox';
1179
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'filter_is_approved' );
1180
+					$updated_field[ 'choices' ] = self::get_is_approved_choices();
1181 1181
 					break;
1182 1182
 			}
1183 1183
 
@@ -1196,16 +1196,16 @@  discard block
 block discarded – undo
1196 1196
 		 */
1197 1197
 		$gravityview_view->search_fields = apply_filters( 'gravityview_widget_search_filters', $search_fields, $this, $widget_args, $context );
1198 1198
 
1199
-		$gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';
1199
+		$gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';
1200 1200
 
1201 1201
 		/** @since 1.14 */
1202
-		$gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';
1202
+		$gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';
1203 1203
 
1204
-		$custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';
1204
+		$custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';
1205 1205
 
1206 1206
 		$gravityview_view->search_class = self::get_search_class( $custom_class );
1207 1207
 
1208
-		$gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;
1208
+		$gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;
1209 1209
 
1210 1210
 		if ( $this->has_date_field( $search_fields ) ) {
1211 1211
 			// enqueue datepicker stuff only if needed!
@@ -1227,10 +1227,10 @@  discard block
 block discarded – undo
1227 1227
 	public static function get_search_class( $custom_class = '' ) {
1228 1228
 		$gravityview_view = GravityView_View::getInstance();
1229 1229
 
1230
-		$search_class = 'gv-search-'.$gravityview_view->search_layout;
1230
+		$search_class = 'gv-search-' . $gravityview_view->search_layout;
1231 1231
 
1232
-		if ( ! empty( $custom_class )  ) {
1233
-			$search_class .= ' '.$custom_class;
1232
+		if ( ! empty( $custom_class ) ) {
1233
+			$search_class .= ' ' . $custom_class;
1234 1234
 		}
1235 1235
 
1236 1236
 		/**
@@ -1274,9 +1274,9 @@  discard block
 block discarded – undo
1274 1274
 
1275 1275
 		if ( ! $label ) {
1276 1276
 
1277
-			$label = isset( $form_field['label'] ) ? $form_field['label'] : '';
1277
+			$label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';
1278 1278
 
1279
-			switch( $field['field'] ) {
1279
+			switch ( $field[ 'field' ] ) {
1280 1280
 				case 'search_all':
1281 1281
 					$label = __( 'Search Entries:', 'gravityview' );
1282 1282
 					break;
@@ -1288,10 +1288,10 @@  discard block
 block discarded – undo
1288 1288
 					break;
1289 1289
 				default:
1290 1290
 					// If this is a field input, not a field
1291
-					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) {
1291
+					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) {
1292 1292
 
1293 1293
 						// Get the label for the field in question, which returns an array
1294
-						$items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );
1294
+						$items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );
1295 1295
 
1296 1296
 						// Get the item with the `label` key
1297 1297
 						$values = wp_list_pluck( $items, 'label' );
@@ -1330,32 +1330,32 @@  discard block
 block discarded – undo
1330 1330
 		$form = $gravityview_view->getForm();
1331 1331
 
1332 1332
 		// for advanced field ids (eg, first name / last name )
1333
-		$name = 'filter_' . str_replace( '.', '_', $field['field'] );
1333
+		$name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );
1334 1334
 
1335 1335
 		// get searched value from $_GET/$_POST (string or array)
1336 1336
 		$value = $this->rgget_or_rgpost( $name );
1337 1337
 
1338 1338
 		// get form field details
1339
-		$form_field = gravityview_get_field( $form, $field['field'] );
1339
+		$form_field = gravityview_get_field( $form, $field[ 'field' ] );
1340 1340
 
1341 1341
 		$filter = array(
1342
-			'key' => $field['field'],
1342
+			'key' => $field[ 'field' ],
1343 1343
 			'name' => $name,
1344 1344
 			'label' => self::get_field_label( $field, $form_field ),
1345
-			'input' => $field['input'],
1345
+			'input' => $field[ 'input' ],
1346 1346
 			'value' => $value,
1347
-			'type' => $form_field['type'],
1347
+			'type' => $form_field[ 'type' ],
1348 1348
 		);
1349 1349
 
1350 1350
 		// collect choices
1351
-		if ( 'post_category' === $form_field['type'] && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) {
1352
-			$filter['choices'] = gravityview_get_terms_choices();
1353
-		} elseif ( ! empty( $form_field['choices'] ) ) {
1354
-			$filter['choices'] = $form_field['choices'];
1351
+		if ( 'post_category' === $form_field[ 'type' ] && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) {
1352
+			$filter[ 'choices' ] = gravityview_get_terms_choices();
1353
+		} elseif ( ! empty( $form_field[ 'choices' ] ) ) {
1354
+			$filter[ 'choices' ] = $form_field[ 'choices' ];
1355 1355
 		}
1356 1356
 
1357
-		if ( 'date_range' === $field['input'] && empty( $value ) ) {
1358
-			$filter['value'] = array( 'start' => '', 'end' => '' );
1357
+		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) {
1358
+			$filter[ 'value' ] = array( 'start' => '', 'end' => '' );
1359 1359
 		}
1360 1360
 
1361 1361
 		return $filter;
@@ -1379,7 +1379,7 @@  discard block
 block discarded – undo
1379 1379
 
1380 1380
 		$choices = array();
1381 1381
 		foreach ( $users as $user ) {
1382
-			$choices[] = array(
1382
+			$choices[ ] = array(
1383 1383
 				'value' => $user->ID,
1384 1384
 				'text' => $user->display_name,
1385 1385
 			);
@@ -1399,9 +1399,9 @@  discard block
 block discarded – undo
1399 1399
 
1400 1400
 		$choices = array();
1401 1401
 		foreach ( GravityView_Entry_Approval_Status::get_all() as $status ) {
1402
-			$choices[] = array(
1403
-				'value' => $status['value'],
1404
-				'text' => $status['label'],
1402
+			$choices[ ] = array(
1403
+				'value' => $status[ 'value' ],
1404
+				'text' => $status[ 'label' ],
1405 1405
 			);
1406 1406
 		}
1407 1407
 
@@ -1453,7 +1453,7 @@  discard block
 block discarded – undo
1453 1453
 	 */
1454 1454
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1455 1455
 
1456
-		$js_dependencies[] = 'jquery-ui-datepicker';
1456
+		$js_dependencies[ ] = 'jquery-ui-datepicker';
1457 1457
 
1458 1458
 		return $js_dependencies;
1459 1459
 	}
@@ -1497,7 +1497,7 @@  discard block
 block discarded – undo
1497 1497
 			'isRTL'             => is_rtl(),
1498 1498
 		), $view_data );
1499 1499
 
1500
-		$localizations['datepicker'] = $datepicker_settings;
1500
+		$localizations[ 'datepicker' ] = $datepicker_settings;
1501 1501
 
1502 1502
 		return $localizations;
1503 1503
 
@@ -1524,7 +1524,7 @@  discard block
 block discarded – undo
1524 1524
 	 * @return void
1525 1525
 	 */
1526 1526
 	private function maybe_enqueue_flexibility() {
1527
-		if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && preg_match( '/MSIE [8-9]/', $_SERVER['HTTP_USER_AGENT'] ) ) {
1527
+		if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) && preg_match( '/MSIE [8-9]/', $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
1528 1528
 			wp_enqueue_script( 'gv-flexibility' );
1529 1529
 		}
1530 1530
 	}
@@ -1546,7 +1546,7 @@  discard block
 block discarded – undo
1546 1546
 		add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );
1547 1547
 
1548 1548
 		$scheme = is_ssl() ? 'https://' : 'http://';
1549
-		wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1549
+		wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1550 1550
 
1551 1551
 		/**
1552 1552
 		 * @filter `gravityview_search_datepicker_class`
@@ -1629,7 +1629,7 @@  discard block
 block discarded – undo
1629 1629
  */
1630 1630
 class GravityView_Widget_Search_GF_Query_Condition extends \GF_Query_Condition {
1631 1631
 	public function __construct( $filter, $view ) {
1632
-		$this->value = $filter['value'];
1632
+		$this->value = $filter[ 'value' ];
1633 1633
 		$this->view = $view;
1634 1634
 	}
1635 1635
 
@@ -1663,11 +1663,11 @@  discard block
 block discarded – undo
1663 1663
 		$conditions = array();
1664 1664
 
1665 1665
 		foreach ( $user_fields as $user_field ) {
1666
-			$conditions[] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) .  '%' );
1666
+			$conditions[ ] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );
1667 1667
 		}
1668 1668
 
1669 1669
 		foreach ( $user_meta_fields as $meta_field ) {
1670
-			$conditions[] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) .  '%' );
1670
+			$conditions[ ] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );
1671 1671
 		}
1672 1672
 
1673 1673
 		$conditions = '(' . implode( ' OR ', $conditions ) . ')';
Please login to merge, or discard this patch.
future/includes/class-gv-request.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 */
46 46
 	public static function is_add_oembed_preview() {
47 47
 		/** The preview request is a parse-embed AJAX call without a type set. */
48
-		return ( self::is_ajax() && ! empty( $_POST['action'] ) && $_POST['action'] == 'parse-embed' && ! isset( $_POST['type'] ) );
48
+		return ( self::is_ajax() && ! empty( $_POST[ 'action' ] ) && $_POST[ 'action' ] == 'parse-embed' && ! isset( $_POST[ 'type' ] ) );
49 49
 	}
50 50
 
51 51
 	/**
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * @return boolean
64 64
 	 */
65 65
 	public static function is_rest() {
66
-		return ! empty( $GLOBALS['wp']->query_vars['rest_route'] );
66
+		return ! empty( $GLOBALS[ 'wp' ]->query_vars[ 'rest_route' ] );
67 67
 	}
68 68
 
69 69
 	/**
@@ -141,15 +141,15 @@  discard block
 block discarded – undo
141 141
 			$get = $_GET;
142 142
 		}
143 143
 
144
-		unset( $get['mode'] );
144
+		unset( $get[ 'mode' ] );
145 145
 
146 146
 		$get = array_filter( $get, 'gravityview_is_not_empty_string' );
147 147
 
148
-		if( $has_field_key = $this->_has_field_key( $get ) ) {
148
+		if ( $has_field_key = $this->_has_field_key( $get ) ) {
149 149
 			return true;
150 150
 		}
151 151
 
152
-		return isset( $get['gv_search'] ) || isset( $get['gv_start'] ) || isset( $get['gv_end'] ) || isset( $get['gv_by'] ) || isset( $get['gv_id'] );
152
+		return isset( $get[ 'gv_search' ] ) || isset( $get[ 'gv_start' ] ) || isset( $get[ 'gv_end' ] ) || isset( $get[ 'gv_by' ] ) || isset( $get[ 'gv_id' ] );
153 153
 	}
154 154
 
155 155
 	/**
@@ -172,13 +172,13 @@  discard block
 block discarded – undo
172 172
 
173 173
 		$meta = array();
174 174
 		foreach ( $fields as $field ) {
175
-			if( empty( $field->_gf_field_class_name ) ) {
176
-				$meta[] = preg_quote( $field->name );
175
+			if ( empty( $field->_gf_field_class_name ) ) {
176
+				$meta[ ] = preg_quote( $field->name );
177 177
 			}
178 178
 		}
179 179
 
180 180
 		foreach ( $get as $key => $value ) {
181
-			if ( preg_match('/^filter_(([0-9_]+)|'. implode( '|', $meta ) .')$/sm', $key ) ) {
181
+			if ( preg_match( '/^filter_(([0-9_]+)|' . implode( '|', $meta ) . ')$/sm', $key ) ) {
182 182
 				$has_field_key = true;
183 183
 				break;
184 184
 			}
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -128,10 +128,10 @@
 block discarded – undo
128 128
 	 */
129 129
 	public function is_edit_entry( $form_id = 0 ) {
130 130
 		/**
131
-		* @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
132
-		* The Edit Entry functionality overrides this value.
133
-		* @param boolean $is_edit_entry
134
-		*/
131
+		 * @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
132
+		 * The Edit Entry functionality overrides this value.
133
+		 * @param boolean $is_edit_entry
134
+		 */
135 135
 		if ( ( $entry = $this->is_entry( $form_id ) ) && apply_filters( 'gravityview_is_edit_entry', false ) ) {
136 136
 			return $entry;
137 137
 		}
Please login to merge, or discard this patch.