Completed
Push — master ( cf9740...0c1274 )
by Zack
19:03 queued 03:33
created

GravityView_Edit_Entry_Render   D

Complexity

Total Complexity 255

Size/Duplication

Total Lines 2006
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 8

Test Coverage

Coverage 61.45%

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 2006
ccs 389
cts 633
cp 0.6145
rs 4.4102
wmc 255
lcom 1
cbo 8

45 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 3 1
A is_field_json_encoded() 0 17 4
A fill_post_template() 0 19 2
B load() 0 28 1
A prevent_render_form() 0 9 3
A prevent_maybe_process_form() 0 11 3
A is_edit_entry() 0 6 3
A is_edit_entry_submission() 0 3 1
A setup_vars() 0 15 1
B init() 0 27 5
A print_scripts() 0 10 1
B process_save() 0 79 6
B unset_hidden_field_values() 0 33 5
A process_save_process_files() 0 16 2
B save_field_value() 0 23 6
A modify_fileupload_settings() 0 9 2
B form_prepare_for_save() 0 27 6
C update_calculation_fields() 0 36 7
C update_post_image() 0 73 14
D maybe_update_post_fields() 0 117 25
A after_update() 0 20 3
A edit_entry_form() 0 56 1
B maybe_print_message() 0 32 3
B render_edit_form() 0 42 1
A render_form_buttons() 0 3 1
A filter_modify_form_fields() 0 20 3
B verify_user_can_edit_post() 0 30 5
C modify_edit_field_input() 0 42 11
C get_field_value() 0 80 19
D gform_pre_validation() 0 87 14
B validate() 0 36 3
F custom_validation() 0 124 21
A get_entry() 0 9 2
B get_configured_edit_fields() 0 34 4
C filter_fields() 0 48 11
B merge_field_properties() 0 23 4
B filter_admin_only_fields() 0 28 6
C prefill_conditional_logic() 0 48 11
B filter_conditional_logic() 0 24 3
A manage_conditional_logic() 0 9 2
C user_can_edit_entry() 0 64 14
B user_can_edit_field() 0 22 4
A check_user_cap_edit_field() 0 16 4
B verify_nonce() 0 26 3
A fix_multiselect_value_serialization() 0 13 4

How to fix   Complexity   

Complex Class

Complex classes like GravityView_Edit_Entry_Render often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use GravityView_Edit_Entry_Render, and based on these observations, apply Extract Interface, too.

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 16 and the first side effect is on line 13.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
/**
3
 * GravityView Edit Entry - render frontend
4
 *
5
 * @package   GravityView
6
 * @license   GPL2+
7
 * @author    Katz Web Services, Inc.
8
 * @link      http://gravityview.co
9
 * @copyright Copyright 2014, Katz Web Services, Inc.
10
 */
11
12
if ( ! defined( 'WPINC' ) ) {
13
    die;
14
}
15
16
class GravityView_Edit_Entry_Render {
17
18
    /**
19
     * @var GravityView_Edit_Entry
20
     */
21
    protected $loader;
22
23
	/**
24
	 * @var string String used to generate unique nonce for the entry/form/view combination. Allows access to edit page.
25
	 */
26
    static $nonce_key;
0 ignored issues
show
Coding Style introduced by
The visibility should be declared for property $nonce_key.

The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using

class A {
    var $property;
}

the property is implicitly global.

To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.

Loading history...
27
28
	/**
29
	 * @since 1.9
30
	 * @var string String used for check valid edit entry form submission. Allows saving edit form values.
31
	 */
32
	private static $nonce_field = 'is_gv_edit_entry';
33
34
	/**
35
	 * @since 1.9
36
	 * @var bool Whether to allow save and continue functionality
37
	 */
38
	private static $supports_save_and_continue = false;
39
40
    /**
41
     * Gravity Forms entry array
42
     *
43
     * @var array
44
     */
45
    public $entry;
46
47
	/**
48
	 * Gravity Forms entry array (it won't get changed during this class lifecycle)
49
	 * @since 1.17.2
50
	 * @var array
51
	 */
52
	private static $original_entry = array();
53
54
    /**
55
     * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
     *
57
     * @var array
58
     */
59
	public $form;
60
61
    /**
62
     * Gravity Forms form array (it won't get changed during this class lifecycle)
63
     * @since 1.16.2.1
64
     * @var array
65
     */
66
    private static $original_form;
67
68
    /**
69
     * Gravity Forms form array after the form validation process
70
     * @since 1.13
71
     * @var array
72
     */
73
	public $form_after_validation = null;
74
75
    /**
76
     * Hold an array of GF field objects that have calculation rules
77
     * @var array
78
     */
79
	public $fields_with_calculation = array();
80
81
    /**
82
     * Gravity Forms form id
83
     *
84
     * @var int
85
     */
86
	public $form_id;
87
88
    /**
89
     * ID of the current view
90
     *
91
     * @var int
92
     */
93
	public $view_id;
94
95
    /**
96
     * Updated entry is valid (GF Validation object)
97
     *
98
     * @var array
99
     */
100
	public $is_valid = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
101
102 3
    function __construct( GravityView_Edit_Entry $loader ) {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
103 3
        $this->loader = $loader;
104 3
    }
105
106 3
    function load() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
107
108
        /** @define "GRAVITYVIEW_DIR" "../../../" */
109 3
        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
110
111
        // Don't display an embedded form when editing an entry
112 3
        add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
113 3
        add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
114
115
        // Stop Gravity Forms processing what is ours!
116 3
        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
117
118 3
        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
119
120 3
        add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
121
122
        // Disable conditional logic if needed (since 1.9)
123 3
        add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
124
125
        // Make sure GF doesn't validate max files (since 1.9)
126 3
        add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
127
128
        // Add fields expected by GFFormDisplay::validate()
129 3
        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
130
131
		// Fix multiselect value for GF 2.2
132 3
		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
133 3
    }
134
135
    /**
136
     * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
137
     *
138
     * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
139
     * And then removes it on the `wp_footer` action
140
     *
141
     * @since 1.16.1
142
     *
143
     * @return void
144
     */
145 1
    public function prevent_render_form() {
146 1
        if( $this->is_edit_entry() ) {
147 1
            if( 'wp_head' === current_filter() ) {
148 1
                add_filter( 'gform_shortcode_form', '__return_empty_string' );
149
            } else {
150 1
                remove_filter( 'gform_shortcode_form', '__return_empty_string' );
151
            }
152
        }
153 1
    }
154
155
    /**
156
     * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
157
     * backend form, we need to prevent them from saving twice.
158
     * @return void
159
     */
160
    public function prevent_maybe_process_form() {
161
162
        if( ! empty( $_POST ) ) {
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
163
	        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
0 ignored issues
show
introduced by
The use of function print_r() is discouraged
Loading history...
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
164
        }
165
166
        if( $this->is_edit_entry_submission() ) {
167
            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
168
	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
169
        }
170
    }
171
172
    /**
173
     * Is the current page an Edit Entry page?
174
     * @return boolean
175
     */
176 4
    public function is_edit_entry() {
177
178 4
        $is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
0 ignored issues
show
introduced by
Detected access of super global var $_GET, probably need manual inspection.
Loading history...
179
180 4
        return ( $is_edit_entry || $this->is_edit_entry_submission() );
181
    }
182
183
	/**
184
	 * Is the current page an Edit Entry page?
185
	 * @since 1.9
186
	 * @return boolean
187
	 */
188 3
	public function is_edit_entry_submission() {
189 3
		return !empty( $_POST[ self::$nonce_field ] );
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
190
	}
191
192
    /**
193
     * When Edit entry view is requested setup the vars
194
     */
195 3
    private function setup_vars() {
196 3
        $gravityview_view = GravityView_View::getInstance();
197
0 ignored issues
show
Coding Style introduced by
Functions must not contain multiple empty lines in a row; found 2 empty lines
Loading history...
198
199 3
        $entries = $gravityview_view->getEntries();
200 3
	    self::$original_entry = $entries[0];
201 3
	    $this->entry = $entries[0];
202
203 3
        self::$original_form = $gravityview_view->getForm();
204 3
        $this->form = $gravityview_view->getForm();
205 3
        $this->form_id = $gravityview_view->getFormId();
206 3
        $this->view_id = $gravityview_view->getViewId();
207
208 3
        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
209 3
    }
210
211
212
    /**
213
     * Load required files and trigger edit flow
214
     *
215
     * Run when the is_edit_entry returns true.
216
     *
217
     * @param GravityView_View_Data $gv_data GravityView Data object
218
     * @return void
219
     */
220 4
    public function init( $gv_data ) {
221
222 4
        require_once( GFCommon::get_base_path() . '/form_display.php' );
223 4
        require_once( GFCommon::get_base_path() . '/entry_detail.php' );
224
225 4
        $this->setup_vars();
226
227
        // Multiple Views embedded, don't proceed if nonce fails
228 4
		$multiple_views = defined( 'GRAVITYVIEW_FUTURE_CORE_LOADED' ) ? gravityview()->views->count() > 1 : $gv_data->has_multiple_views();
0 ignored issues
show
Documentation introduced by
The property views does not exist on object<GV\Core>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
Deprecated Code introduced by
The method GravityView_View_Data::has_multiple_views() has been deprecated.

This method has been deprecated.

Loading history...
229 4
        if( $multiple_views && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
0 ignored issues
show
introduced by
Detected access of super global var $_GET, probably need manual inspection.
Loading history...
introduced by
Detected usage of a non-validated input variable: $_GET
Loading history...
introduced by
Detected usage of a non-sanitized input variable: $_GET
Loading history...
230
            do_action('gravityview_log_error', __METHOD__ . ': Nonce validation failed for the Edit Entry request; returning' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
231
            return;
232
        }
233
234
        // Sorry, you're not allowed here.
235 4
        if( false === $this->user_can_edit_entry( true ) ) {
236 1
            do_action('gravityview_log_error', __METHOD__ . ': User is not allowed to edit this entry; returning', $this->entry );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
237 1
            return;
238
        }
239
240 4
        $this->print_scripts();
241
242 4
        $this->process_save();
243
244 4
        $this->edit_entry_form();
245
246 4
    }
247
248
249
    /**
250
     * Force Gravity Forms to output scripts as if it were in the admin
251
     * @return void
252
     */
253 3
    private function print_scripts() {
254 3
        $gravityview_view = GravityView_View::getInstance();
255
256 3
        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
257
258 3
        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
259
260
        // Sack is required for images
261 3
        wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
262 3
    }
263
264
265
    /**
266
     * Process edit entry form save
267
     */
268 4
    private function process_save() {
269
270 4
        if( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
271 4
            return;
272
        }
273
274
        // Make sure the entry, view, and form IDs are all correct
275 4
        $valid = $this->verify_nonce();
276
277 4
        if( !$valid ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
278
            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
279
            return;
280
        }
281
282 4
        if( $this->entry['id'] !== $_POST['lid'] ) {
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
introduced by
Detected usage of a non-sanitized input variable: $_POST
Loading history...
283
            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
284
            return;
285
        }
286
287 4
        do_action('gravityview_log_debug', __METHOD__ . ': $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
introduced by
The use of function print_r() is discouraged
Loading history...
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
288
289 4
        $this->process_save_process_files( $this->form_id );
290
291 4
        $this->validate();
292
293 4
        if( $this->is_valid ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->is_valid of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
294
295 4
            do_action('gravityview_log_debug', __METHOD__ . ': Submission is valid.' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
296
297
            /**
298
             * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
299
             */
300 4
            $form = $this->form_prepare_for_save();
301
302
            /**
303
             * @hack to avoid the capability validation of the method save_lead for GF 1.9+
304
             */
305 4
            unset( $_GET['page'] );
0 ignored issues
show
introduced by
Detected access of super global var $_GET, probably need manual inspection.
Loading history...
306
307 4
            $date_created = $this->entry['date_created'];
308
309
            /**
310
             * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
311
             * @since 1.17.2
312
             */
313 4
            unset( $this->entry['date_created'] );
314
315 4
            GFFormsModel::save_lead( $form, $this->entry );
316
317
	        // Delete the values for hidden inputs
318 4
	        $this->unset_hidden_field_values();
319
            
320 4
            $this->entry['date_created'] = $date_created;
321
322
            // Process calculation fields
323 4
            $this->update_calculation_fields();
324
325
            // Perform actions normally performed after updating a lead
326 4
            $this->after_update();
327
328
	        /**
329
             * Must be AFTER after_update()!
330
             * @see https://github.com/gravityview/GravityView/issues/764
331
             */
332 4
            $this->maybe_update_post_fields( $form );
333
334
            /**
335
             * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
336
             * @param array $form Gravity Forms form array
337
             * @param string $entry_id Numeric ID of the entry that was updated
338
             * @param GravityView_Edit_Entry_Render $this This object
339
             */
340 4
            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this );
341
342
        } else {
343
            do_action('gravityview_log_error', __METHOD__ . ': Submission is NOT valid.', $this->entry );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
344
        }
345
346 4
    } // process_save
347
348
	/**
349
	 * Delete the value of fields hidden by conditional logic when the entry is edited
350
     *
351
     * @uses GFFormsModel::update_lead_field_value()
352
     *
353
     * @since 1.17.4
354
     *
355
     * @return void
356
	 */
357 3
    private function unset_hidden_field_values() {
358 3
	    global $wpdb;
0 ignored issues
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
359
360 3
		if ( method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
361
			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
362
			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT meta_key, meta_value FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
0 ignored issues
show
introduced by
Usage of a direct database call is discouraged.
Loading history...
introduced by
Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set.
Loading history...
363
		} else {
364 3
			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
365 3
			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_number FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
0 ignored issues
show
introduced by
Usage of a direct database call is discouraged.
Loading history...
introduced by
Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set.
Loading history...
366
		}
367
368 3
	    foreach ( $this->entry as $input_id => $field_value ) {
369
370 3
		    $field = RGFormsModel::get_field( $this->form, $input_id );
371
372
		    // Reset fields that are hidden
373
		    // Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
374 3
		    if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
375
376
		        // List fields are stored as empty arrays when empty
377
			    $empty_value = $this->is_field_json_encoded( $field ) ? '[]' : '';
378
379
			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
380
381
			    GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
382
383
			    // Prevent the $_POST values of hidden fields from being used as default values when rendering the form
384
                // after submission
385
			    $post_input_id = 'input_' . str_replace( '.', '_', $input_id );
386 3
			    $_POST[ $post_input_id ] = '';
387
		    }
388
	    }
389 3
    }
390
391
    /**
392
     * Have GF handle file uploads
393
     *
394
     * Copy of code from GFFormDisplay::process_form()
395
     *
396
     * @param int $form_id
397
     */
398 3
    private function process_save_process_files( $form_id ) {
399
400
        //Loading files that have been uploaded to temp folder
401 3
        $files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
402 3
        if ( ! is_array( $files ) ) {
403 2
            $files = array();
404
        }
405
406
		/**
407
		 * Make sure the fileuploads are not overwritten if no such request was done.
408
         * @since 1.20.1
409
		 */
410 3
		add_filter( "gform_save_field_value_$form_id", array( $this, 'save_field_value' ), 99, 5 );
411
412 3
        RGFormsModel::$uploaded_files[ $form_id ] = $files;
413 3
    }
414
415
	/**
416
	 * Make sure the fileuploads are not overwritten if no such request was done.
417
	 *
418
     * TO ONLY BE USED INTERNALLY; DO NOT DEVELOP ON; MAY BE REMOVED AT ANY TIME.
419
     *
420
	 * @since 1.20.1
421
	 *
422
	 * @param string $value Field value
423
	 * @param array $entry GF entry array
424
	 * @param GF_Field_FileUpload $field
425
	 * @param array $form GF form array
426
	 * @param string $input_id ID of the input being saved
427
	 *
428
	 * @return string
429
	 */
430 3
	public function save_field_value( $value = '', $entry = array(), $field = null, $form = array(), $input_id = '' ) {
431
432 3
		if ( ! $field || $field->type != 'fileupload' ) {
0 ignored issues
show
introduced by
Found "!= '". Use Yoda Condition checks, you must
Loading history...
433 3
			return $value;
434
		}
435
436 1
		$input_name = 'input_' . str_replace( '.', '_', $input_id );
437
438 1
		if ( $field->multipleFiles ) {
439
			if ( empty( $value ) ) {
440
				return json_decode( $entry[ $input_id ], true );
441
			}
442
			return $value;
443
		}
444
445
		/** No file is being uploaded. */
446 1
		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
447
			/** So return the original upload */
448 1
			return $entry[ $input_id ];
449
		}
450
451 1
		return $value;
452
	}
453
454
    /**
455
     * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
456
     * Late validation done on self::custom_validation
457
     *
458
     * @param $plupload_init array Plupload settings
459
     * @param $form_id
460
     * @param $instance
461
     * @return mixed
462
     */
463 1
    public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
0 ignored issues
show
Unused Code introduced by
The parameter $form_id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $instance is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
464 1
        if( ! $this->is_edit_entry() ) {
465
            return $plupload_init;
466
        }
467
468 1
        $plupload_init['gf_vars']['max_files'] = 0;
469
470 1
        return $plupload_init;
471
    }
472
473
474
    /**
475
     * Unset adminOnly and convert field input key to string
476
     * @return array $form
477
     */
478 3
    private function form_prepare_for_save() {
479
480 3
        $form = $this->form;
481
482
	    /** @var GF_Field $field */
483 3
        foreach( $form['fields'] as $k => &$field ) {
484
485
            /**
486
             * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
487
             * @since 1.16.3
488
             * @var GF_Field $field
489
             */
490 3
            if( $field->has_calculation() ) {
491
                unset( $form['fields'][ $k ] );
492
            }
493
494 3
            $field->adminOnly = false;
495
496 3
            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
497
                foreach( $field->inputs as $key => $input ) {
498 3
                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
0 ignored issues
show
introduced by
Array keys should NOT be surrounded by spaces if they only contain a string or an integer.
Loading history...
introduced by
No space after closing casting parenthesis is prohibited
Loading history...
499
                }
500
            }
501
        }
502
503 3
        return $form;
504
    }
505
506 3
    private function update_calculation_fields() {
507
508 3
        $form = self::$original_form;
509 3
        $update = false;
510
511
        // get the most up to date entry values
512 3
        $entry = GFAPI::get_entry( $this->entry['id'] );
513
514 3
        if( !empty( $this->fields_with_calculation ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
515
            $update = true;
516
            foreach ( $this->fields_with_calculation as $calc_field ) {
517
                $inputs = $calc_field->get_entry_inputs();
518
                if ( is_array( $inputs ) ) {
519
                    foreach ( $inputs as $input ) {
520
                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
521
                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
522
                    }
523
                } else {
524
                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
525
                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
526
                }
527
            }
528
529
        }
530
531 3
        if( $update ) {
532
533
            $return_entry = GFAPI::update_entry( $entry );
534
535
            if( is_wp_error( $return_entry ) ) {
536
                do_action( 'gravityview_log_error', 'Updating the entry calculation fields failed', $return_entry );
537
            } else {
538
                do_action( 'gravityview_log_debug', 'Updating the entry calculation fields succeeded' );
539
            }
540
        }
541 3
    }
542
543
    /**
544
     * Handle updating the Post Image field
545
     *
546
     * Sets a new Featured Image if configured in Gravity Forms; otherwise uploads/updates media
547
     *
548
     * @since 1.17
549
     *
550
     * @uses GFFormsModel::media_handle_upload
551
     * @uses set_post_thumbnail
552
     * 
553
     * @param array $form GF Form array
554
     * @param GF_Field $field GF Field
555
     * @param string $field_id Numeric ID of the field
556
     * @param string $value
557
     * @param array $entry GF Entry currently being edited
558
     * @param int $post_id ID of the Post being edited
559
     *
560
     * @return mixed|string
561
     */
562 1
    private function update_post_image( $form, $field, $field_id, $value, $entry, $post_id ) {
563
564 1
        $input_name = 'input_' . $field_id;
565
566 1
        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
567
568
            // We have a new image
569
570
            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
571
572
            $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
573
            $img_url = rgar( $ary, 0 );
574
575
            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
576
            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
577
            $img_description = count( $ary ) > 3 ? $ary[3] : '';
578
579
            $image_meta = array(
580
                'post_excerpt' => $img_caption,
581
                'post_content' => $img_description,
582
            );
583
584
            //adding title only if it is not empty. It will default to the file name if it is not in the array
585
            if ( ! empty( $img_title ) ) {
586
                $image_meta['post_title'] = $img_title;
587
            }
588
589
            /**
590
             * todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
591
             * Note: the method became public in GF 1.9.17.7, but we don't require that version yet.
592
             */
593
            require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
594
            $media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
595
596
            // is this field set as featured image?
597
            if ( $media_id && $field->postFeaturedImage ) {
598
                set_post_thumbnail( $post_id, $media_id );
599
            }
600
601 1
        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
602
603 1
            $img_url = $_POST[ $input_name ];
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
introduced by
Detected usage of a non-sanitized input variable: $_POST
Loading history...
604
605 1
			$img_title       = rgar( $_POST, $input_name.'_1' );
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
606 1
			$img_caption     = rgar( $_POST, $input_name .'_4' );
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
607 1
			$img_description = rgar( $_POST, $input_name .'_7' );
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
608
609 1
			$value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
0 ignored issues
show
Coding Style Comprehensibility introduced by
The string literal |:| does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
610
611 1
			if ( $field->postFeaturedImage ) {
612
613
				$image_meta = array(
614 1
					'ID' => get_post_thumbnail_id( $post_id ),
615 1
					'post_title' => $img_title,
616 1
					'post_excerpt' => $img_caption,
617 1
					'post_content' => $img_description,
618
				);
619
620
				// update image title, caption or description
621 1
				wp_update_post( $image_meta );
622
			}
623
        } else {
624
625
            // if we get here, image was removed or not set.
626
            $value = '';
627
628
            if ( $field->postFeaturedImage ) {
629
                delete_post_thumbnail( $post_id );
630
            }
631
        }
632
633 1
        return $value;
634
    }
635
636
    /**
637
     * Loop through the fields being edited and if they include Post fields, update the Entry's post object
638
     *
639
     * @param array $form Gravity Forms form
640
     *
641
     * @return void
642
     */
643 3
    private function maybe_update_post_fields( $form ) {
644
645 3
        if( empty( $this->entry['post_id'] ) ) {
646 2
	        do_action( 'gravityview_log_debug', __METHOD__ . ': This entry has no post fields. Continuing...' );
647 2
            return;
648
        }
649
650 1
        $post_id = $this->entry['post_id'];
651
652
        // Security check
653 1
        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
654
            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
655
            return;
656
        }
657
658 1
        $update_entry = false;
659
660 1
        $updated_post = $original_post = get_post( $post_id );
661
662 1
        foreach ( $this->entry as $field_id => $value ) {
663
664 1
            $field = RGFormsModel::get_field( $form, $field_id );
665
666 1
            if( ! $field ) {
667 1
                continue;
668
            }
669
670 1
            if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
671
672
                // Get the value of the field, including $_POSTed value
673 1
                $value = RGFormsModel::get_field_value( $field );
674
675
                // Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
676 1
                $entry_tmp = $this->entry;
677 1
                $entry_tmp["{$field_id}"] = $value;
0 ignored issues
show
introduced by
Array keys should be surrounded by spaces unless they contain a string or an integer.
Loading history...
678
679 1
                switch( $field->type ) {
680
681 1
                    case 'post_title':
682
                        $post_title = $value;
683
                        if( rgar( $form, 'postTitleTemplateEnabled' ) ) {
684
                            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
685
                        }
686
                        $updated_post->post_title = $post_title;
687
                        $updated_post->post_name  = $post_title;
688
                        unset( $post_title );
689
                        break;
690
691 1
                    case 'post_content':
692
                        $post_content = $value;
693
                        if( rgar( $form, 'postContentTemplateEnabled' ) ) {
694
                            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
695
                        }
696
                        $updated_post->post_content = $post_content;
697
                        unset( $post_content );
698
                        break;
699 1
                    case 'post_excerpt':
700
                        $updated_post->post_excerpt = $value;
701
                        break;
702 1
                    case 'post_tags':
703
                        wp_set_post_tags( $post_id, $value, false );
704
                        break;
705 1
                    case 'post_category':
706
                        break;
707 1
                    case 'post_custom_field':
708
						if ( is_array( $value ) && ( floatval( $field_id ) !== floatval( $field->id ) ) ) {
709
							$value = $value[ $field_id ];
710
						}
711
712
                        if( ! empty( $field->customFieldTemplateEnabled ) ) {
713
                            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
714
                        }
715
716
	                    if ( $this->is_field_json_encoded( $field ) && ! is_string( $value ) ) {
717
		                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
718
	                    }
719
720
                        update_post_meta( $post_id, $field->postCustomFieldName, $value );
721
                        break;
722
723 1
                    case 'post_image':
724 1
                        $value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
725 1
                        break;
726
727
                }
728
729
                // update entry after
730 1
                $this->entry["{$field_id}"] = $value;
0 ignored issues
show
introduced by
Array keys should be surrounded by spaces unless they contain a string or an integer.
Loading history...
731
732 1
                $update_entry = true;
733
734 1
                unset( $entry_tmp );
735
            }
736
737
        }
738
739 1
        if( $update_entry ) {
740
741 1
            $return_entry = GFAPI::update_entry( $this->entry );
742
743 1
            if( is_wp_error( $return_entry ) ) {
744
               do_action( 'gravityview_log_error', 'Updating the entry post fields failed', array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) );
745
            } else {
746 1
                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
747
            }
748
749
        }
750
751 1
        $return_post = wp_update_post( $updated_post, true );
752
753 1
        if( is_wp_error( $return_post ) ) {
754
            $return_post->add_data( $updated_post, '$updated_post' );
755
            do_action( 'gravityview_log_error', 'Updating the post content failed', compact( 'updated_post', 'return_post' ) );
756
        } else {
757 1
            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
758
        }
759 1
    }
760
761
	/**
762
     * Is the field stored in a JSON-encoded manner?
763
     *
764
	 * @param GF_Field $field
765
	 *
766
	 * @return bool True: stored in DB json_encode()'d; False: not encoded
767
	 */
768
    private function is_field_json_encoded( $field ) {
769
770
	    $json_encoded = false;
771
772
        $input_type = RGFormsModel::get_input_type( $field );
773
774
	    // Only certain custom field types are supported
775
	    switch( $input_type ) {
776
		    case 'fileupload':
777
		    case 'list':
778
		    case 'multiselect':
779
			    $json_encoded = true;
780
			    break;
781
	    }
782
783
	    return $json_encoded;
784
    }
785
786
    /**
787
     * Convert a field content template into prepared output
788
     *
789
     * @uses GravityView_GFFormsModel::get_post_field_images()
790
     *
791
     * @since 1.17
792
     *
793
     * @param string $template The content template for the field
794
     * @param array $form Gravity Forms form
795
     * @param bool $do_shortcode Whether to process shortcode inside content. In GF, only run on Custom Field and Post Content fields
796
     *
797
     * @return string
798
     */
799
    private function fill_post_template( $template, $form, $entry, $do_shortcode = false ) {
800
801
        require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
802
803
        $post_images = GravityView_GFFormsModel::get_post_field_images( $form, $entry );
804
805
        //replacing post image variables
806
        $output = GFCommon::replace_variables_post_image( $template, $post_images, $entry );
807
808
        //replacing all other variables
809
        $output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
810
811
        // replace conditional shortcodes
812
        if( $do_shortcode ) {
813
            $output = do_shortcode( $output );
814
        }
815
816
        return $output;
817
    }
818
819
820
    /**
821
     * Perform actions normally performed after updating a lead
822
     *
823
     * @since 1.8
824
     *
825
     * @see GFEntryDetail::lead_detail_page()
826
     *
827
     * @return void
828
     */
829 3
    private function after_update() {
830
831 3
        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
832 3
        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
833
834
        // Re-define the entry now that we've updated it.
835 3
        $entry = RGFormsModel::get_lead( $this->entry['id'] );
836
837 3
        $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
838
839 3
		if ( ! method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
840
			// We need to clear the cache because Gravity Forms caches the field values, which
841
			// we have just updated.
842 3
			foreach ($this->form['fields'] as $key => $field) {
0 ignored issues
show
introduced by
No space after opening parenthesis is prohibited
Loading history...
introduced by
No space before closing parenthesis is prohibited
Loading history...
843 3
				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
844
			}
845
		}
846
847 3
        $this->entry = $entry;
848 3
    }
849
850
851
    /**
852
     * Display the Edit Entry form
853
     *
854
     * @return void
855
     */
856 3
    public function edit_entry_form() {
857
858
        ?>
859
860
        <div class="gv-edit-entry-wrapper"><?php
861
862 3
            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
0 ignored issues
show
Bug introduced by
The property file cannot be accessed from this context as it is declared private in class GravityView_Edit_Entry.

This check looks for access to properties that are not accessible from the current context.

If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class.

Loading history...
863
864
            /**
865
             * Fixes weird wpautop() issue
866
             * @see https://github.com/katzwebservices/GravityView/issues/451
867
             */
868 3
            echo gravityview_strip_whitespace( $javascript );
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'gravityview_strip_whitespace'
Loading history...
869
870
            ?><h2 class="gv-edit-entry-title">
871
                <span><?php
872
873
                    /**
874
                     * @filter `gravityview_edit_entry_title` Modify the edit entry title
875
                     * @param string $edit_entry_title Modify the "Edit Entry" title
876
                     * @param GravityView_Edit_Entry_Render $this This object
877
                     */
878 3
                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
879
880 3
                    echo esc_attr( $edit_entry_title );
881
            ?></span>
882
            </h2>
883
884
            <?php $this->maybe_print_message(); ?>
885
886
            <?php // The ID of the form needs to be `gform_{form_id}` for the pluploader ?>
887
888
            <form method="post" id="gform_<?php echo $this->form_id; ?>" enctype="multipart/form-data">
0 ignored issues
show
introduced by
Expected next thing to be a escaping function, not '$this'
Loading history...
889
890
                <?php
891
892 3
                wp_nonce_field( self::$nonce_key, self::$nonce_key );
893
894 3
                wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
895
896
                // Print the actual form HTML
897 3
                $this->render_edit_form();
898
899
                ?>
900 3
            </form>
901
902
            <script>
903
                gform.addFilter('gform_reset_pre_conditional_logic_field_action', function ( reset, formId, targetId, defaultValues, isInit ) {
904
                    return false;
905
                });
906
            </script>
907
908
        </div>
909
910
    <?php
911 3
    }
912
913
    /**
914
     * Display success or error message if the form has been submitted
915
     *
916
     * @uses GVCommon::generate_notice
917
     *
918
     * @since 1.16.2.2
919
     *
920
     * @return void
921
     */
922 3
    private function maybe_print_message() {
923
924 3
        if( rgpost('action') === 'update' ) {
0 ignored issues
show
introduced by
Found "=== '". Use Yoda Condition checks, you must
Loading history...
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
925
926
            $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
927
928
            if( ! $this->is_valid ){
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->is_valid of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
929
930
                // Keeping this compatible with Gravity Forms.
931
                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
Coding Style Comprehensibility introduced by
The string literal does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw '__'
Loading history...
Coding Style Comprehensibility introduced by
The string literal </div> does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
932
                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
Coding Style Comprehensibility introduced by
The string literal gform_validation_message does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
933
934
                echo GVCommon::generate_notice( $message , 'gv-error' );
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'GVCommon'
Loading history...
935
936
            } else {
937
                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
938
939
                /**
940
                 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
941
                 * @since 1.5.4
942
                 * @param string $entry_updated_message Existing message
943
                 * @param int $view_id View ID
944
                 * @param array $entry Gravity Forms entry array
945
                 * @param string $back_link URL to return to the original entry. @since 1.6
946
                 */
947
                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
948
949
                echo GVCommon::generate_notice( $message );
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'GVCommon'
Loading history...
950
            }
951
952
        }
953 3
    }
954
955
    /**
956
     * Display the Edit Entry form in the original Gravity Forms format
957
     *
958
     * @since 1.9
959
     *
960
     * @return void
961
     */
962 3
    private function render_edit_form() {
963
964
        /**
965
         * @action `gravityview/edit-entry/render/before` Before rendering the Edit Entry form
966
         * @since 1.17
967
         * @param GravityView_Edit_Entry_Render $this
968
         */
969 3
        do_action( 'gravityview/edit-entry/render/before', $this );
970
971 3
        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
972 3
        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
0 ignored issues
show
introduced by
No space before closing parenthesis of array is bad style
Loading history...
973 3
        add_filter( 'gform_disable_view_counter', '__return_true' );
974
975 3
        add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
976 3
        add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
977
978
        // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
979 3
        unset( $_GET['page'] );
0 ignored issues
show
introduced by
Detected access of super global var $_GET, probably need manual inspection.
Loading history...
980
981
        // TODO: Verify multiple-page forms
982
983 3
        ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
984
985 3
        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
986
987 3
        ob_get_clean();
988
989 3
	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
990 3
        remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
991 3
        remove_filter( 'gform_disable_view_counter', '__return_true' );
992 3
        remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
993 3
        remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
994
995 3
        echo $html;
0 ignored issues
show
introduced by
Expected next thing to be a escaping function, not '$html'
Loading history...
996
997
        /**
998
         * @action `gravityview/edit-entry/render/after` After rendering the Edit Entry form
999
         * @since 1.17
1000
         * @param GravityView_Edit_Entry_Render $this
1001
         */
1002 3
        do_action( 'gravityview/edit-entry/render/after', $this );
1003 3
    }
1004
1005
    /**
1006
     * Display the Update/Cancel/Delete buttons for the Edit Entry form
1007
     * @since 1.8
1008
     * @return string
1009
     */
1010 3
    public function render_form_buttons() {
1011 3
        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
0 ignored issues
show
Bug introduced by
The property file cannot be accessed from this context as it is declared private in class GravityView_Edit_Entry.

This check looks for access to properties that are not accessible from the current context.

If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class.

Loading history...
1012
    }
1013
1014
1015
    /**
1016
     * Modify the form fields that are shown when using GFFormDisplay::get_form()
1017
     *
1018
     * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
1019
     *
1020
     * @param array $form
1021
     * @param boolean $ajax Whether in AJAX mode
1022
     * @param array|string $field_values Passed parameters to the form
1023
     *
1024
     * @since 1.9
1025
     *
1026
     * @return array Modified form array
1027
     */
1028 3
    public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
0 ignored issues
show
Unused Code introduced by
The parameter $ajax is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $field_values is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
1029
1030
        // In case we have validated the form, use it to inject the validation results into the form render
1031 3
        if( isset( $this->form_after_validation ) ) {
1032 3
            $form = $this->form_after_validation;
1033
        } else {
1034 3
            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1035
        }
1036
1037 3
        $form = $this->filter_conditional_logic( $form );
1038
1039 3
        $form = $this->prefill_conditional_logic( $form );
1040
1041
        // for now we don't support Save and Continue feature.
1042 3
        if( ! self::$supports_save_and_continue ) {
1043 3
	        unset( $form['save'] );
1044
        }
1045
1046 3
        return $form;
1047
    }
1048
1049
    /**
1050
     * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
1051
     *
1052
     * @since 1.16.2.2
1053
     *
1054
     * @param string $field_content Always empty. Returning not-empty overrides the input.
1055
     * @param GF_Field $field
1056
     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1057
     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1058
     * @param int $form_id Form ID
1059
     *
1060
     * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
1061
     */
1062 3
    public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
0 ignored issues
show
Unused Code introduced by
The parameter $value is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $lead_id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $form_id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
1063
1064 3
        if( GFCommon::is_post_field( $field ) ) {
1065
1066 1
            $message = null;
1067
1068
            // First, make sure they have the capability to edit the post.
1069 1
            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1070
1071
                /**
1072
                 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1073
                 * @param string $message The existing "You don't have permission..." text
1074
                 */
1075
                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1076
1077 1
            } elseif( null === get_post( $this->entry['post_id'] ) ) {
1078
                /**
1079
                 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1080
                 * @param string $message The existing "This field is not editable; the post no longer exists." text
1081
                 */
1082
                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1083
            }
1084
1085 1
            if( $message ) {
1086
                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1087
            }
1088
        }
1089
1090 3
        return $field_content;
1091
    }
1092
1093
    /**
1094
     *
1095
     * Fill-in the saved values into the form inputs
1096
     *
1097
     * @param string $field_content Always empty. Returning not-empty overrides the input.
1098
     * @param GF_Field $field
1099
     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
1100
     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1101
     * @param int $form_id Form ID
1102
     *
1103
     * @return mixed
1104
     */
1105 3
    public function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
0 ignored issues
show
Unused Code introduced by
The parameter $value is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $lead_id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $form_id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
1106
1107 3
        $gv_field = GravityView_Fields::get_associated_field( $field );
1108
1109
        // If the form has been submitted, then we don't need to pre-fill the values,
1110
        // Except for fileupload type and when a field input is overridden- run always!!
1111
        if(
1112 3
            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1113 3
            && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1114
            && ! GFCommon::is_product_field( $field->type )
1115 3
            || ! empty( $field_content )
1116 3
            || in_array( $field->type, array( 'honeypot' ) )
1117
        ) {
1118
	        return $field_content;
1119
        }
1120
1121
        // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
1122 3
        $field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
1123
1124 3
        $field_value = $this->get_field_value( $field );
1125
1126
	    // Prevent any PHP warnings, like undefined index
1127 3
	    ob_start();
1128
1129 3
	    $return = null;
1130
1131
        /** @var GravityView_Field $gv_field */
1132 3
        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1133 2
            $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1134
        } else {
1135 3
	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1136
	    }
1137
1138
	    // If there was output, it's an error
1139 3
	    $warnings = ob_get_clean();
1140
1141 3
	    if( !empty( $warnings ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1142
		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1143
	    }
1144
1145 3
        return $return;
1146
    }
1147
1148
    /**
1149
     * Modify the value for the current field input
1150
     *
1151
     * @param GF_Field $field
1152
     *
1153
     * @return array|mixed|string
1154
     */
1155 3
    private function get_field_value( $field ) {
1156
1157
        /**
1158
         * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
1159
         * @param boolean True: override saved values; False: don't override (default)
1160
         * @param $field GF_Field object Gravity Forms field object
1161
         * @since 1.13
1162
         */
1163 3
        $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1164
1165
        // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1166 3
        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1167
1168
            $field_value = array();
1169
1170
            // only accept pre-populated values if the field doesn't have any choice selected.
1171
            $allow_pre_populated = $field->allowsPrepopulate;
1172
1173
            foreach ( (array)$field->inputs as $input ) {
0 ignored issues
show
introduced by
No space after closing casting parenthesis is prohibited
Loading history...
1174
1175
                $input_id = strval( $input['id'] );
1176
                
1177
                if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1178
                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
0 ignored issues
show
introduced by
Expected 1 space after "="; 2 found
Loading history...
1179
                    $allow_pre_populated = false;
1180
                }
1181
1182
            }
1183
1184
            $pre_value = $field->get_value_submission( array(), false );
1185
1186
            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1187
1188
        } else {
1189
1190 3
            $id = intval( $field->id );
1191
1192
            // get pre-populated value if exists
1193 3
            $pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1194
1195
            // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1196
            // or pre-populated value if not empty and set to override saved value
1197 3
            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1198
1199
            // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1200 3
            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1201
                $categories = array();
1202
                foreach ( explode( ',', $field_value ) as $cat_string ) {
1203
                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1204
                }
1205
                $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1206
            }
1207
1208
        }
1209
1210
        // if value is empty get the default value if defined
1211 3
        $field_value = $field->get_value_default_if_empty( $field_value );
1212
1213
	    /**
1214
	     * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1215
	     * @since 1.11
1216
	     * @since 1.20 Added third param
1217
	     * @param mixed $field_value field value used to populate the input
1218
	     * @param object $field Gravity Forms field object ( Class GF_Field )
1219
	     * @param GravityView_Edit_Entry_Render $this Current object
1220
	     */
1221 3
	    $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1222
1223
	    /**
1224
	     * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1225
	     * @since 1.17
1226
	     * @since 1.20 Added third param
1227
	     * @param mixed $field_value field value used to populate the input
1228
	     * @param GF_Field $field Gravity Forms field object
1229
	     * @param GravityView_Edit_Entry_Render $this Current object
1230
	     */
1231 3
	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1232
1233 3
        return $field_value;
1234
    }
1235
1236
1237
    // ---- Entry validation
1238
1239
    /**
1240
     * Add field keys that Gravity Forms expects.
1241
     *
1242
     * @see GFFormDisplay::validate()
1243
     * @param  array $form GF Form
1244
     * @return array       Modified GF Form
1245
     */
1246 3
    public function gform_pre_validation( $form ) {
1247
1248 3
        if( ! $this->verify_nonce() ) {
1249
            return $form;
1250
        }
1251
1252
        // Fix PHP warning regarding undefined index.
1253 3
        foreach ( $form['fields'] as &$field) {
0 ignored issues
show
introduced by
No space before closing parenthesis is prohibited
Loading history...
1254
1255
            // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1256
            // expects certain field array items to be set.
1257 3
            foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1258 3
	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1259
            }
1260
1261 3
            switch( RGFormsModel::get_input_type( $field ) ) {
1262
1263
                /**
1264
                 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1265
                 *
1266
                 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1267
                 *
1268
                 * @hack
1269
                 */
1270 3
                case 'fileupload':
1271
1272
                    // Set the previous value
1273 1
                    $entry = $this->get_entry();
1274
1275 1
                    $input_name = 'input_'.$field->id;
1276 1
                    $form_id = $form['id'];
1277
1278 1
                    $value = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1279
1280
                    // Use the previous entry value as the default.
1281 1
                    if( isset( $entry[ $field->id ] ) ) {
1282 1
                        $value = $entry[ $field->id ];
1283
                    }
1284
1285
                    // If this is a single upload file
1286 1
                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1287 1
                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1288 1
                        $value = $file_path['url'];
1289
1290
                    } else {
1291
1292
                        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1293
                        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1294 1
                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
0 ignored issues
show
introduced by
No space after opening parenthesis of array is bad style
Loading history...
1295
1296
                    }
1297
1298 1
                    if( rgar($field, "multipleFiles") ) {
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
Coding Style Comprehensibility introduced by
The string literal multipleFiles does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
1299
1300
                        // If there are fresh uploads, process and merge them.
1301
                        // Otherwise, use the passed values, which should be json-encoded array of URLs
1302 1
                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
0 ignored issues
show
introduced by
Array keys should be surrounded by spaces unless they contain a string or an integer.
Loading history...
1303
                            $value = empty( $value ) ? '[]' : $value;
1304
                            $value = stripslashes_deep( $value );
1305 1
                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1306
                        }
1307
1308
                    } else {
1309
1310
                        // A file already exists when editing an entry
1311
                        // We set this to solve issue when file upload fields are required.
1312 1
                        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1313
1314
                    }
1315
1316 1
                    $this->entry[ $input_name ] = $value;
1317 1
                    $_POST[ $input_name ] = $value;
1318
1319 1
                    break;
1320
1321 3
                case 'number':
1322
                    // Fix "undefined index" issue at line 1286 in form_display.php
1323 1
                    if( !isset( $_POST['input_'.$field->id ] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
introduced by
Array keys should be surrounded by spaces unless they contain a string or an integer.
Loading history...
1324
                        $_POST['input_'.$field->id ] = NULL;
0 ignored issues
show
introduced by
Array keys should be surrounded by spaces unless they contain a string or an integer.
Loading history...
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1325
                    }
1326 3
                    break;
1327
            }
1328
1329
        }
1330
1331 3
        return $form;
1332
    }
1333
1334
1335
    /**
1336
     * Process validation for a edit entry submission
1337
     *
1338
     * Sets the `is_valid` object var
1339
     *
1340
     * @return void
1341
     */
1342 4
    private function validate() {
1343
1344
        /**
1345
         * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1346
         * GF User Registration Add-on version > 3.x has a different class name
1347
         * @since 1.16.2
1348
         */
1349 4
        if ( class_exists( 'GF_User_Registration' ) ) {
1350 4
            remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1351
        } else  if ( class_exists( 'GFUser' ) ) {
1352
            remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1353
        }
1354
0 ignored issues
show
Coding Style introduced by
Functions must not contain multiple empty lines in a row; found 2 empty lines
Loading history...
1355
1356
        /**
1357
         * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1358
         * You can enter whatever you want!
1359
         * We try validating, and customize the results using `self::custom_validation()`
1360
         */
1361 4
        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1362
1363
        // Needed by the validate funtion
1364 4
        $failed_validation_page = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1365 4
        $field_values = RGForms::post( 'gform_field_values' );
1366
1367
        // Prevent entry limit from running when editing an entry, also
1368
        // prevent form scheduling from preventing editing
1369 4
        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1370
1371
        // Hide fields depending on Edit Entry settings
1372 4
        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1373
1374 4
        $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1375
1376 4
        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1377 4
    }
1378
1379
1380
    /**
1381
     * Make validation work for Edit Entry
1382
     *
1383
     * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1384
     * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1385
     * fields. This goes through all the fields and if they're an invalid post field, we
1386
     * set them as valid. If there are still issues, we'll return false.
1387
     *
1388
     * @param  [type] $validation_results [description]
0 ignored issues
show
Documentation introduced by
The doc-type [type] could not be parsed: Unknown type name "" at position 0. [(view supported doc-types)

This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.

Loading history...
1389
     * @return [type]                     [description]
0 ignored issues
show
Documentation introduced by
The doc-type [type] could not be parsed: Unknown type name "" at position 0. [(view supported doc-types)

This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.

Loading history...
1390
     */
1391 4
    public function custom_validation( $validation_results ) {
1392
1393 4
        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1394
1395 4
        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
introduced by
The use of function print_r() is discouraged
Loading history...
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
1396
1397 4
        $gv_valid = true;
1398
1399 4
        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1400
1401 4
            $value = RGFormsModel::get_field_value( $field );
1402 4
            $field_type = RGFormsModel::get_input_type( $field );
1403
1404
            // Validate always
1405
            switch ( $field_type ) {
1406
0 ignored issues
show
Coding Style introduced by
Functions must not contain multiple empty lines in a row; found 2 empty lines
Loading history...
1407
1408 4
                case 'fileupload' :
1409 4
                case 'post_image':
1410
1411
                    // in case nothing is uploaded but there are already files saved
1412 2
                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1413
                        $field->failed_validation = false;
1414
                        unset( $field->validation_message );
1415
                    }
1416
1417
                    // validate if multi file upload reached max number of files [maxFiles] => 2
1418 2
                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1419
1420
                        $input_name = 'input_' . $field->id;
1421
                        //uploaded
1422
                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1423
1424
                        //existent
1425
                        $entry = $this->get_entry();
1426
                        $value = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1427
                        if( isset( $entry[ $field->id ] ) ) {
1428
                            $value = json_decode( $entry[ $field->id ], true );
1429
                        }
1430
1431
                        // count uploaded files and existent entry files
1432
                        $count_files = count( $file_names ) + count( $value );
1433
1434
                        if( $count_files > $field->maxFiles ) {
1435
                            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1436
                            $field->failed_validation = 1;
1437
                            $gv_valid = false;
1438
1439
                            // in case of error make sure the newest upload files are removed from the upload input
1440
                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1441
                        }
1442
1443
                    }
1444
0 ignored issues
show
Coding Style introduced by
Functions must not contain multiple empty lines in a row; found 2 empty lines
Loading history...
1445
1446 2
                    break;
1447
1448
            }
1449
1450
            // This field has failed validation.
1451 4
            if( !empty( $field->failed_validation ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1452
1453 1
                do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1454
1455
                switch ( $field_type ) {
1456
1457
                    // Captchas don't need to be re-entered.
1458 1
                    case 'captcha':
1459
1460
                        // Post Image fields aren't editable, so we un-fail them.
1461 1
                    case 'post_image':
1462
                        $field->failed_validation = false;
1463
                        unset( $field->validation_message );
1464
                        break;
1465
1466
                }
1467
1468
                // You can't continue inside a switch, so we do it after.
1469 1
                if( empty( $field->failed_validation ) ) {
1470
                    continue;
1471
                }
1472
1473
                // checks if the No Duplicates option is not validating entry against itself, since
1474
                // we're editing a stored entry, it would also assume it's a duplicate.
1475 1
                if( !empty( $field->noDuplicates ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1476
1477
                    $entry = $this->get_entry();
1478
1479
                    // If the value of the entry is the same as the stored value
1480
                    // Then we can assume it's not a duplicate, it's the same.
1481
                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1482
                        //if value submitted was not changed, then don't validate
1483
                        $field->failed_validation = false;
1484
1485
                        unset( $field->validation_message );
1486
1487
                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1488
1489
                        continue;
1490
                    }
1491
                }
1492
1493
                // if here then probably we are facing the validation 'At least one field must be filled out'
1494 1
                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 2 found
Loading history...
1495
                    unset( $field->validation_message );
1496
	                $field->validation_message = false;
1497
                    continue;
1498
                }
1499
1500 4
                $gv_valid = false;
1501
1502
            }
1503
1504
        }
1505
1506 4
        $validation_results['is_valid'] = $gv_valid;
1507
1508 4
        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1509
1510
        // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1511 4
        $this->form_after_validation = $validation_results['form'];
1512
1513 4
        return $validation_results;
1514
    }
1515
1516
1517
    /**
1518
     * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1519
     * Get the current entry and set it if it's not yet set.
1520
     * @return array Gravity Forms entry array
1521
     */
1522 1
    public function get_entry() {
1523
1524 1
        if( empty( $this->entry ) ) {
1525
            // Get the database value of the entry that's being edited
1526 1
            $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1527
        }
1528
1529 1
        return $this->entry;
1530
    }
1531
1532
1533
1534
    // --- Filters
1535
1536
    /**
1537
     * Get the Edit Entry fields as configured in the View
1538
     *
1539
     * @since 1.8
1540
     *
1541
     * @param int $view_id
1542
     *
1543
     * @return array Array of fields that are configured in the Edit tab in the Admin
1544
     */
1545 4
    private function get_configured_edit_fields( $form, $view_id ) {
1546
1547
        // Get all fields for form
1548 4
		if ( defined( 'GRAVITYVIEW_FUTURE_CORE_LOADED' ) ) {
1549 4
			if ( \GV\View::exists( $view_id ) ) {
1550 4
				$view = \GV\View::by_id( $view_id );
1551 4
				$properties = $view->fields->as_configuration();
1552
			}
1553
		} else {
1554
			/** GravityView_View_Data is deprecated. */
1555
			$properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
0 ignored issues
show
Deprecated Code introduced by
The method GravityView_View_Data::get_fields() has been deprecated.

This method has been deprecated.

Loading history...
1556
		}
1557
1558
        // If edit tab not yet configured, show all fields
1559 4
        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1560
1561
        // Hide fields depending on admin settings
1562 4
        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1563
1564
	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1565 4
	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1566
1567
        /**
1568
         * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
1569
         * @since 1.17
1570
         * @param GF_Field[] $fields Gravity Forms form fields
1571
         * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1572
         * @param array $form GF Form array (`fields` key modified to have only fields configured to show in Edit Entry)
1573
         * @param int $view_id View ID
1574
         */
1575 4
        $fields = apply_filters( 'gravityview/edit_entry/form_fields', $fields, $edit_fields, $form, $view_id );
1576
1577 4
        return $fields;
1578
    }
1579
1580
1581
    /**
1582
     * Filter area fields based on specified conditions
1583
     *  - This filter removes the fields that have calculation configured
1584
     *
1585
     * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1586
     * @access private
1587
     * @param GF_Field[] $fields
1588
     * @param array $configured_fields
1589
     * @since  1.5
1590
     * @return array $fields
1591
     */
1592 3
    private function filter_fields( $fields, $configured_fields ) {
1593
1594 3
        if( empty( $fields ) || !is_array( $fields ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1595
            return $fields;
1596
        }
1597
1598 3
        $edit_fields = array();
1599
1600 3
        $field_type_blacklist = $this->loader->get_field_blacklist( $this->entry );
1601
1602
        // First, remove blacklist or calculation fields
1603 3
        foreach ( $fields as $key => $field ) {
1604
1605
            // Remove the fields that have calculation properties and keep them to be used later
1606
            // @since 1.16.2
1607 3
            if( $field->has_calculation() ) {
1608
                $this->fields_with_calculation[] = $field;
1609
                // don't remove the calculation fields on form render.
1610
            }
1611
1612 3
            if( in_array( $field->type, $field_type_blacklist ) ) {
1613 3
                unset( $fields[ $key ] );
1614
            }
1615
        }
1616
1617
        // The Edit tab has not been configured, so we return all fields by default.
1618 3
        if( empty( $configured_fields ) ) {
1619 3
            return $fields;
1620
        }
1621
1622
        // The edit tab has been configured, so we loop through to configured settings
1623
        foreach ( $configured_fields as $configured_field ) {
1624
1625
	        /** @var GF_Field $field */
1626
	        foreach ( $fields as $field ) {
1627
1628
                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1629
                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1630
                    break;
1631
                }
1632
1633
            }
1634
1635
        }
1636
1637
        return $edit_fields;
1638
1639
    }
1640
1641
    /**
1642
     * Override GF Form field properties with the ones defined on the View
1643
     * @param  GF_Field $field GF Form field object
1644
     * @param  array $field_setting  GV field options
1645
     * @since  1.5
1646
     * @return array|GF_Field
1647
     */
1648
    private function merge_field_properties( $field, $field_setting ) {
1649
1650
        $return_field = $field;
1651
1652
        if( empty( $field_setting['show_label'] ) ) {
1653
            $return_field->label = '';
1654
        } elseif ( !empty( $field_setting['custom_label'] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1655
            $return_field->label = $field_setting['custom_label'];
1656
        }
1657
1658
        if( !empty( $field_setting['custom_class'] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1659
            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1660
        }
1661
1662
        /**
1663
         * Normalize page numbers - avoid conflicts with page validation
1664
         * @since 1.6
1665
         */
1666
        $return_field->pageNumber = 1;
1667
1668
        return $return_field;
1669
1670
    }
1671
1672
    /**
1673
     * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1674
     *
1675
     * @since 1.9.1
1676
     *
1677
     * @param array|GF_Field[] $fields Gravity Forms form fields
1678
     * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1679
     * @param array $form GF Form array
1680
     * @param int $view_id View ID
1681
     *
1682
     * @return array Possibly modified form array
1683
     */
1684 3
    private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1685
1686
	    /**
1687
         * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1688
	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1689
	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1690
	     * @since 1.9.1
1691
	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1692
	     * @param array $form GF Form array
1693
	     * @param int $view_id View ID
1694
	     */
1695 3
	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1696
1697 3
	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1698
            foreach( $fields as $k => $field ) {
1699
                if( $field->adminOnly ) {
1700
                    unset( $fields[ $k ] );
1701
                }
1702
            }
1703
            return $fields;
1704
        }
1705
1706 3
	    foreach( $fields as &$field ) {
1707 3
		    $field->adminOnly = false;
1708
        }
1709
1710 3
        return $fields;
1711
    }
1712
1713
    // --- Conditional Logic
1714
1715
    /**
1716
     * Conditional logic isn't designed to work with forms that already have content. When switching input values,
1717
     * the dependent fields will be blank.
1718
     *
1719
     * Note: This is because GF populates a JavaScript variable with the input values. This is tough to filter at the input level;
1720
     * via the `gform_field_value` filter; it requires lots of legwork. Doing it at the form level is easier.
1721
     *
1722
     * @since 1.17.4
1723
     *
1724
     * @param array $form Gravity Forms array object
1725
     *
1726
     * @return array $form, modified to fix conditional
1727
     */
1728 3
    function prefill_conditional_logic( $form ) {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
1729
1730 3
        if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1731 3
            return $form;
1732
        }
1733
1734
        // Have Conditional Logic pre-fill fields as if the data were default values
1735
        /** @var GF_Field $field */
1736
        foreach ( $form['fields'] as &$field ) {
1737
1738
            if( 'checkbox' === $field->type ) {
1739
                foreach ( $field->get_entry_inputs() as $key => $input ) {
1740
                    $input_id = $input['id'];
1741
                    $choice = $field->choices[ $key ];
1742
                    $value = rgar( $this->entry, $input_id );
1743
                    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1744
                    if( $match ) {
1745
                        $field->choices[ $key ]['isSelected'] = true;
1746
                    }
1747
                }
1748
            } else {
1749
1750
                // We need to run through each field to set the default values
1751
                foreach ( $this->entry as $field_id => $field_value ) {
1752
1753
                    if( floatval( $field_id ) === floatval( $field->id ) ) {
1754
1755
                        if( 'list' === $field->type ) {
1756
                            $list_rows = maybe_unserialize( $field_value );
1757
1758
                            $list_field_value = array();
1759
                            foreach ( (array) $list_rows as $row ) {
1760
                                foreach ( (array) $row as $column ) {
1761
                                    $list_field_value[] = $column;
1762
                                }
1763
                            }
1764
1765
                            $field->defaultValue = serialize( $list_field_value );
1766
                        } else {
1767
                            $field->defaultValue = $field_value;
1768
                        }
1769
                    }
1770
                }
1771
            }
1772
        }
1773
1774
        return $form;
1775
    }
1776
1777
    /**
1778
     * Remove the conditional logic rules from the form button and the form fields, if needed.
1779
     *
1780
     * @todo Merge with caller method
1781
     * @since 1.9
1782
     *
1783
     * @param array $form Gravity Forms form
1784
     * @return array Modified form, if not using Conditional Logic
1785
     */
1786 3
    private function filter_conditional_logic( $form ) {
1787
1788
        /**
1789
         * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1790
         * @since 1.9
1791
         * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1792
         * @param array $form Gravity Forms form
1793
         */
1794 3
        $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1795
1796 3
        if( $use_conditional_logic ) {
1797 3
            return $form;
1798
        }
1799
1800
        foreach( $form['fields'] as &$field ) {
1801
            /* @var GF_Field $field */
1802
            $field->conditionalLogic = null;
1803
        }
1804
1805
        unset( $form['button']['conditionalLogic'] );
1806
1807
        return $form;
1808
1809
    }
1810
1811
    /**
1812
     * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1813
     *
1814
     * @since 1.9
1815
     *
1816
     * @param $has_conditional_logic
1817
     * @param $form
1818
     * @return mixed
1819
     */
1820 3
    public function manage_conditional_logic( $has_conditional_logic, $form ) {
1821
1822 3
        if( ! $this->is_edit_entry() ) {
1823
            return $has_conditional_logic;
1824
        }
1825
1826
	    /** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
1827 3
        return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1828
    }
1829
1830
1831
    // --- User checks and nonces
1832
1833
    /**
1834
     * Check if the user can edit the entry
1835
     *
1836
     * - Is the nonce valid?
1837
     * - Does the user have the right caps for the entry
1838
     * - Is the entry in the trash?
1839
     *
1840
     * @todo Move to GVCommon
1841
     *
1842
     * @param  boolean $echo Show error messages in the form?
1843
     * @return boolean        True: can edit form. False: nope.
1844
     */
1845 4
    private function user_can_edit_entry( $echo = false ) {
1846
1847 4
        $error = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1848
1849
        /**
1850
         *  1. Permalinks are turned off
1851
         *  2. There are two entries embedded using oEmbed
1852
         *  3. One of the entries has just been saved
1853
         */
1854 4
        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
1855
1856
            $error = true;
1857
1858
        }
1859
1860 4
        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
0 ignored issues
show
introduced by
Expected 1 space after "!"; 0 found
Loading history...
introduced by
No space after closing casting parenthesis is prohibited
Loading history...
1861
1862
            $error = true;
1863
1864 4
        } elseif( ! $this->verify_nonce() ) {
1865
1866
            /**
1867
             * If the Entry is embedded, there may be two entries on the same page.
1868
             * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1869
             */
1870
            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression \GravityView_oEmbed::get...tance()->get_entry_id() of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
1871
                $error = true;
1872
            } else {
1873
                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1874
            }
1875
1876
        }
1877
1878 4
        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1879 1
            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1880
        }
1881
1882 4
        if( $this->entry['status'] === 'trash' ) {
0 ignored issues
show
introduced by
Found "=== '". Use Yoda Condition checks, you must
Loading history...
1883
            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1884
        }
1885
1886
        // No errors; everything's fine here!
1887 4
        if( empty( $error ) ) {
1888 4
            return true;
1889
        }
1890
1891 1
        if( $echo && $error !== true ) {
0 ignored issues
show
introduced by
Found "!== true". Use Yoda Condition checks, you must
Loading history...
1892
1893 1
	        $error = esc_html( $error );
1894
1895
	        /**
1896
	         * @since 1.9
1897
	         */
1898 1
	        if ( ! empty( $this->entry ) ) {
1899 1
		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
Coding Style Comprehensibility introduced by
The string literal window.history.go(-1); return false; does not require double quotes, as per coding-style, please use single quotes.

PHP provides two ways to mark string literals. Either with single quotes 'literal' or with double quotes "literal". The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences.

String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (\') and the backslash (\\). Every other character is displayed as is.

Double quoted string literals may contain other variables or more complex escape sequences.

<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

will print an indented: Single is Value

If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear.

For more information on PHP string literals and available escape sequences see the PHP core documentation.

Loading history...
1900
	        }
1901
1902 1
            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'GVCommon'
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1903
        }
1904
1905 1
        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1906
1907 1
        return false;
1908
    }
1909
1910
1911
    /**
1912
     * Check whether a field is editable by the current user, and optionally display an error message
1913
     * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1914
     * @param  array  $field Field or field settings array
1915
     * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1916
     * @return boolean         True: user can edit the current field; False: nope, they can't.
1917
     */
1918
    private function user_can_edit_field( $field, $echo = false ) {
1919
1920
        $error = NULL;
0 ignored issues
show
Coding Style introduced by
TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.
Loading history...
1921
1922
        if( ! $this->check_user_cap_edit_field( $field ) ) {
1923
            $error = __( 'You do not have permission to edit this field.', 'gravityview');
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1924
        }
1925
1926
        // No errors; everything's fine here!
1927
        if( empty( $error ) ) {
1928
            return true;
1929
        }
1930
1931
        if( $echo ) {
1932
            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
0 ignored issues
show
introduced by
Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'GVCommon'
Loading history...
Coding Style introduced by
Expected 1 spaces before closing bracket; 0 found
Loading history...
1933
        }
1934
1935
        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
0 ignored issues
show
Coding Style introduced by
Expected 1 spaces after opening bracket; 0 found
Loading history...
1936
1937
        return false;
1938
1939
    }
1940
1941
1942
    /**
1943
     * checks if user has permissions to edit a specific field
1944
     *
1945
     * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1946
     *
1947
     * @param  [type] $field [description]
0 ignored issues
show
Documentation introduced by
The doc-type [type] could not be parsed: Unknown type name "" at position 0. [(view supported doc-types)

This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.

Loading history...
1948
     * @return bool
1949
     */
1950
    private function check_user_cap_edit_field( $field ) {
1951
1952
        // If they can edit any entries (as defined in Gravity Forms), we're good.
1953
        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1954
            return true;
1955
        }
1956
1957
        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1958
1959
        // If the field has custom editing capaibilities set, check those
1960
        if( $field_cap ) {
1961
            return GVCommon::has_cap( $field['allow_edit_cap'] );
1962
        }
1963
1964
        return false;
1965
    }
1966
1967
1968
    /**
1969
     * Is the current nonce valid for editing the entry?
1970
     * @return boolean
1971
     */
1972 3
    public function verify_nonce() {
1973
1974
        // Verify form submitted for editing single
1975 3
        if( $this->is_edit_entry_submission() ) {
1976
            $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
0 ignored issues
show
introduced by
Detected access of super global var $_POST, probably need manual inspection.
Loading history...
introduced by
Detected usage of a non-validated input variable: $_POST
Loading history...
introduced by
Detected usage of a non-sanitized input variable: $_POST
Loading history...
1977
        }
1978
1979
        // Verify
1980 3
        else if( ! $this->is_edit_entry() ) {
1981
            $valid = false;
1982
        }
1983
1984
        else {
1985 3
            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
0 ignored issues
show
introduced by
Detected access of super global var $_GET, probably need manual inspection.
Loading history...
introduced by
Detected usage of a non-validated input variable: $_GET
Loading history...
introduced by
Detected usage of a non-sanitized input variable: $_GET
Loading history...
1986
        }
1987
1988
        /**
1989
         * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1990
         * @since 1.13
1991
         * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1992
         * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1993
         */
1994 3
        $valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1995
1996 3
        return $valid;
1997
    }
1998
1999
2000
	/**
2001
	 * Multiselect in GF 2.2 became a json_encoded value. Fix it.
2002
	 *
2003
	 * As a hack for now we'll implode it back.
2004
	 */
2005
	public function fix_multiselect_value_serialization( $field_value, $field, $_this ) {
0 ignored issues
show
Unused Code introduced by
The parameter $_this is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
2006
		if ( empty ( $field->storageType ) || $field->storageType != 'json' ) {
0 ignored issues
show
introduced by
Found "!= '". Use Yoda Condition checks, you must
Loading history...
Coding Style introduced by
Space before opening parenthesis of function call prohibited
Loading history...
2007
			return $field_value;
2008
		}
2009
2010
		$maybe_json = @json_decode( $field_value, true );
0 ignored issues
show
Coding Style introduced by
Silencing errors is discouraged
Loading history...
2011
2012
		if ( $maybe_json ) {
2013
			return implode( ',', $maybe_json );
2014
		}
2015
2016
		return $field_value;
2017
	}
2018
2019
2020
2021
} //end class
2022