Completed
Pull Request — develop (#1303)
by Zack
42:06 queued 25:42
created
includes/admin/metaboxes/views/sort-filter.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -28,18 +28,18 @@
 block discarded – undo
28 28
 
29 29
 	$sort_fields_input = '<select name="template_settings[sort_field][]" class="gravityview_sort_field" id="gravityview_sort_field_%d">%s</select>';
30 30
 
31
-	if ( is_array( $current_settings['sort_field'] ) ) {
32
-		$primary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings['sort_field'][0] );
33
-		$secondary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings['sort_field'][1] );
31
+	if ( is_array( $current_settings[ 'sort_field' ] ) ) {
32
+		$primary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings[ 'sort_field' ][ 0 ] );
33
+		$secondary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings[ 'sort_field' ][ 1 ] );
34 34
 	} else {
35
-		$primary_sort_fields = $secondary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings['sort_field'] );
35
+		$primary_sort_fields = $secondary_sort_fields = gravityview_get_sortable_fields( $curr_form, $current_settings[ 'sort_field' ] );
36 36
 	}
37 37
 
38 38
 	// Splice the sort direction
39 39
 	$_directions = array();
40 40
 	foreach ( (array)\GV\Utils::get( $current_settings, 'sort_direction', array() ) as $i => $direction ) {
41 41
 		if ( ! $i ) {
42
-			$_directions['sort_direction'] = $direction;
42
+			$_directions[ 'sort_direction' ] = $direction;
43 43
 		} else {
44 44
 			$_directions[ sprintf( 'sort_direction_%d', $i + 1 ) ] = $direction;
45 45
 		}
Please login to merge, or discard this patch.
includes/class-frontend-views.php 1 patch
Spacing   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 	private function __construct() {}
86 86
 
87 87
 	private function initialize() {
88
-		add_action( 'wp', array( $this, 'parse_content'), 11 );
88
+		add_action( 'wp', array( $this, 'parse_content' ), 11 );
89 89
 		add_filter( 'parse_query', array( $this, 'parse_query_fix_frontpage' ), 10 );
90
-		add_action( 'template_redirect', array( $this, 'set_entry_data'), 1 );
90
+		add_action( 'template_redirect', array( $this, 'set_entry_data' ), 1 );
91 91
 
92 92
 		// Enqueue scripts and styles after GravityView_Template::register_styles()
93 93
 		add_action( 'wp_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 20 );
@@ -236,12 +236,12 @@  discard block
 block discarded – undo
236 236
 
237 237
 			$this->context_view_id = $view_id;
238 238
 
239
-		} elseif ( isset( $_GET['gvid'] ) && $multiple_views ) {
239
+		} elseif ( isset( $_GET[ 'gvid' ] ) && $multiple_views ) {
240 240
 			/**
241 241
 			 * used on a has_multiple_views context
242 242
 			 * @see GravityView_API::entry_link
243 243
 			 */
244
-			$this->context_view_id = $_GET['gvid'];
244
+			$this->context_view_id = $_GET[ 'gvid' ];
245 245
 
246 246
 		} elseif ( ! $multiple_views ) {
247 247
 			$array_keys = array_keys( $this->getGvOutputData()->get_views() );
@@ -278,25 +278,25 @@  discard block
 block discarded – undo
278 278
 		global $wp_rewrite;
279 279
 
280 280
 		$is_front_page = ( $query->is_home || $query->is_page );
281
-		$show_on_front = ( 'page' === get_option('show_on_front') );
282
-		$front_page_id = get_option('page_on_front');
281
+		$show_on_front = ( 'page' === get_option( 'show_on_front' ) );
282
+		$front_page_id = get_option( 'page_on_front' );
283 283
 
284
-		if (  $is_front_page && $show_on_front && $front_page_id ) {
284
+		if ( $is_front_page && $show_on_front && $front_page_id ) {
285 285
 
286 286
 			// Force to be an array, potentially a query string ( entry=16 )
287 287
 			$_query = wp_parse_args( $query->query );
288 288
 
289 289
 			// pagename can be set and empty depending on matched rewrite rules. Ignore an empty pagename.
290
-			if ( isset( $_query['pagename'] ) && '' === $_query['pagename'] ) {
291
-				unset( $_query['pagename'] );
290
+			if ( isset( $_query[ 'pagename' ] ) && '' === $_query[ 'pagename' ] ) {
291
+				unset( $_query[ 'pagename' ] );
292 292
 			}
293 293
 
294 294
 			// this is where will break from core wordpress
295 295
 			/** @internal Don't use this filter; it will be unnecessary soon - it's just a patch for specific use case */
296 296
 			$ignore = apply_filters( 'gravityview/internal/ignored_endpoints', array( 'preview', 'page', 'paged', 'cpage' ), $query );
297 297
 			$endpoints = \GV\Utils::get( $wp_rewrite, 'endpoints' );
298
-			foreach ( (array) $endpoints as $endpoint ) {
299
-				$ignore[] = $endpoint[1];
298
+			foreach ( (array)$endpoints as $endpoint ) {
299
+				$ignore[ ] = $endpoint[ 1 ];
300 300
 			}
301 301
 			unset( $endpoints );
302 302
 
@@ -306,21 +306,21 @@  discard block
 block discarded – undo
306 306
 			// - The query includes keys that are associated with registered endpoints. `entry`, for example.
307 307
 			if ( empty( $_query ) || ! array_diff( array_keys( $_query ), $ignore ) ) {
308 308
 
309
-				$qv =& $query->query_vars;
309
+				$qv = & $query->query_vars;
310 310
 
311 311
 				// Prevent redirect when on the single entry endpoint
312
-				if( self::is_single_entry() ) {
312
+				if ( self::is_single_entry() ) {
313 313
 					add_filter( 'redirect_canonical', '__return_false' );
314 314
 				}
315 315
 
316 316
 				$query->is_page = true;
317 317
 				$query->is_home = false;
318
-				$qv['page_id']  = $front_page_id;
318
+				$qv[ 'page_id' ]  = $front_page_id;
319 319
 
320 320
 				// Correct <!--nextpage--> for page_on_front
321
-				if ( ! empty( $qv['paged'] ) ) {
322
-					$qv['page'] = $qv['paged'];
323
-					unset( $qv['paged'] );
321
+				if ( ! empty( $qv[ 'paged' ] ) ) {
322
+					$qv[ 'page' ] = $qv[ 'paged' ];
323
+					unset( $qv[ 'paged' ] );
324 324
 				}
325 325
 			}
326 326
 
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
 		$this->setIsGravityviewPostType( get_post_type( $post ) === 'gravityview' );
352 352
 
353
-		$post_id = $this->getPostId() ? $this->getPostId() : (isset( $post ) ? $post->ID : null );
353
+		$post_id = $this->getPostId() ? $this->getPostId() : ( isset( $post ) ? $post->ID : null );
354 354
 		$this->setPostId( $post_id );
355 355
 		$post_has_shortcode = ! empty( $post->post_content ) ? gravityview_has_shortcode_r( $post->post_content, 'gravityview' ) : false;
356 356
 		$this->setPostHasShortcode( $this->isGravityviewPostType() ? null : ! empty( $post_has_shortcode ) );
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
 
387 387
 		$search_method = GravityView_Widget_Search::getInstance()->get_search_method();
388 388
 
389
-		if( 'post' === $search_method ) {
389
+		if ( 'post' === $search_method ) {
390 390
 			$get = $_POST;
391 391
 		} else {
392 392
 			$get = $_GET;
@@ -443,20 +443,20 @@  discard block
 block discarded – undo
443 443
 		 * @param boolean $in_the_loop Whether to apply the filter to the menu title and the meta tag <title> - outside the loop
444 444
 		 * @param array $entry Current entry
445 445
 		 */
446
-		$apply_outside_loop = apply_filters( 'gravityview/single/title/out_loop' , in_the_loop(), $entry );
446
+		$apply_outside_loop = apply_filters( 'gravityview/single/title/out_loop', in_the_loop(), $entry );
447 447
 
448 448
 		if ( ! $apply_outside_loop ) {
449 449
 			return $title;
450 450
 		}
451 451
 
452 452
 		// User reported WooCommerce doesn't pass two args.
453
-		if ( empty( $passed_post_id ) )  {
453
+		if ( empty( $passed_post_id ) ) {
454 454
 			return $title;
455 455
 		}
456 456
 
457 457
 		// Don't modify the title for anything other than the current view/post.
458 458
 		// This is true for embedded shortcodes and Views.
459
-		if ( is_object( $post ) && (int) $post->ID !== (int) $passed_post_id ) {
459
+		if ( is_object( $post ) && (int)$post->ID !== (int)$passed_post_id ) {
460 460
 			return $title;
461 461
 		}
462 462
 
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
 			$view_meta = $this->getGvOutputData()->get_view( $context_view_id );
469 469
 		} else {
470 470
 			foreach ( $this->getGvOutputData()->get_views() as $view_id => $view_data ) {
471
-				if ( intval( $view_data['form_id'] ) === intval( $entry['form_id'] ) ) {
471
+				if ( intval( $view_data[ 'form_id' ] ) === intval( $entry[ 'form_id' ] ) ) {
472 472
 					$view_meta = $view_data;
473 473
 					break;
474 474
 				}
@@ -476,12 +476,12 @@  discard block
 block discarded – undo
476 476
 		}
477 477
 
478 478
 		/** Deprecated stuff in the future. See the branch above. */
479
-		if ( ! empty( $view_meta['atts']['single_title'] ) ) {
479
+		if ( ! empty( $view_meta[ 'atts' ][ 'single_title' ] ) ) {
480 480
 
481
-			$title = $view_meta['atts']['single_title'];
481
+			$title = $view_meta[ 'atts' ][ 'single_title' ];
482 482
 
483 483
 			// We are allowing HTML in the fields, so no escaping the output
484
-			$title = GravityView_API::replace_variables( $title, $view_meta['form'], $entry );
484
+			$title = GravityView_API::replace_variables( $title, $view_meta[ 'form' ], $entry );
485 485
 
486 486
 			$title = do_shortcode( $title );
487 487
 		}
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 
553 553
 		$context = GravityView_View::getInstance()->getContext();
554 554
 
555
-		switch( $context ) {
555
+		switch ( $context ) {
556 556
 			case 'directory':
557 557
 				$tab = __( 'Multiple Entries', 'gravityview' );
558 558
 				break;
@@ -566,12 +566,12 @@  discard block
 block discarded – undo
566 566
 		}
567 567
 
568 568
 
569
-		$title = sprintf( esc_html_x('The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
569
+		$title = sprintf( esc_html_x( 'The %s layout has not been configured.', 'Displayed when a View is not configured. %s is replaced by the tab label', 'gravityview' ), $tab );
570 570
 		$edit_link = admin_url( sprintf( 'post.php?post=%d&action=edit#%s-view', $view_id, $context ) );
571
-		$action_text = sprintf( esc_html__('Add fields to %s', 'gravityview' ), $tab );
571
+		$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
572 572
 		$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
573 573
 
574
-		$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url(plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
574
+		$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
575 575
 		$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
576 576
 
577 577
 		echo GVCommon::generate_notice( $output . $image, 'gv-error error', 'edit_gravityview', $view_id );
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 		$direct_access = apply_filters( 'gravityview_direct_access', true, $view->ID );
620 620
 		$embed_only = $view->settings->get( 'embed_only' );
621 621
 
622
-		if( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
622
+		if ( ! $direct_access || ( $embed_only && ! GVCommon::has_cap( 'read_private_gravityviews' ) ) ) {
623 623
 			return __( 'You are not allowed to view this content.', 'gravityview' );
624 624
 		}
625 625
 
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
 				$datetime_format = 'Y-m-d H:i:s';
667 667
 				$search_is_outside_view_bounds = false;
668 668
 
669
-				if( ! empty( $search_criteria[ $key ] ) ) {
669
+				if ( ! empty( $search_criteria[ $key ] ) ) {
670 670
 
671 671
 					$search_date = strtotime( $search_criteria[ $key ] );
672 672
 
@@ -694,14 +694,14 @@  discard block
 block discarded – undo
694 694
 				if ( empty( $search_criteria[ $key ] ) || $search_is_outside_view_bounds ) {
695 695
 
696 696
 					// Then we override the search and re-set the start date
697
-					$return_search_criteria[ $key ] = date_i18n( $datetime_format , $date, true );
697
+					$return_search_criteria[ $key ] = date_i18n( $datetime_format, $date, true );
698 698
 				}
699 699
 			}
700 700
 		}
701 701
 
702
-		if( isset( $return_search_criteria['start_date'] ) && isset( $return_search_criteria['end_date'] ) ) {
702
+		if ( isset( $return_search_criteria[ 'start_date' ] ) && isset( $return_search_criteria[ 'end_date' ] ) ) {
703 703
 			// The start date is AFTER the end date. This will result in no results, but let's not force the issue.
704
-			if ( strtotime( $return_search_criteria['start_date'] ) > strtotime( $return_search_criteria['end_date'] ) ) {
704
+			if ( strtotime( $return_search_criteria[ 'start_date' ] ) > strtotime( $return_search_criteria[ 'end_date' ] ) ) {
705 705
 				gravityview()->log->error( 'Invalid search: the start date is after the end date.', array( 'data' => $return_search_criteria ) );
706 706
 			}
707 707
 		}
@@ -720,19 +720,19 @@  discard block
 block discarded – undo
720 720
 	public static function process_search_only_approved( $args, $search_criteria ) {
721 721
 
722 722
 		/** @since 1.19 */
723
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
723
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
724 724
 			gravityview()->log->debug( 'User can moderate entries; showing all approval statuses' );
725 725
 			return $search_criteria;
726 726
 		}
727 727
 
728
-		if ( ! empty( $args['show_only_approved'] ) ) {
728
+		if ( ! empty( $args[ 'show_only_approved' ] ) ) {
729 729
 
730
-			$search_criteria['field_filters'][] = array(
730
+			$search_criteria[ 'field_filters' ][ ] = array(
731 731
 				'key' => GravityView_Entry_Approval::meta_key,
732 732
 				'value' => GravityView_Entry_Approval_Status::APPROVED
733 733
 			);
734 734
 
735
-			$search_criteria['field_filters']['mode'] = 'all'; // force all the criterias to be met
735
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all'; // force all the criterias to be met
736 736
 
737 737
 			gravityview()->log->debug( '[process_search_only_approved] Search Criteria if show only approved: ', array( 'data' => $search_criteria ) );
738 738
 		}
@@ -759,18 +759,18 @@  discard block
 block discarded – undo
759 759
 	 */
760 760
 	public static function is_entry_approved( $entry, $args = array() ) {
761 761
 
762
-		if ( empty( $entry['id'] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args['show_only_approved'] ) ) {
762
+		if ( empty( $entry[ 'id' ] ) || ( array_key_exists( 'show_only_approved', $args ) && ! $args[ 'show_only_approved' ] ) ) {
763 763
 			// is implicitly approved if entry is null or View settings doesn't require to check for approval
764 764
 			return true;
765 765
 		}
766 766
 
767 767
 		/** @since 1.19 */
768
-		if( ! empty( $args['admin_show_all_statuses'] ) && GVCommon::has_cap('gravityview_moderate_entries') ) {
768
+		if ( ! empty( $args[ 'admin_show_all_statuses' ] ) && GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
769 769
 			gravityview()->log->debug( 'User can moderate entries, so entry is approved for viewing' );
770 770
 			return true;
771 771
 		}
772 772
 
773
-		$is_approved = gform_get_meta( $entry['id'], GravityView_Entry_Approval::meta_key );
773
+		$is_approved = gform_get_meta( $entry[ 'id' ], GravityView_Entry_Approval::meta_key );
774 774
 
775 775
 		return GravityView_Entry_Approval_Status::is_approved( $is_approved );
776 776
 	}
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 		 * Compatibility with filters hooking in `gravityview_search_criteria` instead of `gravityview_fe_search_criteria`.
795 795
 		 */
796 796
 		$criteria = apply_filters( 'gravityview_search_criteria', array(), array( $form_id ), \GV\Utils::get( $args, 'id' ) );
797
-		$search_criteria = isset( $criteria['search_criteria'] ) ? $criteria['search_criteria'] : array( 'field_filters' => array() );
797
+		$search_criteria = isset( $criteria[ 'search_criteria' ] ) ? $criteria[ 'search_criteria' ] : array( 'field_filters' => array() );
798 798
 
799 799
 		/**
800 800
 		 * @filter `gravityview_fe_search_criteria` Modify the search criteria
@@ -810,29 +810,29 @@  discard block
 block discarded – undo
810 810
 		gravityview()->log->debug( '[get_search_criteria] Search Criteria after hook gravityview_fe_search_criteria: ', array( 'data' =>$search_criteria ) );
811 811
 
812 812
 		// implicity search
813
-		if ( ! empty( $args['search_value'] ) ) {
813
+		if ( ! empty( $args[ 'search_value' ] ) ) {
814 814
 
815 815
 			// Search operator options. Options: `is` or `contains`
816
-			$operator = ! empty( $args['search_operator'] ) && in_array( $args['search_operator'], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args['search_operator'] : 'contains';
816
+			$operator = ! empty( $args[ 'search_operator' ] ) && in_array( $args[ 'search_operator' ], array( 'is', 'isnot', '>', '<', 'contains' ) ) ? $args[ 'search_operator' ] : 'contains';
817 817
 
818
-			$search_criteria['field_filters'][] = array(
818
+			$search_criteria[ 'field_filters' ][ ] = array(
819 819
 				'key' => \GV\Utils::_GET( 'search_field', \GV\Utils::get( $args, 'search_field' ) ), // The field ID to search
820
-				'value' => _wp_specialchars( $args['search_value'] ), // The value to search. Encode ampersands but not quotes.
820
+				'value' => _wp_specialchars( $args[ 'search_value' ] ), // The value to search. Encode ampersands but not quotes.
821 821
 				'operator' => $operator,
822 822
 			);
823 823
 
824 824
 			// Lock search mode to "all" with implicit presearch filter.
825
-			$search_criteria['field_filters']['mode'] = 'all';
825
+			$search_criteria[ 'field_filters' ][ 'mode' ] = 'all';
826 826
 		}
827 827
 
828
-		if( $search_criteria !== $original_search_criteria ) {
828
+		if ( $search_criteria !== $original_search_criteria ) {
829 829
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after implicity search: ', array( 'data' => $search_criteria ) );
830 830
 		}
831 831
 
832 832
 		// Handle setting date range
833 833
 		$search_criteria = self::process_search_dates( $args, $search_criteria );
834 834
 
835
-		if( $search_criteria !== $original_search_criteria ) {
835
+		if ( $search_criteria !== $original_search_criteria ) {
836 836
 			gravityview()->log->debug( '[get_search_criteria] Search Criteria after date params: ', array( 'data' => $search_criteria ) );
837 837
 		}
838 838
 
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
 		 * @filter `gravityview_status` Modify entry status requirements to be included in search results.
844 844
 		 * @param string $status Default: `active`. Accepts all Gravity Forms entry statuses, including `spam` and `trash`
845 845
 		 */
846
-		$search_criteria['status'] = apply_filters( 'gravityview_status', 'active', $args );
846
+		$search_criteria[ 'status' ] = apply_filters( 'gravityview_status', 'active', $args );
847 847
 
848 848
 		return $search_criteria;
849 849
 	}
@@ -956,7 +956,7 @@  discard block
 block discarded – undo
956 956
 			'search_criteria' => $search_criteria,
957 957
 			'sorting' => self::updateViewSorting( $args, $form_id ),
958 958
 			'paging' => $paging,
959
-			'cache' => isset( $args['cache'] ) ? $args['cache'] : true,
959
+			'cache' => isset( $args[ 'cache' ] ) ? $args[ 'cache' ] : true,
960 960
 		);
961 961
 
962 962
 		/**
@@ -981,7 +981,7 @@  discard block
 block discarded – undo
981 981
 		 * @param array $parameters Array with `search_criteria`, `sorting` and `paging` keys.
982 982
 		 * @param array $args View configuration args.
983 983
 		 */
984
-		$parameters = apply_filters( 'gravityview_get_entries_'.\GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
984
+		$parameters = apply_filters( 'gravityview_get_entries_' . \GV\Utils::get( $args, 'id' ), $parameters, $args, $form_id );
985 985
 
986 986
 		gravityview()->log->debug( '$parameters passed to gravityview_get_entries(): ', array( 'data' => $parameters ) );
987 987
 
@@ -1006,17 +1006,17 @@  discard block
 block discarded – undo
1006 1006
 		$default_page_size = apply_filters( 'gravityview_default_page_size', 25 );
1007 1007
 
1008 1008
 		// Paging & offset
1009
-		$page_size = ! empty( $args['page_size'] ) ? intval( $args['page_size'] ) : $default_page_size;
1009
+		$page_size = ! empty( $args[ 'page_size' ] ) ? intval( $args[ 'page_size' ] ) : $default_page_size;
1010 1010
 
1011 1011
 		if ( -1 === $page_size ) {
1012 1012
 			$page_size = PHP_INT_MAX;
1013 1013
 		}
1014 1014
 
1015
-		$curr_page = empty( $_GET['pagenum'] ) ? 1 : intval( $_GET['pagenum'] );
1015
+		$curr_page = empty( $_GET[ 'pagenum' ] ) ? 1 : intval( $_GET[ 'pagenum' ] );
1016 1016
 		$offset = ( $curr_page - 1 ) * $page_size;
1017 1017
 
1018
-		if ( ! empty( $args['offset'] ) ) {
1019
-			$offset += intval( $args['offset'] );
1018
+		if ( ! empty( $args[ 'offset' ] ) ) {
1019
+			$offset += intval( $args[ 'offset' ] );
1020 1020
 		}
1021 1021
 
1022 1022
 		$paging = array(
@@ -1040,8 +1040,8 @@  discard block
 block discarded – undo
1040 1040
 	 */
1041 1041
 	public static function updateViewSorting( $args, $form_id ) {
1042 1042
 		$sorting = array();
1043
-		$sort_field_id = isset( $_GET['sort'] ) ? $_GET['sort'] : \GV\Utils::get( $args, 'sort_field' );
1044
-		$sort_direction = isset( $_GET['dir'] ) ? $_GET['dir'] : \GV\Utils::get( $args, 'sort_direction' );
1043
+		$sort_field_id = isset( $_GET[ 'sort' ] ) ? $_GET[ 'sort' ] : \GV\Utils::get( $args, 'sort_field' );
1044
+		$sort_direction = isset( $_GET[ 'dir' ] ) ? $_GET[ 'dir' ] : \GV\Utils::get( $args, 'sort_direction' );
1045 1045
 
1046 1046
 		if ( ! empty( $sort_field_id ) ) {
1047 1047
 			if ( is_array( $sort_field_id ) ) {
@@ -1064,10 +1064,10 @@  discard block
 block discarded – undo
1064 1064
 				$form = GFAPI::get_form( $form_id );
1065 1065
 
1066 1066
 				// Get the first GF_Field field ID, set as the key for entry randomization
1067
-				if ( ! empty( $form['fields'] ) ) {
1067
+				if ( ! empty( $form[ 'fields' ] ) ) {
1068 1068
 
1069 1069
 					/** @var GF_Field $field */
1070
-					foreach ( $form['fields'] as $field ) {
1070
+					foreach ( $form[ 'fields' ] as $field ) {
1071 1071
 						if ( ! is_a( $field, 'GF_Field' ) ) {
1072 1072
 							continue;
1073 1073
 						}
@@ -1112,7 +1112,7 @@  discard block
 block discarded – undo
1112 1112
 		if ( is_array( $sort_field_id ) ) {
1113 1113
 			$modified_ids = array();
1114 1114
 			foreach ( $sort_field_id as $_sort_field_id ) {
1115
-				$modified_ids []= self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1115
+				$modified_ids [ ] = self::_override_sorting_id_by_field_type( $_sort_field_id, $form_id );
1116 1116
 			}
1117 1117
 			return $modified_ids;
1118 1118
 		}
@@ -1121,11 +1121,11 @@  discard block
 block discarded – undo
1121 1121
 
1122 1122
 		$sort_field = GFFormsModel::get_field( $form, $sort_field_id );
1123 1123
 
1124
-		if( ! $sort_field ) {
1124
+		if ( ! $sort_field ) {
1125 1125
 			return $sort_field_id;
1126 1126
 		}
1127 1127
 
1128
-		switch ( $sort_field['type'] ) {
1128
+		switch ( $sort_field[ 'type' ] ) {
1129 1129
 
1130 1130
 			case 'address':
1131 1131
 				// Sorting by full address
@@ -1142,7 +1142,7 @@  discard block
 block discarded – undo
1142 1142
 					 */
1143 1143
 					$address_part = apply_filters( 'gravityview/sorting/address', 'city', $sort_field_id, $form_id );
1144 1144
 
1145
-					switch( strtolower( $address_part ) ){
1145
+					switch ( strtolower( $address_part ) ) {
1146 1146
 						case 'street':
1147 1147
 							$sort_field_id .= '.1';
1148 1148
 							break;
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
 		 */
1223 1223
 		$single_entry = apply_filters( 'gravityview/is_single_entry', $single_entry );
1224 1224
 
1225
-		if ( empty( $single_entry ) ){
1225
+		if ( empty( $single_entry ) ) {
1226 1226
 			return false;
1227 1227
 		} else {
1228 1228
 			return $single_entry;
@@ -1244,7 +1244,7 @@  discard block
 block discarded – undo
1244 1244
 			$views = $this->getGvOutputData()->get_views();
1245 1245
 
1246 1246
 			foreach ( $views as $view_id => $data ) {
1247
-				$view = \GV\View::by_id( $data['id'] );
1247
+				$view = \GV\View::by_id( $data[ 'id' ] );
1248 1248
 				$view_id = $view->ID;
1249 1249
 				$template_id = gravityview_get_template_id( $view->ID );
1250 1250
 				$data = $view->as_data();
@@ -1253,7 +1253,7 @@  discard block
 block discarded – undo
1253 1253
 				 * Don't enqueue the scripts or styles if it's not going to be displayed.
1254 1254
 				 * @since 1.15
1255 1255
 				 */
1256
-				if( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1256
+				if ( is_user_logged_in() && false === GVCommon::has_cap( 'read_gravityview', $view_id ) ) {
1257 1257
 					continue;
1258 1258
 				}
1259 1259
 
@@ -1270,13 +1270,13 @@  discard block
 block discarded – undo
1270 1270
 					 * @filter `gravity_view_lightbox_script` Override the lightbox script to enqueue. Default: `thickbox`
1271 1271
 					 * @param string $script_slug If you want to use a different lightbox script, return the name of it here.
1272 1272
 					 */
1273
-					$js_dependencies[] = apply_filters( 'gravity_view_lightbox_script', 'thickbox' );
1273
+					$js_dependencies[ ] = apply_filters( 'gravity_view_lightbox_script', 'thickbox' );
1274 1274
 
1275 1275
 					/**
1276 1276
 					 * @filter `gravity_view_lightbox_style` Modify the lightbox CSS slug. Default: `thickbox`
1277 1277
 					 * @param string $script_slug If you want to use a different lightbox script, return the name of its CSS file here.
1278 1278
 					 */
1279
-					$css_dependencies[] = apply_filters( 'gravity_view_lightbox_style', 'thickbox' );
1279
+					$css_dependencies[ ] = apply_filters( 'gravity_view_lightbox_style', 'thickbox' );
1280 1280
 				}
1281 1281
 
1282 1282
 				/**
@@ -1284,19 +1284,19 @@  discard block
 block discarded – undo
1284 1284
 				 * @see https://github.com/katzwebservices/GravityView/issues/536
1285 1285
 				 * @since 1.15
1286 1286
 				 */
1287
-				if( gravityview_view_has_single_checkbox_or_radio( $data['form'], $data['fields'] ) ) {
1288
-					$css_dependencies[] = 'dashicons';
1287
+				if ( gravityview_view_has_single_checkbox_or_radio( $data[ 'form' ], $data[ 'fields' ] ) ) {
1288
+					$css_dependencies[ ] = 'dashicons';
1289 1289
 				}
1290 1290
 
1291 1291
 				wp_register_script( 'gravityview-jquery-cookie', plugins_url( 'assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version, true );
1292 1292
 
1293 1293
 				$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
1294 1294
 
1295
-				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ) , GravityView_Plugin::version, true );
1295
+				wp_register_script( 'gravityview-fe-view', plugins_url( 'assets/js/fe-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), apply_filters( 'gravityview_js_dependencies', $js_dependencies ), GravityView_Plugin::version, true );
1296 1296
 
1297 1297
 				wp_enqueue_script( 'gravityview-fe-view' );
1298 1298
 
1299
-				if ( ! empty( $data['atts']['sort_columns'] ) ) {
1299
+				if ( ! empty( $data[ 'atts' ][ 'sort_columns' ] ) ) {
1300 1300
 					wp_enqueue_style( 'gravityview_font', plugins_url( 'assets/css/font.css', GRAVITYVIEW_FILE ), $css_dependencies, GravityView_Plugin::version, 'all' );
1301 1301
 				}
1302 1302
 
@@ -1359,7 +1359,7 @@  discard block
 block discarded – undo
1359 1359
 	public static function add_style( $template_id ) {
1360 1360
 
1361 1361
 		if ( ! empty( $template_id ) && wp_style_is( 'gravityview_style_' . $template_id, 'registered' ) ) {
1362
-			gravityview()->log->debug(  'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1362
+			gravityview()->log->debug( 'Adding extra template style for {template_id}', array( 'template_id' => $template_id ) );
1363 1363
 			wp_enqueue_style( 'gravityview_style_' . $template_id );
1364 1364
 		} elseif ( empty( $template_id ) ) {
1365 1365
 			gravityview()->log->error( 'Cannot add template style; template_id is empty' );
@@ -1390,11 +1390,11 @@  discard block
 block discarded – undo
1390 1390
 		 * Not a table-based template; don't add sort icons
1391 1391
 		 * @since 1.12
1392 1392
 		 */
1393
-		if( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1393
+		if ( ! preg_match( '/table/ism', GravityView_View::getInstance()->getTemplatePartSlug() ) ) {
1394 1394
 			return $label;
1395 1395
 		}
1396 1396
 
1397
-		if ( ! $this->is_field_sortable( $field['id'], $form ) ) {
1397
+		if ( ! $this->is_field_sortable( $field[ 'id' ], $form ) ) {
1398 1398
 			return $label;
1399 1399
 		}
1400 1400
 
@@ -1402,29 +1402,29 @@  discard block
 block discarded – undo
1402 1402
 
1403 1403
 		$class = 'gv-sort';
1404 1404
 
1405
-		$sort_field_id = self::_override_sorting_id_by_field_type( $field['id'], $form['id'] );
1405
+		$sort_field_id = self::_override_sorting_id_by_field_type( $field[ 'id' ], $form[ 'id' ] );
1406 1406
 
1407 1407
 		$sort_args = array(
1408
-			'sort' => $field['id'],
1408
+			'sort' => $field[ 'id' ],
1409 1409
 			'dir' => 'asc',
1410 1410
 		);
1411 1411
 
1412
-		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
1412
+		if ( ! empty( $sorting[ 'key' ] ) && (string)$sort_field_id === (string)$sorting[ 'key' ] ) {
1413 1413
 			//toggle sorting direction.
1414
-			if ( 'asc' === $sorting['direction'] ) {
1415
-				$sort_args['dir'] = 'desc';
1414
+			if ( 'asc' === $sorting[ 'direction' ] ) {
1415
+				$sort_args[ 'dir' ] = 'desc';
1416 1416
 				$class .= ' gv-icon-sort-desc';
1417 1417
 			} else {
1418
-				$sort_args['dir'] = 'asc';
1418
+				$sort_args[ 'dir' ] = 'asc';
1419 1419
 				$class .= ' gv-icon-sort-asc';
1420 1420
 			}
1421 1421
 		} else {
1422 1422
 			$class .= ' gv-icon-caret-up-down';
1423 1423
 		}
1424 1424
 
1425
-		$url = add_query_arg( $sort_args, remove_query_arg( array('pagenum') ) );
1425
+		$url = add_query_arg( $sort_args, remove_query_arg( array( 'pagenum' ) ) );
1426 1426
 
1427
-		return '<a href="'. esc_url_raw( $url ) .'" class="'. $class .'" ></a>&nbsp;'. $label;
1427
+		return '<a href="' . esc_url_raw( $url ) . '" class="' . $class . '" ></a>&nbsp;' . $label;
1428 1428
 
1429 1429
 	}
1430 1430
 
@@ -1442,7 +1442,7 @@  discard block
 block discarded – undo
1442 1442
 
1443 1443
 		$field_type = $field_id;
1444 1444
 
1445
-		if( is_numeric( $field_id ) ) {
1445
+		if ( is_numeric( $field_id ) ) {
1446 1446
 			$field = GFFormsModel::get_field( $form, $field_id );
1447 1447
 			$field_type = $field ? $field->type : $field_id;
1448 1448
 		}
@@ -1465,7 +1465,7 @@  discard block
 block discarded – undo
1465 1465
 			return false;
1466 1466
 		}
1467 1467
 
1468
-		return apply_filters( "gravityview/sortable/formfield_{$form['id']}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1468
+		return apply_filters( "gravityview/sortable/formfield_{$form[ 'id' ]}_{$field_id}", apply_filters( "gravityview/sortable/field_{$field_id}", true, $form ) );
1469 1469
 
1470 1470
 	}
1471 1471
 
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +66 added lines, -67 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) { 
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -300,13 +300,13 @@  discard block
 block discarded – undo
300 300
 			return $content;
301 301
 		}
302 302
 
303
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
303
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
304 304
 
305 305
 		/**
306 306
 		 * Editing a single entry.
307 307
 		 */
308 308
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
309
-			if ( $entry['status'] != 'active' ) {
309
+			if ( $entry[ 'status' ] != 'active' ) {
310 310
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
311 311
 				return __( 'You are not allowed to view this content.', 'gravityview' );
312 312
 			}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 			}
318 318
 
319 319
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
320
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
320
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
321 321
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
322 322
 					return __( 'You are not allowed to view this content.', 'gravityview' );
323 323
 				}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 
341 341
 			foreach ( $entryset as $e ) {
342 342
 
343
-				if ( 'active' !== $e['status'] ) {
343
+				if ( 'active' !== $e[ 'status' ] ) {
344 344
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
345 345
 					return __( 'You are not allowed to view this content.', 'gravityview' );
346 346
 				}
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 				}
352 352
 
353 353
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
354
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
354
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
355 355
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
356 356
 						return __( 'You are not allowed to view this content.', 'gravityview' );
357 357
 					}
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
527 527
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
528 528
 
529
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
529
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
530 530
 		}
531 531
 
532 532
 		return $joins;
@@ -621,13 +621,13 @@  discard block
 block discarded – undo
621 621
 			}
622 622
 
623 623
 			foreach ( $_fields as $field ) {
624
-				if ( ! empty( $field['unions'] ) ) {
625
-					foreach ( $field['unions'] as $form_id => $field_id ) {
624
+				if ( ! empty( $field[ 'unions' ] ) ) {
625
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
626 626
 						if ( ! isset( $unions[ $form_id ] ) ) {
627 627
 							$unions[ $form_id ] = array();
628 628
 						}
629 629
 
630
-						$unions[ $form_id ][ $field['id'] ] =
630
+						$unions[ $form_id ][ $field[ 'id' ] ] =
631 631
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
632 632
 					}
633 633
 				}
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
 		if ( ! $view->form ) {
677 677
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
678 678
 				'view_id' => $view->ID,
679
-				'form_id' => $view->_gravityview_form_id ? : 0,
679
+				'form_id' => $view->_gravityview_form_id ?: 0,
680 680
 			) );
681 681
 		}
682 682
 
@@ -913,11 +913,11 @@  discard block
 block discarded – undo
913 913
 			 * Remove multiple sorting before calling legacy filters.
914 914
 			 * This allows us to fake it till we make it.
915 915
 			 */
916
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
916
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
917 917
 				$has_multisort = true;
918
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
919
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
920
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
918
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
919
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
920
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
921 921
 				}
922 922
 			}
923 923
 
@@ -925,40 +925,39 @@  discard block
 block discarded – undo
925 925
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
926 926
 			 */
927 927
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
928
-			$parameters['context_view_id'] = $this->ID;
928
+			$parameters[ 'context_view_id' ] = $this->ID;
929 929
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
930 930
 
931 931
 			if ( $request instanceof REST\Request ) {
932 932
 				$atts = $this->settings->as_atts();
933 933
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
934
-						'paging' => array( 'page_size' => $atts['page_size'] ),
934
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
935 935
 					) );
936
-				$parameters['paging'] = $paging_parameters['paging'];
936
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
937 937
 			}
938 938
 
939
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
940
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
939
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
941 940
 
942 941
 			/**
943 942
 			 * Cleanup duplicate field_filter parameters to simplify the query.
944 943
 			 */
945 944
 			$unique_field_filters = array();
946
-			foreach ( $parameters['search_criteria']['field_filters'] as $key => $filter ) {
945
+			foreach ( $parameters[ 'search_criteria' ][ 'field_filters' ] as $key => $filter ) {
947 946
 				if ( 'mode' === $key ) {
948
-					$unique_field_filters['mode'] = $filter;
947
+					$unique_field_filters[ 'mode' ] = $filter;
949 948
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
950
-					$unique_field_filters[] = $filter;
949
+					$unique_field_filters[ ] = $filter;
951 950
 				}
952 951
 			}
953
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
952
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
954 953
 
955
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
954
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
956 955
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
957 956
 			}
958 957
 
959 958
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
960 959
 				$query_class = $this->get_query_class();
961
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
960
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
962 961
 
963 962
 				/**
964 963
 				 * Apply multisort.
@@ -966,9 +965,9 @@  discard block
 block discarded – undo
966 965
 				if ( ! empty( $has_multisort ) ) {
967 966
 					$atts = $this->settings->as_atts();
968 967
 
969
-					if ( $this->settings->get( 'sort_columns' ) && ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] ) ) {
970
-						$sort_field_ids = array_keys( $_GET['sort'] );
971
-						$sort_directions = array_values( $_GET['sort'] );
968
+					if ( $this->settings->get( 'sort_columns' ) && ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] ) ) {
969
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
970
+						$sort_directions = array_values( $_GET[ 'sort' ] );
972 971
 					} else {
973 972
 						$sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
974 973
 						$sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
@@ -976,7 +975,7 @@  discard block
 block discarded – undo
976 975
 
977 976
 					$skip_first = false;
978 977
 
979
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
978
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
980 979
 						if ( ! $skip_first ) {
981 980
 							$skip_first = true; // Skip the first one, it's already in the query
982 981
 							continue;
@@ -996,8 +995,8 @@  discard block
 block discarded – undo
996 995
 					}
997 996
 				}
998 997
 
999
-				$query->limit( $parameters['paging']['page_size'] )
1000
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
998
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
999
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1001 1000
 
1002 1001
 				/**
1003 1002
 				 * Any joins?
@@ -1020,7 +1019,7 @@  discard block
 block discarded – undo
1020 1019
 
1021 1020
 							$query_parameters = $query->_introspect();
1022 1021
 
1023
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1022
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1024 1023
 						}
1025 1024
 
1026 1025
 						/**
@@ -1054,7 +1053,7 @@  discard block
 block discarded – undo
1054 1053
 						}
1055 1054
 
1056 1055
 						$q = $query->_introspect();
1057
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1056
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1058 1057
 
1059 1058
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1060 1059
 
@@ -1079,7 +1078,7 @@  discard block
 block discarded – undo
1079 1078
 
1080 1079
 							$query_parameters = $query->_introspect();
1081 1080
 
1082
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1081
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1083 1082
 						}
1084 1083
 					}
1085 1084
 				
@@ -1103,7 +1102,7 @@  discard block
 block discarded – undo
1103 1102
 							$conditions = array();
1104 1103
 
1105 1104
 							foreach ( $condition->expressions as $_condition ) {
1106
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1105
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1107 1106
 							}
1108 1107
 
1109 1108
 							return call_user_func_array(
@@ -1132,10 +1131,10 @@  discard block
 block discarded – undo
1132 1131
 						$q = new $query_class( $form_id );
1133 1132
 
1134 1133
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1135
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1134
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1136 1135
 
1137 1136
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1138
-						foreach ( $query_parameters['order'] as $order ) {
1137
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1139 1138
 							list( $column, $_order ) = $order;
1140 1139
 
1141 1140
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1149,15 +1148,15 @@  discard block
 block discarded – undo
1149 1148
 
1150 1149
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1151 1150
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1152
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1151
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1153 1152
 
1154 1153
 							// Record the SQL
1155
-							$unions_sql[] = array(
1154
+							$unions_sql[ ] = array(
1156 1155
 								// Remove columns, we'll rebuild them
1157 1156
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1158
-								'from'    => $sql['from'],
1159
-								'join'    => $sql['join'],
1160
-								'where'   => $sql['where'],
1157
+								'from'    => $sql[ 'from' ],
1158
+								'join'    => $sql[ 'join' ],
1159
+								'where'   => $sql[ 'where' ],
1161 1160
 								// Remove order and limit
1162 1161
 							);
1163 1162
 
@@ -1174,11 +1173,11 @@  discard block
 block discarded – undo
1174 1173
 
1175 1174
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1176 1175
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1177
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1176
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1178 1177
 
1179 1178
 						// Remove columns, we'll rebuild them
1180
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1181
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1179
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1180
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1182 1181
 
1183 1182
 						$unions = array();
1184 1183
 
@@ -1189,30 +1188,30 @@  discard block
 block discarded – undo
1189 1188
 						};
1190 1189
 
1191 1190
 						// Add all the order columns into the selects, so we can order by the whole union group
1192
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1191
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1193 1192
 						
1194 1193
 						$columns = array(
1195
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1194
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1196 1195
 						);
1197 1196
 
1198 1197
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1199
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1198
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1200 1199
 
1201 1200
 							// Rewrite the order columns to the shared aliases
1202
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1201
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1203 1202
 						}
1204 1203
 
1205 1204
 						$columns = array_unique( $columns );
1206 1205
 
1207 1206
 						// Add the columns to every UNION
1208 1207
 						foreach ( $unions_sql as $union_sql ) {
1209
-							$union_sql['select'] .= implode( ', ', $columns );
1210
-							$unions []= implode( ' ', $union_sql );
1208
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1209
+							$unions [ ] = implode( ' ', $union_sql );
1211 1210
 						}
1212 1211
 
1213 1212
 						// Add the columns to the main SELECT, but only grab the entry id column
1214
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1215
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1213
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1214
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1216 1215
 
1217 1216
 						return $sql;
1218 1217
 					} );
@@ -1253,20 +1252,20 @@  discard block
 block discarded – undo
1253 1252
 				} );
1254 1253
 			} else {
1255 1254
 				$entries = $this->form->entries
1256
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1255
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1257 1256
 					->offset( $this->settings->get( 'offset' ) )
1258
-					->limit( $parameters['paging']['page_size'] )
1257
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1259 1258
 					->page( $page );
1260 1259
 
1261
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1260
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1262 1261
 					// Pluck off multisort arrays
1263
-					$parameters['sorting'] = $parameters['sorting'][0];
1262
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1264 1263
 				}
1265 1264
 
1266
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1265
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1267 1266
 					$field = new \GV\Field();
1268
-					$field->ID = $parameters['sorting']['key'];
1269
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1267
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1268
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1270 1269
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1271 1270
 				}
1272 1271
 			}
@@ -1337,7 +1336,7 @@  discard block
 block discarded – undo
1337 1336
 		$allowed = $headers = array();
1338 1337
 
1339 1338
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $id => $field ) {
1340
-			$allowed[] = $field;
1339
+			$allowed[ ] = $field;
1341 1340
 		}
1342 1341
 
1343 1342
 		$renderer = new Field_Renderer();
@@ -1359,17 +1358,17 @@  discard block
 block discarded – undo
1359 1358
 			} );
1360 1359
 
1361 1360
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1362
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1361
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1363 1362
 			}
1364 1363
 
1365 1364
 			foreach ( $allowed as $field ) {
1366 1365
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1367 1366
 
1368
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1367
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1369 1368
 
1370 1369
 				if ( ! $headers_done ) {
1371 1370
 					$label = $field->get_label( $view, $source, $entry );
1372
-					$headers[] = $label ? $label : $field->ID;
1371
+					$headers[ ] = $label ? $label : $field->ID;
1373 1372
 				}
1374 1373
 			}
1375 1374
 
Please login to merge, or discard this patch.
includes/class-gvlogic-shortcode.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	public static function get_instance() {
96 96
 
97
-		if( empty( self::$instance ) ) {
97
+		if ( empty( self::$instance ) ) {
98 98
 			self::$instance = new self;
99 99
 		}
100 100
 
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
 
129 129
 		$operators = array_merge( self::$SUPPORTED_ARRAY_OPERATORS, self::$SUPPORTED_NUMERIC_OPERATORS, self::$SUPPORTED_SCALAR_OPERATORS, self::$SUPPORTED_CUSTOM_OPERATORS );
130 130
 
131
-		if( $with_values ) {
131
+		if ( $with_values ) {
132 132
 			$operators_with_values = array();
133
-			foreach( $operators as $key ) {
133
+			foreach ( $operators as $key ) {
134 134
 				$operators_with_values[ $key ] = '';
135 135
 			}
136 136
 			return $operators_with_values;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		$operators = $this->get_operators( false );
151 151
 
152
-		if( !in_array( $operation, $operators ) ) {
152
+		if ( ! in_array( $operation, $operators ) ) {
153 153
 			gravityview()->log->debug( ' Attempted to add invalid operation type. {operation}', array( 'operation' => $operation ) );
154 154
 			return false;
155 155
 		}
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 			return null;
202 202
 		}
203 203
 
204
-		if( empty( $atts ) ) {
204
+		if ( empty( $atts ) ) {
205 205
 			gravityview()->log->error( '$atts are empty.', array( 'data' => $atts ) );
206 206
 			return null;
207 207
 		}
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 			$setup = $this->setup_operation_and_comparison();
226 226
 
227 227
 			// We need an operation and comparison value
228
-			if( ! $setup ) {
228
+			if ( ! $setup ) {
229 229
 				gravityview()->log->error( 'No valid operators were passed.', array( 'data' => $this->atts ) );
230 230
 				return null;
231 231
 			}
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 		$logged_in_match = ! $this->logged_in ^ is_user_logged_in(); // XNOR
278 278
 
279 279
 		// Only logged-in match
280
-		if( 1 === sizeof( $this->passed_atts ) ) {
280
+		if ( 1 === sizeof( $this->passed_atts ) ) {
281 281
 			$this->is_match = $logged_in_match;
282 282
 		} else {
283 283
 			$this->is_match = $logged_in_match && $comparison_match;
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 	 */
292 292
 	private function get_output() {
293 293
 
294
-		if( $this->is_match ) {
294
+		if ( $this->is_match ) {
295 295
 			$output = $this->content;
296 296
 		} else {
297 297
 			$output = $this->else_content;
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 		 * @param string $output HTML/text output
310 310
 		 * @param GVLogic_Shortcode $this This class
311 311
 		 */
312
-		$output = apply_filters('gravityview/gvlogic/output', $output, $this );
312
+		$output = apply_filters( 'gravityview/gvlogic/output', $output, $this );
313 313
 
314 314
 		gravityview()->log->debug( 'Output: ', array( 'data' => $output ) );
315 315
 
@@ -329,14 +329,14 @@  discard block
 block discarded – undo
329 329
 		list( $before_else, $after_else ) = array_pad( explode( '[else]', $passed_content ), 2, NULL );
330 330
 		list( $before_else_if, $after_else_if ) = array_pad( explode( '[else', $passed_content ), 2, NULL );
331 331
 
332
-		$else_attr = isset( $this->atts['else'] ) ? $this->atts['else'] : NULL;
332
+		$else_attr = isset( $this->atts[ 'else' ] ) ? $this->atts[ 'else' ] : NULL;
333 333
 		$else_content = isset( $after_else ) ? $after_else : $else_attr;
334 334
 
335 335
 		// The content is everything OTHER than the [else]
336 336
 		$this->content = $before_else_if;
337 337
 
338 338
 		if ( ! $this->is_match ) {
339
-			if( $elseif_content = $this->process_elseif( $before_else ) ) {
339
+			if ( $elseif_content = $this->process_elseif( $before_else ) ) {
340 340
 				$this->else_content = $elseif_content;
341 341
 			} else {
342 342
 				$this->else_content = $else_content;
@@ -364,16 +364,16 @@  discard block
 block discarded – undo
364 364
 		foreach ( $else_if_matches as $key => $else_if_match ) {
365 365
 
366 366
 			// If $else_if_match[5] exists and has content, check for more shortcodes
367
-			preg_match_all( '/' . $regex . '/', $else_if_match[5] . '[/else]', $recursive_matches, PREG_SET_ORDER );
367
+			preg_match_all( '/' . $regex . '/', $else_if_match[ 5 ] . '[/else]', $recursive_matches, PREG_SET_ORDER );
368 368
 
369 369
 			// If the logic passes, this is the value that should be used for $this->else_content
370
-			$else_if_value = $else_if_match[5];
371
-			$check_elseif_match = $else_if_match[0];
370
+			$else_if_value = $else_if_match[ 5 ];
371
+			$check_elseif_match = $else_if_match[ 0 ];
372 372
 
373 373
 			// Retrieve the value of the match that is currently being checked, without any other [else] tags
374
-			if( ! empty( $recursive_matches[0][0] ) ) {
375
-				$else_if_value = str_replace( $recursive_matches[0][0], '', $else_if_value );
376
-				$check_elseif_match = str_replace( $recursive_matches[0][0], '', $check_elseif_match );
374
+			if ( ! empty( $recursive_matches[ 0 ][ 0 ] ) ) {
375
+				$else_if_value = str_replace( $recursive_matches[ 0 ][ 0 ], '', $else_if_value );
376
+				$check_elseif_match = str_replace( $recursive_matches[ 0 ][ 0 ], '', $check_elseif_match );
377 377
 			}
378 378
 
379 379
 			$check_elseif_match = str_replace( '[else', '[gvlogicelse', $check_elseif_match );
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
 			}
391 391
 
392 392
 			// Process any remaining [else] tags
393
-			return $this->process_elseif( $else_if_match[5] );
393
+			return $this->process_elseif( $else_if_match[ 5 ] );
394 394
 		}
395 395
 
396 396
 		return false;
@@ -417,11 +417,11 @@  discard block
 block discarded – undo
417 417
 		$this->atts = array_intersect_key( $this->passed_atts, $this->atts );
418 418
 
419 419
 		// Strip whitespace if it's not default false
420
-		$this->if = ( isset( $this->atts['if'] ) && is_string( $this->atts['if'] ) ) ? trim( $this->atts['if'] ) : false;
420
+		$this->if = ( isset( $this->atts[ 'if' ] ) && is_string( $this->atts[ 'if' ] ) ) ? trim( $this->atts[ 'if' ] ) : false;
421 421
 
422
-		if ( isset( $this->atts['logged_in'] ) ) {
422
+		if ( isset( $this->atts[ 'logged_in' ] ) ) {
423 423
 			// Truthy
424
-			if ( in_array( strtolower( $this->atts['logged_in'] ), array( '0', 'false', 'no' ) ) ) {
424
+			if ( in_array( strtolower( $this->atts[ 'logged_in' ] ), array( '0', 'false', 'no' ) ) ) {
425 425
 				$this->logged_in = false;
426 426
 			} else {
427 427
 				$this->logged_in = true;
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
 		do_action( 'gravityview/gvlogic/parse_atts/after', $this );
438 438
 
439 439
 		// Make sure the "if" isn't processed in self::setup_operation_and_comparison()
440
-		unset( $this->atts['if'] );
440
+		unset( $this->atts[ 'if' ] );
441 441
 	}
442 442
 }
443 443
 
Please login to merge, or discard this patch.
future/includes/class-gv-template-view-table.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -69,22 +69,22 @@  discard block
 block discarded – undo
69 69
 			if ( is_array( $sorts ) ) {
70 70
 				foreach ( (array)$sorts as $key => $direction ) {
71 71
 					if ( $key == $context->field->ID ) {
72
-						$sorting['key'] = $context->field->ID;
73
-						$sorting['direction'] = strtolower( $direction );
72
+						$sorting[ 'key' ] = $context->field->ID;
73
+						$sorting[ 'direction' ] = strtolower( $direction );
74 74
 						break;
75 75
 					}
76 76
 				}
77 77
 			} else {
78 78
 				if ( $sorts == $context->field->ID ) {
79
-					$sorting['key'] = $context->field->ID;
80
-					$sorting['direction'] = strtolower( Utils::_GET( 'dir', '' ) );
79
+					$sorting[ 'key' ] = $context->field->ID;
80
+					$sorting[ 'direction' ] = strtolower( Utils::_GET( 'dir', '' ) );
81 81
 				}
82 82
 			}
83 83
 		} else {
84 84
 			foreach ( (array)$context->view->settings->get( 'sort_field', array() ) as $i => $sort_field ) {
85 85
 				if ( $sort_field == $context->field->ID ) {
86
-					$sorting['key'] = $sort_field;
87
-					$sorting['direction'] = strtolower( Utils::get( $directions, $i, '' ) );
86
+					$sorting[ 'key' ] = $sort_field;
87
+					$sorting[ 'direction' ] = strtolower( Utils::get( $directions, $i, '' ) );
88 88
 					break; // Only get the first sort
89 89
 				}
90 90
 			}
@@ -100,21 +100,21 @@  discard block
 block discarded – undo
100 100
 		);
101 101
 
102 102
 		// If we are already sorting by the current field...
103
-		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
103
+		if ( ! empty( $sorting[ 'key' ] ) && (string)$sort_field_id === (string)$sorting[ 'key' ] ) {
104 104
 
105
-		    switch( $sorting['direction'] ) {
105
+		    switch ( $sorting[ 'direction' ] ) {
106 106
 		        // No sort
107 107
                 case '':
108
-	                $sort_args[1] = 'asc';
108
+	                $sort_args[ 1 ] = 'asc';
109 109
 	                $class .= ' gv-icon-caret-up-down';
110 110
                     break;
111 111
                 case 'desc':
112
-	                $sort_args[1] = '';
112
+	                $sort_args[ 1 ] = '';
113 113
 	                $class .= ' gv-icon-sort-asc';
114 114
 	                break;
115 115
                 case 'asc':
116 116
                 default:
117
-                    $sort_args[1] = 'desc';
117
+                    $sort_args[ 1 ] = 'desc';
118 118
                     $class .= ' gv-icon-sort-desc';
119 119
                     break;
120 120
             }
@@ -127,15 +127,15 @@  discard block
 block discarded – undo
127 127
 		$url = remove_query_arg( 'sort', $url );
128 128
 		$multisort_url = self::_get_multisort_url( $url, $sort_args, $context->field->ID );
129 129
 
130
-    	$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
130
+    	$url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $url );
131 131
 
132
-		$return = '<a href="'. esc_url_raw( $url ) .'"';
132
+		$return = '<a href="' . esc_url_raw( $url ) . '"';
133 133
 
134 134
 		if ( ! empty( $multisort_url ) ) {
135
-			$return .= ' data-multisort-href="'. esc_url_raw( $multisort_url ) . '"';
135
+			$return .= ' data-multisort-href="' . esc_url_raw( $multisort_url ) . '"';
136 136
 		}
137 137
 
138
-		$return .= ' class="'. $class .'" ></a>&nbsp;'. $column_label;
138
+		$return .= ' class="' . $class . '" ></a>&nbsp;' . $column_label;
139 139
 
140 140
 		return $return;
141 141
 	}
@@ -168,19 +168,19 @@  discard block
 block discarded – undo
168 168
         if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
169 169
             if ( count( $keys ) ) {
170 170
                 $multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
171
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
171
+                $multisort_url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $multisort_url );
172 172
             } else {
173
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
173
+                $multisort_url = add_query_arg( $sort_args[ 0 ], $sort_args[ 1 ], $multisort_url );
174 174
             }
175 175
         }
176 176
         // Otherwise, we are just updating the sort order
177 177
         else {
178 178
 
179 179
             // Pass empty value to unset
180
-            if( '' === $sort_args[1] ) {
180
+            if ( '' === $sort_args[ 1 ] ) {
181 181
 	            unset( $sorts[ $field_id ] );
182 182
             } else {
183
-	            $sorts[ $field_id ] = $sort_args[1];
183
+	            $sorts[ $field_id ] = $sort_args[ 1 ];
184 184
             }
185 185
 
186 186
             $multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
@@ -318,9 +318,9 @@  discard block
 block discarded – undo
318 318
                 do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
319 319
 
320 320
                 foreach ( $fields->all() as $field ) {
321
-					if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) {
322
-						if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) {
323
-							$field = $this->view->unions[ $entry['form_id'] ][ $field->ID ];
321
+					if ( isset( $this->view->unions[ $entry[ 'form_id' ] ] ) ) {
322
+						if ( isset( $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ] ) ) {
323
+							$field = $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ];
324 324
 						} else {
325 325
 							if ( ! $field instanceof Internal_Field ) {
326 326
 								$field = Internal_Field::from_configuration( array( 'id' => 'custom' ) );
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-address.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
 
61 61
 			if ( 'address' === \GV\Utils::get( $search_field, 'type' ) ) {
62 62
 
63
-				$field_id = intval( floor( $search_field['key'] ) );
64
-				$input_id = gravityview_get_input_id_from_id( $search_field['key'] );
63
+				$field_id = intval( floor( $search_field[ 'key' ] ) );
64
+				$input_id = gravityview_get_input_id_from_id( $search_field[ 'key' ] );
65 65
 				$form = GravityView_View::getInstance()->getForm();
66 66
 
67 67
 				/** @var GF_Field_Address $address_field */
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 				$choices = array();
71 71
 
72 72
 				$method_name = 'get_choices_' . self::get_input_type_from_input_id( $input_id );
73
-				if( method_exists( $this, $method_name ) ) {
73
+				if ( method_exists( $this, $method_name ) ) {
74 74
 					/**
75 75
 					 * @uses GravityView_Field_Address::get_choices_country()
76 76
 					 * @uses GravityView_Field_Address::get_choices_state()
@@ -78,12 +78,12 @@  discard block
 block discarded – undo
78 78
 					$choices = $this->{$method_name}( $address_field, $form );
79 79
 				}
80 80
 
81
-				if( ! empty( $choices ) ) {
82
-					$search_field['choices'] = $choices;
83
-					$search_field['type'] = \GV\Utils::get( $search_field, 'input');
81
+				if ( ! empty( $choices ) ) {
82
+					$search_field[ 'choices' ] = $choices;
83
+					$search_field[ 'type' ] = \GV\Utils::get( $search_field, 'input' );
84 84
 				} else {
85
-					$search_field['type'] = 'text';
86
-					$search_field['input'] = 'input_text';
85
+					$search_field[ 'type' ] = 'text';
86
+					$search_field[ 'input' ] = 'input_text';
87 87
 				}
88 88
 			}
89 89
 		}
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 		$country_choices = array();
110 110
 
111 111
 		foreach ( $countries as $key => $country ) {
112
-			$country_choices[] = array(
112
+			$country_choices[ ] = array(
113 113
 				'value' => $country,
114 114
 				'text' => $country,
115 115
 			);
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 */
135 135
 	private function get_choices_state( $address_field, $form ) {
136 136
 
137
-		$address_type = empty( $address_field->addressType ) ? $address_field->get_default_address_type( $form['id'] ) : $address_field->addressType;
137
+		$address_type = empty( $address_field->addressType ) ? $address_field->get_default_address_type( $form[ 'id' ] ) : $address_field->addressType;
138 138
 
139 139
 		$state_choices = array();
140 140
 
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
146 146
 				$states = GFCommon::get_canadian_provinces();
147 147
 				break;
148 148
 			default:
149
-				$address_types = $address_field->get_address_types( $form['id'] );
150
-				$states = empty( $address_types[ $address_type ]['states'] ) ? array() : $address_types[ $address_type ]['states'];
149
+				$address_types = $address_field->get_address_types( $form[ 'id' ] );
150
+				$states = empty( $address_types[ $address_type ][ 'states' ] ) ? array() : $address_types[ $address_type ][ 'states' ];
151 151
 				break;
152 152
 		}
153 153
 
@@ -156,19 +156,19 @@  discard block
 block discarded – undo
156 156
 				$state_subchoices = array();
157 157
 
158 158
 				foreach ( $state as $key => $substate ) {
159
-					$state_subchoices[] = array(
159
+					$state_subchoices[ ] = array(
160 160
 						'value' => is_numeric( $key ) ? $substate : $key,
161 161
 						'text' => $substate,
162 162
 					);
163 163
 				}
164 164
 
165
-				$state_choices[] = array(
165
+				$state_choices[ ] = array(
166 166
 					'text' => $key,
167 167
 					'value' => $state_subchoices,
168 168
 				);
169 169
 
170 170
 			} else {
171
-				$state_choices[] = array(
171
+				$state_choices[ ] = array(
172 172
 					'value' => is_numeric( $key ) ? $state : $key,
173 173
 					'text' => $state,
174 174
 				);
@@ -192,13 +192,13 @@  discard block
 block discarded – undo
192 192
 		// Use the same inputs as the "text" input type allows
193 193
 		$text_inputs = \GV\Utils::get( $input_types, 'text' );
194 194
 
195
-		$input_types['street'] = $text_inputs;
196
-		$input_types['street2'] = $text_inputs;
197
-		$input_types['city'] = $text_inputs;
195
+		$input_types[ 'street' ] = $text_inputs;
196
+		$input_types[ 'street2' ] = $text_inputs;
197
+		$input_types[ 'city' ] = $text_inputs;
198 198
 
199
-		$input_types['state'] = array( 'select', 'radio', 'link' ) + $text_inputs;
200
-		$input_types['zip'] = array( 'input_text' );
201
-		$input_types['country'] = array( 'select', 'radio', 'link' ) + $text_inputs;
199
+		$input_types[ 'state' ] = array( 'select', 'radio', 'link' ) + $text_inputs;
200
+		$input_types[ 'zip' ] = array( 'input_text' );
201
+		$input_types[ 'country' ] = array( 'select', 'radio', 'link' ) + $text_inputs;
202 202
 
203 203
 		return $input_types;
204 204
 	}
@@ -219,10 +219,10 @@  discard block
 block discarded – undo
219 219
 		// Is this search field for an input (eg: 4.2) or the whole address field (eg: 4)?
220 220
 		$input_id = gravityview_get_input_id_from_id( $field_id );
221 221
 
222
-		if( 'address' === $field_type && $input_id ) {
222
+		if ( 'address' === $field_type && $input_id ) {
223 223
 
224 224
 			// If the input ID matches an expected address input, set to that. Otherwise, keep existing input type.
225
-			if( $address_field_name = self::get_input_type_from_input_id( $input_id ) ) {
225
+			if ( $address_field_name = self::get_input_type_from_input_id( $input_id ) ) {
226 226
 				$input_type = $address_field_name;
227 227
 			}
228 228
 		}
@@ -271,20 +271,20 @@  discard block
 block discarded – undo
271 271
 	function field_options( $field_options, $template_id = '', $field_id = '', $context = '', $input_type = '' ) {
272 272
 
273 273
 		// If this is NOT the full address field, return default options.
274
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
274
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
275 275
 			return $field_options;
276 276
 		}
277 277
 
278
-		if( 'edit' === $context ) {
278
+		if ( 'edit' === $context ) {
279 279
 			return $field_options;
280 280
 		}
281 281
 
282 282
 		$add_options = array();
283 283
 
284
-		$add_options['show_map_link'] = array(
284
+		$add_options[ 'show_map_link' ] = array(
285 285
 			'type' => 'checkbox',
286 286
 			'label' => __( 'Show Map Link:', 'gravityview' ),
287
-			'desc' => __('Display a "Map It" link below the address', 'gravityview'),
287
+			'desc' => __( 'Display a "Map It" link below the address', 'gravityview' ),
288 288
 			'value' => true,
289 289
 			'merge_tags' => false,
290 290
 		);
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Spacing   +213 added lines, -213 removed lines patch added patch discarded remove patch
@@ -123,16 +123,16 @@  discard block
 block discarded – undo
123 123
 	function load() {
124 124
 
125 125
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
126
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
126
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
127 127
 
128 128
 		// Don't display an embedded form when editing an entry
129 129
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
130 130
 		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
131 131
 
132 132
 		// Stop Gravity Forms processing what is ours!
133
-		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
133
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
134 134
 
135
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
135
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
136 136
 
137 137
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
138 138
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
144 144
 
145 145
 		// Add fields expected by GFFormDisplay::validate()
146
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
146
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
147 147
 
148 148
 		// Fix multiselect value for GF 2.2
149 149
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	 * @return void
161 161
 	 */
162 162
 	public function prevent_render_form() {
163
-		if( $this->is_edit_entry() ) {
164
-			if( 'wp_head' === current_filter() ) {
163
+		if ( $this->is_edit_entry() ) {
164
+			if ( 'wp_head' === current_filter() ) {
165 165
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
166 166
 			} else {
167 167
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -176,13 +176,13 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179
-		if( ! empty( $_POST ) ) {
179
+		if ( ! empty( $_POST ) ) {
180 180
 	        gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
181 181
 		}
182 182
 
183
-		if( $this->is_edit_entry_submission() ) {
184
-			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
185
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
183
+		if ( $this->is_edit_entry_submission() ) {
184
+			remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
185
+	        remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
186 186
 		}
187 187
 	}
188 188
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function is_edit_entry() {
194 194
 
195
-		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
195
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET[ 'edit' ] );
196 196
 
197 197
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
198 198
 	}
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @return boolean
204 204
 	 */
205 205
 	public function is_edit_entry_submission() {
206
-		return !empty( $_POST[ self::$nonce_field ] );
206
+		return ! empty( $_POST[ self::$nonce_field ] );
207 207
 	}
208 208
 
209 209
 	/**
@@ -216,16 +216,16 @@  discard block
 block discarded – undo
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+	    self::$original_entry = $entries[ 0 ];
220
+	    $this->entry = $entries[ 0 ];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
224
-		$this->form_id = $this->entry['form_id'];
224
+		$this->form_id = $this->entry[ 'form_id' ];
225 225
 		$this->view_id = $gravityview_view->getViewId();
226 226
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
227 227
 
228
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
228
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
229 229
 	}
230 230
 
231 231
 
@@ -284,9 +284,9 @@  discard block
 block discarded – undo
284 284
 	private function print_scripts() {
285 285
 		$gravityview_view = GravityView_View::getInstance();
286 286
 
287
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
287
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
288 288
 
289
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
289
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
290 290
 
291 291
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
292 292
 
@@ -302,19 +302,19 @@  discard block
 block discarded – undo
302 302
 	 */
303 303
 	private function process_save( $gv_data ) {
304 304
 
305
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
305
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
306 306
 			return;
307 307
 		}
308 308
 
309 309
 		// Make sure the entry, view, and form IDs are all correct
310 310
 		$valid = $this->verify_nonce();
311 311
 
312
-		if ( !$valid ) {
312
+		if ( ! $valid ) {
313 313
 			gravityview()->log->error( 'Nonce validation failed.' );
314 314
 			return;
315 315
 		}
316 316
 
317
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
317
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
318 318
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
319 319
 			return;
320 320
 		}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$this->validate();
327 327
 
328
-		if( $this->is_valid ) {
328
+		if ( $this->is_valid ) {
329 329
 
330 330
 			gravityview()->log->debug( 'Submission is valid.' );
331 331
 
@@ -337,15 +337,15 @@  discard block
 block discarded – undo
337 337
 			/**
338 338
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
339 339
 			 */
340
-			unset( $_GET['page'] );
340
+			unset( $_GET[ 'page' ] );
341 341
 
342
-			$date_created = $this->entry['date_created'];
342
+			$date_created = $this->entry[ 'date_created' ];
343 343
 
344 344
 			/**
345 345
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
346 346
 			 * @since 1.17.2
347 347
 			 */
348
-			unset( $this->entry['date_created'] );
348
+			unset( $this->entry[ 'date_created' ] );
349 349
 
350 350
 			/**
351 351
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 			 * @param GravityView_Edit_Entry_Render $this This object
356 356
 			 * @param GravityView_View_Data $gv_data The View data
357 357
 			 */
358
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
358
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362 362
 	        // Delete the values for hidden inputs
363 363
 	        $this->unset_hidden_field_values();
364 364
 			
365
-			$this->entry['date_created'] = $date_created;
365
+			$this->entry[ 'date_created' ] = $date_created;
366 366
 
367 367
 			// Process calculation fields
368 368
 			$this->update_calculation_fields();
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
385 385
 			 * @param GravityView_View_Data $gv_data The View data
386 386
 			 */
387
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
387
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
388 388
 
389 389
 		} else {
390 390
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -412,16 +412,16 @@  discard block
 block discarded – undo
412 412
 		 */
413 413
 		$unset_hidden_field_values = apply_filters( 'gravityview/edit_entry/unset_hidden_field_values', true, $this );
414 414
 
415
-		if( ! $unset_hidden_field_values ) {
415
+		if ( ! $unset_hidden_field_values ) {
416 416
 			return;
417 417
 		}
418 418
 
419 419
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
420 420
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
421
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
421
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
422 422
 		} else {
423 423
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
424
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
424
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
425 425
 		}
426 426
 
427 427
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437
-					$this->form, '', $this->entry['id'], $this->entry
437
+					$this->form, '', $this->entry[ 'id' ], $this->entry
438 438
 				);
439 439
 
440 440
 			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 		}
505 505
 
506 506
 		/** No file is being uploaded. */
507
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
507
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
508 508
 			/** So return the original upload */
509 509
 			return $entry[ $input_id ];
510 510
 		}
@@ -522,11 +522,11 @@  discard block
 block discarded – undo
522 522
 	 * @return mixed
523 523
 	 */
524 524
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
525
-		if( ! $this->is_edit_entry() ) {
525
+		if ( ! $this->is_edit_entry() ) {
526 526
 			return $plupload_init;
527 527
 		}
528 528
 
529
-		$plupload_init['gf_vars']['max_files'] = 0;
529
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
530 530
 
531 531
 		return $plupload_init;
532 532
 	}
@@ -541,27 +541,27 @@  discard block
 block discarded – undo
541 541
 		$form = $this->form;
542 542
 
543 543
 	    /** @var GF_Field $field */
544
-		foreach( $form['fields'] as $k => &$field ) {
544
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
545 545
 
546 546
 			/**
547 547
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
548 548
 			 * @since 1.16.3
549 549
 			 * @var GF_Field $field
550 550
 			 */
551
-			if( $field->has_calculation() ) {
552
-				unset( $form['fields'][ $k ] );
551
+			if ( $field->has_calculation() ) {
552
+				unset( $form[ 'fields' ][ $k ] );
553 553
 			}
554 554
 
555 555
 			$field->adminOnly = false;
556 556
 
557
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
-				foreach( $field->inputs as $key => $input ) {
559
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
557
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
+				foreach ( $field->inputs as $key => $input ) {
559
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
560 560
 				}
561 561
 			}
562 562
 		}
563 563
 
564
-		$form['fields'] = array_values( $form['fields'] );
564
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
565 565
 
566 566
 		return $form;
567 567
 	}
@@ -573,14 +573,14 @@  discard block
 block discarded – undo
573 573
 		$update = false;
574 574
 
575 575
 		// get the most up to date entry values
576
-		$entry = GFAPI::get_entry( $this->entry['id'] );
576
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
577 577
 
578 578
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
579 579
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
580
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
580
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
581 581
 		} else {
582 582
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
583
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
583
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
584 584
 		}
585 585
 
586 586
 
@@ -592,24 +592,24 @@  discard block
 block discarded – undo
592 592
 				$inputs = $field->get_entry_inputs();
593 593
 				if ( is_array( $inputs ) ) {
594 594
 				    foreach ( $inputs as $input ) {
595
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
595
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
596 596
 
597 597
 						if ( 'product' === $field->type ) {
598
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
598
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
599 599
 
600 600
 							// Only allow quantity to be set if it's allowed to be edited
601 601
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
602 602
 							} else { // otherwise set to what it previously was
603
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
603
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
604 604
 							}
605 605
 						} else {
606 606
 							// Set to what it previously was if it's not editable
607 607
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
608
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
608
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
609 609
 							}
610 610
 						}
611 611
 
612
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
612
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
613 613
 				    }
614 614
 				} else {
615 615
 					// Set to what it previously was if it's not editable
@@ -649,19 +649,19 @@  discard block
 block discarded – undo
649 649
 
650 650
 		$input_name = 'input_' . $field_id;
651 651
 
652
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
652
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
653 653
 
654 654
 			// We have a new image
655 655
 
656
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
656
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
657 657
 
658 658
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
659 659
 	        $ary = stripslashes_deep( $ary );
660 660
 			$img_url = \GV\Utils::get( $ary, 0 );
661 661
 
662
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
663
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
664
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
662
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
663
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
664
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
665 665
 
666 666
 			$image_meta = array(
667 667
 				'post_excerpt' => $img_caption,
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
 
671 671
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
672 672
 			if ( ! empty( $img_title ) ) {
673
-				$image_meta['post_title'] = $img_title;
673
+				$image_meta[ 'post_title' ] = $img_title;
674 674
 			}
675 675
 
676 676
 			/**
@@ -728,15 +728,15 @@  discard block
 block discarded – undo
728 728
 	 */
729 729
 	private function maybe_update_post_fields( $form ) {
730 730
 
731
-		if( empty( $this->entry['post_id'] ) ) {
731
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
732 732
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
733 733
 			return;
734 734
 		}
735 735
 
736
-		$post_id = $this->entry['post_id'];
736
+		$post_id = $this->entry[ 'post_id' ];
737 737
 
738 738
 		// Security check
739
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
739
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
740 740
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
741 741
 			return;
742 742
 		}
@@ -749,25 +749,25 @@  discard block
 block discarded – undo
749 749
 
750 750
 			$field = RGFormsModel::get_field( $form, $field_id );
751 751
 
752
-			if( ! $field ) {
752
+			if ( ! $field ) {
753 753
 				continue;
754 754
 			}
755 755
 
756
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
756
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
757 757
 
758 758
 				// Get the value of the field, including $_POSTed value
759 759
 				$value = RGFormsModel::get_field_value( $field );
760 760
 
761 761
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
762 762
 				$entry_tmp = $this->entry;
763
-				$entry_tmp["{$field_id}"] = $value;
763
+				$entry_tmp[ "{$field_id}" ] = $value;
764 764
 
765
-				switch( $field->type ) {
765
+				switch ( $field->type ) {
766 766
 
767 767
 				    case 'post_title':
768 768
 				        $post_title = $value;
769 769
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
770
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
770
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
771 771
 				        }
772 772
 				        $updated_post->post_title = $post_title;
773 773
 				        $updated_post->post_name  = $post_title;
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
 				    case 'post_content':
778 778
 				        $post_content = $value;
779 779
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
780
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
780
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
781 781
 				        }
782 782
 				        $updated_post->post_content = $post_content;
783 783
 				        unset( $post_content );
@@ -795,11 +795,11 @@  discard block
 block discarded – undo
795 795
 							$value = $value[ $field_id ];
796 796
 						}
797 797
 
798
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
798
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
799 799
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
800 800
 				        }
801 801
 
802
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
802
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
803 803
 
804 804
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
805 805
 				        break;
@@ -811,7 +811,7 @@  discard block
 block discarded – undo
811 811
 				}
812 812
 
813 813
 				// update entry after
814
-				$this->entry["{$field_id}"] = $value;
814
+				$this->entry[ "{$field_id}" ] = $value;
815 815
 
816 816
 				$update_entry = true;
817 817
 
@@ -820,11 +820,11 @@  discard block
 block discarded – undo
820 820
 
821 821
 		}
822 822
 
823
-		if( $update_entry ) {
823
+		if ( $update_entry ) {
824 824
 
825 825
 			$return_entry = GFAPI::update_entry( $this->entry );
826 826
 
827
-			if( is_wp_error( $return_entry ) ) {
827
+			if ( is_wp_error( $return_entry ) ) {
828 828
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
829 829
 			} else {
830 830
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -834,7 +834,7 @@  discard block
 block discarded – undo
834 834
 
835 835
 		$return_post = wp_update_post( $updated_post, true );
836 836
 
837
-		if( is_wp_error( $return_post ) ) {
837
+		if ( is_wp_error( $return_post ) ) {
838 838
 			$return_post->add_data( $updated_post, '$updated_post' );
839 839
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
840 840
 		} else {
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
869 869
 
870 870
 		// replace conditional shortcodes
871
-		if( $do_shortcode ) {
871
+		if ( $do_shortcode ) {
872 872
 			$output = do_shortcode( $output );
873 873
 		}
874 874
 
@@ -887,19 +887,19 @@  discard block
 block discarded – undo
887 887
 	 */
888 888
 	private function after_update() {
889 889
 
890
-		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
891
-		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
890
+		do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ], self::$original_entry );
891
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ], self::$original_entry );
892 892
 
893 893
 		// Re-define the entry now that we've updated it.
894
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
894
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
895 895
 
896 896
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
897 897
 
898 898
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
899 899
 			// We need to clear the cache because Gravity Forms caches the field values, which
900 900
 			// we have just updated.
901
-			foreach ($this->form['fields'] as $key => $field) {
902
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
901
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
902
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
903 903
 			}
904 904
 		}
905 905
 
@@ -909,11 +909,11 @@  discard block
 block discarded – undo
909 909
 		 * @since develop
910 910
 		 */
911 911
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
912
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
912
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
913 913
 			if ( ! is_wp_error( $feeds ) ) {
914 914
 				$registered_feeds = array();
915 915
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
916
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
916
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
917 917
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
918 918
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
919 919
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -921,8 +921,8 @@  discard block
 block discarded – undo
921 921
 					}
922 922
 				}
923 923
 				foreach ( $feeds as $feed ) {
924
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
925
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
924
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
925
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
926 926
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
927 927
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
928 928
 								$entry = $returned_entry;
@@ -952,7 +952,7 @@  discard block
 block discarded – undo
952 952
 
953 953
 		<div class="gv-edit-entry-wrapper"><?php
954 954
 
955
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
955
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
956 956
 
957 957
 			/**
958 958
 			 * Fixes weird wpautop() issue
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
969 969
 				     * @param GravityView_Edit_Entry_Render $this This object
970 970
 				     */
971
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
971
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
972 972
 
973 973
 				    echo esc_attr( $edit_entry_title );
974 974
 			?></span>
@@ -1018,13 +1018,13 @@  discard block
 block discarded – undo
1018 1018
 
1019 1019
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1020 1020
 
1021
-			if( ! $this->is_valid ){
1021
+			if ( ! $this->is_valid ) {
1022 1022
 
1023 1023
 				// Keeping this compatible with Gravity Forms.
1024
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1025
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1024
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1025
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1026 1026
 
1027
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1027
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1028 1028
 
1029 1029
 			} else {
1030 1030
 				$view = \GV\View::by_id( $this->view_id );
@@ -1035,23 +1035,23 @@  discard block
 block discarded – undo
1035 1035
 
1036 1036
                     case '0':
1037 1037
 	                    $redirect_url = $back_link;
1038
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1038
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1039 1039
                         break;
1040 1040
 
1041 1041
                     case '1':
1042 1042
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1043
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1043
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1044 1044
 	                    break;
1045 1045
 
1046 1046
                     case '2':
1047 1047
 	                    $redirect_url = $edit_redirect_url;
1048 1048
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1049
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1049
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1050 1050
                         break;
1051 1051
 
1052 1052
                     case '':
1053 1053
                     default:
1054
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1054
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1055 1055
                         break;
1056 1056
 				}
1057 1057
 
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 				 * @param array $entry Gravity Forms entry array
1068 1068
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1069 1069
 				 */
1070
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1070
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1071 1071
 
1072 1072
 				echo GVCommon::generate_notice( $message );
1073 1073
 			}
@@ -1091,21 +1091,21 @@  discard block
 block discarded – undo
1091 1091
 		 */
1092 1092
 		do_action( 'gravityview/edit-entry/render/before', $this );
1093 1093
 
1094
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1095
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1094
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1095
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1096 1096
 		add_filter( 'gform_disable_view_counter', '__return_true' );
1097 1097
 
1098 1098
 		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
1099 1099
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1100 1100
 
1101 1101
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1102
-		unset( $_GET['page'] );
1102
+		unset( $_GET[ 'page' ] );
1103 1103
 
1104 1104
 		// TODO: Verify multiple-page forms
1105 1105
 
1106 1106
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1107 1107
 
1108
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1108
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1109 1109
 
1110 1110
 		ob_get_clean();
1111 1111
 
@@ -1131,7 +1131,7 @@  discard block
 block discarded – undo
1131 1131
 	 * @return string
1132 1132
 	 */
1133 1133
 	public function render_form_buttons() {
1134
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1134
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1135 1135
 	}
1136 1136
 
1137 1137
 
@@ -1151,10 +1151,10 @@  discard block
 block discarded – undo
1151 1151
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1152 1152
 
1153 1153
 		// In case we have validated the form, use it to inject the validation results into the form render
1154
-		if( isset( $this->form_after_validation ) ) {
1154
+		if ( isset( $this->form_after_validation ) ) {
1155 1155
 			$form = $this->form_after_validation;
1156 1156
 		} else {
1157
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1157
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1158 1158
 		}
1159 1159
 
1160 1160
 		$form = $this->filter_conditional_logic( $form );
@@ -1162,8 +1162,8 @@  discard block
 block discarded – undo
1162 1162
 		$form = $this->prefill_conditional_logic( $form );
1163 1163
 
1164 1164
 		// for now we don't support Save and Continue feature.
1165
-		if( ! self::$supports_save_and_continue ) {
1166
-	        unset( $form['save'] );
1165
+		if ( ! self::$supports_save_and_continue ) {
1166
+	        unset( $form[ 'save' ] );
1167 1167
 		}
1168 1168
 
1169 1169
 		$form = $this->unselect_default_values( $form );
@@ -1186,31 +1186,31 @@  discard block
 block discarded – undo
1186 1186
 	 */
1187 1187
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1188 1188
 
1189
-		if( ! GFCommon::is_post_field( $field ) ) {
1189
+		if ( ! GFCommon::is_post_field( $field ) ) {
1190 1190
 			return $field_content;
1191 1191
 		}
1192 1192
 
1193 1193
         $message = null;
1194 1194
 
1195 1195
         // First, make sure they have the capability to edit the post.
1196
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1196
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1197 1197
 
1198 1198
             /**
1199 1199
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1200 1200
              * @param string $message The existing "You don't have permission..." text
1201 1201
              */
1202
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1202
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1203 1203
 
1204
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1204
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1205 1205
             /**
1206 1206
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1207 1207
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1208 1208
              */
1209
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1209
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1210 1210
         }
1211 1211
 
1212
-        if( $message ) {
1213
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1212
+        if ( $message ) {
1213
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1214 1214
         }
1215 1215
 
1216 1216
         return $field_content;
@@ -1234,8 +1234,8 @@  discard block
 block discarded – undo
1234 1234
 
1235 1235
 		// If the form has been submitted, then we don't need to pre-fill the values,
1236 1236
 		// Except for fileupload type and when a field input is overridden- run always!!
1237
-		if(
1238
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1237
+		if (
1238
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1239 1239
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1240 1240
 			&& ! GFCommon::is_product_field( $field->type )
1241 1241
 			|| ! empty( $field_content )
@@ -1255,7 +1255,7 @@  discard block
 block discarded – undo
1255 1255
 	    $return = null;
1256 1256
 
1257 1257
 		/** @var GravityView_Field $gv_field */
1258
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1258
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1259 1259
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1260 1260
 		} else {
1261 1261
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1264,7 +1264,7 @@  discard block
 block discarded – undo
1264 1264
 	    // If there was output, it's an error
1265 1265
 	    $warnings = ob_get_clean();
1266 1266
 
1267
-	    if( !empty( $warnings ) ) {
1267
+	    if ( ! empty( $warnings ) ) {
1268 1268
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1269 1269
 	    }
1270 1270
 
@@ -1289,7 +1289,7 @@  discard block
 block discarded – undo
1289 1289
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1290 1290
 
1291 1291
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1292
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1292
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1293 1293
 
1294 1294
 			$field_value = array();
1295 1295
 
@@ -1298,10 +1298,10 @@  discard block
 block discarded – undo
1298 1298
 
1299 1299
 			foreach ( (array)$field->inputs as $input ) {
1300 1300
 
1301
-				$input_id = strval( $input['id'] );
1301
+				$input_id = strval( $input[ 'id' ] );
1302 1302
 
1303 1303
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1304
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1304
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1305 1305
 				    $allow_pre_populated = false;
1306 1306
 				}
1307 1307
 
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 
1310 1310
 			$pre_value = $field->get_value_submission( array(), false );
1311 1311
 
1312
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1312
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1313 1313
 
1314 1314
 		} else {
1315 1315
 
@@ -1320,13 +1320,13 @@  discard block
 block discarded – undo
1320 1320
 
1321 1321
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1322 1322
 			// or pre-populated value if not empty and set to override saved value
1323
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1323
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1324 1324
 
1325 1325
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1326
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1326
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1327 1327
 				$categories = array();
1328 1328
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1329
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1329
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1330 1330
 				}
1331 1331
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1332 1332
 			}
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
 	     * @param GF_Field $field Gravity Forms field object
1355 1355
 	     * @param GravityView_Edit_Entry_Render $this Current object
1356 1356
 	     */
1357
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1357
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1358 1358
 
1359 1359
 		return $field_value;
1360 1360
 	}
@@ -1371,12 +1371,12 @@  discard block
 block discarded – undo
1371 1371
 	 */
1372 1372
 	public function gform_pre_validation( $form ) {
1373 1373
 
1374
-		if( ! $this->verify_nonce() ) {
1374
+		if ( ! $this->verify_nonce() ) {
1375 1375
 			return $form;
1376 1376
 		}
1377 1377
 
1378 1378
 		// Fix PHP warning regarding undefined index.
1379
-		foreach ( $form['fields'] as &$field) {
1379
+		foreach ( $form[ 'fields' ] as &$field ) {
1380 1380
 
1381 1381
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1382 1382
 			// expects certain field array items to be set.
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1385 1385
 			}
1386 1386
 
1387
-			switch( RGFormsModel::get_input_type( $field ) ) {
1387
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1388 1388
 
1389 1389
 				/**
1390 1390
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1398,26 +1398,26 @@  discard block
 block discarded – undo
1398 1398
 				    // Set the previous value
1399 1399
 				    $entry = $this->get_entry();
1400 1400
 
1401
-				    $input_name = 'input_'.$field->id;
1402
-				    $form_id = $form['id'];
1401
+				    $input_name = 'input_' . $field->id;
1402
+				    $form_id = $form[ 'id' ];
1403 1403
 
1404 1404
 				    $value = NULL;
1405 1405
 
1406 1406
 				    // Use the previous entry value as the default.
1407
-				    if( isset( $entry[ $field->id ] ) ) {
1407
+				    if ( isset( $entry[ $field->id ] ) ) {
1408 1408
 				        $value = $entry[ $field->id ];
1409 1409
 				    }
1410 1410
 
1411 1411
 				    // If this is a single upload file
1412
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1413
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1414
-				        $value = $file_path['url'];
1412
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1413
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1414
+				        $value = $file_path[ 'url' ];
1415 1415
 
1416 1416
 				    } else {
1417 1417
 
1418 1418
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1419 1419
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1420
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1420
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1421 1421
 
1422 1422
 				    }
1423 1423
 
@@ -1425,10 +1425,10 @@  discard block
 block discarded – undo
1425 1425
 
1426 1426
 				        // If there are fresh uploads, process and merge them.
1427 1427
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1428
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1428
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1429 1429
 				            $value = empty( $value ) ? '[]' : $value;
1430 1430
 				            $value = stripslashes_deep( $value );
1431
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1431
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1432 1432
 				        }
1433 1433
 
1434 1434
 				    } else {
@@ -1446,8 +1446,8 @@  discard block
 block discarded – undo
1446 1446
 
1447 1447
 				case 'number':
1448 1448
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1449
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1450
-				        $_POST['input_'.$field->id ] = NULL;
1449
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1450
+				        $_POST[ 'input_' . $field->id ] = NULL;
1451 1451
 				    }
1452 1452
 				    break;
1453 1453
 			}
@@ -1484,7 +1484,7 @@  discard block
 block discarded – undo
1484 1484
 		 * You can enter whatever you want!
1485 1485
 		 * We try validating, and customize the results using `self::custom_validation()`
1486 1486
 		 */
1487
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1487
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1488 1488
 
1489 1489
 		// Needed by the validate funtion
1490 1490
 		$failed_validation_page = NULL;
@@ -1492,14 +1492,14 @@  discard block
 block discarded – undo
1492 1492
 
1493 1493
 		// Prevent entry limit from running when editing an entry, also
1494 1494
 		// prevent form scheduling from preventing editing
1495
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1495
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1496 1496
 
1497 1497
 		// Hide fields depending on Edit Entry settings
1498
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1498
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1499 1499
 
1500 1500
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1501 1501
 
1502
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1502
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1503 1503
 	}
1504 1504
 
1505 1505
 
@@ -1522,7 +1522,7 @@  discard block
 block discarded – undo
1522 1522
 
1523 1523
 		$gv_valid = true;
1524 1524
 
1525
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1525
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1526 1526
 
1527 1527
 			$value = RGFormsModel::get_field_value( $field );
1528 1528
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1535,22 +1535,22 @@  discard block
 block discarded – undo
1535 1535
 				case 'post_image':
1536 1536
 
1537 1537
 				    // in case nothing is uploaded but there are already files saved
1538
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1538
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1539 1539
 				        $field->failed_validation = false;
1540 1540
 				        unset( $field->validation_message );
1541 1541
 				    }
1542 1542
 
1543 1543
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1544
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1544
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1545 1545
 
1546 1546
 				        $input_name = 'input_' . $field->id;
1547 1547
 				        //uploaded
1548
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1548
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1549 1549
 
1550 1550
 				        //existent
1551 1551
 				        $entry = $this->get_entry();
1552 1552
 				        $value = NULL;
1553
-				        if( isset( $entry[ $field->id ] ) ) {
1553
+				        if ( isset( $entry[ $field->id ] ) ) {
1554 1554
 				            $value = json_decode( $entry[ $field->id ], true );
1555 1555
 				        }
1556 1556
 
@@ -1558,13 +1558,13 @@  discard block
 block discarded – undo
1558 1558
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1559 1559
 						               ( is_array( $value ) ? count( $value ) : 0 );
1560 1560
 
1561
-				        if( $count_files > $field->maxFiles ) {
1561
+				        if ( $count_files > $field->maxFiles ) {
1562 1562
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1563 1563
 				            $field->failed_validation = 1;
1564 1564
 				            $gv_valid = false;
1565 1565
 
1566 1566
 				            // in case of error make sure the newest upload files are removed from the upload input
1567
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1567
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1568 1568
 				        }
1569 1569
 
1570 1570
 				    }
@@ -1575,7 +1575,7 @@  discard block
 block discarded – undo
1575 1575
 			}
1576 1576
 
1577 1577
 			// This field has failed validation.
1578
-			if( !empty( $field->failed_validation ) ) {
1578
+			if ( ! empty( $field->failed_validation ) ) {
1579 1579
 
1580 1580
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1581 1581
 
@@ -1593,19 +1593,19 @@  discard block
 block discarded – undo
1593 1593
 				}
1594 1594
 
1595 1595
 				// You can't continue inside a switch, so we do it after.
1596
-				if( empty( $field->failed_validation ) ) {
1596
+				if ( empty( $field->failed_validation ) ) {
1597 1597
 				    continue;
1598 1598
 				}
1599 1599
 
1600 1600
 				// checks if the No Duplicates option is not validating entry against itself, since
1601 1601
 				// we're editing a stored entry, it would also assume it's a duplicate.
1602
-				if( !empty( $field->noDuplicates ) ) {
1602
+				if ( ! empty( $field->noDuplicates ) ) {
1603 1603
 
1604 1604
 				    $entry = $this->get_entry();
1605 1605
 
1606 1606
 				    // If the value of the entry is the same as the stored value
1607 1607
 				    // Then we can assume it's not a duplicate, it's the same.
1608
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1608
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1609 1609
 				        //if value submitted was not changed, then don't validate
1610 1610
 				        $field->failed_validation = false;
1611 1611
 
@@ -1618,7 +1618,7 @@  discard block
 block discarded – undo
1618 1618
 				}
1619 1619
 
1620 1620
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1621
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1621
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1622 1622
 				    unset( $field->validation_message );
1623 1623
 	                $field->validation_message = false;
1624 1624
 				    continue;
@@ -1630,12 +1630,12 @@  discard block
 block discarded – undo
1630 1630
 
1631 1631
 		}
1632 1632
 
1633
-		$validation_results['is_valid'] = $gv_valid;
1633
+		$validation_results[ 'is_valid' ] = $gv_valid;
1634 1634
 
1635 1635
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1636 1636
 
1637 1637
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1638
-		$this->form_after_validation = $validation_results['form'];
1638
+		$this->form_after_validation = $validation_results[ 'form' ];
1639 1639
 
1640 1640
 		return $validation_results;
1641 1641
 	}
@@ -1648,7 +1648,7 @@  discard block
 block discarded – undo
1648 1648
 	 */
1649 1649
 	public function get_entry() {
1650 1650
 
1651
-		if( empty( $this->entry ) ) {
1651
+		if ( empty( $this->entry ) ) {
1652 1652
 			// Get the database value of the entry that's being edited
1653 1653
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1654 1654
 		}
@@ -1680,10 +1680,10 @@  discard block
 block discarded – undo
1680 1680
 		}
1681 1681
 
1682 1682
 		// If edit tab not yet configured, show all fields
1683
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1683
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1684 1684
 
1685 1685
 		// Hide fields depending on admin settings
1686
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1686
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1687 1687
 
1688 1688
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1689 1689
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1715,7 +1715,7 @@  discard block
 block discarded – undo
1715 1715
 	 */
1716 1716
 	private function filter_fields( $fields, $configured_fields ) {
1717 1717
 
1718
-		if( empty( $fields ) || !is_array( $fields ) ) {
1718
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1719 1719
 			return $fields;
1720 1720
 		}
1721 1721
 
@@ -1728,18 +1728,18 @@  discard block
 block discarded – undo
1728 1728
 
1729 1729
 			// Remove the fields that have calculation properties and keep them to be used later
1730 1730
 			// @since 1.16.2
1731
-			if( $field->has_calculation() ) {
1732
-				$this->fields_with_calculation[] = $field;
1731
+			if ( $field->has_calculation() ) {
1732
+				$this->fields_with_calculation[ ] = $field;
1733 1733
 				// don't remove the calculation fields on form render.
1734 1734
 			}
1735 1735
 
1736
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1736
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1737 1737
 				unset( $fields[ $key ] );
1738 1738
 			}
1739 1739
 		}
1740 1740
 
1741 1741
 		// The Edit tab has not been configured, so we return all fields by default.
1742
-		if( empty( $configured_fields ) ) {
1742
+		if ( empty( $configured_fields ) ) {
1743 1743
 			return array_values( $fields );
1744 1744
 		}
1745 1745
 
@@ -1748,8 +1748,8 @@  discard block
 block discarded – undo
1748 1748
 
1749 1749
 	        /** @var GF_Field $field */
1750 1750
 	        foreach ( $fields as $field ) {
1751
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1752
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1751
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1752
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1753 1753
 				    break;
1754 1754
 				}
1755 1755
 
@@ -1772,14 +1772,14 @@  discard block
 block discarded – undo
1772 1772
 
1773 1773
 		$return_field = $field;
1774 1774
 
1775
-		if( empty( $field_setting['show_label'] ) ) {
1775
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1776 1776
 			$return_field->label = '';
1777
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1778
-			$return_field->label = $field_setting['custom_label'];
1777
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1778
+			$return_field->label = $field_setting[ 'custom_label' ];
1779 1779
 		}
1780 1780
 
1781
-		if( !empty( $field_setting['custom_class'] ) ) {
1782
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1781
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1782
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1783 1783
 		}
1784 1784
 
1785 1785
 		/**
@@ -1817,16 +1817,16 @@  discard block
 block discarded – undo
1817 1817
 	     */
1818 1818
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1819 1819
 
1820
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1821
-			foreach( $fields as $k => $field ) {
1822
-				if( $field->adminOnly ) {
1820
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1821
+			foreach ( $fields as $k => $field ) {
1822
+				if ( $field->adminOnly ) {
1823 1823
 				    unset( $fields[ $k ] );
1824 1824
 				}
1825 1825
 			}
1826 1826
 			return array_values( $fields );
1827 1827
 		}
1828 1828
 
1829
-	    foreach( $fields as &$field ) {
1829
+	    foreach ( $fields as &$field ) {
1830 1830
 		    $field->adminOnly = false;
1831 1831
 		}
1832 1832
 
@@ -1847,7 +1847,7 @@  discard block
 block discarded – undo
1847 1847
 	 */
1848 1848
 	private function unselect_default_values( $form ) {
1849 1849
 
1850
-	    foreach ( $form['fields'] as &$field ) {
1850
+	    foreach ( $form[ 'fields' ] as &$field ) {
1851 1851
 
1852 1852
 			if ( empty( $field->choices ) ) {
1853 1853
                 continue;
@@ -1855,7 +1855,7 @@  discard block
 block discarded – undo
1855 1855
 
1856 1856
             foreach ( $field->choices as &$choice ) {
1857 1857
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1858
-					$choice['isSelected'] = false;
1858
+					$choice[ 'isSelected' ] = false;
1859 1859
 				}
1860 1860
 			}
1861 1861
 		}
@@ -1880,22 +1880,22 @@  discard block
 block discarded – undo
1880 1880
 	 */
1881 1881
 	function prefill_conditional_logic( $form ) {
1882 1882
 
1883
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1883
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1884 1884
 			return $form;
1885 1885
 		}
1886 1886
 
1887 1887
 		// Have Conditional Logic pre-fill fields as if the data were default values
1888 1888
 		/** @var GF_Field $field */
1889
-		foreach ( $form['fields'] as &$field ) {
1889
+		foreach ( $form[ 'fields' ] as &$field ) {
1890 1890
 
1891
-			if( 'checkbox' === $field->type ) {
1891
+			if ( 'checkbox' === $field->type ) {
1892 1892
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1893
-				    $input_id = $input['id'];
1893
+				    $input_id = $input[ 'id' ];
1894 1894
 				    $choice = $field->choices[ $key ];
1895 1895
 				    $value = \GV\Utils::get( $this->entry, $input_id );
1896 1896
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1897
-				    if( $match ) {
1898
-				        $field->choices[ $key ]['isSelected'] = true;
1897
+				    if ( $match ) {
1898
+				        $field->choices[ $key ][ 'isSelected' ] = true;
1899 1899
 				    }
1900 1900
 				}
1901 1901
 			} else {
@@ -1903,15 +1903,15 @@  discard block
 block discarded – undo
1903 1903
 				// We need to run through each field to set the default values
1904 1904
 				foreach ( $this->entry as $field_id => $field_value ) {
1905 1905
 
1906
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1906
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
1907 1907
 
1908
-				        if( 'list' === $field->type ) {
1908
+				        if ( 'list' === $field->type ) {
1909 1909
 				            $list_rows = maybe_unserialize( $field_value );
1910 1910
 
1911 1911
 				            $list_field_value = array();
1912
-				            foreach ( (array) $list_rows as $row ) {
1913
-				                foreach ( (array) $row as $column ) {
1914
-				                    $list_field_value[] = $column;
1912
+				            foreach ( (array)$list_rows as $row ) {
1913
+				                foreach ( (array)$row as $column ) {
1914
+				                    $list_field_value[ ] = $column;
1915 1915
 				                }
1916 1916
 				            }
1917 1917
 
@@ -1946,16 +1946,16 @@  discard block
 block discarded – undo
1946 1946
 		 */
1947 1947
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1948 1948
 
1949
-		if( $use_conditional_logic ) {
1949
+		if ( $use_conditional_logic ) {
1950 1950
 			return $form;
1951 1951
 		}
1952 1952
 
1953
-		foreach( $form['fields'] as &$field ) {
1953
+		foreach ( $form[ 'fields' ] as &$field ) {
1954 1954
 			/* @var GF_Field $field */
1955 1955
 			$field->conditionalLogic = null;
1956 1956
 		}
1957 1957
 
1958
-		unset( $form['button']['conditionalLogic'] );
1958
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
1959 1959
 
1960 1960
 		return $form;
1961 1961
 
@@ -1972,7 +1972,7 @@  discard block
 block discarded – undo
1972 1972
 	 */
1973 1973
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
1974 1974
 
1975
-		if( ! $this->is_edit_entry() ) {
1975
+		if ( ! $this->is_edit_entry() ) {
1976 1976
 			return $has_conditional_logic;
1977 1977
 		}
1978 1978
 
@@ -2004,44 +2004,44 @@  discard block
 block discarded – undo
2004 2004
 		 *  2. There are two entries embedded using oEmbed
2005 2005
 		 *  3. One of the entries has just been saved
2006 2006
 		 */
2007
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2007
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2008 2008
 
2009 2009
 			$error = true;
2010 2010
 
2011 2011
 		}
2012 2012
 
2013
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2013
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2014 2014
 
2015 2015
 			$error = true;
2016 2016
 
2017
-		} elseif( ! $this->verify_nonce() ) {
2017
+		} elseif ( ! $this->verify_nonce() ) {
2018 2018
 
2019 2019
 			/**
2020 2020
 			 * If the Entry is embedded, there may be two entries on the same page.
2021 2021
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2022 2022
 			 */
2023
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2023
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2024 2024
 				$error = true;
2025 2025
 			} else {
2026
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2026
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2027 2027
 			}
2028 2028
 
2029 2029
 		}
2030 2030
 
2031
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2032
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2031
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2032
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2033 2033
 		}
2034 2034
 
2035
-		if( $this->entry['status'] === 'trash' ) {
2036
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2035
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2036
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2037 2037
 		}
2038 2038
 
2039 2039
 		// No errors; everything's fine here!
2040
-		if( empty( $error ) ) {
2040
+		if ( empty( $error ) ) {
2041 2041
 			return true;
2042 2042
 		}
2043 2043
 
2044
-		if( $echo && $error !== true ) {
2044
+		if ( $echo && $error !== true ) {
2045 2045
 
2046 2046
 	        $error = esc_html( $error );
2047 2047
 
@@ -2049,10 +2049,10 @@  discard block
 block discarded – undo
2049 2049
 	         * @since 1.9
2050 2050
 	         */
2051 2051
 	        if ( ! empty( $this->entry ) ) {
2052
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2052
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2053 2053
 	        }
2054 2054
 
2055
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2055
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2056 2056
 		}
2057 2057
 
2058 2058
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2072,17 +2072,17 @@  discard block
 block discarded – undo
2072 2072
 
2073 2073
 		$error = NULL;
2074 2074
 
2075
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2076
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2075
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2076
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2077 2077
 		}
2078 2078
 
2079 2079
 		// No errors; everything's fine here!
2080
-		if( empty( $error ) ) {
2080
+		if ( empty( $error ) ) {
2081 2081
 			return true;
2082 2082
 		}
2083 2083
 
2084
-		if( $echo ) {
2085
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2084
+		if ( $echo ) {
2085
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2086 2086
 		}
2087 2087
 
2088 2088
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2103,14 +2103,14 @@  discard block
 block discarded – undo
2103 2103
 	private function check_user_cap_edit_field( $field ) {
2104 2104
 
2105 2105
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2106
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2106
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2107 2107
 			return true;
2108 2108
 		}
2109 2109
 
2110
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2110
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2111 2111
 
2112
-		if( $field_cap ) {
2113
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2112
+		if ( $field_cap ) {
2113
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2114 2114
 		}
2115 2115
 
2116 2116
 		return false;
@@ -2124,17 +2124,17 @@  discard block
 block discarded – undo
2124 2124
 	public function verify_nonce() {
2125 2125
 
2126 2126
 		// Verify form submitted for editing single
2127
-		if( $this->is_edit_entry_submission() ) {
2127
+		if ( $this->is_edit_entry_submission() ) {
2128 2128
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2129 2129
 		}
2130 2130
 
2131 2131
 		// Verify
2132
-		else if( ! $this->is_edit_entry() ) {
2132
+		else if ( ! $this->is_edit_entry() ) {
2133 2133
 			$valid = false;
2134 2134
 		}
2135 2135
 
2136 2136
 		else {
2137
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2137
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2138 2138
 		}
2139 2139
 
2140 2140
 		/**
Please login to merge, or discard this patch.
includes/class-admin-approve-entries.php 1 patch
Spacing   +65 added lines, -65 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 		/** gf_entries page - entries table screen */
45 45
 
46 46
 		// capture bulk actions
47
-		add_action( 'gform_loaded', array( $this, 'process_bulk_action') );
47
+		add_action( 'gform_loaded', array( $this, 'process_bulk_action' ) );
48 48
 
49 49
 		// add hidden field with approve status
50 50
 		add_action( 'gform_entries_first_column_actions', array( $this, 'add_entry_approved_hidden_input' ), 1, 5 );
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		add_filter( 'gravityview/metaboxes/tooltips', array( $this, 'tooltips' ) );
53 53
 
54 54
 		// adding styles and scripts
55
-		add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles') );
55
+		add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ) );
56 56
 		// bypass Gravity Forms no-conflict mode
57 57
 		add_filter( 'gform_noconflict_scripts', array( $this, 'register_gform_noconflict_script' ) );
58 58
 		add_filter( 'gform_noconflict_styles', array( $this, 'register_gform_noconflict_style' ) );
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 		 * @param bool $show_filter_links True: show the "approved"/"disapproved" filter links. False: hide them.
82 82
 		 * @param array $form GF Form object of current form
83 83
 		 */
84
-		if( false === apply_filters( 'gravityview/approve_entries/show_filter_links_entry_list', true, $form ) ) {
84
+		if ( false === apply_filters( 'gravityview/approve_entries/show_filter_links_entry_list', true, $form ) ) {
85 85
 			return $filter_links;
86 86
 		}
87 87
 
@@ -109,27 +109,27 @@  discard block
 block discarded – undo
109 109
 		$approved_count = $disapproved_count = $unapproved_count = 0;
110 110
 
111 111
 		// Only count if necessary
112
-		if( $include_counts ) {
113
-			$approved_count = count( gravityview_get_entry_ids( $form['id'], array( 'status' => 'active', 'field_filters' => $field_filters_approved ) ) );
114
-			$disapproved_count = count( gravityview_get_entry_ids( $form['id'], array( 'status' => 'active', 'field_filters' => $field_filters_disapproved ) ) );
115
-			$unapproved_count = count( gravityview_get_entry_ids( $form['id'], array( 'status' => 'active', 'field_filters' => $field_filters_unapproved ) ) );
112
+		if ( $include_counts ) {
113
+			$approved_count = count( gravityview_get_entry_ids( $form[ 'id' ], array( 'status' => 'active', 'field_filters' => $field_filters_approved ) ) );
114
+			$disapproved_count = count( gravityview_get_entry_ids( $form[ 'id' ], array( 'status' => 'active', 'field_filters' => $field_filters_disapproved ) ) );
115
+			$unapproved_count = count( gravityview_get_entry_ids( $form[ 'id' ], array( 'status' => 'active', 'field_filters' => $field_filters_unapproved ) ) );
116 116
 		}
117 117
 
118
-		$filter_links[] = array(
118
+		$filter_links[ ] = array(
119 119
 			'id'            => 'gv_approved',
120 120
 			'field_filters' => $field_filters_approved,
121 121
 			'count'         => $approved_count,
122 122
 			'label'         => GravityView_Entry_Approval_Status::get_label( GravityView_Entry_Approval_Status::APPROVED ),
123 123
 		);
124 124
 
125
-		$filter_links[] = array(
125
+		$filter_links[ ] = array(
126 126
 			'id'            => 'gv_disapproved',
127 127
 			'field_filters' => $field_filters_disapproved,
128 128
 			'count'         => $disapproved_count,
129 129
 			'label'         => GravityView_Entry_Approval_Status::get_label( GravityView_Entry_Approval_Status::DISAPPROVED ),
130 130
 		);
131 131
 
132
-		$filter_links[] = array(
132
+		$filter_links[ ] = array(
133 133
 			'id'            => 'gv_unapproved',
134 134
 			'field_filters' => $field_filters_unapproved,
135 135
 			'count'         => $unapproved_count,
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
148 148
 	 */
149 149
 	function tooltips( $tooltips ) {
150 150
 
151
-		$tooltips['form_gravityview_fields'] = array(
152
-			'title' => __('GravityView Fields', 'gravityview'),
153
-			'value' => __( 'Allow administrators to approve or reject entries and users to opt-in or opt-out of their entries being displayed.', 'gravityview'),
151
+		$tooltips[ 'form_gravityview_fields' ] = array(
152
+			'title' => __( 'GravityView Fields', 'gravityview' ),
153
+			'value' => __( 'Allow administrators to approve or reject entries and users to opt-in or opt-out of their entries being displayed.', 'gravityview' ),
154 154
 		);
155 155
 
156 156
 		return $tooltips;
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 
262 262
 		$gv_bulk_action = false;
263 263
 
264
-		if( version_compare( GFForms::$version, '2.0', '>=' ) ) {
264
+		if ( version_compare( GFForms::$version, '2.0', '>=' ) ) {
265 265
 			$bulk_action = ( '-1' !== \GV\Utils::_POST( 'action' ) ) ? \GV\Utils::_POST( 'action' ) : \GV\Utils::_POST( 'action2' );
266 266
 		} else {
267 267
 			// GF 1.9.x - Bulk action 2 is the bottom bulk action select form.
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 		}
270 270
 
271 271
 		// Check the $bulk_action value against GV actions, see if they're the same. I hate strpos().
272
-		if( ! empty( $bulk_action ) && preg_match( '/^('. implode( '|', $this->bulk_action_prefixes ) .')/ism', $bulk_action ) ) {
272
+		if ( ! empty( $bulk_action ) && preg_match( '/^(' . implode( '|', $this->bulk_action_prefixes ) . ')/ism', $bulk_action ) ) {
273 273
 			$gv_bulk_action = $bulk_action;
274 274
 		}
275 275
 
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 
295 295
 		// gforms_entry_list is the nonce that confirms we're on the right page
296 296
 		// gforms_update_note is sent when bulk editing entry notes. We don't want to process then.
297
-		if ( $bulk_action && \GV\Utils::_POST( 'gforms_entry_list' ) && empty( $_POST['gforms_update_note'] ) ) {
297
+		if ( $bulk_action && \GV\Utils::_POST( 'gforms_entry_list' ) && empty( $_POST[ 'gforms_update_note' ] ) ) {
298 298
 
299 299
 			check_admin_referer( 'gforms_entry_list', 'gforms_entry_list' );
300 300
 
@@ -312,13 +312,13 @@  discard block
 block discarded – undo
312 312
 			}
313 313
 
314 314
 			// All entries are set to be updated, not just the visible ones
315
-			if ( ! empty( $_POST['all_entries'] ) ) {
315
+			if ( ! empty( $_POST[ 'all_entries' ] ) ) {
316 316
 
317 317
 				// Convert the current entry search into GF-formatted search criteria
318 318
 				$search = array(
319
-					'search_field' => isset( $_POST['f'] ) ? $_POST['f'][0] : 0,
320
-					'search_value' => isset( $_POST['v'][0] ) ? $_POST['v'][0] : '',
321
-					'search_operator' => isset( $_POST['o'][0] ) ? $_POST['o'][0] : 'contains',
319
+					'search_field' => isset( $_POST[ 'f' ] ) ? $_POST[ 'f' ][ 0 ] : 0,
320
+					'search_value' => isset( $_POST[ 'v' ][ 0 ] ) ? $_POST[ 'v' ][ 0 ] : '',
321
+					'search_operator' => isset( $_POST[ 'o' ][ 0 ] ) ? $_POST[ 'o' ][ 0 ] : 'contains',
322 322
 				);
323 323
 
324 324
 				$search_criteria = GravityView_frontend::get_search_criteria( $search, $form_id );
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 			} else {
330 330
 
331 331
 				// Changed from 'lead' to 'entry' in 2.0
332
-				$entries = isset( $_POST['lead'] ) ? $_POST['lead'] : $_POST['entry'];
332
+				$entries = isset( $_POST[ 'lead' ] ) ? $_POST[ 'lead' ] : $_POST[ 'entry' ];
333 333
 
334 334
 			}
335 335
 
@@ -341,15 +341,15 @@  discard block
 block discarded – undo
341 341
 			$entry_count = count( $entries ) > 1 ? sprintf( __( '%d entries', 'gravityview' ), count( $entries ) ) : __( '1 entry', 'gravityview' );
342 342
 
343 343
 			switch ( $approved_status ) {
344
-				case $this->bulk_action_prefixes['approve']:
344
+				case $this->bulk_action_prefixes[ 'approve' ]:
345 345
 					GravityView_Entry_Approval::update_bulk( $entries, GravityView_Entry_Approval_Status::APPROVED, $form_id );
346 346
 					$this->bulk_update_message = sprintf( __( '%s approved.', 'gravityview' ), $entry_count );
347 347
 					break;
348
-				case $this->bulk_action_prefixes['unapprove']:
348
+				case $this->bulk_action_prefixes[ 'unapprove' ]:
349 349
 					GravityView_Entry_Approval::update_bulk( $entries, GravityView_Entry_Approval_Status::UNAPPROVED, $form_id );
350 350
 					$this->bulk_update_message = sprintf( __( '%s unapproved.', 'gravityview' ), $entry_count );
351 351
 					break;
352
-				case $this->bulk_action_prefixes['disapprove']:
352
+				case $this->bulk_action_prefixes[ 'disapprove' ]:
353 353
 					GravityView_Entry_Approval::update_bulk( $entries, GravityView_Entry_Approval_Status::DISAPPROVED, $form_id );
354 354
 					$this->bulk_update_message = sprintf( __( '%s disapproved.', 'gravityview' ), $entry_count );
355 355
 					break;
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
      *
372 372
 	 * @return boolean True: It worked; False: it failed
373 373
 	 */
374
-	public static function update_approved( $entry_id = 0, $approved = 0, $form_id = 0, $approvedcolumn = 0) {
374
+	public static function update_approved( $entry_id = 0, $approved = 0, $form_id = 0, $approvedcolumn = 0 ) {
375 375
 		return GravityView_Entry_Approval::update_approved( $entry_id, $approved, $form_id, $approvedcolumn );
376 376
 	}
377 377
 
@@ -401,20 +401,20 @@  discard block
 block discarded – undo
401 401
 	 *
402 402
 	 * @return void
403 403
 	 */
404
-	static public function add_entry_approved_hidden_input(  $form_id, $field_id, $value, $entry, $query_string ) {
404
+	static public function add_entry_approved_hidden_input( $form_id, $field_id, $value, $entry, $query_string ) {
405 405
 
406
-		if( ! GVCommon::has_cap( 'gravityview_moderate_entries', $entry['id'] ) ) {
406
+		if ( ! GVCommon::has_cap( 'gravityview_moderate_entries', $entry[ 'id' ] ) ) {
407 407
 			return;
408 408
 		}
409 409
 
410
-		if( empty( $entry['id'] ) ) {
410
+		if ( empty( $entry[ 'id' ] ) ) {
411 411
 			return;
412 412
 		}
413 413
 
414 414
 		$status_value = GravityView_Entry_Approval::get_entry_status( $entry, 'value' );
415 415
 
416
-		if( $status_value ) {
417
-			echo '<input type="hidden" class="entry_approval" id="entry_approved_'. $entry['id'] .'" value="' . esc_attr( $status_value ) . '" />';
416
+		if ( $status_value ) {
417
+			echo '<input type="hidden" class="entry_approval" id="entry_approved_' . $entry[ 'id' ] . '" value="' . esc_attr( $status_value ) . '" />';
418 418
 		}
419 419
 	}
420 420
 
@@ -427,10 +427,10 @@  discard block
 block discarded – undo
427 427
 	 */
428 428
 	private function get_form_id() {
429 429
 
430
-		$form_id = GFForms::get('id');
430
+		$form_id = GFForms::get( 'id' );
431 431
 
432 432
 		// If there are no forms identified, use the first form. That's how GF does it.
433
-		if( empty( $form_id ) && class_exists('RGFormsModel') ) {
433
+		if ( empty( $form_id ) && class_exists( 'RGFormsModel' ) ) {
434 434
 			$form_id = $this->get_first_form_id();
435 435
 		}
436 436
 
@@ -450,14 +450,14 @@  discard block
 block discarded – undo
450 450
 
451 451
 		$forms = RGFormsModel::get_forms( null, 'title' );
452 452
 
453
-		if( ! isset( $forms[0] ) ) {
453
+		if ( ! isset( $forms[ 0 ] ) ) {
454 454
 			gravityview()->log->error( 'No forms were found' );
455 455
 			return 0;
456 456
 		}
457 457
 
458
-		$first_form = $forms[0];
458
+		$first_form = $forms[ 0 ];
459 459
 
460
-		$form_id = is_object( $forms[0] ) ? $first_form->id : $first_form['id'];
460
+		$form_id = is_object( $forms[ 0 ] ) ? $first_form->id : $first_form[ 'id' ];
461 461
 
462 462
 		return intval( $form_id );
463 463
 	}
@@ -465,37 +465,37 @@  discard block
 block discarded – undo
465 465
 
466 466
 	function add_scripts_and_styles( $hook ) {
467 467
 
468
-		if( ! class_exists( 'GFForms' ) ) {
468
+		if ( ! class_exists( 'GFForms' ) ) {
469 469
 			gravityview()->log->error( 'GFForms does not exist.' );
470 470
 			return;
471 471
 		}
472 472
 
473 473
 		// enqueue styles & scripts gf_entries
474 474
 		// But only if we're on the main Entries page, not on reports pages
475
-		if( GFForms::get_page() !== 'entry_list' ) {
475
+		if ( GFForms::get_page() !== 'entry_list' ) {
476 476
 			return;
477 477
 		}
478 478
 
479 479
 		$form_id = $this->get_form_id();
480 480
 
481 481
 		// Things are broken; no forms were found
482
-		if( empty( $form_id ) ) {
482
+		if ( empty( $form_id ) ) {
483 483
 			return;
484 484
 		}
485 485
 
486
-		wp_enqueue_style( 'gravityview_entries_list', plugins_url('assets/css/admin-entries-list.css', GRAVITYVIEW_FILE), array(), GravityView_Plugin::version );
486
+		wp_enqueue_style( 'gravityview_entries_list', plugins_url( 'assets/css/admin-entries-list.css', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
487 487
 
488
-		$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
488
+		$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
489 489
 
490
-		wp_enqueue_script( 'gravityview_gf_entries_scripts', plugins_url('assets/js/admin-entries-list'.$script_debug.'.js', GRAVITYVIEW_FILE), array( 'jquery' ), GravityView_Plugin::version );
490
+		wp_enqueue_script( 'gravityview_gf_entries_scripts', plugins_url( 'assets/js/admin-entries-list' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version );
491 491
 
492 492
 		wp_enqueue_script( 'gravityview_entries_list-popper', plugins_url( 'assets/lib/tippy/popper.min.js', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
493 493
 		wp_enqueue_script( 'gravityview_entries_list-tippy', plugins_url( 'assets/lib/tippy/tippy.min.js', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
494 494
 		wp_enqueue_style( 'gravityview_entries_list-tippy', plugins_url( 'assets/lib/tippy/tippy.css', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
495 495
 
496 496
 		wp_localize_script( 'gravityview_gf_entries_scripts', 'gvGlobals', array(
497
-			'nonce' => wp_create_nonce( 'gravityview_entry_approval'),
498
-			'admin_nonce' => wp_create_nonce( 'gravityview_admin_entry_approval'),
497
+			'nonce' => wp_create_nonce( 'gravityview_entry_approval' ),
498
+			'admin_nonce' => wp_create_nonce( 'gravityview_admin_entry_approval' ),
499 499
 			'form_id' => $form_id,
500 500
 			'show_column' => (int)$this->show_approve_entry_column( $form_id ),
501 501
 			'add_bulk_action' => (int)GVCommon::has_cap( 'gravityview_moderate_entries' ),
@@ -504,10 +504,10 @@  discard block
 block discarded – undo
504 504
 			'status_unapproved' => GravityView_Entry_Approval_Status::UNAPPROVED,
505 505
 			'bulk_actions' => $this->get_bulk_actions( $form_id ),
506 506
 			'bulk_message' => $this->bulk_update_message,
507
-			'unapprove_title' => GravityView_Entry_Approval_Status::get_title_attr('unapproved'),
508
-            'approve_title' => GravityView_Entry_Approval_Status::get_title_attr('disapproved'),
509
-			'disapprove_title' => GravityView_Entry_Approval_Status::get_title_attr('approved'),
510
-			'column_title' => __( 'Show entry in directory view?', 'gravityview'),
507
+			'unapprove_title' => GravityView_Entry_Approval_Status::get_title_attr( 'unapproved' ),
508
+            'approve_title' => GravityView_Entry_Approval_Status::get_title_attr( 'disapproved' ),
509
+			'disapprove_title' => GravityView_Entry_Approval_Status::get_title_attr( 'approved' ),
510
+			'column_title' => __( 'Show entry in directory view?', 'gravityview' ),
511 511
 			'column_link' => esc_url( $this->get_sort_link() ),
512 512
             'status_popover_template' => GravityView_Entry_Approval::get_popover_template(),
513 513
 			'status_popover_placement' => GravityView_Entry_Approval::get_popover_placement(),
@@ -551,16 +551,16 @@  discard block
 block discarded – undo
551 551
 		$bulk_actions = array(
552 552
 			'GravityView' => array(
553 553
 				array(
554
-					'label' => GravityView_Entry_Approval_Status::get_string('approved', 'action'),
555
-					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes['approve'], $form_id ),
554
+					'label' => GravityView_Entry_Approval_Status::get_string( 'approved', 'action' ),
555
+					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes[ 'approve' ], $form_id ),
556 556
 				),
557 557
 				array(
558
-					'label' => GravityView_Entry_Approval_Status::get_string('disapproved', 'action'),
559
-					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes['disapprove'], $form_id ),
558
+					'label' => GravityView_Entry_Approval_Status::get_string( 'disapproved', 'action' ),
559
+					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes[ 'disapprove' ], $form_id ),
560 560
 				),
561 561
 				array(
562
-					'label' => GravityView_Entry_Approval_Status::get_string('unapproved', 'action'),
563
-					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes['unapprove'], $form_id ),
562
+					'label' => GravityView_Entry_Approval_Status::get_string( 'unapproved', 'action' ),
563
+					'value' => sprintf( '%s-%d', $this->bulk_action_prefixes[ 'unapprove' ], $form_id ),
564 564
 				),
565 565
 			),
566 566
 		);
@@ -577,13 +577,13 @@  discard block
 block discarded – undo
577 577
 		// Sanitize the values, just to be sure.
578 578
 		foreach ( $bulk_actions as $key => $group ) {
579 579
 
580
-		    if( empty( $group ) ) {
580
+		    if ( empty( $group ) ) {
581 581
 		        continue;
582 582
 		    }
583 583
 
584 584
 			foreach ( $group as $i => $action ) {
585
-				$bulk_actions[ $key ][ $i ]['label'] = esc_html( $bulk_actions[ $key ][ $i ]['label'] );
586
-				$bulk_actions[ $key ][ $i ]['value'] = esc_attr( $bulk_actions[ $key ][ $i ]['value'] );
585
+				$bulk_actions[ $key ][ $i ][ 'label' ] = esc_html( $bulk_actions[ $key ][ $i ][ 'label' ] );
586
+				$bulk_actions[ $key ][ $i ][ 'value' ] = esc_attr( $bulk_actions[ $key ][ $i ][ 'value' ] );
587 587
 			}
588 588
 		}
589 589
 
@@ -608,13 +608,13 @@  discard block
 block discarded – undo
608 608
 		 * @since 1.7.2
609 609
 		 * @param boolean $hide_if_no_connections
610 610
 		 */
611
-		$hide_if_no_connections = apply_filters('gravityview/approve_entries/hide-if-no-connections', false );
611
+		$hide_if_no_connections = apply_filters( 'gravityview/approve_entries/hide-if-no-connections', false );
612 612
 
613
-		if( $hide_if_no_connections ) {
613
+		if ( $hide_if_no_connections ) {
614 614
 
615 615
 			$connected_views = gravityview_get_connected_views( $form_id );
616 616
 
617
-			if( empty( $connected_views ) ) {
617
+			if ( empty( $connected_views ) ) {
618 618
 				$show_approve_column = false;
619 619
 			}
620 620
 		}
@@ -624,21 +624,21 @@  discard block
 block discarded – undo
624 624
 		 * @param boolean $show_approve_column Whether the column will be shown
625 625
 		 * @param int $form_id The ID of the Gravity Forms form for which entries are being shown
626 626
 		 */
627
-		$show_approve_column = apply_filters('gravityview/approve_entries/show-column', $show_approve_column, $form_id );
627
+		$show_approve_column = apply_filters( 'gravityview/approve_entries/show-column', $show_approve_column, $form_id );
628 628
 
629 629
 		return $show_approve_column;
630 630
 	}
631 631
 
632 632
 	function register_gform_noconflict_script( $scripts ) {
633
-		$scripts[] = 'gravityview_gf_entries_scripts';
634
-		$scripts[] = 'gravityview_entries_list-popper';
635
-		$scripts[] = 'gravityview_entries_list-tippy';
633
+		$scripts[ ] = 'gravityview_gf_entries_scripts';
634
+		$scripts[ ] = 'gravityview_entries_list-popper';
635
+		$scripts[ ] = 'gravityview_entries_list-tippy';
636 636
 		return $scripts;
637 637
 	}
638 638
 
639 639
 	function register_gform_noconflict_style( $styles ) {
640
-		$styles[] = 'gravityview_entries_list';
641
-		$styles[] = 'gravityview_entries_list-tippy';
640
+		$styles[ ] = 'gravityview_entries_list';
641
+		$styles[ ] = 'gravityview_entries_list-tippy';
642 642
 		return $styles;
643 643
 	}
644 644
 
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-approval.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 
25 25
 		$this->label = esc_attr__( 'Approve Entries', 'gravityview' );
26 26
 
27
-		$this->description =  esc_attr__( 'Approve and reject entries from the View.', 'gravityview' );
27
+		$this->description = esc_attr__( 'Approve and reject entries from the View.', 'gravityview' );
28 28
 
29 29
 		$this->add_hooks();
30 30
 
@@ -46,11 +46,11 @@  discard block
 block discarded – undo
46 46
 	 */
47 47
 	function field_options( $field_options, $template_id = '', $field_id = '', $context = '', $input_type = '' ) {
48 48
 
49
-		unset( $field_options['only_loggedin'] );
49
+		unset( $field_options[ 'only_loggedin' ] );
50 50
 
51
-		unset( $field_options['new_window'] );
51
+		unset( $field_options[ 'new_window' ] );
52 52
 
53
-		unset( $field_options['show_as_link'] );
53
+		unset( $field_options[ 'show_as_link' ] );
54 54
 
55 55
 		return $field_options;
56 56
 	}
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 		add_action( 'gravityview/field/approval/load_scripts', array( $this, 'enqueue_and_localize_script' ) );
72 72
 
73
-		add_action( 'gravityview_datatables_scripts_styles',  array( $this, 'enqueue_and_localize_script' ) );
73
+		add_action( 'gravityview_datatables_scripts_styles', array( $this, 'enqueue_and_localize_script' ) );
74 74
 
75 75
 		add_filter( 'gravityview_get_entries', array( $this, 'modify_search_parameters' ), 1000 );
76 76
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	public function maybe_prevent_field_render( $html, $args ) {
93 93
 
94 94
 		// If the field is `entry_approval` type but the user doesn't have the moderate entries cap, don't render.
95
-		if( $this->name === \GV\Utils::get( $args['field'], 'id' ) && ! GVCommon::has_cap('gravityview_moderate_entries') ) {
95
+		if ( $this->name === \GV\Utils::get( $args[ 'field' ], 'id' ) && ! GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
96 96
 			return '';
97 97
 		}
98 98
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	public function modify_search_parameters( $parameters ) {
123 123
 
124 124
 		if ( $this->name === \GV\Utils::get( $parameters, 'sorting/key' ) ) {
125
-			$parameters['sorting']['key'] = 'is_approved';
125
+			$parameters[ 'sorting' ][ 'key' ] = 'is_approved';
126 126
 		}
127 127
 
128 128
 		return $parameters;
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	function register_scripts_and_styles() {
139 139
 		$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
140 140
 
141
-		wp_register_script( 'gravityview-field-approval', GRAVITYVIEW_URL . 'assets/js/field-approval'.$script_debug.'.js', array( 'jquery' ), GravityView_Plugin::version, true );
141
+		wp_register_script( 'gravityview-field-approval', GRAVITYVIEW_URL . 'assets/js/field-approval' . $script_debug . '.js', array( 'jquery' ), GravityView_Plugin::version, true );
142 142
 
143 143
 		wp_register_script( 'gravityview-field-approval-popper', GRAVITYVIEW_URL . 'assets/lib/tippy/popper.min.js', array(), GravityView_Plugin::version, true );
144 144
 		wp_register_script( 'gravityview-field-approval-tippy', GRAVITYVIEW_URL . 'assets/lib/tippy/tippy.min.js', array(), GravityView_Plugin::version, true );
@@ -146,14 +146,14 @@  discard block
 block discarded – undo
146 146
 
147 147
 		$style_path = GRAVITYVIEW_DIR . 'templates/css/field-approval.css';
148 148
 
149
-		if( class_exists( 'GravityView_View' ) ) {
149
+		if ( class_exists( 'GravityView_View' ) ) {
150 150
 			/**
151 151
 			 * Override CSS file by placing in your theme's /gravityview/css/ sub-directory.
152 152
 			 */
153 153
 			$style_path = GravityView_View::getInstance()->locate_template( 'css/field-approval.css', false );
154 154
 		}
155 155
 
156
-		$style_url = plugins_url( 'css/field-approval.css', trailingslashit( dirname( $style_path ) )  );
156
+		$style_url = plugins_url( 'css/field-approval.css', trailingslashit( dirname( $style_path ) ) );
157 157
 
158 158
 		/**
159 159
 		 * @filter `gravityview/field/approval/css_url` URL to the Approval field CSS file.
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 		 */
163 163
 		$style_url = apply_filters( 'gravityview/field/approval/css_url', $style_url );
164 164
 
165
-		if( ! empty( $style_url ) ) {
165
+		if ( ! empty( $style_url ) ) {
166 166
 			wp_register_style( 'gravityview-field-approval', $style_url, array( 'dashicons' ), GravityView_Plugin::version, 'screen' );
167 167
 		}
168 168
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 	public function enqueue_and_localize_script() {
178 178
 
179 179
 		// The script is already registered and enqueued
180
-		if( wp_script_is( 'gravityview-field-approval', 'enqueued' ) ) {
180
+		if ( wp_script_is( 'gravityview-field-approval', 'enqueued' ) ) {
181 181
 			return;
182 182
 		}
183 183
 
@@ -190,11 +190,11 @@  discard block
 block discarded – undo
190 190
 
191 191
 		wp_localize_script( 'gravityview-field-approval', 'gvApproval', array(
192 192
 			'ajaxurl' => admin_url( 'admin-ajax.php' ),
193
-			'nonce' => wp_create_nonce('gravityview_entry_approval'),
193
+			'nonce' => wp_create_nonce( 'gravityview_entry_approval' ),
194 194
 			'status' => GravityView_Entry_Approval_Status::get_all(),
195 195
 			'status_popover_template' => GravityView_Entry_Approval::get_popover_template(),
196 196
 			'status_popover_placement' => GravityView_Entry_Approval::get_popover_placement(),
197
-		));
197
+		) );
198 198
 
199 199
 	}
200 200
 
@@ -211,8 +211,8 @@  discard block
 block discarded – undo
211 211
 	 */
212 212
 	public function filter_gravityview_entry_default_field( $entry_default_fields, $form, $context ) {
213 213
 
214
-		if ( ! isset( $entry_default_fields["{$this->name}"] ) && 'edit' !== $context ) {
215
-			$entry_default_fields["{$this->name}"] = array(
214
+		if ( ! isset( $entry_default_fields[ "{$this->name}" ] ) && 'edit' !== $context ) {
215
+			$entry_default_fields[ "{$this->name}" ] = array(
216 216
 				'label' => $this->label,
217 217
 				'desc'  => $this->description,
218 218
 				'type'  => $this->name,
Please login to merge, or discard this patch.