Inspection of "2.1 [WIP]" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1147)

by Gennady

created 2018-09-06 17:57 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 			printf( '<body style="padding: 0; margin: 0; font-family: -apple-system, BlinkMacSystemFont, \'Segoe UI\', Roboto, Oxygen-Sans, Ubuntu, Cantarell, \'Helvetica Neue\', sans-serif;">' );
 			printf( '<img src="' . plugins_url( 'assets/images/astronaut-200x263.png', GRAVITYVIEW_FILE ) . '" alt="The GravityView Astronaut Says:" style="float: left; height: 60px; margin-right : 10px;" />' );
 			printf( __( "%sGravityView requires PHP Version %s or newer.%s \n\nYou're using Version %s. Please ask your host to upgrade your server's PHP.", 'gravityview' ),
-				'<h3 style="font-size:16px; margin: 0 0 8px 0;">', GV_MIN_PHP_VERSION , "</h3>\n\n", $version );
+				'<h3 style="font-size:16px; margin: 0 0 8px 0;">', GV_MIN_PHP_VERSION, "</h3>\n\n", $version );
 			printf( '</body>' );
 		}
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 }
 
 /** The future branch of GravityView requires PHP 5.3+ namespaces and SPL. */
-if ( version_compare( phpversion(), '5.3.0' , '<' ) ) {
+if ( version_compare( phpversion(), '5.3.0', '<' ) ) {
 	require GRAVITYVIEW_DIR . 'future/_stubs.php';
 
 /** All looks fine. */

Please login to merge, or discard this patch.

future/includes/class-gv-renderer.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
 		$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
 		$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
 
-		$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
+		$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
 		$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
 
 		echo \GVCommon::generate_notice( $output . $image, 'gv-error error', 'edit_gravityview', $gravityview->view->ID );

Please login to merge, or discard this patch.

future/includes/class-gv-view.php 4 patches

Indentation -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,6 @@
 block discarded – undo
 	 *
 	 * Internal static cache for gets, and whatnot.
 	 * This is not persistent, resets across requests.
-
 	 * @internal
 	 */
 	private static $cache = array();

Please login to merge, or discard this patch.

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -690,6 +690,7 @@
 block discarded – undo
 	 * Retrieve the entries for the current view and request.
 	 *
 	 * @param \GV\Request The request. Usued for now.
+	 * @param Request $request
 	 *
 	 * @return \GV\Entry_Collection The entries.
 	 */

Please login to merge, or discard this patch.

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -209,7 +209,7 @@  discard block
 block discarded – undo
 		$slug = apply_filters( 'gravityview_slug', 'view' );
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
 
-		add_filter( 'query_vars', function( $query_vars ) { 
+		add_filter( 'query_vars', function( $query_vars ) {
 			$query_vars[] = 'csv';
 			return $query_vars;
 		} );
@@ -254,8 +254,9 @@  discard block
 block discarded – undo
 		 * Check permissions.
 		 */
 		while ( $error = $view->can_render( null, $request ) ) {
-			if ( ! is_wp_error( $error ) )
-				break;
+			if ( ! is_wp_error( $error ) ) {
+							break;
+			}
 
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
 				case 'post_password_required':

Please login to merge, or discard this patch.

Spacing +26 added lines, -27 removed lines patch added patch discarded remove patch

@@ -108,7 +108,7 @@  discard block
 block discarded – undo
 		$supports = array( 'title', 'revisions' );
 
 		if ( $is_hierarchical ) {
-			$supports[] = 'page-attributes';
+			$supports[ ] = 'page-attributes';
 		}
 
 		/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
 
 		add_filter( 'query_vars', function( $query_vars ) { 
-			$query_vars[] = 'csv';
+			$query_vars[ ] = 'csv';
 			return $query_vars;
 		} );
 
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
 			call_user_func_array( 'add_rewrite_rule', $rule );
 		}
 	}
@@ -278,13 +278,13 @@  discard block
 block discarded – undo
 			return $content;
 		}
 
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
 
 		/**
 		 * Editing a single entry.
 		 */
 		if ( $entry = $request->is_edit_entry() ) {
-			if ( $entry['status'] != 'active' ) {
+			if ( $entry[ 'status' ] != 'active' ) {
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
 				return __( 'You are not allowed to view this content.', 'gravityview' );
 			}
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
 			}
 
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
 					return __( 'You are not allowed to view this content.', 'gravityview' );
 				}
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
 		 * Viewing a single entry.
 		 */
 		} else if ( $entry = $request->is_entry() ) {
-			if ( $entry['status'] != 'active' ) {
+			if ( $entry[ 'status' ] != 'active' ) {
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
 				return __( 'You are not allowed to view this content.', 'gravityview' );
 			}
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
 			}
 
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
 					return __( 'You are not allowed to view this content.', 'gravityview' );
 				}
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
 
 			$error = \GVCommon::check_entry_display( $entry->as_entry() );
 
-			if( is_wp_error( $error ) ) {
+			if ( is_wp_error( $error ) ) {
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing: {message}', array( 'entry_id' => $entry->ID, 'message' => $error->get_error_message() ) );
 				return __( 'You are not allowed to view this content.', 'gravityview' );
 			}
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
 
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
 		}
 
 		return $joins;
@@ -527,10 +527,10 @@  discard block
 block discarded – undo
 
 			list( $join, $join_column, $join_on, $join_on_column ) = $meta;
 
-			$forms_ids [] = GF_Form::by_id( $join_on );
+			$forms_ids [ ] = GF_Form::by_id( $join_on );
 		}
 
-		return ( !empty( $forms_ids) ) ? $forms_ids : null;
+		return ( ! empty( $forms_ids ) ) ? $forms_ids : null;
 	}
 
 	/**
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
 		if ( ! $view->form ) {
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
 				'view_id' => $view->ID,
-				'form_id' => $view->_gravityview_form_id ? : 0,
+				'form_id' => $view->_gravityview_form_id ?: 0,
 			) );
 		}
 
@@ -787,28 +787,27 @@  discard block
 block discarded – undo
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
 			 */
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
-			$parameters['context_view_id'] = $this->ID;
+			$parameters[ 'context_view_id' ] = $this->ID;
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
 
 			if ( $request instanceof REST\Request ) {
 				$atts = $this->settings->as_atts();
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
-						'paging' => array( 'page_size' => $atts['page_size'] ),
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
 					) );
-				$parameters['paging'] = $paging_parameters['paging'];
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
 			}
 
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
 
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
 				/**
 				 * New \GF_Query stuff :)
 				 */
-				$query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
+				$query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
 
-				$query->limit( $parameters['paging']['page_size'] )
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
 
 				/**
 				 * Any joins?
@@ -848,15 +847,15 @@  discard block
 block discarded – undo
 				} );
 			} else {
 				$entries = $this->form->entries
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
 					->offset( $this->settings->get( 'offset' ) )
-					->limit( $parameters['paging']['page_size'] )
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
 					->page( $page );
 
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
 					$field = new \GV\Field();
-					$field->ID = $parameters['sorting']['key'];
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
 				}
 			}
@@ -927,7 +926,7 @@  discard block
 block discarded – undo
 		$allowed = $headers = array();
 
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $field ) {
-			$allowed[] = $field->ID;
+			$allowed[ ] = $field->ID;
 		}
 
 		$renderer = new Field_Renderer();

Please login to merge, or discard this patch.

future/includes/class-gv-template-entry-legacy.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 		global $post;
 
 		if ( $post ) {
-			$context['post'] = $post;
+			$context[ 'post' ] = $post;
 		}
 
 		\GV\Mocks\Legacy_Context::push( $context );

Please login to merge, or discard this patch.

future/includes/class-gv-core.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -113,14 +113,14 @@
 block discarded – undo
 
 		/** Require critical legacy core files. @todo Deprecate */
 		require_once $this->plugin->dir( 'includes/helper-functions.php' );
-		require_once $this->plugin->dir( 'includes/class-common.php');
-		require_once $this->plugin->dir( 'includes/connector-functions.php');
+		require_once $this->plugin->dir( 'includes/class-common.php' );
+		require_once $this->plugin->dir( 'includes/connector-functions.php' );
 		require_once $this->plugin->dir( 'includes/class-gravityview-compatibility.php' );
 		require_once $this->plugin->dir( 'includes/class-gravityview-roles-capabilities.php' );
 		require_once $this->plugin->dir( 'includes/class-gravityview-admin-notices.php' );
 		require_once $this->plugin->dir( 'includes/class-admin.php' );
-		require_once $this->plugin->dir( 'includes/class-post-types.php');
-		require_once $this->plugin->dir( 'includes/class-cache.php');
+		require_once $this->plugin->dir( 'includes/class-post-types.php' );
+		require_once $this->plugin->dir( 'includes/class-cache.php' );
 
 		/**
 		 * GravityView extensions and widgets.

Please login to merge, or discard this patch.

future/includes/class-gv-request.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -112,10 +112,10 @@
 block discarded – undo
 	 */
 	public function is_edit_entry() {
 		/**
-		* @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
-		* The Edit Entry functionality overrides this value.
-		* @param boolean $is_edit_entry
-		*/
+		 * @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
+		 * The Edit Entry functionality overrides this value.
+		 * @param boolean $is_edit_entry
+		 */
 		if ( ( $entry = $this->is_entry() ) && apply_filters( 'gravityview_is_edit_entry', false ) ) {
 			return $entry;
 		}

Please login to merge, or discard this patch.

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 	 */
 	public static function is_add_oembed_preview() {
 		/** The preview request is a parse-embed AJAX call without a type set. */
-		return ( self::is_ajax() && ! empty( $_POST['action'] ) && $_POST['action'] == 'parse-embed' && ! isset( $_POST['type'] ) );
+		return ( self::is_ajax() && ! empty( $_POST[ 'action' ] ) && $_POST[ 'action' ] == 'parse-embed' && ! isset( $_POST[ 'type' ] ) );
 	}
 
 	/**
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	 * @return boolean
 	 */
 	public static function is_rest() {
-		return ! empty( $GLOBALS['wp']->query_vars['rest_route'] );
+		return ! empty( $GLOBALS[ 'wp' ]->query_vars[ 'rest_route' ] );
 	}
 
 	/**
@@ -141,15 +141,15 @@  discard block
 block discarded – undo
 			$get = $_GET;
 		}
 
-		unset( $get['mode'] );
+		unset( $get[ 'mode' ] );
 
 		$get = array_filter( $get, 'gravityview_is_not_empty_string' );
 
-		if( $has_field_key = $this->_has_field_key( $get ) ) {
+		if ( $has_field_key = $this->_has_field_key( $get ) ) {
 			return true;
 		}
 
-		return isset( $get['gv_search'] ) || isset( $get['gv_start'] ) || isset( $get['gv_end'] ) || isset( $get['gv_by'] ) || isset( $get['gv_id'] );
+		return isset( $get[ 'gv_search' ] ) || isset( $get[ 'gv_start' ] ) || isset( $get[ 'gv_end' ] ) || isset( $get[ 'gv_by' ] ) || isset( $get[ 'gv_id' ] );
 	}
 
 	/**
@@ -172,13 +172,13 @@  discard block
 block discarded – undo
 
 		$meta = array();
 		foreach ( $fields as $field ) {
-			if( empty( $field->_gf_field_class_name ) ) {
-				$meta[] = preg_quote( $field->name );
+			if ( empty( $field->_gf_field_class_name ) ) {
+				$meta[ ] = preg_quote( $field->name );
 			}
 		}
 
 		foreach ( $get as $key => $value ) {
-			if ( preg_match('/^filter_(([0-9_]+)|'. implode( '|', $meta ) .')$/sm', $key ) ) {
+			if ( preg_match( '/^filter_(([0-9_]+)|' . implode( '|', $meta ) . ')$/sm', $key ) ) {
 				$has_field_key = true;
 				break;
 			}

Please login to merge, or discard this patch.

future/includes/class-gv-collection-entry-sort.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -78,7 +78,7 @@
 block discarded – undo
 		if ( $this->field ) {
 			return array(
 				'key' => $this->field->ID,
-				'direction' => $this->direction ? : self::ASC,
+				'direction' => $this->direction ?: self::ASC,
 				'is_numeric' => self::ALPHA ? true : false,
 			);
 		}

Please login to merge, or discard this patch.

future/includes/class-gv-entry-multi.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 			if ( ! $entry instanceof Entry ) {
 				continue;
 			}
-			$_entry->entries[ $entry['form_id'] ]  = &$entry;
+			$_entry->entries[ $entry[ 'form_id' ] ] = &$entry;
 		}
 		return $_entry;
 	}
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 
 			foreach ( $this->entries as $entry ) {
 				$entry = $entry->as_entry();
-				$_entry['_multi'][ $entry['form_id'] ] = $entry;
+				$_entry[ '_multi' ][ $entry[ 'form_id' ] ] = $entry;
 			}
 		}
 

Please login to merge, or discard this patch.

future/includes/class-gv-wrappers.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -50,8 +50,8 @@
 block discarded – undo
 		/**
 		 * By array.
 		 */
-		if ( is_array( $view ) && ! empty( $view['id'] ) ) {
-			return $this->get( $view['id'] );
+		if ( is_array( $view ) && ! empty( $view[ 'id' ] ) ) {
+			return $this->get( $view[ 'id' ] );
 		}
 
 		/**

Please login to merge, or discard this patch.

		@@ -690,6 +690,7 @@
		block discarded – undo
690	690	* Retrieve the entries for the current view and request.
691	691	*
692	692	* @param \GV\Request The request. Usued for now.
	693	+ * @param Request $request
693	694	*
694	695	* @return \GV\Entry_Collection The entries.
695	696	*/

		@@ -108,7 +108,7 @@ discard block
		block discarded – undo
108	108	$supports = array( 'title', 'revisions' );
109	109
110	110	if ( $is_hierarchical ) {
111		- $supports[] = 'page-attributes';
	111	+ $supports[ ] = 'page-attributes';
112	112	}
113	113
114	114	/**
		@@ -210,11 +210,11 @@ discard block
		block discarded – undo
210	210	$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211	211
212	212	add_filter( 'query_vars', function( $query_vars ) {
213		- $query_vars[] = 'csv';
	213	+ $query_vars[ ] = 'csv';
214	214	return $query_vars;
215	215	} );
216	216
217		- if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
	217	+ if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
218	218	call_user_func_array( 'add_rewrite_rule', $rule );
219	219	}
220	220	}
		@@ -278,13 +278,13 @@ discard block
		block discarded – undo
278	278	return $content;
279	279	}
280	280
281		- $is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
	281	+ $is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
282	282
283	283	/**
284	284	* Editing a single entry.
285	285	*/
286	286	if ( $entry = $request->is_edit_entry() ) {
287		- if ( $entry['status'] != 'active' ) {
	287	+ if ( $entry[ 'status' ] != 'active' ) {
288	288	gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
289	289	return __( 'You are not allowed to view this content.', 'gravityview' );
290	290	}
		@@ -295,7 +295,7 @@ discard block
		block discarded – undo
295	295	}
296	296
297	297	if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
298		- if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
	298	+ if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
299	299	gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
300	300	return __( 'You are not allowed to view this content.', 'gravityview' );
301	301	}
		@@ -308,7 +308,7 @@ discard block
		block discarded – undo
308	308	* Viewing a single entry.
309	309	*/
310	310	} else if ( $entry = $request->is_entry() ) {
311		- if ( $entry['status'] != 'active' ) {
	311	+ if ( $entry[ 'status' ] != 'active' ) {
312	312	gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
313	313	return __( 'You are not allowed to view this content.', 'gravityview' );
314	314	}
		@@ -319,7 +319,7 @@ discard block
		block discarded – undo
319	319	}
320	320
321	321	if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
322		- if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
	322	+ if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
323	323	gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
324	324	return __( 'You are not allowed to view this content.', 'gravityview' );
325	325	}
		@@ -327,7 +327,7 @@ discard block
		block discarded – undo
327	327
328	328	$error = \GVCommon::check_entry_display( $entry->as_entry() );
329	329
330		- if( is_wp_error( $error ) ) {
	330	+ if ( is_wp_error( $error ) ) {
331	331	gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing: {message}', array( 'entry_id' => $entry->ID, 'message' => $error->get_error_message() ) );
332	332	return __( 'You are not allowed to view this content.', 'gravityview' );
333	333	}
		@@ -485,7 +485,7 @@ discard block
		block discarded – undo
485	485	$join_column = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
486	486	$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
487	487
488		- $joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
	488	+ $joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
489	489	}
490	490
491	491	return $joins;
		@@ -527,10 +527,10 @@ discard block
		block discarded – undo
527	527
528	528	list( $join, $join_column, $join_on, $join_on_column ) = $meta;
529	529
530		- $forms_ids [] = GF_Form::by_id( $join_on );
	530	+ $forms_ids [ ] = GF_Form::by_id( $join_on );
531	531	}
532	532
533		- return ( !empty( $forms_ids) ) ? $forms_ids : null;
	533	+ return ( ! empty( $forms_ids ) ) ? $forms_ids : null;
534	534	}
535	535
536	536	/**
		@@ -561,7 +561,7 @@ discard block
		block discarded – undo
561	561	if ( ! $view->form ) {
562	562	gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
563	563	'view_id' => $view->ID,
564		- 'form_id' => $view->_gravityview_form_id ? : 0,
	564	+ 'form_id' => $view->_gravityview_form_id ?: 0,
565	565	) );
566	566	}
567	567
		@@ -787,28 +787,27 @@ discard block
		block discarded – undo
787	787	* @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
788	788	*/
789	789	$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
790		- $parameters['context_view_id'] = $this->ID;
	790	+ $parameters[ 'context_view_id' ] = $this->ID;
791	791	$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
792	792
793	793	if ( $request instanceof REST\Request ) {
794	794	$atts = $this->settings->as_atts();
795	795	$paging_parameters = wp_parse_args( $request->get_paging(), array(
796		- 'paging' => array( 'page_size' => $atts['page_size'] ),
	796	+ 'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
797	797	) );
798		- $parameters['paging'] = $paging_parameters['paging'];
	798	+ $parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
799	799	}
800	800
801		- $page = Utils::get( $parameters['paging'], 'current_page' ) ?
802		- : ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
	801	+ $page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
803	802
804	803	if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
805	804	/**
806	805	* New \GF_Query stuff :)
807	806	*/
808		- $query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
	807	+ $query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
809	808
810		- $query->limit( $parameters['paging']['page_size'] )
811		- ->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
	809	+ $query->limit( $parameters[ 'paging' ][ 'page_size' ] )
	810	+ ->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
812	811
813	812	/**
814	813	* Any joins?
		@@ -848,15 +847,15 @@ discard block
		block discarded – undo
848	847	} );
849	848	} else {
850	849	$entries = $this->form->entries
851		- ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
	850	+ ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
852	851	->offset( $this->settings->get( 'offset' ) )
853		- ->limit( $parameters['paging']['page_size'] )
	852	+ ->limit( $parameters[ 'paging' ][ 'page_size' ] )
854	853	->page( $page );
855	854
856		- if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
	855	+ if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
857	856	$field = new \GV\Field();
858		- $field->ID = $parameters['sorting']['key'];
859		- $direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
	857	+ $field->ID = $parameters[ 'sorting' ][ 'key' ];
	858	+ $direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
860	859	$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
861	860	}
862	861	}
		@@ -927,7 +926,7 @@ discard block
		block discarded – undo
927	926	$allowed = $headers = array();
928	927
929	928	foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $field ) {
930		- $allowed[] = $field->ID;
	929	+ $allowed[ ] = $field->ID;
931	930	}
932	931
933	932	$renderer = new Field_Renderer();

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34	global $post;
35	35
36	36	if ( $post ) {
37		- $context['post'] = $post;
	37	+ $context[ 'post' ] = $post;
38	38	}
39	39
40	40	\GV\Mocks\Legacy_Context::push( $context );

		@@ -113,14 +113,14 @@
		block discarded – undo
113	113
114	114	/** Require critical legacy core files. @todo Deprecate */
115	115	require_once $this->plugin->dir( 'includes/helper-functions.php' );
116		- require_once $this->plugin->dir( 'includes/class-common.php');
117		- require_once $this->plugin->dir( 'includes/connector-functions.php');
	116	+ require_once $this->plugin->dir( 'includes/class-common.php' );
	117	+ require_once $this->plugin->dir( 'includes/connector-functions.php' );
118	118	require_once $this->plugin->dir( 'includes/class-gravityview-compatibility.php' );
119	119	require_once $this->plugin->dir( 'includes/class-gravityview-roles-capabilities.php' );
120	120	require_once $this->plugin->dir( 'includes/class-gravityview-admin-notices.php' );
121	121	require_once $this->plugin->dir( 'includes/class-admin.php' );
122		- require_once $this->plugin->dir( 'includes/class-post-types.php');
123		- require_once $this->plugin->dir( 'includes/class-cache.php');
	122	+ require_once $this->plugin->dir( 'includes/class-post-types.php' );
	123	+ require_once $this->plugin->dir( 'includes/class-cache.php' );
124	124
125	125	/**
126	126	* GravityView extensions and widgets.

		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	*/
46	46	public static function is_add_oembed_preview() {
47	47	/** The preview request is a parse-embed AJAX call without a type set. */
48		- return ( self::is_ajax() && ! empty( $_POST['action'] ) && $_POST['action'] == 'parse-embed' && ! isset( $_POST['type'] ) );
	48	+ return ( self::is_ajax() && ! empty( $_POST[ 'action' ] ) && $_POST[ 'action' ] == 'parse-embed' && ! isset( $_POST[ 'type' ] ) );
49	49	}
50	50
51	51	/**
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	* @return boolean
64	64	*/
65	65	public static function is_rest() {
66		- return ! empty( $GLOBALS['wp']->query_vars['rest_route'] );
	66	+ return ! empty( $GLOBALS[ 'wp' ]->query_vars[ 'rest_route' ] );
67	67	}
68	68
69	69	/**
		@@ -141,15 +141,15 @@ discard block
		block discarded – undo
141	141	$get = $_GET;
142	142	}
143	143
144		- unset( $get['mode'] );
	144	+ unset( $get[ 'mode' ] );
145	145
146	146	$get = array_filter( $get, 'gravityview_is_not_empty_string' );
147	147
148		- if( $has_field_key = $this->_has_field_key( $get ) ) {
	148	+ if ( $has_field_key = $this->_has_field_key( $get ) ) {
149	149	return true;
150	150	}
151	151
152		- return isset( $get['gv_search'] ) \|\| isset( $get['gv_start'] ) \|\| isset( $get['gv_end'] ) \|\| isset( $get['gv_by'] ) \|\| isset( $get['gv_id'] );
	152	+ return isset( $get[ 'gv_search' ] ) \|\| isset( $get[ 'gv_start' ] ) \|\| isset( $get[ 'gv_end' ] ) \|\| isset( $get[ 'gv_by' ] ) \|\| isset( $get[ 'gv_id' ] );
153	153	}
154	154
155	155	/**
		@@ -172,13 +172,13 @@ discard block
		block discarded – undo
172	172
173	173	$meta = array();
174	174	foreach ( $fields as $field ) {
175		- if( empty( $field->_gf_field_class_name ) ) {
176		- $meta[] = preg_quote( $field->name );
	175	+ if ( empty( $field->_gf_field_class_name ) ) {
	176	+ $meta[ ] = preg_quote( $field->name );
177	177	}
178	178	}
179	179
180	180	foreach ( $get as $key => $value ) {
181		- if ( preg_match('/^filter_(([0-9_]+)\|'. implode( '\|', $meta ) .')$/sm', $key ) ) {
	181	+ if ( preg_match( '/^filter_(([0-9_]+)\|' . implode( '\|', $meta ) . ')$/sm', $key ) ) {
182	182	$has_field_key = true;
183	183	break;
184	184	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	printf( '<body style="padding: 0; margin: 0; font-family: -apple-system, BlinkMacSystemFont, \'Segoe UI\', Roboto, Oxygen-Sans, Ubuntu, Cantarell, \'Helvetica Neue\', sans-serif;">' );
26	26	printf( '<img src="' . plugins_url( 'assets/images/astronaut-200x263.png', GRAVITYVIEW_FILE ) . '" alt="The GravityView Astronaut Says:" style="float: left; height: 60px; margin-right : 10px;" />' );
27	27	printf( __( "%sGravityView requires PHP Version %s or newer.%s \n\nYou're using Version %s. Please ask your host to upgrade your server's PHP.", 'gravityview' ),
28		- '<h3 style="font-size:16px; margin: 0 0 8px 0;">', GV_MIN_PHP_VERSION , "</h3>\n\n", $version );
	28	+ '<h3 style="font-size:16px; margin: 0 0 8px 0;">', GV_MIN_PHP_VERSION, "</h3>\n\n", $version );
29	29	printf( '</body>' );
30	30	}
31	31
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	}
35	35
36	36	/** The future branch of GravityView requires PHP 5.3+ namespaces and SPL. */
37		-if ( version_compare( phpversion(), '5.3.0' , '<' ) ) {
	37	+if ( version_compare( phpversion(), '5.3.0', '<' ) ) {
38	38	require GRAVITYVIEW_DIR . 'future/_stubs.php';
39	39
40	40	/** All looks fine. */

		@@ -61,7 +61,7 @@
		block discarded – undo
61	61	$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
62	62	$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
63	63
64		- $image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
	64	+ $image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
65	65	$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
66	66
67	67	echo \GVCommon::generate_notice( $output . $image, 'gv-error error', 'edit_gravityview', $gravityview->view->ID );

		@@ -62,7 +62,6 @@
		block discarded – undo
62	62	*
63	63	* Internal static cache for gets, and whatnot.
64	64	* This is not persistent, resets across requests.
65		-
66	65	* @internal
67	66	*/
68	67	private static $cache = array();

		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	$slug = apply_filters( 'gravityview_slug', 'view' );
210	210	$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211	211
212		- add_filter( 'query_vars', function( $query_vars ) {
	212	+ add_filter( 'query_vars', function( $query_vars ) {
213	213	$query_vars[] = 'csv';
214	214	return $query_vars;
215	215	} );
		@@ -254,8 +254,9 @@ discard block
		block discarded – undo
254	254	* Check permissions.
255	255	*/
256	256	while ( $error = $view->can_render( null, $request ) ) {
257		- if ( ! is_wp_error( $error ) )
258		- break;
	257	+ if ( ! is_wp_error( $error ) ) {
	258	+ break;
	259	+ }
259	260
260	261	switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
261	262	case 'post_password_required':

		@@ -112,10 +112,10 @@
		block discarded – undo
112	112	*/
113	113	public function is_edit_entry() {
114	114	/**
115		- * @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
116		- * The Edit Entry functionality overrides this value.
117		- * @param boolean $is_edit_entry
118		- */
	115	+ * @filter `gravityview_is_edit_entry` Whether we're currently on the Edit Entry screen \n
	116	+ * The Edit Entry functionality overrides this value.
	117	+ * @param boolean $is_edit_entry
	118	+ */
119	119	if ( ( $entry = $this->is_entry() ) && apply_filters( 'gravityview_is_edit_entry', false ) ) {
120	120	return $entry;
121	121	}

		@@ -78,7 +78,7 @@
		block discarded – undo
78	78	if ( $this->field ) {
79	79	return array(
80	80	'key' => $this->field->ID,
81		- 'direction' => $this->direction ? : self::ASC,
	81	+ 'direction' => $this->direction ?: self::ASC,
82	82	'is_numeric' => self::ALPHA ? true : false,
83	83	);
84	84	}

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	if ( ! $entry instanceof Entry ) {
45	45	continue;
46	46	}
47		- $_entry->entries[ $entry['form_id'] ] = &$entry;
	47	+ $_entry->entries[ $entry[ 'form_id' ] ] = &$entry;
48	48	}
49	49	return $_entry;
50	50	}
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65
66	66	foreach ( $this->entries as $entry ) {
67	67	$entry = $entry->as_entry();
68		- $_entry['_multi'][ $entry['form_id'] ] = $entry;
	68	+ $_entry[ '_multi' ][ $entry[ 'form_id' ] ] = $entry;
69	69	}
70	70	}
71	71

		@@ -50,8 +50,8 @@
		block discarded – undo
50	50	/**
51	51	* By array.
52	52	*/
53		- if ( is_array( $view ) && ! empty( $view['id'] ) ) {
54		- return $this->get( $view['id'] );
	53	+ if ( is_array( $view ) && ! empty( $view[ 'id' ] ) ) {
	54	+ return $this->get( $view[ 'id' ] );
55	55	}
56	56
57	57	/**

gravityview / GravityView

Pull Request — master (#1147)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +26 added lines, -27 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch