Completed
Pull Request — master (#651)
by Zack
04:36
created
includes/class-gravityview-admin-bar.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -37,13 +37,13 @@  discard block
 block discarded – undo
37 37
 		/** @var WP_Admin_Bar $wp_admin_bar */
38 38
 		global $wp_admin_bar;
39 39
 
40
-		if( is_admin() ) {
40
+		if ( is_admin() ) {
41 41
 			return;
42 42
 		}
43 43
 
44 44
 		$view_data = GravityView_View_Data::getInstance()->get_views();
45 45
 
46
-		if( empty( $view_data ) ) {
46
+		if ( empty( $view_data ) ) {
47 47
 			return;
48 48
 		}
49 49
 
@@ -80,9 +80,9 @@  discard block
 block discarded – undo
80 80
 				'parent' => 'gravityview',
81 81
 				'title' => __( 'Edit Entry', 'gravityview' ),
82 82
 				'meta' => array(
83
-					'title' => sprintf( __( 'Edit Entry %s', 'gravityview' ), GravityView_API::get_entry_slug( $entry['id'], $entry ) ),
83
+					'title' => sprintf( __( 'Edit Entry %s', 'gravityview' ), GravityView_API::get_entry_slug( $entry[ 'id' ], $entry ) ),
84 84
 				),
85
-				'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_entries&screen_mode=edit&view=entry&id=%d&lid=%d', $entry['form_id'], $entry['id'] ) ) ),
85
+				'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_entries&screen_mode=edit&view=entry&id=%d&lid=%d', $entry[ 'form_id' ], $entry[ 'id' ] ) ) ),
86 86
 			) );
87 87
 
88 88
 		}
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 		/** @var WP_Admin_Bar $wp_admin_bar */
99 99
 		global $wp_admin_bar;
100 100
 
101
-		if( GVCommon::has_cap( array( 'edit_gravityviews', 'edit_gravityview', 'gravityforms_edit_forms' ) ) ) {
101
+		if ( GVCommon::has_cap( array( 'edit_gravityviews', 'edit_gravityview', 'gravityforms_edit_forms' ) ) ) {
102 102
 
103 103
 			$view_data = GravityView_View_Data::getInstance();
104 104
 
@@ -108,26 +108,26 @@  discard block
 block discarded – undo
108 108
 			if ( ! empty( $views ) ) {
109 109
 				foreach ( $views as $view ) {
110 110
 
111
-					if( GVCommon::has_cap( 'edit_gravityview', $view['id'] ) ) {
111
+					if ( GVCommon::has_cap( 'edit_gravityview', $view[ 'id' ] ) ) {
112 112
 						$wp_admin_bar->add_menu( array(
113
-							'id'    => 'edit-view-' . $view['id'],
113
+							'id'    => 'edit-view-' . $view[ 'id' ],
114 114
 							'parent' => 'gravityview',
115 115
 							'title' => __( 'Edit View', 'gravityview' ),
116
-							'href'  => esc_url_raw( admin_url( sprintf( 'post.php?post=%d&action=edit', $view['id'] ) ) ),
116
+							'href'  => esc_url_raw( admin_url( sprintf( 'post.php?post=%d&action=edit', $view[ 'id' ] ) ) ),
117 117
 							'meta' => array(
118
-								'title' => sprintf( __( 'Edit View #%d', 'gravityview' ), $view['id'] ),
118
+								'title' => sprintf( __( 'Edit View #%d', 'gravityview' ), $view[ 'id' ] ),
119 119
 							),
120 120
 						) );
121 121
 					}
122 122
 
123
-					if ( ! empty( $view['form_id'] ) && GVCommon::has_cap( array( 'gravityforms_edit_forms' ), $view['form_id'] ) ) {
123
+					if ( ! empty( $view[ 'form_id' ] ) && GVCommon::has_cap( array( 'gravityforms_edit_forms' ), $view[ 'form_id' ] ) ) {
124 124
 						$wp_admin_bar->add_menu( array(
125
-							'id'    => 'edit-form-' . $view['form_id'],
125
+							'id'    => 'edit-form-' . $view[ 'form_id' ],
126 126
 							'parent' => 'gravityview',
127 127
 							'title' => __( 'Edit Form', 'gravityview' ),
128
-							'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_edit_forms&id=%d', $view['form_id'] ) ) ),
128
+							'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_edit_forms&id=%d', $view[ 'form_id' ] ) ) ),
129 129
 							'meta' => array(
130
-								'title' => sprintf( __( 'Edit Form #%d', 'gravityview' ), $view['form_id'] ),
130
+								'title' => sprintf( __( 'Edit Form #%d', 'gravityview' ), $view[ 'form_id' ] ),
131 131
 							),
132 132
 						) );
133 133
 
Please login to merge, or discard this patch.
plugin-and-theme-hooks/class-gravityview-theme-hooks-church-themes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 	 */
51 51
 	public function if_gravityview_return_true( $has_content = false ) {
52 52
 
53
-		if( ! class_exists( 'GravityView_frontend' ) ) {
53
+		if ( ! class_exists( 'GravityView_frontend' ) ) {
54 54
 			return $has_content;
55 55
 		}
56 56
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 2 patches
Indentation   +1576 added lines, -1576 removed lines patch added patch discarded remove patch
@@ -10,21 +10,21 @@  discard block
 block discarded – undo
10 10
  */
11 11
 
12 12
 if ( ! defined( 'WPINC' ) ) {
13
-    die;
13
+	die;
14 14
 }
15 15
 
16 16
 
17 17
 class GravityView_Edit_Entry_Render {
18 18
 
19
-    /**
20
-     * @var GravityView_Edit_Entry
21
-     */
22
-    protected $loader;
19
+	/**
20
+	 * @var GravityView_Edit_Entry
21
+	 */
22
+	protected $loader;
23 23
 
24 24
 	/**
25 25
 	 * @var string String used to generate unique nonce for the entry/form/view combination. Allows access to edit page.
26 26
 	 */
27
-    static $nonce_key;
27
+	static $nonce_key;
28 28
 
29 29
 	/**
30 30
 	 * @since 1.9
@@ -44,142 +44,142 @@  discard block
 block discarded – undo
44 44
 	 */
45 45
 	private static $supports_product_fields = false;
46 46
 
47
-    /**
48
-     * Gravity Forms entry array
49
-     *
50
-     * @var array
51
-     */
52
-    var $entry;
53
-
54
-    /**
55
-     * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
-     *
57
-     * @var array
58
-     */
59
-    var $form;
60
-
61
-    /**
62
-     * Gravity Forms form array (it won't get changed during this class lifecycle)
63
-     * @since 1.16.2.1
64
-     * @var array
65
-     */
66
-    var $original_form;
67
-
68
-    /**
69
-     * Gravity Forms form array after the form validation process
70
-     * @since 1.13
71
-     * @var array
72
-     */
73
-    var $form_after_validation = null;
74
-
75
-    /**
76
-     * Hold an array of GF field objects that have calculation rules
77
-     * @var array
78
-     */
79
-    var $fields_with_calculation = array();
80
-
81
-    /**
82
-     * Hold an array of GF field objects with type 'total'
83
-     * @var array
84
-     */
85
-    var $total_fields = array();
86
-
87
-    /**
88
-     * Gravity Forms form id
89
-     *
90
-     * @var int
91
-     */
92
-    var $form_id;
93
-
94
-    /**
95
-     * ID of the current view
96
-     *
97
-     * @var int
98
-     */
99
-    var $view_id;
100
-
101
-    /**
102
-     * Updated entry is valid (GF Validation object)
103
-     *
104
-     * @var array
105
-     */
106
-    var $is_valid = NULL;
107
-
108
-    function __construct( GravityView_Edit_Entry $loader ) {
109
-        $this->loader = $loader;
110
-    }
111
-
112
-    function load() {
113
-
114
-        /** @define "GRAVITYVIEW_DIR" "../../../" */
115
-        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
116
-
117
-        // Don't display an embedded form when editing an entry
118
-        add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119
-        add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120
-
121
-        // Stop Gravity Forms processing what is ours!
122
-        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
123
-
124
-        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
125
-
126
-        add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127
-
128
-        // Disable conditional logic if needed (since 1.9)
129
-        add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
130
-
131
-        // Make sure GF doesn't validate max files (since 1.9)
132
-        add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133
-
134
-        // Add fields expected by GFFormDisplay::validate()
135
-        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
136
-
137
-    }
138
-
139
-    /**
140
-     * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
141
-     *
142
-     * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
143
-     * And then removes it on the `wp_footer` action
144
-     *
145
-     * @since 1.16.1
146
-     *
147
-     * @return void
148
-     */
149
-    function prevent_render_form() {
150
-        if( $this->is_edit_entry() ) {
151
-            if( 'wp_head' === current_filter() ) {
152
-                add_filter( 'gform_shortcode_form', '__return_empty_string' );
153
-            } else {
154
-                remove_filter( 'gform_shortcode_form', '__return_empty_string' );
155
-            }
156
-        }
157
-    }
158
-
159
-    /**
160
-     * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
161
-     * backend form, we need to prevent them from saving twice.
162
-     * @return void
163
-     */
164
-    function prevent_maybe_process_form() {
165
-
166
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167
-
168
-        if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
-            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
170
-        }
171
-    }
172
-
173
-    /**
174
-     * Is the current page an Edit Entry page?
175
-     * @return boolean
176
-     */
177
-    public function is_edit_entry() {
178
-
179
-        $gf_page = function_exists('rgpost') && ( 'entry' === rgget( 'view' ) && isset( $_GET['edit'] ) || rgpost( 'action' ) === 'update' );
180
-
181
-        return $gf_page;
182
-    }
47
+	/**
48
+	 * Gravity Forms entry array
49
+	 *
50
+	 * @var array
51
+	 */
52
+	var $entry;
53
+
54
+	/**
55
+	 * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
+	 *
57
+	 * @var array
58
+	 */
59
+	var $form;
60
+
61
+	/**
62
+	 * Gravity Forms form array (it won't get changed during this class lifecycle)
63
+	 * @since 1.16.2.1
64
+	 * @var array
65
+	 */
66
+	var $original_form;
67
+
68
+	/**
69
+	 * Gravity Forms form array after the form validation process
70
+	 * @since 1.13
71
+	 * @var array
72
+	 */
73
+	var $form_after_validation = null;
74
+
75
+	/**
76
+	 * Hold an array of GF field objects that have calculation rules
77
+	 * @var array
78
+	 */
79
+	var $fields_with_calculation = array();
80
+
81
+	/**
82
+	 * Hold an array of GF field objects with type 'total'
83
+	 * @var array
84
+	 */
85
+	var $total_fields = array();
86
+
87
+	/**
88
+	 * Gravity Forms form id
89
+	 *
90
+	 * @var int
91
+	 */
92
+	var $form_id;
93
+
94
+	/**
95
+	 * ID of the current view
96
+	 *
97
+	 * @var int
98
+	 */
99
+	var $view_id;
100
+
101
+	/**
102
+	 * Updated entry is valid (GF Validation object)
103
+	 *
104
+	 * @var array
105
+	 */
106
+	var $is_valid = NULL;
107
+
108
+	function __construct( GravityView_Edit_Entry $loader ) {
109
+		$this->loader = $loader;
110
+	}
111
+
112
+	function load() {
113
+
114
+		/** @define "GRAVITYVIEW_DIR" "../../../" */
115
+		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
116
+
117
+		// Don't display an embedded form when editing an entry
118
+		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119
+		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120
+
121
+		// Stop Gravity Forms processing what is ours!
122
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
123
+
124
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
125
+
126
+		add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127
+
128
+		// Disable conditional logic if needed (since 1.9)
129
+		add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
130
+
131
+		// Make sure GF doesn't validate max files (since 1.9)
132
+		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133
+
134
+		// Add fields expected by GFFormDisplay::validate()
135
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
136
+
137
+	}
138
+
139
+	/**
140
+	 * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
141
+	 *
142
+	 * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
143
+	 * And then removes it on the `wp_footer` action
144
+	 *
145
+	 * @since 1.16.1
146
+	 *
147
+	 * @return void
148
+	 */
149
+	function prevent_render_form() {
150
+		if( $this->is_edit_entry() ) {
151
+			if( 'wp_head' === current_filter() ) {
152
+				add_filter( 'gform_shortcode_form', '__return_empty_string' );
153
+			} else {
154
+				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
155
+			}
156
+		}
157
+	}
158
+
159
+	/**
160
+	 * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
161
+	 * backend form, we need to prevent them from saving twice.
162
+	 * @return void
163
+	 */
164
+	function prevent_maybe_process_form() {
165
+
166
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167
+
168
+		if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
+			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
170
+		}
171
+	}
172
+
173
+	/**
174
+	 * Is the current page an Edit Entry page?
175
+	 * @return boolean
176
+	 */
177
+	public function is_edit_entry() {
178
+
179
+		$gf_page = function_exists('rgpost') && ( 'entry' === rgget( 'view' ) && isset( $_GET['edit'] ) || rgpost( 'action' ) === 'update' );
180
+
181
+		return $gf_page;
182
+	}
183 183
 
184 184
 	/**
185 185
 	 * Is the current page an Edit Entry page?
@@ -190,574 +190,574 @@  discard block
 block discarded – undo
190 190
 		return !empty( $_POST[ self::$nonce_field ] );
191 191
 	}
192 192
 
193
-    /**
194
-     * When Edit entry view is requested setup the vars
195
-     */
196
-    function setup_vars() {
197
-        $gravityview_view = GravityView_View::getInstance();
193
+	/**
194
+	 * When Edit entry view is requested setup the vars
195
+	 */
196
+	function setup_vars() {
197
+		$gravityview_view = GravityView_View::getInstance();
198 198
 
199 199
 
200
-        $entries = $gravityview_view->getEntries();
201
-        $this->entry = $entries[0];
200
+		$entries = $gravityview_view->getEntries();
201
+		$this->entry = $entries[0];
202 202
 
203
-        $this->original_form = $this->form = $gravityview_view->getForm();
204
-        $this->form_id = $gravityview_view->getFormId();
205
-        $this->view_id = $gravityview_view->getViewId();
203
+		$this->original_form = $this->form = $gravityview_view->getForm();
204
+		$this->form_id = $gravityview_view->getFormId();
205
+		$this->view_id = $gravityview_view->getViewId();
206 206
 
207
-        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
208
-    }
207
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
208
+	}
209 209
 
210 210
 
211
-    /**
212
-     * Load required files and trigger edit flow
213
-     *
214
-     * Run when the is_edit_entry returns true.
215
-     *
216
-     * @param GravityView_View_Data $gv_data GravityView Data object
217
-     * @return void
218
-     */
219
-    function init( $gv_data ) {
211
+	/**
212
+	 * Load required files and trigger edit flow
213
+	 *
214
+	 * Run when the is_edit_entry returns true.
215
+	 *
216
+	 * @param GravityView_View_Data $gv_data GravityView Data object
217
+	 * @return void
218
+	 */
219
+	function init( $gv_data ) {
220 220
 
221
-        require_once( GFCommon::get_base_path() . '/form_display.php' );
222
-        require_once( GFCommon::get_base_path() . '/entry_detail.php' );
221
+		require_once( GFCommon::get_base_path() . '/form_display.php' );
222
+		require_once( GFCommon::get_base_path() . '/entry_detail.php' );
223 223
 
224
-        $this->setup_vars();
224
+		$this->setup_vars();
225 225
 
226
-        // Multiple Views embedded, don't proceed if nonce fails
227
-        if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
228
-            return;
229
-        }
226
+		// Multiple Views embedded, don't proceed if nonce fails
227
+		if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
228
+			return;
229
+		}
230 230
 
231
-        // Sorry, you're not allowed here.
232
-        if( false === $this->user_can_edit_entry( true ) ) {
233
-            return;
234
-        }
231
+		// Sorry, you're not allowed here.
232
+		if( false === $this->user_can_edit_entry( true ) ) {
233
+			return;
234
+		}
235 235
 
236
-        $this->print_scripts();
236
+		$this->print_scripts();
237 237
 
238
-        $this->process_save();
238
+		$this->process_save();
239 239
 
240
-        $this->edit_entry_form();
240
+		$this->edit_entry_form();
241 241
 
242
-    }
242
+	}
243 243
 
244 244
 
245
-    /**
246
-     * Force Gravity Forms to output scripts as if it were in the admin
247
-     * @return void
248
-     */
249
-    function print_scripts() {
250
-        $gravityview_view = GravityView_View::getInstance();
245
+	/**
246
+	 * Force Gravity Forms to output scripts as if it were in the admin
247
+	 * @return void
248
+	 */
249
+	function print_scripts() {
250
+		$gravityview_view = GravityView_View::getInstance();
251 251
 
252
-        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
252
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
253 253
 
254
-        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
254
+		GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
255 255
 
256
-        // Sack is required for images
257
-        wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
258
-    }
256
+		// Sack is required for images
257
+		wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
258
+	}
259 259
 
260 260
 
261
-    /**
262
-     * Process edit entry form save
263
-     */
264
-    function process_save() {
261
+	/**
262
+	 * Process edit entry form save
263
+	 */
264
+	function process_save() {
265 265
 
266
-        if( empty( $_POST ) ) {
267
-            return;
268
-        }
266
+		if( empty( $_POST ) ) {
267
+			return;
268
+		}
269 269
 
270
-        // Make sure the entry, view, and form IDs are all correct
271
-        $valid = $this->verify_nonce();
270
+		// Make sure the entry, view, and form IDs are all correct
271
+		$valid = $this->verify_nonce();
272 272
 
273
-        if( !$valid ) {
274
-            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275
-            return;
276
-        }
273
+		if( !$valid ) {
274
+			do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275
+			return;
276
+		}
277 277
 
278
-        if( $this->entry['id'] !== $_POST['lid'] ) {
279
-            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280
-            return;
281
-        }
278
+		if( $this->entry['id'] !== $_POST['lid'] ) {
279
+			do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280
+			return;
281
+		}
282 282
 
283
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
283
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
284 284
 
285
-        $this->process_save_process_files( $this->form_id );
285
+		$this->process_save_process_files( $this->form_id );
286 286
 
287
-        $this->validate();
287
+		$this->validate();
288 288
 
289
-        if( $this->is_valid ) {
289
+		if( $this->is_valid ) {
290 290
 
291
-            do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
291
+			do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
292 292
 
293
-            /**
294
-             * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
295
-             */
296
-            $form = $this->form_prepare_for_save();
293
+			/**
294
+			 * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
295
+			 */
296
+			$form = $this->form_prepare_for_save();
297 297
 
298
-            /**
299
-             * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300
-             */
301
-            unset( $_GET['page'] );
298
+			/**
299
+			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300
+			 */
301
+			unset( $_GET['page'] );
302 302
 
303
-            GFFormsModel::save_lead( $form, $this->entry );
303
+			GFFormsModel::save_lead( $form, $this->entry );
304 304
 
305
-            // If there's a post associated with the entry, process post fields
306
-            if( !empty( $this->entry['post_id'] ) ) {
307
-                $this->maybe_update_post_fields( $form );
308
-            }
305
+			// If there's a post associated with the entry, process post fields
306
+			if( !empty( $this->entry['post_id'] ) ) {
307
+				$this->maybe_update_post_fields( $form );
308
+			}
309 309
 
310
-            // Process calculation fields
311
-            $this->update_calculation_fields();
310
+			// Process calculation fields
311
+			$this->update_calculation_fields();
312 312
 
313
-            // Perform actions normally performed after updating a lead
314
-            $this->after_update();
313
+			// Perform actions normally performed after updating a lead
314
+			$this->after_update();
315 315
 
316
-            /**
317
-             * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
318
-             * @param array $form Gravity Forms form array
319
-             * @param string $entry_id Numeric ID of the entry that was updated
320
-             */
321
-            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
322
-        }
316
+			/**
317
+			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
318
+			 * @param array $form Gravity Forms form array
319
+			 * @param string $entry_id Numeric ID of the entry that was updated
320
+			 */
321
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
322
+		}
323 323
 
324
-    } // process_save
324
+	} // process_save
325 325
 
326 326
 
327
-    /**
328
-     * Have GF handle file uploads
329
-     *
330
-     * Copy of code from GFFormDisplay::process_form()
331
-     *
332
-     * @param int $form_id
333
-     */
334
-    function process_save_process_files( $form_id ) {
327
+	/**
328
+	 * Have GF handle file uploads
329
+	 *
330
+	 * Copy of code from GFFormDisplay::process_form()
331
+	 *
332
+	 * @param int $form_id
333
+	 */
334
+	function process_save_process_files( $form_id ) {
335
+
336
+		//Loading files that have been uploaded to temp folder
337
+		$files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
338
+		if ( ! is_array( $files ) ) {
339
+			$files = array();
340
+		}
341
+
342
+		RGFormsModel::$uploaded_files[ $form_id ] = $files;
343
+	}
344
+
345
+	/**
346
+	 * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
347
+	 * Late validation done on self::custom_validation
348
+	 *
349
+	 * @param $plupload_init array Plupload settings
350
+	 * @param $form_id
351
+	 * @param $instance
352
+	 * @return mixed
353
+	 */
354
+	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
+		if( ! $this->is_edit_entry() ) {
356
+			return $plupload_init;
357
+		}
358
+
359
+		$plupload_init['gf_vars']['max_files'] = 0;
360
+
361
+		return $plupload_init;
362
+	}
363
+
335 364
 
336
-        //Loading files that have been uploaded to temp folder
337
-        $files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
338
-        if ( ! is_array( $files ) ) {
339
-            $files = array();
340
-        }
365
+	/**
366
+	 * Unset adminOnly and convert field input key to string
367
+	 * @return array $form
368
+	 */
369
+	private function form_prepare_for_save() {
370
+
371
+		$form = $this->form;
372
+
373
+		foreach( $form['fields'] as $k => &$field ) {
374
+
375
+			// Remove the fields with calculation formulas before save to avoid conflicts with GF logic
376
+			// @since 1.16.3
377
+			if( $field->has_calculation() ) {
378
+				unset( $form['fields'][ $k ] );
379
+			}
380
+
381
+			$field->adminOnly = false;
382
+
383
+			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
384
+				foreach( $field->inputs as $key => $input ) {
385
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
386
+				}
387
+			}
388
+		}
389
+
390
+		return $form;
391
+	}
392
+
393
+	private function update_calculation_fields() {
394
+
395
+		$form = $this->original_form;
396
+		$update = false;
397
+
398
+		// get the most up to date entry values
399
+		$entry = GFAPI::get_entry( $this->entry['id'] );
400
+
401
+		if( !empty( $this->fields_with_calculation ) ) {
402
+			$update = true;
403
+			foreach ( $this->fields_with_calculation as $calc_field ) {
404
+				$inputs = $calc_field->get_entry_inputs();
405
+				if ( is_array( $inputs ) ) {
406
+					foreach ( $inputs as $input ) {
407
+						$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
408
+						$entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
409
+					}
410
+				} else {
411
+					$input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
412
+					$entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
413
+				}
414
+			}
341 415
 
342
-        RGFormsModel::$uploaded_files[ $form_id ] = $files;
343
-    }
344
-
345
-    /**
346
-     * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
347
-     * Late validation done on self::custom_validation
348
-     *
349
-     * @param $plupload_init array Plupload settings
350
-     * @param $form_id
351
-     * @param $instance
352
-     * @return mixed
353
-     */
354
-    public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
-        if( ! $this->is_edit_entry() ) {
356
-            return $plupload_init;
357
-        }
358
-
359
-        $plupload_init['gf_vars']['max_files'] = 0;
360
-
361
-        return $plupload_init;
362
-    }
363
-
364
-
365
-    /**
366
-     * Unset adminOnly and convert field input key to string
367
-     * @return array $form
368
-     */
369
-    private function form_prepare_for_save() {
370
-
371
-        $form = $this->form;
372
-
373
-        foreach( $form['fields'] as $k => &$field ) {
374
-
375
-            // Remove the fields with calculation formulas before save to avoid conflicts with GF logic
376
-            // @since 1.16.3
377
-            if( $field->has_calculation() ) {
378
-                unset( $form['fields'][ $k ] );
379
-            }
380
-
381
-            $field->adminOnly = false;
382
-
383
-            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
384
-                foreach( $field->inputs as $key => $input ) {
385
-                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
386
-                }
387
-            }
388
-        }
389
-
390
-        return $form;
391
-    }
392
-
393
-    private function update_calculation_fields() {
394
-
395
-        $form = $this->original_form;
396
-        $update = false;
397
-
398
-        // get the most up to date entry values
399
-        $entry = GFAPI::get_entry( $this->entry['id'] );
400
-
401
-        if( !empty( $this->fields_with_calculation ) ) {
402
-            $update = true;
403
-            foreach ( $this->fields_with_calculation as $calc_field ) {
404
-                $inputs = $calc_field->get_entry_inputs();
405
-                if ( is_array( $inputs ) ) {
406
-                    foreach ( $inputs as $input ) {
407
-                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
408
-                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
409
-                    }
410
-                } else {
411
-                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
412
-                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
413
-                }
414
-            }
415
-
416
-        }
417
-
418
-        //saving total field as the last field of the form.
419
-        if ( ! empty( $this->total_fields ) ) {
420
-            $update = true;
421
-            foreach ( $this->total_fields as $total_field ) {
422
-                $input_name = 'input_' . str_replace( '.', '_', $total_field->id);
423
-                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
424
-            }
425
-        }
426
-
427
-        if( $update ) {
428
-
429
-            $return_entry = GFAPI::update_entry( $entry );
430
-
431
-            if( is_wp_error( $return_entry ) ) {
432
-                do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
433
-            } else {
434
-                do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
435
-            }
436
-        }
437
-    }
438
-
439
-    /**
440
-     * Update the post categories based on all post category fields
441
-     *
442
-     * @since 1.17
443
-     *
444
-     * @param WP_Post &$updated_post Post to be updated (passed by reference)
445
-     * @param array $form Form to check post fields
446
-     * @param array $entry
447
-     *
448
-     * @return mixed
449
-     */
450
-    private function set_post_categories( &$updated_post, $form, $entry ) {
451
-
452
-        $post_category_fields = GFAPI::get_fields_by_type( $form, 'post_category' );
416
+		}
417
+
418
+		//saving total field as the last field of the form.
419
+		if ( ! empty( $this->total_fields ) ) {
420
+			$update = true;
421
+			foreach ( $this->total_fields as $total_field ) {
422
+				$input_name = 'input_' . str_replace( '.', '_', $total_field->id);
423
+				$entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
424
+			}
425
+		}
426
+
427
+		if( $update ) {
428
+
429
+			$return_entry = GFAPI::update_entry( $entry );
430
+
431
+			if( is_wp_error( $return_entry ) ) {
432
+				do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
433
+			} else {
434
+				do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
435
+			}
436
+		}
437
+	}
438
+
439
+	/**
440
+	 * Update the post categories based on all post category fields
441
+	 *
442
+	 * @since 1.17
443
+	 *
444
+	 * @param WP_Post &$updated_post Post to be updated (passed by reference)
445
+	 * @param array $form Form to check post fields
446
+	 * @param array $entry
447
+	 *
448
+	 * @return mixed
449
+	 */
450
+	private function set_post_categories( &$updated_post, $form, $entry ) {
451
+
452
+		$post_category_fields = GFAPI::get_fields_by_type( $form, 'post_category' );
453 453
         
454
-        /**
455
-         * @filter `gravityview/edit_entry/post_content/append_categories` Should post categories be added to or replaced?
456
-         * @since 1.17
457
-         * @param bool $append If `true`, don't delete existing categories, just add on. If `false`, replace the categories with the submitted categories. Default: `false`
458
-         */
459
-        $append = apply_filters( 'gravityview/edit_entry/post_content/append_categories', false );
460
-
461
-        $updated_categories = array();
462
-
463
-        if( $append ) {
464
-            $updated_categories = wp_get_post_categories( $updated_post->ID );
465
-        }
466
-
467
-        if( $post_category_fields ) {
468
-
469
-            foreach ( $post_category_fields as $field ) {
470
-                // Get the value of the field, including $_POSTed value
471
-                $field_cats = RGFormsModel::get_field_value( $field );
472
-                $field_cats = is_array( $field_cats ) ? array_values( $field_cats ) : (array)$field_cats;
473
-                $field_cats = gv_map_deep( $field_cats, 'intval' );
474
-                $updated_categories = array_merge( $updated_categories, array_values( $field_cats ) );
475
-            }
476
-        }
477
-
478
-        $updated_post->post_category = $updated_categories;
479
-    }
480
-
481
-    /**
482
-     * Handle updating the Post Image field
483
-     *
484
-     * Sets a new Featured Image if configured in Gravity Forms; otherwise uploads/updates media
485
-     *
486
-     * @since 1.17
487
-     *
488
-     * @uses GFFormsModel::media_handle_upload
489
-     * @uses set_post_thumbnail
490
-     * 
491
-     * @param array $form GF Form array
492
-     * @param GF_Field $field GF Field
493
-     * @param string $field_id Numeric ID of the field
494
-     * @param string $value
495
-     * @param array $entry GF Entry currently being edited
496
-     * @param int $post_id ID of the Post being edited
497
-     *
498
-     * @return mixed|string
499
-     */
500
-    private function update_post_image( $form, $field, $field_id, $value, $entry, $post_id ) {
501
-
502
-        $input_name = 'input_' . $field_id;
503
-
504
-        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
505
-
506
-            // We have a new image
507
-
508
-            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
509
-
510
-            $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
511
-            $img_url = rgar( $ary, 0 );
454
+		/**
455
+		 * @filter `gravityview/edit_entry/post_content/append_categories` Should post categories be added to or replaced?
456
+		 * @since 1.17
457
+		 * @param bool $append If `true`, don't delete existing categories, just add on. If `false`, replace the categories with the submitted categories. Default: `false`
458
+		 */
459
+		$append = apply_filters( 'gravityview/edit_entry/post_content/append_categories', false );
512 460
 
513
-            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
514
-            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
515
-            $img_description = count( $ary ) > 3 ? $ary[3] : '';
461
+		$updated_categories = array();
516 462
 
517
-            $image_meta = array(
518
-                'post_excerpt' => $img_caption,
519
-                'post_content' => $img_description,
520
-            );
463
+		if( $append ) {
464
+			$updated_categories = wp_get_post_categories( $updated_post->ID );
465
+		}
521 466
 
522
-            //adding title only if it is not empty. It will default to the file name if it is not in the array
523
-            if ( ! empty( $img_title ) ) {
524
-                $image_meta['post_title'] = $img_title;
525
-            }
467
+		if( $post_category_fields ) {
526 468
 
527
-            /**
528
-             * todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
529
-             * Note: the method became public in GF 1.9.17.7, but we don't require that version yet.
530
-             */
531
-            require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
532
-            $media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
533
-
534
-            // is this field set as featured image?
535
-            if ( $media_id && $field->postFeaturedImage ) {
536
-                set_post_thumbnail( $post_id, $media_id );
537
-            }
538
-
539
-        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
540
-
541
-            // Same image although the image title, caption or description might have changed
542
-
543
-            $ary = ! empty( $entry[ $field_id ] ) ? explode( '|:|', $entry[ $field_id ] ) : array();
544
-            $img_url = rgar( $ary, 0 );
545
-
546
-            // is this really the same image or something went wrong ?
547
-            if( $img_url === $_POST[ $input_name ] ) {
548
-
549
-                $img_title       = rgar( $value, $field_id .'.1' );
550
-                $img_caption     = rgar( $value, $field_id .'.4' );
551
-                $img_description = rgar( $value, $field_id .'.7' );
552
-
553
-                $value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
554
-
555
-                if ( $field->postFeaturedImage ) {
556
-
557
-                    $image_meta = array(
558
-                        'ID' => get_post_thumbnail_id( $post_id ),
559
-                        'post_title' => $img_title,
560
-                        'post_excerpt' => $img_caption,
561
-                        'post_content' => $img_description,
562
-                    );
563
-
564
-                    // update image title, caption or description
565
-                    wp_update_post( $image_meta );
566
-                }
567
-            }
568
-
569
-        } else {
570
-
571
-            // if we get here, image was removed or not set.
572
-            $value = '';
573
-
574
-            if ( $field->postFeaturedImage ) {
575
-                delete_post_thumbnail( $post_id );
576
-            }
577
-        }
469
+			foreach ( $post_category_fields as $field ) {
470
+				// Get the value of the field, including $_POSTed value
471
+				$field_cats = RGFormsModel::get_field_value( $field );
472
+				$field_cats = is_array( $field_cats ) ? array_values( $field_cats ) : (array)$field_cats;
473
+				$field_cats = gv_map_deep( $field_cats, 'intval' );
474
+				$updated_categories = array_merge( $updated_categories, array_values( $field_cats ) );
475
+			}
476
+		}
578 477
 
579
-        return $value;
580
-    }
478
+		$updated_post->post_category = $updated_categories;
479
+	}
581 480
 
582
-    /**
583
-     * Loop through the fields being edited and if they include Post fields, update the Entry's post object
584
-     *
585
-     * @param array $form Gravity Forms form
586
-     *
587
-     * @return void
588
-     */
589
-    private function maybe_update_post_fields( $form ) {
481
+	/**
482
+	 * Handle updating the Post Image field
483
+	 *
484
+	 * Sets a new Featured Image if configured in Gravity Forms; otherwise uploads/updates media
485
+	 *
486
+	 * @since 1.17
487
+	 *
488
+	 * @uses GFFormsModel::media_handle_upload
489
+	 * @uses set_post_thumbnail
490
+	 * 
491
+	 * @param array $form GF Form array
492
+	 * @param GF_Field $field GF Field
493
+	 * @param string $field_id Numeric ID of the field
494
+	 * @param string $value
495
+	 * @param array $entry GF Entry currently being edited
496
+	 * @param int $post_id ID of the Post being edited
497
+	 *
498
+	 * @return mixed|string
499
+	 */
500
+	private function update_post_image( $form, $field, $field_id, $value, $entry, $post_id ) {
590 501
 
591
-        $post_id = $this->entry['post_id'];
502
+		$input_name = 'input_' . $field_id;
592 503
 
593
-        // Security check
594
-        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
595
-            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
596
-            return;
597
-        }
504
+		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
598 505
 
599
-        $update_entry = false;
506
+			// We have a new image
600 507
 
601
-        $updated_post = $original_post = get_post( $post_id );
508
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
602 509
 
603
-        // get the most up to date entry values
604
-        $entry = GFAPI::get_entry( $this->entry['id'] );
510
+			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
511
+			$img_url = rgar( $ary, 0 );
605 512
 
606
-        foreach ( $entry as $field_id => $value ) {
513
+			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
514
+			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
515
+			$img_description = count( $ary ) > 3 ? $ary[3] : '';
607 516
 
608
-            //todo: only run through the edit entry configured fields
517
+			$image_meta = array(
518
+				'post_excerpt' => $img_caption,
519
+				'post_content' => $img_description,
520
+			);
609 521
 
610
-            $field = RGFormsModel::get_field( $form, $field_id );
522
+			//adding title only if it is not empty. It will default to the file name if it is not in the array
523
+			if ( ! empty( $img_title ) ) {
524
+				$image_meta['post_title'] = $img_title;
525
+			}
611 526
 
612
-            if( class_exists('GF_Fields') ) {
613
-                $field = GF_Fields::create( $field );
614
-            }
527
+			/**
528
+			 * todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
529
+			 * Note: the method became public in GF 1.9.17.7, but we don't require that version yet.
530
+			 */
531
+			require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
532
+			$media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
615 533
 
616
-            if( GFCommon::is_post_field( $field ) ) {
534
+			// is this field set as featured image?
535
+			if ( $media_id && $field->postFeaturedImage ) {
536
+				set_post_thumbnail( $post_id, $media_id );
537
+			}
617 538
 
618
-                // Get the value of the field, including $_POSTed value
619
-                $value = RGFormsModel::get_field_value( $field );
539
+		} elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
620 540
 
621
-                switch( $field->type ) {
541
+			// Same image although the image title, caption or description might have changed
622 542
 
623
-                    case 'post_title':
624
-                    case 'post_content':
625
-                    case 'post_excerpt':
626
-                        $updated_post->{$field->type} = $value;
627
-                        break;
628
-                    case 'post_tags':
629
-                        wp_set_post_tags( $post_id, $value, false );
630
-                        break;
631
-                    case 'post_category':
632
-                        break;
633
-                    case 'post_custom_field':
543
+			$ary = ! empty( $entry[ $field_id ] ) ? explode( '|:|', $entry[ $field_id ] ) : array();
544
+			$img_url = rgar( $ary, 0 );
634 545
 
635
-                        $input_type = RGFormsModel::get_input_type( $field );
636
-                        $custom_field_name = $field->postCustomFieldName;
546
+			// is this really the same image or something went wrong ?
547
+			if( $img_url === $_POST[ $input_name ] ) {
637 548
 
638
-                        // Only certain custom field types are supported
639
-                        switch( $input_type ) {
640
-                            case 'fileupload':
641
-                            /** @noinspection PhpMissingBreakStatementInspection */
642
-                            case 'list':
643
-                                if( ! is_string( $value ) ) {
644
-                                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
645
-                                }
646
-                            // break; left intentionally out
647
-                            default:
648
-                                update_post_meta( $post_id, $custom_field_name, $value );
649
-                        }
549
+				$img_title       = rgar( $value, $field_id .'.1' );
550
+				$img_caption     = rgar( $value, $field_id .'.4' );
551
+				$img_description = rgar( $value, $field_id .'.7' );
650 552
 
651
-                        break;
553
+				$value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
652 554
 
653
-                    case 'post_image':
654
-                        $value = $this->update_post_image( $form, $field, $field_id, $value, $entry, $post_id );
655
-                        break;
555
+				if ( $field->postFeaturedImage ) {
656 556
 
657
-                }
557
+					$image_meta = array(
558
+						'ID' => get_post_thumbnail_id( $post_id ),
559
+						'post_title' => $img_title,
560
+						'post_excerpt' => $img_caption,
561
+						'post_content' => $img_description,
562
+					);
658 563
 
659
-                //ignore fields that have not changed
660
-                if ( $value === rgget( (string) $field_id, $entry ) ) {
661
-                    continue;
662
-                }
564
+					// update image title, caption or description
565
+					wp_update_post( $image_meta );
566
+				}
567
+			}
663 568
 
664
-                // update entry
665
-                if( 'post_category' !== $field->type ) {
666
-                    $entry[ strval( $field_id ) ] = $value;
667
-                }
569
+		} else {
668 570
 
669
-                $update_entry = true;
571
+			// if we get here, image was removed or not set.
572
+			$value = '';
670 573
 
671
-            }
574
+			if ( $field->postFeaturedImage ) {
575
+				delete_post_thumbnail( $post_id );
576
+			}
577
+		}
578
+
579
+		return $value;
580
+	}
581
+
582
+	/**
583
+	 * Loop through the fields being edited and if they include Post fields, update the Entry's post object
584
+	 *
585
+	 * @param array $form Gravity Forms form
586
+	 *
587
+	 * @return void
588
+	 */
589
+	private function maybe_update_post_fields( $form ) {
590
+
591
+		$post_id = $this->entry['post_id'];
592
+
593
+		// Security check
594
+		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
595
+			do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
596
+			return;
597
+		}
598
+
599
+		$update_entry = false;
600
+
601
+		$updated_post = $original_post = get_post( $post_id );
602
+
603
+		// get the most up to date entry values
604
+		$entry = GFAPI::get_entry( $this->entry['id'] );
672 605
 
673
-        }
606
+		foreach ( $entry as $field_id => $value ) {
674 607
 
675
-        if( $update_entry ) {
608
+			//todo: only run through the edit entry configured fields
676 609
 
677
-            $return_entry = GFAPI::update_entry( $entry );
610
+			$field = RGFormsModel::get_field( $form, $field_id );
678 611
 
679
-            if( is_wp_error( $return_entry ) ) {
680
-                do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
681
-            } else {
682
-                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
683
-            }
612
+			if( class_exists('GF_Fields') ) {
613
+				$field = GF_Fields::create( $field );
614
+			}
615
+
616
+			if( GFCommon::is_post_field( $field ) ) {
617
+
618
+				// Get the value of the field, including $_POSTed value
619
+				$value = RGFormsModel::get_field_value( $field );
620
+
621
+				switch( $field->type ) {
622
+
623
+					case 'post_title':
624
+					case 'post_content':
625
+					case 'post_excerpt':
626
+						$updated_post->{$field->type} = $value;
627
+						break;
628
+					case 'post_tags':
629
+						wp_set_post_tags( $post_id, $value, false );
630
+						break;
631
+					case 'post_category':
632
+						break;
633
+					case 'post_custom_field':
634
+
635
+						$input_type = RGFormsModel::get_input_type( $field );
636
+						$custom_field_name = $field->postCustomFieldName;
637
+
638
+						// Only certain custom field types are supported
639
+						switch( $input_type ) {
640
+							case 'fileupload':
641
+							/** @noinspection PhpMissingBreakStatementInspection */
642
+							case 'list':
643
+								if( ! is_string( $value ) ) {
644
+									$value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
645
+								}
646
+							// break; left intentionally out
647
+							default:
648
+								update_post_meta( $post_id, $custom_field_name, $value );
649
+						}
650
+
651
+						break;
652
+
653
+					case 'post_image':
654
+						$value = $this->update_post_image( $form, $field, $field_id, $value, $entry, $post_id );
655
+						break;
656
+
657
+				}
658
+
659
+				//ignore fields that have not changed
660
+				if ( $value === rgget( (string) $field_id, $entry ) ) {
661
+					continue;
662
+				}
663
+
664
+				// update entry
665
+				if( 'post_category' !== $field->type ) {
666
+					$entry[ strval( $field_id ) ] = $value;
667
+				}
668
+
669
+				$update_entry = true;
670
+
671
+			}
684 672
 
685
-        }
673
+		}
674
+
675
+		if( $update_entry ) {
686 676
 
687
-        $this->set_post_categories( $updated_post, $form, $entry );
677
+			$return_entry = GFAPI::update_entry( $entry );
688 678
 
689
-        $return_post = wp_update_post( $updated_post, true );
679
+			if( is_wp_error( $return_entry ) ) {
680
+				do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
681
+			} else {
682
+				do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
683
+			}
690 684
 
691
-        if( is_wp_error( $return_post ) ) {
692
-            $return_post->add_data( $updated_post, '$updated_post' );
693
-            do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
694
-        } else {
695
-            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
696
-        }
685
+		}
697 686
 
698
-    }
687
+		$this->set_post_categories( $updated_post, $form, $entry );
699 688
 
689
+		$return_post = wp_update_post( $updated_post, true );
700 690
 
701
-    /**
702
-     * Perform actions normally performed after updating a lead
703
-     *
704
-     * @since 1.8
705
-     *
706
-     * @see GFEntryDetail::lead_detail_page()
707
-     *
708
-     * @return void
709
-     */
710
-    function after_update() {
691
+		if( is_wp_error( $return_post ) ) {
692
+			$return_post->add_data( $updated_post, '$updated_post' );
693
+			do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
694
+		} else {
695
+			do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
696
+		}
697
+
698
+	}
699
+
700
+
701
+	/**
702
+	 * Perform actions normally performed after updating a lead
703
+	 *
704
+	 * @since 1.8
705
+	 *
706
+	 * @see GFEntryDetail::lead_detail_page()
707
+	 *
708
+	 * @return void
709
+	 */
710
+	function after_update() {
711 711
 
712
-        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
713
-        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
712
+		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
713
+		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
714 714
 
715
-        // Re-define the entry now that we've updated it.
716
-        $entry = RGFormsModel::get_lead( $this->entry['id'] );
715
+		// Re-define the entry now that we've updated it.
716
+		$entry = RGFormsModel::get_lead( $this->entry['id'] );
717 717
 
718
-        $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
718
+		$entry = GFFormsModel::set_entry_meta( $entry, $this->form );
719 719
 
720
-        // We need to clear the cache because Gravity Forms caches the field values, which
721
-        // we have just updated.
722
-        foreach ($this->form['fields'] as $key => $field) {
723
-            GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
724
-        }
720
+		// We need to clear the cache because Gravity Forms caches the field values, which
721
+		// we have just updated.
722
+		foreach ($this->form['fields'] as $key => $field) {
723
+			GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
724
+		}
725 725
 
726
-        $this->entry = $entry;
727
-    }
726
+		$this->entry = $entry;
727
+	}
728 728
 
729 729
 
730
-    /**
731
-     * Display the Edit Entry form
732
-     *
733
-     * @return [type] [description]
734
-     */
735
-    public function edit_entry_form() {
730
+	/**
731
+	 * Display the Edit Entry form
732
+	 *
733
+	 * @return [type] [description]
734
+	 */
735
+	public function edit_entry_form() {
736 736
 
737
-        ?>
737
+		?>
738 738
 
739 739
         <div class="gv-edit-entry-wrapper"><?php
740 740
 
741
-            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
741
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
742 742
 
743
-            /**
744
-             * Fixes weird wpautop() issue
745
-             * @see https://github.com/katzwebservices/GravityView/issues/451
746
-             */
747
-            echo gravityview_strip_whitespace( $javascript );
743
+			/**
744
+			 * Fixes weird wpautop() issue
745
+			 * @see https://github.com/katzwebservices/GravityView/issues/451
746
+			 */
747
+			echo gravityview_strip_whitespace( $javascript );
748 748
 
749
-            ?><h2 class="gv-edit-entry-title">
749
+			?><h2 class="gv-edit-entry-title">
750 750
                 <span><?php
751 751
 
752
-                    /**
753
-                     * @filter `gravityview_edit_entry_title` Modify the edit entry title
754
-                     * @param string $edit_entry_title Modify the "Edit Entry" title
755
-                     * @param GravityView_Edit_Entry_Render $this This object
756
-                     */
757
-                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
752
+					/**
753
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
754
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
755
+					 * @param GravityView_Edit_Entry_Render $this This object
756
+					 */
757
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
758 758
 
759
-                    echo esc_attr( $edit_entry_title );
760
-            ?></span>
759
+					echo esc_attr( $edit_entry_title );
760
+			?></span>
761 761
             </h2>
762 762
 
763 763
             <?php $this->maybe_print_message(); ?>
@@ -768,733 +768,733 @@  discard block
 block discarded – undo
768 768
 
769 769
                 <?php
770 770
 
771
-                wp_nonce_field( self::$nonce_key, self::$nonce_key );
771
+				wp_nonce_field( self::$nonce_key, self::$nonce_key );
772 772
 
773
-                wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
773
+				wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
774 774
 
775
-                // Print the actual form HTML
776
-                $this->render_edit_form();
775
+				// Print the actual form HTML
776
+				$this->render_edit_form();
777 777
 
778
-                ?>
778
+				?>
779 779
             </form>
780 780
 
781 781
         </div>
782 782
 
783 783
     <?php
784
-    }
785
-
786
-    /**
787
-     * Display success or error message if the form has been submitted
788
-     *
789
-     * @uses GVCommon::generate_notice
790
-     *
791
-     * @since 1.16.2.2
792
-     *
793
-     * @return void
794
-     */
795
-    private function maybe_print_message() {
796
-
797
-        if( rgpost('action') === 'update' ) {
798
-
799
-            $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
800
-
801
-            if( ! $this->is_valid ){
802
-
803
-                // Keeping this compatible with Gravity Forms.
804
-                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
805
-                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
806
-
807
-                echo GVCommon::generate_notice( $message , 'gv-error' );
808
-
809
-            } else {
810
-                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
811
-
812
-                /**
813
-                 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
814
-                 * @since 1.5.4
815
-                 * @param string $entry_updated_message Existing message
816
-                 * @param int $view_id View ID
817
-                 * @param array $entry Gravity Forms entry array
818
-                 * @param string $back_link URL to return to the original entry. @since 1.6
819
-                 */
820
-                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
821
-
822
-                echo GVCommon::generate_notice( $message );
823
-            }
824
-
825
-        }
826
-    }
827
-
828
-    /**
829
-     * Display the Edit Entry form in the original Gravity Forms format
830
-     *
831
-     * @since 1.9
832
-     *
833
-     * @return void
834
-     */
835
-    private function render_edit_form() {
836
-
837
-        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
838
-        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
839
-        add_filter( 'gform_disable_view_counter', '__return_true' );
840
-
841
-        add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
842
-        add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
843
-
844
-        add_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10, 3 );
845
-
846
-        // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
847
-        unset( $_GET['page'] );
848
-
849
-        // TODO: Verify multiple-page forms
850
-        // TODO: Product fields are not editable
851
-
852
-        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
853
-
854
-        remove_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10 );
855
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
856
-        remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
857
-        remove_filter( 'gform_disable_view_counter', '__return_true' );
858
-        remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
859
-        remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
860
-
861
-        echo $html;
862
-    }
863
-
864
-    /**
865
-     * Survey fields inject their output using `gform_field_input` filter, but in Edit Entry, the values were empty.
866
-     * We filter the values here because it was the easiest access point: tell the survey field the correct value, GF outputs it.
867
-     *
868
-     * @since 1.16.4
869
-     *
870
-     * @param string $value Existing value
871
-     * @param GF_Field $field
872
-     * @param string $name Field custom parameter name, normally blank.
873
-     *
874
-     * @return mixed
875
-     */
876
-    function fix_survey_fields_value( $value, $field, $name ) {
784
+	}
785
+
786
+	/**
787
+	 * Display success or error message if the form has been submitted
788
+	 *
789
+	 * @uses GVCommon::generate_notice
790
+	 *
791
+	 * @since 1.16.2.2
792
+	 *
793
+	 * @return void
794
+	 */
795
+	private function maybe_print_message() {
796
+
797
+		if( rgpost('action') === 'update' ) {
798
+
799
+			$back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
800
+
801
+			if( ! $this->is_valid ){
802
+
803
+				// Keeping this compatible with Gravity Forms.
804
+				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
805
+				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
806
+
807
+				echo GVCommon::generate_notice( $message , 'gv-error' );
808
+
809
+			} else {
810
+				$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
811
+
812
+				/**
813
+				 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
814
+				 * @since 1.5.4
815
+				 * @param string $entry_updated_message Existing message
816
+				 * @param int $view_id View ID
817
+				 * @param array $entry Gravity Forms entry array
818
+				 * @param string $back_link URL to return to the original entry. @since 1.6
819
+				 */
820
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
821
+
822
+				echo GVCommon::generate_notice( $message );
823
+			}
824
+
825
+		}
826
+	}
827
+
828
+	/**
829
+	 * Display the Edit Entry form in the original Gravity Forms format
830
+	 *
831
+	 * @since 1.9
832
+	 *
833
+	 * @return void
834
+	 */
835
+	private function render_edit_form() {
836
+
837
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
838
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
839
+		add_filter( 'gform_disable_view_counter', '__return_true' );
840
+
841
+		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
842
+		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
843
+
844
+		add_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10, 3 );
845
+
846
+		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
847
+		unset( $_GET['page'] );
848
+
849
+		// TODO: Verify multiple-page forms
850
+		// TODO: Product fields are not editable
851
+
852
+		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
853
+
854
+		remove_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10 );
855
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
856
+		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
857
+		remove_filter( 'gform_disable_view_counter', '__return_true' );
858
+		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
859
+		remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
860
+
861
+		echo $html;
862
+	}
863
+
864
+	/**
865
+	 * Survey fields inject their output using `gform_field_input` filter, but in Edit Entry, the values were empty.
866
+	 * We filter the values here because it was the easiest access point: tell the survey field the correct value, GF outputs it.
867
+	 *
868
+	 * @since 1.16.4
869
+	 *
870
+	 * @param string $value Existing value
871
+	 * @param GF_Field $field
872
+	 * @param string $name Field custom parameter name, normally blank.
873
+	 *
874
+	 * @return mixed
875
+	 */
876
+	function fix_survey_fields_value( $value, $field, $name ) {
877 877
         
878
-        if( 'survey' === $field->type ) {
879
-
880
-	        // We need to run through each survey row until we find a match for expected values
881
-	        foreach ( $this->entry as $field_id => $field_value ) {
882
-
883
-		        if ( floor( $field_id ) !== floor( $field->id ) ) {
884
-			        continue;
885
-		        }
886
-
887
-		        if( rgar( $field, 'gsurveyLikertEnableMultipleRows' ) ) {
888
-			        list( $row_val, $col_val ) = explode( ':', $field_value, 2 );
889
-
890
-		            // If the $name matches the $row_val, we are processing the correct row
891
-			        if( $row_val === $name ) {
892
-				        $value = $field_value;
893
-				        break;
894
-			        }
895
-		        } else {
896
-			        // When not processing multiple rows, the value is the $entry[ $field_id ] value.
897
-			        $value = $field_value;
898
-				    break;
899
-		        }
878
+		if( 'survey' === $field->type ) {
879
+
880
+			// We need to run through each survey row until we find a match for expected values
881
+			foreach ( $this->entry as $field_id => $field_value ) {
882
+
883
+				if ( floor( $field_id ) !== floor( $field->id ) ) {
884
+					continue;
885
+				}
886
+
887
+				if( rgar( $field, 'gsurveyLikertEnableMultipleRows' ) ) {
888
+					list( $row_val, $col_val ) = explode( ':', $field_value, 2 );
889
+
890
+					// If the $name matches the $row_val, we are processing the correct row
891
+					if( $row_val === $name ) {
892
+						$value = $field_value;
893
+						break;
894
+					}
895
+				} else {
896
+					// When not processing multiple rows, the value is the $entry[ $field_id ] value.
897
+					$value = $field_value;
898
+					break;
899
+				}
900 900
 			}
901
-        }
902
-
903
-        return $value;
904
-    }
905
-
906
-    /**
907
-     * Display the Update/Cancel/Delete buttons for the Edit Entry form
908
-     * @since 1.8
909
-     * @return string
910
-     */
911
-    public function render_form_buttons() {
912
-        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
913
-    }
914
-
915
-
916
-    /**
917
-     * Modify the form fields that are shown when using GFFormDisplay::get_form()
918
-     *
919
-     * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
920
-     *
921
-     * @param array $form
922
-     * @param boolean $ajax Whether in AJAX mode
923
-     * @param array|string $field_values Passed parameters to the form
924
-     *
925
-     * @since 1.9
926
-     *
927
-     * @return array Modified form array
928
-     */
929
-    public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
930
-
931
-        // In case we have validated the form, use it to inject the validation results into the form render
932
-        if( isset( $this->form_after_validation ) ) {
933
-            $form = $this->form_after_validation;
934
-        } else {
935
-            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
936
-        }
937
-
938
-        $form = $this->filter_conditional_logic( $form );
939
-
940
-        // for now we don't support Save and Continue feature.
941
-        if( ! self::$supports_save_and_continue ) {
942
-	        unset( $form['save'] );
943
-        }
944
-
945
-        return $form;
946
-    }
947
-
948
-    /**
949
-     * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
950
-     *
951
-     * @since 1.16.2.2
952
-     *
953
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
954
-     * @param GF_Field $field
955
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
956
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
957
-     * @param int $form_id Form ID
958
-     *
959
-     * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
960
-     */
961
-    function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
962
-
963
-        if( GFCommon::is_post_field( $field ) ) {
964
-
965
-            $message = null;
966
-
967
-            // First, make sure they have the capability to edit the post.
968
-            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
969
-
970
-                /**
971
-                 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
972
-                 * @param string $message The existing "You don't have permission..." text
973
-                 */
974
-                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
975
-
976
-            } elseif( null === get_post( $this->entry['post_id'] ) ) {
977
-                /**
978
-                 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
979
-                 * @param string $message The existing "This field is not editable; the post no longer exists." text
980
-                 */
981
-                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
982
-            }
983
-
984
-            if( $message ) {
985
-                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
986
-            }
987
-        }
988
-
989
-        return $field_content;
990
-    }
991
-
992
-    /**
993
-     *
994
-     * Fill-in the saved values into the form inputs
995
-     *
996
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
997
-     * @param GF_Field $field
998
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
999
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1000
-     * @param int $form_id Form ID
1001
-     *
1002
-     * @return mixed
1003
-     */
1004
-    function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1005
-
1006
-        $gv_field = GravityView_Fields::get_associated_field( $field );
1007
-
1008
-        // If the form has been submitted, then we don't need to pre-fill the values,
1009
-        // Except for fileupload type and when a field input is overridden- run always!!
1010
-        if(
1011
-            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1012
-            && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1013
-            || ! empty( $field_content )
1014
-            || GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
1015
-        ) {
1016
-	        return $field_content;
1017
-        }
1018
-
1019
-        // Turn on Admin-style display for file upload fields only
1020
-        if( 'fileupload' === $field->type ) {
1021
-            $_GET['page'] = 'gf_entries';
1022
-        }
1023
-
1024
-        // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
1025
-        $field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
1026
-
1027
-        // add categories as choices for Post Category field
1028
-        if ( 'post_category' === $field->type ) {
1029
-            $field = GFCommon::add_categories_as_choices( $field, $value );
1030
-        }
1031
-
1032
-        $field_value = $this->get_field_value( $field );
1033
-
1034
-        /**
1035
-         * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1036
-         * @since 1.11
1037
-         * @param mixed $field_value field value used to populate the input
1038
-         * @param object $field Gravity Forms field object ( Class GF_Field )
1039
-         */
1040
-        $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field );
1041
-
1042
-	    // Prevent any PHP warnings, like undefined index
1043
-	    ob_start();
1044
-
1045
-        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1046
-            /** @var GF_Field $gv_field */
1047
-            $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1048
-        } else {
1049
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1050
-        }
1051
-
1052
-
1053
-	    // If there was output, it's an error
1054
-	    $warnings = ob_get_clean();
1055
-
1056
-	    if( !empty( $warnings ) ) {
1057
-		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1058
-	    }
1059
-
1060
-        /**
1061
-         * Unset hack $_GET['page'] = 'gf_entries'
1062
-         * We need the fileupload html field to render with the proper id
1063
-         *  ( <li id="field_80_16" ... > )
1064
-         */
1065
-        unset( $_GET['page'] );
1066
-
1067
-        return $return;
1068
-    }
1069
-
1070
-    /**
1071
-     * Modify the value for the current field input
1072
-     *
1073
-     * @param GF_Field $field
1074
-     *
1075
-     * @return array|mixed|string|void
1076
-     */
1077
-    private function get_field_value( $field ) {
1078
-
1079
-        /**
1080
-         * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
1081
-         * @param boolean True: override saved values; False: don't override (default)
1082
-         * @param $field GF_Field object Gravity Forms field object
1083
-         * @since 1.13
1084
-         */
1085
-        $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1086
-
1087
-        // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1088
-        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1089
-
1090
-            $field_value = array();
1091
-
1092
-            // only accept pre-populated values if the field doesn't have any choice selected.
1093
-            $allow_pre_populated = $field->allowsPrepopulate;
1094
-
1095
-            foreach ( (array)$field->inputs as $input ) {
1096
-
1097
-                $input_id = strval( $input['id'] );
901
+		}
902
+
903
+		return $value;
904
+	}
905
+
906
+	/**
907
+	 * Display the Update/Cancel/Delete buttons for the Edit Entry form
908
+	 * @since 1.8
909
+	 * @return string
910
+	 */
911
+	public function render_form_buttons() {
912
+		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
913
+	}
914
+
915
+
916
+	/**
917
+	 * Modify the form fields that are shown when using GFFormDisplay::get_form()
918
+	 *
919
+	 * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
920
+	 *
921
+	 * @param array $form
922
+	 * @param boolean $ajax Whether in AJAX mode
923
+	 * @param array|string $field_values Passed parameters to the form
924
+	 *
925
+	 * @since 1.9
926
+	 *
927
+	 * @return array Modified form array
928
+	 */
929
+	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
930
+
931
+		// In case we have validated the form, use it to inject the validation results into the form render
932
+		if( isset( $this->form_after_validation ) ) {
933
+			$form = $this->form_after_validation;
934
+		} else {
935
+			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
936
+		}
937
+
938
+		$form = $this->filter_conditional_logic( $form );
939
+
940
+		// for now we don't support Save and Continue feature.
941
+		if( ! self::$supports_save_and_continue ) {
942
+			unset( $form['save'] );
943
+		}
944
+
945
+		return $form;
946
+	}
947
+
948
+	/**
949
+	 * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
950
+	 *
951
+	 * @since 1.16.2.2
952
+	 *
953
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
954
+	 * @param GF_Field $field
955
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
956
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
957
+	 * @param int $form_id Form ID
958
+	 *
959
+	 * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
960
+	 */
961
+	function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
962
+
963
+		if( GFCommon::is_post_field( $field ) ) {
964
+
965
+			$message = null;
966
+
967
+			// First, make sure they have the capability to edit the post.
968
+			if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
969
+
970
+				/**
971
+				 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
972
+				 * @param string $message The existing "You don't have permission..." text
973
+				 */
974
+				$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
975
+
976
+			} elseif( null === get_post( $this->entry['post_id'] ) ) {
977
+				/**
978
+				 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
979
+				 * @param string $message The existing "This field is not editable; the post no longer exists." text
980
+				 */
981
+				$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
982
+			}
983
+
984
+			if( $message ) {
985
+				$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
986
+			}
987
+		}
988
+
989
+		return $field_content;
990
+	}
991
+
992
+	/**
993
+	 *
994
+	 * Fill-in the saved values into the form inputs
995
+	 *
996
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
997
+	 * @param GF_Field $field
998
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
999
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
1000
+	 * @param int $form_id Form ID
1001
+	 *
1002
+	 * @return mixed
1003
+	 */
1004
+	function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1005
+
1006
+		$gv_field = GravityView_Fields::get_associated_field( $field );
1007
+
1008
+		// If the form has been submitted, then we don't need to pre-fill the values,
1009
+		// Except for fileupload type and when a field input is overridden- run always!!
1010
+		if(
1011
+			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1012
+			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1013
+			|| ! empty( $field_content )
1014
+			|| GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
1015
+		) {
1016
+			return $field_content;
1017
+		}
1018
+
1019
+		// Turn on Admin-style display for file upload fields only
1020
+		if( 'fileupload' === $field->type ) {
1021
+			$_GET['page'] = 'gf_entries';
1022
+		}
1023
+
1024
+		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
1025
+		$field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
1026
+
1027
+		// add categories as choices for Post Category field
1028
+		if ( 'post_category' === $field->type ) {
1029
+			$field = GFCommon::add_categories_as_choices( $field, $value );
1030
+		}
1031
+
1032
+		$field_value = $this->get_field_value( $field );
1033
+
1034
+		/**
1035
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1036
+		 * @since 1.11
1037
+		 * @param mixed $field_value field value used to populate the input
1038
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
1039
+		 */
1040
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field );
1041
+
1042
+		// Prevent any PHP warnings, like undefined index
1043
+		ob_start();
1044
+
1045
+		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1046
+			/** @var GF_Field $gv_field */
1047
+			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1048
+		} else {
1049
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
1050
+		}
1051
+
1052
+
1053
+		// If there was output, it's an error
1054
+		$warnings = ob_get_clean();
1055
+
1056
+		if( !empty( $warnings ) ) {
1057
+			do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1058
+		}
1059
+
1060
+		/**
1061
+		 * Unset hack $_GET['page'] = 'gf_entries'
1062
+		 * We need the fileupload html field to render with the proper id
1063
+		 *  ( <li id="field_80_16" ... > )
1064
+		 */
1065
+		unset( $_GET['page'] );
1066
+
1067
+		return $return;
1068
+	}
1069
+
1070
+	/**
1071
+	 * Modify the value for the current field input
1072
+	 *
1073
+	 * @param GF_Field $field
1074
+	 *
1075
+	 * @return array|mixed|string|void
1076
+	 */
1077
+	private function get_field_value( $field ) {
1078
+
1079
+		/**
1080
+		 * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
1081
+		 * @param boolean True: override saved values; False: don't override (default)
1082
+		 * @param $field GF_Field object Gravity Forms field object
1083
+		 * @since 1.13
1084
+		 */
1085
+		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1086
+
1087
+		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1088
+		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1089
+
1090
+			$field_value = array();
1091
+
1092
+			// only accept pre-populated values if the field doesn't have any choice selected.
1093
+			$allow_pre_populated = $field->allowsPrepopulate;
1094
+
1095
+			foreach ( (array)$field->inputs as $input ) {
1096
+
1097
+				$input_id = strval( $input['id'] );
1098 1098
                 
1099
-                if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1100
-                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1101
-                    $allow_pre_populated = false;
1102
-                }
1099
+				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1100
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1101
+					$allow_pre_populated = false;
1102
+				}
1103 1103
 
1104
-            }
1104
+			}
1105 1105
 
1106
-            $pre_value = $field->get_value_submission( array(), false );
1106
+			$pre_value = $field->get_value_submission( array(), false );
1107 1107
 
1108
-            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1108
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1109 1109
 
1110
-        } else {
1110
+		} else {
1111 1111
 
1112
-            $id = intval( $field->id );
1112
+			$id = intval( $field->id );
1113 1113
 
1114
-            // get pre-populated value if exists
1115
-            $pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1114
+			// get pre-populated value if exists
1115
+			$pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1116 1116
 
1117
-            // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1118
-            // or pre-populated value if not empty and set to override saved value
1119
-            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1117
+			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1118
+			// or pre-populated value if not empty and set to override saved value
1119
+			$field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1120 1120
 
1121
-            // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1122
-            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1123
-                $categories = array();
1124
-                foreach ( explode( ',', $field_value ) as $cat_string ) {
1125
-                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1126
-                }
1127
-                $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1128
-            }
1121
+			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1122
+			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1123
+				$categories = array();
1124
+				foreach ( explode( ',', $field_value ) as $cat_string ) {
1125
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1126
+				}
1127
+				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1128
+			}
1129 1129
 
1130
-        }
1130
+		}
1131 1131
 
1132
-        // if value is empty get the default value if defined
1133
-        $field_value = $field->get_value_default_if_empty( $field_value );
1132
+		// if value is empty get the default value if defined
1133
+		$field_value = $field->get_value_default_if_empty( $field_value );
1134 1134
 
1135
-        return $field_value;
1136
-    }
1135
+		return $field_value;
1136
+	}
1137 1137
 
1138 1138
 
1139
-    // ---- Entry validation
1139
+	// ---- Entry validation
1140 1140
 
1141
-    /**
1142
-     * Add field keys that Gravity Forms expects.
1143
-     *
1144
-     * @see GFFormDisplay::validate()
1145
-     * @param  array $form GF Form
1146
-     * @return array       Modified GF Form
1147
-     */
1148
-    function gform_pre_validation( $form ) {
1141
+	/**
1142
+	 * Add field keys that Gravity Forms expects.
1143
+	 *
1144
+	 * @see GFFormDisplay::validate()
1145
+	 * @param  array $form GF Form
1146
+	 * @return array       Modified GF Form
1147
+	 */
1148
+	function gform_pre_validation( $form ) {
1149 1149
 
1150
-        if( ! $this->verify_nonce() ) {
1151
-            return $form;
1152
-        }
1150
+		if( ! $this->verify_nonce() ) {
1151
+			return $form;
1152
+		}
1153 1153
 
1154
-        // Fix PHP warning regarding undefined index.
1155
-        foreach ( $form['fields'] as &$field) {
1154
+		// Fix PHP warning regarding undefined index.
1155
+		foreach ( $form['fields'] as &$field) {
1156 1156
 
1157
-            // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1158
-            // expects certain field array items to be set.
1159
-            foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1160
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1161
-            }
1157
+			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1158
+			// expects certain field array items to be set.
1159
+			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1160
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1161
+			}
1162 1162
 
1163
-            // unset emailConfirmEnabled for email type fields
1164
-           /* if( 'email' === $field['type'] && !empty( $field['emailConfirmEnabled'] ) ) {
1163
+			// unset emailConfirmEnabled for email type fields
1164
+		   /* if( 'email' === $field['type'] && !empty( $field['emailConfirmEnabled'] ) ) {
1165 1165
                 $field['emailConfirmEnabled'] = '';
1166 1166
             }*/
1167 1167
 
1168
-            switch( RGFormsModel::get_input_type( $field ) ) {
1168
+			switch( RGFormsModel::get_input_type( $field ) ) {
1169 1169
 
1170
-                /**
1171
-                 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1172
-                 *
1173
-                 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1174
-                 *
1175
-                 * @hack
1176
-                 */
1177
-                case 'fileupload':
1178
-
1179
-                    // Set the previous value
1180
-                    $entry = $this->get_entry();
1181
-
1182
-                    $input_name = 'input_'.$field->id;
1183
-                    $form_id = $form['id'];
1184
-
1185
-                    $value = NULL;
1186
-
1187
-                    // Use the previous entry value as the default.
1188
-                    if( isset( $entry[ $field->id ] ) ) {
1189
-                        $value = $entry[ $field->id ];
1190
-                    }
1170
+				/**
1171
+				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1172
+				 *
1173
+				 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1174
+				 *
1175
+				 * @hack
1176
+				 */
1177
+				case 'fileupload':
1191 1178
 
1192
-                    // If this is a single upload file
1193
-                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1194
-                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1195
-                        $value = $file_path['url'];
1179
+					// Set the previous value
1180
+					$entry = $this->get_entry();
1196 1181
 
1197
-                    } else {
1198
-
1199
-                        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1200
-                        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1201
-                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1202
-
1203
-                    }
1204
-
1205
-                    if( rgar($field, "multipleFiles") ) {
1206
-
1207
-                        // If there are fresh uploads, process and merge them.
1208
-                        // Otherwise, use the passed values, which should be json-encoded array of URLs
1209
-                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1210
-                            $value = empty( $value ) ? '[]' : $value;
1211
-                            $value = stripslashes_deep( $value );
1212
-                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1213
-                        }
1182
+					$input_name = 'input_'.$field->id;
1183
+					$form_id = $form['id'];
1214 1184
 
1215
-                    } else {
1185
+					$value = NULL;
1216 1186
 
1217
-                        // A file already exists when editing an entry
1218
-                        // We set this to solve issue when file upload fields are required.
1219
-                        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1187
+					// Use the previous entry value as the default.
1188
+					if( isset( $entry[ $field->id ] ) ) {
1189
+						$value = $entry[ $field->id ];
1190
+					}
1220 1191
 
1221
-                    }
1192
+					// If this is a single upload file
1193
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1194
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1195
+						$value = $file_path['url'];
1222 1196
 
1223
-                    $this->entry[ $input_name ] = $value;
1224
-                    $_POST[ $input_name ] = $value;
1197
+					} else {
1225 1198
 
1226
-                    break;
1199
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1200
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1201
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1227 1202
 
1228
-                case 'number':
1229
-                    // Fix "undefined index" issue at line 1286 in form_display.php
1230
-                    if( !isset( $_POST['input_'.$field->id ] ) ) {
1231
-                        $_POST['input_'.$field->id ] = NULL;
1232
-                    }
1233
-                    break;
1234
-                case 'captcha':
1235
-                    // Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1236
-                    $_POST['recaptcha_challenge_field'] = NULL;
1237
-                    $_POST['recaptcha_response_field'] = NULL;
1238
-                    break;
1239
-            }
1203
+					}
1240 1204
 
1241
-        }
1205
+					if( rgar($field, "multipleFiles") ) {
1242 1206
 
1243
-        return $form;
1244
-    }
1207
+						// If there are fresh uploads, process and merge them.
1208
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1209
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1210
+							$value = empty( $value ) ? '[]' : $value;
1211
+							$value = stripslashes_deep( $value );
1212
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1213
+						}
1245 1214
 
1215
+					} else {
1246 1216
 
1247
-    /**
1248
-     * Process validation for a edit entry submission
1249
-     *
1250
-     * Sets the `is_valid` object var
1251
-     *
1252
-     * @return void
1253
-     */
1254
-    function validate() {
1217
+						// A file already exists when editing an entry
1218
+						// We set this to solve issue when file upload fields are required.
1219
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1255 1220
 
1256
-        /**
1257
-         * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1258
-         * GF User Registration Add-on version > 3.x has a different class name
1259
-         * @since 1.16.2
1260
-         */
1261
-        if ( class_exists( 'GF_User_Registration' ) ) {
1262
-            remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1263
-        } else  if ( class_exists( 'GFUser' ) ) {
1264
-            remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1265
-        }
1221
+					}
1266 1222
 
1223
+					$this->entry[ $input_name ] = $value;
1224
+					$_POST[ $input_name ] = $value;
1267 1225
 
1268
-        /**
1269
-         * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1270
-         * You can enter whatever you want!
1271
-         * We try validating, and customize the results using `self::custom_validation()`
1272
-         */
1273
-        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1226
+					break;
1274 1227
 
1275
-        // Needed by the validate funtion
1276
-        $failed_validation_page = NULL;
1277
-        $field_values = RGForms::post( 'gform_field_values' );
1228
+				case 'number':
1229
+					// Fix "undefined index" issue at line 1286 in form_display.php
1230
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1231
+						$_POST['input_'.$field->id ] = NULL;
1232
+					}
1233
+					break;
1234
+				case 'captcha':
1235
+					// Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1236
+					$_POST['recaptcha_challenge_field'] = NULL;
1237
+					$_POST['recaptcha_response_field'] = NULL;
1238
+					break;
1239
+			}
1278 1240
 
1279
-        // Prevent entry limit from running when editing an entry, also
1280
-        // prevent form scheduling from preventing editing
1281
-        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1241
+		}
1282 1242
 
1283
-        // Hide fields depending on Edit Entry settings
1284
-        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1243
+		return $form;
1244
+	}
1285 1245
 
1286
-        $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1287 1246
 
1288
-        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1289
-    }
1247
+	/**
1248
+	 * Process validation for a edit entry submission
1249
+	 *
1250
+	 * Sets the `is_valid` object var
1251
+	 *
1252
+	 * @return void
1253
+	 */
1254
+	function validate() {
1255
+
1256
+		/**
1257
+		 * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1258
+		 * GF User Registration Add-on version > 3.x has a different class name
1259
+		 * @since 1.16.2
1260
+		 */
1261
+		if ( class_exists( 'GF_User_Registration' ) ) {
1262
+			remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1263
+		} else  if ( class_exists( 'GFUser' ) ) {
1264
+			remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1265
+		}
1290 1266
 
1291 1267
 
1292
-    /**
1293
-     * Make validation work for Edit Entry
1294
-     *
1295
-     * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1296
-     * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1297
-     * fields. This goes through all the fields and if they're an invalid post field, we
1298
-     * set them as valid. If there are still issues, we'll return false.
1299
-     *
1300
-     * @param  [type] $validation_results [description]
1301
-     * @return [type]                     [description]
1302
-     */
1303
-    function custom_validation( $validation_results ) {
1268
+		/**
1269
+		 * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1270
+		 * You can enter whatever you want!
1271
+		 * We try validating, and customize the results using `self::custom_validation()`
1272
+		 */
1273
+		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1304 1274
 
1305
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1275
+		// Needed by the validate funtion
1276
+		$failed_validation_page = NULL;
1277
+		$field_values = RGForms::post( 'gform_field_values' );
1306 1278
 
1307
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1279
+		// Prevent entry limit from running when editing an entry, also
1280
+		// prevent form scheduling from preventing editing
1281
+		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1308 1282
 
1309
-        $gv_valid = true;
1283
+		// Hide fields depending on Edit Entry settings
1284
+		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1310 1285
 
1311
-        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1286
+		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1312 1287
 
1313
-            $value = RGFormsModel::get_field_value( $field );
1314
-            $field_type = RGFormsModel::get_input_type( $field );
1288
+		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1289
+	}
1315 1290
 
1316
-            // Validate always
1317
-            switch ( $field_type ) {
1318 1291
 
1292
+	/**
1293
+	 * Make validation work for Edit Entry
1294
+	 *
1295
+	 * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1296
+	 * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1297
+	 * fields. This goes through all the fields and if they're an invalid post field, we
1298
+	 * set them as valid. If there are still issues, we'll return false.
1299
+	 *
1300
+	 * @param  [type] $validation_results [description]
1301
+	 * @return [type]                     [description]
1302
+	 */
1303
+	function custom_validation( $validation_results ) {
1319 1304
 
1320
-                case 'fileupload' :
1321
-                case 'post_image':
1305
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1322 1306
 
1323
-                    // in case nothing is uploaded but there are already files saved
1324
-                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1325
-                        $field->failed_validation = false;
1326
-                        unset( $field->validation_message );
1327
-                    }
1307
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1328 1308
 
1329
-                    // validate if multi file upload reached max number of files [maxFiles] => 2
1330
-                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1309
+		$gv_valid = true;
1331 1310
 
1332
-                        $input_name = 'input_' . $field->id;
1333
-                        //uploaded
1334
-                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1311
+		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1335 1312
 
1336
-                        //existent
1337
-                        $entry = $this->get_entry();
1338
-                        $value = NULL;
1339
-                        if( isset( $entry[ $field->id ] ) ) {
1340
-                            $value = json_decode( $entry[ $field->id ], true );
1341
-                        }
1313
+			$value = RGFormsModel::get_field_value( $field );
1314
+			$field_type = RGFormsModel::get_input_type( $field );
1342 1315
 
1343
-                        // count uploaded files and existent entry files
1344
-                        $count_files = count( $file_names ) + count( $value );
1316
+			// Validate always
1317
+			switch ( $field_type ) {
1345 1318
 
1346
-                        if( $count_files > $field->maxFiles ) {
1347
-                            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1348
-                            $field->failed_validation = 1;
1349
-                            $gv_valid = false;
1350 1319
 
1351
-                            // in case of error make sure the newest upload files are removed from the upload input
1352
-                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1353
-                        }
1320
+				case 'fileupload' :
1321
+				case 'post_image':
1354 1322
 
1355
-                    }
1323
+					// in case nothing is uploaded but there are already files saved
1324
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1325
+						$field->failed_validation = false;
1326
+						unset( $field->validation_message );
1327
+					}
1356 1328
 
1329
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1330
+					if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1357 1331
 
1358
-                    break;
1332
+						$input_name = 'input_' . $field->id;
1333
+						//uploaded
1334
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1359 1335
 
1360
-            }
1336
+						//existent
1337
+						$entry = $this->get_entry();
1338
+						$value = NULL;
1339
+						if( isset( $entry[ $field->id ] ) ) {
1340
+							$value = json_decode( $entry[ $field->id ], true );
1341
+						}
1361 1342
 
1362
-            // This field has failed validation.
1363
-            if( !empty( $field->failed_validation ) ) {
1343
+						// count uploaded files and existent entry files
1344
+						$count_files = count( $file_names ) + count( $value );
1364 1345
 
1365
-                do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1346
+						if( $count_files > $field->maxFiles ) {
1347
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1348
+							$field->failed_validation = 1;
1349
+							$gv_valid = false;
1366 1350
 
1367
-                switch ( $field_type ) {
1351
+							// in case of error make sure the newest upload files are removed from the upload input
1352
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1353
+						}
1368 1354
 
1369
-                    // Captchas don't need to be re-entered.
1370
-                    case 'captcha':
1355
+					}
1371 1356
 
1372
-                        // Post Image fields aren't editable, so we un-fail them.
1373
-                    case 'post_image':
1374
-                        $field->failed_validation = false;
1375
-                        unset( $field->validation_message );
1376
-                        break;
1377 1357
 
1378
-                }
1358
+					break;
1379 1359
 
1380
-                // You can't continue inside a switch, so we do it after.
1381
-                if( empty( $field->failed_validation ) ) {
1382
-                    continue;
1383
-                }
1360
+			}
1384 1361
 
1385
-                // checks if the No Duplicates option is not validating entry against itself, since
1386
-                // we're editing a stored entry, it would also assume it's a duplicate.
1387
-                if( !empty( $field->noDuplicates ) ) {
1362
+			// This field has failed validation.
1363
+			if( !empty( $field->failed_validation ) ) {
1388 1364
 
1389
-                    $entry = $this->get_entry();
1365
+				do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1390 1366
 
1391
-                    // If the value of the entry is the same as the stored value
1392
-                    // Then we can assume it's not a duplicate, it's the same.
1393
-                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1394
-                        //if value submitted was not changed, then don't validate
1395
-                        $field->failed_validation = false;
1367
+				switch ( $field_type ) {
1396 1368
 
1397
-                        unset( $field->validation_message );
1369
+					// Captchas don't need to be re-entered.
1370
+					case 'captcha':
1398 1371
 
1399
-                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1372
+						// Post Image fields aren't editable, so we un-fail them.
1373
+					case 'post_image':
1374
+						$field->failed_validation = false;
1375
+						unset( $field->validation_message );
1376
+						break;
1400 1377
 
1401
-                        continue;
1402
-                    }
1403
-                }
1378
+				}
1404 1379
 
1405
-                // if here then probably we are facing the validation 'At least one field must be filled out'
1406
-                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1407
-                    unset( $field->validation_message );
1408
-	                $field->validation_message = false;
1409
-                    continue;
1410
-                }
1380
+				// You can't continue inside a switch, so we do it after.
1381
+				if( empty( $field->failed_validation ) ) {
1382
+					continue;
1383
+				}
1411 1384
 
1412
-                $gv_valid = false;
1385
+				// checks if the No Duplicates option is not validating entry against itself, since
1386
+				// we're editing a stored entry, it would also assume it's a duplicate.
1387
+				if( !empty( $field->noDuplicates ) ) {
1413 1388
 
1414
-            }
1389
+					$entry = $this->get_entry();
1415 1390
 
1416
-        }
1391
+					// If the value of the entry is the same as the stored value
1392
+					// Then we can assume it's not a duplicate, it's the same.
1393
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1394
+						//if value submitted was not changed, then don't validate
1395
+						$field->failed_validation = false;
1417 1396
 
1418
-        $validation_results['is_valid'] = $gv_valid;
1397
+						unset( $field->validation_message );
1419 1398
 
1420
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1399
+						do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1421 1400
 
1422
-        // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1423
-        $this->form_after_validation = $validation_results['form'];
1401
+						continue;
1402
+					}
1403
+				}
1424 1404
 
1425
-        return $validation_results;
1426
-    }
1405
+				// if here then probably we are facing the validation 'At least one field must be filled out'
1406
+				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1407
+					unset( $field->validation_message );
1408
+					$field->validation_message = false;
1409
+					continue;
1410
+				}
1427 1411
 
1412
+				$gv_valid = false;
1428 1413
 
1429
-    /**
1430
-     * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1431
-     * Get the current entry and set it if it's not yet set.
1432
-     * @return array Gravity Forms entry array
1433
-     */
1434
-    private function get_entry() {
1414
+			}
1435 1415
 
1436
-        if( empty( $this->entry ) ) {
1437
-            // Get the database value of the entry that's being edited
1438
-            $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1439
-        }
1416
+		}
1440 1417
 
1441
-        return $this->entry;
1442
-    }
1418
+		$validation_results['is_valid'] = $gv_valid;
1443 1419
 
1420
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1444 1421
 
1422
+		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1423
+		$this->form_after_validation = $validation_results['form'];
1445 1424
 
1446
-    // --- Filters
1425
+		return $validation_results;
1426
+	}
1447 1427
 
1448
-    /**
1449
-     * Get the Edit Entry fields as configured in the View
1450
-     *
1451
-     * @since 1.8
1452
-     *
1453
-     * @param int $view_id
1454
-     *
1455
-     * @return array Array of fields that are configured in the Edit tab in the Admin
1456
-     */
1457
-    private function get_configured_edit_fields( $form, $view_id ) {
1458 1428
 
1459
-        // Get all fields for form
1460
-        $properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1429
+	/**
1430
+	 * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1431
+	 * Get the current entry and set it if it's not yet set.
1432
+	 * @return array Gravity Forms entry array
1433
+	 */
1434
+	private function get_entry() {
1435
+
1436
+		if( empty( $this->entry ) ) {
1437
+			// Get the database value of the entry that's being edited
1438
+			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1439
+		}
1440
+
1441
+		return $this->entry;
1442
+	}
1443
+
1444
+
1445
+
1446
+	// --- Filters
1447
+
1448
+	/**
1449
+	 * Get the Edit Entry fields as configured in the View
1450
+	 *
1451
+	 * @since 1.8
1452
+	 *
1453
+	 * @param int $view_id
1454
+	 *
1455
+	 * @return array Array of fields that are configured in the Edit tab in the Admin
1456
+	 */
1457
+	private function get_configured_edit_fields( $form, $view_id ) {
1461 1458
 
1462
-        // If edit tab not yet configured, show all fields
1463
-        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1459
+		// Get all fields for form
1460
+		$properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1464 1461
 
1465
-	    // Show hidden fields as text fields
1466
-	    $form = $this->fix_hidden_fields( $form );
1462
+		// If edit tab not yet configured, show all fields
1463
+		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1467 1464
 
1468
-        // Show hidden fields as text fields
1469
-        $form = $this->fix_survey_fields( $form );
1465
+		// Show hidden fields as text fields
1466
+		$form = $this->fix_hidden_fields( $form );
1470 1467
 
1471
-        // Hide fields depending on admin settings
1472
-        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1468
+		// Show hidden fields as text fields
1469
+		$form = $this->fix_survey_fields( $form );
1473 1470
 
1474
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1475
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1471
+		// Hide fields depending on admin settings
1472
+		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1476 1473
 
1477
-        return $fields;
1478
-    }
1474
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1475
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1479 1476
 
1480
-    /**
1481
-     * Make sure Survey fields accept pre-populating values; otherwise existing values won't be filled-in
1482
-     *
1483
-     * @since 1.16.4
1484
-     *
1485
-     * @param array $form
1486
-     *
1487
-     * @return array Form, with all fields set to `allowsPrepopulate => true`
1488
-     */
1489
-    private function fix_survey_fields( $form ) {
1477
+		return $fields;
1478
+	}
1490 1479
 
1491
-        /** @var GF_Field $field */
1492
-        foreach( $form['fields'] as &$field ) {
1493
-            $field->allowsPrepopulate = true;
1494
-        }
1480
+	/**
1481
+	 * Make sure Survey fields accept pre-populating values; otherwise existing values won't be filled-in
1482
+	 *
1483
+	 * @since 1.16.4
1484
+	 *
1485
+	 * @param array $form
1486
+	 *
1487
+	 * @return array Form, with all fields set to `allowsPrepopulate => true`
1488
+	 */
1489
+	private function fix_survey_fields( $form ) {
1495 1490
 
1496
-        return $form;
1497
-    }
1491
+		/** @var GF_Field $field */
1492
+		foreach( $form['fields'] as &$field ) {
1493
+			$field->allowsPrepopulate = true;
1494
+		}
1495
+
1496
+		return $form;
1497
+	}
1498 1498
 
1499 1499
 	/**
1500 1500
 	 * @since 1.9.2
@@ -1518,383 +1518,383 @@  discard block
 block discarded – undo
1518 1518
 	}
1519 1519
 
1520 1520
 
1521
-    /**
1522
-     * Filter area fields based on specified conditions
1523
-     *  - This filter removes the fields that have calculation configured
1524
-     *
1525
-     * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1526
-     * @access private
1527
-     * @param GF_Field[] $fields
1528
-     * @param array $configured_fields
1529
-     * @since  1.5
1530
-     * @return array $fields
1531
-     */
1532
-    private function filter_fields( $fields, $configured_fields ) {
1533
-
1534
-        if( empty( $fields ) || !is_array( $fields ) ) {
1535
-            return $fields;
1536
-        }
1537
-
1538
-        $edit_fields = array();
1539
-
1540
-        $field_type_blacklist = array(
1541
-            'page',
1542
-        );
1543
-
1544
-	    /**
1545
-	     * @filter `gravityview/edit_entry/hide-product-fields` Hide product fields from being editable.
1546
-	     * @since 1.9.1
1547
-         * @param boolean $hide_product_fields Whether to hide product fields in the editor.  Default: false
1548
-	     */
1549
-	    $hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1550
-
1551
-	    if( $hide_product_fields ) {
1552
-		    $field_type_blacklist[] = 'option';
1553
-		    $field_type_blacklist[] = 'quantity';
1554
-            $field_type_blacklist[] = 'product';
1555
-            $field_type_blacklist[] = 'total';
1556
-            $field_type_blacklist[] = 'shipping';
1557
-            $field_type_blacklist[] = 'calculation';
1558
-	    }
1559
-
1560
-        // First, remove blacklist or calculation fields
1561
-        foreach ( $fields as $key => $field ) {
1562
-
1563
-            // Remove the fields that have calculation properties and keep them to be used later
1564
-            // @since 1.16.2
1565
-            if( $field->has_calculation() ) {
1566
-                $this->fields_with_calculation[] = $field;
1567
-                // don't remove the calculation fields on form render.
1568
-            }
1569
-
1570
-            // process total field after all fields have been saved
1571
-            if ( $field->type == 'total' ) {
1572
-                $this->total_fields[] = $field;
1573
-                unset( $fields[ $key ] );
1574
-            }
1575
-
1576
-            if( in_array( $field->type, $field_type_blacklist ) ) {
1577
-                unset( $fields[ $key ] );
1578
-            }
1579
-        }
1580
-
1581
-        // The Edit tab has not been configured, so we return all fields by default.
1582
-        if( empty( $configured_fields ) ) {
1583
-            return $fields;
1584
-        }
1585
-
1586
-        // The edit tab has been configured, so we loop through to configured settings
1587
-        foreach ( $configured_fields as $configured_field ) {
1588
-
1589
-	        /** @var GF_Field $field */
1590
-	        foreach ( $fields as $field ) {
1591
-
1592
-                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1593
-                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1594
-                    break;
1595
-                }
1596
-
1597
-            }
1598
-
1599
-        }
1600
-
1601
-        return $edit_fields;
1602
-
1603
-    }
1604
-
1605
-    /**
1606
-     * Override GF Form field properties with the ones defined on the View
1607
-     * @param  GF_Field $field GF Form field object
1608
-     * @param  array $setting  GV field options
1609
-     * @since  1.5
1610
-     * @return array
1611
-     */
1612
-    private function merge_field_properties( $field, $field_setting ) {
1613
-
1614
-        $return_field = $field;
1615
-
1616
-        if( empty( $field_setting['show_label'] ) ) {
1617
-            $return_field->label = '';
1618
-        } elseif ( !empty( $field_setting['custom_label'] ) ) {
1619
-            $return_field->label = $field_setting['custom_label'];
1620
-        }
1621
-
1622
-        if( !empty( $field_setting['custom_class'] ) ) {
1623
-            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1624
-        }
1625
-
1626
-        /**
1627
-         * Normalize page numbers - avoid conflicts with page validation
1628
-         * @since 1.6
1629
-         */
1630
-        $return_field->pageNumber = 1;
1631
-
1632
-        return $return_field;
1633
-
1634
-    }
1635
-
1636
-    /**
1637
-     * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1638
-     *
1639
-     * @since 1.9.1
1640
-     *
1641
-     * @param array|GF_Field[] $fields Gravity Forms form fields
1642
-     * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1643
-     * @param array $form GF Form array
1644
-     * @param int $view_id View ID
1645
-     *
1646
-     * @return array Possibly modified form array
1647
-     */
1648
-    function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1649
-
1650
-	    /**
1651
-         * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1652
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1653
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1654
-	     * @since 1.9.1
1655
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1656
-	     * @param array $form GF Form array
1657
-	     * @param int $view_id View ID
1658
-	     */
1659
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1660
-
1661
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1662
-            foreach( $fields as $k => $field ) {
1663
-                if( $field->adminOnly ) {
1664
-                    unset( $fields[ $k ] );
1665
-                }
1666
-            }
1667
-            return $fields;
1668
-        }
1669
-
1670
-	    foreach( $fields as &$field ) {
1671
-		    $field->adminOnly = false;
1672
-        }
1673
-
1674
-        return $fields;
1675
-    }
1676
-
1677
-    // --- Conditional Logic
1678
-
1679
-    /**
1680
-     * Remove the conditional logic rules from the form button and the form fields, if needed.
1681
-     *
1682
-     * @since 1.9
1683
-     *
1684
-     * @param array $form Gravity Forms form
1685
-     * @return array Modified form, if not using Conditional Logic
1686
-     */
1687
-    function filter_conditional_logic( $form ) {
1688
-
1689
-        /**
1690
-         * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1691
-         * @since 1.9
1692
-         * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1693
-         * @param array $form Gravity Forms form
1694
-         */
1695
-        $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1696
-
1697
-        if( $use_conditional_logic ) {
1698
-            return $form;
1699
-        }
1700
-
1701
-        foreach( $form['fields'] as &$field ) {
1702
-            /* @var GF_Field $field */
1703
-            $field->conditionalLogic = null;
1704
-        }
1705
-
1706
-        unset( $form['button']['conditionalLogic'] );
1707
-
1708
-        return $form;
1709
-
1710
-    }
1711
-
1712
-    /**
1713
-     * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1714
-     *
1715
-     * @since 1.9
1716
-     *
1717
-     * @param $has_conditional_logic
1718
-     * @param $form
1719
-     * @return mixed|void
1720
-     */
1721
-    function manage_conditional_logic( $has_conditional_logic, $form ) {
1722
-
1723
-        if( ! $this->is_edit_entry() ) {
1724
-            return $has_conditional_logic;
1725
-        }
1726
-
1727
-        return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1728
-    }
1729
-
1730
-
1731
-    // --- User checks and nonces
1732
-
1733
-    /**
1734
-     * Check if the user can edit the entry
1735
-     *
1736
-     * - Is the nonce valid?
1737
-     * - Does the user have the right caps for the entry
1738
-     * - Is the entry in the trash?
1739
-     *
1740
-     * @todo Move to GVCommon
1741
-     *
1742
-     * @param  boolean $echo Show error messages in the form?
1743
-     * @return boolean        True: can edit form. False: nope.
1744
-     */
1745
-    function user_can_edit_entry( $echo = false ) {
1746
-
1747
-        $error = NULL;
1748
-
1749
-        /**
1750
-         *  1. Permalinks are turned off
1751
-         *  2. There are two entries embedded using oEmbed
1752
-         *  3. One of the entries has just been saved
1753
-         */
1754
-        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1755
-
1756
-            $error = true;
1757
-
1758
-        }
1759
-
1760
-        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1761
-
1762
-            $error = true;
1763
-
1764
-        } elseif( ! $this->verify_nonce() ) {
1765
-
1766
-            /**
1767
-             * If the Entry is embedded, there may be two entries on the same page.
1768
-             * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1769
-             */
1770
-            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1771
-                $error = true;
1772
-            } else {
1773
-                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1774
-            }
1521
+	/**
1522
+	 * Filter area fields based on specified conditions
1523
+	 *  - This filter removes the fields that have calculation configured
1524
+	 *
1525
+	 * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1526
+	 * @access private
1527
+	 * @param GF_Field[] $fields
1528
+	 * @param array $configured_fields
1529
+	 * @since  1.5
1530
+	 * @return array $fields
1531
+	 */
1532
+	private function filter_fields( $fields, $configured_fields ) {
1533
+
1534
+		if( empty( $fields ) || !is_array( $fields ) ) {
1535
+			return $fields;
1536
+		}
1537
+
1538
+		$edit_fields = array();
1539
+
1540
+		$field_type_blacklist = array(
1541
+			'page',
1542
+		);
1543
+
1544
+		/**
1545
+		 * @filter `gravityview/edit_entry/hide-product-fields` Hide product fields from being editable.
1546
+		 * @since 1.9.1
1547
+		 * @param boolean $hide_product_fields Whether to hide product fields in the editor.  Default: false
1548
+		 */
1549
+		$hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1550
+
1551
+		if( $hide_product_fields ) {
1552
+			$field_type_blacklist[] = 'option';
1553
+			$field_type_blacklist[] = 'quantity';
1554
+			$field_type_blacklist[] = 'product';
1555
+			$field_type_blacklist[] = 'total';
1556
+			$field_type_blacklist[] = 'shipping';
1557
+			$field_type_blacklist[] = 'calculation';
1558
+		}
1559
+
1560
+		// First, remove blacklist or calculation fields
1561
+		foreach ( $fields as $key => $field ) {
1562
+
1563
+			// Remove the fields that have calculation properties and keep them to be used later
1564
+			// @since 1.16.2
1565
+			if( $field->has_calculation() ) {
1566
+				$this->fields_with_calculation[] = $field;
1567
+				// don't remove the calculation fields on form render.
1568
+			}
1569
+
1570
+			// process total field after all fields have been saved
1571
+			if ( $field->type == 'total' ) {
1572
+				$this->total_fields[] = $field;
1573
+				unset( $fields[ $key ] );
1574
+			}
1575
+
1576
+			if( in_array( $field->type, $field_type_blacklist ) ) {
1577
+				unset( $fields[ $key ] );
1578
+			}
1579
+		}
1580
+
1581
+		// The Edit tab has not been configured, so we return all fields by default.
1582
+		if( empty( $configured_fields ) ) {
1583
+			return $fields;
1584
+		}
1585
+
1586
+		// The edit tab has been configured, so we loop through to configured settings
1587
+		foreach ( $configured_fields as $configured_field ) {
1588
+
1589
+			/** @var GF_Field $field */
1590
+			foreach ( $fields as $field ) {
1591
+
1592
+				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1593
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1594
+					break;
1595
+				}
1596
+
1597
+			}
1598
+
1599
+		}
1600
+
1601
+		return $edit_fields;
1602
+
1603
+	}
1604
+
1605
+	/**
1606
+	 * Override GF Form field properties with the ones defined on the View
1607
+	 * @param  GF_Field $field GF Form field object
1608
+	 * @param  array $setting  GV field options
1609
+	 * @since  1.5
1610
+	 * @return array
1611
+	 */
1612
+	private function merge_field_properties( $field, $field_setting ) {
1613
+
1614
+		$return_field = $field;
1615
+
1616
+		if( empty( $field_setting['show_label'] ) ) {
1617
+			$return_field->label = '';
1618
+		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1619
+			$return_field->label = $field_setting['custom_label'];
1620
+		}
1621
+
1622
+		if( !empty( $field_setting['custom_class'] ) ) {
1623
+			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1624
+		}
1625
+
1626
+		/**
1627
+		 * Normalize page numbers - avoid conflicts with page validation
1628
+		 * @since 1.6
1629
+		 */
1630
+		$return_field->pageNumber = 1;
1631
+
1632
+		return $return_field;
1633
+
1634
+	}
1635
+
1636
+	/**
1637
+	 * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1638
+	 *
1639
+	 * @since 1.9.1
1640
+	 *
1641
+	 * @param array|GF_Field[] $fields Gravity Forms form fields
1642
+	 * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1643
+	 * @param array $form GF Form array
1644
+	 * @param int $view_id View ID
1645
+	 *
1646
+	 * @return array Possibly modified form array
1647
+	 */
1648
+	function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1649
+
1650
+		/**
1651
+		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1652
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1653
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1654
+		 * @since 1.9.1
1655
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1656
+		 * @param array $form GF Form array
1657
+		 * @param int $view_id View ID
1658
+		 */
1659
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1660
+
1661
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1662
+			foreach( $fields as $k => $field ) {
1663
+				if( $field->adminOnly ) {
1664
+					unset( $fields[ $k ] );
1665
+				}
1666
+			}
1667
+			return $fields;
1668
+		}
1669
+
1670
+		foreach( $fields as &$field ) {
1671
+			$field->adminOnly = false;
1672
+		}
1673
+
1674
+		return $fields;
1675
+	}
1676
+
1677
+	// --- Conditional Logic
1678
+
1679
+	/**
1680
+	 * Remove the conditional logic rules from the form button and the form fields, if needed.
1681
+	 *
1682
+	 * @since 1.9
1683
+	 *
1684
+	 * @param array $form Gravity Forms form
1685
+	 * @return array Modified form, if not using Conditional Logic
1686
+	 */
1687
+	function filter_conditional_logic( $form ) {
1688
+
1689
+		/**
1690
+		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1691
+		 * @since 1.9
1692
+		 * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1693
+		 * @param array $form Gravity Forms form
1694
+		 */
1695
+		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1696
+
1697
+		if( $use_conditional_logic ) {
1698
+			return $form;
1699
+		}
1700
+
1701
+		foreach( $form['fields'] as &$field ) {
1702
+			/* @var GF_Field $field */
1703
+			$field->conditionalLogic = null;
1704
+		}
1705
+
1706
+		unset( $form['button']['conditionalLogic'] );
1707
+
1708
+		return $form;
1709
+
1710
+	}
1711
+
1712
+	/**
1713
+	 * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1714
+	 *
1715
+	 * @since 1.9
1716
+	 *
1717
+	 * @param $has_conditional_logic
1718
+	 * @param $form
1719
+	 * @return mixed|void
1720
+	 */
1721
+	function manage_conditional_logic( $has_conditional_logic, $form ) {
1722
+
1723
+		if( ! $this->is_edit_entry() ) {
1724
+			return $has_conditional_logic;
1725
+		}
1775 1726
 
1776
-        }
1777
-
1778
-        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1779
-            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
1780
-        }
1781
-
1782
-        if( $this->entry['status'] === 'trash' ) {
1783
-            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1784
-        }
1727
+		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1728
+	}
1785 1729
 
1786
-        // No errors; everything's fine here!
1787
-        if( empty( $error ) ) {
1788
-            return true;
1789
-        }
1790 1730
 
1791
-        if( $echo && $error !== true ) {
1731
+	// --- User checks and nonces
1792 1732
 
1793
-	        $error = esc_html( $error );
1733
+	/**
1734
+	 * Check if the user can edit the entry
1735
+	 *
1736
+	 * - Is the nonce valid?
1737
+	 * - Does the user have the right caps for the entry
1738
+	 * - Is the entry in the trash?
1739
+	 *
1740
+	 * @todo Move to GVCommon
1741
+	 *
1742
+	 * @param  boolean $echo Show error messages in the form?
1743
+	 * @return boolean        True: can edit form. False: nope.
1744
+	 */
1745
+	function user_can_edit_entry( $echo = false ) {
1794 1746
 
1795
-	        /**
1796
-	         * @since 1.9
1797
-	         */
1798
-	        if ( ! empty( $this->entry ) ) {
1799
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1800
-	        }
1747
+		$error = NULL;
1801 1748
 
1802
-            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1803
-        }
1749
+		/**
1750
+		 *  1. Permalinks are turned off
1751
+		 *  2. There are two entries embedded using oEmbed
1752
+		 *  3. One of the entries has just been saved
1753
+		 */
1754
+		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1804 1755
 
1805
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1756
+			$error = true;
1806 1757
 
1807
-        return false;
1808
-    }
1758
+		}
1809 1759
 
1760
+		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1810 1761
 
1811
-    /**
1812
-     * Check whether a field is editable by the current user, and optionally display an error message
1813
-     * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1814
-     * @param  array  $field Field or field settings array
1815
-     * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1816
-     * @return boolean         True: user can edit the current field; False: nope, they can't.
1817
-     */
1818
-    private function user_can_edit_field( $field, $echo = false ) {
1819
-
1820
-        $error = NULL;
1762
+			$error = true;
1821 1763
 
1822
-        if( ! $this->check_user_cap_edit_field( $field ) ) {
1823
-            $error = __( 'You do not have permission to edit this field.', 'gravityview');
1824
-        }
1764
+		} elseif( ! $this->verify_nonce() ) {
1825 1765
 
1826
-        // No errors; everything's fine here!
1827
-        if( empty( $error ) ) {
1828
-            return true;
1829
-        }
1766
+			/**
1767
+			 * If the Entry is embedded, there may be two entries on the same page.
1768
+			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1769
+			 */
1770
+			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1771
+				$error = true;
1772
+			} else {
1773
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1774
+			}
1830 1775
 
1831
-        if( $echo ) {
1832
-            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1833
-        }
1834
-
1835
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1776
+		}
1836 1777
 
1837
-        return false;
1778
+		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1779
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
1780
+		}
1838 1781
 
1839
-    }
1782
+		if( $this->entry['status'] === 'trash' ) {
1783
+			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1784
+		}
1840 1785
 
1786
+		// No errors; everything's fine here!
1787
+		if( empty( $error ) ) {
1788
+			return true;
1789
+		}
1841 1790
 
1842
-    /**
1843
-     * checks if user has permissions to edit a specific field
1844
-     *
1845
-     * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1846
-     *
1847
-     * @param  [type] $field [description]
1848
-     * @return bool
1849
-     */
1850
-    private function check_user_cap_edit_field( $field ) {
1791
+		if( $echo && $error !== true ) {
1851 1792
 
1852
-        // If they can edit any entries (as defined in Gravity Forms), we're good.
1853
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1854
-            return true;
1855
-        }
1793
+			$error = esc_html( $error );
1856 1794
 
1857
-        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1795
+			/**
1796
+			 * @since 1.9
1797
+			 */
1798
+			if ( ! empty( $this->entry ) ) {
1799
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1800
+			}
1858 1801
 
1859
-        // If the field has custom editing capaibilities set, check those
1860
-        if( $field_cap ) {
1861
-            return GVCommon::has_cap( $field['allow_edit_cap'] );
1862
-        }
1863
-
1864
-        return false;
1865
-    }
1802
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1803
+		}
1866 1804
 
1805
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1867 1806
 
1868
-    /**
1869
-     * Is the current nonce valid for editing the entry?
1870
-     * @return boolean
1871
-     */
1872
-    public function verify_nonce() {
1807
+		return false;
1808
+	}
1873 1809
 
1874
-        // Verify form submitted for editing single
1875
-        if( $this->is_edit_entry_submission() ) {
1876
-            $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1877
-        }
1878 1810
 
1879
-        // Verify
1880
-        else if( ! $this->is_edit_entry() ) {
1881
-            $valid = false;
1882
-        }
1811
+	/**
1812
+	 * Check whether a field is editable by the current user, and optionally display an error message
1813
+	 * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1814
+	 * @param  array  $field Field or field settings array
1815
+	 * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1816
+	 * @return boolean         True: user can edit the current field; False: nope, they can't.
1817
+	 */
1818
+	private function user_can_edit_field( $field, $echo = false ) {
1883 1819
 
1884
-        else {
1885
-            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1886
-        }
1820
+		$error = NULL;
1821
+
1822
+		if( ! $this->check_user_cap_edit_field( $field ) ) {
1823
+			$error = __( 'You do not have permission to edit this field.', 'gravityview');
1824
+		}
1887 1825
 
1888
-        /**
1889
-         * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1890
-         * @since 1.13
1891
-         * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1892
-         * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1893
-         */
1894
-        $valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1826
+		// No errors; everything's fine here!
1827
+		if( empty( $error ) ) {
1828
+			return true;
1829
+		}
1830
+
1831
+		if( $echo ) {
1832
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1833
+		}
1895 1834
 
1896
-        return $valid;
1897
-    }
1835
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1836
+
1837
+		return false;
1838
+
1839
+	}
1840
+
1841
+
1842
+	/**
1843
+	 * checks if user has permissions to edit a specific field
1844
+	 *
1845
+	 * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1846
+	 *
1847
+	 * @param  [type] $field [description]
1848
+	 * @return bool
1849
+	 */
1850
+	private function check_user_cap_edit_field( $field ) {
1851
+
1852
+		// If they can edit any entries (as defined in Gravity Forms), we're good.
1853
+		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1854
+			return true;
1855
+		}
1856
+
1857
+		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1858
+
1859
+		// If the field has custom editing capaibilities set, check those
1860
+		if( $field_cap ) {
1861
+			return GVCommon::has_cap( $field['allow_edit_cap'] );
1862
+		}
1863
+
1864
+		return false;
1865
+	}
1866
+
1867
+
1868
+	/**
1869
+	 * Is the current nonce valid for editing the entry?
1870
+	 * @return boolean
1871
+	 */
1872
+	public function verify_nonce() {
1873
+
1874
+		// Verify form submitted for editing single
1875
+		if( $this->is_edit_entry_submission() ) {
1876
+			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1877
+		}
1878
+
1879
+		// Verify
1880
+		else if( ! $this->is_edit_entry() ) {
1881
+			$valid = false;
1882
+		}
1883
+
1884
+		else {
1885
+			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1886
+		}
1887
+
1888
+		/**
1889
+		 * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1890
+		 * @since 1.13
1891
+		 * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1892
+		 * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1893
+		 */
1894
+		$valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1895
+
1896
+		return $valid;
1897
+	}
1898 1898
 
1899 1899
 
1900 1900
 
Please login to merge, or discard this patch.
Spacing   +226 added lines, -226 removed lines patch added patch discarded remove patch
@@ -112,16 +112,16 @@  discard block
 block discarded – undo
112 112
     function load() {
113 113
 
114 114
         /** @define "GRAVITYVIEW_DIR" "../../../" */
115
-        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
115
+        include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
116 116
 
117 117
         // Don't display an embedded form when editing an entry
118 118
         add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119 119
         add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120 120
 
121 121
         // Stop Gravity Forms processing what is ours!
122
-        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
122
+        add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
123 123
 
124
-        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
124
+        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
125 125
 
126 126
         add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127 127
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133 133
 
134 134
         // Add fields expected by GFFormDisplay::validate()
135
-        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
135
+        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
136 136
 
137 137
     }
138 138
 
@@ -147,8 +147,8 @@  discard block
 block discarded – undo
147 147
      * @return void
148 148
      */
149 149
     function prevent_render_form() {
150
-        if( $this->is_edit_entry() ) {
151
-            if( 'wp_head' === current_filter() ) {
150
+        if ( $this->is_edit_entry() ) {
151
+            if ( 'wp_head' === current_filter() ) {
152 152
                 add_filter( 'gform_shortcode_form', '__return_empty_string' );
153 153
             } else {
154 154
                 remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -163,10 +163,10 @@  discard block
 block discarded – undo
163 163
      */
164 164
     function prevent_maybe_process_form() {
165 165
 
166
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
166
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167 167
 
168
-        if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
-            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
168
+        if ( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
+            remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
170 170
         }
171 171
     }
172 172
 
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
      */
177 177
     public function is_edit_entry() {
178 178
 
179
-        $gf_page = function_exists('rgpost') && ( 'entry' === rgget( 'view' ) && isset( $_GET['edit'] ) || rgpost( 'action' ) === 'update' );
179
+        $gf_page = function_exists( 'rgpost' ) && ( 'entry' === rgget( 'view' ) && isset( $_GET[ 'edit' ] ) || rgpost( 'action' ) === 'update' );
180 180
 
181 181
         return $gf_page;
182 182
     }
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 	 * @return boolean
188 188
 	 */
189 189
 	public function is_edit_entry_submission() {
190
-		return !empty( $_POST[ self::$nonce_field ] );
190
+		return ! empty( $_POST[ self::$nonce_field ] );
191 191
 	}
192 192
 
193 193
     /**
@@ -198,13 +198,13 @@  discard block
 block discarded – undo
198 198
 
199 199
 
200 200
         $entries = $gravityview_view->getEntries();
201
-        $this->entry = $entries[0];
201
+        $this->entry = $entries[ 0 ];
202 202
 
203 203
         $this->original_form = $this->form = $gravityview_view->getForm();
204 204
         $this->form_id = $gravityview_view->getFormId();
205 205
         $this->view_id = $gravityview_view->getViewId();
206 206
 
207
-        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
207
+        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
208 208
     }
209 209
 
210 210
 
@@ -224,12 +224,12 @@  discard block
 block discarded – undo
224 224
         $this->setup_vars();
225 225
 
226 226
         // Multiple Views embedded, don't proceed if nonce fails
227
-        if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
227
+        if ( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key ) ) {
228 228
             return;
229 229
         }
230 230
 
231 231
         // Sorry, you're not allowed here.
232
-        if( false === $this->user_can_edit_entry( true ) ) {
232
+        if ( false === $this->user_can_edit_entry( true ) ) {
233 233
             return;
234 234
         }
235 235
 
@@ -249,9 +249,9 @@  discard block
 block discarded – undo
249 249
     function print_scripts() {
250 250
         $gravityview_view = GravityView_View::getInstance();
251 251
 
252
-        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
252
+        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
253 253
 
254
-        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
254
+        GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
255 255
 
256 256
         // Sack is required for images
257 257
         wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
@@ -263,32 +263,32 @@  discard block
 block discarded – undo
263 263
      */
264 264
     function process_save() {
265 265
 
266
-        if( empty( $_POST ) ) {
266
+        if ( empty( $_POST ) ) {
267 267
             return;
268 268
         }
269 269
 
270 270
         // Make sure the entry, view, and form IDs are all correct
271 271
         $valid = $this->verify_nonce();
272 272
 
273
-        if( !$valid ) {
274
-            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
273
+        if ( ! $valid ) {
274
+            do_action( 'gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275 275
             return;
276 276
         }
277 277
 
278
-        if( $this->entry['id'] !== $_POST['lid'] ) {
279
-            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
278
+        if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
279
+            do_action( 'gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280 280
             return;
281 281
         }
282 282
 
283
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
283
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
284 284
 
285 285
         $this->process_save_process_files( $this->form_id );
286 286
 
287 287
         $this->validate();
288 288
 
289
-        if( $this->is_valid ) {
289
+        if ( $this->is_valid ) {
290 290
 
291
-            do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
291
+            do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
292 292
 
293 293
             /**
294 294
              * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
@@ -298,12 +298,12 @@  discard block
 block discarded – undo
298 298
             /**
299 299
              * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300 300
              */
301
-            unset( $_GET['page'] );
301
+            unset( $_GET[ 'page' ] );
302 302
 
303 303
             GFFormsModel::save_lead( $form, $this->entry );
304 304
 
305 305
             // If there's a post associated with the entry, process post fields
306
-            if( !empty( $this->entry['post_id'] ) ) {
306
+            if ( ! empty( $this->entry[ 'post_id' ] ) ) {
307 307
                 $this->maybe_update_post_fields( $form );
308 308
             }
309 309
 
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
              * @param array $form Gravity Forms form array
319 319
              * @param string $entry_id Numeric ID of the entry that was updated
320 320
              */
321
-            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
321
+            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ] );
322 322
         }
323 323
 
324 324
     } // process_save
@@ -352,11 +352,11 @@  discard block
 block discarded – undo
352 352
      * @return mixed
353 353
      */
354 354
     public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
-        if( ! $this->is_edit_entry() ) {
355
+        if ( ! $this->is_edit_entry() ) {
356 356
             return $plupload_init;
357 357
         }
358 358
 
359
-        $plupload_init['gf_vars']['max_files'] = 0;
359
+        $plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
360 360
 
361 361
         return $plupload_init;
362 362
     }
@@ -370,19 +370,19 @@  discard block
 block discarded – undo
370 370
 
371 371
         $form = $this->form;
372 372
 
373
-        foreach( $form['fields'] as $k => &$field ) {
373
+        foreach ( $form[ 'fields' ] as $k => &$field ) {
374 374
 
375 375
             // Remove the fields with calculation formulas before save to avoid conflicts with GF logic
376 376
             // @since 1.16.3
377
-            if( $field->has_calculation() ) {
378
-                unset( $form['fields'][ $k ] );
377
+            if ( $field->has_calculation() ) {
378
+                unset( $form[ 'fields' ][ $k ] );
379 379
             }
380 380
 
381 381
             $field->adminOnly = false;
382 382
 
383
-            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
384
-                foreach( $field->inputs as $key => $input ) {
385
-                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
383
+            if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
384
+                foreach ( $field->inputs as $key => $input ) {
385
+                    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
386 386
                 }
387 387
             }
388 388
         }
@@ -396,20 +396,20 @@  discard block
 block discarded – undo
396 396
         $update = false;
397 397
 
398 398
         // get the most up to date entry values
399
-        $entry = GFAPI::get_entry( $this->entry['id'] );
399
+        $entry = GFAPI::get_entry( $this->entry[ 'id' ] );
400 400
 
401
-        if( !empty( $this->fields_with_calculation ) ) {
401
+        if ( ! empty( $this->fields_with_calculation ) ) {
402 402
             $update = true;
403 403
             foreach ( $this->fields_with_calculation as $calc_field ) {
404 404
                 $inputs = $calc_field->get_entry_inputs();
405 405
                 if ( is_array( $inputs ) ) {
406 406
                     foreach ( $inputs as $input ) {
407
-                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
408
-                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
407
+                        $input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
408
+                        $entry[ strval( $input[ 'id' ] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry[ 'id' ], $entry );
409 409
                     }
410 410
                 } else {
411
-                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
412
-                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
411
+                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id );
412
+                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry[ 'id' ], $entry );
413 413
                 }
414 414
             }
415 415
 
@@ -419,16 +419,16 @@  discard block
 block discarded – undo
419 419
         if ( ! empty( $this->total_fields ) ) {
420 420
             $update = true;
421 421
             foreach ( $this->total_fields as $total_field ) {
422
-                $input_name = 'input_' . str_replace( '.', '_', $total_field->id);
423
-                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
422
+                $input_name = 'input_' . str_replace( '.', '_', $total_field->id );
423
+                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry[ 'id' ], $entry );
424 424
             }
425 425
         }
426 426
 
427
-        if( $update ) {
427
+        if ( $update ) {
428 428
 
429 429
             $return_entry = GFAPI::update_entry( $entry );
430 430
 
431
-            if( is_wp_error( $return_entry ) ) {
431
+            if ( is_wp_error( $return_entry ) ) {
432 432
                 do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
433 433
             } else {
434 434
                 do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
@@ -460,11 +460,11 @@  discard block
 block discarded – undo
460 460
 
461 461
         $updated_categories = array();
462 462
 
463
-        if( $append ) {
463
+        if ( $append ) {
464 464
             $updated_categories = wp_get_post_categories( $updated_post->ID );
465 465
         }
466 466
 
467
-        if( $post_category_fields ) {
467
+        if ( $post_category_fields ) {
468 468
 
469 469
             foreach ( $post_category_fields as $field ) {
470 470
                 // Get the value of the field, including $_POSTed value
@@ -501,18 +501,18 @@  discard block
 block discarded – undo
501 501
 
502 502
         $input_name = 'input_' . $field_id;
503 503
 
504
-        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
504
+        if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
505 505
 
506 506
             // We have a new image
507 507
 
508
-            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
508
+            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
509 509
 
510 510
             $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
511 511
             $img_url = rgar( $ary, 0 );
512 512
 
513
-            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
514
-            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
515
-            $img_description = count( $ary ) > 3 ? $ary[3] : '';
513
+            $img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
514
+            $img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
515
+            $img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
516 516
 
517 517
             $image_meta = array(
518 518
                 'post_excerpt' => $img_caption,
@@ -521,7 +521,7 @@  discard block
 block discarded – undo
521 521
 
522 522
             //adding title only if it is not empty. It will default to the file name if it is not in the array
523 523
             if ( ! empty( $img_title ) ) {
524
-                $image_meta['post_title'] = $img_title;
524
+                $image_meta[ 'post_title' ] = $img_title;
525 525
             }
526 526
 
527 527
             /**
@@ -536,7 +536,7 @@  discard block
 block discarded – undo
536 536
                 set_post_thumbnail( $post_id, $media_id );
537 537
             }
538 538
 
539
-        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
539
+        } elseif ( ! empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
540 540
 
541 541
             // Same image although the image title, caption or description might have changed
542 542
 
@@ -544,11 +544,11 @@  discard block
 block discarded – undo
544 544
             $img_url = rgar( $ary, 0 );
545 545
 
546 546
             // is this really the same image or something went wrong ?
547
-            if( $img_url === $_POST[ $input_name ] ) {
547
+            if ( $img_url === $_POST[ $input_name ] ) {
548 548
 
549
-                $img_title       = rgar( $value, $field_id .'.1' );
550
-                $img_caption     = rgar( $value, $field_id .'.4' );
551
-                $img_description = rgar( $value, $field_id .'.7' );
549
+                $img_title       = rgar( $value, $field_id . '.1' );
550
+                $img_caption     = rgar( $value, $field_id . '.4' );
551
+                $img_description = rgar( $value, $field_id . '.7' );
552 552
 
553 553
                 $value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
554 554
 
@@ -588,11 +588,11 @@  discard block
 block discarded – undo
588 588
      */
589 589
     private function maybe_update_post_fields( $form ) {
590 590
 
591
-        $post_id = $this->entry['post_id'];
591
+        $post_id = $this->entry[ 'post_id' ];
592 592
 
593 593
         // Security check
594
-        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
595
-            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
594
+        if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
595
+            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #' . $post_id );
596 596
             return;
597 597
         }
598 598
 
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
         $updated_post = $original_post = get_post( $post_id );
602 602
 
603 603
         // get the most up to date entry values
604
-        $entry = GFAPI::get_entry( $this->entry['id'] );
604
+        $entry = GFAPI::get_entry( $this->entry[ 'id' ] );
605 605
 
606 606
         foreach ( $entry as $field_id => $value ) {
607 607
 
@@ -609,16 +609,16 @@  discard block
 block discarded – undo
609 609
 
610 610
             $field = RGFormsModel::get_field( $form, $field_id );
611 611
 
612
-            if( class_exists('GF_Fields') ) {
612
+            if ( class_exists( 'GF_Fields' ) ) {
613 613
                 $field = GF_Fields::create( $field );
614 614
             }
615 615
 
616
-            if( GFCommon::is_post_field( $field ) ) {
616
+            if ( GFCommon::is_post_field( $field ) ) {
617 617
 
618 618
                 // Get the value of the field, including $_POSTed value
619 619
                 $value = RGFormsModel::get_field_value( $field );
620 620
 
621
-                switch( $field->type ) {
621
+                switch ( $field->type ) {
622 622
 
623 623
                     case 'post_title':
624 624
                     case 'post_content':
@@ -636,12 +636,12 @@  discard block
 block discarded – undo
636 636
                         $custom_field_name = $field->postCustomFieldName;
637 637
 
638 638
                         // Only certain custom field types are supported
639
-                        switch( $input_type ) {
639
+                        switch ( $input_type ) {
640 640
                             case 'fileupload':
641 641
                             /** @noinspection PhpMissingBreakStatementInspection */
642 642
                             case 'list':
643
-                                if( ! is_string( $value ) ) {
644
-                                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
643
+                                if ( ! is_string( $value ) ) {
644
+                                    $value = function_exists( 'wp_json_encode' ) ? wp_json_encode( $value ) : json_encode( $value );
645 645
                                 }
646 646
                             // break; left intentionally out
647 647
                             default:
@@ -657,12 +657,12 @@  discard block
 block discarded – undo
657 657
                 }
658 658
 
659 659
                 //ignore fields that have not changed
660
-                if ( $value === rgget( (string) $field_id, $entry ) ) {
660
+                if ( $value === rgget( (string)$field_id, $entry ) ) {
661 661
                     continue;
662 662
                 }
663 663
 
664 664
                 // update entry
665
-                if( 'post_category' !== $field->type ) {
665
+                if ( 'post_category' !== $field->type ) {
666 666
                     $entry[ strval( $field_id ) ] = $value;
667 667
                 }
668 668
 
@@ -672,14 +672,14 @@  discard block
 block discarded – undo
672 672
 
673 673
         }
674 674
 
675
-        if( $update_entry ) {
675
+        if ( $update_entry ) {
676 676
 
677 677
             $return_entry = GFAPI::update_entry( $entry );
678 678
 
679
-            if( is_wp_error( $return_entry ) ) {
679
+            if ( is_wp_error( $return_entry ) ) {
680 680
                 do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
681 681
             } else {
682
-                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
682
+                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #' . $post_id . ' succeeded' );
683 683
             }
684 684
 
685 685
         }
@@ -688,11 +688,11 @@  discard block
 block discarded – undo
688 688
 
689 689
         $return_post = wp_update_post( $updated_post, true );
690 690
 
691
-        if( is_wp_error( $return_post ) ) {
691
+        if ( is_wp_error( $return_post ) ) {
692 692
             $return_post->add_data( $updated_post, '$updated_post' );
693 693
             do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
694 694
         } else {
695
-            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
695
+            do_action( 'gravityview_log_debug', 'Updating the post content for post #' . $post_id . ' succeeded', $updated_post );
696 696
         }
697 697
 
698 698
     }
@@ -709,18 +709,18 @@  discard block
 block discarded – undo
709 709
      */
710 710
     function after_update() {
711 711
 
712
-        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
713
-        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
712
+        do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ] );
713
+        do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ] );
714 714
 
715 715
         // Re-define the entry now that we've updated it.
716
-        $entry = RGFormsModel::get_lead( $this->entry['id'] );
716
+        $entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
717 717
 
718 718
         $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
719 719
 
720 720
         // We need to clear the cache because Gravity Forms caches the field values, which
721 721
         // we have just updated.
722
-        foreach ($this->form['fields'] as $key => $field) {
723
-            GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
722
+        foreach ( $this->form[ 'fields' ] as $key => $field ) {
723
+            GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
724 724
         }
725 725
 
726 726
         $this->entry = $entry;
@@ -738,7 +738,7 @@  discard block
 block discarded – undo
738 738
 
739 739
         <div class="gv-edit-entry-wrapper"><?php
740 740
 
741
-            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
741
+            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
742 742
 
743 743
             /**
744 744
              * Fixes weird wpautop() issue
@@ -754,7 +754,7 @@  discard block
 block discarded – undo
754 754
                      * @param string $edit_entry_title Modify the "Edit Entry" title
755 755
                      * @param GravityView_Edit_Entry_Render $this This object
756 756
                      */
757
-                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
757
+                    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
758 758
 
759 759
                     echo esc_attr( $edit_entry_title );
760 760
             ?></span>
@@ -794,20 +794,20 @@  discard block
 block discarded – undo
794 794
      */
795 795
     private function maybe_print_message() {
796 796
 
797
-        if( rgpost('action') === 'update' ) {
797
+        if ( rgpost( 'action' ) === 'update' ) {
798 798
 
799 799
             $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
800 800
 
801
-            if( ! $this->is_valid ){
801
+            if ( ! $this->is_valid ) {
802 802
 
803 803
                 // Keeping this compatible with Gravity Forms.
804
-                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
805
-                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
804
+                $validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
805
+                $message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
806 806
 
807
-                echo GVCommon::generate_notice( $message , 'gv-error' );
807
+                echo GVCommon::generate_notice( $message, 'gv-error' );
808 808
 
809 809
             } else {
810
-                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
810
+                $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . $back_link . '">', '</a>' );
811 811
 
812 812
                 /**
813 813
                  * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
@@ -817,7 +817,7 @@  discard block
 block discarded – undo
817 817
                  * @param array $entry Gravity Forms entry array
818 818
                  * @param string $back_link URL to return to the original entry. @since 1.6
819 819
                  */
820
-                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
820
+                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
821 821
 
822 822
                 echo GVCommon::generate_notice( $message );
823 823
             }
@@ -834,24 +834,24 @@  discard block
 block discarded – undo
834 834
      */
835 835
     private function render_edit_form() {
836 836
 
837
-        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
838
-        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
837
+        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
838
+        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
839 839
         add_filter( 'gform_disable_view_counter', '__return_true' );
840 840
 
841 841
         add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
842 842
         add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
843 843
 
844
-        add_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10, 3 );
844
+        add_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value' ), 10, 3 );
845 845
 
846 846
         // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
847
-        unset( $_GET['page'] );
847
+        unset( $_GET[ 'page' ] );
848 848
 
849 849
         // TODO: Verify multiple-page forms
850 850
         // TODO: Product fields are not editable
851 851
 
852
-        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
852
+        $html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
853 853
 
854
-        remove_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value'), 10 );
854
+        remove_filter( 'gform_field_value', array( $this, 'fix_survey_fields_value' ), 10 );
855 855
 	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
856 856
         remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
857 857
         remove_filter( 'gform_disable_view_counter', '__return_true' );
@@ -875,7 +875,7 @@  discard block
 block discarded – undo
875 875
      */
876 876
     function fix_survey_fields_value( $value, $field, $name ) {
877 877
         
878
-        if( 'survey' === $field->type ) {
878
+        if ( 'survey' === $field->type ) {
879 879
 
880 880
 	        // We need to run through each survey row until we find a match for expected values
881 881
 	        foreach ( $this->entry as $field_id => $field_value ) {
@@ -884,11 +884,11 @@  discard block
 block discarded – undo
884 884
 			        continue;
885 885
 		        }
886 886
 
887
-		        if( rgar( $field, 'gsurveyLikertEnableMultipleRows' ) ) {
887
+		        if ( rgar( $field, 'gsurveyLikertEnableMultipleRows' ) ) {
888 888
 			        list( $row_val, $col_val ) = explode( ':', $field_value, 2 );
889 889
 
890 890
 		            // If the $name matches the $row_val, we are processing the correct row
891
-			        if( $row_val === $name ) {
891
+			        if ( $row_val === $name ) {
892 892
 				        $value = $field_value;
893 893
 				        break;
894 894
 			        }
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
      * @return string
910 910
      */
911 911
     public function render_form_buttons() {
912
-        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
912
+        return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
913 913
     }
914 914
 
915 915
 
@@ -929,17 +929,17 @@  discard block
 block discarded – undo
929 929
     public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
930 930
 
931 931
         // In case we have validated the form, use it to inject the validation results into the form render
932
-        if( isset( $this->form_after_validation ) ) {
932
+        if ( isset( $this->form_after_validation ) ) {
933 933
             $form = $this->form_after_validation;
934 934
         } else {
935
-            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
935
+            $form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
936 936
         }
937 937
 
938 938
         $form = $this->filter_conditional_logic( $form );
939 939
 
940 940
         // for now we don't support Save and Continue feature.
941
-        if( ! self::$supports_save_and_continue ) {
942
-	        unset( $form['save'] );
941
+        if ( ! self::$supports_save_and_continue ) {
942
+	        unset( $form[ 'save' ] );
943 943
         }
944 944
 
945 945
         return $form;
@@ -960,29 +960,29 @@  discard block
 block discarded – undo
960 960
      */
961 961
     function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
962 962
 
963
-        if( GFCommon::is_post_field( $field ) ) {
963
+        if ( GFCommon::is_post_field( $field ) ) {
964 964
 
965 965
             $message = null;
966 966
 
967 967
             // First, make sure they have the capability to edit the post.
968
-            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
968
+            if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
969 969
 
970 970
                 /**
971 971
                  * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
972 972
                  * @param string $message The existing "You don't have permission..." text
973 973
                  */
974
-                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
974
+                $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
975 975
 
976
-            } elseif( null === get_post( $this->entry['post_id'] ) ) {
976
+            } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
977 977
                 /**
978 978
                  * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
979 979
                  * @param string $message The existing "This field is not editable; the post no longer exists." text
980 980
                  */
981
-                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
981
+                $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
982 982
             }
983 983
 
984
-            if( $message ) {
985
-                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
984
+            if ( $message ) {
985
+                $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
986 986
             }
987 987
         }
988 988
 
@@ -1007,8 +1007,8 @@  discard block
 block discarded – undo
1007 1007
 
1008 1008
         // If the form has been submitted, then we don't need to pre-fill the values,
1009 1009
         // Except for fileupload type and when a field input is overridden- run always!!
1010
-        if(
1011
-            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1010
+        if (
1011
+            ( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1012 1012
             && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1013 1013
             || ! empty( $field_content )
1014 1014
             || GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
@@ -1017,8 +1017,8 @@  discard block
 block discarded – undo
1017 1017
         }
1018 1018
 
1019 1019
         // Turn on Admin-style display for file upload fields only
1020
-        if( 'fileupload' === $field->type ) {
1021
-            $_GET['page'] = 'gf_entries';
1020
+        if ( 'fileupload' === $field->type ) {
1021
+            $_GET[ 'page' ] = 'gf_entries';
1022 1022
         }
1023 1023
 
1024 1024
         // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
@@ -1042,7 +1042,7 @@  discard block
 block discarded – undo
1042 1042
 	    // Prevent any PHP warnings, like undefined index
1043 1043
 	    ob_start();
1044 1044
 
1045
-        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1045
+        if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1046 1046
             /** @var GF_Field $gv_field */
1047 1047
             $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1048 1048
         } else {
@@ -1053,7 +1053,7 @@  discard block
 block discarded – undo
1053 1053
 	    // If there was output, it's an error
1054 1054
 	    $warnings = ob_get_clean();
1055 1055
 
1056
-	    if( !empty( $warnings ) ) {
1056
+	    if ( ! empty( $warnings ) ) {
1057 1057
 		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
1058 1058
 	    }
1059 1059
 
@@ -1062,7 +1062,7 @@  discard block
 block discarded – undo
1062 1062
          * We need the fileupload html field to render with the proper id
1063 1063
          *  ( <li id="field_80_16" ... > )
1064 1064
          */
1065
-        unset( $_GET['page'] );
1065
+        unset( $_GET[ 'page' ] );
1066 1066
 
1067 1067
         return $return;
1068 1068
     }
@@ -1085,7 +1085,7 @@  discard block
 block discarded – undo
1085 1085
         $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1086 1086
 
1087 1087
         // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1088
-        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1088
+        if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1089 1089
 
1090 1090
             $field_value = array();
1091 1091
 
@@ -1094,10 +1094,10 @@  discard block
 block discarded – undo
1094 1094
 
1095 1095
             foreach ( (array)$field->inputs as $input ) {
1096 1096
 
1097
-                $input_id = strval( $input['id'] );
1097
+                $input_id = strval( $input[ 'id' ] );
1098 1098
                 
1099 1099
                 if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1100
-                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1100
+                    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1101 1101
                     $allow_pre_populated = false;
1102 1102
                 }
1103 1103
 
@@ -1105,7 +1105,7 @@  discard block
 block discarded – undo
1105 1105
 
1106 1106
             $pre_value = $field->get_value_submission( array(), false );
1107 1107
 
1108
-            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1108
+            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1109 1109
 
1110 1110
         } else {
1111 1111
 
@@ -1116,13 +1116,13 @@  discard block
 block discarded – undo
1116 1116
 
1117 1117
             // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1118 1118
             // or pre-populated value if not empty and set to override saved value
1119
-            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1119
+            $field_value = ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1120 1120
 
1121 1121
             // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1122
-            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1122
+            if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1123 1123
                 $categories = array();
1124 1124
                 foreach ( explode( ',', $field_value ) as $cat_string ) {
1125
-                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1125
+                    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1126 1126
                 }
1127 1127
                 $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1128 1128
             }
@@ -1147,12 +1147,12 @@  discard block
 block discarded – undo
1147 1147
      */
1148 1148
     function gform_pre_validation( $form ) {
1149 1149
 
1150
-        if( ! $this->verify_nonce() ) {
1150
+        if ( ! $this->verify_nonce() ) {
1151 1151
             return $form;
1152 1152
         }
1153 1153
 
1154 1154
         // Fix PHP warning regarding undefined index.
1155
-        foreach ( $form['fields'] as &$field) {
1155
+        foreach ( $form[ 'fields' ] as &$field ) {
1156 1156
 
1157 1157
             // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1158 1158
             // expects certain field array items to be set.
@@ -1165,7 +1165,7 @@  discard block
 block discarded – undo
1165 1165
                 $field['emailConfirmEnabled'] = '';
1166 1166
             }*/
1167 1167
 
1168
-            switch( RGFormsModel::get_input_type( $field ) ) {
1168
+            switch ( RGFormsModel::get_input_type( $field ) ) {
1169 1169
 
1170 1170
                 /**
1171 1171
                  * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1179,37 +1179,37 @@  discard block
 block discarded – undo
1179 1179
                     // Set the previous value
1180 1180
                     $entry = $this->get_entry();
1181 1181
 
1182
-                    $input_name = 'input_'.$field->id;
1183
-                    $form_id = $form['id'];
1182
+                    $input_name = 'input_' . $field->id;
1183
+                    $form_id = $form[ 'id' ];
1184 1184
 
1185 1185
                     $value = NULL;
1186 1186
 
1187 1187
                     // Use the previous entry value as the default.
1188
-                    if( isset( $entry[ $field->id ] ) ) {
1188
+                    if ( isset( $entry[ $field->id ] ) ) {
1189 1189
                         $value = $entry[ $field->id ];
1190 1190
                     }
1191 1191
 
1192 1192
                     // If this is a single upload file
1193
-                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1194
-                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1195
-                        $value = $file_path['url'];
1193
+                    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1194
+                        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1195
+                        $value = $file_path[ 'url' ];
1196 1196
 
1197 1197
                     } else {
1198 1198
 
1199 1199
                         // Fix PHP warning on line 1498 of form_display.php for post_image fields
1200 1200
                         // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1201
-                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1201
+                        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1202 1202
 
1203 1203
                     }
1204 1204
 
1205
-                    if( rgar($field, "multipleFiles") ) {
1205
+                    if ( rgar( $field, "multipleFiles" ) ) {
1206 1206
 
1207 1207
                         // If there are fresh uploads, process and merge them.
1208 1208
                         // Otherwise, use the passed values, which should be json-encoded array of URLs
1209
-                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1209
+                        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1210 1210
                             $value = empty( $value ) ? '[]' : $value;
1211 1211
                             $value = stripslashes_deep( $value );
1212
-                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1212
+                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1213 1213
                         }
1214 1214
 
1215 1215
                     } else {
@@ -1227,14 +1227,14 @@  discard block
 block discarded – undo
1227 1227
 
1228 1228
                 case 'number':
1229 1229
                     // Fix "undefined index" issue at line 1286 in form_display.php
1230
-                    if( !isset( $_POST['input_'.$field->id ] ) ) {
1231
-                        $_POST['input_'.$field->id ] = NULL;
1230
+                    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1231
+                        $_POST[ 'input_' . $field->id ] = NULL;
1232 1232
                     }
1233 1233
                     break;
1234 1234
                 case 'captcha':
1235 1235
                     // Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1236
-                    $_POST['recaptcha_challenge_field'] = NULL;
1237
-                    $_POST['recaptcha_response_field'] = NULL;
1236
+                    $_POST[ 'recaptcha_challenge_field' ] = NULL;
1237
+                    $_POST[ 'recaptcha_response_field' ] = NULL;
1238 1238
                     break;
1239 1239
             }
1240 1240
 
@@ -1270,7 +1270,7 @@  discard block
 block discarded – undo
1270 1270
          * You can enter whatever you want!
1271 1271
          * We try validating, and customize the results using `self::custom_validation()`
1272 1272
          */
1273
-        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1273
+        add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1274 1274
 
1275 1275
         // Needed by the validate funtion
1276 1276
         $failed_validation_page = NULL;
@@ -1278,14 +1278,14 @@  discard block
 block discarded – undo
1278 1278
 
1279 1279
         // Prevent entry limit from running when editing an entry, also
1280 1280
         // prevent form scheduling from preventing editing
1281
-        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1281
+        unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1282 1282
 
1283 1283
         // Hide fields depending on Edit Entry settings
1284
-        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1284
+        $this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1285 1285
 
1286 1286
         $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1287 1287
 
1288
-        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1288
+        remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1289 1289
     }
1290 1290
 
1291 1291
 
@@ -1302,13 +1302,13 @@  discard block
 block discarded – undo
1302 1302
      */
1303 1303
     function custom_validation( $validation_results ) {
1304 1304
 
1305
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1305
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1306 1306
 
1307
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1307
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1308 1308
 
1309 1309
         $gv_valid = true;
1310 1310
 
1311
-        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1311
+        foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1312 1312
 
1313 1313
             $value = RGFormsModel::get_field_value( $field );
1314 1314
             $field_type = RGFormsModel::get_input_type( $field );
@@ -1321,35 +1321,35 @@  discard block
 block discarded – undo
1321 1321
                 case 'post_image':
1322 1322
 
1323 1323
                     // in case nothing is uploaded but there are already files saved
1324
-                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1324
+                    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1325 1325
                         $field->failed_validation = false;
1326 1326
                         unset( $field->validation_message );
1327 1327
                     }
1328 1328
 
1329 1329
                     // validate if multi file upload reached max number of files [maxFiles] => 2
1330
-                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1330
+                    if ( rgobj( $field, 'maxFiles' ) && rgobj( $field, 'multipleFiles' ) ) {
1331 1331
 
1332 1332
                         $input_name = 'input_' . $field->id;
1333 1333
                         //uploaded
1334
-                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1334
+                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1335 1335
 
1336 1336
                         //existent
1337 1337
                         $entry = $this->get_entry();
1338 1338
                         $value = NULL;
1339
-                        if( isset( $entry[ $field->id ] ) ) {
1339
+                        if ( isset( $entry[ $field->id ] ) ) {
1340 1340
                             $value = json_decode( $entry[ $field->id ], true );
1341 1341
                         }
1342 1342
 
1343 1343
                         // count uploaded files and existent entry files
1344 1344
                         $count_files = count( $file_names ) + count( $value );
1345 1345
 
1346
-                        if( $count_files > $field->maxFiles ) {
1346
+                        if ( $count_files > $field->maxFiles ) {
1347 1347
                             $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1348 1348
                             $field->failed_validation = 1;
1349 1349
                             $gv_valid = false;
1350 1350
 
1351 1351
                             // in case of error make sure the newest upload files are removed from the upload input
1352
-                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1352
+                            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1353 1353
                         }
1354 1354
 
1355 1355
                     }
@@ -1360,7 +1360,7 @@  discard block
 block discarded – undo
1360 1360
             }
1361 1361
 
1362 1362
             // This field has failed validation.
1363
-            if( !empty( $field->failed_validation ) ) {
1363
+            if ( ! empty( $field->failed_validation ) ) {
1364 1364
 
1365 1365
                 do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1366 1366
 
@@ -1378,32 +1378,32 @@  discard block
 block discarded – undo
1378 1378
                 }
1379 1379
 
1380 1380
                 // You can't continue inside a switch, so we do it after.
1381
-                if( empty( $field->failed_validation ) ) {
1381
+                if ( empty( $field->failed_validation ) ) {
1382 1382
                     continue;
1383 1383
                 }
1384 1384
 
1385 1385
                 // checks if the No Duplicates option is not validating entry against itself, since
1386 1386
                 // we're editing a stored entry, it would also assume it's a duplicate.
1387
-                if( !empty( $field->noDuplicates ) ) {
1387
+                if ( ! empty( $field->noDuplicates ) ) {
1388 1388
 
1389 1389
                     $entry = $this->get_entry();
1390 1390
 
1391 1391
                     // If the value of the entry is the same as the stored value
1392 1392
                     // Then we can assume it's not a duplicate, it's the same.
1393
-                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1393
+                    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1394 1394
                         //if value submitted was not changed, then don't validate
1395 1395
                         $field->failed_validation = false;
1396 1396
 
1397 1397
                         unset( $field->validation_message );
1398 1398
 
1399
-                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1399
+                        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1400 1400
 
1401 1401
                         continue;
1402 1402
                     }
1403 1403
                 }
1404 1404
 
1405 1405
                 // if here then probably we are facing the validation 'At least one field must be filled out'
1406
-                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1406
+                if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1407 1407
                     unset( $field->validation_message );
1408 1408
 	                $field->validation_message = false;
1409 1409
                     continue;
@@ -1415,12 +1415,12 @@  discard block
 block discarded – undo
1415 1415
 
1416 1416
         }
1417 1417
 
1418
-        $validation_results['is_valid'] = $gv_valid;
1418
+        $validation_results[ 'is_valid' ] = $gv_valid;
1419 1419
 
1420
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1420
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1421 1421
 
1422 1422
         // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1423
-        $this->form_after_validation = $validation_results['form'];
1423
+        $this->form_after_validation = $validation_results[ 'form' ];
1424 1424
 
1425 1425
         return $validation_results;
1426 1426
     }
@@ -1433,7 +1433,7 @@  discard block
 block discarded – undo
1433 1433
      */
1434 1434
     private function get_entry() {
1435 1435
 
1436
-        if( empty( $this->entry ) ) {
1436
+        if ( empty( $this->entry ) ) {
1437 1437
             // Get the database value of the entry that's being edited
1438 1438
             $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1439 1439
         }
@@ -1460,7 +1460,7 @@  discard block
 block discarded – undo
1460 1460
         $properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1461 1461
 
1462 1462
         // If edit tab not yet configured, show all fields
1463
-        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1463
+        $edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1464 1464
 
1465 1465
 	    // Show hidden fields as text fields
1466 1466
 	    $form = $this->fix_hidden_fields( $form );
@@ -1469,7 +1469,7 @@  discard block
 block discarded – undo
1469 1469
         $form = $this->fix_survey_fields( $form );
1470 1470
 
1471 1471
         // Hide fields depending on admin settings
1472
-        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1472
+        $fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1473 1473
 
1474 1474
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1475 1475
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1489,7 +1489,7 @@  discard block
 block discarded – undo
1489 1489
     private function fix_survey_fields( $form ) {
1490 1490
 
1491 1491
         /** @var GF_Field $field */
1492
-        foreach( $form['fields'] as &$field ) {
1492
+        foreach ( $form[ 'fields' ] as &$field ) {
1493 1493
             $field->allowsPrepopulate = true;
1494 1494
         }
1495 1495
 
@@ -1506,11 +1506,11 @@  discard block
 block discarded – undo
1506 1506
 	private function fix_hidden_fields( $form ) {
1507 1507
 
1508 1508
 		/** @var GF_Field $field */
1509
-		foreach( $form['fields'] as $key => $field ) {
1510
-			if( 'hidden' === $field->type ) {
1509
+		foreach ( $form[ 'fields' ] as $key => $field ) {
1510
+			if ( 'hidden' === $field->type ) {
1511 1511
 				$text_field = new GF_Field_Text( $field );
1512 1512
 				$text_field->type = 'text';
1513
-				$form['fields'][ $key ] = $text_field;
1513
+				$form[ 'fields' ][ $key ] = $text_field;
1514 1514
 			}
1515 1515
 		}
1516 1516
 
@@ -1531,7 +1531,7 @@  discard block
 block discarded – undo
1531 1531
      */
1532 1532
     private function filter_fields( $fields, $configured_fields ) {
1533 1533
 
1534
-        if( empty( $fields ) || !is_array( $fields ) ) {
1534
+        if ( empty( $fields ) || ! is_array( $fields ) ) {
1535 1535
             return $fields;
1536 1536
         }
1537 1537
 
@@ -1548,13 +1548,13 @@  discard block
 block discarded – undo
1548 1548
 	     */
1549 1549
 	    $hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1550 1550
 
1551
-	    if( $hide_product_fields ) {
1552
-		    $field_type_blacklist[] = 'option';
1553
-		    $field_type_blacklist[] = 'quantity';
1554
-            $field_type_blacklist[] = 'product';
1555
-            $field_type_blacklist[] = 'total';
1556
-            $field_type_blacklist[] = 'shipping';
1557
-            $field_type_blacklist[] = 'calculation';
1551
+	    if ( $hide_product_fields ) {
1552
+		    $field_type_blacklist[ ] = 'option';
1553
+		    $field_type_blacklist[ ] = 'quantity';
1554
+            $field_type_blacklist[ ] = 'product';
1555
+            $field_type_blacklist[ ] = 'total';
1556
+            $field_type_blacklist[ ] = 'shipping';
1557
+            $field_type_blacklist[ ] = 'calculation';
1558 1558
 	    }
1559 1559
 
1560 1560
         // First, remove blacklist or calculation fields
@@ -1562,24 +1562,24 @@  discard block
 block discarded – undo
1562 1562
 
1563 1563
             // Remove the fields that have calculation properties and keep them to be used later
1564 1564
             // @since 1.16.2
1565
-            if( $field->has_calculation() ) {
1566
-                $this->fields_with_calculation[] = $field;
1565
+            if ( $field->has_calculation() ) {
1566
+                $this->fields_with_calculation[ ] = $field;
1567 1567
                 // don't remove the calculation fields on form render.
1568 1568
             }
1569 1569
 
1570 1570
             // process total field after all fields have been saved
1571 1571
             if ( $field->type == 'total' ) {
1572
-                $this->total_fields[] = $field;
1572
+                $this->total_fields[ ] = $field;
1573 1573
                 unset( $fields[ $key ] );
1574 1574
             }
1575 1575
 
1576
-            if( in_array( $field->type, $field_type_blacklist ) ) {
1576
+            if ( in_array( $field->type, $field_type_blacklist ) ) {
1577 1577
                 unset( $fields[ $key ] );
1578 1578
             }
1579 1579
         }
1580 1580
 
1581 1581
         // The Edit tab has not been configured, so we return all fields by default.
1582
-        if( empty( $configured_fields ) ) {
1582
+        if ( empty( $configured_fields ) ) {
1583 1583
             return $fields;
1584 1584
         }
1585 1585
 
@@ -1589,8 +1589,8 @@  discard block
 block discarded – undo
1589 1589
 	        /** @var GF_Field $field */
1590 1590
 	        foreach ( $fields as $field ) {
1591 1591
 
1592
-                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1593
-                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1592
+                if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1593
+                    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1594 1594
                     break;
1595 1595
                 }
1596 1596
 
@@ -1613,14 +1613,14 @@  discard block
 block discarded – undo
1613 1613
 
1614 1614
         $return_field = $field;
1615 1615
 
1616
-        if( empty( $field_setting['show_label'] ) ) {
1616
+        if ( empty( $field_setting[ 'show_label' ] ) ) {
1617 1617
             $return_field->label = '';
1618
-        } elseif ( !empty( $field_setting['custom_label'] ) ) {
1619
-            $return_field->label = $field_setting['custom_label'];
1618
+        } elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1619
+            $return_field->label = $field_setting[ 'custom_label' ];
1620 1620
         }
1621 1621
 
1622
-        if( !empty( $field_setting['custom_class'] ) ) {
1623
-            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1622
+        if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1623
+            $return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1624 1624
         }
1625 1625
 
1626 1626
         /**
@@ -1658,16 +1658,16 @@  discard block
 block discarded – undo
1658 1658
 	     */
1659 1659
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1660 1660
 
1661
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1662
-            foreach( $fields as $k => $field ) {
1663
-                if( $field->adminOnly ) {
1661
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1662
+            foreach ( $fields as $k => $field ) {
1663
+                if ( $field->adminOnly ) {
1664 1664
                     unset( $fields[ $k ] );
1665 1665
                 }
1666 1666
             }
1667 1667
             return $fields;
1668 1668
         }
1669 1669
 
1670
-	    foreach( $fields as &$field ) {
1670
+	    foreach ( $fields as &$field ) {
1671 1671
 		    $field->adminOnly = false;
1672 1672
         }
1673 1673
 
@@ -1694,16 +1694,16 @@  discard block
 block discarded – undo
1694 1694
          */
1695 1695
         $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1696 1696
 
1697
-        if( $use_conditional_logic ) {
1697
+        if ( $use_conditional_logic ) {
1698 1698
             return $form;
1699 1699
         }
1700 1700
 
1701
-        foreach( $form['fields'] as &$field ) {
1701
+        foreach ( $form[ 'fields' ] as &$field ) {
1702 1702
             /* @var GF_Field $field */
1703 1703
             $field->conditionalLogic = null;
1704 1704
         }
1705 1705
 
1706
-        unset( $form['button']['conditionalLogic'] );
1706
+        unset( $form[ 'button' ][ 'conditionalLogic' ] );
1707 1707
 
1708 1708
         return $form;
1709 1709
 
@@ -1720,7 +1720,7 @@  discard block
 block discarded – undo
1720 1720
      */
1721 1721
     function manage_conditional_logic( $has_conditional_logic, $form ) {
1722 1722
 
1723
-        if( ! $this->is_edit_entry() ) {
1723
+        if ( ! $this->is_edit_entry() ) {
1724 1724
             return $has_conditional_logic;
1725 1725
         }
1726 1726
 
@@ -1751,44 +1751,44 @@  discard block
 block discarded – undo
1751 1751
          *  2. There are two entries embedded using oEmbed
1752 1752
          *  3. One of the entries has just been saved
1753 1753
          */
1754
-        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1754
+        if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
1755 1755
 
1756 1756
             $error = true;
1757 1757
 
1758 1758
         }
1759 1759
 
1760
-        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1760
+        if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
1761 1761
 
1762 1762
             $error = true;
1763 1763
 
1764
-        } elseif( ! $this->verify_nonce() ) {
1764
+        } elseif ( ! $this->verify_nonce() ) {
1765 1765
 
1766 1766
             /**
1767 1767
              * If the Entry is embedded, there may be two entries on the same page.
1768 1768
              * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1769 1769
              */
1770
-            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1770
+            if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1771 1771
                 $error = true;
1772 1772
             } else {
1773
-                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1773
+                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
1774 1774
             }
1775 1775
 
1776 1776
         }
1777 1777
 
1778
-        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1779
-            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
1778
+        if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1779
+            $error = __( 'You do not have permission to edit this entry.', 'gravityview' );
1780 1780
         }
1781 1781
 
1782
-        if( $this->entry['status'] === 'trash' ) {
1783
-            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1782
+        if ( $this->entry[ 'status' ] === 'trash' ) {
1783
+            $error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
1784 1784
         }
1785 1785
 
1786 1786
         // No errors; everything's fine here!
1787
-        if( empty( $error ) ) {
1787
+        if ( empty( $error ) ) {
1788 1788
             return true;
1789 1789
         }
1790 1790
 
1791
-        if( $echo && $error !== true ) {
1791
+        if ( $echo && $error !== true ) {
1792 1792
 
1793 1793
 	        $error = esc_html( $error );
1794 1794
 
@@ -1796,13 +1796,13 @@  discard block
 block discarded – undo
1796 1796
 	         * @since 1.9
1797 1797
 	         */
1798 1798
 	        if ( ! empty( $this->entry ) ) {
1799
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1799
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1800 1800
 	        }
1801 1801
 
1802
-            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1802
+            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
1803 1803
         }
1804 1804
 
1805
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1805
+        do_action( 'gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1806 1806
 
1807 1807
         return false;
1808 1808
     }
@@ -1819,20 +1819,20 @@  discard block
 block discarded – undo
1819 1819
 
1820 1820
         $error = NULL;
1821 1821
 
1822
-        if( ! $this->check_user_cap_edit_field( $field ) ) {
1823
-            $error = __( 'You do not have permission to edit this field.', 'gravityview');
1822
+        if ( ! $this->check_user_cap_edit_field( $field ) ) {
1823
+            $error = __( 'You do not have permission to edit this field.', 'gravityview' );
1824 1824
         }
1825 1825
 
1826 1826
         // No errors; everything's fine here!
1827
-        if( empty( $error ) ) {
1827
+        if ( empty( $error ) ) {
1828 1828
             return true;
1829 1829
         }
1830 1830
 
1831
-        if( $echo ) {
1832
-            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1831
+        if ( $echo ) {
1832
+            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
1833 1833
         }
1834 1834
 
1835
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1835
+        do_action( 'gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1836 1836
 
1837 1837
         return false;
1838 1838
 
@@ -1850,15 +1850,15 @@  discard block
 block discarded – undo
1850 1850
     private function check_user_cap_edit_field( $field ) {
1851 1851
 
1852 1852
         // If they can edit any entries (as defined in Gravity Forms), we're good.
1853
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1853
+        if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1854 1854
             return true;
1855 1855
         }
1856 1856
 
1857
-        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1857
+        $field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
1858 1858
 
1859 1859
         // If the field has custom editing capaibilities set, check those
1860
-        if( $field_cap ) {
1861
-            return GVCommon::has_cap( $field['allow_edit_cap'] );
1860
+        if ( $field_cap ) {
1861
+            return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
1862 1862
         }
1863 1863
 
1864 1864
         return false;
@@ -1872,17 +1872,17 @@  discard block
 block discarded – undo
1872 1872
     public function verify_nonce() {
1873 1873
 
1874 1874
         // Verify form submitted for editing single
1875
-        if( $this->is_edit_entry_submission() ) {
1875
+        if ( $this->is_edit_entry_submission() ) {
1876 1876
             $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1877 1877
         }
1878 1878
 
1879 1879
         // Verify
1880
-        else if( ! $this->is_edit_entry() ) {
1880
+        else if ( ! $this->is_edit_entry() ) {
1881 1881
             $valid = false;
1882 1882
         }
1883 1883
 
1884 1884
         else {
1885
-            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1885
+            $valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
1886 1886
         }
1887 1887
 
1888 1888
         /**
Please login to merge, or discard this patch.
includes/class-gravityview-settings.php 1 patch
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if( ! class_exists('GFAddOn') ) {
3
+if ( ! class_exists( 'GFAddOn' ) ) {
4 4
 	return;
5 5
 }
6 6
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 */
76 76
 	public function __construct( $prevent_multiple_instances = '' ) {
77 77
 
78
-		if( $prevent_multiple_instances === 'get_instance' ) {
78
+		if ( $prevent_multiple_instances === 'get_instance' ) {
79 79
 			return parent::__construct();
80 80
 		}
81 81
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 */
88 88
 	public static function get_instance() {
89 89
 
90
-		if( empty( self::$instance ) ) {
90
+		if ( empty( self::$instance ) ) {
91 91
 			self::$instance = new self( 'get_instance' );
92 92
 		}
93 93
 
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
 		 * Prevent Gravity Forms from showing the uninstall tab on the settings page
111 111
 		 * @hack
112 112
 		 */
113
-		if( $caps === $this->_capabilities_uninstall ) {
113
+		if ( $caps === $this->_capabilities_uninstall ) {
114 114
 			return false;
115 115
 		}
116 116
 
117
-		if( empty( $caps ) ) {
117
+		if ( empty( $caps ) ) {
118 118
 			$caps = array( 'gravityview_full_access' );
119 119
 		}
120 120
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 		add_filter( 'gform_addon_app_settings_menu_gravityview', array( $this, 'modify_app_settings_menu_title' ) );
138 138
 
139 139
 		/** @since 1.7.6 */
140
-		add_action('network_admin_menu', array( $this, 'add_network_menu' ) );
140
+		add_action( 'network_admin_menu', array( $this, 'add_network_menu' ) );
141 141
 
142 142
 		parent::init_admin();
143 143
 	}
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 	 */
152 152
 	public function modify_app_settings_menu_title( $setting_tabs ) {
153 153
 
154
-		$setting_tabs[0]['label'] = __( 'GravityView Settings', 'gravityview');
154
+		$setting_tabs[ 0 ][ 'label' ] = __( 'GravityView Settings', 'gravityview' );
155 155
 
156 156
 		return $setting_tabs;
157 157
 	}
@@ -168,11 +168,11 @@  discard block
 block discarded – undo
168 168
 	 */
169 169
 	private function _load_license_handler() {
170 170
 
171
-		if( !empty( $this->License_Handler ) ) {
171
+		if ( ! empty( $this->License_Handler ) ) {
172 172
 			return;
173 173
 		}
174 174
 
175
-		require_once( GRAVITYVIEW_DIR . 'includes/class-gv-license-handler.php');
175
+		require_once( GRAVITYVIEW_DIR . 'includes/class-gv-license-handler.php' );
176 176
 
177 177
 		$this->License_Handler = GV_License_Handler::get_instance( $this );
178 178
 	}
@@ -184,39 +184,39 @@  discard block
 block discarded – undo
184 184
 	function license_key_notice() {
185 185
 
186 186
 		// Only show on GravityView pages
187
-		if( ! gravityview_is_admin_page() ) {
187
+		if ( ! gravityview_is_admin_page() ) {
188 188
 			return;
189 189
 		}
190 190
 
191
-		$license_status = self::getSetting('license_key_status');
192
-		$license_id = self::getSetting('license_key');
191
+		$license_status = self::getSetting( 'license_key_status' );
192
+		$license_id = self::getSetting( 'license_key' );
193 193
 		$license_id = empty( $license_id ) ? 'license' : $license_id;
194 194
 
195
-		$message = esc_html__('Your GravityView license %s. This means you&rsquo;re missing out on updates and support! %sActivate your license%s or %sget a license here%s.', 'gravityview');
195
+		$message = esc_html__( 'Your GravityView license %s. This means you&rsquo;re missing out on updates and support! %sActivate your license%s or %sget a license here%s.', 'gravityview' );
196 196
 
197 197
 		/**
198 198
 		 * I wanted to remove the period from after the buttons in the string,
199 199
 		 * but didn't want to mess up the translation strings for the translators.
200 200
 		 */
201 201
 		$message = mb_substr( $message, 0, mb_strlen( $message ) - 1 );
202
-		$title = __('Inactive License', 'gravityview');
202
+		$title = __( 'Inactive License', 'gravityview' );
203 203
 		$status = '';
204 204
 		$update_below = false;
205 205
 		$primary_button_link = admin_url( 'edit.php?post_type=gravityview&amp;page=gravityview_settings' );
206 206
 		switch ( $license_status ) {
207 207
 			/** @since 1.17 */
208 208
 			case 'expired':
209
-				$title = __('Expired License', 'gravityview');
209
+				$title = __( 'Expired License', 'gravityview' );
210 210
 				$status = 'expired';
211
-				$message = $this->get_license_handler()->strings( 'expired', self::getSetting('license_key_response') );
211
+				$message = $this->get_license_handler()->strings( 'expired', self::getSetting( 'license_key_response' ) );
212 212
 				break;
213 213
 			case 'invalid':
214
-				$title = __('Invalid License', 'gravityview');
215
-				$status = __('is invalid', 'gravityview');
214
+				$title = __( 'Invalid License', 'gravityview' );
215
+				$status = __( 'is invalid', 'gravityview' );
216 216
 				break;
217 217
 			case 'deactivated':
218
-				$status = __('is inactive', 'gravityview');
219
-				$update_below = __('Activate your license key below.', 'gravityview');
218
+				$status = __( 'is inactive', 'gravityview' );
219
+				$update_below = __( 'Activate your license key below.', 'gravityview' );
220 220
 				break;
221 221
 			/** @noinspection PhpMissingBreakStatementInspection */
222 222
 			case '':
@@ -224,27 +224,27 @@  discard block
 block discarded – undo
224 224
 				// break intentionally left blank
225 225
 			case 'inactive':
226 226
 			case 'site_inactive':
227
-				$status = __('has not been activated', 'gravityview');
228
-				$update_below = __('Activate your license key below.', 'gravityview');
227
+				$status = __( 'has not been activated', 'gravityview' );
228
+				$update_below = __( 'Activate your license key below.', 'gravityview' );
229 229
 				break;
230 230
 		}
231
-		$url = 'https://gravityview.co/pricing/?utm_source=admin_notice&utm_medium=admin&utm_content='.$license_status.'&utm_campaign=Admin%20Notice';
231
+		$url = 'https://gravityview.co/pricing/?utm_source=admin_notice&utm_medium=admin&utm_content=' . $license_status . '&utm_campaign=Admin%20Notice';
232 232
 
233 233
 		// Show a different notice on settings page for inactive licenses (hide the buttons)
234
-		if( $update_below && gravityview_is_admin_page( '', 'settings' ) ) {
234
+		if ( $update_below && gravityview_is_admin_page( '', 'settings' ) ) {
235 235
 			$message = sprintf( $message, $status, '<div class="hidden">', '', '', '</div><a href="#" onclick="jQuery(\'#license_key\').focus(); return false;">' . $update_below . '</a>' );
236 236
 		} else {
237 237
 			$message = sprintf( $message, $status, "\n\n" . '<a href="' . $primary_button_link . '" class="button button-primary">', '</a>', '<a href="' . esc_url( $url ) . '" class="button button-secondary">', '</a>' );
238 238
 		}
239 239
 
240
-		if( !empty( $status ) ) {
240
+		if ( ! empty( $status ) ) {
241 241
 			GravityView_Admin_Notices::add_notice( array(
242 242
 				'message' => $message,
243 243
 				'class'	=> 'updated',
244 244
 				'title' => $title,
245 245
 				'cap' => 'gravityview_edit_settings',
246
-				'dismiss' => sha1( $license_status.'_'.$license_id ),
247
-			));
246
+				'dismiss' => sha1( $license_status . '_' . $license_id ),
247
+			) );
248 248
 		}
249 249
 	}
250 250
 
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 
257 257
 		$styles = parent::styles();
258 258
 
259
-		$styles[] = array(
259
+		$styles[ ] = array(
260 260
 			'handle'  => 'gravityview_settings',
261 261
 			'src'     => plugins_url( 'assets/css/admin-settings.css', GRAVITYVIEW_FILE ),
262 262
 			'version' => GravityView_Plugin::version,
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 	 * @return void
280 280
 	 */
281 281
 	public function add_network_menu() {
282
-		if( GravityView_Plugin::is_network_activated() ) {
282
+		if ( GravityView_Plugin::is_network_activated() ) {
283 283
 			add_menu_page( __( 'Settings', 'gravityview' ), __( 'GravityView', 'gravityview' ), $this->_capabilities_app_settings, "{$this->_slug}_settings", array( $this, 'app_tab_page' ), 'none' );
284 284
 		}
285 285
 	}
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
 		 * If multisite and not network admin, we don't want the settings to show.
297 297
 		 * @since 1.7.6
298 298
 		 */
299
-		$show_submenu = !is_multisite() ||  is_main_site() || !GravityView_Plugin::is_network_activated() || ( is_network_admin() && GravityView_Plugin::is_network_activated() );
299
+		$show_submenu = ! is_multisite() || is_main_site() || ! GravityView_Plugin::is_network_activated() || ( is_network_admin() && GravityView_Plugin::is_network_activated() );
300 300
 
301 301
 		/**
302 302
 		 * Override whether to show the Settings menu on a per-blog basis.
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
 		 */
306 306
 		$show_submenu = apply_filters( 'gravityview/show-settings-menu', $show_submenu );
307 307
 
308
-		if( $show_submenu ) {
308
+		if ( $show_submenu ) {
309 309
 			add_submenu_page( 'edit.php?post_type=gravityview', __( 'Settings', 'gravityview' ), __( 'Settings', 'gravityview' ), $this->_capabilities_app_settings, $this->_slug . '_settings', array( $this, 'app_tab_page' ) );
310 310
 		}
311 311
 	}
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 		/**
337 337
 		 * Backward compatibility with Redux
338 338
 		 */
339
-		if( $setting_name === 'license' ) {
339
+		if ( $setting_name === 'license' ) {
340 340
 			return array(
341 341
 				'license' => parent::get_app_setting( 'license_key' ),
342 342
 				'status' => parent::get_app_setting( 'license_key_status' ),
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
 
401 401
 		$return = $text . $activation;
402 402
 
403
-		if( $echo ) {
403
+		if ( $echo ) {
404 404
 			echo $return;
405 405
 		}
406 406
 
@@ -427,15 +427,15 @@  discard block
 block discarded – undo
427 427
 	 */
428 428
 	public function settings_submit( $field, $echo = true ) {
429 429
 
430
-		$field['type']  = ( isset($field['type']) && in_array( $field['type'], array('submit','reset','button') ) ) ? $field['type'] : 'submit';
430
+		$field[ 'type' ] = ( isset( $field[ 'type' ] ) && in_array( $field[ 'type' ], array( 'submit', 'reset', 'button' ) ) ) ? $field[ 'type' ] : 'submit';
431 431
 
432 432
 		$attributes    = $this->get_field_attributes( $field );
433 433
 		$default_value = rgar( $field, 'value' ) ? rgar( $field, 'value' ) : rgar( $field, 'default_value' );
434
-		$value         = $this->get_setting( $field['name'], $default_value );
434
+		$value         = $this->get_setting( $field[ 'name' ], $default_value );
435 435
 
436 436
 
437
-		$attributes['class'] = isset( $attributes['class'] ) ? esc_attr( $attributes['class'] ) : 'button-primary gfbutton';
438
-		$name    = ( $field['name'] === 'gform-settings-save' ) ? $field['name'] : '_gaddon_setting_'.$field['name'];
437
+		$attributes[ 'class' ] = isset( $attributes[ 'class' ] ) ? esc_attr( $attributes[ 'class' ] ) : 'button-primary gfbutton';
438
+		$name = ( $field[ 'name' ] === 'gform-settings-save' ) ? $field[ 'name' ] : '_gaddon_setting_' . $field[ 'name' ];
439 439
 
440 440
 		if ( empty( $value ) ) {
441 441
 			$value = __( 'Update Settings', 'gravityview' );
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
 		$attributes = $this->get_field_attributes( $field );
445 445
 
446 446
 		$html = '<input
447
-                    type="' . $field['type'] . '"
447
+                    type="' . $field[ 'type' ] . '"
448 448
                     name="' . esc_attr( $name ) . '"
449 449
                     value="' . $value . '" ' .
450 450
 		        implode( ' ', $attributes ) .
@@ -466,16 +466,16 @@  discard block
 block discarded – undo
466 466
 	 * @return string
467 467
 	 */
468 468
 	public function settings_save( $field, $echo = true ) {
469
-		$field['type']  = 'submit';
470
-		$field['name']  = 'gform-settings-save';
471
-		$field['class'] = isset( $field['class'] ) ? $field['class'] : 'button-primary gfbutton';
469
+		$field[ 'type' ]  = 'submit';
470
+		$field[ 'name' ]  = 'gform-settings-save';
471
+		$field[ 'class' ] = isset( $field[ 'class' ] ) ? $field[ 'class' ] : 'button-primary gfbutton';
472 472
 
473 473
 		if ( ! rgar( $field, 'value' ) )
474
-			$field['value'] = __( 'Update Settings', 'gravityview' );
474
+			$field[ 'value' ] = __( 'Update Settings', 'gravityview' );
475 475
 
476 476
 		$output = $this->settings_submit( $field, false );
477 477
 
478
-		if( $echo ) {
478
+		if ( $echo ) {
479 479
 			echo $output;
480 480
 		}
481 481
 
@@ -492,8 +492,8 @@  discard block
 block discarded – undo
492 492
 		parent::single_setting_label( $field );
493 493
 
494 494
 		// Added by GravityView
495
-		if ( isset( $field['description'] ) ) {
496
-			echo '<span class="description">'. $field['description'] .'</span>';
495
+		if ( isset( $field[ 'description' ] ) ) {
496
+			echo '<span class="description">' . $field[ 'description' ] . '</span>';
497 497
 		}
498 498
 
499 499
 	}
@@ -555,11 +555,11 @@  discard block
 block discarded – undo
555 555
 
556 556
 		// If the posted key doesn't match the activated/deactivated key (set using the Activate License button, AJAX response),
557 557
 		// then we assume it's changed. If it's changed, unset the status and the previous response.
558
-		if( $local_key !== $response_key ) {
558
+		if ( $local_key !== $response_key ) {
559 559
 
560
-			unset( $posted_settings['license_key_response'] );
561
-			unset( $posted_settings['license_key_status'] );
562
-			GFCommon::add_error_message( __('The license key you entered has been saved, but not activated. Please activate the license.', 'gravityview' ) );
560
+			unset( $posted_settings[ 'license_key_response' ] );
561
+			unset( $posted_settings[ 'license_key_status' ] );
562
+			GFCommon::add_error_message( __( 'The license key you entered has been saved, but not activated. Please activate the license.', 'gravityview' ) );
563 563
 		}
564 564
 
565 565
 		return $posted_settings;
@@ -594,25 +594,25 @@  discard block
 block discarded – undo
594 594
 				'label'             => __( 'License Key', 'gravityview' ),
595 595
 				'description'          => __( 'Enter the license key that was sent to you on purchase. This enables plugin updates &amp; support.', 'gravityview' ),
596 596
 				'type'              => 'edd_license',
597
-				'data-pending-text' => __('Verifying license&hellip;', 'gravityview'),
598
-				'default_value'           => $default_settings['license_key'],
597
+				'data-pending-text' => __( 'Verifying license&hellip;', 'gravityview' ),
598
+				'default_value'           => $default_settings[ 'license_key' ],
599 599
 				'class'             => ( '' == $this->get_app_setting( 'license_key' ) ) ? 'activate code regular-text edd-license-key' : 'deactivate code regular-text edd-license-key',
600 600
 			),
601 601
 			array(
602 602
 				'name'       => 'license_key_response',
603
-				'default_value'  => $default_settings['license_key_response'],
603
+				'default_value'  => $default_settings[ 'license_key_response' ],
604 604
 				'type'     => 'hidden',
605 605
 			),
606 606
 			array(
607 607
 				'name'       => 'license_key_status',
608
-				'default_value'  => $default_settings['license_key_status'],
608
+				'default_value'  => $default_settings[ 'license_key_status' ],
609 609
 				'type'     => 'hidden',
610 610
 			),
611 611
 			array(
612 612
 				'name'       => 'support-email',
613 613
 				'type'     => 'text',
614 614
 				'validate' => 'email',
615
-				'default_value'  => $default_settings['support-email'],
615
+				'default_value'  => $default_settings[ 'support-email' ],
616 616
 				'label'    => __( 'Support Email', 'gravityview' ),
617 617
 				'description' => __( 'In order to provide responses to your support requests, please provide your email address.', 'gravityview' ),
618 618
 				'class'    => 'code regular-text',
@@ -624,44 +624,44 @@  discard block
 block discarded – undo
624 624
 				'name'         => 'support_port',
625 625
 				'type'       => 'radio',
626 626
 				'label'      => __( 'Show Support Port?', 'gravityview' ),
627
-				'default_value'    => $default_settings['support_port'],
627
+				'default_value'    => $default_settings[ 'support_port' ],
628 628
 				'horizontal' => 1,
629 629
 				'choices'    => array(
630 630
 					array(
631
-						'label' => _x('Show', 'Setting: Show or Hide', 'gravityview'),
631
+						'label' => _x( 'Show', 'Setting: Show or Hide', 'gravityview' ),
632 632
 						'value' => '1',
633 633
 					),
634 634
 					array(
635
-						'label' => _x('Hide', 'Setting: Show or Hide', 'gravityview'),
635
+						'label' => _x( 'Hide', 'Setting: Show or Hide', 'gravityview' ),
636 636
 						'value' => '0',
637 637
 					),
638 638
 				),
639
-				'tooltip' => '<p><img src="' . esc_url_raw( plugins_url('assets/images/screenshots/beacon.png', GRAVITYVIEW_FILE ) ) . '" alt="' . esc_attr__( 'The Support Port looks like this.', 'gravityview' ) . '" class="alignright" style="max-width:40px; margin:.5em;" />' . esc_html__('The Support Port provides quick access to how-to articles and tutorials. For administrators, it also makes it easy to contact support.', 'gravityview') . '</p>',
639
+				'tooltip' => '<p><img src="' . esc_url_raw( plugins_url( 'assets/images/screenshots/beacon.png', GRAVITYVIEW_FILE ) ) . '" alt="' . esc_attr__( 'The Support Port looks like this.', 'gravityview' ) . '" class="alignright" style="max-width:40px; margin:.5em;" />' . esc_html__( 'The Support Port provides quick access to how-to articles and tutorials. For administrators, it also makes it easy to contact support.', 'gravityview' ) . '</p>',
640 640
 				'description'   => __( 'Show the Support Port on GravityView pages?', 'gravityview' ),
641 641
 			),
642 642
 			array(
643 643
 				'name'         => 'no-conflict-mode',
644 644
 				'type'       => 'radio',
645 645
 				'label'      => __( 'No-Conflict Mode', 'gravityview' ),
646
-				'default_value'    => $default_settings['no-conflict-mode'],
646
+				'default_value'    => $default_settings[ 'no-conflict-mode' ],
647 647
 				'horizontal' => 1,
648 648
 				'choices'    => array(
649 649
 					array(
650
-						'label' => _x('On', 'Setting: On or off', 'gravityview'),
650
+						'label' => _x( 'On', 'Setting: On or off', 'gravityview' ),
651 651
 						'value' => '1',
652 652
 					),
653 653
 					array(
654
-						'label' => _x('Off', 'Setting: On or off', 'gravityview'),
654
+						'label' => _x( 'Off', 'Setting: On or off', 'gravityview' ),
655 655
 						'value' => '0',
656 656
 					),
657 657
 				),
658
-				'description'   => __( 'Set this to ON to prevent extraneous scripts and styles from being printed on GravityView admin pages, reducing conflicts with other plugins and themes.', 'gravityview' ) . ' ' . __('If your Edit View tabs are ugly, enable this setting.', 'gravityview'),
658
+				'description'   => __( 'Set this to ON to prevent extraneous scripts and styles from being printed on GravityView admin pages, reducing conflicts with other plugins and themes.', 'gravityview' ) . ' ' . __( 'If your Edit View tabs are ugly, enable this setting.', 'gravityview' ),
659 659
 			),
660 660
 			array(
661 661
 				'name'       => 'delete-on-uninstall',
662 662
 				'type'       => 'radio',
663 663
 				'label'      => __( 'Remove Data on Delete?', 'gravityview' ),
664
-				'default_value'    => $default_settings['delete-on-uninstall'],
664
+				'default_value'    => $default_settings[ 'delete-on-uninstall' ],
665 665
 				'horizontal' => 1,
666 666
 				'choices'    => array(
667 667
 					array(
@@ -687,20 +687,20 @@  discard block
 block discarded – undo
687 687
 		 * @since 1.7.4
688 688
 		 */
689 689
 		foreach ( $fields as &$field ) {
690
-			$field['name']          = isset( $field['name'] ) ? $field['name'] : rgget('id', $field );
691
-			$field['label']         = isset( $field['label'] ) ? $field['label'] : rgget('title', $field );
692
-			$field['default_value'] = isset( $field['default_value'] ) ? $field['default_value'] : rgget('default', $field );
693
-			$field['description']   = isset( $field['description'] ) ? $field['description'] : rgget('subtitle', $field );
690
+			$field[ 'name' ]          = isset( $field[ 'name' ] ) ? $field[ 'name' ] : rgget( 'id', $field );
691
+			$field[ 'label' ]         = isset( $field[ 'label' ] ) ? $field[ 'label' ] : rgget( 'title', $field );
692
+			$field[ 'default_value' ] = isset( $field[ 'default_value' ] ) ? $field[ 'default_value' ] : rgget( 'default', $field );
693
+			$field[ 'description' ]   = isset( $field[ 'description' ] ) ? $field[ 'description' ] : rgget( 'subtitle', $field );
694 694
 
695
-			if( $disabled_attribute ) {
696
-				$field['disabled']  = $disabled_attribute;
695
+			if ( $disabled_attribute ) {
696
+				$field[ 'disabled' ] = $disabled_attribute;
697 697
 			}
698 698
 		}
699 699
 
700 700
 
701 701
         $sections = array(
702 702
             array(
703
-                'description' =>      sprintf( '<span class="version-info description">%s</span>', sprintf( __('You are running GravityView version %s', 'gravityview'), GravityView_Plugin::version ) ),
703
+                'description' =>      sprintf( '<span class="version-info description">%s</span>', sprintf( __( 'You are running GravityView version %s', 'gravityview' ), GravityView_Plugin::version ) ),
704 704
                 'fields'      => $fields,
705 705
             )
706 706
         );
@@ -711,8 +711,8 @@  discard block
 block discarded – undo
711 711
             'type'     => 'save',
712 712
         );
713 713
 
714
-		if( $disabled_attribute ) {
715
-			$button['disabled'] = $disabled_attribute;
714
+		if ( $disabled_attribute ) {
715
+			$button[ 'disabled' ] = $disabled_attribute;
716 716
 		}
717 717
 
718 718
 
@@ -732,20 +732,20 @@  discard block
 block discarded – undo
732 732
 		// If there are extensions, add a section for them
733 733
 		if ( ! empty( $extension_sections ) ) {
734 734
 
735
-			if( $disabled_attribute ) {
735
+			if ( $disabled_attribute ) {
736 736
 				foreach ( $extension_sections as &$section ) {
737
-					foreach ( $section['fields'] as &$field ) {
738
-						$field['disabled'] = $disabled_attribute;
737
+					foreach ( $section[ 'fields' ] as &$field ) {
738
+						$field[ 'disabled' ] = $disabled_attribute;
739 739
 					}
740 740
 				}
741 741
 			}
742 742
 
743
-            $k = count( $extension_sections ) - 1 ;
744
-            $extension_sections[ $k ]['fields'][] = $button;
743
+            $k = count( $extension_sections ) - 1;
744
+            $extension_sections[ $k ][ 'fields' ][ ] = $button;
745 745
 			$sections = array_merge( $sections, $extension_sections );
746 746
 		} else {
747 747
             // add the 'update settings' button to the general section
748
-            $sections[0]['fields'][] = $button;
748
+            $sections[ 0 ][ 'fields' ][ ] = $button;
749 749
         }
750 750
 
751 751
 		return $sections;
Please login to merge, or discard this patch.
plugin-and-theme-hooks/class-gravityview-plugin-hooks-gravity-flow.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 */
55 55
 	function modify_entry_value_workflow_final_status( $output, $entry, $field_settings, $field ) {
56 56
 
57
-		if( ! empty( $output ) ) {
57
+		if ( ! empty( $output ) ) {
58 58
 			$output = gravity_flow()->translate_status_label( $output );
59 59
 		}
60 60
 
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
78 78
 	function modify_entry_value_workflow_step( $output, $entry, $field_settings, $field ) {
79 79
 
80 80
 		// If not set, the entry hasn't started a workflow
81
-		$has_workflow_step = isset( $entry['workflow_step'] );
81
+		$has_workflow_step = isset( $entry[ 'workflow_step' ] );
82 82
 
83
-		if( $has_workflow_step ) {
83
+		if ( $has_workflow_step ) {
84 84
 
85
-			$GFlow = new Gravity_Flow_API( $entry['form_id'] );
85
+			$GFlow = new Gravity_Flow_API( $entry[ 'form_id' ] );
86 86
 
87 87
 			if ( $current_step = $GFlow->get_current_step( $entry ) ) {
88 88
 				$output = esc_html( $current_step->get_name() );
Please login to merge, or discard this patch.
includes/class-gravityview-merge-tags.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 		$gv_modifiers = array(
54 54
 			'maxwords:(\d+)' => 'modifier_maxwords', /** @see modifier_maxwords */
55 55
 			'wpautop' => 'modifier_wpautop', /** @see modifier_wpautop */
56
-		    'timestamp' => 'modifier_timestamp', /** @see modifier_timestamp */
56
+			'timestamp' => 'modifier_timestamp', /** @see modifier_timestamp */
57 57
 		);
58 58
 		
59 59
 		$return = $value;
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
 		$atts = array(
255 255
 			'format' => self::get_format_from_modifiers( $exploded, false ),
256
-		    'human' => in_array( 'human', $exploded ), // {date_created:human}
256
+			'human' => in_array( 'human', $exploded ), // {date_created:human}
257 257
 			'diff' => in_array( 'diff', $exploded ), // {date_created:diff}
258 258
 			'raw' => in_array( 'raw', $exploded ), // {date_created:raw}
259 259
 			'timestamp' => in_array( 'timestamp', $exploded ), // {date_created:timestamp}
Please login to merge, or discard this patch.
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	public static function process_modifiers( $value, $merge_tag, $modifier, $field, $raw_value ) {
46 46
 
47 47
 		// No modifier was set or the raw value was empty
48
-		if( 'all_fields' === $merge_tag || '' === $modifier || ! is_string( $raw_value ) || '' === $raw_value ) {
48
+		if ( 'all_fields' === $merge_tag || '' === $modifier || ! is_string( $raw_value ) || '' === $raw_value ) {
49 49
 			return $value;
50 50
 		}
51 51
 
@@ -61,9 +61,9 @@  discard block
 block discarded – undo
61 61
 		foreach ( $gv_modifiers as $gv_modifier => $method ) {
62 62
 
63 63
 			// Only match the regex if it's the first modifer; this allows us to enforce our own modifier structure
64
-			preg_match( '/^' . $gv_modifier .'/ism', $modifier, $matches );
64
+			preg_match( '/^' . $gv_modifier . '/ism', $modifier, $matches );
65 65
 
66
-			if( ! empty( $matches ) ) {
66
+			if ( ! empty( $matches ) ) {
67 67
 				// The called method is passed the raw value and the full matches array
68 68
 				$return = self::$method( $raw_value, $matches );
69 69
 				break;
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 */
88 88
 	private static function modifier_timestamp( $raw_value, $matches ) {
89 89
 
90
-		if( empty( $matches[0] ) ) {
90
+		if ( empty( $matches[ 0 ] ) ) {
91 91
 			return $raw_value;
92 92
 		}
93 93
 
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 */
112 112
 	private static function modifier_wpautop( $raw_value, $matches ) {
113 113
 
114
-		if( empty( $matches[0] ) || ! function_exists( 'wpautop' ) ) {
114
+		if ( empty( $matches[ 0 ] ) || ! function_exists( 'wpautop' ) ) {
115 115
 			return $raw_value;
116 116
 		}
117 117
 
@@ -135,11 +135,11 @@  discard block
 block discarded – undo
135 135
 	 */
136 136
 	private static function modifier_maxwords( $raw_value, $matches ) {
137 137
 
138
-		if( ! is_string( $raw_value ) || empty( $matches[1] ) || ! function_exists( 'wp_trim_words' ) ) {
138
+		if ( ! is_string( $raw_value ) || empty( $matches[ 1 ] ) || ! function_exists( 'wp_trim_words' ) ) {
139 139
 			return $raw_value;
140 140
 		}
141 141
 
142
-		$max = intval( $matches[1] );
142
+		$max = intval( $matches[ 1 ] );
143 143
 
144 144
 		$more_placeholder = '[GVMORE]';
145 145
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	 * @param  bool       $esc_html     Pass return value through `esc_html()`
172 172
 	 * @return string                  Text with variables maybe replaced
173 173
 	 */
174
-	public static function replace_variables($text, $form = array(), $entry = array(), $url_encode = false, $esc_html = true ) {
174
+	public static function replace_variables( $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = true ) {
175 175
 
176 176
 		/**
177 177
 		 * @filter `gravityview_do_replace_variables` Turn off merge tag variable replacements.\n
@@ -195,9 +195,9 @@  discard block
 block discarded – undo
195 195
 		 * @internal Reported to GF Support on 12/3
196 196
 		 * @internal Fixed in Gravity Forms
197 197
 		 */
198
-		$form['title']  = isset( $form['title'] ) ? $form['title'] : '';
199
-		$form['id']     = isset( $form['id'] ) ? $form['id'] : '';
200
-		$form['fields'] = isset( $form['fields'] ) ? $form['fields'] : array();
198
+		$form[ 'title' ]  = isset( $form[ 'title' ] ) ? $form[ 'title' ] : '';
199
+		$form[ 'id' ]     = isset( $form[ 'id' ] ) ? $form[ 'id' ] : '';
200
+		$form[ 'fields' ] = isset( $form[ 'fields' ] ) ? $form[ 'fields' ] : array();
201 201
 
202 202
 		return GFCommon::replace_variables( $text, $form, $entry, $url_encode, $esc_html );
203 203
 	}
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 	 *
218 218
 	 * @return mixed
219 219
 	 */
220
-	public static function replace_gv_merge_tags(  $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
220
+	public static function replace_gv_merge_tags( $text, $form = array(), $entry = array(), $url_encode = false, $esc_html = false ) {
221 221
 
222 222
 		/**
223 223
 		 * This prevents the gform_replace_merge_tags filter from being called twice, as defined in:
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 		 * @see GFCommon::replace_variables_prepopulate()
226 226
 		 * @todo Remove eventually: Gravity Forms fixed this issue in 1.9.14
227 227
 		 */
228
-		if( false === $form ) {
228
+		if ( false === $form ) {
229 229
 			return $text;
230 230
 		}
231 231
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 			'diff' => in_array( 'diff', $exploded ), // {date_created:diff}
258 258
 			'raw' => in_array( 'raw', $exploded ), // {date_created:raw}
259 259
 			'timestamp' => in_array( 'timestamp', $exploded ), // {date_created:timestamp}
260
-			'time' => in_array( 'time', $exploded ),  // {date_created:time}
260
+			'time' => in_array( 'time', $exploded ), // {date_created:time}
261 261
 		);
262 262
 
263 263
 		$formatted_date = GVCommon::format_date( $date_created, $atts );
@@ -320,14 +320,14 @@  discard block
 block discarded – undo
320 320
 		preg_match_all( "/{get:(.*?)}/ism", $text, $matches, PREG_SET_ORDER );
321 321
 
322 322
 		// If there are no matches OR the Entry `created_by` isn't set or is 0 (no user)
323
-		if( empty( $matches ) ) {
323
+		if ( empty( $matches ) ) {
324 324
 			return $text;
325 325
 		}
326 326
 
327 327
 		foreach ( $matches as $match ) {
328 328
 
329
-			$full_tag = $match[0];
330
-			$property = $match[1];
329
+			$full_tag = $match[ 0 ];
330
+			$property = $match[ 1 ];
331 331
 
332 332
 			$value = stripslashes_deep( rgget( $property ) );
333 333
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 			 * @since 1.15
352 352
 			 * @param bool $esc_html Whether to esc_html() the value. Default: `true`
353 353
 			 */
354
-			$esc_html = apply_filters('gravityview/merge_tags/get/esc_html/' . $property, true );
354
+			$esc_html = apply_filters( 'gravityview/merge_tags/get/esc_html/' . $property, true );
355 355
 
356 356
 			$value = $esc_html ? esc_html( $value ) : $value;
357 357
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 			 * @param[in] array $form Gravity Forms form array
363 363
 			 * @param[in] array $entry Entry array
364 364
 			 */
365
-			$value = apply_filters('gravityview/merge_tags/get/value/' . $property, $value, $text, $form, $entry );
365
+			$value = apply_filters( 'gravityview/merge_tags/get/value/' . $property, $value, $text, $form, $entry );
366 366
 
367 367
 			$text = str_replace( $full_tag, $value, $text );
368 368
 		}
Please login to merge, or discard this patch.
includes/class-common.php 4 patches
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -185,7 +185,6 @@  discard block
 block discarded – undo
185 185
 	 * Returns the list of available forms
186 186
 	 *
187 187
 	 * @access public
188
-	 * @param mixed $form_id
189 188
 	 * @return array Empty array if GFAPI isn't available or no forms. Otherwise, associative array with id, title keys
190 189
 	 */
191 190
 	public static function get_forms() {
@@ -206,7 +205,7 @@  discard block
 block discarded – undo
206 205
 	 * Return array of fields' id and label, for a given Form ID
207 206
 	 *
208 207
 	 * @access public
209
-	 * @param string|array $form_id (default: '') or $form object
208
+	 * @param string|array $form (default: '') or $form object
210 209
 	 * @return array
211 210
 	 */
212 211
 	public static function get_form_fields( $form = '', $add_default_properties = false, $include_parent_field = true ) {
@@ -907,7 +906,7 @@  discard block
 block discarded – undo
907 906
 	 *
908 907
 	 * @param array $form Gravity Forms form array
909 908
 	 * @param string $field_id ID of the field. If an input, full input ID (like `1.3`)
910
-	 * @param string|array $field_value Raw value of the field.
909
+	 * @param string $field_value Raw value of the field.
911 910
 	 * @return string
912 911
 	 */
913 912
 	public static function get_field_label( $form = array(), $field_id = '', $field_value = '' ) {
@@ -1551,9 +1550,9 @@  discard block
 block discarded – undo
1551 1550
 	 * @param string $message            Message body (required)
1552 1551
 	 * @param string $from_name          Displayed name of the sender
1553 1552
 	 * @param string $message_format     If "html", sent text as `text/html`. Otherwise, `text/plain`. Default: "html".
1554
-	 * @param string|array $attachments  Optional. Files to attach. {@see wp_mail()} for usage. Default: "".
1553
+	 * @param string $attachments  Optional. Files to attach. {@see wp_mail()} for usage. Default: "".
1555 1554
 	 * @param array|false $entry         Gravity Forms entry array, related to the email. Default: false.
1556
-	 * @param array|false $notification  Gravity Forms notification that triggered the email. {@see GFCommon::send_notification}. Default:false.
1555
+	 * @param boolean $notification  Gravity Forms notification that triggered the email. {@see GFCommon::send_notification}. Default:false.
1557 1556
 	 */
1558 1557
 	public static function send_email( $from, $to, $bcc, $reply_to, $subject, $message, $from_name = '', $message_format = 'html', $attachments = '', $entry = false, $notification = false ) {
1559 1558
 
Please login to merge, or discard this patch.
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -236,13 +236,13 @@  discard block
 block discarded – undo
236 236
 
237 237
 				if ( $add_default_properties && ! empty( $field->inputs ) ) {
238 238
 					foreach ( $field->inputs as $input ) {
239
-                        /**
240
-                         * @hack
241
-                         * In case of email/email confirmation, the input for email has the same id as the parent field
242
-                         */
239
+						/**
240
+						 * @hack
241
+						 * In case of email/email confirmation, the input for email has the same id as the parent field
242
+						 */
243 243
 						if( 'email' === $field->type && false === strpos( $input['id'], '.' ) ) {
244
-                            continue;
245
-                        }
244
+							continue;
245
+						}
246 246
 						$fields["{$input['id']}"] = array(
247 247
 							'label' => rgar( $input, 'label' ),
248 248
 							'customLabel' => rgar( $input, 'customLabel' ),
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
 		} elseif ( 'delete' === RGForms::get( 'action' ) ) {
420 420
 			$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
421 421
 		} elseif( !isset( $criteria['context_view_id'] ) ) {
422
-            // Prevent overriding the Context View ID: Some widgets could set the context_view_id (e.g. Recent Entries widget)
422
+			// Prevent overriding the Context View ID: Some widgets could set the context_view_id (e.g. Recent Entries widget)
423 423
 			$criteria['context_view_id'] = null;
424 424
 		}
425 425
 
@@ -1148,7 +1148,7 @@  discard block
 block discarded – undo
1148 1148
 			),
1149 1149
 		);
1150 1150
 
1151
-        $fields = $date_created + $fields;
1151
+		$fields = $date_created + $fields;
1152 1152
 
1153 1153
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1154 1154
 
@@ -1160,13 +1160,13 @@  discard block
 block discarded – undo
1160 1160
 			}
1161 1161
 		}
1162 1162
 
1163
-        /**
1164
-         * @filter `gravityview/common/sortable_fields` Filter the sortable fields
1165
-         * @since 1.12
1166
-         * @param array $fields Sub-set of GF form fields that are sortable
1167
-         * @param int $formid The Gravity Forms form ID that the fields are from
1168
-         */
1169
-        $fields = apply_filters( 'gravityview/common/sortable_fields', $fields, $formid );
1163
+		/**
1164
+		 * @filter `gravityview/common/sortable_fields` Filter the sortable fields
1165
+		 * @since 1.12
1166
+		 * @param array $fields Sub-set of GF form fields that are sortable
1167
+		 * @param int $formid The Gravity Forms form ID that the fields are from
1168
+		 */
1169
+		$fields = apply_filters( 'gravityview/common/sortable_fields', $fields, $formid );
1170 1170
 
1171 1171
 		return $fields;
1172 1172
 	}
@@ -1449,17 +1449,17 @@  discard block
 block discarded – undo
1449 1449
 	}
1450 1450
 
1451 1451
 
1452
-    /**
1453
-     * Display updated/error notice
1454
-     *
1455
-     * @param string $notice text/HTML of notice
1456
-     * @param string $class CSS class for notice (`updated` or `error`)
1457
-     *
1458
-     * @return string
1459
-     */
1460
-    public static function generate_notice( $notice, $class = '' ) {
1461
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1462
-    }
1452
+	/**
1453
+	 * Display updated/error notice
1454
+	 *
1455
+	 * @param string $notice text/HTML of notice
1456
+	 * @param string $class CSS class for notice (`updated` or `error`)
1457
+	 *
1458
+	 * @return string
1459
+	 */
1460
+	public static function generate_notice( $notice, $class = '' ) {
1461
+		return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1462
+	}
1463 1463
 
1464 1464
 	/**
1465 1465
 	 * Inspired on \GFCommon::encode_shortcodes, reverse the encoding by replacing the ascii characters by the shortcode brackets
Please login to merge, or discard this patch.
Spacing   +96 added lines, -96 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
 		$entry = self::get_entry( $entry_slug, true );
126 126
 
127
-		$form = self::get_form( $entry['form_id'] );
127
+		$form = self::get_form( $entry[ 'form_id' ] );
128 128
 
129 129
 		return $form;
130 130
 	}
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 
176 176
 		$results = GFAPI::get_entries( 0, $search_criteria, null, $paging );
177 177
 
178
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
178
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
179 179
 
180 180
 		return $result;
181 181
 	}
@@ -193,9 +193,9 @@  discard block
 block discarded – undo
193 193
 		if ( class_exists( 'GFAPI' ) ) {
194 194
 			$gf_forms = GFAPI::get_forms();
195 195
 			foreach ( $gf_forms as $form ) {
196
-				$forms[] = array(
197
-					'id' => $form['id'],
198
-					'title' => $form['title'],
196
+				$forms[ ] = array(
197
+					'id' => $form[ 'id' ],
198
+					'title' => $form[ 'title' ],
199 199
 				);
200 200
 			}
201 201
 		}
@@ -222,10 +222,10 @@  discard block
 block discarded – undo
222 222
 		$has_post_fields = false;
223 223
 
224 224
 		if ( $form ) {
225
-			foreach ( $form['fields'] as $field ) {
225
+			foreach ( $form[ 'fields' ] as $field ) {
226 226
 
227
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
228
-					$fields["{$field->id}"] = array(
227
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
228
+					$fields[ "{$field->id}" ] = array(
229 229
 						'label' => rgar( $field, 'label' ),
230 230
 						'parent' => null,
231 231
 						'type' => rgar( $field, 'type' ),
@@ -240,10 +240,10 @@  discard block
 block discarded – undo
240 240
                          * @hack
241 241
                          * In case of email/email confirmation, the input for email has the same id as the parent field
242 242
                          */
243
-						if( 'email' === $field->type && false === strpos( $input['id'], '.' ) ) {
243
+						if ( 'email' === $field->type && false === strpos( $input[ 'id' ], '.' ) ) {
244 244
                             continue;
245 245
                         }
246
-						$fields["{$input['id']}"] = array(
246
+						$fields[ "{$input[ 'id' ]}" ] = array(
247 247
 							'label' => rgar( $input, 'label' ),
248 248
 							'customLabel' => rgar( $input, 'customLabel' ),
249 249
 							'parent' => $field,
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
 				}
256 256
 
257 257
 
258
-				if( GFCommon::is_product_field( $field->type ) ){
258
+				if ( GFCommon::is_product_field( $field->type ) ) {
259 259
 					$has_product_fields = true;
260 260
 				}
261 261
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 		 * @since 1.7
270 270
 		 */
271 271
 		if ( $has_post_fields ) {
272
-			$fields['post_id'] = array(
272
+			$fields[ 'post_id' ] = array(
273 273
 				'label' => __( 'Post ID', 'gravityview' ),
274 274
 				'type' => 'post_id',
275 275
 			);
@@ -280,10 +280,10 @@  discard block
 block discarded – undo
280 280
 			$payment_fields = GravityView_Fields::get_all( 'pricing' );
281 281
 
282 282
 			foreach ( $payment_fields as $payment_field ) {
283
-				if( isset( $fields["{$payment_field->name}"] ) ) {
283
+				if ( isset( $fields[ "{$payment_field->name}" ] ) ) {
284 284
 					continue;
285 285
 				}
286
-				$fields["{$payment_field->name}"] = array(
286
+				$fields[ "{$payment_field->name}" ] = array(
287 287
 					'label' => $payment_field->label,
288 288
 					'desc' => $payment_field->description,
289 289
 					'type' => $payment_field->name,
@@ -315,9 +315,9 @@  discard block
 block discarded – undo
315 315
 
316 316
 		$fields = array();
317 317
 
318
-		foreach ( $extra_fields as $key => $field ){
319
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
320
-				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
318
+		foreach ( $extra_fields as $key => $field ) {
319
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
320
+				$fields[ $key ] = array( 'label' => $field[ 'label' ], 'type' => 'entry_meta' );
321 321
 			}
322 322
 		}
323 323
 
@@ -357,32 +357,32 @@  discard block
 block discarded – undo
357 357
 			'search_criteria' => null,
358 358
 			'sorting' => null,
359 359
 			'paging' => null,
360
-			'cache' => (isset( $passed_criteria['cache'] ) ? $passed_criteria['cache'] : true),
360
+			'cache' => ( isset( $passed_criteria[ 'cache' ] ) ? $passed_criteria[ 'cache' ] : true ),
361 361
 		);
362 362
 
363 363
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
364 364
 
365
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) ) {
366
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
365
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
366
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
367 367
 
368 368
 				if ( ! is_array( $filter ) ) {
369 369
 					continue;
370 370
 				}
371 371
 
372 372
 				// By default, we want searches to be wildcard for each field.
373
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
373
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
374 374
 
375 375
 				/**
376 376
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
377 377
 				 * @param string $operator Existing search operator
378 378
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
379 379
 				 */
380
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
380
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
381 381
 			}
382 382
 
383 383
 			// don't send just the [mode] without any field filter.
384
-			if( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode' , $criteria['search_criteria']['field_filters'] ) ) {
385
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
384
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
385
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
386 386
 			}
387 387
 
388 388
 		}
@@ -393,21 +393,21 @@  discard block
 block discarded – undo
393 393
 		 * Prepare date formats to be in Gravity Forms DB format;
394 394
 		 * $passed_criteria may include date formats incompatible with Gravity Forms.
395 395
 		 */
396
-		foreach ( array('start_date', 'end_date' ) as $key ) {
396
+		foreach ( array( 'start_date', 'end_date' ) as $key ) {
397 397
 
398
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
398
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
399 399
 
400 400
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
401
-				$date = date_create( $criteria['search_criteria'][ $key ] );
401
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
402 402
 
403 403
 				if ( $date ) {
404 404
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
405
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
405
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
406 406
 				} else {
407 407
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
408
-					unset( $criteria['search_criteria'][ $key ] );
408
+					unset( $criteria[ 'search_criteria' ][ $key ] );
409 409
 
410
-					do_action( 'gravityview_log_error', '[filter_get_entries_criteria] '.$key.' Date format not valid:', $criteria['search_criteria'][ $key ] );
410
+					do_action( 'gravityview_log_error', '[filter_get_entries_criteria] ' . $key . ' Date format not valid:', $criteria[ 'search_criteria' ][ $key ] );
411 411
 				}
412 412
 			}
413 413
 		}
@@ -415,12 +415,12 @@  discard block
 block discarded – undo
415 415
 
416 416
 		// When multiple views are embedded, OR single entry, calculate the context view id and send it to the advanced filter
417 417
 		if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance()->has_multiple_views() || GravityView_frontend::getInstance()->getSingleEntry() ) {
418
-			$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
418
+			$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
419 419
 		} elseif ( 'delete' === RGForms::get( 'action' ) ) {
420
-			$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
421
-		} elseif( !isset( $criteria['context_view_id'] ) ) {
420
+			$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? intval( $_GET[ 'view_id' ] ) : null;
421
+		} elseif ( ! isset( $criteria[ 'context_view_id' ] ) ) {
422 422
             // Prevent overriding the Context View ID: Some widgets could set the context_view_id (e.g. Recent Entries widget)
423
-			$criteria['context_view_id'] = null;
423
+			$criteria[ 'context_view_id' ] = null;
424 424
 		}
425 425
 
426 426
 		/**
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
 		 * @param array $form_ids Forms to search
430 430
 		 * @param int $view_id ID of the view being used to search
431 431
 		 */
432
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
432
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
433 433
 
434 434
 		return (array)$criteria;
435 435
 
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 		/** Reduce # of database calls */
461 461
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
462 462
 
463
-		if ( ! empty( $criteria['cache'] ) ) {
463
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
464 464
 
465 465
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
466 466
 
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
 
469 469
 				// Still update the total count when using cached results
470 470
 				if ( ! is_null( $total ) ) {
471
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
471
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
472 472
 				}
473 473
 
474 474
 				$return = $entries;
@@ -488,9 +488,9 @@  discard block
 block discarded – undo
488 488
 			$entries = apply_filters( 'gravityview_before_get_entries', null, $criteria, $passed_criteria, $total );
489 489
 
490 490
 			// No entries returned from gravityview_before_get_entries
491
-			if( is_null( $entries ) ) {
491
+			if ( is_null( $entries ) ) {
492 492
 
493
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
493
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
494 494
 
495 495
 				if ( is_wp_error( $entries ) ) {
496 496
 					do_action( 'gravityview_log_error', $entries->get_error_message(), $entries );
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
499 499
 				}
500 500
 			}
501 501
 
502
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
502
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
503 503
 
504 504
 				// Cache results
505 505
 				$Cache->set( $entries, 'entries' );
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
 			 */
587 587
 			$check_entry_display = apply_filters( 'gravityview/common/get_entry/check_entry_display', $check_entry_display, $entry );
588 588
 
589
-			if( $check_entry_display ) {
589
+			if ( $check_entry_display ) {
590 590
 				// Is the entry allowed
591 591
 				$entry = self::check_entry_display( $entry );
592 592
 			}
@@ -619,12 +619,12 @@  discard block
 block discarded – undo
619 619
 
620 620
 		$value = false;
621 621
 
622
-		if( 'context' === $val1 ) {
622
+		if ( 'context' === $val1 ) {
623 623
 
624 624
 			$matching_contexts = array( $val2 );
625 625
 
626 626
 			// We allow for non-standard contexts.
627
-			switch( $val2 ) {
627
+			switch ( $val2 ) {
628 628
 				// Check for either single or edit
629 629
 				case 'singular':
630 630
 					$matching_contexts = array( 'single', 'edit' );
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 			return false;
685 685
 		}
686 686
 
687
-		if ( empty( $entry['form_id'] ) ) {
687
+		if ( empty( $entry[ 'form_id' ] ) ) {
688 688
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry is empty! Entry:', $entry );
689 689
 			return false;
690 690
 		}
@@ -692,26 +692,26 @@  discard block
 block discarded – undo
692 692
 		$criteria = self::calculate_get_entries_criteria();
693 693
 
694 694
 		// Make sure the current View is connected to the same form as the Entry
695
-		if( ! empty( $criteria['context_view_id'] ) ) {
696
-			$context_view_id = intval( $criteria['context_view_id'] );
695
+		if ( ! empty( $criteria[ 'context_view_id' ] ) ) {
696
+			$context_view_id = intval( $criteria[ 'context_view_id' ] );
697 697
 			$context_form_id = gravityview_get_form_id( $context_view_id );
698
-			if( intval( $context_form_id ) !== intval( $entry['form_id'] ) ) {
699
-				do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry['form_id'] ), $criteria['context_view_id'] );
698
+			if ( intval( $context_form_id ) !== intval( $entry[ 'form_id' ] ) ) {
699
+				do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry[ 'form_id' ] ), $criteria[ 'context_view_id' ] );
700 700
 				return false;
701 701
 			}
702 702
 		}
703 703
 
704
-		if ( empty( $criteria['search_criteria'] ) || ! is_array( $criteria['search_criteria'] ) ) {
704
+		if ( empty( $criteria[ 'search_criteria' ] ) || ! is_array( $criteria[ 'search_criteria' ] ) ) {
705 705
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry approved! No search criteria found:', $criteria );
706 706
 			return $entry;
707 707
 		}
708 708
 
709
-		$search_criteria = $criteria['search_criteria'];
709
+		$search_criteria = $criteria[ 'search_criteria' ];
710 710
 		unset( $criteria );
711 711
 
712 712
 		// check entry status
713
-		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria['status'] != $entry['status'] ) {
714
-			do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry['status'] ), $search_criteria );
713
+		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria[ 'status' ] != $entry[ 'status' ] ) {
714
+			do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry[ 'status' ] ), $search_criteria );
715 715
 			return false;
716 716
 		}
717 717
 
@@ -719,37 +719,37 @@  discard block
 block discarded – undo
719 719
 		// @todo: Does it make sense to apply the Date create filters to the single entry?
720 720
 
721 721
 		// field_filters
722
-		if ( empty( $search_criteria['field_filters'] ) || ! is_array( $search_criteria['field_filters'] ) ) {
722
+		if ( empty( $search_criteria[ 'field_filters' ] ) || ! is_array( $search_criteria[ 'field_filters' ] ) ) {
723 723
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry approved! No field filters criteria found:', $search_criteria );
724 724
 			return $entry;
725 725
 		}
726 726
 
727
-		$filters = $search_criteria['field_filters'];
727
+		$filters = $search_criteria[ 'field_filters' ];
728 728
 		unset( $search_criteria );
729 729
 
730
-		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters['mode'] ) : 'all';
731
-		unset( $filters['mode'] );
730
+		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters[ 'mode' ] ) : 'all';
731
+		unset( $filters[ 'mode' ] );
732 732
 
733
-		$form = self::get_form( $entry['form_id'] );
733
+		$form = self::get_form( $entry[ 'form_id' ] );
734 734
 
735 735
 		foreach ( $filters as $filter ) {
736 736
 
737
-			if ( ! isset( $filter['key'] ) ) {
737
+			if ( ! isset( $filter[ 'key' ] ) ) {
738 738
 				continue;
739 739
 			}
740 740
 
741
-			$k = $filter['key'];
741
+			$k = $filter[ 'key' ];
742 742
 
743 743
 			if ( in_array( $k, array( 'created_by', 'payment_status' ) ) ) {
744 744
 				$field_value = $entry[ $k ];
745 745
 				$field = null;
746 746
 			} else {
747 747
 				$field = self::get_field( $form, $k );
748
-				$field_value  = GFFormsModel::get_lead_field_value( $entry, $field );
748
+				$field_value = GFFormsModel::get_lead_field_value( $entry, $field );
749 749
 			}
750 750
 
751
-			$operator = isset( $filter['operator'] ) ? strtolower( $filter['operator'] ) : 'is';
752
-			$is_value_match = GFFormsModel::is_value_match( $field_value, $filter['value'], $operator, $field );
751
+			$operator = isset( $filter[ 'operator' ] ) ? strtolower( $filter[ 'operator' ] ) : 'is';
752
+			$is_value_match = GFFormsModel::is_value_match( $field_value, $filter[ 'value' ], $operator, $field );
753 753
 
754 754
 			// verify if we are already free to go!
755 755
 			if ( ! $is_value_match && 'all' === $mode ) {
@@ -807,18 +807,18 @@  discard block
 block discarded – undo
807 807
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
808 808
 		 * @see GFCommon::format_date() for original code
809 809
 		 */
810
-		$date_gmt_time   = mysql2date( 'G', $date_string );
810
+		$date_gmt_time = mysql2date( 'G', $date_string );
811 811
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
812 812
 
813
-		$format  = rgar( $atts, 'format' );
814
-		$is_human  = ! empty( $atts['human'] );
815
-		$is_diff  = ! empty( $atts['diff'] );
816
-		$is_raw = ! empty( $atts['raw'] );
817
-		$is_timestamp = ! empty( $atts['timestamp'] );
818
-		$include_time = ! empty( $atts['time'] );
813
+		$format = rgar( $atts, 'format' );
814
+		$is_human = ! empty( $atts[ 'human' ] );
815
+		$is_diff = ! empty( $atts[ 'diff' ] );
816
+		$is_raw = ! empty( $atts[ 'raw' ] );
817
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
818
+		$include_time = ! empty( $atts[ 'time' ] );
819 819
 
820 820
 		// If we're using time diff, we want to have a different default format
821
-		if( empty( $format ) ) {
821
+		if ( empty( $format ) ) {
822 822
 			/* translators: %s: relative time from now, used for generic date comparisons. "1 day ago", or "20 seconds ago" */
823 823
 			$format = $is_diff ? esc_html__( '%s ago', 'gravityview' ) : get_option( 'date_format' );
824 824
 		}
@@ -826,7 +826,7 @@  discard block
 block discarded – undo
826 826
 		// If raw was specified, don't modify the stored value
827 827
 		if ( $is_raw ) {
828 828
 			$formatted_date = $date_string;
829
-		} elseif( $is_timestamp ) {
829
+		} elseif ( $is_timestamp ) {
830 830
 			$formatted_date = $date_local_timestamp;
831 831
 		} elseif ( $is_diff ) {
832 832
 			$formatted_date = sprintf( $format, human_time_diff( $date_gmt_time ) );
@@ -860,7 +860,7 @@  discard block
 block discarded – undo
860 860
 
861 861
 		$label = rgar( $field, 'label' );
862 862
 
863
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
863
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
864 864
 			$label = GFFormsModel::get_choice_text( $field, $field_value, $field_id );
865 865
 		}
866 866
 
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
 	 * @return GF_Field|null Gravity Forms field object, or NULL: Gravity Forms GFFormsModel does not exist or field at $field_id doesn't exist.
882 882
 	 */
883 883
 	public static function get_field( $form, $field_id ) {
884
-		if ( class_exists( 'GFFormsModel' ) ){
884
+		if ( class_exists( 'GFFormsModel' ) ) {
885 885
 			return GFFormsModel::get_field( $form, $field_id );
886 886
 		} else {
887 887
 			return null;
@@ -928,19 +928,19 @@  discard block
 block discarded – undo
928 928
 			$shortcodes = array();
929 929
 
930 930
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
931
-			if ( empty( $matches ) ){
931
+			if ( empty( $matches ) ) {
932 932
 				return false;
933 933
 			}
934 934
 
935 935
 			foreach ( $matches as $shortcode ) {
936
-				if ( $tag === $shortcode[2] ) {
936
+				if ( $tag === $shortcode[ 2 ] ) {
937 937
 
938 938
 					// Changed this to $shortcode instead of true so we get the parsed atts.
939
-					$shortcodes[] = $shortcode;
939
+					$shortcodes[ ] = $shortcode;
940 940
 
941
-				} else if ( isset( $shortcode[5] ) && $results = self::has_shortcode_r( $shortcode[5], $tag ) ) {
942
-					foreach( $results as $result ) {
943
-						$shortcodes[] = $result;
941
+				} else if ( isset( $shortcode[ 5 ] ) && $results = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
942
+					foreach ( $results as $result ) {
943
+						$shortcodes[ ] = $result;
944 944
 					}
945 945
 				}
946 946
 			}
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
 	 * @return string         html
1102 1102
 	 */
1103 1103
 	public static function get_sortable_fields( $formid, $current = '' ) {
1104
-		$output = '<option value="" ' . selected( '', $current, false ).'>' . esc_html__( 'Default', 'gravityview' ) .'</option>';
1104
+		$output = '<option value="" ' . selected( '', $current, false ) . '>' . esc_html__( 'Default', 'gravityview' ) . '</option>';
1105 1105
 
1106 1106
 		if ( empty( $formid ) ) {
1107 1107
 			return $output;
@@ -1114,11 +1114,11 @@  discard block
 block discarded – undo
1114 1114
 			$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', array( 'list', 'textarea' ), null );
1115 1115
 
1116 1116
 			foreach ( $fields as $id => $field ) {
1117
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
1117
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1118 1118
 					continue;
1119 1119
 				}
1120 1120
 
1121
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'>'. esc_attr( $field['label'] ) .'</option>';
1121
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
1122 1122
 			}
1123 1123
 		}
1124 1124
 
@@ -1153,9 +1153,9 @@  discard block
 block discarded – undo
1153 1153
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1154 1154
 
1155 1155
 		// TODO: Convert to using array_filter
1156
-		foreach( $fields as $id => $field ) {
1156
+		foreach ( $fields as $id => $field ) {
1157 1157
 
1158
-			if( in_array( $field['type'], $blacklist_field_types ) ) {
1158
+			if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1159 1159
 				unset( $fields[ $id ] );
1160 1160
 			}
1161 1161
 		}
@@ -1196,14 +1196,14 @@  discard block
 block discarded – undo
1196 1196
 	 * @param  int|array  $field field key or field array
1197 1197
 	 * @return boolean
1198 1198
 	 */
1199
-	public static function is_field_numeric(  $form = null, $field = '' ) {
1199
+	public static function is_field_numeric( $form = null, $field = '' ) {
1200 1200
 
1201 1201
 		if ( ! is_array( $form ) && ! is_array( $field ) ) {
1202 1202
 			$form = self::get_form( $form );
1203 1203
 		}
1204 1204
 
1205 1205
 		// If entry meta, it's a string. Otherwise, numeric
1206
-		if( ! is_numeric( $field ) && is_string( $field ) ) {
1206
+		if ( ! is_numeric( $field ) && is_string( $field ) ) {
1207 1207
 			$type = $field;
1208 1208
 		} else {
1209 1209
 			$type = self::get_field_type( $form, $field );
@@ -1217,9 +1217,9 @@  discard block
 block discarded – undo
1217 1217
 		$numeric_types = apply_filters( 'gravityview/common/numeric_types', array( 'number', 'time' ) );
1218 1218
 
1219 1219
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
1220
-		if( $gv_field = GravityView_Fields::get( $type ) ) {
1221
-			if( true === $gv_field->is_numeric ) {
1222
-				$numeric_types[] = $gv_field->is_numeric;
1220
+		if ( $gv_field = GravityView_Fields::get( $type ) ) {
1221
+			if ( true === $gv_field->is_numeric ) {
1222
+				$numeric_types[ ] = $gv_field->is_numeric;
1223 1223
 			}
1224 1224
 		}
1225 1225
 
@@ -1369,11 +1369,11 @@  discard block
 block discarded – undo
1369 1369
 		$final_atts = array_filter( $final_atts );
1370 1370
 
1371 1371
 		// If the href wasn't passed as an attribute, use the value passed to the function
1372
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
1373
-			$final_atts['href'] = $href;
1372
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
1373
+			$final_atts[ 'href' ] = $href;
1374 1374
 		}
1375 1375
 
1376
-		$final_atts['href'] = esc_url_raw( $href );
1376
+		$final_atts[ 'href' ] = esc_url_raw( $href );
1377 1377
 
1378 1378
 		// Sort the attributes alphabetically, to help testing
1379 1379
 		ksort( $final_atts );
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
 			$output .= sprintf( ' %s="%s"', $attr, esc_attr( $value ) );
1385 1385
 		}
1386 1386
 
1387
-		if( '' !== $output ) {
1387
+		if ( '' !== $output ) {
1388 1388
 			$output = '<a' . $output . '>' . $anchor_text . '</a>';
1389 1389
 		}
1390 1390
 
@@ -1408,7 +1408,7 @@  discard block
 block discarded – undo
1408 1408
 	public static function array_merge_recursive_distinct( array &$array1, array &$array2 ) {
1409 1409
 		$merged = $array1;
1410 1410
 
1411
-		foreach ( $array2 as $key => &$value )  {
1411
+		foreach ( $array2 as $key => &$value ) {
1412 1412
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1413 1413
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1414 1414
 			} else {
@@ -1443,7 +1443,7 @@  discard block
 block discarded – undo
1443 1443
 		 * `$context` is where are we using this information (e.g. change_entry_creator, search_widget ..)
1444 1444
 		 * @param array $settings Settings array, with `number` key defining the # of users to display
1445 1445
 		 */
1446
-		$get_users_settings = apply_filters( 'gravityview/get_users/'. $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1446
+		$get_users_settings = apply_filters( 'gravityview/get_users/' . $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1447 1447
 
1448 1448
 		return get_users( $get_users_settings );
1449 1449
 	}
@@ -1458,7 +1458,7 @@  discard block
 block discarded – undo
1458 1458
      * @return string
1459 1459
      */
1460 1460
     public static function generate_notice( $notice, $class = '' ) {
1461
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1461
+        return '<div class="gv-notice ' . gravityview_sanitize_html_class( $class ) . '">' . $notice . '</div>';
1462 1462
     }
1463 1463
 
1464 1464
 	/**
Please login to merge, or discard this patch.
Braces   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
 				}
256 256
 
257 257
 
258
-				if( GFCommon::is_product_field( $field->type ) ){
258
+				if( GFCommon::is_product_field( $field->type ) ) {
259 259
 					$has_product_fields = true;
260 260
 				}
261 261
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 
316 316
 		$fields = array();
317 317
 
318
-		foreach ( $extra_fields as $key => $field ){
318
+		foreach ( $extra_fields as $key => $field ) {
319 319
 			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
320 320
 				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
321 321
 			}
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
 	 * @return GF_Field|null Gravity Forms field object, or NULL: Gravity Forms GFFormsModel does not exist or field at $field_id doesn't exist.
882 882
 	 */
883 883
 	public static function get_field( $form, $field_id ) {
884
-		if ( class_exists( 'GFFormsModel' ) ){
884
+		if ( class_exists( 'GFFormsModel' ) ) {
885 885
 			return GFFormsModel::get_field( $form, $field_id );
886 886
 		} else {
887 887
 			return null;
@@ -928,7 +928,7 @@  discard block
 block discarded – undo
928 928
 			$shortcodes = array();
929 929
 
930 930
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
931
-			if ( empty( $matches ) ){
931
+			if ( empty( $matches ) ) {
932 932
 				return false;
933 933
 			}
934 934
 
@@ -1408,7 +1408,7 @@  discard block
 block discarded – undo
1408 1408
 	public static function array_merge_recursive_distinct( array &$array1, array &$array2 ) {
1409 1409
 		$merged = $array1;
1410 1410
 
1411
-		foreach ( $array2 as $key => &$value )  {
1411
+		foreach ( $array2 as $key => &$value ) {
1412 1412
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1413 1413
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1414 1414
 			} else {
Please login to merge, or discard this patch.
includes/connector-functions.php 1 patch
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@  discard block
 block discarded – undo
41 41
  *
42 42
  * @see GVCommon::get_forms()
43 43
  * @access public
44
- * @param mixed $form_id
45 44
  * @return array Empty array if GFAPI isn't available or no forms. Otherwise, associative array with id, title keys
46 45
  */
47 46
 function gravityview_get_forms() {
@@ -53,7 +52,7 @@  discard block
 block discarded – undo
53 52
  *
54 53
  * @see GVCommon::get_form_fields()
55 54
  * @access public
56
- * @param string|array $form_id (default: '') or $form object
55
+ * @param string|array $form (default: '') or $form object
57 56
  * @return array
58 57
  */
59 58
 function gravityview_get_form_fields( $form = '', $add_default_properties = false, $include_parent_field = true ) {
@@ -91,6 +90,7 @@  discard block
 block discarded – undo
91 90
  * @param int|array $form_ids The ID of the form or an array IDs of the Forms. Zero for all forms.
92 91
  * @param mixed $passed_criteria (default: null)
93 92
  * @param mixed &$total (default: null)
93
+ * @param integer $total
94 94
  * @return mixed False: Error fetching entries. Array: Multi-dimensional array of Gravity Forms entry arrays
95 95
  */
96 96
 function gravityview_get_entries( $form_ids = null, $passed_criteria = null, &$total = null ) {
@@ -103,7 +103,6 @@  discard block
 block discarded – undo
103 103
  * Since 1.4, supports custom entry slugs. The way that GravityView fetches an entry based on the custom slug is by searching `gravityview_unique_id` meta. The `$entry_slug` is fetched by getting the current query var set by `is_single_entry()`
104 104
  *
105 105
  * @access public
106
- * @param mixed $entry_id
107 106
  * @param boolean $force_allow_ids Force the get_entry() method to allow passed entry IDs, even if the `gravityview_custom_entry_slug_allow_id` filter returns false.
108 107
  * @param boolean $check_entry_display Check whether the entry is visible for the current View configuration. Default: true {@since 1.14}
109 108
  * @return array|boolean
@@ -190,7 +189,6 @@  discard block
 block discarded – undo
190 189
  *
191 190
  * @see GravityView_Template::template_id
192 191
  *
193
- * @param int $view_id The ID of the View to get the layout of
194 192
  *
195 193
  * @return string GravityView_Template::template_id value. Empty string if not.
196 194
  */
Please login to merge, or discard this patch.
includes/class-admin.php 2 patches
Indentation   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 			7  => sprintf(__( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
176 176
 			8  => __( 'View submitted.', 'gravityview' ),
177 177
 			9  => sprintf(
178
-		        /* translators: Date and time the View is scheduled to be published */
178
+				/* translators: Date and time the View is scheduled to be published */
179 179
 				__( 'View scheduled for: %1$s.', 'gravityview' ),
180 180
 				// translators: Publish box date format, see http://php.net/date
181 181
 				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL )  ) )
@@ -232,7 +232,6 @@  discard block
 block discarded – undo
232 232
 	 *
233 233
 	 * @deprecated since 1.12
234 234
 	 * @see GravityView_Compatibility::get_plugin_status()
235
-
236 235
 	 * @return boolean|string True: plugin is active; False: plugin file doesn't exist at path; 'inactive' it's inactive
237 236
 	 */
238 237
 	static function get_plugin_status( $location = '' ) {
Please login to merge, or discard this patch.
Spacing   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -4,10 +4,10 @@  discard block
 block discarded – undo
4 4
 
5 5
 	function __construct() {
6 6
 
7
-		if( ! is_admin() ) { return; }
7
+		if ( ! is_admin() ) { return; }
8 8
 
9 9
 		// If Gravity Forms isn't active or compatibile, stop loading
10
-		if( false === GravityView_Compatibility::is_valid() ) {
10
+		if ( false === GravityView_Compatibility::is_valid() ) {
11 11
 			return;
12 12
 		}
13 13
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 		require_once( GRAVITYVIEW_DIR . 'includes/class-gravityview-migrate.php' );
26 26
 
27 27
 		// Don't load tooltips if on Gravity Forms, otherwise it overrides translations
28
-		if( class_exists( 'GFCommon' ) && class_exists( 'GFForms' ) && !GFForms::is_gravity_page() ) {
28
+		if ( class_exists( 'GFCommon' ) && class_exists( 'GFForms' ) && ! GFForms::is_gravity_page() ) {
29 29
 			require_once( GFCommon::get_base_path() . '/tooltips.php' );
30 30
 		}
31 31
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 		add_filter( 'post_updated_messages', array( $this, 'post_updated_messages' ) );
54 54
 		add_filter( 'bulk_post_updated_messages', array( $this, 'post_updated_messages' ) );
55 55
 
56
-		add_filter( 'plugin_action_links_'. plugin_basename( GRAVITYVIEW_FILE ) , array( $this, 'plugin_action_links' ) );
56
+		add_filter( 'plugin_action_links_' . plugin_basename( GRAVITYVIEW_FILE ), array( $this, 'plugin_action_links' ) );
57 57
 
58 58
 		add_action( 'plugins_loaded', array( $this, 'backend_actions' ), 100 );
59 59
 
@@ -68,20 +68,20 @@  discard block
 block discarded – undo
68 68
 	public function backend_actions() {
69 69
 
70 70
 		/** @define "GRAVITYVIEW_DIR" "../" */
71
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class.field.type.php' );
72
-		include_once( GRAVITYVIEW_DIR .'includes/admin/class.render.settings.php' );
73
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-label.php' );
74
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-views.php' );
75
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-welcome.php' );
76
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-add-shortcode.php' );
77
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
71
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class.field.type.php' );
72
+		include_once( GRAVITYVIEW_DIR . 'includes/admin/class.render.settings.php' );
73
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-label.php' );
74
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-views.php' );
75
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-welcome.php' );
76
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-add-shortcode.php' );
77
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
78 78
 
79 79
 		/**
80 80
 		 * @action `gravityview_include_backend_actions` Triggered after all GravityView admin files are loaded
81 81
 		 *
82 82
 		 * Nice place to insert extensions' backend stuff
83 83
 		 */
84
-		do_action('gravityview_include_backend_actions');
84
+		do_action( 'gravityview_include_backend_actions' );
85 85
 	}
86 86
 
87 87
 	/**
@@ -97,12 +97,12 @@  discard block
 block discarded – undo
97 97
 
98 98
 		$actions = array();
99 99
 
100
-		if( GVCommon::has_cap( 'gravityview_view_settings' ) ) {
101
-			$actions[] = sprintf( '<a href="%s">%s</a>', admin_url( 'edit.php?post_type=gravityview&page=gravityview_settings' ), esc_html__( 'Settings', 'gravityview' ) );
100
+		if ( GVCommon::has_cap( 'gravityview_view_settings' ) ) {
101
+			$actions[ ] = sprintf( '<a href="%s">%s</a>', admin_url( 'edit.php?post_type=gravityview&page=gravityview_settings' ), esc_html__( 'Settings', 'gravityview' ) );
102 102
 		}
103 103
 
104
-		if( GVCommon::has_cap( 'gravityview_support_port' ) ) {
105
-			$actions[] = '<a href="http://docs.gravityview.co">' . esc_html__( 'Support', 'gravityview' ) . '</a>';
104
+		if ( GVCommon::has_cap( 'gravityview_support_port' ) ) {
105
+			$actions[ ] = '<a href="http://docs.gravityview.co">' . esc_html__( 'Support', 'gravityview' ) . '</a>';
106 106
 		}
107 107
 
108 108
 		return array_merge( $actions, $links );
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 		// By default, there will only be one item being modified.
131 131
 		// When in the `bulk_post_updated_messages` filter, there will be passed a number
132 132
 		// of modified items that will override this array.
133
-		$bulk_counts = is_null( $bulk_counts ) ? array( 'updated' => 1 , 'locked' => 1 , 'deleted' => 1 , 'trashed' => 1, 'untrashed' => 1 ) : $bulk_counts;
133
+		$bulk_counts = is_null( $bulk_counts ) ? array( 'updated' => 1, 'locked' => 1, 'deleted' => 1, 'trashed' => 1, 'untrashed' => 1 ) : $bulk_counts;
134 134
 
135 135
 		// If we're starting fresh, a new form was created.
136 136
 		// We should let the user know this is the case.
@@ -138,60 +138,60 @@  discard block
 block discarded – undo
138 138
 
139 139
 		$new_form_text = '';
140 140
 
141
-		if( !empty( $start_fresh ) ) {
141
+		if ( ! empty( $start_fresh ) ) {
142 142
 
143 143
 			// Get the form that was created
144 144
 			$connected_form = gravityview_get_form_id( $post_id );
145 145
 
146
-			if( !empty( $connected_form ) ) {
146
+			if ( ! empty( $connected_form ) ) {
147 147
 				$form = gravityview_get_form( $connected_form );
148
-				$form_name = esc_attr( $form['title'] );
148
+				$form_name = esc_attr( $form[ 'title' ] );
149 149
 				$image = self::get_floaty();
150
-				$new_form_text .= '<h3>'.$image.sprintf( __( 'A new form was created for this View: "%s"', 'gravityview' ), $form_name ).'</h3>';
151
-				$new_form_text .=  sprintf( __( '%sThere are no entries for the new form, so the View will also be empty.%s To start collecting entries, you can add submissions through %sthe preview form%s and also embed the form on a post or page using this code: %s
150
+				$new_form_text .= '<h3>' . $image . sprintf( __( 'A new form was created for this View: "%s"', 'gravityview' ), $form_name ) . '</h3>';
151
+				$new_form_text .= sprintf( __( '%sThere are no entries for the new form, so the View will also be empty.%s To start collecting entries, you can add submissions through %sthe preview form%s and also embed the form on a post or page using this code: %s
152 152
 
153 153
 					You can %sedit the form%s in Gravity Forms and the updated fields will be available here. Don&rsquo;t forget to %scustomize the form settings%s.
154
-					', 'gravityview' ), '<strong>', '</strong>', '<a href="'.site_url( '?gf_page=preview&amp;id='.$connected_form ).'">', '</a>', '<code>[gravityform id="'.$connected_form.'" name="'.$form_name.'"]</code>', '<a href="'.admin_url( 'admin.php?page=gf_edit_forms&amp;id='.$connected_form ).'">', '</a>', '<a href="'.admin_url( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id='.$connected_form ).'">', '</a>');
154
+					', 'gravityview' ), '<strong>', '</strong>', '<a href="' . site_url( '?gf_page=preview&amp;id=' . $connected_form ) . '">', '</a>', '<code>[gravityform id="' . $connected_form . '" name="' . $form_name . '"]</code>', '<a href="' . admin_url( 'admin.php?page=gf_edit_forms&amp;id=' . $connected_form ) . '">', '</a>', '<a href="' . admin_url( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id=' . $connected_form ) . '">', '</a>' );
155 155
 				$new_form_text = wpautop( $new_form_text );
156 156
 
157 157
 				delete_post_meta( $post_id, '_gravityview_start_fresh' );
158 158
 			}
159 159
 		}
160 160
 
161
-		$messages['gravityview'] = array(
161
+		$messages[ 'gravityview' ] = array(
162 162
 			0  => '', // Unused. Messages start at index 1.
163 163
 			/* translators: %s and %s are HTML tags linking to the View on the website */
164
-			1  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
164
+			1  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
165 165
 			/* translators: %s and %s are HTML tags linking to the View on the website */
166
-			2  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
166
+			2  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
167 167
 			3  => __( 'View deleted.', 'gravityview' ),
168 168
 			/* translators: %s and %s are HTML tags linking to the View on the website */
169
-			4  => sprintf(__( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
169
+			4  => sprintf( __( 'View updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
170 170
 			/* translators: %s: date and time of the revision */
171
-			5  => isset( $_GET['revision'] ) ? sprintf( __( 'View restored to revision from %s', 'gravityview' ), wp_post_revision_title( (int) $_GET['revision'], false ) ) : false,
171
+			5  => isset( $_GET[ 'revision' ] ) ? sprintf( __( 'View restored to revision from %s', 'gravityview' ), wp_post_revision_title( (int)$_GET[ 'revision' ], false ) ) : false,
172 172
 			/* translators: %s and %s are HTML tags linking to the View on the website */
173
-			6  => sprintf(__( 'View published. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
173
+			6  => sprintf( __( 'View published. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ) . $new_form_text,
174 174
 			/* translators: %s and %s are HTML tags linking to the View on the website */
175
-			7  => sprintf(__( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>') . $new_form_text,
175
+			7  => sprintf( __( 'View saved. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ) . $new_form_text,
176 176
 			8  => __( 'View submitted.', 'gravityview' ),
177 177
 			9  => sprintf(
178 178
 		        /* translators: Date and time the View is scheduled to be published */
179 179
 				__( 'View scheduled for: %1$s.', 'gravityview' ),
180 180
 				// translators: Publish box date format, see http://php.net/date
181
-				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL )  ) )
181
+				date_i18n( __( 'M j, Y @ G:i', 'gravityview' ), strtotime( ( isset( $post->post_date ) ? $post->post_date : NULL ) ) )
182 182
 			) . $new_form_text,
183 183
 			/* translators: %s and %s are HTML tags linking to the View on the website */
184
-			10  => sprintf(__( 'View draft updated. %sView on website.%s', 'gravityview' ), '<a href="'.get_permalink( $post_id ).'">', '</a>'),
184
+			10  => sprintf( __( 'View draft updated. %sView on website.%s', 'gravityview' ), '<a href="' . get_permalink( $post_id ) . '">', '</a>' ),
185 185
 
186 186
 			/**
187 187
 			 * These apply to `bulk_post_updated_messages`
188 188
 			 * @file wp-admin/edit.php
189 189
 			 */
190
-			'updated'   => _n( '%s View updated.', '%s Views updated.', $bulk_counts['updated'], 'gravityview' ),
191
-			'locked'    => _n( '%s View not updated, somebody is editing it.', '%s Views not updated, somebody is editing them.', $bulk_counts['locked'], 'gravityview' ),
192
-			'deleted'   => _n( '%s View permanently deleted.', '%s Views permanently deleted.', $bulk_counts['deleted'], 'gravityview' ),
193
-			'trashed'   => _n( '%s View moved to the Trash.', '%s Views moved to the Trash.', $bulk_counts['trashed'], 'gravityview' ),
194
-			'untrashed' => _n( '%s View restored from the Trash.', '%s Views restored from the Trash.', $bulk_counts['untrashed'], 'gravityview' ),
190
+			'updated'   => _n( '%s View updated.', '%s Views updated.', $bulk_counts[ 'updated' ], 'gravityview' ),
191
+			'locked'    => _n( '%s View not updated, somebody is editing it.', '%s Views not updated, somebody is editing them.', $bulk_counts[ 'locked' ], 'gravityview' ),
192
+			'deleted'   => _n( '%s View permanently deleted.', '%s Views permanently deleted.', $bulk_counts[ 'deleted' ], 'gravityview' ),
193
+			'trashed'   => _n( '%s View moved to the Trash.', '%s Views moved to the Trash.', $bulk_counts[ 'trashed' ], 'gravityview' ),
194
+			'untrashed' => _n( '%s View restored from the Trash.', '%s Views restored from the Trash.', $bulk_counts[ 'untrashed' ], 'gravityview' ),
195 195
 		);
196 196
 
197 197
 		return $messages;
@@ -251,29 +251,29 @@  discard block
 block discarded – undo
251 251
 	static function is_admin_page( $hook = '', $page = NULL ) {
252 252
 		global $current_screen, $plugin_page, $pagenow, $post;
253 253
 
254
-		if( ! is_admin() ) { return false; }
254
+		if ( ! is_admin() ) { return false; }
255 255
 
256 256
 		$is_page = false;
257 257
 
258
-		$is_gv_screen = (!empty($current_screen) && isset($current_screen->post_type) && $current_screen->post_type === 'gravityview');
258
+		$is_gv_screen = ( ! empty( $current_screen ) && isset( $current_screen->post_type ) && $current_screen->post_type === 'gravityview' );
259 259
 
260
-		$is_gv_post_type_get = (isset($_GET['post_type']) && $_GET['post_type'] === 'gravityview');
260
+		$is_gv_post_type_get = ( isset( $_GET[ 'post_type' ] ) && $_GET[ 'post_type' ] === 'gravityview' );
261 261
 
262
-		$is_gv_settings_get = isset( $_GET['page'] ) && $_GET['page'] === 'gravityview_settings';
262
+		$is_gv_settings_get = isset( $_GET[ 'page' ] ) && $_GET[ 'page' ] === 'gravityview_settings';
263 263
 
264
-		if( empty( $post ) && $pagenow === 'post.php' && !empty( $_GET['post'] ) ) {
265
-			$gv_post = get_post( intval( $_GET['post'] ) );
266
-			$is_gv_post_type = (!empty($gv_post) && !empty($gv_post->post_type) && $gv_post->post_type === 'gravityview');
264
+		if ( empty( $post ) && $pagenow === 'post.php' && ! empty( $_GET[ 'post' ] ) ) {
265
+			$gv_post = get_post( intval( $_GET[ 'post' ] ) );
266
+			$is_gv_post_type = ( ! empty( $gv_post ) && ! empty( $gv_post->post_type ) && $gv_post->post_type === 'gravityview' );
267 267
 		} else {
268
-			$is_gv_post_type = (!empty($post) && !empty($post->post_type) && $post->post_type === 'gravityview');
268
+			$is_gv_post_type = ( ! empty( $post ) && ! empty( $post->post_type ) && $post->post_type === 'gravityview' );
269 269
 		}
270 270
 
271
-		if( $is_gv_screen || $is_gv_post_type || $is_gv_post_type || $is_gv_post_type_get || $is_gv_settings_get ) {
271
+		if ( $is_gv_screen || $is_gv_post_type || $is_gv_post_type || $is_gv_post_type_get || $is_gv_settings_get ) {
272 272
 
273 273
 			// $_GET `post_type` variable
274
-			if(in_array($pagenow, array( 'post.php' , 'post-new.php' )) ) {
274
+			if ( in_array( $pagenow, array( 'post.php', 'post-new.php' ) ) ) {
275 275
 				$is_page = 'single';
276
-			} else if ( in_array( $plugin_page, array( 'gravityview_settings', 'gravityview_page_gravityview_settings' ) ) || ( !empty( $_GET['page'] ) && $_GET['page'] === 'gravityview_settings' ) ) {
276
+			} else if ( in_array( $plugin_page, array( 'gravityview_settings', 'gravityview_page_gravityview_settings' ) ) || ( ! empty( $_GET[ 'page' ] ) && $_GET[ 'page' ] === 'gravityview_settings' ) ) {
277 277
 				$is_page = 'settings';
278 278
 			} else {
279 279
 				$is_page = 'views';
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
 		$is_page = apply_filters( 'gravityview_is_admin_page', $is_page, $hook );
289 289
 
290 290
 		// If the current page is the same as the compared page
291
-		if( !empty( $page ) ) {
291
+		if ( ! empty( $page ) ) {
292 292
 			return $is_page === $page;
293 293
 		}
294 294
 
@@ -309,6 +309,6 @@  discard block
 block discarded – undo
309 309
  *
310 310
  * @return bool|string|void If `false`, not a GravityView page. `true` if $page is passed and is the same as current page. Otherwise, the name of the page (`single`, `settings`, or `views`)
311 311
  */
312
-function gravityview_is_admin_page($hook = '', $page = NULL) {
312
+function gravityview_is_admin_page( $hook = '', $page = NULL ) {
313 313
 	return GravityView_Admin::is_admin_page( $hook, $page );
314 314
 }
Please login to merge, or discard this patch.