Completed
Push — develop ( a94794...65380d )
by Zack
19:34
created
future/lib/EDD_SL_Plugin_Updater.php 1 patch
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
40 40
 		$this->api_data    = $_api_data;
41 41
 		$this->name        = plugin_basename( $_plugin_file );
42 42
 		$this->slug        = basename( $_plugin_file, '.php' );
43
-		$this->version     = $_api_data['version'];
44
-		$this->wp_override = isset( $_api_data['wp_override'] ) ? (bool) $_api_data['wp_override'] : false;
45
-		$this->beta        = ! empty( $this->api_data['beta'] ) ? true : false;
46
-		$this->cache_key   = 'edd_sl_' . md5( serialize( $this->slug . $this->api_data['license'] . $this->beta ) );
43
+		$this->version     = $_api_data[ 'version' ];
44
+		$this->wp_override = isset( $_api_data[ 'wp_override' ] ) ? (bool)$_api_data[ 'wp_override' ] : false;
45
+		$this->beta        = ! empty( $this->api_data[ 'beta' ] ) ? true : false;
46
+		$this->cache_key   = 'edd_sl_' . md5( serialize( $this->slug . $this->api_data[ 'license' ] . $this->beta ) );
47 47
 
48 48
 		$edd_plugin_data[ $this->slug ] = $this->api_data;
49 49
 
@@ -147,11 +147,11 @@  discard block
 block discarded – undo
147 147
 			return;
148 148
 		}
149 149
 
150
-		if( ! current_user_can( 'update_plugins' ) ) {
150
+		if ( ! current_user_can( 'update_plugins' ) ) {
151 151
 			return;
152 152
 		}
153 153
 
154
-		if( ! is_multisite() ) {
154
+		if ( ! is_multisite() ) {
155 155
 			return;
156 156
 		}
157 157
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 					'<a target="_blank" class="thickbox" href="' . esc_url( $changelog_link ) . '">',
248 248
 					esc_html( $version_info->new_version ),
249 249
 					'</a>',
250
-					'<a href="' . esc_url( wp_nonce_url( self_admin_url( 'update.php?action=upgrade-plugin&plugin=' ) . $this->name, 'upgrade-plugin_' . $this->name ) ) .'">',
250
+					'<a href="' . esc_url( wp_nonce_url( self_admin_url( 'update.php?action=upgrade-plugin&plugin=' ) . $this->name, 'upgrade-plugin_' . $this->name ) ) . '">',
251 251
 					'</a>'
252 252
 				);
253 253
 			}
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
 			)
293 293
 		);
294 294
 
295
-		$cache_key = 'edd_api_request_' . md5( serialize( $this->slug . $this->api_data['license'] . $this->beta ) );
295
+		$cache_key = 'edd_api_request_' . md5( serialize( $this->slug . $this->api_data[ 'license' ] . $this->beta ) );
296 296
 
297 297
 		// Get the transient where we store the api request for this plugin for 24 hours
298 298
 		$edd_api_request_transient = $this->get_cached_version_info( $cache_key );
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
 			$_data->contributors = $this->convert_object_to_array( $_data->contributors );
334 334
 		}
335 335
 
336
-		if( ! isset( $_data->plugin ) ) {
336
+		if ( ! isset( $_data->plugin ) ) {
337 337
 			$_data->plugin = $this->name;
338 338
 		}
339 339
 
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 
373 373
 		$verify_ssl = $this->verify_ssl();
374 374
 		if ( strpos( $url, 'https://' ) !== false && strpos( $url, 'edd_action=package_download' ) ) {
375
-			$args['sslverify'] = $verify_ssl;
375
+			$args[ 'sslverify' ] = $verify_ssl;
376 376
 		}
377 377
 		return $args;
378 378
 
@@ -400,9 +400,9 @@  discard block
 block discarded – undo
400 400
 		if ( ! is_array( $edd_plugin_url_available ) || ! isset( $edd_plugin_url_available[ $store_hash ] ) ) {
401 401
 			$test_url_parts = parse_url( $this->api_url );
402 402
 
403
-			$scheme = ! empty( $test_url_parts['scheme'] ) ? $test_url_parts['scheme']     : 'http';
404
-			$host   = ! empty( $test_url_parts['host'] )   ? $test_url_parts['host']       : '';
405
-			$port   = ! empty( $test_url_parts['port'] )   ? ':' . $test_url_parts['port'] : '';
403
+			$scheme = ! empty( $test_url_parts[ 'scheme' ] ) ? $test_url_parts[ 'scheme' ] : 'http';
404
+			$host   = ! empty( $test_url_parts[ 'host' ] ) ? $test_url_parts[ 'host' ] : '';
405
+			$port   = ! empty( $test_url_parts[ 'port' ] ) ? ':' . $test_url_parts[ 'port' ] : '';
406 406
 
407 407
 			if ( empty( $host ) ) {
408 408
 				$edd_plugin_url_available[ $store_hash ] = false;
@@ -419,27 +419,27 @@  discard block
 block discarded – undo
419 419
 
420 420
 		$data = array_merge( $this->api_data, $_data );
421 421
 
422
-		if ( $data['slug'] != $this->slug ) {
422
+		if ( $data[ 'slug' ] != $this->slug ) {
423 423
 			return;
424 424
 		}
425 425
 
426
-		if( $this->api_url == trailingslashit ( home_url() ) ) {
426
+		if ( $this->api_url == trailingslashit( home_url() ) ) {
427 427
 			return false; // Don't allow a plugin to ping itself
428 428
 		}
429 429
 
430 430
 		$api_params = array(
431 431
 			'edd_action' => 'get_version',
432
-			'license'    => ! empty( $data['license'] ) ? $data['license'] : '',
433
-			'item_name'  => isset( $data['item_name'] ) ? $data['item_name'] : false,
434
-			'item_id'    => isset( $data['item_id'] ) ? $data['item_id'] : false,
435
-			'version'    => isset( $data['version'] ) ? $data['version'] : false,
436
-			'slug'       => $data['slug'],
437
-			'author'     => $data['author'],
432
+			'license'    => ! empty( $data[ 'license' ] ) ? $data[ 'license' ] : '',
433
+			'item_name'  => isset( $data[ 'item_name' ] ) ? $data[ 'item_name' ] : false,
434
+			'item_id'    => isset( $data[ 'item_id' ] ) ? $data[ 'item_id' ] : false,
435
+			'version'    => isset( $data[ 'version' ] ) ? $data[ 'version' ] : false,
436
+			'slug'       => $data[ 'slug' ],
437
+			'author'     => $data[ 'author' ],
438 438
 			'url'        => home_url(),
439
-			'beta'       => ! empty( $data['beta'] ),
439
+			'beta'       => ! empty( $data[ 'beta' ] ),
440 440
 		);
441 441
 
442
-		$request    = wp_remote_post( $this->api_url, array( 'timeout' => 15, 'sslverify' => $verify_ssl, 'body' => $api_params ) );
442
+		$request = wp_remote_post( $this->api_url, array( 'timeout' => 15, 'sslverify' => $verify_ssl, 'body' => $api_params ) );
443 443
 
444 444
 		if ( ! is_wp_error( $request ) ) {
445 445
 			$request = json_decode( wp_remote_retrieve_body( $request ) );
@@ -459,9 +459,9 @@  discard block
 block discarded – undo
459 459
 			$request->icons = maybe_unserialize( $request->icons );
460 460
 		}
461 461
 
462
-		if( ! empty( $request->sections ) ) {
463
-			foreach( $request->sections as $key => $section ) {
464
-				$request->$key = (array) $section;
462
+		if ( ! empty( $request->sections ) ) {
463
+			foreach ( $request->sections as $key => $section ) {
464
+				$request->$key = (array)$section;
465 465
 			}
466 466
 		}
467 467
 
@@ -472,37 +472,37 @@  discard block
 block discarded – undo
472 472
 
473 473
 		global $edd_plugin_data;
474 474
 
475
-		if( empty( $_REQUEST['edd_sl_action'] ) || 'view_plugin_changelog' != $_REQUEST['edd_sl_action'] ) {
475
+		if ( empty( $_REQUEST[ 'edd_sl_action' ] ) || 'view_plugin_changelog' != $_REQUEST[ 'edd_sl_action' ] ) {
476 476
 			return;
477 477
 		}
478 478
 
479
-		if( empty( $_REQUEST['plugin'] ) ) {
479
+		if ( empty( $_REQUEST[ 'plugin' ] ) ) {
480 480
 			return;
481 481
 		}
482 482
 
483
-		if( empty( $_REQUEST['slug'] ) ) {
483
+		if ( empty( $_REQUEST[ 'slug' ] ) ) {
484 484
 			return;
485 485
 		}
486 486
 
487
-		if( ! current_user_can( 'update_plugins' ) ) {
487
+		if ( ! current_user_can( 'update_plugins' ) ) {
488 488
 			wp_die( __( 'You do not have permission to install plugin updates', 'gravityview' ), __( 'Error', 'gravityview' ), array( 'response' => 403 ) );
489 489
 		}
490 490
 
491
-		$data         = $edd_plugin_data[ $_REQUEST['slug'] ];
492
-		$beta         = ! empty( $data['beta'] ) ? true : false;
493
-		$cache_key    = md5( 'edd_plugin_' . sanitize_key( $_REQUEST['plugin'] ) . '_' . $beta . '_version_info' );
491
+		$data         = $edd_plugin_data[ $_REQUEST[ 'slug' ] ];
492
+		$beta         = ! empty( $data[ 'beta' ] ) ? true : false;
493
+		$cache_key    = md5( 'edd_plugin_' . sanitize_key( $_REQUEST[ 'plugin' ] ) . '_' . $beta . '_version_info' );
494 494
 		$version_info = $this->get_cached_version_info( $cache_key );
495 495
 
496
-		if( false === $version_info ) {
496
+		if ( false === $version_info ) {
497 497
 
498 498
 			$api_params = array(
499 499
 				'edd_action' => 'get_version',
500
-				'item_name'  => isset( $data['item_name'] ) ? $data['item_name'] : false,
501
-				'item_id'    => isset( $data['item_id'] ) ? $data['item_id'] : false,
502
-				'slug'       => $_REQUEST['slug'],
503
-				'author'     => $data['author'],
500
+				'item_name'  => isset( $data[ 'item_name' ] ) ? $data[ 'item_name' ] : false,
501
+				'item_id'    => isset( $data[ 'item_id' ] ) ? $data[ 'item_id' ] : false,
502
+				'slug'       => $_REQUEST[ 'slug' ],
503
+				'author'     => $data[ 'author' ],
504 504
 				'url'        => home_url(),
505
-				'beta'       => ! empty( $data['beta'] )
505
+				'beta'       => ! empty( $data[ 'beta' ] )
506 506
 			);
507 507
 
508 508
 			$verify_ssl = $this->verify_ssl();
@@ -519,9 +519,9 @@  discard block
 block discarded – undo
519 519
 				$version_info = false;
520 520
 			}
521 521
 
522
-			if( ! empty( $version_info ) ) {
523
-				foreach( $version_info->sections as $key => $section ) {
524
-					$version_info->$key = (array) $section;
522
+			if ( ! empty( $version_info ) ) {
523
+				foreach ( $version_info->sections as $key => $section ) {
524
+					$version_info->$key = (array)$section;
525 525
 				}
526 526
 			}
527 527
 
@@ -529,8 +529,8 @@  discard block
 block discarded – undo
529 529
 
530 530
 		}
531 531
 
532
-		if( ! empty( $version_info ) && isset( $version_info->sections['changelog'] ) ) {
533
-			echo '<div style="background:#fff;padding:10px;">' . $version_info->sections['changelog'] . '</div>';
532
+		if ( ! empty( $version_info ) && isset( $version_info->sections[ 'changelog' ] ) ) {
533
+			echo '<div style="background:#fff;padding:10px;">' . $version_info->sections[ 'changelog' ] . '</div>';
534 534
 		}
535 535
 
536 536
 		exit;
@@ -538,29 +538,29 @@  discard block
 block discarded – undo
538 538
 
539 539
 	public function get_cached_version_info( $cache_key = '' ) {
540 540
 
541
-		if( empty( $cache_key ) ) {
541
+		if ( empty( $cache_key ) ) {
542 542
 			$cache_key = $this->cache_key;
543 543
 		}
544 544
 
545 545
 		$cache = get_option( $cache_key );
546 546
 
547
-		if( empty( $cache['timeout'] ) || time() > $cache['timeout'] ) {
547
+		if ( empty( $cache[ 'timeout' ] ) || time() > $cache[ 'timeout' ] ) {
548 548
 			return false; // Cache is expired
549 549
 		}
550 550
 
551 551
 		// We need to turn the icons into an array, thanks to WP Core forcing these into an object at some point.
552
-		$cache['value'] = json_decode( $cache['value'] );
553
-		if ( ! empty( $cache['value']->icons ) ) {
554
-			$cache['value']->icons = (array) $cache['value']->icons;
552
+		$cache[ 'value' ] = json_decode( $cache[ 'value' ] );
553
+		if ( ! empty( $cache[ 'value' ]->icons ) ) {
554
+			$cache[ 'value' ]->icons = (array)$cache[ 'value' ]->icons;
555 555
 		}
556 556
 
557
-		return $cache['value'];
557
+		return $cache[ 'value' ];
558 558
 
559 559
 	}
560 560
 
561 561
 	public function set_version_info_cache( $value = '', $cache_key = '' ) {
562 562
 
563
-		if( empty( $cache_key ) ) {
563
+		if ( empty( $cache_key ) ) {
564 564
 			$cache_key = $this->cache_key;
565 565
 		}
566 566
 
@@ -580,7 +580,7 @@  discard block
 block discarded – undo
580 580
 	 * @return bool
581 581
 	 */
582 582
 	private function verify_ssl() {
583
-		return (bool) apply_filters( 'edd_sl_api_request_verify_ssl', true, $this );
583
+		return (bool)apply_filters( 'edd_sl_api_request_verify_ssl', true, $this );
584 584
 	}
585 585
 
586 586
 }
Please login to merge, or discard this patch.
future/includes/class-gv-extension.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -180,13 +180,13 @@  discard block
 block discarded – undo
180 180
 		$tab = wp_parse_args( $tab_settings, $tab_defaults );
181 181
 
182 182
 		// Force the screen to be GravityView
183
-		$tab['screen'] = 'gravityview';
183
+		$tab[ 'screen' ] = 'gravityview';
184 184
 
185 185
 		if ( class_exists( 'GravityView_Metabox_Tab' ) ) {
186
-			$metabox = new \GravityView_Metabox_Tab( $tab['id'], $tab['title'], $tab['file'], $tab['icon-class'], $tab['callback'], $tab['callback_args'] );
186
+			$metabox = new \GravityView_Metabox_Tab( $tab[ 'id' ], $tab[ 'title' ], $tab[ 'file' ], $tab[ 'icon-class' ], $tab[ 'callback' ], $tab[ 'callback_args' ] );
187 187
 			\GravityView_Metabox_Tabs::add( $metabox );
188 188
 		} else {
189
-			add_meta_box( 'gravityview_' . $tab['id'], $tab['title'], $tab['callback'], $tab['screen'], $tab['context'], $tab['priority'] );
189
+			add_meta_box( 'gravityview_' . $tab[ 'id' ], $tab[ 'title' ], $tab[ 'callback' ], $tab[ 'screen' ], $tab[ 'context' ], $tab[ 'priority' ] );
190 190
 		}
191 191
 	}
192 192
 
@@ -211,14 +211,14 @@  discard block
 block discarded – undo
211 211
 	 */
212 212
 	protected function is_extension_supported() {
213 213
 
214
-		self::$is_compatible = is_array( self::$is_compatible ) ? self::$is_compatible : array( get_called_class() => (bool) self::$is_compatible );
214
+		self::$is_compatible = is_array( self::$is_compatible ) ? self::$is_compatible : array( get_called_class() => (bool)self::$is_compatible );
215 215
 
216 216
 		if ( ! function_exists( 'gravityview' ) ) {
217 217
 			$message = sprintf( __( 'Could not activate the %s Extension; GravityView is not active.', 'gravityview' ), esc_html( $this->_title ) );
218
-		} else if ( false === version_compare( Plugin::$version, $this->_min_gravityview_version , ">=" ) ) {
219
-			$message = sprintf( __( 'The %s Extension requires GravityView Version %s or newer.', 'gravityview' ), esc_html( $this->_title ), '<tt>'.$this->_min_gravityview_version.'</tt>' );
220
-		} else if ( isset( $this->_min_php_version ) && false === version_compare( phpversion(), $this->_min_php_version , ">=" ) ) {
221
-			$message = sprintf( __( 'The %s Extension requires PHP Version %s or newer. Please ask your host to upgrade your server\'s PHP.', 'gravityview' ), esc_html( $this->_title ), '<tt>'.$this->_min_php_version.'</tt>' );
218
+		} else if ( false === version_compare( Plugin::$version, $this->_min_gravityview_version, ">=" ) ) {
219
+			$message = sprintf( __( 'The %s Extension requires GravityView Version %s or newer.', 'gravityview' ), esc_html( $this->_title ), '<tt>' . $this->_min_gravityview_version . '</tt>' );
220
+		} else if ( isset( $this->_min_php_version ) && false === version_compare( phpversion(), $this->_min_php_version, ">=" ) ) {
221
+			$message = sprintf( __( 'The %s Extension requires PHP Version %s or newer. Please ask your host to upgrade your server\'s PHP.', 'gravityview' ), esc_html( $this->_title ), '<tt>' . $this->_min_php_version . '</tt>' );
222 222
 		} else if ( ! empty( $this->_max_gravityview_version ) && false === version_compare( $this->_max_gravityview_version, Plugin::$version, ">" ) ) {
223 223
 			$message = sprintf( __( 'The %s Extension is not compatible with this version of GravityView. Please update the Extension to the latest version.', 'gravityview' ), esc_html( $this->_title ) );
224 224
 		} else {
@@ -258,12 +258,12 @@  discard block
 block discarded – undo
258 258
 
259 259
 		$locale = get_locale();
260 260
 
261
-		if ( function_exists('get_user_locale') && is_admin() ) {
261
+		if ( function_exists( 'get_user_locale' ) && is_admin() ) {
262 262
 			$locale = get_user_locale();
263 263
 		}
264 264
 
265 265
 		// Traditional WordPress plugin locale filter
266
-		$locale = apply_filters( 'plugin_locale',  $locale, $this->_text_domain );
266
+		$locale = apply_filters( 'plugin_locale', $locale, $this->_text_domain );
267 267
 
268 268
 		$mofile = sprintf( '%1$s-%2$s.mo', $this->_text_domain, $locale );
269 269
 
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 	public function settings() {
292 292
 
293 293
 		// If doing ajax, get outta here
294
-		if ( ! is_admin() || ( defined( 'DOING_AJAX' ) && DOING_AJAX && 'update-plugin' !== Utils::_POST('action') ) )  {
294
+		if ( ! is_admin() || ( defined( 'DOING_AJAX' ) && DOING_AJAX && 'update-plugin' !== Utils::_POST( 'action' ) ) ) {
295 295
 			return;
296 296
 		}
297 297
 
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
             	'version'	=> $this->_version, // current version number
309 309
             	'license'	=> \GV\Utils::get( $license, 'license_key', \GV\Utils::get( $license, 'license', null ) ),
310 310
 	            'item_id'   => $this->_item_id, // The ID of the download on _remote_update_url
311
-            	'item_name' => $this->_title,  // name of this plugin
311
+            	'item_name' => $this->_title, // name of this plugin
312 312
             	'author' 	=> strip_tags( $this->_author )  // author of this plugin
313 313
           	)
314 314
         );
@@ -337,16 +337,16 @@  discard block
 block discarded – undo
337 337
 	 */
338 338
 	public static function add_notice( $notice = array() ) {
339 339
 
340
-		if ( is_array( $notice ) && empty( $notice['message'] ) ) {
340
+		if ( is_array( $notice ) && empty( $notice[ 'message' ] ) ) {
341 341
 			gravityview()->log->error( 'Notice not set', array( 'data' => $notice ) );
342 342
 			return;
343 343
 		} else if ( is_string( $notice ) ) {
344 344
 			$notice = array( 'message' => $notice );
345 345
 		}
346 346
 
347
-		$notice['class'] = empty( $notice['class'] ) ? 'error' : $notice['class'];
347
+		$notice[ 'class' ] = empty( $notice[ 'class' ] ) ? 'error' : $notice[ 'class' ];
348 348
 
349
-		self::$admin_notices []= $notice;
349
+		self::$admin_notices [ ] = $notice;
350 350
 	}
351 351
 
352 352
 	/**
@@ -360,8 +360,8 @@  discard block
 block discarded – undo
360 360
 		}
361 361
 
362 362
 		foreach ( self::$admin_notices as $key => $notice ) {
363
-			echo '<div id="message" class="'. esc_attr( $notice['class'] ).'">';
364
-			echo wpautop( $notice['message'] );
363
+			echo '<div id="message" class="' . esc_attr( $notice[ 'class' ] ) . '">';
364
+			echo wpautop( $notice[ 'message' ] );
365 365
 			echo '<div class="clear"></div>';
366 366
 			echo '</div>';
367 367
 		}
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Spacing   +230 added lines, -230 removed lines patch added patch discarded remove patch
@@ -123,16 +123,16 @@  discard block
 block discarded – undo
123 123
 	function load() {
124 124
 
125 125
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
126
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
126
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
127 127
 
128 128
 		// Don't display an embedded form when editing an entry
129 129
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
130 130
 		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
131 131
 
132 132
 		// Stop Gravity Forms processing what is ours!
133
-		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
133
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
134 134
 
135
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
135
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
136 136
 
137 137
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
138 138
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
144 144
 
145 145
 		// Add fields expected by GFFormDisplay::validate()
146
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
146
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
147 147
 
148 148
 		// Fix multiselect value for GF 2.2
149 149
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	 * @return void
161 161
 	 */
162 162
 	public function prevent_render_form() {
163
-		if( $this->is_edit_entry() ) {
164
-			if( 'wp_head' === current_filter() ) {
163
+		if ( $this->is_edit_entry() ) {
164
+			if ( 'wp_head' === current_filter() ) {
165 165
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
166 166
 			} else {
167 167
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -176,14 +176,14 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179
-	    if( ! $this->is_edit_entry_submission() ) {
179
+	    if ( ! $this->is_edit_entry_submission() ) {
180 180
 			return;
181 181
 		}
182 182
 
183 183
 		gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] Removing GFForms::maybe_process_form() action.' );
184 184
 
185
-		remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
186
-		remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
185
+		remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
186
+		remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
187 187
 	}
188 188
 
189 189
 	/**
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function is_edit_entry() {
194 194
 
195
-		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET['edit'] );
195
+		$is_edit_entry = GravityView_frontend::is_single_entry() && ! empty( $_GET[ 'edit' ] );
196 196
 
197 197
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
198 198
 	}
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @return boolean
204 204
 	 */
205 205
 	public function is_edit_entry_submission() {
206
-		return !empty( $_POST[ self::$nonce_field ] );
206
+		return ! empty( $_POST[ self::$nonce_field ] );
207 207
 	}
208 208
 
209 209
 	/**
@@ -216,16 +216,16 @@  discard block
 block discarded – undo
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+	    self::$original_entry = $entries[ 0 ];
220
+	    $this->entry = $entries[ 0 ];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
224
-		$this->form_id = $this->entry['form_id'];
224
+		$this->form_id = $this->entry[ 'form_id' ];
225 225
 		$this->view_id = $gravityview_view->getViewId();
226 226
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
227 227
 
228
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
228
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
229 229
 	}
230 230
 
231 231
 
@@ -284,9 +284,9 @@  discard block
 block discarded – undo
284 284
 	private function print_scripts() {
285 285
 		$gravityview_view = GravityView_View::getInstance();
286 286
 
287
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
287
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
288 288
 
289
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
289
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
290 290
 
291 291
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
292 292
 
@@ -302,19 +302,19 @@  discard block
 block discarded – undo
302 302
 	 */
303 303
 	private function process_save( $gv_data ) {
304 304
 
305
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
305
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
306 306
 			return;
307 307
 		}
308 308
 
309 309
 		// Make sure the entry, view, and form IDs are all correct
310 310
 		$valid = $this->verify_nonce();
311 311
 
312
-		if ( !$valid ) {
312
+		if ( ! $valid ) {
313 313
 			gravityview()->log->error( 'Nonce validation failed.' );
314 314
 			return;
315 315
 		}
316 316
 
317
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
317
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
318 318
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
319 319
 			return;
320 320
 		}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$this->validate();
327 327
 
328
-		if( $this->is_valid ) {
328
+		if ( $this->is_valid ) {
329 329
 
330 330
 			gravityview()->log->debug( 'Submission is valid.' );
331 331
 
@@ -337,15 +337,15 @@  discard block
 block discarded – undo
337 337
 			/**
338 338
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
339 339
 			 */
340
-			unset( $_GET['page'] );
340
+			unset( $_GET[ 'page' ] );
341 341
 
342
-			$date_created = $this->entry['date_created'];
342
+			$date_created = $this->entry[ 'date_created' ];
343 343
 
344 344
 			/**
345 345
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
346 346
 			 * @since 1.17.2
347 347
 			 */
348
-			unset( $this->entry['date_created'] );
348
+			unset( $this->entry[ 'date_created' ] );
349 349
 
350 350
 			/**
351 351
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -355,14 +355,14 @@  discard block
 block discarded – undo
355 355
 			 * @param GravityView_Edit_Entry_Render $this This object
356 356
 			 * @param GravityView_View_Data $gv_data The View data
357 357
 			 */
358
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
358
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362 362
 	        // Delete the values for hidden inputs
363 363
 	        $this->unset_hidden_field_values();
364 364
 			
365
-			$this->entry['date_created'] = $date_created;
365
+			$this->entry[ 'date_created' ] = $date_created;
366 366
 
367 367
 			// Process calculation fields
368 368
 			$this->update_calculation_fields();
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
385 385
 			 * @param GravityView_View_Data $gv_data The View data
386 386
 			 */
387
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
387
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
388 388
 
389 389
 		} else {
390 390
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -412,16 +412,16 @@  discard block
 block discarded – undo
412 412
 		 */
413 413
 		$unset_hidden_field_values = apply_filters( 'gravityview/edit_entry/unset_hidden_field_values', true, $this );
414 414
 
415
-		if( ! $unset_hidden_field_values ) {
415
+		if ( ! $unset_hidden_field_values ) {
416 416
 			return;
417 417
 		}
418 418
 
419 419
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
420 420
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
421
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
421
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
422 422
 		} else {
423 423
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
424
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
424
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
425 425
 		}
426 426
 
427 427
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437
-					$this->form, '', $this->entry['id'], $this->entry
437
+					$this->form, '', $this->entry[ 'id' ], $this->entry
438 438
 				);
439 439
 
440 440
 			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 		}
505 505
 
506 506
 		/** No file is being uploaded. */
507
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
507
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
508 508
 			/** So return the original upload */
509 509
 			return $entry[ $input_id ];
510 510
 		}
@@ -522,11 +522,11 @@  discard block
 block discarded – undo
522 522
 	 * @return mixed
523 523
 	 */
524 524
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
525
-		if( ! $this->is_edit_entry() ) {
525
+		if ( ! $this->is_edit_entry() ) {
526 526
 			return $plupload_init;
527 527
 		}
528 528
 
529
-		$plupload_init['gf_vars']['max_files'] = 0;
529
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
530 530
 
531 531
 		return $plupload_init;
532 532
 	}
@@ -541,27 +541,27 @@  discard block
 block discarded – undo
541 541
 		$form = $this->filter_conditional_logic( $this->form );
542 542
 
543 543
 	    /** @var GF_Field $field */
544
-		foreach( $form['fields'] as $k => &$field ) {
544
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
545 545
 
546 546
 			/**
547 547
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
548 548
 			 * @since 1.16.3
549 549
 			 * @var GF_Field $field
550 550
 			 */
551
-			if( $field->has_calculation() ) {
552
-				unset( $form['fields'][ $k ] );
551
+			if ( $field->has_calculation() ) {
552
+				unset( $form[ 'fields' ][ $k ] );
553 553
 			}
554 554
 
555 555
 			$field->adminOnly = false;
556 556
 
557
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
-				foreach( $field->inputs as $key => $input ) {
559
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
557
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
558
+				foreach ( $field->inputs as $key => $input ) {
559
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
560 560
 				}
561 561
 			}
562 562
 		}
563 563
 
564
-		$form['fields'] = array_values( $form['fields'] );
564
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
565 565
 
566 566
 		return $form;
567 567
 	}
@@ -573,14 +573,14 @@  discard block
 block discarded – undo
573 573
 		$update = false;
574 574
 
575 575
 		// get the most up to date entry values
576
-		$entry = GFAPI::get_entry( $this->entry['id'] );
576
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
577 577
 
578 578
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
579 579
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
580
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
580
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
581 581
 		} else {
582 582
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
583
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
583
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
584 584
 		}
585 585
 
586 586
 
@@ -592,24 +592,24 @@  discard block
 block discarded – undo
592 592
 				$inputs = $field->get_entry_inputs();
593 593
 				if ( is_array( $inputs ) ) {
594 594
 				    foreach ( $inputs as $input ) {
595
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
595
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
596 596
 
597 597
 						if ( 'product' === $field->type ) {
598
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
598
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
599 599
 
600 600
 							// Only allow quantity to be set if it's allowed to be edited
601 601
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
602 602
 							} else { // otherwise set to what it previously was
603
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
603
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
604 604
 							}
605 605
 						} else {
606 606
 							// Set to what it previously was if it's not editable
607 607
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
608
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
608
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
609 609
 							}
610 610
 						}
611 611
 
612
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
612
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
613 613
 				    }
614 614
 				} else {
615 615
 					// Set to what it previously was if it's not editable
@@ -649,19 +649,19 @@  discard block
 block discarded – undo
649 649
 
650 650
 		$input_name = 'input_' . $field_id;
651 651
 
652
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
652
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
653 653
 
654 654
 			// We have a new image
655 655
 
656
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
656
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
657 657
 
658 658
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
659 659
 	        $ary = stripslashes_deep( $ary );
660 660
 			$img_url = \GV\Utils::get( $ary, 0 );
661 661
 
662
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
663
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
664
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
662
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
663
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
664
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
665 665
 
666 666
 			$image_meta = array(
667 667
 				'post_excerpt' => $img_caption,
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
 
671 671
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
672 672
 			if ( ! empty( $img_title ) ) {
673
-				$image_meta['post_title'] = $img_title;
673
+				$image_meta[ 'post_title' ] = $img_title;
674 674
 			}
675 675
 
676 676
 			/**
@@ -728,15 +728,15 @@  discard block
 block discarded – undo
728 728
 	 */
729 729
 	private function maybe_update_post_fields( $form ) {
730 730
 
731
-		if( empty( $this->entry['post_id'] ) ) {
731
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
732 732
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
733 733
 			return;
734 734
 		}
735 735
 
736
-		$post_id = $this->entry['post_id'];
736
+		$post_id = $this->entry[ 'post_id' ];
737 737
 
738 738
 		// Security check
739
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
739
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
740 740
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
741 741
 			return;
742 742
 		}
@@ -749,25 +749,25 @@  discard block
 block discarded – undo
749 749
 
750 750
 			$field = RGFormsModel::get_field( $form, $field_id );
751 751
 
752
-			if( ! $field ) {
752
+			if ( ! $field ) {
753 753
 				continue;
754 754
 			}
755 755
 
756
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
756
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
757 757
 
758 758
 				// Get the value of the field, including $_POSTed value
759 759
 				$value = RGFormsModel::get_field_value( $field );
760 760
 
761 761
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
762 762
 				$entry_tmp = $this->entry;
763
-				$entry_tmp["{$field_id}"] = $value;
763
+				$entry_tmp[ "{$field_id}" ] = $value;
764 764
 
765
-				switch( $field->type ) {
765
+				switch ( $field->type ) {
766 766
 
767 767
 				    case 'post_title':
768 768
 				        $post_title = $value;
769 769
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
770
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
770
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
771 771
 				        }
772 772
 				        $updated_post->post_title = $post_title;
773 773
 				        $updated_post->post_name  = $post_title;
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
 				    case 'post_content':
778 778
 				        $post_content = $value;
779 779
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
780
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
780
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
781 781
 				        }
782 782
 				        $updated_post->post_content = $post_content;
783 783
 				        unset( $post_content );
@@ -795,11 +795,11 @@  discard block
 block discarded – undo
795 795
 							$value = $value[ $field_id ];
796 796
 						}
797 797
 
798
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
798
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
799 799
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
800 800
 				        }
801 801
 
802
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
802
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
803 803
 
804 804
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
805 805
 				        break;
@@ -811,7 +811,7 @@  discard block
 block discarded – undo
811 811
 				}
812 812
 
813 813
 				// update entry after
814
-				$this->entry["{$field_id}"] = $value;
814
+				$this->entry[ "{$field_id}" ] = $value;
815 815
 
816 816
 				$update_entry = true;
817 817
 
@@ -820,11 +820,11 @@  discard block
 block discarded – undo
820 820
 
821 821
 		}
822 822
 
823
-		if( $update_entry ) {
823
+		if ( $update_entry ) {
824 824
 
825 825
 			$return_entry = GFAPI::update_entry( $this->entry );
826 826
 
827
-			if( is_wp_error( $return_entry ) ) {
827
+			if ( is_wp_error( $return_entry ) ) {
828 828
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
829 829
 			} else {
830 830
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -834,7 +834,7 @@  discard block
 block discarded – undo
834 834
 
835 835
 		$return_post = wp_update_post( $updated_post, true );
836 836
 
837
-		if( is_wp_error( $return_post ) ) {
837
+		if ( is_wp_error( $return_post ) ) {
838 838
 			$return_post->add_data( $updated_post, '$updated_post' );
839 839
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
840 840
 		} else {
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
869 869
 
870 870
 		// replace conditional shortcodes
871
-		if( $do_shortcode ) {
871
+		if ( $do_shortcode ) {
872 872
 			$output = do_shortcode( $output );
873 873
 		}
874 874
 
@@ -887,19 +887,19 @@  discard block
 block discarded – undo
887 887
 	 */
888 888
 	private function after_update() {
889 889
 
890
-		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'], self::$original_entry );
891
-		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'], self::$original_entry );
890
+		do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ], self::$original_entry );
891
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ], self::$original_entry );
892 892
 
893 893
 		// Re-define the entry now that we've updated it.
894
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
894
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
895 895
 
896 896
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
897 897
 
898 898
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
899 899
 			// We need to clear the cache because Gravity Forms caches the field values, which
900 900
 			// we have just updated.
901
-			foreach ($this->form['fields'] as $key => $field) {
902
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
901
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
902
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
903 903
 			}
904 904
 		}
905 905
 
@@ -909,11 +909,11 @@  discard block
 block discarded – undo
909 909
 		 * @since develop
910 910
 		 */
911 911
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
912
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
912
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
913 913
 			if ( ! is_wp_error( $feeds ) ) {
914 914
 				$registered_feeds = array();
915 915
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
916
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
916
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
917 917
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
918 918
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
919 919
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -921,8 +921,8 @@  discard block
 block discarded – undo
921 921
 					}
922 922
 				}
923 923
 				foreach ( $feeds as $feed ) {
924
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
925
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
924
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
925
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
926 926
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
927 927
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
928 928
 								$entry = $returned_entry;
@@ -952,7 +952,7 @@  discard block
 block discarded – undo
952 952
 
953 953
 		<div class="gv-edit-entry-wrapper"><?php
954 954
 
955
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
955
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
956 956
 
957 957
 			/**
958 958
 			 * Fixes weird wpautop() issue
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
969 969
 				     * @param GravityView_Edit_Entry_Render $this This object
970 970
 				     */
971
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
971
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
972 972
 
973 973
 				    echo esc_attr( $edit_entry_title );
974 974
 			?></span>
@@ -1018,13 +1018,13 @@  discard block
 block discarded – undo
1018 1018
 
1019 1019
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1020 1020
 
1021
-			if( ! $this->is_valid ){
1021
+			if ( ! $this->is_valid ) {
1022 1022
 
1023 1023
 				// Keeping this compatible with Gravity Forms.
1024
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1025
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1024
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1025
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1026 1026
 
1027
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1027
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1028 1028
 
1029 1029
 			} else {
1030 1030
 				$view = \GV\View::by_id( $this->view_id );
@@ -1035,23 +1035,23 @@  discard block
 block discarded – undo
1035 1035
 
1036 1036
                     case '0':
1037 1037
 	                    $redirect_url = $back_link;
1038
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1038
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1039 1039
                         break;
1040 1040
 
1041 1041
                     case '1':
1042 1042
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1043
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1043
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1044 1044
 	                    break;
1045 1045
 
1046 1046
                     case '2':
1047 1047
 	                    $redirect_url = $edit_redirect_url;
1048 1048
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1049
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1049
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1050 1050
                         break;
1051 1051
 
1052 1052
                     case '':
1053 1053
                     default:
1054
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1054
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1055 1055
                         break;
1056 1056
 				}
1057 1057
 
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 				 * @param array $entry Gravity Forms entry array
1068 1068
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1069 1069
 				 */
1070
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1070
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1071 1071
 
1072 1072
 				echo GVCommon::generate_notice( $message );
1073 1073
 			}
@@ -1091,21 +1091,21 @@  discard block
 block discarded – undo
1091 1091
 		 */
1092 1092
 		do_action( 'gravityview/edit-entry/render/before', $this );
1093 1093
 
1094
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1095
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1094
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1095
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1096 1096
 		add_filter( 'gform_disable_view_counter', '__return_true' );
1097 1097
 
1098 1098
 		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
1099 1099
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1100 1100
 
1101 1101
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1102
-		unset( $_GET['page'] );
1102
+		unset( $_GET[ 'page' ] );
1103 1103
 
1104 1104
 		// TODO: Verify multiple-page forms
1105 1105
 
1106 1106
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1107 1107
 
1108
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1108
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1109 1109
 
1110 1110
 		ob_get_clean();
1111 1111
 
@@ -1131,7 +1131,7 @@  discard block
 block discarded – undo
1131 1131
 	 * @return string
1132 1132
 	 */
1133 1133
 	public function render_form_buttons() {
1134
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1134
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1135 1135
 	}
1136 1136
 
1137 1137
 
@@ -1151,10 +1151,10 @@  discard block
 block discarded – undo
1151 1151
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1152 1152
 
1153 1153
 		// In case we have validated the form, use it to inject the validation results into the form render
1154
-		if( isset( $this->form_after_validation ) ) {
1154
+		if ( isset( $this->form_after_validation ) ) {
1155 1155
 			$form = $this->form_after_validation;
1156 1156
 		} else {
1157
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1157
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1158 1158
 		}
1159 1159
 
1160 1160
 		$form = $this->filter_conditional_logic( $form );
@@ -1162,8 +1162,8 @@  discard block
 block discarded – undo
1162 1162
 		$form = $this->prefill_conditional_logic( $form );
1163 1163
 
1164 1164
 		// for now we don't support Save and Continue feature.
1165
-		if( ! self::$supports_save_and_continue ) {
1166
-	        unset( $form['save'] );
1165
+		if ( ! self::$supports_save_and_continue ) {
1166
+	        unset( $form[ 'save' ] );
1167 1167
 		}
1168 1168
 
1169 1169
 		$form = $this->unselect_default_values( $form );
@@ -1186,31 +1186,31 @@  discard block
 block discarded – undo
1186 1186
 	 */
1187 1187
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1188 1188
 
1189
-		if( ! GFCommon::is_post_field( $field ) ) {
1189
+		if ( ! GFCommon::is_post_field( $field ) ) {
1190 1190
 			return $field_content;
1191 1191
 		}
1192 1192
 
1193 1193
         $message = null;
1194 1194
 
1195 1195
         // First, make sure they have the capability to edit the post.
1196
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1196
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1197 1197
 
1198 1198
             /**
1199 1199
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1200 1200
              * @param string $message The existing "You don't have permission..." text
1201 1201
              */
1202
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1202
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1203 1203
 
1204
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1204
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1205 1205
             /**
1206 1206
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1207 1207
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1208 1208
              */
1209
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1209
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1210 1210
         }
1211 1211
 
1212
-        if( $message ) {
1213
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1212
+        if ( $message ) {
1213
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1214 1214
         }
1215 1215
 
1216 1216
         return $field_content;
@@ -1234,8 +1234,8 @@  discard block
 block discarded – undo
1234 1234
 
1235 1235
 		// If the form has been submitted, then we don't need to pre-fill the values,
1236 1236
 		// Except for fileupload type and when a field input is overridden- run always!!
1237
-		if(
1238
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1237
+		if (
1238
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1239 1239
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1240 1240
 			&& ! GFCommon::is_product_field( $field->type )
1241 1241
 			|| ! empty( $field_content )
@@ -1255,7 +1255,7 @@  discard block
 block discarded – undo
1255 1255
 	    $return = null;
1256 1256
 
1257 1257
 		/** @var GravityView_Field $gv_field */
1258
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1258
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1259 1259
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1260 1260
 		} else {
1261 1261
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1264,7 +1264,7 @@  discard block
 block discarded – undo
1264 1264
 	    // If there was output, it's an error
1265 1265
 	    $warnings = ob_get_clean();
1266 1266
 
1267
-	    if( !empty( $warnings ) ) {
1267
+	    if ( ! empty( $warnings ) ) {
1268 1268
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1269 1269
 	    }
1270 1270
 
@@ -1289,7 +1289,7 @@  discard block
 block discarded – undo
1289 1289
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1290 1290
 
1291 1291
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1292
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1292
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1293 1293
 
1294 1294
 			$field_value = array();
1295 1295
 
@@ -1298,10 +1298,10 @@  discard block
 block discarded – undo
1298 1298
 
1299 1299
 			foreach ( (array)$field->inputs as $input ) {
1300 1300
 
1301
-				$input_id = strval( $input['id'] );
1301
+				$input_id = strval( $input[ 'id' ] );
1302 1302
 
1303 1303
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1304
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1304
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1305 1305
 				    $allow_pre_populated = false;
1306 1306
 				}
1307 1307
 
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 
1310 1310
 			$pre_value = $field->get_value_submission( array(), false );
1311 1311
 
1312
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1312
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1313 1313
 
1314 1314
 		} else {
1315 1315
 
@@ -1320,13 +1320,13 @@  discard block
 block discarded – undo
1320 1320
 
1321 1321
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1322 1322
 			// or pre-populated value if not empty and set to override saved value
1323
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1323
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1324 1324
 
1325 1325
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1326
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1326
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1327 1327
 				$categories = array();
1328 1328
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1329
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1329
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1330 1330
 				}
1331 1331
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1332 1332
 			}
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
 	     * @param GF_Field $field Gravity Forms field object
1355 1355
 	     * @param GravityView_Edit_Entry_Render $this Current object
1356 1356
 	     */
1357
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1357
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1358 1358
 
1359 1359
 		return $field_value;
1360 1360
 	}
@@ -1371,12 +1371,12 @@  discard block
 block discarded – undo
1371 1371
 	 */
1372 1372
 	public function gform_pre_validation( $form ) {
1373 1373
 
1374
-		if( ! $this->verify_nonce() ) {
1374
+		if ( ! $this->verify_nonce() ) {
1375 1375
 			return $form;
1376 1376
 		}
1377 1377
 
1378 1378
 		// Fix PHP warning regarding undefined index.
1379
-		foreach ( $form['fields'] as &$field) {
1379
+		foreach ( $form[ 'fields' ] as &$field ) {
1380 1380
 
1381 1381
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1382 1382
 			// expects certain field array items to be set.
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1385 1385
 			}
1386 1386
 
1387
-			switch( RGFormsModel::get_input_type( $field ) ) {
1387
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1388 1388
 
1389 1389
 				/**
1390 1390
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1398,26 +1398,26 @@  discard block
 block discarded – undo
1398 1398
 				    // Set the previous value
1399 1399
 				    $entry = $this->get_entry();
1400 1400
 
1401
-				    $input_name = 'input_'.$field->id;
1402
-				    $form_id = $form['id'];
1401
+				    $input_name = 'input_' . $field->id;
1402
+				    $form_id = $form[ 'id' ];
1403 1403
 
1404 1404
 				    $value = NULL;
1405 1405
 
1406 1406
 				    // Use the previous entry value as the default.
1407
-				    if( isset( $entry[ $field->id ] ) ) {
1407
+				    if ( isset( $entry[ $field->id ] ) ) {
1408 1408
 				        $value = $entry[ $field->id ];
1409 1409
 				    }
1410 1410
 
1411 1411
 				    // If this is a single upload file
1412
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1413
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1414
-				        $value = $file_path['url'];
1412
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1413
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1414
+				        $value = $file_path[ 'url' ];
1415 1415
 
1416 1416
 				    } else {
1417 1417
 
1418 1418
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1419 1419
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1420
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1420
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1421 1421
 
1422 1422
 				    }
1423 1423
 
@@ -1425,10 +1425,10 @@  discard block
 block discarded – undo
1425 1425
 
1426 1426
 				        // If there are fresh uploads, process and merge them.
1427 1427
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1428
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1428
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1429 1429
 				            $value = empty( $value ) ? '[]' : $value;
1430 1430
 				            $value = stripslashes_deep( $value );
1431
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1431
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1432 1432
 				        }
1433 1433
 
1434 1434
 				    } else {
@@ -1446,8 +1446,8 @@  discard block
 block discarded – undo
1446 1446
 
1447 1447
 				case 'number':
1448 1448
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1449
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1450
-				        $_POST['input_'.$field->id ] = NULL;
1449
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1450
+				        $_POST[ 'input_' . $field->id ] = NULL;
1451 1451
 				    }
1452 1452
 				    break;
1453 1453
 			}
@@ -1484,7 +1484,7 @@  discard block
 block discarded – undo
1484 1484
 		 * You can enter whatever you want!
1485 1485
 		 * We try validating, and customize the results using `self::custom_validation()`
1486 1486
 		 */
1487
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1487
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1488 1488
 
1489 1489
 		// Needed by the validate funtion
1490 1490
 		$failed_validation_page = NULL;
@@ -1492,14 +1492,14 @@  discard block
 block discarded – undo
1492 1492
 
1493 1493
 		// Prevent entry limit from running when editing an entry, also
1494 1494
 		// prevent form scheduling from preventing editing
1495
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1495
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1496 1496
 
1497 1497
 		// Hide fields depending on Edit Entry settings
1498
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1498
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1499 1499
 
1500 1500
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1501 1501
 
1502
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1502
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1503 1503
 	}
1504 1504
 
1505 1505
 
@@ -1522,7 +1522,7 @@  discard block
 block discarded – undo
1522 1522
 
1523 1523
 		$gv_valid = true;
1524 1524
 
1525
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1525
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1526 1526
 
1527 1527
 			$value = RGFormsModel::get_field_value( $field );
1528 1528
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1535,22 +1535,22 @@  discard block
 block discarded – undo
1535 1535
 				case 'post_image':
1536 1536
 
1537 1537
 				    // in case nothing is uploaded but there are already files saved
1538
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1538
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1539 1539
 				        $field->failed_validation = false;
1540 1540
 				        unset( $field->validation_message );
1541 1541
 				    }
1542 1542
 
1543 1543
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1544
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1544
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1545 1545
 
1546 1546
 				        $input_name = 'input_' . $field->id;
1547 1547
 				        //uploaded
1548
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1548
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1549 1549
 
1550 1550
 				        //existent
1551 1551
 				        $entry = $this->get_entry();
1552 1552
 				        $value = NULL;
1553
-				        if( isset( $entry[ $field->id ] ) ) {
1553
+				        if ( isset( $entry[ $field->id ] ) ) {
1554 1554
 				            $value = json_decode( $entry[ $field->id ], true );
1555 1555
 				        }
1556 1556
 
@@ -1558,13 +1558,13 @@  discard block
 block discarded – undo
1558 1558
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1559 1559
 						               ( is_array( $value ) ? count( $value ) : 0 );
1560 1560
 
1561
-				        if( $count_files > $field->maxFiles ) {
1561
+				        if ( $count_files > $field->maxFiles ) {
1562 1562
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1563 1563
 				            $field->failed_validation = 1;
1564 1564
 				            $gv_valid = false;
1565 1565
 
1566 1566
 				            // in case of error make sure the newest upload files are removed from the upload input
1567
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1567
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1568 1568
 				        }
1569 1569
 
1570 1570
 				    }
@@ -1575,7 +1575,7 @@  discard block
 block discarded – undo
1575 1575
 			}
1576 1576
 
1577 1577
 			// This field has failed validation.
1578
-			if( !empty( $field->failed_validation ) ) {
1578
+			if ( ! empty( $field->failed_validation ) ) {
1579 1579
 
1580 1580
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1581 1581
 
@@ -1593,19 +1593,19 @@  discard block
 block discarded – undo
1593 1593
 				}
1594 1594
 
1595 1595
 				// You can't continue inside a switch, so we do it after.
1596
-				if( empty( $field->failed_validation ) ) {
1596
+				if ( empty( $field->failed_validation ) ) {
1597 1597
 				    continue;
1598 1598
 				}
1599 1599
 
1600 1600
 				// checks if the No Duplicates option is not validating entry against itself, since
1601 1601
 				// we're editing a stored entry, it would also assume it's a duplicate.
1602
-				if( !empty( $field->noDuplicates ) ) {
1602
+				if ( ! empty( $field->noDuplicates ) ) {
1603 1603
 
1604 1604
 				    $entry = $this->get_entry();
1605 1605
 
1606 1606
 				    // If the value of the entry is the same as the stored value
1607 1607
 				    // Then we can assume it's not a duplicate, it's the same.
1608
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1608
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1609 1609
 				        //if value submitted was not changed, then don't validate
1610 1610
 				        $field->failed_validation = false;
1611 1611
 
@@ -1618,7 +1618,7 @@  discard block
 block discarded – undo
1618 1618
 				}
1619 1619
 
1620 1620
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1621
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1621
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1622 1622
 				    unset( $field->validation_message );
1623 1623
 	                $field->validation_message = false;
1624 1624
 				    continue;
@@ -1630,12 +1630,12 @@  discard block
 block discarded – undo
1630 1630
 
1631 1631
 		}
1632 1632
 
1633
-		$validation_results['is_valid'] = $gv_valid;
1633
+		$validation_results[ 'is_valid' ] = $gv_valid;
1634 1634
 
1635 1635
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1636 1636
 
1637 1637
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1638
-		$this->form_after_validation = $validation_results['form'];
1638
+		$this->form_after_validation = $validation_results[ 'form' ];
1639 1639
 
1640 1640
 		return $validation_results;
1641 1641
 	}
@@ -1648,7 +1648,7 @@  discard block
 block discarded – undo
1648 1648
 	 */
1649 1649
 	public function get_entry() {
1650 1650
 
1651
-		if( empty( $this->entry ) ) {
1651
+		if ( empty( $this->entry ) ) {
1652 1652
 			// Get the database value of the entry that's being edited
1653 1653
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1654 1654
 		}
@@ -1680,10 +1680,10 @@  discard block
 block discarded – undo
1680 1680
 		}
1681 1681
 
1682 1682
 		// If edit tab not yet configured, show all fields
1683
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1683
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1684 1684
 
1685 1685
 		// Hide fields depending on admin settings
1686
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1686
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1687 1687
 
1688 1688
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1689 1689
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1715,7 +1715,7 @@  discard block
 block discarded – undo
1715 1715
 	 */
1716 1716
 	private function filter_fields( $fields, $configured_fields ) {
1717 1717
 
1718
-		if( empty( $fields ) || !is_array( $fields ) ) {
1718
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1719 1719
 			return $fields;
1720 1720
 		}
1721 1721
 
@@ -1728,18 +1728,18 @@  discard block
 block discarded – undo
1728 1728
 
1729 1729
 			// Remove the fields that have calculation properties and keep them to be used later
1730 1730
 			// @since 1.16.2
1731
-			if( $field->has_calculation() ) {
1732
-				$this->fields_with_calculation[] = $field;
1731
+			if ( $field->has_calculation() ) {
1732
+				$this->fields_with_calculation[ ] = $field;
1733 1733
 				// don't remove the calculation fields on form render.
1734 1734
 			}
1735 1735
 
1736
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1736
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1737 1737
 				unset( $fields[ $key ] );
1738 1738
 			}
1739 1739
 		}
1740 1740
 
1741 1741
 		// The Edit tab has not been configured, so we return all fields by default.
1742
-		if( empty( $configured_fields ) ) {
1742
+		if ( empty( $configured_fields ) ) {
1743 1743
 			return array_values( $fields );
1744 1744
 		}
1745 1745
 
@@ -1748,8 +1748,8 @@  discard block
 block discarded – undo
1748 1748
 
1749 1749
 	        /** @var GF_Field $field */
1750 1750
 	        foreach ( $fields as $field ) {
1751
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1752
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1751
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1752
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1753 1753
 				    break;
1754 1754
 				}
1755 1755
 
@@ -1772,14 +1772,14 @@  discard block
 block discarded – undo
1772 1772
 
1773 1773
 		$return_field = $field;
1774 1774
 
1775
-		if( empty( $field_setting['show_label'] ) ) {
1775
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1776 1776
 			$return_field->label = '';
1777
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1778
-			$return_field->label = $field_setting['custom_label'];
1777
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1778
+			$return_field->label = $field_setting[ 'custom_label' ];
1779 1779
 		}
1780 1780
 
1781
-		if( !empty( $field_setting['custom_class'] ) ) {
1782
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1781
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1782
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1783 1783
 		}
1784 1784
 
1785 1785
 		/**
@@ -1817,16 +1817,16 @@  discard block
 block discarded – undo
1817 1817
 	     */
1818 1818
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1819 1819
 
1820
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1821
-			foreach( $fields as $k => $field ) {
1822
-				if( $field->adminOnly ) {
1820
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1821
+			foreach ( $fields as $k => $field ) {
1822
+				if ( $field->adminOnly ) {
1823 1823
 				    unset( $fields[ $k ] );
1824 1824
 				}
1825 1825
 			}
1826 1826
 			return array_values( $fields );
1827 1827
 		}
1828 1828
 
1829
-	    foreach( $fields as &$field ) {
1829
+	    foreach ( $fields as &$field ) {
1830 1830
 		    $field->adminOnly = false;
1831 1831
 		}
1832 1832
 
@@ -1847,7 +1847,7 @@  discard block
 block discarded – undo
1847 1847
 	 */
1848 1848
 	private function unselect_default_values( $form ) {
1849 1849
 
1850
-	    foreach ( $form['fields'] as &$field ) {
1850
+	    foreach ( $form[ 'fields' ] as &$field ) {
1851 1851
 
1852 1852
 			if ( empty( $field->choices ) ) {
1853 1853
                 continue;
@@ -1855,7 +1855,7 @@  discard block
 block discarded – undo
1855 1855
 
1856 1856
             foreach ( $field->choices as &$choice ) {
1857 1857
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1858
-					$choice['isSelected'] = false;
1858
+					$choice[ 'isSelected' ] = false;
1859 1859
 				}
1860 1860
 			}
1861 1861
 		}
@@ -1880,22 +1880,22 @@  discard block
 block discarded – undo
1880 1880
 	 */
1881 1881
 	function prefill_conditional_logic( $form ) {
1882 1882
 
1883
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1883
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
1884 1884
 			return $form;
1885 1885
 		}
1886 1886
 
1887 1887
 		// Have Conditional Logic pre-fill fields as if the data were default values
1888 1888
 		/** @var GF_Field $field */
1889
-		foreach ( $form['fields'] as &$field ) {
1889
+		foreach ( $form[ 'fields' ] as &$field ) {
1890 1890
 
1891
-			if( 'checkbox' === $field->type ) {
1891
+			if ( 'checkbox' === $field->type ) {
1892 1892
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1893
-				    $input_id = $input['id'];
1893
+				    $input_id = $input[ 'id' ];
1894 1894
 				    $choice = $field->choices[ $key ];
1895 1895
 				    $value = \GV\Utils::get( $this->entry, $input_id );
1896 1896
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1897
-				    if( $match ) {
1898
-				        $field->choices[ $key ]['isSelected'] = true;
1897
+				    if ( $match ) {
1898
+				        $field->choices[ $key ][ 'isSelected' ] = true;
1899 1899
 				    }
1900 1900
 				}
1901 1901
 			} else {
@@ -1903,15 +1903,15 @@  discard block
 block discarded – undo
1903 1903
 				// We need to run through each field to set the default values
1904 1904
 				foreach ( $this->entry as $field_id => $field_value ) {
1905 1905
 
1906
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1906
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
1907 1907
 
1908
-				        if( 'list' === $field->type ) {
1908
+				        if ( 'list' === $field->type ) {
1909 1909
 				            $list_rows = maybe_unserialize( $field_value );
1910 1910
 
1911 1911
 				            $list_field_value = array();
1912
-				            foreach ( (array) $list_rows as $row ) {
1913
-				                foreach ( (array) $row as $column ) {
1914
-				                    $list_field_value[] = $column;
1912
+				            foreach ( (array)$list_rows as $row ) {
1913
+				                foreach ( (array)$row as $column ) {
1914
+				                    $list_field_value[ ] = $column;
1915 1915
 				                }
1916 1916
 				            }
1917 1917
 
@@ -1944,32 +1944,32 @@  discard block
 block discarded – undo
1944 1944
 		 * @see https://github.com/gravityview/GravityView/issues/840
1945 1945
 		 * @since develop
1946 1946
 		 */
1947
-		$the_form = GFAPI::get_form( $form['id'] );
1947
+		$the_form = GFAPI::get_form( $form[ 'id' ] );
1948 1948
 		$editable_ids = array();
1949
-		foreach ( $form['fields'] as $field ) {
1950
-			$editable_ids[] = $field['id']; // wp_list_pluck is destructive in this context
1949
+		foreach ( $form[ 'fields' ] as $field ) {
1950
+			$editable_ids[ ] = $field[ 'id' ]; // wp_list_pluck is destructive in this context
1951 1951
 		}
1952 1952
 		$remove_conditions_rule = array();
1953
-		foreach ( $the_form['fields'] as $field ) {
1954
-			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic['rules'] ) ) {
1955
-				foreach ( $field->conditionalLogic['rules'] as $i => $rule ) {
1956
-					if ( ! in_array( $rule['fieldId'], $editable_ids ) ) {
1953
+		foreach ( $the_form[ 'fields' ] as $field ) {
1954
+			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic[ 'rules' ] ) ) {
1955
+				foreach ( $field->conditionalLogic[ 'rules' ] as $i => $rule ) {
1956
+					if ( ! in_array( $rule[ 'fieldId' ], $editable_ids ) ) {
1957 1957
 						/**
1958 1958
 						 * This conditional field is not editable in this View.
1959 1959
 						 * We need to remove the rule, but only if it matches.
1960 1960
 						 */
1961
-						if ( $_field = GFAPI::get_field( $the_form, $rule['fieldId'] ) ) {
1961
+						if ( $_field = GFAPI::get_field( $the_form, $rule[ 'fieldId' ] ) ) {
1962 1962
 							$value = $_field->get_value_export( $this->entry );
1963
-						} elseif ( isset( $this->entry[ $rule['fieldId'] ] ) ) {
1964
-							$value = $this->entry[ $rule['fieldId'] ];
1963
+						} elseif ( isset( $this->entry[ $rule[ 'fieldId' ] ] ) ) {
1964
+							$value = $this->entry[ $rule[ 'fieldId' ] ];
1965 1965
 						} else {
1966
-							$value = gform_get_meta( $this->entry['id'], $rule['fieldId'] );
1966
+							$value = gform_get_meta( $this->entry[ 'id' ], $rule[ 'fieldId' ] );
1967 1967
 						}
1968 1968
 
1969
-						$match = GFFormsModel::matches_operation( $value, $rule['value'], $rule['operator'] );
1969
+						$match = GFFormsModel::matches_operation( $value, $rule[ 'value' ], $rule[ 'operator' ] );
1970 1970
 						
1971 1971
 						if ( $match ) {
1972
-							$remove_conditions_rule[] = array( $field['id'], $i );
1972
+							$remove_conditions_rule[ ] = array( $field[ 'id' ], $i );
1973 1973
 						}
1974 1974
 					}
1975 1975
 				}
@@ -1977,21 +1977,21 @@  discard block
 block discarded – undo
1977 1977
 		}
1978 1978
 
1979 1979
 		if ( $remove_conditions_rule ) {
1980
-			foreach ( $form['fields'] as &$field ) {
1980
+			foreach ( $form[ 'fields' ] as &$field ) {
1981 1981
 				foreach ( $remove_conditions_rule as $_remove_conditions_r ) {
1982 1982
 
1983 1983
 				    list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
1984 1984
 
1985
-					if ( $field['id'] == $rule_field_id ) {
1986
-						unset( $field->conditionalLogic['rules'][ $rule_i ] );
1987
-						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field['id'] ) );
1985
+					if ( $field[ 'id' ] == $rule_field_id ) {
1986
+						unset( $field->conditionalLogic[ 'rules' ][ $rule_i ] );
1987
+						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field[ 'id' ] ) );
1988 1988
 					}
1989 1989
 				}
1990 1990
 			}
1991 1991
 		}
1992 1992
 
1993 1993
 		/** Normalize the indices... */
1994
-		$form['fields'] = array_values( $form['fields'] );
1994
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
1995 1995
 
1996 1996
 		/**
1997 1997
 		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
@@ -2001,16 +2001,16 @@  discard block
 block discarded – undo
2001 2001
 		 */
2002 2002
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
2003 2003
 
2004
-		if( $use_conditional_logic ) {
2004
+		if ( $use_conditional_logic ) {
2005 2005
 			return $form;
2006 2006
 		}
2007 2007
 
2008
-		foreach( $form['fields'] as &$field ) {
2008
+		foreach ( $form[ 'fields' ] as &$field ) {
2009 2009
 			/* @var GF_Field $field */
2010 2010
 			$field->conditionalLogic = null;
2011 2011
 		}
2012 2012
 
2013
-		unset( $form['button']['conditionalLogic'] );
2013
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
2014 2014
 
2015 2015
 		return $form;
2016 2016
 
@@ -2027,7 +2027,7 @@  discard block
 block discarded – undo
2027 2027
 	 */
2028 2028
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
2029 2029
 
2030
-		if( ! $this->is_edit_entry() ) {
2030
+		if ( ! $this->is_edit_entry() ) {
2031 2031
 			return $has_conditional_logic;
2032 2032
 		}
2033 2033
 
@@ -2059,44 +2059,44 @@  discard block
 block discarded – undo
2059 2059
 		 *  2. There are two entries embedded using oEmbed
2060 2060
 		 *  3. One of the entries has just been saved
2061 2061
 		 */
2062
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2062
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2063 2063
 
2064 2064
 			$error = true;
2065 2065
 
2066 2066
 		}
2067 2067
 
2068
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2068
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2069 2069
 
2070 2070
 			$error = true;
2071 2071
 
2072
-		} elseif( ! $this->verify_nonce() ) {
2072
+		} elseif ( ! $this->verify_nonce() ) {
2073 2073
 
2074 2074
 			/**
2075 2075
 			 * If the Entry is embedded, there may be two entries on the same page.
2076 2076
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2077 2077
 			 */
2078
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2078
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2079 2079
 				$error = true;
2080 2080
 			} else {
2081
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2081
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2082 2082
 			}
2083 2083
 
2084 2084
 		}
2085 2085
 
2086
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2087
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2086
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2087
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2088 2088
 		}
2089 2089
 
2090
-		if( $this->entry['status'] === 'trash' ) {
2091
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2090
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2091
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2092 2092
 		}
2093 2093
 
2094 2094
 		// No errors; everything's fine here!
2095
-		if( empty( $error ) ) {
2095
+		if ( empty( $error ) ) {
2096 2096
 			return true;
2097 2097
 		}
2098 2098
 
2099
-		if( $echo && $error !== true ) {
2099
+		if ( $echo && $error !== true ) {
2100 2100
 
2101 2101
 	        $error = esc_html( $error );
2102 2102
 
@@ -2104,10 +2104,10 @@  discard block
 block discarded – undo
2104 2104
 	         * @since 1.9
2105 2105
 	         */
2106 2106
 	        if ( ! empty( $this->entry ) ) {
2107
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2107
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2108 2108
 	        }
2109 2109
 
2110
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2110
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2111 2111
 		}
2112 2112
 
2113 2113
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2127,17 +2127,17 @@  discard block
 block discarded – undo
2127 2127
 
2128 2128
 		$error = NULL;
2129 2129
 
2130
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2131
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2130
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2131
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2132 2132
 		}
2133 2133
 
2134 2134
 		// No errors; everything's fine here!
2135
-		if( empty( $error ) ) {
2135
+		if ( empty( $error ) ) {
2136 2136
 			return true;
2137 2137
 		}
2138 2138
 
2139
-		if( $echo ) {
2140
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2139
+		if ( $echo ) {
2140
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2141 2141
 		}
2142 2142
 
2143 2143
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2158,14 +2158,14 @@  discard block
 block discarded – undo
2158 2158
 	private function check_user_cap_edit_field( $field ) {
2159 2159
 
2160 2160
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2161
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2161
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2162 2162
 			return true;
2163 2163
 		}
2164 2164
 
2165
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2165
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2166 2166
 
2167
-		if( $field_cap ) {
2168
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2167
+		if ( $field_cap ) {
2168
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2169 2169
 		}
2170 2170
 
2171 2171
 		return false;
@@ -2179,17 +2179,17 @@  discard block
 block discarded – undo
2179 2179
 	public function verify_nonce() {
2180 2180
 
2181 2181
 		// Verify form submitted for editing single
2182
-		if( $this->is_edit_entry_submission() ) {
2182
+		if ( $this->is_edit_entry_submission() ) {
2183 2183
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2184 2184
 		}
2185 2185
 
2186 2186
 		// Verify
2187
-		else if( ! $this->is_edit_entry() ) {
2187
+		else if ( ! $this->is_edit_entry() ) {
2188 2188
 			$valid = false;
2189 2189
 		}
2190 2190
 
2191 2191
 		else {
2192
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2192
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2193 2193
 		}
2194 2194
 
2195 2195
 		/**
Please login to merge, or discard this patch.
includes/class-gravityview-change-entry-creator.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -10,17 +10,17 @@  discard block
 block discarded – undo
10 10
     	/**
11 11
     	 * @since  1.5.1
12 12
     	 */
13
-    	add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
13
+    	add_action( 'gform_user_registered', array( $this, 'assign_new_user_to_lead' ), 10, 4 );
14 14
 
15 15
     	// ONLY ADMIN FROM HERE ON.
16
-    	if( !is_admin() ) { return; }
16
+    	if ( ! is_admin() ) { return; }
17 17
 
18 18
 	    /**
19 19
          * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20 20
 	     * @since 1.7.4
21 21
 	     * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22 22
 	     */
23
-	    if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
23
+	    if ( apply_filters( 'gravityview_disable_change_entry_creator', false ) ) {
24 24
 		    return;
25 25
 	    }
26 26
 
@@ -28,9 +28,9 @@  discard block
 block discarded – undo
28 28
          * Use `init` to fix bbPress warning
29 29
          * @see https://bbpress.trac.wordpress.org/ticket/2309
30 30
          */
31
-    	add_action('init', array( $this, 'load'), 100 );
31
+    	add_action( 'init', array( $this, 'load' ), 100 );
32 32
 
33
-    	add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
33
+    	add_action( 'plugins_loaded', array( $this, 'prevent_conflicts' ) );
34 34
 
35 35
     }
36 36
 
@@ -56,20 +56,20 @@  discard block
 block discarded – undo
56 56
     	$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57 57
 
58 58
     	// If filter returns false, do not process
59
-    	if( empty( $assign_to_lead ) ) {
59
+    	if ( empty( $assign_to_lead ) ) {
60 60
     		return;
61 61
     	}
62 62
 
63 63
     	// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
-    	$result = RGFormsModel::update_entry_property( (int) $entry['id'], 'created_by', (int) $user_id, false, true );
64
+    	$result = RGFormsModel::update_entry_property( (int)$entry[ 'id' ], 'created_by', (int)$user_id, false, true );
65 65
 
66 66
     	if ( false === $result ) {
67
-    		$status = __('Error', 'gravityview');
67
+    		$status = __( 'Error', 'gravityview' );
68 68
     		global $wpdb;
69 69
 		    $note = sprintf( '%s: Failed to assign User ID #%d as the entry creator (Last database error: "%s")', $status, $user_id, $wpdb->last_error );
70 70
     	} else {
71
-    		$status = __('Success', 'gravityview');
72
-    	    $note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
71
+    		$status = __( 'Success', 'gravityview' );
72
+    	    $note = sprintf( _x( '%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview' ), $status, $user_id );
73 73
     	}
74 74
 
75 75
     	gravityview()->log->debug( 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - {note}', array( 'note' => $note ) );
@@ -79,11 +79,11 @@  discard block
 block discarded – undo
79 79
 	     * @since 1.21.5
80 80
 	     * @param boolean $disable Disable the Change Entry Creator note. Default: false.
81 81
 	     */
82
-	    if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
82
+	    if ( apply_filters( 'gravityview_disable_change_entry_creator_note', false ) ) {
83 83
 		    return;
84 84
 	    }
85 85
 
86
-        GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
86
+        GravityView_Entry_Notes::add_note( $entry[ 'id' ], -1, 'GravityView', $note, 'gravityview' );
87 87
 
88 88
     }
89 89
 
@@ -95,8 +95,8 @@  discard block
 block discarded – undo
95 95
 
96 96
     	// Plugin that was provided here:
97 97
     	// @link https://gravityview.co/support/documentation/201991205/
98
-    	remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
-    	remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
98
+    	remove_action( "gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
+    	remove_action( "gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
100 100
 
101 101
     }
102 102
 
@@ -107,26 +107,26 @@  discard block
 block discarded – undo
107 107
     function load() {
108 108
 
109 109
     	// Does GF exist?
110
-        if( !class_exists('GFCommon') ) {
110
+        if ( ! class_exists( 'GFCommon' ) ) {
111 111
             return;
112 112
         }
113 113
 
114 114
         // Can the user edit entries?
115
-        if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
115
+        if ( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
116 116
             return;
117 117
         }
118 118
 
119 119
         // If screen mode isn't set, then we're in the wrong place.
120
-        if( empty( $_REQUEST['screen_mode'] ) ) {
120
+        if ( empty( $_REQUEST[ 'screen_mode' ] ) ) {
121 121
             return;
122 122
         }
123 123
 
124 124
         // Now, no validation is required in the methods; let's hook in.
125
-        add_action('admin_init', array( &$this, 'set_screen_mode' ) );
125
+        add_action( 'admin_init', array( &$this, 'set_screen_mode' ) );
126 126
 
127
-        add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
127
+        add_action( "gform_entry_info", array( &$this, 'add_select' ), 10, 2 );
128 128
 
129
-        add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
129
+        add_action( "gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2 );
130 130
 
131 131
     }
132 132
 
@@ -136,13 +136,13 @@  discard block
 block discarded – undo
136 136
      */
137 137
     function set_screen_mode() {
138 138
 
139
-    	if( 'view' === \GV\Utils::_POST( 'screen_mode' ) ) {
139
+    	if ( 'view' === \GV\Utils::_POST( 'screen_mode' ) ) {
140 140
     		return;
141 141
 	    }
142 142
 
143 143
     	// If $_GET['screen_mode'] is set to edit, set $_POST value
144
-        if( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
145
-            $_POST["screen_mode"] = 'edit';
144
+        if ( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
145
+            $_POST[ "screen_mode" ] = 'edit';
146 146
         }
147 147
 
148 148
     }
@@ -153,11 +153,11 @@  discard block
 block discarded – undo
153 153
      * @param  int $entry_id Entry ID
154 154
      * @return void
155 155
      */
156
-    function update_entry_creator($form, $entry_id) {
156
+    function update_entry_creator( $form, $entry_id ) {
157 157
             global $current_user;
158 158
 
159 159
         // Update the entry
160
-        $created_by = absint( \GV\Utils::_POST( 'created_by') );
160
+        $created_by = absint( \GV\Utils::_POST( 'created_by' ) );
161 161
 
162 162
         RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
163 163
 
@@ -165,30 +165,30 @@  discard block
 block discarded – undo
165 165
         $originally_created_by = \GV\Utils::_POST( 'originally_created_by' );
166 166
 
167 167
         // If there's no owner and there didn't used to be, keep going
168
-        if( empty( $originally_created_by ) && empty( $created_by ) ) {
168
+        if ( empty( $originally_created_by ) && empty( $created_by ) ) {
169 169
             return;
170 170
         }
171 171
 
172 172
         // If the values have changed
173
-        if( absint( $originally_created_by ) !== absint( $created_by ) ) {
173
+        if ( absint( $originally_created_by ) !== absint( $created_by ) ) {
174 174
 
175
-            $user_data = get_userdata($current_user->ID);
175
+            $user_data = get_userdata( $current_user->ID );
176 176
 
177
-            $user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
177
+            $user_format = _x( '%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview' );
178 178
 
179
-            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
179
+            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview' );
180 180
 
181
-            if( !empty( $originally_created_by ) ) {
182
-                $originally_created_by_user_data = get_userdata($originally_created_by);
181
+            if ( ! empty( $originally_created_by ) ) {
182
+                $originally_created_by_user_data = get_userdata( $originally_created_by );
183 183
                 $original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
184 184
             }
185 185
 
186
-            if( !empty( $created_by ) ) {
187
-                $created_by_user_data =  get_userdata($created_by);
186
+            if ( ! empty( $created_by ) ) {
187
+                $created_by_user_data = get_userdata( $created_by );
188 188
                 $created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
189 189
             }
190 190
 
191
-            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
191
+            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __( 'Changed entry creator from %s to %s', 'gravityview' ), $original_name, $created_by_name ), 'note' );
192 192
         }
193 193
 
194 194
     }
@@ -199,9 +199,9 @@  discard block
 block discarded – undo
199 199
      * @param array $entry    GF entry array
200 200
      * @return void
201 201
      */
202
-    function add_select($form_id, $entry ) {
202
+    function add_select( $form_id, $entry ) {
203 203
 
204
-        if( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
204
+        if ( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
205 205
             return;
206 206
         }
207 207
 
@@ -220,23 +220,23 @@  discard block
 block discarded – undo
220 220
 	    }
221 221
 
222 222
         $output = '<label for="change_created_by">';
223
-        $output .= esc_html__('Change Entry Creator:', 'gravityview');
223
+        $output .= esc_html__( 'Change Entry Creator:', 'gravityview' );
224 224
         $output .= '</label>';
225 225
 
226 226
 	    // If there are users who are not being shown, show a warning.
227 227
 	    // TODO: Use AJAX instead of <select>
228 228
 	    $count_users = count_users();
229
-	    if( sizeof( $users ) < $count_users['total_users'] ) {
229
+	    if ( sizeof( $users ) < $count_users[ 'total_users' ] ) {
230 230
 		    $output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
231 231
 	    }
232 232
 
233 233
 	    $output .= '<select name="created_by" id="change_created_by" class="widefat">';
234
-        $output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
235
-        foreach($users as $user) {
236
-            $output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
234
+        $output .= '<option value="' . selected( $entry[ 'created_by' ], '0', false ) . '"> &mdash; ' . esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview' ) . ' &mdash; </option>';
235
+        foreach ( $users as $user ) {
236
+            $output .= '<option value="' . $user->ID . '"' . selected( $entry[ 'created_by' ], $user->ID, false ) . '>' . esc_attr( $user->display_name . ' (' . $user->user_nicename . ')' ) . '</option>';
237 237
         }
238 238
         $output .= '</select>';
239
-        $output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
239
+        $output .= '<input name="originally_created_by" value="' . esc_attr( $entry[ 'created_by' ] ) . '" type="hidden" />';
240 240
 
241 241
 	    unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
242 242
 
Please login to merge, or discard this patch.
future/_mocks.php 1 patch
Spacing   +44 added lines, -47 removed lines patch added patch discarded remove patch
@@ -102,8 +102,7 @@  discard block
 block discarded – undo
102 102
 			$entries = $view->get_entries( gravityview()->request );
103 103
 		}
104 104
 
105
-		$page = \GV\Utils::get( $parameters['paging'], 'current_page' ) ?
106
-			: ( ( ( $parameters['paging']['offset'] - $view->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
105
+		$page = \GV\Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $view->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
107 106
 
108 107
 		/** Set paging, count and unwrap the entries. */
109 108
 		$paging = array(
@@ -142,17 +141,17 @@  discard block
 block discarded – undo
142 141
  * @return null|string The value of a field in an entry.
143 142
  */
144 143
 function GravityView_API_field_value( $entry, $field_settings, $format ) {
145
-	if ( empty( $entry['form_id'] ) || empty( $field_settings['id'] ) ) {
144
+	if ( empty( $entry[ 'form_id' ] ) || empty( $field_settings[ 'id' ] ) ) {
146 145
 		gravityview()->log->error( 'No entry or field_settings[id] supplied', array( 'data' => array( func_get_args() ) ) );
147 146
 		return null;
148 147
 	}
149 148
 
150
-	if ( ! empty( $entry['_multi'] ) && ! empty( $field_settings['form_id'] ) && ! empty( $entry['_multi'][ $field_settings['form_id'] ] ) ) {
151
-		$multientry = \GV\Multi_Entry::from_entries( array_map( '\GV\GF_Entry::from_entry', $entry['_multi'] ) );
152
-		$entry = $entry['_multi'][ $field_settings['form_id'] ];
149
+	if ( ! empty( $entry[ '_multi' ] ) && ! empty( $field_settings[ 'form_id' ] ) && ! empty( $entry[ '_multi' ][ $field_settings[ 'form_id' ] ] ) ) {
150
+		$multientry = \GV\Multi_Entry::from_entries( array_map( '\GV\GF_Entry::from_entry', $entry[ '_multi' ] ) );
151
+		$entry = $entry[ '_multi' ][ $field_settings[ 'form_id' ] ];
153 152
 	}
154 153
 
155
-	if ( empty( $entry['id'] ) || ! $entry = \GV\GF_Entry::by_id( $entry['id'] ) ) {
154
+	if ( empty( $entry[ 'id' ] ) || ! $entry = \GV\GF_Entry::by_id( $entry[ 'id' ] ) ) {
156 155
 		gravityview()->log->error( 'Invalid \GV\GF_Entry supplied', array( 'data' => $entry ) );
157 156
 		return null;
158 157
 	}
@@ -162,18 +161,18 @@  discard block
 block discarded – undo
162 161
 	 *
163 162
 	 * Fields with a numeric ID are Gravity Forms ones.
164 163
 	 */
165
-	$source = is_numeric( $field_settings['id'] ) ? \GV\Source::BACKEND_GRAVITYFORMS : \GV\Source::BACKEND_INTERNAL;;
164
+	$source = is_numeric( $field_settings[ 'id' ] ) ? \GV\Source::BACKEND_GRAVITYFORMS : \GV\Source::BACKEND_INTERNAL; ;
166 165
 
167 166
 	/** Initialize the future field. */
168 167
 	switch ( $source ):
169 168
 		/** The Gravity Forms backend. */
170 169
 		case \GV\Source::BACKEND_GRAVITYFORMS:
171
-			if ( ! $form = \GV\GF_Form::by_id( $entry['form_id'] ) ) {
170
+			if ( ! $form = \GV\GF_Form::by_id( $entry[ 'form_id' ] ) ) {
172 171
 				gravityview()->log->error( 'No form Gravity Form found for entry', array( 'data' => $entry ) );
173 172
 				return null;
174 173
 			}
175 174
 
176
-			if ( ! $field = $form::get_field( $form, $field_settings['id'] ) ) {
175
+			if ( ! $field = $form::get_field( $form, $field_settings[ 'id' ] ) ) {
177 176
 				return null;
178 177
 			}
179 178
 
@@ -181,7 +180,7 @@  discard block
 block discarded – undo
181 180
 
182 181
 		/** Our internal backend. */
183 182
 		case \GV\Source::BACKEND_INTERNAL:
184
-			if ( ! $field = \GV\Internal_Source::get_field( $field_settings['id'] ) ) {
183
+			if ( ! $field = \GV\Internal_Source::get_field( $field_settings[ 'id' ] ) ) {
185 184
 				return null;
186 185
 			}
187 186
 
@@ -215,13 +214,13 @@  discard block
 block discarded – undo
215 214
 
216 215
 	/** A bail condition. */
217 216
 	$bail = function( $label, $field_settings, $entry, $force_show_label, $form ) {
218
-		if ( ! empty( $field_settings['show_label'] ) || $force_show_label ) {
217
+		if ( ! empty( $field_settings[ 'show_label' ] ) || $force_show_label ) {
219 218
 
220
-			$label = isset( $field_settings['label'] ) ? $field_settings['label'] : '';
219
+			$label = isset( $field_settings[ 'label' ] ) ? $field_settings[ 'label' ] : '';
221 220
 
222 221
 			// Use Gravity Forms label by default, but if a custom label is defined in GV, use it.
223
-			if ( ! empty( $field_settings['custom_label'] ) ) {
224
-				$label = \GravityView_API::replace_variables( $field_settings['custom_label'], $form, $entry );
222
+			if ( ! empty( $field_settings[ 'custom_label' ] ) ) {
223
+				$label = \GravityView_API::replace_variables( $field_settings[ 'custom_label' ], $form, $entry );
225 224
 			}
226 225
 
227 226
 			/**
@@ -247,19 +246,19 @@  discard block
 block discarded – undo
247 246
 
248 247
 	$label = '';
249 248
 
250
-	if ( ! empty( $entry['_multi'] ) && ! empty( $field_settings['form_id'] ) && ! empty( $entry['_multi'][ $field_settings['form_id'] ] ) ) {
251
-		$entry = $entry['_multi'][ $field_settings['form_id'] ];
252
-		if ( $_form = \GV\GF_Form::by_id( $field_settings['form_id'] ) ) {
249
+	if ( ! empty( $entry[ '_multi' ] ) && ! empty( $field_settings[ 'form_id' ] ) && ! empty( $entry[ '_multi' ][ $field_settings[ 'form_id' ] ] ) ) {
250
+		$entry = $entry[ '_multi' ][ $field_settings[ 'form_id' ] ];
251
+		if ( $_form = \GV\GF_Form::by_id( $field_settings[ 'form_id' ] ) ) {
253 252
 			$form = $_form->form;
254 253
 		}
255 254
 	}
256 255
 
257
-	if ( empty( $entry['form_id'] ) || empty( $field_settings['id'] ) ) {
256
+	if ( empty( $entry[ 'form_id' ] ) || empty( $field_settings[ 'id' ] ) ) {
258 257
 		gravityview()->log->error( 'No entry or field_settings[id] supplied', array( 'data' => array( func_get_args() ) ) );
259 258
 		return $bail( $label, $field_settings, $entry, $force_show_label, $form );
260 259
 	}
261 260
 
262
-	if ( empty( $entry['id'] ) || ! $gv_entry = \GV\GF_Entry::by_id( $entry['id'] ) ) {
261
+	if ( empty( $entry[ 'id' ] ) || ! $gv_entry = \GV\GF_Entry::by_id( $entry[ 'id' ] ) ) {
263 262
 		gravityview()->log->error( 'Invalid \GV\GF_Entry supplied', array( 'data' => $entry ) );
264 263
 		return $bail( $label, $field_settings, $entry, $force_show_label, $form );
265 264
 	}
@@ -271,31 +270,31 @@  discard block
 block discarded – undo
271 270
 	 *
272 271
 	 * Fields with a numeric ID are Gravity Forms ones.
273 272
 	 */
274
-	$source = is_numeric( $field_settings['id'] ) ? \GV\Source::BACKEND_GRAVITYFORMS : \GV\Source::BACKEND_INTERNAL;
273
+	$source = is_numeric( $field_settings[ 'id' ] ) ? \GV\Source::BACKEND_GRAVITYFORMS : \GV\Source::BACKEND_INTERNAL;
275 274
 
276 275
 	/** Initialize the future field. */
277 276
 	switch ( $source ):
278 277
 		/** The Gravity Forms backend. */
279 278
 		case \GV\Source::BACKEND_GRAVITYFORMS:
280
-			if ( ! $gf_form = \GV\GF_Form::by_id( $entry['form_id'] ) ) {
279
+			if ( ! $gf_form = \GV\GF_Form::by_id( $entry[ 'form_id' ] ) ) {
281 280
 				gravityview()->log->error( 'No form Gravity Form found for entry', array( 'data' => $entry ) );
282 281
 				return $bail( $label, $field_settings, $entry->as_entry(), $force_show_label, $form );
283 282
 			}
284 283
 
285
-			if ( ! $field = $gf_form::get_field( $gf_form, $field_settings['id'] ) ) {
286
-				gravityview()->log->error( 'No field found for specified form and field ID #{field_id}', array( 'field_id' => $field_settings['id'], 'data' => $form ) );
284
+			if ( ! $field = $gf_form::get_field( $gf_form, $field_settings[ 'id' ] ) ) {
285
+				gravityview()->log->error( 'No field found for specified form and field ID #{field_id}', array( 'field_id' => $field_settings[ 'id' ], 'data' => $form ) );
287 286
 				return $bail( $label, $field_settings, $entry->as_entry(), $force_show_label, $gf_form->form );
288 287
 			}
289
-			if ( empty( $field_settings['show_label'] ) ) {
288
+			if ( empty( $field_settings[ 'show_label' ] ) ) {
290 289
 				/** The label never wins... */
291
-				$field_settings['label'] = '';
290
+				$field_settings[ 'label' ] = '';
292 291
 			}
293 292
 
294 293
 			break;
295 294
 
296 295
 		/** Our internal backend. */
297 296
 		case \GV\Source::BACKEND_INTERNAL:
298
-			if ( ! $field = \GV\Internal_Source::get_field( $field_settings['id'] ) ) {
297
+			if ( ! $field = \GV\Internal_Source::get_field( $field_settings[ 'id' ] ) ) {
299 298
 				return $bail( $label, $field_settings, $entry->as_entry(), $force_show_label, $form );
300 299
 			}
301 300
 			break;
@@ -307,8 +306,8 @@  discard block
 block discarded – undo
307 306
 			break;
308 307
 	endswitch;
309 308
 
310
-	if( $force_show_label ) {
311
-		$field_settings['show_label'] = '1';
309
+	if ( $force_show_label ) {
310
+		$field_settings[ 'show_label' ] = '1';
312 311
 	}
313 312
 
314 313
 	/** Add the field settings. */
@@ -444,7 +443,7 @@  discard block
 block discarded – undo
444 443
 			'\GravityView_View::_current_entry' => \GravityView_View::getInstance()->getCurrentEntry(),
445 444
 			'\GravityView_View::fields' => \GravityView_View::getInstance()->getFields(),
446 445
 			'\GravityView_View::_current_field' => \GravityView_View::getInstance()->getCurrentField(),
447
-			'wp_actions[loop_start]' => empty( $wp_actions['loop_start'] ) ? 0 : $wp_actions['loop_start'],
446
+			'wp_actions[loop_start]' => empty( $wp_actions[ 'loop_start' ] ) ? 0 : $wp_actions[ 'loop_start' ],
448 447
 			'wp_query::in_the_loop' => $wp_query->in_the_loop,
449 448
 		);
450 449
 	}
@@ -532,7 +531,7 @@  discard block
 block discarded – undo
532 531
 					break;
533 532
 				case 'wp_actions[loop_start]':
534 533
 					global $wp_actions;
535
-					$wp_actions['loop_start'] = $value;
534
+					$wp_actions[ 'loop_start' ] = $value;
536 535
 					break;
537 536
 				case 'wp_query::in_the_loop':
538 537
 					global $wp_query;
@@ -629,9 +628,7 @@  discard block
 block discarded – undo
629 628
 				case 'request':
630 629
 					self::thaw( array(
631 630
 						'\GravityView_View::context' => (
632
-							$value->is_entry() ? 'single' :
633
-							( $value->is_edit_entry() ? 'edit' :
634
-									( $value->is_view() ? 'directory': null )
631
+							$value->is_entry() ? 'single' : ( $value->is_edit_entry() ? 'edit' : ( $value->is_view() ? 'directory' : null )
635 632
 								)
636 633
 						),
637 634
 						'\GravityView_frontend::is_search' => $value->is_search(),
@@ -685,14 +682,14 @@  discard block
 block discarded – undo
685 682
 		global $wp_query, $wp_actions;
686 683
 
687 684
 		$wp_query->in_the_loop = false;
688
-		$wp_actions['loop_start'] = 0;
685
+		$wp_actions[ 'loop_start' ] = 0;
689 686
 	}
690 687
 }
691 688
 
692 689
 
693 690
 /** Add some global fix for field capability discrepancies. */
694 691
 add_filter( 'gravityview/configuration/fields', function( $fields ) {
695
-	if ( empty( $fields  ) ) {
692
+	if ( empty( $fields ) ) {
696 693
 		return $fields;
697 694
 	}
698 695
 
@@ -719,11 +716,11 @@  discard block
 block discarded – undo
719 716
 		}
720 717
 
721 718
 		foreach ( $_fields as $uid => &$_field ) {
722
-			if ( ! isset( $_field['only_loggedin'] ) ) {
719
+			if ( ! isset( $_field[ 'only_loggedin' ] ) ) {
723 720
 				continue;
724 721
 			}
725 722
 			/** If we do not require login, we don't require a cap. */
726
-			$_field['only_loggedin'] != '1' && ( $_field['only_loggedin_cap'] = '' );
723
+			$_field[ 'only_loggedin' ] != '1' && ( $_field[ 'only_loggedin_cap' ] = '' );
727 724
 		}
728 725
 	}
729 726
 	return $fields;
@@ -754,8 +751,8 @@  discard block
 block discarded – undo
754 751
 		}
755 752
 
756 753
 		foreach ( $_fields as $uid => &$_field ) {
757
-			if ( ! empty( $_field['id'] ) && is_numeric( $_field['id'] ) && empty( $_field['form_id'] ) ) {
758
-				$_field['form_id'] = $view->form->ID;
754
+			if ( ! empty( $_field[ 'id' ] ) && is_numeric( $_field[ 'id' ] ) && empty( $_field[ 'form_id' ] ) ) {
755
+				$_field[ 'form_id' ] = $view->form->ID;
759 756
 			}
760 757
 		}
761 758
 	}
@@ -769,25 +766,25 @@  discard block
 block discarded – undo
769 766
 	if ( class_exists( '\GravityView_frontend' ) ) {
770 767
 		global $wp_filter;
771 768
 
772
-		if ( empty( $wp_filter['gravityview_after'] ) ) {
769
+		if ( empty( $wp_filter[ 'gravityview_after' ] ) ) {
773 770
 			return;
774 771
 		}
775 772
 
776 773
 		/** WordPress 4.6 and lower compatibility, when WP_Hook classes were still absent. */
777
-		if ( is_array( $wp_filter['gravityview_after'] ) ) {
778
-			if ( ! empty( $wp_filter['gravityview_after'][10] ) ) {
779
-				foreach ( $wp_filter['gravityview_after'][10] as $function_key => $callback ) {
774
+		if ( is_array( $wp_filter[ 'gravityview_after' ] ) ) {
775
+			if ( ! empty( $wp_filter[ 'gravityview_after' ][ 10 ] ) ) {
776
+				foreach ( $wp_filter[ 'gravityview_after' ][ 10 ] as $function_key => $callback ) {
780 777
 					if ( strpos( $function_key, 'context_not_configured_warning' ) ) {
781
-						unset( $wp_filter['gravityview_after'][10][ $function_key ] );
778
+						unset( $wp_filter[ 'gravityview_after' ][ 10 ][ $function_key ] );
782 779
 					}
783 780
 				}
784 781
 			}
785 782
 			return;
786 783
 		}
787 784
 
788
-		foreach ( $wp_filter['gravityview_after']->callbacks[10] as $function_key => $callback ) {
785
+		foreach ( $wp_filter[ 'gravityview_after' ]->callbacks[ 10 ] as $function_key => $callback ) {
789 786
 			if ( strpos( $function_key, 'context_not_configured_warning' ) ) {
790
-				unset( $wp_filter['gravityview_after']->callbacks[10][ $function_key ] );
787
+				unset( $wp_filter[ 'gravityview_after' ]->callbacks[ 10 ][ $function_key ] );
791 788
 			}
792 789
 		}
793 790
 	}
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-sequence.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 
39 39
 		$this->label = esc_html__( 'Number Sequence', 'gravityview' );
40 40
 
41
-		add_filter( 'gravityview/metaboxes/tooltips', array( $this, 'field_tooltips') );
41
+		add_filter( 'gravityview/metaboxes/tooltips', array( $this, 'field_tooltips' ) );
42 42
 
43 43
 		parent::__construct();
44 44
 	}
@@ -52,9 +52,9 @@  discard block
 block discarded – undo
52 52
 
53 53
 		$return = $tooltips;
54 54
 
55
-		$return['reverse_sequence'] = array(
56
-			'title' => __('Reverse the order of the result numbers', 'gravityview'),
57
-			'value' => __('Output the number sequence in descending order. If enabled, numbers will count down from high to low.', 'gravityview'),
55
+		$return[ 'reverse_sequence' ] = array(
56
+			'title' => __( 'Reverse the order of the result numbers', 'gravityview' ),
57
+			'value' => __( 'Output the number sequence in descending order. If enabled, numbers will count down from high to low.', 'gravityview' ),
58 58
 		);
59 59
 
60 60
 		return $return;
@@ -62,13 +62,13 @@  discard block
 block discarded – undo
62 62
 
63 63
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
64 64
 
65
-		unset ( $field_options['search_filter'] );
65
+		unset ( $field_options[ 'search_filter' ] );
66 66
 
67 67
 		$new_fields = array(
68 68
 			'start' => array(
69 69
 				'type' => 'number',
70 70
 				'label' => __( 'First Number in the Sequence', 'gravityview' ),
71
-				'desc' => __('For each entry, the displayed number will increase by one. When displaying ten entries, the first entry will display "1", and the last entry will show "10".', 'gravityview'),
71
+				'desc' => __( 'For each entry, the displayed number will increase by one. When displaying ten entries, the first entry will display "1", and the last entry will show "10".', 'gravityview' ),
72 72
 				'value' => '1',
73 73
 				'merge_tags' => false,
74 74
 			),
@@ -124,17 +124,17 @@  discard block
 block discarded – undo
124 124
 		$return = $text;
125 125
 
126 126
 		$context = new \GV\Template_Context();
127
-		$context->view = \GV\View::by_id( $view_data['view_id'] );
127
+		$context->view = \GV\View::by_id( $view_data[ 'view_id' ] );
128 128
 		$context->entry = \GV\GF_Entry::from_entry( $entry );
129 129
 
130 130
 		$gv_field = \GV\Internal_Field::by_id( 'sequence' );
131 131
 		$merge_tag_context = \GV\Utils::get( $legacy_field, 'UID' );
132
-		$merge_tag_context = $entry['id'] . "/{$merge_tag_context}";
132
+		$merge_tag_context = $entry[ 'id' ] . "/{$merge_tag_context}";
133 133
 
134 134
 		foreach ( $matches as $match ) {
135 135
 
136
-			$full_tag = $match[0];
137
-			$property = $match[1];
136
+			$full_tag = $match[ 0 ];
137
+			$property = $match[ 1 ];
138 138
 
139 139
 			$gv_field->reverse = false;
140 140
 			$gv_field->start = 1;
@@ -153,12 +153,12 @@  discard block
 block discarded – undo
153 153
 
154 154
 				// If there is a field with the ID of the start number, the merge tag won't work.
155 155
 				// In that case, you can use "=" instead: `{sequence start=10}`
156
-				if( 1 === sizeof( $maybe_start ) ) {
156
+				if ( 1 === sizeof( $maybe_start ) ) {
157 157
 					$maybe_start = explode( '=', $modifier );
158 158
 				}
159 159
 
160 160
 				if ( 'start' === rgar( $maybe_start, 0 ) && is_numeric( rgar( $maybe_start, 1 ) ) ) {
161
-					$gv_field->start = (int) rgar( $maybe_start, 1 );
161
+					$gv_field->start = (int)rgar( $maybe_start, 1 );
162 162
 				}
163 163
 			}
164 164
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 			$merge_tag_context_modifiers = $merge_tag_context . '/' . var_export( $gv_field->reverse, true ) . '/' . $gv_field->start;
170 170
 
171 171
 			if ( ! isset( $merge_tag_sequences[ $merge_tag_context_modifiers ] ) ) {
172
-				$gv_field->UID = $legacy_field['UID'] . '/' . var_export( $gv_field->reverse, true ) . '/' . $gv_field->start;
172
+				$gv_field->UID = $legacy_field[ 'UID' ] . '/' . var_export( $gv_field->reverse, true ) . '/' . $gv_field->start;
173 173
 				$context->field = $gv_field;
174 174
 				$sequence = $merge_tag_sequences[ $merge_tag_context_modifiers ] = $this->get_sequence( $context );
175 175
 			} else {
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
 			$total = $context->view->get_entries()->total();
215 215
 			remove_filter( 'gform_gf_query_sql', $callback );
216 216
 
217
-			unset( $sql_query['paginate'] );
217
+			unset( $sql_query[ 'paginate' ] );
218 218
 
219 219
 			global $wpdb;
220 220
 
Please login to merge, or discard this patch.
includes/class-admin-views.php 1 patch
Spacing   +184 added lines, -184 removed lines patch added patch discarded remove patch
@@ -27,32 +27,32 @@  discard block
 block discarded – undo
27 27
 		add_filter( 'gravityview_blacklist_field_types', array( $this, 'default_field_blacklist' ), 10, 2 );
28 28
 
29 29
 		// Tooltips
30
-		add_filter( 'gform_tooltips', array( $this, 'tooltips') );
30
+		add_filter( 'gform_tooltips', array( $this, 'tooltips' ) );
31 31
 
32 32
 		// adding styles and scripts
33
-		add_action( 'admin_enqueue_scripts', array( 'GravityView_Admin_Views', 'add_scripts_and_styles'), 999 );
34
-		add_filter( 'gform_noconflict_styles', array( $this, 'register_no_conflict') );
35
-		add_filter( 'gform_noconflict_scripts', array( $this, 'register_no_conflict') );
36
-		add_filter( 'gravityview_noconflict_styles', array( $this, 'register_no_conflict') );
37
-		add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict') );
38
-
39
-		add_action( 'gravityview_render_directory_active_areas', array( $this, 'render_directory_active_areas'), 10, 4 );
40
-		add_action( 'gravityview_render_widgets_active_areas', array( $this, 'render_widgets_active_areas'), 10, 3 );
41
-		add_action( 'gravityview_render_field_pickers', array( $this, 'render_field_pickers') );
42
-		add_action( 'gravityview_render_available_fields', array( $this, 'render_available_fields'), 10, 2 );
43
-		add_action( 'gravityview_render_available_widgets', array( $this, 'render_available_widgets') );
44
-		add_action( 'gravityview_render_active_areas', array( $this, 'render_active_areas'), 10, 5 );
33
+		add_action( 'admin_enqueue_scripts', array( 'GravityView_Admin_Views', 'add_scripts_and_styles' ), 999 );
34
+		add_filter( 'gform_noconflict_styles', array( $this, 'register_no_conflict' ) );
35
+		add_filter( 'gform_noconflict_scripts', array( $this, 'register_no_conflict' ) );
36
+		add_filter( 'gravityview_noconflict_styles', array( $this, 'register_no_conflict' ) );
37
+		add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
38
+
39
+		add_action( 'gravityview_render_directory_active_areas', array( $this, 'render_directory_active_areas' ), 10, 4 );
40
+		add_action( 'gravityview_render_widgets_active_areas', array( $this, 'render_widgets_active_areas' ), 10, 3 );
41
+		add_action( 'gravityview_render_field_pickers', array( $this, 'render_field_pickers' ) );
42
+		add_action( 'gravityview_render_available_fields', array( $this, 'render_available_fields' ), 10, 2 );
43
+		add_action( 'gravityview_render_available_widgets', array( $this, 'render_available_widgets' ) );
44
+		add_action( 'gravityview_render_active_areas', array( $this, 'render_active_areas' ), 10, 5 );
45 45
 
46 46
 		// @todo check if this hook is needed..
47 47
 		//add_action( 'gravityview_render_field_options', array( $this, 'render_field_options'), 10, 9 );
48 48
 
49 49
 		// Add Connected Form column
50
-		add_filter('manage_gravityview_posts_columns' , array( $this, 'add_post_type_columns' ) );
50
+		add_filter( 'manage_gravityview_posts_columns', array( $this, 'add_post_type_columns' ) );
51 51
 
52 52
 		add_filter( 'gform_toolbar_menu', array( 'GravityView_Admin_Views', 'gform_toolbar_menu' ), 10, 2 );
53 53
 		add_action( 'gform_form_actions', array( 'GravityView_Admin_Views', 'gform_toolbar_menu' ), 10, 2 );
54 54
 
55
-		add_action( 'manage_gravityview_posts_custom_column', array( $this, 'add_custom_column_content'), 10, 2 );
55
+		add_action( 'manage_gravityview_posts_custom_column', array( $this, 'add_custom_column_content' ), 10, 2 );
56 56
 
57 57
 		add_action( 'restrict_manage_posts', array( $this, 'add_view_dropdown' ) );
58 58
 
@@ -71,11 +71,11 @@  discard block
 block discarded – undo
71 71
 	 */
72 72
 	function suggest_support_articles( $localization_data = array() ) {
73 73
 
74
-	    if( ! gravityview()->request->is_view() ) {
74
+	    if ( ! gravityview()->request->is_view() ) {
75 75
 	        return $localization_data;
76 76
         }
77 77
 
78
-		$localization_data['suggest'] = array(
78
+		$localization_data[ 'suggest' ] = array(
79 79
             '57ef23539033602e61d4a560',
80 80
             '54c67bb9e4b0512429885513',
81 81
             '54c67bb9e4b0512429885512',
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 	public function filter_pre_get_posts_by_gravityview_form_id( &$query ) {
97 97
 		global $pagenow;
98 98
 
99
-		if ( !is_admin() ) {
99
+		if ( ! is_admin() ) {
100 100
 			return;
101 101
 		}
102 102
 
103
-		$form_id = isset( $_GET['gravityview_form_id'] ) ? (int) $_GET['gravityview_form_id'] : false;
103
+		$form_id = isset( $_GET[ 'gravityview_form_id' ] ) ? (int)$_GET[ 'gravityview_form_id' ] : false;
104 104
 
105
-		if( 'edit.php' !== $pagenow || ! $form_id || ! isset( $query->query_vars[ 'post_type' ] ) ) {
105
+		if ( 'edit.php' !== $pagenow || ! $form_id || ! isset( $query->query_vars[ 'post_type' ] ) ) {
106 106
 			return;
107 107
 		}
108 108
 
@@ -119,18 +119,18 @@  discard block
 block discarded – undo
119 119
 	function add_view_dropdown() {
120 120
 		$current_screen = get_current_screen();
121 121
 
122
-		if( 'gravityview' !== $current_screen->post_type ) {
122
+		if ( 'gravityview' !== $current_screen->post_type ) {
123 123
 			return;
124 124
 		}
125 125
 
126 126
 		$forms = gravityview_get_forms();
127 127
 		$current_form = \GV\Utils::_GET( 'gravityview_form_id' );
128 128
 		// If there are no forms to select, show no forms.
129
-		if( !empty( $forms ) ) { ?>
129
+		if ( ! empty( $forms ) ) { ?>
130 130
 			<select name="gravityview_form_id" id="gravityview_form_id">
131 131
 				<option value="" <?php selected( '', $current_form, true ); ?>><?php esc_html_e( 'All forms', 'gravityview' ); ?></option>
132
-				<?php foreach( $forms as $form ) { ?>
133
-					<option value="<?php echo $form['id']; ?>" <?php selected( $form['id'], $current_form, true ); ?>><?php echo esc_html( $form['title'] ); ?></option>
132
+				<?php foreach ( $forms as $form ) { ?>
133
+					<option value="<?php echo $form[ 'id' ]; ?>" <?php selected( $form[ 'id' ], $current_form, true ); ?>><?php echo esc_html( $form[ 'title' ] ); ?></option>
134 134
 				<?php } ?>
135 135
 			</select>
136 136
 		<?php }
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 */
144 144
 	public static function render_setting_row( $key = '', $current_settings = array(), $override_input = null, $name = 'template_settings[%s]', $id = 'gravityview_se_%s' ) {
145 145
 		_deprecated_function( 'GravityView_Admin_Views::render_setting_row', '1.1.7', 'GravityView_Render_Settings::render_setting_row' );
146
-		GravityView_Render_Settings::render_setting_row( $key, $current_settings, $override_input, $name , $id );
146
+		GravityView_Render_Settings::render_setting_row( $key, $current_settings, $override_input, $name, $id );
147 147
 	}
148 148
 
149 149
 	/**
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 	public static function gform_toolbar_menu( $menu_items = array(), $id = NULL ) {
166 166
 
167 167
 		// Don't show on Trashed forms
168
-		if( 'trash' === rgget( 'filter') ) {
168
+		if ( 'trash' === rgget( 'filter' ) ) {
169 169
 			return $menu_items;
170 170
 		}
171 171
 
@@ -173,13 +173,13 @@  discard block
 block discarded – undo
173 173
 
174 174
 		$priority = 0;
175 175
 
176
-		if( 'form_list' === GFForms::get_page() ) {
176
+		if ( 'form_list' === GFForms::get_page() ) {
177 177
 			$priority = 790;
178 178
         }
179 179
 
180
-		if( empty( $connected_views ) ) {
180
+		if ( empty( $connected_views ) ) {
181 181
 
182
-		    $menu_items['gravityview'] = array(
182
+		    $menu_items[ 'gravityview' ] = array(
183 183
 				'label'          => esc_attr__( 'Create a View', 'gravityview' ),
184 184
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
185 185
 				'title'          => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -195,22 +195,22 @@  discard block
 block discarded – undo
195 195
 		$sub_menu_items = array();
196 196
 		foreach ( (array)$connected_views as $view ) {
197 197
 
198
-			if( ! GVCommon::has_cap( 'edit_gravityview', $view->ID ) ) {
198
+			if ( ! GVCommon::has_cap( 'edit_gravityview', $view->ID ) ) {
199 199
 				continue;
200 200
 			}
201 201
 
202
-			$label = empty( $view->post_title ) ? sprintf( __('No Title (View #%d)', 'gravityview' ), $view->ID ) : $view->post_title;
202
+			$label = empty( $view->post_title ) ? sprintf( __( 'No Title (View #%d)', 'gravityview' ), $view->ID ) : $view->post_title;
203 203
 
204
-			$sub_menu_items[] = array(
204
+			$sub_menu_items[ ] = array(
205 205
 				'label' => esc_attr( $label ),
206
-				'url' => admin_url( 'post.php?action=edit&post='.$view->ID ),
206
+				'url' => admin_url( 'post.php?action=edit&post=' . $view->ID ),
207 207
 			);
208 208
 		}
209 209
 
210 210
 		// If there were no items added, then let's create the parent menu
211
-		if( $sub_menu_items ) {
211
+		if ( $sub_menu_items ) {
212 212
 
213
-		    $sub_menu_items[] = array(
213
+		    $sub_menu_items[ ] = array(
214 214
 			    'label' => esc_attr__( 'Create a View', 'gravityview' ),
215 215
                 'link_class' => 'gv-create-view',
216 216
 			    'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -219,14 +219,14 @@  discard block
 block discarded – undo
219 219
             );
220 220
 
221 221
 			// Make sure Gravity Forms uses the submenu; if there's only one item, it uses a link instead of a dropdown
222
-			$sub_menu_items[] = array(
222
+			$sub_menu_items[ ] = array(
223 223
 				'url' => '#',
224 224
 				'label' => '',
225 225
 				'menu_class' => 'hidden',
226 226
 				'capabilities' => '',
227 227
 			);
228 228
 
229
-			$menu_items['gravityview'] = array(
229
+			$menu_items[ 'gravityview' ] = array(
230 230
 				'label'          => __( 'Connected Views', 'gravityview' ),
231 231
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
232 232
 				'title'          => __( 'GravityView Views using this form as a data source', 'gravityview' ),
@@ -255,8 +255,8 @@  discard block
 block discarded – undo
255 255
 		$add = array( 'captcha', 'page' );
256 256
 
257 257
 		// Don't allowing editing the following values:
258
-		if( $context === 'edit' ) {
259
-			$add[] = 'post_id';
258
+		if ( $context === 'edit' ) {
259
+			$add[ ] = 'post_id';
260 260
 		}
261 261
 
262 262
 		$return = array_merge( $array, $add );
@@ -279,32 +279,32 @@  discard block
 block discarded – undo
279 279
 		foreach ( $default_args as $key => $arg ) {
280 280
 
281 281
 			// If an arg has `tooltip` defined, but it's false, don't display a tooltip
282
-			if( isset( $arg['tooltip'] ) && empty( $arg['tooltip'] ) ) { continue; }
282
+			if ( isset( $arg[ 'tooltip' ] ) && empty( $arg[ 'tooltip' ] ) ) { continue; }
283 283
 
284 284
 			// By default, use `tooltip` if defined.
285
-			$tooltip = empty( $arg['tooltip'] ) ? NULL : $arg['tooltip'];
285
+			$tooltip = empty( $arg[ 'tooltip' ] ) ? NULL : $arg[ 'tooltip' ];
286 286
 
287 287
 			// Otherwise, use the description as a tooltip.
288
-			if( empty( $tooltip ) && !empty( $arg['desc'] ) ) {
289
-				$tooltip = $arg['desc'];
288
+			if ( empty( $tooltip ) && ! empty( $arg[ 'desc' ] ) ) {
289
+				$tooltip = $arg[ 'desc' ];
290 290
 			}
291 291
 
292 292
 			// If there's no tooltip set, continue
293
-			if( empty( $tooltip ) ) {
293
+			if ( empty( $tooltip ) ) {
294 294
 				continue;
295 295
 			}
296 296
 
297 297
 			// Add the tooltip
298
-			$gv_tooltips[ 'gv_'.$key ] = array(
299
-				'title'	=> $arg['label'],
298
+			$gv_tooltips[ 'gv_' . $key ] = array(
299
+				'title'	=> $arg[ 'label' ],
300 300
 				'value'	=> $tooltip,
301 301
 			);
302 302
 
303 303
 		}
304 304
 
305
-		$gv_tooltips['gv_css_merge_tags'] = array(
306
-			'title' => __('CSS Merge Tags', 'gravityview'),
307
-			'value' => sprintf( __( 'Developers: The CSS classes will be sanitized using the %ssanitize_title_with_dashes()%s function.', 'gravityview'), '<code>', '</code>' )
305
+		$gv_tooltips[ 'gv_css_merge_tags' ] = array(
306
+			'title' => __( 'CSS Merge Tags', 'gravityview' ),
307
+			'value' => sprintf( __( 'Developers: The CSS classes will be sanitized using the %ssanitize_title_with_dashes()%s function.', 'gravityview' ), '<code>', '</code>' )
308 308
 		);
309 309
 
310 310
 		/**
@@ -322,9 +322,9 @@  discard block
 block discarded – undo
322 322
 
323 323
 		foreach ( $gv_tooltips as $key => $tooltip ) {
324 324
 
325
-			$title = empty( $tooltip['title'] ) ? '' : '<h6>'.esc_html( $tooltip['title'] ) .'</h6>';
325
+			$title = empty( $tooltip[ 'title' ] ) ? '' : '<h6>' . esc_html( $tooltip[ 'title' ] ) . '</h6>';
326 326
 
327
-			$tooltips[ $key ] = $title . wpautop( esc_html( $tooltip['value'] ) );
327
+			$tooltips[ $key ] = $title . wpautop( esc_html( $tooltip[ 'value' ] ) );
328 328
 		}
329 329
 
330 330
 		return $tooltips;
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 	 *
339 339
 	 * @return void
340 340
 	 */
341
-	public function add_custom_column_content( $column_name = NULL, $post_id )	{
341
+	public function add_custom_column_content( $column_name = NULL, $post_id ) {
342 342
 
343 343
 		$output = '';
344 344
 
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 				// Generate backup if label doesn't exist: `example_name` => `Example Name`
361 361
 				$template_id_pretty = ucwords( implode( ' ', explode( '_', $template_id ) ) );
362 362
 
363
-				$output = $template ? $template['label'] : $template_id_pretty;
363
+				$output = $template ? $template[ 'label' ] : $template_id_pretty;
364 364
 
365 365
 				break;
366 366
 
@@ -401,44 +401,44 @@  discard block
 block discarded – undo
401 401
 	static public function get_connected_form_links( $form, $include_form_link = true ) {
402 402
 
403 403
 		// Either the form is empty or the form ID is 0, not yet set.
404
-		if( empty( $form ) ) {
404
+		if ( empty( $form ) ) {
405 405
 			return '';
406 406
 		}
407 407
 
408 408
 		// The $form is passed as the form ID
409
-		if( !is_array( $form ) ) {
409
+		if ( ! is_array( $form ) ) {
410 410
 			$form = gravityview_get_form( $form );
411 411
 		}
412 412
 
413
-		$form_id = $form['id'];
413
+		$form_id = $form[ 'id' ];
414 414
 		$links = array();
415 415
 
416
-		if( GVCommon::has_cap( 'gravityforms_edit_forms' ) ) {
416
+		if ( GVCommon::has_cap( 'gravityforms_edit_forms' ) ) {
417 417
 			$form_url = admin_url( sprintf( 'admin.php?page=gf_edit_forms&amp;id=%d', $form_id ) );
418
-			$form_link = '<strong class="gv-form-title">'.gravityview_get_link( $form_url, $form['title'], 'class=row-title' ).'</strong>';
419
-			$links[] = '<span>'.gravityview_get_link( $form_url, __('Edit Form', 'gravityview') ).'</span>';
418
+			$form_link = '<strong class="gv-form-title">' . gravityview_get_link( $form_url, $form[ 'title' ], 'class=row-title' ) . '</strong>';
419
+			$links[ ] = '<span>' . gravityview_get_link( $form_url, __( 'Edit Form', 'gravityview' ) ) . '</span>';
420 420
 		} else {
421
-			$form_link = '<strong class="gv-form-title">'. esc_html( $form['title'] ). '</strong>';
421
+			$form_link = '<strong class="gv-form-title">' . esc_html( $form[ 'title' ] ) . '</strong>';
422 422
 		}
423 423
 
424
-		if( GVCommon::has_cap( 'gravityforms_view_entries' ) ) {
424
+		if ( GVCommon::has_cap( 'gravityforms_view_entries' ) ) {
425 425
 			$entries_url = admin_url( sprintf( 'admin.php?page=gf_entries&amp;id=%d', $form_id ) );
426
-			$links[] = '<span>'.gravityview_get_link( $entries_url, __('Entries', 'gravityview') ).'</span>';
426
+			$links[ ] = '<span>' . gravityview_get_link( $entries_url, __( 'Entries', 'gravityview' ) ) . '</span>';
427 427
 		}
428 428
 
429
-		if( GVCommon::has_cap( array( 'gravityforms_edit_settings', 'gravityview_view_settings' ) ) ) {
429
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_settings', 'gravityview_view_settings' ) ) ) {
430 430
 			$settings_url = admin_url( sprintf( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id=%d', $form_id ) );
431
-			$links[] = '<span>'.gravityview_get_link( $settings_url, __('Settings', 'gravityview'), 'title='.__('Edit settings for this form', 'gravityview') ).'</span>';
431
+			$links[ ] = '<span>' . gravityview_get_link( $settings_url, __( 'Settings', 'gravityview' ), 'title=' . __( 'Edit settings for this form', 'gravityview' ) ) . '</span>';
432 432
 		}
433 433
 
434
-		if( GVCommon::has_cap( array("gravityforms_edit_forms", "gravityforms_create_form", "gravityforms_preview_forms") ) ) {
434
+		if ( GVCommon::has_cap( array( "gravityforms_edit_forms", "gravityforms_create_form", "gravityforms_preview_forms" ) ) ) {
435 435
 			$preview_url = site_url( sprintf( '?gf_page=preview&amp;id=%d', $form_id ) );
436
-			$links[] = '<span>'.gravityview_get_link( $preview_url, __('Preview Form', 'gravityview'), 'title='.__('Preview this form', 'gravityview') ).'</span>';
436
+			$links[ ] = '<span>' . gravityview_get_link( $preview_url, __( 'Preview Form', 'gravityview' ), 'title=' . __( 'Preview this form', 'gravityview' ) ) . '</span>';
437 437
 		}
438 438
 
439 439
 		$output = '';
440 440
 
441
-		if( !empty( $include_form_link ) ) {
441
+		if ( ! empty( $include_form_link ) ) {
442 442
 			$output .= $form_link;
443 443
 		}
444 444
 
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 		 */
451 451
 		$links = apply_filters( 'gravityview_connected_form_links', $links, $form );
452 452
 
453
-		$output .= '<div class="row-actions">'. implode( ' | ', $links ) .'</div>';
453
+		$output .= '<div class="row-actions">' . implode( ' | ', $links ) . '</div>';
454 454
 
455 455
 		return $output;
456 456
 	}
@@ -464,8 +464,8 @@  discard block
 block discarded – undo
464 464
 		// Get the date column and save it for later to add back in.
465 465
 		// This adds it after the Data Source column.
466 466
 		// This way, we don't need to do array_slice, array_merge, etc.
467
-		$date = $columns['date'];
468
-		unset( $columns['date'] );
467
+		$date = $columns[ 'date' ];
468
+		unset( $columns[ 'date' ] );
469 469
 
470 470
 		$data_source_required_caps = array(
471 471
 			'gravityforms_edit_forms',
@@ -476,14 +476,14 @@  discard block
 block discarded – undo
476 476
 			'gravityforms_preview_forms',
477 477
 		);
478 478
 
479
-		if( GVCommon::has_cap( $data_source_required_caps ) ) {
480
-			$columns['gv_connected_form'] = __( 'Data Source', 'gravityview' );
479
+		if ( GVCommon::has_cap( $data_source_required_caps ) ) {
480
+			$columns[ 'gv_connected_form' ] = __( 'Data Source', 'gravityview' );
481 481
 		}
482 482
 
483
-		$columns['gv_template'] = _x( 'Template', 'Column title that shows what template is being used for Views', 'gravityview' );
483
+		$columns[ 'gv_template' ] = _x( 'Template', 'Column title that shows what template is being used for Views', 'gravityview' );
484 484
 
485 485
 		// Add the date back in.
486
-		$columns['date'] = $date;
486
+		$columns[ 'date' ] = $date;
487 487
 
488 488
 		return $columns;
489 489
 	}
@@ -497,12 +497,12 @@  discard block
 block discarded – undo
497 497
 	 */
498 498
 	function save_postdata( $post_id ) {
499 499
 
500
-		if( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ){
500
+		if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
501 501
 			return;
502 502
 		}
503 503
 
504 504
 		// validate post_type
505
-		if ( ! isset( $_POST['post_type'] ) || 'gravityview' != $_POST['post_type'] ) {
505
+		if ( ! isset( $_POST[ 'post_type' ] ) || 'gravityview' != $_POST[ 'post_type' ] ) {
506 506
 			return;
507 507
 		}
508 508
 
@@ -517,65 +517,65 @@  discard block
 block discarded – undo
517 517
 		$statii = array();
518 518
 
519 519
 		// check if this is a start fresh View
520
-		if ( isset( $_POST['gravityview_select_form_nonce'] ) && wp_verify_nonce( $_POST['gravityview_select_form_nonce'], 'gravityview_select_form' ) ) {
520
+		if ( isset( $_POST[ 'gravityview_select_form_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_select_form_nonce' ], 'gravityview_select_form' ) ) {
521 521
 
522
-			$form_id = !empty( $_POST['gravityview_form_id'] ) ? $_POST['gravityview_form_id'] : '';
522
+			$form_id = ! empty( $_POST[ 'gravityview_form_id' ] ) ? $_POST[ 'gravityview_form_id' ] : '';
523 523
 			// save form id
524
-			$statii['form_id'] = update_post_meta( $post_id, '_gravityview_form_id', $form_id );
524
+			$statii[ 'form_id' ] = update_post_meta( $post_id, '_gravityview_form_id', $form_id );
525 525
 
526 526
 		}
527 527
 
528
-		if( false === GVCommon::has_cap( 'gravityforms_create_form' ) && empty( $statii['form_id'] ) ) {
528
+		if ( false === GVCommon::has_cap( 'gravityforms_create_form' ) && empty( $statii[ 'form_id' ] ) ) {
529 529
 			gravityview()->log->error( 'Current user does not have the capability to create a new Form.', array( 'data' => wp_get_current_user() ) );
530 530
 			return;
531 531
 		}
532 532
 
533 533
 		// Was this a start fresh?
534
-		if ( ! empty( $_POST['gravityview_form_id_start_fresh'] ) ) {
535
-			$statii['start_fresh'] = add_post_meta( $post_id, '_gravityview_start_fresh', 1 );
534
+		if ( ! empty( $_POST[ 'gravityview_form_id_start_fresh' ] ) ) {
535
+			$statii[ 'start_fresh' ] = add_post_meta( $post_id, '_gravityview_start_fresh', 1 );
536 536
 		} else {
537
-			$statii['start_fresh'] = delete_post_meta( $post_id, '_gravityview_start_fresh' );
537
+			$statii[ 'start_fresh' ] = delete_post_meta( $post_id, '_gravityview_start_fresh' );
538 538
 		}
539 539
 
540 540
 		// Check if we have a template id
541
-		if ( isset( $_POST['gravityview_select_template_nonce'] ) && wp_verify_nonce( $_POST['gravityview_select_template_nonce'], 'gravityview_select_template' ) ) {
541
+		if ( isset( $_POST[ 'gravityview_select_template_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_select_template_nonce' ], 'gravityview_select_template' ) ) {
542 542
 
543
-			$template_id = !empty( $_POST['gravityview_directory_template'] ) ? $_POST['gravityview_directory_template'] : '';
543
+			$template_id = ! empty( $_POST[ 'gravityview_directory_template' ] ) ? $_POST[ 'gravityview_directory_template' ] : '';
544 544
 
545 545
 			// now save template id
546
-			$statii['directory_template'] = update_post_meta( $post_id, '_gravityview_directory_template', $template_id );
546
+			$statii[ 'directory_template' ] = update_post_meta( $post_id, '_gravityview_directory_template', $template_id );
547 547
 		}
548 548
 
549 549
 
550 550
 		// save View Configuration metabox
551
-		if ( isset( $_POST['gravityview_view_configuration_nonce'] ) && wp_verify_nonce( $_POST['gravityview_view_configuration_nonce'], 'gravityview_view_configuration' ) ) {
551
+		if ( isset( $_POST[ 'gravityview_view_configuration_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_view_configuration_nonce' ], 'gravityview_view_configuration' ) ) {
552 552
 
553 553
 			// template settings
554
-			if( empty( $_POST['template_settings'] ) ) {
555
-				$_POST['template_settings'] = array();
554
+			if ( empty( $_POST[ 'template_settings' ] ) ) {
555
+				$_POST[ 'template_settings' ] = array();
556 556
 			}
557
-			$statii['template_settings'] = update_post_meta( $post_id, '_gravityview_template_settings', $_POST['template_settings'] );
557
+			$statii[ 'template_settings' ] = update_post_meta( $post_id, '_gravityview_template_settings', $_POST[ 'template_settings' ] );
558 558
 
559 559
 			$fields = array();
560 560
 
561 561
 			// Directory&single Visible Fields
562
-			if( !empty( $preset_fields ) ) {
562
+			if ( ! empty( $preset_fields ) ) {
563 563
 
564 564
 				$fields = $preset_fields;
565 565
 
566
-			} elseif( !empty( $_POST['gv_fields'] ) ) {
566
+			} elseif ( ! empty( $_POST[ 'gv_fields' ] ) ) {
567 567
 				$fields = _gravityview_process_posted_fields();
568 568
 			}
569 569
 
570 570
 			$fields = wp_slash( $fields );
571 571
 
572
-			$statii['directory_fields'] = update_post_meta( $post_id, '_gravityview_directory_fields', $fields );
572
+			$statii[ 'directory_fields' ] = update_post_meta( $post_id, '_gravityview_directory_fields', $fields );
573 573
 
574 574
 			// Directory Visible Widgets
575
-			if( empty( $_POST['widgets'] ) ) {
576
-				$_POST['widgets'] = array();
575
+			if ( empty( $_POST[ 'widgets' ] ) ) {
576
+				$_POST[ 'widgets' ] = array();
577 577
 			}
578
-			$statii['directory_widgets'] = gravityview_set_directory_widgets( $post_id, $_POST['widgets'] );
578
+			$statii[ 'directory_widgets' ] = gravityview_set_directory_widgets( $post_id, $_POST[ 'widgets' ] );
579 579
 
580 580
 		} // end save view configuration
581 581
 
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
 		 * @param array $statii Array of statuses of the post meta saving processes. If saving worked, each key should be mapped to a value of the post ID (`directory_widgets` => `124`). If failed (or didn't change), the value will be false.
586 586
 		 * @since 1.17.2
587 587
 		 */
588
-		do_action('gravityview_view_saved', $post_id, $statii );
588
+		do_action( 'gravityview_view_saved', $post_id, $statii );
589 589
 
590 590
 		gravityview()->log->debug( '[save_postdata] Update Post Meta Statuses (also returns false if nothing changed)', array( 'data' => array_map( 'intval', $statii ) ) );
591 591
 	}
@@ -629,20 +629,20 @@  discard block
 block discarded – undo
629 629
 
630 630
 		$output = '';
631 631
 
632
-		if( !empty( $fields ) ) {
632
+		if ( ! empty( $fields ) ) {
633 633
 
634
-			foreach( $fields as $id => $details ) {
634
+			foreach ( $fields as $id => $details ) {
635 635
 
636
-				if( in_array( $details['type'], (array) $blacklist_field_types ) ) {
636
+				if ( in_array( $details[ 'type' ], (array)$blacklist_field_types ) ) {
637 637
 					continue;
638 638
 				}
639 639
 
640 640
 				// Edit mode only allows editing the parent fields, not single inputs.
641
-				if( $context === 'edit' && !empty( $details['parent'] ) ) {
641
+				if ( $context === 'edit' && ! empty( $details[ 'parent' ] ) ) {
642 642
 					continue;
643 643
 				}
644 644
 
645
-				$output .= new GravityView_Admin_View_Field( $details['label'], $id, $details, $settings = array(), $form );
645
+				$output .= new GravityView_Admin_View_Field( $details[ 'label' ], $id, $details, $settings = array(), $form );
646 646
 
647 647
 			} // End foreach
648 648
 		}
@@ -650,7 +650,7 @@  discard block
 block discarded – undo
650 650
 		echo $output;
651 651
 
652 652
 		// For the EDIT view we only want to allow the form fields.
653
-		if( $context === 'edit' ) {
653
+		if ( $context === 'edit' ) {
654 654
 			return;
655 655
 		}
656 656
 
@@ -674,16 +674,16 @@  discard block
 block discarded – undo
674 674
 		$additional_fields = apply_filters( 'gravityview_additional_fields', array(
675 675
 			array(
676 676
 				'label_text' => __( '+ Add All Fields', 'gravityview' ),
677
-				'desc' => __('Add all the available fields at once.', 'gravityview'),
677
+				'desc' => __( 'Add all the available fields at once.', 'gravityview' ),
678 678
 				'field_id' => 'all-fields',
679 679
 				'label_type' => 'field',
680 680
 				'input_type' => NULL,
681 681
 				'field_options' => NULL,
682 682
 				'settings_html'	=> NULL,
683 683
 			)
684
-		));
684
+		) );
685 685
 
686
-		if( !empty( $additional_fields )) {
686
+		if ( ! empty( $additional_fields ) ) {
687 687
 			foreach ( (array)$additional_fields as $item ) {
688 688
 
689 689
 				// Prevent items from not having index set
@@ -694,16 +694,16 @@  discard block
 block discarded – undo
694 694
 					'input_type' => NULL,
695 695
 					'field_options' => NULL,
696 696
 					'settings_html'	=> NULL,
697
-				));
697
+				) );
698 698
 
699 699
 				// Backward compat.
700
-				if( !empty( $item['field_options'] ) ) {
700
+				if ( ! empty( $item[ 'field_options' ] ) ) {
701 701
 					// Use settings_html from now on.
702
-					$item['settings_html'] = $item['field_options'];
702
+					$item[ 'settings_html' ] = $item[ 'field_options' ];
703 703
 				}
704 704
 
705 705
 				// Render a label for each of them
706
-				echo new GravityView_Admin_View_Field( $item['label_text'], $item['field_id'], $item, $settings = array(), $form );
706
+				echo new GravityView_Admin_View_Field( $item[ 'label_text' ], $item[ 'field_id' ], $item, $settings = array(), $form );
707 707
 
708 708
 			}
709 709
 		}
@@ -716,54 +716,54 @@  discard block
 block discarded – undo
716 716
 	 * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
717 717
 	 * @return array
718 718
 	 */
719
-	function get_entry_default_fields($form, $zone) {
719
+	function get_entry_default_fields( $form, $zone ) {
720 720
 
721 721
 		$entry_default_fields = array();
722 722
 
723
-		if( in_array( $zone, array( 'directory', 'single' ) ) ) {
723
+		if ( in_array( $zone, array( 'directory', 'single' ) ) ) {
724 724
 
725 725
 			$entry_default_fields = array(
726 726
 				'id' => array(
727
-					'label' => __('Entry ID', 'gravityview'),
727
+					'label' => __( 'Entry ID', 'gravityview' ),
728 728
 					'type' => 'id',
729
-					'desc'	=> __('The unique ID of the entry.', 'gravityview'),
729
+					'desc'	=> __( 'The unique ID of the entry.', 'gravityview' ),
730 730
 				),
731 731
 				'date_created' => array(
732
-					'label' => __('Entry Date', 'gravityview'),
733
-					'desc'	=> __('The date the entry was created.', 'gravityview'),
732
+					'label' => __( 'Entry Date', 'gravityview' ),
733
+					'desc'	=> __( 'The date the entry was created.', 'gravityview' ),
734 734
 					'type' => 'date_created',
735 735
 				),
736 736
 				'source_url' => array(
737
-					'label' => __('Source URL', 'gravityview'),
737
+					'label' => __( 'Source URL', 'gravityview' ),
738 738
 					'type' => 'source_url',
739
-					'desc'	=> __('The URL of the page where the form was submitted.', 'gravityview'),
739
+					'desc'	=> __( 'The URL of the page where the form was submitted.', 'gravityview' ),
740 740
 				),
741 741
 				'ip' => array(
742
-					'label' => __('User IP', 'gravityview'),
742
+					'label' => __( 'User IP', 'gravityview' ),
743 743
 					'type' => 'ip',
744
-					'desc'	=> __('The IP Address of the user who created the entry.', 'gravityview'),
744
+					'desc'	=> __( 'The IP Address of the user who created the entry.', 'gravityview' ),
745 745
 				),
746 746
 				'created_by' => array(
747
-					'label' => __('User', 'gravityview'),
747
+					'label' => __( 'User', 'gravityview' ),
748 748
 					'type' => 'created_by',
749
-					'desc'	=> __('Details of the logged-in user who created the entry (if any).', 'gravityview'),
749
+					'desc'	=> __( 'Details of the logged-in user who created the entry (if any).', 'gravityview' ),
750 750
 				),
751 751
 
752 752
 				/**
753 753
 				 * @since 1.7.2
754 754
 				 */
755 755
 			    'other_entries' => array(
756
-				    'label'	=> __('Other Entries', 'gravityview'),
756
+				    'label'	=> __( 'Other Entries', 'gravityview' ),
757 757
 				    'type'	=> 'other_entries',
758
-				    'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
758
+				    'desc'	=> __( 'Display other entries created by the entry creator.', 'gravityview' ),
759 759
 			    ),
760 760
 	        );
761 761
 
762
-			if( 'single' !== $zone) {
762
+			if ( 'single' !== $zone ) {
763 763
 
764
-				$entry_default_fields['entry_link'] = array(
765
-					'label' => __('Link to Entry', 'gravityview'),
766
-					'desc'	=> __('A dedicated link to the single entry with customizable text.', 'gravityview'),
764
+				$entry_default_fields[ 'entry_link' ] = array(
765
+					'label' => __( 'Link to Entry', 'gravityview' ),
766
+					'desc'	=> __( 'A dedicated link to the single entry with customizable text.', 'gravityview' ),
767 767
 					'type' => 'entry_link',
768 768
 				);
769 769
 			}
@@ -773,19 +773,19 @@  discard block
 block discarded – undo
773 773
 		/**
774 774
 		 * @since  1.2
775 775
 		 */
776
-		$entry_default_fields['custom']	= array(
777
-			'label'	=> __('Custom Content', 'gravityview'),
776
+		$entry_default_fields[ 'custom' ] = array(
777
+			'label'	=> __( 'Custom Content', 'gravityview' ),
778 778
 			'type'	=> 'custom',
779
-			'desc'	=> __('Insert custom text or HTML.', 'gravityview'),
779
+			'desc'	=> __( 'Insert custom text or HTML.', 'gravityview' ),
780 780
 		);
781 781
 
782 782
 		/**
783 783
 		 * @since develop
784 784
 		 */
785
-		$entry_default_fields['sequence'] = array(
786
-			'label'	=> __('Result Number', 'gravityview'),
785
+		$entry_default_fields[ 'sequence' ] = array(
786
+			'label'	=> __( 'Result Number', 'gravityview' ),
787 787
 			'type'	=> 'sequence',
788
-			'desc'	=> __('Display a sequential result number for each entry.', 'gravityview'),
788
+			'desc'	=> __( 'Display a sequential result number for each entry.', 'gravityview' ),
789 789
 		);
790 790
 
791 791
 		/**
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 		 * @param  string|array $form form_ID or form object
795 795
 		 * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
796 796
 		 */
797
-		return apply_filters( 'gravityview_entry_default_fields', $entry_default_fields, $form, $zone);
797
+		return apply_filters( 'gravityview_entry_default_fields', $entry_default_fields, $form, $zone );
798 798
 	}
799 799
 
800 800
 	/**
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
 	 */
806 806
 	function get_available_fields( $form = '', $zone = NULL ) {
807 807
 
808
-		if( empty( $form ) ) {
808
+		if ( empty( $form ) ) {
809 809
 			gravityview()->log->error( '$form is empty' );
810 810
 			return array();
811 811
 		}
@@ -814,7 +814,7 @@  discard block
 block discarded – undo
814 814
 		$fields = gravityview_get_form_fields( $form, true );
815 815
 
816 816
 		// get meta fields ( only if form was already created )
817
-		if( !is_array( $form ) ) {
817
+		if ( ! is_array( $form ) ) {
818 818
 			$meta_fields = gravityview_get_entry_meta( $form );
819 819
 		} else {
820 820
 			$meta_fields = array();
@@ -827,7 +827,7 @@  discard block
 block discarded – undo
827 827
 		$fields = $fields + $meta_fields + $default_fields;
828 828
 
829 829
 		// Move Custom Content to top
830
-		$fields = array( 'custom' => $fields['custom'] ) + $fields;
830
+		$fields = array( 'custom' => $fields[ 'custom' ] ) + $fields;
831 831
 
832 832
 		return $fields;
833 833
 	}
@@ -841,11 +841,11 @@  discard block
 block discarded – undo
841 841
 
842 842
 		$widgets = $this->get_registered_widgets();
843 843
 
844
-		if( !empty( $widgets ) ) {
844
+		if ( ! empty( $widgets ) ) {
845 845
 
846
-			foreach( $widgets as $id => $details ) {
846
+			foreach ( $widgets as $id => $details ) {
847 847
 
848
-				echo new GravityView_Admin_View_Widget( $details['label'], $id, $details );
848
+				echo new GravityView_Admin_View_Widget( $details[ 'label' ], $id, $details );
849 849
 
850 850
 			}
851 851
 		}
@@ -874,7 +874,7 @@  discard block
 block discarded – undo
874 874
 	function render_active_areas( $template_id, $type, $zone, $rows, $values ) {
875 875
 		global $post;
876 876
 
877
-		if( $type === 'widget' ) {
877
+		if ( $type === 'widget' ) {
878 878
 			$button_label = __( 'Add Widget', 'gravityview' );
879 879
 		} else {
880 880
 			$button_label = __( 'Add Field', 'gravityview' );
@@ -886,10 +886,10 @@  discard block
 block discarded – undo
886 886
 		$form_id = null;
887 887
 
888 888
 		// if saved values, get available fields to label everyone
889
-		if( !empty( $values ) && ( !empty( $post->ID ) || !empty( $_POST['template_id'] ) ) ) {
889
+		if ( ! empty( $values ) && ( ! empty( $post->ID ) || ! empty( $_POST[ 'template_id' ] ) ) ) {
890 890
 
891
-			if( !empty( $_POST['template_id'] ) ) {
892
-				$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
891
+			if ( ! empty( $_POST[ 'template_id' ] ) ) {
892
+				$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
893 893
 			} else {
894 894
 				$form_id = $form = gravityview_get_form_id( $post->ID );
895 895
 			}
@@ -907,44 +907,44 @@  discard block
 block discarded – undo
907 907
 			}
908 908
 		}
909 909
 
910
-		foreach( $rows as $row ) :
911
-			foreach( $row as $col => $areas ) :
912
-				$column = ($col == '2-2') ? '1-2' : $col; ?>
910
+		foreach ( $rows as $row ) :
911
+			foreach ( $row as $col => $areas ) :
912
+				$column = ( $col == '2-2' ) ? '1-2' : $col; ?>
913 913
 
914 914
 				<div class="gv-grid-col-<?php echo esc_attr( $column ); ?>">
915 915
 
916
-					<?php foreach( $areas as $area ) : 	?>
916
+					<?php foreach ( $areas as $area ) : 	?>
917 917
 
918
-						<div class="gv-droppable-area" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>">
919
-							<div class="active-drop active-drop-<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>">
918
+						<div class="gv-droppable-area" data-areaid="<?php echo esc_attr( $zone . '_' . $area[ 'areaid' ] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>">
919
+							<div class="active-drop active-drop-<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone . '_' . $area[ 'areaid' ] ); ?>">
920 920
 
921 921
 								<?php // render saved fields
922 922
 
923
-								if( ! empty( $values[ $zone .'_'. $area['areaid'] ] ) ) {
923
+								if ( ! empty( $values[ $zone . '_' . $area[ 'areaid' ] ] ) ) {
924 924
 
925
-									foreach( $values[ $zone .'_'. $area['areaid'] ] as $uniqid => $field ) {
925
+									foreach ( $values[ $zone . '_' . $area[ 'areaid' ] ] as $uniqid => $field ) {
926 926
 
927 927
 										// Maybe has a form ID
928
-										$form_id = empty( $field['form_id'] ) ? $form_id : $field['form_id'];
928
+										$form_id = empty( $field[ 'form_id' ] ) ? $form_id : $field[ 'form_id' ];
929 929
 
930 930
 										$input_type = NULL;
931 931
 
932 932
 										if ( $form_id ) {
933
-											$original_item = isset( $available_items[ $form_id ] [ $field['id'] ] ) ? $available_items[ $form_id ] [ $field['id'] ] : false ;
933
+											$original_item = isset( $available_items[ $form_id ] [ $field[ 'id' ] ] ) ? $available_items[ $form_id ] [ $field[ 'id' ] ] : false;
934 934
                                         } else {
935
-											$original_item = isset( $available_items[ $field['id'] ] ) ? $available_items[ $field['id'] ] : false ;
935
+											$original_item = isset( $available_items[ $field[ 'id' ] ] ) ? $available_items[ $field[ 'id' ] ] : false;
936 936
                                         }
937 937
 
938
-										if ( !$original_item ) {
939
-											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array(' data' => array('available_items' => $available_items, 'field' => $field ) ) );
938
+										if ( ! $original_item ) {
939
+											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array( ' data' => array( 'available_items' => $available_items, 'field' => $field ) ) );
940 940
 
941 941
 											$original_item = $field;
942 942
 										} else {
943
-											$input_type = isset( $original_item['type'] ) ? $original_item['type'] : NULL;
943
+											$input_type = isset( $original_item[ 'type' ] ) ? $original_item[ 'type' ] : NULL;
944 944
 										}
945 945
 
946 946
 										// Field options dialog box
947
-										$field_options = GravityView_Render_Settings::render_field_options( $form_id, $type, $template_id, $field['id'], $original_item['label'], $zone .'_'. $area['areaid'], $input_type, $uniqid, $field, $zone, $original_item );
947
+										$field_options = GravityView_Render_Settings::render_field_options( $form_id, $type, $template_id, $field[ 'id' ], $original_item[ 'label' ], $zone . '_' . $area[ 'areaid' ], $input_type, $uniqid, $field, $zone, $original_item );
948 948
 
949 949
 										$item = array(
950 950
 											'input_type' => $input_type,
@@ -957,23 +957,23 @@  discard block
 block discarded – undo
957 957
 											$item = wp_parse_args( $item, $original_item );
958 958
 										}
959 959
 
960
-										switch( $type ) {
960
+										switch ( $type ) {
961 961
 											case 'widget':
962
-												echo new GravityView_Admin_View_Widget( $item['label'], $field['id'], $item, $field );
962
+												echo new GravityView_Admin_View_Widget( $item[ 'label' ], $field[ 'id' ], $item, $field );
963 963
 												break;
964 964
 											default:
965
-												echo new GravityView_Admin_View_Field( $field['label'], $field['id'], $item, $field, $form_id );
965
+												echo new GravityView_Admin_View_Field( $field[ 'label' ], $field[ 'id' ], $item, $field, $form_id );
966 966
 										}
967 967
 									}
968 968
 
969 969
 								} // End if zone is not empty ?>
970 970
 
971
-								<span class="drop-message"><?php echo sprintf(esc_attr__('"+ %s" or drag existing %ss here.', 'gravityview'), $button_label, $type ); ?></span>
971
+								<span class="drop-message"><?php echo sprintf( esc_attr__( '"+ %s" or drag existing %ss here.', 'gravityview' ), $button_label, $type ); ?></span>
972 972
 							</div>
973 973
 							<div class="gv-droppable-area-action">
974
-								<a href="#" class="gv-add-field button-secondary" title="" data-objecttype="<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>" data-formid="<?php echo $view ? esc_attr( $view->form ? $view->form->ID : '' ) : ''; ?>"><?php echo '+ '.esc_html( $button_label ); ?></a>
974
+								<a href="#" class="gv-add-field button-secondary" title="" data-objecttype="<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone . '_' . $area[ 'areaid' ] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>" data-formid="<?php echo $view ? esc_attr( $view->form ? $view->form->ID : '' ) : ''; ?>"><?php echo '+ ' . esc_html( $button_label ); ?></a>
975 975
 
976
-								<p class="gv-droppable-area-title"><strong><?php echo esc_html( $area['title'] ); ?></strong><?php if( !empty( $area['subtitle'] ) ) { ?><span class="gv-droppable-area-subtitle"> &ndash; <?php echo esc_html( $area['subtitle'] ); ?></span><?php } ?></p>
976
+								<p class="gv-droppable-area-title"><strong><?php echo esc_html( $area[ 'title' ] ); ?></strong><?php if ( ! empty( $area[ 'subtitle' ] ) ) { ?><span class="gv-droppable-area-subtitle"> &ndash; <?php echo esc_html( $area[ 'subtitle' ] ); ?></span><?php } ?></p>
977 977
 							</div>
978 978
 						</div>
979 979
 
@@ -996,7 +996,7 @@  discard block
 block discarded – undo
996 996
 		$default_widget_areas = \GV\Widget::get_default_widget_areas();
997 997
 
998 998
 		$widgets = array();
999
-		if( !empty( $post_id ) ) {
999
+		if ( ! empty( $post_id ) ) {
1000 1000
 			$widgets = gravityview_get_directory_widgets( $post_id );
1001 1001
 		}
1002 1002
 
@@ -1029,7 +1029,7 @@  discard block
 block discarded – undo
1029 1029
 		// list of available fields to be shown in the popup
1030 1030
 		$forms = gravityview_get_forms( 'any' );
1031 1031
 
1032
-		$form_ids = array_map( function ($form) { return $form['id']; }, $forms);
1032
+		$form_ids = array_map( function( $form ) { return $form[ 'id' ]; }, $forms );
1033 1033
 
1034 1034
 		foreach ( $form_ids as $form_id ) {
1035 1035
 			$filter_field_id = sprintf( 'gv-field-filter-%s-%d', $context, $form_id );
@@ -1042,7 +1042,7 @@  discard block
 block discarded – undo
1042 1042
                 </div>
1043 1043
 
1044 1044
                 <div id="available-fields-<?php echo $filter_field_id; ?>" aria-live="polite" role="listbox">
1045
-                <?php do_action('gravityview_render_available_fields', $form_id, $context ); ?>
1045
+                <?php do_action( 'gravityview_render_available_fields', $form_id, $context ); ?>
1046 1046
                 </div>
1047 1047
 
1048 1048
                 <div class="gv-no-results hidden description"><?php esc_html_e( 'No fields were found matching the search.', 'gravityview' ); ?></div>
@@ -1061,7 +1061,7 @@  discard block
 block discarded – undo
1061 1061
 	 * @return string HTML of the active areas
1062 1062
 	 */
1063 1063
 	function render_directory_active_areas( $template_id = '', $context = 'single', $post_id = '', $echo = false ) {
1064
-		if( empty( $template_id ) ) {
1064
+		if ( empty( $template_id ) ) {
1065 1065
 			gravityview()->log->debug( '[render_directory_active_areas] {template_id} is empty', array( 'template_id' => $template_id ) );
1066 1066
 			return '';
1067 1067
 		}
@@ -1075,12 +1075,12 @@  discard block
 block discarded – undo
1075 1075
 		 */
1076 1076
 		$template_areas = apply_filters( 'gravityview_template_active_areas', array(), $template_id, $context );
1077 1077
 
1078
-		if( empty( $template_areas ) ) {
1078
+		if ( empty( $template_areas ) ) {
1079 1079
 
1080 1080
 			gravityview()->log->debug( '[render_directory_active_areas] No areas defined. Maybe template {template_id} is disabled.', array( 'data' => $template_id ) );
1081 1081
 			$output = '<div>';
1082
-			$output .= '<h2 class="description" style="font-size: 16px; margin:0">'. sprintf( esc_html__( 'This View is configured using the %s View type, which is disabled.', 'gravityview' ), '<em>'.$template_id.'</em>' ) .'</h2>';
1083
-			$output .= '<p class="description" style="font-size: 14px; margin:0 0 1em 0;padding:0">'.esc_html__('The data is not lost; re-activate the associated plugin and the configuration will re-appear.', 'gravityview').'</p>';
1082
+			$output .= '<h2 class="description" style="font-size: 16px; margin:0">' . sprintf( esc_html__( 'This View is configured using the %s View type, which is disabled.', 'gravityview' ), '<em>' . $template_id . '</em>' ) . '</h2>';
1083
+			$output .= '<p class="description" style="font-size: 14px; margin:0 0 1em 0;padding:0">' . esc_html__( 'The data is not lost; re-activate the associated plugin and the configuration will re-appear.', 'gravityview' ) . '</p>';
1084 1084
 			$output .= '</div>';
1085 1085
 		} else {
1086 1086
 
@@ -1095,7 +1095,7 @@  discard block
 block discarded – undo
1095 1095
 
1096 1096
 		}
1097 1097
 
1098
-		if( $echo ) {
1098
+		if ( $echo ) {
1099 1099
 			echo $output;
1100 1100
 		}
1101 1101
 
@@ -1115,32 +1115,32 @@  discard block
 block discarded – undo
1115 1115
 		$is_widgets_page = ( $pagenow === 'widgets.php' );
1116 1116
 
1117 1117
 		// Add the GV font (with the Astronaut)
1118
-        wp_enqueue_style( 'gravityview_global', plugins_url('assets/css/admin-global.css', GRAVITYVIEW_FILE), array(), \GV\Plugin::$version );
1118
+        wp_enqueue_style( 'gravityview_global', plugins_url( 'assets/css/admin-global.css', GRAVITYVIEW_FILE ), array(), \GV\Plugin::$version );
1119 1119
 		wp_register_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array( 'dashicons', 'wp-jquery-ui-dialog' ), \GV\Plugin::$version );
1120 1120
 
1121
-		wp_register_script( 'gravityview-jquery-cookie', plugins_url('assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE), array( 'jquery' ), \GV\Plugin::$version, true );
1121
+		wp_register_script( 'gravityview-jquery-cookie', plugins_url( 'assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE ), array( 'jquery' ), \GV\Plugin::$version, true );
1122 1122
 
1123
-		if( GFForms::get_page() === 'form_list' ) {
1123
+		if ( GFForms::get_page() === 'form_list' ) {
1124 1124
 			wp_enqueue_style( 'gravityview_views_styles' );
1125 1125
 			return;
1126 1126
         }
1127 1127
 
1128 1128
 		// Don't process any scripts below here if it's not a GravityView page.
1129
-		if( ! gravityview()->request->is_admin( $hook, 'single' ) && ! $is_widgets_page ) {
1129
+		if ( ! gravityview()->request->is_admin( $hook, 'single' ) && ! $is_widgets_page ) {
1130 1130
 		    return;
1131 1131
 		}
1132 1132
 
1133 1133
         wp_enqueue_script( 'jquery-ui-datepicker' );
1134
-        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), \GV\Plugin::$version );
1134
+        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url( 'assets/css/admin-datepicker.css', GRAVITYVIEW_FILE ), \GV\Plugin::$version );
1135 1135
 
1136
-        $script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1136
+        $script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
1137 1137
 
1138 1138
         //enqueue scripts
1139 1139
         wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), \GV\Plugin::$version );
1140 1140
 
1141
-        wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1141
+        wp_localize_script( 'gravityview_views_scripts', 'gvGlobals', array(
1142 1142
             'cookiepath' => COOKIEPATH,
1143
-            'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1143
+            'passed_form_id' => (bool)\GV\Utils::_GET( 'form_id' ),
1144 1144
             'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1145 1145
             'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1146 1146
             'label_close' => __( 'Close', 'gravityview' ),
@@ -1152,7 +1152,7 @@  discard block
 block discarded – undo
1152 1152
             'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1153 1153
             'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1154 1154
             'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1155
-        ));
1155
+        ) );
1156 1156
 
1157 1157
 		wp_enqueue_style( 'gravityview_views_styles' );
1158 1158
 
@@ -1179,7 +1179,7 @@  discard block
 block discarded – undo
1179 1179
 		);
1180 1180
 
1181 1181
 		if ( wp_is_mobile() ) {
1182
-		    $scripts[] = 'jquery-touch-punch';
1182
+		    $scripts[ ] = 'jquery-touch-punch';
1183 1183
 		}
1184 1184
 
1185 1185
 		wp_enqueue_script( $scripts );
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +68 added lines, -69 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) { 
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -300,13 +300,13 @@  discard block
 block discarded – undo
300 300
 			return $content;
301 301
 		}
302 302
 
303
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
303
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
304 304
 
305 305
 		/**
306 306
 		 * Editing a single entry.
307 307
 		 */
308 308
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
309
-			if ( $entry['status'] != 'active' ) {
309
+			if ( $entry[ 'status' ] != 'active' ) {
310 310
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
311 311
 				return __( 'You are not allowed to view this content.', 'gravityview' );
312 312
 			}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 			}
318 318
 
319 319
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
320
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
320
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
321 321
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
322 322
 					return __( 'You are not allowed to view this content.', 'gravityview' );
323 323
 				}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 
341 341
 			foreach ( $entryset as $e ) {
342 342
 
343
-				if ( 'active' !== $e['status'] ) {
343
+				if ( 'active' !== $e[ 'status' ] ) {
344 344
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
345 345
 					return __( 'You are not allowed to view this content.', 'gravityview' );
346 346
 				}
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 				}
352 352
 
353 353
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
354
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
354
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
355 355
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
356 356
 						return __( 'You are not allowed to view this content.', 'gravityview' );
357 357
 					}
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
527 527
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
528 528
 
529
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
529
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
530 530
 		}
531 531
 
532 532
 		return $joins;
@@ -621,13 +621,13 @@  discard block
 block discarded – undo
621 621
 			}
622 622
 
623 623
 			foreach ( $_fields as $field ) {
624
-				if ( ! empty( $field['unions'] ) ) {
625
-					foreach ( $field['unions'] as $form_id => $field_id ) {
624
+				if ( ! empty( $field[ 'unions' ] ) ) {
625
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
626 626
 						if ( ! isset( $unions[ $form_id ] ) ) {
627 627
 							$unions[ $form_id ] = array();
628 628
 						}
629 629
 
630
-						$unions[ $form_id ][ $field['id'] ] =
630
+						$unions[ $form_id ][ $field[ 'id' ] ] =
631 631
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
632 632
 					}
633 633
 				}
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
 		if ( ! $view->form ) {
677 677
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
678 678
 				'view_id' => $view->ID,
679
-				'form_id' => $view->_gravityview_form_id ? : 0,
679
+				'form_id' => $view->_gravityview_form_id ?: 0,
680 680
 			) );
681 681
 		}
682 682
 
@@ -915,11 +915,11 @@  discard block
 block discarded – undo
915 915
 			 * Remove multiple sorting before calling legacy filters.
916 916
 			 * This allows us to fake it till we make it.
917 917
 			 */
918
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
918
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
919 919
 				$has_multisort = true;
920
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
921
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
922
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
920
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
921
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
922
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
923 923
 				}
924 924
 			}
925 925
 
@@ -927,34 +927,33 @@  discard block
 block discarded – undo
927 927
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
928 928
 			 */
929 929
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
930
-			$parameters['context_view_id'] = $this->ID;
930
+			$parameters[ 'context_view_id' ] = $this->ID;
931 931
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
932 932
 
933 933
 			if ( $request instanceof REST\Request ) {
934 934
 				$atts = $this->settings->as_atts();
935 935
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
936
-						'paging' => array( 'page_size' => $atts['page_size'] ),
936
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
937 937
 					) );
938
-				$parameters['paging'] = $paging_parameters['paging'];
938
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
939 939
 			}
940 940
 
941
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
942
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
941
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
943 942
 
944 943
 			/**
945 944
 			 * Cleanup duplicate field_filter parameters to simplify the query.
946 945
 			 */
947 946
 			$unique_field_filters = array();
948
-			foreach ( $parameters['search_criteria']['field_filters'] as $key => $filter ) {
947
+			foreach ( $parameters[ 'search_criteria' ][ 'field_filters' ] as $key => $filter ) {
949 948
 				if ( 'mode' === $key ) {
950
-					$unique_field_filters['mode'] = $filter;
949
+					$unique_field_filters[ 'mode' ] = $filter;
951 950
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
952
-					$unique_field_filters[] = $filter;
951
+					$unique_field_filters[ ] = $filter;
953 952
 				}
954 953
 			}
955
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
954
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
956 955
 
957
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
956
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
958 957
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
959 958
 			}
960 959
 
@@ -963,7 +962,7 @@  discard block
 block discarded – undo
963 962
 				$query_class = $this->get_query_class();
964 963
 
965 964
 				/** @var \GF_Query $query */
966
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
965
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
967 966
 
968 967
 				/**
969 968
 				 * Apply multisort.
@@ -974,15 +973,15 @@  discard block
 block discarded – undo
974 973
 					$view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
975 974
 					$view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
976 975
 
977
-					$has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );
976
+					$has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );
978 977
 
979
-					if( $has_sort_query_param ) {
980
-						$has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );
978
+					if ( $has_sort_query_param ) {
979
+						$has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );
981 980
 					}
982 981
 
983 982
 					if ( $this->settings->get( 'sort_columns' ) && $has_sort_query_param ) {
984
-						$sort_field_ids = array_keys( $_GET['sort'] );
985
-						$sort_directions = array_values( $_GET['sort'] );
983
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
984
+						$sort_directions = array_values( $_GET[ 'sort' ] );
986 985
 					} else {
987 986
 						$sort_field_ids = $view_setting_sort_field_ids;
988 987
 						$sort_directions = $view_setting_sort_directions;
@@ -990,7 +989,7 @@  discard block
 block discarded – undo
990 989
 
991 990
 					$skip_first = false;
992 991
 
993
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
992
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
994 993
 
995 994
 						if ( ! $skip_first && ! $has_sort_query_param ) {
996 995
 							$skip_first = true; // Skip the first one, it's already in the query
@@ -1011,8 +1010,8 @@  discard block
 block discarded – undo
1011 1010
 					}
1012 1011
 				}
1013 1012
 
1014
-				$query->limit( $parameters['paging']['page_size'] )
1015
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
1013
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
1014
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1016 1015
 
1017 1016
 				/**
1018 1017
 				 * Any joins?
@@ -1035,7 +1034,7 @@  discard block
 block discarded – undo
1035 1034
 
1036 1035
 							$query_parameters = $query->_introspect();
1037 1036
 
1038
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1037
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1039 1038
 						}
1040 1039
 
1041 1040
 						/**
@@ -1069,7 +1068,7 @@  discard block
 block discarded – undo
1069 1068
 						}
1070 1069
 
1071 1070
 						$q = $query->_introspect();
1072
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1071
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1073 1072
 
1074 1073
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1075 1074
 
@@ -1094,7 +1093,7 @@  discard block
 block discarded – undo
1094 1093
 
1095 1094
 							$query_parameters = $query->_introspect();
1096 1095
 
1097
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1096
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1098 1097
 						}
1099 1098
 					}
1100 1099
 				
@@ -1118,7 +1117,7 @@  discard block
 block discarded – undo
1118 1117
 							$conditions = array();
1119 1118
 
1120 1119
 							foreach ( $condition->expressions as $_condition ) {
1121
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1120
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1122 1121
 							}
1123 1122
 
1124 1123
 							return call_user_func_array(
@@ -1147,10 +1146,10 @@  discard block
 block discarded – undo
1147 1146
 						$q = new $query_class( $form_id );
1148 1147
 
1149 1148
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1150
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1149
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1151 1150
 
1152 1151
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1153
-						foreach ( $query_parameters['order'] as $order ) {
1152
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1154 1153
 							list( $column, $_order ) = $order;
1155 1154
 
1156 1155
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1164,15 +1163,15 @@  discard block
 block discarded – undo
1164 1163
 
1165 1164
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1166 1165
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1167
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1166
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1168 1167
 
1169 1168
 							// Record the SQL
1170
-							$unions_sql[] = array(
1169
+							$unions_sql[ ] = array(
1171 1170
 								// Remove columns, we'll rebuild them
1172 1171
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1173
-								'from'    => $sql['from'],
1174
-								'join'    => $sql['join'],
1175
-								'where'   => $sql['where'],
1172
+								'from'    => $sql[ 'from' ],
1173
+								'join'    => $sql[ 'join' ],
1174
+								'where'   => $sql[ 'where' ],
1176 1175
 								// Remove order and limit
1177 1176
 							);
1178 1177
 
@@ -1189,11 +1188,11 @@  discard block
 block discarded – undo
1189 1188
 
1190 1189
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1191 1190
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1192
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1191
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1193 1192
 
1194 1193
 						// Remove columns, we'll rebuild them
1195
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1196
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1194
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1195
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1197 1196
 
1198 1197
 						$unions = array();
1199 1198
 
@@ -1204,30 +1203,30 @@  discard block
 block discarded – undo
1204 1203
 						};
1205 1204
 
1206 1205
 						// Add all the order columns into the selects, so we can order by the whole union group
1207
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1206
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1208 1207
 						
1209 1208
 						$columns = array(
1210
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1209
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1211 1210
 						);
1212 1211
 
1213 1212
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1214
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1213
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1215 1214
 
1216 1215
 							// Rewrite the order columns to the shared aliases
1217
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1216
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1218 1217
 						}
1219 1218
 
1220 1219
 						$columns = array_unique( $columns );
1221 1220
 
1222 1221
 						// Add the columns to every UNION
1223 1222
 						foreach ( $unions_sql as $union_sql ) {
1224
-							$union_sql['select'] .= implode( ', ', $columns );
1225
-							$unions []= implode( ' ', $union_sql );
1223
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1224
+							$unions [ ] = implode( ' ', $union_sql );
1226 1225
 						}
1227 1226
 
1228 1227
 						// Add the columns to the main SELECT, but only grab the entry id column
1229
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1230
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1228
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1229
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1231 1230
 
1232 1231
 						return $sql;
1233 1232
 					} );
@@ -1268,20 +1267,20 @@  discard block
 block discarded – undo
1268 1267
 				} );
1269 1268
 			} else {
1270 1269
 				$entries = $this->form->entries
1271
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1270
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1272 1271
 					->offset( $this->settings->get( 'offset' ) )
1273
-					->limit( $parameters['paging']['page_size'] )
1272
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1274 1273
 					->page( $page );
1275 1274
 
1276
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1275
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1277 1276
 					// Pluck off multisort arrays
1278
-					$parameters['sorting'] = $parameters['sorting'][0];
1277
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1279 1278
 				}
1280 1279
 
1281
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1280
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1282 1281
 					$field = new \GV\Field();
1283
-					$field->ID = $parameters['sorting']['key'];
1284
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1282
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1283
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1285 1284
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1286 1285
 				}
1287 1286
 			}
@@ -1356,7 +1355,7 @@  discard block
 block discarded – undo
1356 1355
 		$allowed = $headers = array();
1357 1356
 
1358 1357
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $id => $field ) {
1359
-			$allowed[] = $field;
1358
+			$allowed[ ] = $field;
1360 1359
 		}
1361 1360
 
1362 1361
 		$renderer = new Field_Renderer();
@@ -1378,17 +1377,17 @@  discard block
 block discarded – undo
1378 1377
 			} );
1379 1378
 
1380 1379
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1381
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1380
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1382 1381
 			}
1383 1382
 
1384 1383
 			foreach ( $allowed as $field ) {
1385 1384
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1386 1385
 
1387
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1386
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1388 1387
 
1389 1388
 				if ( ! $headers_done ) {
1390 1389
 					$label = $field->get_label( $view, $source, $entry );
1391
-					$headers[] = $label ? $label : $field->ID;
1390
+					$headers[ ] = $label ? $label : $field->ID;
1392 1391
 				}
1393 1392
 			}
1394 1393
 
Please login to merge, or discard this patch.
future/includes/class-gv-field.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	 * @return \GV\Field The field implementation from configuration (\GV\GF_Field, \GV\Internal_Field).
167 167
 	 */
168 168
 	public static function from_configuration( $configuration ) {
169
-		if ( empty( $configuration['id'] ) ) {
169
+		if ( empty( $configuration[ 'id' ] ) ) {
170 170
 			$field = new self();
171 171
 			gravityview()->log->error( 'Trying to get field from configuration without a field ID.', array( 'data' => $configuration ) );
172 172
 			$field->update_configuration( $configuration );
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 		} else {
180 180
 			$trace = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS );
181 181
 		}
182
-		$trace = $trace[1];
183
-		if ( $trace['function'] == 'from_configuration' && $trace['class'] == __CLASS__ ) {
182
+		$trace = $trace[ 1 ];
183
+		if ( $trace[ 'function' ] == 'from_configuration' && $trace[ 'class' ] == __CLASS__ ) {
184 184
 			$field = new self();
185 185
 			gravityview()->log->error( 'Infinite loop protection tripped. Returning default class here.' );
186 186
 			$field->update_configuration( $configuration );
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 		}
189 189
 
190 190
 		/** @var \GV\GF_Field|\GV\Internal_Field $field_class Determine the field implementation to use, and try to use. */
191
-		$field_class = is_numeric( $configuration['id'] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
191
+		$field_class = is_numeric( $configuration[ 'id' ] ) ? '\GV\GF_Field' : '\GV\Internal_Field';
192 192
 
193 193
 		/**
194 194
 		 * @filter `gravityview/field/class` Filter the field class about to be created from the configuration.
@@ -227,24 +227,24 @@  discard block
 block discarded – undo
227 227
 	public function update_configuration( $configuration ) {
228 228
 		$configuration = wp_parse_args( $configuration, $this->as_configuration() );
229 229
 
230
-		if ( $this->ID != $configuration['id'] ) {
230
+		if ( $this->ID != $configuration[ 'id' ] ) {
231 231
 			/** Smelling trouble here... */
232 232
 			gravityview()->log->warning( 'ID is being changed for {field_class} instance, but implementation is not. Use ::from_configuration instead', array( 'field_class', __CLASS__ ) );
233 233
 		}
234 234
 
235
-		$this->ID = $configuration['id'];
236
-		$this->label = $configuration['label'];
237
-		$this->show_label = $configuration['show_label'] == '1';
238
-		$this->custom_label = $configuration['custom_label'];
239
-		$this->custom_class = $configuration['custom_class'];
240
-		$this->cap = $configuration['only_loggedin'] == '1' ? $configuration['only_loggedin_cap'] : '';
241
-		$this->search_filter = $configuration['search_filter'] == '1';
242
-		$this->show_as_link = $configuration['show_as_link'] == '1';
235
+		$this->ID = $configuration[ 'id' ];
236
+		$this->label = $configuration[ 'label' ];
237
+		$this->show_label = $configuration[ 'show_label' ] == '1';
238
+		$this->custom_label = $configuration[ 'custom_label' ];
239
+		$this->custom_class = $configuration[ 'custom_class' ];
240
+		$this->cap = $configuration[ 'only_loggedin' ] == '1' ? $configuration[ 'only_loggedin_cap' ] : '';
241
+		$this->search_filter = $configuration[ 'search_filter' ] == '1';
242
+		$this->show_as_link = $configuration[ 'show_as_link' ] == '1';
243 243
 
244 244
 		/** Shared among all field types (sort of). */
245 245
 		$shared_configuration_keys = array(
246 246
 			'id', 'label', 'show_label', 'custom_label', 'custom_class',
247
-			'only_loggedin' ,'only_loggedin_cap', 'search_filter', 'show_as_link',
247
+			'only_loggedin', 'only_loggedin_cap', 'search_filter', 'show_as_link',
248 248
 		);
249 249
 
250 250
 		/** Everything else goes into the properties for now. @todo subclasses! */
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 
274 274
 		/** A custom label is available. */
275 275
 		if ( ! empty( $this->custom_label ) ) {
276
-			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ? : null : null, $entry ? $entry->as_entry() : null );
276
+			return \GravityView_API::replace_variables( $this->custom_label, $source ? $source->form ?: null : null, $entry ? $entry->as_entry() : null );
277 277
 		}
278 278
 
279 279
 		return '';
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * @return mixed|null The value for the given configuration key, null if doesn't exist.
351 351
 	 */
352 352
 	public function __get( $key ) {
353
-		switch( $key ) {
353
+		switch ( $key ) {
354 354
 			default:
355 355
 				if ( isset( $this->configuration[ $key ] ) ) {
356 356
 					return $this->configuration[ $key ];
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 	 * @return boolean Whether this $key is set or not.
369 369
 	 */
370 370
 	public function __isset( $key ) {
371
-		switch( $key ) {
371
+		switch ( $key ) {
372 372
 			default:
373 373
 				return isset( $this->configuration[ $key ] );
374 374
 		}
Please login to merge, or discard this patch.