Complex classes like View_Table_Template often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use View_Table_Template, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class View_Table_Template extends View_Template { |
||
| 15 | /** |
||
| 16 | * @var string The template slug to be loaded (like "table", "list") |
||
| 17 | */ |
||
| 18 | public static $slug = 'table'; |
||
| 19 | |||
| 20 | |||
| 21 | /** |
||
| 22 | * Constructor. Add filters to modify output. |
||
| 23 | * |
||
| 24 | * @since 2.0.4 |
||
| 25 | * |
||
| 26 | * @param View $view |
||
| 27 | * @param Entry_Collection $entries |
||
| 28 | * @param Request $request |
||
| 29 | */ |
||
| 30 | 18 | public function __construct( View $view, Entry_Collection $entries, Request $request ) { |
|
| 36 | |||
| 37 | /** |
||
| 38 | * Add sorting links to HTML columns that support sorting |
||
| 39 | * |
||
| 40 | * @since 2.0.4 |
||
| 41 | * @since 2.0.5 Made static |
||
| 42 | * |
||
| 43 | * @static |
||
| 44 | * |
||
| 45 | * @param string $column_label Label for the table column |
||
| 46 | * @param \GV\Template_Context $context |
||
| 47 | * |
||
| 48 | * @return string |
||
| 49 | */ |
||
| 50 | static public function add_columns_sort_links( $column_label, $context = null ) { |
||
| 51 | |||
| 52 | $sort_columns = $context->view->settings->get( 'sort_columns' ); |
||
| 53 | |||
| 54 | if ( empty( $sort_columns ) ) { |
||
| 55 | return $column_label; |
||
| 56 | } |
||
| 57 | |||
| 58 | if ( ! \GravityView_frontend::getInstance()->is_field_sortable( $context->field->ID, $context->view->form->form ) ) { |
||
| 59 | return $column_label; |
||
| 60 | } |
||
| 61 | |||
| 62 | $sorting = array(); |
||
| 63 | |||
| 64 | $directions = $context->view->settings->get( 'sort_direction' ); |
||
| 65 | |||
| 66 | $sorts = Utils::_GET( 'sort' ); |
||
| 67 | |||
| 68 | if ( $sorts ) { |
||
| 69 | if ( is_array( $sorts ) ) { |
||
| 70 | foreach ( (array)$sorts as $key => $direction ) { |
||
| 71 | if ( $key == $context->field->ID ) { |
||
| 72 | $sorting['key'] = $context->field->ID; |
||
| 73 | $sorting['direction'] = strtolower( $direction ); |
||
| 74 | break; |
||
| 75 | } |
||
| 76 | } |
||
| 77 | } else { |
||
| 78 | if ( $sorts == $context->field->ID ) { |
||
| 79 | $sorting['key'] = $context->field->ID; |
||
| 80 | $sorting['direction'] = strtolower( Utils::_GET( 'dir', '' ) ); |
||
| 81 | } |
||
| 82 | } |
||
| 83 | } else { |
||
| 84 | foreach ( (array)$context->view->settings->get( 'sort_field', array() ) as $i => $sort_field ) { |
||
| 85 | if ( $sort_field == $context->field->ID ) { |
||
| 86 | $sorting['key'] = $sort_field; |
||
| 87 | $sorting['direction'] = strtolower( Utils::get( $directions, $i, '' ) ); |
||
| 88 | break; // Only get the first sort |
||
| 89 | } |
||
| 90 | } |
||
| 91 | } |
||
| 92 | |||
| 93 | $class = 'gv-sort'; |
||
| 94 | |||
| 95 | $sort_field_id = \GravityView_frontend::_override_sorting_id_by_field_type( $context->field->ID, $context->view->form->ID ); |
||
| 96 | |||
| 97 | $sort_args = array( |
||
| 98 | sprintf( 'sort[%s]', $context->field->ID ), |
||
| 99 | 'asc' |
||
| 100 | ); |
||
| 101 | |||
| 102 | // If we are already sorting by the current field... |
||
| 103 | if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) { |
||
| 104 | |||
| 105 | switch( $sorting['direction'] ) { |
||
| 106 | // No sort |
||
| 107 | case '': |
||
| 108 | $sort_args[1] = 'asc'; |
||
| 109 | $class .= ' gv-icon-caret-up-down'; |
||
| 110 | break; |
||
| 111 | case 'desc': |
||
| 112 | $sort_args[1] = ''; |
||
| 113 | $class .= ' gv-icon-sort-asc'; |
||
| 114 | break; |
||
| 115 | case 'asc': |
||
| 116 | default: |
||
| 117 | $sort_args[1] = 'desc'; |
||
| 118 | $class .= ' gv-icon-sort-desc'; |
||
| 119 | break; |
||
| 120 | } |
||
| 121 | |||
| 122 | } else { |
||
| 123 | $class .= ' gv-icon-caret-up-down'; |
||
| 124 | } |
||
| 125 | |||
| 126 | $url = remove_query_arg( array( 'pagenum' ) ); |
||
| 127 | $url = remove_query_arg( 'sort', $url ); |
||
| 128 | $multisort_url = self::_get_multisort_url( $url, $sort_args, $context->field->ID ); |
||
| 129 | |||
| 130 | $url = add_query_arg( $sort_args[0], $sort_args[1], $url ); |
||
| 131 | |||
| 132 | $return = '<a href="'. esc_url_raw( $url ) .'"'; |
||
| 133 | |||
| 134 | if ( ! empty( $multisort_url ) ) { |
||
| 135 | $return .= ' data-multisort-href="'. esc_url_raw( $multisort_url ) . '"'; |
||
| 136 | } |
||
| 137 | |||
| 138 | $return .= ' class="'. $class .'" ></a> '. $column_label; |
||
| 139 | |||
| 140 | return $return; |
||
| 141 | } |
||
| 142 | |||
| 143 | /** |
||
| 144 | * Get the multi-sort URL used in the sorting links |
||
| 145 | * |
||
| 146 | * @todo Consider moving to Utils? |
||
| 147 | * |
||
| 148 | * @since 2.3 |
||
| 149 | * |
||
| 150 | * @see add_columns_sort_links |
||
| 151 | * @param string $url Single-sort URL |
||
| 152 | * @param array $sort_args Single sorting for rules, in [ field_id, dir ] format |
||
| 153 | * @param string|int $field_id ID of the current field being displayed |
||
| 154 | * |
||
| 155 | * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url |
||
| 156 | */ |
||
| 157 | 1 | static public function _get_multisort_url( $url, $sort_args, $field_id ) { |
|
| 191 | |||
| 192 | /** |
||
| 193 | * Output the table column names. |
||
| 194 | * |
||
| 195 | * @return void |
||
| 196 | */ |
||
| 197 | 16 | public function the_columns() { |
|
| 198 | 16 | $fields = $this->view->fields->by_position( 'directory_table-columns' ); |
|
| 199 | |||
| 200 | 16 | foreach ( $fields->by_visible( $this->view )->all() as $field ) { |
|
| 201 | $context = Template_Context::from_template( $this, compact( 'field' ) ); |
||
| 202 | |||
| 203 | $args = array( |
||
| 204 | 'field' => is_numeric( $field->ID ) ? $field->as_configuration() : null, |
||
| 205 | 'hide_empty' => false, |
||
| 206 | 'zone_id' => 'directory_table-columns', |
||
| 207 | 'markup' => '<th id="{{ field_id }}" class="{{ class }}" style="{{width:style}}" data-label="{{label_value:data-label}}">{{label}}</th>', |
||
| 208 | 'label_markup' => '<span class="gv-field-label">{{ label }}</span>', |
||
| 209 | 'label' => self::get_field_column_label( $field, $context ), |
||
| 210 | ); |
||
| 211 | |||
| 212 | echo \gravityview_field_output( $args, $context ); |
||
| 213 | } |
||
| 214 | 16 | } |
|
| 215 | |||
| 216 | /** |
||
| 217 | * Returns the label for a column, with support for all deprecated filters |
||
| 218 | * |
||
| 219 | * @since 2.1 |
||
| 220 | * |
||
| 221 | * @param \GV\Field $field |
||
| 222 | * @param \GV\Template_Context $context |
||
| 223 | */ |
||
| 224 | protected static function get_field_column_label( $field, $context = null ) { |
||
| 225 | |||
| 226 | $form = $field->form_id ? GF_Form::by_id( $field->form_id ) : $context->view->form; |
||
|
|
|||
| 227 | |||
| 228 | /** |
||
| 229 | * @deprecated Here for back-compatibility. |
||
| 230 | */ |
||
| 231 | $column_label = apply_filters( 'gravityview_render_after_label', $field->get_label( $context->view, $form ), $field->as_configuration() ); |
||
| 232 | $column_label = apply_filters( 'gravityview/template/field_label', $column_label, $field->as_configuration(), ( $form && $form->form ) ? $form->form : null, null ); |
||
| 233 | |||
| 234 | /** |
||
| 235 | * @filter `gravityview/template/field/label` Override the field label. |
||
| 236 | * @since 2.0 |
||
| 237 | * @param[in,out] string $column_label The label to override. |
||
| 238 | * @param \GV\Template_Context $context The context. Does not have entry set here. |
||
| 239 | */ |
||
| 240 | $column_label = apply_filters( 'gravityview/template/field/label', $column_label, $context ); |
||
| 241 | |||
| 242 | return $column_label; |
||
| 243 | } |
||
| 244 | |||
| 245 | /** |
||
| 246 | * Output the entry row. |
||
| 247 | * |
||
| 248 | * @param \GV\Entry $entry The entry to be rendered. |
||
| 249 | * @param array $attributes The attributes for the <tr> tag |
||
| 250 | * |
||
| 251 | * @return void |
||
| 252 | */ |
||
| 253 | 12 | public function the_entry( \GV\Entry $entry, $attributes ) { |
|
| 254 | |||
| 255 | 12 | $fields = $this->view->fields->by_position( 'directory_table-columns' )->by_visible( $this->view ); |
|
| 256 | |||
| 257 | 12 | $context = Template_Context::from_template( $this, compact( 'entry', 'fields' ) ); |
|
| 258 | |||
| 259 | /** |
||
| 260 | * Push legacy entry context. |
||
| 261 | */ |
||
| 262 | 12 | \GV\Mocks\Legacy_Context::load( array( |
|
| 263 | 12 | 'entry' => $entry, |
|
| 264 | ) ); |
||
| 265 | |||
| 266 | /** |
||
| 267 | * @filter `gravityview_table_cells` Modify the fields displayed in a table |
||
| 268 | * @param array $fields |
||
| 269 | * @param \GravityView_View $this |
||
| 270 | * @deprecated Use `gravityview/template/table/fields` |
||
| 271 | */ |
||
| 272 | 12 | $fields = apply_filters( 'gravityview_table_cells', $fields->as_configuration(), \GravityView_View::getInstance() ); |
|
| 273 | 12 | $fields = Field_Collection::from_configuration( $fields ); |
|
| 274 | |||
| 275 | /** |
||
| 276 | * @filter `gravityview/template/table/fields` Modify the fields displayed in this tables. |
||
| 277 | * @param \GV\Field_Collection $fields The fields. |
||
| 278 | * @param \GV\Template_Context $context The context. |
||
| 279 | * @since 2.0 |
||
| 280 | */ |
||
| 281 | 12 | $fields = apply_filters( 'gravityview/template/table/fields', $fields, $context ); |
|
| 282 | |||
| 283 | 12 | $context = Template_Context::from_template( $this, compact( 'entry', 'fields' ) ); |
|
| 284 | |||
| 285 | /** |
||
| 286 | * @filter `gravityview/template/table/entry/row/attributes` Filter the row attributes for the row in table view. |
||
| 287 | * |
||
| 288 | * @param array $attributes The HTML attributes. |
||
| 289 | * @param \GV\Template_Context The context. |
||
| 290 | * |
||
| 291 | * @since 2.0 |
||
| 292 | */ |
||
| 293 | 12 | $attributes = apply_filters( 'gravityview/template/table/entry/row/attributes', $attributes, $context ); |
|
| 294 | |||
| 295 | /** Glue the attributes together. */ |
||
| 296 | 12 | foreach ( $attributes as $attribute => $value ) { |
|
| 297 | 12 | $attributes[ $attribute ] = sprintf( "$attribute=\"%s\"", esc_attr( $value ) ); |
|
| 298 | } |
||
| 299 | 12 | $attributes = implode( ' ', $attributes ); |
|
| 300 | |||
| 301 | ?> |
||
| 302 | <tr<?php echo $attributes ? " $attributes" : ''; ?>> |
||
| 303 | <?php |
||
| 304 | |||
| 305 | /** |
||
| 306 | * @action `gravityview/template/table/cells/before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells. |
||
| 307 | * @since 2.0 |
||
| 308 | * @param \GV\Template_Context The context. |
||
| 309 | */ |
||
| 310 | 12 | do_action( 'gravityview/template/table/cells/before', $context ); |
|
| 311 | |||
| 312 | /** |
||
| 313 | * @action `gravityview_table_cells_before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells. |
||
| 314 | * @since 1.0.7 |
||
| 315 | * @param \GravityView_View $this Current GravityView_View object |
||
| 316 | * @deprecated Use `gravityview/template/table/cells/before` |
||
| 317 | */ |
||
| 318 | 12 | do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() ); |
|
| 319 | |||
| 320 | 12 | foreach ( $fields->all() as $field ) { |
|
| 321 | if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) { |
||
| 322 | if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) { |
||
| 323 | $field = $this->view->unions[ $entry['form_id'] ][ $field->ID ]; |
||
| 324 | } else { |
||
| 325 | if ( ! $field instanceof Internal_Field ) { |
||
| 326 | $field = Internal_Field::from_configuration( array( 'id' => 'custom' ) ); |
||
| 327 | } |
||
| 328 | } |
||
| 329 | } |
||
| 330 | $this->the_field( $field, $entry ); |
||
| 331 | } |
||
| 332 | |||
| 333 | /** |
||
| 334 | * @action `gravityview/template/table/cells/after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells. |
||
| 335 | * @since 2.0 |
||
| 336 | * @param \GV\Template_Context The context. |
||
| 337 | */ |
||
| 338 | 12 | do_action( 'gravityview/template/table/cells/after', $context ); |
|
| 339 | |||
| 340 | /** |
||
| 341 | * @action `gravityview_table_cells_after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells. |
||
| 342 | * @since 1.0.7 |
||
| 343 | * @param \GravityView_View $this Current GravityView_View object |
||
| 344 | * @deprecated Use `gravityview/template/table/cells/after` |
||
| 345 | */ |
||
| 346 | 12 | do_action( 'gravityview_table_cells_after', \GravityView_View::getInstance() ); |
|
| 347 | |||
| 348 | ?> |
||
| 349 | 12 | </tr> |
|
| 350 | <?php |
||
| 351 | 12 | } |
|
| 352 | |||
| 353 | /** |
||
| 354 | * Output a field cell. |
||
| 355 | * |
||
| 356 | * @param \GV\Field $field The field to be ouput. |
||
| 357 | * @param \GV\Field $entry The entry this field is for. |
||
| 358 | * |
||
| 359 | * @return void |
||
| 360 | */ |
||
| 361 | public function the_field( \GV\Field $field, \GV\Entry $entry ) { |
||
| 362 | $form = $this->view->form; |
||
| 363 | $single_entry = $entry; |
||
| 364 | |||
| 365 | /** |
||
| 366 | * Push legacy entry context. |
||
| 367 | */ |
||
| 368 | \GV\Mocks\Legacy_Context::load( array( |
||
| 369 | 'field' => $field, |
||
| 370 | ) ); |
||
| 371 | |||
| 372 | if ( $entry->is_multi() ) { |
||
| 373 | if ( ! $single_entry = $entry->from_field( $field ) ) { |
||
| 374 | echo '<td></td>'; |
||
| 375 | return; |
||
| 376 | } |
||
| 377 | $form = GF_Form::by_id( $field->form_id ); |
||
| 378 | } |
||
| 379 | |||
| 380 | $renderer = new Field_Renderer(); |
||
| 381 | $source = is_numeric( $field->ID ) ? $form : new Internal_Source(); |
||
| 382 | |||
| 383 | $value = $renderer->render( $field, $this->view, $source, $entry, $this->request ); |
||
| 384 | |||
| 385 | $context = Template_Context::from_template( $this, compact( 'field' ) ); |
||
| 386 | $context->entry = $single_entry; |
||
| 387 | |||
| 388 | $args = array( |
||
| 389 | 'entry' => $entry->as_entry(), |
||
| 390 | 'field' => is_numeric( $field->ID ) ? $field->as_configuration() : null, |
||
| 391 | 'value' => $value, |
||
| 392 | 'hide_empty' => false, |
||
| 393 | 'zone_id' => 'directory_table-columns', |
||
| 394 | 'label' => self::get_field_column_label( $field, $context ), |
||
| 395 | 'markup' => '<td id="{{ field_id }}" class="{{ class }}" data-label="{{label_value:data-label}}">{{ value }}</td>', |
||
| 396 | 'form' => $form, |
||
| 397 | ); |
||
| 398 | |||
| 399 | /** Output. */ |
||
| 400 | echo \gravityview_field_output( $args, $context ); |
||
| 401 | } |
||
| 402 | |||
| 403 | /** |
||
| 404 | * `gravityview_table_body_before` and `gravityview/template/table/body/before` actions. |
||
| 405 | * |
||
| 406 | * Output inside the `tbody` of the table. |
||
| 407 | * |
||
| 408 | * @param $context \GV\Template_Context The 2.0 context. |
||
| 409 | * |
||
| 410 | * @return void |
||
| 411 | */ |
||
| 412 | 15 | public static function body_before( $context ) { |
|
| 428 | |||
| 429 | /** |
||
| 430 | * `gravityview_table_body_after` and `gravityview/template/table/body/after` actions. |
||
| 431 | * |
||
| 432 | * Output inside the `tbody` of the table. |
||
| 433 | * |
||
| 434 | * @param $context \GV\Template_Context The 2.0 context. |
||
| 435 | * |
||
| 436 | * @return void |
||
| 437 | */ |
||
| 438 | 15 | public static function body_after( $context ) { |
|
| 454 | |||
| 455 | /** |
||
| 456 | * `gravityview_table_tr_before` and `gravityview/template/table/tr/after` actions. |
||
| 457 | * |
||
| 458 | * Output inside the `tr` of the table. |
||
| 459 | * |
||
| 460 | * @param $context \GV\Template_Context The 2.0 context. |
||
| 461 | * |
||
| 462 | * @return void |
||
| 463 | */ |
||
| 464 | 5 | public static function tr_before( $context ) { |
|
| 480 | |||
| 481 | /** |
||
| 482 | * `gravityview_table_tr_after` and `gravityview/template/table/tr/after` actions. |
||
| 483 | * |
||
| 484 | * Output inside the `tr` of the table. |
||
| 485 | * |
||
| 486 | * @param $context \GV\Template_Context The 2.0 context. |
||
| 487 | * |
||
| 488 | * @return void |
||
| 489 | */ |
||
| 490 | 5 | public static function tr_after( $context ) { |
|
| 506 | |||
| 507 | /** |
||
| 508 | * `gravityview_entry_class` and `gravityview/template/table/entry/class` filters. |
||
| 509 | * |
||
| 510 | * Modify of the class of a row. |
||
| 511 | * |
||
| 512 | * @param string $class The class. |
||
| 513 | * @param \GV\Entry $entry The entry. |
||
| 514 | * @param \GV\Template_Context The context. |
||
| 515 | * |
||
| 516 | * @return string The classes. |
||
| 517 | */ |
||
| 518 | 12 | public static function entry_class( $class, $entry, $context ) { |
|
| 537 | } |
||
| 538 |
Since your code implements the magic getter
_get, this function will be called for any read access on an undefined variable. You can add the@propertyannotation to your class or interface to document the existence of this variable.If the property has read access only, you can use the @property-read annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.