views - Code Metrics - Inspection of "Fix missing View context for shortcodes" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 828be0...07d5bb )

by Gennady

created 2018-05-29 21:31 UTC

views A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

93.75%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	75
ccs	15
cts	16
cp	0.9375
rs	10
wmc	13
lcom	0
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
C	get()	0	45	12
A	set()	0	3	1

<?php
namespace GV\Wrappers;

/**
 * This file contains magic wrapper code for `gravityview()`.
 *
 * Every `gravityview()` magic key maps to a class that exposes more magic.
 *  Chains of inifite magic can be constructed spanning seas of mermaids,
 *  valleys of unicorns and whirlwinds of shooting stars.
 */

/**
 * The views magic wrapper.
 */
class views {


	/**
	 * @var \GV\View An internal View keeper.
	 */
	private $view = null;

	/**
	 * Gets a View.
	 *
	 * Doesn't care what you provide it. Will try to find
	 *  out what you need from the current context, from the supplied
	 *  args, etc.
	 *
	 * @param string|int|array|\GV\View\WP_Post|null Anything goes.
	 *
	 * @return \GV\View|null The detected View.
	 */
	public function get( $view = null ) {

		/**
		 * By View.
		 */
		if ( $view instanceof \GV\View && $view->ID ) {
			return $this->get( $view->ID );
		}

		/** 
		 * By View ID.
		 */
		if ( is_numeric( $view ) ) {
			return \GV\View::by_id( $view );
		}

		/** 
		 * By post object.
		 */
		if ( $view instanceof \WP_Post ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
			return \GV\View::from_post( $view );
		}

		/**
		 * By array.
		 */
		if ( is_array( $view ) && ! empty( $view['id'] ) ) {
			return $this->get( $view['id'] );
		}

		/**
		 * From various contexts.
		 */
		if ( is_null( $view ) ) {
			if ( in_array( get_class( gravityview()->request ), array( 'GV\Frontend_Request', 'GV\Mock_Request' ) ) && $view = gravityview()->request->is_view() ) {
				return $view;
			}

			global $post;
function myFunction($a, $b) {
    // Do something
}

			if ( $post instanceof \WP_Post && $post->post_type == 'gravityview' ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				return $this->get( $post );
			}
		}
	}

	/**
	 * Mock the internal pointer.
	 *
	 * @param \GV\View $view The View to supply on fallback in ::get()
	 *
	 * @return void
	 */
	public function set( $view ) {
		$this->view = $view;
	}
}


Push — develop ( 828be0...07d5bb )

views A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

1. Missing dependencies

2. Missing use statement

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

1		<?php
2		namespace GV\Wrappers;
3
4		/**
5		* This file contains magic wrapper code for `gravityview()`.
6		*
7		* Every `gravityview()` magic key maps to a class that exposes more magic.
8		* Chains of inifite magic can be constructed spanning seas of mermaids,
9		* valleys of unicorns and whirlwinds of shooting stars.
10		*/
11
12		/**
13		* The views magic wrapper.
14		*/
15		class views {
		0 ignored issues – show Coding Style introduced 2018-05-29 21:49 UTC by Report Bug Copy Issue Report Class name "views" is not in camel caps format Loading history...
16
17		/**
18		* @var \GV\View An internal View keeper.
19		*/
20		private $view = null;
21
22		/**
23		* Gets a View.
24		*
25		* Doesn't care what you provide it. Will try to find
26		* out what you need from the current context, from the supplied
27	6	* args, etc.
28		*
29		* @param string\|int\|array\|\GV\View\WP_Post\|null Anything goes.
30		*
31		* @return \GV\View\|null The detected View.
32	6	*/
33	1	public function get( $view = null ) {
34
35		/**
36		* By View.
37		*/
38		if ( $view instanceof \GV\View && $view->ID ) {
39	6	return $this->get( $view->ID );
40	1	}
41
42		/**
43		* By View ID.
44		*/
45		if ( is_numeric( $view ) ) {
46	6	return \GV\View::by_id( $view );
47	1	}
48
49		/**
50		* By post object.
51		*/
52		if ( $view instanceof \WP_Post ) {
		0 ignored issues – show Bug introduced 2018-05-08 22:39 UTC by Report Bug Copy Issue Report The class `WP_Post` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
53	6	return \GV\View::from_post( $view );
54	1	}
55
56		/**
57		* By array.
58		*/
59		if ( is_array( $view ) && ! empty( $view['id'] ) ) {
60	6	return $this->get( $view['id'] );
61	6	}
62	5
63		/**
64		* From various contexts.
65	1	*/
66		if ( is_null( $view ) ) {
67	1	if ( in_array( get_class( gravityview()->request ), array( 'GV\Frontend_Request', 'GV\Mock_Request' ) ) && $view = gravityview()->request->is_view() ) {
68		return $view;
69		}
70
71	1	global $post;
		0 ignored issues – show Compatibility Best Practice introduced 2018-05-08 22:40 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
72
73		if ( $post instanceof \WP_Post && $post->post_type == 'gravityview' ) {
		0 ignored issues – show Bug introduced 2018-05-08 22:39 UTC by Report Bug Copy Issue Report The class `WP_Post` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history... introduced 2018-05-08 22:40 UTC by Report Bug Copy Issue Report Found "== '". Use Yoda Condition checks, you must Loading history...
74		return $this->get( $post );
75		}
76		}
77		}
78
79		/**
80		* Mock the internal pointer.
81		*
82		* @param \GV\View $view The View to supply on fallback in ::get()
83		*
84		* @return void
85		*/
86		public function set( $view ) {
87		$this->view = $view;
88		}
89		}
90

gravityview / GravityView

Push — develop ( 828be0...07d5bb )

views A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

1. Missing dependencies

2. Missing use statement

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like