gravityview /
GravityView
Complex classes like GravityView_oEmbed often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use GravityView_oEmbed, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class GravityView_oEmbed { |
||
| 23 | |||
| 24 | protected $output = array(); |
||
| 25 | protected $entry_id = NULL; |
||
| 26 | protected $view_id = NULL; |
||
| 27 | protected $is_full_oembed_preview = false; |
||
| 28 | |||
| 29 | static $instance = NULL; |
||
| 30 | |||
| 31 | private function __construct() {} |
||
| 32 | |||
| 33 | private function initialize() { |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @return GravityView_oEmbed |
||
| 45 | * @since 1.6 |
||
| 46 | */ |
||
| 47 | static function getInstance() { |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Register the oEmbed handler |
||
| 60 | * |
||
| 61 | * @since 1.6 |
||
| 62 | * @uses get_handler_regex |
||
| 63 | */ |
||
| 64 | function register_handler() { |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Become an oEmbed provider for GravityView. |
||
| 72 | * |
||
| 73 | * @return void |
||
| 74 | */ |
||
| 75 | function add_provider() { |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Output a response as a provider for an entry oEmbed URL. |
||
| 81 | * |
||
| 82 | * For now we only output the JSON format and don't care about the size (width, height). |
||
| 83 | * Our only current use-case is for it to provide output to the Add Media / From URL box |
||
| 84 | * in WordPress 4.8. |
||
| 85 | * |
||
| 86 | * @return void |
||
| 87 | */ |
||
| 88 | function render_provider_request() { |
||
| 124 | |||
| 125 | /** |
||
| 126 | * Generate the Regular expression that matches embedded entries. |
||
| 127 | * |
||
| 128 | * Generates different regex if using permalinks and if not using permalinks |
||
| 129 | * |
||
| 130 | * @since 1.6 |
||
| 131 | * |
||
| 132 | * @return string Regex code |
||
| 133 | */ |
||
| 134 | private function get_handler_regex() { |
||
| 163 | |||
| 164 | /** |
||
| 165 | * Get the post ID from an URL |
||
| 166 | * |
||
| 167 | * This is necessary because url_to_postid() doesn't work with permalinks off for custom post types |
||
| 168 | * |
||
| 169 | * @uses url_to_postid() |
||
| 170 | * @since 1.6 |
||
| 171 | * |
||
| 172 | * @param string $url URL to get the post ID from |
||
| 173 | * @param string $slug The name of a post, used as backup way of checking for post ID |
||
| 174 | * @return int 0 if not found; int of URL post ID otherwise |
||
| 175 | */ |
||
| 176 | private function get_postid_from_url_and_slug( $url = '', $slug = '' ) { |
||
| 197 | |||
| 198 | /** |
||
| 199 | * Get the entry id for the current oEmbedded entry |
||
| 200 | * |
||
| 201 | * @since 1.6 |
||
| 202 | * |
||
| 203 | * @return int|null |
||
| 204 | */ |
||
| 205 | public function get_entry_id() { |
||
| 208 | |||
| 209 | /** |
||
| 210 | * |
||
| 211 | * |
||
| 212 | * @since 1.6 |
||
| 213 | * @see GravityView_oEmbed::add_providers() for the regex |
||
| 214 | * |
||
| 215 | * @param array $matches The regex matches from the provided regex when calling wp_embed_register_handler() |
||
| 216 | * @param array $attr Embed attributes. |
||
| 217 | * @param string $url The original URL that was matched by the regex. |
||
| 218 | * @param array $rawattr The original unmodified attributes. |
||
| 219 | * @return string The embed HTML. |
||
| 220 | */ |
||
| 221 | public function render_handler( $matches, $attr, $url, $rawattr ) { |
||
| 257 | |||
| 258 | |||
| 259 | /** |
||
| 260 | * Generate a warning to users when previewing oEmbed in the Add Media modal |
||
| 261 | * |
||
| 262 | * @return string HTML notice |
||
| 263 | */ |
||
| 264 | private function generate_preview_notice() { |
||
| 270 | |||
| 271 | /** |
||
| 272 | * Set entry_id and view_id from the data sent to render_handler |
||
| 273 | * |
||
| 274 | * @var $entry_id |
||
| 275 | * @var $view_id |
||
| 276 | * |
||
| 277 | * @see render_handler |
||
| 278 | */ |
||
| 279 | 1 | private function set_vars( $matches, $attr, $url, $rawattr ) { |
|
| 317 | |||
| 318 | /** |
||
| 319 | * Display a nice placeholder in the admin for the entry |
||
| 320 | * |
||
| 321 | * @param array $matches The regex matches from the provided regex when calling wp_embed_register_handler() |
||
| 322 | * @param array $attr Embed attributes. |
||
| 323 | * @param string $url The original URL that was matched by the regex. |
||
| 324 | * @param array $rawattr The original unmodified attributes. |
||
| 325 | * @return string The embed HTML. |
||
| 326 | */ |
||
| 327 | private function render_admin( $matches, $attr, $url, $rawattr ) { |
||
| 347 | |||
| 348 | private function generate_entry_output() { |
||
| 369 | |||
| 370 | /** |
||
| 371 | * Tell get_gravityview() to display a single entry |
||
| 372 | * |
||
| 373 | * REQUIRED FOR THE VIEW TO OUTPUT A SINGLE ENTRY |
||
| 374 | * |
||
| 375 | * @param bool|int $is_single_entry Existing single entry. False, because GV thinks we're in a post or page. |
||
| 376 | * |
||
| 377 | * @return int The current entry ID |
||
| 378 | */ |
||
| 379 | public function set_single_entry_id( $is_single_entry = false ) { |
||
| 383 | |||
| 384 | /** |
||
| 385 | * GravityView embed entry handler |
||
| 386 | * |
||
| 387 | * @param array $matches The regex matches from the provided regex when calling {@link wp_embed_register_handler()}. |
||
| 388 | * @param array $attr Embed attributes. |
||
| 389 | * @param string $url The original URL that was matched by the regex. |
||
| 390 | * @param array $rawattr The original unmodified attributes. |
||
| 391 | * @return string The embed HTML. |
||
| 392 | */ |
||
| 393 | private function render_frontend( $matches, $attr, $url, $rawattr ) { |
||
| 425 | |||
| 426 | } |
||
| 427 | |||
| 428 | GravityView_oEmbed::getInstance(); |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.