Inspection of "Refresh admin styles" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1492)

by Zack

created 2020-08-24 21:19 UTC

Switch Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -57,16 +57,16 @@
 block discarded – undo
 }
 
 switch ($blah) {
-    case 'one':
-        if ($blah) {
-            // There are no spaces before break.
-        }
-    break;
-
-    default:
-        if ($blah) {
-            // Code here.
-        }
+    	case 'one':
+        	if ($blah) {
+            	// There are no spaces before break.
+        	}
+    	break;
+
+    	default:
+        	if ($blah) {
+            	// Code here.
+        	}
 }
 
 foreach ($blah as $var) {

Please login to merge, or discard this patch.

src/Standards/Squiz/Tests/Arrays/ArrayDeclarationUnitTest.php 1 patch

Switch Indentation +163 added lines, -163 removed lines patch added patch discarded remove patch

		@@ -28,169 +28,169 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'ArrayDeclarationUnitTest.1.inc':
32		- return [
33		- 2 => 1,
34		- 8 => 2,
35		- 10 => 2,
36		- 22 => 1,
37		- 23 => 2,
38		- 24 => 2,
39		- 25 => 1,
40		- 31 => 2,
41		- 35 => 1,
42		- 36 => 2,
43		- 41 => 1,
44		- 46 => 1,
45		- 47 => 1,
46		- 50 => 1,
47		- 51 => 1,
48		- 53 => 1,
49		- 56 => 1,
50		- 58 => 1,
51		- 61 => 1,
52		- 62 => 1,
53		- 63 => 1,
54		- 64 => 1,
55		- 65 => 1,
56		- 66 => 3,
57		- 70 => 1,
58		- 76 => 2,
59		- 77 => 1,
60		- 78 => 7,
61		- 79 => 2,
62		- 81 => 2,
63		- 82 => 4,
64		- 87 => 1,
65		- 88 => 1,
66		- 92 => 1,
67		- 97 => 1,
68		- 100 => 1,
69		- 101 => 1,
70		- 102 => 1,
71		- 105 => 1,
72		- 106 => 1,
73		- 107 => 1,
74		- 125 => 1,
75		- 126 => 1,
76		- 141 => 1,
77		- 144 => 1,
78		- 146 => 1,
79		- 148 => 1,
80		- 151 => 1,
81		- 157 => 1,
82		- 174 => 3,
83		- 179 => 1,
84		- 182 => 1,
85		- 188 => 1,
86		- 207 => 1,
87		- 212 => 2,
88		- 214 => 1,
89		- 218 => 2,
90		- 219 => 2,
91		- 223 => 1,
92		- 255 => 1,
93		- 294 => 1,
94		- 295 => 1,
95		- 296 => 1,
96		- 311 => 1,
97		- 317 => 1,
98		- 339 => 2,
99		- 348 => 2,
100		- 352 => 2,
101		- 355 => 3,
102		- 358 => 3,
103		- 359 => 2,
104		- 360 => 1,
105		- 362 => 1,
106		- 363 => 2,
107		- 364 => 1,
108		- 365 => 2,
109		- 366 => 2,
110		- 367 => 2,
111		- 368 => 2,
112		- 369 => 1,
113		- 370 => 1,
114		- 383 => 1,
115		- 394 => 1,
116		- ];
117		- case 'ArrayDeclarationUnitTest.2.inc':
118		- return [
119		- 2 => 1,
120		- 10 => 1,
121		- 23 => 2,
122		- 24 => 2,
123		- 25 => 1,
124		- 31 => 2,
125		- 36 => 2,
126		- 41 => 1,
127		- 46 => 1,
128		- 47 => 1,
129		- 51 => 1,
130		- 53 => 1,
131		- 56 => 1,
132		- 61 => 1,
133		- 63 => 1,
134		- 64 => 1,
135		- 65 => 1,
136		- 66 => 2,
137		- 70 => 1,
138		- 76 => 1,
139		- 77 => 1,
140		- 78 => 7,
141		- 79 => 2,
142		- 81 => 2,
143		- 82 => 4,
144		- 87 => 1,
145		- 88 => 1,
146		- 92 => 1,
147		- 97 => 1,
148		- 100 => 1,
149		- 101 => 1,
150		- 102 => 1,
151		- 105 => 1,
152		- 106 => 1,
153		- 107 => 1,
154		- 125 => 1,
155		- 126 => 1,
156		- 141 => 1,
157		- 144 => 1,
158		- 146 => 1,
159		- 148 => 1,
160		- 151 => 1,
161		- 157 => 1,
162		- 174 => 3,
163		- 179 => 1,
164		- 190 => 1,
165		- 191 => 1,
166		- 192 => 1,
167		- 207 => 1,
168		- 210 => 1,
169		- 211 => 1,
170		- 215 => 1,
171		- 247 => 1,
172		- 286 => 1,
173		- 287 => 1,
174		- 288 => 1,
175		- 303 => 1,
176		- 309 => 1,
177		- 331 => 2,
178		- 345 => 3,
179		- 348 => 3,
180		- 349 => 2,
181		- 350 => 1,
182		- 352 => 2,
183		- 353 => 2,
184		- 354 => 2,
185		- 355 => 2,
186		- 356 => 2,
187		- 357 => 1,
188		- 358 => 1,
189		- 372 => 1,
190		- 383 => 1,
191		- ];
192		- default:
193		- return [];
	31	+ case 'ArrayDeclarationUnitTest.1.inc':
	32	+ return [
	33	+ 2 => 1,
	34	+ 8 => 2,
	35	+ 10 => 2,
	36	+ 22 => 1,
	37	+ 23 => 2,
	38	+ 24 => 2,
	39	+ 25 => 1,
	40	+ 31 => 2,
	41	+ 35 => 1,
	42	+ 36 => 2,
	43	+ 41 => 1,
	44	+ 46 => 1,
	45	+ 47 => 1,
	46	+ 50 => 1,
	47	+ 51 => 1,
	48	+ 53 => 1,
	49	+ 56 => 1,
	50	+ 58 => 1,
	51	+ 61 => 1,
	52	+ 62 => 1,
	53	+ 63 => 1,
	54	+ 64 => 1,
	55	+ 65 => 1,
	56	+ 66 => 3,
	57	+ 70 => 1,
	58	+ 76 => 2,
	59	+ 77 => 1,
	60	+ 78 => 7,
	61	+ 79 => 2,
	62	+ 81 => 2,
	63	+ 82 => 4,
	64	+ 87 => 1,
	65	+ 88 => 1,
	66	+ 92 => 1,
	67	+ 97 => 1,
	68	+ 100 => 1,
	69	+ 101 => 1,
	70	+ 102 => 1,
	71	+ 105 => 1,
	72	+ 106 => 1,
	73	+ 107 => 1,
	74	+ 125 => 1,
	75	+ 126 => 1,
	76	+ 141 => 1,
	77	+ 144 => 1,
	78	+ 146 => 1,
	79	+ 148 => 1,
	80	+ 151 => 1,
	81	+ 157 => 1,
	82	+ 174 => 3,
	83	+ 179 => 1,
	84	+ 182 => 1,
	85	+ 188 => 1,
	86	+ 207 => 1,
	87	+ 212 => 2,
	88	+ 214 => 1,
	89	+ 218 => 2,
	90	+ 219 => 2,
	91	+ 223 => 1,
	92	+ 255 => 1,
	93	+ 294 => 1,
	94	+ 295 => 1,
	95	+ 296 => 1,
	96	+ 311 => 1,
	97	+ 317 => 1,
	98	+ 339 => 2,
	99	+ 348 => 2,
	100	+ 352 => 2,
	101	+ 355 => 3,
	102	+ 358 => 3,
	103	+ 359 => 2,
	104	+ 360 => 1,
	105	+ 362 => 1,
	106	+ 363 => 2,
	107	+ 364 => 1,
	108	+ 365 => 2,
	109	+ 366 => 2,
	110	+ 367 => 2,
	111	+ 368 => 2,
	112	+ 369 => 1,
	113	+ 370 => 1,
	114	+ 383 => 1,
	115	+ 394 => 1,
	116	+ ];
	117	+ case 'ArrayDeclarationUnitTest.2.inc':
	118	+ return [
	119	+ 2 => 1,
	120	+ 10 => 1,
	121	+ 23 => 2,
	122	+ 24 => 2,
	123	+ 25 => 1,
	124	+ 31 => 2,
	125	+ 36 => 2,
	126	+ 41 => 1,
	127	+ 46 => 1,
	128	+ 47 => 1,
	129	+ 51 => 1,
	130	+ 53 => 1,
	131	+ 56 => 1,
	132	+ 61 => 1,
	133	+ 63 => 1,
	134	+ 64 => 1,
	135	+ 65 => 1,
	136	+ 66 => 2,
	137	+ 70 => 1,
	138	+ 76 => 1,
	139	+ 77 => 1,
	140	+ 78 => 7,
	141	+ 79 => 2,
	142	+ 81 => 2,
	143	+ 82 => 4,
	144	+ 87 => 1,
	145	+ 88 => 1,
	146	+ 92 => 1,
	147	+ 97 => 1,
	148	+ 100 => 1,
	149	+ 101 => 1,
	150	+ 102 => 1,
	151	+ 105 => 1,
	152	+ 106 => 1,
	153	+ 107 => 1,
	154	+ 125 => 1,
	155	+ 126 => 1,
	156	+ 141 => 1,
	157	+ 144 => 1,
	158	+ 146 => 1,
	159	+ 148 => 1,
	160	+ 151 => 1,
	161	+ 157 => 1,
	162	+ 174 => 3,
	163	+ 179 => 1,
	164	+ 190 => 1,
	165	+ 191 => 1,
	166	+ 192 => 1,
	167	+ 207 => 1,
	168	+ 210 => 1,
	169	+ 211 => 1,
	170	+ 215 => 1,
	171	+ 247 => 1,
	172	+ 286 => 1,
	173	+ 287 => 1,
	174	+ 288 => 1,
	175	+ 303 => 1,
	176	+ 309 => 1,
	177	+ 331 => 2,
	178	+ 345 => 3,
	179	+ 348 => 3,
	180	+ 349 => 2,
	181	+ 350 => 1,
	182	+ 352 => 2,
	183	+ 353 => 2,
	184	+ 354 => 2,
	185	+ 355 => 2,
	186	+ 356 => 2,
	187	+ 357 => 1,
	188	+ 358 => 1,
	189	+ 372 => 1,
	190	+ 383 => 1,
	191	+ ];
	192	+ default:
	193	+ return [];
194	194	}//end switch
195	195
196	196	}//end getErrorList()

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/Squiz/Tests/CSS/IndentationUnitTest.php 1 patch

Switch Indentation +23 added lines, -23 removed lines patch added patch discarded remove patch

		@@ -28,30 +28,30 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'IndentationUnitTest.1.css':
32		- return [
33		- 2 => 1,
34		- 3 => 1,
35		- 5 => 1,
36		- 6 => 1,
37		- 7 => 1,
38		- 12 => 1,
39		- 30 => 1,
40		- 32 => 1,
41		- 50 => 1,
42		- 52 => 1,
43		- 53 => 1,
44		- 66 => 1,
45		- 67 => 1,
46		- 68 => 1,
47		- 69 => 1,
48		- 70 => 1,
49		- 71 => 1,
50		- 72 => 1,
51		- ];
	31	+ case 'IndentationUnitTest.1.css':
	32	+ return [
	33	+ 2 => 1,
	34	+ 3 => 1,
	35	+ 5 => 1,
	36	+ 6 => 1,
	37	+ 7 => 1,
	38	+ 12 => 1,
	39	+ 30 => 1,
	40	+ 32 => 1,
	41	+ 50 => 1,
	42	+ 52 => 1,
	43	+ 53 => 1,
	44	+ 66 => 1,
	45	+ 67 => 1,
	46	+ 68 => 1,
	47	+ 69 => 1,
	48	+ 70 => 1,
	49	+ 71 => 1,
	50	+ 72 => 1,
	51	+ ];
52	52
53		- default:
54		- return [];
	53	+ default:
	54	+ return [];
55	55	}//end switch
56	56
57	57	}//end getErrorList()

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/PSR2/Tests/Files/ClosingTagUnitTest.php 1 patch

Switch Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -28,18 +28,18 @@
 block discarded – undo
     public function getErrorList($testFile='')
     {
         switch ($testFile) {
-        case 'ClosingTagUnitTest.1.inc':
-            return [11 => 1];
+        	case 'ClosingTagUnitTest.1.inc':
+            	return [11 => 1];
 
-        case 'ClosingTagUnitTest.4.inc':
-        case 'ClosingTagUnitTest.5.inc':
-            return [1 => 1];
+        	case 'ClosingTagUnitTest.4.inc':
+        	case 'ClosingTagUnitTest.5.inc':
+            	return [1 => 1];
 
-        case 'ClosingTagUnitTest.6.inc':
-            return [5 => 1];
+        	case 'ClosingTagUnitTest.6.inc':
+            	return [5 => 1];
 
-        default:
-            return [];
+        	default:
+            	return [];
         }
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.10.inc 1 patch

Switch Indentation -2 removed lines patch added patch discarded remove patch

		@@ -1,3 +1,1 @@
		block discarded – undo
1	1	<?php
2		-/** Why me?
3		-

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.8.inc 1 patch

Switch Indentation -1 removed lines patch added patch discarded remove patch

		@@ -1,2 +1,1 @@
		block discarded – undo
1	1	<?php
2		-/** Why me?

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.9.inc 1 patch

Switch Indentation -1 removed lines patch added patch discarded remove patch

		@@ -1,2 +1,1 @@
		block discarded – undo
1	1	<?php
2		-/** Why me?
3	2	\ No newline at end of file

Please login to merge, or discard this patch.

php_codesniffer/src/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.php 1 patch

Switch Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -28,15 +28,15 @@
 block discarded – undo
     public function getErrorList($testFile='')
     {
         switch ($testFile) {
-        case 'EndFileNewlineUnitTest.1.inc':
-        case 'EndFileNewlineUnitTest.3.inc':
-        case 'EndFileNewlineUnitTest.6.inc':
-        case 'EndFileNewlineUnitTest.7.inc':
-        case 'EndFileNewlineUnitTest.9.inc':
-        case 'EndFileNewlineUnitTest.10.inc':
-            return [2 => 1];
-        default:
-            return [];
+        	case 'EndFileNewlineUnitTest.1.inc':
+        	case 'EndFileNewlineUnitTest.3.inc':
+        	case 'EndFileNewlineUnitTest.6.inc':
+        	case 'EndFileNewlineUnitTest.7.inc':
+        	case 'EndFileNewlineUnitTest.9.inc':
+        	case 'EndFileNewlineUnitTest.10.inc':
+            	return [2 => 1];
+        	default:
+            	return [];
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc 1 patch

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -34,10 +34,10 @@  discard block
 block discarded – undo
 }
 
 switch ($foo) {
-    case'Foo': {
-        echo 'foo';
-        break;
-        }
+    	case'Foo': {
+        	echo 'foo';
+        	break;
+        	}
 }
 
 while ($i < 10) {
@@ -52,10 +52,10 @@  discard block
 block discarded – undo
 }
 
 switch (true) {
-    case is_resource($value):
-        throw new Exception('foo');
-    case is_object($value):
-        return 'object';
+    	case is_resource($value):
+        	throw new Exception('foo');
+    	case is_object($value):
+        	return 'object';
 }
 
 switch (0) {
@@ -105,13 +105,13 @@  discard block
 block discarded – undo
 }
 
 switch ($foo) {
-    case 1: $bar = 1; break;
-    case 2:
+    	case 1: $bar = 1; break;
+    	case 2:
     
-        $bar = 2; break;
-    case 21:
-    case 3: return 3;
-    default: $bar = 0;
+        	$bar = 2; break;
+    	case 21:
+    	case 3: return 3;
+    	default: $bar = 0;
 }
 
 switch ($foo) {
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
 }
 
 switch ($foo) {
-    case Foo::INTERFACE:
-        return self::INTERFACE;
-    case Foo::NAMESPACE:
-        return self::MODULE;
-    case Foo::TRAIT:
-    case Foo::ARRAY:
-        return self::VALUE;
+    	case Foo::INTERFACE:
+        	return self::INTERFACE;
+    	case Foo::NAMESPACE:
+        	return self::MODULE;
+    	case Foo::TRAIT:
+    	case Foo::ARRAY:
+        	return self::VALUE;
 }
 
 // OK: Every clause terminates

Please login to merge, or discard this patch.

		@@ -57,16 +57,16 @@
		block discarded – undo
57	57	}
58	58
59	59	switch ($blah) {
60		- case 'one':
61		- if ($blah) {
62		- // There are no spaces before break.
63		- }
64		- break;
65		-
66		- default:
67		- if ($blah) {
68		- // Code here.
69		- }
	60	+ case 'one':
	61	+ if ($blah) {
	62	+ // There are no spaces before break.
	63	+ }
	64	+ break;
	65	+
	66	+ default:
	67	+ if ($blah) {
	68	+ // Code here.
	69	+ }
70	70	}
71	71
72	72	foreach ($blah as $var) {

		@@ -28,18 +28,18 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'ClosingTagUnitTest.1.inc':
32		- return [11 => 1];
	31	+ case 'ClosingTagUnitTest.1.inc':
	32	+ return [11 => 1];
33	33
34		- case 'ClosingTagUnitTest.4.inc':
35		- case 'ClosingTagUnitTest.5.inc':
36		- return [1 => 1];
	34	+ case 'ClosingTagUnitTest.4.inc':
	35	+ case 'ClosingTagUnitTest.5.inc':
	36	+ return [1 => 1];
37	37
38		- case 'ClosingTagUnitTest.6.inc':
39		- return [5 => 1];
	38	+ case 'ClosingTagUnitTest.6.inc':
	39	+ return [5 => 1];
40	40
41		- default:
42		- return [];
	41	+ default:
	42	+ return [];
43	43	}
44	44
45	45	}//end getErrorList()

		@@ -28,15 +28,15 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'EndFileNewlineUnitTest.1.inc':
32		- case 'EndFileNewlineUnitTest.3.inc':
33		- case 'EndFileNewlineUnitTest.6.inc':
34		- case 'EndFileNewlineUnitTest.7.inc':
35		- case 'EndFileNewlineUnitTest.9.inc':
36		- case 'EndFileNewlineUnitTest.10.inc':
37		- return [2 => 1];
38		- default:
39		- return [];
	31	+ case 'EndFileNewlineUnitTest.1.inc':
	32	+ case 'EndFileNewlineUnitTest.3.inc':
	33	+ case 'EndFileNewlineUnitTest.6.inc':
	34	+ case 'EndFileNewlineUnitTest.7.inc':
	35	+ case 'EndFileNewlineUnitTest.9.inc':
	36	+ case 'EndFileNewlineUnitTest.10.inc':
	37	+ return [2 => 1];
	38	+ default:
	39	+ return [];
40	40	}//end switch
41	41
42	42	}//end getErrorList()

		@@ -34,10 +34,10 @@ discard block
		block discarded – undo
34	34	}
35	35
36	36	switch ($foo) {
37		- case'Foo': {
38		- echo 'foo';
39		- break;
40		- }
	37	+ case'Foo': {
	38	+ echo 'foo';
	39	+ break;
	40	+ }
41	41	}
42	42
43	43	while ($i < 10) {
		@@ -52,10 +52,10 @@ discard block
		block discarded – undo
52	52	}
53	53
54	54	switch (true) {
55		- case is_resource($value):
56		- throw new Exception('foo');
57		- case is_object($value):
58		- return 'object';
	55	+ case is_resource($value):
	56	+ throw new Exception('foo');
	57	+ case is_object($value):
	58	+ return 'object';
59	59	}
60	60
61	61	switch (0) {
		@@ -105,13 +105,13 @@ discard block
		block discarded – undo
105	105	}
106	106
107	107	switch ($foo) {
108		- case 1: $bar = 1; break;
109		- case 2:
	108	+ case 1: $bar = 1; break;
	109	+ case 2:
110	110
111		- $bar = 2; break;
112		- case 21:
113		- case 3: return 3;
114		- default: $bar = 0;
	111	+ $bar = 2; break;
	112	+ case 21:
	113	+ case 3: return 3;
	114	+ default: $bar = 0;
115	115	}
116	116
117	117	switch ($foo) {
		@@ -146,13 +146,13 @@ discard block
		block discarded – undo
146	146	}
147	147
148	148	switch ($foo) {
149		- case Foo::INTERFACE:
150		- return self::INTERFACE;
151		- case Foo::NAMESPACE:
152		- return self::MODULE;
153		- case Foo::TRAIT:
154		- case Foo::ARRAY:
155		- return self::VALUE;
	149	+ case Foo::INTERFACE:
	150	+ return self::INTERFACE;
	151	+ case Foo::NAMESPACE:
	152	+ return self::MODULE;
	153	+ case Foo::TRAIT:
	154	+ case Foo::ARRAY:
	155	+ return self::VALUE;
156	156	}
157	157
158	158	// OK: Every clause terminates

gravityview / GravityView

Pull Request — develop (#1492)

Category

Switch Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Switch Indentation +163 added lines, -163 removed lines patch added patch discarded remove patch

Switch Indentation +23 added lines, -23 removed lines patch added patch discarded remove patch

Switch Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Switch Indentation -2 removed lines patch added patch discarded remove patch

Switch Indentation -1 removed lines patch added patch discarded remove patch

Switch Indentation -1 removed lines patch added patch discarded remove patch

Switch Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Switch Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch