Completed
Push — develop ( d53d64...92f117 )
by Zack
18:11 queued 14:25
created
includes/class-admin-views.php 1 patch
Indentation   +83 added lines, -83 removed lines patch added patch discarded remove patch
@@ -63,28 +63,28 @@  discard block
 block discarded – undo
63 63
 	}
64 64
 
65 65
 	/**
66
-     * When on the Add/Edit View screen, suggest most popular articles related to that
67
-     *
66
+	 * When on the Add/Edit View screen, suggest most popular articles related to that
67
+	 *
68 68
 	 * @param array $localization_data Data to be passed to the Support Port JS
69 69
 	 *
70 70
 	 * @return array
71 71
 	 */
72 72
 	function suggest_support_articles( $localization_data = array() ) {
73 73
 
74
-	    if( ! gravityview()->request->is_view() ) {
75
-	        return $localization_data;
76
-        }
74
+		if( ! gravityview()->request->is_view() ) {
75
+			return $localization_data;
76
+		}
77 77
 
78 78
 		$localization_data['suggest'] = array(
79
-            '57ef23539033602e61d4a560',
80
-            '54c67bb9e4b0512429885513',
81
-            '54c67bb9e4b0512429885512',
82
-            '54c67bbbe4b07997ea3f3f6b',
83
-            '54d1a33ae4b086c0c0964ce9',
84
-            '57ef253c9033602e61d4a563',
85
-            '552355bfe4b0221aadf2572b',
86
-            '54c67bcde4b051242988553e',
87
-        );
79
+			'57ef23539033602e61d4a560',
80
+			'54c67bb9e4b0512429885513',
81
+			'54c67bb9e4b0512429885512',
82
+			'54c67bbbe4b07997ea3f3f6b',
83
+			'54d1a33ae4b086c0c0964ce9',
84
+			'57ef253c9033602e61d4a563',
85
+			'552355bfe4b0221aadf2572b',
86
+			'54c67bcde4b051242988553e',
87
+		);
88 88
 
89 89
 		return $localization_data;
90 90
 	}
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 
171 171
 		if( 'form_list' === GFForms::get_page() ) {
172 172
 			$priority = 790;
173
-        }
173
+		}
174 174
 
175 175
 		if( empty( $connected_views ) ) {
176 176
 
177
-		    $menu_items['gravityview'] = array(
177
+			$menu_items['gravityview'] = array(
178 178
 				'label'          => esc_attr__( 'Create a View', 'gravityview' ),
179 179
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
180 180
 				'title'          => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -205,13 +205,13 @@  discard block
 block discarded – undo
205 205
 		// If there were no items added, then let's create the parent menu
206 206
 		if( $sub_menu_items ) {
207 207
 
208
-		    $sub_menu_items[] = array(
209
-			    'label' => esc_attr__( 'Create a View', 'gravityview' ),
210
-                'link_class' => 'gv-create-view',
211
-			    'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
212
-			    'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
213
-			    'capabilities'   => array( 'edit_gravityviews' ),
214
-            );
208
+			$sub_menu_items[] = array(
209
+				'label' => esc_attr__( 'Create a View', 'gravityview' ),
210
+				'link_class' => 'gv-create-view',
211
+				'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
212
+				'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
213
+				'capabilities'   => array( 'edit_gravityviews' ),
214
+			);
215 215
 
216 216
 			// Make sure Gravity Forms uses the submenu; if there's only one item, it uses a link instead of a dropdown
217 217
 			$sub_menu_items[] = array(
@@ -596,12 +596,12 @@  discard block
 block discarded – undo
596 596
 	 * Render html for displaying available fields based on a Form ID
597 597
 	 * $blacklist_field_types - contains the field types which are not proper to be shown in a directory.
598 598
 	 *
599
-     * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
599
+	 * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
600 600
 	 * @access public
601
-     *
601
+	 *
602 602
 	 * @param int $form Gravity Forms Form ID (default: '')
603 603
 	 * @param string $context (default: 'single')
604
-     *
604
+	 *
605 605
 	 * @return void
606 606
 	 */
607 607
 	function render_available_fields( $form = 0, $context = 'single' ) {
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 
616 616
 		if ( ! is_array( $blacklist_field_types ) ) {
617 617
 
618
-		    gravityview()->log->error( '$blacklist_field_types is not an array', array( 'data' => print_r( $blacklist_field_types, true ) ) );
618
+			gravityview()->log->error( '$blacklist_field_types is not an array', array( 'data' => print_r( $blacklist_field_types, true ) ) );
619 619
 
620 620
 			$blacklist_field_types = array();
621 621
 		}
@@ -747,12 +747,12 @@  discard block
 block discarded – undo
747 747
 				/**
748 748
 				 * @since 1.7.2
749 749
 				 */
750
-			    'other_entries' => array(
751
-				    'label'	=> __('Other Entries', 'gravityview'),
752
-				    'type'	=> 'other_entries',
753
-				    'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
754
-			    ),
755
-	        );
750
+				'other_entries' => array(
751
+					'label'	=> __('Other Entries', 'gravityview'),
752
+					'type'	=> 'other_entries',
753
+					'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
754
+				),
755
+			);
756 756
 
757 757
 			if( 'single' !== $zone) {
758 758
 
@@ -885,9 +885,9 @@  discard block
 block discarded – undo
885 885
 
886 886
 				$joined_forms = gravityview_get_joined_forms( $post->ID );
887 887
 
888
-                foreach ( $joined_forms as $form ) {
889
-                    $available_items[ $form->ID ] = $this->get_available_fields( $form->ID, $zone );
890
-                }
888
+				foreach ( $joined_forms as $form ) {
889
+					$available_items[ $form->ID ] = $this->get_available_fields( $form->ID, $zone );
890
+				}
891 891
 			} else {
892 892
 				$available_items[ $form ] = $this->get_registered_widgets();
893 893
 			}
@@ -917,9 +917,9 @@  discard block
 block discarded – undo
917 917
 
918 918
 										if ( $form_id ) {
919 919
 											$original_item = isset( $available_items[ $form_id ] [ $field['id'] ] ) ? $available_items[ $form_id ] [ $field['id'] ] : false ;
920
-                                        } else {
920
+										} else {
921 921
 											$original_item = isset( $available_items[ $field['id'] ] ) ? $available_items[ $field['id'] ] : false ;
922
-                                        }
922
+										}
923 923
 
924 924
 										if ( !$original_item ) {
925 925
 											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array(' data' => array('available_items' => $available_items, 'field' => $field ) ) );
@@ -1001,13 +1001,13 @@  discard block
 block discarded – undo
1001 1001
 	}
1002 1002
 
1003 1003
 	/**
1004
-     * Renders "Add Field" tooltips
1005
-     *
1006
-     * @since 2.0.11
1007
-     *
1004
+	 * Renders "Add Field" tooltips
1005
+	 *
1006
+	 * @since 2.0.11
1007
+	 *
1008 1008
 	 * @param string $context "directory", "single", or "edit"
1009
-     *
1010
-     * @return void
1009
+	 *
1010
+	 * @return void
1011 1011
 	 */
1012 1012
 	function render_field_pickers( $context = 'directory' ) {
1013 1013
 
@@ -1034,7 +1034,7 @@  discard block
 block discarded – undo
1034 1034
             </div>
1035 1035
 			<?php
1036 1036
 		}
1037
-    }
1037
+	}
1038 1038
 
1039 1039
 	/**
1040 1040
 	 * Render the Template Active Areas and configured active fields for a given template id and post id
@@ -1100,7 +1100,7 @@  discard block
 block discarded – undo
1100 1100
 		$is_widgets_page = ( $pagenow === 'widgets.php' );
1101 1101
 
1102 1102
 		// Add the GV font (with the Astronaut)
1103
-        wp_enqueue_style( 'gravityview_global', plugins_url('assets/css/admin-global.css', GRAVITYVIEW_FILE), array(), \GV\Plugin::$version );
1103
+		wp_enqueue_style( 'gravityview_global', plugins_url('assets/css/admin-global.css', GRAVITYVIEW_FILE), array(), \GV\Plugin::$version );
1104 1104
 		wp_register_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array( 'dashicons', 'wp-jquery-ui-dialog' ), \GV\Plugin::$version );
1105 1105
 
1106 1106
 		wp_register_script( 'gravityview-jquery-cookie', plugins_url('assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE), array( 'jquery' ), \GV\Plugin::$version, true );
@@ -1108,63 +1108,63 @@  discard block
 block discarded – undo
1108 1108
 		if( GFForms::get_page() === 'form_list' ) {
1109 1109
 			wp_enqueue_style( 'gravityview_views_styles' );
1110 1110
 			return;
1111
-        }
1111
+		}
1112 1112
 
1113 1113
 		// Don't process any scripts below here if it's not a GravityView page.
1114 1114
 		if( ! gravityview()->request->is_admin( $hook, 'single' ) && ! $is_widgets_page ) {
1115
-		    return;
1115
+			return;
1116 1116
 		}
1117 1117
 
1118
-        wp_enqueue_script( 'jquery-ui-datepicker' );
1119
-        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), \GV\Plugin::$version );
1120
-
1121
-        $script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1122
-
1123
-        //enqueue scripts
1124
-        wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), \GV\Plugin::$version );
1125
-
1126
-        wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1127
-            'cookiepath' => COOKIEPATH,
1128
-            'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1129
-            'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1130
-            'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1131
-            'label_close' => __( 'Close', 'gravityview' ),
1132
-            'label_cancel' => __( 'Cancel', 'gravityview' ),
1133
-            'label_continue' => __( 'Continue', 'gravityview' ),
1134
-            'label_ok' => __( 'Ok', 'gravityview' ),
1135
-            'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1136
-            'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1137
-            'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1138
-            'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1139
-            'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1140
-        ));
1118
+		wp_enqueue_script( 'jquery-ui-datepicker' );
1119
+		wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), \GV\Plugin::$version );
1120
+
1121
+		$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1122
+
1123
+		//enqueue scripts
1124
+		wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), \GV\Plugin::$version );
1125
+
1126
+		wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1127
+			'cookiepath' => COOKIEPATH,
1128
+			'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1129
+			'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1130
+			'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1131
+			'label_close' => __( 'Close', 'gravityview' ),
1132
+			'label_cancel' => __( 'Cancel', 'gravityview' ),
1133
+			'label_continue' => __( 'Continue', 'gravityview' ),
1134
+			'label_ok' => __( 'Ok', 'gravityview' ),
1135
+			'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1136
+			'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1137
+			'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1138
+			'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1139
+			'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1140
+		));
1141 1141
 
1142 1142
 		wp_enqueue_style( 'gravityview_views_styles' );
1143 1143
 
1144
-        // Enqueue scripts needed for merge tags
1145
-        self::enqueue_gravity_forms_scripts();
1144
+		// Enqueue scripts needed for merge tags
1145
+		self::enqueue_gravity_forms_scripts();
1146 1146
 	}
1147 1147
 
1148 1148
 	/**
1149 1149
 	 * Enqueue Gravity Forms scripts, needed for Merge Tags
1150
-     *
1151
-     * @since 1.0.5-beta
1152
-     *
1153
-     * @return void
1150
+	 *
1151
+	 * @since 1.0.5-beta
1152
+	 *
1153
+	 * @return void
1154 1154
 	 */
1155 1155
 	static function enqueue_gravity_forms_scripts() {
1156 1156
 		GFForms::register_scripts();
1157 1157
 
1158 1158
 		$scripts = array(
1159
-		    'sack',
1160
-		    'gform_gravityforms',
1161
-		    'gform_forms',
1162
-		    'gform_form_admin',
1163
-		    'jquery-ui-autocomplete'
1159
+			'sack',
1160
+			'gform_gravityforms',
1161
+			'gform_forms',
1162
+			'gform_form_admin',
1163
+			'jquery-ui-autocomplete'
1164 1164
 		);
1165 1165
 
1166 1166
 		if ( wp_is_mobile() ) {
1167
-		    $scripts[] = 'jquery-touch-punch';
1167
+			$scripts[] = 'jquery-touch-punch';
1168 1168
 		}
1169 1169
 
1170 1170
 		wp_enqueue_script( $scripts );
Please login to merge, or discard this patch.
includes/class-gravityview-change-entry-creator.php 1 patch
Indentation   +209 added lines, -209 removed lines patch added patch discarded remove patch
@@ -5,239 +5,239 @@
 block discarded – undo
5 5
  */
6 6
 class GravityView_Change_Entry_Creator {
7 7
 
8
-    function __construct() {
9
-
10
-    	/**
11
-    	 * @since  1.5.1
12
-    	 */
13
-    	add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
14
-
15
-    	// ONLY ADMIN FROM HERE ON.
16
-    	if( !is_admin() ) { return; }
17
-
18
-	    /**
19
-         * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20
-	     * @since 1.7.4
21
-	     * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22
-	     */
23
-	    if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
24
-		    return;
25
-	    }
26
-
27
-        /**
28
-         * Use `init` to fix bbPress warning
29
-         * @see https://bbpress.trac.wordpress.org/ticket/2309
30
-         */
31
-    	add_action('init', array( $this, 'load'), 100 );
32
-
33
-    	add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
34
-
35
-    }
36
-
37
-    /**
38
-     * When an user is created using the User Registration add-on, assign the entry to them
39
-     *
40
-     * @since  1.5.1
41
-     * @uses RGFormsModel::update_lead_property() Modify the entry `created_by` field
42
-     * @param  int $user_id  WordPress User ID
43
-     * @param  array $config   User registration feed configuration
44
-     * @param  array  $entry     GF Entry array
45
-     * @param  string $password User password
46
-     * @return void
47
-     */
48
-    function assign_new_user_to_lead( $user_id, $config, $entry = array(), $password = '' ) {
49
-
50
-    	/**
51
-    	 * Disable assigning the new user to the entry by returning false.
52
-    	 * @param  int $user_id  WordPress User ID
53
-	     * @param  array $config   User registration feed configuration
54
-	     * @param  array  $entry     GF Entry array
55
-    	 */
56
-    	$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57
-
58
-    	// If filter returns false, do not process
59
-    	if( empty( $assign_to_lead ) ) {
60
-    		return;
61
-    	}
62
-
63
-    	// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
-    	$result = RGFormsModel::update_entry_property( (int) $entry['id'], 'created_by', (int) $user_id, false, true );
65
-
66
-    	if ( false === $result ) {
67
-    		$status = __('Error', 'gravityview');
68
-    		global $wpdb;
69
-		    $note = sprintf( '%s: Failed to assign User ID #%d as the entry creator (Last database error: "%s")', $status, $user_id, $wpdb->last_error );
70
-    	} else {
71
-    		$status = __('Success', 'gravityview');
72
-    	    $note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
73
-    	}
74
-
75
-    	gravityview()->log->debug( 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - {note}', array( 'note' => $note ) );
76
-
77
-	    /**
78
-	     * @filter `gravityview_disable_change_entry_creator_note` Disable adding a note when changing the entry creator
79
-	     * @since 1.21.5
80
-	     * @param boolean $disable Disable the Change Entry Creator note. Default: false.
81
-	     */
82
-	    if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
83
-		    return;
84
-	    }
85
-
86
-        GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
87
-
88
-    }
89
-
90
-    /**
91
-     * Disable previous functionality; use this one as the canonical.
92
-     * @return void
93
-     */
94
-    function prevent_conflicts() {
95
-
96
-    	// Plugin that was provided here:
97
-    	// @link https://gravityview.co/support/documentation/201991205/
98
-    	remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
-    	remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
100
-
101
-    }
102
-
103
-    /**
104
-     * @since  3.6.3
105
-     * @return void
106
-     */
107
-    function load() {
108
-
109
-    	// Does GF exist?
110
-        if( !class_exists('GFCommon') ) {
111
-            return;
112
-        }
113
-
114
-        // Can the user edit entries?
115
-        if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
116
-            return;
117
-        }
118
-
119
-        // If screen mode isn't set, then we're in the wrong place.
120
-        if( empty( $_REQUEST['screen_mode'] ) ) {
121
-            return;
122
-        }
123
-
124
-        // Now, no validation is required in the methods; let's hook in.
125
-        add_action('admin_init', array( &$this, 'set_screen_mode' ) );
126
-
127
-        add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
128
-
129
-        add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
130
-
131
-    }
132
-
133
-    /**
134
-     * Allows for edit links to work with a link instead of a form (GET instead of POST)
135
-     * @return void
136
-     */
137
-    function set_screen_mode() {
138
-
139
-    	// If $_GET['screen_mode'] is set to edit, set $_POST value
140
-        if( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
141
-            $_POST["screen_mode"] = 'edit';
142
-        }
143
-
144
-    }
145
-
146
-    /**
147
-     * When the entry creator is changed, add a note to the entry
148
-     * @param  array $form   GF entry array
149
-     * @param  int $entry_id Entry ID
150
-     * @return void
151
-     */
152
-    function update_entry_creator($form, $entry_id) {
153
-            global $current_user;
8
+	function __construct() {
9
+
10
+		/**
11
+		 * @since  1.5.1
12
+		 */
13
+		add_action('gform_user_registered', array( $this, 'assign_new_user_to_lead'), 10, 4 );
14
+
15
+		// ONLY ADMIN FROM HERE ON.
16
+		if( !is_admin() ) { return; }
17
+
18
+		/**
19
+		 * @filter `gravityview_disable_change_entry_creator` Disable the Change Entry Creator functionality
20
+		 * @since 1.7.4
21
+		 * @param boolean $disable Disable the Change Entry Creator functionality. Default: false.
22
+		 */
23
+		if( apply_filters('gravityview_disable_change_entry_creator', false ) ) {
24
+			return;
25
+		}
26
+
27
+		/**
28
+		 * Use `init` to fix bbPress warning
29
+		 * @see https://bbpress.trac.wordpress.org/ticket/2309
30
+		 */
31
+		add_action('init', array( $this, 'load'), 100 );
32
+
33
+		add_action('plugins_loaded', array( $this, 'prevent_conflicts') );
34
+
35
+	}
36
+
37
+	/**
38
+	 * When an user is created using the User Registration add-on, assign the entry to them
39
+	 *
40
+	 * @since  1.5.1
41
+	 * @uses RGFormsModel::update_lead_property() Modify the entry `created_by` field
42
+	 * @param  int $user_id  WordPress User ID
43
+	 * @param  array $config   User registration feed configuration
44
+	 * @param  array  $entry     GF Entry array
45
+	 * @param  string $password User password
46
+	 * @return void
47
+	 */
48
+	function assign_new_user_to_lead( $user_id, $config, $entry = array(), $password = '' ) {
49
+
50
+		/**
51
+		 * Disable assigning the new user to the entry by returning false.
52
+		 * @param  int $user_id  WordPress User ID
53
+		 * @param  array $config   User registration feed configuration
54
+		 * @param  array  $entry     GF Entry array
55
+		 */
56
+		$assign_to_lead = apply_filters( 'gravityview_assign_new_user_to_entry', true, $user_id, $config, $entry );
57
+
58
+		// If filter returns false, do not process
59
+		if( empty( $assign_to_lead ) ) {
60
+			return;
61
+		}
62
+
63
+		// Update the entry. The `false` prevents checking Akismet; `true` disables the user updated hook from firing
64
+		$result = RGFormsModel::update_entry_property( (int) $entry['id'], 'created_by', (int) $user_id, false, true );
65
+
66
+		if ( false === $result ) {
67
+			$status = __('Error', 'gravityview');
68
+			global $wpdb;
69
+			$note = sprintf( '%s: Failed to assign User ID #%d as the entry creator (Last database error: "%s")', $status, $user_id, $wpdb->last_error );
70
+		} else {
71
+			$status = __('Success', 'gravityview');
72
+			$note = sprintf( _x('%s: Assigned User ID #%d as the entry creator.', 'First parameter: Success or error of the action. Second: User ID number', 'gravityview'), $status, $user_id );
73
+		}
74
+
75
+		gravityview()->log->debug( 'GravityView_Change_Entry_Creator[assign_new_user_to_lead] - {note}', array( 'note' => $note ) );
76
+
77
+		/**
78
+		 * @filter `gravityview_disable_change_entry_creator_note` Disable adding a note when changing the entry creator
79
+		 * @since 1.21.5
80
+		 * @param boolean $disable Disable the Change Entry Creator note. Default: false.
81
+		 */
82
+		if( apply_filters('gravityview_disable_change_entry_creator_note', false ) ) {
83
+			return;
84
+		}
85
+
86
+		GravityView_Entry_Notes::add_note( $entry['id'], -1, 'GravityView', $note, 'gravityview' );
87
+
88
+	}
89
+
90
+	/**
91
+	 * Disable previous functionality; use this one as the canonical.
92
+	 * @return void
93
+	 */
94
+	function prevent_conflicts() {
95
+
96
+		// Plugin that was provided here:
97
+		// @link https://gravityview.co/support/documentation/201991205/
98
+		remove_action("gform_entry_info", 'gravityview_change_entry_creator_form', 10 );
99
+		remove_action("gform_after_update_entry", 'gravityview_update_entry_creator', 10 );
100
+
101
+	}
102
+
103
+	/**
104
+	 * @since  3.6.3
105
+	 * @return void
106
+	 */
107
+	function load() {
108
+
109
+		// Does GF exist?
110
+		if( !class_exists('GFCommon') ) {
111
+			return;
112
+		}
113
+
114
+		// Can the user edit entries?
115
+		if( ! GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_entries' ) ) ) {
116
+			return;
117
+		}
118
+
119
+		// If screen mode isn't set, then we're in the wrong place.
120
+		if( empty( $_REQUEST['screen_mode'] ) ) {
121
+			return;
122
+		}
123
+
124
+		// Now, no validation is required in the methods; let's hook in.
125
+		add_action('admin_init', array( &$this, 'set_screen_mode' ) );
126
+
127
+		add_action("gform_entry_info", array( &$this, 'add_select' ), 10, 2);
128
+
129
+		add_action("gform_after_update_entry", array( &$this, 'update_entry_creator' ), 10, 2);
130
+
131
+	}
132
+
133
+	/**
134
+	 * Allows for edit links to work with a link instead of a form (GET instead of POST)
135
+	 * @return void
136
+	 */
137
+	function set_screen_mode() {
138
+
139
+		// If $_GET['screen_mode'] is set to edit, set $_POST value
140
+		if( \GV\Utils::_GET( 'screen_mode' ) === 'edit' ) {
141
+			$_POST["screen_mode"] = 'edit';
142
+		}
143
+
144
+	}
145
+
146
+	/**
147
+	 * When the entry creator is changed, add a note to the entry
148
+	 * @param  array $form   GF entry array
149
+	 * @param  int $entry_id Entry ID
150
+	 * @return void
151
+	 */
152
+	function update_entry_creator($form, $entry_id) {
153
+			global $current_user;
154 154
 
155
-        // Update the entry
156
-        $created_by = absint( \GV\Utils::_POST( 'created_by') );
155
+		// Update the entry
156
+		$created_by = absint( \GV\Utils::_POST( 'created_by') );
157 157
 
158
-        RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
158
+		RGFormsModel::update_lead_property( $entry_id, 'created_by', $created_by );
159 159
 
160
-        // If the creator has changed, let's add a note about who it used to be.
161
-        $originally_created_by = \GV\Utils::_POST( 'originally_created_by' );
160
+		// If the creator has changed, let's add a note about who it used to be.
161
+		$originally_created_by = \GV\Utils::_POST( 'originally_created_by' );
162 162
 
163
-        // If there's no owner and there didn't used to be, keep going
164
-        if( empty( $originally_created_by ) && empty( $created_by ) ) {
165
-            return;
166
-        }
163
+		// If there's no owner and there didn't used to be, keep going
164
+		if( empty( $originally_created_by ) && empty( $created_by ) ) {
165
+			return;
166
+		}
167 167
 
168
-        // If the values have changed
169
-        if( absint( $originally_created_by ) !== absint( $created_by ) ) {
168
+		// If the values have changed
169
+		if( absint( $originally_created_by ) !== absint( $created_by ) ) {
170 170
 
171
-            $user_data = get_userdata($current_user->ID);
171
+			$user_data = get_userdata($current_user->ID);
172 172
 
173
-            $user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
173
+			$user_format = _x('%s (ID #%d)', 'The name and the ID of users who initiated changes to entry ownership', 'gravityview');
174 174
 
175
-            $original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
175
+			$original_name = $created_by_name = esc_attr_x( 'No User', 'To show that the entry was unassigned from an actual user to no user.', 'gravityview');
176 176
 
177
-            if( !empty( $originally_created_by ) ) {
178
-                $originally_created_by_user_data = get_userdata($originally_created_by);
179
-                $original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
180
-            }
177
+			if( !empty( $originally_created_by ) ) {
178
+				$originally_created_by_user_data = get_userdata($originally_created_by);
179
+				$original_name = sprintf( $user_format, $originally_created_by_user_data->display_name, $originally_created_by_user_data->ID );
180
+			}
181 181
 
182
-            if( !empty( $created_by ) ) {
183
-                $created_by_user_data =  get_userdata($created_by);
184
-                $created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
185
-            }
182
+			if( !empty( $created_by ) ) {
183
+				$created_by_user_data =  get_userdata($created_by);
184
+				$created_by_name = sprintf( $user_format, $created_by_user_data->display_name, $created_by_user_data->ID );
185
+			}
186 186
 
187
-            GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
188
-        }
187
+			GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $user_data->display_name, sprintf( __('Changed entry creator from %s to %s', 'gravityview'), $original_name, $created_by_name ), 'note' );
188
+		}
189 189
 
190
-    }
190
+	}
191 191
 
192
-    /**
193
-     * Output the select to change the entry creator
194
-     * @param int $form_id GF Form ID
195
-     * @param array $entry    GF entry array
196
-     * @return void
197
-     */
198
-    function add_select($form_id, $entry ) {
192
+	/**
193
+	 * Output the select to change the entry creator
194
+	 * @param int $form_id GF Form ID
195
+	 * @param array $entry    GF entry array
196
+	 * @return void
197
+	 */
198
+	function add_select($form_id, $entry ) {
199 199
 
200
-        if( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
201
-            return;
202
-        }
200
+		if( \GV\Utils::_POST( 'screen_mode' ) !== 'edit' ) {
201
+			return;
202
+		}
203 203
 
204
-        $created_by_id = \GV\Utils::get( $entry, 'created_by' );
204
+		$created_by_id = \GV\Utils::get( $entry, 'created_by' );
205 205
 
206
-        $users = GVCommon::get_users( 'change_entry_creator' );
206
+		$users = GVCommon::get_users( 'change_entry_creator' );
207 207
 
208
-        $is_created_by_in_users = wp_list_filter( $users, array( 'ID' => $created_by_id ) );
208
+		$is_created_by_in_users = wp_list_filter( $users, array( 'ID' => $created_by_id ) );
209 209
 
210
-        // Make sure that the entry creator is included in the users list. If not, add them.
211
-        if ( ! empty( $created_by_id ) && empty( $is_created_by_in_users ) ) {
210
+		// Make sure that the entry creator is included in the users list. If not, add them.
211
+		if ( ! empty( $created_by_id ) && empty( $is_created_by_in_users ) ) {
212 212
 
213
-	        if ( $created_by_user = GVCommon::get_users( 'change_entry_creator', array( 'include' => $created_by_id ) ) ) {
214
-	            $users = array_merge( $users, $created_by_user );
215
-	        }
216
-	    }
213
+			if ( $created_by_user = GVCommon::get_users( 'change_entry_creator', array( 'include' => $created_by_id ) ) ) {
214
+				$users = array_merge( $users, $created_by_user );
215
+			}
216
+		}
217 217
 
218
-        $output = '<label for="change_created_by">';
219
-        $output .= esc_html__('Change Entry Creator:', 'gravityview');
220
-        $output .= '</label>';
218
+		$output = '<label for="change_created_by">';
219
+		$output .= esc_html__('Change Entry Creator:', 'gravityview');
220
+		$output .= '</label>';
221 221
 
222
-	    // If there are users who are not being shown, show a warning.
223
-	    // TODO: Use AJAX instead of <select>
224
-	    $count_users = count_users();
225
-	    if( sizeof( $users ) < $count_users['total_users'] ) {
226
-		    $output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
227
-	    }
222
+		// If there are users who are not being shown, show a warning.
223
+		// TODO: Use AJAX instead of <select>
224
+		$count_users = count_users();
225
+		if( sizeof( $users ) < $count_users['total_users'] ) {
226
+			$output .= '<p><i class="dashicons dashicons-warning"></i> ' . sprintf( esc_html__( 'The displayed list of users has been trimmed due to the large number of users. %sLearn how to remove this limit%s.', 'gravityview' ), '<a href="https://docs.gravityview.co/article/251-i-only-see-some-users-in-the-change-entry-creator-dropdown" rel="external">', '</a>' ) . '</p>';
227
+		}
228 228
 
229
-	    $output .= '<select name="created_by" id="change_created_by" class="widefat">';
230
-        $output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
231
-        foreach($users as $user) {
232
-            $output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
233
-        }
234
-        $output .= '</select>';
235
-        $output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
229
+		$output .= '<select name="created_by" id="change_created_by" class="widefat">';
230
+		$output .= '<option value="' . selected( $entry['created_by'], '0', false ) . '"> &mdash; '.esc_attr_x( 'No User', 'No user assigned to the entry', 'gravityview').' &mdash; </option>';
231
+		foreach($users as $user) {
232
+			$output .= '<option value="'. $user->ID .'"'. selected( $entry['created_by'], $user->ID, false ).'>'.esc_attr( $user->display_name.' ('.$user->user_nicename.')' ).'</option>';
233
+		}
234
+		$output .= '</select>';
235
+		$output .= '<input name="originally_created_by" value="'.esc_attr( $entry['created_by'] ).'" type="hidden" />';
236 236
 
237
-	    unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
237
+		unset( $is_created_by_in_users, $created_by_user, $users, $created_by_id, $count_users );
238 238
 
239
-        echo $output;
240
-    }
239
+		echo $output;
240
+	}
241 241
 
242 242
 }
243 243
 
Please login to merge, or discard this patch.
includes/widgets/search-widget/templates/search-field-select.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 }
17 17
 
18 18
 if( is_array( $search_field['value'] ) ) {
19
-    gravityview()->log->debug( 'search-field-select.php - Array values passed; using first value.' );
19
+	gravityview()->log->debug( 'search-field-select.php - Array values passed; using first value.' );
20 20
 	$search_field['value'] = reset( $search_field['value'] );
21 21
 }
22 22
 
Please login to merge, or discard this patch.
includes/admin/class-gravityview-support-port.php 1 patch
Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 
14 14
 	/**
15 15
 	 * @var string The hash key used to generate secure message history
16
-     * @since 2.2.5
16
+	 * @since 2.2.5
17 17
 	 */
18 18
 	const beacon_key = 'lCXlwbQR707kipR+J0MCqcxrhGOHjGF0ldD6yNbGM0w=';
19 19
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 			'payment_id'       => '',
111 111
 			'customer_name'    => '',
112 112
 			'customer_email'   => '',
113
-            'price_id'         => '0',
113
+			'price_id'         => '0',
114 114
 		) );
115 115
 
116 116
 		// This is just HTML we don't need.
@@ -127,9 +127,9 @@  discard block
 block discarded – undo
127 127
 			case 3:
128 128
 				$package = 'All Access';
129 129
 				break;
130
-            case 4:
131
-                $package = 'Lifetime';
132
-                break;
130
+			case 4:
131
+				$package = 'Lifetime';
132
+				break;
133 133
 		}
134 134
 
135 135
 		$current_user = wp_get_current_user();
@@ -159,27 +159,27 @@  discard block
 block discarded – undo
159 159
 		// Help Scout length limit is 200 characters
160 160
 		foreach( $data as $key => $value ) {
161 161
 			if ( ! is_string( $value ) ) {
162
-                continue;
162
+				continue;
163 163
 			}
164
-		    $data[ $key ] = mb_substr( $value, 0, 200 );
165
-        }
164
+			$data[ $key ] = mb_substr( $value, 0, 200 );
165
+		}
166 166
 
167 167
 		$localization_data = array(
168 168
 			'contactEnabled' => (int)GVCommon::has_cap( 'gravityview_contact_support' ),
169 169
 			'data' => $data,
170 170
 			'translation' => $translation,
171
-            'suggest' => array(),
171
+			'suggest' => array(),
172 172
 		);
173 173
 
174 174
 		/**
175
-         * @filter `gravityview/support_port/localization_data` Filter data passed to the Support Port, before localize_script is run
175
+		 * @filter `gravityview/support_port/localization_data` Filter data passed to the Support Port, before localize_script is run
176 176
 		 * @since 2.0
177
-         * @param array $localization_data {
178
-         *   @type int $contactEnabled Can the user contact support?
179
-         *   @type array $data Support/license info
180
-         *   @type array $translation i18n strings
181
-         *   @type array $suggest Article IDs to recommend to the user (per page in the admin
182
-         * }
177
+		 * @param array $localization_data {
178
+		 *   @type int $contactEnabled Can the user contact support?
179
+		 *   @type array $data Support/license info
180
+		 *   @type array $translation i18n strings
181
+		 *   @type array $suggest Article IDs to recommend to the user (per page in the admin
182
+		 * }
183 183
 		 */
184 184
 		$localization_data = apply_filters( 'gravityview/support_port/localization_data', $localization_data );
185 185
 
@@ -193,11 +193,11 @@  discard block
 block discarded – undo
193 193
 	 *
194 194
 	 * If the user doesn't have the `gravityview_support_port` capability, returns false; then
195 195
 	 * If global setting is "hide", returns false; then
196
-     * If user preference is not set, return global setting; then
197
-     * If user preference is set, return that setting.
196
+	 * If user preference is not set, return global setting; then
197
+	 * If user preference is set, return that setting.
198 198
 	 *
199 199
 	 * @since 1.15
200
-     * @since 1.17.5 Changed behavior to respect global setting
200
+	 * @since 1.17.5 Changed behavior to respect global setting
201 201
 	 *
202 202
 	 * @param int $user Optional. ID of the user to check, defaults to 0 for current user.
203 203
 	 *
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 		$global_setting = gravityview()->plugin->settings->get( 'support_port' );
213 213
 
214 214
 		if ( empty( $global_setting ) ) {
215
-            return false;
215
+			return false;
216 216
 		}
217 217
 
218 218
 		// Get the per-user Support Port setting
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 	 * Modifies the output of profile.php to add GravityView Support preference
249 249
 	 *
250 250
 	 * @since 1.15
251
-     * @since 1.17.5 Only show if global setting is active
251
+	 * @since 1.17.5 Only show if global setting is active
252 252
 	 *
253 253
 	 * @param WP_User $user Current user info
254 254
 	 *
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 		$global_setting = gravityview()->plugin->settings->get( 'support_port' );
260 260
 
261 261
 		if ( empty( $global_setting ) ) {
262
-            return;
262
+			return;
263 263
 		}
264 264
 
265 265
 		/**
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Indentation   +289 added lines, -289 removed lines patch added patch discarded remove patch
@@ -102,10 +102,10 @@  discard block
 block discarded – undo
102 102
 
103 103
 	/**
104 104
 	 * ID of the current post. May also be ID of the current View.
105
-     *
106
-     * @since 2.0.13
107
-     * 
108
-     * @var int
105
+	 *
106
+	 * @since 2.0.13
107
+	 * 
108
+	 * @var int
109 109
 	 */
110 110
 	public $post_id;
111 111
 
@@ -177,12 +177,12 @@  discard block
 block discarded – undo
177 177
 	public function prevent_maybe_process_form() {
178 178
 
179 179
 		if( ! empty( $_POST ) ) {
180
-	        gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
180
+			gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', array( 'data' => esc_html( print_r( $_POST, true ) ) ) );
181 181
 		}
182 182
 
183 183
 		if( $this->is_edit_entry_submission() ) {
184 184
 			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
185
-	        remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
185
+			remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
186 186
 		}
187 187
 	}
188 188
 
@@ -210,14 +210,14 @@  discard block
 block discarded – undo
210 210
 	 * When Edit entry view is requested setup the vars
211 211
 	 */
212 212
 	private function setup_vars() {
213
-        global $post;
213
+		global $post;
214 214
 
215 215
 		$gravityview_view = GravityView_View::getInstance();
216 216
 
217 217
 
218 218
 		$entries = $gravityview_view->getEntries();
219
-	    self::$original_entry = $entries[0];
220
-	    $this->entry = $entries[0];
219
+		self::$original_entry = $entries[0];
220
+		$this->entry = $entries[0];
221 221
 
222 222
 		self::$original_form = $gravityview_view->getForm();
223 223
 		$this->form = $gravityview_view->getForm();
@@ -359,8 +359,8 @@  discard block
 block discarded – undo
359 359
 
360 360
 			GFFormsModel::save_lead( $form, $this->entry );
361 361
 
362
-	        // Delete the values for hidden inputs
363
-	        $this->unset_hidden_field_values();
362
+			// Delete the values for hidden inputs
363
+			$this->unset_hidden_field_values();
364 364
 			
365 365
 			$this->entry['date_created'] = $date_created;
366 366
 
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
 			// Perform actions normally performed after updating a lead
371 371
 			$this->after_update();
372 372
 
373
-	        /**
373
+			/**
374 374
 			 * Must be AFTER after_update()!
375 375
 			 * @see https://github.com/gravityview/GravityView/issues/764
376 376
 			 */
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
 			/**
380 380
 			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
381
-             * @since 2.1 Added $gv_data parameter
381
+			 * @since 2.1 Added $gv_data parameter
382 382
 			 * @param array $form Gravity Forms form array
383 383
 			 * @param string $entry_id Numeric ID of the entry that was updated
384 384
 			 * @param GravityView_Edit_Entry_Render $this This object
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 	 * @return void
403 403
 	 */
404 404
 	private function unset_hidden_field_values() {
405
-	    global $wpdb;
405
+		global $wpdb;
406 406
 
407 407
 		/**
408 408
 		 * @filter `gravityview/edit_entry/unset_hidden_field_values` Whether to delete values of fields hidden by conditional logic
@@ -424,29 +424,29 @@  discard block
 block discarded – undo
424 424
 			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
425 425
 		}
426 426
 
427
-	    foreach ( $this->entry as $input_id => $field_value ) {
427
+		foreach ( $this->entry as $input_id => $field_value ) {
428 428
 
429
-		    $field = RGFormsModel::get_field( $this->form, $input_id );
429
+			$field = RGFormsModel::get_field( $this->form, $input_id );
430 430
 
431
-		    // Reset fields that are hidden
432
-		    // Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
433
-		    if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
431
+			// Reset fields that are hidden
432
+			// Don't pass $entry as fourth parameter; force using $_POST values to calculate conditional logic
433
+			if ( GFFormsModel::is_field_hidden( $this->form, $field, array(), NULL ) ) {
434 434
 
435 435
 				$empty_value = $field->get_value_save_entry(
436 436
 					is_array( $field->get_entry_inputs() ) ? array() : '',
437 437
 					$this->form, '', $this->entry['id'], $this->entry
438 438
 				);
439 439
 
440
-			    $lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
440
+				$lead_detail_id = GFFormsModel::get_lead_detail_id( $current_fields, $input_id );
441 441
 
442
-			    GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
442
+				GFFormsModel::update_lead_field_value( $this->form, $this->entry, $field, $lead_detail_id, $input_id, $empty_value );
443 443
 
444
-			    // Prevent the $_POST values of hidden fields from being used as default values when rendering the form
444
+				// Prevent the $_POST values of hidden fields from being used as default values when rendering the form
445 445
 				// after submission
446
-			    $post_input_id = 'input_' . str_replace( '.', '_', $input_id );
447
-			    $_POST[ $post_input_id ] = '';
448
-		    }
449
-	    }
446
+				$post_input_id = 'input_' . str_replace( '.', '_', $input_id );
447
+				$_POST[ $post_input_id ] = '';
448
+			}
449
+		}
450 450
 	}
451 451
 
452 452
 	/**
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 
543 543
 		$non_submitted_fields = array();
544 544
 
545
-	    /** @var GF_Field $field */
545
+		/** @var GF_Field $field */
546 546
 		foreach( $form['fields'] as $k => &$field ) {
547 547
 
548 548
 			/**
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
 
559 559
 			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
560 560
 				foreach( $field->inputs as $key => $input ) {
561
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
561
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
562 562
 				}
563 563
 			}
564 564
 
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 			foreach ( $this->fields_with_calculation as $field ) {
620 620
 				$inputs = $field->get_entry_inputs();
621 621
 				if ( is_array( $inputs ) ) {
622
-				    foreach ( $inputs as $input ) {
622
+					foreach ( $inputs as $input ) {
623 623
 						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
624 624
 
625 625
 						if ( 'product' === $field->type ) {
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 						}
639 639
 
640 640
 						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
641
-				    }
641
+					}
642 642
 				} else {
643 643
 					// Set to what it previously was if it's not editable
644 644
 					if ( ! in_array( $field->id, $allowed_fields ) ) {
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
685 685
 
686 686
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
687
-	        $ary = stripslashes_deep( $ary );
687
+			$ary = stripslashes_deep( $ary );
688 688
 			$img_url = \GV\Utils::get( $ary, 0 );
689 689
 
690 690
 			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
@@ -757,7 +757,7 @@  discard block
 block discarded – undo
757 757
 	private function maybe_update_post_fields( $form ) {
758 758
 
759 759
 		if( empty( $this->entry['post_id'] ) ) {
760
-	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
760
+			gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
761 761
 			return;
762 762
 		}
763 763
 
@@ -792,49 +792,49 @@  discard block
 block discarded – undo
792 792
 
793 793
 				switch( $field->type ) {
794 794
 
795
-				    case 'post_title':
796
-				        $post_title = $value;
797
-				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
798
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
799
-				        }
800
-				        $updated_post->post_title = $post_title;
801
-				        $updated_post->post_name  = $post_title;
802
-				        unset( $post_title );
803
-				        break;
804
-
805
-				    case 'post_content':
806
-				        $post_content = $value;
807
-				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
808
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
809
-				        }
810
-				        $updated_post->post_content = $post_content;
811
-				        unset( $post_content );
812
-				        break;
813
-				    case 'post_excerpt':
814
-				        $updated_post->post_excerpt = $value;
815
-				        break;
816
-				    case 'post_tags':
817
-				        wp_set_post_tags( $post_id, $value, false );
818
-				        break;
819
-				    case 'post_category':
820
-				        break;
821
-				    case 'post_custom_field':
795
+					case 'post_title':
796
+						$post_title = $value;
797
+						if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
798
+							$post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
799
+						}
800
+						$updated_post->post_title = $post_title;
801
+						$updated_post->post_name  = $post_title;
802
+						unset( $post_title );
803
+						break;
804
+
805
+					case 'post_content':
806
+						$post_content = $value;
807
+						if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
808
+							$post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
809
+						}
810
+						$updated_post->post_content = $post_content;
811
+						unset( $post_content );
812
+						break;
813
+					case 'post_excerpt':
814
+						$updated_post->post_excerpt = $value;
815
+						break;
816
+					case 'post_tags':
817
+						wp_set_post_tags( $post_id, $value, false );
818
+						break;
819
+					case 'post_category':
820
+						break;
821
+					case 'post_custom_field':
822 822
 						if ( is_array( $value ) && ( floatval( $field_id ) !== floatval( $field->id ) ) ) {
823 823
 							$value = $value[ $field_id ];
824 824
 						}
825 825
 
826
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
827
-				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
828
-				        }
826
+						if( ! empty( $field->customFieldTemplateEnabled ) ) {
827
+							$value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
828
+						}
829 829
 
830 830
 						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
831 831
 
832
-				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
833
-				        break;
832
+						update_post_meta( $post_id, $field->postCustomFieldName, $value );
833
+						break;
834 834
 
835
-				    case 'post_image':
836
-				        $value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
837
-				        break;
835
+					case 'post_image':
836
+						$value = $this->update_post_image( $form, $field, $field_id, $value, $this->entry, $post_id );
837
+						break;
838 838
 
839 839
 				}
840 840
 
@@ -991,14 +991,14 @@  discard block
 block discarded – undo
991 991
 			?><h2 class="gv-edit-entry-title">
992 992
 				<span><?php
993 993
 
994
-				    /**
995
-				     * @filter `gravityview_edit_entry_title` Modify the edit entry title
996
-				     * @param string $edit_entry_title Modify the "Edit Entry" title
997
-				     * @param GravityView_Edit_Entry_Render $this This object
998
-				     */
999
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
994
+					/**
995
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
996
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
997
+					 * @param GravityView_Edit_Entry_Render $this This object
998
+					 */
999
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
1000 1000
 
1001
-				    echo esc_attr( $edit_entry_title );
1001
+					echo esc_attr( $edit_entry_title );
1002 1002
 			?></span>
1003 1003
 			</h2>
1004 1004
 
@@ -1061,26 +1061,26 @@  discard block
 block discarded – undo
1061 1061
 
1062 1062
 				switch ( $edit_redirect ) {
1063 1063
 
1064
-                    case '0':
1065
-	                    $redirect_url = $back_link;
1066
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1067
-                        break;
1068
-
1069
-                    case '1':
1070
-	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1071
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1072
-	                    break;
1073
-
1074
-                    case '2':
1075
-	                    $redirect_url = $edit_redirect_url;
1076
-	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1077
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1078
-                        break;
1079
-
1080
-                    case '':
1081
-                    default:
1082
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1083
-                        break;
1064
+					case '0':
1065
+						$redirect_url = $back_link;
1066
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1067
+						break;
1068
+
1069
+					case '1':
1070
+						$redirect_url = $directory_link = GravityView_API::directory_link();
1071
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1072
+						break;
1073
+
1074
+					case '2':
1075
+						$redirect_url = $edit_redirect_url;
1076
+						$redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1077
+						$entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1078
+						break;
1079
+
1080
+					case '':
1081
+					default:
1082
+						$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1083
+						break;
1084 1084
 				}
1085 1085
 
1086 1086
 				if ( isset( $redirect_url ) ) {
@@ -1137,7 +1137,7 @@  discard block
 block discarded – undo
1137 1137
 
1138 1138
 		ob_get_clean();
1139 1139
 
1140
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1140
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
1141 1141
 		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1142 1142
 		remove_filter( 'gform_disable_view_counter', '__return_true' );
1143 1143
 		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
@@ -1191,7 +1191,7 @@  discard block
 block discarded – undo
1191 1191
 
1192 1192
 		// for now we don't support Save and Continue feature.
1193 1193
 		if( ! self::$supports_save_and_continue ) {
1194
-	        unset( $form['save'] );
1194
+			unset( $form['save'] );
1195 1195
 		}
1196 1196
 
1197 1197
 		$form = $this->unselect_default_values( $form );
@@ -1218,30 +1218,30 @@  discard block
 block discarded – undo
1218 1218
 			return $field_content;
1219 1219
 		}
1220 1220
 
1221
-        $message = null;
1221
+		$message = null;
1222 1222
 
1223
-        // First, make sure they have the capability to edit the post.
1224
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1223
+		// First, make sure they have the capability to edit the post.
1224
+		if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1225 1225
 
1226
-            /**
1227
-             * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1228
-             * @param string $message The existing "You don't have permission..." text
1229
-             */
1230
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1226
+			/**
1227
+			 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1228
+			 * @param string $message The existing "You don't have permission..." text
1229
+			 */
1230
+			$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1231 1231
 
1232
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1233
-            /**
1234
-             * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1235
-             * @param string $message The existing "This field is not editable; the post no longer exists." text
1236
-             */
1237
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1238
-        }
1232
+		} elseif( null === get_post( $this->entry['post_id'] ) ) {
1233
+			/**
1234
+			 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1235
+			 * @param string $message The existing "This field is not editable; the post no longer exists." text
1236
+			 */
1237
+			$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1238
+		}
1239 1239
 
1240
-        if( $message ) {
1241
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1242
-        }
1240
+		if( $message ) {
1241
+			$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1242
+		}
1243 1243
 
1244
-        return $field_content;
1244
+		return $field_content;
1245 1245
 	}
1246 1246
 
1247 1247
 	/**
@@ -1269,7 +1269,7 @@  discard block
 block discarded – undo
1269 1269
 			|| ! empty( $field_content )
1270 1270
 			|| in_array( $field->type, array( 'honeypot' ) )
1271 1271
 		) {
1272
-	        return $field_content;
1272
+			return $field_content;
1273 1273
 		}
1274 1274
 
1275 1275
 		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
@@ -1277,24 +1277,24 @@  discard block
 block discarded – undo
1277 1277
 
1278 1278
 		$field_value = $this->get_field_value( $field );
1279 1279
 
1280
-	    // Prevent any PHP warnings, like undefined index
1281
-	    ob_start();
1280
+		// Prevent any PHP warnings, like undefined index
1281
+		ob_start();
1282 1282
 
1283
-	    $return = null;
1283
+		$return = null;
1284 1284
 
1285 1285
 		/** @var GravityView_Field $gv_field */
1286 1286
 		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1287 1287
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1288 1288
 		} else {
1289
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
1290
-	    }
1289
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
1290
+		}
1291 1291
 
1292
-	    // If there was output, it's an error
1293
-	    $warnings = ob_get_clean();
1292
+		// If there was output, it's an error
1293
+		$warnings = ob_get_clean();
1294 1294
 
1295
-	    if( !empty( $warnings ) ) {
1296
-		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1297
-	    }
1295
+		if( !empty( $warnings ) ) {
1296
+			gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1297
+		}
1298 1298
 
1299 1299
 		return $return;
1300 1300
 	}
@@ -1329,8 +1329,8 @@  discard block
 block discarded – undo
1329 1329
 				$input_id = strval( $input['id'] );
1330 1330
 
1331 1331
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1332
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1333
-				    $allow_pre_populated = false;
1332
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1333
+					$allow_pre_populated = false;
1334 1334
 				}
1335 1335
 
1336 1336
 			}
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
 			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1355 1355
 				$categories = array();
1356 1356
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1357
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1357
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1358 1358
 				}
1359 1359
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1360 1360
 			}
@@ -1364,25 +1364,25 @@  discard block
 block discarded – undo
1364 1364
 		// if value is empty get the default value if defined
1365 1365
 		$field_value = $field->get_value_default_if_empty( $field_value );
1366 1366
 
1367
-	    /**
1368
-	     * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1369
-	     * @since 1.11
1370
-	     * @since 1.20 Added third param
1371
-	     * @param mixed $field_value field value used to populate the input
1372
-	     * @param object $field Gravity Forms field object ( Class GF_Field )
1373
-	     * @param GravityView_Edit_Entry_Render $this Current object
1374
-	     */
1375
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1376
-
1377
-	    /**
1378
-	     * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1379
-	     * @since 1.17
1380
-	     * @since 1.20 Added third param
1381
-	     * @param mixed $field_value field value used to populate the input
1382
-	     * @param GF_Field $field Gravity Forms field object
1383
-	     * @param GravityView_Edit_Entry_Render $this Current object
1384
-	     */
1385
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1367
+		/**
1368
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
1369
+		 * @since 1.11
1370
+		 * @since 1.20 Added third param
1371
+		 * @param mixed $field_value field value used to populate the input
1372
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
1373
+		 * @param GravityView_Edit_Entry_Render $this Current object
1374
+		 */
1375
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field, $this );
1376
+
1377
+		/**
1378
+		 * @filter `gravityview/edit_entry/field_value_{field_type}` Change the value of an Edit Entry field for a specific field type
1379
+		 * @since 1.17
1380
+		 * @since 1.20 Added third param
1381
+		 * @param mixed $field_value field value used to populate the input
1382
+		 * @param GF_Field $field Gravity Forms field object
1383
+		 * @param GravityView_Edit_Entry_Render $this Current object
1384
+		 */
1385
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1386 1386
 
1387 1387
 		return $field_value;
1388 1388
 	}
@@ -1409,7 +1409,7 @@  discard block
 block discarded – undo
1409 1409
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1410 1410
 			// expects certain field array items to be set.
1411 1411
 			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1412
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1412
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1413 1413
 			}
1414 1414
 
1415 1415
 			switch( RGFormsModel::get_input_type( $field ) ) {
@@ -1423,61 +1423,61 @@  discard block
 block discarded – undo
1423 1423
 				 */
1424 1424
 				case 'fileupload':
1425 1425
 
1426
-				    // Set the previous value
1427
-				    $entry = $this->get_entry();
1426
+					// Set the previous value
1427
+					$entry = $this->get_entry();
1428 1428
 
1429
-				    $input_name = 'input_'.$field->id;
1430
-				    $form_id = $form['id'];
1429
+					$input_name = 'input_'.$field->id;
1430
+					$form_id = $form['id'];
1431 1431
 
1432
-				    $value = NULL;
1432
+					$value = NULL;
1433 1433
 
1434
-				    // Use the previous entry value as the default.
1435
-				    if( isset( $entry[ $field->id ] ) ) {
1436
-				        $value = $entry[ $field->id ];
1437
-				    }
1434
+					// Use the previous entry value as the default.
1435
+					if( isset( $entry[ $field->id ] ) ) {
1436
+						$value = $entry[ $field->id ];
1437
+					}
1438 1438
 
1439
-				    // If this is a single upload file
1440
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1441
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1442
-				        $value = $file_path['url'];
1439
+					// If this is a single upload file
1440
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1441
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1442
+						$value = $file_path['url'];
1443 1443
 
1444
-				    } else {
1444
+					} else {
1445 1445
 
1446
-				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1447
-				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1448
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1446
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1447
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1448
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1449 1449
 
1450
-				    }
1450
+					}
1451 1451
 
1452
-				    if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1452
+					if ( \GV\Utils::get( $field, "multipleFiles" ) ) {
1453 1453
 
1454
-				        // If there are fresh uploads, process and merge them.
1455
-				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1456
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1457
-				            $value = empty( $value ) ? '[]' : $value;
1458
-				            $value = stripslashes_deep( $value );
1459
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1460
-				        }
1454
+						// If there are fresh uploads, process and merge them.
1455
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1456
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1457
+							$value = empty( $value ) ? '[]' : $value;
1458
+							$value = stripslashes_deep( $value );
1459
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1460
+						}
1461 1461
 
1462
-				    } else {
1462
+					} else {
1463 1463
 
1464
-				        // A file already exists when editing an entry
1465
-				        // We set this to solve issue when file upload fields are required.
1466
-				        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1464
+						// A file already exists when editing an entry
1465
+						// We set this to solve issue when file upload fields are required.
1466
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1467 1467
 
1468
-				    }
1468
+					}
1469 1469
 
1470
-				    $this->entry[ $input_name ] = $value;
1471
-				    $_POST[ $input_name ] = $value;
1470
+					$this->entry[ $input_name ] = $value;
1471
+					$_POST[ $input_name ] = $value;
1472 1472
 
1473
-				    break;
1473
+					break;
1474 1474
 
1475 1475
 				case 'number':
1476
-				    // Fix "undefined index" issue at line 1286 in form_display.php
1477
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1478
-				        $_POST['input_'.$field->id ] = NULL;
1479
-				    }
1480
-				    break;
1476
+					// Fix "undefined index" issue at line 1286 in form_display.php
1477
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1478
+						$_POST['input_'.$field->id ] = NULL;
1479
+					}
1480
+					break;
1481 1481
 			}
1482 1482
 
1483 1483
 		}
@@ -1562,43 +1562,43 @@  discard block
 block discarded – undo
1562 1562
 				case 'fileupload' :
1563 1563
 				case 'post_image':
1564 1564
 
1565
-				    // in case nothing is uploaded but there are already files saved
1566
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1567
-				        $field->failed_validation = false;
1568
-				        unset( $field->validation_message );
1569
-				    }
1565
+					// in case nothing is uploaded but there are already files saved
1566
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1567
+						$field->failed_validation = false;
1568
+						unset( $field->validation_message );
1569
+					}
1570 1570
 
1571
-				    // validate if multi file upload reached max number of files [maxFiles] => 2
1572
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1571
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1572
+					if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1573 1573
 
1574
-				        $input_name = 'input_' . $field->id;
1575
-				        //uploaded
1576
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1574
+						$input_name = 'input_' . $field->id;
1575
+						//uploaded
1576
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1577 1577
 
1578
-				        //existent
1579
-				        $entry = $this->get_entry();
1580
-				        $value = NULL;
1581
-				        if( isset( $entry[ $field->id ] ) ) {
1582
-				            $value = json_decode( $entry[ $field->id ], true );
1583
-				        }
1578
+						//existent
1579
+						$entry = $this->get_entry();
1580
+						$value = NULL;
1581
+						if( isset( $entry[ $field->id ] ) ) {
1582
+							$value = json_decode( $entry[ $field->id ], true );
1583
+						}
1584 1584
 
1585
-				        // count uploaded files and existent entry files
1586
-				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1587
-						               ( is_array( $value ) ? count( $value ) : 0 );
1585
+						// count uploaded files and existent entry files
1586
+						$count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1587
+									   ( is_array( $value ) ? count( $value ) : 0 );
1588 1588
 
1589
-				        if( $count_files > $field->maxFiles ) {
1590
-				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1591
-				            $field->failed_validation = 1;
1592
-				            $gv_valid = false;
1589
+						if( $count_files > $field->maxFiles ) {
1590
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1591
+							$field->failed_validation = 1;
1592
+							$gv_valid = false;
1593 1593
 
1594
-				            // in case of error make sure the newest upload files are removed from the upload input
1595
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1596
-				        }
1594
+							// in case of error make sure the newest upload files are removed from the upload input
1595
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1596
+						}
1597 1597
 
1598
-				    }
1598
+					}
1599 1599
 
1600 1600
 
1601
-				    break;
1601
+					break;
1602 1602
 
1603 1603
 			}
1604 1604
 
@@ -1609,47 +1609,47 @@  discard block
 block discarded – undo
1609 1609
 
1610 1610
 				switch ( $field_type ) {
1611 1611
 
1612
-				    // Captchas don't need to be re-entered.
1613
-				    case 'captcha':
1612
+					// Captchas don't need to be re-entered.
1613
+					case 'captcha':
1614 1614
 
1615
-				        // Post Image fields aren't editable, so we un-fail them.
1616
-				    case 'post_image':
1617
-				        $field->failed_validation = false;
1618
-				        unset( $field->validation_message );
1619
-				        break;
1615
+						// Post Image fields aren't editable, so we un-fail them.
1616
+					case 'post_image':
1617
+						$field->failed_validation = false;
1618
+						unset( $field->validation_message );
1619
+						break;
1620 1620
 
1621 1621
 				}
1622 1622
 
1623 1623
 				// You can't continue inside a switch, so we do it after.
1624 1624
 				if( empty( $field->failed_validation ) ) {
1625
-				    continue;
1625
+					continue;
1626 1626
 				}
1627 1627
 
1628 1628
 				// checks if the No Duplicates option is not validating entry against itself, since
1629 1629
 				// we're editing a stored entry, it would also assume it's a duplicate.
1630 1630
 				if( !empty( $field->noDuplicates ) ) {
1631 1631
 
1632
-				    $entry = $this->get_entry();
1632
+					$entry = $this->get_entry();
1633 1633
 
1634
-				    // If the value of the entry is the same as the stored value
1635
-				    // Then we can assume it's not a duplicate, it's the same.
1636
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1637
-				        //if value submitted was not changed, then don't validate
1638
-				        $field->failed_validation = false;
1634
+					// If the value of the entry is the same as the stored value
1635
+					// Then we can assume it's not a duplicate, it's the same.
1636
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1637
+						//if value submitted was not changed, then don't validate
1638
+						$field->failed_validation = false;
1639 1639
 
1640
-				        unset( $field->validation_message );
1640
+						unset( $field->validation_message );
1641 1641
 
1642
-				        gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1642
+						gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', array( 'data' => $entry ) );
1643 1643
 
1644
-				        continue;
1645
-				    }
1644
+						continue;
1645
+					}
1646 1646
 				}
1647 1647
 
1648 1648
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1649 1649
 				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1650
-				    unset( $field->validation_message );
1651
-	                $field->validation_message = false;
1652
-				    continue;
1650
+					unset( $field->validation_message );
1651
+					$field->validation_message = false;
1652
+					continue;
1653 1653
 				}
1654 1654
 
1655 1655
 				$gv_valid = false;
@@ -1713,8 +1713,8 @@  discard block
 block discarded – undo
1713 1713
 		// Hide fields depending on admin settings
1714 1714
 		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1715 1715
 
1716
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1717
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1716
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1717
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1718 1718
 
1719 1719
 		/**
1720 1720
 		 * @filter `gravityview/edit_entry/form_fields` Modify the fields displayed in Edit Entry form
@@ -1774,11 +1774,11 @@  discard block
 block discarded – undo
1774 1774
 		// The edit tab has been configured, so we loop through to configured settings
1775 1775
 		foreach ( $configured_fields as $configured_field ) {
1776 1776
 
1777
-	        /** @var GF_Field $field */
1778
-	        foreach ( $fields as $field ) {
1777
+			/** @var GF_Field $field */
1778
+			foreach ( $fields as $field ) {
1779 1779
 				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1780
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1781
-				    break;
1780
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1781
+					break;
1782 1782
 				}
1783 1783
 
1784 1784
 			}
@@ -1834,28 +1834,28 @@  discard block
 block discarded – undo
1834 1834
 	 */
1835 1835
 	private function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1836 1836
 
1837
-	    /**
1837
+		/**
1838 1838
 		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1839
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1840
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1841
-	     * @since 1.9.1
1842
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1843
-	     * @param array $form GF Form array
1844
-	     * @param int $view_id View ID
1845
-	     */
1846
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1847
-
1848
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1839
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1840
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1841
+		 * @since 1.9.1
1842
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1843
+		 * @param array $form GF Form array
1844
+		 * @param int $view_id View ID
1845
+		 */
1846
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1847
+
1848
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1849 1849
 			foreach( $fields as $k => $field ) {
1850 1850
 				if( $field->adminOnly ) {
1851
-				    unset( $fields[ $k ] );
1851
+					unset( $fields[ $k ] );
1852 1852
 				}
1853 1853
 			}
1854 1854
 			return array_values( $fields );
1855 1855
 		}
1856 1856
 
1857
-	    foreach( $fields as &$field ) {
1858
-		    $field->adminOnly = false;
1857
+		foreach( $fields as &$field ) {
1858
+			$field->adminOnly = false;
1859 1859
 		}
1860 1860
 
1861 1861
 		return $fields;
@@ -1875,13 +1875,13 @@  discard block
 block discarded – undo
1875 1875
 	 */
1876 1876
 	private function unselect_default_values( $form ) {
1877 1877
 
1878
-	    foreach ( $form['fields'] as &$field ) {
1878
+		foreach ( $form['fields'] as &$field ) {
1879 1879
 
1880 1880
 			if ( empty( $field->choices ) ) {
1881
-                continue;
1881
+				continue;
1882 1882
 			}
1883 1883
 
1884
-            foreach ( $field->choices as &$choice ) {
1884
+			foreach ( $field->choices as &$choice ) {
1885 1885
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
1886 1886
 					$choice['isSelected'] = false;
1887 1887
 				}
@@ -1918,36 +1918,36 @@  discard block
 block discarded – undo
1918 1918
 
1919 1919
 			if( 'checkbox' === $field->type ) {
1920 1920
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
1921
-				    $input_id = $input['id'];
1922
-				    $choice = $field->choices[ $key ];
1923
-				    $value = \GV\Utils::get( $this->entry, $input_id );
1924
-				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
1925
-				    if( $match ) {
1926
-				        $field->choices[ $key ]['isSelected'] = true;
1927
-				    }
1921
+					$input_id = $input['id'];
1922
+					$choice = $field->choices[ $key ];
1923
+					$value = \GV\Utils::get( $this->entry, $input_id );
1924
+					$match = RGFormsModel::choice_value_match( $field, $choice, $value );
1925
+					if( $match ) {
1926
+						$field->choices[ $key ]['isSelected'] = true;
1927
+					}
1928 1928
 				}
1929 1929
 			} else {
1930 1930
 
1931 1931
 				// We need to run through each field to set the default values
1932 1932
 				foreach ( $this->entry as $field_id => $field_value ) {
1933 1933
 
1934
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
1934
+					if( floatval( $field_id ) === floatval( $field->id ) ) {
1935 1935
 
1936
-				        if( 'list' === $field->type ) {
1937
-				            $list_rows = maybe_unserialize( $field_value );
1936
+						if( 'list' === $field->type ) {
1937
+							$list_rows = maybe_unserialize( $field_value );
1938 1938
 
1939
-				            $list_field_value = array();
1940
-				            foreach ( (array) $list_rows as $row ) {
1941
-				                foreach ( (array) $row as $column ) {
1942
-				                    $list_field_value[] = $column;
1943
-				                }
1944
-				            }
1939
+							$list_field_value = array();
1940
+							foreach ( (array) $list_rows as $row ) {
1941
+								foreach ( (array) $row as $column ) {
1942
+									$list_field_value[] = $column;
1943
+								}
1944
+							}
1945 1945
 
1946
-				            $field->defaultValue = serialize( $list_field_value );
1947
-				        } else {
1948
-				            $field->defaultValue = $field_value;
1949
-				        }
1950
-				    }
1946
+							$field->defaultValue = serialize( $list_field_value );
1947
+						} else {
1948
+							$field->defaultValue = $field_value;
1949
+						}
1950
+					}
1951 1951
 				}
1952 1952
 			}
1953 1953
 		}
@@ -2004,7 +2004,7 @@  discard block
 block discarded – undo
2004 2004
 			return $has_conditional_logic;
2005 2005
 		}
2006 2006
 
2007
-	    /** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2007
+		/** @see GravityView_Edit_Entry_Render::filter_conditional_logic for filter documentation */
2008 2008
 		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
2009 2009
 	}
2010 2010
 
@@ -2071,14 +2071,14 @@  discard block
 block discarded – undo
2071 2071
 
2072 2072
 		if( $echo && $error !== true ) {
2073 2073
 
2074
-	        $error = esc_html( $error );
2074
+			$error = esc_html( $error );
2075 2075
 
2076
-	        /**
2077
-	         * @since 1.9
2078
-	         */
2079
-	        if ( ! empty( $this->entry ) ) {
2080
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2081
-	        }
2076
+			/**
2077
+			 * @since 1.9
2078
+			 */
2079
+			if ( ! empty( $this->entry ) ) {
2080
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2081
+			}
2082 2082
 
2083 2083
 			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2084 2084
 		}
Please login to merge, or discard this patch.
future/includes/class-gv-template-view-table.php 1 patch
Indentation   +88 added lines, -88 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 
20 20
 
21 21
 	/**
22
-     * Constructor. Add filters to modify output.
23
-     *
22
+	 * Constructor. Add filters to modify output.
23
+	 *
24 24
 	 * @since 2.0.4
25 25
 	 *
26 26
 	 * @param View $view
@@ -29,19 +29,19 @@  discard block
 block discarded – undo
29 29
 	 */
30 30
 	public function __construct( View $view, Entry_Collection $entries, Request $request ) {
31 31
 
32
-	    add_filter( 'gravityview/template/field/label', array( __CLASS__, 'add_columns_sort_links' ), 100, 2 );
32
+		add_filter( 'gravityview/template/field/label', array( __CLASS__, 'add_columns_sort_links' ), 100, 2 );
33 33
 
34 34
 		parent::__construct( $view, $entries, $request );
35 35
 	}
36 36
 
37 37
 	/**
38
-     * Add sorting links to HTML columns that support sorting
39
-     *
40
-     * @since 2.0.4
41
-     * @since 2.0.5 Made static
42
-     *
43
-     * @static
44
-     *
38
+	 * Add sorting links to HTML columns that support sorting
39
+	 *
40
+	 * @since 2.0.4
41
+	 * @since 2.0.5 Made static
42
+	 *
43
+	 * @static
44
+	 *
45 45
 	 * @param string $column_label Label for the table column
46 46
 	 * @param \GV\Template_Context $context
47 47
 	 *
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		$sort_columns = $context->view->settings->get( 'sort_columns' );
53 53
 
54 54
 		if ( empty( $sort_columns ) ) {
55
-            return $column_label;
55
+			return $column_label;
56 56
 		}
57 57
 
58 58
 		if ( ! \GravityView_frontend::getInstance()->is_field_sortable( $context->field->ID, $context->view->form->form ) ) {
@@ -102,22 +102,22 @@  discard block
 block discarded – undo
102 102
 		// If we are already sorting by the current field...
103 103
 		if ( ! empty( $sorting['key'] ) && (string) $sort_field_id === (string) $sorting['key'] ) {
104 104
 
105
-		    switch( $sorting['direction'] ) {
106
-		        // No sort
107
-                case '':
108
-	                $sort_args[1] = 'asc';
109
-	                $class .= ' gv-icon-caret-up-down';
110
-                    break;
111
-                case 'desc':
112
-	                $sort_args[1] = '';
113
-	                $class .= ' gv-icon-sort-asc';
114
-	                break;
115
-                case 'asc':
116
-                default:
117
-                    $sort_args[1] = 'desc';
118
-                    $class .= ' gv-icon-sort-desc';
119
-                    break;
120
-            }
105
+			switch( $sorting['direction'] ) {
106
+				// No sort
107
+				case '':
108
+					$sort_args[1] = 'asc';
109
+					$class .= ' gv-icon-caret-up-down';
110
+					break;
111
+				case 'desc':
112
+					$sort_args[1] = '';
113
+					$class .= ' gv-icon-sort-asc';
114
+					break;
115
+				case 'asc':
116
+				default:
117
+					$sort_args[1] = 'desc';
118
+					$class .= ' gv-icon-sort-desc';
119
+					break;
120
+			}
121 121
 
122 122
 		} else {
123 123
 			$class .= ' gv-icon-caret-up-down';
@@ -127,56 +127,56 @@  discard block
 block discarded – undo
127 127
 		$url = remove_query_arg( 'sort', $url );
128 128
 		$multisort_url = self::_get_multisort_url( $url, $sort_args, $context->field->ID );
129 129
 
130
-    	$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
130
+		$url = add_query_arg( $sort_args[0], $sort_args[1], $url );
131 131
 
132 132
 		return '<a href="'. esc_url_raw( $url ) .'" data-multisort-href="'. esc_url_raw( $multisort_url ) . '" class="'. $class .'" ></a>&nbsp;'. $column_label;
133 133
 	}
134 134
 
135 135
 	/**
136
-     * Get the multi-sort URL used in the sorting links
137
-     *
138
-     * @todo Consider moving to Utils?
139
-     *
140
-     * @since 2.3
141
-     *
142
-     * @see add_columns_sort_links
136
+	 * Get the multi-sort URL used in the sorting links
137
+	 *
138
+	 * @todo Consider moving to Utils?
139
+	 *
140
+	 * @since 2.3
141
+	 *
142
+	 * @see add_columns_sort_links
143 143
 	 * @param string $url Single-sort URL
144 144
 	 * @param array $sort_args Single sorting for rules, in [ field_id, dir ] format
145
-     * @param string|int $field_id ID of the current field being displayed
146
-     *
147
-     * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url
145
+	 * @param string|int $field_id ID of the current field being displayed
146
+	 *
147
+	 * @return string Multisort URL, if there are multiple sorts. Otherwise, existing $url
148 148
 	 */
149 149
 	static public function _get_multisort_url( $url, $sort_args, $field_id ) {
150 150
 
151 151
 		$sorts = Utils::_GET( 'sort' );
152 152
 
153 153
 		if ( ! is_array( $sorts ) ) {
154
-            return $url;
154
+			return $url;
155 155
 		}
156 156
 
157
-        $multisort_url = $url;
157
+		$multisort_url = $url;
158 158
 
159 159
 		// If the field has already been sorted by, add the field to the URL
160
-        if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
161
-            if ( count( $keys ) ) {
162
-                $multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
163
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
164
-            } else {
165
-                $multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
166
-            }
167
-        }
168
-        // Otherwise, we are just updating the sort order
169
-        else {
170
-
171
-            // Pass empty value to unset
172
-            if( '' === $sort_args[1] ) {
173
-	            unset( $sorts[ $field_id ] );
174
-            } else {
175
-	            $sorts[ $field_id ] = $sort_args[1];
176
-            }
177
-
178
-            $multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
179
-        }
160
+		if ( ! in_array( $field_id, $keys = array_keys( $sorts ) ) ) {
161
+			if ( count( $keys ) ) {
162
+				$multisort_url = add_query_arg( sprintf( 'sort[%s]', end( $keys ) ), $sorts[ end( $keys ) ], $multisort_url );
163
+				$multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
164
+			} else {
165
+				$multisort_url = add_query_arg( $sort_args[0], $sort_args[1], $multisort_url );
166
+			}
167
+		}
168
+		// Otherwise, we are just updating the sort order
169
+		else {
170
+
171
+			// Pass empty value to unset
172
+			if( '' === $sort_args[1] ) {
173
+				unset( $sorts[ $field_id ] );
174
+			} else {
175
+				$sorts[ $field_id ] = $sort_args[1];
176
+			}
177
+
178
+			$multisort_url = add_query_arg( array( 'sort' => $sorts ), $multisort_url );
179
+		}
180 180
 
181 181
 		return $multisort_url;
182 182
 	}
@@ -206,10 +206,10 @@  discard block
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-     * Returns the label for a column, with support for all deprecated filters
210
-     *
211
-     * @since 2.1
212
-     *
209
+	 * Returns the label for a column, with support for all deprecated filters
210
+	 *
211
+	 * @since 2.1
212
+	 *
213 213
 	 * @param \GV\Field $field
214 214
 	 * @param \GV\Template_Context $context
215 215
 	 */
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 		$column_label = apply_filters( 'gravityview/template/field/label', $column_label, $context );
233 233
 
234 234
 		return $column_label;
235
-    }
235
+	}
236 236
 
237 237
 	/**
238 238
 	 * Output the entry row.
@@ -301,15 +301,15 @@  discard block
 block discarded – undo
301 301
 				 */
302 302
 				do_action( 'gravityview/template/table/cells/before', $context );
303 303
 
304
-                /**
305
-                 * @action `gravityview_table_cells_before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
306
-                 * @since 1.0.7
304
+				/**
305
+				 * @action `gravityview_table_cells_before` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
306
+				 * @since 1.0.7
307 307
 				 * @param \GravityView_View $this Current GravityView_View object
308 308
 				 * @deprecated Use `gravityview/template/table/cells/before`
309
-                 */
310
-                do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
309
+				 */
310
+				do_action( 'gravityview_table_cells_before', \GravityView_View::getInstance() );
311 311
 
312
-                foreach ( $fields->all() as $field ) {
312
+				foreach ( $fields->all() as $field ) {
313 313
 					if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) {
314 314
 						if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) {
315 315
 							$field = $this->view->unions[ $entry['form_id'] ][ $field->ID ];
@@ -329,13 +329,13 @@  discard block
 block discarded – undo
329 329
 				 */
330 330
 				do_action( 'gravityview/template/table/cells/after', $context );
331 331
 
332
-                /**
333
-                 * @action `gravityview_table_cells_after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
334
-                 * @since 1.0.7
332
+				/**
333
+				 * @action `gravityview_table_cells_after` Inside the `tr` while rendering each entry in the loop. Can be used to insert additional table cells.
334
+				 * @since 1.0.7
335 335
 				 * @param \GravityView_View $this Current GravityView_View object
336 336
 				 * @deprecated Use `gravityview/template/table/cells/after`
337
-                 */
338
-                do_action( 'gravityview_table_cells_after', \GravityView_View::getInstance() );
337
+				 */
338
+				do_action( 'gravityview_table_cells_after', \GravityView_View::getInstance() );
339 339
 
340 340
 				?>
341 341
 			</tr>
@@ -376,9 +376,9 @@  discard block
 block discarded – undo
376 376
 			'value' => $value,
377 377
 			'hide_empty' => false,
378 378
 			'zone_id' => 'directory_table-columns',
379
-            'label' => self::get_field_column_label( $field, $context ),
379
+			'label' => self::get_field_column_label( $field, $context ),
380 380
 			'markup' => '<td id="{{ field_id }}" class="{{ class }}" data-label="{{label_value:data-label}}">{{ value }}</td>',
381
-            'form' => $form,
381
+			'form' => $form,
382 382
 		);
383 383
 
384 384
 		/** Output. */
@@ -403,11 +403,11 @@  discard block
 block discarded – undo
403 403
 		do_action( 'gravityview/template/table/body/before', $context );
404 404
 
405 405
 		/**
406
-		* @action `gravityview_table_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
407
-		* @deprecated Use `gravityview/template/table/body/before`
408
-		* @since 1.0.7
409
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
410
-		*/
406
+		 * @action `gravityview_table_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
407
+		 * @deprecated Use `gravityview/template/table/body/before`
408
+		 * @since 1.0.7
409
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
410
+		 */
411 411
 		do_action( 'gravityview_table_body_before', \GravityView_View::getInstance() /** ugh! */ );
412 412
 	}
413 413
 
@@ -429,11 +429,11 @@  discard block
 block discarded – undo
429 429
 		do_action( 'gravityview/template/table/body/after', $context );
430 430
 
431 431
 		/**
432
-		* @action `gravityview_table_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
433
-		* @deprecated Use `gravityview/template/table/body/after`
434
-		* @since 1.0.7
435
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
436
-		*/
432
+		 * @action `gravityview_table_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
433
+		 * @deprecated Use `gravityview/template/table/body/after`
434
+		 * @since 1.0.7
435
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
436
+		 */
437 437
 		do_action( 'gravityview_table_body_after', \GravityView_View::getInstance() /** ugh! */ );
438 438
 	}
439 439
 
Please login to merge, or discard this patch.