Issues in class-gv-request-frontend.php - New Issues - Inspection of "Merge pull request #833 from gravityview/future" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 507546...65eb42 )

by Zack

created 2017-02-01 19:45 UTC

future/includes/class-gv-request-frontend.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GV;

/** If this file is called directly, abort. */
if ( ! defined( 'GRAVITYVIEW_DIR' ) )
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
	die();

/**
 * The default Request class.
 *
 * Parses and transforms an end-request for a view to a View
 *  in a default frontend, WP_Query-based WordPress context.
 */
final class Frontend_Request extends Request {
	/**
	 * Bootstrap.
	 *
	 * @return void

	 */
	public function __construct() {
		add_action( 'wp', array( $this, 'parse' ) );
	}

	/**
	 * Parse the current WordPress context around the $post global.
	 *
	 * Called by the `wp` hook.
	 *
	 * @param \WP $wp The WordPress environment class. Unused.
	 *
	 * @internal
	 * @return void
	 */
	public function parse( $wp = null ) {

		/** Nothing to do in an administrative context. */
		if ( $this->is_admin() ) {
			return;
		}

		/** The post might either be a gravityview, or contain gravityview shortcodes. */
		global $post;
function myFunction($a, $b) {
    // Do something
}

		if ( ! $post instanceof \WP_Post ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
			$this->views = new View_Collection();
		} else {
			$this->views = View_Collection::from_post( $post );
		}
	}

	/**
	 * Check if WordPress is_admin(), and make sure not DOING_AJAX.
	 *
	 * @todo load-(scripts|styles).php return true for \is_admin()!
	 *
	 * @api
	 * @since future
	 *
	 * @return bool Pure is_admin or not?
	 */
	public function is_admin() {
		$doing_ajax = defined( 'DOING_AJAX' ) ? DOING_AJAX : false;
		return is_admin() && ! $doing_ajax;
	}
}


Push — develop ( 507546...65eb42 )

future/includes/class-gv-request-frontend.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-01 19:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 14 and the first side effect is on line 5. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			namespace GV;
3
4			/** If this file is called directly, abort. */
5			if ( ! defined( 'GRAVITYVIEW_DIR' ) )
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-29 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
6			die();
7
8			/**
9			* The default Request class.
10			*
11			* Parses and transforms an end-request for a view to a View
12			* in a default frontend, WP_Query-based WordPress context.
13			*/
14			final class Frontend_Request extends Request {
15			/**
16			* Bootstrap.
17			*
18			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-01-29 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
19			*/
20			public function __construct() {
21			add_action( 'wp', array( $this, 'parse' ) );
22			}
23
24			/**
25			* Parse the current WordPress context around the $post global.
26			*
27			* Called by the `wp` hook.
28			*
29			* @param \WP $wp The WordPress environment class. Unused.
30			*
31			* @internal
32			* @return void
33			*/
34			public function parse( $wp = null ) {
			0 ignored issues – show Unused Code introduced 2017-01-29 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$wp` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
35			/** Nothing to do in an administrative context. */
36			if ( $this->is_admin() ) {
37			return;
38			}
39
40			/** The post might either be a gravityview, or contain gravityview shortcodes. */
41			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2017-01-29 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
42
43			if ( ! $post instanceof \WP_Post ) {
			0 ignored issues – show Bug introduced 2017-01-29 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `WP_Post` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
44			$this->views = new View_Collection();
45			} else {
46			$this->views = View_Collection::from_post( $post );
47			}
48			}
49
50			/**
51			* Check if WordPress is_admin(), and make sure not DOING_AJAX.
52			*
53			* @todo load-(scripts\|styles).php return true for \is_admin()!
54			*
55			* @api
56			* @since future
57			*
58			* @return bool Pure is_admin or not?
59			*/
60			public function is_admin() {
61			$doing_ajax = defined( 'DOING_AJAX' ) ? DOING_AJAX : false;
62			return is_admin() && ! $doing_ajax;
63			}
64			}
65

gravityview / GravityView

Push — develop ( 507546...65eb42 )

future/includes/class-gv-request-frontend.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like