Completed
Pull Request — develop (#1492)
by Zack
28:58 queued 09:00
created
includes/class-gravityview-migrate.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 			$table_name = GFFormsModel::get_lead_meta_table_name();
67 67
 		}
68 68
 
69
-		$sql = "UPDATE {$table_name} SET `meta_value` = %s WHERE `meta_key` = 'is_approved' AND `meta_value` = %s";
69
+		$sql = "update {$table_name} SET `meta_value` = %s WHERE `meta_key` = 'is_approved' AND `meta_value` = %s";
70 70
 
71 71
 		$approved_result = $wpdb->query( $wpdb->prepare( $sql, GravityView_Entry_Approval_Status::APPROVED, 'Approved' ) );
72 72
 
Please login to merge, or discard this patch.
includes/class-api.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -526,7 +526,7 @@
 block discarded – undo
526 526
 					$column = 'lead_id';
527 527
 				}
528 528
 
529
-				$results = $wpdb->get_results( $wpdb->prepare( "SELECT $column, meta_value FROM $table WHERE form_id = (SELECT form_id FROM $table WHERE $column = %d LIMIT 1) AND meta_key = 'gravityview_unique_id'", $id_or_string ) );
529
+				$results = $wpdb->get_results( $wpdb->prepare( "select $column, meta_value FROM $table WHERE form_id = (SELECT form_id FROM $table WHERE $column = %d LIMIT 1) AND meta_key = 'gravityview_unique_id'", $id_or_string ) );
530 530
 
531 531
 				if ( $results ) {
532 532
 					$cache = array_replace( $cache, array_combine( wp_list_pluck( $results, $column ), wp_list_pluck( $results, 'meta_value' ) ) );
Please login to merge, or discard this patch.
includes/class-gravityview-entry-approval.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -326,6 +326,6 @@
 block discarded – undo
326 326
 <a href="#" data-approved="{$choices['approved']['value']}" aria-role="button"  aria-live="polite" class="gv-approval-toggle gv-approval-approved popover" title="{$choices['approved']['action']}"><span class="screen-reader-text">{$choices['approved']['action']}</span></a>
327 327
 <a href="#" data-approved="{$choices['disapproved']['value']}" aria-role="button"  aria-live="polite" class="gv-approval-toggle gv-approval-disapproved popover" title="{$choices['disapproved']['action']}"><span class="screen-reader-text">{$choices['disapproved']['action']}</span></a>
328 328
 <a href="#" data-approved="{$choices['unapproved']['value']}" aria-role="button"  aria-live="polite" class="gv-approval-toggle gv-approval-unapproved popover" title="{$choices['unapproved']['action']}"><span class="screen-reader-text">{$choices['unapproved']['action']}</span></a>
329
-TEMPLATE;
329
+template;
330 330
 	}
331 331
 }
Please login to merge, or discard this patch.
future/includes/class-gv-settings-addon.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -421,7 +421,7 @@
 block discarded – undo
421 421
     </header>
422 422
     <div class="gform-settings-panel__content" style="padding: 0 1rem 1.25rem">
423 423
 
424
-HTML;
424
+html;
425 425
 		} else {
426 426
 			echo '<div class="gv-uninstall-form-wrapper" style="font-size: 110%; padding: 15px 0;">';
427 427
 		}
Please login to merge, or discard this patch.
vendor/squizlabs/php_codesniffer/tests/Core/File/FindEndOfStatementTest.inc 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
 
13 13
 /* testHeredocFunctionArg */
14 14
 myFunction(<<<END
15
-Foo
16
-END
15
+foo
16
+end
17 17
 , 'bar');
18 18
 
19 19
 /* testSwitch */
Please login to merge, or discard this patch.
vendor/squizlabs/php_codesniffer/scripts/build-phar.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 ];
28 28
 
29 29
 foreach ($scripts as $script) {
30
-    echo "Building $script phar".PHP_EOL;
30
+    echo "building $script phar".PHP_EOL;
31 31
 
32 32
     $pharName = $script.'.phar';
33 33
     $pharFile = getcwd().'/'.$pharName;
Please login to merge, or discard this patch.
vendor/squizlabs/php_codesniffer/src/Ruleset.php 1 patch
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
         // one last time and clear the output buffer.
249 249
         $sniffs[] = '';
250 250
 
251
-        echo PHP_EOL."The $this->name standard contains $sniffCount sniffs".PHP_EOL;
251
+        echo PHP_EOL."the $this->name standard contains $sniffCount sniffs".PHP_EOL;
252 252
 
253 253
         ob_start();
254 254
 
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
         libxml_use_internal_errors(true);
318 318
         $ruleset = simplexml_load_string(file_get_contents($rulesetPath));
319 319
         if ($ruleset === false) {
320
-            $errorMsg = "Ruleset $rulesetPath is not valid".PHP_EOL;
320
+            $errorMsg = "ruleset $rulesetPath is not valid".PHP_EOL;
321 321
             $errors   = libxml_get_errors();
322 322
             foreach ($errors as $error) {
323 323
                 $errorMsg .= '- On line '.$error->line.', column '.$error->column.': '.$error->message;
@@ -1171,7 +1171,7 @@  discard block
 block discarded – undo
1171 1171
             $listeners[$className] = $className;
1172 1172
 
1173 1173
             if (PHP_CODESNIFFER_VERBOSITY > 2) {
1174
-                echo "Registered $className".PHP_EOL;
1174
+                echo "registered $className".PHP_EOL;
1175 1175
             }
1176 1176
         }//end foreach
1177 1177
 
@@ -1217,7 +1217,7 @@  discard block
 block discarded – undo
1217 1217
 
1218 1218
             $tokens = $this->sniffs[$sniffClass]->register();
1219 1219
             if (is_array($tokens) === false) {
1220
-                $msg = "Sniff $sniffClass register() method must return an array";
1220
+                $msg = "sniff $sniffClass register() method must return an array";
1221 1221
                 throw new RuntimeException($msg);
1222 1222
             }
1223 1223
 
Please login to merge, or discard this patch.
src/Standards/Generic/Tests/Formatting/SpaceAfterNotUnitTest.inc 1 patch
Upper-Lower-Casing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if (! $someVar || ! $x instanceOf stdClass) {}
3
-if (!$someVar || !$x instanceOf stdClass) {}
4
-if (!     $someVar || !   $x instanceOf stdClass) {}
2
+if (! $someVar || ! $x instanceof stdClass) {}
3
+if (!$someVar || !$x instanceof stdClass) {}
4
+if (!     $someVar || !   $x instanceof stdClass) {}
5 5
 if (!foo() && (!$x || true)) {}
6 6
 $var = !($x || $y);
7 7
 $var = !           ($x || $y);
@@ -34,9 +34,9 @@  discard block
 block discarded – undo
34 34
 // phpcs:set Generic.Formatting.SpaceAfterNot ignoreNewlines false
35 35
 
36 36
 // phpcs:set Generic.Formatting.SpaceAfterNot spacing 2
37
-if (!  $someVar || !  $x instanceOf stdClass) {}
38
-if (!$someVar || !$x instanceOf stdClass) {}
39
-if (! $someVar || !       $x instanceOf stdClass) {}
37
+if (!  $someVar || !  $x instanceof stdClass) {}
38
+if (!$someVar || !$x instanceof stdClass) {}
39
+if (! $someVar || !       $x instanceof stdClass) {}
40 40
 if (!foo() && (!  $x || true)) {}
41 41
 $var = ! ($x || $y);
42 42
 $var = !           ($x || $y);
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 }
53 53
 
54 54
 // phpcs:set Generic.Formatting.SpaceAfterNot spacing 0
55
-if (!$someVar || !$x instanceOf stdClass) {}
56
-if (! $someVar || !    $x instanceOf stdClass) {}
55
+if (!$someVar || !$x instanceof stdClass) {}
56
+if (! $someVar || !    $x instanceof stdClass) {}
57 57
 if (!   foo() && (!$x || true)) {}
58 58
 $var = ! ($x || $y);
59 59
 $var = ! /*comment*/ ($x || $y);
Please login to merge, or discard this patch.
php_codesniffer/src/Standards/Generic/Tests/PHP/LowerCaseTypeUnitTest.inc 1 patch
Upper-Lower-Casing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -18,12 +18,12 @@  discard block
 block discarded – undo
18 18
 $foo = (Array) $bar;
19 19
 
20 20
 function foo(int $a, string $b, bool $c, array $d, Foo\Bar $e) : int {}
21
-function foo(Int $a, String $b, BOOL $c, Array $d, Foo\Bar $e) : Foo\Bar {}
22
-function foo(Int $a, Bar $b, BOOL $c, Array $d, Foo\Bar $e) : Bar {}
23
-function foo(callable $a, Callable $b, self $c, Iterable $d, iterable $e) : Float {}
21
+function foo(Int $a, String $b, BOOL $c, array $d, Foo\Bar $e) : Foo\Bar {}
22
+function foo(Int $a, Bar $b, BOOL $c, array $d, Foo\Bar $e) : Bar {}
23
+function foo(callable $a, callable $b, self $c, Iterable $d, iterable $e) : Float {}
24 24
 
25 25
 $foo = function (int $a, Bool $b) {};
26
-$foo = function (int $a, Callable $b) :INT{};
26
+$foo = function (int $a, callable $b) :INT{};
27 27
 $foo = function (BOOL $a, float $b) use ($foo) : INT {};
28 28
 $foo = function (Foo $a, Foo\Bar $b) use ($foo) : \Foo\Bar {};
29 29
 $foo = function (bool $a, callable $b) use ($foo) : Bar {};
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     ?Foo\Bar $e
41 41
 ) : ?Foo\Bar {}
42 42
 
43
-$foo = function (?Int $a, ?    Callable $b)
43
+$foo = function (?Int $a, ?    callable $b)
44 44
     :?INT{};
45 45
 
46 46
 $var = (BInARY) $string;
Please login to merge, or discard this patch.