Inspection of "Refresh admin styles" - gravityview/GravityView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1492)

by Zack

created 2021-02-17 13:53 UTC

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -17,8 +17,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class AssignmentInConditionSniff implements Sniff
-{
+class AssignmentInConditionSniff implements Sniff {
 
 
     /**
@@ -43,8 +42,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         $this->assignmentTokens = Tokens::$assignmentTokens;
         unset($this->assignmentTokens[T_DOUBLE_ARROW]);
 
@@ -75,8 +73,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -20,8 +20,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class UnusedFunctionParameterSniff implements Sniff
-{
+class UnusedFunctionParameterSniff implements Sniff {
 
 
     /**
@@ -29,8 +28,7 @@  discard block
 block discarded – undo
      *
      * @return array
      */
-    public function register()
-    {
+    public function register() {
         return [
             T_FUNCTION,
             T_CLOSURE,
@@ -48,8 +46,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/ForLoopShouldBeWhileLoopSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -26,8 +26,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class ForLoopShouldBeWhileLoopSniff implements Sniff
-{
+class ForLoopShouldBeWhileLoopSniff implements Sniff {
 
 
     /**
@@ -35,8 +34,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [T_FOR];
 
     }//end register()
@@ -51,8 +49,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/UselessOverridingMethodSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -25,8 +25,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class UselessOverridingMethodSniff implements Sniff
-{
+class UselessOverridingMethodSniff implements Sniff {
 
 
     /**
@@ -34,8 +33,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [T_FUNCTION];
 
     }//end register()
@@ -50,8 +48,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/EmptyStatementSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -27,8 +27,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class EmptyStatementSniff implements Sniff
-{
+class EmptyStatementSniff implements Sniff {
 
 
     /**
@@ -36,8 +35,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [
             T_TRY,
             T_CATCH,
@@ -64,8 +62,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -26,8 +26,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class UnnecessaryFinalModifierSniff implements Sniff
-{
+class UnnecessaryFinalModifierSniff implements Sniff {
 
 
     /**
@@ -35,8 +34,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [T_CLASS];
 
     }//end register()
@@ -51,8 +49,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

Standards/Generic/Sniffs/CodeAnalysis/ForLoopWithTestFunctionCallSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -30,8 +30,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class ForLoopWithTestFunctionCallSniff implements Sniff
-{
+class ForLoopWithTestFunctionCallSniff implements Sniff {
 
 
     /**
@@ -39,8 +38,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [T_FOR];
 
     }//end register()
@@ -55,8 +53,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
         $token  = $tokens[$stackPtr];
 

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/CodeAnalysis/EmptyPHPStatementSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -16,8 +16,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
 
-class EmptyPHPStatementSniff implements Sniff
-{
+class EmptyPHPStatementSniff implements Sniff {
 
 
     /**
@@ -25,8 +24,7 @@  discard block
 block discarded – undo
      *
      * @return int[]
      */
-    public function register()
-    {
+    public function register() {
         return [
             T_SEMICOLON,
             T_CLOSE_TAG,
@@ -44,8 +42,7 @@  discard block
 block discarded – undo
      *
      * @return void
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $tokens = $phpcsFile->getTokens();
 
         switch ($tokens[$stackPtr]['type']) {

Please login to merge, or discard this patch.

src/Standards/Generic/Sniffs/Files/LowercasedFilenameSniff.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -12,8 +12,7 @@  discard block
 block discarded – undo
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
 
-class LowercasedFilenameSniff implements Sniff
-{
+class LowercasedFilenameSniff implements Sniff {
 
 
     /**
@@ -21,8 +20,7 @@  discard block
 block discarded – undo
      *
      * @return array
      */
-    public function register()
-    {
+    public function register() {
         return [T_OPEN_TAG];
 
     }//end register()
@@ -37,8 +35,7 @@  discard block
 block discarded – undo
      *
      * @return int
      */
-    public function process(File $phpcsFile, $stackPtr)
-    {
+    public function process(File $phpcsFile, $stackPtr) {
         $filename = $phpcsFile->getFilename();
         if ($filename === 'STDIN') {
             return;

Please login to merge, or discard this patch.

		@@ -17,8 +17,7 @@ discard block
		block discarded – undo
17	17	use PHP_CodeSniffer\Files\File;
18	18	use PHP_CodeSniffer\Util\Tokens;
19	19
20		-class AssignmentInConditionSniff implements Sniff
21		-{
	20	+class AssignmentInConditionSniff implements Sniff {
22	21
23	22
24	23	/**
		@@ -43,8 +42,7 @@ discard block
		block discarded – undo
43	42	*
44	43	* @return int[]
45	44	*/
46		- public function register()
47		- {
	45	+ public function register() {
48	46	$this->assignmentTokens = Tokens::$assignmentTokens;
49	47	unset($this->assignmentTokens[T_DOUBLE_ARROW]);
50	48
		@@ -75,8 +73,7 @@ discard block
		block discarded – undo
75	73	*
76	74	* @return void
77	75	*/
78		- public function process(File $phpcsFile, $stackPtr)
79		- {
	76	+ public function process(File $phpcsFile, $stackPtr) {
80	77	$tokens = $phpcsFile->getTokens();
81	78	$token = $tokens[$stackPtr];
82	79

		@@ -20,8 +20,7 @@ discard block
		block discarded – undo
20	20	use PHP_CodeSniffer\Files\File;
21	21	use PHP_CodeSniffer\Util\Tokens;
22	22
23		-class UnusedFunctionParameterSniff implements Sniff
24		-{
	23	+class UnusedFunctionParameterSniff implements Sniff {
25	24
26	25
27	26	/**
		@@ -29,8 +28,7 @@ discard block
		block discarded – undo
29	28	*
30	29	* @return array
31	30	*/
32		- public function register()
33		- {
	31	+ public function register() {
34	32	return [
35	33	T_FUNCTION,
36	34	T_CLOSURE,
		@@ -48,8 +46,7 @@ discard block
		block discarded – undo
48	46	*
49	47	* @return void
50	48	*/
51		- public function process(File $phpcsFile, $stackPtr)
52		- {
	49	+ public function process(File $phpcsFile, $stackPtr) {
53	50	$tokens = $phpcsFile->getTokens();
54	51	$token = $tokens[$stackPtr];
55	52

		@@ -26,8 +26,7 @@ discard block
		block discarded – undo
26	26	use PHP_CodeSniffer\Files\File;
27	27	use PHP_CodeSniffer\Util\Tokens;
28	28
29		-class ForLoopShouldBeWhileLoopSniff implements Sniff
30		-{
	29	+class ForLoopShouldBeWhileLoopSniff implements Sniff {
31	30
32	31
33	32	/**
		@@ -35,8 +34,7 @@ discard block
		block discarded – undo
35	34	*
36	35	* @return int[]
37	36	*/
38		- public function register()
39		- {
	37	+ public function register() {
40	38	return [T_FOR];
41	39
42	40	}//end register()
		@@ -51,8 +49,7 @@ discard block
		block discarded – undo
51	49	*
52	50	* @return void
53	51	*/
54		- public function process(File $phpcsFile, $stackPtr)
55		- {
	52	+ public function process(File $phpcsFile, $stackPtr) {
56	53	$tokens = $phpcsFile->getTokens();
57	54	$token = $tokens[$stackPtr];
58	55

		@@ -25,8 +25,7 @@ discard block
		block discarded – undo
25	25	use PHP_CodeSniffer\Files\File;
26	26	use PHP_CodeSniffer\Util\Tokens;
27	27
28		-class UselessOverridingMethodSniff implements Sniff
29		-{
	28	+class UselessOverridingMethodSniff implements Sniff {
30	29
31	30
32	31	/**
		@@ -34,8 +33,7 @@ discard block
		block discarded – undo
34	33	*
35	34	* @return int[]
36	35	*/
37		- public function register()
38		- {
	36	+ public function register() {
39	37	return [T_FUNCTION];
40	38
41	39	}//end register()
		@@ -50,8 +48,7 @@ discard block
		block discarded – undo
50	48	*
51	49	* @return void
52	50	*/
53		- public function process(File $phpcsFile, $stackPtr)
54		- {
	51	+ public function process(File $phpcsFile, $stackPtr) {
55	52	$tokens = $phpcsFile->getTokens();
56	53	$token = $tokens[$stackPtr];
57	54

		@@ -27,8 +27,7 @@ discard block
		block discarded – undo
27	27	use PHP_CodeSniffer\Files\File;
28	28	use PHP_CodeSniffer\Util\Tokens;
29	29
30		-class EmptyStatementSniff implements Sniff
31		-{
	30	+class EmptyStatementSniff implements Sniff {
32	31
33	32
34	33	/**
		@@ -36,8 +35,7 @@ discard block
		block discarded – undo
36	35	*
37	36	* @return int[]
38	37	*/
39		- public function register()
40		- {
	38	+ public function register() {
41	39	return [
42	40	T_TRY,
43	41	T_CATCH,
		@@ -64,8 +62,7 @@ discard block
		block discarded – undo
64	62	*
65	63	* @return void
66	64	*/
67		- public function process(File $phpcsFile, $stackPtr)
68		- {
	65	+ public function process(File $phpcsFile, $stackPtr) {
69	66	$tokens = $phpcsFile->getTokens();
70	67	$token = $tokens[$stackPtr];
71	68

		@@ -30,8 +30,7 @@ discard block
		block discarded – undo
30	30	use PHP_CodeSniffer\Files\File;
31	31	use PHP_CodeSniffer\Util\Tokens;
32	32
33		-class ForLoopWithTestFunctionCallSniff implements Sniff
34		-{
	33	+class ForLoopWithTestFunctionCallSniff implements Sniff {
35	34
36	35
37	36	/**
		@@ -39,8 +38,7 @@ discard block
		block discarded – undo
39	38	*
40	39	* @return int[]
41	40	*/
42		- public function register()
43		- {
	41	+ public function register() {
44	42	return [T_FOR];
45	43
46	44	}//end register()
		@@ -55,8 +53,7 @@ discard block
		block discarded – undo
55	53	*
56	54	* @return void
57	55	*/
58		- public function process(File $phpcsFile, $stackPtr)
59		- {
	56	+ public function process(File $phpcsFile, $stackPtr) {
60	57	$tokens = $phpcsFile->getTokens();
61	58	$token = $tokens[$stackPtr];
62	59

		@@ -16,8 +16,7 @@ discard block
		block discarded – undo
16	16	use PHP_CodeSniffer\Files\File;
17	17	use PHP_CodeSniffer\Util\Tokens;
18	18
19		-class EmptyPHPStatementSniff implements Sniff
20		-{
	19	+class EmptyPHPStatementSniff implements Sniff {
21	20
22	21
23	22	/**
		@@ -25,8 +24,7 @@ discard block
		block discarded – undo
25	24	*
26	25	* @return int[]
27	26	*/
28		- public function register()
29		- {
	27	+ public function register() {
30	28	return [
31	29	T_SEMICOLON,
32	30	T_CLOSE_TAG,
		@@ -44,8 +42,7 @@ discard block
		block discarded – undo
44	42	*
45	43	* @return void
46	44	*/
47		- public function process(File $phpcsFile, $stackPtr)
48		- {
	45	+ public function process(File $phpcsFile, $stackPtr) {
49	46	$tokens = $phpcsFile->getTokens();
50	47
51	48	switch ($tokens[$stackPtr]['type']) {

		@@ -12,8 +12,7 @@ discard block
		block discarded – undo
12	12	use PHP_CodeSniffer\Sniffs\Sniff;
13	13	use PHP_CodeSniffer\Files\File;
14	14
15		-class LowercasedFilenameSniff implements Sniff
16		-{
	15	+class LowercasedFilenameSniff implements Sniff {
17	16
18	17
19	18	/**
		@@ -21,8 +20,7 @@ discard block
		block discarded – undo
21	20	*
22	21	* @return array
23	22	*/
24		- public function register()
25		- {
	23	+ public function register() {
26	24	return [T_OPEN_TAG];
27	25
28	26	}//end register()
		@@ -37,8 +35,7 @@ discard block
		block discarded – undo
37	35	*
38	36	* @return int
39	37	*/
40		- public function process(File $phpcsFile, $stackPtr)
41		- {
	38	+ public function process(File $phpcsFile, $stackPtr) {
42	39	$filename = $phpcsFile->getFilename();
43	40	if ($filename === 'STDIN') {
44	41	return;

gravityview / GravityView

Pull Request — develop (#1492)

Category

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch