gravityview / GravityView

wpcs/WordPress/AbstractClassRestrictionsSniff.php

Spacing +8 added lines, -8 removed lines

@@ -118,8 +118,8 @@ 
 		$token     = $this->tokens[ $stackPtr ];
 		$classname = '';
 
-		if ( \in_array( $token['code'], array( \T_NEW, \T_EXTENDS, \T_IMPLEMENTS ), true ) ) {
-			if ( \T_NEW === $token['code'] ) {
+		if ( \in_array( $token[ 'code' ], array( \T_NEW, \T_EXTENDS, \T_IMPLEMENTS ), true ) ) {
+			if ( \T_NEW === $token[ 'code' ] ) {
 				$nameEnd = ( $this->phpcsFile->findNext( array( \T_OPEN_PARENTHESIS, \T_WHITESPACE, \T_SEMICOLON, \T_OBJECT_OPERATOR ), ( $stackPtr + 2 ) ) - 1 );
 			} else {
 				$nameEnd = ( $this->phpcsFile->findNext( array( \T_CLOSE_CURLY_BRACKET, \T_WHITESPACE ), ( $stackPtr + 2 ) ) - 1 );
@@ -128,18 +128,18 @@ 
 			$length    = ( $nameEnd - ( $stackPtr + 1 ) );
 			$classname = $this->phpcsFile->getTokensAsString( ( $stackPtr + 2 ), $length );
 
-			if ( \T_NS_SEPARATOR !== $this->tokens[ ( $stackPtr + 2 ) ]['code'] ) {
+			if ( \T_NS_SEPARATOR !== $this->tokens[ ( $stackPtr + 2 ) ][ 'code' ] ) {
 				$classname = $this->get_namespaced_classname( $classname, ( $stackPtr - 1 ) );
 			}
 		}
 
-		if ( \T_DOUBLE_COLON === $token['code'] ) {
+		if ( \T_DOUBLE_COLON === $token[ 'code' ] ) {
 			$nameEnd   = $this->phpcsFile->findPrevious( \T_STRING, ( $stackPtr - 1 ) );
 			$nameStart = ( $this->phpcsFile->findPrevious( array( \T_STRING, \T_NS_SEPARATOR, \T_NAMESPACE ), ( $nameEnd - 1 ), null, true, null, true ) + 1 );
 			$length    = ( $nameEnd - ( $nameStart - 1 ) );
 			$classname = $this->phpcsFile->getTokensAsString( $nameStart, $length );
 
-			if ( \T_NS_SEPARATOR !== $this->tokens[ $nameStart ]['code'] ) {
+			if ( \T_NS_SEPARATOR !== $this->tokens[ $nameStart ][ 'code' ] ) {
 				$classname = $this->get_namespaced_classname( $classname, ( $nameStart - 1 ) );
 			}
 		}
@@ -177,8 +177,8 @@ 
 				continue;
 			}
 
-			if ( preg_match( $group['regex'], $this->classname ) === 1 ) {
-				$skip_to[] = $this->process_matched_token( $stackPtr, $groupName, $this->classname );
+			if ( preg_match( $group[ 'regex' ], $this->classname ) === 1 ) {
+				$skip_to[ ] = $this->process_matched_token( $stackPtr, $groupName, $this->classname );
 			}
 		}
 
@@ -215,7 +215,7 @@ 
 	 */
 	protected function get_namespaced_classname( $classname, $search_from ) {
 		// Don't do anything if this is already a fully qualified classname.
-		if ( empty( $classname ) || '\\' === $classname[0] ) {
+		if ( empty( $classname ) || '\\' === $classname[ 0 ] ) {
 			return $classname;
 		}
 

wpcs/WordPress/AbstractFunctionRestrictionsSniff.php

Spacing +11 added lines, -11 removed lines

@@ -153,10 +153,10 @@ 
 				unset( $this->groups[ $groupName ] );
 			} else {
 				$items       = array_map( array( $this, 'prepare_name_for_regex' ), $group[ $key ] );
-				$all_items[] = $items;
+				$all_items[ ] = $items;
 				$items       = implode( '|', $items );
 
-				$this->groups[ $groupName ]['regex'] = sprintf( $this->regex_pattern, $items );
+				$this->groups[ $groupName ][ 'regex' ] = sprintf( $this->regex_pattern, $items );
 			}
 		}
 
@@ -192,7 +192,7 @@ 
 		// Preliminary check. If the content of the T_STRING is not one of the functions we're
 		// looking for, we can bow out before doing the heavy lifting of checking whether
 		// this is a function call.
-		if ( preg_match( $this->prelim_check_regex, $this->tokens[ $stackPtr ]['content'] ) !== 1 ) {
+		if ( preg_match( $this->prelim_check_regex, $this->tokens[ $stackPtr ][ 'content' ] ) !== 1 ) {
 			return;
 		}
 
@@ -213,7 +213,7 @@ 
 	public function is_targetted_token( $stackPtr ) {
 
 		// Exclude function definitions, class methods, and namespaced calls.
-		if ( \T_STRING === $this->tokens[ $stackPtr ]['code'] ) {
+		if ( \T_STRING === $this->tokens[ $stackPtr ][ 'code' ] ) {
 			if ( $this->is_class_object_call( $stackPtr ) === true ) {
 				return false;
 			}
@@ -232,7 +232,7 @@ 
 					\T_AS       => \T_AS, // Use declaration alias.
 				);
 
-				if ( isset( $skipped[ $this->tokens[ $prev ]['code'] ] ) ) {
+				if ( isset( $skipped[ $this->tokens[ $prev ][ 'code' ] ] ) ) {
 					return false;
 				}
 			}
@@ -254,7 +254,7 @@ 
 	 *                  normal file processing.
 	 */
 	public function check_for_matches( $stackPtr ) {
-		$token_content = strtolower( $this->tokens[ $stackPtr ]['content'] );
+		$token_content = strtolower( $this->tokens[ $stackPtr ][ 'content' ] );
 		$skip_to       = array();
 
 		foreach ( $this->groups as $groupName => $group ) {
@@ -263,12 +263,12 @@ 
 				continue;
 			}
 
-			if ( isset( $group['whitelist'][ $token_content ] ) ) {
+			if ( isset( $group[ 'whitelist' ][ $token_content ] ) ) {
 				continue;
 			}
 
-			if ( preg_match( $group['regex'], $token_content ) === 1 ) {
-				$skip_to[] = $this->process_matched_token( $stackPtr, $groupName, $token_content );
+			if ( preg_match( $group[ 'regex' ], $token_content ) === 1 ) {
+				$skip_to[ ] = $this->process_matched_token( $stackPtr, $groupName, $token_content );
 			}
 		}
 
@@ -294,9 +294,9 @@ 
 	public function process_matched_token( $stackPtr, $group_name, $matched_content ) {
 
 		$this->addMessage(
-			$this->groups[ $group_name ]['message'],
+			$this->groups[ $group_name ][ 'message' ],
 			$stackPtr,
-			( 'error' === $this->groups[ $group_name ]['type'] ),
+			( 'error' === $this->groups[ $group_name ][ 'type' ] ),
 			$this->string_to_errorcode( $group_name . '_' . $matched_content ),
 			array( $matched_content )
 		);

wpcs/WordPress/Sniffs/PHP/StrictComparisonsSniff.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 	public function process_token( $stackPtr ) {
 
 		if ( ! $this->has_whitelist_comment( 'loose comparison', $stackPtr ) ) {
-			$error = 'Found: ' . $this->tokens[ $stackPtr ]['content'] . '. Use strict comparisons (=== or !==).';
+			$error = 'Found: ' . $this->tokens[ $stackPtr ][ 'content' ] . '. Use strict comparisons (=== or !==).';
 			$this->phpcsFile->addWarning( $error, $stackPtr, 'LooseComparison' );
 		}
 	}

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		return array(

wpcs/WordPress/Sniffs/PHP/YodaConditionsSniff.php

Spacing +7 added lines, -7 removed lines

@@ -77,20 +77,20 @@ 
 		for ( $i = $stackPtr; $i > $start; $i-- ) {
 
 			// Ignore whitespace.
-			if ( isset( Tokens::$emptyTokens[ $this->tokens[ $i ]['code'] ] ) ) {
+			if ( isset( Tokens::$emptyTokens[ $this->tokens[ $i ][ 'code' ] ] ) ) {
 				continue;
 			}
 
 			// If this is a variable or array, we've seen all we need to see.
-			if ( \T_VARIABLE === $this->tokens[ $i ]['code']
-				|| \T_CLOSE_SQUARE_BRACKET === $this->tokens[ $i ]['code']
+			if ( \T_VARIABLE === $this->tokens[ $i ][ 'code' ]
+				|| \T_CLOSE_SQUARE_BRACKET === $this->tokens[ $i ][ 'code' ]
 			) {
 				$needs_yoda = true;
 				break;
 			}
 
 			// If this is a function call or something, we are OK.
-			if ( \T_CLOSE_PARENTHESIS === $this->tokens[ $i ]['code'] ) {
+			if ( \T_CLOSE_PARENTHESIS === $this->tokens[ $i ][ 'code' ] ) {
 				return;
 			}
 		}
@@ -102,11 +102,11 @@ 
 		// Check if this is a var to var comparison, e.g.: if ( $var1 == $var2 ).
 		$next_non_empty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $stackPtr + 1 ), null, true );
 
-		if ( isset( Tokens::$castTokens[ $this->tokens[ $next_non_empty ]['code'] ] ) ) {
+		if ( isset( Tokens::$castTokens[ $this->tokens[ $next_non_empty ][ 'code' ] ] ) ) {
 			$next_non_empty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $next_non_empty + 1 ), null, true );
 		}
 
-		if ( \in_array( $this->tokens[ $next_non_empty ]['code'], array( \T_SELF, \T_PARENT, \T_STATIC ), true ) ) {
+		if ( \in_array( $this->tokens[ $next_non_empty ][ 'code' ], array( \T_SELF, \T_PARENT, \T_STATIC ), true ) ) {
 			$next_non_empty = $this->phpcsFile->findNext(
 				array_merge( Tokens::$emptyTokens, array( \T_DOUBLE_COLON ) ),
 				( $next_non_empty + 1 ),
@@ -115,7 +115,7 @@ 
 			);
 		}
 
-		if ( \T_VARIABLE === $this->tokens[ $next_non_empty ]['code'] ) {
+		if ( \T_VARIABLE === $this->tokens[ $next_non_empty ][ 'code' ] ) {
 			return;
 		}
 

Doc Comments +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 

wpcs/WordPress/Sniffs/PHP/TypeCastsSniff.php

Spacing +2 added lines, -2 removed lines

@@ -52,8 +52,8 @@
 	 */
 	public function process_token( $stackPtr ) {
 
-		$token_code  = $this->tokens[ $stackPtr ]['code'];
-		$typecast    = str_replace( ' ', '', $this->tokens[ $stackPtr ]['content'] );
+		$token_code  = $this->tokens[ $stackPtr ][ 'code' ];
+		$typecast    = str_replace( ' ', '', $this->tokens[ $stackPtr ][ 'content' ] );
 		$typecast_lc = strtolower( $typecast );
 
 		switch ( $token_code ) {

wpcs/WordPress/Sniffs/PHP/IniSetSniff.php

Spacing +9 added lines, -9 removed lines

@@ -136,27 +136,27 @@ 
 	 * @return void
 	 */
 	public function process_parameters( $stackPtr, $group_name, $matched_content, $parameters ) {
-		$option_name  = $this->strip_quotes( $parameters[1]['raw'] );
-		$option_value = $this->strip_quotes( $parameters[2]['raw'] );
+		$option_name  = $this->strip_quotes( $parameters[ 1 ][ 'raw' ] );
+		$option_value = $this->strip_quotes( $parameters[ 2 ][ 'raw' ] );
 		if ( isset( $this->whitelisted_options[ $option_name ] ) ) {
 			$whitelisted_option = $this->whitelisted_options[ $option_name ];
-			if ( ! isset( $whitelisted_option['valid_values'] ) || in_array( strtolower( $option_value ), $whitelisted_option['valid_values'], true ) ) {
+			if ( ! isset( $whitelisted_option[ 'valid_values' ] ) || in_array( strtolower( $option_value ), $whitelisted_option[ 'valid_values' ], true ) ) {
 				return;
 			}
 		}
 
 		if ( isset( $this->blacklisted_options[ $option_name ] ) ) {
 			$blacklisted_option = $this->blacklisted_options[ $option_name ];
-			if ( ! isset( $blacklisted_option['invalid_values'] ) || in_array( strtolower( $option_value ), $blacklisted_option['invalid_values'], true ) ) {
+			if ( ! isset( $blacklisted_option[ 'invalid_values' ] ) || in_array( strtolower( $option_value ), $blacklisted_option[ 'invalid_values' ], true ) ) {
 				$this->phpcsFile->addError(
 					'%s(%s, %s) found. %s',
 					$stackPtr,
 					$this->string_to_errorcode( $option_name . '_Blacklisted' ),
 					array(
 						$matched_content,
-						$parameters[1]['raw'],
-						$parameters[2]['raw'],
-						$blacklisted_option['message'],
+						$parameters[ 1 ][ 'raw' ],
+						$parameters[ 2 ][ 'raw' ],
+						$blacklisted_option[ 'message' ],
 					)
 				);
 				return;
@@ -169,8 +169,8 @@ 
 			'Risky',
 			array(
 				$matched_content,
-				$parameters[1]['raw'],
-				$parameters[2]['raw'],
+				$parameters[ 1 ][ 'raw' ],
+				$parameters[ 2 ][ 'raw' ],
 			)
 		);
 	}

wpcs/WordPress/Sniffs/PHP/StrictInArraySniff.php

Spacing +3 added lines, -3 removed lines

@@ -81,20 +81,20 @@
 		}
 
 		// We're only interested in the third parameter.
-		if ( false === isset( $parameters[3] ) || 'true' !== strtolower( $parameters[3]['raw'] ) ) {
+		if ( false === isset( $parameters[ 3 ] ) || 'true' !== strtolower( $parameters[ 3 ][ 'raw' ] ) ) {
 			$errorcode = 'MissingTrueStrict';
 
 			/*
 			 * Use a different error code when `false` is found to allow for excluding
 			 * the warning as this will be a conscious choice made by the dev.
 			 */
-			if ( isset( $parameters[3] ) && 'false' === strtolower( $parameters[3]['raw'] ) ) {
+			if ( isset( $parameters[ 3 ] ) && 'false' === strtolower( $parameters[ 3 ][ 'raw' ] ) ) {
 				$errorcode = 'FoundNonStrictFalse';
 			}
 
 			$this->phpcsFile->addWarning(
 				'Not using strict comparison for %s; supply true for third argument.',
-				( isset( $parameters[3]['start'] ) ? $parameters[3]['start'] : $parameters[1]['start'] ),
+				( isset( $parameters[ 3 ][ 'start' ] ) ? $parameters[ 3 ][ 'start' ] : $parameters[ 1 ][ 'start' ] ),
 				$errorcode,
 				array( $matched_content )
 			);

wpcs/WordPress/Sniffs/DB/DirectDatabaseQuerySniff.php

Spacing +23 added lines, -23 removed lines

@@ -114,7 +114,7 @@ 
 	public function process_token( $stackPtr ) {
 
 		// Check for $wpdb variable.
-		if ( '$wpdb' !== $this->tokens[ $stackPtr ]['content'] ) {
+		if ( '$wpdb' !== $this->tokens[ $stackPtr ][ 'content' ] ) {
 			return;
 		}
 
@@ -124,11 +124,11 @@ 
 		}
 
 		$methodPtr = $this->phpcsFile->findNext( array( \T_WHITESPACE ), ( $is_object_call + 1 ), null, true, null, true );
-		$method    = $this->tokens[ $methodPtr ]['content'];
+		$method    = $this->tokens[ $methodPtr ][ 'content' ];
 
 		$this->mergeFunctionLists();
 
-		if ( ! isset( $this->methods['all'][ $method ] ) ) {
+		if ( ! isset( $this->methods[ 'all' ][ $method ] ) ) {
 			return;
 		}
 
@@ -136,12 +136,12 @@ 
 		$endOfLineComment = '';
 		for ( $i = ( $endOfStatement + 1 ); $i < $this->phpcsFile->numTokens; $i++ ) {
 
-			if ( $this->tokens[ $i ]['line'] !== $this->tokens[ $endOfStatement ]['line'] ) {
+			if ( $this->tokens[ $i ][ 'line' ] !== $this->tokens[ $endOfStatement ][ 'line' ] ) {
 				break;
 			}
 
-			if ( \T_COMMENT === $this->tokens[ $i ]['code'] ) {
-				$endOfLineComment .= $this->tokens[ $i ]['content'];
+			if ( \T_COMMENT === $this->tokens[ $i ][ 'code' ] ) {
+				$endOfLineComment .= $this->tokens[ $i ][ 'content' ];
 			}
 		}
 
@@ -157,7 +157,7 @@ 
 				break;
 			}
 
-			if ( preg_match( '#\b(?:ALTER|CREATE|DROP)\b#i', $this->tokens[ $_pos ]['content'] ) > 0 ) {
+			if ( preg_match( '#\b(?:ALTER|CREATE|DROP)\b#i', $this->tokens[ $_pos ][ 'content' ] ) > 0 ) {
 				$this->phpcsFile->addWarning( 'Attempting a database schema change is discouraged.', $_pos, 'SchemaChange' );
 			}
 		}
@@ -167,7 +167,7 @@ 
 			$this->phpcsFile->addWarning( 'Usage of a direct database call is discouraged.', $stackPtr, 'DirectQuery' );
 		}
 
-		if ( ! isset( $this->methods['cachable'][ $method ] ) ) {
+		if ( ! isset( $this->methods[ 'cachable' ][ $method ] ) ) {
 			return $endOfStatement;
 		}
 
@@ -177,7 +177,7 @@ 
 		if ( preg_match( '/cache\s+(?:ok|pass|clear|whitelist)/i', $endOfLineComment ) ) {
 			$whitelisted_cache = true;
 		}
-		if ( ! $whitelisted_cache && ! empty( $this->tokens[ $stackPtr ]['conditions'] ) ) {
+		if ( ! $whitelisted_cache && ! empty( $this->tokens[ $stackPtr ][ 'conditions' ] ) ) {
 			$scope_function = $this->phpcsFile->getCondition( $stackPtr, \T_FUNCTION );
 
 			if ( false === $scope_function ) {
@@ -185,23 +185,23 @@ 
 			}
 
 			if ( false !== $scope_function ) {
-				$scopeStart = $this->tokens[ $scope_function ]['scope_opener'];
-				$scopeEnd   = $this->tokens[ $scope_function ]['scope_closer'];
+				$scopeStart = $this->tokens[ $scope_function ][ 'scope_opener' ];
+				$scopeEnd   = $this->tokens[ $scope_function ][ 'scope_closer' ];
 
 				for ( $i = ( $scopeStart + 1 ); $i < $scopeEnd; $i++ ) {
-					if ( \T_STRING === $this->tokens[ $i ]['code'] ) {
+					if ( \T_STRING === $this->tokens[ $i ][ 'code' ] ) {
 
-						if ( isset( $this->cacheDeleteFunctions[ $this->tokens[ $i ]['content'] ] ) ) {
+						if ( isset( $this->cacheDeleteFunctions[ $this->tokens[ $i ][ 'content' ] ] ) ) {
 
 							if ( \in_array( $method, array( 'query', 'update', 'replace', 'delete' ), true ) ) {
 								$cached = true;
 								break;
 							}
-						} elseif ( isset( $this->cacheGetFunctions[ $this->tokens[ $i ]['content'] ] ) ) {
+						} elseif ( isset( $this->cacheGetFunctions[ $this->tokens[ $i ][ 'content' ] ] ) ) {
 
 							$wp_cache_get = true;
 
-						} elseif ( isset( $this->cacheSetFunctions[ $this->tokens[ $i ]['content'] ] ) ) {
+						} elseif ( isset( $this->cacheSetFunctions[ $this->tokens[ $i ][ 'content' ] ] ) ) {
 
 							if ( $wp_cache_get ) {
 								$cached = true;
@@ -229,35 +229,35 @@ 
 	 * @return void
 	 */
 	protected function mergeFunctionLists() {
-		if ( ! isset( $this->methods['all'] ) ) {
-			$this->methods['all'] = array_merge( $this->methods['cachable'], $this->methods['noncachable'] );
+		if ( ! isset( $this->methods[ 'all' ] ) ) {
+			$this->methods[ 'all' ] = array_merge( $this->methods[ 'cachable' ], $this->methods[ 'noncachable' ] );
 		}
 
-		if ( $this->customCacheGetFunctions !== $this->addedCustomFunctions['cacheget'] ) {
+		if ( $this->customCacheGetFunctions !== $this->addedCustomFunctions[ 'cacheget' ] ) {
 			$this->cacheGetFunctions = $this->merge_custom_array(
 				$this->customCacheGetFunctions,
 				$this->cacheGetFunctions
 			);
 
-			$this->addedCustomFunctions['cacheget'] = $this->customCacheGetFunctions;
+			$this->addedCustomFunctions[ 'cacheget' ] = $this->customCacheGetFunctions;
 		}
 
-		if ( $this->customCacheSetFunctions !== $this->addedCustomFunctions['cacheset'] ) {
+		if ( $this->customCacheSetFunctions !== $this->addedCustomFunctions[ 'cacheset' ] ) {
 			$this->cacheSetFunctions = $this->merge_custom_array(
 				$this->customCacheSetFunctions,
 				$this->cacheSetFunctions
 			);
 
-			$this->addedCustomFunctions['cacheset'] = $this->customCacheSetFunctions;
+			$this->addedCustomFunctions[ 'cacheset' ] = $this->customCacheSetFunctions;
 		}
 
-		if ( $this->customCacheDeleteFunctions !== $this->addedCustomFunctions['cachedelete'] ) {
+		if ( $this->customCacheDeleteFunctions !== $this->addedCustomFunctions[ 'cachedelete' ] ) {
 			$this->cacheDeleteFunctions = $this->merge_custom_array(
 				$this->customCacheDeleteFunctions,
 				$this->cacheDeleteFunctions
 			);
 
-			$this->addedCustomFunctions['cachedelete'] = $this->customCacheDeleteFunctions;
+			$this->addedCustomFunctions[ 'cachedelete' ] = $this->customCacheDeleteFunctions;
 		}
 	}
 

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		return array(

wpcs/WordPress/Sniffs/DB/PreparedSQLPlaceholdersSniff.php

Spacing +65 added lines, -65 removed lines

@@ -179,7 +179,7 @@ 
 			return;
 		}
 
-		$query                    = $parameters[1];
+		$query                    = $parameters[ 1 ];
 		$text_string_tokens_found = false;
 		$variable_found           = false;
 		$sql_wildcard_found       = false;
@@ -191,51 +191,51 @@ 
 			'adjustment_count' => 0,
 		);
 
-		for ( $i = $query['start']; $i <= $query['end']; $i++ ) {
+		for ( $i = $query[ 'start' ]; $i <= $query[ 'end' ]; $i++ ) {
 			// Skip over groups of tokens if they are part of an inline function call.
 			if ( isset( $skip_from, $skip_to ) && $i >= $skip_from && $i < $skip_to ) {
 				$i = $skip_to;
 				continue;
 			}
 
-			if ( ! isset( Tokens::$textStringTokens[ $this->tokens[ $i ]['code'] ] ) ) {
-				if ( \T_VARIABLE === $this->tokens[ $i ]['code'] ) {
-					if ( '$wpdb' !== $this->tokens[ $i ]['content'] ) {
+			if ( ! isset( Tokens::$textStringTokens[ $this->tokens[ $i ][ 'code' ] ] ) ) {
+				if ( \T_VARIABLE === $this->tokens[ $i ][ 'code' ] ) {
+					if ( '$wpdb' !== $this->tokens[ $i ][ 'content' ] ) {
 						$variable_found = true;
 					}
 					continue;
 				}
 
 				// Detect a specific pattern for variable replacements in combination with `IN`.
-				if ( \T_STRING === $this->tokens[ $i ]['code'] ) {
+				if ( \T_STRING === $this->tokens[ $i ][ 'code' ] ) {
 
-					if ( 'sprintf' === strtolower( $this->tokens[ $i ]['content'] ) ) {
+					if ( 'sprintf' === strtolower( $this->tokens[ $i ][ 'content' ] ) ) {
 						$sprintf_parameters = $this->get_function_call_parameters( $i );
 
 						if ( ! empty( $sprintf_parameters ) ) {
-							$skip_from  = ( $sprintf_parameters[1]['end'] + 1 );
+							$skip_from  = ( $sprintf_parameters[ 1 ][ 'end' ] + 1 );
 							$last_param = end( $sprintf_parameters );
-							$skip_to    = ( $last_param['end'] + 1 );
+							$skip_to    = ( $last_param[ 'end' ] + 1 );
 
-							$valid_in_clauses['implode_fill']     += $this->analyse_sprintf( $sprintf_parameters );
-							$valid_in_clauses['adjustment_count'] += ( \count( $sprintf_parameters ) - 1 );
+							$valid_in_clauses[ 'implode_fill' ]     += $this->analyse_sprintf( $sprintf_parameters );
+							$valid_in_clauses[ 'adjustment_count' ] += ( \count( $sprintf_parameters ) - 1 );
 						}
 						unset( $sprintf_parameters, $last_param );
 
-					} elseif ( 'implode' === strtolower( $this->tokens[ $i ]['content'] ) ) {
+					} elseif ( 'implode' === strtolower( $this->tokens[ $i ][ 'content' ] ) ) {
 						$prev = $this->phpcsFile->findPrevious(
 							Tokens::$textStringTokens,
 							( $i - 1 ),
-							$query['start']
+							$query[ 'start' ]
 						);
 
-						$prev_content = $this->strip_quotes( $this->tokens[ $prev ]['content'] );
-						$regex_quote  = $this->get_regex_quote_snippet( $prev_content, $this->tokens[ $prev ]['content'] );
+						$prev_content = $this->strip_quotes( $this->tokens[ $prev ][ 'content' ] );
+						$regex_quote  = $this->get_regex_quote_snippet( $prev_content, $this->tokens[ $prev ][ 'content' ] );
 
 						// Only examine the implode if preceded by an ` IN (`.
 						if ( preg_match( '`\s+IN\s*\(\s*(' . $regex_quote . ')?$`i', $prev_content, $match ) > 0 ) {
 
-							if ( isset( $match[1] ) && $regex_quote !== $this->regex_quote ) {
+							if ( isset( $match[ 1 ] ) && $regex_quote !== $this->regex_quote ) {
 								$this->phpcsFile->addError(
 									'Dynamic placeholder generation should not have surrounding quotes.',
 									$i,
@@ -244,15 +244,15 @@ 
 							}
 
 							if ( $this->analyse_implode( $i ) === true ) {
-								++$valid_in_clauses['uses_in'];
-								++$valid_in_clauses['implode_fill'];
+								++$valid_in_clauses[ 'uses_in' ];
+								++$valid_in_clauses[ 'implode_fill' ];
 
 								$next = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $i + 1 ), null, true );
-								if ( \T_OPEN_PARENTHESIS === $this->tokens[ $next ]['code']
-									&& isset( $this->tokens[ $next ]['parenthesis_closer'] )
+								if ( \T_OPEN_PARENTHESIS === $this->tokens[ $next ][ 'code' ]
+									&& isset( $this->tokens[ $next ][ 'parenthesis_closer' ] )
 								) {
 									$skip_from = ( $i + 1 );
-									$skip_to   = ( $this->tokens[ $next ]['parenthesis_closer'] + 1 );
+									$skip_to   = ( $this->tokens[ $next ][ 'parenthesis_closer' ] + 1 );
 								}
 							}
 						}
@@ -264,16 +264,16 @@ 
 			}
 
 			$text_string_tokens_found = true;
-			$content                  = $this->tokens[ $i ]['content'];
+			$content                  = $this->tokens[ $i ][ 'content' ];
 
 			$regex_quote = $this->regex_quote;
-			if ( isset( Tokens::$stringTokens[ $this->tokens[ $i ]['code'] ] ) ) {
+			if ( isset( Tokens::$stringTokens[ $this->tokens[ $i ][ 'code' ] ] ) ) {
 				$content     = $this->strip_quotes( $content );
-				$regex_quote = $this->get_regex_quote_snippet( $content, $this->tokens[ $i ]['content'] );
+				$regex_quote = $this->get_regex_quote_snippet( $content, $this->tokens[ $i ][ 'content' ] );
 			}
 
-			if ( \T_DOUBLE_QUOTED_STRING === $this->tokens[ $i ]['code']
-				|| \T_HEREDOC === $this->tokens[ $i ]['code']
+			if ( \T_DOUBLE_QUOTED_STRING === $this->tokens[ $i ][ 'code' ]
+				|| \T_HEREDOC === $this->tokens[ $i ][ 'code' ]
 			) {
 				// Only interested in actual query text, so strip out variables.
 				$stripped_content = $this->strip_interpolated_variables( $content );
@@ -305,23 +305,23 @@ 
 			$regex = '`\s+LIKE\s*(?:(' . $regex_quote . ')(?!%s(?:\1|$))(?P<content>.*?)(?:\1|$)|(?:concat\((?![^\)]*%s[^\)]*\))(?P<concat>[^\)]*))\))`i';
 			if ( preg_match_all( $regex, $content, $matches ) > 0 ) {
 				$walk = array();
-				if ( ! empty( $matches['content'] ) ) {
-					$matches['content'] = array_filter( $matches['content'] );
-					if ( ! empty( $matches['content'] ) ) {
-						$walk[] = 'content';
+				if ( ! empty( $matches[ 'content' ] ) ) {
+					$matches[ 'content' ] = array_filter( $matches[ 'content' ] );
+					if ( ! empty( $matches[ 'content' ] ) ) {
+						$walk[ ] = 'content';
 					}
 				}
-				if ( ! empty( $matches['concat'] ) ) {
-					$matches['concat'] = array_filter( $matches['concat'] );
-					if ( ! empty( $matches['concat'] ) ) {
-						$walk[] = 'concat';
+				if ( ! empty( $matches[ 'concat' ] ) ) {
+					$matches[ 'concat' ] = array_filter( $matches[ 'concat' ] );
+					if ( ! empty( $matches[ 'concat' ] ) ) {
+						$walk[ ] = 'concat';
 					}
 				}
 
 				if ( ! empty( $walk ) ) {
 					foreach ( $walk as $match_key ) {
 						foreach ( $matches[ $match_key ] as $index => $match ) {
-							$data = array( $matches[0][ $index ] );
+							$data = array( $matches[ 0 ][ $index ] );
 
 							// Both a `%` as well as a `_` are wildcards in SQL.
 							if ( strpos( $match, '%' ) === false && strpos( $match, '_' ) === false ) {
@@ -370,8 +370,8 @@ 
 			 * Analyse the query for unsupported placeholders.
 			 */
 			if ( preg_match_all( self::UNSUPPORTED_PLACEHOLDER_REGEX, $content, $matches ) > 0 ) {
-				if ( ! empty( $matches[0] ) ) {
-					foreach ( $matches[0] as $match ) {
+				if ( ! empty( $matches[ 0 ] ) ) {
+					foreach ( $matches[ 0 ] as $match ) {
 						if ( '%' === $match ) {
 							$this->phpcsFile->addError(
 								'Found unescaped literal "%%" character.',
@@ -397,8 +397,8 @@ 
 			 */
 			$regex = '`(' . $regex_quote . ')%[dfFs]\1`';
 			if ( preg_match_all( $regex, $content, $matches ) > 0 ) {
-				if ( ! empty( $matches[0] ) ) {
-					foreach ( $matches[0] as $match ) {
+				if ( ! empty( $matches[ 0 ] ) ) {
+					foreach ( $matches[ 0 ] as $match ) {
 						$this->phpcsFile->addError(
 							'Simple placeholders should not be quoted in the query string in $wpdb->prepare(). Found: %s.',
 							$i,
@@ -415,8 +415,8 @@ 
 			 */
 			$regex = '`(?<!' . $regex_quote . ')' . self::PREPARE_PLACEHOLDER_REGEX . '(?!' . $regex_quote . ')`x';
 			if ( preg_match_all( $regex, $content, $matches ) > 0 ) {
-				if ( ! empty( $matches[0] ) ) {
-					foreach ( $matches[0] as $match ) {
+				if ( ! empty( $matches[ 0 ] ) ) {
+					foreach ( $matches[ 0 ] as $match ) {
 						if ( preg_match( '`%[dfFs]`', $match ) !== 1 ) {
 							$this->phpcsFile->addWarning(
 								'Complex placeholders used for values in the query string in $wpdb->prepare() will NOT be quoted automagically. Found: %s.',
@@ -435,7 +435,7 @@ 
 			 */
 			$found_in = preg_match_all( '`\s+IN\s*\(\s*%s\s*\)`i', $content, $matches );
 			if ( $found_in > 0 ) {
-				$valid_in_clauses['uses_in'] += $found_in;
+				$valid_in_clauses[ 'uses_in' ] += $found_in;
 			}
 			unset( $found_in );
 		}
@@ -465,7 +465,7 @@ 
 						'UnnecessaryPrepare'
 					);
 				}
-			} elseif ( false === $count_diff_whitelisted && 0 === $valid_in_clauses['uses_in'] ) {
+			} elseif ( false === $count_diff_whitelisted && 0 === $valid_in_clauses[ 'uses_in' ] ) {
 				$this->phpcsFile->addWarning(
 					'Replacement variables found, but no valid placeholders found in the query.',
 					$i,
@@ -494,28 +494,28 @@ 
 		array_shift( $replacements ); // Remove the query.
 
 		// The parameters may have been passed as an array in parameter 2.
-		if ( isset( $parameters[2] ) && 2 === $total_parameters ) {
+		if ( isset( $parameters[ 2 ] ) && 2 === $total_parameters ) {
 			$next = $this->phpcsFile->findNext(
 				Tokens::$emptyTokens,
-				$parameters[2]['start'],
-				( $parameters[2]['end'] + 1 ),
+				$parameters[ 2 ][ 'start' ],
+				( $parameters[ 2 ][ 'end' ] + 1 ),
 				true
 			);
 
 			if ( false !== $next
-				&& ( \T_ARRAY === $this->tokens[ $next ]['code']
-					|| \T_OPEN_SHORT_ARRAY === $this->tokens[ $next ]['code'] )
+				&& ( \T_ARRAY === $this->tokens[ $next ][ 'code' ]
+					|| \T_OPEN_SHORT_ARRAY === $this->tokens[ $next ][ 'code' ] )
 			) {
 				$replacements = $this->get_function_call_parameters( $next );
 			}
 		}
 
 		$total_replacements  = \count( $replacements );
-		$total_placeholders -= $valid_in_clauses['adjustment_count'];
+		$total_placeholders -= $valid_in_clauses[ 'adjustment_count' ];
 
 		// Bow out when `IN` clauses have been used which appear to be correct.
-		if ( $valid_in_clauses['uses_in'] > 0
-			&& $valid_in_clauses['uses_in'] === $valid_in_clauses['implode_fill']
+		if ( $valid_in_clauses[ 'uses_in' ] > 0
+			&& $valid_in_clauses[ 'uses_in' ] === $valid_in_clauses[ 'implode_fill' ]
 			&& 1 === $total_replacements
 		) {
 			return;
@@ -553,7 +553,7 @@ 
 		$regex_quote = $this->regex_quote;
 
 		if ( $original_content !== $stripped_content ) {
-			$quote_style = $original_content[0];
+			$quote_style = $original_content[ 0 ];
 
 			if ( '"' === $quote_style ) {
 				$regex_quote = '\\\\"|\'';
@@ -581,21 +581,21 @@ 
 	protected function analyse_sprintf( $sprintf_params ) {
 		$found = 0;
 
-		unset( $sprintf_params[1] );
+		unset( $sprintf_params[ 1 ] );
 
 		foreach ( $sprintf_params as $sprintf_param ) {
-			if ( strpos( strtolower( $sprintf_param['raw'] ), 'implode' ) === false ) {
+			if ( strpos( strtolower( $sprintf_param[ 'raw' ] ), 'implode' ) === false ) {
 				continue;
 			}
 
 			$implode = $this->phpcsFile->findNext(
 				Tokens::$emptyTokens,
-				$sprintf_param['start'],
-				$sprintf_param['end'],
+				$sprintf_param[ 'start' ],
+				$sprintf_param[ 'end' ],
 				true
 			);
-			if ( \T_STRING === $this->tokens[ $implode ]['code']
-				&& 'implode' === strtolower( $this->tokens[ $implode ]['content'] )
+			if ( \T_STRING === $this->tokens[ $implode ][ 'code' ]
+				&& 'implode' === strtolower( $this->tokens[ $implode ][ 'content' ] )
 			) {
 				if ( $this->analyse_implode( $implode ) === true ) {
 					++$found;
@@ -628,23 +628,23 @@ 
 			return false;
 		}
 
-		if ( preg_match( '`^(["\']), ?\1$`', $implode_params[1]['raw'] ) !== 1 ) {
+		if ( preg_match( '`^(["\']), ?\1$`', $implode_params[ 1 ][ 'raw' ] ) !== 1 ) {
 			return false;
 		}
 
-		if ( strpos( strtolower( $implode_params[2]['raw'] ), 'array_fill' ) === false ) {
+		if ( strpos( strtolower( $implode_params[ 2 ][ 'raw' ] ), 'array_fill' ) === false ) {
 			return false;
 		}
 
 		$array_fill = $this->phpcsFile->findNext(
 			Tokens::$emptyTokens,
-			$implode_params[2]['start'],
-			$implode_params[2]['end'],
+			$implode_params[ 2 ][ 'start' ],
+			$implode_params[ 2 ][ 'end' ],
 			true
 		);
 
-		if ( \T_STRING !== $this->tokens[ $array_fill ]['code']
-			|| 'array_fill' !== strtolower( $this->tokens[ $array_fill ]['content'] )
+		if ( \T_STRING !== $this->tokens[ $array_fill ][ 'code' ]
+			|| 'array_fill' !== strtolower( $this->tokens[ $array_fill ][ 'content' ] )
 		) {
 			return false;
 		}
@@ -655,7 +655,7 @@ 
 			return false;
 		}
 
-		return (bool) preg_match( '`^(["\'])%[dfFs]\1$`', $array_fill_params[3]['raw'] );
+		return (bool)preg_match( '`^(["\'])%[dfFs]\1$`', $array_fill_params[ 3 ][ 'raw' ] );
 	}
 
 }

Doc Comments +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
 	 *
 	 * @since 0.14.0
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		return array(