gravityview / GravityView

vendor/wp-coding-standards/wpcs/WordPress/Sniffs/PHP/StrictComparisonsSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		return array(

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 	public function process_token( $stackPtr ) {
 
 		if ( ! $this->has_whitelist_comment( 'loose comparison', $stackPtr ) ) {
-			$error = 'Found: ' . $this->tokens[ $stackPtr ]['content'] . '. Use strict comparisons (=== or !==).';
+			$error = 'Found: ' . $this->tokens[ $stackPtr ][ 'content' ] . '. Use strict comparisons (=== or !==).';
 			$this->phpcsFile->addWarning( $error, $stackPtr, 'LooseComparison' );
 		}
 	}

vendor/wp-coding-standards/wpcs/WordPress/Sniffs/Security/EscapeOutputSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 

Spacing +43 added lines, -43 removed lines

@@ -190,26 +190,26 @@ 
 
 		$this->mergeFunctionLists();
 
-		$function = $this->tokens[ $stackPtr ]['content'];
+		$function = $this->tokens[ $stackPtr ][ 'content' ];
 
 		// Find the opening parenthesis (if present; T_ECHO might not have it).
 		$open_paren = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $stackPtr + 1 ), null, true );
 
 		// If function, not T_ECHO nor T_PRINT.
-		if ( \T_STRING === $this->tokens[ $stackPtr ]['code'] ) {
+		if ( \T_STRING === $this->tokens[ $stackPtr ][ 'code' ] ) {
 			// Skip if it is a function but is not one of the printing functions.
-			if ( ! isset( $this->printingFunctions[ $this->tokens[ $stackPtr ]['content'] ] ) ) {
+			if ( ! isset( $this->printingFunctions[ $this->tokens[ $stackPtr ][ 'content' ] ] ) ) {
 				return;
 			}
 
-			if ( isset( $this->tokens[ $open_paren ]['parenthesis_closer'] ) ) {
-				$end_of_statement = $this->tokens[ $open_paren ]['parenthesis_closer'];
+			if ( isset( $this->tokens[ $open_paren ][ 'parenthesis_closer' ] ) ) {
+				$end_of_statement = $this->tokens[ $open_paren ][ 'parenthesis_closer' ];
 			}
 
 			// These functions only need to have the first argument escaped.
 			if ( \in_array( $function, array( 'trigger_error', 'user_error' ), true ) ) {
 				$first_param      = $this->get_function_call_parameter( $stackPtr, 1 );
-				$end_of_statement = ( $first_param['end'] + 1 );
+				$end_of_statement = ( $first_param[ 'end' ] + 1 );
 				unset( $first_param );
 			}
 		}
@@ -243,13 +243,13 @@ 
 
 			// Check for the ternary operator. We only need to do this here if this
 			// echo is lacking parenthesis. Otherwise it will be handled below.
-			if ( \T_OPEN_PARENTHESIS !== $this->tokens[ $open_paren ]['code'] || \T_CLOSE_PARENTHESIS !== $this->tokens[ $last_token ]['code'] ) {
+			if ( \T_OPEN_PARENTHESIS !== $this->tokens[ $open_paren ][ 'code' ] || \T_CLOSE_PARENTHESIS !== $this->tokens[ $last_token ][ 'code' ] ) {
 
 				$ternary = $this->phpcsFile->findNext( \T_INLINE_THEN, $stackPtr, $end_of_statement );
 
 				// If there is a ternary skip over the part before the ?. However, if
 				// the ternary is within parentheses, it will be handled in the loop.
-				if ( false !== $ternary && empty( $this->tokens[ $ternary ]['nested_parenthesis'] ) ) {
+				if ( false !== $ternary && empty( $this->tokens[ $ternary ][ 'nested_parenthesis' ] ) ) {
 					$stackPtr = $ternary;
 				}
 			}
@@ -265,18 +265,18 @@ 
 		for ( $i = $stackPtr; $i < $end_of_statement; $i++ ) {
 
 			// Ignore whitespaces and comments.
-			if ( isset( Tokens::$emptyTokens[ $this->tokens[ $i ]['code'] ] ) ) {
+			if ( isset( Tokens::$emptyTokens[ $this->tokens[ $i ][ 'code' ] ] ) ) {
 				continue;
 			}
 
 			// Ignore namespace separators.
-			if ( \T_NS_SEPARATOR === $this->tokens[ $i ]['code'] ) {
+			if ( \T_NS_SEPARATOR === $this->tokens[ $i ][ 'code' ] ) {
 				continue;
 			}
 
-			if ( \T_OPEN_PARENTHESIS === $this->tokens[ $i ]['code'] ) {
+			if ( \T_OPEN_PARENTHESIS === $this->tokens[ $i ][ 'code' ] ) {
 
-				if ( ! isset( $this->tokens[ $i ]['parenthesis_closer'] ) ) {
+				if ( ! isset( $this->tokens[ $i ][ 'parenthesis_closer' ] ) ) {
 					// Live coding or parse error.
 					break;
 				}
@@ -284,20 +284,20 @@ 
 				if ( $in_cast ) {
 
 					// Skip to the end of a function call if it has been casted to a safe value.
-					$i       = $this->tokens[ $i ]['parenthesis_closer'];
+					$i       = $this->tokens[ $i ][ 'parenthesis_closer' ];
 					$in_cast = false;
 
 				} else {
 
 					// Skip over the condition part of a ternary (i.e., to after the ?).
-					$ternary = $this->phpcsFile->findNext( \T_INLINE_THEN, $i, $this->tokens[ $i ]['parenthesis_closer'] );
+					$ternary = $this->phpcsFile->findNext( \T_INLINE_THEN, $i, $this->tokens[ $i ][ 'parenthesis_closer' ] );
 
 					if ( false !== $ternary ) {
 
-						$next_paren = $this->phpcsFile->findNext( \T_OPEN_PARENTHESIS, ( $i + 1 ), $this->tokens[ $i ]['parenthesis_closer'] );
+						$next_paren = $this->phpcsFile->findNext( \T_OPEN_PARENTHESIS, ( $i + 1 ), $this->tokens[ $i ][ 'parenthesis_closer' ] );
 
 						// We only do it if the ternary isn't within a subset of parentheses.
-						if ( false === $next_paren || ( isset( $this->tokens[ $next_paren ]['parenthesis_closer'] ) && $ternary > $this->tokens[ $next_paren ]['parenthesis_closer'] ) ) {
+						if ( false === $next_paren || ( isset( $this->tokens[ $next_paren ][ 'parenthesis_closer' ] ) && $ternary > $this->tokens[ $next_paren ][ 'parenthesis_closer' ] ) ) {
 							$i = $ternary;
 						}
 					}
@@ -307,48 +307,48 @@ 
 			}
 
 			// Handle arrays for those functions that accept them.
-			if ( \T_ARRAY === $this->tokens[ $i ]['code'] ) {
+			if ( \T_ARRAY === $this->tokens[ $i ][ 'code' ] ) {
 				$i++; // Skip the opening parenthesis.
 				continue;
 			}
 
-			if ( \T_OPEN_SHORT_ARRAY === $this->tokens[ $i ]['code']
-				|| \T_CLOSE_SHORT_ARRAY === $this->tokens[ $i ]['code']
+			if ( \T_OPEN_SHORT_ARRAY === $this->tokens[ $i ][ 'code' ]
+				|| \T_CLOSE_SHORT_ARRAY === $this->tokens[ $i ][ 'code' ]
 			) {
 				continue;
 			}
 
-			if ( \in_array( $this->tokens[ $i ]['code'], array( \T_DOUBLE_ARROW, \T_CLOSE_PARENTHESIS ), true ) ) {
+			if ( \in_array( $this->tokens[ $i ][ 'code' ], array( \T_DOUBLE_ARROW, \T_CLOSE_PARENTHESIS ), true ) ) {
 				continue;
 			}
 
 			// Handle magic constants for debug functions.
-			if ( isset( $this->magic_constant_tokens[ $this->tokens[ $i ]['type'] ] ) ) {
+			if ( isset( $this->magic_constant_tokens[ $this->tokens[ $i ][ 'type' ] ] ) ) {
 				continue;
 			}
 
 			// Handle safe PHP native constants.
-			if ( \T_STRING === $this->tokens[ $i ]['code']
-				&& isset( $this->safe_php_constants[ $this->tokens[ $i ]['content'] ] )
+			if ( \T_STRING === $this->tokens[ $i ][ 'code' ]
+				&& isset( $this->safe_php_constants[ $this->tokens[ $i ][ 'content' ] ] )
 				&& $this->is_use_of_global_constant( $i )
 			) {
 				continue;
 			}
 
 			// Wake up on concatenation characters, another part to check.
-			if ( \T_STRING_CONCAT === $this->tokens[ $i ]['code'] ) {
+			if ( \T_STRING_CONCAT === $this->tokens[ $i ][ 'code' ] ) {
 				$watch = true;
 				continue;
 			}
 
 			// Wake up after a ternary else (:).
-			if ( false !== $ternary && \T_INLINE_ELSE === $this->tokens[ $i ]['code'] ) {
+			if ( false !== $ternary && \T_INLINE_ELSE === $this->tokens[ $i ][ 'code' ] ) {
 				$watch = true;
 				continue;
 			}
 
 			// Wake up for commas.
-			if ( \T_COMMA === $this->tokens[ $i ]['code'] ) {
+			if ( \T_COMMA === $this->tokens[ $i ][ 'code' ] ) {
 				$in_cast = false;
 				$watch   = true;
 				continue;
@@ -360,23 +360,23 @@ 
 
 			// Allow T_CONSTANT_ENCAPSED_STRING eg: echo 'Some String';
 			// Also T_LNUMBER, e.g.: echo 45; exit -1; and booleans.
-			if ( isset( $this->safe_components[ $this->tokens[ $i ]['type'] ] ) ) {
+			if ( isset( $this->safe_components[ $this->tokens[ $i ][ 'type' ] ] ) ) {
 				continue;
 			}
 
 			$watch = false;
 
 			// Allow int/double/bool casted variables.
-			if ( isset( $this->safe_cast_tokens[ $this->tokens[ $i ]['type'] ] ) ) {
+			if ( isset( $this->safe_cast_tokens[ $this->tokens[ $i ][ 'type' ] ] ) ) {
 				$in_cast = true;
 				continue;
 			}
 
 			// Now check that next token is a function call.
-			if ( \T_STRING === $this->tokens[ $i ]['code'] ) {
+			if ( \T_STRING === $this->tokens[ $i ][ 'code' ] ) {
 
 				$ptr                    = $i;
-				$functionName           = $this->tokens[ $i ]['content'];
+				$functionName           = $this->tokens[ $i ][ 'content' ];
 				$function_opener        = $this->phpcsFile->findNext( \T_OPEN_PARENTHESIS, ( $i + 1 ), null, false, null, true );
 				$is_formatting_function = isset( $this->formattingFunctions[ $functionName ] );
 
@@ -397,15 +397,15 @@ 
 							 */
 							$mapped_function = $this->phpcsFile->findNext(
 								Tokens::$emptyTokens,
-								$callback['start'],
-								( $callback['end'] + 1 ),
+								$callback[ 'start' ],
+								( $callback[ 'end' ] + 1 ),
 								true
 							);
 
 							if ( false !== $mapped_function
-								&& \T_CONSTANT_ENCAPSED_STRING === $this->tokens[ $mapped_function ]['code']
+								&& \T_CONSTANT_ENCAPSED_STRING === $this->tokens[ $mapped_function ][ 'code' ]
 							) {
-								$functionName = $this->strip_quotes( $this->tokens[ $mapped_function ]['content'] );
+								$functionName = $this->strip_quotes( $this->tokens[ $mapped_function ][ 'content' ] );
 								$ptr          = $mapped_function;
 							}
 						}
@@ -418,8 +418,8 @@ 
 						$i     = ( $function_opener + 1 );
 						$watch = true;
 					} else {
-						if ( isset( $this->tokens[ $function_opener ]['parenthesis_closer'] ) ) {
-							$i = $this->tokens[ $function_opener ]['parenthesis_closer'];
+						if ( isset( $this->tokens[ $function_opener ][ 'parenthesis_closer' ] ) ) {
+							$i = $this->tokens[ $function_opener ][ 'parenthesis_closer' ];
 						} else {
 							// Live coding or parse error.
 							break;
@@ -439,7 +439,7 @@ 
 				$content = $functionName;
 
 			} else {
-				$content = $this->tokens[ $i ]['content'];
+				$content = $this->tokens[ $i ][ 'content' ];
 				$ptr     = $i;
 			}
 
@@ -462,7 +462,7 @@ 
 	 * @return void
 	 */
 	protected function mergeFunctionLists() {
-		if ( $this->customEscapingFunctions !== $this->addedCustomFunctions['escape'] ) {
+		if ( $this->customEscapingFunctions !== $this->addedCustomFunctions[ 'escape' ] ) {
 			$customEscapeFunctions = $this->merge_custom_array( $this->customEscapingFunctions, array(), false );
 
 			$this->escapingFunctions = $this->merge_custom_array(
@@ -470,26 +470,26 @@ 
 				$this->escapingFunctions
 			);
 
-			$this->addedCustomFunctions['escape'] = $this->customEscapingFunctions;
+			$this->addedCustomFunctions[ 'escape' ] = $this->customEscapingFunctions;
 		}
 
-		if ( $this->customAutoEscapedFunctions !== $this->addedCustomFunctions['autoescape'] ) {
+		if ( $this->customAutoEscapedFunctions !== $this->addedCustomFunctions[ 'autoescape' ] ) {
 			$this->autoEscapedFunctions = $this->merge_custom_array(
 				$this->customAutoEscapedFunctions,
 				$this->autoEscapedFunctions
 			);
 
-			$this->addedCustomFunctions['autoescape'] = $this->customAutoEscapedFunctions;
+			$this->addedCustomFunctions[ 'autoescape' ] = $this->customAutoEscapedFunctions;
 		}
 
-		if ( $this->customPrintingFunctions !== $this->addedCustomFunctions['print'] ) {
+		if ( $this->customPrintingFunctions !== $this->addedCustomFunctions[ 'print' ] ) {
 
 			$this->printingFunctions = $this->merge_custom_array(
 				$this->customPrintingFunctions,
 				$this->printingFunctions
 			);
 
-			$this->addedCustomFunctions['print'] = $this->customPrintingFunctions;
+			$this->addedCustomFunctions[ 'print' ] = $this->customPrintingFunctions;
 		}
 	}
 

vendor/wp-coding-standards/wpcs/WordPress/Sniffs/WP/CapitalPDangitSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -270,7 +270,7 @@
 	/**
 	 * Retrieve a list of misspellings based on an array of matched variations on the target word.
 	 *
-	 * @param array $match_stack Array of matched variations of the target word.
+	 * @param string[] $match_stack Array of matched variations of the target word.
 	 * @return array Array containing only the misspelled variants.
 	 */
 	protected function retrieve_misspellings( $match_stack ) {

Spacing +31 added lines, -31 removed lines

@@ -126,24 +126,24 @@ 
 		 * The return values skip to the end of the array.
 		 * This prevents the sniff "hanging" on very long configuration arrays.
 		 */
-		if ( \T_OPEN_SHORT_ARRAY === $this->tokens[ $stackPtr ]['code'] && isset( $this->tokens[ $stackPtr ]['bracket_closer'] ) ) {
-			return $this->tokens[ $stackPtr ]['bracket_closer'];
-		} elseif ( \T_ARRAY === $this->tokens[ $stackPtr ]['code'] && isset( $this->tokens[ $stackPtr ]['parenthesis_closer'] ) ) {
-			return $this->tokens[ $stackPtr ]['parenthesis_closer'];
+		if ( \T_OPEN_SHORT_ARRAY === $this->tokens[ $stackPtr ][ 'code' ] && isset( $this->tokens[ $stackPtr ][ 'bracket_closer' ] ) ) {
+			return $this->tokens[ $stackPtr ][ 'bracket_closer' ];
+		} elseif ( \T_ARRAY === $this->tokens[ $stackPtr ][ 'code' ] && isset( $this->tokens[ $stackPtr ][ 'parenthesis_closer' ] ) ) {
+			return $this->tokens[ $stackPtr ][ 'parenthesis_closer' ];
 		}
 
 		/*
 		 * Deal with misspellings in class/interface/trait names.
 		 * These are not auto-fixable, but need the attention of a developer.
 		 */
-		if ( isset( Tokens::$ooScopeTokens[ $this->tokens[ $stackPtr ]['code'] ] ) ) {
+		if ( isset( Tokens::$ooScopeTokens[ $this->tokens[ $stackPtr ][ 'code' ] ] ) ) {
 			$classname = $this->phpcsFile->getDeclarationName( $stackPtr );
 			if ( empty( $classname ) ) {
 				return;
 			}
 
 			if ( preg_match_all( self::WP_CLASSNAME_REGEX, $classname, $matches, \PREG_PATTERN_ORDER ) > 0 ) {
-				$mispelled = $this->retrieve_misspellings( $matches[1] );
+				$mispelled = $this->retrieve_misspellings( $matches[ 1 ] );
 
 				if ( ! empty( $mispelled ) ) {
 					$this->phpcsFile->addWarning(
@@ -163,14 +163,14 @@ 
 		 */
 
 		// Ignore content of docblock @link tags.
-		if ( \T_DOC_COMMENT_STRING === $this->tokens[ $stackPtr ]['code']
-			|| \T_DOC_COMMENT === $this->tokens[ $stackPtr ]['code']
+		if ( \T_DOC_COMMENT_STRING === $this->tokens[ $stackPtr ][ 'code' ]
+			|| \T_DOC_COMMENT === $this->tokens[ $stackPtr ][ 'code' ]
 		) {
 
 			$comment_start = $this->phpcsFile->findPrevious( \T_DOC_COMMENT_OPEN_TAG, ( $stackPtr - 1 ) );
 			if ( false !== $comment_start ) {
 				$comment_tag = $this->phpcsFile->findPrevious( \T_DOC_COMMENT_TAG, ( $stackPtr - 1 ), $comment_start );
-				if ( false !== $comment_tag && '@link' === $this->tokens[ $comment_tag ]['content'] ) {
+				if ( false !== $comment_tag && '@link' === $this->tokens[ $comment_tag ][ 'content' ] ) {
 					// @link tag, so ignore.
 					return;
 				}
@@ -178,11 +178,11 @@ 
 		}
 
 		// Ignore any text strings which are array keys `$var['key']` as this is a false positive in 80% of all cases.
-		if ( \T_CONSTANT_ENCAPSED_STRING === $this->tokens[ $stackPtr ]['code'] ) {
+		if ( \T_CONSTANT_ENCAPSED_STRING === $this->tokens[ $stackPtr ][ 'code' ] ) {
 			$prevToken = $this->phpcsFile->findPrevious( Tokens::$emptyTokens, ( $stackPtr - 1 ), null, true, null, true );
-			if ( false !== $prevToken && \T_OPEN_SQUARE_BRACKET === $this->tokens[ $prevToken ]['code'] ) {
+			if ( false !== $prevToken && \T_OPEN_SQUARE_BRACKET === $this->tokens[ $prevToken ][ 'code' ] ) {
 				$nextToken = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $stackPtr + 1 ), null, true, null, true );
-				if ( false !== $nextToken && \T_CLOSE_SQUARE_BRACKET === $this->tokens[ $nextToken ]['code'] ) {
+				if ( false !== $nextToken && \T_CLOSE_SQUARE_BRACKET === $this->tokens[ $nextToken ][ 'code' ] ) {
 					return;
 				}
 			}
@@ -202,44 +202,44 @@ 
 			\T_OPEN_CURLY_BRACKET,
 		);
 		$maybe_const = $this->phpcsFile->findPrevious( $stop_points, ( $stackPtr - 1 ) );
-		if ( false !== $maybe_const && \T_CONST === $this->tokens[ $maybe_const ]['code'] ) {
+		if ( false !== $maybe_const && \T_CONST === $this->tokens[ $maybe_const ][ 'code' ] ) {
 			return;
 		}
 
-		$content = $this->tokens[ $stackPtr ]['content'];
+		$content = $this->tokens[ $stackPtr ][ 'content' ];
 
 		if ( preg_match_all( self::WP_REGEX, $content, $matches, ( \PREG_PATTERN_ORDER | \PREG_OFFSET_CAPTURE ) ) > 0 ) {
 			/*
 			 * Prevent some typical false positives.
 			 */
-			if ( isset( $this->text_and_comment_tokens[ $this->tokens[ $stackPtr ]['code'] ] ) ) {
+			if ( isset( $this->text_and_comment_tokens[ $this->tokens[ $stackPtr ][ 'code' ] ] ) ) {
 				$offset = 0;
-				foreach ( $matches[1] as $key => $match_data ) {
-					$next_offset = ( $match_data[1] + \strlen( $match_data[0] ) );
+				foreach ( $matches[ 1 ] as $key => $match_data ) {
+					$next_offset = ( $match_data[ 1 ] + \strlen( $match_data[ 0 ] ) );
 
 					// Prevent matches on part of a URL.
-					if ( preg_match( '`http[s]?://[^\s<>\'"()]*' . preg_quote( $match_data[0], '`' ) . '`', $content, $discard, 0, $offset ) === 1 ) {
-						unset( $matches[1][ $key ] );
-					} elseif ( preg_match( '`[a-z]+=(["\'])' . preg_quote( $match_data[0], '`' ) . '\1`', $content, $discard, 0, $offset ) === 1 ) {
+					if ( preg_match( '`http[s]?://[^\s<>\'"()]*' . preg_quote( $match_data[ 0 ], '`' ) . '`', $content, $discard, 0, $offset ) === 1 ) {
+						unset( $matches[ 1 ][ $key ] );
+					} elseif ( preg_match( '`[a-z]+=(["\'])' . preg_quote( $match_data[ 0 ], '`' ) . '\1`', $content, $discard, 0, $offset ) === 1 ) {
 						// Prevent matches on html attributes like: `value="wordpress"`.
-						unset( $matches[1][ $key ] );
-					} elseif ( preg_match( '`\\\\\'' . preg_quote( $match_data[0], '`' ) . '\\\\\'`', $content, $discard, 0, $offset ) === 1 ) {
+						unset( $matches[ 1 ][ $key ] );
+					} elseif ( preg_match( '`\\\\\'' . preg_quote( $match_data[ 0 ], '`' ) . '\\\\\'`', $content, $discard, 0, $offset ) === 1 ) {
 						// Prevent matches on xpath queries and such: `\'wordpress\'`.
-						unset( $matches[1][ $key ] );
-					} elseif ( preg_match( '`(?:\?|&amp;|&)[a-z0-9_]+=' . preg_quote( $match_data[0], '`' ) . '(?:&|$)`', $content, $discard, 0, $offset ) === 1 ) {
+						unset( $matches[ 1 ][ $key ] );
+					} elseif ( preg_match( '`(?:\?|&amp;|&)[a-z0-9_]+=' . preg_quote( $match_data[ 0 ], '`' ) . '(?:&|$)`', $content, $discard, 0, $offset ) === 1 ) {
 						// Prevent matches on url query strings: `?something=wordpress`.
-						unset( $matches[1][ $key ] );
+						unset( $matches[ 1 ][ $key ] );
 					}
 
 					$offset = $next_offset;
 				}
 
-				if ( empty( $matches[1] ) ) {
+				if ( empty( $matches[ 1 ] ) ) {
 					return;
 				}
 			}
 
-			$mispelled = $this->retrieve_misspellings( $matches[1] );
+			$mispelled = $this->retrieve_misspellings( $matches[ 1 ] );
 
 			if ( empty( $mispelled ) ) {
 				return;
@@ -258,8 +258,8 @@ 
 			if ( true === $fix ) {
 				// Apply fixes based on offset to ensure we don't replace false positives.
 				$replacement = $content;
-				foreach ( $matches[1] as $match ) {
-					$replacement = substr_replace( $replacement, 'WordPress', $match[1], \strlen( $match[0] ) );
+				foreach ( $matches[ 1 ] as $match ) {
+					$replacement = substr_replace( $replacement, 'WordPress', $match[ 1 ], \strlen( $match[ 0 ] ) );
 				}
 
 				$this->phpcsFile->fixer->replaceToken( $stackPtr, $replacement );
@@ -278,11 +278,11 @@ 
 		foreach ( $match_stack as $match ) {
 			// Deal with multi-dimensional arrays when capturing offset.
 			if ( \is_array( $match ) ) {
-				$match = $match[0];
+				$match = $match[ 0 ];
 			}
 
 			if ( 'WordPress' !== $match ) {
-				$mispelled[] = $match;
+				$mispelled[ ] = $match;
 			}
 		}
 

wpcs/WordPress/Sniffs/Arrays/ArrayKeySpacingRestrictionsSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public function register() {
 		return array(

Spacing +6 added lines, -6 removed lines

@@ -46,7 +46,7 @@ 
 	public function process_token( $stackPtr ) {
 
 		$token = $this->tokens[ $stackPtr ];
-		if ( ! isset( $token['bracket_closer'] ) ) {
+		if ( ! isset( $token[ 'bracket_closer' ] ) ) {
 			$this->phpcsFile->addWarning( 'Missing bracket closer.', $stackPtr, 'MissingBracketCloser' );
 			return;
 		}
@@ -54,12 +54,12 @@ 
 		$need_spaces = $this->phpcsFile->findNext(
 			array( \T_CONSTANT_ENCAPSED_STRING, \T_LNUMBER, \T_WHITESPACE, \T_MINUS ),
 			( $stackPtr + 1 ),
-			$token['bracket_closer'],
+			$token[ 'bracket_closer' ],
 			true
 		);
 
-		$spaced1 = ( \T_WHITESPACE === $this->tokens[ ( $stackPtr + 1 ) ]['code'] );
-		$spaced2 = ( \T_WHITESPACE === $this->tokens[ ( $token['bracket_closer'] - 1 ) ]['code'] );
+		$spaced1 = ( \T_WHITESPACE === $this->tokens[ ( $stackPtr + 1 ) ][ 'code' ] );
+		$spaced2 = ( \T_WHITESPACE === $this->tokens[ ( $token[ 'bracket_closer' ] - 1 ) ][ 'code' ] );
 
 		// It should have spaces unless if it only has strings or numbers as the key.
 		if ( false !== $need_spaces && ! ( $spaced1 && $spaced2 ) ) {
@@ -70,7 +70,7 @@ 
 					$this->phpcsFile->fixer->addContentBefore( ( $stackPtr + 1 ), ' ' );
 				}
 				if ( ! $spaced2 ) {
-					$this->phpcsFile->fixer->addContentBefore( $token['bracket_closer'], ' ' );
+					$this->phpcsFile->fixer->addContentBefore( $token[ 'bracket_closer' ], ' ' );
 				}
 			}
 		} elseif ( false === $need_spaces && ( $spaced1 || $spaced2 ) ) {
@@ -81,7 +81,7 @@ 
 					$this->phpcsFile->fixer->replaceToken( ( $stackPtr + 1 ), '' );
 				}
 				if ( $spaced2 ) {
-					$this->phpcsFile->fixer->replaceToken( ( $token['bracket_closer'] - 1 ), '' );
+					$this->phpcsFile->fixer->replaceToken( ( $token[ 'bracket_closer' ] - 1 ), '' );
 				}
 			}
 		}

wpcs/WordPress/Sniffs/Classes/ClassInstantiationSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		/*

Spacing +7 added lines, -7 removed lines

@@ -91,10 +91,10 @@ 
 	 */
 	public function process_token( $stackPtr ) {
 		// Make sure we have the right token, JS vs PHP.
-		if ( ( 'PHP' === $this->phpcsFile->tokenizerType && \T_NEW !== $this->tokens[ $stackPtr ]['code'] )
+		if ( ( 'PHP' === $this->phpcsFile->tokenizerType && \T_NEW !== $this->tokens[ $stackPtr ][ 'code' ] )
 			|| ( 'JS' === $this->phpcsFile->tokenizerType
-				&& ( \T_STRING !== $this->tokens[ $stackPtr ]['code']
-				|| 'new' !== strtolower( $this->tokens[ $stackPtr ]['content'] ) ) )
+				&& ( \T_STRING !== $this->tokens[ $stackPtr ][ 'code' ]
+				|| 'new' !== strtolower( $this->tokens[ $stackPtr ][ 'content' ] ) ) )
 		) {
 			return;
 		}
@@ -110,7 +110,7 @@ 
 				true
 			);
 
-			if ( false !== $prev_non_empty && 'T_BITWISE_AND' === $this->tokens[ $prev_non_empty ]['type'] ) {
+			if ( false !== $prev_non_empty && 'T_BITWISE_AND' === $this->tokens[ $prev_non_empty ][ 'type' ] ) {
 				$this->phpcsFile->recordMetric( $stackPtr, 'Assigning new by reference', 'yes' );
 
 				$this->phpcsFile->addError(
@@ -143,7 +143,7 @@ 
 		// Walk back to the last part of the class name.
 		$has_comment = false;
 		for ( $classname_ptr = ( $next_non_empty_after_class_name - 1 ); $classname_ptr >= $stackPtr; $classname_ptr-- ) {
-			if ( ! isset( Tokens::$emptyTokens[ $this->tokens[ $classname_ptr ]['code'] ] ) ) {
+			if ( ! isset( Tokens::$emptyTokens[ $this->tokens[ $classname_ptr ][ 'code' ] ] ) ) {
 				// Prevent a false positive on variable variables, disregard them for now.
 				if ( $stackPtr === $classname_ptr ) {
 					return;
@@ -152,12 +152,12 @@ 
 				break;
 			}
 
-			if ( \T_WHITESPACE !== $this->tokens[ $classname_ptr ]['code'] ) {
+			if ( \T_WHITESPACE !== $this->tokens[ $classname_ptr ][ 'code' ] ) {
 				$has_comment = true;
 			}
 		}
 
-		if ( \T_OPEN_PARENTHESIS !== $this->tokens[ $next_non_empty_after_class_name ]['code'] ) {
+		if ( \T_OPEN_PARENTHESIS !== $this->tokens[ $next_non_empty_after_class_name ][ 'code' ] ) {
 			$this->phpcsFile->recordMetric( $stackPtr, 'Object instantiation with parenthesis', 'no' );
 
 			$fix = $this->phpcsFile->addFixableError(

wpcs/WordPress/Sniffs/Files/FileNameSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function register() {
 		if ( \defined( '\PHP_CODESNIFFER_IN_TESTS' ) ) {

Spacing +10 added lines, -10 removed lines

@@ -148,18 +148,18 @@ 
 		if ( \defined( '\T_PHPCS_DISABLE' ) && \defined( '\T_PHPCS_ENABLE' ) ) {
 			$i = -1;
 			while ( $i = $this->phpcsFile->findNext( \T_PHPCS_DISABLE, ( $i + 1 ) ) ) {
-				if ( empty( $this->tokens[ $i ]['sniffCodes'] )
-					|| isset( $this->tokens[ $i ]['sniffCodes']['WordPress'] )
-					|| isset( $this->tokens[ $i ]['sniffCodes']['WordPress.Files'] )
-					|| isset( $this->tokens[ $i ]['sniffCodes']['WordPress.Files.FileName'] )
+				if ( empty( $this->tokens[ $i ][ 'sniffCodes' ] )
+					|| isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress' ] )
+					|| isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress.Files' ] )
+					|| isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress.Files.FileName' ] )
 				) {
 					do {
 						$i = $this->phpcsFile->findNext( \T_PHPCS_ENABLE, ( $i + 1 ) );
 					} while ( false !== $i
-						&& ! empty( $this->tokens[ $i ]['sniffCodes'] )
-						&& ! isset( $this->tokens[ $i ]['sniffCodes']['WordPress'] )
-						&& ! isset( $this->tokens[ $i ]['sniffCodes']['WordPress.Files'] )
-						&& ! isset( $this->tokens[ $i ]['sniffCodes']['WordPress.Files.FileName'] ) );
+						&& ! empty( $this->tokens[ $i ][ 'sniffCodes' ] )
+						&& ! isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress' ] )
+						&& ! isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress.Files' ] )
+						&& ! isset( $this->tokens[ $i ][ 'sniffCodes' ][ 'WordPress.Files.FileName' ] ) );
 
 					if ( false === $i ) {
 						// The entire (rest of the) file is disabled.
@@ -221,8 +221,8 @@ 
 					$fileName_end = substr( $fileName, -13 );
 					$has_class    = $this->phpcsFile->findNext( \T_CLASS, $stackPtr );
 
-					if ( ( 'Template' === trim( $this->tokens[ $subpackage ]['content'] )
-						&& $this->tokens[ $subpackage_tag ]['line'] === $this->tokens[ $subpackage ]['line'] )
+					if ( ( 'Template' === trim( $this->tokens[ $subpackage ][ 'content' ] )
+						&& $this->tokens[ $subpackage_tag ][ 'line' ] === $this->tokens[ $subpackage ][ 'line' ] )
 						&& ( ( ! \defined( '\PHP_CODESNIFFER_IN_TESTS' ) && '-template.php' !== $fileName_end )
 						|| ( \defined( '\PHP_CODESNIFFER_IN_TESTS' ) && '-template.inc' !== $fileName_end ) )
 						&& false === $has_class

wpcs/WordPress/Sniffs/PHP/NoSilencedErrorsSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
 	 *
 	 * @since 1.1.0
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public function register() {
 		$this->empty_tokens                    = Tokens::$emptyTokens;

Spacing +5 added lines, -5 removed lines

@@ -184,10 +184,10 @@ 
 			 * Check if the error silencing is done for one of the whitelisted functions.
 			 */
 			$next_non_empty = $this->phpcsFile->findNext( $this->empty_tokens, ( $stackPtr + 1 ), null, true, null, true );
-			if ( false !== $next_non_empty && \T_STRING === $this->tokens[ $next_non_empty ]['code'] ) {
+			if ( false !== $next_non_empty && \T_STRING === $this->tokens[ $next_non_empty ][ 'code' ] ) {
 				$has_parenthesis = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $next_non_empty + 1 ), null, true, null, true );
-				if ( false !== $has_parenthesis && \T_OPEN_PARENTHESIS === $this->tokens[ $has_parenthesis ]['code'] ) {
-					$function_name = strtolower( $this->tokens[ $next_non_empty ]['content'] );
+				if ( false !== $has_parenthesis && \T_OPEN_PARENTHESIS === $this->tokens[ $has_parenthesis ][ 'code' ] ) {
+					$function_name = strtolower( $this->tokens[ $next_non_empty ][ 'content' ] );
 					if ( ( true === $this->use_default_whitelist
 						&& isset( $this->function_whitelist[ $function_name ] ) === true )
 						|| in_array( $function_name, $this->custom_whitelist, true ) === true
@@ -199,7 +199,7 @@ 
 			}
 		}
 
-		$this->context_length = (int) $this->context_length;
+		$this->context_length = (int)$this->context_length;
 		$context_length       = $this->context_length;
 		if ( $this->context_length <= 0 ) {
 			$context_length = 2;
@@ -217,7 +217,7 @@ 
 		$data      = array();
 		if ( $this->context_length > 0 ) {
 			$error_msg .= ' Found: %s';
-			$data[]     = $found;
+			$data[ ]     = $found;
 		}
 
 		$this->phpcsFile->addWarning(

wpcs/WordPress/Sniffs/WP/PostsPerPageSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 	 * @param  mixed  $val   Assigned value.
 	 * @param  int    $line  Token line.
 	 * @param  array  $group Group definition.
-	 * @return mixed         FALSE if no match, TRUE if matches, STRING if matches
+	 * @return string|false         FALSE if no match, TRUE if matches, STRING if matches
 	 *                       with custom error message passed to ->process().
 	 */
 	public function callback( $key, $val, $line, $group ) {

Spacing +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 	 *                       with custom error message passed to ->process().
 	 */
 	public function callback( $key, $val, $line, $group ) {
-		$this->posts_per_page = (int) $this->posts_per_page;
+		$this->posts_per_page = (int)$this->posts_per_page;
 
 		if ( $val > $this->posts_per_page ) {
 			return 'Detected high pagination limit, `%s` is set to `%s`';

future/includes/class-gv-plugin.php

Spacing +12 added lines, -12 removed lines

@@ -505,8 +505,8 @@ 
 	 */
 	private function get_php_version() {
 
-		return ! empty( $GLOBALS['GRAVITYVIEW_TESTS_PHP_VERSION_OVERRIDE'] ) ?
-			$GLOBALS['GRAVITYVIEW_TESTS_PHP_VERSION_OVERRIDE'] : phpversion();
+		return ! empty( $GLOBALS[ 'GRAVITYVIEW_TESTS_PHP_VERSION_OVERRIDE' ] ) ?
+			$GLOBALS[ 'GRAVITYVIEW_TESTS_PHP_VERSION_OVERRIDE' ] : phpversion();
 	}
 
 	/**
@@ -518,8 +518,8 @@ 
 	 */
 	private function get_wordpress_version() {
 
-		return ! empty( $GLOBALS['GRAVITYVIEW_TESTS_WP_VERSION_OVERRIDE'] ) ?
-			$GLOBALS['GRAVITYVIEW_TESTS_WP_VERSION_OVERRIDE'] : $GLOBALS['wp_version'];
+		return ! empty( $GLOBALS[ 'GRAVITYVIEW_TESTS_WP_VERSION_OVERRIDE' ] ) ?
+			$GLOBALS[ 'GRAVITYVIEW_TESTS_WP_VERSION_OVERRIDE' ] : $GLOBALS[ 'wp_version' ];
 	}
 
 	/**
@@ -531,14 +531,14 @@ 
 	 */
 	private function get_gravityforms_version() {
 
-		if ( ! class_exists( '\GFCommon' ) || ! empty( $GLOBALS['GRAVITYVIEW_TESTS_GF_INACTIVE_OVERRIDE'] ) ) {
+		if ( ! class_exists( '\GFCommon' ) || ! empty( $GLOBALS[ 'GRAVITYVIEW_TESTS_GF_INACTIVE_OVERRIDE' ] ) ) {
 			gravityview()->log->error( 'Gravity Forms is inactive or not installed.' );
 
 			return null;
 		}
 
-		return ! empty( $GLOBALS['GRAVITYVIEW_TESTS_GF_VERSION_OVERRIDE'] ) ?
-			$GLOBALS['GRAVITYVIEW_TESTS_GF_VERSION_OVERRIDE'] : \GFCommon::$version;
+		return ! empty( $GLOBALS[ 'GRAVITYVIEW_TESTS_GF_VERSION_OVERRIDE' ] ) ?
+			$GLOBALS[ 'GRAVITYVIEW_TESTS_GF_VERSION_OVERRIDE' ] : \GFCommon::$version;
 	}
 
 	/**
@@ -584,7 +584,7 @@ 
 		$items = get_posts( array(
 			'post_type'   => 'gravityview',
 			'post_status' => 'any',
-			'numberposts' => - 1,
+			'numberposts' => -1,
 			'fields'      => 'ids',
 		) );
 
@@ -598,9 +598,9 @@ 
 		$tables = array();
 
 		if ( version_compare( \GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) ) {
-			$tables [] = \GFFormsModel::get_entry_meta_table_name();
+			$tables [ ] = \GFFormsModel::get_entry_meta_table_name();
 		} elseif ( ! $this->is_GF_25() ) {
-			$tables [] = \GFFormsModel::get_lead_meta_table_name();
+			$tables [ ] = \GFFormsModel::get_lead_meta_table_name();
 		}
 
 		foreach ( $tables as $meta_table ) {
@@ -619,9 +619,9 @@ 
 		$tables = array();
 
 		if ( version_compare( \GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_notes_table_name' ) ) {
-			$tables[] = \GFFormsModel::get_entry_notes_table_name();
+			$tables[ ] = \GFFormsModel::get_entry_notes_table_name();
 		} elseif ( ! $this->is_GF_25() ) {
-			$tables[] = \GFFormsModel::get_lead_notes_table_name();
+			$tables[ ] = \GFFormsModel::get_lead_notes_table_name();
 		}
 
 		$disapproved = __( 'Disapproved the Entry for GravityView', 'gravityview' );