+global\GravityView_Admin_Views::render_active_areas()

Complexity

Conditions	22
Paths	120

Size

Total Lines	108
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	506

Importance

Changes

0

<?php
	function render_active_areas( $template_id, $type, $zone, $rows, $values ) {

It is generally recommended to explicitly declare the visibility for methods.

		global $post;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		if( $type === 'widget' ) {

Found "=== '". Use Yoda Condition checks, you must

			$button_label = __( 'Add Widget', 'gravityview' );
		} else {
			$button_label = __( 'Add Field', 'gravityview' );
		}

		$available_items = array();

		$view = \GV\View::from_post( $post );

		// if saved values, get available fields to label everyone
		if( !empty( $values ) && ( !empty( $post->ID ) || !empty( $_POST['template_id'] ) ) ) {

Expected 1 space after "!"; 0 found

			if( !empty( $_POST['template_id'] ) ) {

Expected 1 space after "!"; 0 found

				$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );

Detected access of super global var $_POST, probably need manual inspection.

Detected usage of a non-sanitized input variable: $_POST

			} else {
				$form = gravityview_get_form_id( $post->ID );
			}

			if( 'field' === $type ) {
				$available_items = $this->get_available_fields( $form, $zone );
			} else {
				$available_items = $this->get_registered_widgets();

The method GravityView_Admin_Views::get_registered_widgets() has been deprecated with message: Use \GV\Widget::registered()

			}

		}

		foreach( $rows as $row ) :
			foreach( $row as $col => $areas ) :
				$column = ($col == '2-2') ? '1-2' : $col; ?>

				<div class="gv-grid-col-<?php echo esc_attr( $column ); ?>">

					<?php foreach( $areas as $area ) : 	?>

						<div class="gv-droppable-area">
							<div class="active-drop active-drop-<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>">

								<?php // render saved fields

								if( !empty( $values[ $zone .'_'. $area['areaid'] ] ) ) {

Expected 1 space after "!"; 0 found

									foreach( $values[ $zone .'_'. $area['areaid'] ] as $uniqid => $field ) {

										$input_type = NULL;

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

										$original_item = isset( $available_items[ $field['id'] ] ) ? $available_items[ $field['id'] ] : false ;

										if( !$original_item ) {

Expected 1 space after "!"; 0 found

											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array(' data' => array('available_items' => $available_items, 'field' => $field ) ) );

No space after opening parenthesis of array is bad style

											$original_item = $field;
										} else {

											$input_type = isset( $original_item['type'] ) ? $original_item['type'] : NULL;

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

										}

										// Maybe has a form ID
										$form_id = empty( $field['form_id'] ) ? null : $field['form_id'];

										// Field options dialog box
										$field_options = GravityView_Render_Settings::render_field_options( $form_id, $type, $template_id, $field['id'], $original_item['label'], $zone .'_'. $area['areaid'], $input_type, $uniqid, $field, $zone, $original_item );

										$item = array(
											'input_type' => $input_type,
											'settings_html' => $field_options,
											'label_type' => $type

Each line in an array declaration must end in a comma

										);

										// Merge the values with the current item to pass things like widget descriptions and original field names
										if( $original_item ) {
											$item = wp_parse_args( $item, $original_item );
										}

										switch( $type ) {
											case 'widget':
												echo new GravityView_Admin_View_Widget( $item['label'], $field['id'], $item, $field );

Expected next thing to be a escaping function, not 'new'

												break;
											default:
												echo new GravityView_Admin_View_Field( $item['label'], $field['id'], $item, $field );

Expected next thing to be a escaping function, not 'new'

										}

Functions must not contain multiple empty lines in a row; found 2 empty lines

										//endif;

									}

								} // End if zone is not empty ?>

								<span class="drop-message"><?php echo sprintf(esc_attr__('"+ %s" or drag existing %ss here.', 'gravityview'), $button_label, $type ); ?></span>

Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'sprintf'

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

							</div>
							<div class="gv-droppable-area-action">
								<a href="#" class="gv-add-field button-secondary" title="" data-objecttype="<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>" data-formid="<?php echo $view ? esc_attr( $view->form ? $view->form->ID : '' ) : ''; ?>"><?php echo '+ '.esc_html( $button_label ); ?></a>

Expected next thing to be a escaping function, not '$view'

								<p class="gv-droppable-area-title"><strong><?php echo esc_html( $area['title'] ); ?></strong><?php if( !empty( $area['subtitle'] ) ) { ?><span class="gv-droppable-area-subtitle"> &ndash; <?php echo esc_html( $area['subtitle'] ); ?></span><?php } ?></p>

Expected 1 space after "!"; 0 found

							</div>
						</div>

					<?php endforeach; ?>

				</div>
			<?php endforeach;
		endforeach;
	}