Completed
Pull Request — develop (#1436)
by
unknown
15:35
created
includes/class-cache.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 		/**
82 82
 		 * @see RGFormsModel::update_lead_property() Trigger when any entry property changes
83 83
 		 */
84
-		foreach( $this->lead_db_columns as $column ) {
84
+		foreach ( $this->lead_db_columns as $column ) {
85 85
 			add_action( 'gform_update_' . $column, array( $this, 'entry_status_changed' ), 10, 3 );
86 86
 		}
87 87
 
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
114 114
 			return;
115 115
 		}
116 116
 
117
-		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{lead_id} was deleted', array( 'form_id' => $entry['form_id'], 'entry_id' => $lead_id, 'data' => array( 'value' => $property_value, 'previous' => $previous_value ) ) );
117
+		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{lead_id} was deleted', array( 'form_id' => $entry[ 'form_id' ], 'entry_id' => $lead_id, 'data' => array( 'value' => $property_value, 'previous' => $previous_value ) ) );
118 118
 
119
-		$this->blacklist_add( $entry['form_id'] );
119
+		$this->blacklist_add( $entry[ 'form_id' ] );
120 120
 	}
121 121
 
122 122
 	/**
@@ -129,9 +129,9 @@  discard block
 block discarded – undo
129 129
 	 */
130 130
 	public function entry_updated( $form, $lead_id ) {
131 131
 
132
-		gravityview()->log->debug(' adding form {form_id} to blacklist because entry #{entry_id} was updated', array( 'form_id' => $form['id'], 'entry_id' => $lead_id ) );
132
+		gravityview()->log->debug( ' adding form {form_id} to blacklist because entry #{entry_id} was updated', array( 'form_id' => $form[ 'id' ], 'entry_id' => $lead_id ) );
133 133
 
134
-		$this->blacklist_add( $form['id'] );
134
+		$this->blacklist_add( $form[ 'id' ] );
135 135
 	}
136 136
 
137 137
 	/**
@@ -146,9 +146,9 @@  discard block
 block discarded – undo
146 146
 	 */
147 147
 	public function entry_created( $entry, $form ) {
148 148
 
149
-		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{entry_id} was created', array( 'form_id' => $form['id'], 'entry_id' => $entry['id'] ) );
149
+		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{entry_id} was created', array( 'form_id' => $form[ 'id' ], 'entry_id' => $entry[ 'id' ] ) );
150 150
 
151
-		$this->blacklist_add( $form['id'] );
151
+		$this->blacklist_add( $form[ 'id' ] );
152 152
 	}
153 153
 
154 154
 	/**
@@ -164,9 +164,9 @@  discard block
 block discarded – undo
164 164
 			return;
165 165
 		}
166 166
 
167
-		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{entry_id} was added', array( 'form_id' => $form['id'], 'entry_id' => $entry['id'] ) );
167
+		gravityview()->log->debug( 'adding form {form_id} to blacklist because entry #{entry_id} was added', array( 'form_id' => $form[ 'id' ], 'entry_id' => $entry[ 'id' ] ) );
168 168
 
169
-		$this->blacklist_add( $form['id'] );
169
+		$this->blacklist_add( $form[ 'id' ] );
170 170
 	}
171 171
 
172 172
 	/**
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 		// Normally just one form, but supports multiple forms
186 186
 		//
187 187
 		// Array of IDs 12, 5, 14 would result in `f:12-f:5-f:14`
188
-		$forms = 'f:' . implode( '-f:', (array) $form_ids );
188
+		$forms = 'f:' . implode( '-f:', (array)$form_ids );
189 189
 
190 190
 		// Prefix for transient keys
191 191
 		// Now the prefix would be: `gv-cache-f:12-f:5-f:14-`
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		) ) );
243 243
 
244 244
 		// Add the passed form IDs
245
-		$blacklist = array_merge( (array) $blacklist, $form_ids );
245
+		$blacklist = array_merge( (array)$blacklist, $form_ids );
246 246
 
247 247
 		// Don't duplicate
248 248
 		$blacklist = array_unique( $blacklist );
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
 		$blacklist = get_option( self::BLACKLIST_OPTION_NAME, array() );
267 267
 
268
-		$updated_list = array_diff( $blacklist, (array) $form_ids );
268
+		$updated_list = array_diff( $blacklist, (array)$form_ids );
269 269
 
270 270
 		gravityview()->log->debug( 'Removing form IDs from cache blacklist', array( 'data' => array(
271 271
 			'$form_ids'     => $form_ids,
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
 			return false;
299 299
 		}
300 300
 
301
-		foreach ( (array) $form_ids as $form_id ) {
301
+		foreach ( (array)$form_ids as $form_id ) {
302 302
 
303 303
 			if ( in_array( $form_id, $blacklist ) ) {
304 304
 
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
 			 * @filter `gravityview_cache_time_{$filter_name}` Modify the cache time for a type of cache
371 371
 			 * @param int $time_in_seconds Default: `DAY_IN_SECONDS`
372 372
 			 */
373
-			$cache_time = (int) apply_filters( 'gravityview_cache_time_' . $filter_name, DAY_IN_SECONDS );
373
+			$cache_time = (int)apply_filters( 'gravityview_cache_time_' . $filter_name, DAY_IN_SECONDS );
374 374
 
375 375
 			gravityview()->log->debug( 'Setting cache with transient key {key} for {cache_time} seconds', array( 'key' => $this->key, 'cache_time' => $cache_time ) );
376 376
 
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 			return;
407 407
 		}
408 408
 
409
-		foreach ( (array) $form_ids as $form_id ) {
409
+		foreach ( (array)$form_ids as $form_id ) {
410 410
 
411 411
 			$key = '_transient_gv-cache-';
412 412
 
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
522 522
 	public function use_cache() {
523 523
 
524 524
 		// Exit early if debugging (unless running PHPUnit)
525
-		if ( defined( 'WP_DEBUG' ) && WP_DEBUG && ! ( defined('DOING_GRAVITYVIEW_TESTS' ) && DOING_GRAVITYVIEW_TESTS ) ) {
525
+		if ( defined( 'WP_DEBUG' ) && WP_DEBUG && ! ( defined( 'DOING_GRAVITYVIEW_TESTS' ) && DOING_GRAVITYVIEW_TESTS ) ) {
526 526
 			return apply_filters( 'gravityview_use_cache', false, $this );
527 527
 		}
528 528
 
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
 
531 531
 		if ( GVCommon::has_cap( 'edit_gravityviews' ) ) {
532 532
 
533
-			if ( isset( $_GET['cache'] ) || isset( $_GET['nocache'] ) ) {
533
+			if ( isset( $_GET[ 'cache' ] ) || isset( $_GET[ 'nocache' ] ) ) {
534 534
 
535 535
 				gravityview()->log->debug( 'Not using cache: ?cache or ?nocache is in the URL' );
536 536
 
@@ -557,7 +557,7 @@  discard block
 block discarded – undo
557 557
 		 */
558 558
 		$use_cache = apply_filters( 'gravityview_use_cache', $use_cache, $this );
559 559
 
560
-		return (boolean) $use_cache;
560
+		return (boolean)$use_cache;
561 561
 	}
562 562
 
563 563
 }
Please login to merge, or discard this patch.
future/includes/class-gv-template-view-list.php 2 patches
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -151,11 +151,11 @@  discard block
 block discarded – undo
151 151
 		do_action( 'gravityview/template/list/body/before', $context );
152 152
 
153 153
 		/**
154
-		* @action `gravityview_list_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
155
-		* @deprecated Use `gravityview/template/list/body/before`
156
-		* @since 1.0.7
157
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
158
-		*/
154
+		 * @action `gravityview_list_body_before` Inside the `tbody`, before any rows are rendered. Can be used to insert additional rows.
155
+		 * @deprecated Use `gravityview/template/list/body/before`
156
+		 * @since 1.0.7
157
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
158
+		 */
159 159
 		do_action( 'gravityview_list_body_before', \GravityView_View::getInstance() /** ugh! */ );
160 160
 	}
161 161
 
@@ -177,11 +177,11 @@  discard block
 block discarded – undo
177 177
 		do_action( 'gravityview/template/list/body/after', $context );
178 178
 
179 179
 		/**
180
-		* @action `gravityview_list_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
181
-		* @deprecated Use `gravityview/template/list/body/after`
182
-		* @since 1.0.7
183
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
184
-		*/
180
+		 * @action `gravityview_list_body_after` Inside the `tbody`, after any rows are rendered. Can be used to insert additional rows.
181
+		 * @deprecated Use `gravityview/template/list/body/after`
182
+		 * @since 1.0.7
183
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
184
+		 */
185 185
 		do_action( 'gravityview_list_body_after', \GravityView_View::getInstance() /** ugh! */ );
186 186
 	}
187 187
 
@@ -212,11 +212,11 @@  discard block
 block discarded – undo
212 212
 		$zone = str_replace( '/', '_', $zone );
213 213
 
214 214
 		/**
215
-		* @action `gravityview_list_entry_$zone_before` Inside the `entry`, before any rows are rendered. Can be used to insert additional rows.
216
-		* @deprecated Use `gravityview/template/list/entry/$zone/before`
217
-		* @since 1.0.7
218
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
219
-		*/
215
+		 * @action `gravityview_list_entry_$zone_before` Inside the `entry`, before any rows are rendered. Can be used to insert additional rows.
216
+		 * @deprecated Use `gravityview/template/list/entry/$zone/before`
217
+		 * @since 1.0.7
218
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
219
+		 */
220 220
 		do_action( sprintf( 'gravityview_list_entry%sbefore', $zone ), $entry->as_entry(), \GravityView_View::getInstance() /** ugh! */ );
221 221
 	}
222 222
 
@@ -247,11 +247,11 @@  discard block
 block discarded – undo
247 247
 		$zone = str_replace( '/', '_', $zone );
248 248
 
249 249
 		/**
250
-		* @action `gravityview_list_entry_$zone_after` Inside the `entry`, after any rows are rendered. Can be used to insert additional rows.
251
-		* @deprecated Use `gravityview/template/list/entry/after`
252
-		* @since 1.0.7
253
-		* @param \GravityView_View $gravityview_view Current GravityView_View object.
254
-		*/
250
+		 * @action `gravityview_list_entry_$zone_after` Inside the `entry`, after any rows are rendered. Can be used to insert additional rows.
251
+		 * @deprecated Use `gravityview/template/list/entry/after`
252
+		 * @since 1.0.7
253
+		 * @param \GravityView_View $gravityview_view Current GravityView_View object.
254
+		 */
255 255
 		do_action( sprintf( 'gravityview_list_entry%safter', $zone ), $entry->as_entry(), \GravityView_View::getInstance() /** ugh! */ );
256 256
 	}
257 257
 }
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -29,9 +29,9 @@  discard block
 block discarded – undo
29 29
 	public function the_field( \GV\Field $field, \GV\Entry $entry, $extras = null ) {
30 30
 		$form = $this->view->form;
31 31
 
32
-		if ( isset( $this->view->unions[ $entry['form_id'] ] ) ) {
33
-			if ( isset( $this->view->unions[ $entry['form_id'] ][ $field->ID ] ) ) {
34
-				$field = $this->view->unions[ $entry['form_id'] ][ $field->ID ];
32
+		if ( isset( $this->view->unions[ $entry[ 'form_id' ] ] ) ) {
33
+			if ( isset( $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ] ) ) {
34
+				$field = $this->view->unions[ $entry[ 'form_id' ] ][ $field->ID ];
35 35
 			} elseif ( ! $field instanceof Internal_Field ) {
36 36
 				$field = Internal_Field::from_configuration( array( 'id' => 'custom' ) );
37 37
 			}
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
 		$hide_empty = apply_filters( 'gravityview/render/hide-empty-zone', Utils::get( $extras, 'hide_empty', $this->view->settings->get( 'hide_empty', false ) ), $context );
82 82
 
83 83
 		if ( is_numeric( $field->ID ) ) {
84
-			$extras['field'] = $field->as_configuration();
84
+			$extras[ 'field' ] = $field->as_configuration();
85 85
 		}
86 86
 
87
-		$extras['entry'] = $entry->as_entry();
88
-		$extras['hide_empty'] = $hide_empty;
89
-		$extras['label'] = $label;
90
-		$extras['value'] = $value;
87
+		$extras[ 'entry' ] = $entry->as_entry();
88
+		$extras[ 'hide_empty' ] = $hide_empty;
89
+		$extras[ 'label' ] = $label;
90
+		$extras[ 'value' ] = $value;
91 91
 
92 92
 		return \gravityview_field_output( $extras, $context );
93 93
 	}
Please login to merge, or discard this patch.
plugin-and-theme-hooks/abstract-gravityview-plugin-and-theme-hooks.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -195,7 +195,6 @@  discard block
 block discarded – undo
195 195
 	 *
196 196
 	 * @deprecated 2.0.7
197 197
 	 *
198
-	 * @param array $handles Array of meta keys to check for existence of shortcodes
199 198
 	 * @param int $post_id The ID being checked by GravityView
200 199
 	 *
201 200
 	 * @return array Meta key array, merged with existing meta keys
@@ -209,7 +208,6 @@  discard block
 block discarded – undo
209 208
 	 *
210 209
 	 * @since 2.0.7
211 210
 	 *
212
-	 * @param array $handles Array of meta keys to check for existence of shortcodes
213 211
 	 * @param \WP_Post $post The ID being checked by GravityView
214 212
 	 *
215 213
 	 * @return array Meta key array, merged with existing meta keys
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -110,9 +110,9 @@  discard block
 block discarded – undo
110 110
 	private function maybe_add_hooks() {
111 111
 		$class_exists = $this->class_name && class_exists( $this->class_name );
112 112
 		$function_exists = $this->function_name && function_exists( $this->function_name );
113
-		$constant_defined = $this->constant_name && defined("{$this->constant_name}");
113
+		$constant_defined = $this->constant_name && defined( "{$this->constant_name}" );
114 114
 
115
-		if( $class_exists || $function_exists || $constant_defined ) {
115
+		if ( $class_exists || $function_exists || $constant_defined ) {
116 116
 			$this->add_hooks();
117 117
 		}
118 118
 	}
@@ -124,23 +124,23 @@  discard block
 block discarded – undo
124 124
 	 */
125 125
 	protected function add_hooks() {
126 126
 
127
-		if( $this->meta_keys ) {
127
+		if ( $this->meta_keys ) {
128 128
 			add_filter( 'gravityview/data/parse/meta_keys', array( $this, 'merge_meta_keys' ), 10, 2 );
129 129
 		}
130 130
 
131
-		if( $this->content_meta_keys ) {
131
+		if ( $this->content_meta_keys ) {
132 132
 			add_filter( 'gravityview/view_collection/from_post/meta_keys', array( $this, 'merge_content_meta_keys' ), 10, 3 );
133 133
 		}
134 134
 
135
-		if( $this->script_handles ) {
135
+		if ( $this->script_handles ) {
136 136
 			add_filter( 'gravityview_noconflict_scripts', array( $this, 'merge_noconflict_scripts' ) );
137 137
 		}
138 138
 
139
-		if( $this->style_handles ) {
139
+		if ( $this->style_handles ) {
140 140
 			add_filter( 'gravityview_noconflict_styles', array( $this, 'merge_noconflict_styles' ) );
141 141
 		}
142 142
 
143
-		if( $this->post_type_support ) {
143
+		if ( $this->post_type_support ) {
144 144
 			add_filter( 'gravityview_post_type_support', array( $this, 'merge_post_type_support' ), 10, 2 );
145 145
 		}
146 146
 	}
Please login to merge, or discard this patch.
plugin-and-theme-hooks/class-gravityview-theme-hooks-siteorigin.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
 	 */
40 40
 	function merge_content_meta_keys( $meta_keys = array(), $post = null, & $views = null ) {
41 41
 
42
-		if( empty( $post->panels_data ) || empty( $post->panels_data['widgets'] ) ) {
42
+		if ( empty( $post->panels_data ) || empty( $post->panels_data[ 'widgets' ] ) ) {
43 43
 			return $meta_keys;
44 44
 		}
45 45
 
46
-		foreach ( (array) $post->panels_data['widgets'] as $widget ) {
46
+		foreach ( (array)$post->panels_data[ 'widgets' ] as $widget ) {
47 47
 
48 48
 			$views->merge( \GV\View_Collection::from_content( \GV\Utils::get( $widget, 'text' ) ) );
49 49
 
50
-			if ( empty( $widget['tabs'] ) || ! is_array( $widget['tabs'] ) ) {
50
+			if ( empty( $widget[ 'tabs' ] ) || ! is_array( $widget[ 'tabs' ] ) ) {
51 51
 				continue;
52 52
 			}
53 53
 
54
-			foreach ( $widget['tabs'] as $tab ) {
54
+			foreach ( $widget[ 'tabs' ] as $tab ) {
55 55
 
56 56
 				// Livemesh Tabs
57 57
 				$backup = \GV\Utils::get( $tab, 'tab_content' );
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 				// SiteOrigin Tabs
60 60
 				$content = \GV\Utils::get( $tab, 'content_text', $backup );
61 61
 
62
-				if( $content ) {
62
+				if ( $content ) {
63 63
 					$views->merge( \GV\View_Collection::from_content( $content ) );
64 64
 				}
65 65
 			}
Please login to merge, or discard this patch.
includes/plugin-and-theme-hooks/class-gravityview-plugin-hooks-acf.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
 		$acf_keys = get_field_objects( $post->ID, array( 'load_value' => false ) );
57 57
 
58
-		if( $acf_keys ) {
58
+		if ( $acf_keys ) {
59 59
 			return array_merge( array_keys( $acf_keys ), $meta_keys );
60 60
 		}
61 61
 
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
 	 * @return void
71 71
 	 */
72 72
 	private function fix_posted_fields() {
73
-		if( is_admin() && isset( $_POST['action'] ) && isset( $_POST['post_type'] ) ) {
74
-			if( 'editpost' === $_POST['action'] && 'gravityview' === $_POST['post_type'] ) {
75
-				$_POST['fields'] = _gravityview_process_posted_fields();
73
+		if ( is_admin() && isset( $_POST[ 'action' ] ) && isset( $_POST[ 'post_type' ] ) ) {
74
+			if ( 'editpost' === $_POST[ 'action' ] && 'gravityview' === $_POST[ 'post_type' ] ) {
75
+				$_POST[ 'fields' ] = _gravityview_process_posted_fields();
76 76
 			}
77 77
 		}
78 78
 	}
Please login to merge, or discard this patch.
future/includes/class-gv-source-internal.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,9 +24,8 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * Get a \GV\Field by Field ID for this data source.
26 26
 	 *
27
-	 * @param int $field_id The internal field ID (custom content, etc.)
28 27
 	 *
29
-	 * @return \GV\Field|null The requested field or null if not found.
28
+	 * @return null|Internal_Field The requested field or null if not found.
30 29
 	 */
31 30
 	public static function get_field( /** varargs */ ) {
32 31
 		$args = func_get_args();
Please login to merge, or discard this patch.
future/includes/class-gv-field-internal.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,12 +29,12 @@
 block discarded – undo
29 29
 	 */
30 30
 	public static function from_configuration( $configuration ) {
31 31
 
32
-		if ( empty( $configuration['id'] ) || ! is_string( $configuration['id'] ) ) {
32
+		if ( empty( $configuration[ 'id' ] ) || ! is_string( $configuration[ 'id' ] ) ) {
33 33
 			gravityview()->log->error( 'Invalid configuration[id] supplied.' );
34 34
 			return null;
35 35
 		}
36 36
 
37
-		$field = self::by_id( $configuration['id'] );
37
+		$field = self::by_id( $configuration[ 'id' ] );
38 38
 
39 39
 		$field->update_configuration( $configuration );
40 40
 
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-list.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@  discard block
 block discarded – undo
53 53
 	 * Columns are able to be added to View layouts, but not separately searched!
54 54
 	 *
55 55
 	 * @param array $fields
56
-	 * @param int $form_id
57 56
 	 *
58 57
 	 * @return array
59 58
 	 */
@@ -133,7 +132,7 @@  discard block
 block discarded – undo
133 132
 	 *
134 133
 	 * @param GF_Field_List $field Gravity Forms field
135 134
 	 * @param string|array $field_value Serialized or unserialized array value for the field
136
-	 * @param int|string $column_id The numeric key of the column (0-index) or the label of the column
135
+	 * @param integer $column_id The numeric key of the column (0-index) or the label of the column
137 136
 	 * @param string $format If set to 'raw', return an array of values for the column. Otherwise, allow Gravity Forms to render using `html` or `text`
138 137
 	 *
139 138
 	 * @return array|string|null Returns null if the $field_value passed wasn't an array or serialized array
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	public function remove_columns_from_searchable_fields( $fields ) {
61 61
 
62 62
 		foreach ( $fields as $key => $field ) {
63
-			if ( isset( $field['parent'] ) && $field['parent'] instanceof \GF_Field_List ) {
63
+			if ( isset( $field[ 'parent' ] ) && $field[ 'parent' ] instanceof \GF_Field_List ) {
64 64
 				unset( $fields[ $key ] );
65 65
 			}
66 66
 		}
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 		// Add the list columns
87 87
 		foreach ( $list_fields as $list_field ) {
88 88
 
89
-			if( empty( $list_field->enableColumns ) ) {
89
+			if ( empty( $list_field->enableColumns ) ) {
90 90
 				continue;
91 91
 			}
92 92
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 			}
108 108
 
109 109
 			// If there are columns, add them under the parent field
110
-			if( ! empty( $list_columns ) ) {
110
+			if ( ! empty( $list_columns ) ) {
111 111
 
112 112
 				$index = array_search( $list_field->id, array_keys( $fields ) ) + 1;
113 113
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 				 * Merge the $list_columns into the $fields array at $index
116 116
 				 * @see https://stackoverflow.com/a/1783125
117 117
 				 */
118
-				$fields = array_slice( $fields, 0, $index, true) + $list_columns + array_slice( $fields, $index, null, true);
118
+				$fields = array_slice( $fields, 0, $index, true ) + $list_columns + array_slice( $fields, $index, null, true );
119 119
 			}
120 120
 
121 121
 			unset( $list_columns, $index, $input_id );
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
 		$list_rows = maybe_unserialize( $field_value );
144 144
 
145
-		if( ! is_array( $list_rows ) ) {
145
+		if ( ! is_array( $list_rows ) ) {
146 146
 			gravityview()->log->error( '$field_value did not unserialize', array( 'data' => $field_value ) );
147 147
 			return null;
148 148
 		}
@@ -152,18 +152,18 @@  discard block
 block discarded – undo
152 152
 		// Each list row
153 153
 		foreach ( $list_rows as $list_row ) {
154 154
 			$current_column = 0;
155
-			foreach ( (array) $list_row as $column_key => $column_value ) {
155
+			foreach ( (array)$list_row as $column_key => $column_value ) {
156 156
 
157 157
 				// If the label of the column matches $column_id, or the numeric key value matches, add the value
158
-				if( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
-					$column_values[] = $column_value;
158
+				if ( (string)$column_key === (string)$column_id || ( is_numeric( $column_id ) && (int)$column_id === $current_column ) ) {
159
+					$column_values[ ] = $column_value;
160 160
 				}
161 161
 				$current_column++;
162 162
 			}
163 163
 		}
164 164
 
165 165
 		// Return the array of values
166
-		if( 'raw' === $format ) {
166
+		if ( 'raw' === $format ) {
167 167
 			return $column_values;
168 168
 		}
169 169
 		// Return the Gravity Forms Field output
@@ -186,22 +186,22 @@  discard block
 block discarded – undo
186 186
 	 */
187 187
 	public function _filter_field_label( $label, $field, $form, $entry ) {
188 188
 
189
-		$field_object = RGFormsModel::get_field( $form, $field['id'] );
189
+		$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
190 190
 
191 191
 		// Not a list field
192
-		if( ! $field_object || 'list' !== $field_object->type ) {
192
+		if ( ! $field_object || 'list' !== $field_object->type ) {
193 193
 			return $label;
194 194
 		}
195 195
 
196 196
 		// Custom label is defined, so use it
197
-		if( ! empty( $field['custom_label'] ) ) {
197
+		if ( ! empty( $field[ 'custom_label' ] ) ) {
198 198
 			return $label;
199 199
 		}
200 200
 
201
-		$column_id = gravityview_get_input_id_from_id( $field['id'] );
201
+		$column_id = gravityview_get_input_id_from_id( $field[ 'id' ] );
202 202
 
203 203
 		// Parent field, not column field
204
-		if( false === $column_id ) {
204
+		if ( false === $column_id ) {
205 205
 			return $label;
206 206
 		}
207 207
 
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	public static function get_column_label( GF_Field_List $field, $column_id, $backup_label = '' ) {
223 223
 
224 224
 		// Doesn't have columns enabled
225
-		if( ! isset( $field->choices ) || ! $field->enableColumns ) {
225
+		if ( ! isset( $field->choices ) || ! $field->enableColumns ) {
226 226
 			return $backup_label;
227 227
 		}
228 228
 
Please login to merge, or discard this patch.
includes/widgets/search-widget/class-search-widget.php 3 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -603,7 +603,8 @@  discard block
 block discarded – undo
603 603
 				// Fast-forward 24 hour on the end time
604 604
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
605 605
 				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
606
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
606
+				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) {
607
+// See https://github.com/gravityview/GravityView/issues/1056
607 608
 					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
608 609
 				}
609 610
 			}
@@ -874,7 +875,7 @@  discard block
 block discarded – undo
874 875
 			'ymd_dot' => 'Y.m.d',
875 876
 		);
876 877
 
877
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
878
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
878 879
 			$format = $datepicker[ $field->dateFormat ];
879 880
 		}
880 881
 
Please login to merge, or discard this patch.
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 	/**
247 247
 	 * Add admin script to the no-conflict scripts whitelist
248 248
 	 * @param array $allowed Scripts allowed in no-conflict mode
249
-	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
249
+	 * @return string[] Scripts allowed in no-conflict mode, plus the search widget script
250 250
 	 */
251 251
 	public function register_no_conflict( $allowed ) {
252 252
 		$allowed[] = 'gravityview_searchwidget_admin';
@@ -420,6 +420,7 @@  discard block
 block discarded – undo
420 420
 	 * Display hidden fields to add support for sites using Default permalink structure
421 421
 	 *
422 422
 	 * @since 1.8
423
+	 * @param GravityView_Widget_Search $object
423 424
 	 * @return array Search fields, modified if not using permalinks
424 425
 	 */
425 426
 	public function add_no_permalink_fields( $search_fields, $object, $widget_args = array() ) {
@@ -729,7 +730,6 @@  discard block
 block discarded – undo
729 730
 	 * Dropin for the legacy flat filters when \GF_Query is available.
730 731
 	 *
731 732
 	 * @param \GF_Query $query The current query object reference
732
-	 * @param \GV\View $this The current view object
733 733
 	 * @param \GV\Request $request The request object
734 734
 	 */
735 735
 	public function gf_query_filter( &$query, $view, $request ) {
@@ -1428,7 +1428,7 @@  discard block
 block discarded – undo
1428 1428
 	/**
1429 1429
 	 * Get the label for a search form field
1430 1430
 	 * @param  array $field      Field setting as sent by the GV configuration - has `field`, `input` (input type), and `label` keys
1431
-	 * @param  array $form_field Form field data, as fetched by `gravityview_get_field()`
1431
+	 * @param  GF_Field|null $form_field Form field data, as fetched by `gravityview_get_field()`
1432 1432
 	 * @return string             Label for the search form
1433 1433
 	 */
1434 1434
 	private static function get_field_label( $field, $form_field = array() ) {
@@ -1486,7 +1486,7 @@  discard block
 block discarded – undo
1486 1486
 	 * @param array $field
1487 1487
 	 * @param \GV\Context $context
1488 1488
 	 *
1489
-	 * @return array
1489
+	 * @return GV\View
1490 1490
 	 */
1491 1491
 	private function get_search_filter_details( $field, $context ) {
1492 1492
 
@@ -1634,7 +1634,7 @@  discard block
 block discarded – undo
1634 1634
 	/**
1635 1635
 	 * Require the datepicker script for the frontend GV script
1636 1636
 	 * @param array $js_dependencies Array of existing required scripts for the fe-views.js script
1637
-	 * @return array Array required scripts, with `jquery-ui-datepicker` added
1637
+	 * @return string[] Array required scripts, with `jquery-ui-datepicker` added
1638 1638
 	 */
1639 1639
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1640 1640
 
@@ -1646,7 +1646,7 @@  discard block
 block discarded – undo
1646 1646
 	/**
1647 1647
 	 * Modify the array passed to wp_localize_script()
1648 1648
 	 *
1649
-	 * @param array $js_localization The data padded to the Javascript file
1649
+	 * @param array $localizations The data padded to the Javascript file
1650 1650
 	 * @param array $view_data View data array with View settings
1651 1651
 	 *
1652 1652
 	 * @return array
@@ -1826,7 +1826,7 @@  discard block
 block discarded – undo
1826 1826
 	 *
1827 1827
 	 * @param array  $get     Where to look for the operator.
1828 1828
 	 * @param string $key     The filter key to look for.
1829
-	 * @param array  $allowed The allowed operators (whitelist).
1829
+	 * @param string[]  $allowed The allowed operators (whitelist).
1830 1830
 	 * @param string $default The default operator.
1831 1831
 	 *
1832 1832
 	 * @return string The operator.
Please login to merge, or discard this patch.
Spacing   +183 added lines, -183 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 				'type' => 'radio',
65 65
 				'full_width' => true,
66 66
 				'label' => esc_html__( 'Search Mode', 'gravityview' ),
67
-				'desc' => __('Should search results match all search fields, or any?', 'gravityview'),
67
+				'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),
68 68
 				'value' => 'any',
69 69
 				'class' => 'hide-if-js',
70 70
 				'options' => array(
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 			// admin - add scripts - run at 1100 to make sure GravityView_Admin_Views::add_scripts_and_styles() runs first at 999
85 85
 			add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 1100 );
86
-			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts') );
86
+			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts' ) );
87 87
 			add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
88 88
 
89 89
 			// ajax - get the searchable fields
@@ -119,19 +119,19 @@  discard block
 block discarded – undo
119 119
 	 */
120 120
 	public function add_reserved_args( $args ) {
121 121
 
122
-		$args[] = 'gv_search';
123
-		$args[] = 'gv_start';
124
-		$args[] = 'gv_end';
125
-		$args[] = 'gv_id';
126
-		$args[] = 'gv_by';
127
-		$args[] = 'mode';
122
+		$args[ ] = 'gv_search';
123
+		$args[ ] = 'gv_start';
124
+		$args[ ] = 'gv_end';
125
+		$args[ ] = 'gv_id';
126
+		$args[ ] = 'gv_by';
127
+		$args[ ] = 'mode';
128 128
 
129
-		$get = (array) $_GET;
129
+		$get = (array)$_GET;
130 130
 
131 131
 		// If the fields being searched as reserved; not to be considered user-passed variables
132 132
 		foreach ( $get as $key => $value ) {
133 133
 			if ( $key !== $this->convert_request_key_to_filter_key( $key ) ) {
134
-				$args[] = $key;
134
+				$args[ ] = $key;
135 135
 			}
136 136
 		}
137 137
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
 		$script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
256 256
 		$script_source = empty( $script_min ) ? '/source' : '';
257 257
 
258
-		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
258
+		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
259 259
 
260 260
 		wp_localize_script( 'gravityview_searchwidget_admin', 'gvSearchVar', array(
261 261
 			'nonce' => wp_create_nonce( 'gravityview_ajaxsearchwidget' ),
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
278 278
 	 */
279 279
 	public function register_no_conflict( $allowed ) {
280
-		$allowed[] = 'gravityview_searchwidget_admin';
280
+		$allowed[ ] = 'gravityview_searchwidget_admin';
281 281
 		return $allowed;
282 282
 	}
283 283
 
@@ -289,24 +289,24 @@  discard block
 block discarded – undo
289 289
 	 */
290 290
 	public static function get_searchable_fields() {
291 291
 
292
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) {
292
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) {
293 293
 			exit( '0' );
294 294
 		}
295 295
 
296 296
 		$form = '';
297 297
 
298 298
 		// Fetch the form for the current View
299
-		if ( ! empty( $_POST['view_id'] ) ) {
299
+		if ( ! empty( $_POST[ 'view_id' ] ) ) {
300 300
 
301
-			$form = gravityview_get_form_id( $_POST['view_id'] );
301
+			$form = gravityview_get_form_id( $_POST[ 'view_id' ] );
302 302
 
303
-		} elseif ( ! empty( $_POST['formid'] ) ) {
303
+		} elseif ( ! empty( $_POST[ 'formid' ] ) ) {
304 304
 
305
-			$form = (int) $_POST['formid'];
305
+			$form = (int)$_POST[ 'formid' ];
306 306
 
307
-		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) {
307
+		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) {
308 308
 
309
-			$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
309
+			$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
310 310
 
311 311
 		}
312 312
 
@@ -356,14 +356,14 @@  discard block
 block discarded – undo
356 356
 		);
357 357
 
358 358
 		if ( gravityview()->plugin->supports( \GV\Plugin::FEATURE_GFQUERY ) ) {
359
-			$custom_fields['is_approved'] = array(
359
+			$custom_fields[ 'is_approved' ] = array(
360 360
 				'text' => esc_html__( 'Approval Status', 'gravityview' ),
361 361
 				'type' => 'multi',
362 362
 			);
363 363
 		}
364 364
 
365
-		foreach( $custom_fields as $custom_field_key => $custom_field ) {
366
-			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] );
365
+		foreach ( $custom_fields as $custom_field_key => $custom_field ) {
366
+			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );
367 367
 		}
368 368
 
369 369
 		// Get fields with sub-inputs and no parent
@@ -385,13 +385,13 @@  discard block
 block discarded – undo
385 385
 
386 386
 			foreach ( $fields as $id => $field ) {
387 387
 
388
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
388
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
389 389
 					continue;
390 390
 				}
391 391
 
392
-				$types = self::get_search_input_types( $id, $field['type'] );
392
+				$types = self::get_search_input_types( $id, $field[ 'type' ] );
393 393
 
394
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';
394
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';
395 395
 			}
396 396
 		}
397 397
 
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 	public static function get_search_input_types( $field_id = '', $field_type = null ) {
415 415
 
416 416
 		// @todo - This needs to be improved - many fields have . including products and addresses
417
-		if ( false !== strpos( (string) $field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
417
+		if ( false !== strpos( (string)$field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
418 418
 			$input_type = 'boolean'; // on/off checkbox
419 419
 		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) {
420 420
 			$input_type = 'multi'; //multiselect
@@ -460,19 +460,19 @@  discard block
 block discarded – undo
460 460
 			$post_id = 0;
461 461
 
462 462
 			// We're in the WordPress Widget context, and an overriding post ID has been set.
463
-			if ( ! empty( $widget_args['post_id'] ) ) {
464
-				$post_id = absint( $widget_args['post_id'] );
463
+			if ( ! empty( $widget_args[ 'post_id' ] ) ) {
464
+				$post_id = absint( $widget_args[ 'post_id' ] );
465 465
 			}
466 466
 			// We're in the WordPress Widget context, and the base View ID should be used
467
-			else if ( ! empty( $widget_args['view_id'] ) ) {
468
-				$post_id = absint( $widget_args['view_id'] );
467
+			else if ( ! empty( $widget_args[ 'view_id' ] ) ) {
468
+				$post_id = absint( $widget_args[ 'view_id' ] );
469 469
 			}
470 470
 
471 471
 			$args = gravityview_get_permalink_query_args( $post_id );
472 472
 
473 473
 			// Add hidden fields to the search form
474 474
 			foreach ( $args as $key => $value ) {
475
-				$search_fields[] = array(
475
+				$search_fields[ ] = array(
476 476
 					'name'  => $key,
477 477
 					'input' => 'hidden',
478 478
 					'value' => $value,
@@ -511,28 +511,28 @@  discard block
 block discarded – undo
511 511
 		/**
512 512
 		 * Include the sidebar Widgets.
513 513
 		 */
514
-		$widgets = (array) get_option( 'widget_gravityview_search', array() );
514
+		$widgets = (array)get_option( 'widget_gravityview_search', array() );
515 515
 
516 516
 		foreach ( $widgets as $widget ) {
517
-			if ( ! empty( $widget['view_id'] ) && $widget['view_id'] == $view->ID ) {
518
-				if( $_fields = json_decode( $widget['search_fields'], true ) ) {
517
+			if ( ! empty( $widget[ 'view_id' ] ) && $widget[ 'view_id' ] == $view->ID ) {
518
+				if ( $_fields = json_decode( $widget[ 'search_fields' ], true ) ) {
519 519
 					foreach ( $_fields as $field ) {
520
-						if ( empty( $field['form_id'] ) ) {
521
-							$field['form_id'] = $view->form ? $view->form->ID : 0;
520
+						if ( empty( $field[ 'form_id' ] ) ) {
521
+							$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
522 522
 						}
523
-						$searchable_fields[] = $with_full_field ? $field : $field['field'];
523
+						$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
524 524
 					}
525 525
 				}
526 526
 			}
527 527
 		}
528 528
 
529 529
 		foreach ( $view->widgets->by_id( $this->get_widget_id() )->all() as $widget ) {
530
-			if( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
530
+			if ( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
531 531
 				foreach ( $_fields as $field ) {
532
-					if ( empty( $field['form_id'] ) ) {
533
-						$field['form_id'] = $view->form ? $view->form->ID : 0;
532
+					if ( empty( $field[ 'form_id' ] ) ) {
533
+						$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
534 534
 					}
535
-					$searchable_fields[] = $with_full_field ? $field : $field['field'];
535
+					$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
536 536
 				}
537 537
 			}
538 538
 		}
@@ -570,7 +570,7 @@  discard block
 block discarded – undo
570 570
 			return $search_criteria; // Return the original criteria, GF_Query modification kicks in later
571 571
 		}
572 572
 
573
-		if( 'post' === $this->search_method ) {
573
+		if ( 'post' === $this->search_method ) {
574 574
 			$get = $_POST;
575 575
 		} else {
576 576
 			$get = $_GET;
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
 		$get = gv_map_deep( $get, 'rawurldecode' );
590 590
 
591 591
 		// Make sure array key is set up
592
-		$search_criteria['field_filters'] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
592
+		$search_criteria[ 'field_filters' ] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
593 593
 
594 594
 		$searchable_fields = $this->get_view_searchable_fields( $view );
595 595
 		$searchable_field_objects = $this->get_view_searchable_fields( $view, true );
@@ -609,9 +609,9 @@  discard block
 block discarded – undo
609 609
 		$trim_search_value = apply_filters( 'gravityview/search-trim-input', true );
610 610
 
611 611
 		// add free search
612
-		if ( isset( $get['gv_search'] ) && '' !== $get['gv_search'] && in_array( 'search_all', $searchable_fields ) ) {
612
+		if ( isset( $get[ 'gv_search' ] ) && '' !== $get[ 'gv_search' ] && in_array( 'search_all', $searchable_fields ) ) {
613 613
 
614
-			$search_all_value = $trim_search_value ? trim( $get['gv_search'] ) : $get['gv_search'];
614
+			$search_all_value = $trim_search_value ? trim( $get[ 'gv_search' ] ) : $get[ 'gv_search' ];
615 615
 
616 616
 			if ( $split_words ) {
617 617
 				// Search for a piece
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
 			}
628 628
 
629 629
 			foreach ( $words as $word ) {
630
-				$search_criteria['field_filters'][] = array(
630
+				$search_criteria[ 'field_filters' ][ ] = array(
631 631
 					'key' => null, // The field ID to search
632 632
 					'value' => $word, // The value to search
633 633
 					'operator' => 'contains', // What to search in. Options: `is` or `contains`
@@ -640,14 +640,14 @@  discard block
 block discarded – undo
640 640
 			/**
641 641
 			 * Get and normalize the dates according to the input format.
642 642
 			 */
643
-			if ( $curr_start = ! empty( $get['gv_start'] ) ? $get['gv_start'] : '' ) {
644
-				if( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
643
+			if ( $curr_start = ! empty( $get[ 'gv_start' ] ) ? $get[ 'gv_start' ] : '' ) {
644
+				if ( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
645 645
 					$curr_start = $curr_start_date->format( 'Y-m-d' );
646 646
 				}
647 647
 			}
648 648
 
649
-			if ( $curr_end = ! empty( $get['gv_start'] ) ? ( ! empty( $get['gv_end'] ) ? $get['gv_end'] : '' ) : '' ) {
650
-				if( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
649
+			if ( $curr_end = ! empty( $get[ 'gv_start' ] ) ? ( ! empty( $get[ 'gv_end' ] ) ? $get[ 'gv_end' ] : '' ) : '' ) {
650
+				if ( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
651 651
 					$curr_end = $curr_end_date->format( 'Y-m-d' );
652 652
 				}
653 653
 			}
@@ -683,22 +683,22 @@  discard block
 block discarded – undo
683 683
 			 */
684 684
 			if ( ! empty( $curr_start ) ) {
685 685
 				$curr_start = date( 'Y-m-d H:i:s', strtotime( $curr_start ) );
686
-				$search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
686
+				$search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
687 687
 			}
688 688
 
689 689
 			if ( ! empty( $curr_end ) ) {
690 690
 				// Fast-forward 24 hour on the end time
691 691
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
692
-				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
693
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
694
-					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
692
+				$search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
693
+				if ( strpos( $search_criteria[ 'end_date' ], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
694
+					$search_criteria[ 'end_date' ] = date( 'Y-m-d H:i:s', strtotime( $search_criteria[ 'end_date' ] ) - 1 );
695 695
 				}
696 696
 			}
697 697
 		}
698 698
 
699 699
 		// search for a specific entry ID
700 700
 		if ( ! empty( $get[ 'gv_id' ] ) && in_array( 'entry_id', $searchable_fields ) ) {
701
-			$search_criteria['field_filters'][] = array(
701
+			$search_criteria[ 'field_filters' ][ ] = array(
702 702
 				'key' => 'id',
703 703
 				'value' => absint( $get[ 'gv_id' ] ),
704 704
 				'operator' => $this->get_operator( $get, 'gv_id', array( '=' ), '=' ),
@@ -707,15 +707,15 @@  discard block
 block discarded – undo
707 707
 
708 708
 		// search for a specific Created_by ID
709 709
 		if ( ! empty( $get[ 'gv_by' ] ) && in_array( 'created_by', $searchable_fields ) ) {
710
-			$search_criteria['field_filters'][] = array(
710
+			$search_criteria[ 'field_filters' ][ ] = array(
711 711
 				'key' => 'created_by',
712
-				'value' => $get['gv_by'],
712
+				'value' => $get[ 'gv_by' ],
713 713
 				'operator' => $this->get_operator( $get, 'gv_by', array( '=' ), '=' ),
714 714
 			);
715 715
 		}
716 716
 
717 717
 		// Get search mode passed in URL
718
-		$mode = isset( $get['mode'] ) && in_array( $get['mode'], array( 'any', 'all' ) ) ?  $get['mode'] : 'any';
718
+		$mode = isset( $get[ 'mode' ] ) && in_array( $get[ 'mode' ], array( 'any', 'all' ) ) ? $get[ 'mode' ] : 'any';
719 719
 
720 720
 		// get the other search filters
721 721
 		foreach ( $get as $key => $value ) {
@@ -724,7 +724,7 @@  discard block
 block discarded – undo
724 724
 				$value = is_array( $value ) ? array_map( 'trim', $value ) : trim( $value );
725 725
 			}
726 726
 
727
-			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[0], false, false ) ) ) {
727
+			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[ 0 ], false, false ) ) ) {
728 728
 				continue; // Not a filter, or empty
729 729
 			}
730 730
 
@@ -738,21 +738,21 @@  discard block
 block discarded – undo
738 738
 				continue;
739 739
 			}
740 740
 
741
-			if ( ! isset( $filter['operator'] ) ) {
742
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
741
+			if ( ! isset( $filter[ 'operator' ] ) ) {
742
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
743 743
 			}
744 744
 
745
-			if ( isset( $filter[0]['value'] ) ) {
746
-				$filter[0]['value'] = $trim_search_value ? trim( $filter[0]['value'] ) : $filter[0]['value'];
745
+			if ( isset( $filter[ 0 ][ 'value' ] ) ) {
746
+				$filter[ 0 ][ 'value' ] = $trim_search_value ? trim( $filter[ 0 ][ 'value' ] ) : $filter[ 0 ][ 'value' ];
747 747
 
748
-				$search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );
748
+				$search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );
749 749
 
750 750
 				// if date range type, set search mode to ALL
751
-				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>=', '<=', '>', '<' ) ) ) {
751
+				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>=', '<=', '>', '<' ) ) ) {
752 752
 					$mode = 'all';
753 753
 				}
754
-			} elseif( !empty( $filter ) ) {
755
-				$search_criteria['field_filters'][] = $filter;
754
+			} elseif ( ! empty( $filter ) ) {
755
+				$search_criteria[ 'field_filters' ][ ] = $filter;
756 756
 			}
757 757
 		}
758 758
 
@@ -761,7 +761,7 @@  discard block
 block discarded – undo
761 761
 		 * @since 1.5.1
762 762
 		 * @param[out,in] string $mode Search mode (`any` vs `all`)
763 763
 		 */
764
-		$search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );
764
+		$search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );
765 765
 
766 766
 		gravityview()->log->debug( 'Returned Search Criteria: ', array( 'data' => $search_criteria ) );
767 767
 
@@ -795,19 +795,19 @@  discard block
 block discarded – undo
795 795
 
796 796
 		$query_class = $view->get_query_class();
797 797
 
798
-		if ( empty( $search_criteria['field_filters'] ) ) {
798
+		if ( empty( $search_criteria[ 'field_filters' ] ) ) {
799 799
 			return;
800 800
 		}
801 801
 
802 802
 		$widgets = $view->widgets->by_id( $this->widget_id );
803 803
 		if ( $widgets->count() ) {
804 804
 			$widgets = $widgets->all();
805
-			$widget  = $widgets[0];
805
+			$widget  = $widgets[ 0 ];
806 806
 
807 807
 			$search_fields = json_decode( $widget->configuration->get( 'search_fields' ), true );
808 808
 
809
-			foreach ( (array) $search_fields as $search_field ) {
810
-				if ( 'created_by' === $search_field['field'] && 'input_text' === $search_field['input'] ) {
809
+			foreach ( (array)$search_fields as $search_field ) {
810
+				if ( 'created_by' === $search_field[ 'field' ] && 'input_text' === $search_field[ 'input' ] ) {
811 811
 					$created_by_text_mode = true;
812 812
 				}
813 813
 			}
@@ -816,7 +816,7 @@  discard block
 block discarded – undo
816 816
 		$extra_conditions = array();
817 817
 		$mode = 'any';
818 818
 
819
-		foreach ( $search_criteria['field_filters'] as &$filter ) {
819
+		foreach ( $search_criteria[ 'field_filters' ] as &$filter ) {
820 820
 			if ( ! is_array( $filter ) ) {
821 821
 				if ( in_array( strtolower( $filter ), array( 'any', 'all' ) ) ) {
822 822
 					$mode = $filter;
@@ -825,13 +825,13 @@  discard block
 block discarded – undo
825 825
 			}
826 826
 
827 827
 			// Construct a manual query for unapproved statuses
828
-			if ( 'is_approved' === $filter['key'] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array) $filter['value'] ) ) {
829
-				$_tmp_query       = new $query_class( $view->form->ID, array(
828
+			if ( 'is_approved' === $filter[ 'key' ] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array)$filter[ 'value' ] ) ) {
829
+				$_tmp_query = new $query_class( $view->form->ID, array(
830 830
 					'field_filters' => array(
831 831
 						array(
832 832
 							'operator' => 'in',
833 833
 							'key'      => 'is_approved',
834
-							'value'    => (array) $filter['value'],
834
+							'value'    => (array)$filter[ 'value' ],
835 835
 						),
836 836
 						array(
837 837
 							'operator' => 'is',
@@ -843,30 +843,30 @@  discard block
 block discarded – undo
843 843
 				) );
844 844
 				$_tmp_query_parts = $_tmp_query->_introspect();
845 845
 
846
-				$extra_conditions[] = $_tmp_query_parts['where'];
846
+				$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
847 847
 
848 848
 				$filter = false;
849 849
 				continue;
850 850
 			}
851 851
 
852 852
 			// Construct manual query for text mode creator search
853
-			if ( 'created_by' === $filter['key'] && ! empty( $created_by_text_mode ) ) {
854
-				$extra_conditions[] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
853
+			if ( 'created_by' === $filter[ 'key' ] && ! empty( $created_by_text_mode ) ) {
854
+				$extra_conditions[ ] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
855 855
 				$filter = false;
856 856
 				continue;
857 857
 			}
858 858
 
859 859
 			// By default, we want searches to be wildcard for each field.
860
-			$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
860
+			$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
861 861
 
862 862
 			// For multichoice, let's have an in (OR) search.
863
-			if ( is_array( $filter['value'] ) ) {
864
-				$filter['operator'] = 'in'; // @todo what about in contains (OR LIKE chains)?
863
+			if ( is_array( $filter[ 'value' ] ) ) {
864
+				$filter[ 'operator' ] = 'in'; // @todo what about in contains (OR LIKE chains)?
865 865
 			}
866 866
 
867 867
 			// Default form with joins functionality
868
-			if ( empty( $filter['form_id'] ) ) {
869
-				$filter['form_id'] = $view->form ? $view->form->ID : 0;
868
+			if ( empty( $filter[ 'form_id' ] ) ) {
869
+				$filter[ 'form_id' ] = $view->form ? $view->form->ID : 0;
870 870
 			}
871 871
 
872 872
 			/**
@@ -876,28 +876,28 @@  discard block
 block discarded – undo
876 876
 			 * @since develop
877 877
 			 * @param \GV\View $view The View we're operating on.
878 878
 			 */
879
-			$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter, $view );
879
+			$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter, $view );
880 880
 		}
881 881
 
882
-		if ( ! empty( $search_criteria['start_date'] ) || ! empty( $search_criteria['end_date'] ) ) {
882
+		if ( ! empty( $search_criteria[ 'start_date' ] ) || ! empty( $search_criteria[ 'end_date' ] ) ) {
883 883
 			$date_criteria = array();
884 884
 
885
-			if ( isset( $search_criteria['start_date'] ) ) {
886
-				$date_criteria['start_date'] = $search_criteria['start_date'];
885
+			if ( isset( $search_criteria[ 'start_date' ] ) ) {
886
+				$date_criteria[ 'start_date' ] = $search_criteria[ 'start_date' ];
887 887
 			}
888 888
 
889
-			if ( isset( $search_criteria['end_date'] ) ) {
890
-				$date_criteria['end_date'] = $search_criteria['end_date'];
889
+			if ( isset( $search_criteria[ 'end_date' ] ) ) {
890
+				$date_criteria[ 'end_date' ] = $search_criteria[ 'end_date' ];
891 891
 			}
892 892
 
893 893
 			$_tmp_query         = new $query_class( $view->form->ID, $date_criteria );
894 894
 			$_tmp_query_parts   = $_tmp_query->_introspect();
895
-			$extra_conditions[] = $_tmp_query_parts['where'];
895
+			$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
896 896
 		}
897 897
 
898 898
 		$search_conditions = array();
899 899
 
900
-		if ( $filters = array_filter( $search_criteria['field_filters'] ) ) {
900
+		if ( $filters = array_filter( $search_criteria[ 'field_filters' ] ) ) {
901 901
 			foreach ( $filters as &$filter ) {
902 902
 				if ( ! is_array( $filter ) ) {
903 903
 					continue;
@@ -909,12 +909,12 @@  discard block
 block discarded – undo
909 909
 				 * code by reusing what's inside GF_Query already as they
910 910
 				 * take care of many small things like forcing numeric, etc.
911 911
 				 */
912
-				$_tmp_query       = new $query_class( $filter['form_id'], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
912
+				$_tmp_query       = new $query_class( $filter[ 'form_id' ], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
913 913
 				$_tmp_query_parts = $_tmp_query->_introspect();
914
-				$search_condition = $_tmp_query_parts['where'];
914
+				$search_condition = $_tmp_query_parts[ 'where' ];
915 915
 
916
-				if ( empty( $filter['key'] ) && $search_condition->expressions ) {
917
-					$search_conditions[] = $search_condition;
916
+				if ( empty( $filter[ 'key' ] ) && $search_condition->expressions ) {
917
+					$search_conditions[ ] = $search_condition;
918 918
 				} else {
919 919
 					$left = $search_condition->left;
920 920
 					$alias = $query->_alias( $left->field_id, $left->source, $left->is_entry_column() ? 't' : 'm' );
@@ -924,7 +924,7 @@  discard block
 block discarded – undo
924 924
 							$on = $_join->join_on;
925 925
 							$join = $_join->join;
926 926
 
927
-							$search_conditions[] = GF_Query_Condition::_or(
927
+							$search_conditions[ ] = GF_Query_Condition::_or(
928 928
 								// Join
929 929
 								new GF_Query_Condition(
930 930
 									new GF_Query_Column( GF_Query_Column::META, $join->ID, $query->_alias( GF_Query_Column::META, $join->ID, 'm' ) ),
@@ -940,7 +940,7 @@  discard block
 block discarded – undo
940 940
 							);
941 941
 						}
942 942
 					} else {
943
-						$search_conditions[] = new GF_Query_Condition(
943
+						$search_conditions[ ] = new GF_Query_Condition(
944 944
 							new GF_Query_Column( $left->field_id, $left->source, $alias ),
945 945
 							$search_condition->operator,
946 946
 							$search_condition->right
@@ -962,7 +962,7 @@  discard block
 block discarded – undo
962 962
 		/**
963 963
 		 * Combine the parts as a new WHERE clause.
964 964
 		 */
965
-		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts['where'] ), $search_conditions, $extra_conditions ) );
965
+		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts[ 'where' ] ), $search_conditions, $extra_conditions ) );
966 966
 		$query->where( $where );
967 967
 	}
968 968
 
@@ -985,7 +985,7 @@  discard block
 block discarded – undo
985 985
 		$field_id = str_replace( 'filter_', '', $key );
986 986
 
987 987
 		// calculates field_id, removing 'filter_' and for '_' for advanced fields ( like name or checkbox )
988
-		if ( preg_match('/^[0-9_]+$/ism', $field_id ) ) {
988
+		if ( preg_match( '/^[0-9_]+$/ism', $field_id ) ) {
989 989
 			$field_id = str_replace( '_', '.', $field_id );
990 990
 		}
991 991
 
@@ -1042,7 +1042,7 @@  discard block
 block discarded – undo
1042 1042
 			// form is in searchable fields
1043 1043
 			$found = false;
1044 1044
 			foreach ( $searchable_fields as $field ) {
1045
-				if ( $field_id == $field['field'] && $form->ID == $field['form_id'] ) {
1045
+				if ( $field_id == $field[ 'field' ] && $form->ID == $field[ 'form_id' ] ) {
1046 1046
 					$found = true;
1047 1047
 					break;
1048 1048
 				}
@@ -1082,7 +1082,7 @@  discard block
 block discarded – undo
1082 1082
 
1083 1083
 			case 'select':
1084 1084
 			case 'radio':
1085
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1085
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1086 1086
 				break;
1087 1087
 
1088 1088
 			case 'post_category':
@@ -1096,7 +1096,7 @@  discard block
 block discarded – undo
1096 1096
 
1097 1097
 				foreach ( $value as $val ) {
1098 1098
 					$cat = get_term( $val, 'category' );
1099
-					$filter[] = array(
1099
+					$filter[ ] = array(
1100 1100
 						'key'      => $field_id,
1101 1101
 						'value'    => esc_attr( $cat->name ) . ':' . $val,
1102 1102
 						'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1115,7 +1115,7 @@  discard block
 block discarded – undo
1115 1115
 				$filter = array();
1116 1116
 
1117 1117
 				foreach ( $value as $val ) {
1118
-					$filter[] = array( 'key' => $field_id, 'value' => $val );
1118
+					$filter[ ] = array( 'key' => $field_id, 'value' => $val );
1119 1119
 				}
1120 1120
 
1121 1121
 				break;
@@ -1124,9 +1124,9 @@  discard block
 block discarded – undo
1124 1124
 				// convert checkbox on/off into the correct search filter
1125 1125
 				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field->inputs ) && ! empty( $form_field->choices ) ) {
1126 1126
 					foreach ( $form_field->inputs as $k => $input ) {
1127
-						if ( $input['id'] == $field_id ) {
1128
-							$filter['value'] = $form_field->choices[ $k ]['value'];
1129
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1127
+						if ( $input[ 'id' ] == $field_id ) {
1128
+							$filter[ 'value' ] = $form_field->choices[ $k ][ 'value' ];
1129
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1130 1130
 							break;
1131 1131
 						}
1132 1132
 					}
@@ -1136,7 +1136,7 @@  discard block
 block discarded – undo
1136 1136
 					$filter = array();
1137 1137
 
1138 1138
 					foreach ( $value as $val ) {
1139
-						$filter[] = array(
1139
+						$filter[ ] = array(
1140 1140
 							'key'      => $field_id,
1141 1141
 							'value'    => $val,
1142 1142
 							'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1157,9 +1157,9 @@  discard block
 block discarded – undo
1157 1157
 					foreach ( $words as $word ) {
1158 1158
 						if ( ! empty( $word ) && strlen( $word ) > 1 ) {
1159 1159
 							// Keep the same key for each filter
1160
-							$filter['value'] = $word;
1160
+							$filter[ 'value' ] = $word;
1161 1161
 							// Add a search for the value
1162
-							$filters[] = $filter;
1162
+							$filters[ ] = $filter;
1163 1163
 						}
1164 1164
 					}
1165 1165
 
@@ -1173,19 +1173,19 @@  discard block
 block discarded – undo
1173 1173
 
1174 1174
 					foreach ( $searchable_fields as $searchable_field ) {
1175 1175
 
1176
-						if( $form_field->ID !== $searchable_field['field'] ) {
1176
+						if ( $form_field->ID !== $searchable_field[ 'field' ] ) {
1177 1177
 							continue;
1178 1178
 						}
1179 1179
 
1180 1180
 						// Only exact-match dropdowns, not text search
1181
-						if( in_array( $searchable_field['input'], array( 'text', 'search' ), true ) ) {
1181
+						if ( in_array( $searchable_field[ 'input' ], array( 'text', 'search' ), true ) ) {
1182 1182
 							continue;
1183 1183
 						}
1184 1184
 
1185 1185
 						$input_id = gravityview_get_input_id_from_id( $form_field->ID );
1186 1186
 
1187 1187
 						if ( 4 === $input_id ) {
1188
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1188
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1189 1189
 						};
1190 1190
 					}
1191 1191
 				}
@@ -1213,12 +1213,12 @@  discard block
 block discarded – undo
1213 1213
 						 * @since 1.16.3
1214 1214
 						 * Safeguard until GF implements '<=' operator
1215 1215
 						 */
1216
-						if( !GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1216
+						if ( ! GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1217 1217
 							$operator = '<';
1218 1218
 							$date = date( 'Y-m-d', strtotime( self::get_formatted_date( $date, 'Y-m-d', $date_format ) . ' +1 day' ) );
1219 1219
 						}
1220 1220
 
1221
-						$filter[] = array(
1221
+						$filter[ ] = array(
1222 1222
 							'key'      => $field_id,
1223 1223
 							'value'    => self::get_formatted_date( $date, 'Y-m-d', $date_format ),
1224 1224
 							'operator' => $this->get_operator( $get, $key, array( $operator ), $operator ),
@@ -1226,12 +1226,12 @@  discard block
 block discarded – undo
1226 1226
 					}
1227 1227
 				} else {
1228 1228
 					$date = $value;
1229
-					$filter['value'] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1230
-					$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1229
+					$filter[ 'value' ] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1230
+					$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1231 1231
 				}
1232 1232
 
1233
-				if ('payment_date' === $key) {
1234
-					$filter['operator'] = 'contains';
1233
+				if ( 'payment_date' === $key ) {
1234
+					$filter[ 'operator' ] = 'contains';
1235 1235
 				}
1236 1236
 
1237 1237
 				break;
@@ -1260,7 +1260,7 @@  discard block
 block discarded – undo
1260 1260
 			'ymd_dot' => 'Y.m.d',
1261 1261
 		);
1262 1262
 
1263
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
1263
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
1264 1264
 			$format = $datepicker[ $field->dateFormat ];
1265 1265
 		}
1266 1266
 
@@ -1297,7 +1297,7 @@  discard block
 block discarded – undo
1297 1297
 	public function add_template_path( $file_paths ) {
1298 1298
 
1299 1299
 		// Index 100 is the default GravityView template path.
1300
-		$file_paths[102] = self::$file . 'templates/';
1300
+		$file_paths[ 102 ] = self::$file . 'templates/';
1301 1301
 
1302 1302
 		return $file_paths;
1303 1303
 	}
@@ -1316,7 +1316,7 @@  discard block
 block discarded – undo
1316 1316
 		$has_date = false;
1317 1317
 
1318 1318
 		foreach ( $search_fields as $k => $field ) {
1319
-			if ( in_array( $field['input'], array( 'date', 'date_range', 'entry_date' ) ) ) {
1319
+			if ( in_array( $field[ 'input' ], array( 'date', 'date_range', 'entry_date' ) ) ) {
1320 1320
 				$has_date = true;
1321 1321
 				break;
1322 1322
 			}
@@ -1345,7 +1345,7 @@  discard block
 block discarded – undo
1345 1345
 		$view = \GV\View::by_id( $gravityview_view->view_id );
1346 1346
 
1347 1347
 		// get configured search fields
1348
-		$search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';
1348
+		$search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';
1349 1349
 
1350 1350
 		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) {
1351 1351
 			gravityview()->log->debug( 'No search fields configured for widget:', array( 'data' => $widget_args ) );
@@ -1359,40 +1359,40 @@  discard block
 block discarded – undo
1359 1359
 
1360 1360
 			$updated_field = $this->get_search_filter_details( $updated_field, $context );
1361 1361
 
1362
-			switch ( $field['field'] ) {
1362
+			switch ( $field[ 'field' ] ) {
1363 1363
 
1364 1364
 				case 'search_all':
1365
-					$updated_field['key'] = 'search_all';
1366
-					$updated_field['input'] = 'search_all';
1367
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_search' );
1365
+					$updated_field[ 'key' ] = 'search_all';
1366
+					$updated_field[ 'input' ] = 'search_all';
1367
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_search' );
1368 1368
 					break;
1369 1369
 
1370 1370
 				case 'entry_date':
1371
-					$updated_field['key'] = 'entry_date';
1372
-					$updated_field['input'] = 'entry_date';
1373
-					$updated_field['value'] = array(
1371
+					$updated_field[ 'key' ] = 'entry_date';
1372
+					$updated_field[ 'input' ] = 'entry_date';
1373
+					$updated_field[ 'value' ] = array(
1374 1374
 						'start' => $this->rgget_or_rgpost( 'gv_start' ),
1375 1375
 						'end' => $this->rgget_or_rgpost( 'gv_end' ),
1376 1376
 					);
1377 1377
 					break;
1378 1378
 
1379 1379
 				case 'entry_id':
1380
-					$updated_field['key'] = 'entry_id';
1381
-					$updated_field['input'] = 'entry_id';
1382
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_id' );
1380
+					$updated_field[ 'key' ] = 'entry_id';
1381
+					$updated_field[ 'input' ] = 'entry_id';
1382
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_id' );
1383 1383
 					break;
1384 1384
 
1385 1385
 				case 'created_by':
1386
-					$updated_field['key'] = 'created_by';
1387
-					$updated_field['name'] = 'gv_by';
1388
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_by' );
1389
-					$updated_field['choices'] = self::get_created_by_choices( $view );
1386
+					$updated_field[ 'key' ] = 'created_by';
1387
+					$updated_field[ 'name' ] = 'gv_by';
1388
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_by' );
1389
+					$updated_field[ 'choices' ] = self::get_created_by_choices( $view );
1390 1390
 					break;
1391 1391
 
1392 1392
 				case 'is_approved':
1393
-					$updated_field['key'] = 'is_approved';
1394
-					$updated_field['value'] = $this->rgget_or_rgpost( 'filter_is_approved' );
1395
-					$updated_field['choices'] = self::get_is_approved_choices();
1393
+					$updated_field[ 'key' ] = 'is_approved';
1394
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'filter_is_approved' );
1395
+					$updated_field[ 'choices' ] = self::get_is_approved_choices();
1396 1396
 					break;
1397 1397
 			}
1398 1398
 
@@ -1413,16 +1413,16 @@  discard block
 block discarded – undo
1413 1413
 
1414 1414
 		$gravityview_view->permalink_fields = $this->add_no_permalink_fields( array(), $this, $widget_args );
1415 1415
 
1416
-		$gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';
1416
+		$gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';
1417 1417
 
1418 1418
 		/** @since 1.14 */
1419
-		$gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';
1419
+		$gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';
1420 1420
 
1421
-		$custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';
1421
+		$custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';
1422 1422
 
1423 1423
 		$gravityview_view->search_class = self::get_search_class( $custom_class );
1424 1424
 
1425
-		$gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;
1425
+		$gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;
1426 1426
 
1427 1427
 		if ( $this->has_date_field( $search_fields ) ) {
1428 1428
 			// enqueue datepicker stuff only if needed!
@@ -1444,10 +1444,10 @@  discard block
 block discarded – undo
1444 1444
 	public static function get_search_class( $custom_class = '' ) {
1445 1445
 		$gravityview_view = GravityView_View::getInstance();
1446 1446
 
1447
-		$search_class = 'gv-search-'.$gravityview_view->search_layout;
1447
+		$search_class = 'gv-search-' . $gravityview_view->search_layout;
1448 1448
 
1449
-		if ( ! empty( $custom_class )  ) {
1450
-			$search_class .= ' '.$custom_class;
1449
+		if ( ! empty( $custom_class ) ) {
1450
+			$search_class .= ' ' . $custom_class;
1451 1451
 		}
1452 1452
 
1453 1453
 		/**
@@ -1498,9 +1498,9 @@  discard block
 block discarded – undo
1498 1498
 
1499 1499
 		if ( ! $label ) {
1500 1500
 
1501
-			$label = isset( $form_field['label'] ) ? $form_field['label'] : '';
1501
+			$label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';
1502 1502
 
1503
-			switch( $field['field'] ) {
1503
+			switch ( $field[ 'field' ] ) {
1504 1504
 				case 'search_all':
1505 1505
 					$label = __( 'Search Entries:', 'gravityview' );
1506 1506
 					break;
@@ -1512,10 +1512,10 @@  discard block
 block discarded – undo
1512 1512
 					break;
1513 1513
 				default:
1514 1514
 					// If this is a field input, not a field
1515
-					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) {
1515
+					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) {
1516 1516
 
1517 1517
 						// Get the label for the field in question, which returns an array
1518
-						$items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );
1518
+						$items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );
1519 1519
 
1520 1520
 						// Get the item with the `label` key
1521 1521
 						$values = wp_list_pluck( $items, 'label' );
@@ -1556,13 +1556,13 @@  discard block
 block discarded – undo
1556 1556
 		$form = $gravityview_view->getForm();
1557 1557
 
1558 1558
 		// for advanced field ids (eg, first name / last name )
1559
-		$name = 'filter_' . str_replace( '.', '_', $field['field'] );
1559
+		$name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );
1560 1560
 
1561 1561
 		// get searched value from $_GET/$_POST (string or array)
1562 1562
 		$value = $this->rgget_or_rgpost( $name );
1563 1563
 
1564 1564
 		// get form field details
1565
-		$form_field = gravityview_get_field( $form, $field['field'] );
1565
+		$form_field = gravityview_get_field( $form, $field[ 'field' ] );
1566 1566
 
1567 1567
 		$form_field_type = \GV\Utils::get( $form_field, 'type' );
1568 1568
 
@@ -1576,17 +1576,17 @@  discard block
 block discarded – undo
1576 1576
 		);
1577 1577
 
1578 1578
 		// collect choices
1579
-		if ( 'post_category' === $form_field_type && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) {
1580
-			$filter['choices'] = gravityview_get_terms_choices();
1581
-		} elseif ( ! empty( $form_field['choices'] ) ) {
1582
-			$filter['choices'] = $form_field['choices'];
1579
+		if ( 'post_category' === $form_field_type && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) {
1580
+			$filter[ 'choices' ] = gravityview_get_terms_choices();
1581
+		} elseif ( ! empty( $form_field[ 'choices' ] ) ) {
1582
+			$filter[ 'choices' ] = $form_field[ 'choices' ];
1583 1583
 		}
1584 1584
 
1585
-		if ( 'date_range' === $field['input'] && empty( $value ) ) {
1586
-			$filter['value'] = array( 'start' => '', 'end' => '' );
1585
+		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) {
1586
+			$filter[ 'value' ] = array( 'start' => '', 'end' => '' );
1587 1587
 		}
1588 1588
 
1589
-		if ( ! empty( $filter['choices'] ) ) {
1589
+		if ( ! empty( $filter[ 'choices' ] ) ) {
1590 1590
 			/**
1591 1591
 			 * @filter `gravityview/search/sieve_choices` Only output used choices for this field.
1592 1592
 			 * @param[in,out] bool Yes or no.
@@ -1594,7 +1594,7 @@  discard block
 block discarded – undo
1594 1594
 			 * @param \GV\Context The context.
1595 1595
 			 */
1596 1596
 			if ( apply_filters( 'gravityview/search/sieve_choices', false, $field, $context ) ) {
1597
-				$filter['choices'] = $this->sieve_filter_choices( $filter, $context );
1597
+				$filter[ 'choices' ] = $this->sieve_filter_choices( $filter, $context );
1598 1598
 			}
1599 1599
 		}
1600 1600
 
@@ -1623,11 +1623,11 @@  discard block
 block discarded – undo
1623 1623
 	 * @return array The filter choices.
1624 1624
 	 */
1625 1625
 	private function sieve_filter_choices( $filter, $context ) {
1626
-		if ( empty( $filter['key'] ) || empty( $filter['choices'] ) ) {
1626
+		if ( empty( $filter[ 'key' ] ) || empty( $filter[ 'choices' ] ) ) {
1627 1627
 			return $filter; // @todo Populate plugins might give us empty choices
1628 1628
 		}
1629 1629
 
1630
-		if ( ! is_numeric( $filter['key'] ) ) {
1630
+		if ( ! is_numeric( $filter[ 'key' ] ) ) {
1631 1631
 			return $filter;
1632 1632
 		}
1633 1633
 
@@ -1637,29 +1637,29 @@  discard block
 block discarded – undo
1637 1637
 
1638 1638
 		$table = GFFormsModel::get_entry_meta_table_name();
1639 1639
 
1640
-		$key_like = $wpdb->esc_like( $filter['key'] ) . '.%';
1640
+		$key_like = $wpdb->esc_like( $filter[ 'key' ] ) . '.%';
1641 1641
 
1642 1642
 		switch ( \GV\Utils::get( $filter, 'type' ) ):
1643 1643
 			case 'post_category':
1644 1644
 				$choices = $wpdb->get_col( $wpdb->prepare(
1645 1645
 					"SELECT DISTINCT SUBSTRING_INDEX(meta_value, ':', 1) FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1646
-					$key_like, $filter['key'], $form_id
1646
+					$key_like, $filter[ 'key' ], $form_id
1647 1647
 				) );
1648 1648
 				break;
1649 1649
 			default:
1650 1650
 				$choices = $wpdb->get_col( $wpdb->prepare(
1651 1651
 					"SELECT DISTINCT meta_value FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1652
-					$key_like, $filter['key'], $form_id
1652
+					$key_like, $filter[ 'key' ], $form_id
1653 1653
 				) );
1654 1654
 
1655
-				if ( ( $field = gravityview_get_field( $form_id, $filter['key'] ) ) && 'json' === $field->storageType ) {
1655
+				if ( ( $field = gravityview_get_field( $form_id, $filter[ 'key' ] ) ) && 'json' === $field->storageType ) {
1656 1656
 					$choices = array_map( 'json_decode', $choices );
1657 1657
 					$_choices_array = array();
1658 1658
 					foreach ( $choices as $choice ) {
1659 1659
 						if ( is_array( $choice ) ) {
1660 1660
 							$_choices_array = array_merge( $_choices_array, $choice );
1661 1661
 						} else {
1662
-							$_choices_array []= $choice;
1662
+							$_choices_array [ ] = $choice;
1663 1663
 						}
1664 1664
 					}
1665 1665
 					$choices = array_unique( $_choices_array );
@@ -1669,9 +1669,9 @@  discard block
 block discarded – undo
1669 1669
 		endswitch;
1670 1670
 
1671 1671
 		$filter_choices = array();
1672
-		foreach ( $filter['choices'] as $choice ) {
1673
-			if ( in_array( $choice['text'], $choices, true ) || in_array( $choice['value'], $choices, true ) ) {
1674
-				$filter_choices[] = $choice;
1672
+		foreach ( $filter[ 'choices' ] as $choice ) {
1673
+			if ( in_array( $choice[ 'text' ], $choices, true ) || in_array( $choice[ 'value' ], $choices, true ) ) {
1674
+				$filter_choices[ ] = $choice;
1675 1675
 			}
1676 1676
 		}
1677 1677
 
@@ -1706,7 +1706,7 @@  discard block
 block discarded – undo
1706 1706
 			 * @param \GV\View $view The view.
1707 1707
 			 */
1708 1708
 			$text = apply_filters( 'gravityview/search/created_by/text', $user->display_name, $user, $view );
1709
-			$choices[] = array(
1709
+			$choices[ ] = array(
1710 1710
 				'value' => $user->ID,
1711 1711
 				'text' => $text,
1712 1712
 			);
@@ -1726,9 +1726,9 @@  discard block
 block discarded – undo
1726 1726
 
1727 1727
 		$choices = array();
1728 1728
 		foreach ( GravityView_Entry_Approval_Status::get_all() as $status ) {
1729
-			$choices[] = array(
1730
-				'value' => $status['value'],
1731
-				'text' => $status['label'],
1729
+			$choices[ ] = array(
1730
+				'value' => $status[ 'value' ],
1731
+				'text' => $status[ 'label' ],
1732 1732
 			);
1733 1733
 		}
1734 1734
 
@@ -1780,7 +1780,7 @@  discard block
 block discarded – undo
1780 1780
 	 */
1781 1781
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1782 1782
 
1783
-		$js_dependencies[] = 'jquery-ui-datepicker';
1783
+		$js_dependencies[ ] = 'jquery-ui-datepicker';
1784 1784
 
1785 1785
 		return $js_dependencies;
1786 1786
 	}
@@ -1824,7 +1824,7 @@  discard block
 block discarded – undo
1824 1824
 			'isRTL'             => is_rtl(),
1825 1825
 		), $view_data );
1826 1826
 
1827
-		$localizations['datepicker'] = $datepicker_settings;
1827
+		$localizations[ 'datepicker' ] = $datepicker_settings;
1828 1828
 
1829 1829
 		return $localizations;
1830 1830
 
@@ -1851,7 +1851,7 @@  discard block
 block discarded – undo
1851 1851
 	 * @return void
1852 1852
 	 */
1853 1853
 	private function maybe_enqueue_flexibility() {
1854
-		if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && preg_match( '/MSIE [8-9]/', $_SERVER['HTTP_USER_AGENT'] ) ) {
1854
+		if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) && preg_match( '/MSIE [8-9]/', $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
1855 1855
 			wp_enqueue_script( 'gv-flexibility' );
1856 1856
 		}
1857 1857
 	}
@@ -1873,7 +1873,7 @@  discard block
 block discarded – undo
1873 1873
 		add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );
1874 1874
 
1875 1875
 		$scheme = is_ssl() ? 'https://' : 'http://';
1876
-		wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1876
+		wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1877 1877
 
1878 1878
 		/**
1879 1879
 		 * @filter `gravityview_search_datepicker_class`
@@ -1952,7 +1952,7 @@  discard block
 block discarded – undo
1952 1952
 	public function add_preview_inputs() {
1953 1953
 		global $wp;
1954 1954
 
1955
-		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews') ) {
1955
+		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews' ) ) {
1956 1956
 			return;
1957 1957
 		}
1958 1958
 
@@ -2004,7 +2004,7 @@  discard block
 block discarded – undo
2004 2004
  */
2005 2005
 class GravityView_Widget_Search_Author_GF_Query_Condition extends \GF_Query_Condition {
2006 2006
 	public function __construct( $filter, $view ) {
2007
-		$this->value = $filter['value'];
2007
+		$this->value = $filter[ 'value' ];
2008 2008
 		$this->view = $view;
2009 2009
 	}
2010 2010
 
@@ -2036,11 +2036,11 @@  discard block
 block discarded – undo
2036 2036
 		$conditions = array();
2037 2037
 
2038 2038
 		foreach ( $user_fields as $user_field ) {
2039
-			$conditions[] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) .  '%' );
2039
+			$conditions[ ] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );
2040 2040
 		}
2041 2041
 
2042 2042
 		foreach ( $user_meta_fields as $meta_field ) {
2043
-			$conditions[] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) .  '%' );
2043
+			$conditions[ ] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );
2044 2044
 		}
2045 2045
 
2046 2046
 		$conditions = '(' . implode( ' OR ', $conditions ) . ')';
Please login to merge, or discard this patch.