grandrew / taskjuggler-python

taskjuggler_python/jsonjuggler.py

# json parser implementation
from juggler import *

The usage of wildcard imports like juggler should generally be avoided.

JugglerSimpleProperty was imported with wildcard, but is not used.

JugglerTimesheet was imported with wildcard, but is not used.

JugglerTaskProperty was imported with wildcard, but is not used.

is_number was imported with wildcard, but is not used.

DEFAULT_OUTPUT was imported with wildcard, but is not used.

os was imported with wildcard, but is not used.

set_logging_level was imported with wildcard, but is not used.

to_tj3interval was imported with wildcard, but is not used.

JugglerCompoundKeyword was imported with wildcard, but is not used.

JugglerOutputdir was imported with wildcard, but is not used.

icalendar was imported with wildcard, but is not used.

TAB was imported with wildcard, but is not used.

JugglerTimezone was imported with wildcard, but is not used.

to_tj3time was imported with wildcard, but is not used.

shutil was imported with wildcard, but is not used.

logging was imported with wildcard, but is not used.

subprocess was imported with wildcard, but is not used.

tempfile was imported with wildcard, but is not used.

datetime was imported with wildcard, but is not used.

DEFAULT_LOGLEVEL was imported with wildcard, but is not used.

to_identifier was imported with wildcard, but is not used.

from_identifier was imported with wildcard, but is not used.

TJP_DASH_PREFIX was imported with wildcard, but is not used.

TJP_NUM_ID_PREFIX was imported with wildcard, but is not used.

TJP_SPACE_PREFIX was imported with wildcard, but is not used.

OrderedDict was imported with wildcard, but is not used.

DEBUG was imported with wildcard, but is not used.

JugglerWorkingHours was imported with wildcard, but is not used.

import json, re, math

Multiple imports on one line (json, re, math)

standard import "import json, re, math" should be placed before "from juggler import *"

import dateutil.parser

third party import "import dateutil.parser" should be placed before "from juggler import *"

class DictJugglerTaskDepends(JugglerTaskDepends):
    def load_from_issue(self, issue):
        """
        Args:
            issue["depends"] - a list of identifiers that this task depends on
        """
        if "depends" in issue: 

Trailing whitespace

            # TODO HERE: remove ID normalization!
            if isinstance(issue["depends"], str) or isinstance(issue['depends'], unicode):

Consider merging these isinstance calls to isinstance(issue['depends'], (str, unicode))

Undefined variable 'unicode'

                self.set_value([int(x) for x in re.findall(r"[\w']+", issue["depends"])])
            # TODO check for list, else add idfr
            else: self.set_value([int(x) for x in issue["depends"]])

class DictJugglerTaskPriority(JugglerTaskPriority):
    def load_from_issue(self, issue):
        if "priority" in issue: self.set_value(int(issue["priority"]))

More than one statement on a single line

Trailing whitespace

class DictJugglerTaskStart(JugglerTaskStart):
    def load_from_issue(self, issue):
        if "start" in issue: 

Trailing whitespace

            if isinstance(issue["start"], str) or isinstance(issue['start'], unicode):

Consider merging these isinstance calls to isinstance(issue['start'], (str, unicode))

Undefined variable 'unicode'

                self.set_value(dateutil.parser.parse(issue["start"]))
            else:
                self.set_value(issue["start"])
        

Trailing whitespace

class DictJugglerTaskEffort(JugglerTaskEffort):
    UNIT = "h"
    def load_from_issue(self, issue):
        if "effort" in issue: self.set_value(math.ceil(issue["effort"]))

More than one statement on a single line

class DictJugglerTaskAllocate(JugglerTaskAllocate):
    def load_from_issue(self, issue):

Signature differs from overridden 'load_from_issue' method

        if "allocate" in issue: alloc = issue["allocate"]

More than one statement on a single line

        else: alloc = "me" # stub!
        self.set_value(alloc) 

Trailing whitespace

        src.walk(JugglerSource)[0].set_property(DictJugglerResource(issue))

class DictJugglerTask(JugglerTask):
    def load_default_properties(self, issue):

Signature differs from overridden 'load_default_properties' method

        self.set_property(DictJugglerTaskDepends(issue))
        self.set_property(DictJugglerTaskEffort(issue))
        self.set_property(DictJugglerTaskAllocate(issue))
        self.set_property(DictJugglerTaskStart(issue))
        self.set_property(DictJugglerTaskPriority(issue))
    def load_from_issue(self, issue):
        self.set_id(issue["id"])
        if "summary" in issue: self.summary = issue["summary"]

More than one statement on a single line

class DictJuggler(GenericJuggler):

The method __inter__ which was declared abstract in the super-class GenericJuggler
was not overridden.

    """ a simple dictionary based format parser """
    def __init__(self, issues):

The __init__ method of the super-class GenericJuggler is not called.

        self.issues = issues
    def load_issues(self):
        return self.issues
    def create_task_instance(self, issue):
        return DictJugglerTask(issue)
    def create_jugglersource_instance(self):
        global src

Global variable 'src' undefined at the module level

        src = DictJugglerSource()
        return src

class DictJugglerSource(JugglerSource):
    def load_default_properties(self, issue = None):

No space allowed around keyword argument assignment

        self.set_property(JugglerProject())
        # self.set_property(DictJugglerResource()) # define no resource
        self.set_property(JugglerIcalreport())
        

Trailing whitespace

class DictJugglerResource(JugglerResource):
    def load_from_issue(self, issue):
        if "allocate" in issue:
            self.set_id(issue["allocate"])
            self.set_value(issue["allocate"])

class JsonJuggler(DictJuggler):

The method __inter__ which was declared abstract in the super-class GenericJuggler
was not overridden.

    def __init__(self, json_issues):

The __init__ method of the super-class DictJuggler is not called.

        self.issues = json.loads(json_issues)
    def toJSON(self):
        for t in self.walk(JugglerTask):
            for i in self.issues:
                if t.get_id() == i["id"]:
                    i["booking"] = t.walk(JugglerBooking)[0].decode()[0].isoformat()
        return json.dumps(self.issues, sort_keys=True, indent=4, separators=(',', ': '))

Trailing newlines