Gr8abbasi\Container\Factory\JsonServiceFactory

Complexity

Total Complexity

7

Size/Duplication

Total Lines	69
Duplicated Lines	23.19 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	loadJsonFile()	0	5	1
A	loadServiceList()	0	8	2
A	create()	16	16	3

<?php

namespace Gr8abbasi\Container\Factory;

use Gr8abbasi\Container\Exception\NotFoundException;
use Gr8abbasi\Container\Exception\ContainerException;

/**
 * Class JsonServiceFactory
 */
class JsonServiceFactory implements ServiceFactoryInterface
{
    /**
     * @var array $services
     */
    private $services;

    /**
     * @var array $serviceList
     */
    private $serviceList;

    /**
     * Constructor
     *
     * @param string $jsonFile
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($jsonFile)
    {
        $this->services = $this->loadServiceList($jsonFile);

It seems like $this->loadServiceList($jsonFile) of type null is incompatible with the declared type array of property $services.

Are you sure the assignment to $this->services is correct as $this->loadServiceList($jsonFile) (which targets Gr8abbasi\Container\Factory\JsonServiceFactory::loadServiceList()) seems to always return null.

    }

    /**
     * @param string $jsonFile
     *
     * @return array
     */
    private function loadJsonFile($jsonFile)
    {
        $jsonString = file_get_contents($jsonFile);
        return json_decode($jsonString);
    }

    /**
     * @param string $jsonFile
     *
     * @return void
     */
    private function loadServiceList($jsonFile)
    {
       $services =  $this->loadJsonFile($jsonFile);

       foreach($services->services as $service) {
           $this->serviceList[$service->id] = $service;
       }
    }

    /**
     * @inheritdoc
     */
    public function create($service)

This method seems to be duplicated in your project.

    {
        if(!isset($this->serviceList[$service])) {
            throw new NotFoundException('Service not found: ' . $service);
        }

        if (!class_exists($this->serviceList[$service]->class)) {
            throw new ContainerException(
                'Class does not exists: ' . $this->serviceList[$service]->class
            );
        }

        $service = new \ReflectionClass($this->serviceList[$service]->class);
        return $service->newInstance();

    }
}