Gr8abbasi\Container\Container

Complexity

Total Complexity

10

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	get()	0	12	3
A	has()	0	4	1
A	createService()	0	17	4

<?php

namespace Gr8abbasi\Container;

use Interop\Container\ContainerInterface;
use Gr8abbasi\Container\Exception\NotFoundException;
use Gr8abbasi\Container\Exception\ContainerException;
use Gr8abbasi\Container\Repository\InMemoryServiceRepository;
use Gr8abbasi\Container\Factory\ConfigFileServiceFactory;

/**
 * Container Class
 */
class Container implements ContainerInterface
{
    /**
     * @var array
     */
    private $services;

    /**
     * @var array
     */
    private $serviceStore;

    /**
     * @var ServiceRepositoryInterface
     */
    private $repository;

    /**
     * @var ServiceFactoryInterface
     */
    private $factory;

The property $factory is not used and could be removed.

    /**
     * Constructor for Container
     *
     * @param array $services
     */
    public function __construct(
        array $services = [],
        ServiceRepositoryInterface $repository = null,
        ServiceFactoryInterface $factory = null

The parameter $factory is not used and could be removed.

    ) {
        $this->services = $services;
        $this->serviceStore = [];
        $this->repository = $repository ?: new InMemoryServiceRepository();

It seems like $repository ?: new \Gr8abbasi\Container\Repository\InMemoryServiceRepository() can also be of type object<Gr8abbasi\Container\Repository\InMemoryServiceRepository>. However, the property $repository is declared as type object<Gr8abbasi\Container\ServiceRepositoryInterface>. Maybe add an additional type check?

        // $this->factory = $factory ?: new ConfigFileServiceFactory();
    }

    /**
     * {@inheritdoc}
     */
    public function get($name)
    {
        if (!$this->has($name)) {
            throw new NotFoundException('Service not found: ' . $name);
        }

        if (!isset($this->serviceStore[$name])) {
            $this->serviceStore[$name] = $this->createService($name);
        }

        return $this->serviceStore[$name];
    }

    /**
     * {@inheritdoc}
     */
    public function has($name)
    {
        return isset($this->services[$name]);
    }

    /**
     * Create service instance
     *
     * @param string $name
     *
     * @return mixed created service
     */
    private function createService($name)
    {
        if (!isset($this->services[$name]) || empty($this->services[$name])) {
            throw new ContainerException(
                'Service should be an array with key value pair: ' . $name
            );
        }

        if (!class_exists($this->services[$name]['class'])) {
            throw new ContainerException(
                'Class does not exists: ' . $this->services[$name]['class']
            );
        }

        $service = new \ReflectionClass($this->services[$name]['class']);
        return $service->newInstance();
    }
}