Manager::resolveNew() - Code Metrics - Inspection of "doc" - gpupo/netshoes-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 25d97b...a01eb8 )

by Gilmar

created 2016-08-09 19:41 UTC

Manager::resolveNew() A

↳ Parent: Manager

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285
ccs	0
cts	3
cp	0
cc	1
eloc	4
nc	1
nop	1
crap	2

<?php

/*
 * This file is part of gpupo/netshoes-sdk
 * Created by Gilmar Pupo <[email protected]>
 * For the information of copyright and license you should read the file
 * LICENSE which is distributed with this source code.
 * Para a informação dos direitos autorais e de licença você deve ler o arquivo
 * LICENSE que é distribuído com este código-fonte.
 * Para obtener la información de los derechos de autor y la licencia debe leer
 * el archivo LICENSE que se distribuye con el código fuente.
 * For more information, see <http://www.g1mr.com/>.
 */

namespace Gpupo\NetshoesSdk\Entity\Product;

use Gpupo\CommonSdk\Entity\EntityInterface;
use Gpupo\CommonSdk\Exception\InvalidArgumentException;
use Gpupo\CommonSdk\Exception\RuntimeException;
use Gpupo\CommonSdk\Traits\TranslatorManagerTrait;
use Gpupo\NetshoesSdk\Entity\AbstractManager;
use Gpupo\NetshoesSdk\Factory;

final class Manager extends AbstractManager
{
    use TranslatorManagerTrait;

    protected $entity = 'Product';

    protected $strategy = [
        'info' => false,
    ];

    /**
     * @codeCoverageIgnore
     */
    protected $maps = [
        'save'       => ['POST', '/products'],
        'findById'   => ['GET', '/products/{itemId}'],
        'patch'      => ['PATCH', '/products/{itemId}'],
        'update'     => ['PUT', '/products/{itemId}'],
        'fetch'      => ['GET', '/products?page={offset}&size={limit}'],
        'statusById' => ['GET', '/skus/{itemId}/bus/{buId}/status'],
    ];

    public function patch(EntityInterface $entity, $compare)
    {
        if (empty($compare)) {
            return false;
        }

        $json = json_encode($entity->toPatch($compare));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $map = $this->factoryMap('patch', ['itemId' => $entity->getId()]);
        $operation = $this->execute($map, $json);

        $feedback = [
            'fields'        => $compare,
            'response_code' => $operation->getHttpStatusCode(),
        ];

        $this->log('info', 'Operação de Atualização de produto (PATCH)', $feedback);

        return $feedback;
    }

    protected function resolveNew(EntityInterface $entity)
    {
        $this->save($entity);

        return [
            'created' => true,
        ];
    }

    public function fetchStatusById($itemId)
    {
        $response = $this->perform($this->factoryMap('statusById', [
            'itemId' => $itemId,
        ]));

        $data = $this->processResponse($response);

        if (empty($data)) {
            return;
        }

        return new Status($data->toArray());
    }

    private function skuManager()
    {
        return $this->factorySubManager(Factory::getInstance(), 'sku');
    }

    /**
     * {@inheritdoc}
     */
    public function update(EntityInterface $entity, EntityInterface $existent = null)
    {
        if (0 === $entity->getSkus()->count()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new InvalidArgumentException('Product precisa conter SKU!');
        }

        try {
            $status = $entity->get('status');
            if (!$status instanceof Status) {
                $status = $this->fetchStatusById($entity->getId());
            }

            if (true === $status->isPending()) {
                return ['pending' => true];
            }
        } catch (RuntimeException $e) {
            if (404 === $e->getCode()) {
                return $this->resolveNew($entity);
            }
        }

        $response = [];

        if (true === $this->strategy['info']) {
            $compare = $this->attributesDiff($entity, $existent, ['department', 'productType']);
            $response['patch'] = $this->patch($entity, $compare);
        }

        $response['skus'] = [];

        foreach ($entity->getSkus() as $sku) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $previous = null;

            if ($existent instanceof EntityInterface) {
                $previous = $existent->getSkus()->findById($sku->getId());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            }

            $response['skus'][] = $this->skuManager()->update($sku, $previous);
        }

        return $response;
    }

    public function factoryTranslator(array $data = [])
    {
        $translator = new Translator($data);

        return $translator;
    }

    public function findById($itemId)
    {
        $product = parent::findById($itemId);

        if (empty($product)) {
            return false;
        }

        $sm = $this->skuManager();
        $product->getSkus()->forAll(function ($key, $element) use ($sm) {
            $sm->hydrate($element);
        });

        return $product;
    }
}


1		<?php
2
3		/*
4		* This file is part of gpupo/netshoes-sdk
5		* Created by Gilmar Pupo <[email protected]>
6		* For the information of copyright and license you should read the file
7		* LICENSE which is distributed with this source code.
8		* Para a informação dos direitos autorais e de licença você deve ler o arquivo
9		* LICENSE que é distribuído com este código-fonte.
10		* Para obtener la información de los derechos de autor y la licencia debe leer
11		* el archivo LICENSE que se distribuye con el código fuente.
12		* For more information, see <http://www.g1mr.com/>.
13		*/
14
15		namespace Gpupo\NetshoesSdk\Entity\Product;
16
17		use Gpupo\CommonSdk\Entity\EntityInterface;
18		use Gpupo\CommonSdk\Exception\InvalidArgumentException;
19		use Gpupo\CommonSdk\Exception\RuntimeException;
20		use Gpupo\CommonSdk\Traits\TranslatorManagerTrait;
21		use Gpupo\NetshoesSdk\Entity\AbstractManager;
22		use Gpupo\NetshoesSdk\Factory;
23
24		final class Manager extends AbstractManager
25		{
26		use TranslatorManagerTrait;
27
28		protected $entity = 'Product';
29
30		protected $strategy = [
31		'info' => false,
32		];
33
34		/**
35		* @codeCoverageIgnore
36		*/
37		protected $maps = [
38		'save' => ['POST', '/products'],
39		'findById' => ['GET', '/products/{itemId}'],
40		'patch' => ['PATCH', '/products/{itemId}'],
41		'update' => ['PUT', '/products/{itemId}'],
42		'fetch' => ['GET', '/products?page={offset}&size={limit}'],
43		'statusById' => ['GET', '/skus/{itemId}/bus/{buId}/status'],
44		];
45
46	1	public function patch(EntityInterface $entity, $compare)
47		{
48	1	if (empty($compare)) {
49	1	return false;
50		}
51
52	1	$json = json_encode($entity->toPatch($compare));
		0 ignored issues – show Bug introduced 2016-07-18 21:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `toPatch()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53	1	$map = $this->factoryMap('patch', ['itemId' => $entity->getId()]);
54	1	$operation = $this->execute($map, $json);
55
56		$feedback = [
57	1	'fields' => $compare,
58	1	'response_code' => $operation->getHttpStatusCode(),
59		];
60
61	1	$this->log('info', 'Operação de Atualização de produto (PATCH)', $feedback);
62
63	1	return $feedback;
64		}
65
66		protected function resolveNew(EntityInterface $entity)
67		{
68		$this->save($entity);
69
70		return [
71		'created' => true,
72		];
73		}
74
75		public function fetchStatusById($itemId)
76		{
77		$response = $this->perform($this->factoryMap('statusById', [
78		'itemId' => $itemId,
79		]));
80
81		$data = $this->processResponse($response);
82
83		if (empty($data)) {
84		return;
85		}
86
87		return new Status($data->toArray());
88		}
89
90	1	private function skuManager()
91		{
92	1	return $this->factorySubManager(Factory::getInstance(), 'sku');
93		}
94
95		/**
96		* {@inheritdoc}
97		*/
98	2	public function update(EntityInterface $entity, EntityInterface $existent = null)
99		{
100	2	if (0 === $entity->getSkus()->count()) {
		0 ignored issues – show Bug introduced 2016-07-07 21:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
101	1	throw new InvalidArgumentException('Product precisa conter SKU!');
102		}
103
104		try {
105	1	$status = $entity->get('status');
106	1	if (!$status instanceof Status) {
107		$status = $this->fetchStatusById($entity->getId());
108		}
109
110	1	if (true === $status->isPending()) {
111	1	return ['pending' => true];
112		}
113		} catch (RuntimeException $e) {
114		if (404 === $e->getCode()) {
115		return $this->resolveNew($entity);
116		}
117		}
118
119	1	$response = [];
120
121	1	if (true === $this->strategy['info']) {
122		$compare = $this->attributesDiff($entity, $existent, ['department', 'productType']);
123		$response['patch'] = $this->patch($entity, $compare);
124		}
125
126	1	$response['skus'] = [];
127
128	1	foreach ($entity->getSkus() as $sku) {
		0 ignored issues – show Bug introduced 2016-07-07 21:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
129	1	$previous = null;
130
131	1	if ($existent instanceof EntityInterface) {
132	1	$previous = $existent->getSkus()->findById($sku->getId());
		0 ignored issues – show Bug introduced 2016-07-11 18:35 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
133		}
134
135	1	$response['skus'][] = $this->skuManager()->update($sku, $previous);
136		}
137
138	1	return $response;
139		}
140
141	1	public function factoryTranslator(array $data = [])
142		{
143	1	$translator = new Translator($data);
144
145	1	return $translator;
146		}
147
148	2	public function findById($itemId)
149		{
150	2	$product = parent::findById($itemId);
151
152	2	if (empty($product)) {
153	1	return false;
154		}
155
156	1	$sm = $this->skuManager();
157	1	$product->getSkus()->forAll(function ($key, $element) use ($sm) {
158	1	$sm->hydrate($element);
159	1	});
160
161	1	return $product;
162		}
163		}
164

gpupo / netshoes-sdk

Push — master ( 25d97b...a01eb8 )

Manager::resolveNew() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like