Gpupo\NetshoesSdk\Entity\Product\Sku\Manager

Complexity

Total Complexity

11

Size/Duplication

Total Lines	121
Duplicated Lines	24.79 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	18
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	getDetail()	0	18	1
A	findById()	17	17	2
A	getPriceScheduleCollection()	13	13	2
A	saveDetail()	0	7	1
A	hydrate()	0	9	1
B	update()	0	33	3

<?php

/*
 * This file is part of gpupo/netshoes-sdk
 * Created by Gilmar Pupo <g@g1mr.com>
 * For the information of copyright and license you should read the file
 * LICENSE which is distributed with this source code.
 * Para a informação dos direitos autorais e de licença você deve ler o arquivo
 * LICENSE que é distribuído com este código-fonte.
 * Para obtener la información de los derechos de autor y la licencia debe leer
 * el archivo LICENSE que se distribuye con el código fuente.
 * For more information, see <http://www.g1mr.com/>.
 */

namespace Gpupo\NetshoesSdk\Entity\Product\Sku;

use Gpupo\CommonSdk\Entity\EntityInterface;
use Gpupo\NetshoesSdk\Entity\AbstractManager;

class Manager extends AbstractManager
{
    protected $entity = 'SkuCollection';

    /**
     * @codeCoverageIgnore
     */
    protected function setUp()
    {
        $this->maps = include 'map.php';
    }

    /**
     * @return Gpupo\Common\Entity\CollectionAbstract|null
     */
    public function findById($itemId)

This method seems to be duplicated in your project.

    {
        $response = $this->perform($this->factoryMap('findById', [
            'productId' => $itemId,
            'itemId'    => $itemId,
        ]));

        $data = $this->processResponse($response);

        if (empty($data)) {
            return;
        }

        $sku = new Item($data->toArray());

        return $this->hydrate($sku);
    }

    protected function getDetail(EntityInterface $sku, $type)
    {
        $response = $this->perform($this->factoryMap('get'.$type, ['sku' => $sku->getId()]));
        $className = 'Gpupo\NetshoesSdk\Entity\Product\Sku\\'.$type;
        $data = $this->processResponse($response);

        $o = new $className($data->toArray());

        $this->getLogger()->addInfo('Detail', [
            'sku'       => $sku->getId(),
            'typ'       => $type,
            'response'  => $data,
            'className' => $className,
            'object'    => $o,
        ]);

        return $o;
    }

    protected function getPriceScheduleCollection(EntityInterface $sku)

This method seems to be duplicated in your project.

    {
        $response = $this->perform($this->factoryMap('getPriceSchedule', ['sku' => $sku->getId()]));
        $data = $this->processResponse($response);

        if (empty($data)) {
            return;
        }

        $collection = new PriceScheduleCollection($data->toArray());

        return $collection;
    }

    public function saveDetail(Item $sku, $type)
    {
        $json = $sku->toJson($type);
        $map = $this->factoryMap('save'.$type, ['sku' => $sku->getId()]);

        return $this->execute($map, $json);
    }

    protected function hydrate(EntityInterface $sku)
    {
        $sku->setPrice($this->getDetail($sku, 'Price'))

It seems like you code against a concrete implementation and not the interface Gpupo\CommonSdk\Entity\EntityInterface as the method setPrice() does only exist in the following implementations of said interface: Gpupo\NetshoesSdk\Entity\Product\Sku\Price.

            ->setPriceSchedule($this->getPriceScheduleCollection($sku)->getCurrent())
            ->setStock($this->getDetail($sku, 'Stock'))
            ->setStatus($this->getDetail($sku, 'Status'));

        return $sku;
    }

    /**
     * {@inheritdoc}
     */
    public function update(EntityInterface $entity, EntityInterface $existent = null)
    {
        parent::update($entity, $existent);

        $response = [
            'sku'      => $entity->getId(),
            'bypassed' => [],
            'updated'  => [],
            'code'     => [],
        ];

        foreach ([
            'Status' => ['active'],
            'Stock' => ['available'],
            'Price' => ['price'],
            'PriceSchedule' => ['priceTo'],
        ] as $key => $attributes) {
            $getter = 'get'.$key;
            $diff = $this->attributesDiff($entity->$getter(), $existent->$getter(), $attributes);
            if (!empty($diff)) {
                $response['code'][$key] = $this->saveDetail($entity, $key)->getHttpStatusCode();

$entity of type object<Gpupo\CommonSdk\Entity\EntityInterface> is not a sub-type of object<Gpupo\NetshoesSdk\Entity\Product\Sku\Item>. It seems like you assume a concrete implementation of the interface Gpupo\CommonSdk\Entity\EntityInterface to be always present.

                $response['updated'][] = $key;
            } else {
                $response['bypassed'][] = $key;
            }
        }

        $this->log('info', 'Operação de Atualização de entity '
            .$this->entity, $response);

        return $response;
    }
}