Manager::update() - Code Metrics - Inspection of "product:update" - gpupo/netshoes-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f4b9fa...7f1616 )

by Gilmar

created 2016-07-07 20:49 UTC

Manager::update() A

↳ Parent: Manager

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	3
eloc	9
nc	4
nop	2

<?php

/*
 * This file is part of gpupo/netshoes-sdk
 * Created by Gilmar Pupo <[email protected]>
 * For the information of copyright and license you should read the file
 * LICENSE which is distributed with this source code.
 * Para a informação dos direitos autorais e de licença você deve ler o arquivo
 * LICENSE que é distribuído com este código-fonte.
 * Para obtener la información de los derechos de autor y la licencia debe leer
 * el archivo LICENSE que se distribuye con el código fuente.
 * For more information, see <http://www.g1mr.com/>.
 */

namespace Gpupo\NetshoesSdk\Entity\Product;

use Gpupo\CommonSdk\Entity\EntityInterface;
use Gpupo\NetshoesSdk\Entity\AbstractManager;
use Gpupo\NetshoesSdk\Factory;

class Manager extends AbstractManager
{
    protected $entity = 'Product';

    /**
     * @codeCoverageIgnore
     */
    protected $maps = [
        'save'     => ['POST', '/products'],
        'findById' => ['GET', '/products/{itemId}'],
        'patch'    => ['PATCH', '/products/{itemId}'],
        'update'   => ['PUT', '/products/{itemId}'],
        'fetch'    => ['GET', '/products?page={offset}&size={limit}'],
    ];

    /**
     * {@inheritdoc}
     */
    public function update(EntityInterface $entity, EntityInterface $existent = null)
    {
        $previous = null;

        if ($existent) {
            $previous = $existent->getSkus()->first();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        if (0 === $entity->getSkus()->count()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new \InvalidArgumentException('Product precisa conter SKU!');
        }

        Factory::getInstance()->factoryManager('sku')
            ->update($entity->getSkus()->first(), $previous);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return true;
    }
}


Push — master ( f4b9fa...7f1616 )

Manager::update() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of gpupo/netshoes-sdk
5			* Created by Gilmar Pupo <[email protected]>
6			* For the information of copyright and license you should read the file
7			* LICENSE which is distributed with this source code.
8			* Para a informação dos direitos autorais e de licença você deve ler o arquivo
9			* LICENSE que é distribuído com este código-fonte.
10			* Para obtener la información de los derechos de autor y la licencia debe leer
11			* el archivo LICENSE que se distribuye con el código fuente.
12			* For more information, see <http://www.g1mr.com/>.
13			*/
14
15			namespace Gpupo\NetshoesSdk\Entity\Product;
16
17			use Gpupo\CommonSdk\Entity\EntityInterface;
18			use Gpupo\NetshoesSdk\Entity\AbstractManager;
19			use Gpupo\NetshoesSdk\Factory;
20
21			class Manager extends AbstractManager
22			{
23			protected $entity = 'Product';
24
25			/**
26			* @codeCoverageIgnore
27			*/
28			protected $maps = [
29			'save' => ['POST', '/products'],
30			'findById' => ['GET', '/products/{itemId}'],
31			'patch' => ['PATCH', '/products/{itemId}'],
32			'update' => ['PUT', '/products/{itemId}'],
33			'fetch' => ['GET', '/products?page={offset}&size={limit}'],
34			];
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function update(EntityInterface $entity, EntityInterface $existent = null)
40			{
41			$previous = null;
42
43			if ($existent) {
44			$previous = $existent->getSkus()->first();
			0 ignored issues – show Bug introduced 2016-07-07 21:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45			}
46
47			if (0 === $entity->getSkus()->count()) {
			0 ignored issues – show Bug introduced 2016-07-07 21:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
48			throw new \InvalidArgumentException('Product precisa conter SKU!');
49			}
50
51			Factory::getInstance()->factoryManager('sku')
52			->update($entity->getSkus()->first(), $previous);
			0 ignored issues – show Bug introduced 2016-07-07 21:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Gpupo\CommonSdk\Entity\EntityInterface` as the method `getSkus()` does only exist in the following implementations of said interface: `Gpupo\NetshoesSdk\Entity\Product\Product`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53
54			return true;
55			}
56			}
57

gpupo / netshoes-sdk

Push — master ( f4b9fa...7f1616 )

Manager::update() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like